Nick Terrell [Fri, 19 Jul 2019 01:45:32 +0000 (18:45 -0700)]
[lz4frame] Skip magic and checksums in fuzzing mode
When `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` is defined we skip
magic and checksum checks. This makes it easier to fuzz decompression.
Nick Terrell [Thu, 18 Jul 2019 02:40:04 +0000 (19:40 -0700)]
Fix LZ4_attach_dictionary with empty dictionary
Nick Terrell [Thu, 18 Jul 2019 01:31:44 +0000 (18:31 -0700)]
[fuzz] Add HC fuzzers for round trip, compress, and streaming
Nick Terrell [Thu, 18 Jul 2019 00:41:41 +0000 (17:41 -0700)]
[fuzzer] Update scripts for new fuzzers
Nick Terrell [Thu, 18 Jul 2019 00:33:31 +0000 (17:33 -0700)]
[fuzz] Add a streaming round trip fuzzer
W. Felix Handte [Thu, 18 Jul 2019 17:35:12 +0000 (13:35 -0400)]
Unconditionally Clear `dictCtx`
W. Felix Handte [Thu, 18 Jul 2019 16:41:12 +0000 (12:41 -0400)]
Fix Data Corruption Bug when Streaming with an Attached Dict in HC Mode
This diff fixes an issue in which we failed to clear the `dictCtx` in HC
compression. The `dictCtx` is not supposed to be used when an `extDict` is
present: matches found in the `dictCtx` do not account for the presence of an
`extDict` segment, and their offsets are therefore miscalculated when one is
present. This can lead to data corruption.
This diff clears the `dictCtx` whenever setting an `extDict`.
This issue was uncovered by @terrelln's fuzzing work.
Yann Collet [Wed, 17 Jul 2019 20:25:41 +0000 (13:25 -0700)]
Merge pull request #756 from terrelln/destSize
[LZ4_compress_destSize + multi-blocks streaming] Fix rare data corruption bug
Nick Terrell [Wed, 17 Jul 2019 18:50:47 +0000 (11:50 -0700)]
[LZ4_compress_destSize] Fix overflow condition
Nick Terrell [Wed, 17 Jul 2019 18:28:38 +0000 (11:28 -0700)]
[LZ4_compress_destSize] Fix rare data corruption bug
Nick Terrell [Wed, 17 Jul 2019 18:07:24 +0000 (11:07 -0700)]
[LZ4_compress_destSize] Allow 2 more bytes of match length
Yann Collet [Tue, 16 Jul 2019 18:18:09 +0000 (11:18 -0700)]
Merge pull request #752 from terrelln/fuzzers
[ossfuzz] Improve the fuzzers
Yann Collet [Mon, 15 Jul 2019 23:38:28 +0000 (16:38 -0700)]
Merge pull request #755 from lz4/custom_distance
ensure conformance with custom LZ4_DISTANCE_MAX
Nick Terrell [Sat, 13 Jul 2019 02:27:00 +0000 (19:27 -0700)]
[ossfuzz] Improve the fuzzers
* Run more decompression variants
* Round trip the compression fuzzer and do partial decompression as well
* Add a compression fuzzer that compresses into a smaller output buffer
and test the destSize variant
These fuzzers caught 2 bugs that were fixed in the previous commit.
* Input buffer over-read in partial decompress
* Partial decompress fails if output size is 0
Nick Terrell [Sat, 13 Jul 2019 01:36:28 +0000 (18:36 -0700)]
[lz4] Fix bugs in partial decoding
* Partial decoding could read a few bytes beyond the end of the input
* Partial decoding returned an error with an empty output buffer
Yann Collet [Mon, 15 Jul 2019 19:11:34 +0000 (12:11 -0700)]
ensure conformance with custom LZ4_DISTANCE_MAX
It's now possible to select a custom LZ4_DISTANCE_MAX at compile time,
provided it's <= 65535.
However, in some cases (when compressing in byU16 mode),
the new distance wasn't respected,
as it used to implied that it was necessarily within range.
Added a distance check for this case.
Also : added a new TravisCI test which ensures that
custom LZ4_DISTANCE_MAX compiles correctly
and compresses correctly (relying on `assert()` to find outsized offsets).
Yann Collet [Mon, 15 Jul 2019 16:08:11 +0000 (09:08 -0700)]
Merge pull request #753 from Hitatm/fix_LZ4_DISTANCE_MAX
bugfix: correctly control the offset < LZ4_DISTANCE_MAX,when change t…
Hitatm [Mon, 15 Jul 2019 14:53:46 +0000 (22:53 +0800)]
bugfix: correctly control the offset < LZ4_DISTANCE_MAX,when change the value of LZ4_DISTANCE_MAX,
Yann Collet [Fri, 12 Jul 2019 00:29:16 +0000 (17:29 -0700)]
keep the "lorem ipsum" topic of the example string
but make it compressible
Yann Collet [Fri, 12 Jul 2019 00:26:15 +0000 (17:26 -0700)]
Merge pull request #751 from hamidzr/simple-buffer-example-input
simple buffer example minor input update. fixes #750
Hamid Zare [Thu, 11 Jul 2019 21:39:29 +0000 (14:39 -0700)]
print the compression ratio
Hamid Zare [Thu, 11 Jul 2019 21:34:52 +0000 (14:34 -0700)]
changed the input text to something more compression friendly
Yann Collet [Thu, 4 Jul 2019 20:03:08 +0000 (13:03 -0700)]
Merge pull request #749 from sylvestre/patch-1
Remove an useless declaration
Sylvestre Ledru [Thu, 4 Jul 2019 16:13:36 +0000 (18:13 +0200)]
Remove an useless declaration
Yann Collet [Wed, 3 Jul 2019 23:16:52 +0000 (16:16 -0700)]
Merge pull request #746 from lz4/circleci
CircleCI : reduced test duration
Yann Collet [Wed, 3 Jul 2019 23:16:19 +0000 (16:16 -0700)]
Merge pull request #743 from lz4/fuzzasan_fixed
updated frametest
Yann Collet [Wed, 3 Jul 2019 23:13:44 +0000 (16:13 -0700)]
Merge pull request #748 from amchoukir/amchoukir-doublebuffer-doc
Update blockStreaming_doubleBuffer.md
Amine Choukir [Wed, 3 Jul 2019 09:50:38 +0000 (11:50 +0200)]
Update blockStreaming_doubleBuffer.md
Yann Collet [Mon, 1 Jul 2019 18:52:08 +0000 (11:52 -0700)]
Merge pull request #745 from lz4/bump_192
bumped version number to v1.9.2
Yann Collet [Mon, 1 Jul 2019 17:55:54 +0000 (10:55 -0700)]
CircleCI : reduced test duration
Ideally, we want to make CircleCI a "fast" test environment, with short feedback loop (~5mn).
We are still far from this goal.
This patch starts this process by removing "long" tasks which are non-essential and redundant with travisCI.
It also acknowledges that parallelism is broken.
The script should be more heavily updated to support parallelism,
which might be important to support its goal.
Yann Collet [Mon, 1 Jul 2019 16:01:43 +0000 (09:01 -0700)]
bumped version number to v1.9.2
to reduce risks that future bug reports in `dev` branch report `v1.9.1` as the failing version.
Yann Collet [Sun, 30 Jun 2019 22:36:32 +0000 (15:36 -0700)]
fix minor cppcheck warnings
Yann Collet [Sun, 30 Jun 2019 21:57:12 +0000 (14:57 -0700)]
updated frametest
so that noisy src decompression
doesn't generate output
nor fails when decompression fails (which is expected).
Yann Collet [Sun, 30 Jun 2019 21:01:08 +0000 (14:01 -0700)]
Merge branch 'fuzzasan' into fuzzasan_fixed
Yann Collet [Sun, 30 Jun 2019 20:59:49 +0000 (13:59 -0700)]
frametest: added LZ4F decoder noise test
Yann Collet [Sun, 30 Jun 2019 20:05:15 +0000 (13:05 -0700)]
Merge pull request #739 from cmeister2/cmeister2/ossfuzz
oss-fuzz: Add a fuzzing target that compiles in the oss-fuzz environment
Max Dymond [Sun, 30 Jun 2019 19:16:03 +0000 (20:16 +0100)]
Remove unnecessary call to Makefile.inc
Yann Collet [Sun, 30 Jun 2019 18:33:38 +0000 (11:33 -0700)]
Merge pull request #741 from lzutao/meson-deprecated-warn
meson: Fix deprecated warnings on build options
Yann Collet [Sun, 30 Jun 2019 16:41:56 +0000 (09:41 -0700)]
Merge pull request #742 from lz4/fuzzasan_fixed
New fuzzer test for #738
Lzu Tao [Sat, 29 Jun 2019 13:54:39 +0000 (20:54 +0700)]
meson: Rename options in travis config
Yann Collet [Sat, 29 Jun 2019 04:03:07 +0000 (21:03 -0700)]
Merge branch 'dev' into fuzzasan_fixed
Yann Collet [Sat, 29 Jun 2019 03:55:47 +0000 (20:55 -0700)]
travisCI: added ASAN fuzzer tests
and fixed minor formatting warnings
Yann Collet [Sat, 29 Jun 2019 03:23:12 +0000 (20:23 -0700)]
moved noisy-src decoder test into cBuffer_exact
so that it can also catch any potential read out-of-bound in the input buffer
(none reported so far, just a precaution for the future).
Yann Collet [Sat, 29 Jun 2019 03:15:43 +0000 (20:15 -0700)]
fuzzer: added test to catch #738
Lzu Tao [Sat, 29 Jun 2019 03:11:32 +0000 (10:11 +0700)]
meson: Always build gen_manual on build machine
As gen_manual is using as a generator, not a binary target
installed on host machine.
Lzu Tao [Sat, 29 Jun 2019 03:10:05 +0000 (10:10 +0700)]
meson: Fix deprecated warnings on build options
Meson now reserves `build_` prefix options.
Yann Collet [Sat, 29 Jun 2019 02:22:54 +0000 (19:22 -0700)]
Merge pull request #740 from terrelln/fix2
Fix out-of-bounds read
Max Dymond [Fri, 28 Jun 2019 23:23:06 +0000 (00:23 +0100)]
More markups for style changes
Max Dymond [Fri, 28 Jun 2019 22:48:33 +0000 (23:48 +0100)]
Move to using C rather than C++ for compilation
Nick Terrell [Fri, 28 Jun 2019 21:40:14 +0000 (14:40 -0700)]
Fix out-of-bounds read of up to 64 KB in the past
Max Dymond [Fri, 28 Jun 2019 21:19:27 +0000 (22:19 +0100)]
Write a simple decompress target as well
Max Dymond [Fri, 28 Jun 2019 19:54:46 +0000 (20:54 +0100)]
Code review markups:
- Correct use of CPPFLAGS
- Detect allocation failure
- Add a CHECK macro for failure
Max Dymond [Tue, 25 Jun 2019 16:22:02 +0000 (17:22 +0100)]
Add a fuzzing target that compiles in the oss-fuzz environment
Yann Collet [Tue, 25 Jun 2019 17:32:19 +0000 (10:32 -0700)]
Merge pull request #735 from lz4/versionOut
fix #734 : --version should output to stdout
Yann Collet [Mon, 24 Jun 2019 23:08:30 +0000 (16:08 -0700)]
fix #734 : --version should output to stdout
instead of stderr
Yann Collet [Thu, 6 Jun 2019 21:17:44 +0000 (14:17 -0700)]
update simple_buffer example
there were a few tiny inaccuracies, especially in error conditions.
Yann Collet [Thu, 6 Jun 2019 20:20:30 +0000 (13:20 -0700)]
precise again that LZ4 decoder needs metadata
and that such metadata must be provided / sent / saved by the application.
Yann Collet [Wed, 5 Jun 2019 21:34:28 +0000 (14:34 -0700)]
Merge pull request #727 from ephiepark/dev
CircleCI : use custom Docker Image with pre-installed dependencies
Ephraim Park [Tue, 4 Jun 2019 19:45:31 +0000 (12:45 -0700)]
circleci : use custom docker image with pre-installed dependencies
Yann Collet [Tue, 4 Jun 2019 21:04:49 +0000 (14:04 -0700)]
restored FORCE_INLINE
Yann Collet [Fri, 31 May 2019 22:18:12 +0000 (15:18 -0700)]
Merge pull request #718 from lz4/fullbench
fullbench: added test scenario LZ4F_decompress_followHint
Yann Collet [Fri, 31 May 2019 20:25:12 +0000 (13:25 -0700)]
fullbench: ensure decompressionFunction and dName are initialized
Visual Studio seems to miss that they are necessarily initialized in the switch() { case: }
Yann Collet [Fri, 31 May 2019 19:59:38 +0000 (12:59 -0700)]
Merge pull request #717 from lz4/inplace
Added documentation and macro to support in-place compression and decompression
Yann Collet [Fri, 31 May 2019 19:23:52 +0000 (12:23 -0700)]
Merge pull request #719 from parheliamm/dev
FAST_DEC_LOOP: move offset check in specific condition.
Yann Collet [Fri, 31 May 2019 19:01:33 +0000 (12:01 -0700)]
replaced while(1)
by for (;;)
just to please Visual Studio C4127 .
Yann Collet [Fri, 31 May 2019 18:56:59 +0000 (11:56 -0700)]
added more details for in-place documentation
Yann Collet [Fri, 31 May 2019 18:44:37 +0000 (11:44 -0700)]
decompress: changed final memcpy() into memmove()
for compatibility with in-place decompression scenarios.
Yann Collet [Fri, 31 May 2019 18:31:48 +0000 (11:31 -0700)]
Makefile removed CFLAGS modifier
which was removing `-O3` as a side effect
Chenxi Mao [Fri, 31 May 2019 00:36:13 +0000 (08:36 +0800)]
FAST_DEC_LOOP: only did offset check in specific condition.
When I did FAST_DEC_LOOP performance test, I found the
offset check is much more than v1.8.3
You will see the condition check difference via lzbench with dickens test case.
v1.8.3 34959
v.1.9.x 1055885
After investigate the code, we could see the difference.
v.1.8.3 SKIP the condition check if
if condition is true in:
https://github.com/lz4/lz4/blob/v1.8.3/lib/lz4.c#L1463
AND below condition is true
https://github.com/lz4/lz4/blob/v1.8.3/lib/lz4.c#L1478\
The offset check should be invoked.
v1.9.3
The offset check code will be invoked in every loop which lead to downgrade.
So the fix would be move this check to specific condition
to avoid useless condition check.
After this change, the call number is same as v1.8.3
Yann Collet [Fri, 31 May 2019 00:29:51 +0000 (17:29 -0700)]
fullbench: added test scenario LZ4F_decompress_followHint
This emulates a streaming scenario,
where the caller follows rigorously the srcSize hints
provided as return value of LZ4F_decompress().
This is useful to show the issue in #714,
where data is uselessly copied in a tmp buffer first.
Yann Collet [Fri, 31 May 2019 00:28:59 +0000 (17:28 -0700)]
Merge pull request #714 from dreambottle/fix-lz4f-input-buf-use
Fix src temporary buffer use in lz4frame
Yann Collet [Thu, 30 May 2019 23:23:53 +0000 (16:23 -0700)]
updated API manual
Yann Collet [Thu, 30 May 2019 23:19:30 +0000 (16:19 -0700)]
updated LZ4_DECOMPRESS_INPLACE_MARGIN
to pass worst case scenario.
Now adds margin proportional to input size to counter local expansion.
Yann Collet [Thu, 30 May 2019 23:17:47 +0000 (16:17 -0700)]
added test case for in-place decompression
worst case, designed to make the decoder overwrite into input
Yann Collet [Thu, 30 May 2019 16:45:21 +0000 (09:45 -0700)]
add more doc on in-place (de)compression
Yann Collet [Wed, 29 May 2019 20:33:55 +0000 (13:33 -0700)]
fuzzer: changed internal buffer size
to ensure no overflow during unit tests
Yann Collet [Wed, 29 May 2019 20:17:45 +0000 (13:17 -0700)]
one more conversion warning
Yann Collet [Wed, 29 May 2019 20:14:52 +0000 (13:14 -0700)]
some more minor conversion warnings fixes
Yann Collet [Wed, 29 May 2019 19:56:27 +0000 (12:56 -0700)]
fixed minor conversion warning
Yann Collet [Wed, 29 May 2019 19:21:14 +0000 (12:21 -0700)]
ensure lz4.h can be included with or without LZ4_STATIC_LINKING_ONLY in any order
ensure correct propagation of LZ4_DISTANCE_MAX
Yann Collet [Wed, 29 May 2019 19:06:13 +0000 (12:06 -0700)]
added comments and macros for in-place (de)compression
Yann Collet [Wed, 29 May 2019 18:19:10 +0000 (11:19 -0700)]
added test case for in-place compression
Yann Collet [Mon, 27 May 2019 18:59:23 +0000 (11:59 -0700)]
Merge pull request #715 from gabrielstedman/ret
Handle file not existing case #704
gabrielstedman [Sat, 25 May 2019 18:57:04 +0000 (19:57 +0100)]
Handle file not existing case #704
Niko Dzhus [Fri, 24 May 2019 15:25:06 +0000 (18:25 +0300)]
fix temporary buffer use when input size hint is respected
Yann Collet [Fri, 17 May 2019 19:22:39 +0000 (12:22 -0700)]
Merge pull request #709 from lz4/circle
updated tests for CircleCI
Yann Collet [Thu, 16 May 2019 23:46:16 +0000 (16:46 -0700)]
updated tests
- only play listTest with `make test`, not `make all` which is limited to build
- update `clangtest`, so that it's possible to disable O3 optimization, for faster processing
Yann Collet [Thu, 16 May 2019 22:56:42 +0000 (15:56 -0700)]
Merge pull request #708 from gabrielstedman/list
Add multiframe report to --list command
gstedman [Thu, 16 May 2019 14:12:00 +0000 (15:12 +0100)]
List mode improvements.
Improve formatting
Include static assert
Use UTIL_fseek to handle potential fseek limitation
Be explicit when refusing to read from stdin
Properly free dctx after use
Include valgrind tests
gstedman [Fri, 10 May 2019 15:54:05 +0000 (16:54 +0100)]
Add multiframe report to --list command
Yann Collet [Tue, 14 May 2019 03:35:10 +0000 (20:35 -0700)]
Merge pull request #707 from prekageo/dev
enable LZ4_FAST_DEC_LOOP build macro on aarch64 by default
George Prekas [Fri, 3 May 2019 16:44:56 +0000 (11:44 -0500)]
enable LZ4_FAST_DEC_LOOP build macro on aarch64/GCC by default
Yann Collet [Tue, 30 Apr 2019 06:40:42 +0000 (23:40 -0700)]
Merge pull request #700 from lzutao/meson-non-failures
contrib: Make Meson build non optional
Lzu Tao [Tue, 30 Apr 2019 05:25:40 +0000 (12:25 +0700)]
meson: Rely only on extracted version in lz4.h
So now instead of warning when failing to extract version number
from lz4.h, we error and stop the build instead.
Lzu Tao [Fri, 26 Apr 2019 18:41:03 +0000 (01:41 +0700)]
contrib: Make Meson build non optional
* Update ninja version to 1.9 in CI.
* Update default project version in meson script.
Yann Collet [Fri, 26 Apr 2019 03:26:04 +0000 (20:26 -0700)]
Merge pull request #699 from brendene/compressBound
Include block checksum in worst case scenario calculation of dstCapacity
Brenden Eng [Fri, 26 Apr 2019 02:37:39 +0000 (22:37 -0400)]
Include block checksum in worst case scenario calculation of dstCapacity
Yann Collet [Wed, 24 Apr 2019 18:50:50 +0000 (11:50 -0700)]
Merge pull request #698 from lz4/tidy
several minor style changes recommended by clang-tidy
Yann Collet [Wed, 24 Apr 2019 17:03:02 +0000 (10:03 -0700)]
several minor style changes recommended by clang-tidy
Yann Collet [Wed, 24 Apr 2019 00:20:03 +0000 (17:20 -0700)]
Merge pull request #697 from ldv-alt/fixes/test-amalgamation
Fix test-amalgamation