platform/upstream/gstreamer.git
4 years agosctp: usrsctp: increase DIAG_MSG_LEN to accomodate longer file path
Tim-Philipp Müller [Tue, 25 Aug 2020 22:46:16 +0000 (23:46 +0100)]
sctp: usrsctp: increase DIAG_MSG_LEN to accomodate longer file path

Fixes "‘%s’ directive output truncated writing XX bytes into
a region of size NN [-Wformat-truncation=]" compiler warnings.

https://github.com/sctplab/usrsctp/pull/521

Fixes #1389

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1540>

4 years agodshowsrcwrapper: fix typo in variable name
Jérôme Laheurte [Tue, 25 Aug 2020 08:49:11 +0000 (10:49 +0200)]
dshowsrcwrapper: fix typo in variable name

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1538>

4 years agovulkan: fix the enumtypes install path
Wim Taymans [Fri, 21 Aug 2020 14:28:42 +0000 (16:28 +0200)]
vulkan: fix the enumtypes install path

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1528>

4 years agowpe: skip glbasesrc decide_allocation when non-GL caps are negotiated
Philippe Normand [Sat, 22 Aug 2020 13:38:38 +0000 (14:38 +0100)]
wpe: skip glbasesrc decide_allocation when non-GL caps are negotiated

Checking for GL caps features in gl_start() was done too late in case the parent
class fails to setup a working GL context. The element now determines if GL
support should be enabled during the decide-allocation query handling.

Additionally, when no GL context was found, we need to handle the element
cleanup because in that situation glbasesrc won't call gl_stop.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1376

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1532>

4 years agocodecs: h264decoder: Fix possible GstH264Picture leak and small cleanup
Seungha Yang [Fri, 21 Aug 2020 13:48:48 +0000 (22:48 +0900)]
codecs: h264decoder: Fix possible GstH264Picture leak and small cleanup

Don't leak pictures when dpb is full unexpectedly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1527>

4 years agod3d11videosink: Fix crash caused by missing null termination
Seungha Yang [Thu, 20 Aug 2020 17:36:13 +0000 (02:36 +0900)]
d3d11videosink: Fix crash caused by missing null termination

gst_caps_features_new() must be null terminated.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1524>

4 years agova: allocator: remove parameter from _create_buffer_surface()
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 14:50:46 +0000 (16:50 +0200)]
va: allocator: remove parameter from _create_buffer_surface()

Don't the allocator to _create_buffer_surface() since it's not used.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: utils: free allocated string
Víctor Manuel Jáquez Leal [Wed, 19 Aug 2020 15:18:26 +0000 (17:18 +0200)]
va: utils: free allocated string

and fix a memleak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: utils: fix log category initialization
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 07:05:00 +0000 (09:05 +0200)]
va: utils: fix log category initialization

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: h264dec: check va allocator at decide allocation
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 09:39:46 +0000 (11:39 +0200)]
va: h264dec: check va allocator at decide allocation

And some code cleanups

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agova: decoder: improve locks for member variable access
Víctor Manuel Jáquez Leal [Tue, 18 Aug 2020 09:38:46 +0000 (11:38 +0200)]
va: decoder: improve locks for member variable access

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1516>

4 years agowebrtc/datachannel: clear the error after use
Matthew Waters [Mon, 24 Aug 2020 07:01:59 +0000 (17:01 +1000)]
webrtc/datachannel: clear the error after use

Fixes a memory leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agowebrtc/datachannel: free previous protocol/label fields
Matthew Waters [Mon, 24 Aug 2020 07:01:22 +0000 (17:01 +1000)]
webrtc/datachannel: free previous protocol/label fields

Fixes a memory leak

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agotests/webrtc: unref GBytes after use
Matthew Waters [Mon, 24 Aug 2020 07:00:30 +0000 (17:00 +1000)]
tests/webrtc: unref GBytes after use

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agosctpdec: unref after retrieving the static pad template
Matthew Waters [Mon, 24 Aug 2020 06:58:41 +0000 (16:58 +1000)]
sctpdec: unref after retrieving the static pad template

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1535>

4 years agoRelease 1.17.90
Tim-Philipp Müller [Thu, 20 Aug 2020 15:14:23 +0000 (16:14 +0100)]
Release 1.17.90

4 years agowebrtc/ice: resolve .local candidates internally
Matthew Waters [Thu, 20 Aug 2020 02:58:30 +0000 (12:58 +1000)]
webrtc/ice: resolve .local candidates internally

Requires the system's DNS resolver to support mdns resolution.

Fixes interoperablity with recent versions of chrome/firefox that
produce .local address in for local candidates.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1139

4 years agosrtobject: set error when canceled waiting for a caller
J. Kim [Wed, 19 Aug 2020 11:46:31 +0000 (11:46 +0000)]
srtobject: set error when canceled waiting for a caller

To propagate error, this commit sets a reason. Otherwise, the function
caller should check if `error` is NULL when the return value is not normal.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1522>

4 years agosrtobject: fix typo, s/errorj/error
J. Kim [Wed, 19 Aug 2020 11:30:47 +0000 (11:30 +0000)]
srtobject: fix typo, s/errorj/error

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1522>

4 years agodocs: fix gst-docs build if opencv is not being built
Tim-Philipp Müller [Mon, 17 Aug 2020 17:51:17 +0000 (18:51 +0100)]
docs: fix gst-docs build if opencv is not being built

The disabler in opencv_dep (retrieved via libs_doc) will
cause a meson interpreter error if opencv is not being built:

ERROR: The += operator currently only works with arrays, dicts, strings or ints
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1519>

4 years agofdkaacenc: Implement flush function
Vivia Nikolaidou [Fri, 14 Aug 2020 16:57:30 +0000 (19:57 +0300)]
fdkaacenc: Implement flush function

The internal fdk encoder always produces 1024 bytes even with no input,
so special care should be taken to not drain it twice.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1515>

4 years agomediafoundation: Correct wrong raw video format mapping
Seungha Yang [Mon, 17 Aug 2020 12:39:13 +0000 (21:39 +0900)]
mediafoundation: Correct wrong raw video format mapping

Was a shameful mistake

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1517>

4 years agova: h264dec: set latency
Víctor Manuel Jáquez Leal [Sat, 8 Aug 2020 17:59:33 +0000 (19:59 +0200)]
va: h264dec: set latency

The min latency is calculated with the maximum number of frames that
precede any frame, if available, and it is lower than the maximum
number of frames in DBP.

The max latency is calculated with the maxium size of frames in DBP.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1500>

4 years agofdkaacenc: Refactor layout selection code
Jan Alexander Steffens (heftig) [Thu, 16 May 2019 18:40:14 +0000 (20:40 +0200)]
fdkaacenc: Refactor layout selection code

No functional change.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1359>

4 years agofdkaacenc: Move channel layouts to gstfdkaac.c
Jan Alexander Steffens (heftig) [Thu, 18 Jun 2020 09:33:49 +0000 (11:33 +0200)]
fdkaacenc: Move channel layouts to gstfdkaac.c

In preparation of sharing them with the decoder. Iteration of the
channel layouts needs to be changed to use a sentinel element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1359>

4 years agovulkan: docs annotation updates
Matthew Waters [Wed, 12 Aug 2020 05:59:01 +0000 (15:59 +1000)]
vulkan: docs annotation updates

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1506>

4 years agobuild/vulkan: split vulkan gir
Matthew Waters [Tue, 11 Aug 2020 11:56:39 +0000 (21:56 +1000)]
build/vulkan: split vulkan gir

also add to docs

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1506>

4 years agowpe: WebView and WebContext handling fixes
Philippe Normand [Wed, 5 Aug 2020 17:41:45 +0000 (18:41 +0100)]
wpe: WebView and WebContext handling fixes

The WPEThreaded view is now split in 2 classes:
- WPEContextThread handles the persistent WebKit thread, where all WebKit API
calls should be handled.
- WPEView: is created from the WPEContextThread. It handles the WebView and
maintains the public interface on which wpesrc relies. This is the facade for
the WebView, basically. It takes care of dispatching API calls into the context
thread.

With these fixes it is now possible to create (and reuse) mutlple wpesrc
elements during the application lifetime.

Fixes #1372

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1484>

4 years agosctp: fix build with GST_DISABLE_GST_DEBUG
Sebastian Dröge [Fri, 7 Aug 2020 06:26:19 +0000 (09:26 +0300)]
sctp: fix build with GST_DISABLE_GST_DEBUG

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1465>

4 years agosctp: hook up internal copy of libusrsctp to build
Tim-Philipp Müller [Sat, 25 Jul 2020 16:56:43 +0000 (17:56 +0100)]
sctp: hook up internal copy of libusrsctp to build

Add option 'sctp-internal-usrsctp' so people can choose
to build againts the distro version instead.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/870

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1465>

4 years agosctp: import internal copy of usrsctp library
Tim-Philipp Müller [Fri, 24 Jul 2020 18:23:19 +0000 (19:23 +0100)]
sctp: import internal copy of usrsctp library

There are problems with global shared state and no API stability
guarantees, and we can't rely on distros shipping the fixes we
need. Both firefox and Chrome bundle their own copies too.

Imported from https://github.com/sctplab/usrsctp,
commit 547d3b46c64876c0336b9eef297fda58dbe1adaf
Date: Thu Jul 23 21:49:32 2020 +0200

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/870

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1465>

4 years agoproxysink: event_function needs to handle the event when it is disconnecetd from...
Jose Quaresma [Wed, 12 Aug 2020 10:57:10 +0000 (11:57 +0100)]
proxysink: event_function needs to handle the event when it is disconnecetd from proxysrc

without this a disconneted proxysink fail when goes to play with error:

 Internal data stream error.
 streaming stopped, reason error (-5)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1508>

4 years agocccombiner: Correct sink_query chain up and fix caps leaks
Seungha Yang [Thu, 13 Aug 2020 11:19:21 +0000 (20:19 +0900)]
cccombiner: Correct sink_query chain up and fix caps leaks

Don't chain up to src_query() from sink_query() method, and
returned caps by gst_static_pad_template_get_caps() needs to be
cleared.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1513>

4 years agomediafoundation: Call MFShutdown when destroying plugin
Seungha Yang [Wed, 12 Aug 2020 17:24:52 +0000 (02:24 +0900)]
mediafoundation: Call MFShutdown when destroying plugin

MFStartup and MFShutdown should be paired as documented in
https://docs.microsoft.com/en-us/windows/win32/api/mfapi/nf-mfapi-mfstartup#remarks
Otherwise valgrind-like tools would report false positive memory leak.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1512>

4 years agomsdkvpp: do not hold too many input buffers in locked list
Xu Guangxin [Tue, 4 Aug 2020 09:14:44 +0000 (17:14 +0800)]
msdkvpp: do not hold too many input buffers in locked list

If the surface is locked before vpp, upstream takes the reference.
We do not need to take a reference for msdk in vpp.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1490>

4 years agomsdkvpp: refact, put input and output surface in diffrent list
Xu Guangxin [Mon, 3 Aug 2020 07:29:08 +0000 (15:29 +0800)]
msdkvpp: refact, put input and output surface in diffrent list

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1490>

4 years agoCorrect typos in gsth264parse.c
Felix Yan [Wed, 12 Aug 2020 17:03:00 +0000 (17:03 +0000)]
Correct typos in gsth264parse.c

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1511>

4 years agod3d11: Handle newly added GST_VIDEO_TRANSFER_BT601
Seungha Yang [Mon, 6 Jul 2020 19:31:50 +0000 (04:31 +0900)]
d3d11: Handle newly added GST_VIDEO_TRANSFER_BT601

Use the value for mapping between DXGI_COLOR_SPACE_TYPE and GstVideoColorimetry.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1410>

4 years agod3d11: Store more device information in context structure
Seungha Yang [Wed, 12 Aug 2020 08:11:57 +0000 (17:11 +0900)]
d3d11: Store more device information in context structure

It would be more informative for debugging

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1507>

4 years agod3d11: Selected adapter index should be unsigned integer
Seungha Yang [Wed, 12 Aug 2020 08:02:31 +0000 (17:02 +0900)]
d3d11: Selected adapter index should be unsigned integer

If d3d11device was created successfully, the index of adapter
must not be negative value

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1507>

4 years agoh264parse: Add new H.264 levels
Nicolas Dufresne [Tue, 11 Aug 2020 21:17:39 +0000 (17:17 -0400)]
h264parse: Add new H.264 levels

The spec now list 6, 6.1 and 6.2.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1509>

4 years agova: h264dec: remove spurious comment
Víctor Manuel Jáquez Leal [Sat, 8 Aug 2020 17:59:49 +0000 (19:59 +0200)]
va: h264dec: remove spurious comment

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1499>

4 years agova: h264dec: check return value of gst_va_handle_set_context()
Víctor Manuel Jáquez Leal [Sat, 8 Aug 2020 17:59:11 +0000 (19:59 +0200)]
va: h264dec: check return value of gst_va_handle_set_context()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1499>

4 years agosmoothstreaming: start closer to the edge in live streams
Hosang Lee [Tue, 16 Jun 2020 03:42:16 +0000 (12:42 +0900)]
smoothstreaming: start closer to the edge in live streams

It is more appropriate to start closer to the live edge in
live streams. Some live streams maintain a large dvr window
(over few hours in some cases), so starting from the first
fragment will be too far away from the live edge.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1346>

4 years agocccombiner: Update for additional info parameter to the "samples-selected" signal
Sebastian Dröge [Fri, 7 Aug 2020 06:37:20 +0000 (09:37 +0300)]
cccombiner: Update for additional info parameter to the "samples-selected" signal

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/590

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1498>

4 years agobuild: update for gl pkg-config file split
Matthew Waters [Fri, 24 Jul 2020 07:31:36 +0000 (17:31 +1000)]
build: update for gl pkg-config file split

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1462>

4 years agodocs: include *.cc and *.hh in gst-c-sources
Mathieu Duponchelle [Thu, 6 Aug 2020 17:11:34 +0000 (19:11 +0200)]
docs: include *.cc and *.hh in gst-c-sources

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: add disable-encode-retries property
Mathieu Duponchelle [Tue, 4 Aug 2020 14:33:34 +0000 (16:33 +0200)]
mpeg2enc: add disable-encode-retries property

MJPEG Tools may reencode pictures in a second pass to stick
closer to the target bitrate. This can result in slower than
real-time encoding for full HD content in certain situations,
as entire GOPs need reencoding when the reference picture is
reencoded.

See https://sourceforge.net/p/mjpeg/bugs/141/ for background

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: report a latency
Mathieu Duponchelle [Tue, 4 Aug 2020 14:05:55 +0000 (16:05 +0200)]
mpeg2enc: report a latency

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: finalize GstVideoEncoder port
Mathieu Duponchelle [Tue, 4 Aug 2020 14:05:33 +0000 (16:05 +0200)]
mpeg2enc: finalize GstVideoEncoder port

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: store video encoder instance directly in stream writer class
Tim-Philipp Müller [Sun, 23 Jun 2013 15:38:49 +0000 (16:38 +0100)]
mpeg2enc: store video encoder instance directly in stream writer class

Instead of storing the pad and then only using it to get the
element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: remove unused streamwriter member 'buf'
Tim-Philipp Müller [Sun, 23 Jun 2013 15:33:59 +0000 (16:33 +0100)]
mpeg2enc: remove unused streamwriter member 'buf'

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: remove some unused code
Tim-Philipp Müller [Sun, 23 Jun 2013 14:07:53 +0000 (15:07 +0100)]
mpeg2enc: remove some unused code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: remove code paths for older mjpegtools versions
Tim-Philipp Müller [Sun, 23 Jun 2013 13:32:15 +0000 (14:32 +0100)]
mpeg2enc: remove code paths for older mjpegtools versions

Gets rid of lots of code paths that no one has built,
used or tested for ages, and makes code more maintainable.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agompeg2enc: initial port to GstVideoEncoder base class
Alban Browaeys [Mon, 1 Oct 2012 11:11:29 +0000 (13:11 +0200)]
mpeg2enc: initial port to GstVideoEncoder base class

https://bugzilla.gnome.org/show_bug.cgi?id=685414

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1491>

4 years agodecklink: Re-order modes enum for backwards compatibility with 1.16
Sebastian Dröge [Wed, 5 Aug 2020 07:52:08 +0000 (10:52 +0300)]
decklink: Re-order modes enum for backwards compatibility with 1.16

The PAL/NTSC widescreen modes were added after 1.16 but inserted before
the HD modes, which changed the integer values of the enums.

Move them to the very end instead to keep backwards compatibility.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1048

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1492>

4 years agosrt: Add support for using hostnames instead of IP addresses
Sebastian Dröge [Wed, 5 Aug 2020 08:21:48 +0000 (11:21 +0300)]
srt: Add support for using hostnames instead of IP addresses

If an address can't be parsed as IP address, try resolving it via
GResolver instead. SRT URIs more often than not contain hostnames and
without trying to resolve them we won't be able to handle such URIs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1493>

4 years agocccombiner: update to new samples selection API
Mathieu Duponchelle [Wed, 5 Aug 2020 14:57:15 +0000 (16:57 +0200)]
cccombiner: update to new samples selection API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1497>

4 years agoopencv: compile with -Wno-format-nonliteral
Jordan Petridis [Wed, 5 Aug 2020 09:35:12 +0000 (12:35 +0300)]
opencv: compile with -Wno-format-nonliteral

opencv plugin is pulling a header which makses clang++ 10
complain a lot and blocks -werror.

```
/usr/include/opencv4/opencv2/flann/logger.h:83:36: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
        int ret = vfprintf(stream, fmt, arglist);
                                   ^~~
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1494>

4 years agoplayer: Add g_autoptr() support
Guillaume Desmottes [Wed, 5 Aug 2020 10:31:53 +0000 (12:31 +0200)]
player: Add g_autoptr() support

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1495>

4 years agogstlv2utils.c: avoid implicit float to int conversion
Jordan Petridis [Mon, 3 Aug 2020 15:40:31 +0000 (18:40 +0300)]
gstlv2utils.c: avoid implicit float to int conversion

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1487>

4 years agogstautoconvert.c: fix clang warnings
Jordan Petridis [Mon, 3 Aug 2020 15:35:56 +0000 (18:35 +0300)]
gstautoconvert.c: fix clang warnings

clang 10 is complaining about incompatible types due to the
glib typesystem.

```
gst-plugins-bad/gst/autoconvert/b5c3019@@gstautoconvert@sha/gstautoconvert.c.o' -c ../subprojects/gst-plugins-bad/gst/autoconvert/gstautoconvert.c
../subprojects/gst-plugins-bad/gst/autoconvert/gstautoconvert.c:898:8: error: incompatible pointer types passing 'typeof ((((void *)0))) *' (aka 'void **') to parameter of type 'GList **' (aka 'struct _GList **') [-Werror,-Wincompatible-pointer-types]
  if (!g_atomic_pointer_compare_and_exchange (&autoconvert->factories, NULL,
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gatomic.h:192:44: note: expanded from macro 'g_atomic_pointer_compare_and_exchange'
    __atomic_compare_exchange_n ((atomic), &gapcae_oldval, (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \
                                           ^~~~~~~~~~~~~~
1 error generated.
```

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1487>

4 years agogstladspautils.c: avoid implicit float to int conversion
Jordan Petridis [Mon, 3 Aug 2020 15:25:28 +0000 (18:25 +0300)]
gstladspautils.c: avoid implicit float to int conversion

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1487>

4 years agoandroidmedia: ignore additional camera effects if not present
Andrew Branson [Mon, 27 Jul 2020 13:45:49 +0000 (15:45 +0200)]
androidmedia: ignore additional camera effects if not present

Fixes https://gitlab.freedesktop.org/gstreamer/cerbero/-/issues/283

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1470>

4 years agomeson: Only look for Obj-C/C++ compilers on macOS/iOS
Nirbheek Chauhan [Tue, 4 Aug 2020 00:04:23 +0000 (05:34 +0530)]
meson: Only look for Obj-C/C++ compilers on macOS/iOS

On Windows, MinGW-GCC Objective-C/C++ compilers can be in PATH and
mess up the build since they may not match the CPU family of the C/C++
compilers we are using.

Also require them on macOS/iOS, because they should always be present.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-build/-/issues/88

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1488>

4 years agova: h264dec: log if upstream pool is kept
Víctor Manuel Jáquez Leal [Tue, 4 Aug 2020 08:38:30 +0000 (10:38 +0200)]
va: h264dec: log if upstream pool is kept

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1489>

4 years agova: utils: fix precondition check for handle_context_query()
Víctor Manuel Jáquez Leal [Tue, 4 Aug 2020 08:24:49 +0000 (10:24 +0200)]
va: utils: fix precondition check for handle_context_query()

display paramater can be NULL, but if it's not, it has to be a
GstVaDisplay.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1489>

4 years agova: tests: example: Fix memory leaks
Víctor Manuel Jáquez Leal [Tue, 4 Aug 2020 08:20:46 +0000 (10:20 +0200)]
va: tests: example: Fix memory leaks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1489>

4 years agosrtobject: Add support for IPv6
Francisco Javier Velázquez-García [Thu, 30 Jul 2020 16:26:34 +0000 (18:26 +0200)]
srtobject: Add support for IPv6

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1477>

4 years agosrtobject: Reset parameters before setting URI
Francisco Javier Velázquez-García [Thu, 30 Jul 2020 16:26:34 +0000 (18:26 +0200)]
srtobject: Reset parameters before setting URI

This makes `gst_srt_object_validate_parameters` work properly since
`localaddress` and `localport` will be missing if the URL did not
provide them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1477>

4 years agosrtobject: Simplify gst_srt_object_set_*_value
Francisco Javier Velázquez-García [Thu, 30 Jul 2020 16:26:33 +0000 (18:26 +0200)]
srtobject: Simplify gst_srt_object_set_*_value

This fixes `gst_srt_object_set_string_value` in particular because the
value might not be a static string.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1477>

4 years agosrtobject: Store passphrase like other parameters
Francisco Javier Velázquez-García [Thu, 30 Jul 2020 16:26:33 +0000 (18:26 +0200)]
srtobject: Store passphrase like other parameters

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1477>

4 years agowebrtc, rtmp2: Warn if the user or password aren't escaped
Nirbheek Chauhan [Fri, 31 Jul 2020 20:48:39 +0000 (02:18 +0530)]
webrtc, rtmp2: Warn if the user or password aren't escaped

If the user/pass aren't escaped, the userinfo will be ambiguous and we
won't know where to split. We will accidentally get it right if the :
belongs in the password.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481>

4 years agowebrtc, rtmp2: Fix parsing of userinfo in URI strings
Nirbheek Chauhan [Fri, 31 Jul 2020 20:42:21 +0000 (02:12 +0530)]
webrtc, rtmp2: Fix parsing of userinfo in URI strings

While parsing the string, `gst_uri_from_string()` also unescapes the
userinfo. This is bad if your username contains a `:` character, since
we will then split the userinfo at the wrong location when parsing it.

To fix this, we can use the new `gst_uri_from_string_escaped()` API
that was added in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/583

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/831

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481>

4 years agotests: examples: add va-x11-render example
Víctor Manuel Jáquez Leal [Mon, 3 Aug 2020 11:50:23 +0000 (13:50 +0200)]
tests: examples: add va-x11-render example

This a GTK+ example will share, through GstContext, a custom X11
VADisplay to a pipeline using vah264dec and appsink.

When the frames are processed for rendering, the VASurfaceID is
fetched from the buffer and it is rendered using vaPutSurface in a X11
widget.

4 years agotests: examples: Comply with compilation order
Víctor Manuel Jáquez Leal [Mon, 3 Aug 2020 11:45:49 +0000 (13:45 +0200)]
tests: examples: Comply with compilation order

4 years agova: allocator: support for GST_MAP_VA map flag
Víctor Manuel Jáquez Leal [Sun, 2 Aug 2020 15:52:50 +0000 (17:52 +0200)]
va: allocator: support for GST_MAP_VA map flag

This flag will return the VASurface value at mapping

4 years agova: context: instanciate VA display through GstContext
Víctor Manuel Jáquez Leal [Sun, 2 Aug 2020 13:51:08 +0000 (15:51 +0200)]
va: context: instanciate VA display through GstContext

Add all the machinery to instanciate VA display through GstContext,
thus all va elements can share the same display and the user can set
a custom one.

4 years agova: h264dec: don't copy frames if VAMemory capsfeature is negotiated
Víctor Manuel Jáquez Leal [Mon, 3 Aug 2020 11:44:23 +0000 (13:44 +0200)]
va: h264dec: don't copy frames if VAMemory capsfeature is negotiated

Otherwise the VASurfaceID is lost.

4 years agova: h264dec: copy render_device_path in klass
Víctor Manuel Jáquez Leal [Mon, 3 Aug 2020 11:42:54 +0000 (13:42 +0200)]
va: h264dec: copy render_device_path in klass

It it's not copied both cdata and klass, the string is lost. Thus
also it's freed from cdata when freeing it.

4 years agova: display: wrapped: Fix property name
Víctor Manuel Jáquez Leal [Mon, 3 Aug 2020 11:42:00 +0000 (13:42 +0200)]
va: display: wrapped: Fix property name

4 years agova: decoder: remove unused argument
Víctor Manuel Jáquez Leal [Sun, 2 Aug 2020 13:54:31 +0000 (15:54 +0200)]
va: decoder: remove unused argument

And that changes function's namespace

4 years agova: caps: bail raw caps if driver doesn't report surface formats
Víctor Manuel Jáquez Leal [Sat, 1 Aug 2020 19:59:30 +0000 (21:59 +0200)]
va: caps: bail raw caps if driver doesn't report surface formats

This is a bug in Gallium RadeonSI driver for Polaris10, which doesn't
report sufrace formats for reported chroma.

If one chroma doesn't report surface formats, skip the generated caps.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1483>

4 years agova: allocator: get a surface format from a image format
Víctor Manuel Jáquez Leal [Sat, 1 Aug 2020 13:47:19 +0000 (15:47 +0200)]
va: allocator: get a surface format from a image format

For the allocator to create surfaces with the correct chroma an
fourcc, it should use a surface format, not necessarily the negotiated
format.

Instead of the previous arbitrary extra formats list, the decoder
extracts the valid pixel formats from the given VA config, and pass
that list to the allocator which stores it (full transfer).

Then, when the allocator allocates a new surface, it looks for a
surface color format chroma-compatible with the negotiated image color
format.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1483>

4 years agova: caps: add raw caps image formats with same chroma of surfaces
Víctor Manuel Jáquez Leal [Sat, 1 Aug 2020 13:03:22 +0000 (15:03 +0200)]
va: caps: add raw caps image formats with same chroma of surfaces

Instead of adding a list of ad-hoc formats for raw caps (I420 and
YV12), the display queries the available image formats and we assume
that driver can download frames in that available format with same
chroma of the config surfaces chroma.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1483>

4 years agova: display: add gst_va_display_get_image_formats()
Víctor Manuel Jáquez Leal [Mon, 27 Jul 2020 09:14:02 +0000 (11:14 +0200)]
va: display: add gst_va_display_get_image_formats()

For this it was also added gst_va_video_format_from_va_image_format()

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1483>

4 years agova: decoder: initialize rt_formas to zero
Víctor Manuel Jáquez Leal [Mon, 27 Jul 2020 09:14:49 +0000 (11:14 +0200)]
va: decoder: initialize rt_formas to zero

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1483>

4 years agod3d11download: Allow linking with downstream d3d11 elements
Seungha Yang [Mon, 3 Aug 2020 10:49:15 +0000 (19:49 +0900)]
d3d11download: Allow linking with downstream d3d11 elements

It will make pipeline configuration easier since d3d11download
element can be placed unconditionally. This behavior is similar
to that of gldownload element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1485>

4 years agohlssink2: Don't assert if we don't have a current location when receiving the fragmen...
Sebastian Dröge [Mon, 27 Jul 2020 13:37:20 +0000 (16:37 +0300)]
hlssink2: Don't assert if we don't have a current location when receiving the fragment-closed message

This can happen if the application did not provide an output stream for
the fragment and didn't handle the error message before splitmuxsink
decided to consider the fragment closed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1469>

4 years agoopencv: allow compilation against 4.4.x
Nicola Murino [Fri, 31 Jul 2020 21:38:56 +0000 (23:38 +0200)]
opencv: allow compilation against 4.4.x

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1482>

4 years agomfvideosrc: Select common formats if both VideoPreview and VideoRecord are available
Seungha Yang [Fri, 31 Jul 2020 17:19:07 +0000 (02:19 +0900)]
mfvideosrc: Select common formats if both VideoPreview and VideoRecord are available

Some devices (e.g., Surface Book 2, Surface Pro X) will expose
both MediaStreamType_VideoPreview and MediaStreamType_VideoRecord types
for a logical device. And for some reason, MediaStreamType_VideoPreview
seems to be selected between them while initiailzing device.
But I cannot find any documentation for the decision rule.
To be safe, we will select common formats between them.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1478>

4 years agomfvideosrc: Check framerate for target IMediaFrameFormat selection
Seungha Yang [Fri, 31 Jul 2020 15:53:46 +0000 (00:53 +0900)]
mfvideosrc: Check framerate for target IMediaFrameFormat selection

Not only resolution and format, but framerate needs to be checked
for proper target IMediaFrameFormat selection.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1478>

4 years agomfvideosrc: Handle I420/IYUV subtypes for UWP cases
Seungha Yang [Thu, 30 Jul 2020 18:46:39 +0000 (03:46 +0900)]
mfvideosrc: Handle I420/IYUV subtypes for UWP cases

Microsoft defines two I420 formats, one is I420, and the other is
IYUV (but both are same, just names are different).
Since both will be converted to GST_VIDEO_FORMAT_I420,
we should check both I420 and IYUV subtypes during
GstVideoFormat to Microsoft's format conversion.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1478>

4 years agomfvideosrc: Add more debug log
Seungha Yang [Thu, 30 Jul 2020 18:26:35 +0000 (03:26 +0900)]
mfvideosrc: Add more debug log

It would be useful for finding the error reason.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1478>

4 years agodocs: Update wasapi2 and mfvideosrc doc
Seungha Yang [Fri, 31 Jul 2020 12:07:15 +0000 (21:07 +0900)]
docs: Update wasapi2 and mfvideosrc doc

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1480>

4 years agowasapi2, mfvideosrc: Update "dispatcher" property to be only writable
Seungha Yang [Fri, 31 Jul 2020 11:57:29 +0000 (20:57 +0900)]
wasapi2, mfvideosrc: Update "dispatcher" property to be only writable

Disallow getting dispatcher pointer, since it doesn't seem to be useful
and might not be safe.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1480>

4 years agocccombiner: implement samples selection API
Mathieu Duponchelle [Wed, 1 Jul 2020 01:59:56 +0000 (03:59 +0200)]
cccombiner: implement samples selection API

Call gst_aggregator_selected_samples() after identifying the
caption buffers that will be added as a meta on the next video
buffer.

Implement GstAggregator.peek_next_sample.

Add an example that demonstrates usage of the new API in
combination with the existing buffer-consumed signal.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1390>

4 years agowpesrc: timestamp buffers when working with SHM buffers
Mathieu Duponchelle [Tue, 28 Jul 2020 22:04:40 +0000 (00:04 +0200)]
wpesrc: timestamp buffers when working with SHM buffers

GLBaseSrc::fill() will take care of that when dealing with
images, but as we don't chain up when dealing with SHM buffers
this needs to be done in order for GLBaseSrc::get_times() to
work appropriately.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1476>

4 years agowpe: fix ready signalling
Mathieu Duponchelle [Tue, 28 Jul 2020 21:28:12 +0000 (23:28 +0200)]
wpe: fix ready signalling

Receiving the WEBKIT_LOAD_COMMITTED event doesn't actually
mean we have committed an SHM buffer / image yet.

As this is the condition we are interested in, check it
instead.

Also wrap g_cond_wait in a loop for extra correctness points.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1476>

4 years agobasecamerabinsrc: silence g-ir-scanner warnings
Tim-Philipp Müller [Tue, 28 Jul 2020 10:43:47 +0000 (11:43 +0100)]
basecamerabinsrc: silence g-ir-scanner warnings

They're legit, but there's lots of other stuff that needs
fixing up in this API, so just silence for now and add a
FIXME and leave it for some other day.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1475>