dakovaci [Tue, 6 Dec 2011 05:25:31 +0000 (15:25 +1000)]
Edited the Camera systemtest
Just some small editing
Change-Id: I918a259570ef105047015dccfbf27c1be6e5a513
Reviewed-by: Natalia Shubina <natalia.shubina@nokia.com>
Jason McDonald [Tue, 6 Dec 2011 07:15:15 +0000 (17:15 +1000)]
Remove unused QTRY_WAIT macros.
Change-Id: I8484c19d0458d9ec9a3a621fa0b866258e8212c3
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Jason McDonald [Tue, 6 Dec 2011 07:10:25 +0000 (17:10 +1000)]
Remove duplicates of QTRY_VERIFY and QTRY_COMPARE.
These macros are now provided by testlib via the QtTest/QtTest header.
Change-Id: I6b499395888268aab315d63404e2b0eed8688615
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Friedemann Kleint [Mon, 5 Dec 2011 10:09:03 +0000 (11:09 +0100)]
QtMultiMedia: Fix warnings about missing return values.
In QDebug operator<< for enumerations.
Change-Id: I52309356f05a9520b7472a673450a224d7fa71d3
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Friedemann Kleint [Mon, 5 Dec 2011 12:58:30 +0000 (13:58 +0100)]
QtMultimedia: Fix warnings about declarative/quick.
Change-Id: Ic9323b222641e41dae05cb4b0dccb6531e845676
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Jason McDonald [Fri, 2 Dec 2011 04:39:42 +0000 (14:39 +1000)]
Cleanup multimedia unit tests.
Use QTEST_MAIN or QTEST_GUILESS_MAIN instead of equivalent custom main()
functions. Also collapse each test into a single source file, in line
with most other autotests.
Change-Id: I38c7b6a9eb0ff1c9b8ac44de7d5f40d6ac6c46ea
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
dakovaci [Fri, 2 Dec 2011 03:32:33 +0000 (13:32 +1000)]
Add playlist test
Added some playlist tests and edit some audio
Change-Id: I936ef4772be9aebe5baf8f755cedadc93107f9e4
Reviewed-by: Natalia Shubina <natalia.shubina@nokia.com>
Dmytro Poplavskiy [Thu, 1 Dec 2011 04:29:32 +0000 (14:29 +1000)]
Implemented QDeclarativeCameraCapture::setMetadata
QMetaDataWriterControl is used if it's available.
Change-Id: I18fd36c411b6d3c397ff22ebfea9b2c0e878cdeb
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Dmytro Poplavskiy [Mon, 28 Nov 2011 05:00:26 +0000 (15:00 +1000)]
Allow nested read only maps of QVideoFrame.
It's useful when video frame is accessed from multiple places
like display and encoding.
Change-Id: I8af175c780783216d8b7717cdf0744ad9bc95348
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Fri, 25 Nov 2011 05:25:22 +0000 (15:25 +1000)]
Add orientation support to VideoOutput.
Just uses an integer to represent the degrees rotation from standard.
Only supports multiples of 90 - other rotation can be done with
standard QML.
Change-Id: Id4013169c5d9da473b6e5be94ba341da21c2f2a3
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Toby Tomkins [Fri, 25 Nov 2011 05:38:27 +0000 (15:38 +1000)]
Fixed QtMultimedia core namespace compilation.
Change-Id: Ie276a7766bd26f3e49b2bc9c1a28ec96f1e3e4b0
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Dmytro Poplavskiy [Thu, 24 Nov 2011 04:23:45 +0000 (14:23 +1000)]
Updated I420 video node to be consistent with RGB node implementation.
Don't keep the frame after it was uploaded to texture;
Upload frame data during rendering (in material shader updateState)
instead of updatePaintNode().
Change-Id: Ia6a4063bfa02d4d20f75735649fe4f777cf50494
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Thu, 24 Nov 2011 03:25:21 +0000 (13:25 +1000)]
QAudioDeviceInfo is actually an integration test.
It should be separated at some point.
Change-Id: I03adde303eed558d52e06f0afa673252e54c2182
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Thu, 24 Nov 2011 02:42:24 +0000 (12:42 +1000)]
If we fail to connect to pulse, don't enumerate sinks or sources.
Otherwise the pulse client library dislikes having methods called
with a null context.
Change-Id: I96629065b7a0e36e0d10402526cb167e65458e27
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Ling Hu [Tue, 22 Nov 2011 06:17:23 +0000 (16:17 +1000)]
Add testDestroyWhileRestartPlaying for qsoundeffect
This covers the potential crash reported by qfeedbackmmk test.
Change-Id: Ib533e80b25c4c7fb291527d62445aaa40960baa0
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Dmytro Poplavskiy [Fri, 18 Nov 2011 03:23:21 +0000 (13:23 +1000)]
VideoOutput: release video frames when the video surface is stopped.
It's necessary to release video frames during media pipeline shutdown
or reconfiguration.
Change-Id: I386ad4d173b8731f257ec9272ef8c46a27769bd0
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Fri, 18 Nov 2011 06:59:36 +0000 (16:59 +1000)]
Fix SoundEffect(pulseaudio) crash in qfeedbackmmk auto test
Task-Number: QTBUG-22779
Some pulseaudio callback may happen after SoundEffect was deleted,
thus the userdata(SoundEffect point) we passed previously may
result in potential crash with QMetaObject::invokeMethod to queue some event.
To solve this problem, the release mehtod is added to SoundEffectPrivate,
and instead of calling d->deleteLater in SoundEffect::dtor,
d->release is called. So SoundEffectPrivate will no when it is going to
be deleted soon rather than handle everything in SoundEffectPrivate::dtor
which may be too late.
class RefObject is also added to be able to track the SoundEffectPrivate
status by pulseaduio callbacks. I thought this could be avoided by checking
the connection state of pulse stream. However, that doesn't work as expected,
stream state remains Ready when checked in callbacks even after disconnect
stream has been called. So RefObject is used instead and its lifecycle is
managed by an internal reference count.
When release is invoked,
m_ref->onDeleted is called first, this will mark SoundEffectPrivate as dead.
and then unloadPulseStream is called.
After those two invocations, we can be asured that:
1. if some pulse callbacks has been called without knowing
SoundEffectPrivate dead, the queued invocation on SoundEffectPrivate
would be safe, since SoundEffectPrivate::deleteLater would
be called after them.
2. Since on pulse callbacks would be executed when unloadPulseStream is called,
then at this moment if some pulse callbacks is called again, it would certainly
knows that SoundEffectPrivate is marked as dead and would not queue and
event on SoundEffectPrivate.
Now, the deleteLater can be safely called.
Change-Id: I807f29cddb677d1f4bc078fd306ed0d83d6f7dc4
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Toby Tomkins [Mon, 21 Nov 2011 07:37:31 +0000 (17:37 +1000)]
Fixed qtmultimedia imports -qtnamespace issues.
Change-Id: Ie7896faf92b3cc5fdf2b6dbe885913c2669e6e36
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Michael Goddard [Fri, 18 Nov 2011 02:30:42 +0000 (12:30 +1000)]
If the sample hasn't been loaded, don't try and delete things.
Causes entirely reasonable warnings from QCoreApplication::postEvents,
when calling deleteLater on a null pointer.
Change-Id: I5f1fa526b2d57844b9c0d2e634d434e2f7867bdf
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Michael Goddard [Fri, 18 Nov 2011 02:30:42 +0000 (12:30 +1000)]
If the sample hasn't been loaded, don't try and delete things.
Causes entirely reasonable warnings from QCoreApplication::postEvents,
when calling deleteLater on a null pointer.
Change-Id: I5f1fa526b2d57844b9c0d2e634d434e2f7867bdf
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Jonas Rabbe [Fri, 18 Nov 2011 00:53:29 +0000 (10:53 +1000)]
Export QMediaPluginLoader so it can be used by libqgsttools_p.
Change-Id: I2af6a68646cccaa92ae8b85b67e2095dcfee485e
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Jonas Rabbe [Fri, 18 Nov 2011 00:53:29 +0000 (10:53 +1000)]
Export QMediaPluginLoader so it can be used by libqgsttools_p.
Change-Id: I2af6a68646cccaa92ae8b85b67e2095dcfee485e
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Michael Goddard [Thu, 17 Nov 2011 07:22:36 +0000 (17:22 +1000)]
If Pulse isn't ready, don't crash when trying to play.
Change-Id: I996581e4492004f716d44a39fb5f74c26c9f9ac2
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Ling Hu [Wed, 28 Sep 2011 02:15:51 +0000 (12:15 +1000)]
Fix volume change error on mono stream for soundeffect(pulseaudio)
(Cherry-picked from
663df44fc8563c548c26a7ae21927b09664c28f2)
Change-Id: I005071bc1a8b2eae4d0660042fc8986d61804c47
Reviewed-by: Michael Goddard
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Tue, 15 Nov 2011 05:40:04 +0000 (15:40 +1000)]
Add cap on internal read/write buffer for QAudioOuput(PA)
cap set to no more than 5x period size
Change-Id: If3ae244993a8929832f6724c386dac6f12ef0f03
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Dmytro Poplavskiy [Mon, 14 Nov 2011 23:56:32 +0000 (09:56 +1000)]
Added support for non QMediaObject based VideoOutput sources.
VideoOutput element checks first for mediaObject property of
source object and if it's not available it checks
for videoSurface property.
It allows to implement video frames generator and connect it
to optimized VideoOutput QML element.
Change-Id: I8ee618cf61b9d9100f25e742c631ea8724c188dc
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Ling Hu [Mon, 14 Nov 2011 04:37:40 +0000 (14:37 +1000)]
Add additional protection on the write size in QAudioOuput(pulseaudio)
Check and cap the write size in pull mode to handle the case
where user returned an invalid write size through QIODevice
Change-Id: Ie0610a63f1d5400fba87f32a99bdc38479e0e7e8
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Jonas Rabbe [Tue, 8 Nov 2011 02:38:02 +0000 (12:38 +1000)]
Changed QVideoSurfaceGstSink to take pools from plugins
Change-Id: Iec743efc52513e2000276b9a18d1d9639c270699
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Jason McDonald [Wed, 9 Nov 2011 04:14:08 +0000 (14:14 +1000)]
Remove SkipMode parameter from QSKIP.
The SkipMode parameter has been removed from the API in qtbase, so it
must be in all calls to QSKIP.
Task-number: QTBUG-21851, QTBUG-21652
Change-Id: Ib6225572a46eac7881222fdce192750b8b13ee3b
Reviewed-by: Steve Schilz <sschilz@pasco.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
dakovaci [Mon, 31 Oct 2011 05:52:26 +0000 (15:52 +1000)]
Radio systemtests
Added some radio functionality to match the qlm radio example
Change-Id: Ie0358c3443121b638db406e095467b18b4d6b57c
Reviewed-by: Daron Andrew Edie
(cherry picked from commit
1e542df82fbcc4e3a8f75537af204f83827a4587)
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Tue, 8 Nov 2011 07:41:00 +0000 (17:41 +1000)]
Add qRegisterMetaTypes for the public Q_DECLARE_METATYPEs.
Also turned qtmedianamespace.qdoc into a cpp file so I
could stick the qRegisterMetaTypes into it.
Change-Id: Idd6d3e2f348f1ed45b0a35ce180d023a170e8625
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Ling Hu [Mon, 7 Nov 2011 01:49:09 +0000 (11:49 +1000)]
Fix pullmode data lost problem in QAudioOutput(pulseaudio)
At each userFeed, m_bytesAvailable is not updated properly in pullmode,
so the pull data size become irrelevent to the size we can actually write.
This problem is fixed by checking the actual writable size each time
before pulling the data and limit the size of the pulled and written data.
Change-Id: I6f53e6348693ddf4e3c79e90d3c3d0c1ffc713aa
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Tue, 8 Nov 2011 06:56:12 +0000 (16:56 +1000)]
Change the order textures are bound.
Leave texture unit 0 active at the end, since the active texture unit
is not restored by SG itself.
Change-Id: I4970a955fea5c9342cc93c1d1b07ffbfb71e5f04
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Jonas Rabbe [Tue, 8 Nov 2011 03:32:14 +0000 (13:32 +1000)]
Added qRegisterMetatype for QVideoSurfaceFormat.
Change-Id: I7dbae1dde2f24db89479dcb23ef6fc5e29377f25
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Bradley T. Hughes [Tue, 1 Nov 2011 12:37:41 +0000 (13:37 +0100)]
Use QAtomicInt::load() and ::store()
The operator=(int) and implicit int cast operators are deprecated
and will be removed.
Change-Id: I5091d705fba45195239c901f210355e09e123faa
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
Michael Goddard [Fri, 4 Nov 2011 03:38:44 +0000 (13:38 +1000)]
Rearrange the automatic tests.
Split them into unit and integration tests. Integration tests really
need to be run on the real platform (not in a VM etc) since they are
somewhat unstable or nonfunctional otherwise.
A few tests were previously broken by QUrl changes and they were repaired.
Removed one test since it was not providing a lot of value.
There are still a number of tests that rely on Q_AUTOTEST_EXPORT symbols.
Change-Id: Ic402abf0af946baa5945075d975b3f584f9ef280
Reviewed-by: Kalle Lehtonen <kalle.ju.lehtonen@nokia.com>
Michael Goddard [Tue, 1 Nov 2011 02:46:48 +0000 (12:46 +1000)]
Declare more metatypes and debug operators.
Nearly all of the multimedia metatypes used in the auto tests are
now declared properly, and a large number of the types have debug
operators as well.
Removed the superfluous decls as well.
Change-Id: I42cfe37562db0c71d9811b4577fc326a3326ccc9
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Tue, 1 Nov 2011 01:19:22 +0000 (11:19 +1000)]
Add a private class, since we now can.
This was a XXX Qt5 thing for binary compatibility. We could also
now use QObjectPrivate if we wanted to.
Change-Id: I7d95e3adf7b0725e91e1e229646a453863e989ed
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Friedemann Kleint [Fri, 28 Oct 2011 07:09:59 +0000 (09:09 +0200)]
QtMultimedia: Remove qpa-sections from .profiles.
Prepare for removal of the -qpa configure option.
Change-Id: Ibf4be58231d29cd972eb765f32b410e1eb9d7fed
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Kent Hansen [Wed, 5 Oct 2011 12:20:22 +0000 (14:20 +0200)]
Fix logic in QAudioDeviceInfoInternal::updateLists()
Task-number: QTBUG-20482
Change-Id: I0dd59a0388965726eb8cfd36a8549250916d999a
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Thu, 27 Oct 2011 00:45:13 +0000 (10:45 +1000)]
Remove the last bits of QtMultimediaKit (*).
Except a comment about it in the module overview.
Change-Id: I22d9111d7917d1a3259ee1e525fd52501733454e
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Wed, 26 Oct 2011 05:33:16 +0000 (15:33 +1000)]
Use deleteLater when called on a decoder error.
Since we cleanup the decoder itself, it can crash when the stack
unwinds back into the decoder code. Similarly on a network error.
Change-Id: Ice36a3008359565f186406945973747b3134d296
Reviewed-by: Ling Hu <ling.hu@nokia.com>
(cherry picked from commit
fb10bcf6cea520e1c43a77b6b88cf01ae9dc74ad)
Michael Goddard [Wed, 26 Oct 2011 00:33:50 +0000 (10:33 +1000)]
Merge remote branch 'qtmultimedia.git/master'
This replaces the qtmultimedia.git contents with qtmultimediakit.git's
contents (as a merge with -s ours, when run against qtmmk).
Change-Id: I940f84fb09285eb7e37d0aaac07ccc4f3165b04f
Michael Goddard [Tue, 25 Oct 2011 05:03:11 +0000 (15:03 +1000)]
Fix config.test
Using "this" in non member function, oops.
Change-Id: I7cda3eea755099af2ff2df7b777e3e228e53e325
Reviewed-by: Sergey Dubitskiy <sergey.dubitskiy@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Rohan McGovern [Tue, 25 Oct 2011 01:05:20 +0000 (11:05 +1000)]
Don't ignore debug plugins on Mac when release plugins aren't available
Previously, we unconditionally ignored any plugins whose names ended
with _debug.dylib. This makes the mediaservice plugins unusable on Mac
if Qt is configured to build plugins as debug-only (which is
incidentally the default).
Change-Id: I5a8981b2251e803fa233b74c968f6eaa452d367c
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Tue, 25 Oct 2011 03:51:32 +0000 (13:51 +1000)]
We already have a mock backend.
Change-Id: Ic4f9277c4c4bff225ac6cd70d28b495a42435e35
Reviewed-by: Sergey Dubitskiy <sergey.dubitskiy@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Tue, 25 Oct 2011 02:57:05 +0000 (12:57 +1000)]
Declare these metatypes.
Change-Id: I5b10669f2b17f67d95469dc28e99822d7f08280c
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Kent Hansen [Thu, 20 Oct 2011 06:37:39 +0000 (08:37 +0200)]
Adapt to QtDeclarative api renaming (QSG --> QQuick)
Change-Id: Iefee24c6262679263caef1976d0d9af541834ea0
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Rohan McGovern [Mon, 24 Oct 2011 03:04:56 +0000 (13:04 +1000)]
Fixed compile; QDesktopServices -> QStandardPaths
Broken by qtbase
dfa24768a3243eda68d91f573050bf23f96da2dd.
Change-Id: Ie0d79eaee5c6fedfaacae69800f6aec9190f83db
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Sami Nurmenniemi [Tue, 11 Oct 2011 06:06:12 +0000 (09:06 +0300)]
Added RDS functionality to the QRadioTuner/QDeclarativeRadio
Change-Id: I865e3caba82977002cf1f01f1d64ee0a42de77c6
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Fri, 21 Oct 2011 01:32:21 +0000 (11:32 +1000)]
Limit the sequential bytes skipping to a max 16kB at a time.
Otherwise QIODevice::read will try and allocate whatever junk is
passed in, so a corrupt chunk can result in 1GB+ allocations which
are never actually used.
Change-Id: I1ea4a5c1a5d21b1ee6f7e428105c52c0ee6ca7f7
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Fri, 21 Oct 2011 01:16:26 +0000 (11:16 +1000)]
Fix debug output test - type is qreal, so can be float or double.
Change-Id: Ica34e3076b186c4e4af4492722c1fe00445d3184
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Dmytro Poplavskiy [Thu, 20 Oct 2011 04:04:36 +0000 (14:04 +1000)]
Added testcase to qcamerabackend test CONFIG
To ensure the test case is installed.
Change-Id: I959a1d73e3d8c913c4f15bb9e12b663ca4fb0343
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Jonas Rabbe [Thu, 20 Oct 2011 02:45:28 +0000 (12:45 +1000)]
Fixed build problems with Quicktime
Because the Q_WS_* defines were removed, the Quicktime backend
stopped working. Replacing them with Q_OS_* works. Additionally,
the Quicktimer Player Service has to depend on QtWidgets.
Change-Id: I687b352191c38a91edaaf2a687ac13ed118fcf88
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Jerome Pasion [Wed, 12 Oct 2011 13:21:24 +0000 (15:21 +0200)]
Doc: Add ability to generate documentation for the module.
-Added targets so that "make docs" will generate the
documentation.
Change-Id: I16a74d7e15e12df16570f110c7e67a110d53afad
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Fri, 14 Oct 2011 00:36:49 +0000 (10:36 +1000)]
Init mediaobject at classBegin rather than componentComplete
Since we use an explicit backgroundaudio class,
there is no need to wait for other property to determine
the mediaobject type. So it is better to init the mediaobject
at classBegin to prevent being accessed before mediaobject initialized.
Change-Id: Ia55b8b4c1ab70cc0acbf6f49bcb3e20bdb813a88
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Michael Goddard [Mon, 17 Oct 2011 02:12:43 +0000 (12:12 +1000)]
Make the C++ API of QSoundEffect public.
The QML API already was. The C++ API still needs good documentation,
though.
Change-Id: I669f5ec7dd17d616788d71d77dc906acc0c0279f
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Dmytro Poplavskiy [Fri, 14 Oct 2011 02:36:18 +0000 (12:36 +1000)]
Declarative VideoOutput: added support for more rgb formats.
RGB 565, RGB 32 and BGR 32 formats added,
all of them supported with OpenGL ES.
Change-Id: I026628611c59575af5934bac0a5f95dfbc6770cb
Reviewed-on: http://codereview.qt-project.org/6644
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Jonas Rabbe [Fri, 14 Oct 2011 02:49:25 +0000 (12:49 +1000)]
Copied ALSA config test into QtMultimedia module
The config test which still exists in QtBase should be removed at a
later date, together with pulseaudio and gstreamer config tests.
Change-Id: I4bea45ab69d1bac10814fc60ecf24dbc859b0f20
Reviewed-on: http://codereview.qt-project.org/6643
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Fri, 14 Oct 2011 01:49:41 +0000 (11:49 +1000)]
Make sure this library gets installed.
Change-Id: I6b556b3b22deae002d2d2cf47680f23e207b5d00
Reviewed-on: http://codereview.qt-project.org/6639
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Kalle Juhani Lehtonen [Thu, 13 Oct 2011 07:16:51 +0000 (17:16 +1000)]
Fix qwavedecoder test data deployment on device
- Device deployment changed to use DEPLOYMENT instead of INSTALLS for
test data files
- Test data deployment target fixed to go under binary
installation directory instead of the build directory
Change-Id: I4b0007f9309767083a4a5dfa6f3dc26f3c36c330
Reviewed-on: http://codereview.qt-project.org/6573
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Friedemann Kleint [Wed, 12 Oct 2011 06:53:21 +0000 (08:53 +0200)]
Multimedia: Compile on Windows.
MSVC is more strict about #include <> and #include "".
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Change-Id: I8973d7b2717d892407ad93785f92a64b05bdb6b5
Reviewed-on: http://codereview.qt-project.org/6134
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Jonas Rabbe [Tue, 11 Oct 2011 05:25:36 +0000 (15:25 +1000)]
Moved general gstreamer helper classes into separate library.
Cleaned up configuration of gstreamer with a separate config
test.
Change-Id: I1ec9ee466233687fbcfdc544a12d9fce578e4379
Reviewed-on: http://codereview.qt-project.org/6459
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Jonas Rabbe [Tue, 11 Oct 2011 21:41:09 +0000 (07:41 +1000)]
Fixed a couple of failing auto tests.
QDeclarativeAudio test is using a fake backend initialised
to a specific volume. The test was testing against a
different volume.
QMediaPlayerWidgets was trying to include QApplication,
but from the wrong place and was not including QtWidgets
module.
Change-Id: I5ca108a040a4f4bd0d7550268f3a4ef5d790e755
Reviewed-on: http://codereview.qt-project.org/6458
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Jonas Rabbe [Tue, 11 Oct 2011 05:59:56 +0000 (15:59 +1000)]
Tests should not be unconditionally excluded.
Change-Id: I3910a03e5c2231f91b84b368339948fbca750f28
Reviewed-on: http://codereview.qt-project.org/6399
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Tue, 11 Oct 2011 06:41:05 +0000 (16:41 +1000)]
Add QNAM tests to wavedecoder as well, to simulate slow sources.
Change-Id: Ic65659bfdf72aea2cea5ae97de50a1e661db189b
Reviewed-on: http://codereview.qt-project.org/6404
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Michael Goddard [Tue, 11 Oct 2011 06:38:34 +0000 (16:38 +1000)]
Rename the parsing error signal to parsingError.
Refactor the error handling code a little.
Change-Id: I717b3aaacb24660b3f26769f19ac718b73106473
Reviewed-on: http://codereview.qt-project.org/6401
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Michael Goddard [Tue, 11 Oct 2011 03:50:50 +0000 (13:50 +1000)]
Fix the wavedecoder a little.
Handle RIFX and corrupted files better. Update the autotest so that it
is run properly (and copies files properly in shadow build). Fix the
gendata script to properly create testdata.
Change-Id: I47b705507bebaef54df2835ec767c6b220c64678
Reviewed-on: http://codereview.qt-project.org/6380
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Rohan McGovern [Tue, 11 Oct 2011 03:59:32 +0000 (13:59 +1000)]
tests: eliminated usage of qttest_p4.prf
Change-Id: I45f6c818c9dbdcf37c9f5f382b42da9c69618311
Reviewed-on: http://codereview.qt-project.org/6382
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
hawcroft [Mon, 10 Oct 2011 04:31:09 +0000 (14:31 +1000)]
only corrupt 'data' descriptor nothing else
Change-Id: I5640d13e8c893152e449d348f8bf6c45b899b44d
Reviewed-on: http://codereview.qt-project.org/6283
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Rohan McGovern [Mon, 10 Oct 2011 04:59:27 +0000 (14:59 +1000)]
tests: eliminated usage of qttest_p4.prf
qttest_p4.prf was added as a convenience for Qt's own autotests in Qt4.
It enables various crufty undocumented magic, of dubious value.
Stop using it, and explicitly enable the things from it which we want.
Change-Id: I3f49fd3b79899eff1d6ad9458143f34419026276
Reviewed-on: http://codereview.qt-project.org/6286
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
hawcroft [Mon, 10 Oct 2011 03:36:02 +0000 (13:36 +1000)]
Auto test for private class QWaveDecoder
Change-Id: I50ffbc3187ae7d7a7623af3ef7d3fed2975bdbbe
Reviewed-on: http://codereview.qt-project.org/6270
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Sanity-Review: Michael Goddard <michael.goddard@nokia.com>
hawcroft [Mon, 10 Oct 2011 03:55:02 +0000 (13:55 +1000)]
bail out in case of missing descriptors
Change-Id: I7c231367a4b5ef2d15fd1a7af2c2a6c1d51c9460
Reviewed-on: http://codereview.qt-project.org/6279
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Fri, 7 Oct 2011 02:03:35 +0000 (12:03 +1000)]
Improve video test coverage and debugging output.
Added a few debug operators for some useful enums, and
added tests for them. One or two other features not really
tested.
Change-Id: Idffec6ade1d4e05dbf72f3dc47dfc0d01ddddf8b
Reviewed-on: http://codereview.qt-project.org/6201
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Thu, 6 Oct 2011 04:31:58 +0000 (14:31 +1000)]
Rename QtMultimediaKit to QtMultimedia.
There are a few legacy bits left in place so it passes CI, and
then qt5.git etc can be updated.
Change-Id: I6b082e50e6958c72fdabc2974992e16d90dafa3a
Reviewed-on: http://codereview.qt-project.org/5368
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Ling Hu [Fri, 9 Sep 2011 01:23:37 +0000 (11:23 +1000)]
Add a new servicename for background mediaplayer
Change-Id: I40b3670462f0b865a9e64bd2abd6d6a01db01e80
Reviewed-on: http://codereview.qt-project.org/4492
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Ling Hu [Fri, 9 Sep 2011 01:25:53 +0000 (11:25 +1000)]
Update background audio element to use new service name
Change-Id: I8f0480e4fb40b034f75dcd900f2d440fd0e7610d
Reviewed-on: http://codereview.qt-project.org/4493
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
hawcroft [Wed, 28 Sep 2011 03:04:18 +0000 (13:04 +1000)]
Update audiooutput example with volume slider
Update example for new volume API
Change-Id: I1b9ccbccc62930549e667f0063b3d76feb23a2ea
Reviewed-on: http://codereview.qt-project.org/5662
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
hawcroft [Wed, 28 Sep 2011 03:20:26 +0000 (13:20 +1000)]
Add QAudioOutput volume API and pulseaudio backend implementation.
Change-Id: I70784e8d17522a23f6467713d58384b30557694b
Reviewed-on: http://codereview.qt-project.org/5663
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Jonas Rabbe [Tue, 27 Sep 2011 02:25:49 +0000 (12:25 +1000)]
Fakeradio: emit signal when scanning aborted
Patch from Sami Nurmenniemi.
Emits searchingChanged(false)
when scanning is aborted because it was initiated too close to
the limits of the frequency range.
Change-Id: I15a1334c8a7058dd8eb413c2742f8f12aed7bed5
Reviewed-on: http://codereview.qt-project.org/5570
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Dmytro Poplavskiy [Mon, 29 Aug 2011 06:09:04 +0000 (16:09 +1000)]
Gst player backend: don't show the first frame when resuming playback.
It's necessary to temporarily disable show-preroll-frame of video sink,
load pipeline to paused state, seek to requested position,
and after seeking is finished (position updated) playback is started
with show-preroll-frame restored.
Task-number: MOBILITY-3030
Reviewed-by: Jonas Rabbe
Change-Id: Ide1e6d909dd53f670229c293bc6be496a54e8626
(cherry picked from commit
625cce87e28fc7b5ec8785824affb3129fd3607b)
Reviewed-on: http://codereview.qt-project.org/5500
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
hawcroft [Mon, 26 Sep 2011 04:39:29 +0000 (14:39 +1000)]
Needs widgets module to build.
Change-Id: I95ba0c64843bfcdfc9797c4d818ac17606e4a1d3
Reviewed-on: http://codereview.qt-project.org/5563
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: derick hawcroft <derick.hawcroft@nokia.com>
Michael Goddard [Mon, 26 Sep 2011 07:07:49 +0000 (17:07 +1000)]
Fix a few QT_BEGIN/END_HEADER pairs.
Change-Id: Ie723af34680222b939aeb0179df21d63cec3cf3b
Reviewed-on: http://codereview.qt-project.org/5514
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Mon, 26 Sep 2011 06:49:20 +0000 (16:49 +1000)]
Remove QApplication usage - it's in QCoreApplication.
Change-Id: I0c1fab0c0eea56f1ecb141d6238acdf2778c82d8
Reviewed-on: http://codereview.qt-project.org/5513
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Sergey Dubitskiy <sergey.dubitskiy@nokia.com>
Michael Goddard [Wed, 31 Aug 2011 07:37:58 +0000 (17:37 +1000)]
Move the backend specific documentation into a nicer place.
We really don't need to bore the 99.9% of people who won't care. And
it's certainly not more important than camera.
Reviewed-by: Derick Hawcroft
(cherry picked from commit
51e3a1bc45ffc2688fcd3949216aedda4c41bf81)
Change-Id: I8add47e42c2c06bf5e16f406604a19531af6901e
Reviewed-on: http://codereview.qt-project.org/5501
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Mon, 15 Aug 2011 01:17:23 +0000 (11:17 +1000)]
Fix a playback bug for mediaplayer windows media foundation backend
Task-number:QTMOBILITY-1606
Reviewed-by:Jonas Rabbe
(cherry picked from commit
d5426bf52e19c9c6a52837b423f48024979ea076)
Change-Id: Ie7c1c90a8f5a64e77c435ffc1917d8f9638dfff3
Reviewed-on: http://codereview.qt-project.org/5499
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Gareth Stockwell [Mon, 1 Aug 2011 10:17:29 +0000 (11:17 +0100)]
Fixed directshow config test
In some versions of Microsoft Windows SDK v6.0A, the qedit.h header is
present, but dxtrans.h (which is #included by qedit.h) is missing.
The standard workaround for this issue is already used by
plugins/multimedia/directshow/camera/dscamerasession.h; this commit adds
the same workaround to the config test.
Reviewed-by: Michael Goddard
Reviewed-by: Ling Hu
(cherry picked from commit
e3c07dc9dd6a9f7930ca3c61cfd667d816731ce1)
Change-Id: Ia53c4f6b3efc86e2447a39e6d95e7f67d7e46b5d
Reviewed-on: http://codereview.qt-project.org/5498
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Gareth Stockwell [Wed, 27 Jul 2011 12:44:37 +0000 (13:44 +0100)]
Fixed a typo in the WMF backend which caused a compilation failure
Reviewed-by: trustme
(cherry picked from commit
7eab979c41513321518d5e3cea6d142bbf4e58d9)
Change-Id: I9cd5de907867ea6561c568d10c88e3bf5a701509
Reviewed-on: http://codereview.qt-project.org/5496
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Wed, 27 Jul 2011 07:41:25 +0000 (17:41 +1000)]
fix a spelling error
Change-Id: Ic593f342055a4ff65503bd92236ff2904012d4f4
Reviewed-by:Michael Goddard
(cherry picked from commit
d9cd5386f6d9aa1c702424d272d70a0b45a6b9db)
Reviewed-on: http://codereview.qt-project.org/5495
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Wed, 27 Jul 2011 00:26:59 +0000 (10:26 +1000)]
Fix config.tests for directshow backend.
directshow camera backend requires header qedit.h(currently removed since Windows SDK v7.0),
so if there is only Windows SDK v7.0, directshow backend should be disabled, since the directshow
mediaplayer will also be replaced by wmf backend.
Change-Id: I0de60fdcb683a57cc0aa3570f769179afc0c581b
Reviewed-by:Michael Goddard
(cherry picked from commit
68d78008f9d1eb82de673b8f4c8e73bdde2150c2)
Reviewed-on: http://codereview.qt-project.org/5494
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Ling Hu [Wed, 27 Jul 2011 00:22:19 +0000 (10:22 +1000)]
Fix the config.tests for WMF backend.
Windows SDK v7.0 is required to compile the WMF backend,
so add additional check for MENonFatalError.
Change-Id: I3edb86b8132b8022b30c02ea6289f617aadfc683
Reviewed-by: Michael Goddard
(cherry picked from commit
b738126352e5d914ea366b2725b72e2306b39ee2)
Reviewed-on: http://codereview.qt-project.org/5493
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Mon, 26 Sep 2011 04:17:32 +0000 (14:17 +1000)]
Merge branch 'camera' of ssh://codereview.qt-project.org:29418/qt/qtmultimediakit
Conflicts:
src/imports/multimedia/multimedia.cpp
src/imports/multimedia/multimedia.pro
Change-Id: I9d4bc1aa65f89ac24dd12c1e2c21a02f49913e13
Michael Goddard [Fri, 23 Sep 2011 07:49:49 +0000 (17:49 +1000)]
Move resource policy usage to a config test.
MeeGo uses this too.
Change-Id: I0b7ec00538289d4a3beea62da08233c0d1eb45a2
Reviewed-on: http://codereview.qt-project.org/5447
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Michael Goddard [Thu, 22 Sep 2011 05:03:51 +0000 (15:03 +1000)]
Clean some doc warnings.
Change-Id: I9cadc589a02bbc4804d2d21ab30752af375ef89c
Reviewed-on: http://codereview.qt-project.org/5348
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Ling Hu <ling.hu@nokia.com>
Michael Goddard [Thu, 22 Sep 2011 04:27:31 +0000 (14:27 +1000)]
Add QT_BEGIN/END_HEADER things, plus QT_MODULE thing.
Change-Id: I1a5f51a659175cadadcdaf0c4e5e9048f98e64e0
Reviewed-on: http://codereview.qt-project.org/5346
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Gunnar Sletta [Wed, 21 Sep 2011 07:11:43 +0000 (09:11 +0200)]
Fix widget dependencies for multimediawidget tests and examples.
Change-Id: I9c7600ce2cf7980f923ba038ef122b49add24c37
Reviewed-on: http://codereview.qt-project.org/5286
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
Michael Goddard [Thu, 22 Sep 2011 02:28:40 +0000 (12:28 +1000)]
Remove older QGLContext calls in favour of new QOpenGLContext.
Change-Id: I2669f48ebac5c14f5aaf85135f3d0adbf541d877
Reviewed-on: http://codereview.qt-project.org/5339
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
Ling Hu [Thu, 8 Sep 2011 07:15:15 +0000 (17:15 +1000)]
Don't re-set default properties in MediaBase::componentComplete
This is to avoid conflicting with state restore from background playback.
Change-Id: Idc5440b55a27bb5c5109717f405591e934bbedbc
Reviewed-on: http://codereview.qt-project.org/4397
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Dmytro Poplavskiy <dmytro.poplavskiy@nokia.com>
Gunnar Sletta [Tue, 20 Sep 2011 05:28:19 +0000 (07:28 +0200)]
add QT+=widgets for tests to run
Change-Id: Idccbb5429f1f081d815b4596f0cf0f74c1160f5c
Reviewed-on: http://codereview.qt-project.org/5188
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jonas Rabbe <jonas.rabbe@nokia.com>
dakovaci [Thu, 15 Sep 2011 06:39:19 +0000 (16:39 +1000)]
Added basic radio system tests
Change-Id: I6f3ef3e3c9f1bb851c2d9f9cbad1aea1df77004f
Reviewed-on: http://codereview.qt-project.org/4945
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daron Andrew Edie