Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I7a6e172719c8bd688e642a70e26dae42731715b1

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I2280d6ce320738b91994d4603600c38d5d1ba4ee

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: If390df3efc02bff47f240c62e35d23e78c537b4c

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I31b3e7ec830aa10aa3c06ef61972a4e9c48dffc2

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I010f996f4b726f1f79e9bbe9b9f3e96131021f00

Disable BC7 mode 8 pattern generation

Due to BC7 is underspecified for mode 8 (LSB=0x00) tests
should avoid testing it. This commit avoids generation
mode 8 BC7 compressed blocks.

Affects tests:
 * dEQP-VK.*bc7*

Components: Framework, Vulkan

VK-GL-CTS issue: 3501

Change-Id: I222046f703fbead2bf5c64376defc6481989be24

Fix multiview dynamic rendering tests to enable dynamicRendering feature

The test uses own, custom VkDevice which is created without enabling
'dynamicRendering' feature -  while this feature is used by the test.

The fix is to add VkPhysicalDeviceDynamicRenderingFeatures to the
chain of create infos used for getting and requesting features, so
the feature would be alwyas enabled if supported.

(The support of the feature is checked elsewhere).

Components: Vulkan

VK-GL-CTS Issue 3537

Affects: dEQP-VK.multiview.dynamic_rendering,*

Change-Id: Ibcc9a27e01c5deeff1ef90baf97eee5148244603

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ie2d3f521cea9ab73d6646abe1d2f9c66d2c6833e

Fix checkSupport in compressed texture sampling tests

Compressed texture sampling tests didn't properly check that images
using a compressed format can be created with the extended usage
flags. This commit fixes the check.

VK-GL-CTS issue: 3225

Affected Tests:
dEQP-VK.image.sample_texture.*

Components: Vulkan
Change-Id: I1c077d29befac3d1b22c5ac2072518296f721f47

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ib6194cc5034a2dada976ef494cf4c23fe997555f

Don't adjust vertext buffer pointer in AS for indirect AS build.

Indirect build test programs offsets into the vertex buffer in the wr-asb
shader. This shader mimics vertex buffer pointer adjustment that is done in
AS build util.

Doing both adjustments (in shader and in AS) would cause out of bounds
accesses.

Authored-by: German, Leonid <leonid.german@intel.com>
Components: Vulkan

VK-GL-CTS Issue: 3540

Affects: dEQP-VK.ray_tracing_pipeline.indirect.build_structure

Change-Id: Iace6cf96d478641f412de3a3d0ec7ab001860f29

Do not require full subgroups when requiring a work group size

Most subgroup tests that require a particular work group size use the
VK_PIPELINE_SHADER_STAGE_CREATE_REQUIRE_FULL_SUBGROUPS_BIT_EXT flag when
creating the shader stage, but that in turn forces the local size in the
X dimension to have certain values as required by the following VUID:

  VUID-VkPipelineShaderStageCreateInfo-pNext-02757

There are specific tests to check full subgroups. The flag can be safely
omitted and these other tests should still work.

Affected tests:
dEQP-VK.subgroups.*compute*

Components: Vulkan
VK-GL-CTS issue: 3520

Change-Id: Ic20d07d3a875156f817066d040ddf5813aef311f

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I589df8409840b42f6c683dda57616b3ee8359128

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I3cf7433d510e0966f4f4d96971519aa849cecda0

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I8e72cdeaa8eed150a5548dd30871eccb09f31d5c

Mark gl_Position as invariant in invariance tests

Always marks gl_Position as invariant. The reason
for this is that there is no guarantee that it
will be computed in an invariant way otherwise,
which may cause test failures.

Affects:

dEQP-VK.glsl.invariance.*user_defined*

VK-GL-CTS issue: 3493

Change-Id: Ia172664b454182458dbd13146c2d1688ecf4161f

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I3195f9f15bfe716204d8908062f62528fd70f580

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I37050cfb18cd34bd869b26531623f3b881973a3b

Increase tolerance in multiple interpolation tests

These tests test that if a shader has multiple varyings with different
interpolation modes each varying is interpolated using the correct
interpolation mode.

The test runs a shader with multiple varyings with different
interpolation modes and expects this to be an exact match with an image
produced by a similar shader with a single varying of the same
interpolation mode.

Due to floating point inaccuracies and different rounding, allow a 1
bit tolerance when comparing the images.

Affects: dEQP-VK.draw.*multiple_interpolation.*

Components: vulkan

VK-GL-CTS issue: 3522

Change-Id: Ib4a8ab527644de5e1c36ecd3e627afe5384cc6f6

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I3e993e882a340347eea3582c1ba4feb3393b58fc

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I3ae2bc92916e5c4e2b525a085ba763d4c4b124d1

Ray tracing: avoid skipping triangles and AABBs at the same time

This is illegal according to the spec.

Removed tests:
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*pipelineskipboth*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskiptriangles.pipelineskipaabbs*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskipaabbs.pipelineskiptriangles*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskipboth*

Components: Vulkan
VK-GL-CTS issue: 3508

Change-Id: Iebc50b4b546abc36b2607eeb7c5cbb900de35fcb

Update mandatory features for Vulkan1.3

Vulkan 1.3 only requires
descriptorBindingInlineUniformBlockUpdateAfterBind to be supported if
descriptor indexing is supported.

Vulkan 1.3 also made a number of Vulkan 1.2 features mandatory, so add
these to the mandatory feature check for 1.3 implementations.

Affects:
dEQP-VK.api.info.vulkan1p3.feature_extensions_consistency
dEQP-VK.info.device_mandatory_features

Compontents: vulkan

VK-GL-CTS issue: 3496

Change-Id: I79a6df710b7770171b7a1128cdec30fa30d6a456

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I67ca22b6f7d5e71d139482417f8ac5f30f6a1f81

Always use workaround for blitting to/from BC6H

Qualcomm's implementation of cubic filtering can give large inaccuracies
when texel values within the 4x4 grid are very big and very small,
especially if the values around the "edge" are much bigger then the
values at the center. This can happen with randomly-generated blocks for
floating-point compressed formats like BC6H. There was already a
workaround for similar issues seen blitting to e5b9g9r9, extend it to
all formats to fix this.

Components: Vulkan

VK-GL-CTS Issue: 3450

Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.bc6h_ufloat_block.*
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.*.bc6h_ufloat_block.*

Change-Id: I3445ecba2ebc9e4e52e26111a109eaf79f611bd8

Fix build error on gcc 4.8

Changes a copy initializtion to a direct initialization.

GCC 4.8 complains about the copy initialization of
 const tcu::StringTemplate meshTemplate = meshTemplateStr.str();
but not the direct initialization of
 const tcu::StringTemplate taskDataDecl(taskDataDeclTemplate);

Replacing the copy initialization with the direct initialization fixes
the build issue.

Components: Vulkan
Affects: dEQP-VK.mesh_shader.nv.*

VK-GL-CTS issue: 3511

Change-Id: I9de57bc28e56da8288894e32c938fea0cd165927

Fix load_store_op_none dynamic rendering validation error

The test case below was using a multisample color attachment with
integer format and specified VK_RESOLVE_MODE_AVERAGE_BIT as the resolve
mode, which is illegal. The purpose of the test is different, and the
resolve mode is not relevant, so it can be switched to one of the legal
values.

Affected tests:
dEQP-VK.dynamic_rendering.suballocation.load_store_op_none.color_load_op_none_store_op_none_resolve

Components: Vulkan
VK-GL-CTS issue: 3509

Change-Id: I42cf959f67d80694aee37c19c966ab037609d44f

Fix dynamic rendering multisampling test layout transition operation

Those tests are failing on Intel/Mesa because they're not
transitioning the right mip level from COLOR_ATTACHMENT to TRANFER_DST
layouts.

Component: Vulkan

Affects: dEQP-VK.dynamic_rendering.*.multisample_resolve.*resolve_level*

VK-GL-CTS issue: 3482

Change-Id: I6dcdf6a9a72d96c559acd28f0114b308267d3cb8

Use the correct stencilInitialLayout for unused resolve targets with separate stencil

The initial stencil layout was always being specified as UNDEFINED even
though, in the unused resolve target case, we clear it with
vkCmdClearDepthStencilImage() and need an initial layout of
TRANSFER_SRC_OPTIMAL.

Components: Vulkan
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*

Change-Id: Id0e0dcd2066d02758875a786c5634b23c893f7a2

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: If3af09eda7b56dbfa484de49f06401ff53fda906

Avoid invalid reportIntersectionEXT hit kinds in subroup tests

Some subgroup ray tracing tests were using invalid values when calling the
reportIntersectionEXT function.

Affected tests:
dEQP-VK.subgroups.*ray_tracing*

Components: Vulkan
VK-GL-CTS issue: 3513

Change-Id: I96310c32e1e5b4fde157570f0a3131d61f5a125c

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Iba2783e1e1e2bcb839c075dcf4d2b1dbcfbdf43f

Replace bitwise or with logical

This fixes a Clang 14 bitwise-instead-of-logical warning.

Affects:
dEQP-VK.robustness.robustness2.*
dEQP-VK.robustness.image_robustness.*

Components: Vulkan

VK-GL-CTS issue: 3492

Change-Id: I803ed494ed218b404a2285ed891d41170d66abfe

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I4adbb2e30086c26c8ad3312a6086e267c2840d42

Avoid invalid reportIntersectionEXT hit kinds in mem guarantee tests

Only values in the [0, 127] range are allowed with reportIntersectionEXT.

Affected tests:
dEQP-VK.ray_tracing_pipeline.memguarantee.*

Components: Vulkan
VK-GL-CTS issue: 3513

Change-Id: I54669b5b7e2c0f696bbbf3e5a477b1533e4f4488

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Ib8646342ae0c6c9df3c7f2fa78c24643c10d5e96

Fix validation errors in compute tests

This CL fixes various validation errors in compute tests.

Affects:
dEQP-VK.compute.basic.image_barrier*
dEQP-VK.compute.cooperative_matrix.*

Components: Vulkan

VK-GL-CTS Issue: 3451

Change-Id: I33037a50d10a5cf8098c33b55ba42900f97f0019

Update SPIRV-Tools version

Pulls in fix for nontemporal operand

Components: Framework

Change-Id: I248f7c12094d318682cc80e82db2a876f2aa4634
(cherry picked from commit a8fc4961d753dc2bddb1f78bdb91a21960a1ed57)

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I0d1eb20fc6b29d9e4c05f1dd9c4f729e8a0453ce

Delay initializing fragment_shading_rate tests

When the shading rate tests were renamed, they turned a delayed call
to createChildren into an immediate call. For partial test-suite runs,
this can significantly impact run times.

Components: Vulkan

VK-GL_CTS Issue: 3460

Affects:
dEQP-VK.fragment_shading_rate.*

Change-Id: Ie2bb7a7690b2650006da888433397dae9a5ff7cf

Fix rounding issues with texture generation shader

VK-GL-CTS Issue: 3250

Affects:

dEQP-VK.graphicsfuzz.cov-global-loop-counter-texture-sample-loop-condition-set-array-element
dEQP-VK.graphicsfuzz.cov-multiple-fragcoord-conditions-false-never-return-sample-texture
dEQP-VK.graphicsfuzz.cov-nested-loops-sample-opposite-corners

Components: Vulkan
Change-Id: Ifba30c4dbf17f51c790ce66819da3785049bec6b

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I064e8e9c25536c26df4b575da647443cc753e542

Re-enable GCC warning for Amber

The Amber version used by vulkan-cts-1.2.7 and later includes aa69a0
which should fix all uninitialized variable warnings.

Components: Framework, Vulkan

VK-GL-CTS issue: 3361

Change-Id: I95bab777232216dad1c1c02bd57f21c8bd2a1528

Fix rounding issues with texture generation shader

VK-GL-CTS Issue: 3250

Affects:

dEQP-VK.graphicsfuzz.cov-min-nested-loop-same-value-for-variables
dEQP-VK.graphicsfuzz.cov-sample-texture-hundred-iterations
dEQP-VK.graphicsfuzz.cov-sampler-as-function-argument
dEQP-VK.graphicsfuzz.cov-texel-double-negation
dEQP-VK.graphicsfuzz.cov-variable-copy-in-function-tex-sample
dEQP-VK.graphicsfuzz.spv-stable-sampler-loop-extra-instructions
dEQP-VK.graphicsfuzz.spv-stable-sampler-polar-simple-O-access-chain

Components: Vulkan
Change-Id: I1758bd50da844b2835c858ee5d78af4e7c4bd69a

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Ib1155d0946f8c94eed1395127c6441c6a1a54174

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I96cce7d1a37d9ab836f098aecf1f5895a9e0185d

Fix Set/WaitEvent2KHR dependency flags setup

Vulkan specifies that the dependencyFlags member of pDependencyInfo
must be 0 in case of vkCmdSetEvent2KHR and vkCmdWaitEvents2KHR.
The conformance tests use a non zero default flag.

Components: Vulkan

Affects:

dEQP-VK.synchronization2.basic.event.*
dEQP-VK.synchronization2.op.single_queue.event.*

VK-GL-CTS Issue: 3462

Change-Id: Ic67fb77bcddf198fc77bbc9b3a25979d3e43678b

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Ic3ea84ef67493d7b596c4f4a9547b7841170a9a9

Fix compilation on Android

Function testSemaphoreImportSyncFdSignaled is not used and the build process
for Android fails because of it.
Fix just removes this unused function.

Components: Vulkan, AOSP

Affects:

None

VK-GL-CTS Issue: 3465

Change-Id: I82ad0e8df8196ac08d0003f30b7e624461239f84

Fix mandatory features checks for vk1.3

This change fixes:
* feature_extensions_consistency test that required some of
  extensions that were promoted to vk1.3 to be present
  which is not mandatory.
* device_mandatory_features test that didn't check for
  vk1.3 mandatory features

Components: Vulkan

Affects:
dEQP-VK.api.info.vulkan1p3.feature_extensions_consistency
dEQP-VK.info.device_mandatory_features

Change-Id: Ife0251617e773d028647148f5538b837dcf13221

Update fetch_sources to vulkan 1.3

Points to public github

Components: Framework

Change-Id: I8638dbca5a38823e836922794d3ec47c3892368c

Use signed sampled type for signed integer formats

Nontemporal image write tests incorrectly use an unsigned sampled type
for signed integer formats.

Affects:
dEQP-VK.image.nontemporal_operand.*sint

Components: Vulkan
VK-GL-CTS issue: 3469

Change-Id: Ib77faf8cff8d2aec31f5f9c7f97d5b5172fa7dcc

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I95aaeb725066ddc8fd04918ebaa05e65de16af44

Fix issues in load_store_op_none tests

This commit fixes several issues from the load_store_op_none tests:

- Checking depth/stencil image format support in a checkSupport() method
  instead of at iteration time.
- Validation error regarding mismatched attachment counts in dynamic
  rendering variants.
- Validation error regarding image layout in dynamic rendering variants.
- Wrong barriers after clearing color and depth/stencil images.
- Make the code not assume depth/stencil formats have both aspects,
  paving the way to testing more formats in the near future.

Affected tests:
dEQP-VK.*.load_store_op_none.*

Components: Vulkan
VK-GL-CTS issue: 3413

Change-Id: Iec237547f5762f299f1225eb4dda010e4256b367

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Idb8b94c0b0e0052ff4bafffcdf473b1e9aa468e1

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I078d372dbbcb1886aa13f37995bfcf50cd97413a

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I60ad45aaeeb84782bde80829cb1e731fb8e76b01

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Iff22de3540519a435bbb7874188bbcadec977b05

Fix bug in calcFloatDiff

bsign variable in function calcFloatDiff is wrongly declared. Fixing.

VK-GL-CTS issue: 3472

Affects:
dEQP-VK.api.image_clearing.core.clear_depth_stencil_image*
and all the tests from the vktApiImageClearingTests.cpp file.

Components: Vulkan
Signed-off-by: Nishit Shah <nishit.shah@samsung.com>
Change-Id: I654920c9de460eb04caaca988552f65da3aa2687

Additions to VARYING_SUBGROUP_SIZE and FULL_SUBGROUPS_BIT tests

The behavior in VK_EXT_subgroup_size_control is assumed by default when
using SPIR-V 1.6. This CL adds variants of the existing tests for
subgroup_size_control where instead of adding these flags, a SPIR-V 1.6
module is used.

VK-GL-CTS issue: 3072

New Tests:
dEQP-VK.subgroups.size_control.*_spirv16

Components: Vulkan
Change-Id: I374f56e4ff8f6d971785a53e50667214cc536689

Update vulkan-docs to main

Components: Framework, Vulkan
Affects:
dEQP-VK.*

Change-Id: I930c36d5c7bc50cb62f130cac58731c294b6f687

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I6be2d3495b8e5badf3441ba4a40b4b1f8163f2de

Relax precision for matrix precision tests

The Vulkan spec does not specify the precision for inverse and
determinant built in functions, however newly added tests effecitively
adds a precision requirement for them.

The precision required in these tests is too high for some valid
implementations of these builtin functions.

Relax the precision required in the tests to allow valid
implementations to pass.

Affects:
dEQP-VK.glsl.builtin.precision*.determinant.*
dEQP-VK.glsl.builtin.precision*.inverse.*

Compontents: vulkan

VK-GL-CTS issue: 3182

Change-Id: Ib4c5b9d04578732456b8f981bc82a2c86ad877fa

Skip the "two_draw" variants of zero_stride_with_offset tests

There's only one vertex in vertex array for singleVertex config.
Non-zero stride can cause out of bound memory access error since
vkd.cmdDraw draws 6(singleVertexDrawCount) vertices in singleVertex
config.

Affects:
dEQP-VK.pipeline.extended_dynamic_state.*.zero_stride_with_offset

Components: Vulkan

VK-GL-CTS issue: 3463

Change-Id: I77baa395c40f74f518bc9c7e8daf32c87686868a

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I4e8734003d9e689045fd25601bc521a4fb119f0b

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Iab61e615b3f7d5b108d925150255a73171e3d438

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: If56557dcb21ca8bfd90acbb2fffbd3f8ceed16f2

Re-enable Clang warning for Amber

The Amber version used by vulkan-cts-1.2.5 and later includes 4d0115c
which should fix all suggest-destructor-override warnings.

Components: Framework, Vulkan

VK-GL-CTS issue: 3361

Change-Id: I36437c797c067521e1444d20cfece33babfe435a

GCC 11 build fixes

Some files used std::numeric_limits without including <limits> and
failed to compile.

VK-GL-CTS issue: 2842

Change-Id: I21e37ce38db08c7c7041f4628ac852588a788852

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I790e54266657e91c84b9e40f6eb7385914d569c6

Decrease required subgroup size

dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point
test assumed that the subgroupSize is >= 8. The test failed if the
supported subgroupSize is less than 8.

This CL lowers the required subgroup size to 4.

Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point

Components: Vulkan

VK-GL-CTS issue: 2698

Change-Id: I9931dab7a57c0b6b73530e72bca0c0d9cc90f87d
(cherry picked from commit 8f9b9137470ed5b0cd0b38edd9e9c28ccf565731)

Fix for potentially uninitialized variables

This change adds a constructor for a struct which sets the members that
do not have a constructor of their own to known values.

This potentially affects anything that uses the reference rasterizer,
but should not change any test results.

Affects:
*

Components: Framework
VK-GL-CTS issue: 3434

Change-Id: Ie874b4baa4d2ff5a8aa66f9ea2c3cd11b37edb64

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I3080cbdc60602f0faea714502bbc5461cac257e0

Fix NULL/False to std::string conversion errors

Newer versions of GCC reject std::string(DE_NULL). Previously this
didn't cause any errors or warnings when compiling, but should produce
an error at runtime. This change replaces invalid values with empty
string literals and adds deFatalStr for cases that potentially
relied on the string constructor throwing an exception.

Components: Framework, OpenGL, Vulkan
VK-GL-CTS issue: 3419

Change-Id: I68ec7d1447d1e96f5d7841e0684687cdd294fe39

Require geometry shaders for adjacency topologies

Clipping tests would use adjacency topologies with drivers that didn't
support geometry shaders.

Components: Vulkan

Affects: dEQP-VK.clipping.clip_volume.depth_clip.*
VK-GL-CTS Issue: 2906

Change-Id: I7a41e62dcbcdcab46ce4f8b04bfe322c688fbcac

Remove repeated struct in writeDeviceFeatures2

Remove VkPhysicalDeviceShaderIntegerDotProductFeaturesKHR from list of
feature structs in writeDeviceFeatures2, as it is an alias for
VkPhysicalDeviceShaderIntegerDotProductFeatures which is also in the
list.

Affects:
dEQP-VK.api.info.get_physical_device_properties2.features

Components: Vulkan
VK-GL-CTS issue: 3437

Change-Id: Ibb0b6b655887c1452f55c730245941afb7dc108b

Update vulkan-docs version

Recent changes to vulkan video include generating video extension
'Std' header files from video.xml and addition of *_INVALID enum
values that have same value as *_MAX_ENUM values.
This change updates vulkan-docs to version 1.2.203 and updates
gen_framework.py script to properly handle changes in vulkan video.

Affects: *

Components: Framework, Vulkan

VK-GL-CTS issue: 3431

Change-Id: Ibdb4bc8ace9572da920fa02649fcab7bc563841d

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ie7b28e84ceb9de28964db02e7744a01ea52b7c50

Remove redundant load/store op none tests

Load/store op none tests had originally a hard coded
depth stencil format, but was later changed to iterate
on multiple formats. The depth tests were accidentally
left there (as a duplicate) outside a format loop, and
the depth format parameter was uninitialized in these
tests.

This change removes these old tests and also fixes
the dynamic rendering tests to use correct depth
stencil formats.

VK-GL-CTS Issue: 3426

Affects:

dEQP-VK.*.suballocation.load_store_op_none.*

Components: Vulkan
Change-Id: I5c1e0a6d95bb1dbc88364f6e99f84e47619c285d

Fix vktFragmentShadingRateBasic tests

Many graphics pipelines are used in dynamic render pass which uses
fragment shading attachment, but these pipelines don't have
VK_PIPELINE_CREATE_RENDERING_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR
flags when they are created. Adding those flags.

Affects: dEQP-VK.fragment_shading_rate.dynamic_rendering.*

Components: Vulkan

VK-GL-CTS issue: 3440

Change-Id: I3dd0aae9d6e9f2fc0bb5266f4f4ba442ebc0317b

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ic1cf8fed8e0713c216ff31212334cb53acbbf72d

Fix getting capture address in RT capture replay tests

Use vkGetBufferOpaqueCaptureAddress to retreive address
used in opaqueCaptureAddress

Components: Vulkan

VK-GL-CTS Issue: 3420

Affects: dEQP-VK.ray_tracing_pipeline.capture_replay.shader_binding_tables
Change-Id: Ifaa2fe92d6517fa75a29ad21c06365efd7857de4

Remove time measurement on deferred host build tests

The time measurement is wrongly implemented in this test
- it measures also thread creation, allocations and VK setup time, additionally
to AS build.  It is not easily fixable.

Moreover, the spec says that offloading the work to background threads
is 'desirable', however it never says it is faster.

VK-GL-CTS Issue: 3435

Components: vulkan

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*
dEQP-VK.ray_query.acceleration_structures.*

Change-Id: I41d836e2e454b9fb9bb46109edddd4eda19370e9

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I1d7510b4e0626392ff35aa1f38c1bd193b8ce319

Remove api.tooling_info.validate_instance_layers

Remove:
dEQP-VK.api.tooling_info.validate_instance_layers

Components: Vulkan
VK-GL-CTS issue: 3395

This reverts commit 7628909f404f665eb54c6a5019386747fb631134.

Change-Id: I68de938e73c10fed80d4e9bb3698b513a1b44315

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: Ic336acbf09ed630cc1b20ea82796f20369b1a5dc

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I7ec0667baf95d997230a8befced3ca4f2cda4876

Fix sType Tooling Info tests

Tooling Info tests were not setting the sType correctly. This goes
against spec
where "sType must be
VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TOOL_PROPERTIES_EXT". These
tests also check this sType to validate functionality.

Components: Vulkan

Affects:
dEQP-VK.api.tooling_info.*

VK-GL-CTS issue: 3444

Change-Id: Ic72104261a577d7d767742d4b2828296eba3922c

DeqpTestRunner: fix deqpLogFilename

Fix capitalization of shell argument "deqpLogFilename" in
DeqpTestRunner.java. The code still worked fine in most cases because
the default filename matches the filename passed in DeqpTestRunner.java.

Components: Android
Google bug: b/206657494

Change-Id: I857fa3994ada72aa96d199569704a46034255309
(cherry picked from commit 42017ff7072dcc7e7a7d51dd5611be05abf5460f)

Add format check to SharedPresentableImageTest

The SharedPresentableImageTest does not follow Vulkan spec.
The SurfaceFormats got by getPhysicalDeviceSurfaceFormats ->
getPhysicalDeviceSurfaceFormatsKHR should be checked by
vkGetPhysicalDeviceImageFormatProperties. This is according to:
www.khronos.org/registry/vulkan/specs/1.2-extensions/html/chap33.html
"33.5. Surface Queries
In addition to the surface capabilities as obtained by surface queries
below, swapchain images are also subject to ordinary image creation
limits as reported by vkGetPhysicalDeviceImageFormatProperties. As an
application is instructed by the appropriate Valid Usage sections, both
the surface capabilities and the image creation limits have to be
satisfied whenever swapchain images are created."

Unsupported format can lead to non-deterministic behavior e.g.
a segmentation fault, a null pointer dereference in a test or a driver.

VK-GL-CTS issue: 3422

Affects:
dEQP-VK.wsi.android.shared_presentable_image.*

Components: Vulkan

Change-Id: Id4bb4d1c81e090ed1d7f34a76f3cfafc464d8cf8

Fix inl files

Change-Id: I6468dff8d75e73dbd23a0a1b1b1314ea80ef954b
Components: Vulkan, Framework

Fix for issues in dynamic rendering tests

Missing barrier before begin rendering to transition image from
VK_IMAGE_LAYOUT_UNDEFINED to VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL

Components: Vulkan

VK-GL-CTS issue: 3383

Affects:
dEQP-VK.dynamic_rendering.suballocation.sparserendertarget*

Change-Id: Ied286e31282d56e8221e327e3d02a5d9333cf499

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Iba40a0634a1de5fde930a2f469b5c9bc31d8c4d9

Fix stencil layout transitions in samplemask tests

This change fixes the validation layer errors for the _samplemask cases.

affects:
dEQP-VK.renderpass2.depth_stencil_resolve.*_samplemask

Components: Vulkan
VK-GL-CTS issue: 3362

Change-Id: I0e1d9a44c3ed127fbde3765725243fae722ad938

Fix RGBA10x6 feature check

Verify that the extension is available before quering for support.

Affects:
dEQP-VK.api.info.format_properties.r10x6g10x6b10x6a10x6_unorm_4pack16

Components: Vulkan
VK-GL-CTS issue: 3370

Change-Id: Ib8cbbbe1f8c36b5022de1c04e623d49f5fb2b4c4

Rename some waived tests for dynamic rendering

These tests were renamed in commit 90835b7 "Rename dynamic_rendering
tests", but the waivers file was not updated. (The Android waiver file
was updated, so is not changed here).

Component: Vulkan
VK-GL-CTS issue: 757

Change-Id: I0beae9cd0e6b4e33e8c8f717b0eae44797104844

Fix barrier for initializing resolve attachment image to use proper level

This changes the level in the barrier to match level used by image view
used as resolve attachment in renderpass.

VK-GL-CTS Issue: 3407

Components: Vulkan

Change-Id: I500dfdbf15c4b7cd9943d3b063122107e1890688
Affects: dEQP-VK.dynamic_rendering.*.multisample_resolve.*_resolve_level_*

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ib63fd21efc3a2a3e4896a212d51e3ab1f12e56d4

Checked .inl files back into the repo

By default .inl files won't be generated at build time but
this functionality is still present and to activate it
value of DEQP_VULKAN_INL_GEN_OUTPUTS_DIR should be changed
to point to PROJECT_BINARY_DIR.

VK-GL-CTS issue: 3197

Components: Framework, Vulkan

Affects:
dEQP-VK.*

Change-Id: I6ba5932aa51740048c8dcc0c0222e8f7553ac4b3

Pass force to fetch_sources

Switching vulkan-docs folders between gitlab and github branches
results in errors on the server (clobbering the tags). Using
fetch sources with --force param resolves the issue.

Components: Vulkan

VK-GL-CTS issue: 3197

Change-Id: I913d5803836e9f7a59494e5ebf6e6261ede52948