platform/upstream/dotnet/runtime.git
8 years agoMerge pull request dotnet/coreclr#1857 from ramarag/testhygiene
Rama krishnan Raghupathy [Sat, 24 Oct 2015 01:59:28 +0000 (18:59 -0700)]
Merge pull request dotnet/coreclr#1857 from ramarag/testhygiene

Ensure each test has its own unique directory

Commit migrated from https://github.com/dotnet/coreclr/commit/71d9cfe123f81cf775012f3505a93709bcbb142e

8 years agoTest Cleanup:
Rama Krishnan Raghupathy [Fri, 23 Oct 2015 21:39:25 +0000 (14:39 -0700)]
Test Cleanup:

1. Ensures each test has its own unique directory
2. Use Project Reference to refer native CMakeLists.txt
3. Avoids copying the facades to the test  build

Commit migrated from https://github.com/dotnet/coreclr/commit/f0e0ebc0624e690dcebd0f3d31b36daf7750c295

8 years agoMerge pull request dotnet/coreclr#1818 from gkhanna79/Fix1774
Gaurav Khanna [Fri, 23 Oct 2015 22:52:07 +0000 (15:52 -0700)]
Merge pull request dotnet/coreclr#1818 from gkhanna79/Fix1774

Fix Unix CoreConsole to correctly determine the path to the entrypoint executable

Commit migrated from https://github.com/dotnet/coreclr/commit/3689ec1d8b76e7fde7b4a0d0b71b4dd95bc83768

8 years agoAddress a messaging nit.
Gaurav Khanna [Fri, 23 Oct 2015 21:13:59 +0000 (14:13 -0700)]
Address a messaging nit.

Commit migrated from https://github.com/dotnet/coreclr/commit/953381311fe66d2140ce2594e21af88baddd996e

8 years agoFix issue 1774
Gaurav Khanna [Mon, 19 Oct 2015 05:18:43 +0000 (22:18 -0700)]
Fix issue 1774

Commit migrated from https://github.com/dotnet/coreclr/commit/46a198ef387f482d76d0711944f575450e3d9675

8 years agoMerge pull request dotnet/coreclr#1858 from caslan/addcriticalsectionexports
Cagri Aslan [Fri, 23 Oct 2015 16:47:35 +0000 (09:47 -0700)]
Merge pull request dotnet/coreclr#1858 from caslan/addcriticalsectionexports

Add EnterCriticalSection / LeaveCriticalSection exports to libcoreclr

Commit migrated from https://github.com/dotnet/coreclr/commit/68764ae2b70a1d84d05d7bcfd4a9296161e6627a

8 years agoAdd EnterCriticalSection / LeaveCriticalSection exports to libcoreclr
Cagri [Fri, 23 Oct 2015 06:59:38 +0000 (23:59 -0700)]
Add EnterCriticalSection / LeaveCriticalSection exports to libcoreclr

Commit migrated from https://github.com/dotnet/coreclr/commit/898e5fe129569c93b201e85b5dd8747af7fa0d3e

8 years agoMerge pull request dotnet/coreclr#1834 from Priya91/fixnull
Lakshmi Priya [Fri, 23 Oct 2015 03:33:47 +0000 (20:33 -0700)]
Merge pull request dotnet/coreclr#1834 from Priya91/fixnull

Add null checks to StackString usages.

Commit migrated from https://github.com/dotnet/coreclr/commit/5a9cb981ec4b4c8399cb43b41af9120ea0741efa

8 years agoMerge pull request dotnet/coreclr#1854 from janvorli/fix-comment
Aditya Mandaleeka [Fri, 23 Oct 2015 02:17:17 +0000 (19:17 -0700)]
Merge pull request dotnet/coreclr#1854 from janvorli/fix-comment

Fix obsolete comment

Commit migrated from https://github.com/dotnet/coreclr/commit/0fd48fae6d323dde307f4f20e5239517e217f560

8 years agoAdd null checks to StackString usages.
Lakshmi Priya Sekar [Thu, 22 Oct 2015 03:37:06 +0000 (20:37 -0700)]
Add null checks to StackString usages.

Commit migrated from https://github.com/dotnet/coreclr/commit/f8b1a81067f49190355b487a1b040c93d6974225

8 years agoMerge pull request dotnet/coreclr#1832 from bryanar/enable_crossgen_tests
Bryan P. Arant [Fri, 23 Oct 2015 01:15:39 +0000 (18:15 -0700)]
Merge pull request dotnet/coreclr#1832 from bryanar/enable_crossgen_tests

- Changes required to enable crossgen on the tests.
- Added priority level parameter to buildtest.cmd
- Added crossgen parameter to buildtest.cmd
- Updated testing documentation to reflect prioritylevel testing, and crossgen testing.

Commit migrated from https://github.com/dotnet/coreclr/commit/76f7dfbcbe226985deb4ff25a0c9dc7ffe3ffed5

8 years agoFix obsolete comment
Jan Vorlicek [Fri, 23 Oct 2015 01:15:35 +0000 (18:15 -0700)]
Fix obsolete comment

Commit migrated from https://github.com/dotnet/coreclr/commit/48b076eea6a5cb6b6067a72c3d7dc5546e8f6dd5

8 years agoMerge pull request dotnet/coreclr#1850 from dotnet-bot/from-tfs
Matt Ellis [Fri, 23 Oct 2015 00:42:48 +0000 (17:42 -0700)]
Merge pull request dotnet/coreclr#1850 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/a7c205d15936a409b250970b3830be0f3561d2c3

8 years agoMerge pull request dotnet/coreclr#1849 from janvorli/fix-fp-registers-offset
Jan Vorlicek [Thu, 22 Oct 2015 23:52:57 +0000 (16:52 -0700)]
Merge pull request dotnet/coreclr#1849 from janvorli/fix-fp-registers-offset

Fix floatingpoint register offsets in TransitionBlock for Unix

Commit migrated from https://github.com/dotnet/coreclr/commit/2e174c421e86851d057538bc1c16790006d22ed7

8 years agoMerge pull request dotnet/coreclr#1830 from erozenfeld/RotateBits
Eugene Rozenfeld [Thu, 22 Oct 2015 22:37:41 +0000 (15:37 -0700)]
Merge pull request dotnet/coreclr#1830 from erozenfeld/RotateBits

     Generate efficient code for rotation patterns.

Commit migrated from https://github.com/dotnet/coreclr/commit/429bb1cecd6208b6334c73eae7e48442951d2c5d

8 years agoMerge pull request dotnet/coreclr#1848 from dotnet-bot/from-tfs
Matt Ellis [Thu, 22 Oct 2015 22:35:03 +0000 (15:35 -0700)]
Merge pull request dotnet/coreclr#1848 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/895284e7bedf25585944acd5e85170a39645d832

8 years agoChanges required to enable crossgen on the tests.
Bryan Arant [Thu, 22 Oct 2015 03:19:51 +0000 (20:19 -0700)]
Changes required to enable crossgen on the tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/3ff774096c0a6634911db24a8406d3ca1466a289

8 years agoadding more context
Rama Krishnan Raghupathy [Thu, 22 Oct 2015 22:07:33 +0000 (15:07 -0700)]
adding more context

[tfs-changeset: 1540889]

Commit migrated from https://github.com/dotnet/coreclr/commit/d12f402bf8a7bf16c5665f21295580e05d77c23f

8 years agoAddressing Desktop Build break due to addition of a new non windows event in Clretwal...
Rama Krishnan Raghupathy [Thu, 22 Oct 2015 21:10:15 +0000 (14:10 -0700)]
Addressing Desktop Build break due to addition of a new non windows event in Clretwall.man

[tfs-changeset: 1540865]

Commit migrated from https://github.com/dotnet/coreclr/commit/10e7d686ef553a6cceb19fc6e71ca8156531ae7f

8 years agoMerge pull request dotnet/coreclr#1816 from stephentoub/string_indexof_perf
Stephen Toub [Thu, 22 Oct 2015 20:47:51 +0000 (16:47 -0400)]
Merge pull request dotnet/coreclr#1816 from stephentoub/string_indexof_perf

Improve string.{Last}IndexOf perf on Unix for Ordinal/OrdinalIgnoreCase

Commit migrated from https://github.com/dotnet/coreclr/commit/527cda0178f5e477036e6ca02a4d4beca860cc06

8 years agoMerge pull request dotnet/coreclr#1840 from caslan/customnotificationfix
Cagri Aslan [Thu, 22 Oct 2015 20:20:23 +0000 (13:20 -0700)]
Merge pull request dotnet/coreclr#1840 from caslan/customnotificationfix

Fixed an issue with getting event size not working for custom notific…

Commit migrated from https://github.com/dotnet/coreclr/commit/c2f0c1f843257959066e710ecbf677860f75a289

8 years agoUpdate IndexOfOrdinalIgnoreCase to use full code units
stephentoub [Wed, 21 Oct 2015 02:32:14 +0000 (22:32 -0400)]
Update IndexOfOrdinalIgnoreCase to use full code units

Commit migrated from https://github.com/dotnet/coreclr/commit/91f0f8bb71ee74855bcd2e2bff0f088c3346cde7

8 years agoImprove string.{Last}IndexOf perf on Unix for Ordinal/OrdinalIgnoreCase
stephentoub [Tue, 20 Oct 2015 19:34:38 +0000 (15:34 -0400)]
Improve string.{Last}IndexOf perf on Unix for Ordinal/OrdinalIgnoreCase

Our current implementation of IndexOfOrdinal for strings on Unix uses Substring to get the piece of the source string we care about; this results in an unnecessary allocation / string copy.  When using OrdinalIgnoreCase, we also convert both the source and search strings to upper-case using ToUpperInvariant, resulting in more allocations.  And our LastIndexOfOrdinal implementation delegates to IndexOfOrdinal repeatedly, incurring such allocations potentially multiple times.

This change reimplements Ordinal searching in managed code to not use Substring, and it implements OrdinalIgnoreCase searching via new functions exposed in the native globalization shim, so as to use ICU without having to make managed/native transitions for each character.

With the changes, {Last}IndexOf with Ordinal/OrdinalIgnoreCase are now allocateion-free (as you'd expect), and throughput when startIndex/count and/or OrdinalIgnoreCase are used is increased significantly, on my machine anywhere from 20% to 3x, depending on the inputs.

Commit migrated from https://github.com/dotnet/coreclr/commit/80800eb0ead17dc724275d426904755b3bc64139

8 years agoMerge pull request dotnet/coreclr#1833 from kouvel/Inline2
Koundinya Veluri [Thu, 22 Oct 2015 18:03:04 +0000 (11:03 -0700)]
Merge pull request dotnet/coreclr#1833 from kouvel/Inline2

Move some functions to allow them to be inlined with clang

Commit migrated from https://github.com/dotnet/coreclr/commit/3ddea17fc4e5b0c9ff2cb0651be82594a0eddffb

8 years agoFix floatingpoint register offsets in TransitionBlock for Unix
Jan Vorlicek [Thu, 22 Oct 2015 17:55:02 +0000 (10:55 -0700)]
Fix floatingpoint register offsets in TransitionBlock for Unix

The conversion between floating point register index and offset was incorrectly
multiplying the the index by 8 instead of 16. The xmm registers in the
TransitionBlock on Unix take 16 bytes each, not 8.

Commit migrated from https://github.com/dotnet/coreclr/commit/c13593b553ca78c6a94a2523e8f8549031077b60

8 years agoMerge pull request dotnet/coreclr#1839 from mmitche/fix-linux-coreclr-tests
Matt Mitchell [Thu, 22 Oct 2015 15:45:48 +0000 (08:45 -0700)]
Merge pull request dotnet/coreclr#1839 from mmitche/fix-linux-coreclr-tests

A couple tweaks to coreclr linux tests

Commit migrated from https://github.com/dotnet/coreclr/commit/545a76e35e4429ed33e9dfcbec3e61ea346afb80

8 years agoA couple tweaks to coreclr linux tests
Matt Mitchell [Thu, 22 Oct 2015 15:40:34 +0000 (08:40 -0700)]
A couple tweaks to coreclr linux tests

Commit migrated from https://github.com/dotnet/coreclr/commit/d8f475e6eead62bf9425a99e070df654152dc08d

8 years agoFixed an issue with getting event size not working for custom notification event
Cagri Aslan [Sat, 17 Oct 2015 00:43:39 +0000 (17:43 -0700)]
Fixed an issue with getting event size not working for custom notification event

Commit migrated from https://github.com/dotnet/coreclr/commit/136d6c24026f003a894ec1ea207d6fdcb3329949

8 years agoMerge pull request dotnet/coreclr#1820 from richlander/rich-cleanup
Matt Ellis [Thu, 22 Oct 2015 05:43:32 +0000 (22:43 -0700)]
Merge pull request dotnet/coreclr#1820 from richlander/rich-cleanup

Update license attribution

Commit migrated from https://github.com/dotnet/coreclr/commit/735337e25623144913d368f2ae7421c9033895b6

8 years agoMove some functions to allow them to be inlined with clang
Koundinya Veluri [Tue, 20 Oct 2015 17:37:01 +0000 (10:37 -0700)]
Move some functions to allow them to be inlined with clang

For the moment, GetThread, _rotl/_rotr, Interlocked..., and similar functions were moved to allow inlining them with clang.

The plan is to eventually enable link-time optimization (LTO) to cover inlining across translation units.

Renamed some code files in PAL tests to compile as C++ to use the C++ inline semantics.

Commit migrated from https://github.com/dotnet/coreclr/commit/194d5a41455bda3f348524a1b54f59b5e0c19f0c

8 years agoMerge pull request dotnet/coreclr#1827 from brianrob/tracinginit
Brian Robbins [Thu, 22 Oct 2015 03:03:38 +0000 (20:03 -0700)]
Merge pull request dotnet/coreclr#1827 from brianrob/tracinginit

Initialize LTTng tracepoint providers automatically

Commit migrated from https://github.com/dotnet/coreclr/commit/ec209f65458ed447434d8b2186187c0444c8d227

8 years agoMerge pull request dotnet/coreclr#1751 from ramarag/eventsource
Rama krishnan Raghupathy [Thu, 22 Oct 2015 03:00:57 +0000 (20:00 -0700)]
Merge pull request dotnet/coreclr#1751 from ramarag/eventsource

Enable EventSource Logging in Linux via Lttng

Commit migrated from https://github.com/dotnet/coreclr/commit/419629fdc3e51c6c28467bf1b57b7fcd80dc8360

8 years ago Generate efficient code for rotation patterns.
Eugene Rozenfeld [Tue, 13 Oct 2015 01:36:25 +0000 (18:36 -0700)]
 Generate efficient code for rotation patterns.

     This change adds code to recognize rotation idioms and generate efficient instructions for them.

     Two new operators are added: GT_ROL and GT_ROR.

     The patterns recognized:
     (x << c1) | (x >>> c2) => x rol c1
     (x >>> c1) | (x << c2) => x ror c2

     where c1 and c2  are constant and c1 + c2 == bitsize(x)

     (x << y) | (x >>> (N - y)) => x rol y
     (x >>> y) | (x << (N - y)) => x ror y

     where N == bitsize(x)

     (x << y & M1) | (x >>> (N - y) & M2) => x rol y
     (x >>> y & M1) | (x << (N - y) & M2) => x ror y

     where N == bitsize(x)
     M1 & (N - 1) == N - 1
     M2 & (N - 1) == N - 1

     For a simple benchmark with 4 rotation patterns in a tight loop
     time goes from 7.324 to 2.600 (2.8 speedup).

     Rotations found and optimized in mscorlib:
     System.Security.Cryptography.SHA256Managed::RotateRight
     System.Security.Cryptography.SHA384Managed::RotateRight
     System.Security.Cryptography.SHA512Managed::RotateRight
     System.Security.Cryptography.RIPEMD160Managed:MDTransform (320 instances!)
     System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Rol1
     System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Rol5
     System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Rol30
     System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Drain
     (9 instances of Sha1ForNonSecretPurposes::Rol* inlined)

     Closes dotnet/coreclr#1619.

Commit migrated from https://github.com/dotnet/coreclr/commit/7b4508ba9419157570a9c47e4ebc8a79dcc53a11

8 years agoMerge pull request dotnet/coreclr#1828 from ellismg/fix-directory-casing
Matt Ellis [Thu, 22 Oct 2015 01:46:58 +0000 (18:46 -0700)]
Merge pull request dotnet/coreclr#1828 from ellismg/fix-directory-casing

Fix directory casing of `regressions' in test/src

Commit migrated from https://github.com/dotnet/coreclr/commit/57b13a94fbcdd0b429aa56d7e4faf65aeec7949a

8 years agoEnable EventSource Logging in Linux via Lttng
Rama [Mon, 12 Oct 2015 23:09:40 +0000 (16:09 -0700)]
Enable EventSource Logging in Linux via Lttng

Commit migrated from https://github.com/dotnet/coreclr/commit/9b7b565f952d6f34bc75236b4d9d71954bb65017

8 years agoFix directory casing of `regressions' in test/src
Matt Ellis [Thu, 22 Oct 2015 00:42:33 +0000 (17:42 -0700)]
Fix directory casing of `regressions' in test/src

We had both tests/src/Regressions and tests/src/regressions which causes
problems because the on disc casing of files now differs based on if you
have a case insensitive file system or not.

This was confusing the the mirror a great deal because the casing of the
files is unified on the TFS side but the mirror was seeing these files
as renames.

Commit migrated from https://github.com/dotnet/coreclr/commit/d063c22dc418bc0394be1ff59d8a714640c401fc

8 years agoInitialize LTTng tracepoint provider as part of loading libcoreclr.so.
Brian Robbins [Wed, 21 Oct 2015 23:34:42 +0000 (16:34 -0700)]
Initialize LTTng tracepoint provider as part of loading libcoreclr.so.

Commit migrated from https://github.com/dotnet/coreclr/commit/bd4c05057c66439e420835eaf06ef325e91f7f4d

8 years agoMerge pull request dotnet/coreclr#1809 from mmitche/add-x86-builds
Matt Mitchell [Wed, 21 Oct 2015 23:26:36 +0000 (16:26 -0700)]
Merge pull request dotnet/coreclr#1809 from mmitche/add-x86-builds

Add x86 builds to CI (most off by default)

Commit migrated from https://github.com/dotnet/coreclr/commit/d78a8513df236fa20447ed7ddb6ecb9e47cfe7e0

8 years agoAdd x86 builds to CI (most off by default)
Matt Mitchell [Tue, 20 Oct 2015 18:20:45 +0000 (11:20 -0700)]
Add x86 builds to CI (most off by default)

* Builds are available through trigger phrases
* x86 windows_nt on for pushes by default
Additionally:
 * fixes workspace parameter quoting for Linux coreclr tests

Commit migrated from https://github.com/dotnet/coreclr/commit/95f3cb2d020ffcfdfa644470a4ce6294d708df6b

8 years agoMerge pull request dotnet/coreclr#1788 from naamunds/UpdateXplatDoc
Nate Amundson [Wed, 21 Oct 2015 22:45:44 +0000 (17:45 -0500)]
Merge pull request dotnet/coreclr#1788 from naamunds/UpdateXplatDoc

Update Linux and OS X build instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/f2e6e3571452707666d693aaffba60d90208235e

8 years agoUpdate Linux and OS X build instructions
Nate Amundson [Wed, 21 Oct 2015 22:43:26 +0000 (17:43 -0500)]
Update Linux and OS X build instructions

CoreClr (including mscorlib) and CoreFx can now be built using Mono on
both Linux and OS X; this change updates the instructions to reflect
that.  It also moves the instructions for the alternative option of
building the x-plat bits on Windows to cross-building.md.

This change also adds System.Globalization.Native, which is now
necessary.

At some point the FreeBSD documentation should also be updated to be
consistent with the Linux and OS X instructions; ideally, they should be
combined into one file, as discussed in https://github.com/dotnet/coreclr/issues/1590.

Commit migrated from https://github.com/dotnet/coreclr/commit/38787b0d6802eb6138b9ea1653d6fa8ed8063a42

8 years agoMerge pull request dotnet/coreclr#1780 from adityamandaleeka/librarySearchPaths
Aditya Mandaleeka [Wed, 21 Oct 2015 22:26:49 +0000 (15:26 -0700)]
Merge pull request dotnet/coreclr#1780 from adityamandaleeka/librarySearchPaths

Fix DllImport search logic with respect to prefixes/suffixes

Commit migrated from https://github.com/dotnet/coreclr/commit/2fadd657a3d3826e32638a6bdde1f7c9394531dc

8 years agoAdd STANDARD_VM_CONTRACT and remove loop that's no longer needed.
Aditya Mandaleeka [Wed, 21 Oct 2015 20:58:52 +0000 (13:58 -0700)]
Add STANDARD_VM_CONTRACT and remove loop that's no longer needed.

Commit migrated from https://github.com/dotnet/coreclr/commit/c9a6067831b40b739e5a4a908b66a8b7b84e565f

8 years agoMerge pull request dotnet/coreclr#1824 from Priya91/fixbug
Lakshmi Priya [Wed, 21 Oct 2015 20:01:37 +0000 (13:01 -0700)]
Merge pull request dotnet/coreclr#1824 from Priya91/fixbug

Fix lpFileName leak in InternalCreateProcess.

Commit migrated from https://github.com/dotnet/coreclr/commit/65b55ab02eba5fc71daadb0db9f4d4a424906dba

8 years agoAlways attempt to load specified DLL name first before trying variations
Aditya Mandaleeka [Tue, 20 Oct 2015 03:53:05 +0000 (20:53 -0700)]
Always attempt to load specified DLL name first before trying variations

Commit migrated from https://github.com/dotnet/coreclr/commit/f087812e819ebfb20b1a72d34f9eea9ea1cc34ad

8 years agoRemove ReversePInvoke test from failing tests list.
Aditya Mandaleeka [Thu, 15 Oct 2015 22:30:36 +0000 (15:30 -0700)]
Remove ReversePInvoke test from failing tests list.

Commit migrated from https://github.com/dotnet/coreclr/commit/dec03df223e1a1448bc061b8016b8323c6ec5b81

8 years agoMove prefix/suffix logic to dllimport
Aditya Mandaleeka [Thu, 15 Oct 2015 22:09:51 +0000 (15:09 -0700)]
Move prefix/suffix logic to dllimport

Commit migrated from https://github.com/dotnet/coreclr/commit/16515a943e18ebeedcc96a9129f6cd99b5b4af6c

8 years agoFix lpFileName leak in InternalCreateProcess.
Lakshmi Priya Sekar [Wed, 21 Oct 2015 15:57:23 +0000 (08:57 -0700)]
Fix lpFileName leak in InternalCreateProcess.

Commit migrated from https://github.com/dotnet/coreclr/commit/59de8a76b21c6a0b754fb1c60b094968faaca582

8 years agoMerge pull request dotnet/coreclr#1822 from janvorli/fix-pal-new-usage
Stephen Toub [Wed, 21 Oct 2015 16:19:58 +0000 (12:19 -0400)]
Merge pull request dotnet/coreclr#1822 from janvorli/fix-pal-new-usage

Remove new operator usage in PAL

Commit migrated from https://github.com/dotnet/coreclr/commit/4d7a3ddd641d91d02c2dbb7ef8829e41939e1a16

8 years agoRemove new operator usage in PAL
Jan Vorlicek [Wed, 21 Oct 2015 14:49:45 +0000 (07:49 -0700)]
Remove new operator usage in PAL

This change fixes an issue caused by recent change in filename buffers
allocations. It was using the operator new, but it should not be used
in PAL since it invokes overriden operator new in the coreclr.
The fix is to use InternalMalloc instead.

Commit migrated from https://github.com/dotnet/coreclr/commit/d8755f9d7ba419d31cf7ae6e0db6b7d10fafd440

8 years agoMerge pull request dotnet/coreclr#1808 from om3n07/master
Stephen Toub [Wed, 21 Oct 2015 14:34:21 +0000 (10:34 -0400)]
Merge pull request dotnet/coreclr#1808 from om3n07/master

Correct comments on Array sorting methods

Commit migrated from https://github.com/dotnet/coreclr/commit/c955065b8bf842f31dacd1d352f02847dc3b001f

8 years agoMerge pull request dotnet/coreclr#1804 from dotnet-bot/from-tfs
Matt Ellis [Wed, 21 Oct 2015 06:58:01 +0000 (23:58 -0700)]
Merge pull request dotnet/coreclr#1804 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/e9f018f94407e80c3ed76f227717deac70cc85f7

8 years agoMerge pull request dotnet/coreclr#1817 from bryanar/pri1testfix
Bryan P. Arant [Wed, 21 Oct 2015 06:13:07 +0000 (23:13 -0700)]
Merge pull request dotnet/coreclr#1817 from bryanar/pri1testfix

Fixing test infrastructure that affects pri1 tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/d25e96ae0550b87284e3ab9ab402d729cd2ad794

8 years agoRemove bad wording
Richard Lander [Wed, 21 Oct 2015 06:02:19 +0000 (23:02 -0700)]
Remove bad wording
One team borrowed code from another.

Commit migrated from https://github.com/dotnet/coreclr/commit/19ac8764fcd461a1b5d9c14940cca24dac62db02

8 years agoAdd attribution for lookup3.c
Richard Lander [Tue, 20 Oct 2015 04:08:32 +0000 (21:08 -0700)]
Add attribution for lookup3.c

Commit migrated from https://github.com/dotnet/coreclr/commit/1349986987bdd23411bfaebb9f68d63eca6a8b39

8 years agoRemove duplicate license
Richard Lander [Tue, 20 Oct 2015 03:27:30 +0000 (20:27 -0700)]
Remove duplicate license

Commit migrated from https://github.com/dotnet/coreclr/commit/6f01a884916e82f24e99c6e0b4f3e87851bb35e8

8 years agoAdd attribution for RFC 3492
Richard Lander [Tue, 20 Oct 2015 05:25:51 +0000 (22:25 -0700)]
Add attribution for RFC 3492

Commit migrated from https://github.com/dotnet/coreclr/commit/7c64e38743eeb7a38e2407586de6e5cec7dda15f

8 years agoCorrect attribution for UUIDs and GUIDs
Richard Lander [Mon, 19 Oct 2015 22:35:15 +0000 (15:35 -0700)]
Correct attribution for UUIDs and GUIDs

Commit migrated from https://github.com/dotnet/coreclr/commit/b4d5bc82403495bf5ca41c07e45b4448b80c3ccf

8 years agoRemove NR reference
Richard Lander [Mon, 19 Oct 2015 16:26:00 +0000 (09:26 -0700)]
Remove NR reference
After speaking to the authors, the attribution comment is not required for this instance. However, Numerical Recipes in C is an awesome book written by some very smart and classy folks. It's a great book.

Commit migrated from https://github.com/dotnet/coreclr/commit/086b32fbef099b8be50683ea942ee09fd8021866

8 years agoMerge pull request dotnet/coreclr#1744 from Priya91/palstring-rest
Lakshmi Priya [Wed, 21 Oct 2015 02:02:33 +0000 (19:02 -0700)]
Merge pull request dotnet/coreclr#1744 from Priya91/palstring-rest

Use StackString in PAL file apis.

Commit migrated from https://github.com/dotnet/coreclr/commit/6b091902c7f2cc2578a8fb34a7ce8115f0f9cb8b

8 years agoMerge pull request dotnet/coreclr#1813 from adityamandaleeka/pal_cleanup
Aditya Mandaleeka [Wed, 21 Oct 2015 00:18:49 +0000 (17:18 -0700)]
Merge pull request dotnet/coreclr#1813 from adityamandaleeka/pal_cleanup

Clean up cleanup code in PAL

Commit migrated from https://github.com/dotnet/coreclr/commit/96515c550cf891cc62287cd6f03ed02894f9a5cc

8 years agoFix boundary bugs on buffer lengths. Include null char in MAX_LONGPATH.
Lakshmi Priya Sekar [Mon, 19 Oct 2015 18:01:24 +0000 (11:01 -0700)]
Fix boundary bugs on buffer lengths. Include null char in MAX_LONGPATH.

Commit migrated from https://github.com/dotnet/coreclr/commit/fdbd0a799c370d7fcf3832e04819c5ec9d85b6a7

8 years agoFixing some pri1 tests.
Bryan Arant [Tue, 20 Oct 2015 23:03:04 +0000 (16:03 -0700)]
Fixing some pri1 tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/8af5de08e22661b386eb517bea57fb8727b72485

8 years agoMerge pull request dotnet/coreclr#1806 from LLITCHEV/SystemVStructs
Lubomir Litchev [Tue, 20 Oct 2015 23:14:16 +0000 (16:14 -0700)]
Merge pull request dotnet/coreclr#1806 from LLITCHEV/SystemVStructs

Implementation of System V ABI struct passing.

Commit migrated from https://github.com/dotnet/coreclr/commit/c96f74816ad03b39d0311c445a089520a8136314

8 years agoImplementation of System V ABI struct passing.
Lubomir Litchev [Thu, 19 Feb 2015 19:42:30 +0000 (11:42 -0800)]
Implementation of System V ABI struct passing.

This PR adds support for System V x86_64 ABI classification and calling
convention to the VM and the Jit, including, but not limited to Ubuntu
Linux and Mac OS X.
The general rules outlined in the System V x86_64 ABI (described at
http://www.x86-64.org/documentation/abi.pdf) are followed with a few
little exceptions, described below:
1. The hidden argument for by-value passed structs is always after
the ÎéÎíthisÎéÎí parameter (if there is one.). This is a difference with
the Sysetem V ABI and affects only the internal jit calling conventions.
For PInvoke calls the hidden argument is always the first parameter since
there is no ÎéÎíthisÎéÎí parameter in this case.
2. Managed structs that have no fields are always passed by-value on
the stack.
3. The jit proactively generates frame register frames (with RBP as a
frame register) in order to aid the native OS tooling for stack unwinding
and the like.

Commit migrated from https://github.com/dotnet/coreclr/commit/378e304f9e22b3c4d03c3b1b62c47b0aa58ceaf5

8 years agoRemove unused full_cleanup parameter
Aditya Mandaleeka [Tue, 20 Oct 2015 21:20:15 +0000 (14:20 -0700)]
Remove unused full_cleanup parameter

Commit migrated from https://github.com/dotnet/coreclr/commit/0de2be938c00f3b3b824b2493b916aa901a74cae

8 years agoMerge pull request dotnet/coreclr#1811 from mikem8361/exceptfix
Mike McLaughlin [Tue, 20 Oct 2015 21:12:31 +0000 (14:12 -0700)]
Merge pull request dotnet/coreclr#1811 from mikem8361/exceptfix

Managed unhandled exceptions for debugging and other fixes

Commit migrated from https://github.com/dotnet/coreclr/commit/4be080ee4c52211247d720e24f71d87b657357ee

8 years agoMerge pull request dotnet/coreclr#1805 from sergiy-k/nodebugmsgs
Jan Vorlicek [Tue, 20 Oct 2015 21:02:54 +0000 (14:02 -0700)]
Merge pull request dotnet/coreclr#1805 from sergiy-k/nodebugmsgs

Disable DEBUG_MESSAGES in release build of CoreCLR PAL

Commit migrated from https://github.com/dotnet/coreclr/commit/fc4da45649e0e58d18d23af98e1230b71ddbcbe0

8 years agoFix issue dotnet/coreclr#1782 unhanded exceptions don't generate core dumps by changi...
Mike McLaughlin [Tue, 20 Oct 2015 01:38:26 +0000 (18:38 -0700)]
Fix issue dotnet/coreclr#1782 unhanded exceptions don't generate core dumps by changing HandleFatalError to end up calling TerminateProcess (which calls the unix abort()) instead of ExitProcess.

Commit migrated from https://github.com/dotnet/coreclr/commit/64c377e4069af40b5f7c3c19481ec95526fcdb57

8 years agoFix assert when unhandled exception is unwound and restored some previous code in...
Mike McLaughlin [Tue, 20 Oct 2015 00:20:56 +0000 (17:20 -0700)]
Fix assert when unhandled exception is unwound and restored some previous code in the first pass dispatcher so the managed debugger notification is sent at the right time (during the first pass instead after everything is unwound).

Also fixed issue dotnet/coreclr#1799 by not masking SIGTERM anymore.

Commit migrated from https://github.com/dotnet/coreclr/commit/ce40fd159f6961efa44daeb6e7043a40407b6590

8 years agoMerge pull request dotnet/coreclr#1775 from mmitche/add-coreclr-linux-tests
Matt Mitchell [Tue, 20 Oct 2015 16:06:31 +0000 (09:06 -0700)]
Merge pull request dotnet/coreclr#1775 from mmitche/add-coreclr-linux-tests

Add coreclr Linux tests to CI definition

Commit migrated from https://github.com/dotnet/coreclr/commit/1bed1529e6f48418899bc057e9e3cecd8cb72db6

8 years agoFixup
Matt Mitchell [Tue, 20 Oct 2015 15:52:36 +0000 (08:52 -0700)]
Fixup

Commit migrated from https://github.com/dotnet/coreclr/commit/6ec712cb1864b69a73053bc9bad97cdcd414919f

8 years agoCorrect comments on Array sorting methods
Matt [Tue, 20 Oct 2015 13:50:54 +0000 (09:50 -0400)]
Correct comments on Array sorting methods

Changed "recrusively" to "recursively" and "subtrack" to "subtract".

https://github.com/dotnet/coreclr/issues/1801

Commit migrated from https://github.com/dotnet/coreclr/commit/8e1c0b305729f04ef25eb422e73625688db3a0d7

8 years agoMerge pull request dotnet/coreclr#1803 from adityamandaleeka/fix_4cf34fe
Aditya Mandaleeka [Tue, 20 Oct 2015 06:23:43 +0000 (23:23 -0700)]
Merge pull request dotnet/coreclr#1803 from adityamandaleeka/fix_4cf34fe

Revert some changed files from an incorrectly merged commit

Commit migrated from https://github.com/dotnet/coreclr/commit/b422116a7ef6f03884604620a71671645fe66b30

8 years agoDisable DEBUG_MESSAGES in release build of CoreCLR PAL
Sergiy Kuryata [Tue, 20 Oct 2015 04:13:01 +0000 (21:13 -0700)]
Disable DEBUG_MESSAGES in release build of CoreCLR PAL

This reduces the size of libcoreclr by 1.3MB and improves performace results by a few percent on some benchmarks.

Commit migrated from https://github.com/dotnet/coreclr/commit/d1ee2104052aeb3b4dacdf33d9ecf55f1ed33f1d

8 years agoMerge pull request dotnet/coreclr#1802 from jkotas/networking
Jan Kotas [Tue, 20 Oct 2015 02:11:20 +0000 (19:11 -0700)]
Merge pull request dotnet/coreclr#1802 from jkotas/networking

Delete remaining vestiges of PAL networking support

Commit migrated from https://github.com/dotnet/coreclr/commit/3d1175e017b0c0b4cd7276044f607203a3e9e436

8 years agoMerge pull request dotnet/coreclr#1800 from stephentoub/invariant_casing_fix
Stephen Toub [Tue, 20 Oct 2015 01:53:35 +0000 (21:53 -0400)]
Merge pull request dotnet/coreclr#1800 from stephentoub/invariant_casing_fix

Fix Turkish i casing with invariant culture on Unix

Commit migrated from https://github.com/dotnet/coreclr/commit/8f3cbd96aa9f3952686fc37d8547fe9c928f7279

8 years agoRevert some changed files from an incorrectly merged commit.
Aditya Mandaleeka [Tue, 20 Oct 2015 01:21:36 +0000 (18:21 -0700)]
Revert some changed files from an incorrectly merged commit.

Commit 4cf34fe seems to have included some unintentional changes which are
affecting the product. This reverts those files to what they should be.

Commit migrated from https://github.com/dotnet/coreclr/commit/0786c55bf36321a49bb09b5d37a1b2d5f79fd9e9

8 years agoaddressing desktop build failure
Rama Krishnan Raghupathy [Tue, 20 Oct 2015 01:22:07 +0000 (18:22 -0700)]
addressing desktop build failure

Code which does not have FEATURE_EVENT_TRACE defined is using artifacts from it

[tfs-changeset: 1539531]

Commit migrated from https://github.com/dotnet/coreclr/commit/586b884dc1b8fb7487a6c25cec327627ba75f411

8 years agoDelete remaining vestiges of PAL networking support
Jan Kotas [Tue, 20 Oct 2015 00:49:57 +0000 (17:49 -0700)]
Delete remaining vestiges of PAL networking support

Commit migrated from https://github.com/dotnet/coreclr/commit/27d9deab63ecedd2e2cf12fb74e25175f8bd300b

8 years agoFix Turkish i casing with invariant culture
stephentoub [Mon, 19 Oct 2015 20:35:36 +0000 (16:35 -0400)]
Fix Turkish i casing with invariant culture

It turns out there are some differences in the casing data used by Windows and ICU for our invariant culture.  In particular, Turkish 'i' is handled differently.

This change splits the shim ChangeCase function into three: ChangeCaseTurkish (used for Turkish culture), ChangeCaseInvariant (used for Invariant culture), and ChangeCase (used for everything else.  ChangeCaseInvariant includes the new special cases.  Call sites in the  managed code are localized to a single function that determines which native function to invoke.

Commit migrated from https://github.com/dotnet/coreclr/commit/28e12d2a14d87f03586e9afd58065abb95b1a637

8 years agoMerge pull request dotnet/coreclr#1785 from bryanar/managed-test-port
Bryan P. Arant [Mon, 19 Oct 2015 08:11:21 +0000 (01:11 -0700)]
Merge pull request dotnet/coreclr#1785 from bryanar/managed-test-port

Managed Test Port

Commit migrated from https://github.com/dotnet/coreclr/commit/3015ff7afb4936a1c5c5856daa4e3482e6b390a9

8 years agoRemoved #ifndef CORECLR blocks from shmemory.
Lakshmi Priya Sekar [Mon, 19 Oct 2015 07:37:21 +0000 (00:37 -0700)]
Removed #ifndef CORECLR blocks from shmemory.

Commit migrated from https://github.com/dotnet/coreclr/commit/3433abc7838db54b9656bd0cfb606a7a0d6fed91

8 years agoRemove MAX_LONGPATH constraint checks from file name string length.
Lakshmi Priya Sekar [Mon, 19 Oct 2015 07:11:49 +0000 (00:11 -0700)]
Remove MAX_LONGPATH constraint checks from file name string length.

Commit migrated from https://github.com/dotnet/coreclr/commit/ab9a052eca3d3784b87b0c9f288f266bf1f846be

8 years agoUse StackString in PAL file apis.
Lakshmi Priya Sekar [Wed, 7 Oct 2015 01:19:32 +0000 (18:19 -0700)]
Use StackString in PAL file apis.

Commit migrated from https://github.com/dotnet/coreclr/commit/01a7eb3df39e828c0c83980ff2d32bc49b3db73b

8 years agoManaged Test Port
dotnet-bot [Wed, 30 Sep 2015 19:20:52 +0000 (12:20 -0700)]
Managed Test Port

This is a collection of managed runtime tests from an internal legacy test tree.

Commit migrated from https://github.com/dotnet/coreclr/commit/004514c07bcf5230b518befd75f794733b5f9067

8 years agoFix build break with WindowsOS CRT
Jan Kotas [Sat, 17 Oct 2015 01:54:12 +0000 (18:54 -0700)]
Fix build break with WindowsOS CRT

_get_wpgmptr is not available in WindowsOS CRT. Replace it with GetModuleFileName.

[tfs-changeset: 1538931]

Commit migrated from https://github.com/dotnet/coreclr/commit/5992ffac963acc0fbd9e3fd9976d9842a74abbe7

8 years agoMerge pull request dotnet/coreclr#1789 from jkotas/crsttypetool
Jan Kotas [Sat, 17 Oct 2015 00:11:30 +0000 (17:11 -0700)]
Merge pull request dotnet/coreclr#1789 from jkotas/crsttypetool

Add CrstTypeTool source code

Commit migrated from https://github.com/dotnet/coreclr/commit/917e33ad279878b4929e95bfdd1ec5484d108ab0

8 years agoAdd CrstTypeTool source code
Jan Kotas [Fri, 16 Oct 2015 23:41:55 +0000 (16:41 -0700)]
Add CrstTypeTool source code

This tool is required for updating autogenerated crsttypes.h file

Commit migrated from https://github.com/dotnet/coreclr/commit/7a130e64d66045975d3a36e810e8d15819fdadda

8 years agoMerge pull request dotnet/coreclr#1779 from ramarag/control_xplat_event_logging
Rama krishnan Raghupathy [Fri, 16 Oct 2015 23:01:37 +0000 (16:01 -0700)]
Merge pull request dotnet/coreclr#1779 from ramarag/control_xplat_event_logging

Controlling Xplat Event logging

Commit migrated from https://github.com/dotnet/coreclr/commit/36a6186a87cdcfe3818cd3b876feab0b93774a4e

8 years agoFix Windows x86 build - use macro for friend declaration
dotnet-bot [Fri, 16 Oct 2015 22:10:29 +0000 (15:10 -0700)]
Fix Windows x86 build - use macro for friend declaration

The friend declaration conflicted with the extern declaration on x86 because the macro uses fastcall.

[tfs-changeset: 1538868]

Commit migrated from https://github.com/dotnet/coreclr/commit/4f748b62207375417b7923f30becf65cc1d733e7

8 years agoMerge pull request dotnet/coreclr#1786 from kouvel/BuildFix
Koundinya Veluri [Fri, 16 Oct 2015 22:03:20 +0000 (15:03 -0700)]
Merge pull request dotnet/coreclr#1786 from kouvel/BuildFix

Fix Windows x86 build - use macro for friend declaration

Commit migrated from https://github.com/dotnet/coreclr/commit/55bff47d2f2230d79c00004c45565bf784db306e

8 years agoControlling Xplat Event logging:
Rama [Thu, 15 Oct 2015 22:16:24 +0000 (15:16 -0700)]
Controlling Xplat Event logging:
Adding an environment variable COMPlus_EnableEventLog to turn on/off
Xplat Event Logging, by default Xplat Event logging is turned off

Commit migrated from https://github.com/dotnet/coreclr/commit/647156a4c78269f5393eb9fa2e85b24255426df2

8 years agoMerge pull request dotnet/coreclr#1783 from nguerrera/explicit-location-model
Nick Guerrera [Fri, 16 Oct 2015 20:41:10 +0000 (13:41 -0700)]
Merge pull request dotnet/coreclr#1783 from nguerrera/explicit-location-model

Be explicit about exposing Assembly.Location in model.xml

Commit migrated from https://github.com/dotnet/coreclr/commit/f7089df9e2377603b04fe2837bd9bbc3fc434304

8 years agoFix Windows x86 build - use macro for friend declaration
Koundinya Veluri [Fri, 16 Oct 2015 20:37:57 +0000 (13:37 -0700)]
Fix Windows x86 build - use macro for friend declaration

Commit migrated from https://github.com/dotnet/coreclr/commit/257fb0e6cd7fda099a790d5e9a38b9c602e76050

8 years agoMerge pull request dotnet/coreclr#1781 from nguerrera/expose-mvid
Nick Guerrera [Fri, 16 Oct 2015 18:41:39 +0000 (11:41 -0700)]
Merge pull request dotnet/coreclr#1781 from nguerrera/expose-mvid

Expose Module.ModuleVersionId

Commit migrated from https://github.com/dotnet/coreclr/commit/e83ca434502e3043527cb6929874089029ecc255

8 years agoPass __IntermediatesDir to msbuild in build.sh
Nate Amundson [Fri, 16 Oct 2015 16:32:06 +0000 (11:32 -0500)]
Pass __IntermediatesDir to msbuild in build.sh

Currently, building coreclr x-plat fails if not running as root due to
the build trying to copy files to "/ToolRuntime".  The issue is that
$(IntermediatesOutputRootPath) is not set when running from build.sh,
and testruntime.targets in buildtools defines ToolRuntimePath as
"$(IntermediateOutputRootPath)ToolRuntime\".  The fix is to pass
__IntermediatesDir to msbuild in build_mscorlib, which results in
$(IntermediatesOutputRootPath) being properly set.

This change also adds a skipcoreclr flag to allow the user to skip the
CoreCLR part of the build, similar to the existing skipmscorlib flag.

Commit migrated from https://github.com/dotnet/coreclr/commit/18e80622347e41cc53ca2ffa880a19298edfd60d

8 years agoBe explicit about exposing Assembly.Location in model.xml
Nick Guerrera [Fri, 16 Oct 2015 01:07:29 +0000 (18:07 -0700)]
Be explicit about exposing Assembly.Location in model.xml

Commit migrated from https://github.com/dotnet/coreclr/commit/cc228c0597791b48ba669e0d133c655347da2dac

8 years agoRemove unnecessary condemnation and suspension in PALCommonCleanup.
Aditya Mandaleeka [Fri, 16 Oct 2015 00:46:19 +0000 (17:46 -0700)]
Remove unnecessary condemnation and suspension in PALCommonCleanup.

Commit migrated from https://github.com/dotnet/coreclr/commit/3d14d24f37e7728d9f1ec833b231f00c00693b76

8 years agoRemove CPalSynchronizationManager::Shutdown
Aditya Mandaleeka [Fri, 16 Oct 2015 00:19:52 +0000 (17:19 -0700)]
Remove CPalSynchronizationManager::Shutdown

Commit migrated from https://github.com/dotnet/coreclr/commit/b409ad2b921c6e2fa4bd429f7a9560ef960ad701