erikcorry [Mon, 8 Jun 2015 12:00:47 +0000 (05:00 -0700)]
Only record one in n line endings to save space.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1137683003
Cr-Commit-Position: refs/heads/master@{#28837}
Benedikt Meurer [Mon, 8 Jun 2015 11:47:03 +0000 (13:47 +0200)]
[turbofan] Initial support for the %_DateField intrinsic.
This only introduces better typing and lowering for access to the value
field.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1169723002
Cr-Commit-Position: refs/heads/master@{#28836}
mbrandy [Mon, 8 Jun 2015 11:42:14 +0000 (04:42 -0700)]
Fix uninitialized variable compiler errors [GCC 4.8.4]
R=svenpanne@chromium.org, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1163143005
Cr-Commit-Position: refs/heads/master@{#28835}
jochen [Mon, 8 Jun 2015 11:28:46 +0000 (04:28 -0700)]
Factor out handling of mixed objects preprocessing after migration
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1135353003
Cr-Commit-Position: refs/heads/master@{#28834}
ulan [Mon, 8 Jun 2015 11:23:56 +0000 (04:23 -0700)]
Sample allocation throughput in all idle notifications.
This removes special handling of long idle notifications.
BUG=
Review URL: https://codereview.chromium.org/
1159153003
Cr-Commit-Position: refs/heads/master@{#28833}
ulan [Mon, 8 Jun 2015 11:20:30 +0000 (04:20 -0700)]
Revert of Replace ad-hoc weakness in prototype transitions with WeakCell. (patchset #2 id:20001 of https://codereview.chromium.org/
1163073002/)
Reason for revert:
GC stress failures.
Original issue's description:
> Replace ad-hoc weakness in prototype transitions with WeakCell.
>
> BUG=
>
> Committed: https://crrev.com/
bfb81fbe0d38c88cc1b6ed6eb1a4b8cbe2c469c3
> Cr-Commit-Position: refs/heads/master@{#28830}
TBR=jkummerow@chromium.org,hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1169733002
Cr-Commit-Position: refs/heads/master@{#28832}
verwaest [Mon, 8 Jun 2015 10:21:41 +0000 (03:21 -0700)]
Micro-optimize not-found for elements on objects with empty_fixed_array backing store
BUG=chromium:495949
LOG=n
Review URL: https://codereview.chromium.org/
1163033004
Cr-Commit-Position: refs/heads/master@{#28831}
ulan [Mon, 8 Jun 2015 10:20:34 +0000 (03:20 -0700)]
Replace ad-hoc weakness in prototype transitions with WeakCell.
BUG=
Review URL: https://codereview.chromium.org/
1163073002
Cr-Commit-Position: refs/heads/master@{#28830}
bmeurer [Mon, 8 Jun 2015 10:14:46 +0000 (03:14 -0700)]
[for-in] Make ForInNext and ForInFilter deal properly with exceptions.
Both ToName() and HasProperty() can actually throw, so we need to
propagate those exceptions properly.
BUG=chromium:496331
LOG=y
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1162833006
Cr-Commit-Position: refs/heads/master@{#28829}
hablich [Mon, 8 Jun 2015 10:11:23 +0000 (03:11 -0700)]
Fixes for try-catch microbenchmark
BUG=v8:4131
LOG=n
Review URL: https://codereview.chromium.org/
1163043003
Cr-Commit-Position: refs/heads/master@{#28828}
mvstanton [Mon, 8 Jun 2015 10:10:10 +0000 (03:10 -0700)]
Vector ICs: ClassLiterals need to allocate a vector slot for home objects.
BUG=
Review URL: https://codereview.chromium.org/
1160173004
Cr-Commit-Position: refs/heads/master@{#28827}
jarin [Mon, 8 Jun 2015 10:04:51 +0000 (03:04 -0700)]
Unify decoding of deoptimization translations.
This unifies methods Deoptimizer::DoTranslateCommand, Deotpimizer::DoTranslateObject and the arguments object materializer.
To unify these, we have to separate reading of the input frame from writing to the output frame because the argument materializer does not write to output frames.
Instead, we now deoptimize in following stages:
1. Read out the input frame/registers, decode them using the translations from the deoptimizer and store them in the deoptimizer (Deoptimizer::translated_state_). This is done in TranslatedState::Init.
2. Write out into the output frame buffer all the values that do not require allocation. We also remember references to the values that require materialization. As before, this is done in Deoptimizer::DoCompute*Frame method, but instead calling to DoTranslateCommand, we use the translated frame to obtain the values and write them to the output frames.
3. The platform specific code then sets up the output frames and calls into the deoptimization notification. This has not been changed at all.
4. Once the stack is setup, we handlify all the references in the saved translated values (TranslatedState::Prepare).
5. Finally, we materialize all the values we remembered in step (1) and write them to their frames on the stack (using the TranslatedValue::GetValue method).
BUG=
Review URL: https://codereview.chromium.org/
1136223004
Cr-Commit-Position: refs/heads/master@{#28826}
mvstanton [Mon, 8 Jun 2015 09:34:36 +0000 (02:34 -0700)]
Vector ICs: debugger should save registers for vector store ics.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1154303008
Cr-Commit-Position: refs/heads/master@{#28825}
ulan [Mon, 8 Jun 2015 09:13:27 +0000 (02:13 -0700)]
Add compiler field to code print output.
BUG=
Review URL: https://codereview.chromium.org/
1151883004
Cr-Commit-Position: refs/heads/master@{#28824}
mstarzinger [Mon, 8 Jun 2015 08:59:00 +0000 (01:59 -0700)]
[turbofan] Optimized lowering of DYNAMIC_LOCAL lookup slot loads.
This adds handling of JSLoadDynamicContext nodes to JSTypedLowering to
perform extension checks and an inline fast path. The fast path is a
context slot load targeting a specific context.
R=bmeurer@chromium.org
BUG=v8:4131
LOG=N
Review URL: https://codereview.chromium.org/
1155543003
Cr-Commit-Position: refs/heads/master@{#28823}
erikcorry [Mon, 8 Jun 2015 08:47:36 +0000 (01:47 -0700)]
Never uncommit the whole marking deque in case we can't get it back
R=hpayer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1133153003
Cr-Commit-Position: refs/heads/master@{#28822}
machenbach [Mon, 8 Jun 2015 07:14:35 +0000 (00:14 -0700)]
Make x32 compile with gcc.
BUG=chromium:430032
LOG=n
Review URL: https://codereview.chromium.org/
1156183004
Cr-Commit-Position: refs/heads/master@{#28821}
v8-autoroll [Sun, 7 Jun 2015 03:26:57 +0000 (20:26 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
1efaf64b8e648c8c6539245b10cbea6f3004eb61
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1168033003
Cr-Commit-Position: refs/heads/master@{#28820}
dusan.milosavljevic [Fri, 5 Jun 2015 18:22:13 +0000 (11:22 -0700)]
Revert "MIPS64: Fix lithium arithmetic operations for integers to sign-extend result."
This reverts commit
75744da2689c57c3c8c5bbff2965fe9afe602258.
revert reason:
octane failures.
BUG=
Review URL: https://codereview.chromium.org/
1160143008
Cr-Commit-Position: refs/heads/master@{#28819}
ulan [Fri, 5 Jun 2015 17:15:51 +0000 (10:15 -0700)]
Print and save JS stacktrace on OOM crash.
BUG=
Review URL: https://codereview.chromium.org/
1149623010
Cr-Commit-Position: refs/heads/master@{#28818}
mstarzinger [Fri, 5 Jun 2015 16:40:42 +0000 (09:40 -0700)]
[turbofan] Turn LoadElimination into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1158723005
Cr-Commit-Position: refs/heads/master@{#28817}
ishell [Fri, 5 Jun 2015 15:52:04 +0000 (08:52 -0700)]
A couple of other "stack overflow" vs. "has_pending_exception()" issues fixed.
BUG=chromium:471659, chromium:494158
LOG=N
Review URL: https://codereview.chromium.org/
1151333005
Cr-Commit-Position: refs/heads/master@{#28816}
arv [Fri, 5 Jun 2015 14:32:38 +0000 (07:32 -0700)]
[es6] Add TF support for super.property
Currently does super.prop (load) and super.method() (call). Like full
codegen it uses runtime calls to load the property value.
BUG=v8:3330
LOG=N
R=mstarzinger@chromium.org, dslomov@chromium.org
Review URL: https://codereview.chromium.org/
1149133005
Cr-Commit-Position: refs/heads/master@{#28815}
arv [Fri, 5 Jun 2015 14:18:01 +0000 (07:18 -0700)]
[es6] Array.prototype.find and findIndex should include holes
We should not skip holes for these 2 functions.
BUG=v8:3895
LOG=N
R=adamk
Review URL: https://codereview.chromium.org/
1165003005
Cr-Commit-Position: refs/heads/master@{#28814}
mstarzinger [Fri, 5 Jun 2015 12:37:43 +0000 (05:37 -0700)]
[turbofan] Turn JSBuiltinReducer into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer. It will allow us to deal
with exception continuations correctly.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1158273011
Cr-Commit-Position: refs/heads/master@{#28813}
danno [Fri, 5 Jun 2015 12:28:51 +0000 (05:28 -0700)]
Add %GetCallerJSFunction intrinsic
Only optimized for TF
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1146963002
Cr-Commit-Position: refs/heads/master@{#28812}
jochen [Fri, 5 Jun 2015 12:09:37 +0000 (05:09 -0700)]
Add CHECKs to verify that we never finalize stale copies of external strings
BUG=none
R=ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1160253010
Cr-Commit-Position: refs/heads/master@{#28811}
mstarzinger [Fri, 5 Jun 2015 12:01:55 +0000 (05:01 -0700)]
[turbofan] Allow ReplaceWithValue to kill control.
This allows any AdvancedReducer to remove exception projections from
graphs. This is the common case when JS-operators are being replaced
with pure values. The old NodeProperties::ReplaceWithValue is being
deprecated in favor of AdvancedReducer::ReplaceWithValue.
R=titzer@chromium.org
TEST=unittests/AdvancedReducerTest
Review URL: https://codereview.chromium.org/
1168693002
Cr-Commit-Position: refs/heads/master@{#28810}
ishell [Fri, 5 Jun 2015 11:15:31 +0000 (04:15 -0700)]
Fixed memory leak in JSDate::JSDatePrint().
BUG=chromium:496013
LOG=N
Review URL: https://codereview.chromium.org/
1163203002
Cr-Commit-Position: refs/heads/master@{#28809}
machenbach [Fri, 5 Jun 2015 09:50:53 +0000 (02:50 -0700)]
[test] Fix missing heartbeats in test runner.
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1163523008
Cr-Commit-Position: refs/heads/master@{#28808}
v8-autoroll [Fri, 5 Jun 2015 08:10:08 +0000 (01:10 -0700)]
Update V8 DEPS.
Rolling v8/third_party/icu to
9939a5d5314b6d59d5fb070902d73304c2482f88
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1168573003
Cr-Commit-Position: refs/heads/master@{#28807}
arv [Thu, 4 Jun 2015 21:16:18 +0000 (14:16 -0700)]
[es6] super.prop, eval and lazy functions
We used to only store the uses_super_property in the preparse data
logger. Let the logger use NeedsHomeObject instead.
BUG=v8:3768
LOG=N
R=wingo, adamk
Review URL: https://codereview.chromium.org/
1164073003
Cr-Commit-Position: refs/heads/master@{#28806}
adamk [Thu, 4 Jun 2015 20:08:27 +0000 (13:08 -0700)]
Stage ES6 Array and TypedArray methods
Also stages ES6 @@isConcatSpreadable support.
BUG=v8:3578
LOG=y
Review URL: https://codereview.chromium.org/
1148983006
Cr-Commit-Position: refs/heads/master@{#28805}
arv [Thu, 4 Jun 2015 17:33:20 +0000 (10:33 -0700)]
Unship harmony tostring
Blink's DOM bindings are not yet ready.
BUG=493137, 239915
LOG=N
R=rossberg, adamk
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/
1153263004
Cr-Commit-Position: refs/heads/master@{#28804}
dehrenberg [Thu, 4 Jun 2015 16:36:37 +0000 (09:36 -0700)]
Implement %TypedArray%.prototype.{reduce,reduceRight}
This patch re-commits a previous commit after fixing a test to not
run into another known bug.
This reverts commit
b104a67ef0a50beab2dc85a6ac5732c696d07698.
This patch implements the last two methods on TypedArrays. These
were previously committed and led to a test failure.
BUG=v8:3578
LOG=Y
R=adamk
Review URL: https://codereview.chromium.org/
1159663004
Cr-Commit-Position: refs/heads/master@{#28803}
arv [Thu, 4 Jun 2015 16:22:29 +0000 (09:22 -0700)]
Refactor lexical home object binding
Before this we had 3 super related lexical bindings that got injected
into method bodies: .home_object, .this_function, and new.target.
With this change we get rid of the .home_object one in favor of using
.this_function[home_object_symbol] which allows some simplifications
throughout the code base.
BUG=v8:3768
LOG=N
R=adamk@chromium.org, wingo@igalia.com
Review URL: https://codereview.chromium.org/
1154103005
Cr-Commit-Position: refs/heads/master@{#28802}
mbrandy [Thu, 4 Jun 2015 14:44:00 +0000 (07:44 -0700)]
Add support for Embedded Constant Pools for PPC and Arm
Embed constant pools within their corresponding Code
objects.
This removes support for out-of-line constant pools in favor
of the new approach -- the main advantage being that it
eliminates the need to allocate and manage separate constant
pool array objects.
Currently supported on PPC and ARM. Enabled by default on
PPC only.
This yields a 6% improvment in Octane on PPC64.
R=bmeurer@chromium.org, rmcilroy@chromium.org, michael_dawson@ca.ibm.com
BUG=chromium:478811
LOG=Y
Review URL: https://codereview.chromium.org/
1162993006
Cr-Commit-Position: refs/heads/master@{#28801}
Djordje.Pesic [Thu, 4 Jun 2015 11:45:08 +0000 (04:45 -0700)]
Fix more -Wsign-compare bugs with GCC 4.9.2
Review URL: https://codereview.chromium.org/
1152993005
Cr-Commit-Position: refs/heads/master@{#28800}
v8-autoroll [Thu, 4 Jun 2015 03:26:22 +0000 (20:26 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
b7e158c9336030c1527dfbce92656a2d7b8cfb60
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1150313007
Cr-Commit-Position: refs/heads/master@{#28799}
paul.lind [Thu, 4 Jun 2015 01:28:14 +0000 (18:28 -0700)]
Fix more -Wsign-compare bugs with GCC 4.9.2.
BUG=
Review URL: https://codereview.chromium.org/
1167613004
Cr-Commit-Position: refs/heads/master@{#28798}
bbudge [Wed, 3 Jun 2015 23:56:21 +0000 (16:56 -0700)]
Add new Float32x4 type for SIMD.js.
LOG=N
BUG=v8:4124
Review URL: https://codereview.chromium.org/
1153373003
Cr-Commit-Position: refs/heads/master@{#28797}
binji [Wed, 3 Jun 2015 17:58:29 +0000 (10:58 -0700)]
Implement Atomics API
This is behind the flag "--harmony-atomics", and it only works on
SharedArrayBuffers. This implementation only includes the runtime functions.
The TurboFan implementation will be next.
The draft spec for Atomics can be found here:
https://docs.google.com/document/d/1NDGA_gZJ7M7w1Bh8S0AoDyEqwDdRh4uSoTPSNn77PFk
BUG=
LOG=n
Review URL: https://codereview.chromium.org/
1162503002
Cr-Commit-Position: refs/heads/master@{#28796}
balazs.kilvady [Wed, 3 Jun 2015 17:57:13 +0000 (10:57 -0700)]
MIPS64: Fix '[es6] Super call in arrows and eval'.
Port
4b8051a02ae9f765b7d803fc7986301abde36007
Original commit message:
This splits the SuperReference AST node into SuperPropertyReference and
SuperCallReference. The super call reference node consists of three
unresolved vars to this, new.target and this_function. These gets
declared when the right function is entered and if it is in use. The
variables gets assigned in FullCodeGenerator::Generate.
This is a revert of the revert
88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8
BUG=v8:3768
LOG=N
Review URL: https://codereview.chromium.org/
1160973008
Cr-Commit-Position: refs/heads/master@{#28795}
mbrandy [Wed, 3 Jun 2015 17:21:57 +0000 (10:21 -0700)]
PPC: [date] Refactor the %_DateField intrinsic to be optimizable.
Port
e4782a9b468258344d512a5f7dadbf1584928849
Original commit message:
Previously the %_DateField intrinsic would also check the object and
throw an exception if you happen to pass something that is not a valid
JSDate, which (a) violates our policy for instrinsics and (b) is hard to
optimize in TurboFan (even Crankshaft has a hard time, but there we will
never inline the relevant builtins, so it doesn't show up). The throwing
part is now a separate intrinsics %_ThrowIfNotADate that throws an
exception in full codegen and deoptimizes in Crankshaft, which means the
code for the current use cases is roughly the same (modulo some register
renamings/gap moves).
R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1170463002
Cr-Commit-Position: refs/heads/master@{#28794}
adamk [Wed, 3 Jun 2015 16:32:52 +0000 (09:32 -0700)]
Flatten the Arrays returned and consumed by the v8::Map API
This will significantly simplify the serialization code, as well
as speeding it up (by triggering only a single allocation instead of O(size)
allocations).
BUG=chromium:478263
LOG=y
Review URL: https://codereview.chromium.org/
1157843006
Cr-Commit-Position: refs/heads/master@{#28793}
ishell [Wed, 3 Jun 2015 16:23:01 +0000 (09:23 -0700)]
Fixed noi18n build.
Review URL: https://codereview.chromium.org/
1159553011
Cr-Commit-Position: refs/heads/master@{#28792}
mbrandy [Wed, 3 Jun 2015 15:50:43 +0000 (08:50 -0700)]
PPC: [es6] Super call in arrows and eval
Port
4b8051a02ae9f765b7d803fc7986301abde36007
Original commit message:
This splits the SuperReference AST node into SuperPropertyReference and
SuperCallReference. The super call reference node consists of three
unresolved vars to this, new.target and this_function. These gets
declared when the right function is entered and if it is in use. The
variables gets assigned in FullCodeGenerator::Generate.
This is a revert of the revert
88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8
R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1146403010
Cr-Commit-Position: refs/heads/master@{#28791}
ishell [Wed, 3 Jun 2015 14:34:50 +0000 (07:34 -0700)]
Fixed memory-leak in d8. It did not clean evaluation context used for executing shell commands.
BUG=chromium:493284
LOG=N
Review URL: https://codereview.chromium.org/
1147343004
Cr-Commit-Position: refs/heads/master@{#28790}
hablich [Wed, 3 Jun 2015 12:12:20 +0000 (05:12 -0700)]
Micro benchmark for Try-Catch-Finally
BUG=v8:4131
LOG=n
Review URL: https://codereview.chromium.org/
1155493007
Cr-Commit-Position: refs/heads/master@{#28789}
mstarzinger [Wed, 3 Jun 2015 11:32:25 +0000 (04:32 -0700)]
Fix arrow functions requiring context without slots.
This fixes a corner-case where arrow functions that require a context
allocate none, because there are no additional slots allocated. Note
that this didn't happen with true function scopes because they always
had at least the receiver slot.
The outcome was a context chain that no longer was in sync with the
scope chain, hence context slot loads were bogus. This is observable
using the DYNAMIC_LOCAL optimization in all compilers.
R=rossberg@chromium.org,wingo@igalia.com
TEST=mjsunit/harmony/regress/regress-4160
BUG=v8:4160
LOG=N
Review URL: https://codereview.chromium.org/
1146063006
Cr-Commit-Position: refs/heads/master@{#28788}
bmeurer [Wed, 3 Jun 2015 11:24:14 +0000 (04:24 -0700)]
[turbofan] Don't lower to NumberModulus unless the inputs are numbers.
The IC for modulus is usually way faster than converting the inputs to
numbers and doing a Float64Mod on them.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1170433002
Cr-Commit-Position: refs/heads/master@{#28787}
bmeurer [Wed, 3 Jun 2015 11:23:06 +0000 (04:23 -0700)]
[x64] Smi zero can be used as an immediate.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1150853009
Cr-Commit-Position: refs/heads/master@{#28786}
ulan [Wed, 3 Jun 2015 11:07:24 +0000 (04:07 -0700)]
Add ARM64 suppport to grokdump.py
Constants are taken from chromium/src/google_breakpad/common/minidump_cpu_arm64.h
BUG=
Review URL: https://codereview.chromium.org/
1149293005
Cr-Commit-Position: refs/heads/master@{#28785}
mstarzinger [Wed, 3 Jun 2015 10:46:58 +0000 (03:46 -0700)]
[turbofan] Make the verifier a little bit more cooperative.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
1155723005
Cr-Commit-Position: refs/heads/master@{#28784}
jochen [Wed, 3 Jun 2015 10:27:46 +0000 (03:27 -0700)]
Remove usage of to-be-deprecated APIs from v8 core
Also turn on the macro to disable to-be-deprecated APIs for core
BUG=v8:4134
R=vogelheim@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1162363005
Cr-Commit-Position: refs/heads/master@{#28783}
bmeurer [Wed, 3 Jun 2015 08:31:15 +0000 (01:31 -0700)]
[date] Refactor the %_DateField intrinsic to be optimizable.
Previously the %_DateField intrinsic would also check the object and
throw an exception if you happen to pass something that is not a valid
JSDate, which (a) violates our policy for instrinsics and (b) is hard to
optimize in TurboFan (even Crankshaft has a hard time, but there we will
never inline the relevant builtins, so it doesn't show up). The throwing
part is now a separate intrinsics %_ThrowIfNotADate that throws an
exception in full codegen and deoptimizes in Crankshaft, which means the
code for the current use cases is roughly the same (modulo some register
renamings/gap moves).
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
1167813003
Cr-Commit-Position: refs/heads/master@{#28782}
hpayer [Wed, 3 Jun 2015 08:14:47 +0000 (01:14 -0700)]
VisitObject should use MarkObject.
BUG=
Review URL: https://codereview.chromium.org/
1151993005
Cr-Commit-Position: refs/heads/master@{#28781}
jochen [Wed, 3 Jun 2015 07:41:28 +0000 (00:41 -0700)]
Also allocate small typed arrays on heap when initialized from an array-like
This means something like new Float32Array([23, 42]) will be allocated on heap.
BUG=v8:3996
R=bmeurer@chromium.org,mstarzinger@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
1144393003
Cr-Commit-Position: refs/heads/master@{#28780}
michael_dawson [Wed, 3 Jun 2015 07:23:15 +0000 (00:23 -0700)]
AIX: fix another may be uninitialized failure
fix two additional cases in heap.cc where the AIX
compiler is now reporting that a variable may be
uninitialized.
R=svenpanne@chromium.org, mbrandy@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1157053007
Cr-Commit-Position: refs/heads/master@{#28779}
sejunho [Wed, 3 Jun 2015 07:09:21 +0000 (00:09 -0700)]
Just clear semi-space mark bits once before Scavenge
Both PrepareForScavenge and ResetAllocationInfo clear semi-space mark bits before Scavenge. Doing this once is good enough.
BUG=
Review URL: https://codereview.chromium.org/
1158623003
Cr-Commit-Position: refs/heads/master@{#28778}
bmeurer [Wed, 3 Jun 2015 05:29:30 +0000 (22:29 -0700)]
Revert of Implement %TypedArray%.prototype.{reduce,reduceRight} (patchset #3 id:40001 of https://codereview.chromium.org/
1154423014/)
Reason for revert:
Breaks Win32 mjsunit/harmony/typedarray-reduce, see http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/7121/steps/Check/logs/typedarray-reduce for details.
Original issue's description:
> Implement %TypedArray%.prototype.{reduce,reduceRight}
>
> This patch implements the last two methods on TypedArrays. These
> were previously committed and led to a test failure.
>
> BUG=v8:3578
> LOG=Y
> R=adamk
>
> Committed: https://crrev.com/
95d779ecc9816ac20c1565bebeeac6a1ef29f1c7
> Cr-Commit-Position: refs/heads/master@{#28773}
TBR=adamk@chromium.org,dehrenberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3578
Review URL: https://codereview.chromium.org/
1162043008
Cr-Commit-Position: refs/heads/master@{#28777}
bmeurer [Wed, 3 Jun 2015 05:10:44 +0000 (22:10 -0700)]
[turbofan] Use reference equal to zero instead of a smi check.
In typed lowering we can use the ReferenceEqual simplified operator
instead of ObjectIsSmi to check for context extensions. This generates
the desired code.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1163963003
Cr-Commit-Position: refs/heads/master@{#28776}
mstarzinger [Wed, 3 Jun 2015 05:03:57 +0000 (22:03 -0700)]
[turbofan] Ship TF for computed property names.
R=bmeurer@chromium.org
BUG=v8:4158
LOG=N
Review URL: https://codereview.chromium.org/
1162353002
Cr-Commit-Position: refs/heads/master@{#28775}
v8-autoroll [Wed, 3 Jun 2015 05:02:49 +0000 (22:02 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
12a1473d6de70775c77726b62aed18bfd56818c1
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1166643004
Cr-Commit-Position: refs/heads/master@{#28774}
dehrenberg [Wed, 3 Jun 2015 05:01:31 +0000 (22:01 -0700)]
Implement %TypedArray%.prototype.{reduce,reduceRight}
This patch implements the last two methods on TypedArrays. These
were previously committed and led to a test failure.
BUG=v8:3578
LOG=Y
R=adamk
Review URL: https://codereview.chromium.org/
1154423014
Cr-Commit-Position: refs/heads/master@{#28773}
bmeurer [Wed, 3 Jun 2015 03:02:26 +0000 (20:02 -0700)]
Revert of Embedded constant pools. (patchset #12 id:220001 of https://codereview.chromium.org/
1131783003/)
Reason for revert:
Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP..
Original issue's description:
> Add support for Embedded Constant Pools for PPC and Arm
>
> Embed constant pools within their corresponding Code
> objects.
>
> This removes support for out-of-line constant pools in favor
> of the new approach -- the main advantage being that it
> eliminates the need to allocate and manage separate constant
> pool array objects.
>
> Currently supported on PPC and ARM. Enabled by default on
> PPC only.
>
> This yields a 6% improvment in Octane on PPC64.
>
> R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
> BUG=chromium:478811
> LOG=Y
>
> Committed: https://crrev.com/
a9404029343d65f146e3443f5280c40a97e736af
> Cr-Commit-Position: refs/heads/master@{#28770}
TBR=rmcilroy@chromium.org,ishell@chromium.org,rodolph.perfetta@arm.com,mbrandy@us.ibm.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:478811
Review URL: https://codereview.chromium.org/
1155703006
Cr-Commit-Position: refs/heads/master@{#28772}
bbudge [Tue, 2 Jun 2015 22:56:00 +0000 (15:56 -0700)]
Add SIMD 128 alignment support to Heap.
Adds SIMD 128 alignment sizes and masks.
Adds support in Heap for SIMD alignments and fills.
Reworks cctest so that each test independently aligns its allocation address, rather than depending on the previous tests ending state. Adds test cases for SIMD.
LOG=N
BUG=v8:4124
Committed: https://crrev.com/
4347d56a6919ae06a70e4a4a8b2f1179cf47bc7e
Cr-Commit-Position: refs/heads/master@{#28767}
Review URL: https://codereview.chromium.org/
1159453004
Cr-Commit-Position: refs/heads/master@{#28771}
mbrandy [Tue, 2 Jun 2015 22:50:00 +0000 (15:50 -0700)]
Add support for Embedded Constant Pools for PPC and Arm
Embed constant pools within their corresponding Code
objects.
This removes support for out-of-line constant pools in favor
of the new approach -- the main advantage being that it
eliminates the need to allocate and manage separate constant
pool array objects.
Currently supported on PPC and ARM. Enabled by default on
PPC only.
This yields a 6% improvment in Octane on PPC64.
R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=chromium:478811
LOG=Y
Review URL: https://codereview.chromium.org/
1131783003
Cr-Commit-Position: refs/heads/master@{#28770}
arv [Tue, 2 Jun 2015 22:04:25 +0000 (15:04 -0700)]
[es6] Super call in arrows and eval
This splits the SuperReference AST node into SuperPropertyReference and
SuperCallReference. The super call reference node consists of three
unresolved vars to this, new.target and this_function. These gets
declared when the right function is entered and if it is in use. The
variables gets assigned in FullCodeGenerator::Generate.
This is a revert of the revert
88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8
BUG=v8:3768
LOG=N
R=wingo@igalia.com, adamk@chromium.org
Review URL: https://codereview.chromium.org/
1168513004
Cr-Commit-Position: refs/heads/master@{#28769}
bbudge [Tue, 2 Jun 2015 21:13:14 +0000 (14:13 -0700)]
Revert of Add SIMD 128 alignment support to Heap. (patchset #3 id:40001 of https://codereview.chromium.org/
1159453004/)
Reason for revert:
Breaks Linux - arm64 - sim - MSAN
TBR=jochen
Original issue's description:
> Add SIMD 128 alignment support to Heap.
> Adds SIMD 128 alignment sizes and masks.
> Adds support in Heap for SIMD alignments and fills.
> Reworks cctest so that each test independently aligns its allocation address, rather than depending on the previous tests ending state. Adds test cases for SIMD.
>
> LOG=N
> BUG=v8:4124
TBR=hpayer@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4124
Review URL: https://codereview.chromium.org/
1169453003
Cr-Commit-Position: refs/heads/master@{#28768}
bbudge [Tue, 2 Jun 2015 20:40:17 +0000 (13:40 -0700)]
Add SIMD 128 alignment support to Heap.
Adds SIMD 128 alignment sizes and masks.
Adds support in Heap for SIMD alignments and fills.
Reworks cctest so that each test independently aligns its allocation address, rather than depending on the previous tests ending state. Adds test cases for SIMD.
LOG=N
BUG=v8:4124
Review URL: https://codereview.chromium.org/
1159453004
Cr-Commit-Position: refs/heads/master@{#28767}
dehrenberg [Tue, 2 Jun 2015 18:58:12 +0000 (11:58 -0700)]
Implement %TypedArray%.prototype.{toString,toLocaleString,join}
Implementations factored out from Array. Tests are derived from
normal array toString tests.
BUG=v8:3578
LOG=Y
R=adamk
Review URL: https://codereview.chromium.org/
1166623004
Cr-Commit-Position: refs/heads/master@{#28766}
mbrandy [Tue, 2 Jun 2015 17:36:49 +0000 (10:36 -0700)]
PPC: Refine '[strong] create strong array literals'
R=dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1156823003
Cr-Commit-Position: refs/heads/master@{#28765}
mbrandy [Tue, 2 Jun 2015 17:35:22 +0000 (10:35 -0700)]
PPC: Build ObjectLiteral constant properties in the numbering phase.
Port
450002f3a105d4bb17fd3b1a9d9d54464c01d200
Original commit message:
It's necessary to do this in order to know how many type feedback vector slots
we should allocate for the object literal.
R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1166473004
Cr-Commit-Position: refs/heads/master@{#28764}
titzer [Tue, 2 Jun 2015 15:00:55 +0000 (08:00 -0700)]
[test] Refactor call-tester to use c-signature.h.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1146173005
Cr-Commit-Position: refs/heads/master@{#28763}
verwaest [Tue, 2 Jun 2015 11:52:30 +0000 (04:52 -0700)]
Handle Delete of element with LookupIterator
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/
1157093003
Cr-Commit-Position: refs/heads/master@{#28762}
mstarzinger [Tue, 2 Jun 2015 11:47:13 +0000 (04:47 -0700)]
[turbofan] Ship TF for class literals.
R=bmeurer@chromium.org
BUG=v8:4158
LOG=N
Review URL: https://codereview.chromium.org/
1158883006
Cr-Commit-Position: refs/heads/master@{#28761}
conradw [Tue, 2 Jun 2015 11:46:04 +0000 (04:46 -0700)]
[strong] create strong array literals
Copied, with permission, from https://codereview.chromium.org/
1151853003/
Initial patch set is an unmodified copy, rebased on top of related fixes from
https://codereview.chromium.org/
1158933002/
Subsequent patch sets contain fixes for remaining bugs in the CL.
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/
1152093003
Cr-Commit-Position: refs/heads/master@{#28760}
ishell [Tue, 2 Jun 2015 11:29:22 +0000 (04:29 -0700)]
Mark proxy map as unstable during proxy fixing (freezing, sealing or preventing extensions).
BUG=chromium:493568
LOG=N
Review URL: https://codereview.chromium.org/
1158023003
Cr-Commit-Position: refs/heads/master@{#28759}
verwaest [Tue, 2 Jun 2015 11:24:52 +0000 (04:24 -0700)]
Remove Execution::CharAt
BUG=
Review URL: https://codereview.chromium.org/
1143153004
Cr-Commit-Position: refs/heads/master@{#28758}
verwaest [Tue, 2 Jun 2015 11:10:50 +0000 (04:10 -0700)]
Use LookupIterator for GetElementAttributes and friends
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/
1153583006
Cr-Commit-Position: refs/heads/master@{#28757}
ishell [Tue, 2 Jun 2015 11:00:45 +0000 (04:00 -0700)]
Filter out store/slots buffer entries that point into raw data objects.
This is just a workaround till we found the root cause of the issue, there must be no slots for data object recorded.
BUG=chromium:454297
LOG=N
Review URL: https://codereview.chromium.org/
1106983004
Cr-Commit-Position: refs/heads/master@{#28756}
martyn.capewell [Tue, 2 Jun 2015 10:57:40 +0000 (03:57 -0700)]
[arm64] Use ubfiz in ARM64 instruction selector
Select ubfiz for (x & mask) << imm where mask is contiguous and imm is non-zero.
BUG=
Review URL: https://codereview.chromium.org/
1161643003
Cr-Commit-Position: refs/heads/master@{#28755}
verwaest [Tue, 2 Jun 2015 10:42:16 +0000 (03:42 -0700)]
Use GetProperty for getting elements.
This also fixes issues with
- kMaxUint32 being a valid length but not index cornercases
- exotic integer objects masking "exotic indexes" even though its in the prototype chain
- concating of holey sloppy arguments
BUG=v8:4137
LOG=n
Review URL: https://codereview.chromium.org/
1159433003
Cr-Commit-Position: refs/heads/master@{#28754}
mstarzinger [Tue, 2 Jun 2015 10:36:21 +0000 (03:36 -0700)]
[turbofan] Ship TF for dynamic lookup slots.
R=bmeurer@chromium.org
BUG=v8:4131
LOG=N
Review URL: https://codereview.chromium.org/
1152173011
Cr-Commit-Position: refs/heads/master@{#28753}
ishell [Tue, 2 Jun 2015 10:29:12 +0000 (03:29 -0700)]
GlobalDictionary now stores PropertyDetails in PropertyCells.
BUG=
Review URL: https://codereview.chromium.org/
1156993018
Cr-Commit-Position: refs/heads/master@{#28752}
rossberg [Tue, 2 Jun 2015 10:15:06 +0000 (03:15 -0700)]
Fix redundant map allocation
R=bmeurer@chromium.org
BUG=chromium:492022,v8:3956
LOG=N
Review URL: https://codereview.chromium.org/
1159623008
Cr-Commit-Position: refs/heads/master@{#28751}
mstarzinger [Tue, 2 Jun 2015 09:37:49 +0000 (02:37 -0700)]
[turbofan] Optimized lowering of DYNAMIC_GLOBAL lookup slot loads.
This adds handling of JSLoadDynamicGlobal nodes to JSTypedLowering to
perform extension checks and an inline fast path. The fast path is a
global variable load from the global object.
R=bmeurer@chromium.org
BUG=v8:4131
LOG=N
Review URL: https://codereview.chromium.org/
1150723005
Cr-Commit-Position: refs/heads/master@{#28750}
mvstanton [Tue, 2 Jun 2015 09:35:21 +0000 (02:35 -0700)]
Build ObjectLiteral constant properties in the numbering phase.
It's necessary to do this in order to know how many type feedback vector slots
we should allocate for the object literal.
BUG=
Review URL: https://codereview.chromium.org/
1165463007
Cr-Commit-Position: refs/heads/master@{#28749}
chunyang.dai [Tue, 2 Jun 2015 09:07:13 +0000 (02:07 -0700)]
X87: [turbofan] First step towards sanitizing for-in and making it optimizable.
port
e2e47f30be06e6ea6b8a3cc90138381914ecd07d (r28711)
original commit message:
[turbofan] First step towards sanitizing for-in and making it optimizable.
In a nutshell: The FILTER_KEY builtin is gone, and was replaced by a
simple runtime call to ForInFilter, which does everything and is even
cheaper (because FILTER_KEY used to call into the runtime anyway).
And ForInFilter returns either the name or undefined, which makes it
possible to remove the control flow construction from the AstGraphBuilder,
and thereby make both the initialization and the per-loop code of for-in
optimizable later (in typed lowering).
BUG=
Review URL: https://codereview.chromium.org/
1144143005
Cr-Commit-Position: refs/heads/master@{#28748}
bmeurer [Tue, 2 Jun 2015 08:50:46 +0000 (01:50 -0700)]
[turbofan] Enable typed lowering of string addition.
Unfortunately StringAdd is not pure in V8 because we might throw an
exception if the resulting string length is outside the valid bounds, so
there's no point in having a simplified StringAdd operator.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1164743002
Cr-Commit-Position: refs/heads/master@{#28747}
bmeurer [Tue, 2 Jun 2015 06:18:23 +0000 (23:18 -0700)]
[turbofan] Specify better type for FixedArray::length field.
This avoids redundant smi checks when using the length of a FixedArray,
which is always a positve smi.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1162163003
Cr-Commit-Position: refs/heads/master@{#28746}
v8-autoroll [Tue, 2 Jun 2015 04:07:28 +0000 (21:07 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
dc542e2b87607a399e0c107b78990aba11f5af48
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1143213004
Cr-Commit-Position: refs/heads/master@{#28745}
arv [Mon, 1 Jun 2015 23:40:46 +0000 (16:40 -0700)]
[es6] Stage array spread
BUG=v8:3018
LOG=N
Review URL: https://codereview.chromium.org/
1165653003
Cr-Commit-Position: refs/heads/master@{#28744}
adamk [Mon, 1 Jun 2015 23:16:27 +0000 (16:16 -0700)]
Fix Map/Set creation via the API with nosnap build
The Map and Set maps get overwritten when collection.js executes, so in
a nosnap build we have to wait until it runs before we grab the maps.
To facilitate that, store the functions in the native context as well.
Review URL: https://codereview.chromium.org/
1161363002
Cr-Commit-Position: refs/heads/master@{#28743}
erikcorry [Mon, 1 Jun 2015 22:46:54 +0000 (15:46 -0700)]
Cosmetic changes to tests to make it easier to concatenate them.
When compiling on a laptop I like to concatenate the small test files.
This makes a big difference to compile times. These changes make that
easier.
R=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1163803002
Cr-Commit-Position: refs/heads/master@{#28742}
conradw [Mon, 1 Jun 2015 22:43:50 +0000 (15:43 -0700)]
[strong] fix strong object exception messages
A mistake in a recent CL has messed up the error messages for strong object
semantics.
BUG=
LOG=N
Review URL: https://codereview.chromium.org/
1166433007
Cr-Commit-Position: refs/heads/master@{#28741}
caitpotter88 [Mon, 1 Jun 2015 18:34:55 +0000 (11:34 -0700)]
Revert of [es6] implement default parameters via desugaring (patchset #19 id:380001 of https://codereview.chromium.org/
1127063003/)
Reason for revert:
Broken on arm64
Original issue's description:
> [es6] implement default parameters via desugaring
>
> Stage 1 implementation:
>
> - Parameters can't be referenced before initialized (from left-to-right)
> - SingleNameBindings only, no support for BindingPatterns
>
> Known issues:
>
> - Incorrect scoping (parameter expressions may reference variables declared in function body)
> - Function arity is untouched
> - Hole-checking needs work
> - Rest parameters are broken when mixed with optional arguments
>
> BUG=v8:2160
> LOG=N
> R=arv@chromium.org, rossberg@chromium.org
>
> Committed: https://crrev.com/
892c85485881f8be2f17bd83238980f858126576
> Cr-Commit-Position: refs/heads/master@{#28739}
TBR=rossberg@chromium.org,wingo@igalia.com,arv@chromium.org,dslomov@chromium.org,adamk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:2160
Review URL: https://codereview.chromium.org/
1163853002
Cr-Commit-Position: refs/heads/master@{#28740}
caitpotter88 [Mon, 1 Jun 2015 17:10:39 +0000 (10:10 -0700)]
[es6] implement default parameters via desugaring
Stage 1 implementation:
- Parameters can't be referenced before initialized (from left-to-right)
- SingleNameBindings only, no support for BindingPatterns
Known issues:
- Incorrect scoping (parameter expressions may reference variables declared in function body)
- Function arity is untouched
- Hole-checking needs work
- Rest parameters are broken when mixed with optional arguments
BUG=v8:2160
LOG=N
R=arv@chromium.org, rossberg@chromium.org
Review URL: https://codereview.chromium.org/
1127063003
Cr-Commit-Position: refs/heads/master@{#28739}
ishell [Mon, 1 Jun 2015 17:07:25 +0000 (10:07 -0700)]
Enum DictionaryEntryType removed.
Dictionary customization should be implemented in respective shape class.
Review URL: https://codereview.chromium.org/
1160813009
Cr-Commit-Position: refs/heads/master@{#28738}