Matthew Leibowitz [Thu, 19 Jan 2017 01:10:44 +0000 (03:10 +0200)]
Added C binding for the 3DView
Matthew Leibowitz [Tue, 17 Jan 2017 19:29:19 +0000 (21:29 +0200)]
Added support for PDF metadata
Matthew Leibowitz [Tue, 17 Jan 2017 00:48:49 +0000 (02:48 +0200)]
Add canvas annotations
Matthew Leibowitz [Mon, 16 Jan 2017 12:08:07 +0000 (14:08 +0200)]
Merge branch 'xamarin-svg-canvas' into xamarin-mobile-bindings
# Conflicts:
# gyp/core.gyp
# gyp/core.gypi
# include/c/sk_types.h
# src/c/sk_types_priv.h
Matthew Leibowitz [Sat, 14 Jan 2017 19:05:34 +0000 (21:05 +0200)]
Copy the array contents to avoid warnings when using std::copy
Matthew Leibowitz [Sat, 14 Jan 2017 18:59:14 +0000 (20:59 +0200)]
Fixes for the return types
- the C API can't handle returning structs on some platforms
Matthew Leibowitz [Fri, 13 Jan 2017 06:42:55 +0000 (08:42 +0200)]
Merge pull request #44 from google/chrome/m56
M56 cherrypick Fix mapping from src to in SkAlphaThresholdFilter
Robert Phillips [Wed, 11 Jan 2017 15:30:08 +0000 (10:30 -0500)]
M56 cherrypick Fix mapping from src to in SkAlphaThresholdFilter
This cherrypicks https://skia-review.googlesource.com/c/6291/ (Fix mapping from src to dst image space in SkAlphaThresholdFilter) to M56
BUG=675332
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=6880
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Change-Id: Id225b462eb91e3d766804392c6986415ad531808
Reviewed-on: https://skia-review.googlesource.com/6880
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Matthew Leibowitz [Sat, 7 Jan 2017 01:33:31 +0000 (03:33 +0200)]
Added the C API for SkBitmapScaler::Resize
Matthew Leibowitz [Fri, 6 Jan 2017 23:38:45 +0000 (01:38 +0200)]
Added C bindings for SkPixmap
Matthew Leibowitz [Fri, 6 Jan 2017 21:29:51 +0000 (23:29 +0200)]
Merge pull request #42 from mono/develop-next
All the bits for m56
Matthew Leibowitz [Thu, 5 Jan 2017 22:06:48 +0000 (00:06 +0200)]
Disable the C4244: conversion from 'int' to 'SkScalar' warnings
Matthew Leibowitz [Thu, 5 Jan 2017 21:34:12 +0000 (23:34 +0200)]
Merge pull request #41 from google/chrome/m56
Chrome/m56
Brian Salomon [Thu, 22 Dec 2016 14:39:40 +0000 (09:39 -0500)]
Fix SDF generation for pixel-aligned paths (take two)
Cherry-pick to M56
BUG=668550
Change-Id: Ic771818bd5a4a46b83fdb82b69b98cb6b93a23a2
Reviewed-on: https://skia-review.googlesource.com/5697
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-on: https://skia-review.googlesource.com/6413
Brian Salomon [Thu, 22 Dec 2016 14:26:29 +0000 (09:26 -0500)]
Make flag values in GrResourceProvider and GrTextureProvider consistent
Cherry pick to M56
BUG=chromium:665673
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5602
Change-Id: I41522aa24cd4b4a7e085132dd9bcbfdd66bd9617
Reviewed-on: https://skia-review.googlesource.com/5602
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-on: https://skia-review.googlesource.com/6411
Reviewed-by: Brian Salomon <bsalomon@google.com>
Brian Salomon [Thu, 22 Dec 2016 14:16:57 +0000 (09:16 -0500)]
Add an extra pixel to the distance field path renderer bounds.
Cherry-pick to M56
BUG=chromium:663701
BUG=skia:5989
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5086
Change-Id: Ie97f46b108f54c711c5928b11a9921be38356f8d
Reviewed-on: https://skia-review.googlesource.com/5086
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cherry-pick to M55
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Change-Id: I3f8e5de782846447c6f809c3284c5081b5d7a283
Reviewed-on: https://skia-review.googlesource.com/5267
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-on: https://skia-review.googlesource.com/6412
Matthew Leibowitz [Mon, 19 Dec 2016 22:34:49 +0000 (00:34 +0200)]
Merge pull request #40 from google/chrome/m56
Chrome/m56
msarett [Tue, 29 Nov 2016 21:22:01 +0000 (13:22 -0800)]
Fuzzer fix for overflow in some Lut8 profiles.
Bug(?) in the tetrahedral interpolation causes output values to go out
of range a bit (1.035/1.0) in the upper range. We will just clamp for
now as a temporary fix.
BUG=668784
Change-Id: I78dd90da7174133e647b1c6c6e914dbde5de123c
Reviewed-on: https://skia-review.googlesource.com/5228
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Robert Aftias <raftias@google.com>
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2535383002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2535383002
Robert Phillips [Mon, 21 Nov 2016 14:03:54 +0000 (09:03 -0500)]
Cherry pick fuzzer fixes back to M56
This cherry-pick combines 3 fuzzer-fix CLs:
These two rolled into Chrome in https://codereview.chromium.org/
2511733006 at 433297 on 11/18
https://skia-review.googlesource.com/c/4961/ (Remove accessRenderTarget call in SkGpuDevice ctor)
https://skia-review.googlesource.com/c/4929/ (Guard against instantiate & accessRenderTarget failures)
This one rolled into Chrome in https://codereview.chromium.org/
2516183002 at 433454 on 11/20
https://skia-review.googlesource.com/c/4991/ (Add handling for instantiate failure up the call stack)
Together they address the fuzzer bugs:
crbug.com/665681 P1 (Crash in SkSpecialImage_Gpu::onAsTextureRef)
crbug.com/665621 P1 (Crash in GrGpuCommandBuffer::draw)
crbug.com/665500 P1 (Crash in GrDrawBatch::renderTargetUniqueID)
The fuzzer bugs were fixed by the first two patches but the third is going to be necessary too.
BUG=665681,665500,665621
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5081
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Change-Id: I3a8b70eae29ac11608e062e66bc26c2208c1dfb3
Reviewed-on: https://skia-review.googlesource.com/5081
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Matthew Leibowitz [Sat, 26 Nov 2016 06:23:00 +0000 (08:23 +0200)]
Added the members for decoding gif frames
Matthew Leibowitz [Fri, 25 Nov 2016 15:52:43 +0000 (17:52 +0200)]
Corrected the method header
Matthew Leibowitz [Fri, 25 Nov 2016 08:54:38 +0000 (10:54 +0200)]
Added SkCodec::getEngodedInfo to the C API
raftias [Mon, 21 Nov 2016 17:59:36 +0000 (12:59 -0500)]
Fixed issue with some A2B0 images being too dark
The issue was with the A2B0 matrix not being scaled by its encoding
factor when it needed to be (for A2B0 matrices only).
NOTRY=true
NOTREECHECKS=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5003
Change-Id: I3f202323e137e1b014e564bd96d87c601c4748ab
Reviewed-on: https://skia-review.googlesource.com/5003
Commit-Queue: Robert Aftias <raftias@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-on: https://skia-review.googlesource.com/5110
Matthew Leibowitz [Tue, 22 Nov 2016 09:24:05 +0000 (11:24 +0200)]
Added the C API for SkShadowMaskFilter
Matthew Leibowitz [Sat, 19 Nov 2016 04:21:03 +0000 (06:21 +0200)]
Enable the SSSE3 Xcode flag when building that project
Matthew Leibowitz [Fri, 18 Nov 2016 14:46:52 +0000 (16:46 +0200)]
Ignore a few warnings with MS VS
Matthew Leibowitz [Fri, 18 Nov 2016 03:15:09 +0000 (05:15 +0200)]
A few small changes made to types used
Matthew Leibowitz [Fri, 18 Nov 2016 02:31:42 +0000 (04:31 +0200)]
Seems git couldn't care about merging these files
Matthew Leibowitz [Fri, 18 Nov 2016 02:17:14 +0000 (04:17 +0200)]
Merge branch 'chrome/m56' into update-m56
- there is something wrong since there are missing files...
Matthew Leibowitz [Thu, 17 Nov 2016 19:59:39 +0000 (21:59 +0200)]
Merge pull request #36 from Tylerflick/xamarin-mobile-bindings
Add SkColorTable setting support to C API
Matthew Leibowitz [Thu, 17 Nov 2016 19:35:20 +0000 (21:35 +0200)]
Added a few more members to the C API
Heather Miller [Thu, 17 Nov 2016 19:03:42 +0000 (14:03 -0500)]
Fix milestone version number on branch
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4966
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Change-Id: I6a78060979066f839958c0e57d0898af6dcd7414
Reviewed-on: https://skia-review.googlesource.com/4966
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Eric Boren [Wed, 16 Nov 2016 20:55:06 +0000 (15:55 -0500)]
[nobuildbot] More Android bots
- GalaxyS7
- NVIDIA_Shield
- Nexus10
- Nexus7
- Nexus9
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4915
Change-Id: Ie4fb27085fe154ddf15de4774de9932cde28e842
Reviewed-on: https://skia-review.googlesource.com/4915
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Matthew Leibowitz [Thu, 17 Nov 2016 02:33:31 +0000 (04:33 +0200)]
Added C API support for incremental codec decodes
Mike Klein [Wed, 16 Nov 2016 21:00:46 +0000 (16:00 -0500)]
Don't build :public_headers_warnings_check on NoGPU builds.
skia.h includes GPU headers. No real point in getting fancy here... if there are no unused parameters in all headers, there are no unused parameters in the subset of non-GPU headers.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4916
Change-Id: Iaaea405633aabcc82e40cd4b1a2286aadd5cea17
Reviewed-on: https://skia-review.googlesource.com/4916
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Herb Derby [Wed, 16 Nov 2016 21:23:24 +0000 (16:23 -0500)]
Use SkSmallAllocator for SamplerStage and Accessor.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4917
Change-Id: Id67d7c1cefa2aadfc706c56dd02d086120f99be3
Reviewed-on: https://skia-review.googlesource.com/4917
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Matt Sarett [Wed, 16 Nov 2016 21:07:15 +0000 (16:07 -0500)]
Hook into parametric and table raster pipeline stages
BUG:664864
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4913
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: I909152f1abba60803f0ce2f970eec1f8f1816d78
Reviewed-on: https://skia-review.googlesource.com/4913
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Yuqian Li [Wed, 16 Nov 2016 20:34:59 +0000 (15:34 -0500)]
Turn off all SkDebugfs in SkScan_AAAPath.cpp
TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4912
Change-Id: Ia69f2932936e34bc487c9c468bba176de0b2b0df
Reviewed-on: https://skia-review.googlesource.com/4912
Reviewed-by: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Yuqian Li [Wed, 16 Nov 2016 20:31:27 +0000 (15:31 -0500)]
No SkDebugf for approximate intersection
TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4911
Change-Id: I23bc298186f93c1a97a15d00b34f65cd72f964e7
Reviewed-on: https://skia-review.googlesource.com/4911
Reviewed-by: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Reed [Wed, 16 Nov 2016 20:54:31 +0000 (15:54 -0500)]
remove CANVAS_IS_REFCNT flag from public.bzl
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4914
Change-Id: I3ea6c2b96dd79da9ebba659726cbab52bda21651
Reviewed-on: https://skia-review.googlesource.com/4914
Reviewed-by: Mike Reed <reed@google.com>
Florin Malita [Wed, 16 Nov 2016 19:45:34 +0000 (14:45 -0500)]
External SkImageGenerator API
Introduce an SkImageGenerator API to support the implementation of
externally-managed image decode and scale caches.
BUG=skia:5806
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4720
Change-Id: Ibfe37af5471f78f28f88f9d5e80938882be1a344
Reviewed-on: https://skia-review.googlesource.com/4720
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Kevin Lubick [Wed, 16 Nov 2016 19:07:17 +0000 (14:07 -0500)]
Add vulkan build to skpbench.
This also fixes the name of the tasks because skpbench is always GPU.
There was a config for monitoring the gpu clock instead of the cpu clock,
but this was removed because the gpu clock isn't very useful at the moment.
cpu clock is basically wall-time, i.e. an accurate measurement of the
entire test.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4873
Change-Id: If1c7dd3141e24f79555ee7b3756f09618df54cb4
Reviewed-on: https://skia-review.googlesource.com/4873
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
csmartdalton [Wed, 16 Nov 2016 18:28:16 +0000 (11:28 -0700)]
Rename GrTextureBufferSampler to GrBufferSampler
Just a simple renaming to reinforce the Ganesh notion that a buffer
access is not related to a texture.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4879
Change-Id: I3f12b6eccff744e246618be0a7abf41c4a1228a1
Reviewed-on: https://skia-review.googlesource.com/4879
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Brian Salomon [Wed, 16 Nov 2016 17:06:01 +0000 (12:06 -0500)]
Revert "Revert "Add support for image load to SkSL""
This reverts commit
cb115bdeed5898ded3fdbe572a14616cff809b7c.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4900
Change-Id: Ibcb381bae83d0cfc1a1226be90792061d401426a
Reviewed-on: https://skia-review.googlesource.com/4900
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Mike Klein [Wed, 16 Nov 2016 17:13:44 +0000 (12:13 -0500)]
GN: add public headers warnings check.
We already generate skia.h to include all public headers for Fiddle.
This just includes it with -Wunused-parameter turned on as an error.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4901
Change-Id: Ia55a901c09a3c9c9d6d35a43259431dba3532ed9
Reviewed-on: https://skia-review.googlesource.com/4901
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Brian Salomon [Wed, 16 Nov 2016 17:55:57 +0000 (12:55 -0500)]
Rename kTexture2DISampler to kITexture2DSampler.
Also remove unused kGrSLTypeCount.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4903
Change-Id: I7f934c56515424b2668886dec2f16296a1256e2c
Reviewed-on: https://skia-review.googlesource.com/4903
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Mike Klein [Wed, 16 Nov 2016 18:38:15 +0000 (13:38 -0500)]
Add trace and registers stages.
Yet more debugging tools.
TBR=herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4908
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: I92e2e6b17abfc32c8d3554e71dbf95abadbb3824
Reviewed-on: https://skia-review.googlesource.com/4908
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Herb Derby [Wed, 16 Nov 2016 18:26:42 +0000 (13:26 -0500)]
Use SkSmallAllocator for tiling.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4904
Change-Id: If401ea43454b46591d6f39492e7761b16a7e7a29
Reviewed-on: https://skia-review.googlesource.com/4904
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Reed [Wed, 16 Nov 2016 18:13:16 +0000 (13:13 -0500)]
move SkBlendMode_Name into public (for chrome)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4905
Change-Id: I4f6cbc7b4d2a9d41ba5da39d550961587f30a4ac
Reviewed-on: https://skia-review.googlesource.com/4905
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Kevin Lubick [Tue, 15 Nov 2016 21:07:02 +0000 (16:07 -0500)]
Add back in min/max check on fuzzer range
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4798
Change-Id: Ia93b4eeea82dd04f0c6bd287f61d26086a0aa740
Reviewed-on: https://skia-review.googlesource.com/4798
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
robertphillips [Wed, 16 Nov 2016 19:17:17 +0000 (11:17 -0800)]
Add IORef capability to GrSurfaceProxy objects - take 2
Re-landing of https://skia-review.googlesource.com/c/4734/ (Add IORef capability to GrSurfaceProxy objects) with fixes for:
platforms that don't support discards.
memory leak due to copying over of GrSurfaceProxy's creation ref to instantiated GrSurface in instantiate()
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4827
BUG=skia:
Change-Id: If0b695d5cafc5ef3fdd251c38262849d09e5d27f
Review-Url: https://codereview.chromium.org/
2502923003
Yuqian Li [Wed, 16 Nov 2016 18:07:57 +0000 (13:07 -0500)]
Fix mask overflow caused by edge drift
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4797
Change-Id: Ica1568b67c1e1ce4aae2bdaba2c5b1f2155d1382
Reviewed-on: https://skia-review.googlesource.com/4797
Reviewed-by: Cary Clark <caryclark@google.com>
Yuqian Li [Wed, 16 Nov 2016 16:54:48 +0000 (11:54 -0500)]
Drop forceRLE to simplify aaa_walk_convex_edges
The virtual flush function doesn't seem to affect the performance much.
Maybe there's a 1% drop in performance in nanobench against
fill_big_triangle and fill_big_circle, but that's too small a change for
nanobench to reliabily diffrentiate.
The smooth jump (ignore fractional y if edges don't change their
directions significantly) no longer needs to be guarded against SkAAClip
because our recent CL (https://skia-review.googlesource.com/c/4636/)
make left/rightBound much tighter.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4899
Change-Id: If323013b810cc1ff5f6dbb868a8981354ee6f9b5
Reviewed-on: https://skia-review.googlesource.com/4899
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
Tylerflick [Wed, 16 Nov 2016 17:33:17 +0000 (09:33 -0800)]
remove duplicate function
Eric Boren [Wed, 16 Nov 2016 15:49:52 +0000 (10:49 -0500)]
infra recipe: Add -t flag to "go test"
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4896
Change-Id: Iff66f67a28b65797446d0ba26064f00dc948bb47
Reviewed-on: https://skia-review.googlesource.com/4896
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Matthew Leibowitz [Wed, 16 Nov 2016 16:12:27 +0000 (18:12 +0200)]
Merge pull request #37 from google/chrome/m55
Compute the correct dst->src rect for bitmap tiles in SkGpuDevice
Yuqian Li [Wed, 16 Nov 2016 15:12:58 +0000 (10:12 -0500)]
Simplify the signature of sk/aaa_fill_path
Previously, the clipRect is either equal to nullptr or clipRgn's bound
(after necessary supersampling shift). Hence we drop one of them to make
the signature simpler.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4874
Change-Id: Ied8d5313809d6cf90374365b01f2b8d52f2236e2
Reviewed-on: https://skia-review.googlesource.com/4874
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Jim Van Verth [Wed, 16 Nov 2016 15:15:23 +0000 (10:15 -0500)]
Fix error with transforming custom/large glyphs
BUG=661244
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4738
Change-Id: I9f14ca830f9de92000e751a4a99ff1eb9b01db33
Reviewed-on: https://skia-review.googlesource.com/4866
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Mike Reed [Tue, 15 Nov 2016 21:44:34 +0000 (16:44 -0500)]
make SkXfermode.h go away
This is step one:
- make SkXfermode useless to public clients
- everything they should need is in SkBlendMode.h
Step two:
- remove SkXfermode.h entirely (since skia core will already be using SkXfermodePriv.h)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4534
Change-Id: If2cea9f71df92430ed6644edb98dd306c5572cbc
Reviewed-on: https://skia-review.googlesource.com/4534
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
egdaniel [Wed, 16 Nov 2016 15:29:51 +0000 (07:29 -0800)]
Revert of added support for push_constant layout (patchset #7 id:140001 of https://codereview.chromium.org/
2187433003/ )
Reason for revert:
hitting assert in vulkan
Original issue's description:
> added support for push_constant layout
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187433003
>
> Committed: https://skia.googlesource.com/skia/+/
fa5f65ac61fd525029aa9dab161ffe4896c10f6d
TBR=ethannicholas@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2509673002
Stan Iliev [Wed, 16 Nov 2016 15:25:42 +0000 (15:25 +0000)]
Revert "Add support for image load to SkSL"
This reverts commit
bd85a105ba7b3ee2008d20fb9281bfb47325ad0e.
Reason for revert: Needing to revert a dependent CL
Original change's description:
> Add support for image load to SkSL
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4865
>
> Change-Id: I4647e6b255946ced2b1b8cb05e62f0f5a8ad28b6
> Reviewed-on: https://skia-review.googlesource.com/4865
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
>
TBR=bsalomon@google.com,ethannicholas@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I45932a53c606aadd645ee2b8264f08ad63429939
Reviewed-on: https://skia-review.googlesource.com/4892
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Mike Klein [Wed, 16 Nov 2016 14:01:30 +0000 (09:01 -0500)]
add {parametric,table}_{r,g,b} stages.
Think you can take over from here, hook these into SkColorSpaceXform_A2B, and remove the need for fn_1_{r,g,b}?
BUG=skia:664864
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4888
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: If573fa2861f32f201f4db28598559290b1eef812
Reviewed-on: https://skia-review.googlesource.com/4888
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Matt Sarett <msarett@google.com>
Eric Boren [Wed, 16 Nov 2016 12:14:36 +0000 (07:14 -0500)]
[nobuildbot] Nexus 5
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4870
Change-Id: Id8bcb72926155d8754e99e5ec5b3ae2461b22e0f
Reviewed-on: https://skia-review.googlesource.com/4870
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Brian Salomon [Wed, 16 Nov 2016 00:09:52 +0000 (19:09 -0500)]
Add support for image load to SkSL
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4865
Change-Id: I4647e6b255946ced2b1b8cb05e62f0f5a8ad28b6
Reviewed-on: https://skia-review.googlesource.com/4865
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
csmartdalton [Tue, 15 Nov 2016 21:26:27 +0000 (14:26 -0700)]
Fix flushing of HWAA state relating to mixed samples
Fixes the sense of the "stencilEnabled" argument sent to
flushHWAAState.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4872
Change-Id: If7097f2819607864c95b0ffd04dc1d302fa66fdc
Reviewed-on: https://skia-review.googlesource.com/4872
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
James Zern [Thu, 10 Nov 2016 03:22:46 +0000 (19:22 -0800)]
LinearGradientContext::shade4_clamp: fix div by 0
getScaleX() may return 0; move division using it after a
SkScalarNearlyZero check and closer to its first use.
Change-Id: Ie209d46dc101213e20e90486651ee17570425bb8
Reviewed-on: https://skia-review.googlesource.com/4643
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Eric Boren [Tue, 15 Nov 2016 20:18:20 +0000 (15:18 -0500)]
[nobuildbot] RecreateSKPs
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4836
Change-Id: Idee05a4b1ea909c5dc1de2e9ebc8c2f9631c78e2
Reviewed-on: https://skia-review.googlesource.com/4836
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Tyler Hoeflicker [Tue, 15 Nov 2016 22:17:47 +0000 (14:17 -0800)]
fix duplicate signature
Robert Phillips [Tue, 15 Nov 2016 22:17:22 +0000 (22:17 +0000)]
Revert "Defer more renderTargetContexts in the GPU image filter paths"
This reverts commit
fd01ce05ef7902c49b0272b3524a389693c72b35.
Reason for revert: see if this is the cause of the Nexus7 assertion failure
Original change's description:
> Defer more renderTargetContexts in the GPU image filter paths
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4767
>
> Change-Id: I4c1f27247ef340a49d1ac96761810e77e6047ca2
> Reviewed-on: https://skia-review.googlesource.com/4767
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
>
TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I158f96ec1252481345fc5dca15086ffd4b47cb95
Reviewed-on: https://skia-review.googlesource.com/4875
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Tyler Hoeflicker [Tue, 15 Nov 2016 22:11:46 +0000 (14:11 -0800)]
fix set pixel params
herb [Tue, 15 Nov 2016 22:07:13 +0000 (14:07 -0800)]
Move the matrix stage of SkLinearBitmapPipeline over to using SkSmallAllocator.
The rest of the stages will follow. When all stages are completed,
this should significantly reduce stack use in the typical case.
This a step in removing the baroque stage system and moving towards
a SkRasterPipeline stage system.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2484273002
Review-Url: https://codereview.chromium.org/
2484273002
Mike Klein [Tue, 15 Nov 2016 21:18:38 +0000 (16:18 -0500)]
Add SkRasterPipeline::dump().
Entirely for debugging.
TBR=herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4871
Change-Id: I6d6972c40b11854441f566c12516a2ec8c75c78f
Reviewed-on: https://skia-review.googlesource.com/4871
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
ethannicholas [Tue, 15 Nov 2016 20:53:05 +0000 (12:53 -0800)]
added support for push_constant layout
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2187433003
Review-Url: https://codereview.chromium.org/
2187433003
Robert Phillips [Tue, 15 Nov 2016 19:46:09 +0000 (14:46 -0500)]
Add kRenderTarget_GrSurfaceFlag to GrVkGpu::onWrapBackendRenderTarget
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4868
Change-Id: I7f169d050c47c074cf63ef9b63fb7df8efdaed62
Reviewed-on: https://skia-review.googlesource.com/4868
Commit-Queue: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Brian Salomon [Tue, 15 Nov 2016 19:05:01 +0000 (14:05 -0500)]
Add detection of image load/store to caps
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4861
Change-Id: Ibf70cce9f61553e830b62339551c1541dc054e8b
Reviewed-on: https://skia-review.googlesource.com/4861
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Florin Malita [Tue, 15 Nov 2016 19:38:43 +0000 (14:38 -0500)]
Ignore ctm param of SkShader::onAppendStages()
Clang 3.8.0:
../../include/core/SkShader.h:513:49: error: unused parameter 'ctm' [-Werror,-Wunused-parameter]
const SkMatrix& ctm) const {
R=mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4867
Change-Id: I242180cb33ad099b28b06654934029690da195ee
Reviewed-on: https://skia-review.googlesource.com/4867
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Brian Salomon [Tue, 15 Nov 2016 17:36:29 +0000 (12:36 -0500)]
Add image functions to GrGLInterface
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4840
Change-Id: I250cc4e637765c321c90e33c9b3f25c4ad12fe04
Reviewed-on: https://skia-review.googlesource.com/4840
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Brian Salomon [Tue, 15 Nov 2016 18:26:08 +0000 (13:26 -0500)]
Add 4.20 as a GLSL output version.
GLSL 4.20 adds support for image functions which will be used in forthcoming changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4833
Change-Id: I8cab511d95f04b45faaf916628148117b8be2128
Reviewed-on: https://skia-review.googlesource.com/4833
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Cary Clark [Tue, 15 Nov 2016 18:22:25 +0000 (13:22 -0500)]
fuzz hang fix and pathops client debugging
The ASAN fuzzer on chrome caught a hanging state.
To capture the data, allow the pathops client debugging
to run in a release build.
TBR=reed@google.com
BUG=665295
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4834
Change-Id: I6b2c2baabd63994f63aa730d2ee7828986b5ab89
Reviewed-on: https://skia-review.googlesource.com/4834
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Mike Klein [Tue, 15 Nov 2016 18:20:33 +0000 (13:20 -0500)]
More shader preliminaries / refactoring
- thread through ctm
- make blitter handle paint modulation instead of each shader
TBR=herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4830
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: I8161e6b3864c4e48e4d47d5ad40a56a13c02fee8
Reviewed-on: https://skia-review.googlesource.com/4830
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
csmartdalton [Tue, 15 Nov 2016 16:57:15 +0000 (09:57 -0700)]
skpbench: fix parser script for bots
- emits the timings as numbers instead of strings.
- moves 'bench_type' and 'source_type' into the key.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4823
Change-Id: Ibf98891e21c5d4c8a794c207e60d0df78d8a063c
Reviewed-on: https://skia-review.googlesource.com/4823
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Brian Osman [Tue, 15 Nov 2016 18:07:26 +0000 (18:07 +0000)]
Revert "Support decoding images to multiple formats, depending on usage"
This reverts commit
c73a1ecbed64652b3d7aa8dc6face9a2205ce830.
Reason for revert: ANGLE and CommandBuffer failures
Original change's description:
> Support decoding images to multiple formats, depending on usage
>
> Our codec generator will now preserve any asked-for color space, and
> convert the encoded data to that representation. Cacherator now
> allows decoding an image to both legacy (nullptr color space), and
> color-correct formats. In color-correct mode, we choose the best
> decoded format, based on the original properties, and our backend's
> capabilities. Preference is given to the native format, when it's
> already texturable (sRGB 8888 or F16 linear). Otherwise, we prefer
> linear F16, and fall back to sRGB when that's not an option.
>
> BUG=skia:5907
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4438
>
> Change-Id: I847c243dcfb72d8c0f1f6fc73c09547adea933f0
> Reviewed-on: https://skia-review.googlesource.com/4438
> Reviewed-by: Matt Sarett <msarett@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
>
TBR=mtklein@google.com,bsalomon@google.com,msarett@google.com,brianosman@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I1818f937464573d601f64e5a1f1eb43f5a778f4e
Reviewed-on: https://skia-review.googlesource.com/4832
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Brian Osman [Tue, 15 Nov 2016 18:06:18 +0000 (18:06 +0000)]
Revert "Fix NoGPU compilation"
This reverts commit
d5a78805c5133bc55e07c5da21f8d72b91a3df4f.
Reason for revert: This was a patch for an earlier change that's going to be reverted as well.
Original change's description:
> Fix NoGPU compilation
>
> All of these functions were written to work without GPU support, just
> forgot to compile them in that situation.
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4796
>
> Change-Id: Ia23d304f07eb16714390b459dd448bc08402f479
> Reviewed-on: https://skia-review.googlesource.com/4796
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Stan Iliev <stani@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Commit-Queue: Stan Iliev <stani@google.com>
>
TBR=egdaniel@google.com,brianosman@google.com,stani@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Id0b9db355f416c118c0ef95501a6cfdeb083b54e
Reviewed-on: https://skia-review.googlesource.com/4831
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Mike Klein [Tue, 15 Nov 2016 17:58:33 +0000 (17:58 +0000)]
Revert "While we can, restrict SkFixedAlloc/SkFallbackAlloc to POD."
This reverts commit
1ee70359a199f161ce38451989a706d727954cc1.
Reason for revert: breaking my various rolls.
Original change's description:
> While we can, restrict SkFixedAlloc/SkFallbackAlloc to POD.
>
> This trims the overhead down to a uniform 4 bytes.
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4786
>
> Change-Id: I92127a0c2d6c23a4a372eca39842e22195d2dc99
> Reviewed-on: https://skia-review.googlesource.com/4786
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
>
TBR=mtklein@chromium.org,herb@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Iae9ef553422352a1abf95b709fccd014d468da86
Reviewed-on: https://skia-review.googlesource.com/4829
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Klein [Tue, 15 Nov 2016 17:57:48 +0000 (17:57 +0000)]
Revert "fix google3?"
This reverts commit
ccb8e8bf38f51e35e0a456c6a724bab96d1b657a.
Reason for revert: rolling back a CL this attempted to fix.
Original change's description:
> fix google3?
>
> TBR=brianosman@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4822
>
> Change-Id: I991232e90c6851938151daa59cdeb4a3e22a7f03
> Reviewed-on: https://skia-review.googlesource.com/4822
> Commit-Queue: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
>
TBR=mtklein@chromium.org,brianosman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: I127165f065be45af98528c8ae825e2f0fe5c8b0d
Reviewed-on: https://skia-review.googlesource.com/4828
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Klein [Tue, 15 Nov 2016 15:31:38 +0000 (10:31 -0500)]
Fix up arguments passed to pipeline.
- Add half to (x,y) to get pixel centers.
- The x updates were just totally wrong...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4794
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: I314489a74b54e2b88f12dd35896452ac0b9718f3
Reviewed-on: https://skia-review.googlesource.com/4794
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Mike Klein [Tue, 15 Nov 2016 16:56:56 +0000 (11:56 -0500)]
fix google3?
TBR=brianosman@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4822
Change-Id: I991232e90c6851938151daa59cdeb4a3e22a7f03
Reviewed-on: https://skia-review.googlesource.com/4822
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Mike Reed [Tue, 15 Nov 2016 16:52:55 +0000 (11:52 -0500)]
change SkCanvasStack to take ownership of its subcanvases
Inspired by https://bugs.chromium.org/p/chromium/issues/detail?id=663959
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4799
Change-Id: I69f7ac73386bb7ca96778e2fec4cb2757b982a52
Reviewed-on: https://skia-review.googlesource.com/4799
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Brian Salomon [Tue, 15 Nov 2016 17:11:17 +0000 (12:11 -0500)]
Compute the correct dst->src rect for bitmap tiles in SkGpuDevice
Use anisotropic scale to show bug in verylargebitmap test.
Cherry pick to M55
BUG=chromium:664615
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4774
Change-Id: If92eab6d26b9fb506670412a80df259f99db2a21
Reviewed-on: https://skia-review.googlesource.com/4774
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-on: https://skia-review.googlesource.com/4825
Reviewed-by: Brian Salomon <bsalomon@google.com>
Tyler Hoeflicker [Tue, 15 Nov 2016 16:47:09 +0000 (08:47 -0800)]
update from remote
Tyler Hoeflicker [Tue, 15 Nov 2016 16:41:36 +0000 (08:41 -0800)]
rename method
Brian Osman [Tue, 15 Nov 2016 15:55:12 +0000 (10:55 -0500)]
Fix NoGPU compilation
All of these functions were written to work without GPU support, just
forgot to compile them in that situation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4796
Change-Id: Ia23d304f07eb16714390b459dd448bc08402f479
Reviewed-on: https://skia-review.googlesource.com/4796
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Stan Iliev <stani@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Stan Iliev <stani@google.com>
Mike Klein [Tue, 15 Nov 2016 15:26:44 +0000 (10:26 -0500)]
While we can, restrict SkFixedAlloc/SkFallbackAlloc to POD.
This trims the overhead down to a uniform 4 bytes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4786
Change-Id: I92127a0c2d6c23a4a372eca39842e22195d2dc99
Reviewed-on: https://skia-review.googlesource.com/4786
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Florin Malita [Tue, 15 Nov 2016 15:03:32 +0000 (10:03 -0500)]
Resurrect SkDebugger
Can't let go <sniffle>.
R=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4793
Change-Id: Ida5936d17af2ef60c3f50e27b4f4987a79165fa5
Reviewed-on: https://skia-review.googlesource.com/4793
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Brian Osman [Mon, 14 Nov 2016 20:09:56 +0000 (15:09 -0500)]
Support decoding images to multiple formats, depending on usage
Our codec generator will now preserve any asked-for color space, and
convert the encoded data to that representation. Cacherator now
allows decoding an image to both legacy (nullptr color space), and
color-correct formats. In color-correct mode, we choose the best
decoded format, based on the original properties, and our backend's
capabilities. Preference is given to the native format, when it's
already texturable (sRGB 8888 or F16 linear). Otherwise, we prefer
linear F16, and fall back to sRGB when that's not an option.
BUG=skia:5907
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4438
Change-Id: I847c243dcfb72d8c0f1f6fc73c09547adea933f0
Reviewed-on: https://skia-review.googlesource.com/4438
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Robert Phillips [Mon, 14 Nov 2016 18:23:15 +0000 (13:23 -0500)]
Defer more renderTargetContexts in the GPU image filter paths
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4767
Change-Id: I4c1f27247ef340a49d1ac96761810e77e6047ca2
Reviewed-on: https://skia-review.googlesource.com/4767
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Mike Klein [Tue, 15 Nov 2016 13:52:04 +0000 (08:52 -0500)]
Start each pipeline with (x,y) in (dr,dg) registers for the shader.
Image shaders need to do some geometry work before sampling the image colors:
1) determine dst coordinates
2) map back to src coordinates
3) tiling
Feeding (x,y) through as (dr,dg) registers makes step 1) easy, perhaps trivial, while leaving (r,g,b,a) with their usual meanings, "the color", starting with the paint color.
This is easy to tweak into something like (x+0.5, y+0.5, 1) in (dr,dg,db) once this lands. Mostly I just want to get all the uninteresting boilerplate out of the way first.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4791
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Change-Id: Ia07815d942ded6672dc1df785caf80a508fc8f37
Reviewed-on: https://skia-review.googlesource.com/4791
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
herb [Tue, 15 Nov 2016 14:26:56 +0000 (06:26 -0800)]
Make SkSmallAllocator obey the RAII invariants and move to heap structures when needed.
The biggest change is to the API which allowed code to bypass the
destruction invariants. This destruction bypass feature was needed in
only one use, and is totally encapsulated using createWithIniterT.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2488523003
Committed: https://skia.googlesource.com/skia/+/
d5dc657b8c3ac916f98005dafdedafe02f023449
Committed: https://skia.googlesource.com/skia/+/
c18b5f8f57a4efc5d5d1e399ed8bd3bd02c592ab
Review-Url: https://codereview.chromium.org/
2488523003
Eric Boren [Tue, 15 Nov 2016 12:25:23 +0000 (07:25 -0500)]
[nobuildbot] Nexus 6p
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4788
Change-Id: I5049bd59eccfc3106991096652765b79c9dbaffd
Reviewed-on: https://skia-review.googlesource.com/4788
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Mike Klein [Mon, 14 Nov 2016 23:05:16 +0000 (18:05 -0500)]
Fix iOS builders.
Gyp... sigh.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4787
Change-Id: I5488bbc6a8e267dc42d1c716cf0f879b662af171
Reviewed-on: https://skia-review.googlesource.com/4787
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>