platform/upstream/llvm.git
3 years ago[NFC][compiler-rt][test] when using ptrauth, strip before checking if poisoned
Emily Shi [Sat, 17 Jul 2021 00:03:47 +0000 (17:03 -0700)]
[NFC][compiler-rt][test] when using ptrauth, strip before checking if poisoned

ptrauth stores info in the address of functions, so it's not the right address we should check if poisoned

rdar://75246928

Differential Revision: https://reviews.llvm.org/D106199

3 years ago[trace][intel pt] Implement the Intel PT cursor
Walter Erquinigo [Tue, 29 Jun 2021 21:03:30 +0000 (14:03 -0700)]
[trace][intel pt] Implement the Intel PT cursor

D104422 added the interface for TraceCursor, which is the main way to traverse instructions in a trace. This diff implements the corresponding cursor class for Intel PT and deletes the now obsolete code.

Besides that, the logic for the "thread trace dump instructions" was adapted to use this cursor (pretty much I ended up moving code from Trace.cpp to TraceCursor.cpp). The command by default traverses the instructions backwards, and if the user passes --forwards, then it's not forwards. More information about that is in the Options.td file.

Regarding the Intel PT cursor. All Intel PT cursors for the same thread share the same DecodedThread instance. I'm not yet implementing lazy decoding because we don't need it. That'll be for later. For the time being, the entire thread trace is decoded when the first cursor for that thread is requested.

Differential Revision: https://reviews.llvm.org/D105531

3 years ago[CSSPGO] Turn on unique linkage name by default for pseudo probe.
Hongtao Yu [Fri, 16 Jul 2021 21:26:03 +0000 (14:26 -0700)]
[CSSPGO] Turn on unique linkage name by default for pseudo probe.

Turning on -funique-internal-linkage-names when -fpseudo-probe-for-profiling is on, unless -fno-unique-internal-linkage-names is specified.

Reviewed By: wenlei

Differential Revision: https://reviews.llvm.org/D106193

3 years ago[ScalarEvolution] Fix overflow in computeBECount.
Eli Friedman [Fri, 9 Jul 2021 21:10:44 +0000 (14:10 -0700)]
[ScalarEvolution] Fix overflow in computeBECount.

The current implementation of computeBECount doesn't account for the
possibility that adding "Stride - 1" to Delta might overflow. For almost
all loops, it doesn't, but it's not actually proven anywhere.

To deal with this, use a variety of tricks to try to prove that the
addition doesn't overflow.  If the proof is impossible, use an alternate
sequence which never overflows.

Differential Revision: https://reviews.llvm.org/D105216

3 years ago[lit] Add --xfail-not/LIT_XFAIL_NOT
Joel E. Denny [Fri, 16 Jul 2021 23:13:34 +0000 (19:13 -0400)]
[lit] Add --xfail-not/LIT_XFAIL_NOT

For example, I need this lately in my CI config:

LIT_XFAIL_NOT='libomptarget :: nvptx64-nvidia-cuda :: unified_shared_memory/api.c'

That test specifies an XFAIL directive, but I get an XPASS result.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D106022

3 years agoRevert "Build libSupport with -Werror=global-constructors (NFC)"
Mehdi Amini [Fri, 16 Jul 2021 22:46:17 +0000 (22:46 +0000)]
Revert "Build libSupport with -Werror=global-constructors (NFC)"

This reverts commit 1f71bcabb77df482cc0dc7bab90a73e15f3e347b.

Some platform have global destructors for std::mutex that still
needs to be fixed.

3 years agoAdd a mutex to guard access to the ThreadPlanStack class
Jim Ingham [Fri, 16 Jul 2021 03:39:15 +0000 (20:39 -0700)]
Add a mutex to guard access to the ThreadPlanStack class

We've seen reports of crashes (none we've been able to reproduce
locally) that look like they are caused by concurrent access to a
thread plan stack.  It looks like there are error paths when an
interrupt request to debugserver times out that cause this problem.

The thread plan stack access is never in a hot loop, and there
aren't enough of them for the extra data member to matter, so
there's really no good reason not to protect the access.

Adding the mutex revealed a couple of places where we were
using "auto" in an iteration when we should have been using
"auto &" - we didn't intend to copy the stack - and I fixed
those as well.

Except for preventing crashes this should be NFC.

Differential Revision: https\://reviews.llvm.org/D106122

3 years ago[libcxx][modules] protects users from relying on libc++ detail headers (1/n)
Christopher Di Bella [Tue, 13 Jul 2021 19:44:07 +0000 (19:44 +0000)]
[libcxx][modules] protects users from relying on libc++ detail headers (1/n)

libc++ has started splicing standard library headers into much more
fine-grained content for maintainability. It's very likely that outdated
and naive tooling (some of which is outside of LLVM's scope) will
suggest users include things such as `<__algorithm/find.h>` instead of
`<algorithm>`, and Hyrum's law suggests that users will eventually begin
to rely on this without the help of tooling. As such, this commit
intends to protect users from themselves, by making it a hard error for
anyone outside of the standard library to include libc++ detail headers.

This is the first of four patches. Patch #2 will solve the problem for
pre-processor `#include`s; patches #3 and #4 will solve the problem for
`<__tree>` and `<__hash_table>` (since I've never touched the test cases
that are failing for these two, I want to split them out into their own
commits to be extra careful). Patch #5 will concern itself with
`<__threading_support>`, which intersects with libcxxabi (which I know
even less about).

Differential Revision: https://reviews.llvm.org/D105932

3 years ago[Bazel] Delete blank line to make buildifier happy
Fangrui Song [Fri, 16 Jul 2021 22:33:42 +0000 (15:33 -0700)]
[Bazel] Delete blank line to make buildifier happy

3 years ago[sanitizer] Fix test build on Windows
Vitaly Buka [Fri, 16 Jul 2021 22:28:26 +0000 (15:28 -0700)]
[sanitizer] Fix test build on Windows

3 years agoBuild libSupport with -Werror=global-constructors (NFC)
Mehdi Amini [Fri, 16 Jul 2021 03:32:59 +0000 (03:32 +0000)]
Build libSupport with -Werror=global-constructors (NFC)

Ensure that libSupport does not carry any static global initializer.
libSupport can be embedded in use cases where we don't want to load all
cl::opt unless we want to parse the command line.
ManagedStatic can be used to enable lazy-initialization of globals.

3 years ago[ARM] Fix for matching reductions that are both sext and zext.
David Green [Fri, 16 Jul 2021 22:11:42 +0000 (23:11 +0100)]
[ARM] Fix for matching reductions that are both sext and zext.

Fix a silly mistake that was not making sure that _both_ operands were
the correct extend code.

3 years agoRevert "ThinLTO: Fix inline assembly references to static functions with CFI"
Sami Tolvanen [Fri, 16 Jul 2021 21:47:19 +0000 (14:47 -0700)]
Revert "ThinLTO: Fix inline assembly references to static functions with CFI"

This reverts commit 8e3b5cb39eef462943ed7556469604ce25c07a1d.

Reverting to investigate test failures.

3 years agoThinLTO: Fix inline assembly references to static functions with CFI
Sami Tolvanen [Fri, 16 Jul 2021 20:56:54 +0000 (13:56 -0700)]
ThinLTO: Fix inline assembly references to static functions with CFI

Create an internal alias with the original name for static functions
that are renamed in promoteInternals to avoid breaking inline
assembly references to them. This version uses module inline assembly
to avoid issues with LowerTypeTestsModule.

Link: https://github.com/ClangBuiltLinux/linux/issues/1354
Reviewed By: nickdesaulniers, pcc

Differential Revision: https://reviews.llvm.org/D104058

3 years ago[PowerPC] Implement intrinsics for mtfsf[i]
Nemanja Ivanovic [Fri, 16 Jul 2021 18:54:21 +0000 (13:54 -0500)]
[PowerPC] Implement intrinsics for mtfsf[i]

This provides intrinsics for emitting instructions that set the FPSCR (`mtfsf/mtfsfi`).

The patch also conservatively marks the rounding mode as an implicit def for both since they both may set the rounding mode depending on the operands.

Reviewed By: #powerpc, qiucf

Differential Revision: https://reviews.llvm.org/D105957

3 years agoAdd `lli` as dependency of MLIR integration tests
Mehdi Amini [Fri, 16 Jul 2021 21:06:38 +0000 (21:06 +0000)]
Add `lli` as dependency of MLIR integration tests

This fixes running `ninja check-mlir` from a clean build when
the integration tests are enabled.

3 years ago[Bazel] Add examples to bazelignore
Geoffrey Martin-Noble [Fri, 2 Jul 2021 16:13:19 +0000 (09:13 -0700)]
[Bazel] Add examples to bazelignore

This avoids Bazel recursing into these directories when overlayed, which
will break if someone has run Bazel in these dirs (which would only be
successful with the http_archive example) because of the Bazel directory
symlinks (already gitignored).

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D105357

3 years ago[Bazel] Make gentbl_test compatible with coverage
Geoffrey Martin-Noble [Fri, 16 Jul 2021 01:05:57 +0000 (18:05 -0700)]
[Bazel] Make gentbl_test compatible with coverage

Add explicit coverage provider. Also remove output_to_genfiles which
isn't necessary for this test (it's just copy-pasta from gentbl_rule,
which needs it for output C++ header files).

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D106115

3 years ago[Bazel] Use bazel_skylib paths for paths munging
Geoffrey Martin-Noble [Fri, 16 Jul 2021 18:49:50 +0000 (11:49 -0700)]
[Bazel] Use bazel_skylib paths for paths munging

We do a lot of path munging and bazel_sklyib is a pretty reasonable dep.

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D106175

3 years ago[SLP]Improve calculations of the cost for reused/reordered scalars.
Alexey Bataev [Thu, 15 Jul 2021 12:12:17 +0000 (05:12 -0700)]
[SLP]Improve calculations of the cost for reused/reordered scalars.

Part of D105020. Also, fixed FIXMEs that need to use wider vector type
when trying to calculate the cost of reused scalars. This may cause
regressions unless D100486 is landed to improve the cost estimations
for long vectors shuffling.

Differential Revision: https://reviews.llvm.org/D106060

3 years ago[gn build] Port 0bf4b81d57b0
LLVM GN Syncbot [Fri, 16 Jul 2021 20:32:47 +0000 (20:32 +0000)]
[gn build] Port 0bf4b81d57b0

3 years ago[GlobalISel] Fix non-pow-2 legalization of s56 stores.
Amara Emerson [Fri, 16 Jul 2021 19:56:11 +0000 (12:56 -0700)]
[GlobalISel] Fix non-pow-2 legalization of s56 stores.

s56 stores are broken down into s32 + s24 stores. During this step
both of those new stores use an anyextended s64 value, resulting in
truncating stores. With s56, the s24 requires another lower step to
make it legal, and we were crashing because we didn't expect non-pow-2
stores to also be truncating as well.

Differential Revision: https://reviews.llvm.org/D106183

3 years ago[COFF][test] Fix llvm-readobj tests
Fangrui Song [Fri, 16 Jul 2021 20:28:46 +0000 (13:28 -0700)]
[COFF][test] Fix llvm-readobj tests

3 years ago[NFC][compiler-rt][test] pass through MallocNanoZone to iossim env
Emily Shi [Fri, 16 Jul 2021 18:47:16 +0000 (11:47 -0700)]
[NFC][compiler-rt][test] pass through MallocNanoZone to iossim env

This is required for no-fd.cpp test

rdar://79354597

Differential Revision: https://reviews.llvm.org/D106174

3 years ago[libcxx] [test] Fix experimental/memory.resource.adaptor.mem/db_deallocate on Windows
Martin Storsjö [Tue, 13 Jul 2021 12:38:56 +0000 (12:38 +0000)]
[libcxx] [test] Fix experimental/memory.resource.adaptor.mem/db_deallocate on Windows

The checks within the libc++experimental memory_resource class uses this
limit:

     _MaxAlign = _LIBCPP_ALIGNOF(max_align_t);

Therefore, only use max_align_t for this limit instead of using
`__STDCPP_DEFAULT_NEW_ALIGNMENT__` if available.

Differential Revision: https://reviews.llvm.org/D105905

3 years ago[PATCH] D105827: [SLP]Workaround for InsertSubVector cost.
Alexey Bataev [Fri, 16 Jul 2021 19:42:19 +0000 (12:42 -0700)]
[PATCH] D105827: [SLP]Workaround for InsertSubVector cost.

The cost of the InsertSubvector shuffle kind cost is not complete and
may end up with just extracts + inserts costs in many cases. Added
a workaround to represent it as a generic PermuteSingleSrc, which is
still pessimistic but better than InsertSubvector.

Differential Revision: https://reviews.llvm.org/D105827

3 years ago[gn build] (semi-manually) port 6a4054ef060b
Nico Weber [Fri, 16 Jul 2021 19:54:13 +0000 (15:54 -0400)]
[gn build] (semi-manually) port 6a4054ef060b

3 years ago[RISCV] Compose vector subregs hierarchically
Jon Roelofs [Fri, 16 Jul 2021 17:59:56 +0000 (10:59 -0700)]
[RISCV] Compose vector subregs hierarchically

This fixes the test I broke in: https://reviews.llvm.org/D105953#2883579

Differential revision: https://reviews.llvm.org/D106168

3 years agoAdd a scalar argument case for the Fortran spread intrinsic unit test.
Mark Leair [Mon, 12 Jul 2021 19:38:55 +0000 (12:38 -0700)]
Add a scalar argument case for the Fortran spread intrinsic unit test.

3 years ago[llvm-readelf/llvm-readobj] Remove one-dash long options
Fangrui Song [Fri, 16 Jul 2021 19:03:08 +0000 (12:03 -0700)]
[llvm-readelf/llvm-readobj] Remove one-dash long options

llvm-readelf is a user-facing tool which emulates GNU readelf. Remove one-dash
long options which are not recognized by GNU style `getopt_long`. This ensures
long options cannot collide with grouped short options.

Note: the documentation (D63719)/help messages have recommended the double-dash
forms since LLVM 9.0.0.
llvm-readobj is intended as an internal tool which has some flexibility.
llvm-readelf/llvm-readobj use the same option parsing code and llvm-readobj's
one-dash long options aren't used after test migration.

Differential Revision: https://reviews.llvm.org/D106037

3 years ago[test] Avoid llvm-readelf/llvm-readobj one-dash long options
Fangrui Song [Fri, 16 Jul 2021 19:02:49 +0000 (12:02 -0700)]
[test] Avoid llvm-readelf/llvm-readobj one-dash long options

3 years ago[ARM] Extra MLA vecreduce tests. NFC
David Green [Fri, 16 Jul 2021 19:01:52 +0000 (20:01 +0100)]
[ARM] Extra MLA vecreduce tests. NFC

3 years ago[X86][SSE] combineX86ShufflesRecursively - bail if constant folding fails due to...
Simon Pilgrim [Fri, 16 Jul 2021 17:50:12 +0000 (18:50 +0100)]
[X86][SSE] combineX86ShufflesRecursively - bail if constant folding fails due to oneuse limits.

Fixes issue reported on D105827 where a single shuffle of a constant (with multiple uses) was caught in an infinite loop where one shuffle (UNPCKL) used an undef arg but then that got recombined to SHUFPS as the constant value had its own undef that confused matching.....

3 years ago[PowerPC] Implement XL compact math builtins
Lei Huang [Tue, 13 Jul 2021 19:32:36 +0000 (14:32 -0500)]
[PowerPC] Implement XL compact math builtins

Implement a subset of builtins required for compatiblilty with AIX XL compiler.

Reviewed By: nemanjai

Differential Revision: https://reviews.llvm.org/D105930

3 years ago[OpenMP][NFC] Update the comment header for optimizations.
Joseph Huber [Fri, 16 Jul 2021 18:12:42 +0000 (14:12 -0400)]
[OpenMP][NFC] Update the comment header for optimizations.

3 years ago[OpenMP] Add remark documentation to the OpenMP webpage
Joseph Huber [Wed, 14 Jul 2021 21:04:54 +0000 (17:04 -0400)]
[OpenMP] Add remark documentation to the OpenMP webpage

This patch begins adding documentation for each remark emitted by
`openmp-opt`. This builds on the IDs introduced in D105939 so that users
can more easily identify each remark in the webpage.

Depends on D105939.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D106018

3 years ago[OpenMP] Add IDs to OpenMP remarks
Joseph Huber [Tue, 13 Jul 2021 19:31:44 +0000 (15:31 -0400)]
[OpenMP] Add IDs to OpenMP remarks

This patch adds unique idenfitiers to the existing OpenMP remarks. This makes
it easier to identify the corresponding documentation for each remark that will
be hosted in the OpenMP webpage.

Depends on D105898

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D105939

3 years ago[OpenMP] Rework OpenMP remarks
Joseph Huber [Tue, 13 Jul 2021 14:01:21 +0000 (10:01 -0400)]
[OpenMP] Rework OpenMP remarks

This patch rewrites and reworks a few of the existing remarks to make the mmore
concise and consistent prior to writing the documentation for them.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D105898

3 years agosanitizer_common: link Synchronization.lib on Windows
Dmitry Vyukov [Fri, 16 Jul 2021 17:55:32 +0000 (19:55 +0200)]
sanitizer_common: link Synchronization.lib on Windows

Windows bot failed with:
sanitizer_win.cpp.obj : error LNK2019: unresolved external symbol WaitOnAddress referenced in function "void __cdecl __sanitizer::FutexWait(struct __sanitizer::atomic_uint32_t *,unsigned int)" (?FutexWait@__sanitizer@@YAXPEAUatomic_uint32_t@1@I@Z)
sanitizer_win.cpp.obj : error LNK2019: unresolved external symbol WakeByAddressSingle referenced in function "void __cdecl __sanitizer::FutexWake(struct __sanitizer::atomic_uint32_t *,unsigned int)" (?FutexWake@__sanitizer@@YAXPEAUatomic_uint32_t@1@I@Z)
sanitizer_win.cpp.obj : error LNK2019: unresolved external symbol WakeByAddressAll referenced in function "void __cdecl __sanitizer::FutexWake(struct __sanitizer::atomic_uint32_t *,unsigned int)" (?FutexWake@__sanitizer@@YAXPEAUatomic_uint32_t@1@I@Z)
https://lab.llvm.org/buildbot/#/builders/127/builds/14046

According to MSDN we need to link Synchronization.lib:
https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-waitonaddress

Differential Revision: https://reviews.llvm.org/D106167

3 years ago[compiler-rt] change write order of frexpl & frexpf so it doesn't corrupt stack ids
Emily Shi [Fri, 25 Jun 2021 20:32:03 +0000 (13:32 -0700)]
[compiler-rt] change write order of frexpl & frexpf so it doesn't corrupt stack ids

This was fixed in the past for `frexp`, but was not made for `frexpl` & `frexpf` https://github.com/google/sanitizers/issues/321
This patch copies the fix over to `frexpl` because it caused `frexp_interceptor.cpp` test to fail on iPhone and `frexpf` for consistency.

rdar://79652161

Reviewed By: delcypher, vitalybuka

Differential Revision: https://reviews.llvm.org/D104948

3 years ago[tests] Precommit test for D104140
Philip Reames [Fri, 16 Jul 2021 17:57:51 +0000 (10:57 -0700)]
[tests] Precommit test for D104140

3 years ago[mlir][sparse] minor cleanup of Merger
Aart Bik [Fri, 16 Jul 2021 16:02:58 +0000 (09:02 -0700)]
[mlir][sparse] minor cleanup of Merger

Removed inconsistent name prefixes, added consistency checks
on debug strings, added more assertions to verify assumptions
that may be lifted in the future.

Reviewed By: gussmith23

Differential Revision: https://reviews.llvm.org/D106108

3 years ago[Clang] Add an empty builtins.h file.
Stefan Pintilie [Thu, 15 Jul 2021 14:23:23 +0000 (09:23 -0500)]
[Clang] Add an empty builtins.h file.

On Power PC some legacy compilers included a number of builtins in a
builtins.h header file. While this header file is not required to hold
builtins for clang some legacy code does try to include this file and so
this patch provides an empty version of that file.

Differential Revision: https://reviews.llvm.org/D106065

3 years ago[RISCV] Rename the fixed vector vwmacc tests to have the 'm' in their filenames. NFC
Craig Topper [Fri, 16 Jul 2021 17:20:38 +0000 (10:20 -0700)]
[RISCV] Rename the fixed vector vwmacc tests to have the 'm' in their filenames. NFC

3 years ago[RISCV] Use tail agnostic policy for fixed vector vwmacc(u).
Craig Topper [Fri, 16 Jul 2021 17:17:36 +0000 (10:17 -0700)]
[RISCV] Use tail agnostic policy for fixed vector vwmacc(u).

This adds new pseudoinstructions with ForceTailAgnostic set. This
matches what we did for non-widening VMACC. We should move to a
tail policy operand on the pseudos when we expand the intrinsic
interface to include the tail policy.

3 years ago[RISCV] Refactor where in the multiclass hierarchy we add commutable VFMADD/VFMACC...
Craig Topper [Fri, 16 Jul 2021 17:01:05 +0000 (10:01 -0700)]
[RISCV] Refactor where in the multiclass hierarchy we add commutable VFMADD/VFMACC instructions. NFC

I'm preparing to add tail agnostic versions of VWMACC and VFWMACC
so this will make them more consistent.

3 years ago[docs] Update llvm-readelf supported options after D105532
Fangrui Song [Fri, 16 Jul 2021 17:40:30 +0000 (10:40 -0700)]
[docs] Update llvm-readelf supported options after D105532

3 years agosanitizer_common: add Semaphore
Dmitry Vyukov [Thu, 15 Jul 2021 15:15:48 +0000 (17:15 +0200)]
sanitizer_common: add Semaphore

Semaphore is a portable way to park/unpark threads.
The plan is to use it to implement a portable blocking
mutex in subsequent changes. Semaphore can also be used
to efficiently wait for other things (e.g. we currently
spin to synchronize thread creation and start).

Reviewed By: vitalybuka, melver

Differential Revision: https://reviews.llvm.org/D106071

3 years ago[test] Extend negative stride backedge tests to cover signed comparisons
Philip Reames [Fri, 16 Jul 2021 17:24:41 +0000 (10:24 -0700)]
[test] Extend negative stride backedge tests to cover signed comparisons

3 years ago[X86FixupLEAs] Try again to transform the sequence LEA/SUB to SUB/SUB
Guozhi Wei [Fri, 16 Jul 2021 17:16:03 +0000 (10:16 -0700)]
[X86FixupLEAs] Try again to transform the sequence LEA/SUB to SUB/SUB

This patch transforms the sequence
    lea (reg1, reg2), reg3
    sub reg3, reg4
to two sub instructions
    sub reg1, reg4
    sub reg2, reg4

Similar optimization can also be applied to LEA/ADD sequence.

The modifications to TwoAddressInstructionPass is to ensure the operands of ADD
instruction has expected order (the dest register of LEA should be src register
of ADD).

Differential Revision: https://reviews.llvm.org/D104684

3 years ago[SCEV] Add tests for known negative strides in trip count logic
Philip Reames [Fri, 16 Jul 2021 17:08:20 +0000 (10:08 -0700)]
[SCEV] Add tests for known negative strides in trip count logic

3 years ago[ELF][test] Avoid llvm-readelf/llvm-readobj one-dash long options
Fangrui Song [Fri, 16 Jul 2021 17:02:47 +0000 (10:02 -0700)]
[ELF][test] Avoid llvm-readelf/llvm-readobj one-dash long options

3 years agoRevert "[MachineVerifier] Diagnose invalid INSERT_SUBREGs"
Jon Roelofs [Fri, 16 Jul 2021 16:53:16 +0000 (09:53 -0700)]
Revert "[MachineVerifier] Diagnose invalid INSERT_SUBREGs"

This reverts commit dd57ba1a17b93dbe211d04cb2d4de5f6dc898d60.

It broke some tests: http://45.33.8.238/linux/51314/step_12.txt

3 years ago[X86] Regenerate twoaddr-lea.ll test checks.
Simon Pilgrim [Fri, 16 Jul 2021 14:14:05 +0000 (15:14 +0100)]
[X86] Regenerate twoaddr-lea.ll test checks.

3 years ago[DAG] SelectionDAG::MaskedElementsAreZero - assert we're calling with a vector. NFCI.
Simon Pilgrim [Fri, 16 Jul 2021 11:05:05 +0000 (12:05 +0100)]
[DAG] SelectionDAG::MaskedElementsAreZero - assert we're calling with a vector. NFCI.

Add an assertion that we've calling MaskedElementsAreZero with a vector op and that the DemandedElts arg is a matching width.

Makes the error a lot easier to grok when something else accidentally gets used.

3 years ago[MachineVerifier] Diagnose invalid INSERT_SUBREGs
Jon Roelofs [Wed, 14 Jul 2021 00:07:48 +0000 (17:07 -0700)]
[MachineVerifier] Diagnose invalid INSERT_SUBREGs

Differential revision: https://reviews.llvm.org/D105953

3 years ago[RISCV] Teach constant materialization that it can use zext.w at the end with Zba...
Craig Topper [Fri, 16 Jul 2021 16:23:17 +0000 (09:23 -0700)]
[RISCV] Teach constant materialization that it can use zext.w at the end with Zba to reduce number of instructions.

If the upper 32 bits are zero and bit 31 is set, we might be able to
use zext.w to fill in the zeros after using an lui and/or addi.

Most of this patch is plumbing the subtarget features into the constant
materialization.

Reviewed By: luismarques

Differential Revision: https://reviews.llvm.org/D105509

3 years ago[RISCV] Add curly braces around a case body that declares variables. NFC
Craig Topper [Fri, 16 Jul 2021 01:06:59 +0000 (18:06 -0700)]
[RISCV] Add curly braces around a case body that declares variables. NFC

This is at the end of the switch so doesn't cause any issues now,
but if a new case is added it will break.

3 years ago[Verifier] Require same signature for intrinsic calls
Nikita Popov [Wed, 14 Jul 2021 20:21:06 +0000 (22:21 +0200)]
[Verifier] Require same signature for intrinsic calls

As suggested on D105733, this adds a verifier rule that calls to
intrinsics must match the signature of the intrinsic.

Without opaque pointers this is automatically enforced for all
calls, because the pointer types need to match. If the signatures
don't match, a pointer bitcast has to be inserted. For intrinsics
in particular, such bitcasts are not legal, because the address of
intrinsics cannot be taken.

With opaque pointers, there are no more pointer bitcasts, so it's
generally possible for the call and the callee signature to differ.
However, for intrinsics we still want to enforce that the signatures
must match, the same as was done before through the address taken
check.

We can't enforce this more generally for non-intrinsics, because
calls with mismatched signatures at the very least can legally
occur in unreachable code, and might also be valid in some other
cases, depending on how exactly the signatures differ.

Differential Revision: https://reviews.llvm.org/D106013

3 years ago[NFC] Fix typo intrinisic
madhur13490 [Fri, 16 Jul 2021 16:13:48 +0000 (21:43 +0530)]
[NFC] Fix typo intrinisic

Differential Revision: https://reviews.llvm.org/D106161

3 years ago[libcxx][modularisation] adds several headers to the module map
Christopher Di Bella [Thu, 15 Jul 2021 06:41:17 +0000 (06:41 +0000)]
[libcxx][modularisation] adds several headers to the module map

* <__algorithm/iter_swap.h>
* <__algorithm/swap_ranges.h>
* <__functional/is_transparent.h>
* <__memory/uses_allocator.h>
* <__ranges/drop_view.h>
* <__ranges/transform_view.h>
* <shared_mutex>
* <span>

Also updates header inclusions that were affected.

**NOTE:** This is a proper subset of D105932. Since the content has
already been LGTM'd, I intend to merge this patch without review,
pending green CI. I decided it would be better to move these changes
into their own commit since the former patch has undergone further
changes and will need yet another light review. In the event any of
that gets rolled back (for whatever reason), the changes in this patch
won't be affected.

Differential Revision: https://reviews.llvm.org/D106040

3 years ago[flang][driver] Fix output filename generation in `flang`
Andrzej Warzynski [Fri, 16 Jul 2021 16:06:06 +0000 (17:06 +0100)]
[flang][driver] Fix output filename generation in `flang`

In the `flang` bash script, we need to be careful _when_ to use <output>
from `flang -c -o <output> <input>` when generating the relocatable
output file name.

In particular, we should use it in this case:
```compilation only
flang -c -o <output> <input>
```
but leave it for the final executable here:
```compile, assemble and link
flang  -o <output> <input>
```
This change is implemented in `get_relocatable_name`.

I've also taken the liberty to fix how errors from sub-commands are
reported (without this change, `flang` always returns `0` on failure).
This is implemented in `main`.

Differential Revision: https://reviews.llvm.org/D105896

3 years ago[LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level...
Congzhe Cao [Fri, 16 Jul 2021 15:47:11 +0000 (11:47 -0400)]
[LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level nested loops

We already know that we need to check whether lcssa
phis are supported in inner loop exit block or in
outer loop exit block, and we have logic to check
them already. Presumably the inner loop latch does
not have lcssa phis and there is no code that deals
with lcssa phis in the inner loop latch. However,
that assumption is not true, when we have loops
with more than two-level nesting. This patch adds
checks for lcssa phis in the inner latch.

Reviewed By: Whitney

Differential Revision: https://reviews.llvm.org/D102300

3 years ago[libc++] ci: Create ~/Library/LaunchAgents if it does not exist yet
Louis Dionne [Fri, 16 Jul 2021 15:46:47 +0000 (11:46 -0400)]
[libc++] ci: Create ~/Library/LaunchAgents if it does not exist yet

3 years agoMips/GlobalISel: Use LLT form of getMachineMemOperand
Matt Arsenault [Fri, 11 Jun 2021 16:17:32 +0000 (12:17 -0400)]
Mips/GlobalISel: Use LLT form of getMachineMemOperand

NFC here since it's just using a scalar anyway.

3 years agoGlobalISel: Preserve memory type for memset expansion
Matt Arsenault [Fri, 16 Jul 2021 15:25:07 +0000 (11:25 -0400)]
GlobalISel: Preserve memory type for memset expansion

3 years agoAArch64/GlobalISel: Update tests to use correct memory types
Matt Arsenault [Fri, 16 Jul 2021 13:19:23 +0000 (09:19 -0400)]
AArch64/GlobalISel: Update tests to use correct memory types

3 years ago[libc++] CI: Setup BuildKite agents through launchd
Louis Dionne [Fri, 16 Jul 2021 15:37:16 +0000 (11:37 -0400)]
[libc++] CI: Setup BuildKite agents through launchd

This makes sure that even if a node goes down, the BuildKite agent will
be started again when it goes back up.

3 years ago[mlir] Remove unused functions in LinalgOps.cpp
Alexander Belyaev [Fri, 16 Jul 2021 15:14:34 +0000 (17:14 +0200)]
[mlir] Remove unused functions in LinalgOps.cpp

3 years ago[Bazel] Delete deprecated gentbl rule
Geoffrey Martin-Noble [Fri, 16 Jul 2021 01:06:21 +0000 (18:06 -0700)]
[Bazel] Delete deprecated gentbl rule

This has been deprecated for a while. There are no users in tree and I'm
not aware of any out of tree users either.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D106114

3 years ago[PowerPC] Updated the error message of MASSV pass to mention vectorization
Masoud Ataei [Fri, 16 Jul 2021 14:45:09 +0000 (14:45 +0000)]
[PowerPC] Updated the error message of MASSV pass to mention vectorization
 is needed be enable on P8 and later targets.

 Differential Revision: https://reviews.llvm.org/D106091

3 years ago[runtimes] Simplify how we set the target triple
Louis Dionne [Wed, 14 Jul 2021 19:54:13 +0000 (15:54 -0400)]
[runtimes] Simplify how we set the target triple

Instead of using TARGET_TRIPLE, which is always set to LLVM_DEFAULT_TARGET_TRIPLE,
use that variable directly to populate the various XXXX_TARGET_TRIPLE
variables in the runtimes.

This re-applies 77396bbc98 and 5099e01568, which were reverted in
850b57c5fbe because they broke the build.

Differential Revision: https://reviews.llvm.org/D106009

3 years ago[PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests
Amy Kwan [Wed, 14 Jul 2021 01:33:23 +0000 (20:33 -0500)]
[PowerPC] Update Refactored Load/Store Implementation, XForm VSX Patterns, and Tests

This patch includes the following updates to the load/store refactoring effort introduced in D93370:
 - Update various VSX patterns that use to "force" an XForm, to instead just XForm.
   This allows the ability for the patterns to compute the most optimal addressing
   mode (and to produce a DForm instruction when possible)
- Update pattern and test case for the LXVD2X/STXVD2X intrinsics
- Update LIT test cases that use to use the XForm instruction to use the DForm instruction

Differential Revision: https://reviews.llvm.org/D95115

3 years agoRevert "[RISCV] Lower more BUILD_VECTOR sequences to RVV's VID"
Fraser Cormack [Fri, 16 Jul 2021 13:58:39 +0000 (14:58 +0100)]
Revert "[RISCV] Lower more BUILD_VECTOR sequences to RVV's VID"

This reverts commit a6ca88e908b5befcd9b0f8c8cb40f53095cc17bc.

More caution is required to avoid overflow/underflow. Thanks to the
santizers for catching this.

3 years ago[lldb][AArch64] Add tag packing and repetition memory tag manager
David Spickett [Wed, 31 Mar 2021 12:35:56 +0000 (13:35 +0100)]
[lldb][AArch64] Add tag packing and repetition memory tag manager

PackTags is used by to compress tags to go in the QMemTags packet
and be passed to ptrace when writing memory tags.

The behaviour of RepeatTagsForRange matches that described for QMemTags
in the GDB documentation:
https://sourceware.org/gdb/current/onlinedocs/gdb/General-Query-Packets.html#General-Query-Packets

In addition, unpacking tags with number of tags 0 now means
do not check that number of tags matches the range.
This will be used by lldb-server to unpack tags before repeating
them to fill the requested range.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D105179

3 years ago[mlir] add missing build dependency
Alex Zinenko [Fri, 16 Jul 2021 13:20:07 +0000 (15:20 +0200)]
[mlir] add missing build dependency

3 years ago[mlir] replace llvm.mlir.cast with unrealized_conversion_cast
Alex Zinenko [Tue, 13 Jul 2021 08:55:35 +0000 (10:55 +0200)]
[mlir] replace llvm.mlir.cast with unrealized_conversion_cast

The dialect-specific cast between builtin (ex-standard) types and LLVM
dialect types was introduced long time before built-in support for
unrealized_conversion_cast. It has a similar purpose, but is restricted
to compatible builtin and LLVM dialect types, which may hamper
progressive lowering and composition with types from other dialects.
Replace llvm.mlir.cast with unrealized_conversion_cast, and drop the
operation that became unnecessary.

Also make unrealized_conversion_cast legal by default in
LLVMConversionTarget as the majority of convesions using it are partial
conversions that actually want the casts to persist in the IR. The
standard-to-llvm conversion, which is still expected to run last, cleans
up the remaining casts  standard-to-llvm conversion, which is still
expected to run last, cleans up the remaining casts

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D105880

3 years agoGlobalISel: Remove dead function
Matt Arsenault [Thu, 15 Jul 2021 18:44:03 +0000 (14:44 -0400)]
GlobalISel: Remove dead function

3 years agoAMDGPU/GlobalISel: Preserve more memory types
Matt Arsenault [Thu, 15 Jul 2021 18:24:00 +0000 (14:24 -0400)]
AMDGPU/GlobalISel: Preserve more memory types

3 years agoAMDGPU/GlobalISel: Redo kernel argument load handling
Matt Arsenault [Thu, 15 Jul 2021 18:23:06 +0000 (14:23 -0400)]
AMDGPU/GlobalISel: Redo kernel argument load handling

This avoids relying on G_EXTRACT on unusual types, and also properly
decomposes structs into multiple registers. This also preserves the
LLTs in the memory operands.

3 years ago[InstrRef][FastISel] Support emitting DBG_INSTR_REF from fast-isel
Jeremy Morse [Fri, 16 Jul 2021 12:36:27 +0000 (13:36 +0100)]
[InstrRef][FastISel] Support emitting DBG_INSTR_REF from fast-isel

If you attach __attribute__((optnone)) to a function when using
optimisations, that function will use fast-isel instead of the usual
SelectionDAG method. This is a problem for instruction referencing,
because it means DBG_VALUEs of virtual registers will be created,
triggering some safety assertions in LiveDebugVariables. Those assertions
exist to detect exactly this scenario, where an unexpected piece of code is
generating virtual register references in instruction referencing mode.

Fix this by transforming the DBG_VALUEs created by fast-isel into
half-formed DBG_INSTR_REFs, after which they get patched up in
finalizeDebugInstrRefs. The test modified adds a fast-isel mode to the
instruction referencing isel test.

Differential Revision: https://reviews.llvm.org/D105694

3 years ago[SLP] add tests for poison-safe bool logic reductions; NFC
Sanjay Patel [Fri, 16 Jul 2021 12:31:28 +0000 (08:31 -0400)]
[SLP] add tests for poison-safe bool logic reductions; NFC

More coverage for D105730

3 years agoSubstTemplateTypeParmType can contain an 'auto' type in their replacement type
serge-sans-paille [Thu, 15 Jul 2021 19:55:22 +0000 (21:55 +0200)]
SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

This fixes bug 36064

Differential Revision: https://reviews.llvm.org/D106093

3 years ago[AMDGPU][MC] Added missing isCall/isBranch flags
Dmitry Preobrazhensky [Fri, 16 Jul 2021 11:42:30 +0000 (14:42 +0300)]
[AMDGPU][MC] Added missing isCall/isBranch flags

Added isCall for S_CALL_B64; added isBranch for S_SUBVECTOR_LOOP_*.

Differential Revision: https://reviews.llvm.org/D106072

3 years ago[PowerPC][AIX] Add warning when alignment is incompatible with XL
Zarko Todorovski [Fri, 16 Jul 2021 11:49:36 +0000 (07:49 -0400)]
[PowerPC][AIX] Add warning when alignment is incompatible with XL

https://reviews.llvm.org/D105659 implements ByVal handling in llc but
some cases are not compatible with existing XL compiler on AIX.  Adding
a clang warning for such cases.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D105660

3 years ago[mlir] Move linalg::Expand/CollapseShapeOp to memref dialect.
Alexander Belyaev [Fri, 16 Jul 2021 11:31:02 +0000 (13:31 +0200)]
[mlir] Move linalg::Expand/CollapseShapeOp to memref dialect.

RFC: https://llvm.discourse.group/t/rfc-reshape-ops-restructuring/3310

Differential Revision: https://reviews.llvm.org/D106141

3 years agoUse update_test_checks.py to auto-generate check lines
Serge Pavlov [Fri, 16 Jul 2021 11:19:31 +0000 (18:19 +0700)]
Use update_test_checks.py to auto-generate check lines

3 years ago[mlir] add an interface to support custom types in LLVM dialect pointers
Alex Zinenko [Thu, 15 Jul 2021 16:16:07 +0000 (18:16 +0200)]
[mlir] add an interface to support custom types in LLVM dialect pointers

This may be necessary in partial multi-stage conversion when a container type
from dialect A containing types from dialect B goes through the conversion
where only dialect A is converted to the LLVM dialect. We will need to keep a
pointer-to-non-LLVM type in the IR until a further conversion can convert
dialect B types to LLVM types.

Reviewed By: wsmoses

Differential Revision: https://reviews.llvm.org/D106076

3 years ago[AArch64] Update Cortex-A55 SchedModel to improve LDP scheduling
Nicholas Guy [Mon, 12 Jul 2021 09:36:35 +0000 (10:36 +0100)]
[AArch64] Update Cortex-A55 SchedModel to improve LDP scheduling

Specifying the latencies of specific LDP variants appears to improve
performance almost universally.

Differential Revision: https://reviews.llvm.org/D105882

3 years ago[LV] Avoid scalable vectorization for loops containing alloca
Kerry McLaughlin [Fri, 16 Jul 2021 10:04:20 +0000 (11:04 +0100)]
[LV] Avoid scalable vectorization for loops containing alloca

This patch returns an Invalid cost from getInstructionCost() for alloca
instructions if the VF is scalable, as otherwise loops which contain
these instructions will crash when attempting to scalarize the alloca.

Reviewed By: sdesmalen

Differential Revision: https://reviews.llvm.org/D105824

3 years ago[AArch64][SME] Add load and store instructions
Cullen Rhodes [Fri, 16 Jul 2021 09:14:08 +0000 (09:14 +0000)]
[AArch64][SME] Add load and store instructions

This patch adds support for following contiguous load and store
instructions:

  * LD1B, LD1H, LD1W, LD1D, LD1Q
  * ST1B, ST1H, ST1W, ST1D, ST1Q

A new register class and operand is added for the 32-bit vector select
register W12-W15. The differences in the following tests which have been
re-generated are caused by the introduction of this register class:

  * llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll
  * llvm/test/CodeGen/AArch64/GlobalISel/regbank-inlineasm.mir
  * llvm/test/CodeGen/AArch64/stp-opt-with-renaming-reserved-regs.mir
  * llvm/test/CodeGen/AArch64/stp-opt-with-renaming.mir

D88663 attempts to resolve the issue with the store pair test
differences in the AArch64 load/store optimizer.

The GlobalISel differences are caused by changes in the enum values of
register classes, tests have been updated with the new values.

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2021-06

Reviewed By: CarolineConcatto

Differential Revision: https://reviews.llvm.org/D105572

3 years ago[lldb][AArch64] Refactor memory tag range handling
David Spickett [Thu, 8 Jul 2021 12:17:43 +0000 (13:17 +0100)]
[lldb][AArch64] Refactor memory tag range handling

Previously GetMemoryTagManager checked many things in one:
* architecture supports memory tagging
* process supports memory tagging
* memory range isn't inverted
* memory range is all tagged

Since writing follow up patches for tag writing (in review
at the moment) it has become clear that this gets unwieldy
once we add the features needed for that.

It also implies that the memory tag manager is tied to the
range you used to request it with but it is not. It's a per
process object.

Instead:
* GetMemoryTagManager just checks architecture and process.
* Then the MemoryTagManager can later be asked to check a
  memory range.

This is better because:
* We don't imply that range and manager are tied together.
* A slightly diferent range calculation for tag writing
  doesn't add more code to Process.
* Range checking code can now be unit tested.

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D105630

3 years agoReland "[LV] Print remark when loop cannot be vectorized due to invalid costs."
Sander de Smalen [Thu, 15 Jul 2021 14:32:31 +0000 (15:32 +0100)]
Reland "[LV] Print remark when loop cannot be vectorized due to invalid costs."

The original patch was:
  https://reviews.llvm.org/D105806

There were some issues with undeterministic behaviour of the sorting
function, which led to scalable-call.ll passing and/or failing. This
patch fixes the issue by numbering all instructions in the array first,
and using that number as the order, which should provide a consistent
ordering.

This reverts commit a607f64118240f70bf1b14ec121b65f49d63800d.

3 years ago[RISCV] Lower more BUILD_VECTOR sequences to RVV's VID
Fraser Cormack [Thu, 24 Jun 2021 15:32:46 +0000 (16:32 +0100)]
[RISCV] Lower more BUILD_VECTOR sequences to RVV's VID

This patch teaches the compiler to identify a wider variety of
`BUILD_VECTOR`s which form integer arithmetic sequences, and to lower
them to `vid.v` with modifications for non-unit steps and non-zero
addends.

The sequences handled by this optimization must either be monotonically
increasing or decreasing. Consecutive elements holding the same value
indicate a fractional step which, while simple mathematically,
becomes more complex to handle both in the realm of lossy integer
division and in the presence of `undef`s.

For example, a common "interleaving" shuffle index will be lowered by
LLVM to both `<0,u,1,u,2,...>` and `<u,0,u,1,u,...>` `BUILD_VECTOR`
nodes. Either of these would ideally be lowered to `vid.v` shifted right
by 1. Detection of this sequence in presence of general `undef` values
is more complicated, however: `<0,u,u,1,>` could match either
`<0,0,0,1,>` or `<0,0,1,1,>` depending on later values in the sequence.
Both are possible, so backtracking or multiple passes is inevitable.

Sticking to monotonic sequences keeps the logic simpler as it can be
done in one pass. Fractional steps will likely be a separate
optimization in a future patch.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D104921

3 years ago[MLIR][NFC] Improve doc comment and delete stale comment
Uday Bondhugula [Fri, 16 Jul 2021 09:29:16 +0000 (14:59 +0530)]
[MLIR][NFC] Improve doc comment and delete stale comment

Remove duplicate and stale doc comment on affineParallelize. NFC.

3 years ago[llvm][tools] Hide unrelated llvm-cfi-verify options
Timm Bäder [Fri, 16 Jul 2021 08:17:41 +0000 (10:17 +0200)]
[llvm][tools] Hide unrelated llvm-cfi-verify options

Differential Revision: https://reviews.llvm.org/D106055

3 years ago[analyzer] Do not assume that all pointers have the same bitwidth as void*
Vince Bridgers [Wed, 14 Jul 2021 12:00:14 +0000 (07:00 -0500)]
[analyzer] Do not assume that all pointers have the same bitwidth as void*

This change addresses this assertion that occurs in a downstream
compiler with a custom target.

```APInt.h:1151: bool llvm::APInt::operator==(const llvm::APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Comparison requires equal bit widths"'```

No covering test case is susbmitted with this change since this crash
cannot be reproduced using any upstream supported target. The test case
that exposes this issue is as simple as:

```lang=c++
  void test(int * p) {
    int * q = p-1;
    if (q) {}
    if (q) {} // crash
    (void)q;
  }
```

The custom target that exposes this problem supports two address spaces,
16-bit `char`s, and a `_Bool` type that maps to 16-bits. There are no upstream
supported targets with similar attributes.

The assertion appears to be happening as a result of evaluating the
`SymIntExpr` `(reg_$0<int * p>) != 0U` in `VisitSymIntExpr` located in
`SimpleSValBuilder.cpp`. The `LHS` is evaluated to `32b` and the `RHS` is
evaluated to `16b`. This eventually leads to the assertion in `APInt.h`.

While this change addresses the crash and passes LITs, two follow-ups
are required:
  1) The remainder of `getZeroWithPtrWidth()` and `getIntWithPtrWidth()`
     should be cleaned up following this model to prevent future
     confusion.
  2) We're not sure why references are found along with the modified
     code path, that should not be the case. A more principled
     fix may be found after some further comprehension of why this
     is the case.

Acks: Thanks to @steakhal and @martong for the discussions leading to this
fix.

Reviewed By: NoQ

Differential Revision: https://reviews.llvm.org/D105974

3 years agoReformat files.
Simon Giesecke [Wed, 14 Jul 2021 08:21:16 +0000 (08:21 +0000)]
Reformat files.

Differential Revision: https://reviews.llvm.org/D105982

3 years agoUse ManagedStatic and lazy initialization of cl::opt in libSupport to make it free...
Mehdi Amini [Thu, 15 Jul 2021 23:52:44 +0000 (23:52 +0000)]
Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

We can build it with -Werror=global-constructors now. This helps
in situation where libSupport is embedded as a shared library,
potential with dlopen/dlclose scenario, and when command-line
parsing or other facilities may not be involved. Avoiding the
implicit construction of these cl::opt can avoid double-registration
issues and other kind of behavior.

Reviewed By: lattner, jpienaar

Differential Revision: https://reviews.llvm.org/D105959

3 years agoRevert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make...
Mehdi Amini [Fri, 16 Jul 2021 07:34:41 +0000 (07:34 +0000)]
Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

This reverts commit af9321739b20becf170e6bb5060b8d780e1dc8dd.
Still some specific config broken in some way that requires more
investigation.