Cedric BAIL [Fri, 24 Jan 2020 19:03:23 +0000 (11:03 -0800)]
efl: add test for efl_model_children_index_get.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11186
Cedric BAIL [Fri, 24 Jan 2020 19:01:03 +0000 (11:01 -0800)]
efl: add Efl.Model.Children_Index_Get.
This allow for fetching random children in a model. A simple fallback is
provided by Efl.Loop_Model that will allow all model to provide this
feature in a non optimized way. Later on this can be speeded up.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11185
Cedric BAIL [Fri, 24 Jan 2020 18:59:01 +0000 (10:59 -0800)]
ecore: refactor unpacking/packing code used in conjonction with eina_future_all*.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11184
Cedric BAIL [Thu, 30 Jan 2020 23:16:22 +0000 (15:16 -0800)]
eina: do not warn when calling eina_inarray_pop on empty inarray to match eina_array_pop.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11253
Cedric BAIL [Wed, 22 Jan 2020 18:23:53 +0000 (10:23 -0800)]
eina: add test for eina_future_all_iterator.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11181
Cedric BAIL [Wed, 22 Jan 2020 18:22:06 +0000 (10:22 -0800)]
eina: add eina_future_all_iterator and eina_promise_all_iterator.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11180
Tom Callaway [Fri, 31 Jan 2020 12:40:45 +0000 (12:40 +0000)]
Fix build with gcc 10 (which has -fno-common enabled by default).
EFL failed to build from source in Fedora Rawhide as a result of the update to GCC 10. GCC 10 enables -fno-common by default, and this found three issues in EFL:
# The eina benchmark code defined int key_size in a header that was included in multiple places.
# The elementary test code defines the "dt1", "dt2", "dt3" vars in two code files which are compiled together (but these variables do not appear to be used globally)
# The eio test code defines the "ee" var in two code files which are compiled together (but this variable does not appear to be used globally)
I've fixed these issues and confirmed locally that the code builds again in Fedora.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11259
ProhtMeyhet [Fri, 31 Jan 2020 07:20:54 +0000 (07:20 +0000)]
edje: use EINA_UNUSED consistently after in function signatures -- part2
Sorry, I've overlooked these as they are on a new line,
or at the beginning of a function, but I think I've got them all now.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11254
Marcel Hollerbach [Fri, 31 Jan 2020 12:51:38 +0000 (13:51 +0100)]
evas_object_grid: fix leaking of pointer
priv->children was leaked to a freed pointer here.
This is now fixed.
Woochanlee [Thu, 30 Jan 2020 06:25:36 +0000 (06:25 +0000)]
evas_object_grid: Fix memory leak.
_evas_object_smart_clipped_init() (in evas_object_smart.c) is called when evas_object_grid is created.
And a rectangle is created in the function.
But, the rectangle is not deleted even though evas_objecct_grid is deleted.
This patch fixes the problem by deleting it in smart_del fucntion.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11140
Shinwoo Kim [Fri, 31 Jan 2020 12:34:49 +0000 (21:34 +0900)]
evas filter: fix crash issue
Summary:
If image object geometry is same with image size, then a crash occurs on both
GL and SW engine.
[Test Code]
evas_object_image_size_get(img, &w, &h);
evas_object_resize(img, w, h);
[GL engine]
eng_ector_buffer_wrap should use output instead of engine for calling
evas_ector_buffer_engine_image, because it expects the output not the engine.
[SW engine]
eng_ector_buffer_wrap should check if im->image.data is NULL because
_evas_ector_software_buffer_evas_ector_buffer_engine_image_set returns before
calling evas_cache_iamge_ref if im->image.data is NULL, and it causes
a segmentation fault finally with following backtrace.
(#0) evas_cache_image_drop (im=0x0)
(#1) _evas_ector_software_buffer_efl_object_destructor
(#2) efl_destructor
(#3) _efl_del_internal
(#4) _efl_unref_internal
(#5) _efl_add_internal_end
(#6) _efl_add_end
(#7) eng_ector_buffer_wrap
Test Plan: {
F3841366}
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11258
Xavi Artigas [Fri, 31 Jan 2020 09:55:54 +0000 (10:55 +0100)]
docs: Remove leftover 'see also' from Efl.Ui.Image
Shinwoo Kim [Fri, 31 Jan 2020 09:31:08 +0000 (18:31 +0900)]
Efl.Canvas.Group: make mask filter work on GL engine
Summary:
The _gl_filter_mask defines value of gc->dc->clip.mask, and make_color but
those are not used at all, because the evas_gl_common_Filter_blend_push calls
evas_gl_common_context_image_push which doesn't care of those values.
So this patch is using evas_gl_common_image_draw to use mask and mask_color.
Test Plan:
[Filter Program]
efl_gfx_filter_program_set(text,
"buffer:a(alpha); buffer:fat(alpha); buffer:rgbfat(rgba);
curve (0:255-255:0, dst = a); blend (a, color = #
00ca00ff);
grow (1, dst = fat); blur (3, src = fat, color=#
0000b9ff, ox = -2, oy = -2, dst = rgbfat);
mask (a, src = rgbfat);padding_set(t=5);",
"name");
[Before]
{
F3835430}
[After]
{
F3835431}
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11139
JunsuChoi [Fri, 31 Jan 2020 07:35:57 +0000 (16:35 +0900)]
Efl.Ui.Vg_Animation: Remove @beta mark
Summary:
Remove beta mark for Efl.Ui.Vg_Animation.
.playing_sector and .value_provider_override leave a beta mark.
It will be removed after more review.
Depends on D10953
Ref T8476
Test Plan:
meson_option.txt -> remove json in evas-loaders-disabler option
elementary_test -to "Vector Graphics Animation"
Reviewers: Hermet, Jaehyun_Cho, bu5hm4n, cedric, zmike
Reviewed By: Hermet, cedric, zmike
Subscribers: zmike, segfaultxavi, YOhoho, cedric, #reviewers, #committers, kimcinoo
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D10870
Yeongjong Lee [Fri, 31 Jan 2020 10:55:30 +0000 (19:55 +0900)]
Revert "Revert "elementary: make focus manager update_children and update_order an internal function to not expose list<>.""
This reverts commit
d887f91efe81f63c567fb9563f6493e47cb54cb9.
Change-Id: I24911fe63c6de645c07f9fcc2a847c2febc3048d
Yeongjong Lee [Fri, 31 Jan 2020 11:04:23 +0000 (20:04 +0900)]
efl_ui_focus_manager_calc: remove update_children, update_order
They were removed from upstream
@tizen_fix
Change-Id: Idde9fd37b690a2c09cce45f3adcdffc8fc0981da
Woochanlee [Fri, 31 Jan 2020 08:29:19 +0000 (17:29 +0900)]
tizen_vector: Fix callback calling after deleted callback.
_progressbar_process_pulse_start() called after called progressbar_del_cb()
It makes crash.
_progressbar_process_pulse_start() ready to emit in queue when we deleted elm_object_signal_callback_del().
To prevent this weird action using deleting flag here.
Change-Id: I5df9c571b3e35afde9b6b23435b9ac36bd1bf55c
Yeongjong Lee [Thu, 30 Jan 2020 04:55:23 +0000 (13:55 +0900)]
efl_access_object: mark @beta efl_access_object.eo
Efl.Access.Object is beta in upstream.
This patch will prevent conflict with upstream eolian patches.
@tizen_fix
Change-Id: I9313ec7f59305ef4e4bfcc4d5fc6ac5e8823d28d
Jongmin Lee [Thu, 30 Jan 2020 21:08:44 +0000 (06:08 +0900)]
Revert "elementary: make focus manager update_children and update_order an internal function to not expose list<>."
This reverts commit
d12ddb3ecb816e836e286c3c9a95f45f3a88d0bb.
Proht [Wed, 29 Jan 2020 17:18:32 +0000 (17:18 +0000)]
edje: use EINA_UNUSED consistently after declaration in function signatures
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11237
Stefan Schmidt [Wed, 29 Jan 2020 10:38:27 +0000 (11:38 +0100)]
ci: add leak ignore as a temporary bandaid
This needs some more digging where this leak comes from. I see it
triggering on edje_cc during the build.
Until we have this sorted out add as ignore here to keep CI working.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11234
Stefan Schmidt [Wed, 29 Jan 2020 10:33:37 +0000 (11:33 +0100)]
ci: update Ubuntu bionic deps to cover openjp2 we now depend on
Since we switched on some loader to default we have this as a default
dependency. Reflect this in our CI setup to avoid breaks.
Also make sure we use sudo for the meson pip install to not break on the
ARM64 infrastructure on TravisCI.
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11233
Mike Blumenkrantz [Mon, 13 Jan 2020 20:04:38 +0000 (15:04 -0500)]
efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers
this lets gesture framework track two touch points in order to distinguish between
successive presses and e.g., treat a simultaneous two finger tap as a single tap
gesture rather than two
it also simplifies some internal code and removes most hash lookups
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11085
Mike Blumenkrantz [Thu, 9 Jan 2020 15:05:32 +0000 (10:05 -0500)]
tests/gesture: add longpress tests
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11084
Mike Blumenkrantz [Thu, 9 Jan 2020 15:04:06 +0000 (10:04 -0500)]
tests/elm: add util functions for pressing mouse button without releasing
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11083
Mike Blumenkrantz [Thu, 9 Jan 2020 15:02:26 +0000 (10:02 -0500)]
tests/elm: add util function to automatically delay loop by given time
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11082
Mike Blumenkrantz [Thu, 9 Jan 2020 14:59:45 +0000 (09:59 -0500)]
efl/gesture: unset timer pointers for tap recognizers
avoid having stale timer pointers around once timers have triggered
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11081
Mike Blumenkrantz [Wed, 8 Jan 2020 19:40:50 +0000 (14:40 -0500)]
tests/gesture: beef up gesture flick/momentum tests significantly
this adds test cases for flicks in different directions, flicks which
leave the canvas, and gestures which are momentums but not flicks
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11055
Mike Blumenkrantz [Wed, 8 Jan 2020 19:40:18 +0000 (14:40 -0500)]
tests/elm: add util function for dragging the pointer in an arc
useful for throwing in non-linear drags
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D11054
Mike Blumenkrantz [Wed, 8 Jan 2020 15:23:49 +0000 (10:23 -0500)]
efl/gesture: formatting
some parts of this were entirely unreadable due to mixed tabs/spaces and other
bizarre formatting issues which somehow made it into the tree
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11053
Mike Blumenkrantz [Mon, 6 Jan 2020 17:30:45 +0000 (12:30 -0500)]
tests/efl_ui: begin some gesture unit tests
adds basic testing for taps and flick
Differential Revision: https://phab.enlightenment.org/D11029
Mike Blumenkrantz [Mon, 6 Jan 2020 19:26:15 +0000 (14:26 -0500)]
tests/elm: add basic timestamping for event helpers
this enables various internal components which use timestamps to have timestamps
that can be used
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11028
Mike Blumenkrantz [Mon, 6 Jan 2020 18:18:50 +0000 (13:18 -0500)]
efl/gesture: do not emit events for canceled gestures with no state
for non-continuing gestures which have been canceled at this point, we must
not emit events in order to avoid sending useless events which serve no
purpose other than to waste cpu cycles
Reviewed-by: woochan lee <wc0917.lee@samsung.com>
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11027
Cedric BAIL [Thu, 2 Jan 2020 20:10:56 +0000 (12:10 -0800)]
elementary: make focus manager update_children and update_order an internal function to not expose list<>.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11045
Cedric BAIL [Thu, 2 Jan 2020 19:48:45 +0000 (11:48 -0800)]
ecore_con: remove use of list<> from Efl.Net.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11044
Yeongjong Lee [Thu, 30 Jan 2020 11:34:14 +0000 (20:34 +0900)]
efl_ui_widget: remove unused atspi,highlighted/atspi,unhighlighted event in eo
atspi,highlighted/atspi,unhighlighted event is used for only legacy.
They don't need to define in eo file.
@tizen_fix
Change-Id: I88dde7b69be7db3583482f6882d6099692eeb5fe
Jongmin Lee [Wed, 29 Jan 2020 22:14:18 +0000 (07:14 +0900)]
Revert "eolian: enforce that list<> can only be used with @beta API."
This reverts commit
f67fe75517736045549fb61a530856f0709f5d9d.
Ali Alzyod [Wed, 29 Jan 2020 18:30:39 +0000 (19:30 +0100)]
efll.ui.internal_text_interactive: remove useless condition
Summary: Remove useless condition and unreachable return value
Reviewers: woohyun, segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11231
Ali Alzyod [Wed, 29 Jan 2020 15:34:27 +0000 (16:34 +0100)]
config: replace evil tabs with spaces
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11232
Cedric BAIL [Thu, 2 Jan 2020 23:41:36 +0000 (15:41 -0800)]
eolian: enforce that list<> can only be used with @beta API.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11050
Felipe Magno de Almeida [Wed, 29 Jan 2020 15:22:15 +0000 (16:22 +0100)]
C#: Fix using beta for lists and hashes in tests
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11235
Woochanlee [Wed, 29 Jan 2020 14:01:51 +0000 (09:01 -0500)]
ecore_wl2: Fix doc(delete tags).
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11226
Christopher Michael [Wed, 29 Jan 2020 14:01:06 +0000 (09:01 -0500)]
tests/ecore_wl2: Fix check for Enlightenment compositor
ref T8016
Woochanlee [Wed, 29 Jan 2020 14:00:08 +0000 (09:00 -0500)]
tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions.
Summary:
Add dummy tests for below functions.
Updates will be... when there is a better verification method.
ref T8016
Reviewers: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8016
Differential Revision: https://phab.enlightenment.org/D11214
JunsuChoi [Wed, 29 Jan 2020 12:40:28 +0000 (21:40 +0900)]
vg_common_json: Supports transform properties
Summary:
Supports scale, position, and rotation properties
related to transform among properties supported by value provider.
Test Plan:
Remove 'json' in evas-loaders-disabler
build
elementary_test -to "value provider"
(path : layer.box1)
Depends on D11213
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11129
JunsuChoi [Wed, 29 Jan 2020 12:39:53 +0000 (21:39 +0900)]
Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4
Summary:
Change type to matrix4 for 3-axis use when using value provider.
Depends on D11159
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11213
Proht [Sat, 25 Jan 2020 19:06:33 +0000 (19:06 +0000)]
edje_legacy: avoid calling any functions if part is NULL
This avoids calling any functions like _edje_fetch if part is NULL, because it's unnecessary. This does not fix any null pointers, the EINA_SAFE* macros are just used for convenience.
Differential Revision: https://phab.enlightenment.org/D11189
Ali Alzyod [Tue, 28 Jan 2020 17:04:51 +0000 (17:04 +0000)]
efl.ui.textbox: replace strncmp with strcmp for Part
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11218
Ali Alzyod [Tue, 28 Jan 2020 16:36:52 +0000 (16:36 +0000)]
efl.ui.textbox: replace ecore_job with Efl_Future
This patch will replace the use of ecore_job with Efl_Future
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11216
Ali Alzyod [Tue, 28 Jan 2020 16:54:32 +0000 (16:54 +0000)]
efl.ui.textbox: clean up all evas_object related functions from stable methods/interfaces
This patch will:
- Replace all Evas callbacks with unified ones.
- Replace evas_object* methods with unified ones (For **stabilized** methods and interfaces)
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11217
Marcel Hollerbach [Wed, 29 Jan 2020 09:45:24 +0000 (10:45 +0100)]
Revert "eolian: enforce that list<> can only be used with @beta API."
This reverts commit
6b110e578d24b2a99c4c1b158433327a0a43ce1a.
This breaks bindings compilation.
Marcel Hollerbach [Wed, 29 Jan 2020 09:45:06 +0000 (10:45 +0100)]
Revert "mono-test: Fix build break"
This reverts commit
594f00c815d8ee15878071b23f041e5092abe7c2.
This breaks tests
Xavi Artigas [Wed, 29 Jan 2020 09:23:08 +0000 (10:23 +0100)]
mono-test: Fix build break
Recent
6b110e578d24b2a99c4c1b158433327a0a43ce1a forbids list<> in
stable contexts.
Subodh Kumar [Fri, 24 Jan 2020 14:49:03 +0000 (14:49 +0000)]
edje_entry: Add matching tag.
When textblock has several other tags
which are closing as </>, textblock
is not able to find the matching one.
@fix
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D11172
Cedric BAIL [Fri, 3 Jan 2020 19:22:12 +0000 (11:22 -0800)]
elementary: do not use list<> in Efl.Ui.Focus_Manager.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11051
Cedric BAIL [Thu, 2 Jan 2020 23:41:36 +0000 (15:41 -0800)]
eolian: enforce that list<> can only be used with @beta API.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11050
Cedric BAIL [Thu, 2 Jan 2020 23:27:56 +0000 (15:27 -0800)]
efl: mark @beta Efl.Gfx.Event.Render_Post.
This is an oversight during last release. It should not affect anyone as
all the user of this type are marked @beta themself.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11049
Cedric BAIL [Thu, 2 Jan 2020 23:26:44 +0000 (15:26 -0800)]
evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Differential Revision: https://phab.enlightenment.org/D11048
JunsuChoi [Wed, 29 Jan 2020 05:56:05 +0000 (14:56 +0900)]
eina_matrix: Add eina_matrix4 operator(translate, rotate, scale)
Summary:
Add an operator related to the 3D transform in eina_matrix.
enum eina_matrix_axis
EINA_MATRIX_AXIS_X
EINA_MATRIX_AXIS_Y
EINA_MATRIX_AXIS_Z
eina_matrix4_translate
eina_matrix4_scale
eina_matrix4_rotate
eina_matrix4_transpose
Test Plan: src/tests/eina/eina_test_matrix.c
Reviewers: Hermet, bu5hm4n, kimcinoo, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11159
Yeongjong Lee [Wed, 29 Jan 2020 04:46:37 +0000 (13:46 +0900)]
eolian_mono: blacklist c-only internal APIs
Summary: This patch prevent generating c-only internal APIs. C# doesn't need c-only APIs.
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: felipealmeida, Jaehyun_Cho, woohyun
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11151
Change-Id: Id4d1b46952645ff4fb0242a11648e03c4995e205
Yeongjong Lee [Wed, 29 Jan 2020 04:45:56 +0000 (13:45 +0900)]
eolian_mono: change property name from args to Args
Summary: PascalCasing is always used for property names.
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: woohyun, felipealmeida, segfaultxavi
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11149
Yeongjong Lee [Wed, 29 Jan 2020 04:13:10 +0000 (13:13 +0900)]
eolian_mono: generate Efl.IPlayer.PlaybackPosition again
Summary: There is no reason that `efl_player_playback_position_get` is in blacklist..
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11152
Change-Id: I6da9a0882b966264e39973fb36d5570c056cf1ba
JunsuChoi [Tue, 28 Jan 2020 15:36:33 +0000 (16:36 +0100)]
Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation
Summary:
Move autoplay and playback_loop method from Efl.Ui.Vg_Animation/
and The playback_loop changed from looping
because it conflict with the efl_ui_scrollable's symbol.
Efl.Ui.Image and Efl.Ui.Image_Zoomable is needed implements about this method.
So it temporarily set the @empty marker.
ref T8476
Test Plan:
elementary_test -to "Vector Graphics Animation"
check to 'loop'
Reviewers: Hermet, bu5hm4n, zmike, Jaehyun_Cho, jsuya
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers, woohyun, kimcinoo
Tags: #efl
Maniphest Tasks: T8476
Differential Revision: https://phab.enlightenment.org/D11212
Carsten Haitzler (Rasterman) [Tue, 28 Jan 2020 11:17:51 +0000 (11:17 +0000)]
lz4 - sync to latest current lz4 upstream source
Carsten Haitzler (Rasterman) [Tue, 28 Jan 2020 11:00:03 +0000 (11:00 +0000)]
add build conf for win and osx
not sure if they totally work - but based on ci scripts and build
scripts that peolpe do use.
Carsten Haitzler (Rasterman) [Tue, 28 Jan 2020 08:28:10 +0000 (08:28 +0000)]
webp - promote to default on
i just noticed a pattern... we recommend in our sample confs ... to
not disable webp. why keep doing that and why not just make it a dep
on by default you need to explicitly disable? make lives easier and
less complex. it was a good exercise to write these as it points this
out... :)
Yeongjong Lee [Tue, 28 Jan 2020 05:46:10 +0000 (14:46 +0900)]
eolian_mono: make struct immutable
Summary:
Immutable value type is recommeneded for struct type in cs world.
`DO NOT define mutable value types.`
(see, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/struct)
Also, this patch include refactoring of generated struct types.
1. Change field type to property type that have only getter. it will fix CA1051(ref T8397).
2. Remove internal NativeStruct. there is private field for marshalling struct instead.
3. Fix some test cases that change value inside struct. because struct is immutable.
Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: woohyun, felipealmeida, Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8397
Differential Revision: https://phab.enlightenment.org/D11146
Marcel Hollerbach [Mon, 27 Jan 2020 21:49:46 +0000 (06:49 +0900)]
efl_ui_textbox / efl_ui_image_zoomable: remove duplicated code
Summary:
these implementations were totally equal to what is there in
efl_ui_layout. No point in keeping them. (Note, entry_edje is equal to
resize_obj)
ref T8522
Reviewers: segfaultxavi, cedric, zmike, woohyun
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D11141
Yeongjong Lee [Tue, 28 Jan 2020 12:08:20 +0000 (21:08 +0900)]
efl_mono: remove "Event" from event name in efl_csharp_application.cs
"Event" is removed from event name in efl_csharp_application.cs.
This patch is required for
b94538d474a9a3473254a68f54bf4099e8d64095
@tizen_only
Change-Id: I3ffa19e5a13335fb293e6906b8a9f613ce3e5737
Hermet Park [Tue, 28 Jan 2020 09:04:05 +0000 (18:04 +0900)]
canvas vector: fix incorrect caching hit.
animated vector(lottie) caches current playing resource data,
for resuing if it's possible, but it must take care of the drawing size.
Previous logic missed that part, fixed it.
Change-Id: Ic572f4baf330e8a8a09d7ce13f8b12fd84f41b92
Woochanlee [Tue, 28 Jan 2020 07:41:47 +0000 (16:41 +0900)]
ecore_wl2 : Fix keyboard repeate rate formula to Tizen form.
Change-Id: I76bd9bc22d92e4562a3de4f729a805048a441b61
Jihoon Kim [Tue, 28 Jan 2020 01:47:24 +0000 (10:47 +0900)]
edje: Use transaction start and end enum for freezing and thaw
Change-Id: I965999e8c005df750725708d7b89ae3ce91369c2
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
InHong Han [Fri, 23 Mar 2018 06:26:03 +0000 (15:26 +0900)]
edje: Add missing comment
Change-Id: I0aa371a5544ca3007c49291306e62259a3eece7f
InHong Han [Thu, 22 Mar 2018 06:39:36 +0000 (15:39 +0900)]
edje: modified not to send cursor position until the transaction isn't terminated
Change-Id: Iac0183e06b705a54becf8698595c26924d5fa55a
SangHyeon Jade Lee [Wed, 22 Jan 2020 10:24:23 +0000 (19:24 +0900)]
Elementary : add transition_duration_factor in legacy API
Change-Id: I55e7d4d98ba4493f8a987fe22b651f43ca6c61d6
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
godlytalias14573465 [Tue, 21 Jan 2020 11:02:52 +0000 (16:32 +0530)]
[Genlist] Optimization of first item get
Change-Id: I18eae42f7ced7803ea038c01a001239e134ec671
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
Prasoon Singh [Mon, 9 Dec 2019 15:36:05 +0000 (21:06 +0530)]
access: Do not accept children with unacceptable role
Highlight frame on tap does not appear because of obj
with unacceptable role being returned.
Change-Id: I08011738ef43d9574c2789d02349b008a2c0c6a8
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Jongmin Lee [Mon, 27 Jan 2020 21:16:53 +0000 (06:16 +0900)]
spec: disable jp2k evas loader
Change-Id: I9c622a2ccc230608d7370cd97c5f3b83dcce8983
Carsten Haitzler (Rasterman) [Mon, 27 Jan 2020 20:03:13 +0000 (20:03 +0000)]
ecore_con - try an extended bsd workaround by keeping lock open
so keep lock file open for whole duration the socket is bound because
bsd seesm to not do this right... :( (2 things can call bind() on the
same socket with 1 of them block forever).
João Paulo Taylor Ienczak Zanette [Mon, 27 Jan 2020 16:51:53 +0000 (17:51 +0100)]
csharp: Escape contents of struct fields' value tag.
Summary:
In structs' definition, field `<value>` tags weren't scaping
characters, so characters like "&" would lead to invalid XML errors.
Fixes T8588.
Test Plan: Run ninja test.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8588
Differential Revision: https://phab.enlightenment.org/D11202
Marcel Hollerbach [Mon, 27 Jan 2020 16:23:30 +0000 (11:23 -0500)]
ecore_wl2: do not silently return
Summary:
if we are getting a up event after our touch window object is not
focused anymore, then the compositor has sent a invalid up. Beeing
explicit here is important, otherwise we might leak a pressed finger on
the touchscreen.
Depends on D11199
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11200
Marcel Hollerbach [Mon, 27 Jan 2020 16:23:13 +0000 (11:23 -0500)]
ecore_wl2: only ungrab/grab on last/first down/up event
Summary: otherwise we are silently forgetting about up events.
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11199
ali [Fri, 31 May 2019 23:34:50 +0000 (23:34 +0000)]
evas_textblock: <ps> tag respects multiline propertie
previously multi-line property does not effect <ps> tag.
now <ps> is treated visually like <br> when multiline is set to EINA_FALSE
this issue was that each new paragraph will create new line regardless of multi line property value, now only first paragraph will create new line if multi-line property is false, and other paragraphs will use same line
this will also fix the following patch https://phab.enlightenment.org/D8603
And both will use same test suite code
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9064
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 20:16:47 +0000 (20:16 +0000)]
evas - loaders - jp2k - re-enable in the build after it was lost
it seems to have been forgotten. bring it back to building again
@fix
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 15:47:22 +0000 (15:47 +0000)]
add some sample configureations for a few os's
the idea is - if the configure fails .. provide the dep it's asking
for. that simple. the rest of the build is the same (ninja -C build
etc.)
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 15:05:01 +0000 (15:05 +0000)]
pythoin scripts - use /usr/bin/env to fond python3 like the others
Carsten Haitzler (Rasterman) [Sat, 25 Jan 2020 05:08:01 +0000 (05:08 +0000)]
README - update the removal of bullet and libxp and mention harfbuzz
Cedric BAIL [Thu, 2 Jan 2020 23:23:14 +0000 (15:23 -0800)]
eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11046
Cedric BAIL [Thu, 2 Jan 2020 23:24:12 +0000 (15:24 -0800)]
eolian_cxx: move tests of list<> to be protected by @beta.
Reviewed-by: Daniel Kolesa <daniel@octaforge.org>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11047
Simon Tischer [Fri, 24 Jan 2020 07:40:48 +0000 (08:40 +0100)]
theme: fix close issue for notification popup
This gives back the ability to close the notification.
fixes T8316
Hosang Kim [Thu, 23 Jan 2020 14:03:08 +0000 (09:03 -0500)]
efl_ui_layout: send theme signal when style is already updated.
Summary:
If you run below code, text is invisible.
```
efl_add(EFL_UI_BUTTON_CLASS, box,
efl_ui_widget_style_set(efl_added, "anchor"),
efl_text_set(efl_added, "anchor style"),
efl_pack_end(box, efl_added));
```
But below code is working well.
```
efl_add(EFL_UI_BUTTON_CLASS, box,
efl_text_set(efl_added, "anchor style"),
efl_ui_widget_style_set(efl_added, "anchor"),
efl_pack_end(box, efl_added));
```
Test Plan: run efl_ui_theme_example_01
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11118
Ali Alzyod [Thu, 23 Jan 2020 11:31:57 +0000 (12:31 +0100)]
efl.canvas.textblock: annotate obstacle methods as beta
Summary:
We decided to annotate these methods as beta
**obstacle_add**
**obstacle_del**
**obstacles_update**
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8460
Differential Revision: https://phab.enlightenment.org/D11136
Marcel Hollerbach [Thu, 23 Jan 2020 10:14:33 +0000 (11:14 +0100)]
ecore_wl2: fix compilation
Xavi Artigas [Thu, 23 Jan 2020 09:34:29 +0000 (10:34 +0100)]
docs: Slight improvements to eina_types.eot Matrix docs
Reference D11158
JunsuChoi [Thu, 23 Jan 2020 09:15:23 +0000 (10:15 +0100)]
Eolian eina_types: Add Eina.Matrix4 type
Summary: for using in eolian
Test Plan: N/A
Reviewers: Hermet, bu5hm4n, segfaultxavi
Reviewed By: bu5hm4n, segfaultxavi
Subscribers: bu5hm4n, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11158
Ali Alzyod [Thu, 23 Jan 2020 08:54:11 +0000 (08:54 +0000)]
efl.ui.textbox: move file implementation in to internal class
We want to keep implementation for file interface in a safe place and remove it from our side world (eo).
This is a simple copy-paste, from efl.ui.textbox into efl_ui_internal_text_interactive
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11153
JunsuChoi [Thu, 23 Jan 2020 08:36:41 +0000 (17:36 +0900)]
Revert "efl_ui_image: Call unload file when calling file_set"
Summary:
This reverts commit
93bd97025983e48ae8048d0c63b5d8b314f1de42.
efl.ui.image using prev and current inner image object.
Unloading the efl.ui.image class can be unloaded up to the prev image.
And because efl.ui.image is using the image caching feature together,
it may get unexpected errors. Therefore, revert this patch.
Test Plan: N/A
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11157
Ali Alzyod [Wed, 22 Jan 2020 07:33:58 +0000 (07:33 +0000)]
efl_text_interactive: selection enhancment
1- Implement setting selection range programmatically by modifying selection cursors from **efl_text_interactive_selection_cursors_get**
2- Add setter with **efl_text_interactive_selection_cursors_set** to set the range at once (modify start and end)
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: WooHyun Jung <wh0705.jung@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10968
Ali Alzyod [Thu, 23 Jan 2020 07:21:22 +0000 (16:21 +0900)]
evas_object_textblock: treat variation sequence as single run
Summary:
Variation sequence treated as a single run, if we found one, we keep looking adding to the same run, but if it is not, then we need to start a new one.
Before:
{
F3826735}
After:
{
F3826736}
Test Plan:
```
#include <stdio.h>
#include <Elementary.h>
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *en;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("emoji-example", "emoji-example");
elm_win_autodel_set(win, EINA_TRUE);
en = elm_entry_add(win);
elm_entry_scrollable_set(en, EINA_TRUE);
evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_object_text_set(en, "<font_size=25>☪☪️☪가</font_size>");
evas_object_show(en);
elm_object_content_set(win, en);
evas_object_resize(win, 400, 200);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: woohyun, bowonryu
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8542
Differential Revision: https://phab.enlightenment.org/D11096
Ali Alzyod [Thu, 23 Jan 2020 07:07:42 +0000 (16:07 +0900)]
efl.text.interactive: use Eina_Int_Range for selection range event
Summary:
1- add new Eina type (Eina_Int_Range). which represents int range (start, Len).
2- Use this type instead of Efl.Text_Range with selection events.
Reviewers: cedric, woohyun, bu5hm4n, segfaultxavi, zmike
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8570
Differential Revision: https://phab.enlightenment.org/D11128