review.tizen.org Git - profile/ivi/webkit-efl.git/log

projects / profile / ivi / webkit-efl.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

haraken@chromium.org [Wed, 25 Jan 2012 02:47:06 +0000 (02:47 +0000)]

Invalidate r105697, r105766, r105809 and r105805
https://bugs.webkit.org/show_bug.cgi?id=76970

Reviewed by Adam Barth.

I've been trying to stop rebuilding .h/.cpp files generated by
unchanged IDLs (bug 76836), but the approach was wrong.
This patch invalidates patches committed in r105697, r105766,
r105809 and r105805.

In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm
so that they overwrite .h/.cpp files only when the bytes differ.
By this fix, we were able to stop rebuilding .h/.cpp files that are not
changed. However, the fix has made generate-bindings.pl run for almost
all IDLs every time. The reason is as follows:

(0) Assume that there are A.idl, B.idl and C.idl.

(1) Modify A.idl.
(2) First build.
(3) supplemental_dependency.tmp is updated.
(4) generate-bindings.pl runs for A.idl, B.idl and C.idl.
(5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated.

(6) Second build.
(7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(8) B.h, B.cpp, C.h and C.cpp are not updated.

(9) Third build.
(10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(11) B.h, B.cpp, C.h and C.cpp are not updated.
...

We should fix the bug somehow, but how to fix it is not obvious.
For the time being, this patch invalidates r105697, r105766, r105809
and r105805.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(UpdateFile):
* bindings/scripts/CodeGeneratorCPP.pm:
(WriteData):
* bindings/scripts/CodeGeneratorJS.pm:
(WriteData):
* bindings/scripts/CodeGeneratorObjC.pm:
(WriteData):
* bindings/scripts/CodeGeneratorV8.pm:
(WriteData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ericu@chromium.org [Wed, 25 Jan 2012 02:20:00 +0000 (02:20 +0000)]

Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it. This patch
merely enables that, without changing behavior.

* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL): Add missing escaping of URL path.

* page/SecurityOrigin.cpp:
(WebCore::extractInnerURL): Use innerURL member, if it's populated.

* platform/KURL.h:
(WebCore::KURL::innerURL): Add innerURL member.

* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F ['/'] in paths; it's much more readable, and it's safe.

* platform/KURLGooglePrivate.h:
(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ojan@chromium.org [Wed, 25 Jan 2012 02:13:51 +0000 (02:13 +0000)]

Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960

Reviewed by Adam Barth.

Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
on my Mac Pro.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.__init__):
(Bugzilla._get_browser):
(Bugzilla):
(Bugzilla._set_browser):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

barraclough@apple.com [Wed, 25 Jan 2012 02:02:50 +0000 (02:02 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Oliver Hunt.

Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):
    - Track live handle objects in a map.
(WTF::MetaAllocator::release):
    - Removed support for handles with null m_allocator (no longer used).
    - Notify the tracker of handles being released.
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
    - Moved functionality out into MetaAllocator::release.
(WTF::MetaAllocatorHandle::shrink):
    - Removed support for handles with null m_allocator (no longer used).
(WTF::MetaAllocator::MetaAllocator):
    - Initialize m_tracker.
(WTF::MetaAllocator::allocate):
    - Notify the tracker of new allocations.
* wtf/MetaAllocator.h:
(WTF::MetaAllocatorTracker::find):
    - Lookup a MetaAllocatorHandle based on an address inside the allocation.
(WTF::MetaAllocator::trackAllocations):
    - Register a callback object to track allocation state.
* wtf/MetaAllocatorHandle.h:
    - Remove unused createSelfManagedHandle/constructor.
(WTF::MetaAllocatorHandle::key):
    - Added, for use in RedBlackTree.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mrowe@apple.com [Wed, 25 Jan 2012 01:44:57 +0000 (01:44 +0000)]

Death to JavaScriptGlue.

Rubber-stamped by Geoffrey Garen.

.:

* Source/JavaScriptGlue: Removed.
* Source/Makefile: Stop building JavaScriptGlue.

Tools:

* BuildSlaveSupport/build-launcher-app:
(copyNightlyLauncher):
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
* Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
path in conjunction with a cross-platform path.
(ShouldBuildTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Wed, 25 Jan 2012 01:38:00 +0000 (01:38 +0000)]

Mark test as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Wed, 25 Jan 2012 01:19:03 +0000 (01:19 +0000)]

webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836

Reviewed by David Kilzer.

Previously parser_unittests.pl can just test the returned value of
get_function_line_ranges() in prepare-ChangeLog. This patch fixes
parser_unittests.pl so that it also tests the stdout and stderr of
get_function_line_ranges().

This patch adds css_unittests_warning.css, which contains test cases
for warning messages of the CSS parser of prepare-ChangeLog.

* Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
(captureOutput): Captures the stdout and stderr of a given method.
(convertAbsolutepathToWebKitPath): Converts absolute paths in a given
string to relative paths.

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
(element1):
(element2):
(element3):
(element4):
():
(element5):
(element6):

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
Just updated the test results, i.e. added stdout and stderr results.
No essential changes in the test results.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dpranke@chromium.org [Wed, 25 Jan 2012 01:03:34 +0000 (01:03 +0000)]

webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963

Reviewed by Adam Barth.

r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.

* Scripts/new-run-webkit-httpd:
(run):
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Wed, 25 Jan 2012 00:56:23 +0000 (00:56 +0000)]

garden-o-matic pixel zoomer should let you look at every pixel of the image
https://bugs.webkit.org/show_bug.cgi?id=76962

Reviewed by Ojan Vafai.

Previously, you couldn't get up to the right and bottom pixels.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mrowe@apple.com [Wed, 25 Jan 2012 00:27:07 +0000 (00:27 +0000)]

Clear some bogus executable bits that r105828 set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Wed, 25 Jan 2012 00:22:31 +0000 (00:22 +0000)]

Add Linux-specific overrides.

* platform/chromium-linux/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-linux/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enrica@apple.com [Tue, 24 Jan 2012 23:58:42 +0000 (23:58 +0000)]

WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Source/WebKit/mac:

The Inspector bar calls the typingAttributes methods on the clients that support it
to retrieve the set of attributes representing the style at the selection and uses
this information to update the state of the B, I and U buttons.
If this method is not supported, it defaults to the attributes of the previous
character position, reporting an incorrect state.
This occurs only when we have a caret selection.

Reviewed by Alexey Proskuryakov.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
(-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
(-[WebHTMLView typingAttributes]): Added.

Tools:

Added test to verify that WebHTMLView supports the typingAttributes method and that it
works as expected.

Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Tue, 24 Jan 2012 23:53:27 +0000 (23:53 +0000)]

Crash in updateFirstLetter() from unnecessary anonymous block
https://bugs.webkit.org/show_bug.cgi?id=72675

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-24
Reviewed by David Hyatt.

Source/WebCore:

There was a problem with anonymous blocks not getting removed when
their only block flow siblings are removed if they also have non-block
flow first-letter siblings (i.e. floats). This patch modifies
RenderBlock::removeChild() to look for this situation and strip out
unnecessary anonymous container blocks if it occurs.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added
* rendering/RenderBlock.h:
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

LayoutTests:

Adding a test that cause a div to be removed from between a floating
first-letter block and its remaining text. If the anonymous block is
removed as an immediate consequence of the div removal, this shouldn't
crash.

* fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 23:51:14 +0000 (23:51 +0000)]

Mark these tests as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dcheng@chromium.org [Tue, 24 Jan 2012 23:48:23 +0000 (23:48 +0000)]

[chromium] event.dataTransfer.types should not return "Text" or "URL"
https://bugs.webkit.org/show_bug.cgi?id=76218

Source/WebCore:

Per the spec, "Text" and "URL" are special values handled for IE compatibility reasons in
dataTransfer.setData() and dataTransfer.getData(). These values should not be exposed
elsewhere.

Reviewed by Tony Chang.

Test: fast/events/dropzone-005.html

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):

LayoutTests:

Reviewed by Tony Chang.

* editing/pasteboard/dataTransfer-setData-getData-expected.txt:
* fast/events/dropzone-002.html:
* fast/events/dropzone-005-expected.txt: Added.
* fast/events/dropzone-005.html: Modified from LayoutTests/fast/events/dropzone-002.html.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dcheng@chromium.org [Tue, 24 Jan 2012 23:46:49 +0000 (23:46 +0000)]

Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946

Just a const-correctness change.

Reviewed by Tony Chang.

No new tests since no functionality changed.

* dom/DataTransferItemList.h:
(DataTransferItemList):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::length):
* platform/chromium/DataTransferItemListChromium.h:
(DataTransferItemListChromium):
* platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::length):
* platform/qt/DataTransferItemListQt.h:
(DataTransferItemListQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 23:34:39 +0000 (23:34 +0000)]

Update table image baselines after trac.webkit.org/changeset/105775.

* platform/chromium-mac-leopard/fast/table/027-expected.png:
* platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/027-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/027-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.txt: Added.
* platform/chromium-win/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-win/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* platform/chromium-win/fast/table/027-expected.png:
* platform/chromium-win/fast/table/027-vertical-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 23:30:56 +0000 (23:30 +0000)]

More tweaks after leviw's updating of Mac baselines.

* platform/chromium-linux-x86/fast/multicol: Removed.
* platform/chromium-linux/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

tony@chromium.org [Tue, 24 Jan 2012 23:21:09 +0000 (23:21 +0000)]

REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
https://bugs.webkit.org/show_bug.cgi?id=76317

Reviewed by Darin Adler.

Source/WebCore:

Test: scrollbars/scroll-rtl-or-bt-layer.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
scrolling to the just computed offset.

LayoutTests:

* platform/win/Skipped:
* scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
* scrollbars/scroll-rtl-or-bt-layer.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mrowe@apple.com [Tue, 24 Jan 2012 23:14:32 +0000 (23:14 +0000)]

Fix all of the builds after r105812.

* loader/EmptyClients.h: Move the #include in to the correct #if.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mhahnenberg@apple.com [Tue, 24 Jan 2012 22:54:31 +0000 (22:54 +0000)]

Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665

Reviewed by Geoffrey Garen.

* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
Also added a temporary variable to avoid warnings from GCC.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new. Also added a temporary variable to avoid warnings from GCC.
* runtime/JSObject.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dslomov@google.com [Tue, 24 Jan 2012 22:52:24 +0000 (22:52 +0000)]

[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
https://bugs.webkit.org/show_bug.cgi?id=76944.

Reviewed by David Levin.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieveWindowForCallingContext):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

levin@chromium.org [Tue, 24 Jan 2012 22:39:21 +0000 (22:39 +0000)]

Change reference of revokeObjectURL in worker-apply-blob-url-to-xhr.html to use webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=76942

Reviewed by Jian Li.

* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(onmessage):
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ggaren@apple.com [Tue, 24 Jan 2012 22:36:56 +0000 (22:36 +0000)]

Updated bindings test expectations after my last patch.

Not reviewed.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
(WebCore::jsTestOverridingNameGetterPrototypeFunctionAnotherFunction):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Tue, 24 Jan 2012 22:36:00 +0000 (22:36 +0000)]

Change dispatchIntent API to pure virtual in FrameLoaderClient.

The Windows compiler needs this to deal with the forward declaration
of WebCore::IntentRequest.
https://bugs.webkit.org/show_bug.cgi?id=76940

Patch by Greg Billock <gbillock@google.com> on 2012-01-24
Reviewed by Adam Barth.

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
* loader/FrameLoaderClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ggaren@apple.com [Tue, 24 Jan 2012 22:31:41 +0000 (22:31 +0000)]

JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861

Source/JavaScriptCore:

Fixed two failing layout tests after my last patch.

Reviewed by Gavin Barraclough.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort): Call value() after calling toString(), as
in all other cases.

I missed this case because the JSString* type has a valid operator<,
so the compiler didn't complain.

LayoutTests:

Reviewed by Gavin Barraclough.

Added a unit test for something I got wrong while writing this patch.

* fast/js/add-to-primitive-expected.txt: Added.
* fast/js/add-to-primitive.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 22:24:02 +0000 (22:24 +0000)]

CodeGeneratorJS.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76922

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorJS.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated JS*.h and JS*.cpp do not change.

* bindings/scripts/CodeGeneratorJS.pm:
(WriteData): Used UpdateFileIfChanged().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

bdakin@apple.com [Tue, 24 Jan 2012 22:10:32 +0000 (22:10 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=76928
Accelerated drawing should force compositing mode
-and corresponding-
<rdar://problem/10697417>

Reviewed by Simon Fraser.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 22:09:45 +0000 (22:09 +0000)]

CodeGeneratorCPP.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76926

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorCPP.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
Manually confirm that when you add a new attribute to Element.idl,
the time-stamps of unrelated WebDOM*.h and WebDOM*.cpp do not change.

* bindings/scripts/CodeGeneratorCPP.pm:
(WriteData): Used UpdateFileIfChanged().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Tue, 24 Jan 2012 22:04:14 +0000 (22:04 +0000)]

Unreviewed, rolling out r105238.
http://trac.webkit.org/changeset/105238
https://bugs.webkit.org/show_bug.cgi?id=76943

Remove the assert text hack as it served its purpose.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 21:43:43 +0000 (21:43 +0000)]

[Refactoring] In CodeGeneratorGObject.pm, merge
GeneratePrivateHeader() into WriteData()
https://bugs.webkit.org/show_bug.cgi?id=76923

Reviewed by Adam Barth.

This patch merges GeneratePrivateHeader() into WriteData(),
so that all code to output .h/.cpp is managed by WriteData(),
just like other CodeGenerator*.pm does.

No tests. No change in behavior.
Confirm that GTK/GObject build passes.

* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
(WriteData): Copied GeneratePrivateHeader() to here.
Removed $hasLegacyParen, $hasRealParent and $hasParent
since they are not used.
(GenerateInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 21:38:50 +0000 (21:38 +0000)]

Add expected results for test introduced in trac.webkit.org/changeset/105769

* fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Tue, 24 Jan 2012 21:38:40 +0000 (21:38 +0000)]

Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
https://bugs.webkit.org/show_bug.cgi?id=76884

Patch by James Robinson <jamesr@chromium.org> on 2012-01-24
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout.execute):
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
(SheriffIRCBotTest.test_rollout):
(SheriffIRCBotTest.test_revert):
(SheriffIRCBotTest.test_multi_rollout):
(SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dcheng@chromium.org [Tue, 24 Jan 2012 21:32:39 +0000 (21:32 +0000)]

dropzone does not normalize type strings
https://bugs.webkit.org/show_bug.cgi?id=76925

Source/WebCore:

Per the HTML spec, we are supposed to normalize types during dropzone processing by
lowercasing them.

Reviewed by Tony Chang.

Tests: fast/events/dropzone-002.html

* dom/Clipboard.cpp:
(WebCore::Clipboard::hasDropZoneType):

LayoutTests:

Reviewed by Tony Chang.

* fast/events/dropzone-002.html: Update layout test to check case normalization as well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

robert@webkit.org [Tue, 24 Jan 2012 21:31:35 +0000 (21:31 +0000)]

Qt and Gtk results for tests added in r105775

Unreviewed.

* platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Added.
* platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
* platform/qt/fast/css/min-width-with-spanned-cell-expected.txt: Added.
* platform/qt/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 21:27:16 +0000 (21:27 +0000)]

The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
https://bugs.webkit.org/show_bug.cgi?id=75531

Reviewed by David Kilzer.

Previously, the cpp parser of prepare-ChangeLog could not detect a change
outside methods. Consider the following cpp file.

    namespace N {
    int a;     // this change does not appear on ChangeLog.
    class C {
        int b;     // this change does not appear on ChangeLog.
        void f()
        {
            int c;     // this change appears on ChangeLog.
        }
        int d;     // this change does not appear on ChangeLog.
    };
    int e;     // this change does not appear on ChangeLog.
    };

The previous prepare-ChangeLog outputs just methods in which a change is found:
    (N::C::f):

This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
and methods in which a change is found:
    (N):
    (N::C):
    (N::C::f):

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp): Modified as described above.

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
(Class104):
(Class105):
(Class106):
(Class106::func32):
(Class106::func33):
(NameSpace3):
(NameSpace4):
(NameSpace5):
(NameSpace6):
(Class107):
(NameSpace5::NameSpace6::Class107::func34):
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 21:24:32 +0000 (21:24 +0000)]

prepare-ChangeLog outputs warnings for top-level { ... } blocks
https://bugs.webkit.org/show_bug.cgi?id=75943

Reviewed by David Kilzer.

Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
because it does not distinguish '}' at the end of a subroutine
with '}' at the end of a if or for statement.

foo.pl:
    if (1) {
    }
    for (@v) {
    }

output:
    nested functions found at top-level at foo.pl:2
    nested functions found at top-level at foo.pl:4

This patch fixes the bug.

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_perl):
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
Added test cases. No change in the test results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dslomov@google.com [Tue, 24 Jan 2012 21:22:07 +0000 (21:22 +0000)]

Unreviewed: removing WebWorker.h again after r105684.

* WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dpranke@chromium.org [Tue, 24 Jan 2012 21:20:47 +0000 (21:20 +0000)]

r105674 broke check-webkit-style for chromium's test_expectations.

Unreviewed, build fix.

We now need to pass in a platform name of 'chromium' if we want
the chromium port; options.chromium is no longer recognized. I
will follow this patch up with a separate patch that has a test,
but this at least fixes the build.

* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_exepectations_path):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 21:18:36 +0000 (21:18 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Don't expose functions for the ATK interfaces in header files.

Expose only the initialization function for each interface, and
use the generic functions from ATK interfaces where needed.

* accessibility/gtk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionDoAction): Made this function static.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
(webkitAccessibleActionInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceAction.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentRefAccessibleAtPoint): Made this function static.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.
(webkitAccessibleComponentInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentGetAttributeValue): Made this function static.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
(webkitAccessibleDocumentInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextSetRunAttributes): Made this function static.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.
(webkitAccessibleEditableTextInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp:
(webkitAccessibleHyperlinkImplGetHyperlink): Made this function static.
(webkitAccessibleHyperlinkImplInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink): Made this function static.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.
(webkitAccessibleHypertextInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition): Made this function static.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.
(webkitAccessibleImageInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceImage.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp:
(webkitAccessibleSelectionAddSelection): Made this function static.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.
(webkitAccessibleSelectionInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): Made this function static.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.
(webkitAccessibleTableInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceTable.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Made this function static.
(textForObject): Ditto.
(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.
(webkitAccessibleTextInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceText.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue): Made this function static.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
(webkitAccessibleValueInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceValue.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName): Replace call to
webkitAccessibleTextGetText with atk_text_get_text.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

scheib@chromium.org [Tue, 24 Jan 2012 21:09:28 +0000 (21:09 +0000)]

check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Patch by Ojan Vafai <ojan@chromium.org> on 2012-01-20
Reviewed by Dimitri Glazkov.

When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.

Also, got rid of the double-printing of errors when linting through check-webkit-style.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.lint):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
(TestExpectations._add_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
(test_error_on_different_platform):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

jamesr@google.com [Tue, 24 Jan 2012 20:51:34 +0000 (20:51 +0000)]

[chromium] Add null check for ContentLayerChromium::m_delegate back to ContentLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76887

Reviewed by Dimitri Glazkov.

A ContentLayerChromium's m_delegate pointer is nulled out when its owning GraphicsLayerChromium is destroyed.
It's possible in some circumstances for this to happen during painting. The null check for this pointer was
erroneously removed from the base class TiledLayerChromium in r105460.

No new tests since we don't know how to reproduce this sort of layer mutation during paint (not for lack of
trying!). Fix based on crash reports from the field.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::drawsContent):
* platform/graphics/chromium/ContentLayerChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 20:42:52 +0000 (20:42 +0000)]

Chromium Mac Lepoard overrides following the Chromium Mac Snow Leopard baselines.

* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

robert@webkit.org [Tue, 24 Jan 2012 20:32:37 +0000 (20:32 +0000)]

REGRESSION (r102040): Wrong column widths when row has colspan and unwrappable text
https://bugs.webkit.org/show_bug.cgi?id=74874

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/css/min-width-with-spanned-cell-fixed.html
       fast/css/min-width-with-spanned-cell.html

A cell with unwrappable text must be as wide as the text is long. If it is a colspan in a table whose
columns are all percent and the width of the span cell is wider than the cells it spans in any other
row then it will squeeze those cells beyond the width required to display their contents.

To fix this ensure that the squeezing of cells within a span respects the minimum width determined by
their contents. The squeezing remains for fixed layout tables as per FF and Opera.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):

LayoutTests:

* fast/css/min-width-with-spanned-cell-expected.png: Added.
* fast/css/min-width-with-spanned-cell-expected.txt: Added.
* fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
* fast/css/min-width-with-spanned-cell-fixed.html: Added.
* fast/css/min-width-with-spanned-cell.html: Added.
* platform/chromium-linux/fast/table/027-expected.png:
   1 px difference - benign
* platform/chromium-linux/fast/table/027-vertical-expected.png:
   This is a progression - previously the image in the last cell was
   extruding from the table in a 800x600 view.
* platform/chromium-win/fast/table/027-expected.txt:
* platform/chromium-win/fast/table/027-vertical-expected.txt:
* platform/mac/test_expectations.txt: Suppress 027* tests for rebaseline.
* platform/win/test_expectations.txt: ditto
   The 2 tests are skipped on gtk and qt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

tommyw@google.com [Tue, 24 Jan 2012 20:29:44 +0000 (20:29 +0000)]

MediaStream API: Split the MediaStream track list into audio/video specific ones.
https://bugs.webkit.org/show_bug.cgi?id=76614

Source/WebCore:

The latest draft of the WebRTC standard have split the MediaStream combined track list
into audio/video specific ones.

Reviewed by Darin Fisher.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
* mediastream/LocalMediaStream.h:
* mediastream/MediaStream.cpp:
(WebCore::processTrackList):
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
* mediastream/MediaStream.h:
(WebCore::MediaStream::audioTracks):
(WebCore::MediaStream::videoTracks):
* mediastream/MediaStream.idl:
* mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::component):
* mediastream/MediaStreamTrack.h:
* mediastream/UserMediaClient.h:
* mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):
* mediastream/UserMediaRequest.h:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
* platform/mediastream/MediaStreamCenter.h:
* platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::numberOfAudioComponents):
(WebCore::MediaStreamDescriptor::audioComponent):
(WebCore::MediaStreamDescriptor::numberOfVideoComponents):
(WebCore::MediaStreamDescriptor::videoComponent):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Source/WebKit/chromium:

Reviewed by Darin Fisher.

* public/WebUserMediaClient.h:
(WebKit::WebUserMediaClient::requestUserMedia):
* public/WebUserMediaRequest.h:
* public/platform/WebMediaStreamDescriptor.h:
* src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
* src/UserMediaClientImpl.h:
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::sources):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):
(WebKit::WebMediaStreamDescriptor::initialize):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::requestSucceeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Tue, 24 Jan 2012 20:27:06 +0000 (20:27 +0000)]

Unreviewed, rolling out r105738.
http://trac.webkit.org/changeset/105738
https://bugs.webkit.org/show_bug.cgi?id=76930

caused fast/css/getComputedStyle/computed-style-border-
image.html to crash (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

* dom/NamedNodeMap.cpp:
* dom/NamedNodeMap.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::style):
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Tue, 24 Jan 2012 20:24:11 +0000 (20:24 +0000)]

REGRESSION (r73385): Marquee with behavior="alternate" is not working
https://bugs.webkit.org/show_bug.cgi?id=64230

Patch by Parag Radke <nrqv63@motorola.com> on 2012-01-24
Reviewed by Simon Fraser.

Source/WebCore:

This patch gives correct content width for marquee, which computes
correct start position to scroll marquee.

Test: fast/html/marquee-alternate.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
We need(style()->marqueeBehavior() != MALTERNATE) check as we always need the marquee's
actual content width to compute the initial/end position in case of 'MALTERNATE'.
So we need to calculate the logical width in Alternate case even if fixed width is specified
as content has to animate between renderBox().right().x() - contentWidth() and
renderBox().left().x() + contentWidth().

* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
Using PreferredLogicalWidth in place of LayoutOverflow for calculating correct content width.

LayoutTests:

Added a test case to check marquee alternate behavior with fixed width.

* fast/html/marquee-alternate-expected.txt: Added.
* fast/html/marquee-alternate.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

kling@webkit.org [Tue, 24 Jan 2012 20:22:00 +0000 (20:22 +0000)]

RenderInline: Skip caching the computed line height.
<http://webkit.org/b/76929>

Reviewed by David Hyatt.

Stop caching the computed line height on RenderInline and make retrieving it from
RenderStyle slightly cheaper, freeing up 4 bytes per RenderInline instance.
This appears to be mostly performance neutral, I don't get more than the occasional
sample hit when instrumenting heavier web pages.

This reduces memory consumption by 228 kB (both 32/64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::lineHeight):
* rendering/RenderInline.h:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::computedLineHeight):

Optimize computedLineHeight() to mitigate some of the damage of calling
it more often.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ojan@chromium.org [Tue, 24 Jan 2012 20:10:27 +0000 (20:10 +0000)]

check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Reviewed by Dimitri Glazkov.

When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.

Also, got rid of the double-printing of errors when linting through check-webkit-style.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.lint):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
(TestExpectations._add_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
(test_error_on_different_platform):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

inferno@chromium.org [Tue, 24 Jan 2012 20:04:52 +0000 (20:04 +0000)]

Crash when rendering -webkit-column-span.
https://bugs.webkit.org/show_bug.cgi?id=73265

Reviewed by David Hyatt.

Source/WebCore:

This patch addresses 2 problems causing crashes in multi-column layout
1. Trying to render -webkit-column-span for :before, :after caused
   re-entrancy in updateBeforeAfterContent while working on splitFlow.
2. Cloning a block which has its :before, :after content not added yet,
   caused issues because cloneBlock will definitely have its :before,
   :after content created when setStyle() is called. So, we would
   overwrite cloneBlock with a wrong childrenInline value.

Tests: fast/multicol/clone-block-children-inline-mismatch-crash.html
       fast/multicol/span/generated-child-split-flow-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

* fast/multicol/clone-block-children-inline-mismatch-crash-expected.txt: Added.
* fast/multicol/clone-block-children-inline-mismatch-crash.html: Added.
* fast/multicol/span/generated-child-split-flow-crash.html: Added.
* platform/mac-snowleopard/fast/multicol/span: Added.
* platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

robert@webkit.org [Tue, 24 Jan 2012 19:52:10 +0000 (19:52 +0000)]

Incorrect positioning of floating pseudo-elements in table captions
https://bugs.webkit.org/show_bug.cgi?id=76664

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/caption-encloses-overhanging-float-expected.html
fast/table/caption-encloses-overhanging-float.html

Allow table captions to expand and enclose overhanging floats. When performing
layout on a caption ensure that its logical top is set so that it does not mistakenly
conclude that floats in a previous sibling are intruding into it when they're not.

Mostly diagnosed by Abhishek Arya.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats): add table captions to the list
that can enclosed overhanging floats.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layoutCaption): use the best available approximation of the caption's logical
top offset before laying it out.
(WebCore::RenderTable::layout):
* rendering/RenderTable.h:

LayoutTests:

* fast/table/caption-encloses-overhanging-float-expected.html: Added.
* fast/table/caption-encloses-overhanging-float.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 19:40:27 +0000 (19:40 +0000)]

In CodeGeneratorV8.pm, overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76920

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorV8.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated V8*.h and V8*.cpp do not change.

* bindings/scripts/CodeGeneratorV8.pm:
(WriteData): Used UpdateFileIfChanged().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 19:39:28 +0000 (19:39 +0000)]

Similar to the change below, this patch creates Chromium Mac specific
baselines after the Apple Mac changes in
http://trac.webkit.org/changeset/105753.

* fast/block/positioning/028-expected.txt: Added.
* fast/block/positioning/031-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/028-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/031-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
* platform/gtk/fast/block/positioning/028-expected.txt: Removed.
* platform/gtk/fast/block/positioning/031-expected.txt: Removed.
* platform/mac/fast/block/positioning/028-expected.txt: Removed.
* platform/mac/fast/block/positioning/031-expected.txt: Removed.
* platform/qt/fast/block/positioning/028-expected.txt: Removed.
* platform/qt/fast/block/positioning/031-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

alexis.menard@openbossa.org [Tue, 24 Jan 2012 19:26:14 +0000 (19:26 +0000)]

Unreviewed build fix for Qt.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

haraken@chromium.org [Tue, 24 Jan 2012 19:25:00 +0000 (19:25 +0000)]

[Refactoring] Remove finish() from all CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=76918

Reviewed by Darin Adler.

Now finish() is empty in all CodeGenerator*.pm. This patch removes them.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

benjamin@webkit.org [Tue, 24 Jan 2012 19:07:34 +0000 (19:07 +0000)]

pageCacheSupportsPlugins should default to true on WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76891

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-24
Reviewed by Joseph Pecoraro.

The default was left out of r102619 by accident.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Tue, 24 Jan 2012 19:01:36 +0000 (19:01 +0000)]

Another build fix attempt after r105543.

* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_as_multipart_form_data):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

vsevik@chromium.org [Tue, 24 Jan 2012 18:55:52 +0000 (18:55 +0000)]

Web Inspector: incorrect highlight position when searching in console
https://bugs.webkit.org/show_bug.cgi?id=76837

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.clearHighlight):
(WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults):
(WebInspector.ConsoleMessageImpl.prototype._highlightSearchResultsInElement):
(WebInspector.ConsoleMessageImpl.prototype.matchesRegex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

simon.fraser@apple.com [Tue, 24 Jan 2012 18:54:43 +0000 (18:54 +0000)]

Show layer borders for scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=76888

Source/WebCore:

Reviewed by Beth Dakin.

When compositing layer borders are showing, show the borders
for scrollbars layers. This reduces confusion about whether scrollbars
are rendering into their own layers.

Requires a new parameter to two GraphicsLayerClient methods.

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::showDebugBorders):
(WebCore::GraphicsLayer::showRepaintCounter):
* platform/graphics/GraphicsLayerClient.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::showDebugBorders):
(WebCore::RenderLayerBacking::showRepaintCounter):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::showDebugBorders):
(WebCore::RenderLayerCompositor::showRepaintCounter):
* rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

Reviewed by Beth Dakin.

Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):
* src/NonCompositedContentHost.h:
* src/PageOverlay.cpp:
(WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders):
(WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):

Source/WebKit/win:

Reviewed by Beth Dakin.

Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().

* WebView.cpp:
(WebView::showDebugBorders):
(WebView::showRepaintCounter):
* WebView.h:

Source/WebKit2:

Reviewed by Beth Dakin.

Update for new signatures of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().

* UIProcess/LayerTreeHostProxy.h:
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::showDebugBorders):
(WebKit::LayerTreeHostCA::showRepaintCounter):
* WebProcess/WebPage/ca/LayerTreeHostCA.h:
* WebProcess/WebPage/qt/LayerTreeHostQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

levin@chromium.org [Tue, 24 Jan 2012 18:51:50 +0000 (18:51 +0000)]

[windows] Convert usage of GetDC to HWndDC Part 3.
https://bugs.webkit.org/show_bug.cgi?id=76889

Reviewed by Adam Roben.

Source/WebCore:

No new functionality so no new tests.

* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem): Simple replacement.
(WebCore::UniscribeController::shape): Use the delayed allocation.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint): Fix a dc leak and use the dellayed allocation.

Source/WebKit2:

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::paint): Fix a dc leak and use the dellayed allocation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abarth@webkit.org [Tue, 24 Jan 2012 18:49:22 +0000 (18:49 +0000)]

Update Chromium-specific baselines that used to use Apple Mac results
before http://trac.webkit.org/changeset/105744.

* platform/chromium-mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Added.
* platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 18:48:50 +0000 (18:48 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Fix coding style in the ATK AccessibilityObject wrapper.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
(webkitAccessibleGetParent):
(webkitAccessibleGetNChildren):
(webkitAccessibleRefChild):
(webkitAccessibleGetIndexInParent):
(webkitAccessibleGetAttributes):
(atkRole):
(webkitAccessibleGetRole):
(setAtkStateSetFromCoreObject):
(webkitAccessibleRefStateSet):
(webkitAccessibleRefRelationSet):
(webkitAccessibleInit):
(webkitAccessibleFinalize):
(webkit_accessible_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

leviw@chromium.org [Tue, 24 Jan 2012 18:41:15 +0000 (18:41 +0000)]

Update Snow Leopard image test expectations
https://bugs.webkit.org/show_bug.cgi?id=76869

Rubber stamped by Simon Fraser.

Addingmore SnowLeopard image expectations for tests failing due to subtle differences in rendering
between SnowLeopard and Lion. Also fixing those that hadn't been updated to the new mock scrollbars.

* platform/mac-snowleopard/css3/filters: Added.
* platform/mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
* platform/mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
* platform/mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-custom-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-custom-parameters-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
* platform/mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/mac-snowleopard/css3/filters/filter-region-expected.png: Added.
* platform/mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
* platform/mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
* platform/mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
* platform/mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
* platform/mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
* platform/mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
* platform/mac-snowleopard/css3/images: Added.
* platform/mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
* platform/mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
* platform/mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
* platform/mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
* platform/mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
* platform/mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3: Added.
* platform/mac-snowleopard/css3/selectors3/html: Added.
* platform/mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39b-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39c-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xhtml: Added.
* platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39a-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39b-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39c-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xml: Added.
* platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Added.
* platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Added.
* platform/mac-snowleopard/editing/inserting: Added.
* platform/mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
* platform/mac-snowleopard/editing/pasteboard: Added.
* platform/mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
* platform/mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/mac-snowleopard/editing/selection: Added.
* platform/mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
* platform/mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content: Added.
* platform/mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/list-type-after-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/list-type-before-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added.
* platform/mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds: Added.
* platform/mac-snowleopard/fast/backgrounds/repeat: Added.
* platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds/size: Added.
* platform/mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/mac-snowleopard/fast/block/basic: Added.
* platform/mac-snowleopard/fast/block/basic/truncation-rtl-expected.png: Added.
* platform/mac-snowleopard/fast/block/float: Added.
* platform/mac-snowleopard/fast/block/float/020-expected.png: Added.
* platform/mac-snowleopard/fast/block/float/float-avoidance-expected.png: Added.
* platform/mac-snowleopard/fast/block/margin-collapse/103-expected.png:
* platform/mac-snowleopard/fast/block/positioning: Added.
* platform/mac-snowleopard/fast/block/positioning/028-expected.png: Added.
* platform/mac-snowleopard/fast/block/positioning/031-expected.png: Added.
* platform/mac-snowleopard/fast/borders: Added.
* platform/mac-snowleopard/fast/borders/border-image-massive-scale-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-scale-transform-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-scaled-expected.png: Added.
* platform/mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/mac-snowleopard/fast/borders/inline-mask-overlay-image-expected.png: Added.
* platform/mac-snowleopard/fast/borders/rtl-border-01-expected.png: Added.
* platform/mac-snowleopard/fast/borders/rtl-border-02-expected.png: Added.
* platform/mac-snowleopard/fast/borders/rtl-border-03-expected.png: Added.
* platform/mac-snowleopard/fast/canvas: Added.
* platform/mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/mac-snowleopard/fast/canvas/canvas-incremental-repaint-expected.png: Added.
* platform/mac-snowleopard/fast/canvas/shadow-offset-7-expected.png: Added.
* platform/mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/mac-snowleopard/fast/css/background-shorthand-invalid-url-expected.png: Added.
* platform/mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/mac-snowleopard/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
* platform/mac-snowleopard/fast/css/color-correction-on-background-image-expected.png: Added.
* platform/mac-snowleopard/fast/css/continuationCrash-expected.png: Added.
* platform/mac-snowleopard/fast/css/font-family-pictograph-expected.png: Added.
* platform/mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
* platform/mac-snowleopard/fast/css/outline-narrowLine-expected.png: Added.
* platform/mac-snowleopard/fast/css/text-overflow-input-expected.png: Added.
* platform/mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
* platform/mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
* platform/mac-snowleopard/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
* platform/mac-snowleopard/fast/dom/52776-expected.png:
* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
* platform/mac-snowleopard/fast/encoding: Added.
* platform/mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Added.
* platform/mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Added.
* platform/mac-snowleopard/fast/forms/basic-textareas-expected.png:
* platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png:
* platform/mac-snowleopard/fast/forms/fieldset-align-expected.png:
* platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
* platform/mac-snowleopard/fast/forms/form-hides-table-expected.png:
* platform/mac-snowleopard/fast/forms/input-table-expected.png:
* platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
* platform/mac-snowleopard/fast/forms/textAreaLineHeight-expected.png:
* platform/mac-snowleopard/fast/forms/textarea-scroll-height-expected.png:
* platform/mac-snowleopard/fast/gradients: Added.
* platform/mac-snowleopard/fast/gradients/crash-on-zero-radius-expected.png: Added.
* platform/mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
* platform/mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
* platform/mac-snowleopard/fast/gradients/gradient-after-transparent-border-expected.png: Added.
* platform/mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
* platform/mac-snowleopard/fast/images: Added.
* platform/mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
* platform/mac-snowleopard/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
* platform/mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
* platform/mac-snowleopard/fast/images/pdf-as-background-expected.png: Added.
* platform/mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
* platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
* platform/mac-snowleopard/fast/inline: Added.
* platform/mac-snowleopard/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
* platform/mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Added.
* platform/mac-snowleopard/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
* platform/mac-snowleopard/fast/lists: Added.
* platform/mac-snowleopard/fast/lists/003-expected.png: Added.
* platform/mac-snowleopard/fast/media: Added.
* platform/mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/column-rules-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/column-rules-stacking-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/float-avoidance-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/float-multicol-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/float-paginate-complex-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/layers-in-multicol-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/nested-columns-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/overflow-across-columns-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/positive-leading-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/single-line-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span: Added.
* platform/mac-snowleopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* platform/mac-snowleopard/fast/overflow/006-expected.png: Added.
* platform/mac-snowleopard/fast/overflow/overflow-focus-ring-expected.png: Added.
* platform/mac-snowleopard/fast/overflow/overflow-x-y-expected.png:
* platform/mac-snowleopard/fast/parser: Added.
* platform/mac-snowleopard/fast/parser/document-write-option-expected.png: Added.
* platform/mac-snowleopard/fast/reflections: Added.
* platform/mac-snowleopard/fast/reflections/reflection-direction-expected.png: Added.
* platform/mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
* platform/mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
* platform/mac-snowleopard/fast/reflections/reflection-masks-outset-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/text-shadow-expected.png: Added.
* platform/mac-snowleopard/fast/repaint/text-shadow-horizontal-expected.png: Added.
* platform/mac-snowleopard/fast/replaced: Added.
* platform/mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
* platform/mac-snowleopard/fast/replaced/width100percent-button-expected.png: Added.
* platform/mac-snowleopard/fast/ruby: Added.
* platform/mac-snowleopard/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/mac-snowleopard/fast/selectors: Added.
* platform/mac-snowleopard/fast/selectors/166-expected.png: Added.
* platform/mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
* platform/mac-snowleopard/fast/table: Added.
* platform/mac-snowleopard/fast/table/auto-100-percent-width-expected.png: Added.
* platform/mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
* platform/mac-snowleopard/fast/table/frame-and-rules-expected.png: Added.
* platform/mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
* platform/mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
* platform/mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png:
* platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.png: Added.
* platform/mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
* platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/mac-snowleopard/fast/text/hyphens-expected.png: Added.
* platform/mac-snowleopard/fast/text/international/bidi-menulist-expected.png: Added.
* platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac-snowleopard/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
* platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
* platform/mac-snowleopard/fast/text/midword-break-after-breakable-char-expected.png: Added.
* platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
* platform/mac-snowleopard/fast/text/stroking-decorations-expected.png: Added.
* platform/mac-snowleopard/fast/text/stroking-expected.png: Added.
* platform/mac-snowleopard/fast/text/text-letter-spacing-expected.png: Added.
* platform/mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
* platform/mac-snowleopard/fast/text/wbr-expected.png: Added.
* platform/mac-snowleopard/fast/text/whitespace: Added.
* platform/mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/mac-snowleopard/fast/writing-mode: Added.
* platform/mac-snowleopard/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
* platform/mac-snowleopard/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
* platform/mac-snowleopard/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
* platform/mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Added.
* platform/mac-snowleopard/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
* platform/mac-snowleopard/fonts: Added.
* platform/mac-snowleopard/fonts/cursive-expected.png: Added.
* platform/mac-snowleopard/fonts/default-expected.png: Added.
* platform/mac-snowleopard/fonts/fantasy-expected.png: Added.
* platform/mac-snowleopard/fonts/monospace-expected.png: Added.
* platform/mac-snowleopard/fonts/sans-serif-expected.png: Added.
* platform/mac-snowleopard/fonts/serif-expected.png: Added.
* platform/mac-snowleopard/fullscreen: Added.
* platform/mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
* platform/mac-snowleopard/http/tests/media: Added.
* platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
* platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/mac-snowleopard/http/tests/security: Added.
* platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Added.
* platform/mac-snowleopard/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
* platform/mac-snowleopard/media/controls-layout-direction-expected.png: Added.
* platform/mac-snowleopard/media/controls-without-preload-expected.txt: Added.
* platform/mac-snowleopard/media/media-document-audio-repaint-expected.png: Added.
* platform/mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
* platform/mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
* platform/mac-snowleopard/media/video-colorspace-yuv420-expected.png: Added.
* platform/mac-snowleopard/media/video-colorspace-yuv422-expected.png: Added.
* platform/mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
* platform/mac-snowleopard/media/video-layer-crash-expected.png:
* platform/mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
* platform/mac-snowleopard/media/video-zoom-expected.png: Added.
* platform/mac-snowleopard/platform/mac/editing: Added.
* platform/mac-snowleopard/platform/mac/editing/selection: Added.
* platform/mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
* platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
* platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
* platform/mac-snowleopard/platform/mac/scrollbars: Added.
* platform/mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
* platform/mac-snowleopard/plugins: Added.
* platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Added.
* platform/mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
* platform/mac-snowleopard/printing: Added.
* platform/mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
* platform/mac-snowleopard/printing/media-queries-print-expected.png: Added.
* platform/mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
* platform/mac-snowleopard/printing/return-from-printing-mode-expected.png: Added.
* platform/mac-snowleopard/scrollbars: Added.
* platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
* platform/mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Added.
* platform/mac-snowleopard/tables: Added.
* platform/mac-snowleopard/tables/mozilla: Added.
* platform/mac-snowleopard/tables/mozilla/bugs: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug10269-2-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug1055-1-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug2479-1-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug3977-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug5835-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug7112-1-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/bugs/bug7112-2-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/collapsing_borders: Added.
* platform/mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core: Added.
* platform/mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/cell_heights-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_fix-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/nested1-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/one_row-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_index-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/other: Added.
* platform/mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/other/nestedTables-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/other/test3-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/other/test6-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
* platform/mac-snowleopard/transforms: Added.
* platform/mac-snowleopard/transforms/2d: Added.
* platform/mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
* platform/mac-snowleopard/transforms/2d/transform-fixed-container-expected.png: Added.
* platform/mac-snowleopard/transforms/3d: Added.
* platform/mac-snowleopard/transforms/3d/general: Added.
* platform/mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/mac-snowleopard/transforms/3d/point-mapping: Added.
* platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/mac-snowleopard/webarchive: Added.
* platform/mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
* platform/mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
* platform/mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 18:37:45 +0000 (18:37 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Cleanup the list of includes in WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Removes
'include' lines that are no longer needed after the refactor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

kubo@profusion.mobi [Tue, 24 Jan 2012 18:34:56 +0000 (18:34 +0000)]

[EFL] Remove CookieJarEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=76916

Reviewed by Gustavo Noronha Silva.

CookieJarEfl.cpp has not been used for years -- we either need
CookieJarCurl or CookieJarSoup depending on the chosen network
backend.

No new tests, just an unused file being removed.

* WebCore.gypi: Remove reference to CookieJarEfl.cpp.
* platform/efl/CookieJarEfl.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

inferno@chromium.org [Tue, 24 Jan 2012 18:33:05 +0000 (18:33 +0000)]

Crash when accessing removed parent in InlineTextBox.
https://bugs.webkit.org/show_bug.cgi?id=72982

Reviewed by James Robinson.

Source/WebCore:

The crash happens because:
1. We add heading element(h1) before the span element(span1),
   causing splitflow on the anonymous block containing BeforeText,
   span1(and SpanText) and AfterText.
2. span1 moves to the cloneBlock (continuation).
3. Our anonymous block and cloneBlock are both marked for layout,
   however we still have a copy of our lineboxes with its childs
   as the textboxes belonging to SpanText.
4. Our anonymous block only child BeforeText is getting removed,
   so we dont have any children anymore and we delete our lineboxes,
   leaving behind the children textboxes belonging to SpanText.
5. SpanText is getting destroyed, so it tries to inform removed
   parent lineboxes causing the crash.

Test: fast/block/block-remove-child-delete-line-box-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

Tests passes if it does not crash on ASSERT(!m_hasBadParent)
in InlineBox::parent().

* fast/block/block-remove-child-delete-line-box-crash-expected.txt: Added.
* fast/block/block-remove-child-delete-line-box-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 18:28:22 +0000 (18:28 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkTable interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceTable.cpp: Added.
(core):
(cell):
(cellIndex):
(cellAtIndex):
(webkitAccessibleTableInterfaceInit):
(webkitAccessibleTableRefAt):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
(webkitAccessibleTableGetCaption):
(webkitAccessibleTableGetColumnDescription):
(webkitAccessibleTableGetRowDescription):
* accessibility/gtk/WebKitAccessibleInterfaceTable.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkTable interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceTable.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

vsevik@chromium.org [Tue, 24 Jan 2012 18:25:08 +0000 (18:25 +0000)]

Web Inspector: Scripts panel tabbed editor container should have gray background when there are no open tabs.
https://bugs.webkit.org/show_bug.cgi?id=76903

Reviewed by Yury Semikhatsky.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._updateTabElements):
* inspector/front-end/tabbedPane.css:
(.tabbed-pane-content.has-no-tabs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

vsevik@chromium.org [Tue, 24 Jan 2012 18:22:43 +0000 (18:22 +0000)]

Web Inspector: OpenResourceDialog should work when there are no open tabs in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=76907

Reviewed by Yury Semikhatsky.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.install):
* inspector/front-end/ScriptsPanel.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

sergio@webkit.org [Tue, 24 Jan 2012 18:03:06 +0000 (18:03 +0000)]

[WK2] [GTK] TestDownloads hitting an assertion in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=76915

Reviewed by Martin Robinson.

No new tests required as it fixes some assertions in a unit test.

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 18:02:08 +0000 (18:02 +0000)]

Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
https://bugs.webkit.org/show_bug.cgi?id=76868

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
Reviewed by Yury Semikhatsky.

Configurations of (hopefully) all build systems are fixed.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.py:
(dash_to_camelcase):
(InspectorFrontend_h):
(InspectorBackendDispatcher_h):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

leviw@chromium.org [Tue, 24 Jan 2012 17:57:42 +0000 (17:57 +0000)]

Update Snow Leopard image test expectations
https://bugs.webkit.org/show_bug.cgi?id=76869

Reviewed by Simon Fraser.

Adding SnowLeopard image expectations for tests failing due to subtle differences in rendering
between SnowLeopard and Lion. Also fixing those that hadn't been updated to the new mock scrollbars.

* platform/mac-snowleopard/animations: Added.
* platform/mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
* platform/mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
* platform/mac-snowleopard/animations/suspend-transform-animation-expected.png: Added.
* platform/mac-snowleopard/compositing/color-matching: Added.
* platform/mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
* platform/mac-snowleopard/compositing/flat-with-transformed-child-expected.png: Added.
* platform/mac-snowleopard/compositing/framesets: Added.
* platform/mac-snowleopard/compositing/framesets/composited-frame-alignment-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry: Added.
* platform/mac-snowleopard/compositing/geometry/clipping-foreground-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/composited-html-size-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/fixed-in-composited-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/foreground-layer-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/repaint-foreground-layer-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/root-layer-update-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/mac-snowleopard/compositing/iframes: Added.
* platform/mac-snowleopard/compositing/iframes/composited-iframe-scroll-expected.png: Added.
* platform/mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Added.
* platform/mac-snowleopard/compositing/images: Added.
* platform/mac-snowleopard/compositing/images/content-image-change-expected.png: Added.
* platform/mac-snowleopard/compositing/images/direct-image-background-color-expected.png: Added.
* platform/mac-snowleopard/compositing/images/direct-pdf-image-expected.png: Added.
* platform/mac-snowleopard/compositing/images/direct-svg-image-expected.png: Added.
* platform/mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
* platform/mac-snowleopard/compositing/masks: Added.
* platform/mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
* platform/mac-snowleopard/compositing/masks/simple-composited-mask-expected.png: Added.
* platform/mac-snowleopard/compositing/overflow: Added.
* platform/mac-snowleopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
* platform/mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/mac-snowleopard/compositing/overflow/overflow-positioning-expected.png: Added.
* platform/mac-snowleopard/compositing/overflow/overflow-scroll-expected.png: Added.
* platform/mac-snowleopard/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
* platform/mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections: Added.
* platform/mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-opacity-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/reflection-opacity-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/remove-add-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png: Added.
* platform/mac-snowleopard/compositing/repaint: Added.
* platform/mac-snowleopard/compositing/repaint/same-size-invalidation-expected.png: Added.
* platform/mac-snowleopard/compositing/scaling: Added.
* platform/mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/mac-snowleopard/compositing/scrollbar-painting-expected.png: Added.
* platform/mac-snowleopard/compositing/self-painting-layers-expected.png: Added.
* platform/mac-snowleopard/compositing/shadows: Added.
* platform/mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/mac-snowleopard/compositing/tiling: Added.
* platform/mac-snowleopard/compositing/tiling/constrained-layer-size-expected.png: Added.
* platform/mac-snowleopard/compositing/transitions: Added.
* platform/mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png: Added.
* platform/mac-snowleopard/compositing/video: Added.
* platform/mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
* platform/mac-snowleopard/compositing/visibility: Added.
* platform/mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Added.
* platform/mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
* platform/mac-snowleopard/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
* platform/mac-snowleopard/compositing/webgl: Added.
* platform/mac-snowleopard/compositing/webgl/webgl-background-color-expected.png: Added.
* platform/mac-snowleopard/compositing/webgl/webgl-no-alpha-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties: Added.
* platform/mac-snowleopard/css1/box_properties/border_bottom-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/border_left-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/border_right_inline-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/margin_inline-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/margin_left-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/margin_right-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/padding_bottom_inline-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/padding_inline-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/padding_left-expected.png: Added.
* platform/mac-snowleopard/css1/box_properties/padding_right-expected.png: Added.
* platform/mac-snowleopard/css1/cascade: Added.
* platform/mac-snowleopard/css1/cascade/important-expected.png: Added.
* platform/mac-snowleopard/css1/classification: Added.
* platform/mac-snowleopard/css1/classification/display-expected.png: Added.
* platform/mac-snowleopard/css1/color_and_background: Added.
* platform/mac-snowleopard/css1/color_and_background/background_image-expected.png: Added.
* platform/mac-snowleopard/css1/color_and_background/background_position-expected.png: Added.
* platform/mac-snowleopard/css1/color_and_background/background_repeat-expected.png: Added.
* platform/mac-snowleopard/css1/font_properties/font-expected.png:
* platform/mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
* platform/mac-snowleopard/css1/formatting_model: Added.
* platform/mac-snowleopard/css1/formatting_model/inline_elements-expected.png: Added.
* platform/mac-snowleopard/css1/pseudo: Added.
* platform/mac-snowleopard/css1/pseudo/firstletter-expected.png: Added.
* platform/mac-snowleopard/css1/pseudo/firstline-expected.png: Added.
* platform/mac-snowleopard/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
* platform/mac-snowleopard/css1/pseudo/pseudo_elements_in_selectors-expected.png: Added.
* platform/mac-snowleopard/css1/text_properties: Added.
* platform/mac-snowleopard/css1/text_properties/text_decoration-expected.png: Added.
* platform/mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
* platform/mac-snowleopard/css1/units: Added.
* platform/mac-snowleopard/css1/units/urls-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/block-replaced-height-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/block-replaced-width-006-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-height-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-width-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-width-002-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-width-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-width-004-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-width-005-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/float-replaced-width-011-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/height-width-table-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-002-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-003-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-004-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-005-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-006-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-007-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-008-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-009-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-010-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-012-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-013-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-014-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/margin-applies-to-015-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
* platform/mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
* platform/mac-snowleopard/css2.1/20110323/width-replaced-element-001-expected.png: Added.
* platform/mac-snowleopard/css2.1/t051201-c23-first-line-00-b-expected.png: Added.
* platform/mac-snowleopard/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
* platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png:
* platform/mac-snowleopard/css2.1/t1508-c527-font-01-b-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

vsevik@chromium.org [Tue, 24 Jan 2012 17:46:09 +0000 (17:46 +0000)]

Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
https://bugs.webkit.org/show_bug.cgi?id=76868

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
Reviewed by Yury Semikhatsky.

Configurations of (hopefully) all build systems are fixed.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.py:
(dash_to_camelcase):
(InspectorFrontend_h):
(InspectorBackendDispatcher_h):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Tue, 24 Jan 2012 16:59:09 +0000 (16:59 +0000)]

[Qt] Unreviewed gardening. Unskip now passing tests and add/update platform specific expected files for them.

* platform/qt/Skipped:
* platform/qt/dom/xhtml/level3/core/canonicalform08-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/canonicalform08-expected.txt:
* platform/qt/dom/xhtml/level3/core/canonicalform09-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/canonicalform09-expected.txt:
* platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
* platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
* platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
* platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
* platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
* platform/qt/editing/pasteboard/paste-noscript-expected.png: Added.
* platform/qt/editing/pasteboard/paste-noscript-expected.txt: Added.
* platform/qt/editing/style/style-3681552-fix-001-expected.png: Added.
* platform/qt/editing/style/style-3681552-fix-001-expected.txt:
* platform/qt/editing/style/style-3681552-fix-002-expected.png: Added.
* platform/qt/editing/style/style-3681552-fix-002-expected.txt: Copied from LayoutTests/platform/qt/editing/style/typing-style-002-expected.txt.
* platform/qt/editing/style/style-boundary-002-expected.png: Added.
* platform/qt/editing/style/style-boundary-002-expected.txt:
* platform/qt/editing/style/style-boundary-003-expected.png: Added.
* platform/qt/editing/style/style-boundary-003-expected.txt:
* platform/qt/editing/style/style-boundary-005-expected.png: Added.
* platform/qt/editing/style/style-boundary-005-expected.txt:
* platform/qt/editing/style/typing-style-001-expected.png: Added.
* platform/qt/editing/style/typing-style-001-expected.txt:
* platform/qt/editing/style/typing-style-002-expected.png: Added.
* platform/qt/editing/style/typing-style-002-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Tue, 24 Jan 2012 16:58:44 +0000 (16:58 +0000)]

Build fix attempt after r105543.

* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_as_multipart_form_data):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 16:22:57 +0000 (16:22 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkValue interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceValue.cpp: Added.
(core):
(webkitAccessibleValueInterfaceInit):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
* accessibility/gtk/WebKitAccessibleInterfaceValue.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkValue interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceValue.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

antti@apple.com [Tue, 24 Jan 2012 16:09:05 +0000 (16:09 +0000)]

Reduce internal use of CSSStyleDeclaration base class
https://bugs.webkit.org/show_bug.cgi?id=76904

Reviewed by Andreas Kling.

Internally WebCore should use the more specific CSSMutableStyleDeclaration and CSSComputedStyleDeclaration types.
The CSSStyleDeclaration base should be used in the DOM API functions only. This will make it easier to separate
internal style sheet implementation from the DOM in the future.

- Switch CSSStyleDeclaration -> CSSMutableStyleDeclaration where feasible
- Use StyledElement::ensureInlineStyleDecl() instead of Element::style() (which is a DOM API function)
- Remove Attribute::style() which looks like a DOM API function but is not exposed.

* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
* dom/Attr.h:
(WebCore::Attr::style):
* dom/Attribute.h:
* editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
* editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
* page/PageSerializer.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

kling@webkit.org [Tue, 24 Jan 2012 15:42:07 +0000 (15:42 +0000)]

Make elements that don't have attributes smaller.
<http://webkit.org/b/76876>

Reviewed by Antti Koivisto.

Move the inline style declaration from StyledElement to NamedNodeMap, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.

This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
(WebCore::NamedNodeMap::createInlineStyleDecl):
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::inlineStyleDecl):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

noam.rosenthal@nokia.com [Tue, 24 Jan 2012 15:17:11 +0000 (15:17 +0000)]

[Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
https://bugs.webkit.org/show_bug.cgi?id=76877

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add BitmapTexture::updateRawContents(), which allows uploading image data to a texture
without changing its format or swizzling RGB. The data has to be in the texture's native
format.

No new tests, this affects performance on all existing tests.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateRawContents):
* platform/graphics/qt/TextureMapperQt.cpp:
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::updateRawContents):
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
* platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Instead of copying QImages, pass a reference to the ShareableBitmap that was originally
created by the web process. Also, swizzle the image's RGB in the web process, before it's
transferred to the UI process.

Data flow before change:
(Web Process) Render to image -> IPC -> (UI Process) Copy (render queue) -> Copy Swizzled RGB -> Upload

Data flow after change:
(Web Process) Render to image -> swizzle RGB -> IPC -> (UI Process) -> Upload

* Shared/ShareableBitmap.h:
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::swizzleRGB):
* UIProcess/LayerTreeHostProxy.h:
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::adoptImageBackingStore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 14:53:31 +0000 (14:53 +0000)]

Unreviewed, skip WK2 API test timing out on some GTK bots.

WebKit2APITests/TestDownloads is consistently timing out on the
32bit release and 64bit debug bots.

* Scripts/run-gtk-tests:
(TestRunner): Skip WebKit2APITests/TestDownloads.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

loislo@chromium.org [Tue, 24 Jan 2012 14:35:36 +0000 (14:35 +0000)]

Web Inspector: inspector/debugger/dom-breakpoints.html started to fail after r105642
https://bugs.webkit.org/show_bug.cgi?id=76908

Reviewed by Yury Semikhatsky.

* css/CSSMutableStyleDeclaration.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Tue, 24 Jan 2012 13:58:04 +0000 (13:58 +0000)]

[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846

Reviewed by Tor Arne Vestbø.

* bindings/scripts/CodeGeneratorJS.pm: Warning fix after r105683.
(WriteData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Tue, 24 Jan 2012 13:32:07 +0000 (13:32 +0000)]

[Qt] Fix the build with the newes Qt5 hashes
https://bugs.webkit.org/show_bug.cgi?id=76657

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-01-24
Reviewed by Simon Hausmann.

Source/WebCore:

No new tests needed.

* platform/graphics/cairo/OpenGLShims.cpp:
(WebCore::getProcAddress): Adopt API changes.

Tools:

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Tue, 24 Jan 2012 13:30:53 +0000 (13:30 +0000)]

[Qt][WK2] QtWebIconDatabaseClient leaves a dangling pointer on WebIconDatabase after its destruction
https://bugs.webkit.org/show_bug.cgi?id=76399

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-24
Reviewed by Simon Hausmann.

Due a circular dependency between WebContext and WebProcessProxy, WebContext it not
being destroyed, neither WebIconDatabase. As QtWebIconDatabaseClient's life time is the same
as QtWebContext and this one is being destroyed, the remaining reference to our client
on WebIconDatabase should be cleaned upon its destruction.

* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::~QtWebIconDatabaseClient): Clear client pointer on WebIconDatabase.
* UIProcess/qt/QtWebIconDatabaseClient.h: Make this client hold a reference to WebIconDatabase.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Tue, 24 Jan 2012 13:28:08 +0000 (13:28 +0000)]

[Qt] Incremental build problem.
https://bugs.webkit.org/show_bug.cgi?id=74687

It is necessary to set mathattrs.in dependency for generating MathMLNames.cpp file.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-01-24
Reviewed by Csaba Osztrogonác.

* DerivedSources.pri:
I added missing depend.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

tkent@chromium.org [Tue, 24 Jan 2012 12:55:05 +0000 (12:55 +0000)]

[Chromium] Update test expectation

* platform/chromium/test_expectations.txt:
perf/adding-radio-buttons.html is TEXT on Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

vestbo@webkit.org [Tue, 24 Jan 2012 12:31:00 +0000 (12:31 +0000)]

[Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables

We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
building with MinGW inside cmd.exe will require the same construct. Instead
we assume that when the first character in PWD is a '/' we're running under
Cygwin, and use the normal unix way of setting environment variables.

Reviewed by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

zeno.albisser@nokia.com [Tue, 24 Jan 2012 12:28:31 +0000 (12:28 +0000)]

[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933

Add a test that checks handling of url strings.
Add a test that verifies replies in case of multiple
available application url schemes.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 12:25:13 +0000 (12:25 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkSelection interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp: Added.
(core):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkitAccessibleSelectionInterfaceInit):
(webkitAccessibleSelectionAddSelection):
(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionRefSelection):
(webkitAccessibleSelectionGetSelectionCount):
(webkitAccessibleSelectionIsChildSelected):
(webkitAccessibleSelectionRemoveSelection):
(webkitAccessibleSelectionSelectAllSelection):
* accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkSelection interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceSelection.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 12:04:16 +0000 (12:04 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkImage interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceImage.cpp: Added.
(core):
(webkitAccessibleImageInterfaceInit):
(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageDescription):
(webkitAccessibleImageGetImageSize):
* accessibility/gtk/WebKitAccessibleInterfaceImage.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkImage interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceImage.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 11:58:52 +0000 (11:58 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkHypertext interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp: Added.
(core):
(webkitAccessibleHypertextInterfaceInit):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
* accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkHypertext interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceHypertext.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 11:55:18 +0000 (11:55 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkHyperlinkImpl interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp: Added.
(webkitAccessibleHyperlinkImplInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
* accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkHyperlinkImpl interface.
(webkit_accessible_class_init):

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceHyperlinkImpl.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

carlosgc@webkit.org [Tue, 24 Jan 2012 11:49:47 +0000 (11:49 +0000)]

[GTK] Fix /webkit2/WebKitWebView/reload after r105688
https://bugs.webkit.org/show_bug.cgi?id=76898

Reviewed by Alejandro G. Castro.

* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::reload): Add reload method that clears events
and initializes progress.
* UIProcess/API/gtk/tests/LoadTrackingTest.h:
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testWebViewReload): Use LoadTrackingTest::reload() instead of
webkit_web_view_reload().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 11:47:51 +0000 (11:47 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkEditableText interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp: Added.
(core):
(webkitAccessibleEditableTextInterfaceInit):
(webkitAccessibleEditableTextSetRunAttributes):
(webkitAccessibleEditableTextSetTextContents):
(webkitAccessibleEditableTextInsertText):
(webkitAccessibleEditableTextCopyText):
(webkitAccessibleEditableTextCutText):
(webkitAccessibleEditableTextDeleteText):
(webkitAccessibleEditableTextPasteText):
* accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Added.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkEditableText interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceEditableText.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 11:40:44 +0000 (11:40 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkDocument interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp: Added.
(core):
(documentAttributeValue):
(webkitAccessibleDocumentInterfaceInit):
(webkitAccessibleDocumentGetAttributeValue):
(webkitAccessibleDocumentGetAttributes):
(webkitAccessibleDocumentGetLocale):
* accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Added.

Move common function addAttributeToSet() out from the wrapper to
the utility file, used from WebKitAccessibleInterfaceDocument.cpp.

* accessibility/gtk/WebKitAccessibleUtil.cpp:
(addToAtkAttributeSet): Taken from WebKitAccessibleWrapperAtk.cpp.
* accessibility/gtk/WebKitAccessibleUtil.h:
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove local
implementation of addAttributeToSet, as well as all the code related
to the implementation of the AtkDocument interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceDocument.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

scheib@chromium.org [Tue, 24 Jan 2012 11:29:01 +0000 (11:29 +0000)]

[Chromium] Add WebKit API for Pointer Lock
https://bugs.webkit.org/show_bug.cgi?id=76410

Reviewed by Darin Fisher.

Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
into a series of patches, this stubs out the API.

* public/WebWidget.h:
(WebKit::WebWidget::didCompletePointerLock):
(WebKit::WebWidget::didNotCompletePointerLock):
(WebKit::WebWidget::didLosePointerLock):
* public/WebWidgetClient.h:
(WebKit::WebWidgetClient::requestPointerLock):
(WebKit::WebWidgetClient::requestPointerUnlock):
(WebKit::WebWidgetClient::isPointerLocked):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::requestPointerLock):
(WebKit::ChromeClientImpl::requestPointerUnlock):
(WebKit::ChromeClientImpl::isPointerLocked):
* src/ChromeClientImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::didCompletePointerLock):
(WebKit::WebViewImpl::didNotCompletePointerLock):
(WebKit::WebViewImpl::didLosePointerLock):
(WebKit::WebViewImpl::requestPointerLock):
(WebKit::WebViewImpl::requestPointerUnlock):
(WebKit::WebViewImpl::isPointerLocked):
(WebKit::WebViewImpl::pointerLockMouseEvent):
* src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

hausmann@webkit.org [Tue, 24 Jan 2012 11:22:26 +0000 (11:22 +0000)]

Some qmake build files must include Qt5's "quick" module.
https://bugs.webkit.org/show_bug.cgi?id=76671

Unreviewed build fix.

.:

* Source/api.pri:

Source/WebKit2:

* UIProcess/API/qt/tests/tests.pri:

Tools:

* MiniBrowser/qt/MiniBrowser.pro:
* WebKitTestRunner/Target.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abecsi@webkit.org [Tue, 24 Jan 2012 11:19:46 +0000 (11:19 +0000)]

[Qt] Fix the event timestamps for touch mocking

Reviewed by Simon Hausmann.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
timestamp argument in the QWindowSystemInterface::handleTouchEvent call.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

tkent@chromium.org [Tue, 24 Jan 2012 11:05:13 +0000 (11:05 +0000)]

[Chromium] Update test expectation

* platform/chromium/test_expectations.txt:
perf/adding-radio-buttons.html is MISSING on buildbots.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Tue, 24 Jan 2012 11:03:51 +0000 (11:03 +0000)]

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkComponent interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp: Added.
(core):
(atkToContents):
(webkitAccessibleComponentInterfaceInit):
(webkitAccessibleComponentRefAccessibleAtPoint):
(webkitAccessibleComponentGetExtents):
(webkitAccessibleComponentGrabFocus):
* accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Added.

Move common function contentsToAtk() out from the wrapper to the
utility file, used from WebKitAccessibleInterfaceComponent.cpp.

* accessibility/gtk/WebKitAccessibleUtil.cpp:
(contentsRelativeToAtkCoordinateType): Taken from WebKitAccessibleWrapperAtk.cpp.
* accessibility/gtk/WebKitAccessibleUtil.h:
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove local
implementation of contentsToAtk, as well as all the code related
to the implementation of the AtkComponent interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceComponent.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Domain: Web Framework / Uncategorized;