Mike Klein [Mon, 25 Aug 2014 17:50:29 +0000 (13:50 -0400)]
gradtext also needed rebaselining from the gamma change
BUG=skia:
Review URL: https://codereview.chromium.org/
501113002
bungeman [Mon, 25 Aug 2014 17:16:01 +0000 (10:16 -0700)]
Require length in sk_wchar_to_string.
This information is already available at all call sites and allows
the call to WideCharToMultiByte to not overwrite the '\0' in the
writable_str() which isn't really writable.
BUG=skia:1989
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
500113002
Mike Klein [Mon, 25 Aug 2014 17:14:16 +0000 (13:14 -0400)]
Rebaseline 565 precision changes and matrixconvolution.
BUG=skia:2797
Review URL: https://codereview.chromium.org/
504873002
mtklein [Mon, 25 Aug 2014 17:10:47 +0000 (10:10 -0700)]
Document return value of SkPaint::operator==.
BUG=skia:1491
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
467063003
djsollen [Mon, 25 Aug 2014 16:06:19 +0000 (09:06 -0700)]
Revert of Fix recursive computation of filter bounds for drop shadow, (patchset #1 of https://codereview.chromium.org/
481273005/)
Reason for revert:
This CL is currently breaking the Win7 and Win8 bots on some of the new tests (in DM).
Original issue's description:
> Fix recursive computation of filter bounds for drop shadow,
> morphology, blur.
>
> Because we're computing "backwards" from a clip rect of destination
> pixels to be filled to the required source pixels, we should use tail
> recursion rather than head recursion in onFilterBounds().
>
> This actually only makes a difference for drop-shadow, where
> the computation is non-commutative. Blur and morphology commute, but I
> moved them to tail recursion anyway for clarity (so all onFilterBounds
> use tail recursion).
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
28648fe4a69b0cee8df42b5966e4e645c3aabefb
R=bsalomon@google.com, senorblanco@chromium.org
TBR=bsalomon@google.com, senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
504773003
senorblanco [Mon, 25 Aug 2014 15:06:57 +0000 (08:06 -0700)]
Fix recursive computation of filter bounds for drop shadow,
morphology, blur.
Because we're computing "backwards" from a clip rect of destination
pixels to be filled to the required source pixels, we should use tail
recursion rather than head recursion in onFilterBounds().
This actually only makes a difference for drop-shadow, where
the computation is non-commutative. Blur and morphology commute, but I
moved them to tail recursion anyway for clarity (so all onFilterBounds
use tail recursion).
BUG=skia:
R=bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
481273005
bungeman [Mon, 25 Aug 2014 14:31:53 +0000 (07:31 -0700)]
XPS to use PathOps for inverse winding paths.
R=caryclark@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
484343003
bungeman [Mon, 25 Aug 2014 14:14:02 +0000 (07:14 -0700)]
Reverse swap order in DirectWrite typeface.
C++ forbids temporaries to bind to non-const references.
VC++ allows you to do so anyway, but it makes clang on Windows sad.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
487533004
caryclark [Mon, 25 Aug 2014 13:53:04 +0000 (06:53 -0700)]
add const to arrays of member functions
running 'size ./out/Release/libskia_core.a' revealed a couple of
places where path ops chose poorly and declared arrays of member
functions to be unnecessarily writable.
R=reed@android.com
TBR=reed
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
461363003
jbroman [Mon, 25 Aug 2014 13:22:12 +0000 (06:22 -0700)]
Add SK_API to SkTextBlob and SkTextBlobBuilder.
BUG=skia:2868
R=fmalita@chromium.org, reed@google.com
Author: jbroman@chromium.org
Review URL: https://codereview.chromium.org/
497993002
halcanary [Mon, 25 Aug 2014 13:20:13 +0000 (06:20 -0700)]
remove SkPurgeGlobalDiscardableMemoryPool
BUG=skia:2721
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
495453004
qiankun.miao [Mon, 25 Aug 2014 13:08:25 +0000 (06:08 -0700)]
Clean up useless comments in SkScaledImageCache.h
BUG=skia:
R=reed@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
499203002
borenet [Sun, 24 Aug 2014 03:48:08 +0000 (20:48 -0700)]
Update SKP version to 82
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
499893002
borenet [Sat, 23 Aug 2014 04:11:56 +0000 (21:11 -0700)]
Update SKP version to 81
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
497343002
mtklein [Fri, 22 Aug 2014 20:42:56 +0000 (13:42 -0700)]
Don't leak the shader by reffing twice in SkRectShaderImageFilter.
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
501563002
mtklein [Fri, 22 Aug 2014 20:15:38 +0000 (13:15 -0700)]
Disable Neon optimization of bad S32A/D565 blend.
BUG=skia:2797
Committed: https://skia.googlesource.com/skia/+/
84cab93186fbe3e87d931fea73cb31b70ff5017b
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
497823002
borenet [Fri, 22 Aug 2014 19:23:56 +0000 (12:23 -0700)]
Copy Ubuntu12 RenderSKPs expectations for Recipes bot
This is in preparation for implementing the render_skps workflow in recipes.
BUG=skia:761
R=epoger@google.com, stephana@google.com
TBR=epoger, stephana
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
496283005
Ben Wagner [Fri, 22 Aug 2014 19:07:06 +0000 (15:07 -0400)]
Add testing flag for XPS for deterministic ids.
BUG=skia:455
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
494423002
bsalomon [Fri, 22 Aug 2014 19:01:46 +0000 (12:01 -0700)]
Fix leak of GrResourceCacheEntry
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
502543002
mtklein [Fri, 22 Aug 2014 18:58:46 +0000 (11:58 -0700)]
Disable Neon optimization of bad S32A/D565 blend.
BUG=skia:2797
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
497823002
mtklein [Fri, 22 Aug 2014 18:44:26 +0000 (11:44 -0700)]
Support comment groups in SkRecord.
This should fix the failing paint-command-log-nodes.html layout test.
BUG=406425
R=tomhudson@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
501533003
Mike Klein [Fri, 22 Aug 2014 17:09:02 +0000 (13:09 -0400)]
suppress matrixconvolution
BUG=skia:
Review URL: https://codereview.chromium.org/
476283003
mtklein [Fri, 22 Aug 2014 16:06:34 +0000 (09:06 -0700)]
Fix saveLayer() with a pixel-moving filter vs SkBBoxHierarchyRecord / SkRecordDraw
In SkBBoxHierarchyRecord:
Since the bounds we pass to saveLayer are in the pre-filtering
coordinate space, they aren't correct for determining the actual
device pixels touched by the saveLayer in this case.
The easiest fix for now is to pass the clip bounds, since the final
draw done in restore() will never draw outside the clip.
In SkRecordDraw:
We do adjust the bounds passed to saveLayer, so we just need to make
sure that when we're using a paint that may affect transparent black,
we ignore the calculated bounds of draw ops and use the clip intersected
with those adjusted bounds.
See originally crrev.com/
497773002
BUG=skia:
R=reed@google.com, senorblanco@chromium.org, junov@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
496963003
bsalomon [Fri, 22 Aug 2014 16:02:38 +0000 (09:02 -0700)]
Fix leak in multipicturedraw GMs.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
502493002
fmalita [Fri, 22 Aug 2014 16:01:19 +0000 (09:01 -0700)]
[SkTextBlob] Merge run font data at draw time.
R=bungeman@google.com, reed@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
496773002
reed [Fri, 22 Aug 2014 15:30:20 +0000 (08:30 -0700)]
extend SkShader to report a luminance-color to be used for gamma correction
BUG=skia:590
R=bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
492963002
reed [Fri, 22 Aug 2014 15:27:45 +0000 (08:27 -0700)]
disable neon proc that is triggering asserts
BUG=skia:2845
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
498733002
Mike Klein [Fri, 22 Aug 2014 15:23:18 +0000 (11:23 -0400)]
Some early 565 rebaselines.
BUG=skia:2797
Review URL: https://codereview.chromium.org/
488453003
fmalita [Fri, 22 Aug 2014 14:50:45 +0000 (07:50 -0700)]
Add some text blob bounds unit tests.
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
498693002
reed [Fri, 22 Aug 2014 14:27:14 +0000 (07:27 -0700)]
fix numerical overflows in 565 blends
BUG=skia:2797
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
474983007
egdaniel [Fri, 22 Aug 2014 14:19:35 +0000 (07:19 -0700)]
Store vertex size in DrawState when setVertexAttribs is called
This will avoid recalculating vertex size throughout code, and will allow
for a set original vertex size once optimizations start removing VA's
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
498483002
Mike Klein [Fri, 22 Aug 2014 14:16:03 +0000 (10:16 -0400)]
Ignore GMs that will need 565 rebaselines.
BUG=skia:
Review URL: https://codereview.chromium.org/
483883004
tfarina [Fri, 22 Aug 2014 12:42:44 +0000 (05:42 -0700)]
Cleanup: Remove BenchTool xcode project file.
BUG=None
TEST=None
R=mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
491263003
reed [Fri, 22 Aug 2014 12:08:26 +0000 (05:08 -0700)]
fix leak in new createproc
BUG=skia:
R=caryclark@google.com, mike@reedtribe.org, mtklein@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
461253007
caryclark [Fri, 22 Aug 2014 11:55:14 +0000 (04:55 -0700)]
add tool generated whitespace
the rebaseline tool adds whitespace at the end of lines in the json file.
While harmless, git flags this as something worth fixing. Fixing it causes
the rebaseline tool to generate a new difference with the whitespace.
Checking the whitespace back in to avoid future back-and-forth.
TBR=
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
494363002
caryclark [Fri, 22 Aug 2014 11:48:12 +0000 (04:48 -0700)]
fix remaining arm64 expectations
R=halcanary@google.com
TBR=halcanary@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:2845
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
496253004
rmistry [Fri, 22 Aug 2014 11:46:30 +0000 (04:46 -0700)]
Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server.
BUG=skia:2230
R=epoger@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
479613002
epoger [Fri, 22 Aug 2014 06:21:32 +0000 (23:21 -0700)]
create sk_tools::Expectation class, similar to skiagm::Expectations class
The overarching goal here is for our "gm" and "render_pictures" tools to handle
image expectations/actuals in the same way, sharing the same code, so their
results can be processed through a single pipeline.
By adding an Expectation class within tools/image_expectations.h, similar to
the Expectations class in gm/gm_expectations.h, we get one step closer to
that goal.
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
493363002
borenet [Fri, 22 Aug 2014 04:13:51 +0000 (21:13 -0700)]
Update SKP version to 80
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
475873003
joshualitt [Fri, 22 Aug 2014 03:18:45 +0000 (20:18 -0700)]
Initial refactor of shaderbuilder to prepare for geometry shaders
gitignore for eclipse
BUG=skia:
R=bsalomon@google.com, bsalomon@chromium.org
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
491673002
mtklein [Fri, 22 Aug 2014 00:10:14 +0000 (17:10 -0700)]
Revert of Revert back to SkPictureData pictures. Huge perf regression. (patchset #1 of https://codereview.chromium.org/
496603002/)
Reason for revert:
Try again now that we have --bbh on nanobench and it's looking decent.
Original issue's description:
> Revert back to SkPictureData pictures. Huge perf regression.
>
> http://skiaperf.com/#108
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
4082d290eea2f70caa82120ff3bc4fbdccbf206c
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
496173002
mtklein [Thu, 21 Aug 2014 23:39:12 +0000 (16:39 -0700)]
1.5x -> 2x text size for y pad.
This will expand the cheat to just big enough to pass an assertion coming
from our GDI bot. Currently failing:
-6.000000 -1.500000 6.000000 1.500000 vs. -1.000000 -2.000000 3.000000 1.000000
Will become (-8 -2 8 2) vs. (-1 -2 3 1).
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
496153002
mtklein [Thu, 21 Aug 2014 22:51:22 +0000 (15:51 -0700)]
Add --bbh (default true) to nanobench.
Chrome's using a bounding box, so it's a good idea for our
bots to do so too.
When set, we'll create an SkTileGrid to match the
parameters of --clip, and so should always hit its fast
path.
This will impose a small overhead (querying the BBH) on all
SKPs, but make large SKPs render more quickly. E.g. on
GPU desk_pokemonwiki should show about a 30% improvement,
tabl_mozilla about 40%, and one very long page from my
personal suite, askmefast.com, gets 5x faster.
(The performance changes are not the point of the CL, but
something we should be aware of.)
BUG=
R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
497493003
fmalita [Thu, 21 Aug 2014 22:03:04 +0000 (15:03 -0700)]
Add some SkTextBlob builder tests.
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
493443004
mtklein [Thu, 21 Aug 2014 21:46:49 +0000 (14:46 -0700)]
Ignore small text sizes in the text bounding assert.
Seems we sometimes give back unduely large metrics for 0 text size.
BUG=skia:2862
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
498503003
bsalomon [Thu, 21 Aug 2014 21:40:36 +0000 (14:40 -0700)]
Fix surface leak in multidraw GMs.
TBR=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
496793003
djsollen [Thu, 21 Aug 2014 20:17:50 +0000 (13:17 -0700)]
fix android framework build for nanobench
R=mtklein@google.com, tomhudson@chromium.org, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
495003004
halcanary [Thu, 21 Aug 2014 20:17:43 +0000 (13:17 -0700)]
git-sync-deps handles recursive DEPS
NOTRY=true
R=mtklein@google.com, borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
468113003
robertphillips [Thu, 21 Aug 2014 20:12:42 +0000 (13:12 -0700)]
SkMultiPictureDraw API
This CL adds a new API to optimize across multiple SkPicture draw calls.
Note that multiple pictures rendered at once (i.e., picture piles) should be flattened into a single new picture that includes the required clipping on the different layers.
R=bsalomon@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
491313003
djsollen [Thu, 21 Aug 2014 20:12:34 +0000 (13:12 -0700)]
Fix root level Android.mk to now point to the correct nanobench makefile
R=mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
494193003
robertphillips [Thu, 21 Aug 2014 20:07:35 +0000 (13:07 -0700)]
Split up monolithic EXPERIMENTAL_drawPicture method
This is prep for the new multi-picture API.
This is split out of (Add new API to allow layer hoisting/atlasing across picture piles - https://codereview.chromium.org/
474623002/)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
489103002
mtklein [Thu, 21 Aug 2014 20:07:27 +0000 (13:07 -0700)]
Install a hook to swap between SkPicture backends with a single define.
BUG=skia:
R=robertphillips@google.com, reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
492023002
djsollen [Thu, 21 Aug 2014 20:02:27 +0000 (13:02 -0700)]
Cleanup FDO options.
R=tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
489373004
bsalomon [Thu, 21 Aug 2014 20:02:13 +0000 (13:02 -0700)]
Add GrResourceCache2.
Currently it just replaces GrGpu as the owner of the linked list of resources.
Committed: https://skia.googlesource.com/skia/+/
94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f
R=mtklein@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
481443002
caryclark [Thu, 21 Aug 2014 19:37:55 +0000 (12:37 -0700)]
update expectations for Nexus 10 Debug
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
492303003
reed [Thu, 21 Aug 2014 19:32:40 +0000 (12:32 -0700)]
remember to init fOrigPos in legacy constructor
NOTREECHECKS=True
R=caryclark@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
496833002
mtklein [Thu, 21 Aug 2014 18:52:36 +0000 (11:52 -0700)]
Does this fix things?
NOTREECHECKS=true
CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
492343002
reed [Thu, 21 Aug 2014 17:53:34 +0000 (10:53 -0700)]
use globals to register custom effects
NOTREECHECKS=True
NOTRY=True
R=mtklein@google.com, caryclark@google.com, bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
498453003
reed [Thu, 21 Aug 2014 17:50:25 +0000 (10:50 -0700)]
rename gradients private BitmapCache to GradientBitmapCache
R=caryclark@google.com
NOTREECHECKS=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
474983005
reed [Thu, 21 Aug 2014 16:46:49 +0000 (09:46 -0700)]
expose generalized imagecache key
BUG=skia:
R=mtklein@google.com, halcanary@google.com, qiankun.miao@intel.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
483493003
mtklein [Thu, 21 Aug 2014 16:11:37 +0000 (09:11 -0700)]
Our SkPicture::Analysis visitors should recurse into nested pictures.
BUG=skia:
R=tomhudson@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
495793002
halcanary [Thu, 21 Aug 2014 16:03:50 +0000 (09:03 -0700)]
temporary rebaseline on arm64
Affects all blur tests.
BUG=skia:2845
NOTRY=true
R=caryclark@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
495093002
fmalita [Thu, 21 Aug 2014 15:53:26 +0000 (08:53 -0700)]
SkTextBlob
Initial implementation.
R=bungeman@google.com, jbroman@chromium.org, mtklein@google.com, reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
473633002
reed [Thu, 21 Aug 2014 14:59:51 +0000 (07:59 -0700)]
Simplify flattening to just write enough to call the factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc).
Refactoring pattern:
1. guard the existing constructor(readbuffer) with the legacy build-flag
2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL).
If you're a shader subclass
1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it.
R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
395603002
caryclark [Thu, 21 Aug 2014 14:43:43 +0000 (07:43 -0700)]
update gm expectations for Nexus 10
the Android version was updated, introducing a new GPU driver
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2860
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
496733002
djsollen [Thu, 21 Aug 2014 14:40:42 +0000 (07:40 -0700)]
Temporarily adjust Matrix.isSimilarity test tolerance on 64-bit ARM devices
BUG=skia:2405
R=halcanary@google.com, jvanverth@google.com, reed@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
494113002
djsollen [Thu, 21 Aug 2014 14:38:31 +0000 (07:38 -0700)]
Update FDO options to match what is needed by the framework
R=tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
497503003
djsollen [Thu, 21 Aug 2014 14:33:40 +0000 (07:33 -0700)]
Remove unecessary check from android framework build
R=bungeman@google.com, raph@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
495063002
djsollen [Thu, 21 Aug 2014 14:33:20 +0000 (07:33 -0700)]
Use medium filtering when downscaling bitmap glyphs in FreeType host
This enable Android to save space on emoji glyphs
R=bungeman@google.com, raph@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
492253002
egdaniel [Thu, 21 Aug 2014 13:47:50 +0000 (06:47 -0700)]
Fix == operator in GrTextureDomain so we don't compair uninitilized values
We were getting random behavior when comparing two GrTexureDomains since
fDomain was not initialized when the mode was set to ignore.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
469393007
halcanary [Thu, 21 Aug 2014 13:30:11 +0000 (06:30 -0700)]
Make SkPMColorAssert a macro (all assert-like functions should be macros).
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
494863003
egdaniel [Thu, 21 Aug 2014 13:27:22 +0000 (06:27 -0700)]
Remove State struct from GrDrawState
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
464363002
reed [Thu, 21 Aug 2014 12:51:22 +0000 (05:51 -0700)]
remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPE
BUG=skia:
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
489103003
borenet [Thu, 21 Aug 2014 04:20:35 +0000 (21:20 -0700)]
Update SKP version to 79
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
485233003
mtklein [Wed, 20 Aug 2014 23:18:25 +0000 (16:18 -0700)]
Revert back to SkPictureData pictures. Huge perf regression.
http://skiaperf.com/#108
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
496603002
mtklein [Wed, 20 Aug 2014 22:50:45 +0000 (15:50 -0700)]
Always read .skp files and other serialized pictures into SkRecord.
This should switch all our internal tools that aren't clever about it over to SkRecord pictures. (The clever tools know what they're doing.)
Also, deletes the old SkPicture::clone() path. return this or die.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
7b705bb17e09508e3761b54f59833b1ceb4ce9a6
R=robertphillips@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
481743003
halcanary [Wed, 20 Aug 2014 21:40:09 +0000 (14:40 -0700)]
Turn off NEON SkBoxBlurGetPlatformProcs for ARM64 (for now)
BUG=skia:2845
R=djsollen@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
491973002
mtklein [Wed, 20 Aug 2014 21:22:58 +0000 (14:22 -0700)]
Always read .skp files and other serialized pictures into SkRecord.
This should switch all our internal tools that aren't clever about it over to SkRecord pictures. (The clever tools know what they're doing.)
Also, deletes the old SkPicture::clone() path. return this or die.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
481743003
caryclark [Wed, 20 Aug 2014 21:01:28 +0000 (14:01 -0700)]
ignore flaky failure on android
this failed to commit the first time
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
488273002
reed [Wed, 20 Aug 2014 20:41:56 +0000 (13:41 -0700)]
make imagecache's Key more general purpose
This should allow other clients with different sized keys to still use the cache.
BUG=skia:
R=fmalita@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
472343002
epoger [Wed, 20 Aug 2014 19:21:48 +0000 (12:21 -0700)]
rebaseline_server: force checksumValue to an integer to prevent spurious comparison failures
Without this change, SKP tests *appeared* to fail because the actuals reported
their checksumValues as integers, while the expectations recorded their
checksumValues as strings.
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
489023003
bungeman [Wed, 20 Aug 2014 19:21:32 +0000 (12:21 -0700)]
Directly compute glyphToUnicode array in DirectWrite.
This new code is still rather bad, but has fewer steps.
The motivation for looking at this is that on Windows 8 the previous code
was occasionally asserting in such a way as to imply that GetGlyphIndices
might return different data the second time through the font. This avoids
that particular issue by only going through the font once.
R=mtklein@google.com, halcanary@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
472333003
epoger [Wed, 20 Aug 2014 18:51:39 +0000 (11:51 -0700)]
add headers to experimental SKP expectations
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
491023003
mtklein [Wed, 20 Aug 2014 18:45:00 +0000 (11:45 -0700)]
Add --properties for things like gitHash that describe the current nanobench run.
--key describes the type of run (describes the line on the chart), --properties
describes the run itself (describes the dot on the chart).
We'll pass --properties gitHash <git hash> build_number <build number> --key
... to nanobench from the bots.
And... delete a whole lot of dead code.
Example: nanobench --properties gitHash foo build_number 1234 --key bar baz
{
"build_number" : "1234",
"gitHash" : "foo",
"key" : {
"bar" : "baz"
},
"results" : {
....
Friends with https://codereview.chromium.org/
491943002
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
488213002
epoger [Wed, 20 Aug 2014 18:39:34 +0000 (11:39 -0700)]
rebaseline_server: if creating brand new expectations files, include the header
Otherwise, the first time you compare against these expectations, you get
failures.
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
491063002
epoger [Wed, 20 Aug 2014 18:10:30 +0000 (11:10 -0700)]
update experimental SKP expectations using the new tool
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
488203002
epoger [Wed, 20 Aug 2014 17:55:27 +0000 (10:55 -0700)]
rebaseline_server: add download link for SKP diff patchfile
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
489183002
mtklein [Wed, 20 Aug 2014 16:44:28 +0000 (09:44 -0700)]
Dump out more information if this assert fails.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
ec924b9696277df4c684e73315194482e1d43e50
R=caryclark@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
491903002
mtklein [Wed, 20 Aug 2014 16:22:28 +0000 (09:22 -0700)]
Dump out more information if this assert fails.
BUG=skia:
R=caryclark@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
491903002
epoger [Wed, 20 Aug 2014 15:22:26 +0000 (08:22 -0700)]
add 2 missing SKP expectations files within experimental dir
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
(SkipBuildbotRuns)
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
470193006
caryclark [Wed, 20 Aug 2014 15:11:24 +0000 (08:11 -0700)]
copy points in array that may stretch
Description:
Potential SkOpSegment::addT() use-after-free
The 'pt' arg can be a reference to a point stored in the local fTs
TDArray => appending may cause a realloc and leave the reference
pointing to deallocated mem.
Copy the points from the stretchy array before adding them.
R=fmalita@google.com, fmalita@chromium.org, fmalita
BUG=405417
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
489853002
mtklein [Wed, 20 Aug 2014 15:09:46 +0000 (08:09 -0700)]
Implement SkPicture::hasText() for SkRecord backend.
Plus, some small tweaks to the existing code surrounding it. Just proposals,
will undo whatever you don't like.
BUG=skia:
R=mtklein@google.com, tomhudson@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
494683003
bungeman [Wed, 20 Aug 2014 15:01:35 +0000 (08:01 -0700)]
Remove SK_FONT_HOST_DOES_NOT_USE_FONTMGR and guarded code.
This define is no longer needed or set, so remove it from the code.
R=tomhudson@google.com, djsollen@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
488083004
epoger [Wed, 20 Aug 2014 15:00:28 +0000 (08:00 -0700)]
rebaseline_server: allow users to generate SKP diff patches on a shared instance
This will allow developers to maintain SKP baselines without ever running their
own rebaseline_server instance!
For now, the developer must manually apply the resulting patchset to his local
Skia checkout to actually modify expectations; in the near future, we hope to
make the UI upload the patchset to Rietveld on the user's behalf.
BUG=skia:1918
NOTRY=true
R=stephana@google.com, rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
487853004
epoger [Wed, 20 Aug 2014 14:52:28 +0000 (07:52 -0700)]
start maintaining some experimental SKP expectations
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
491003002
mtklein [Wed, 20 Aug 2014 14:38:46 +0000 (07:38 -0700)]
Define NDEBUG instead of SK_DEBUG/SK_RELEASE.
This makes our builds more like Chrome's, and will make our builds fail
if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
481513004
reed [Wed, 20 Aug 2014 14:24:01 +0000 (07:24 -0700)]
fix Image::isOpaque test to not leak
BUG=skia:
R=halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
495523002
djsollen [Wed, 20 Aug 2014 14:03:23 +0000 (07:03 -0700)]
Revert to old autohinting behavior on Android.
This CL reverts to the NO_AUTOHINT behavior when autohinting is not
explicitly requested. This should be removed when Skia supports a
better API for selecting the correct variation.
This CL has landed in the Android repo and is being upstreamed to
avoid fragmenting the codebase.
R=bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
490913003
caryclark [Wed, 20 Aug 2014 13:34:15 +0000 (06:34 -0700)]
ignore release as well
This GM is flaky as Brian expected on both Release and Debug,
so suppress the Release expectation as well.
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2826
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
489083002
borenet [Wed, 20 Aug 2014 13:31:12 +0000 (06:31 -0700)]
Rename Recipes bot expectations
Accidentally used the wrong name :-/
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
BUG=skia:761
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
495493002