Bruno da Silva Belo [Tue, 1 Oct 2019 02:14:46 +0000 (23:14 -0300)]
mono_docs:adding and updating eina_binbuf.cs.
Summary: Generating docs and setting to 1.23.
Reviewers: lauromoura, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10252
Bruno da Silva Belo [Tue, 1 Oct 2019 02:13:07 +0000 (23:13 -0300)]
mono-docs: adding and updating docs for eina_array.
Summary: Generating docs and setting to 1.23 for eina_array.cs
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10251
Lauro Moura [Tue, 1 Oct 2019 02:10:40 +0000 (23:10 -0300)]
csharp: Document Eina.List
Summary:
Also added Since 1.23 info
Depends on D10253o
ref T8293
Test Plan: Check docs
Reviewers: segfaultxavi, brunobelo, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10254
Lauro Moura [Tue, 1 Oct 2019 02:08:44 +0000 (23:08 -0300)]
csharp: Allow improved cbs in eina comparators
Summary:
Instead of receiving a callback that compares two intptrs (which is
still used internally), expose a more C#-friendly delegate which is
wrapped into the native one.
Test Plan: run test suite
Reviewers: felipealmeida, segfaultxavi, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10253
Lauro Moura [Tue, 1 Oct 2019 02:05:36 +0000 (23:05 -0300)]
csharp: Document Eina.Log
Summary: ref T8293
Reviewers: brunobelo, segfaultxavi, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10255
Lauro Moura [Tue, 1 Oct 2019 02:03:51 +0000 (23:03 -0300)]
csharp: Add since to Eina.Promise
Summary: ref T8293
Reviewers: segfaultxavi, felipealmeida, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10256
Jaehyun Cho [Tue, 19 Jun 2018 06:41:49 +0000 (15:41 +0900)]
elm_slider: do not clip indicator to slider
By calling evas_object_smart_member_add(), indicator is clipped to slider.
To keep backward compatibility, indicator should not be clipped to slider.
Change-Id: I625413f65641afa0a415776402749f88d7b88338
Wonki Kim [Tue, 1 Oct 2019 09:35:44 +0000 (18:35 +0900)]
ecore: fix improper usage of sizeof keyword
sizeof operator is applied to the address of a variable.
this patch removes & operater.
Change-Id: I46772c52bf916cd4c007fcd81af4cd91f223d158
Jongmin Lee [Mon, 30 Sep 2019 23:48:56 +0000 (08:48 +0900)]
build: resolve migration build error
Change-Id: I0be6fbd7a8d9169271e9631f9ae93676657090a8
Carsten Haitzler (Rasterman) [Mon, 30 Sep 2019 21:06:07 +0000 (22:06 +0100)]
evas - gl_drm - handle modifiers for drm formats
this was/is breaking e on rpi4 as modifiers are used to pass tiling
info it seems. we had no support thus leaving garbage in buffers. this
fixes that.
Daniel Kolesa [Mon, 30 Sep 2019 17:45:45 +0000 (19:45 +0200)]
efl: add code to enforce presence of @since tags
This is not yet enabled because there's too many instances where
this is broken.
Ref T7704
Xavi Artigas [Mon, 30 Sep 2019 17:48:19 +0000 (19:48 +0200)]
Revert "eolian: disallow missing docs for stable API where necessary"
I'm afraid but this breaks the mono bindings too close to a release.
This also fixes the missing docs errors by adding a lot of inconsistent
placeholder text ("No description supplied.", "TBD") which will make
finding them later on more complicated.
I was the one that asked for this feature but it is not critical at this
point, so I suggest we explore some refinements (like T8291) before landing
this patch in its current state.
This reverts commit
2946cb3c325f27d77354ac1b83b614e3a1d9e1d5.
Daniel Kolesa [Mon, 30 Sep 2019 15:01:31 +0000 (17:01 +0200)]
eolian: disallow missing docs for stable API where necessary
The things that require docs include classes, variables, typedecls,
events and methods/properties. Implements, params, returns, parts
and struct/enum fields don't require them.
Empty/whitespace only string does not count as documentation.
Xavi Artigas [Mon, 30 Sep 2019 16:05:07 +0000 (18:05 +0200)]
mono-docs: Formatting of @since tags
Use a line break <br/> now that we can properly escape these things.
Previously we appended (Since EFL X.XX) which didn't look very nice.
Marcel Hollerbach [Mon, 30 Sep 2019 15:03:01 +0000 (17:03 +0200)]
efl_canvas_animation_player: improve docs
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10250
Lauro Moura [Mon, 30 Sep 2019 13:38:55 +0000 (15:38 +0200)]
eolian-cxx: Release iterators
Summary:
When the iterators advanced, the CXX wrappers null'd them but did not
call eina_value_free.
ref T8280
Reviewers: q66, brunobelo, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8280
Differential Revision: https://phab.enlightenment.org/D10238
Lauro Moura [Mon, 30 Sep 2019 13:38:34 +0000 (15:38 +0200)]
bindings: Fix disposal of eolian state
Summary:
It was actually leaking before. Let's use some RAII classes that were
already there.
ref T8280
Reviewers: q66, felipealmeida, brunobelo
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8280
Differential Revision: https://phab.enlightenment.org/D10237
Xavi Artigas [Mon, 30 Sep 2019 13:26:17 +0000 (10:26 -0300)]
mono-docs: Add some missing docs for workaround.cs
Test Plan: Only docs changed.
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10249
Jaehyun Cho [Mon, 30 Sep 2019 11:21:41 +0000 (07:21 -0400)]
theme: remove duplicated version 119
Summary: Since the current version is 123, duplicated version 119 is removed.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10248
Daniel Kolesa [Mon, 30 Sep 2019 09:28:32 +0000 (11:28 +0200)]
eolian: fix potential ABI violation in expr serialization
While this may seem safe, and likely is on any 64-bit system,
it may not be entirely well defined. And in this case we should
not have to worry about copying.
Maybe fixes T8276...
Mike Blumenkrantz [Thu, 26 Sep 2019 18:10:39 +0000 (14:10 -0400)]
tests/position_manager: initialize variable in declaration
CID 1404756, 1404747
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10202
Marcel Hollerbach [Fri, 27 Sep 2019 14:33:35 +0000 (16:33 +0200)]
elm_code_widget: when the position is updated, set new geom to cursor
in order to do that, we need to ensure that the internal box is
calculated, otherwise the position is still not updated correctly.
This fixes wrong cursor positions in edi.
fixes T8214
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10225
Marcel Hollerbach [Fri, 27 Sep 2019 14:32:25 +0000 (16:32 +0200)]
elm_code_widget: initialize these vars correctly
otherwise we are setting a cursor from time to time at a uninitialized
position. Which causes disappeared cursors
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10224
Mike Blumenkrantz [Tue, 10 Sep 2019 17:31:13 +0000 (13:31 -0400)]
Revert "eo beta - mark task, io classes as beta because they are..."
This reverts commit
5455a2dcf7ded4e0fe91c0a6b734998278de8fe8.
these classes were explicitly stabilized for 1.22
see T7599, T7600, T7601
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9901
Bruno da Silva Belo [Thu, 26 Sep 2019 21:49:00 +0000 (21:49 +0000)]
Updating README for clang requirements.
OpenMP needs to be installed in system to sucessfully compile with
clang, needs libomp, while gcc use his version, libgomp.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10213
Marcel Hollerbach [Fri, 27 Sep 2019 14:31:47 +0000 (16:31 +0200)]
test_code: do not create a background by hand
the background here was wrong, it hasnt resizable hints, which means
that the whole object cannot be resized.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10223
Mike Blumenkrantz [Fri, 27 Sep 2019 15:08:05 +0000 (11:08 -0400)]
efl_ui: remove legacy component includes, include Efl_Layout.h and Efl_Canvas.h
this header shouldn't include any legacy headers whatsoever
fix T8274
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10236
Mike Blumenkrantz [Fri, 27 Sep 2019 15:07:17 +0000 (11:07 -0400)]
efl_ui: remove efl_ui_text headers from Efl_Ui.h for now
these require legacy types and headers, which should not be brought into
this header
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10235
Mike Blumenkrantz [Fri, 27 Sep 2019 17:46:08 +0000 (13:46 -0400)]
benchmark/collection: add Elementary.h
this uses legacy api
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10234
Mike Blumenkrantz [Fri, 27 Sep 2019 15:06:21 +0000 (11:06 -0400)]
tests/spin_button: include Elementary.h since this uses legacy api
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10233
Mike Blumenkrantz [Fri, 27 Sep 2019 15:06:05 +0000 (11:06 -0400)]
tests/spec: use eo types here since this isn't supposed to use legacy
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10232
Mike Blumenkrantz [Fri, 27 Sep 2019 15:05:24 +0000 (11:05 -0400)]
efl_ui: explicitly include eo headers for a couple types
the general headers here pull in legacy headers, which is bad
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10231
Mike Blumenkrantz [Fri, 27 Sep 2019 15:04:38 +0000 (11:04 -0400)]
elm_test/radio: use eo type here
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10230
Mike Blumenkrantz [Fri, 27 Sep 2019 14:27:05 +0000 (10:27 -0400)]
edje: add Efl_Layout.h for eo-based layout headers
this includes all related headers
ref T8274
Additional Authors: Lauro Moura <lauromoura@expertisesolutions.com.br>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10228
Mike Blumenkrantz [Fri, 27 Sep 2019 14:26:27 +0000 (10:26 -0400)]
edje: rename edje_types.eot to efl_canvas_types.eot and move include
this has no relation to legacy and should not be included in legacy headers
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10227
Mike Blumenkrantz [Fri, 27 Sep 2019 14:06:30 +0000 (10:06 -0400)]
efl/canvas: add Efl_Canvas.h
this includes all the efl.canvas headers and adds some compilation tests
for the header to the unit test suite
ref T8274
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10226
Hermet Park [Mon, 30 Sep 2019 07:53:29 +0000 (16:53 +0900)]
evas map: diable high quality texture mapping feature.
This is a little bit buggy, need to make it stablize further.
Temporarily diable this for 1.23 release.
Jaehyun Cho [Mon, 30 Sep 2019 07:19:31 +0000 (07:19 +0000)]
theme: port to efl.ui.clickable and use macro for anchor style
This patch applies the following commits to anchor style.
bb1388798b1afaced65484cedf385a93f6b1bb6a
122ca2fa2f9290729e10715253e45f0ad343e09a
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10247
Jaehyun Cho [Mon, 30 Sep 2019 06:51:31 +0000 (15:51 +0900)]
eolian_mono: support beta for enum if mono-beta is enabled
Summary: this generates beta enum with `-Dmono-beta=true`.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10246
Yeongjong Lee [Mon, 30 Sep 2019 04:52:45 +0000 (13:52 +0900)]
eolian_mono: Respect beta for enum
Summary: this prevent generating beta enum with `-Dmono-beta=false`.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=false
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10245
Hosang Kim [Mon, 8 Jul 2019 11:53:28 +0000 (20:53 +0900)]
evas_event: fix proxy event is not passed through
Change-Id: I1e56af96688a9f9f05b703f21d8f8353174cfbce
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Jongmin Lee [Sun, 29 Sep 2019 21:49:05 +0000 (06:49 +0900)]
build: resolve build error during migration
Change-Id: I9b5d04334b51653fa691ee6f8733484d79c46b66
Dave Andreoli [Sun, 29 Sep 2019 09:29:38 +0000 (11:29 +0200)]
Pyolian: implemented eolian Error object
Dave Andreoli [Sun, 29 Sep 2019 08:19:11 +0000 (10:19 +0200)]
Pyolian: reformat code to make pycharm happy
and fix some typos in the code
Marcel Hollerbach [Sat, 28 Sep 2019 16:02:56 +0000 (18:02 +0200)]
elm_*: make scrolling correct again
in revision D9859 the scroll events have been renamed. However this also
renamed the legacy widgets, which also renamed the evas smart events,
which is a bug. With this commit we are back to plain old
evas_smart_callback_call calls, as these just take the string, and do
not need the bypassing through the eo events.
This fixes:
- elm_test gengrid,toolbar,panel (the events are now shown correctly
again)
- scrolling in elm_code_widget
- elm_map in a touchscreen
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10240
Mike Blumenkrantz [Fri, 27 Sep 2019 18:34:32 +0000 (14:34 -0400)]
elm_test: undef logging macros before redefining them in header
Summary: Depends on D10228
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10229
Bruno da Silva Belo [Fri, 27 Sep 2019 15:07:37 +0000 (15:07 +0000)]
efl_ui_suite: Some pointers were being delete.
`efl_ui_smart_transition_lifetime` test causes segfault
when compile with `clang`.
Fixes half of T8277
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10221
Xavi Artigas [Fri, 27 Sep 2019 12:42:27 +0000 (08:42 -0400)]
themes: Rename "dragable" to "draggable"
Summary:
"Dragable" is a misspelling:
https://en.wiktionary.org/wiki/dragable
We have it EVERYWHERE in EFL, even with jokes:
./src/lib/efl/interfaces/efl_ui_drag.eo:1
This patch only fixes the theme API so it does not get carved in stone for this release.
Depends on D10217
Test Plan: No functional changes.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10218
Jaehyun Cho [Fri, 27 Sep 2019 12:40:35 +0000 (08:40 -0400)]
theme: replace hbar and vbar to horizontal_bar and vertical_bar
Summary:
To make clear the meaning, hbar and vbar are replaced to horizontal_bar
and vertical_bar.
Reviewers: zmike, woohyun, segfaultxavi
Reviewed By: zmike, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10217
Shinwoo Kim [Fri, 27 Sep 2019 06:30:36 +0000 (15:30 +0900)]
evas filter: Implement grayscale filter in pure GL
Summary:
Initial version implementing grayscale filter in pure GL.
This patch needs a logt of love as 5bce712 did.
Grasyscale formula:
https://www.tutorialspoint.com/dip/grayscale_to_rgb_conversion.htm
Test Plan:
1. Create filter_example with following .
efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");
2. Run.
ELM_ACCEL=gl ./filter_example
Reviewers: Hermet, jsuya
Subscribers: ali.alzyod, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9858
Cedric Bail [Fri, 27 Sep 2019 05:19:38 +0000 (14:19 +0900)]
evas: fix memory leak with Efl.Canvas.Vg
Summary:
It is not correct to change the parent and hope that refcount will work
for you. The parent chain is a decision made by the user, not something
a widget can touch. Only ref count are to be used when given an outside
object. As things where not triggering destruction, there was also no
point where the image buffer would be getting to zero and be freed. This
commit also fix this.
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10169
Jaehyun Cho [Fri, 27 Sep 2019 03:21:48 +0000 (23:21 -0400)]
theme: remove efl.track.slider and efl.track2.slider from efl_ui_slider
Summary:
efl_ui_slider does not support popup which shows the current value.
Therefore, efl.track.slider and efl.track2.slider swallows which set the
popup size and position are not required in efl_ui_slider.
Reviewers: zmike, woohyun
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10216
Mike Blumenkrantz [Thu, 26 Sep 2019 22:00:05 +0000 (18:00 -0400)]
evas/object; fix null deref
Summary:
_efl_canvas_object_clipper_prev_reset() derefs obj->cur
CID 1396985
Depends on D10211
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10212
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:59 +0000 (17:59 -0400)]
eio/dir: fix null deref
Summary:
above cases may fail, causing target to be null
CID 1399103
Depends on D10210
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10211
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:54 +0000 (17:59 -0400)]
efl_ui/image fix null derefs
Summary:
CID 1405781, 1405780
Depends on D10209
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10210
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:49 +0000 (17:59 -0400)]
efl_ui/scroll_manager: fix null derefs
Summary:
CID 1405811, 1405804
Depends on D10208
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10209
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:43 +0000 (17:59 -0400)]
efl_ui/table: handle case where table has no items
Summary:
CID 1399086
Depends on D10207
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10208
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:38 +0000 (17:59 -0400)]
ecore_evas/convert: fix div by zero
Summary:
if one is 0, the printf line will divide by it
CID 1403900
Depends on D10206
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10207
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:34 +0000 (17:59 -0400)]
tests/eina: outdent code
Summary:
this is a very important coverity issue.
CID 1400838
Depends on D10205
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10206
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:29 +0000 (17:59 -0400)]
eina/list: move dead code inside corresponding #ifdef
Summary:
this is debug code
CID 1404753, 1404745
Depends on D10204
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10205
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:24 +0000 (17:59 -0400)]
tests/strbuf: call va_end for varargs
Summary: CID 1400792
Reviewers: brunobelo
Reviewed By: brunobelo
Subscribers: brunobelo, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10204
Mike Blumenkrantz [Thu, 26 Sep 2019 21:59:19 +0000 (17:59 -0400)]
epp: remove extra variable passed in format specifier
Summary: CID 1402674
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10203
Bruno da Silva Belo [Thu, 26 Sep 2019 21:48:20 +0000 (18:48 -0300)]
eolian_cxx: Possible infinite loop, if called.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10200
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again
Summary:
this isn't strictly necessary at the moment
Depends on D10197
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10199
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23
Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing
ref T8231
Depends on D10196
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10197
Change-Id: I79bb8f1ad664172b1dd136cfc071f20a66a7467e
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles
Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10196
Change-Id: Icf3a44ea37afef6804108971c4a117cd08324cba
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check
Summary:
coverage++
Depends on D10194
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10195
Change-Id: Iac8dddaa348cc08a6cee94090be35b4bc98d91f3
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails
Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10194
Change-Id: I21f9bb740ff0316866fd5e0060ef8ed287fa2c97
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning
Summary:
a variable with the same name is declared above
Depends on D10192
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10193
Change-Id: I8d39246bf4276ce4a6880f214b36bae422f7d7f7
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals
Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10192
Change-Id: Ida519eed1ac99c8ecc7f07e1ba0ce7583d6110d9
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window
Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10014
Change-Id: Ic69aa45cdbf6a9cd125edc32f98b28616af8e709
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window
Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10013
Change-Id: I8d88315a36d8b74e6839d9648f6581a3c3a65875
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window
Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing
Depends on D9899
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10012
Change-Id: Iedae76203dc28ad3e496eeaf300513ae423552d6
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly
Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed
fix T7838
Depends on D10014
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7838
Differential Revision: https://phab.enlightenment.org/D9900
Change-Id: Ife7e3217461e06ef5f711d5ee57cf8587c56c137
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code
Summary:
handle cases where null params could be passed and cause crashes
@fix
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9899
Change-Id: I784f393ee7f93fb5b1c914dfb5d79f23a6999847
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const
Change-Id: I9a0442d0d9c8c3e0c801b8f8e2baa38052b528e9
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model
Summary:
stabilzed Efl.Generic_Model
depends on D10188
Reviewers: cedric, zmike, segfaultxavi
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10189
Change-Id: I34e7eece539fea71057d1d6e77fffeadddb3cb03
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View
Summary:
Efl.Ui.View is base infrastructure interface of MVVM.
fixes T7578
Reviewers: zmike, cedric, segfaultxavi, bu5hm4n
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7578
Differential Revision: https://phab.enlightenment.org/D10188
Change-Id: Iccf2d4faf276d0e454eaf6e95b8335c5f4a3ed5c
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency
Change-Id: I7f3e09d39d32b8dcb3c35ba1085756acb6b90b54
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Change-Id: I71ea138db0959c178c5d496fcdb4a93bbeaceba8
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events
this is just a button and not the full clickable struct
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API
Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.
Reviewers: zmike, segfaultxavi, bu5hm4n
Reviewed By: zmike, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10186
Change-Id: I036c10c301d223b4cd1cec0c5ae415f5ad2f9ed3
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value
Summary:
When invalid object comes, the return value should be
EINA_FALSE.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10185
Change-Id: Ib2f71f30594bbf02434c6ee4accceb091a65c90d
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value
Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.
Reviewers: zmike, bu5hm4n, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10187
Change-Id: Ia7e1f46f9f089afc237557ca64ab857317a20253
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable
Summary:
fixes T7871
fixes T7852
This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.
Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: SanghyeonLee, cedric
Tags: #efl
Maniphest Tasks: T7871, T7852
Differential Revision: https://phab.enlightenment.org/D10184
Change-Id: I734b272411e3fc9ebb79d907f171528849219c10
Radoslaw Cybulski [Fri, 6 Sep 2019 09:54:20 +0000 (11:54 +0200)]
atspi: add stop reading command
Adds stop reading command over dbus, which cancels all quened readings
(including one in progress if any). Additional passed argument, boolean
flag, when set to false limits cancelling only to discardable readings.
Change-Id: I1ff8571edbaf0513da9d710c9eea16846aba62d4
Hosang Kim [Wed, 25 Sep 2019 09:33:00 +0000 (18:33 +0900)]
evas_events: fix usage of last mouse
Change-Id: Ifa21646cf43f969c347ca7fe4127309f2920ddf4
Jongmin Lee [Thu, 26 Sep 2019 21:57:18 +0000 (06:57 +0900)]
build: resolve migration build errors
Change-Id: I588c4a50424c77b980136c89b31a25d28c452c68
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again
Summary:
this isn't strictly necessary at the moment
Depends on D10197
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10199
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23
Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing
ref T8231
Depends on D10196
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10197
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles
Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10196
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check
Summary:
coverage++
Depends on D10194
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10195
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails
Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10194
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning
Summary:
a variable with the same name is declared above
Depends on D10192
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10193
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals
Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10192
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings
projects / platform / upstream / efl.git / log