oliver@apple.com [Thu, 16 Feb 2012 01:29:12 +0000 (01:29 +0000)]
Ensure that the DFG JIT always plants a CodeOrigin when making calls
https://bugs.webkit.org/show_bug.cgi?id=78763
Reviewed by Gavin Barraclough.
Make all calls plant a CodeOrigin prior to the actual
call. Also clobbers the Interpreter with logic to ensure
that the interpreter always plants a bytecode offset.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(CallBeginToken):
(JSC::DFG::JITCompiler::beginJSCall):
(JSC::DFG::JITCompiler::beginCall):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(ExecState):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::codeOriginIndexForDFG):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 16 Feb 2012 01:19:28 +0000 (01:19 +0000)]
Source/WebCore: Fix test regressons from r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564
Move setting CachedRawResource::m_identifer from
data() to setResponse(). WorkerScriptLoader depends
on the identifier being set correctly during setResponse()
in order to correctly mark itself as a ScriptResource in
the inspector.
Reviewed by Adam Barth.
Fixes several worker script loading tests.
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data):
(WebCore::CachedRawResource::setResponse):
LayoutTests: Remove Skipped tests that were broken by r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564
Reviewed by Adam Barth.
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Thu, 16 Feb 2012 01:06:44 +0000 (01:06 +0000)]
Unreviewed, rolling out r107704.
http://trac.webkit.org/changeset/107704
https://bugs.webkit.org/show_bug.cgi?id=78486
Caused layout test crashes in debug builds.
Specific crashing tests:
fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html
inspector/console/console-long-eval-crash.html
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 16 Feb 2012 00:47:23 +0000 (00:47 +0000)]
[chromium] Unreviewed. regionOverflow tests are flaky in debug.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Thu, 16 Feb 2012 00:45:53 +0000 (00:45 +0000)]
REGRESSION: "Copy image" fails...copies image URL instead.
https://bugs.webkit.org/show_bug.cgi?id=78723
<rdar://problem/
10869104>
During the refactoring of the Pasteboard class some code was lost.
When placing an NSImage in the NSPasteboard as NSTIFFPboardType, we need
to use the its TIFF representation.
Reviewed by Andy Estes.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 16 Feb 2012 00:39:25 +0000 (00:39 +0000)]
[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644
Reviewed by Antonio Gomes.
No functionalities changed, no new tests.
* blackberry/Api/ActiveNodeContext.h: Renamed from Source/WebKit/blackberry/Api/BlackBerryContext.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Thu, 16 Feb 2012 00:27:45 +0000 (00:27 +0000)]
[soup] Add support for multiple SoupSessions.
https://bugs.webkit.org/show_bug.cgi?id=77341
Source/WebCore:
Reviewed by Gustavo Noronha Silva.
Make the libsoup network backend support multiple SoupSessions. This is
accomplished by using the NetworkingContext classes, which now have a
`soupSession()' method when the libsoup backend is being used.
libsoup's ResourceHandle implementation now retrieves the SoupSession
via the NetworkingContext it receives instead of relying on
defaultSession(). defaultSession() is still used when a null
NetworkingContext is passed to ResourceHandle::start (for example, via
webkit_download_start).
The CookieJar implementation retrieves the SoupSession from the
NetworkingContext as much as possible as well -- the functions used by
WebKit2 could not be converted, though, as they seem to assume there is
only one shared cookie jar.
No new tests, covered by the existing ones.
* platform/network/NetworkingContext.h:
(NetworkingContext): Add soupSession() method if USE(SOUP) is set.
* platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForDocument):
(WebCore):
(WebCore::defaultCookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::soupSession): Add method to retrieve
a SoupSession from a NetworkingContext and fallback to defaultSession()
if there's no valid NetworkingContext.
(WebCore):
(WebCore::ensureSessionIsInitialized): Only change or use the default
cookie jar if the SoupSession being changed is the default one.
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::cancel):
(WebCore::startNonHTTPRequest):
Source/WebKit/efl:
Add the necessary infrastructure to support multiple SoupSessions. Each
WebView now has a "session" property, which defaults to
ResourceHandle::defaultSession() and can be changed to another
SoupSession by the user.
Some API in ewk_network and ewk_view which required SoupSession to be a
valid type in the headers has now been moved inside #if USE(SOUP)
ifdefs so we can actually the required Soup header and avoid build
problems with duplicate typedefs.
* CMakeListsEfl.txt:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::createNetworkingContext):
* WebCoreSupport/FrameNetworkingContextEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h.
(WebCore):
(WebCore::FrameNetworkingContextEfl::create):
(WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
(WebCore::FrameNetworkingContextEfl::soupSession):
* WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
* ewk/ewk_cookies.h: Mention this API is only valid with the
default SoupSession.
* ewk/ewk_network.cpp:
(ewk_network_default_soup_session_get): Define only if USE(SOUP) is set.
* ewk/ewk_network.h: Ditto, and mention this API is only valid with the
default SoupSession.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
* ewk/ewk_view.h:
():
Source/WebKit/gtk:
Reviewed by Gustavo Noronha Silva.
Adapt to the changes to FrameNetworkingContext in WebCore.
* GNUmakefile.am:
* WebCoreSupport/FrameNetworkingContextGtk.cpp: Copied from Source/WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h.
(WebKit):
(WebKit::FrameNetworkingContextGtk::soupSession): Always return ResourceHandle::defaultSession().
* WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 16 Feb 2012 00:01:55 +0000 (00:01 +0000)]
The TileCache object should be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78757
<rdar://problem/
10866161>
Reviewed by Sam Weinig.
Since the WebTileCacheLayer can be deleted on the scrolling thread, we need to make sure that the underlying
TileCache object is actually destroyed on the main thread.
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::~TileCache):
Assert that this object is being destroyed on the main thread.
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer dealloc]):
If dealloc is being called from a non-main thread, make sure to delete the tile cache object on the main thread.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 15 Feb 2012 23:58:55 +0000 (23:58 +0000)]
[chromium] Unreviewed, rebasing tests after r107836.
* platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac-leopard/fast/transforms/shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png:
* platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Wed, 15 Feb 2012 23:54:02 +0000 (23:54 +0000)]
[Chromium] Roll DEPS to r122122
https://bugs.webkit.org/show_bug.cgi?id=78754
Unreviewed DEPS roll.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 23:47:26 +0000 (23:47 +0000)]
Scrolling Coordinator must be deleted on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78756
<rdar://problem/
10866167>
Reviewed by Sam Weinig.
ScrollingTree::invalidate will finish breaking the cycle between the scrolling coordinator and the
scrolling tree by dereffing the scrolling coordinator. We need to make sure that this happens on the main
thread because the scrolling coordinator expects to be destroyed from there.
* page/scrolling/ScrollingTree.cpp:
(WebCore::derefScrollingCoordinator):
(WebCore):
(WebCore::ScrollingTree::invalidate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 23:37:25 +0000 (23:37 +0000)]
Scrolling coordinator should handle pages being restored from the page cache
https://bugs.webkit.org/show_bug.cgi?id=78753
<rdar://problem/
10866171>
Reviewed by Sam Weinig.
Replace ScrollingCoordinator::frameViewScrollLayerDidChange with a new member function,
ScrollingCoordinator::frameViewRootLayerDidChange which is called whenever the root layer
of the frame view changes (which happens on back/forward navigation as well).
In this function, reset the scrolling tree state from the frame view.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::scrollLayerForFrameView):
Add a helper function.
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Reset the entire scrolling tree state.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Call the newly added helper function.
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
Remove frameViewScrollLayerDidChange.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
Remove call to ScrollingCoordinator::frameViewScrollLayerDidChange.
(WebCore::RenderLayerCompositor::attachRootLayer):
Call ScrollingCoordinator::frameViewRootLayerDidChange.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Wed, 15 Feb 2012 23:14:24 +0000 (23:14 +0000)]
[chromium] Add setter/getter to expose drag data as a list of items
https://bugs.webkit.org/show_bug.cgi?id=77125
This change supports the unification of the data store backing ChromiumDataObject and
DataTransferItemListChromium. ChromiumDataObject will represent dragging and clipboard data
as a list of data nodes to make it more straightforward to implement the HTML spec for
DataTransferItemList. Thus, we extend the abstraction to the webkit glue layer to
simplify the serialization/deserialization between platform-specific data and WebDragData.
The other setter/getter methods are deprecated and will be removed once the dependencies in
Chromium code are gone.
Reviewed by Darin Fisher.
* public/platform/WebDragData.h:
(WebKit):
(WebDragData):
* src/WebDragData.cpp:
(WebKit::WebDragData::items):
(WebKit):
(WebKit::WebDragData::setItems):
(WebKit::WebDragData::addItem):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 23:10:26 +0000 (23:10 +0000)]
Add TiledCoreAnimationDrawingArea::forceRepaint
https://bugs.webkit.org/show_bug.cgi?id=78749
<rdar://problem/
10866221>
Reviewed by Sam Weinig.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Force a repaint and synchronize the layer tree to the UI process.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Wed, 15 Feb 2012 23:08:25 +0000 (23:08 +0000)]
Refactor ClipboardMac class to use PlatformStrategies.
https://bugs.webkit.org/show_bug.cgi?id=78554
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. No change in behavior.
* WebCore.exp.in: Added new exported methods of the PlatformPasteboard class
* editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard): Use name based pasteboard references.
* page/DragClient.h:
(WebCore::DragClient::declareAndWriteDragImage): Ditto.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard): Ditto.
* platform/PasteboardStrategy.h: Added new methods to get a unique pasteboard name
and the pasteboard change count.
* platform/PlatformPasteboard.h: Ditto.
* platform/mac/ClipboardMac.h:
(WebCore::ClipboardMac::create): Using name based pasteboard.
(WebCore::ClipboardMac::pasteboardName): Replacing the old pasteboard() method.
* platform/mac/ClipboardMac.mm: All the methods below have been modified to avoid
using Objective-C types and direct access to NSPasteboard object.
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::hasData):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::absoluteURLsFromPasteboardFilenames):
(WebCore::absoluteURLsFromPasteboard):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writePlainText):
(WebCore::ClipboardMac::writeURL):
(WebCore::ClipboardMac::declareAndWriteDragImage):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard): Using name based pasteboard reference.
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::getPathnamesForType): Fixed to support NSArray and NString content.
(WebCore::PlatformPasteboard::changeCount): Added.
(WebCore::PlatformPasteboard::uniqueName): Added.
Source/WebKit/mac:
* WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
* WebCoreSupport/WebDragClient.mm: Ditto.
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
* WebCoreSupport/WebPlatformStrategies.h: Added new methods.
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::changeCount):
(WebPlatformStrategies::uniqueName):
Source/WebKit2:
* WebProcess/WebCoreSupport/WebDragClient.h: Changed method signature to reference
the pasteboard by name.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added new methods.
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Changed method signature to reference
the pasteboard by name.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 22:48:36 +0000 (22:48 +0000)]
TileCache needs to support setting the contents scale
https://bugs.webkit.org/show_bug.cgi?id=78741
<rdar://problem/
10710773>
Reviewed by Sam Weinig.
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):
Update the contents scale of all the tiles and then revalidate the tile cache since tiles
might have come and gone as a result of setting the contents scale.
(WebCore::TileCache::createTileLayer):
Set the contents scale of the tile layer.
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setContentsScale.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 22:36:31 +0000 (22:36 +0000)]
Try to fix the Chromium build and remove a snarky comment in the process.
* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::handleWheelEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Wed, 15 Feb 2012 22:14:51 +0000 (22:14 +0000)]
Unreviewed gardening: mark a test as no longer MISSING.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 15 Feb 2012 22:09:29 +0000 (22:09 +0000)]
Unreviewed gardening: Fix more results after r107833.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 22:06:39 +0000 (22:06 +0000)]
Wheel events should be re-dispatched to the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78731
<rdar://problem/
10866144>
Reviewed by Sam Weinig.
When threaded scrolling is enabled, all the state is assumed to be kept in the scrolling tree,
on the scrolling thread. This means that even if we do end up processing an event on the main thread
(because of wheel event handlers for example), we still have to dispatch the wheel event back to the
scrolling thread.
* page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
Move wheelEvent from ScrollView and ask the scrolling coordinator to handle the wheel event.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEvent):
Dispatch the event to the scrolling thread, unless it will start a gesture. In that case we'll return false
so that information will be passed back to the UI process.
(ScrollingCoordinator):
* platform/ScrollView.cpp:
* platform/ScrollView.h:
Move wheelEvent to FrameView.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 15 Feb 2012 21:59:36 +0000 (21:59 +0000)]
RootObject::finalize can cause a crash in object->invalidate()
https://bugs.webkit.org/show_bug.cgi?id=78645
Reviewed by Geoffrey Garen.
No new tests.
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::finalize): Added a stack-allocated RefPtr to protect the RootObject
during the call to invalidate().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 15 Feb 2012 21:57:02 +0000 (21:57 +0000)]
<rdar://problem/
10870238> Box shadow drawing takes an unnecessarily slow code path in some single-shadow, opaque-background cases
https://bugs.webkit.org/show_bug.cgi?id=78728
In some cases, when there is only one normal box shadow, and the box has an opaque background,
it is possible to draw the box shadow by having the background cast it directly. This appears
to be faster than the generic code path that uses a separate drawing pass to cast the shadow,
clipping out the border box and the shadow-casting box.
Reviewed by Dave Hyatt.
No new tests, because behavior is unchanged.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Ditto.
* rendering/RenderBox.h: Made determineBackgroundBleedAvoidance() protected.
* rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground): Added this helper function, which applies the first
normal shadow from the given RenderStyle to the given GraphicsContext.
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Added calls to
applyBoxShadowForBackground() before drawing the background color when needed.
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added. Returns true
in some of the cases where the box shadow can be cast by the background directly.
* rendering/RenderBoxModelObject.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground): Added this override that
always returns false, because table cells sometimes apply a clip before drawing the background.
* rendering/RenderTableCell.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 15 Feb 2012 21:02:37 +0000 (21:02 +0000)]
[chromium] Unreviewed, adding the chromium-mac result for this test (test added in r107822).
* platform/chromium-mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 15 Feb 2012 20:30:13 +0000 (20:30 +0000)]
Add a test asserting that the second argument to MutationCallback is the observer
https://bugs.webkit.org/show_bug.cgi?id=78653
Reviewed by Ryosuke Niwa.
This is specified in the spec text, so I wanted to make sure it was
properly exercised in a layout test.
* fast/mutation/callback-second-argument-expected.txt: Added.
* fast/mutation/callback-second-argument.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 15 Feb 2012 20:26:40 +0000 (20:26 +0000)]
getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
https://bugs.webkit.org/show_bug.cgi?id=76326
Reviewed by Tony Chang.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
* css3/flexbox/css-properties-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 20:21:15 +0000 (20:21 +0000)]
Notify ChromeClient when touch-event handlers are installed/removed.
https://bugs.webkit.org/show_bug.cgi?id=77440
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-15
Reviewed by Darin Fisher and Ryosuke Niwa.
Source/WebCore:
Keep a count of the number of touch-event handlers and notify the
embedder when the count changes. Depending on the count, the embedder
can decide whether or not to dispatch touch events to webkit.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler):
(WebCore):
(WebCore::Document::didRemoveTouchEventHandler):
* dom/Document.h:
(WebCore::Document::touchEventHandlerCount):
(Document):
* dom/Node.cpp:
(WebCore::isTouchEventType):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::numTouchEventHandlersChanged):
* page/ChromeClient.h:
(ChromeClient):
* page/Frame.cpp:
(WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
(WebCore::Frame::notifyChromeClientTouchEventHandlerCountChanged):
(WebCore):
* page/Frame.h:
(Frame):
Source/WebKit/chromium:
* public/WebViewClient.h:
(WebKit::WebViewClient::numberOfTouchEventHandlersChanged):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numTouchEventHandlersChanged):
(WebKit):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfTouchEventHandlersChanged):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/efl:
* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::numTouchEventHandlersChanged):
Source/WebKit/gtk:
* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::numTouchEventHandlersChanged):
Source/WebKit/mac:
* WebCoreSupport/WebChromeClient.h:
Source/WebKit/qt:
* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::numTouchEventHandlersChanged):
Source/WebKit/win:
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numTouchEventHandlersChanged):
Source/WebKit/wince:
* WebCoreSupport/ChromeClientWinCE.h:
(WebKit::ChromeClientWinCE::numTouchEventHandlersChanged):
Source/WebKit/wx:
* WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::numTouchEventHandlersChanged):
Source/WebKit2:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::numTouchEventHandlersChanged):
* WebProcess/WebCoreSupport/WebChromeClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Wed, 15 Feb 2012 20:03:27 +0000 (20:03 +0000)]
Unset the active flag when TextTrackCues go away
https://bugs.webkit.org/show_bug.cgi?id=72552
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: media/track/track-active-cues.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired): Configure new text tracks before preparing to load
so we know about all tracks when resource selection begins.
(WebCore::HTMLMediaElement::prepareForLoad): Call updateActiveTextTrackCues after setting
to m_readyState is HAVE_NOTHING so all cues get deactivated. Don't build list of
available text tracks because resource selection won't actually start until after the load timer fires.
(WebCore::HTMLMediaElement::loadInternal): Build list of non-disabled tracks.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Clear the active flag on all cues
when m_readyState is HAVE_NOTHING or m_player is 0.
(WebCore::HTMLMediaElement::setReadyState): Don't update m_readyState when tracks which haven't
loaded yet will prevent events from firing. Call updateActiveTextTrackCues to ensure that the
first cue(s) are shown as soon as possible.
(WebCore::HTMLMediaElement::userCancelledLoad): Call updateActiveTextTrackCues when when m_readyState
is HAVE_NOTHING so all cues get deactivated.
LayoutTests:
* media/track/track-active-cues-expected.txt: Added.
* media/track/track-active-cues.html: Added.
* track-cue-mutable-text.html: Update to not run test until track and video have
both loaded.
* media/video-test.js:
(waitForEventsAndCall): New, call the specified function after the list of events
has been seen.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Wed, 15 Feb 2012 19:52:07 +0000 (19:52 +0000)]
Unreviewed gardening.
Added baseline for new test multiple-filters-invalidation.html.
* platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 15 Feb 2012 19:44:34 +0000 (19:44 +0000)]
Stop skipping fast/filesystem/file-writer-gc-blob.html, as FileWriter is well-supported in DRT.
Unreviewed test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 15 Feb 2012 19:43:47 +0000 (19:43 +0000)]
[chromium] Unreviewed, land chromium pixel results after r107797.
* platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 15 Feb 2012 19:37:01 +0000 (19:37 +0000)]
fast/regions/element-region-overflow-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=78654
Reviewed by Ojan Vafai.
Sometimes layout happens before test() is called (e.g., if one of the
script or other resources take a long time to load). In that case, we
get different results. Not waiting for the load event should always
be before layout.
* fast/regions/element-region-overflow-state-expected.txt:
* fast/regions/element-region-overflow-state.html:
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt
* fast/regions/element-region-overflow-state-vertical-rl.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Wed, 15 Feb 2012 19:16:39 +0000 (19:16 +0000)]
Re-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they never crash.
Unreviewed test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 15 Feb 2012 18:57:06 +0000 (18:57 +0000)]
WebCore build exceeds address space on 32-bit Windows builders (again).
https://bugs.webkit.org/show_bug.cgi?id=78724
Reviewed by Jon Honeycutt.
Add the rest of the inspector .cpp files to the InspectorAllInOne.cpp file in Production and
Release builds.
* WebCore.vcproj/WebCore.vcproj:
In the process, let VS have its way with this file.
* inspector/InspectorAllInOne.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 18:53:50 +0000 (18:53 +0000)]
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661
Reviewed by Adam Roben.
Source/WebCore:
ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/ScrollAnimator.cpp:
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
* platform/ScrollableArea.h:
(ScrollableArea):
Source/WebKit/chromium:
Update for WebCore changes.
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Wed, 15 Feb 2012 18:44:33 +0000 (18:44 +0000)]
Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626
Reviewed by Darin Adler.
Test: css3/filters/multiple-filters-invalidation.html
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.
LayoutTests: New test to exercise invalidation of multiple CSS filters.
https://bugs.webkit.org/show_bug.cgi?id=78626
Reviewed by Darin Adler.
* css3/filters/multiple-filters-invalidation-expected.txt: Added.
* css3/filters/multiple-filters-invalidation.html: Added.
* platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 15 Feb 2012 16:09:30 +0000 (16:09 +0000)]
Web Inspector: "Minus" (Delete) button disappears for hovered watch expression in Watches pane
https://bugs.webkit.org/show_bug.cgi?id=78714
Reviewed by Pavel Feldman.
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._mouseOut):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 15 Feb 2012 16:01:36 +0000 (16:01 +0000)]
[CMake] Move RunLoop to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=78504
Reviewed by Adam Roben.
Source/WebCore:
r105475 moved RunLoop.cpp from WebKit2 to WebCore, but missed the CMake based ports.
* CMakeLists.txt:
* PlatformWinCE.cmake:
Source/WebKit2:
* CMakeLists.txt: Remove RunLoop.cpp from list of souces.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 15:56:59 +0000 (15:56 +0000)]
Unreviewed Qt 4.x build fix.
* WebCoreSupport/PageClientQt.cpp: Fix the QT_VERSION_CHECK pre-processor foo.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Wed, 15 Feb 2012 15:54:31 +0000 (15:54 +0000)]
Remove clipToImageBuffer from SourceAlpha and feComposite
https://bugs.webkit.org/show_bug.cgi?id=78355
Reviewed by Nikolas Zimmermann.
The implementation of clipToImageBuffer is inefficient on
non-mac platforms, so we would benefit if remove it.
Existing tests cover this feature.
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::platformApplySoftware):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 15:42:30 +0000 (15:42 +0000)]
[Qt] Replace use of QGLWidget/QGLContext with QOpenGLContext and QSurface for Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78694
Reviewed by Noam Rosenthal.
Source/WebCore:
Typedef PlatformGraphicsContext3D and PlatformGraphicsSurface3D to QOpenGLContext
and QSurface for Qt 5. Use these APIs to change the current context and get the
procedure addresses. Removed QGraphicsObject inheritance remainder while we're at it,
because that code path is obsolete.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/cairo/OpenGLShims.cpp:
(WebCore::getProcAddress):
* platform/graphics/cairo/OpenGLShims.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
Source/WebKit/qt:
* WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget): Return the QOpenGLContext and QSurface
from the QGLWidget when compiling with Qt 5, as that's what WebCore expects.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 15:38:06 +0000 (15:38 +0000)]
[Qt] Add UI for HTTP authentication in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=76347
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-15
Reviewed by Kenneth Rohde Christiansen.
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/DialogLineInput.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 15:33:07 +0000 (15:33 +0000)]
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
https://bugs.webkit.org/show_bug.cgi?id=78692
Reviewed by Noam Rosenthal.
Source/WebCore:
Replace the "glWidget" term in the GraphicsContext with "surface" and delegate
the context and surface creation to the page client.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
* platform/qt/QWebPageClient.h:
(QWebPageClient):
Source/WebKit/qt:
Implement GLWidget and GLContext creation from the page client interface.
* WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget):
(WebCore):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):
* WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Wed, 15 Feb 2012 15:29:40 +0000 (15:29 +0000)]
[Texmap] Support filters in TextureMapperImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=76026
Source/WebCore:
Implement GraphicsLayer::setFilters for TextureMapper, and pass the filters all the way
to BitmapTextureImageBuffer. This does not introduce a new filters implementation, but
rather uses the non-AC implementation. A complete implementation will be needed in
TextureMapperGL, which can use some of the glue in this code.
Reviewed by Kenneth Rohde Christiansen.
Unskipped 10 tests in css3/filters.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setFilters):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapper.h:
(BitmapTexture):
(WebCore::BitmapTexture::applyFilters):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore):
(WebCore::BitmapTextureImageBuffer::applyFilters):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore):
(WebCore::applyFilters):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
* platform/graphics/texmap/TextureMapperLayer.h:
(State):
LayoutTests:
Unskipping hardware filter tests. They're still skipped in WebKit2.
Reviewed by Kenneth Rohde Christiansen.
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:
* platform/qt/css3/filters/crash-hw-sw-switch-expected.png:
* platform/qt/css3/filters/effect-blur-hw-expected.png: Added.
* platform/qt/css3/filters/effect-blur-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-combined-expected.png: Added.
* platform/qt/css3/filters/effect-combined-expected.txt: Added.
* platform/qt/css3/filters/effect-combined-hw-expected.png: Added.
* platform/qt/css3/filters/effect-combined-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-grayscale-hw-expected.png: Added.
* platform/qt/css3/filters/effect-grayscale-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-invert-hw-expected.png: Added.
* platform/qt/css3/filters/effect-invert-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/qt/css3/filters/effect-opacity-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/qt/css3/filters/effect-saturate-hw-expected.txt: Added.
* platform/qt/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/qt/css3/filters/effect-sepia-hw-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 15:26:28 +0000 (15:26 +0000)]
[Qt] Clean up fallback rendering of GraphicsContext3D to Canvas
https://bugs.webkit.org/show_bug.cgi?id=78690
Reviewed by Noam Rosenthal.
Use the common paintRenderingResultsToCanvas code to retrieve the
pixels from the FBO and use a Qt port specific paintToCanvas
implementation to wrap the pixels into a QImage and render it
into the graphics context, just like it's done for the other ports.
This removes the QGraphicsObject based paint, which is an now
obsolete method of rendering.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::paintToCanvas):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 15:13:58 +0000 (15:13 +0000)]
[EFL] Add missing libsoup to (pkgconfig) dependency requirements
https://bugs.webkit.org/show_bug.cgi?id=78702
Unreviewed build fix.
Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-15
* ewebkit.pc.in: Now that bug 77874 had its patch landed, we
always require libsoup as a dependency for the EFL port. The
'Require' session of this file has to contemplate that, otherwise
code linking with ewebkit will fail to lookup to libsoup's header
files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 14:14:27 +0000 (14:14 +0000)]
[Qt] Eliminate first set of QtWidgets dependencies from WebCore
https://bugs.webkit.org/show_bug.cgi?id=78611
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
* bindings/js/ScriptControllerQt.cpp: Remove unused include.
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::tabsToAllFormControls): Replace import
of private Qt(Widgets) variable with the default of Qt 5, where
it is also not configurable.
* platform/ContextMenu.h: Remove unused include.
* platform/ContextMenuItem.h: Ditto.
* platform/Widget.h: Use QObject as type for PlatformWidget
instead of QWidget.
* platform/graphics/Icon.h:
(Icon): Prefer QImage over QIcon for storage.
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
(WebCore): Make it compile with QWindow for Qt 5 and QWidget for Qt 4.
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(PlatformVideoWindow::PlatformVideoWindow):
* platform/graphics/qt/IconQt.cpp: Revert the implementation of this class
back to notImplemented(). It was trying to load the actual file as QIcon
instead of trying to find a symbolic icon for the given file. We should
probably use the QMimeType API in Qt 5 once it becomes available.
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):
* platform/graphics/qt/ImageQt.cpp:
(graphics): Remove use of QStyle for retrieving icons. Code moved to
WebCoreSupport instead.
* platform/qt/ContextMenuQt.cpp: Removed unused include.
* platform/qt/PlatformScreenQt.cpp: Add #ifdefs to use QScreen API
with Qt 5.
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/qt/QWebPageClient.h: Add hook for showing/hiding widget.
(WebCore):
(QWebPageClient):
* platform/qt/SoundQt.cpp:
(WebCore::systemBeep): Beep is not implemented in Qt 5 and its use is
questionable. Move back to notImplemented() until proper QPA API becomes
available in Qt 5 (if ever...).
* platform/qt/WidgetQt.cpp: Delegate QWidget specific show/hide calls
to the PageClient, out of WebCore.
(WebCore::Widget::Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
* plugins/PluginView.h: Remove unused include.
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject): When dumping properties of
QWidget, use the QObject property API to retrieve the values instead of
QWidget specific API. Removed the mask from the dump as it's not available
as property and our layout tests don't seem to use it.
Source/WebKit/qt:
* Api/qwebpage.cpp: Add missing includes.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
* WebCoreSupport/FrameLoaderClientQt.cpp: Make it compile by casting
the QObject based PlatformWidget back to QWidget before doing QWidget
specific function calls.
* WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt): Moved QStyle specific web-graphic initialization
here from WebCore.
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setWidgetVisible): Implement show/hiding of widgets
through delegation to QWidget.
(WebCore):
(WebCore::PageClientQGraphicsWidget::setWidgetVisible): Provide empty widget
show/hide implementation, as it doesn't seem to make sense for graphicsviews.
* WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
* UIProcess/qt/QtWebPageEventHandler.cpp: Add missing QCursor include
to fix compilation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 15 Feb 2012 14:11:38 +0000 (14:11 +0000)]
Web Inspector: Fix minor design issues in the Spectrum color picker
https://bugs.webkit.org/show_bug.cgi?id=78693
Drive-by: frontend compilability fixes.
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/compile-front-end.sh:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/Popover.js:
* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get isVisible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
* inspector/front-end/elementsPanel.css:
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
* inspector/front-end/inspector.css:
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Wed, 15 Feb 2012 14:09:41 +0000 (14:09 +0000)]
[CMake] Remove unused PkgConfig module import from FindCFLite.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78600
Reviewed by Adam Roben.
* Source/cmake/FindCFLite.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 15 Feb 2012 14:05:04 +0000 (14:05 +0000)]
2012-02-15 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix after r107806
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
* inspector/InjectedScript.h:
(InjectedScript):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 13:59:55 +0000 (13:59 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #13 of N.
* platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Removed.
* platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 15 Feb 2012 13:55:49 +0000 (13:55 +0000)]
Web Inspector: crash when inspecting an element on a page with eval disabled by CSP
https://bugs.webkit.org/show_bug.cgi?id=78705
Source/WebCore:
Inspector functions in injected script may use eval so we need to make sure
it is allowed for inspector code on pages where it is prohibited by CSP.
Reviewed by Pavel Feldman.
Test: inspector/elements/resolve-node-blocked.html
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
(WebCore):
(WebCore::InjectedScript::makeCall):
* inspector/InjectedScript.h:
(InjectedScript):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/elements/resolve-node-blocked-expected.txt: Added.
* inspector/elements/resolve-node-blocked.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 15 Feb 2012 13:39:18 +0000 (13:39 +0000)]
Clean up radio button tests
https://bugs.webkit.org/show_bug.cgi?id=78679
Reviewed by Kentaro Hara.
- Split checkbox-radio-onchange.html into checkbox-onchange.html and radio/radio-onchange.html.
- Convert the following rendering tests to text tests.
radio-attr-order.html
radio-nested-labels.html
radio_checked.html
radio_checked_dynamic.html
This change is a preparation of moving radio button tests to fast/forms/radio/.
* fast/forms/checkbox-onchange-expected.txt: Added.
* fast/forms/checkbox-onchange.html: Added.
* fast/forms/checkbox-radio-onchange.html: Removed.
* fast/forms/radio-attr-order-expected.txt: Added.
* fast/forms/radio-attr-order.html:
* fast/forms/radio-nested-labels-expected.txt: Added.
* fast/forms/radio-nested-labels.html:
* fast/forms/radio/radio-onchange-expected.txt: Added.
* fast/forms/radio/radio-onchange.html: Added.
* fast/forms/radio_checked-expected.txt: Added.
* fast/forms/radio_checked.html:
* fast/forms/radio_checked_dynamic-expected.txt: Added.
* fast/forms/radio_checked_dynamic.html:
* platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png: Removed.
* platform/chromium-linux/fast/forms/radio-attr-order-expected.png: Removed.
* platform/chromium-linux/fast/forms/radio-nested-labels-expected.png: Removed.
* platform/chromium-linux/fast/forms/radio_checked-expected.png: Removed.
* platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.png: Removed.
* platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
* platform/chromium-win/fast/forms/radio-attr-order-expected.png: Removed.
* platform/chromium-win/fast/forms/radio-attr-order-expected.txt: Removed.
* platform/chromium-win/fast/forms/radio-nested-labels-expected.png: Removed.
* platform/chromium-win/fast/forms/radio-nested-labels-expected.txt: Removed.
* platform/chromium-win/fast/forms/radio_checked-expected.png: Removed.
* platform/chromium-win/fast/forms/radio_checked-expected.txt: Removed.
* platform/chromium-win/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/chromium-win/fast/forms/radio_checked_dynamic-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/forms/checkbox-radio-onchange-expected.png: Removed.
* platform/efl/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
* platform/efl/fast/forms/radio-attr-order-expected.png: Removed.
* platform/efl/fast/forms/radio-attr-order-expected.txt: Removed.
* platform/efl/fast/forms/radio-nested-labels-expected.png: Removed.
* platform/efl/fast/forms/radio-nested-labels-expected.txt: Removed.
* platform/efl/fast/forms/radio_checked-expected.png: Removed.
* platform/efl/fast/forms/radio_checked-expected.txt: Removed.
* platform/efl/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/efl/fast/forms/radio_checked_dynamic-expected.txt: Removed.
* platform/gtk/fast/forms/checkbox-radio-onchange-expected.png: Removed.
* platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
* platform/gtk/fast/forms/radio-attr-order-expected.png: Removed.
* platform/gtk/fast/forms/radio-attr-order-expected.txt: Removed.
* platform/gtk/fast/forms/radio-nested-labels-expected.png: Removed.
* platform/gtk/fast/forms/radio-nested-labels-expected.txt: Removed.
* platform/gtk/fast/forms/radio_checked-expected.png: Removed.
* platform/gtk/fast/forms/radio_checked-expected.txt: Removed.
* platform/gtk/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/gtk/fast/forms/radio_checked_dynamic-expected.txt: Removed.
* platform/mac-leopard/fast/forms/checkbox-radio-onchange-expected.png: Removed.
* platform/mac-leopard/fast/forms/radio-attr-order-expected.png: Removed.
* platform/mac-leopard/fast/forms/radio-nested-labels-expected.png: Removed.
* platform/mac-leopard/fast/forms/radio_checked-expected.png: Removed.
* platform/mac-leopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/radio_checked-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/radio_checked-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.txt: Removed.
* platform/mac/fast/forms/checkbox-radio-onchange-expected.png: Removed.
* platform/mac/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
* platform/mac/fast/forms/radio-attr-order-expected.png: Removed.
* platform/mac/fast/forms/radio-attr-order-expected.txt: Removed.
* platform/mac/fast/forms/radio-nested-labels-expected.png: Removed.
* platform/mac/fast/forms/radio-nested-labels-expected.txt: Removed.
* platform/mac/fast/forms/radio_checked-expected.png: Removed.
* platform/mac/fast/forms/radio_checked-expected.txt: Removed.
* platform/mac/fast/forms/radio_checked_dynamic-expected.png: Removed.
* platform/mac/fast/forms/radio_checked_dynamic-expected.txt: Removed.
* platform/qt-mac/Skipped:
* platform/qt/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
* platform/qt/fast/forms/radio-attr-order-expected.txt: Removed.
* platform/qt/fast/forms/radio-nested-labels-expected.txt: Removed.
* platform/qt/fast/forms/radio_checked-expected.txt: Removed.
* platform/qt/fast/forms/radio_checked_dynamic-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 15 Feb 2012 13:18:01 +0000 (13:18 +0000)]
Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar
https://bugs.webkit.org/show_bug.cgi?id=71262
Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Settings.js:
* inspector/front-end/Spectrum.js: Added.
(WebInspector.Spectrum.hueDrag):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.alphaDrag):
(WebInspector.Spectrum):
(WebInspector.Spectrum.hsvaToRGBA):
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.draggable.prevent):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):
(WebInspector.Spectrum.draggable.stop):
(WebInspector.Spectrum.draggable):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get color):
(WebInspector.Spectrum.prototype.get outputColorFormat):
(WebInspector.Spectrum.prototype.get colorHueOnly):
(WebInspector.Spectrum.prototype.set displayText):
(WebInspector.Spectrum.prototype._onchange):
(WebInspector.Spectrum.prototype._updateHelperLocations):
(WebInspector.Spectrum.prototype._updateUI):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.reposition):
(WebInspector.Spectrum.prototype.hide):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.swatch):
(.swatch-inner):
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
* inspector/front-end/inspector.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 13:06:02 +0000 (13:06 +0000)]
Source/WebCore: [Qt] Be smarter with tile usages during tiling
https://bugs.webkit.org/show_bug.cgi?id=78243
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.
The keep rect used to know what existing tiles to keep around, is now a
padding (in tile dimensions) around the usual cover rect. With usual,
I mean to point out that we take our panning optimization into account.
We also do a good effort at keeping the amount of tiles steady, by not
simply intersecting our areas with the contentRect, but moving it
first into legal bounds and then expanding in opposite direction to
cover a similar amount of pixels.
In the future the cover area should be calculated given available
system memory.
* platform/graphics/TiledBackingStore.cpp:
(WebCore):
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
Source/WebKit/qt: [Qt] Be smarted with tile usages during tiling
https://bugs.webkit.org/show_bug.cgi?id=78243
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.
Remove internal API used by Symbian.
* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 15 Feb 2012 12:54:57 +0000 (12:54 +0000)]
2012-02-15 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update SnowLeopard SVG pixel test baseline - chunk 1.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
* platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
* platform/mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
* platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png:
* platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
* platform/mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
* platform/mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
* platform/mac-snowleopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
* platform/mac-snowleopard/svg/as-object/embedded-svg-size-changes-expected.png:
* platform/mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
* platform/mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
* platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
* platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png:
* platform/mac-snowleopard/svg/batik/text/textEffect-expected.png:
* platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png:
* platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
* platform/mac-snowleopard/svg/carto.net/window-expected.png:
* platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png: Added.
* platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
* platform/mac-snowleopard/svg/css/shadow-changes-expected.png:
* platform/mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
* platform/mac-snowleopard/svg/custom/convolution-crash-expected.png: Added.
* platform/mac-snowleopard/svg/custom/createImageElement-expected.png: Added.
* platform/mac-snowleopard/svg/custom/createImageElement2-expected.png:
* platform/mac-snowleopard/svg/custom/empty-merge-expected.png: Added.
* platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
* platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png: Added.
* platform/mac-snowleopard/svg/custom/focus-ring-expected.png:
* platform/mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
* platform/mac-snowleopard/svg/custom/getTransformToElement-expected.png:
* platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/mac-snowleopard/svg/custom/group-opacity-expected.png:
* platform/mac-snowleopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
* platform/mac-snowleopard/svg/custom/hit-test-with-br-expected.png:
* platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png:
* platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png:
* platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
* platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png: Added.
* platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png: Added.
* platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png: Added.
* platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Added.
* platform/mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png:
* platform/mac-snowleopard/svg/custom/mask-invalidation-expected.png:
* platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png:
* platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
* platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png:
* platform/mac-snowleopard/svg/custom/recursive-filter-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-content-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
* platform/mac-snowleopard/svg/custom/relative-sized-inner-svg-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-use-on-symbol-expected.png:
* platform/mac-snowleopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
* platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
* platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/mac-snowleopard/svg/custom/text-filter-expected.png: Added.
* platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png:
* platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-clipped-hit-expected.png:
* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
* platform/mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png:
* platform/mac-snowleopard/svg/custom/use-elementInstance-methods-expected.png:
* platform/mac-snowleopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
* platform/mac-snowleopard/svg/custom/use-event-handler-on-use-element-expected.png:
* platform/mac-snowleopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
* platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png: Added.
* platform/mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
* platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
* platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 15 Feb 2012 12:19:12 +0000 (12:19 +0000)]
Web Inspector: [InspectorIndexedDB] Pass data entries from object stores and indexes to front-end.
https://bugs.webkit.org/show_bug.cgi?id=78503
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/indexeddb/database-data.html
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):
* bindings/js/SerializedScriptValue.h:
(SerializedScriptValue):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore):
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::assertFrame):
(WebCore::assertDocument):
(WebCore::InspectorIndexedDBAgent::requestData):
* inspector/InspectorIndexedDBAgent.h:
(WebCore):
(WebCore::InspectorIndexedDBAgent::create):
(InspectorIndexedDBAgent):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
(WebInspector.IndexedDBModel.keyFromIDBKey):
(WebInspector.IndexedDBModel.keyRangeFromIDBKeyRange):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.Entry):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype._requestData.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype._requestData):
(WebInspector.IndexedDBRequestManager.prototype.requestObjectStoreData):
(WebInspector.IndexedDBRequestManager.prototype._objectStoreDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestIndexData):
(WebInspector.IndexedDBRequestManager.prototype._indexDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DataRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):
(WebInspector.IndexedDBDispatcher.prototype.objectStoreDataLoaded):
(WebInspector.IndexedDBDispatcher.prototype.indexDataLoaded):
LayoutTests:
* http/tests/inspector/indexeddb/database-data-expected.txt: Added.
* http/tests/inspector/indexeddb/database-data.html: Added.
* http/tests/inspector/indexeddb/database-names-expected.txt:
* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest.addIDBValue):
(initialize_IndexedDBTest):
(doWithReadWriteTransaction.step2.innerCommitCallback):
(doWithReadWriteTransaction.step2):
(doWithReadWriteTransaction):
(addIDBValue.doWithReadWriteTransaction.withTransactionCallback):
(addIDBValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Feb 2012 11:47:24 +0000 (11:47 +0000)]
[Qt] Fix WebGL in QtTestBrowser
Reviewed by Tor Arne Vestbø.
* QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
the options for enabling GL we also pass them on properly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 11:37:25 +0000 (11:37 +0000)]
REGRESSION(r107518): DeviceOrientationController doesn't remove registered DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=78683
Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-15
Reviewed by Kentaro Hara.
A copy-n-paste disaster. This change fixed it by calling correct methods.
No new tests. Needs browser side mocking for testing this.
A Chromium automated test covers this.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
* page/Page.cpp:
(WebCore::Page::provideSupplement):
(WebCore::Page::requireSupplement):
* page/Page.h: Fix typo.
(Page):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 15 Feb 2012 11:28:40 +0000 (11:28 +0000)]
2012-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, change the encoding of a test HTML.
* fast/forms/radio-nested-labels.html: Convert from UTF-16 to UTF-8.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 15 Feb 2012 10:48:58 +0000 (10:48 +0000)]
Switch svg/dynamic-updates tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78219
Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.
This is the last step, all svg tests have been converted.
The only relevant change to look at is svg/dynamic-updates/resources/SVGTestCase.js, the rest is mechanic, done by a script.
Ran following magic in svg/dynamic-updates: (inject repaint.js in all *.html files in that folder, and register onload handler)
find . -type f -name "*.html" | xargs perl -pi -e "s/js-test-pre\.js\"><\/script\>/js-test-pre\.js\"><\/script\>\n\<script src=\"..\/..\/fast\/repaint\/resources\/repaint\.js\"\>\<\/script\>/"
find . -type f -name "*.html" | xargs perl -pi -e "s/<body>/<body onload=\"runRepaintTest()\">/"
And in svg/dynamic-updates/script-tests: (remove manual startTest function calls, and rename executeTest to repaintTest).
find . -type f -name "*.js" | xargs perl -pi -e "s/startTest\(.*\);\n//"
find . -type f -name "*.js" | xargs perl -pi -e "s/function\ executeTest/function\ repaintTest/"
Only a few tests needed other adjustments.
* platform/chromium/test_expectations.txt:
* svg/animations/resources/SVGAnimationTestCase.js:
(runSMILTest):
...
* platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
...
* svg/dynamic-updates/SVG-dynamic-css-transform.html:
* svg/dynamic-updates/SVGAElement-dom-href-attr.html:
...
* svg/dynamic-updates/resources/SVGTestCase.js: Changed to utilize the repaint.js harness.
(createSVGTestCase):
(clickAt):
* svg/dynamic-updates/resources/linkTarget.svg:
* svg/dynamic-updates/script-tests/SVGAElement-dom-href-attr.js:
(repaintTest):
* svg/dynamic-updates/script-tests/SVGAElement-dom-target-attr.js:
(repaintTest):
...
* svg/dynamic-updates/script-tests/TEMPLATE.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 15 Feb 2012 10:30:29 +0000 (10:30 +0000)]
2012-02-15 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed, quick build fix for 107792
* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveAttributeAction::redo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 15 Feb 2012 09:52:17 +0000 (09:52 +0000)]
2012-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, correct svn:mime-type of a test.
* fast/forms/radio-nested-labels.html:
Modified property svn:mime-type from application/octet-stream to text/html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Wed, 15 Feb 2012 09:24:36 +0000 (09:24 +0000)]
[chromium] Don't use increased FontCache size on Android
https://bugs.webkit.org/show_bug.cgi?id=78656
Reviewed by Adam Barth.
The chromium port uses a larger font cache size because it increases
performance on the intl1 and intl2 page cyclers. However, on Android
devices where resources are more constrained, it isn't desireable to
allow the FontCache to grow so big.
No new tests because no testable difference in functionality.
* platform/graphics/FontCache.cpp:
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 15 Feb 2012 09:17:20 +0000 (09:17 +0000)]
<style scoped>: Allow <style scoped> as a direct child of a ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=77853
.:
numberOfScopedHTMLStyleChildren got moved from Element into Node.
Reviewed by Dimitri Glazkov.
* Source/autotools/symbols.filter:
Source/WebCore:
Moved registration code from Element to Node. updated Internals and build files accordingly.
Moved registration data members from ElementRareData to NodeRareData.
Forward willRemove() from host element into shadow DOM tree.
Reviewed by Dimitri Glazkov.
Test: fast/css/style-scoped/registering-shadowroot.html
* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::willRemove):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::hasScopedHTMLStyleChild):
(WebCore::Node::numberOfScopedHTMLStyleChildren):
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
(WebCore::NodeRareData::registerScopedHTMLStyleChild):
(WebCore::NodeRareData::unregisterScopedHTMLStyleChild):
(WebCore::NodeRareData::hasScopedHTMLStyleChild):
(WebCore::NodeRareData::numberOfScopedHTMLStyleChildren):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::willRemove):
(WebCore):
* dom/ShadowRootList.h:
(ShadowRootList):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
* testing/Internals.cpp:
(WebCore::Internals::numberOfScopedHTMLStyleChildren):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit2:
numberOfScopedHTMLStyleChildren got moved from Element into Node.
Reviewed by Dimitri Glazkov.
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
Test registration of <style scoped> as a direct child of a ShadowRoot.
Reviewed by Dimitri Glazkov.
* fast/css/style-scoped/registering-shadowroot-expected.txt: Added.
* fast/css/style-scoped/registering-shadowroot.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 15 Feb 2012 09:12:15 +0000 (09:12 +0000)]
Web Inspector: implement redo for DOM actions.
https://bugs.webkit.org/show_bug.cgi?id=78601
Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-14
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::redo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::redo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::redo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::redo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::redo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::redo):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::redo):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::redo):
(DOMEditor::SetNodeValueAction):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::redo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::redo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::redo):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::redo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::redo):
(InspectorCSSAgent::AddRuleAction):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::redo):
(WebCore):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore):
* inspector/InspectorHistory.h:
(Action):
(InspectorHistory):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._undoRedoRequested):
(WebInspector.CSSStyleModel.prototype._undoRedoCompleted):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.get undo):
(WebInspector.DOMAgent.prototype.redo):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.generateUndoTest):
* inspector/elements/undo-dom-edits-2-expected.txt:
* inspector/elements/undo-dom-edits-expected.txt:
* inspector/styles/undo-add-new-rule-expected.txt:
* inspector/styles/undo-add-new-rule.html:
* inspector/styles/undo-add-property-expected.txt:
* inspector/styles/undo-add-property.html:
* inspector/styles/undo-change-property-expected.txt:
* inspector/styles/undo-change-property.html:
* inspector/styles/undo-property-toggle-expected.txt:
* inspector/styles/undo-property-toggle.html:
* inspector/styles/undo-set-selector-text-expected.txt:
* inspector/styles/undo-set-selector-text.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 15 Feb 2012 08:59:37 +0000 (08:59 +0000)]
2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Rubber-stamped by Simon Hausmann.
Further cleanup of the svg/animation tests. Always use "0.001" as sampling time
for "just-after-anim-begin" instead of 0.1/0.01 variations. Use "3.999" as
"just-before-anim-end" time instead of 3.9/3.99 variations.
Use a default tolerance of 0.1, instead of the strict 0.01, to avoid having
to expect values like "199.98". Use "200" instead. That doesn't reduce the
value of any of the tests, but its likely to be more stable.
Changed some real-quick running animamtions to have a higher duration.
This minimizes the sampling time error when sampling the animation right after
it started (svg/animation/*nested-transforms*). This doesn't affect the runtime
of the tests at all, as we manually drive the timeline anyways.
Always use shouldBe() instead of shouldBeCloseEnough() if the sampling time
is an integer, like 2.0 for animations that eg. animate x from 0 to 200.
Sampling exactly at 2.0, yields 100, so there's no need to check for equal
with tolerance.
* platform/chromium/test_expectations.txt:
* svg/animations/animate-calcMode-spline-by-expected.txt:
* svg/animations/animate-calcMode-spline-from-by-expected.txt:
* svg/animations/animate-calcMode-spline-from-to-expected.txt:
* svg/animations/animate-calcMode-spline-to-expected.txt:
* svg/animations/animate-calcMode-spline-values-expected.txt:
* svg/animations/animate-path-animation-Cc-Ss-expected.txt:
* svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
* svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
* svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
* svg/animations/animate-path-nested-transforms-expected.txt:
* svg/animations/animate-path-to-animation-expected.txt:
* svg/animations/animate-text-nested-transforms-expected.txt:
* svg/animations/resources/SVGAnimationTestCase.js:
(shouldBeCloseEnough):
* svg/animations/script-tests/animVal-basics.js:
(sample3):
* svg/animations/script-tests/animate-calcMode-spline-by.js:
(sample2):
(sample3):
* svg/animations/script-tests/animate-calcMode-spline-from-by.js:
(sample2):
(sample3):
* svg/animations/script-tests/animate-calcMode-spline-from-to.js:
(sample2):
(sample3):
* svg/animations/script-tests/animate-calcMode-spline-to.js:
(sample2):
(sample3):
* svg/animations/script-tests/animate-calcMode-spline-values.js:
(sample2):
(sample3):
* svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:
(executeTest):
* svg/animations/script-tests/animate-dynamic-update-attributeName.js:
(executeTest):
* svg/animations/script-tests/animate-end-attribute.js:
(sample3):
* svg/animations/script-tests/animate-mpath-insert.js:
(endSample):
(executeTest):
* svg/animations/script-tests/animate-path-animation-Cc-Ss.js:
(sample2):
(sample3):
(sample4):
* svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:
(sample2):
(sample3):
(sample4):
* svg/animations/script-tests/animate-path-animation-Qq-Tt.js:
(sample2):
(sample3):
(sample4):
* svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:
(sample2):
(sample3):
(sample4):
* svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:
(sample2):
(sample3):
(sample4):
* svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:
(sample2):
(sample3):
(sample4):
* svg/animations/script-tests/animate-path-nested-transforms.js:
(endSample):
(executeTest):
* svg/animations/script-tests/animate-path-to-animation.js:
(sample2):
(sample3):
* svg/animations/script-tests/animate-text-nested-transforms.js:
(endSample):
(executeTest):
* svg/animations/script-tests/animateTransform-pattern-transform.js:
(sample3):
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample2):
(sample3):
* svg/animations/script-tests/svginteger-animation-1.js:
(sample3):
* svg/animations/script-tests/svglength-animation-LengthModeHeight.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-LengthModeOther.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-LengthModeWidth.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-number-to-number.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-cm.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-ems.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-exs.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-in.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-number.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-pc.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-percentage.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-pt.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-px-to-px.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglength-animation-values.js:
(sample2):
(sample3):
(sample4):
(sample5):
* svg/animations/script-tests/svglengthlist-animation-1.js:
(sample3):
* svg/animations/script-tests/svglengthlist-animation-2.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-3.js:
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-4.js:
(sample3):
* svg/animations/script-tests/svglengthlist-animation-5.js:
(sample3):
* svg/animations/script-tests/svgnumber-animation-1.js:
(sample3):
* svg/animations/script-tests/svgnumber-animation-2.js:
(sample3):
* svg/animations/script-tests/svgnumberlist-animation-1.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberlist-animation-2.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgpath-animation-1.js:
(sample2):
(sample3):
* svg/animations/script-tests/svgpointlist-animation-1.js:
(sample3):
* svg/animations/script-tests/svgpointlist-animation-2.js:
(sample3):
* svg/animations/script-tests/svgrect-animation-1.js:
(sample3):
* svg/animations/script-tests/svgrect-animation-2.js:
(sample3):
* svg/animations/script-tests/svgtransform-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgtransform-animation-discrete.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svgangle-animation-deg-to-grad-expected.txt:
* svg/animations/svgangle-animation-deg-to-rad-expected.txt:
* svg/animations/svgangle-animation-grad-to-deg-expected.txt:
* svg/animations/svgangle-animation-grad-to-rad-expected.txt:
* svg/animations/svgangle-animation-rad-to-deg-expected.txt:
* svg/animations/svgangle-animation-rad-to-grad-expected.txt:
* svg/animations/svglength-animation-LengthModeHeight-expected.txt:
* svg/animations/svglength-animation-LengthModeOther-expected.txt:
* svg/animations/svglength-animation-LengthModeWidth-expected.txt:
* svg/animations/svglength-animation-number-to-number-expected.txt:
* svg/animations/svglength-animation-px-to-cm-expected.txt:
* svg/animations/svglength-animation-px-to-ems-expected.txt:
* svg/animations/svglength-animation-px-to-exs-expected.txt:
* svg/animations/svglength-animation-px-to-in-expected.txt:
* svg/animations/svglength-animation-px-to-number-expected.txt:
* svg/animations/svglength-animation-px-to-pc-expected.txt:
* svg/animations/svglength-animation-px-to-percentage-expected.txt:
* svg/animations/svglength-animation-px-to-pt-expected.txt:
* svg/animations/svglength-animation-px-to-px-expected.txt:
* svg/animations/svglength-animation-values-expected.txt:
* svg/animations/svglengthlist-animation-2-expected.txt:
* svg/animations/svgnumberlist-animation-1-expected.txt:
* svg/animations/svgnumberlist-animation-2-expected.txt:
* svg/animations/svgpath-animation-1-expected.txt:
* svg/animations/svgpointlist-animation-1-expected.txt:
* svg/animations/svgpointlist-animation-2-expected.txt:
* svg/animations/svgrect-animation-1-expected.txt:
* svg/animations/svgrect-animation-2-expected.txt:
* svg/animations/svgtransform-animation-1-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 15 Feb 2012 08:53:02 +0000 (08:53 +0000)]
Unreviewed, GTK rebaseline after r107785 and r107762. Also
skipping a new SVG failure.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-zoom-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 15 Feb 2012 08:45:57 +0000 (08:45 +0000)]
[Qt] Unreviewed morning gardening.
* platform/qt/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added after r107749.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r107785.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Wed, 15 Feb 2012 08:43:48 +0000 (08:43 +0000)]
WebSocket: MessageEvent fired during send() on workers
https://bugs.webkit.org/show_bug.cgi?id=76521
Reviewed by David Levin.
Source/WebCore:
WebSocket's message event should not be invoked while a synchronous operation
(send() and bufferedAmount) is in progress.
Test: http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Added #if ENABLE(WORKERS) because ThreadableWebSocketChannelClientWrapper is not used
if Web Workers is not available.
Changed access label because private members were declared as protected with no good reason.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
Receive ScriptExecutionContext so we can post a task that should be executed later.
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
LayoutTests:
* http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op.js:
Added. The server sends messages immediately after the connection is established, but
these messages should not be delivered until the script exits the current cycle of
the event loop. The script calls a few synchronous operations to make sure we don't
fire MessageEvents while we are waiting for these operations to finish.
* http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op_wsh.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Wed, 15 Feb 2012 08:26:30 +0000 (08:26 +0000)]
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660
Source/WebCore:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
No new tests.
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setParent):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::removeFromParent):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::syncCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::layer):
* platform/graphics/texmap/TextureMapperLayer.cpp: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp.
(WebCore):
(WebCore::toTextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::clearBackingStoresRecursive):
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paint):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::compareGraphicsLayersZValue):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::syncCompositingState):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::syncAnimationsRecursively):
* platform/graphics/texmap/TextureMapperLayer.h: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.h.
(WebCore):
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setTextureMapper):
(WebCore::TextureMapperLayer::setShouldUpdateBackingStoreFromLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(WebCore::TextureMapperLayer::backingStore):
(WebCore::TextureMapperLayer::texture):
(WebCore::TextureMapperLayer::layerRect):
(State):
(WebCore::TextureMapperLayer::State::State):
Source/WebKit/gtk:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
Source/WebKit/qt:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
* Api/qwebframe.h:
(WebCore):
* Api/qwebframe_p.h:
(WebCore):
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::TextureMapperLayerClientQt::TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
(WebCore::TextureMapperLayerClientQt::~TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
(WebCore::TextureMapperLayerClientQt::rootLayer):
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
* WebCoreSupport/PageClientQt.h:
(TextureMapperLayerClientQt):
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Wed, 15 Feb 2012 08:21:29 +0000 (08:21 +0000)]
ShadowRoot: Remove a public static factory function which doesn't have any callers.
https://bugs.webkit.org/show_bug.cgi?id=78668
Reviewed by Kent Tamura.
No tests. No change in behavior.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRoot.h:
(ShadowRoot):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 08:04:44 +0000 (08:04 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #11 of N.
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Removed.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png.
* platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Removed.
* platform/chromium-mac/svg/custom/image-rescale-expected.png: Removed.
* platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-win/svg/custom/image-rescale-expected.png:
* platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/image-rescale-expected.txt: Removed.
* platform/qt/svg/custom/image-rescale-expected.txt: Removed.
* svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/image-rescale-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 07:03:43 +0000 (07:03 +0000)]
Cleanup pending transaction queue in Database.
https://bugs.webkit.org/show_bug.cgi?id=75048
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-14
Reviewed by David Levin.
Source/WebCore:
Each SQLTransaction has 3 SQLCallbackWrappers, and each of them
holds a ref to WorkerContext. As a result, if the worker thread is
stopped before all SQLTransactions are finished, the ASSERT of
m_workerContext->hasOneRef() in WorkerThread::workerThread() would fail.
No new tests.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts
* storage/Database.cpp:
(WebCore::Database::close): Cleanup pending transaction queue in close().
* storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(SafeReleaseTask): Make SafeReleaseTask a cleanup task, which is
necessary because at the time of SafeReleaseTask is performed,
WorkerRunLoop has been terminated and only runs cleanup tasks.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
LayoutTests:
As crash is fixed, trun BUGWK75048 into BUGWK75111, so that we can
close 75048 and fix the timeout in 75111 for both DEBUG and RELEASE.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 15 Feb 2012 06:58:59 +0000 (06:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=78662
CSSStyleSelector should not rely on parent rule pointer in StylePropertySet
Reviewed by Andreas Kling.
Pass the rule pointer down to the style applying so we don't need to rely on
StylePropertySet having one.
To make this easier the patch also refactors the matched properties vector to
be part of MatchResult object instead of a member of CSSStyleSelector.
Rename Declaration -> Properties.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::matchUserRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyProperties):
(WebCore::CSSStyleSelector::applyMatchedProperties):
(WebCore::CSSStyleSelector::computeMatchedPropertiesHash):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addToMatchedPropertiesCache):
(WebCore::CSSStyleSelector::invalidateMatchedPropertiesCache):
(WebCore::isCacheableInMatchedPropertiesCache):
(WebCore::CSSStyleSelector::matchPageRules):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::MatchedProperties::MatchedProperties):
(MatchedProperties):
(MatchResult):
(MatchedPropertiesCacheItem):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Wed, 15 Feb 2012 06:56:24 +0000 (06:56 +0000)]
Provide SocketStreamHandleInternal::toWebSocketStreamHandle(SocketStreamHandle*).
https://bugs.webkit.org/show_bug.cgi?id=78581
Reviewed by Kent Tamura.
Now, there is no way to convert SocketStreamHandle to
WebSocketStreamHandle. In subsequent changes, I'll use this function
in FrameLoaderClientImpl.
* src/SocketStreamHandle.cpp: Remove SocketStreamHandleInternal class declaration.
* src/SocketStreamHandleInternal.h: Move SocketStreamHandleInternal class declaration from SocketStreamHandle.cpp to expose, and add conversion function to WebSocketStreamHandle from SocketStreamHandle.
(WebKit):
(WebCore):
(SocketStreamHandleInternal):
(WebCore::SocketStreamHandleInternal::create):
(WebCore::SocketStreamHandleInternal::toWebSocketStreamHandle):
* WebKit.gyp: Add SocketStreamHandleInternal.h entry.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 15 Feb 2012 06:56:00 +0000 (06:56 +0000)]
Stop using script-tests in LayoutTests/fast/forms
https://bugs.webkit.org/show_bug.cgi?id=78667
Reviewed by Kentaro Hara.
* fast/forms/ValidityState-patternMismatch-unsupported.html:
* fast/forms/ValidityState-rangeOverflow.html:
* fast/forms/ValidityState-rangeUnderflow.html:
* fast/forms/ValidityState-stepMismatch.html:
* fast/forms/ValidityState-tooLong-input.html:
* fast/forms/ValidityState-tooLong-textarea.html:
* fast/forms/ValidityState-typeMismatch-date-expected.txt: Removed.
* fast/forms/ValidityState-typeMismatch-url.html:
* fast/forms/ValidityState-valueMissing-radio.html:
* fast/forms/checkValidity-cancel.html:
* fast/forms/checkValidity-handler-updates-dom.html:
* fast/forms/form-attribute-elements-order.html:
* fast/forms/form-attribute-elements-order2.html:
* fast/forms/form-attribute-elements.html:
* fast/forms/form-attribute.html:
* fast/forms/form-collection-elements-order.html:
* fast/forms/form-collection-elements.html:
* fast/forms/formnovalidate-attribute.html:
* fast/forms/incremental-dom-property.html:
* fast/forms/input-maxlength-ime-completed.html:
* fast/forms/input-maxlength-ime-preedit.html:
* fast/forms/input-maxlength-unsupported.html:
* fast/forms/input-minmax.html:
* fast/forms/input-pattern.html:
* fast/forms/input-step.html:
* fast/forms/input-stepup-stepdown.html:
* fast/forms/input-type-change3.html:
* fast/forms/input-valueasnumber-unsupported.html:
* fast/forms/labels-add-htmlFor-label.html:
* fast/forms/labels-add-parent-label.html:
* fast/forms/labels-change-htmlFor-attribute.html:
* fast/forms/labels-item-index.html:
* fast/forms/labels-remove-htmlFor-attribute.html:
* fast/forms/labels-remove-htmlFor-label.html:
* fast/forms/labels-remove-parent-label.html:
* fast/forms/labels-set-htmlFor-attribute.html:
* fast/forms/listbox-deselect-scroll.html:
* fast/forms/listbox-selection-2.html:
* fast/forms/listbox-selection.html:
* fast/forms/menulist-disabled-selected-option.html:
* fast/forms/menulist-submit-without-selection.html:
* fast/forms/novalidate-attribute.html:
* fast/forms/output-reset-assertion-failed.html:
* fast/forms/placeholder-dom-property.html:
* fast/forms/script-tests/TEMPLATE.html: Removed.
* fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed.
* fast/forms/script-tests/ValidityState-stepMismatch.js: Removed.
* fast/forms/script-tests/ValidityState-tooLong-input.js: Removed.
* fast/forms/script-tests/ValidityState-tooLong-textarea.js: Removed.
* fast/forms/script-tests/ValidityState-typeMismatch-date.js: Removed.
* fast/forms/script-tests/ValidityState-typeMismatch-url.js: Removed.
* fast/forms/script-tests/ValidityState-valueMissing-radio.js: Removed.
* fast/forms/script-tests/checkValidity-cancel.js: Removed.
* fast/forms/script-tests/checkValidity-handler-updates-dom.js: Removed.
* fast/forms/script-tests/form-attribute-elements-order.js: Removed.
* fast/forms/script-tests/form-attribute-elements-order2.js: Removed.
* fast/forms/script-tests/form-attribute-elements.js: Removed.
* fast/forms/script-tests/form-attribute.js: Removed.
* fast/forms/script-tests/form-collection-elements-order.js: Removed.
* fast/forms/script-tests/form-collection-elements.js: Removed.
* fast/forms/script-tests/formnovalidate-attribute.js: Removed.
* fast/forms/script-tests/incremental-dom-property.js: Removed.
* fast/forms/script-tests/input-maxlength-ime-completed.js: Removed.
* fast/forms/script-tests/input-maxlength-ime-preedit.js: Removed.
* fast/forms/script-tests/input-maxlength-unsupported.js: Removed.
* fast/forms/script-tests/input-minmax.js: Removed.
* fast/forms/script-tests/input-pattern.js: Removed.
* fast/forms/script-tests/input-step.js: Removed.
* fast/forms/script-tests/input-stepup-stepdown.js: Removed.
* fast/forms/script-tests/input-type-change3.js: Removed.
* fast/forms/script-tests/input-valueasnumber-unsupported.js: Removed.
* fast/forms/script-tests/labels-add-htmlFor-label.js: Removed.
* fast/forms/script-tests/labels-add-parent-label.js: Removed.
* fast/forms/script-tests/labels-change-htmlFor-attribute.js: Removed.
* fast/forms/script-tests/labels-item-index.js: Removed.
* fast/forms/script-tests/labels-remove-htmlFor-attribute.js: Removed.
* fast/forms/script-tests/labels-remove-htmlFor-label.js: Removed.
* fast/forms/script-tests/labels-remove-parent-label.js: Removed.
* fast/forms/script-tests/labels-set-htmlFor-attribute.js: Removed.
* fast/forms/script-tests/listbox-deselect-scroll.js: Removed.
* fast/forms/script-tests/listbox-selection-2.js: Removed.
* fast/forms/script-tests/listbox-selection.js: Removed.
* fast/forms/script-tests/menulist-disabled-selected-option.js: Removed.
* fast/forms/script-tests/menulist-submit-without-selection.js: Removed.
* fast/forms/script-tests/novalidate-attribute.js: Removed.
* fast/forms/script-tests/output-reset-assertion-failed.js: Removed.
* fast/forms/script-tests/placeholder-dom-property.js: Removed.
* fast/forms/script-tests/search-cancel-button-events.js: Removed.
* fast/forms/script-tests/select-set-length-optgroup.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation-remove.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation.js: Removed.
* fast/forms/script-tests/select-set-length.js: Removed.
* fast/forms/script-tests/setCustomValidity-existence.js: Removed.
* fast/forms/script-tests/shadow-tree-exposure.js: Removed.
* fast/forms/script-tests/submit-form-attributes.js: Removed.
* fast/forms/script-tests/text-control-intrinsic-widths.js: Removed.
* fast/forms/script-tests/textarea-maxlength.js: Removed.
* fast/forms/script-tests/textarea-metrics.js: Removed.
* fast/forms/script-tests/textarea-placeholder-dom-property.js: Removed.
* fast/forms/script-tests/textarea-rows-cols.js: Removed.
* fast/forms/script-tests/textarea-textlength.js: Removed.
* fast/forms/script-tests/validationMessage.js: Removed.
* fast/forms/script-tests/willvalidate.js: Removed.
* fast/forms/search-cancel-button-events.html:
* fast/forms/select-set-length-optgroup.html:
* fast/forms/select-set-length-with-mutation-remove.html:
* fast/forms/select-set-length-with-mutation-reorder.html:
* fast/forms/select-set-length-with-mutation-reparent.html:
* fast/forms/select-set-length-with-mutation.html:
* fast/forms/select-set-length.html:
* fast/forms/setCustomValidity-existence.html:
* fast/forms/shadow-tree-exposure.html:
* fast/forms/submit-form-attributes.html:
* fast/forms/text-control-intrinsic-widths.html:
* fast/forms/textarea-maxlength.html:
* fast/forms/textarea-metrics.html:
* fast/forms/textarea-placeholder-dom-property.html:
* fast/forms/textarea-rows-cols.html:
* fast/forms/textarea-textlength.html:
* fast/forms/validationMessage.html:
* fast/forms/willvalidate.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Wed, 15 Feb 2012 06:39:35 +0000 (06:39 +0000)]
WebSocketChannel minor refactoring for code manageability
https://bugs.webkit.org/show_bug.cgi?id=78576
Reviewed by Kent Tamura.
Change the first argument type of WebSocketChannel
from ScriptExecutionContext to Document.
WebSocketChannel always assume this ScriptExecutionContext must
inherit Document. Then, it results in many static cast.
It isn't readable and dangerous against future code changes.
* websockets/ThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.
(WebCore::ThreadableWebSocketChannel::create):
* websockets/WebSocketChannel.cpp: Replace all ScriptExecutionContext* m_context descriptions to Document* m_document.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
* websockets/WebSocketChannel.h: Change the first argument for construction to Document and hold it as Document m_document.
(WebCore):
(WebCore::WebSocketChannel::create):
(WebSocketChannel):
* websockets/WorkerThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 06:00:36 +0000 (06:00 +0000)]
Unreviewed, rolling out r107774.
http://trac.webkit.org/changeset/107774
https://bugs.webkit.org/show_bug.cgi?id=78661
Broke Chromium build
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/ScrollAnimator.cpp:
(WebCore):
(WebCore::ScrollAnimator::handleGestureEvent):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
(WebCore):
(WebCore::ScrollableArea::handleGestureEvent):
* platform/ScrollableArea.h:
(ScrollableArea):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 15 Feb 2012 05:19:16 +0000 (05:19 +0000)]
Unreviewed, rolling out r107766.
http://trac.webkit.org/changeset/107766
https://bugs.webkit.org/show_bug.cgi?id=78665
Breaks Chromium Win build (Requested by bashi1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14
Source/WebCore:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* websockets/WebSocketDeflater.cpp: Removed.
* websockets/WebSocketDeflater.h: Removed.
Source/WebKit/chromium:
* WebKit.gypi:
* tests/WebSocketDeflaterTest.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 05:10:16 +0000 (05:10 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #10 of N.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 15 Feb 2012 04:13:40 +0000 (04:13 +0000)]
Add #include of unistd.h on the mac for getcwd.
Reviewed by Anders Carlsson.
This is necessary when building with libc++.
* WebKitTestRunner/TestInvocation.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 15 Feb 2012 04:10:26 +0000 (04:10 +0000)]
In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
https://bugs.webkit.org/show_bug.cgi?id=78663
Reviewed by Anders Carlsson.
* DumpRenderTree/DumpRenderTreePrefix.h:
* DumpRenderTree/cg/ImageDiffCG.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 03:56:22 +0000 (03:56 +0000)]
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661
Reviewed by Sam Weinig.
ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/ScrollAnimator.cpp:
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
* platform/ScrollableArea.h:
(ScrollableArea):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 15 Feb 2012 03:22:14 +0000 (03:22 +0000)]
[JSC] Cache the number of non-custom constructor arguments
https://bugs.webkit.org/show_bug.cgi?id=78195
Reviewed by Darin Adler.
Source/WebCore:
If [ConstructorParameters=] is specified, JSC caches the number of constructor
arguments for performance. However, at present, [ConstructorParameters=] is specified
on a small part of constructors (It appears that people have forgotten to
add [ConstructorParameters=]). Thus, for non-custom constructors, this patch modifies
CodeGeneratorJS.pm so that it caches the number of constructor arguments automatically
without [ConstructorParameters=] (CodeGeneratorJS.pm can know the number of arguments
by the [Constructor=...] signature).
Test: fast/js/constructor-length.html
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
LayoutTests:
The added tests check the length property of constructors.
The test fails for "flag-disabled" constructors.
* fast/js/constructor-length.html: Added.
* platform/mac/fast/js/constructor-length-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 15 Feb 2012 03:04:48 +0000 (03:04 +0000)]
<webkit.org/b/78658> platformUserPreferredLanguages is leaking all of the language codes
Reviewed by Darin Adler.
* platform/mac/Language.mm:
(WebCore::httpStyleLanguageCode): Switch to using RetainPtr's for temporaries to make the ownership
more explicit. Switch to returning a WTF::String so that the caller doesn't have to worry about
ownership at all. Change the name to reflect the lack of transfer of ownership.
(WebCore::platformUserPreferredLanguages):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 15 Feb 2012 02:20:19 +0000 (02:20 +0000)]
[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655
Reviewed by Hajime Morita.
Although the bots have been working fine, PasteboardMac.mm build fails
in our local Mac environments due to an uninitialized variable:
/Users/haraken/WebKit/Source/WebCore/platform/mac/PasteboardMac.mm:322: warning: 'string' may be used uninitialized in this function
This patch initializes the 'string' to nil to fix the build failure.
No tests. No change in behavior.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 15 Feb 2012 02:11:46 +0000 (02:11 +0000)]
[WebSocket] Add extension attribute support
https://bugs.webkit.org/show_bug.cgi?id=78557
Source/WebCore:
Implement WebSocket "extensions" attribute that holds a list of
extension the server accepted. No change in behavior at this time
because we don't send any extension on handshake.
Reviewed by Kent Tamura.
No new tests. http/tests/websocket/tests/hybi/extensions.html checks the value of this attribute.
* websockets/ThreadableWebSocketChannel.h: Add extensions().
(ThreadableWebSocketChannel):
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions): Added.
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Added.
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(ThreadableWebSocketChannelClientWrapper):
* websockets/WebSocket.cpp: Added m_extensions member variable.
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::extensions): Returns m_extensions.
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::extensions): Added.
(WebCore):
* websockets/WebSocketChannel.h:
(WebSocketChannel):
* websockets/WebSocketExtensionDispatcher.cpp:
(WebCore::WebSocketExtensionDispatcher::fail): Added.
(WebCore::WebSocketExtensionDispatcher::processHeaderValue): Stores accepted extensions.
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
(WebCore):
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
* websockets/WebSocketExtensionDispatcher.h:
(WebSocketExtensionDispatcher):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::acceptedExtensions): Added.
(WebCore):
* websockets/WebSocketHandshake.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::extensions): Added.
(WebCore):
(WebCore::workerContextDidConnect): Calls ThreadableWebSocketChannelClientWrapper::setExtensions().
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect): Passes extensions as an argument.
* websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Source/WebKit/chromium:
Add WebSocketExtensionDispatcher::acceptedExtensions() checks.
Reviewed by Kent Tamura.
* tests/WebSocketExtensionDispatcherTest.cpp:
(WebCore::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 15 Feb 2012 02:05:13 +0000 (02:05 +0000)]
Rename [JSGenerateToJS] to [JSGenerateToJSObject]
https://bugs.webkit.org/show_bug.cgi?id=78490
Reviewed by Adam Barth.
This patch renames [JSGenerateToJS] to [JSGenerateToJSObject],
for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* dom/WebKitNamedFlow.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* html/DOMFormData.idl:
* html/DOMSettableTokenList.idl:
* html/DOMURL.idl:
* html/MediaController.idl:
* mediastream/LocalMediaStream.idl:
* webaudio/AudioBufferCallback.idl:
* webaudio/AudioBufferSourceNode.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioPannerNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/MediaElementAudioSourceNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* webaudio/RealtimeAnalyserNode.idl:
* webaudio/WaveShaperNode.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 02:04:53 +0000 (02:04 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #9 of N.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 15 Feb 2012 02:02:53 +0000 (02:02 +0000)]
Source/WebCore: [WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449
Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.
Reviewed by Kent Tamura.
No new tests except for chromium port. Behavior is unchanged.
* GNUmakefile.list.am: Added.WebSocketDeflater.(cpp|h).
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* websockets/WebSocketDeflater.cpp: Added.
(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):
* websockets/WebSocketDeflater.h: Added.
(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):
Source/WebKit/chromium: [WebSocket] Add deflater/inflater classes.
https://bugs.webkit.org/show_bug.cgi?id=78449
Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.
Reviewed by Kent Tamura.
* WebKit.gypi:
* tests/WebSocketDeflaterTest.cpp: Added.
(WebCore):
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 01:47:57 +0000 (01:47 +0000)]
[BlackBerry] Upstreaming WebSettings code
https://bugs.webkit.org/show_bug.cgi?id=78633
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
* blackberry/Api/WebSettings.cpp: Added.
* blackberry/Api/WebSettings.h: Added.
* blackberry/Api/WebSettings_p.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 01:34:36 +0000 (01:34 +0000)]
[chromium] Compare filters on impl thread when setting them, and test setting in unit tests
https://bugs.webkit.org/show_bug.cgi?id=78643
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Source/WebCore:
Add setFilters() coverage to CCLayerImplTest.cpp
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setFilters):
Source/WebKit/chromium:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Wed, 15 Feb 2012 01:34:14 +0000 (01:34 +0000)]
Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634
Unreviewed layouttest rebaselining.
* platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-expected.png:
* platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-win/media/video-zoom-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-zoom-expected.png:
* platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/video-zoom-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-zoom-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 15 Feb 2012 01:23:49 +0000 (01:23 +0000)]
Crash in deleteInsignificantText
https://bugs.webkit.org/show_bug.cgi?id=78567
Reviewed by Eric Seidel.
Source/WebCore:
Fix the crash. Also update layout at the beginning of each call to deleteInsignificantText
since the previous call may have mutated the DOM.
Test: editing/inserting/delete-insignificant-text-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
LayoutTests:
Add a regression test.
* editing/inserting/delete-insignificant-text-crash.html: Added.
* editing/inserting/delete-insignificant-text-crash.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 15 Feb 2012 01:20:32 +0000 (01:20 +0000)]
Prepare RenderLayerBacking and RenderLayerCompositor for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78630
Reviewed by Simon Fraser.
In our transition to subpixel layout in the render tree, we continue to pass RenderLayerBacking
and RenderLayerCompositor integer (pixel) sizes and positions. This patch moves nearly all
methods and members on these two classes back to integers, and applies pixel snapping logic to
LayoutUnits pulled in.
No new tests. No change in behavior.
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedLayoutOverflowRect): Convenience function for getting pixel
snapped overflow bounds.
* rendering/RenderLayerBacking.cpp:
(WebCore):
(WebCore::RenderLayerBacking::updateCompositedBounds): Switch to integers and pixel snapping the
clipping bounds.
(WebCore::clipBox): Returns a pixel snapped rect.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Using pixelSnappedLayerCoords. Removing
pixelSnappedIntRect calls to clipBox since this is now an IntRect.
(WebCore::RenderLayerBacking::computeTransformOrigin): Switching to operate on a pixel snapped rect.
(WebCore::RenderLayerBacking::computePerspectiveOrigin): Ditto.
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Returns a size based on m_compositingBounds,
which is now an IntSize.
(WebCore::RenderLayerBacking::contentsBox): Switching to use pixel snapped values from the render tree.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): This now takes in and outputs integers.
(WebCore::RenderLayerBacking::paintIntoLayer): Uses a pixel snapped rect for the dirty rect.
(WebCore::paintScrollbar): Scrollbars are Widgets & painted natively, so they should use integers.
(WebCore::RenderLayerBacking::paintContents): We now properly take in an integer clip rect, as it's
used for the scrollbars.
(WebCore::RenderLayerBacking::startAnimation): Using pixel snapped values for animations and transitions.
(WebCore::RenderLayerBacking::startTransition): Ditto.
(WebCore::RenderLayerBacking::compositedBounds): Composited bounds are now properly stored as integers.
(WebCore::RenderLayerBacking::setCompositedBounds): Ditto.
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Composited bounds are pixel snapped, but
we use LayoutUnits up until we snap and return.
(WebCore::RenderLayerCompositor::addToOverlapMap): Overlap mapping uses our integer positions. Switching
it back to operating on them.
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive): Ditto.
(WebCore::RenderLayerCompositor::overlapsCompositedLayers): Ditto.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Using integers.
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation): FrameViews are on integer bounds. We now
properly use these as integers.
(WebCore::RenderLayerCompositor::frameViewDidScroll): Ditto.
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Switching to use integers and
pixelSnappedLayerCoords.
(WebCore::RenderLayerCompositor::repaintCompositedLayersAbsoluteRect): Ditto.
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Using integer positions, which are what
the apis used already returned.
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Using pixel snapped values.
(WebCore::RenderLayerCompositor::requiresCompositingForFrame): Ditto.
(WebCore::paintScrollbar): Scrollbars should always use integers.
(WebCore::RenderLayerCompositor::paintContents): Switching to use an integer clip rect.
(WebCore::RenderLayerCompositor::ensureRootLayer): Using values from new pixelSnappedLayoutOverflowRect
method on RenderBox to ensure we're using values that are pixel snapped to the proper location.
(WebCore::RenderLayerCompositor::destroyRootLayer): Properly calling scrollbar invalidation methods
with integers.
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 01:16:53 +0000 (01:16 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #8 of N.
* platform/chromium-mac-snowleopard/fast/writing-mode/background-horizontal-bt-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-lr-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-rl-expected.png: Added.
* platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png: Removed.
* platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png: Removed.
* platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png: Removed.
* platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
* platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 01:08:25 +0000 (01:08 +0000)]
Swipe gestures don't work if main frame has a horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=78650
<rdar://problem/
10864993>
Reviewed by Sam Weinig.
Source/WebCore:
Change ScrollingTree::tryToHandleWheelEvent so we can indicate that an event was
processed by the scrolling tree but that we should indicate back to WebKit that it wasn't handled.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::tryToHandleWheelEvent):
If the wheel event will start a swipe gesture, return DidNotHandleEvent.
(WebCore::ScrollingTree::updateBackForwardState):
This can now be called from any thread, so use a mutex.
(WebCore::ScrollingTree::setMainFramePinState):
New function that will set the current main frame pin state.
(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Put locks around these.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Helper function that returns whether the given wheel event will start a swipe gesture
because the main frame is pinned to the left/right and we can go back/forward.
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Call updateMainFramePinState if the frame geometry changes.
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Call updateMainFramePinState.
(WebCore::ScrollingTreeNodeMac::updateMainFramePinState):
Compute the main frame pin state and set it on the scrolling tree.
Source/WebKit2:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
ScrollingTree::tryToHandleWheelEvent now returns a tri-state enum so handle the extra case.
(WebKit::EventDispatcher::sendDidReceiveEvent):
Rename this now that it takes a parameter indicating whether the event was handled or not.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 15 Feb 2012 01:05:58 +0000 (01:05 +0000)]
Source/WebCore: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641
Reviewed by Timothy Hatcher.
* WebCore.exp.in: Add a new function to be exported.
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::showResources): Call showResources on load.
* inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.showResources): Show the resources panel.
Source/WebKit2: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641
Add WebKit2 API for the ability to show the resources panel. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showResources.
Reviewed by Timothy Hatcher.
* UIProcess/API/C/WKInspector.cpp:
(WKInspectorShowResources): Call WebInspectorProxy::showResources.
* UIProcess/API/C/WKInspector.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::showResources): Send a message to the web process.
* UIProcess/WebInspectorProxy.h:
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::showResources): Call InspectorFrontendClientLocal::showResources.
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/WebInspector.messages.in: Add a ShowResources message.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Feb 2012 01:00:46 +0000 (01:00 +0000)]
Implement an adb-based driver for the ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78627
Reviewed by Eric Seidel.
This driver mostly just wires up the ChromiumDriver through adb. In
some cases, it translates protocol elements, such as URIs, so that the
rest of webkitpy is insulated from the "remoteness" of the target device.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._driver_class):
(ChromiumAndroidPort._update_version):
(ChromiumAndroidPort._get_stderr):
(ChromiumAndroidPort):
(ChromiumAndroidPort._get_last_stacktrace):
(ChromiumAndroidPort._teardown_performance):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._test_shell_command):
(ChromiumAndroidDriver._write_command_and_read_line):
(ChromiumAndroidDriver._output_image):
(ChromiumAndroidDriver._has_crash_hint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 15 Feb 2012 00:57:07 +0000 (00:57 +0000)]
webkitpy: the real_name() method in the Port class is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=78651
Reviewed by Eric Seidel.
The change in bug 78565 / r107718 made it no longer necessary
(we can use options.platform instead).
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.name):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc