Sander de Smalen [Mon, 13 Dec 2021 16:52:35 +0000 (16:52 +0000)]
[LV] Enable scalable vectorization by default for SVE cores.
The availability of SVE should be sufficient to enable scalable
auto-vectorization.
This patch adds a new TTI interface to query the target what style of
vectorization it wants when scalable vectors are available. For other
targets than AArch64, this currently defaults to 'FixedWidthOnly'.
Differential Revision: https://reviews.llvm.org/D115651
Kadir Cetinkaya [Mon, 20 Dec 2021 14:51:09 +0000 (15:51 +0100)]
[clangd] Don't trim xrefs references if we overran the limit
This preserves all the results we've processed already rather than
throwing them away in the end.
It has some performance implications on the edge cases, in the worst case we
might issue 1 relations and 2 xrefs requests in extra to deduce `HasMore`
correctly.
Fixes https://github.com/clangd/clangd/issues/204.
Differential Revision: https://reviews.llvm.org/D116043
Louis Dionne [Tue, 14 Dec 2021 15:18:19 +0000 (10:18 -0500)]
[libc++] Add a helper class to write code with the strong exception guarantee
__transaction is a helper class that allows rolling back code in case an
exception is thrown. The main goal is to reduce the clutter when code
needs to be guarded with `#if _LIBCPP_NO_EXCEPTIONS`.
Differential Revision: https://reviews.llvm.org/D115730
Sam McCall [Fri, 19 Nov 2021 16:20:58 +0000 (17:20 +0100)]
[AST] Add UsingType: a sugar type for types found via UsingDecl
Currently there's no way to find the UsingDecl that a typeloc found its
underlying type through. Compare to DeclRefExpr::getFoundDecl().
Design decisions:
- a sugar type, as there are many contexts this type of use may appear in
- UsingType is a leaf like TypedefType, the underlying type has no TypeLoc
- not unified with UnresolvedUsingType: a single name is appealing,
but being sometimes-sugar is often fiddly.
- not unified with TypedefType: the UsingShadowDecl is not a TypedefNameDecl or
even a TypeDecl, and users think of these differently.
- does not cover other rarer aliases like objc @compatibility_alias,
in order to be have a concrete API that's easy to understand.
- implicitly desugared by the hasDeclaration ASTMatcher, to avoid
breaking existing patterns and following the precedent of ElaboratedType.
Scope:
- This does not cover types associated with template names introduced by
using declarations. A future patch should introduce a sugar TemplateName
variant for this. (CTAD deduced types fall under this)
- There are enough AST matchers to fix the in-tree clang-tidy tests and
probably any other matchers, though more may be useful later.
Caveats:
- This changes a fairly common pattern in the AST people may depend on matching.
Previously, typeLoc(loc(recordType())) matched whether a struct was
referred to by its original scope or introduced via using-decl.
Now, the using-decl case is not matched, and needs a separate matcher.
This is similar to the case of typedefs but nevertheless both adds
complexity and breaks existing code.
Differential Revision: https://reviews.llvm.org/D114251
Shivam Gupta [Mon, 20 Dec 2021 16:13:40 +0000 (21:43 +0530)]
Revert "[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience"
This reverts commit
731bde1ed30fcd8474ea6b88c3a9fc3072d2dca4.
Nemanja Ivanovic [Mon, 20 Dec 2021 15:52:11 +0000 (09:52 -0600)]
[PowerPC] Support hwsync extended mnemonic
This mnemonic has been supported by GAS for years and
it was added to the PowerPC ISA as of ISA 3.1. We will
support the mnemonic to be compatible with GAS.
Jacques Pienaar [Mon, 20 Dec 2021 16:03:43 +0000 (08:03 -0800)]
[mlir] Switching accessors to prefixed form (NFC)
Makes eventual prefixing flag flip smaller change.
Yaxun (Sam) Liu [Fri, 17 Dec 2021 16:01:51 +0000 (11:01 -0500)]
[HIPSPV][3/4] Enable SPIR-V emission for HIP
This patch enables SPIR-V binary emission for HIP device code via the
HIPSPV tool chain.
‘--offload’ option, which is envisioned in [1], is added for specifying
offload targets. This option is used to override default device target
(amdgcn-amd-amdhsa) for HIP compilation for emitting device code as
SPIR-V binary. The option is handled in getHIPOffloadTargetTriple().
getOffloadingDeviceToolChain() function (based on the design in the
SYCL repository) is added to select HIPSPVToolChain when HIP offload
target is ‘spirv64’.
The HIPActionBuilder is modified to produce LLVM IR at the backend
phase. HIPSPV tool chain expects to receive HIP device code as LLVM
IR so it can run external LLVM passes over them. HIPSPV TC is also
responsible for emitting the SPIR-V binary.
A Cuda GPU architecture ‘generic’ is added. The name is picked from
the LLVM SPIR-V Backend. In the HIPSPV code path the architecture
name is inserted to the bundle entry ID as target ID. Target ID is
expected to be always present so a component in the target triple
is not mistaken as target ID.
Tests are added for checking the HIPSPV tool chain.
[1]: https://lists.llvm.org/pipermail/cfe-dev/2020-December/067362.html
Patch by: Henry Linjamäki
Reviewed by: Yaxun Liu, Artem Belevich, Alexey Bader
Differential Revision: https://reviews.llvm.org/D110622
Serge Guelton [Mon, 20 Dec 2021 15:31:55 +0000 (10:31 -0500)]
Prevent copy of AttrBuilder
It's a relatively heavy data structure, make sure it's not copied.
Differential Revision: https://reviews.llvm.org/D116034
Frederic Cambus [Mon, 20 Dec 2021 15:22:01 +0000 (16:22 +0100)]
[llvm-readobj] Check ELFType value first when checking for OpenBSD notes.
Checking ELFType == ELF::ET_CORE first skips string comparison for the
majority of cases.
Suggested by Fangrui Song in D114635 for a similar construct.
Alexey Bataev [Fri, 17 Dec 2021 13:46:10 +0000 (05:46 -0800)]
[SLP]Fix PR52756: SLPVectorizer crashes with assertion VecTy == FinalVecTy.
Need to check for the number of the unique non-constant values since the
unique values may include several constants.
Differential Revision: https://reviews.llvm.org/D115939
Alexey Bataev [Mon, 20 Dec 2021 13:52:17 +0000 (05:52 -0800)]
Revert "[SLP]Fix PR52756: SLPVectorizer crashes with assertion VecTy == FinalVecTy."
This reverts commit
fcaf290d0278bb83387e1a1d972c55e08b8c40e3 to fix test
mismatch reported in https://lab.llvm.org/buildbot#builders/117/builds/3531
Florian Hahn [Mon, 20 Dec 2021 15:03:46 +0000 (15:03 +0000)]
[VPlan] Add Debugloc to VPInstruction.
Upcoming changes require attaching debug locations to VPInstructions,
e.g. adding induction increment recipes in D113223.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D115123
Danila Kutenin [Mon, 20 Dec 2021 14:56:56 +0000 (15:56 +0100)]
[clang-include-fixer] Fix incorrect ranking because of dangling references
SymbolAndSignals stores SymbolInfo which stores two std::strings. Then
the values are stored in a llvm::DenseMap<llvm::StringRef, double>. When
the sorting is happening, SymbolAndSignals are swapped and thus because
of small string optimization some strings may become invalid. This
results in incorrect ranking.
This was detected when running new std::sort algorithm against llvm
toolchain. This could have been prevented with running llvm::sort and
EXPENSIVE_CHECKS. Unfortunately, no sanitizer yelled.
I don't have commit rights, kutdanila@yandex.ru Danila Kutenin
Reviewed By: bkramer
Differential Revision: https://reviews.llvm.org/D116037
Christian Ulmann [Mon, 20 Dec 2021 14:36:25 +0000 (20:06 +0530)]
[MLIR] rewrite AffineStructures and Presburger tests to use the parser
This commit rewrites most existing unittests involving FlatAffineConstraints
to use the parsing utility. This helps to make the tests more understandable.
This relands commit
b0e8667b1dbdb45bdc2738e4bec1c69fe3790a27, which was
reverted in
6963be12761f9d78a49c6d43e7ac13862a8f7270, with a fix to a unittest
which was incorrectly rewritten before.
Reviewed By: arjunp
Differential Revision: https://reviews.llvm.org/D115920
Jay Foad [Mon, 20 Dec 2021 14:19:32 +0000 (14:19 +0000)]
[AMDGPU] Remove dead code after D109052
Sanjay Patel [Mon, 20 Dec 2021 14:10:50 +0000 (09:10 -0500)]
[Support] improve known bits analysis for leading zeros of multiply
Instead of summing leading zeros on the input operands, multiply the
max possible values of those inputs and count the leading zeros of
the result. This can give us an extra zero bit (typically in cases
where one of the operands is a known constant).
This allows folding away the remaining 'add' ops in the motivating
bug (modeled in the PhaseOrdering IR test):
https://github.com/llvm/llvm-project/issues/48399
Fixes #48399
Differential Revision: https://reviews.llvm.org/D115969
Alexey Bataev [Fri, 17 Dec 2021 13:46:10 +0000 (05:46 -0800)]
[SLP]Fix PR52756: SLPVectorizer crashes with assertion VecTy == FinalVecTy.
Need to check for the number of the unique non-constant values since the
unique values may include several constants.
Differential Revision: https://reviews.llvm.org/D115939
alex-t [Fri, 17 Dec 2021 17:42:00 +0000 (20:42 +0300)]
[AMDGPU] Re-enabling divergence predicates for min/max
This patch enables divergence predicates for min/max nodes.
It makes ISD::MIN/MAX selected to S_MIN_I(U)32/S_MAX_I(U)32 or V_MIN_I(U)32_e64/V_MAX_I(U)32_e64
Reviewed By: rampitec
Differential Revision: https://reviews.llvm.org/D115954
Nikita Popov [Mon, 20 Dec 2021 11:58:40 +0000 (12:58 +0100)]
[Inline] Add test for PR52660 (NFC)
alex-t [Thu, 16 Dec 2021 17:00:49 +0000 (20:00 +0300)]
[AMDGPU] Expand not pattern according to the XOR node divergence
The "not" is defined as XOR $src -1.
We need to transform this pattern to either S_NOT_B32 or V_NOT_B32_e32
dependent on the "xor" node divergence.
Reviewed By: rampitec, foad
Differential Revision: https://reviews.llvm.org/D115884
Pavel Labath [Tue, 26 Oct 2021 18:37:29 +0000 (20:37 +0200)]
[lldb] Summary provider for char flexible array members
Add a summary provider which can print char[] members at the ends of
structs.
Differential Revision: https://reviews.llvm.org/D113174
Pavel Labath [Mon, 20 Dec 2021 09:02:08 +0000 (10:02 +0100)]
[lldb/test] Remove some decorators from TestModuleCacheUniversal
Now that the test uses a yaml file for creating binaries, we can run in
anywhere.
Endre Fülöp [Sun, 19 Dec 2021 12:03:02 +0000 (13:03 +0100)]
[analyzer] Add range constructor to CallDescriptionMap
CallDescriptionMap benefits from a range constructor when the
CallDescription and mapped type pairs cannot be constructed at once, but
are built incrementally.
Reviewed By: steakhal
Differential Revision: https://reviews.llvm.org/D115934
Endre Fülöp [Sun, 19 Dec 2021 12:01:30 +0000 (13:01 +0100)]
[analyzer] Enable move semantics for CallDescriptionMap
CallDescriptionMap is supposed to be immutable and opaque about the
stored CallDescriptions, but moving a CallDescriptionMap does not
violate these principles.
Reviewed By: steakhal
Differential Revision: https://reviews.llvm.org/D115931
Nikita Popov [Sat, 18 Dec 2021 13:56:12 +0000 (14:56 +0100)]
[Attributes] Add AttributeList ctor from AttributeSet (NFC)
It was already possible to create an AttributeList from an Index
and an AttributeSet. However, this would actually end up using
the implicit constructor on AttrBuilder, thus doing an unnecessary
conversion from AttributeSet to AttrBuilder to AttributeSet.
Instead we can accept the AttributeSet directly, as that is what
we need anyway.
Pavel Labath [Mon, 20 Dec 2021 08:57:29 +0000 (09:57 +0100)]
[lldb/python] Fix a compile error in
7406d236d8
cannot pass object of non-trivial type
'lldb_private::python::PythonObject' through variadic function
Pavel Labath [Thu, 18 Nov 2021 07:11:34 +0000 (08:11 +0100)]
[lldb/python] Fix (some) dangling pointers in our glue code
This starts to fix the other half of the lifetime problems in this code
-- dangling references. SB objects created on the stack will go away
when the function returns, which is a problem if the python code they
were meant for stashes a reference to them somewhere. Most of the time
this goes by unnoticed, as the code rarely has a reason to store these,
but in case it does, we shouldn't respond by crashing.
This patch fixes the management for a couple of SB objects (Debugger,
Frame, Thread). The SB objects are now created on the heap, and
their ownership is immediately passed on to SWIG, which will ensure they
are destroyed when the last python reference goes away. I will handle
the other objects in separate patches.
I include one test which demonstrates the lifetime issue for SBDebugger.
Strictly speaking, one should create a test case for each of these
objects and each of the contexts they are being used. That would require
figuring out how to persist (and later access) each of these objects.
Some of those may involve a lot of hoop-jumping (we can run python code
from within a frame-format string). I don't think that is
necessary/worth it since the new wrapper functions make it very hard to
get this wrong.
Differential Revision: https://reviews.llvm.org/D115925
LLVM GN Syncbot [Mon, 20 Dec 2021 08:24:56 +0000 (08:24 +0000)]
[gn build] Port
754ea6fd4d52
Konstantin Varlamov [Mon, 20 Dec 2021 08:24:10 +0000 (00:24 -0800)]
[libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`.
Also:
- refactor out `__voidify`;
- use the `destroy` algorithm internally;
- refactor out helper classes used in tests for `uninitialized_*`
algorithms.
Differential Revision: https://reviews.llvm.org/D115626
Kazu Hirata [Mon, 20 Dec 2021 08:14:45 +0000 (00:14 -0800)]
[ObjectYAML] Use llvm::all_of (NFC)
Marek Kurdej [Mon, 20 Dec 2021 08:12:35 +0000 (09:12 +0100)]
[clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.
Before this patch, the code:
```
template <class T>
concept a_concept = X<>;
namespace B {
struct b_struct {};
} // namespace B
```
with config:
```
NamespaceIndentation: None
```
was wrongly indented inside namespace B, giving:
```
template <class T>
concept a_concept = X<>;
namespace B {
struct b_struct {};
} // namespace B
```
Fixes https://github.com/llvm/llvm-project/issues/50645
Reviewed By: MyDeveloperDay, owenpan
Differential Revision: https://reviews.llvm.org/D116008
Kazu Hirata [Mon, 20 Dec 2021 08:04:52 +0000 (00:04 -0800)]
[ARM] Use range-based for loops (NFC)
Mehdi Amini [Mon, 20 Dec 2021 07:20:31 +0000 (07:20 +0000)]
Revert "[MLIR] rewrite AffineStructures and Presburger tests to use the parser"
This reverts commit
b0e8667b1dbdb45bdc2738e4bec1c69fe3790a27.
ASAN/UBSAN bot is broken with this trace:
[ RUN ] FlatAffineConstraintsTest.FindSampleTest
llvm-project/mlir/include/mlir/Support/MathExtras.h:27:15: runtime error: signed integer overflow:
1229996100002 *
809999700000 cannot be represented in type 'long'
#0 0x7f63ace960e4 in mlir::ceilDiv(long, long) llvm-project/mlir/include/mlir/Support/MathExtras.h:27:15
#1 0x7f63ace8587e in ceil llvm-project/mlir/include/mlir/Analysis/Presburger/Fraction.h:57:42
#2 0x7f63ace8587e in operator* llvm-project/llvm/include/llvm/ADT/STLExtras.h:347:42
#3 0x7f63ace8587e in uninitialized_copy<llvm::mapped_iterator<mlir::Fraction *, long (*)(mlir::Fraction), long>, long *> include/c++/v1/__memory/uninitialized_algorithms.h:36:62
#4 0x7f63ace8587e in uninitialized_copy<llvm::mapped_iterator<mlir::Fraction *, long (*)(mlir::Fraction), long>, long *> llvm-project/llvm/include/llvm/ADT/SmallVector.h:490:5
#5 0x7f63ace8587e in append<llvm::mapped_iterator<mlir::Fraction *, long (*)(mlir::Fraction), long>, void> llvm-project/llvm/include/llvm/ADT/SmallVector.h:662:5
#6 0x7f63ace8587e in SmallVector<llvm::mapped_iterator<mlir::Fraction *, long (*)(mlir::Fraction), long> > llvm-project/llvm/include/llvm/ADT/SmallVector.h:1204:11
#7 0x7f63ace8587e in mlir::FlatAffineConstraints::findIntegerSample() const llvm-project/mlir/lib/Analysis/AffineStructures.cpp:1171:27
#8 0x7f63ae95a84d in mlir::checkSample(bool, mlir::FlatAffineConstraints const&, mlir::TestFunction) llvm-project/mlir/unittests/Analysis/AffineStructuresTest.cpp:37:23
#9 0x7f63ae957545 in mlir::FlatAffineConstraintsTest_FindSampleTest_Test::TestBody() llvm-project/mlir/unittests/Analysis/AffineStructuresTest.cpp:222:3
Mehdi Amini [Mon, 20 Dec 2021 07:17:26 +0000 (07:17 +0000)]
Move getAsmBlockArgumentNames from OpAsmDialectInterface to OpAsmOpInterface
This method is more suitable as an opinterface: it seems intrinsic to
individual instances of the operation instead of the dialect.
Also remove the restriction on the interface being applicable to the entry block only.
Differential Revision: https://reviews.llvm.org/D116018
jacquesguan [Mon, 20 Dec 2021 06:25:06 +0000 (14:25 +0800)]
[Clang][RISCV] Fix upper bound of RISC-V V type in debug info
The UpperBound of RVV type in debug info should be elements count minus one,
as the LowerBound start from zero.
Reviewed By: HsiangKai
Differential Revision: https://reviews.llvm.org/D115430
Shilei Tian [Mon, 20 Dec 2021 03:07:15 +0000 (22:07 -0500)]
[Clang] Add helper text to fopenmp_version_EQ to make it show in help menu
For now if we check `clang --help`, it doesn't show `-fopenmp-version`. This option
should be visible to users. In addition, it is not set to hidden in
`clang/include/clang/Driver/Options.td` as well. The reason it doesn't show is
there is no corresponding helper text. This patch simply adds it.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D115998
Esme-Yi [Mon, 20 Dec 2021 02:40:42 +0000 (02:40 +0000)]
[DebugInfo][Clang] record the access flag for class/struct/union types.
Summary: This patch records the access flag for
class/struct/union types in the clang part.
The summary of binary size change and debug info size change due to the DW_AT_accessibility attribute are as the following table. They are built with flags of `clang -O0 -g` (no -gz).
| section | before | after | change | % |
| .debug_loc | 929821 | 929821 |0|0|
|.debug_abbrev | 5885289 | 5971547 |+86258|+1.466%|
|.debug_info |
497613455 |
498122074 |+508619|+0.102%|
|.debug_ranges |
45731664 |
45731664 |0|0|
|.debug_str |
233842595 |
233839388 |-3207| -0.001%|
|.debug_line |
149773166 |
149764583 |-8583|-0.006%|
|total (debug) |
933775990 |
934359077|+583087 |+0.062%|
|total (binary) |
1394617288 |
1395200024| +582736|+0.042%|
Reviewed By: dblaikie, shchenz
Differential Revision: https://reviews.llvm.org/D115503
Shao-Ce SUN [Tue, 14 Dec 2021 09:33:51 +0000 (17:33 +0800)]
[RISCV] Remove Zvamo Extention
Based on D111692. Zvamo is not part of the 1.0 V spec. Remove it.
Reviewed By: arcbbb
Differential Revision: https://reviews.llvm.org/D115709
David Green [Sun, 19 Dec 2021 21:53:50 +0000 (21:53 +0000)]
[ARM] Fold away CMP/CSINC from CMOV
This makes use of the code in D114013 to fold away unnecessary
CMPZ/CSINC starting from a CMOV, in a similar way to how we fold away
CSINV/CSINC/etc
Differential Revision: https://reviews.llvm.org/D115185
Aleksandr Platonov [Sun, 19 Dec 2021 19:23:45 +0000 (22:23 +0300)]
[clangd] Fix undefined behavior when generating error message at rename with an invalid name
`Message()` lambda uses `Reason.Details` as an input parameter for `llvm::formatv()`, but `Reason` in `Message()` is a local object.
Return value of `llvm::formatv()` contains references to its input arguments, thus `Message()` returns an object which contains a reference to `Details` field of the local object `Reason`.
This patch fixes this behavior by passing `Reason` as a reference to `Message()` to ensure that return value of `Message()` contains references to alive object and also prevents copying of `InvalidName` structure at passing it to `makeError()`.
Provided test passes on Linux+GCC with or without this patch, but fails on Windows+VisualStudio without this patch.
Reviewed By: sammccall
Differential Revision: https://reviews.llvm.org/D115959
Sanjay Patel [Sun, 19 Dec 2021 16:53:56 +0000 (11:53 -0500)]
[CodeGen] remove creation of FP cast function attribute
This is the last cleanup step resulting from D115804 .
Now that clang uses intrinsics when we're in the special FP mode,
we don't need a function attribute as an indicator to the backend.
The LLVM part of the change is in D115885.
Differential Revision: https://reviews.llvm.org/D115886
Sanjay Patel [Fri, 17 Dec 2021 21:03:08 +0000 (16:03 -0500)]
[InstCombine] add tests for icmp with mul operand; NFC
Arjun P [Thu, 16 Dec 2021 12:41:31 +0000 (18:11 +0530)]
[MLIR] Simplex: split some basic functionality out into a SimplexBase class
This is a purely mechanical patch moving some functionality out from the
`Simplex` class out into a `SimplexBase` class. This pavees the way for
a future patch adding support for lexicographic optimization with a class
`LexSimplex`, which will inherit from `SimplexBase`. Inheriting directly
from `Simplex` would bring many additional functions that would not work in
`LexSimplex` because it operates slighty differently from `Simplex`. So We
split out only the basic functionality it needs to inherit into `SimplexBase`.
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D115831
bakhtiyar [Sun, 19 Dec 2021 16:35:37 +0000 (08:35 -0800)]
Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity.
Reviewed By: ezhulenev, mehdi_amini
Differential Revision: https://reviews.llvm.org/D115423
Simon Pilgrim [Sun, 19 Dec 2021 16:40:06 +0000 (16:40 +0000)]
[X86][AVX512] cvt_by_vec_width - don't hardcode the schedule class. NFC.
Pull out the WriteMove schedule class into the cvt_mask_by_elt_width wrapper
Shivam Gupta [Sun, 19 Dec 2021 15:27:55 +0000 (20:57 +0530)]
[DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience
When the source has a series of assignments, users reasonably want to
have the debugger step through each one individually. Turn off the combine
for adjacent stores so we get this behavior at -O0.
Similar to D7181.
Differential Revision: https://reviews.llvm.org/D115808
Krasimir Georgiev [Sun, 19 Dec 2021 15:06:55 +0000 (16:06 +0100)]
[clang-format] add regression tests for braced lists
Depends on https://reviews.llvm.org/D116000.
Added test cases from the comments on https://reviews.llvm.org/D114583.
Reviewed By: MyDeveloperDay
Differential Revision: https://reviews.llvm.org/D116001
Krasimir Georgiev [Sun, 19 Dec 2021 15:04:20 +0000 (16:04 +0100)]
Revert "[clang-format] Adjust braced list detection"
It appears that this regressed the formatting of initializer lists in some
cases, see comments on https://reviews.llvm.org/D114583. I'll follow-up
by adding regression tests for these.
This reverts commit
c41b3b0fa0f4f70aad8deaf48bcd42a04385066c.
Reviewed By: MyDeveloperDay
Differential Revision: https://reviews.llvm.org/D116000
Christian Ulmann [Sun, 19 Dec 2021 13:56:25 +0000 (19:26 +0530)]
[MLIR] rewrite AffineStructures and Presburger tests to use the parser
This commit rewrites most existing unittests involving FlatAffineConstraints to use the parsing utility. This helps to make the tests more understandable.
Reviewed By: arjunp
Differential Revision: https://reviews.llvm.org/D115920
Krasimir Georgiev [Sun, 19 Dec 2021 13:37:05 +0000 (14:37 +0100)]
[Bazel] update build files for
https://github.com/llvm/llvm-project/commit/
65d7fd0239bf301c5dcaa26ed474200845966136
Simon Pilgrim [Sun, 19 Dec 2021 13:19:40 +0000 (13:19 +0000)]
[DAG] visitADDSAT/visitSUBSAT - merge scalar/vector canonicalization and constant folding.
Match order of most of the other integer opcode combines
Simon Pilgrim [Sun, 19 Dec 2021 13:00:11 +0000 (13:00 +0000)]
[X86] Adjust some IceLake fp shuffle schedule classes (PR48110)
The IceLake scheduler model is still mainly a copy of the SkylakeServer model.
This patch adjusts the fp shuffle classes to account for most instructions now working on Port 1 as well as Port 5.
This is based off Agner + uops.info as well as the PR48110 report.
Differential Revision: https://reviews.llvm.org/D115752
Simon Pilgrim [Sat, 18 Dec 2021 22:28:53 +0000 (22:28 +0000)]
[DAG] Improve FMINNUM/FMAXNUM/FMINIMUM/FMAXIMUM constant folding
Merge the node combines into a common DAGCombiner::visitFMinMax (like we do for IMINMAX).
Move the constant folding into SelectionDAG::foldConstantFPMath.
This allows us to fold the vecreduce-propagate-sd-flags.ll test as it reduces constants - so I've refactored it to take variables instead.
Differential Revision: https://reviews.llvm.org/D115952
Shilei Tian [Sun, 19 Dec 2021 02:32:49 +0000 (21:32 -0500)]
[NFC][Clang] Remove trailing spaces in `clang/include/clang/Driver/Options.td`
Cyndy Ishida [Sun, 19 Dec 2021 00:42:00 +0000 (16:42 -0800)]
[llvm-tapi-diff] rename tests for clarity, NFC
Craig Topper [Sat, 18 Dec 2021 21:35:18 +0000 (13:35 -0800)]
[RISCV] Remove stale comments from tests. NFC
The tests no longer generate the instructions that are mentioned
in the comments.
Jakub Kuderski [Sat, 18 Dec 2021 21:07:03 +0000 (16:07 -0500)]
[AMDGPU] Use enum_seq to iterator over InstCounterTypes. NFC.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D115900
Jakub Kuderski [Sat, 18 Dec 2021 21:02:45 +0000 (16:02 -0500)]
[AMDGPU] Fix data race in SIInsertWaitcnts
The race condition happened when two pass managers ran on two different modules but modified/read the global variables.
To address this, I considered using singletons and freestanding functions to allow getting/setting `HardwareLimits` and `RegisterEncoding`, or making it local to the pass. I chose the latter and made it a member of `WaitcntsBrackets`, to minimizes the amount of global state.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D115896
Craig Topper [Sat, 18 Dec 2021 20:53:24 +0000 (12:53 -0800)]
[RISCV] Rename a Zfh and put it in the same order as the same test for F and D. NFC
Drop stale FIXME.
Michael Berg [Sat, 18 Dec 2021 02:31:29 +0000 (18:31 -0800)]
[RISCV] Add target specific loop unrolling and peeling preferences
Both these preference helper functions have initial support with
this change. The loop unrolling preferences are set with initial
settings to control thresholds, size and attributes of loops to
unroll with some tuning done. The peeling preferences may need
some tuning as well as the initial support looks much like what
other architectures utilize.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D113798
Mehdi Amini [Sat, 18 Dec 2021 20:38:06 +0000 (20:38 +0000)]
Fix warning "comparison of integers of different signs" (NFC)
Nikita Popov [Sat, 18 Dec 2021 19:40:42 +0000 (20:40 +0100)]
Revert "[ConstantFolding] Unify handling of load from uniform value"
This reverts commit
9fd4f80e33a4ae4567483819646650f5735286e2.
This breaks SingleSource/Regression/C/gcc-c-torture/execute/pr19687.c
in test-suite. Either the test is incorrect, or clang is generating
incorrect union initialization code. I've submitted
https://reviews.llvm.org/D115994 to fix the test, assuming my
interpretation is correct. Reverting this in the meantime as it
may take some time to resolve.
Martin Storsjö [Thu, 9 Dec 2021 21:40:25 +0000 (23:40 +0200)]
[lit] Flush stderr manually on Windows after printing messages
When run in a git bash terminal, sys.stderr isn't flushed implicitly
after printing each line. Manually flush it after each printout,
to avoid getting broken/misordered output.
A similar fix had been done in the old libcxx test config, committed
as part of
7e3ee09ad24cbca3ea7687c50b53be5269127fb1 / D28725; this
generalizes the fix, making it available in the new libcxx test
configs too, and for any other test that uses lit_config.note().
Differential Revision: https://reviews.llvm.org/D115761
Cyndy Ishida [Sat, 18 Dec 2021 17:42:40 +0000 (09:42 -0800)]
[llvm-tapi-diff] Replicate diff utility error handling
For scripting purposes, use different error code for cases that aren't a
result of different tbd files, e.g. bad input like a path to a broken
symlink. This behaves more similiarly to how the unix `diff` command behaves.
This also includes minor tweaks on error messages.
Reviewed By: ributzka, JDevlieghere
Differential Revision: https://reviews.llvm.org/D115905
Ricky Zhou [Sat, 18 Dec 2021 17:49:17 +0000 (18:49 +0100)]
[AA] Handle callbr instructions in alias analysis
Before this change, AAResults::getModRefInfo() was missing a case for
callbr instructions (asm goto), which may read/write memory. In PR52735,
this led to a miscompile where a load was incorrect eliminated.
Add this missing case, as well as an assert verifying that all
memory-accessing instructions are handled properly.
Fixes #52735.
Differential Revision: https://reviews.llvm.org/D115992
Nikita Popov [Sat, 18 Dec 2021 16:55:39 +0000 (17:55 +0100)]
[LLParser] Avoid unnecessary AttrBuilder<->AttributeSet roundtrip (NFC)
This was creating an AttributeSet from an AttrBuilder, and then
(implicitly) constructing an AttrBuilder from the AttributeSet,
and then the method would internally convert that back into an
AttributeSet. Instead, directly pass the AttrBuilder.
Matt Arsenault [Sat, 18 Dec 2021 16:36:43 +0000 (11:36 -0500)]
AMDGPU: Regenerate more mir test checks with -NEXT
Matt Arsenault [Sat, 18 Dec 2021 15:07:00 +0000 (10:07 -0500)]
AMDGPU: Regenerate some mir test checks with -NEXT
mydeveloperday [Sat, 18 Dec 2021 14:10:14 +0000 (14:10 +0000)]
[clang-format] extern with new line brace without indentation
https://github.com/llvm/llvm-project/issues/49804
Interaction between IndentExternBlock and AfterExternBlock means you cannot have AfterExternBlock = true and IndentExternBlock = NoIndent/Indent
This patch resolves that
```
BraceWrapping:
AfterExternBlock: true
IndentExternBlock: AfterExternBlock
```
Fixes: #49804
Reviewed By: HazardyKnusperkeks, curdeius, owenpan
Differential Revision: https://reviews.llvm.org/D115879
Konstantin Boyarinov [Sat, 18 Dec 2021 13:05:16 +0000 (16:05 +0300)]
[libcxx][test][NFC] noexcept tests for std::array
Minor change - add tests that std::array methods (data, (c/r)begin,
(c/r)end) are noexcept
Reviewed By: ldionne, rarutyun, #libc
Differential Revision: https://reviews.llvm.org/D115717
mydeveloperday [Fri, 17 Dec 2021 18:33:17 +0000 (18:33 +0000)]
[clang-format] Extra spaces surrounding arrow in templated member call in variable decl
https://github.com/llvm/llvm-project/issues/43196
Fixes #43196
-> is incorrectly interpreted as a TrailingReturnArrow if we've seen an auto
```
auto p = new A;
auto x = p -> foo<1>();
```
Reviewed By: curdeius
Differential Revision: https://reviews.llvm.org/D115903
Nikita Popov [Sat, 18 Dec 2021 08:11:33 +0000 (09:11 +0100)]
Revert "[DSE] Remove calls with known writes to dead memory"
This reverts commit
a8a51fe55649f5e07f9f2973507dc20bc4e40765.
This breaks the strncpy-overflow.cpp test case.
Fangrui Song [Sat, 18 Dec 2021 07:30:42 +0000 (23:30 -0800)]
[ELF] Parallelize MergeNoTailSection::writeTo
With this patch, writing .debug_str is significantly for a program with
1.5G .debug_str:
* .debug_info 1.22s
* .debug_str 2.57s decreases to 0.66
Kazu Hirata [Sat, 18 Dec 2021 04:55:10 +0000 (20:55 -0800)]
[clang] Strip redundant lambda (NFC)
Fangrui Song [Sat, 18 Dec 2021 03:22:15 +0000 (19:22 -0800)]
[ELF] Use SmallVector for many SyntheticSections. NFC
This decreases struct sizes and usually decreases the lld executable
size (39KiB for my x86-64 executable) (unless in some cases smaller
SmallVector leads to more inlining, e.g. StringTableBuilder).
For --gdb-index, there may be memory usage saving.
Joshua Huels [Sat, 18 Dec 2021 02:37:55 +0000 (18:37 -0800)]
[doc] Fix regex in ClangFormatStyleOptions for IncludeCategories
This fixes the regex in ClangFormatStyleOptions for IncludeCategories
to match anything starting with < or starting with | AND followed by
(gtest|gmock|isl|json) then /.
Differential Revision: https://reviews.llvm.org/D115910
Kazu Hirata [Sat, 18 Dec 2021 02:19:24 +0000 (18:19 -0800)]
Use DenseMap::lookup (NFC)
Jonas Devlieghere [Fri, 17 Dec 2021 22:45:24 +0000 (14:45 -0800)]
[lldb] Remove reproducer replay functionality
This is part of a bigger rework of the reproducer feature. See [1] for
more details.
[1] https://lists.llvm.org/pipermail/lldb-dev/2021-September/017045.html
Kazu Hirata [Sat, 18 Dec 2021 00:51:42 +0000 (16:51 -0800)]
[clang] Use llvm::reverse (NFC)
Yuanfang Chen [Sat, 18 Dec 2021 00:26:08 +0000 (16:26 -0800)]
WinMsvc.cmake: try lower-case include/lib when searching for windows SDK
if the pascal case ones failed. Some tools, like msvc-wine/xwin, use the
lower case.
Julian Lettner [Thu, 16 Dec 2021 03:33:51 +0000 (19:33 -0800)]
[TSan][Darwin] Fix shadow mapping for iOS simulator on Apple Silicon
With the introduction of Apple Silicon `defined(__aarch64__)` is not a
reliable way to check for the platform anymore.
We want to use the "normal" `Mapping48AddressSpace` mapping everywhere
except devices, including the iOS simulators on AS.
Relevant revisions:
https://reviews.llvm.org/D35147
https://reviews.llvm.org/D86377
https://reviews.llvm.org/D107743
https://reviews.llvm.org/D107888
Differential Revision: https://reviews.llvm.org/D115843
Julian Lettner [Fri, 17 Dec 2021 03:33:12 +0000 (19:33 -0800)]
[TSan][Darwin] Make malloc_size interceptor more robust
Previously we would crash in the TSan runtime if the user program passes
a pointer to `malloc_size()` that doesn't point into app memory.
In these cases, `malloc_size()` should return 0.
For ASan, we fixed a similar issue here:
https://reviews.llvm.org/D15008
Radar-Id: rdar://problem/
86213149
Differential Revision: https://reviews.llvm.org/D115947
Vitaly Buka [Fri, 17 Dec 2021 23:03:57 +0000 (15:03 -0800)]
[runtimes] Remove LLVM_ENABLE_LLD
It was added D115852 and related patches and it brakes https://lab.llvm.org/buildbot/#/builders/fuchsia-x86_64-linux
Kazu Hirata [Fri, 17 Dec 2021 22:34:30 +0000 (14:34 -0800)]
[Hexagon] Use is_contained (NFC)
Jon Chesterfield [Fri, 17 Dec 2021 22:23:56 +0000 (22:23 +0000)]
[libomptarget][nfc] Refactor dlwrap.h for easier reuse in D115966 and upcoming patches
Ellis Hoag [Fri, 17 Dec 2021 21:44:16 +0000 (13:44 -0800)]
[InstrProf][NFC] Require zlib for debug info tests
There was a build failure on the `instrprof-debug-info-correlate.c` test
because zlib was missing so we need to require it to run the test.
Differential Revision: https://reviews.llvm.org/D115970
Marek Kurdej [Fri, 17 Dec 2021 22:02:16 +0000 (23:02 +0100)]
[clang-format] Refactor common handling of attributes. NFC.
Reviewed By: MyDeveloperDay
Differential Revision: https://reviews.llvm.org/D115968
Kazu Hirata [Fri, 17 Dec 2021 21:48:56 +0000 (13:48 -0800)]
[llvm] Use none_of instead of \!any_of (NFC)
Philip Reames [Fri, 17 Dec 2021 21:41:25 +0000 (13:41 -0800)]
[DSE] Remove calls with known writes to dead memory
The majority of this change is sinking logic from instcombine into MemoryLocation such that it can be generically reused. If we have a call with a single analyzable write to an argument, we can treat that as-if it were a store of unknown size.
Merging the code in this was unblocks DSE in the store to dead memory code paths. In theory, it should also enable classic DSE of such calls, but the code appears to not know how to use object sizes to refine unknown access bounds (yet).
In addition, this does make the isAllocRemovable path slightly stronger by reusing the libfunc and additional intrinsics bits which are already in getForDest.
Differential Revision: https://reviews.llvm.org/D115904
Vy Nguyen [Wed, 15 Dec 2021 02:07:06 +0000 (21:07 -0500)]
[lld-macho] Handle $ld$hide[$os] symbols.
PR/52708
Differential Revision: https://reviews.llvm.org/D115775
Vitaly Buka [Fri, 17 Dec 2021 21:36:25 +0000 (13:36 -0800)]
[runtimes] Fix type on flag name in D115852
Sanjay Patel [Fri, 17 Dec 2021 15:58:48 +0000 (10:58 -0500)]
[SDAG] remove FP-to-int cast attribute check in fold to FTRUNC
We were using a function attribute to indicate a non-standard FP mode,
but now we can use intrinsics for that job as shown in the new tests.
Presumably the x86 asm could be improved for that IR with intrinsics,
but I have not worked out exactly how to do that. Note that the
transform to FTRUNC still requires a hacky check for "nsz" (because
FMF are not applied to FP casts).
This is a cleanup based on the clang change in D115804 /
8c7f2a4f87192 .
This is effectively a revert of
5a90285bd98d2 + D46237 .
Differential Revision: https://reviews.llvm.org/D115885
Jacques Pienaar [Fri, 17 Dec 2021 20:55:44 +0000 (12:55 -0800)]
[mlir][vscode] Highlight inside c++ raw strings
Within C++ raw strings with mlir delimitter use MLIR syntax.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D115963
Alexey Bataev [Fri, 17 Dec 2021 20:41:47 +0000 (12:41 -0800)]
[SLP][NFC]Adjust type in debug output loop.
The ReuseShuffleIndices indeces are integer, not unsigned, need to fix
the type in the debug print loop.
Philip Reames [Fri, 17 Dec 2021 20:42:42 +0000 (12:42 -0800)]
[tests] Precommit tests from D115904
Nico Weber [Fri, 17 Dec 2021 17:35:52 +0000 (12:35 -0500)]
[lld/mac] Don't lose "weak ref" bit when doing LTO
Fixes #52778.
Probably fixes Chromium crashing on startup on macOS 10.15 (and older) systems
when building with LTO, but I haven't verified that yet.
Differential Revision: https://reviews.llvm.org/D115949
Jonas Devlieghere [Fri, 17 Dec 2021 20:18:22 +0000 (12:18 -0800)]
[lldb] Remove --reproducer-finalize and associated functionality
This is part of a bigger rework of the reproducer feature. See [1] for
more details.
[1] https://lists.llvm.org/pipermail/lldb-dev/2021-September/017045.html
Greg Clayton [Fri, 17 Dec 2021 20:14:44 +0000 (12:14 -0800)]
Fix macOS buildbots after https://reviews.llvm.org/D115324.
The test was attempting to make a universal x86_64/arm64 binary, but some older bots don't have a macOS SDK that can handle this. Switching over to using a yaml file instead should solve the problem.
Alexey Bataev [Fri, 17 Dec 2021 18:57:44 +0000 (10:57 -0800)]
[SLP][NFC]Use 'llvm::copy' instead of element-by-elemen copying.