Mark Nauwelaerts [Tue, 16 Nov 2010 11:08:54 +0000 (12:08 +0100)]
flacparse: minor refactor and enable default baseparse segment clipping
Mark Nauwelaerts [Tue, 9 Nov 2010 18:38:25 +0000 (19:38 +0100)]
mpegaudioparse: fix silly leak in _reset
Mark Nauwelaerts [Fri, 29 Oct 2010 12:08:58 +0000 (14:08 +0200)]
baseparse: use only upstream duration if it provides one
Mark Nauwelaerts [Mon, 25 Oct 2010 12:15:50 +0000 (14:15 +0200)]
baseparse: reflow update_bitrate code
... which makes local variables represent real state better, and avoids
triggering unneeded updates/actions.
Mark Nauwelaerts [Mon, 25 Oct 2010 12:13:51 +0000 (14:13 +0200)]
baseparse: add some debug statements
Tim-Philipp Müller [Tue, 19 Oct 2010 22:25:54 +0000 (23:25 +0100)]
dcaparse: init variable to make osx build bot happy
gstdcaparse.c: In function 'gst_dca_parse_check_valid_frame':
gstdcaparse.c:246: warning: 'best_sync' may be used uninitialized in this function
Tim-Philipp Müller [Mon, 18 Oct 2010 23:15:20 +0000 (00:15 +0100)]
audioparsers: add very basic dts/dca parser
Still some issues, e.g. with seekable queries in totem, but also
processing already-chunked input (created with matroskademux ! gdppay).
Mark Nauwelaerts [Thu, 14 Oct 2010 14:48:21 +0000 (16:48 +0200)]
ac3parse: properly parse e-ac3 frame header
Also add a few debug statements.
Mark Nauwelaerts [Wed, 13 Oct 2010 09:00:01 +0000 (11:00 +0200)]
flacparse: tweak setting buffer metadata; avoid timestamp jitter
Fixes #631993.
Mark Nauwelaerts [Tue, 12 Oct 2010 16:07:49 +0000 (18:07 +0200)]
aacparse: streamline src caps setting
In particular, also set src caps whenever changes in stream warrant doing so.
Sebastian Dröge [Tue, 12 Oct 2010 08:28:33 +0000 (10:28 +0200)]
flacparse: Adjust unit tests to new flacparse behaviour
Garbage after frames is now included in the frames because flacparse
has no easy way to detect the real end of a frame. Decoders are
expected to everything after the frame because only decoding the
bitstream will reveal the real end of the frame.
Fixes bug #631814.
Sebastian Dröge [Tue, 12 Oct 2010 08:27:53 +0000 (10:27 +0200)]
flacparse: Don't drop the last frame if it is followed by garbage
See bug #631814.
Mark Nauwelaerts [Mon, 11 Oct 2010 15:49:46 +0000 (17:49 +0200)]
baseparse: perform bitrate handling and posting after newsegment sending
Mark Nauwelaerts [Mon, 11 Oct 2010 15:36:19 +0000 (17:36 +0200)]
baseparse: immediately post subclass provided bitrate
Mark Nauwelaerts [Mon, 11 Oct 2010 15:06:48 +0000 (17:06 +0200)]
flacparse: fix parsing with unknown framesizes
Fixes #631814 (mostly).
Sebastian Dröge [Thu, 7 Oct 2010 21:37:36 +0000 (23:37 +0200)]
flacparse: Simplify frame header parsing by using lookup tables
Based on a patch by Felipe Contreras.
See bug #631200.
Sebastian Dröge [Thu, 7 Oct 2010 21:28:08 +0000 (23:28 +0200)]
flacparse: Don't parse the complete FLAC frames but only look for valid frame headers
Thanks to Felipe Contreras for the suggestion. This is partially
based on his patches and makes flacparse more than 3.5 times faster.
Looking for valid frame headers is unlikely to give false positives
because every frame header is at least 9 bytes long, contains a
14 bit sync code and a 8 bit checksum over the first 8 bytes.
Fixes bug #631200.
Sebastian Dröge [Wed, 6 Oct 2010 16:32:51 +0000 (18:32 +0200)]
flacparse: Really post tags only after the initial newsegment event
The first newsegment event will be send by the first call to
gst_base_parse_push_buffer() if necessary, posting the tags
before that is not a good idea. Instead do it from the
GstBaseParse::pre_push_buffer vfunc.
Tim-Philipp Müller [Tue, 5 Oct 2010 10:17:52 +0000 (11:17 +0100)]
Revert "baseparse: add skip property"
This reverts commit
b5a3d60363d837a10f0533c141ec93d10b742312.
Reverting this for now, since no one really seems to remember why this
property exists or what it could possibly be good for. It seems to have
been in the original mp3parse since the beginning of time and was back-
ported from there.
Sebastian Dröge [Mon, 4 Oct 2010 08:41:52 +0000 (10:41 +0200)]
flacparse: Fix uninitialized variable compiler warnings
These warnings are wrong, the variables are only used if they were
initialized by the bit reader.
Felipe Contreras [Mon, 13 Sep 2010 23:48:58 +0000 (02:48 +0300)]
flacparse: fix picture parsing
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Sebastian Dröge [Sun, 3 Oct 2010 21:54:49 +0000 (23:54 +0200)]
flacparse: Push tags before the header buffers are pushed
Felipe Contreras [Mon, 2 Aug 2010 17:50:21 +0000 (20:50 +0300)]
flacparse: trivial caps fix
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Sebastian Dröge [Sun, 3 Oct 2010 21:50:29 +0000 (23:50 +0200)]
audioparser: Let the format string agree with the parameters to fix compiler warning
Sebastian Dröge [Sun, 3 Oct 2010 13:41:20 +0000 (15:41 +0200)]
ac3parse: Use unchecked versions of the bitreader get functions
We didn't check the return values anyway...
Arun Raghavan [Wed, 22 Sep 2010 10:14:43 +0000 (15:44 +0530)]
baseparse: Fix debug output
We lose the reference to the buffer after gst_pad_push(), so the debug
print should happen before.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
Mark Nauwelaerts [Fri, 1 Oct 2010 10:34:55 +0000 (12:34 +0200)]
audioparsers: add flacparse unit test
... and tweak parser test helper in the process.
Mark Nauwelaerts [Wed, 29 Sep 2010 14:12:42 +0000 (16:12 +0200)]
baseparse: support reverse playback
... in pull mode or upstream driven.
Mark Nauwelaerts [Mon, 27 Sep 2010 10:16:43 +0000 (12:16 +0200)]
baseparse: remove done TODOs and update documentation
Mark Nauwelaerts [Sat, 25 Sep 2010 12:40:54 +0000 (14:40 +0200)]
baseparse: use determined seekability in answering SEEKING query
Mark Nauwelaerts [Sat, 25 Sep 2010 12:32:06 +0000 (14:32 +0200)]
baseparse: add skip property
Mark Nauwelaerts [Sat, 25 Sep 2010 11:59:39 +0000 (13:59 +0200)]
audioparsers: add ac3parse and mpegaudioparse unit test
Mark Nauwelaerts [Sat, 25 Sep 2010 11:59:18 +0000 (13:59 +0200)]
mpegaudioparse: initial version
... adequately equivalent to mp3parse, so lets boldly set it
to higher rank.
Mark Nauwelaerts [Sat, 25 Sep 2010 12:01:07 +0000 (14:01 +0200)]
aacparse: set minimum frame size at _start
... rather than one time at _init.
Mark Nauwelaerts [Sat, 25 Sep 2010 11:50:51 +0000 (13:50 +0200)]
audioparsers: refactor existing unit tests using common helper
Mark Nauwelaerts [Wed, 22 Sep 2010 13:07:09 +0000 (15:07 +0200)]
baseparse: use _set_frame_props to configure frame lead_in and lead_out
... provided a corresponding decoder with sufficient leading and following
frames to carry out full decoding for a particular segment.
Mark Nauwelaerts [Wed, 22 Sep 2010 12:13:17 +0000 (14:13 +0200)]
baseparse: use _set_duration to configure duration update interval
... as it logically belongs there as one or the other; either subclass
can provide a duration, or an estimate must be made (reguarly updated).
Mark Nauwelaerts [Wed, 22 Sep 2010 11:55:20 +0000 (13:55 +0200)]
baseparse: localize use of provided fps information
Mark Nauwelaerts [Wed, 22 Sep 2010 10:13:12 +0000 (12:13 +0200)]
baseparse: seek table and accurate seek support
Mark Nauwelaerts [Tue, 21 Sep 2010 11:57:10 +0000 (13:57 +0200)]
baseparse: proper and more extended segment and seek handling
That is, loop pause handling, segment seek support, newsegment for gaps, etc
Mark Nauwelaerts [Tue, 21 Sep 2010 08:57:04 +0000 (10:57 +0200)]
baseparse: add index support
Mark Nauwelaerts [Tue, 21 Sep 2010 07:59:56 +0000 (09:59 +0200)]
baseparse: refactor state reset
Mark Nauwelaerts [Mon, 20 Sep 2010 14:39:37 +0000 (16:39 +0200)]
baseparse: prevent indefinite resyncing
Mark Nauwelaerts [Mon, 20 Sep 2010 11:57:55 +0000 (13:57 +0200)]
baseparse: specific EOS handling if no output so far
Mark Nauwelaerts [Mon, 20 Sep 2010 11:31:57 +0000 (13:31 +0200)]
baseparse: adjust _set_frame_prop documentation and set default as claimed
Mark Nauwelaerts [Mon, 20 Sep 2010 11:30:54 +0000 (13:30 +0200)]
baseparse: fix bitrate copy-and-paste and update heuristic
Mark Nauwelaerts [Fri, 17 Sep 2010 16:33:29 +0000 (18:33 +0200)]
baseparse: post duration message if average bitrates is updated
Mark Nauwelaerts [Fri, 17 Sep 2010 16:24:22 +0000 (18:24 +0200)]
baseparse: remove is_seekable vmethod and use a set_seek instead
Seekability, like duration, etc is unlikely to change (frequently), and
the default assumption covers most cases, so let subclass set when needed.
At the same time, allow subclass to indicate if it has seek-metadata (table)
available, and possibly have it provide an average bitrate.
Mark Nauwelaerts [Fri, 17 Sep 2010 15:35:40 +0000 (17:35 +0200)]
ac3parse: remove redundant default is_seekable
Mark Nauwelaerts [Fri, 17 Sep 2010 15:21:46 +0000 (17:21 +0200)]
baseparse: add another hook for subclass prior to pushing buffer
... and allow subclass to perform custom segment clipping, or to
emit tags or messages at this time.
Mark Nauwelaerts [Fri, 17 Sep 2010 15:19:37 +0000 (17:19 +0200)]
baseparse: 0 converts to 0 by default
Mark Nauwelaerts [Thu, 16 Sep 2010 16:56:46 +0000 (18:56 +0200)]
basepase: refactor conversion using helper function and export default convert
Mark Nauwelaerts [Thu, 16 Sep 2010 16:35:47 +0000 (18:35 +0200)]
baseparse: streamline query handling
Mark Nauwelaerts [Thu, 16 Sep 2010 09:51:20 +0000 (11:51 +0200)]
baseparse: cleanup struct and remove unused member
Mark Nauwelaerts [Mon, 16 Aug 2010 09:04:37 +0000 (11:04 +0200)]
audioparsers: increase ranks to enable auto-plugging
Because we can, and should, have some shakedown testing before having
these make it into -good later on ...
Arun Raghavan [Wed, 22 Sep 2010 10:37:24 +0000 (16:07 +0530)]
baseparse: Allow chaining of subclass event handlers
This allows the child class to chain its event handler with
GstBaseParse, so that subclasses don't have to duplicate all the default
event handling logic.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
Sebastian Dröge [Fri, 27 Aug 2010 16:35:10 +0000 (18:35 +0200)]
baseparse: Don't use GST_FLOW_IS_FATAL()
Also don't post an error message for UNEXPECTED and do it
for NOT_LINKED.
Mark Nauwelaerts [Mon, 6 Sep 2010 12:12:00 +0000 (14:12 +0200)]
baseparse: non-TIME seek event is simply not handled
Mark Nauwelaerts [Tue, 15 Jun 2010 13:34:05 +0000 (15:34 +0200)]
baseparse: fix seek event ref handling
Mark Nauwelaerts [Tue, 15 Jun 2010 13:33:37 +0000 (15:33 +0200)]
baseparse: prevent arithmetic overflows in pull mode buffer cache handling
Mark Nauwelaerts [Tue, 15 Jun 2010 13:32:34 +0000 (15:32 +0200)]
baseparse: fix seek handling
Allow a few more seek event type combinations, and really use the result
of gst_segment_set_seek to perform the seek. Also add some debug.
Edward Hervey [Mon, 12 Apr 2010 16:07:29 +0000 (18:07 +0200)]
check: Don't re-declare 'GList *buffers' in the tests
It's an external which lives in gstcheck.c. Redeclaring it makes some
compilers/architectures think the 'buffers' in the individual tests are
a different symbol... and therefore we end up comparing holodecks with
oranges.
Arun Raghavan [Fri, 26 Mar 2010 18:56:49 +0000 (18:56 +0000)]
baseparse: Don't emit bitrate tags too early
We wait to parse a minimum number of frames (10, arbitrarily) before
emiting bitrate tags so that our early estimates are not wildly
inaccurate for streams that start with a silence. If the stream ends
before that, we just emit the tags anyway.
While it _would_ be nicer to be specify the threshold to start pushing
the tags in terms of duration, this would introduce more complexity than
this merits.
https://bugzilla.gnome.org/show_bug.cgi?id=614991
Sebastian Dröge [Fri, 26 Mar 2010 17:58:35 +0000 (18:58 +0100)]
flacparse: Optionally check the overall frame checksums too before accepting a frame as valid
This is optional because it's a quite expensive operation and it's very
unlikely that a non-frame is detected as frame after the header CRC check
and checking all bits for valid values. The overall frame checksums are
mainly useful to detect inconsistencies in the encoded payload.
Sebastian Dröge [Fri, 26 Mar 2010 17:42:28 +0000 (18:42 +0100)]
flacparse: Check the CRC-8 of the headers before accepting a frame as valid
This makes false-positives during seeking much less likely and detection of
them much faster.
Sebastian Dröge [Fri, 26 Mar 2010 17:20:24 +0000 (18:20 +0100)]
baseparse: Set the last stop to the buffer starttime if the duration is invalid
...instead of not setting it at all.
Joshua M. Doe [Fri, 26 Mar 2010 17:19:00 +0000 (18:19 +0100)]
baseparse: Send NEWSEGMENT event with correct start and position
Instead of taking the last stop (which could be buffer endtime instead
of starttime) always take the buffer starttime.
Fixes bug #614016.
Arun Raghavan [Fri, 26 Mar 2010 16:49:01 +0000 (16:49 +0000)]
flacparse: Fix buffer refcount issue
When called from the GST_FLAC_PARSE_STATE_HEADERS case,
gst_flac_parse_hand_headers() does a gst_buffer_set_caps() on a buffer
with refcount > 1. This change handles this case by making the buffer
metadata_Writable.
https://bugzilla.gnome.org/show_bug.cgi?id=614037
Tim-Philipp Müller [Thu, 25 Mar 2010 17:09:17 +0000 (17:09 +0000)]
audioparsers: remove unused GstBaseParseClassPrivate structure
Arun Raghavan [Thu, 25 Mar 2010 12:55:02 +0000 (12:55 +0000)]
flacparse: Make bitrate estimation more accurate
This implements the get_frame_overhead() vfunc so that baseparse can
make more accurate bitrate estimates.
Arun Raghavan [Thu, 25 Mar 2010 11:48:46 +0000 (11:48 +0000)]
aacparse: Fix bitrate calculation
This patch adds the get_frame_overhead() vfunc so that baseparse can
accurately calculate the min/avg/max bitrates for aacparse.
Note: The bitrate was being incorrectly calculated for ADTS streams
(it's not in the header as the code suggests).
Arun Raghavan [Thu, 25 Mar 2010 11:22:58 +0000 (11:22 +0000)]
audioparsers: Add bitrate calculation to baseparse
This makes baseparse keep a running average of the stream bitrate, as
well as the minimum and maximum bitrates. Subclasses can override a
vfunc to make sure that per-frame overhead from the container is not
accounted for in the bitrate calculation.
We take care not to override the bitrate, minimum-bitrate, and
maximum-bitrate tags if they have been posted upstream. We also
rate-limit the emission of bitrate so that it is only triggered by a
change of >10 kbps.
Benjamin Otte [Mon, 22 Mar 2010 15:56:03 +0000 (16:56 +0100)]
Add -Wold-style-definition
and fix the warnings
Benjamin Otte [Sun, 21 Mar 2010 20:39:18 +0000 (21:39 +0100)]
Add -Wmissing-declarations -Wmissing-prototypes to configure flags
And fix all warnings
Benjamin Otte [Thu, 18 Mar 2010 16:30:26 +0000 (17:30 +0100)]
gst_element_class_set_details => gst_element_class_set_details_simple
Mark Nauwelaerts [Thu, 14 Jan 2010 10:50:33 +0000 (11:50 +0100)]
audioparsers: rename baseparse GType name to avoid possible conflicts
Edward Hervey [Tue, 12 Jan 2010 17:55:53 +0000 (18:55 +0100)]
flacparse: Initialize variables.
Fixes build on $#@*( macosx
Ðóñëàí Èæáóëàòîâ [Mon, 11 Jan 2010 19:41:57 +0000 (22:41 +0300)]
win32: Include config.h before anything else. Fix mpegdemux LIBADD
Because config.h defines __MSVCRT_VERSION__, which should be defined
before inclusion of any system header.
Also fixes mpegdemux Makefile.am LIBADD typo.
Fixes #606665
Thiago Santos [Mon, 11 Jan 2010 16:20:26 +0000 (13:20 -0300)]
aacparse: Also add stream-format to template caps
Do not forget to add stream-format to template caps
off aacparse
Thiago Santos [Mon, 11 Jan 2010 16:13:41 +0000 (13:13 -0300)]
Rename aac's stream-format 'none' to 'raw'
Renames aac's stream-format from previous commits from none to
raw
Thiago Santos [Mon, 11 Jan 2010 15:10:02 +0000 (12:10 -0300)]
aacparse: update tests to stream-format changes
Updates aacparse unit tests to check for stream-format
correctness as well.
Thiago Santos [Mon, 11 Jan 2010 13:51:18 +0000 (10:51 -0300)]
aacparse: Add stream-format to output caps
Adds stream-format field to output caps
Mark Nauwelaerts [Tue, 5 Jan 2010 14:05:05 +0000 (15:05 +0100)]
audioparsers: documentation fixes
Mark Nauwelaerts [Tue, 5 Jan 2010 14:04:38 +0000 (15:04 +0100)]
ac3parse: add documentation
Mark Nauwelaerts [Tue, 5 Jan 2010 13:48:49 +0000 (14:48 +0100)]
flacparse: add documentation
Mark Nauwelaerts [Mon, 21 Dec 2009 17:29:43 +0000 (18:29 +0100)]
flacparse: perform additional frame checks when resyncing
Mark Nauwelaerts [Tue, 5 Jan 2010 15:35:52 +0000 (16:35 +0100)]
flacparse: fix (multiple channel) frame parsing
Mark Nauwelaerts [Tue, 5 Jan 2010 15:35:44 +0000 (16:35 +0100)]
flacparse: declare unparsed input and parsed output
Mark Nauwelaerts [Mon, 21 Dec 2009 17:19:23 +0000 (18:19 +0100)]
ac3parse: fix scanning for next syncword
Mark Nauwelaerts [Mon, 21 Dec 2009 17:18:39 +0000 (18:18 +0100)]
baseparse: adjust seek handling and newsegment sending
Perform sanity check on type of seek, and only perform one that is
appropriately supported. Adjust downstream newsegment event
to first buffer timestamp that is sent downstream.
Mark Nauwelaerts [Mon, 21 Dec 2009 10:59:45 +0000 (11:59 +0100)]
baseparse: minor refactor cleanup
Also add some debug logging.
Mark Nauwelaerts [Fri, 18 Dec 2009 20:05:11 +0000 (21:05 +0100)]
flacparse: locate next sync code more efficiently
Mark Nauwelaerts [Fri, 18 Dec 2009 20:04:12 +0000 (21:04 +0100)]
flacparse: baseparse takes care of handling leftover pieces
Mark Nauwelaerts [Fri, 18 Dec 2009 20:02:40 +0000 (21:02 +0100)]
baseparse: implement leftover draining in pull mode
Mark Nauwelaerts [Thu, 17 Dec 2009 11:45:36 +0000 (12:45 +0100)]
flacparse: set _OFFSET and _OFFSET_END on outgoing buffers
Mark Nauwelaerts [Thu, 17 Dec 2009 11:44:20 +0000 (12:44 +0100)]
audioparsers: move 'flacparse' into it
Mark Nauwelaerts [Wed, 16 Dec 2009 17:38:33 +0000 (18:38 +0100)]
baseparse: provide default conversion using bps if no fps available
Also store estimated duration as such, rather than pretending otherwise
(e.g. set by subclass).
Mark Nauwelaerts [Fri, 18 Dec 2009 12:30:29 +0000 (13:30 +0100)]
baseparse: check for remaining data when draining in push mode
Mark Nauwelaerts [Fri, 18 Dec 2009 12:30:07 +0000 (13:30 +0100)]
baseparse: fix pull mode cache size comparison
Edward Hervey [Fri, 18 Dec 2009 12:01:17 +0000 (13:01 +0100)]
ac3parse: Fix unitialized variable.