Qiang Yu [Mon, 6 Dec 2021 09:45:59 +0000 (17:45 +0800)]
mesa: add ARB_sparse_texture query in glGetInternalformativ
Add new parameter of glGetInternalformativ for ARB_sparse_texture.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Qiang Yu [Mon, 6 Dec 2021 09:43:20 +0000 (17:43 +0800)]
gallium: add get_sparse_texture_virtual_page_size for noop/rbug/trace
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Qiang Yu [Mon, 6 Dec 2021 09:37:35 +0000 (17:37 +0800)]
gallium: add screen get_sparse_texture_virtual_page_size callback
For ARB_sparse_texture extension to query driver supported page
size for each texture format.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Qiang Yu [Sat, 4 Dec 2021 03:47:33 +0000 (11:47 +0800)]
mesa: add ARB_sparse_texture constants
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Qiang Yu [Sat, 4 Dec 2021 03:36:03 +0000 (11:36 +0800)]
mesa: add ARB_sparse_texture extension
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Qiang Yu [Fri, 3 Dec 2021 08:12:42 +0000 (16:12 +0800)]
gallium: add caps for sparse texture support
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Qiang Yu [Sat, 4 Dec 2021 02:46:53 +0000 (10:46 +0800)]
glapi: should not add alias function to static_data.py
Alias function should not be assigned an offset, otherwise new added
function will get error:
Exception: entries are not ordered by slots
Fixes:
757bc6d37a6 ("mesa: Add support for EXT_clear_texture")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14223>
Vinson Lee [Tue, 10 Aug 2021 00:33:04 +0000 (17:33 -0700)]
r600/sfn: Remove unused AluInstruction members.
Fix defects reported by Coverity Scan.
uninit_member: Non-static class member m_omod is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member m_pred_sel is not initialized in this constructor nor in any functions that it calls.
Suggested-by: Emma Anholt <emma@anholt.net>
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12294>
Dave Airlie [Thu, 30 Dec 2021 01:10:46 +0000 (11:10 +1000)]
crocus: set max clip planes to 6 for gen4.
Fixes piglit gl-1.0-user-clip-all-planes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14344>
Dave Airlie [Thu, 30 Dec 2021 01:09:07 +0000 (11:09 +1000)]
gallium/mesa: enhance PIPE_CAP_CLIP_PLANES to support override number
There exists hardware intel gen4 specifically that has only 6 clip planes
but supports GLSL 1.30. This enhances the CAP so that the current values
of 0,1 remain the same, but giving it a larger number will override the
max.
This allows the gen4 intel to set this to 6 and leave everyone else alone.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14344>
Dave Airlie [Thu, 30 Dec 2021 01:52:32 +0000 (11:52 +1000)]
crocus: don't create staging resources > half aperture
The theory here is that a staging resource will need to be transferred
into or out of a non-staging resource. If the staging resource is too
big for 1/2 aperture threshold, then it the corresponding non-stage
resource will be similiarly sized. This means there's no hope of fitting
both of them in.
This will cause the st blit transfer path to fall back and allow
max-texture-size to pass.
Fixes piglit max-texture-size
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14347>
Dave Airlie [Wed, 29 Dec 2021 07:32:12 +0000 (17:32 +1000)]
crocus: fail resource allocation properly.
Older gens have a limit of 2GB on surfaces, this results in
isl_surf_init_s failing if the surface exceeds that, in this
case this should fail all the way back up the stack.
This fixes some cases of max-texture-size on crocus
Fixes:
f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14347>
Dave Airlie [Thu, 30 Dec 2021 01:25:13 +0000 (11:25 +1000)]
intel/genxml/gen4-5: fix more Raster Operation in BLT to be a uint
This has been partly fixed twice before, but looks like some got missed.
Fixes arb_copy_image on gen4 with crocus
Fixes:
de625dddeea4 ("intel/genxml: fix raster operation field in blt genxml")
Acked-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14345>
Emma Anholt [Mon, 20 Dec 2021 23:21:14 +0000 (15:21 -0800)]
ci/i915g: Add a couple more recent regressions.
The new frontfacing one is just different UB for the same lack of
frontfacing support. And for RGB10_A2, we have another fail in that area
already as well.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14300>
Emma Anholt [Thu, 23 Dec 2021 17:15:27 +0000 (09:15 -0800)]
ci: Enable reporting to the flakes IRC channel for i915g and crocus.
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14300>
Emma Anholt [Thu, 23 Dec 2021 15:15:28 +0000 (07:15 -0800)]
ci/crocus: Add manual CI for the new HSW box I have at home.
Also extend the set of traces being tested and add more notes about them,
as well as add some g41 flakes since I did more runs.
Acked-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14300>
Eric Engestrom [Wed, 29 Dec 2021 21:51:22 +0000 (21:51 +0000)]
docs: update calendar and link releases notes for 21.3.3
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14341>
Eric Engestrom [Wed, 29 Dec 2021 21:00:13 +0000 (21:00 +0000)]
docs: add release notes for 21.3.3
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14341>
Filip Gawin [Tue, 21 Dec 2021 17:52:31 +0000 (18:52 +0100)]
r300: fix handling swizzle in transform_source_conflicts
these tests are now passing:
dEQP-GLES2.functional.shaders.operator.exponential.pow.highp_vec2_vertex,Fail
dEQP-GLES2.functional.shaders.operator.exponential.pow.highp_vec3_vertex,Fail
dEQP-GLES2.functional.shaders.operator.exponential.pow.highp_vec4_vertex,Fail
dEQP-GLES2.functional.shaders.operator.exponential.pow.mediump_vec2_vertex,Fail
dEQP-GLES2.functional.shaders.operator.exponential.pow.mediump_vec3_vertex,Fail
dEQP-GLES2.functional.shaders.operator.exponential.pow.mediump_vec4_vertex,Fail
Fixes:
1c2c4ddbd1e9 ("r300g: copy the compiler from r300c")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14282>
Pavel Ondračka [Wed, 29 Dec 2021 10:07:17 +0000 (11:07 +0100)]
r300: Replace RADEON_NO_TCL with RADEON_DEBUG=notcl
The old option was broken with shader cache.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14333>
Pavel Ondračka [Wed, 29 Dec 2021 10:04:51 +0000 (11:04 +0100)]
r300: Document the RADEON_DEBUG options
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14333>
Samuel Pitoiset [Wed, 29 Dec 2021 13:13:23 +0000 (14:13 +0100)]
radv: print number of levels with RADV_DEBUG=img
Might help debugging image related issues like DCC or HTILE.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14336>
Samuel Pitoiset [Wed, 29 Dec 2021 09:29:05 +0000 (10:29 +0100)]
radv: stop checking buffer size in vkCreateBuffer()
This was added to fix dEQP-VK.api.buffer.basic.size_max_uint64 but
with VK_KHR_maintenance4 this is now considered invalid usage.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14331>
Daniel Stone [Wed, 29 Dec 2021 13:48:03 +0000 (13:48 +0000)]
Revert "gitlab-ci: disable radv-fossils"
The fossils-db repository is fixed now.
This reverts commit
7b8ea3384832656e7db0e94692aca47f10083cce.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14337>
Eleni Maria Stea [Tue, 28 Dec 2021 13:52:44 +0000 (15:52 +0200)]
dri_drawable: missing header
dri_util.h must be included in dri_drawable.h for __DRI* types and
driDrawPriv to be defined.
Signed-off-by: Eleni Maria Stea <elene.mst@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14334>
Hamish Arblaster [Sun, 19 Dec 2021 00:10:11 +0000 (00:10 +0000)]
zink: Fix building on macOS
This fixes building on macOS:
Disable ZINK_USE_DMABUF on macOS, it is unsupported.
Import vk_mvk_moltenvk.h for MVK_VERSION in zink_resource.c.
Add additional build arguments (see meson.build) to build properly.
To build on macOS, you will probably need to run:
brew install bison llvm cmake libxext xquartz ninja xorgproto meson
And you also need to setup meson with something like:
-Dmoltenvk-dir=/Users/<Username>/VulkanSDK/<VersionNumber>/MoltenVK
-Dc_std=c11
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14255>
Lionel Landwerlin [Thu, 30 Jul 2020 12:56:14 +0000 (15:56 +0300)]
intel/devinfo: adjust subslice array size
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14324>
Nanley Chery [Mon, 26 Oct 2020 00:08:20 +0000 (17:08 -0700)]
iris: Use util packing fns in convert_clear_color
A couple things happen as a result of this:
1. This function is more consistent. It aims to clamp clear color ranges
to format-dependent values, but it didn't clamp the upper ranges of
10-bit and 11-bit floats (64512 and 65024 respectively). Those are
handled now.
2. The clear colors are quantized. The quantization method seems to
differ from what the HW uses for slow (and obviously fast) clears.
Due to this change in quantization method, iris starts failing
dEQP-EGL.functional.image.modify.renderbuffer_rgba4_renderbuffer_clear_color.
That's okay however. That test was removed from the mustpass list
because of threshold issues (see egl-test-issues.txt).
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7740>
Samuel Pitoiset [Thu, 16 Dec 2021 14:40:38 +0000 (15:40 +0100)]
radv: fix clears with value of "1" and different DCC signedness
For example, if the driver clears a view of SINT with 127 and the image
format is UNORM, the hw fills "1" instead of the clear value
(127.0f / 255.0f). This CB feature is GFX9+ only.
This should fix test_typed_srv_cast_clear from vkd3d-proton once it
correctly sets the MUTABLE flag (which is still buggy as of
c0a3fa8a).
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5676
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14228>
Georg Lehmann [Mon, 27 Dec 2021 13:36:27 +0000 (14:36 +0100)]
radv: Increase maxFragmentCombinedOutputResources.
This also includes storage images and storage buffers, not just color
attachments.
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14311>
Bas Nieuwenhuizen [Sat, 11 Dec 2021 18:44:53 +0000 (19:44 +0100)]
radv/amdgpu: Use VkResult for wait_timeline_syncobj.
So we can actually return errors.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14165>
Bas Nieuwenhuizen [Sun, 12 Dec 2021 00:01:55 +0000 (01:01 +0100)]
radv: Skip wait timeline ioctl with 0 handles.
Fixes:
55d8022878f "radv: Add winsys functions for timeline syncobj."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14165>
Bas Nieuwenhuizen [Fri, 17 Dec 2021 09:08:23 +0000 (10:08 +0100)]
radv: Use correct buffer size for query pool result copies.
1. the dst stride may be too small if count=1.
2. the src stride may be too small due to the availability bit.
So lets just compute the size needed explicitly and use it.
Fixes:
90a0556c ("radv: use pool stride when copying single query results")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14242>
Samuel Pitoiset [Tue, 28 Dec 2021 14:14:02 +0000 (15:14 +0100)]
radv: re-apply "Do not access set layout during vkCmdBindDescriptorSets."
Uplay needs this to avoid a crash because it does an use-after-free
of a descriptor set layout. This was initially introduced by Bas to
workaround a similar issue with Baldur's Gate 3, it seems needed again.
Cc: 21.3 mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5789
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14318>
Samuel Pitoiset [Mon, 29 Nov 2021 15:34:47 +0000 (16:34 +0100)]
radv: re-enable fast clears for images that support comp-to-single
This optimized path was disabled, oops.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14176>
Alyssa Rosenzweig [Mon, 6 Dec 2021 20:06:23 +0000 (15:06 -0500)]
panfrost: Make pan_merge macro more robust
Consider the following innocuous-looking code:
pan_merge(packed, vtx->attributes[i], ATTRIBUTE);
Under the current implementation, this code is completely broken. Why?
The current implemention is a macro which hardcodes the loop index i,
which shadows the i used to index attributes. Pull out a helper method
so we do the right thing without resulting to further preprocessor abuse
(__COUNTER__).
While making things more robust, assert the crucial pan_merge
invariant that the total size is a multiple of 4; if this fails, the
routine risks memory corruption.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14119>
Jason2013 [Mon, 13 Dec 2021 08:11:44 +0000 (08:11 +0000)]
Fix typo
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14169>
Samuel Pitoiset [Tue, 28 Dec 2021 09:38:41 +0000 (10:38 +0100)]
radv: fix restoring subpass during hw/fs color resolves
This fixes an stack-use-after-scope detect by ASAN because the
subpass is used after the loop by radv_mark_noncoherent_rb().
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14317>
Samuel Pitoiset [Wed, 15 Dec 2021 11:53:31 +0000 (12:53 +0100)]
radv/winsys: remove radv_amdgpu_winsys_bo::is_shared
This has never been used.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14287>
Samuel Pitoiset [Wed, 15 Dec 2021 11:49:04 +0000 (12:49 +0100)]
radv/winsys: stop zeroing few structs in buffer_from_fd()
Errors are correctly handled here.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14287>
Samuel Pitoiset [Wed, 15 Dec 2021 11:33:07 +0000 (12:33 +0100)]
radv: remove unnecessary NULL checks in vkMapMemory()/vkUnmapMemory()
It's required to have a valid device memory handle and it would make
no sense to call these functions with a NULL pointer.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14287>
Thomas H.P. Andersen [Tue, 28 Dec 2021 01:24:42 +0000 (02:24 +0100)]
tu/clear_blit: use || when working with bools
Fixes a warning with clang
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14315>
Jesse Natalie [Wed, 22 Dec 2021 02:22:50 +0000 (18:22 -0800)]
d3d12: Avoid a debug warning trying to unmap a not-mapped resource
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 00:25:01 +0000 (16:25 -0800)]
d3d12: Set SSBO support caps
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 19:54:40 +0000 (11:54 -0800)]
d3d12: Use DXIL load/store lowering pass
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 00:24:55 +0000 (16:24 -0800)]
d3d12: Support setting SSBOs on the context and turning them into descriptors
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 00:23:36 +0000 (16:23 -0800)]
d3d12: Always create buffers as UAV-capable
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 00:14:41 +0000 (16:14 -0800)]
d3d12: Support SSBOs in root signatures
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 19:51:49 +0000 (11:51 -0800)]
microsoft/compiler: Handle write masks in SSBO lowering pass
Previously, the lowering was for 8/16/64-bit values, or 8/16-component
vectors. Now, it also handles write masks on 32-bit 1/2/3/4-component
vectors.
DXIL looks like it supports putting an interesting write mask in the
buffer store intrinsic, but DXC never generates stores with write
masks, and multiple drivers completely ignore the write mask.
Also, set the write mask properly on the output intrinsic.
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 02:15:29 +0000 (18:15 -0800)]
microsoft/compiler: Hook up uavs-at-every-stage flag
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Jesse Natalie [Wed, 22 Dec 2021 00:13:45 +0000 (16:13 -0800)]
microsoft/compiler: Emit SSBOs from 0 -> count for GL (non-kernel, non-Vulkan) shaders
Reviewed-by: Sil Vilerino <sivileri@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14294>
Lionel Landwerlin [Mon, 27 Dec 2021 21:59:08 +0000 (23:59 +0200)]
gitlab-ci: disable radv-fossils
For some reason CI is unable to pull a git repo needed to run this.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14312>
Jesse Natalie [Mon, 27 Dec 2021 19:10:26 +0000 (11:10 -0800)]
CI: Trigger Windows build on softpipe changes
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14312>
Jesse Natalie [Mon, 27 Dec 2021 19:09:05 +0000 (11:09 -0800)]
softpipe: Add a dummy field to sp_fragment_shader_variant_key
MSVC doesn't support 0-size structs in C.
Fixes:
0b7a0d1a ("softpipe: Use the draw module's poly stipple handling, like llvmpipe.")
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14312>
Emma Anholt [Sun, 26 Dec 2021 19:44:05 +0000 (11:44 -0800)]
softpipe: Drop duplicate decl of softpipe_find_fs_variant
Reviewed-by: Zoltán Böszőrményi <zboszor@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13731>
Emma Anholt [Tue, 21 Dec 2021 23:31:36 +0000 (15:31 -0800)]
softpipe: Use the draw module's poly stipple handling, like llvmpipe.
softpipe was using the draw helper module as a testbed for the draw helper
module long ago, but we can just use the finished product.
Reviewed-by: Zoltán Böszőrményi <zboszor@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13731>
Emma Anholt [Tue, 21 Dec 2021 23:25:23 +0000 (15:25 -0800)]
softpipe: Drop the quad pstipple stage.
It's unused, and it doesn't have the information it needs ("what is the
prim type after poly fill mode but without considering
wide point/line-to-triangle conversion) to stipple correctly.
Reviewed-by: Zoltán Böszőrményi <zboszor@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13731>
Vinson Lee [Mon, 20 Dec 2021 03:10:21 +0000 (19:10 -0800)]
radv: Fix memory leak on error path.
Fix defects reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable signal_semaphore_infos going out of scope leaks the storage it points to
leaked_storage: Variable wait_semaphore_infos going out of scope leaks the storage it points to.
Fixes:
3da7d10d9bb ("radv: implement vkQueueSubmit2KHR()")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14260>
Dave Airlie [Mon, 20 Dec 2021 03:23:41 +0000 (13:23 +1000)]
mesa/st: remove conditionals for driver state bits that are always set.
Just removes some conditional checks that never work out now.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 03:11:52 +0000 (13:11 +1000)]
mesa/st: drop multisample mask/locations state drivers bits
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 03:08:16 +0000 (13:08 +1000)]
mesa/st: drop new framebuffer srgb driver state bit
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 03:07:08 +0000 (13:07 +1000)]
mesa/st: drop clip plane driver state bits
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 03:03:42 +0000 (13:03 +1000)]
mesa/st: drop scissor/window rect driver state bits
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:56:03 +0000 (12:56 +1000)]
mesa/st: drop ssbo, image and sampler driver state flags bits
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:49:47 +0000 (12:49 +1000)]
mesa: drop unused transform feedback state driver flags
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:47:12 +0000 (12:47 +1000)]
mesa/st: drop new uniform driver state bit
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:44:59 +0000 (12:44 +1000)]
mesa/st: drop new tess state driver bit
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:43:37 +0000 (12:43 +1000)]
mesa/st: drop poly stipple driver state bit
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:38:18 +0000 (12:38 +1000)]
mesa/st: drop new depth/stencil state bits
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:34:46 +0000 (12:34 +1000)]
mesa/st: drop NewBlend driver state flags
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:23:04 +0000 (12:23 +1000)]
mesa/st: remove the viewport driver state flags
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:20:42 +0000 (12:20 +1000)]
mesa/st: drop the rasterizer driver flags
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:16:34 +0000 (12:16 +1000)]
mesa/st: drop the new array driver state bit
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 02:13:40 +0000 (12:13 +1000)]
mesa/st: merge NewDepthClamp state flag
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 01:31:31 +0000 (11:31 +1000)]
mesa: drop optional tex/tnl maintains mode.
These are always going to be on with gallium
v2: drop call, tidy up switch (kwg)
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 01:27:23 +0000 (11:27 +1000)]
mesa/st: move default enabled extensions into mesa.
This just moves a bunch of true assignments into the core
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 01:21:33 +0000 (11:21 +1000)]
mesa/draw: drop the multi draw with indices fallback.
Gallium drivers don't need this.
v2: drop some more code
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Dave Airlie [Mon, 20 Dec 2021 00:55:57 +0000 (10:55 +1000)]
mesa: remove StripTextureBorder option.
Always make this true.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14261>
Thomas H.P. Andersen [Wed, 22 Dec 2021 10:28:46 +0000 (11:28 +0100)]
ci: debian-clang: build more drivers
Add gallium drivers: i915 + asahi
Add vulkan drivers: swrast + panfrost
These can now compile with the current no-error list
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14289>
Thomas H.P. Andersen [Thu, 23 Dec 2021 15:15:00 +0000 (16:15 +0100)]
panvk: cast negative value to unint8_t
The index is a uint8_t but can be assigned a negative 1
value in panvk_pipeline_builder_parse_color_blend()
The comparison to ~0 thus makes sense but clang will complain:
"result of comparison of constant -1 with expression of type
'const uint8_t' (aka 'const unsigned char') is always true
[-Wtautological-constant-out-of-range-compare]"
Fix this by casting to a uint8_t before comparison.
Fixes a warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14289>
Thomas H.P. Andersen [Wed, 22 Dec 2021 01:07:02 +0000 (02:07 +0100)]
panvk: use FALLTHROUGH to stop a warning
Fixes a warning with clang
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14289>
Thomas H.P. Andersen [Wed, 22 Dec 2021 01:08:08 +0000 (02:08 +0100)]
i915g: avoid left shifting a negative number
Fixes a warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14289>
Thomas H.P. Andersen [Wed, 22 Dec 2021 10:29:40 +0000 (11:29 +0100)]
lavapipe: fix string-plus-int warning
Fixes a warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14289>
Alyssa Rosenzweig [Wed, 16 Jun 2021 20:27:04 +0000 (16:27 -0400)]
pan/bi: Don't call useless NIR passes
Cargo culted from the Midgard compiler.
nir_move_vec_src_uses_to_dest is intended for vec4 backends, which does
not apply to Bifrost. nir_lower_locals_to_regs runs much earlier in the
compiler and is a no-op here.
total instructions in shared programs: 107252 -> 107242 (<.01%)
instructions in affected programs: 2403 -> 2393 (-0.42%)
helped: 10
HURT: 0
helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1
helped stats (rel) min: 0.33% max: 0.57% x̄: 0.43% x̃: 0.42%
95% mean confidence interval for instructions value: -1.00 -1.00
95% mean confidence interval for instructions %-change: -0.49% -0.37%
Instructions are helped.
total tuples in shared programs: 89664 -> 89664 (0.00%)
tuples in affected programs: 333 -> 333 (0.00%)
helped: 1
HURT: 1
helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1
helped stats (rel) min: 0.52% max: 0.52% x̄: 0.52% x̃: 0.52%
HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1
HURT stats (rel) min: 0.70% max: 0.70% x̄: 0.70% x̃: 0.70%
total cycles in shared programs: 8103.88 -> 8103.79 (<.01%)
cycles in affected programs: 29.42 -> 29.33 (-0.28%)
helped: 3
HURT: 1
helped stats (abs) min: 0.
041665999999999315 max: 0.
04166700000000034 x̄:
0.04 x̃: 0
helped stats (rel) min: 0.49% max: 0.55% x̄: 0.53% x̃: 0.54%
HURT stats (abs) min: 0.
04166700000000034 max: 0.
04166700000000034 x̄:
0.04 x̃: 0
HURT stats (rel) min: 0.74% max: 0.74% x̄: 0.74% x̃: 0.74%
95% mean confidence interval for cycles value: -0.09 0.05
95% mean confidence interval for cycles %-change: -1.22% 0.80%
Inconclusive result (value mean confidence interval includes 0).
total arith in shared programs: 3376.42 -> 3376.33 (<.01%)
arith in affected programs: 29.42 -> 29.33 (-0.28%)
helped: 3
HURT: 1
helped stats (abs) min: 0.
041665999999999315 max: 0.
04166700000000034 x̄:
0.04 x̃: 0
helped stats (rel) min: 0.49% max: 0.55% x̄: 0.53% x̃: 0.54%
HURT stats (abs) min: 0.
04166700000000034 max: 0.
04166700000000034 x̄:
0.04 x̃: 0
HURT stats (rel) min: 0.74% max: 0.74% x̄: 0.74% x̃: 0.74%
95% mean confidence interval for arith value: -0.09 0.05
95% mean confidence interval for arith %-change: -1.22% 0.80%
Inconclusive result (value mean confidence interval includes 0).
total quadwords in shared programs: 79681 -> 79681 (0.00%)
quadwords in affected programs: 283 -> 283 (0.00%)
helped: 1
HURT: 1
helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1
helped stats (rel) min: 0.62% max: 0.62% x̄: 0.62% x̃: 0.62%
HURT stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1
HURT stats (rel) min: 0.82% max: 0.82% x̄: 0.82% x̃: 0.82%
total threads in shared programs: 2226 -> 2227 (0.04%)
threads in affected programs: 1 -> 2 (100.00%)
helped: 1
HURT: 0
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14293>
Emma Anholt [Wed, 15 Dec 2021 23:01:17 +0000 (15:01 -0800)]
glcpp: Disable the valgrind tests.
We have the glcpp unit tests covered with ASan and MSan in CI, no need to
make everyone doing a "meson test" suffer through valgrind slowly churning
through these.
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14236>
Emma Anholt [Fri, 17 Dec 2021 18:25:36 +0000 (10:25 -0800)]
ci: Enable a build with MSan.
This will catch uninitialized data usage (such as
37855fd59d18 ("glcpp:
Fully initialize struct gl_context")) much faster than valgrind does.
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14236>
Vinson Lee [Mon, 20 Dec 2021 02:25:33 +0000 (18:25 -0800)]
isaspec: Sort field names to generate deterministic output.
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Acked-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14259>
Thomas H.P. Andersen [Wed, 22 Dec 2021 13:16:31 +0000 (14:16 +0100)]
microsoft/compiler: dxil_nir_opt_alu_deref_srcs: return progress
dxil_nir_opt_alu_deref_srcs will always return false because
the progress variable is declared both for the function and also
inside the loop.
Spotted by a unused-but-set-variable warning from clang
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14290>
Alyssa Rosenzweig [Wed, 22 Dec 2021 17:47:19 +0000 (12:47 -0500)]
pan/va: Generalize LD_VAR_IMM_* to support flat varyings
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292>
Alyssa Rosenzweig [Wed, 22 Dec 2021 17:14:59 +0000 (12:14 -0500)]
pan/va: Add .signed bit to right shift instructions
This makes the RSHIFT_* family of instructions act like ARSHIFT.* on
Bifrost.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292>
Alyssa Rosenzweig [Wed, 8 Dec 2021 00:02:50 +0000 (19:02 -0500)]
pan/va: Rename LEA_ATTR to LEA_VARY
This more accurately reflects the function of the instruction. Unlike
earlier Malis, there don't seem to be attribute records for varyings.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292>
Alyssa Rosenzweig [Tue, 7 Dec 2021 23:56:49 +0000 (18:56 -0500)]
pan/va: Remove extra LD_VAR_IMM_F32 source
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14292>
Dave Airlie [Wed, 15 Dec 2021 00:29:31 +0000 (10:29 +1000)]
intel/compiler: drop unused decleration
Acked-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14202>
Dave Airlie [Wed, 15 Dec 2021 00:22:50 +0000 (10:22 +1000)]
intel/compiler: don't lower swizzles in backend.
These are lowered by crocus in the frontend, the key
entries are still used.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14202>
Dave Airlie [Wed, 15 Dec 2021 00:21:46 +0000 (10:21 +1000)]
intel/compiler: remove gfx6 gather wa from backend.
Crocus lowers this in the frontend, they key member is still used
but reset prior to backend.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14202>
Dave Airlie [Wed, 22 Dec 2021 07:08:12 +0000 (17:08 +1000)]
mesa/dd: drop unused InvalidateBufferSubData entry.
I already removed the users of this, but forgot the entry.
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286>
Dave Airlie [Wed, 22 Dec 2021 07:07:28 +0000 (17:07 +1000)]
mesa: drop unused _mesa_new_program.
This isn't used since classic removal.
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286>
Dave Airlie [Wed, 22 Dec 2021 07:06:12 +0000 (17:06 +1000)]
mesa: drop unused new renderbuffer code.
This isn't used anywhere currently
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286>
Dave Airlie [Wed, 22 Dec 2021 07:05:09 +0000 (17:05 +1000)]
mesa/st: use has_stencil_export instead of querying screen cap.
We already query at context setup, just use that value.
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286>
Dave Airlie [Wed, 22 Dec 2021 06:58:45 +0000 (16:58 +1000)]
mesa: drop texformat code this isn't used.
v2: dropped comment (Tapani)
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14286>