platform/upstream/dotnet/runtime.git
6 years agoAdd coverlet runtime deps to testhost shared runtime (dotnet/corefx#31209)
Paulo Janotti [Thu, 19 Jul 2018 23:26:49 +0000 (16:26 -0700)]
Add coverlet runtime deps to testhost shared runtime (dotnet/corefx#31209)

Commit migrated from https://github.com/dotnet/corefx/commit/8dfc18ef68c455660823cc3c78753e03d95a9fb3

6 years agoUpdate Common.Tests.sln file for new SDK project changes. (dotnet/corefx#31205)
Eric Erhardt [Thu, 19 Jul 2018 22:21:51 +0000 (17:21 -0500)]
Update Common.Tests.sln file for new SDK project changes. (dotnet/corefx#31205)

Commit migrated from https://github.com/dotnet/corefx/commit/1739a03a89665afeb2facf2e2ef70771e7c9b9d6

6 years agoPorting X509Certificate2UI to .Net Core (dotnet/corefx#31111)
Anirudh Agnihotry [Thu, 19 Jul 2018 18:48:43 +0000 (11:48 -0700)]
Porting X509Certificate2UI to .Net Core (dotnet/corefx#31111)

* Ref build Successful

* Basic tests proj added

* src build Successful

* Moved from framework

* Moved handles

* build successful

* build successful

* strings added and build fixed

* Interop guidelines followed

* ref and src build properly

* BasicTests

* minor changes

* namespace name change

* Feedback addressed

* fixing reference build

* name of function changed and using using statement

* changing parameter to X509Certificate2

Commit migrated from https://github.com/dotnet/corefx/commit/a6159bb0929b5eb8b297a9a8ebba595d5f3a9bb0

6 years agoAdd back TypeBuilder.DefinePInvokeMethod (dotnet/corefx#31096)
Atsushi Kanamori [Thu, 19 Jul 2018 18:47:00 +0000 (11:47 -0700)]
Add back TypeBuilder.DefinePInvokeMethod (dotnet/corefx#31096)

* Add back TypeBuilder.DefinePInvokeMethod

https://github.com/dotnet/corefx/issues/30355

* Fix UAPAOT build

* Fix packaging build

* Remove S.R.I reference

Commit migrated from https://github.com/dotnet/corefx/commit/c454d79db0dd8ef49135d38c0825a532f39e357d

6 years agoCleanup and add more Marshal.StringTo tests (dotnet/corefx#31150)
Hugh Bellamy [Thu, 19 Jul 2018 16:41:25 +0000 (17:41 +0100)]
Cleanup and add more Marshal.StringTo tests (dotnet/corefx#31150)

* Cleanup and add more Marshal.StringTo tests

* Remove blank lines

Commit migrated from https://github.com/dotnet/corefx/commit/ce37aae38fdf2c74512569856401c568f959bb09

6 years agoDefault generatedefaultsource to true (dotnet/corefx#31161)
Dan Seefeldt [Thu, 19 Jul 2018 16:38:27 +0000 (11:38 -0500)]
Default generatedefaultsource to true (dotnet/corefx#31161)

* Default generatedefaultsource to true

* Change option to skip versiongeneration for bootstrap script.

Commit migrated from https://github.com/dotnet/corefx/commit/9dfcd8fb53dd0e388a81e328b55f68409c7333ad

6 years agoPort System.Drawing.Design members needed by winforms (dotnet/corefx#31110)
Santiago Fernandez Madero [Thu, 19 Jul 2018 16:26:39 +0000 (09:26 -0700)]
Port System.Drawing.Design members needed by winforms (dotnet/corefx#31110)

* Port System.Drawing.Design members needed by winforms

* Add a few tests and fix configurations to only support netcoreapp

* PR Feedback

* Add more tests, rename and condition tests to gdiplusavailable

* Fix perf tests build error

Commit migrated from https://github.com/dotnet/corefx/commit/8d6f4d1e9bfde867e2c862977b651d80feddb66a

6 years agoAdd coverlet.msbuild package for experiments (dotnet/corefx#31171)
Paulo Janotti [Thu, 19 Jul 2018 15:21:20 +0000 (08:21 -0700)]
Add coverlet.msbuild package for experiments (dotnet/corefx#31171)

Commit migrated from https://github.com/dotnet/corefx/commit/9e3d0618bc4aff22e7a77ffb3e1e1ecfe5a1f392

6 years agoAdd even more integer parsing tests (dotnet/corefx#31089)
Stephen Toub [Thu, 19 Jul 2018 14:12:50 +0000 (07:12 -0700)]
Add even more integer parsing tests (dotnet/corefx#31089)

* Add more integer parsing tests

In particular to improve UInt32/UInt64 coverage and to reuse more Int32 tests for other types.

* Fix test

Commit migrated from https://github.com/dotnet/corefx/commit/0d6c1088eb5cb1a20caebf2dcf4295c2a641ee66

6 years agoUpdate .NET SDK link (dotnet/corefx#30703)
Marco Rossignoli [Thu, 19 Jul 2018 13:46:36 +0000 (15:46 +0200)]
Update .NET SDK link  (dotnet/corefx#30703)

* update .NET SDK link

* Update benchmarking.md

update link

Commit migrated from https://github.com/dotnet/corefx/commit/8d24439634a491cce36545adb5f0a424dd2fe6d1

6 years agoAdd command line install (dotnet/corefx#29154)
Dan Friedman [Thu, 19 Jul 2018 12:48:49 +0000 (07:48 -0500)]
Add command line install (dotnet/corefx#29154)

Commit migrated from https://github.com/dotnet/corefx/commit/4469b2037f24c5a06a1837c90509864d0feaeb93

6 years agoFilter binplacepackage depproj's to only direct reference (dotnet/corefx#31167)
Wes Haggard [Thu, 19 Jul 2018 06:59:38 +0000 (23:59 -0700)]
Filter binplacepackage depproj's to only direct reference (dotnet/corefx#31167)

Don't copy out the full closure of all packages for binplacePackages.

Commit migrated from https://github.com/dotnet/corefx/commit/eb41cd4480f831de784666ad63acb9f2088fd97c

6 years agoMerge pull request dotnet/corefx#31175 from dotnet-maestro-bot/master-UpdateDependencies
Stephen Toub [Thu, 19 Jul 2018 04:13:12 +0000 (21:13 -0700)]
Merge pull request dotnet/corefx#31175 from dotnet-maestro-bot/master-UpdateDependencies

Update CoreClr, CoreFx, CoreSetup, ProjectNTfs to preview1-26719-01, preview1-26717-04, preview1-26718-04, beta-26718-00, respectively (master)

Commit migrated from https://github.com/dotnet/corefx/commit/156aebead70e4950f08463d047b548620d5921b6

6 years agosupport for correct Tools on Linux/ARM (dotnet/corefx#31160)
Tomas Weinfurt [Thu, 19 Jul 2018 04:11:26 +0000 (21:11 -0700)]
support for correct Tools on Linux/ARM (dotnet/corefx#31160)

Commit migrated from https://github.com/dotnet/corefx/commit/a53adfc55bcb028d36a8647e45c66f7be5374f92

6 years agoRevert ProjectNtfs update
Stephen Toub [Thu, 19 Jul 2018 02:52:03 +0000 (19:52 -0700)]
Revert ProjectNtfs update

Commit migrated from https://github.com/dotnet/corefx/commit/3ab406c043410715d1fee8f8ab119c13ffc91bb0

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs to preview1-26719-01, preview1-26717...
dotnet-maestro-bot [Thu, 19 Jul 2018 02:16:58 +0000 (19:16 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs to preview1-26719-01, preview1-26717-04, preview1-26718-04, beta-26718-00, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/04f92159cc494feb1ce1a0510ef78d54b7607b37

6 years agoAdd more TimeSpan formatting tests (dotnet/corefx#31157)
Stephen Toub [Wed, 18 Jul 2018 19:17:04 +0000 (12:17 -0700)]
Add more TimeSpan formatting tests (dotnet/corefx#31157)

* Add more TimeSpan formatting tests

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/84d044411b400044f75ee90c744a7f9bd6e4fe1d

6 years agoPkcs9SigningTime: normalize exception on time < 1601
Maxim Lipnin [Wed, 18 Jul 2018 17:59:51 +0000 (20:59 +0300)]
Pkcs9SigningTime: normalize exception on time < 1601

Make Pkcs9SigningTime throw CryptographicException for all times which cannot be encoded.

In .NET Framework (and prior versions of .NET Core) an ArgumentException is thrown for values which cannot be expressed as a FILETIME value, and a CryptographicException for dates in [1601, 1949] and [2050, ...)

Commit migrated from https://github.com/dotnet/corefx/commit/826f821eab39f6fd6140a44f1511543fdf35f4f1

6 years agoAdd more Type tests (dotnet/corefx#31013)
Hugh Bellamy [Wed, 18 Jul 2018 17:48:13 +0000 (18:48 +0100)]
Add more Type tests (dotnet/corefx#31013)

* Remove duplicate tests

* Consolidate TimeZoneInfo tests to a single file

* Add more Type tests

Commit migrated from https://github.com/dotnet/corefx/commit/713d74bdafbf585b8cda8ed08fbdfd3c81707f2d

6 years agoMerge pull request dotnet/corefx#31137 from weshaggard/GenerateVersionPropsForSync-m
Wes Haggard [Wed, 18 Jul 2018 17:08:59 +0000 (10:08 -0700)]
Merge pull request dotnet/corefx#31137 from weshaggard/GenerateVersionPropsForSync-m

Ensure we generate version prop before sync parallel build

Commit migrated from https://github.com/dotnet/corefx/commit/20ac3b14daf406a98a8a4966ce12c04c9d566cc0

6 years agoGet rid of DoubleHelper in Number.FormatAndParse.cs (dotnet/corefx#30965)
Egor Bogatov [Wed, 18 Jul 2018 10:12:51 +0000 (13:12 +0300)]
Get rid of DoubleHelper in Number.FormatAndParse.cs (dotnet/corefx#30965)

Commit migrated from https://github.com/dotnet/corefx/commit/bcc5fdf2c45ddb66b40a8b028ffee411ca9e28e3

6 years agoFix RD.XML for System.Private.Xml (dotnet/corefx#31125)
Michal Strehovský [Wed, 18 Jul 2018 07:18:53 +0000 (09:18 +0200)]
Fix RD.XML for System.Private.Xml (dotnet/corefx#31125)

This corrects the size on disk regression caused by dotnet/corefx#19912. After that pull request, all of the schema validation stuff would always be included for any app that depends on System.Private.Xml because during initial analysis we consider a lot of things in S.P.Xml necessary as a precaution for SG generating references to it. The RD.XML in S.P.Xml then roots things forever.

I spent some time getting a repro of the original failure and convinced myself this is not a scenario that would require RD.XML in the S.P.Xml assembly.

Here's the facts:
* This test uses a test hook to explicitly disable pregenerated serialization code for `XmlSchema`. (https://github.com/dotnet/corefx/blob/dotnet/corefx@1afc5360013bedc4099875c836342f493b083e5f/src/System.Private.Xml/src/System/Xml/Schema/XmlSchema.cs#L175 that is on stack at the time of failure is an analysis slam dunk, so we do have pregenerated code, we just don't use it because of the hook)
* The test is then testing the reflection fallback path to serialize `XmlSchema`. This doesn't work. Reflection fallback path won't in general work for _any framework provided type_ because there's no RD.XML to root it. Reflection fallback really only works for user types because of our default RD.XML that roots all user types (we also use that for the CoreFX tests, which is why the other reflection fallback tests don't hit issues).

Commit migrated from https://github.com/dotnet/corefx/commit/6867b6fc9327d2f9c3e36dd5889a0eb9c3991da5

6 years agoMerge pull request dotnet/corefx#30740 from geoffkizer/http2
Geoff Kizer [Wed, 18 Jul 2018 04:04:39 +0000 (21:04 -0700)]
Merge pull request dotnet/corefx#30740 from geoffkizer/http2

SocketsHttpHandler: Initial cut at HTTP2 support

Commit migrated from https://github.com/dotnet/corefx/commit/a3021f143b762006a7e19ad11785ca0c3c454933

6 years agoMitigate exception ambiguity in Marshal test (dotnet/corefx#31136)
Aaron Robinson [Wed, 18 Jul 2018 03:55:32 +0000 (20:55 -0700)]
Mitigate exception ambiguity in Marshal test (dotnet/corefx#31136)

Address issue 30866
Remove the special case of expecting a COMException when the argument
is non-empty or null for Marshal.BindToMoniker() tests.

Commit migrated from https://github.com/dotnet/corefx/commit/a754a612eed6d16b52d7f75c602f71eb367760ae

6 years agoSystem.IO.Pipes: Add additional Create overloads for Mono (dotnet/corefx#31118)
Filip Navara [Wed, 18 Jul 2018 03:46:58 +0000 (05:46 +0200)]
System.IO.Pipes: Add additional Create overloads for Mono (dotnet/corefx#31118)

* Add additional Create overloads in NamedPipeServerStream.Windows.cs and AnonymousPipeServerStream.Windows.cs to make code sharing in Mono easier.

* Add comments to Create methods about their usage in Mono. Replace if condition by an Assert.

Commit migrated from https://github.com/dotnet/corefx/commit/f252b5a964f6fd34b280be767518d989f4c2766f

6 years agoAdd information about collecting memory usage (dotnet/corefx#31141)
Jeremy Kuhne [Wed, 18 Jul 2018 03:07:10 +0000 (20:07 -0700)]
Add information about collecting memory usage (dotnet/corefx#31141)

Commit migrated from https://github.com/dotnet/corefx/commit/653d41fb63152ed920b516b3706cd42b1275b474

6 years agoFix Sync targets to not actually cause a build to occur as well
Wes Haggard [Tue, 17 Jul 2018 23:29:32 +0000 (16:29 -0700)]
Fix Sync targets to not actually cause a build to occur as well

The TraversalBuildDependsOn gets other things added to it like
BuildAllProjects which we don't want for the Sync target so
factoring out the common pre-steps and sharing just those
with sync and build.

Commit migrated from https://github.com/dotnet/corefx/commit/8a007546ca2b73faadf6d717d45e3d10d5a35336

6 years agoEnsure we generate version prop before sync parallel build
Wes Haggard [Mon, 16 Jul 2018 16:18:45 +0000 (09:18 -0700)]
Ensure we generate version prop before sync parallel build

We need to generate the buildversion props file before we start
a parallel build otherwise we race condition that can break
the build.

Commit migrated from https://github.com/dotnet/corefx/commit/984131abff78a8eef0d99a19a3ccb925fe102fbc

6 years agoUpdate System.Memory as inbox & expose LastIndexOf (dotnet/corefx#30897)
Viktor Hofer [Tue, 17 Jul 2018 20:58:37 +0000 (22:58 +0200)]
Update System.Memory as inbox & expose LastIndexOf (dotnet/corefx#30897)

* Remove netstandard configurations from System.Memory

* Binplace harvested System.Memory

* Update packageIndex.json versions

* Replace some wrongly copied IndexOf calls

Commit migrated from https://github.com/dotnet/corefx/commit/56dfb8834fa50f3bc61ea9b4bfdc9dcc759b6ec9

6 years agoAdd Unsafe.Unbox (dotnet/corefx#31133)
Stephen Toub [Tue, 17 Jul 2018 20:46:50 +0000 (13:46 -0700)]
Add Unsafe.Unbox (dotnet/corefx#31133)

Commit migrated from https://github.com/dotnet/corefx/commit/64c6d9fe5409be14bdc3609d73ffb3fea1f35797

6 years agoaddress review feedback
Geoff Kizer [Tue, 17 Jul 2018 18:42:14 +0000 (11:42 -0700)]
address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/04928d2ddedc8e9f62345b8725870f86a559e862

6 years agorename ArrayBuffer stuff
Geoff Kizer [Fri, 6 Jul 2018 20:24:06 +0000 (13:24 -0700)]
rename ArrayBuffer stuff

Commit migrated from https://github.com/dotnet/corefx/commit/1a4574f26f513eeb8428e4bc56c8f7aed485d290

6 years agoimprove RST_STREAM handling
Geoff Kizer [Fri, 6 Jul 2018 20:16:41 +0000 (13:16 -0700)]
improve RST_STREAM handling

Commit migrated from https://github.com/dotnet/corefx/commit/f9b961b5082ad402ddc02259211363f58070cfa2

6 years agorework request header framing and several other fixes
Geoff Kizer [Wed, 4 Jul 2018 22:46:34 +0000 (15:46 -0700)]
rework request header framing and several other fixes

cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/3134237aafbc598e69b23be29e3442ebe9795e70

6 years agodon't include for UWP
Geoff Kizer [Tue, 3 Jul 2018 18:48:24 +0000 (11:48 -0700)]
don't include for UWP

Commit migrated from https://github.com/dotnet/corefx/commit/eafe860028c637e19bb7acef284a7ccc82ca6de1

6 years agoadd connection shutdown handling
Geoff Kizer [Mon, 2 Jul 2018 21:21:22 +0000 (14:21 -0700)]
add connection shutdown handling

Commit migrated from https://github.com/dotnet/corefx/commit/a3603a36a1a54373215cc3770c9ddf1fc13f7e62

6 years agomore review feedback
Geoff Kizer [Mon, 2 Jul 2018 19:00:24 +0000 (12:00 -0700)]
more review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/50efe7a7e32f84df02681e5e53633804ac57bba7

6 years agoimplement client-initiated connection shutdown
Geoff Kizer [Sun, 1 Jul 2018 02:19:42 +0000 (19:19 -0700)]
implement client-initiated connection shutdown

Commit migrated from https://github.com/dotnet/corefx/commit/98f2f66b69619c9aa797da39c6a17de9e89ccbda

6 years agomore review feedback
Geoff Kizer [Sun, 1 Jul 2018 00:55:22 +0000 (17:55 -0700)]
more review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/a4299d90628458ca5d6c0ec7ea5dc093ff76cbc3

6 years agoaddress review feedback for HPACK implementation
Geoff Kizer [Sat, 30 Jun 2018 18:34:36 +0000 (11:34 -0700)]
address review feedback for HPACK implementation

Commit migrated from https://github.com/dotnet/corefx/commit/7ab4c60111ef3bc18aaec6d83fc8940b3c254e0f

6 years agoaddress review feedback
Geoff Kizer [Sat, 30 Jun 2018 17:27:06 +0000 (10:27 -0700)]
address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3cd5cb3fbb72180dd7534112433a939594105cfc

6 years agoclean up Http2ReadStream stuff
Geoff Kizer [Fri, 29 Jun 2018 04:34:55 +0000 (21:34 -0700)]
clean up Http2ReadStream stuff

Commit migrated from https://github.com/dotnet/corefx/commit/dd2f48896a3998f851f0d008dcbed59092c59a5f

6 years agorework EmptyReadStream to not be HttpConnection-specific
Geoff Kizer [Fri, 29 Jun 2018 04:39:00 +0000 (21:39 -0700)]
rework EmptyReadStream to not be HttpConnection-specific

Commit migrated from https://github.com/dotnet/corefx/commit/71b2a178a2b96f964bbd045cf2b013c23b5b5468

6 years agoadd BaseAsyncStream and refactor stream classes to derive from this
Geoff Kizer [Thu, 28 Jun 2018 21:30:27 +0000 (14:30 -0700)]
add BaseAsyncStream and refactor stream classes to derive from this

Commit migrated from https://github.com/dotnet/corefx/commit/6a4579428ebcceb1783a2e86aced7fb81fc51a01

6 years agoinitial cut at HTTP2 support for SocketsHttpHandler
Geoff Kizer [Thu, 1 Mar 2018 22:58:33 +0000 (14:58 -0800)]
initial cut at HTTP2 support for SocketsHttpHandler

Commit migrated from https://github.com/dotnet/corefx/commit/2b208a5fa5bea539c519fd432e926f8d613af666

6 years agoadd HttpConnectionBase and refactor some connection logic, in preparation for HTTP2...
Geoff Kizer [Wed, 25 Apr 2018 10:12:42 +0000 (03:12 -0700)]
add HttpConnectionBase and refactor some connection logic, in preparation for HTTP2 support

Commit migrated from https://github.com/dotnet/corefx/commit/8595970e24d5f52c0777ef2b4a5f0d88397fe7bb

6 years agoAdd some hex parsing perf tests (dotnet/corefx#31115)
Stephen Toub [Tue, 17 Jul 2018 08:42:46 +0000 (01:42 -0700)]
Add some hex parsing perf tests (dotnet/corefx#31115)

Commit migrated from https://github.com/dotnet/corefx/commit/1afc5360013bedc4099875c836342f493b083e5f

6 years agoRemove char[] allocation from GetDrives (dotnet/corefx#31114)
Stephen Toub [Tue, 17 Jul 2018 08:40:32 +0000 (01:40 -0700)]
Remove char[] allocation from GetDrives (dotnet/corefx#31114)

Commit migrated from https://github.com/dotnet/corefx/commit/eeeda65cd477a9a51ea9b33b19f4f166e9a68ad6

6 years agoPort some missing methods from the Strings class (dotnet/corefx#31086)
Dan Moseley [Tue, 17 Jul 2018 05:39:17 +0000 (22:39 -0700)]
Port some missing methods from the Strings class (dotnet/corefx#31086)

* building

* Asc, Chr tests

* Trim tests

* Remaining tests

* Fix test param names

* Fix netfx tests

* Spacing

Commit migrated from https://github.com/dotnet/corefx/commit/5a6f230836006184c923b8c0e38631225c172e33

6 years agoTemporarily comment out dictionary remove modification tests (dotnet/corefx#31113)
Stephen Toub [Tue, 17 Jul 2018 05:10:08 +0000 (22:10 -0700)]
Temporarily comment out dictionary remove modification tests (dotnet/corefx#31113)

Commit migrated from https://github.com/dotnet/corefx/commit/9e21bd93f338887bc4157e878599562b897d564d

6 years agoDisable GetNativeVariantForObject() API tests when targeting UAP (dotnet/corefx#31109)
Aaron Robinson [Tue, 17 Jul 2018 03:32:07 +0000 (20:32 -0700)]
Disable GetNativeVariantForObject() API tests when targeting UAP (dotnet/corefx#31109)

Commit migrated from https://github.com/dotnet/corefx/commit/2f68aea299c6b79cf78e74f7202aa6409e17c068

6 years agoFix HttpWebRequest when using system proxy settings (dotnet/corefx#31100)
David Shulman [Tue, 17 Jul 2018 02:51:03 +0000 (19:51 -0700)]
Fix HttpWebRequest when using system proxy settings (dotnet/corefx#31100)

While investigating other HttpClient/HttpWebRequest proxy-related bugs, I discovered that
HttpWebRequest was not honoring system proxy settings as defined on Windows with IE
settings or on Linux using environment variables.

The problem is due to how HttpClient and HttpWebRequest differ in how they represent
the default behavior of using system proxy settings with the various properties. Fixed
HttpWebRequest so that it will translate the system proxy settings to the internal
HttpClient/HttpClientHandler objects.

I also removed an invalid Assert in HttpConnection. This assert was firing when using a proxy
that was defined on the loopback adapter using IPv6 literal "[::1]".  Due to issue dotnet/corefx#28863 with Uri,
the Uri.IdnHost property doesn't have the brackets for IPv6 literals. So, the Assert was
occuring.

I did not add any new CI tests because it is currently not possible to test system proxy settings
in CI since it involves changing machine configuration. But I ran manual tests.

Commit migrated from https://github.com/dotnet/corefx/commit/72119235e294e711871cf453f2ffc66ba17ff23b

6 years agoFix line endings (CRLF->LF) (dotnet/corefx#31108)
Matt Mitchell [Mon, 16 Jul 2018 22:57:37 +0000 (15:57 -0700)]
Fix line endings (CRLF->LF) (dotnet/corefx#31108)

Commit migrated from https://github.com/dotnet/corefx/commit/37f5622a47dac3c1f4cd1ce77b388172d4f9eb95

6 years agoFix race conditions in DatataContractSerialization (dotnet/corefx#31065)
Jiayi Yu [Mon, 16 Jul 2018 18:55:01 +0000 (11:55 -0700)]
Fix race conditions in DatataContractSerialization (dotnet/corefx#31065)

* Fix some race conditions in DatataContractSerialization

Commit migrated from https://github.com/dotnet/corefx/commit/2b9fa079f9640a2a2af34eda8be681c9354ef7f0

6 years agoMerge pull request dotnet/corefx#30917 from keeratsingh/utf8-feature-extension
Keerat Singh [Mon, 16 Jul 2018 17:11:37 +0000 (10:11 -0700)]
Merge pull request dotnet/corefx#30917 from keeratsingh/utf8-feature-extension

Add support for UTF8 Feature Extension

Commit migrated from https://github.com/dotnet/corefx/commit/06b5dab217d1c00633f6ffad1d00e79669c95a8b

6 years agoMerge pull request dotnet/corefx#31063 from AfsanehR/GithubIssue30720
Afsaneh Rafighi [Mon, 16 Jul 2018 17:10:48 +0000 (10:10 -0700)]
Merge pull request dotnet/corefx#31063 from AfsanehR/GithubIssue30720

Added missing #ifnetcoreapp for PoolBlockingPeriod property.

Commit migrated from https://github.com/dotnet/corefx/commit/6b7572fea79d5979b86acdd333e522d28d94a6df

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview1-26714-04, preview1-26714-03, preview1...
dotnet-maestro-bot [Sat, 14 Jul 2018 15:30:09 +0000 (08:30 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26714-04, preview1-26714-03, preview1-26714-01, respectively (dotnet/corefx#31072)

Commit migrated from https://github.com/dotnet/corefx/commit/c3e7ffac564b7133dd5442e2683c360bf8e77e86

6 years agoHandle empty and disposed certificates in X509Store and X509Chain.
Filip Navara [Sat, 14 Jul 2018 09:48:00 +0000 (11:48 +0200)]
Handle empty and disposed certificates in X509Store and X509Chain.

* Ignore removing empty or disposed certificates from X509Store.

* Fix X509Chain.Build with empty certificate.

Commit migrated from https://github.com/dotnet/corefx/commit/906725f53f9f84a911bcddc60e72ba7abb8adaf8

6 years agoUpdate BuildTools, CoreClr, ProjectNTfs, ProjectNTfsTestILC to preview1-03013-03...
dotnet-maestro-bot [Sat, 14 Jul 2018 04:45:54 +0000 (21:45 -0700)]
Update BuildTools, CoreClr, ProjectNTfs, ProjectNTfsTestILC to preview1-03013-03, preview1-26714-01, beta-26713-01, beta-26713-01, respectively (dotnet/corefx#31058)

Commit migrated from https://github.com/dotnet/corefx/commit/bacf617d06bc96d3e98d61bd45e19ed06606b0d0

6 years agoProvide a low-level API for reading and writing PKCSdotnet/corefx#12 (PFX) files
Jeremy Barton [Sat, 14 Jul 2018 02:09:11 +0000 (19:09 -0700)]
Provide a low-level API for reading and writing PKCSdotnet/corefx#12 (PFX) files

This change adds two top-level classes, Pkcs12Info and Pkcs12Builder, for
reading existing file blobs and creating new ones.  These classes, and the
object model they expose/consume, are very raw on top of IETF RFC 7292.
Most user interaction with a PFX file/blob will continue to be with the
X509Certificate2 constructor (and Export method) and the
X509Certificate2Collection Import and Export methods.

Commit migrated from https://github.com/dotnet/corefx/commit/64477348da1ff57a43deb65a4b12d32986ed00bd

6 years agoFix TransformManyBlock's EnsureOrdered=false to not hold lock while iterating (dotnet...
Stephen Toub [Sat, 14 Jul 2018 00:19:41 +0000 (20:19 -0400)]
Fix TransformManyBlock's EnsureOrdered=false to not hold lock while iterating (dotnet/corefx#31059)

When EnsureOrdered is set to false (the default is true) and the max degree of parallelism isn't 1 (meaning it allows for parallelism), TransformManyBlock doesn't employ a reordering buffer but needs to then ensure that the collection it writes the results of the transform to is accessed in a thread-safe manner, so it takes a lock.  Currently it takes the lock around the whole enumeration of the result.  While that avoids lots of locking/unlocking for cases where the enumerable produces all of its results very quickly, it causes problems when the enumerable may be slow to produce results, as it then ends up serializing the processing of all of the enumerables.  The fix is simply to take the lock if it's needed only while adding to the target collection, not while iterating the enumerable.

This change does have a small breaking change potential, in that it's possible someone could have set parallelism to > 1 and set EnsureOrdered to false, and then relied on the lock that was being taken exactly for its serialization, in order to make their delegate effectively thread-safe.  But a) EnsureOrdered is a relatively new feature and this setting isn't the default, b) if you've set parallelism to something other than 1, by design you're asking for your delegate to run concurrently with itself.  So the chances of actually breaking something with this bug fix are minimal.

Commit migrated from https://github.com/dotnet/corefx/commit/b64500068a978f0fd96f1dfc8abf1e021b2b83b1

6 years agoUpdate issue-guide.md
Dan Moseley [Sat, 14 Jul 2018 00:03:51 +0000 (17:03 -0700)]
Update issue-guide.md

Commit migrated from https://github.com/dotnet/corefx/commit/3c56ee5053d018fc874e6d0d90669cfbb7ab5a9f

6 years agoFactor out large generic additions in System.Linq for uap build (dotnet/corefx#31025)
Stephen Toub [Fri, 13 Jul 2018 23:58:11 +0000 (19:58 -0400)]
Factor out large generic additions in System.Linq for uap build (dotnet/corefx#31025)

* Factor out large generic additions in System.Linq

New generic types in System.Linq are causing significant size-on-disk increases in AOT builds.  This change addresses some of them:

- The many implementations of IPartition and IIListProvider are causing significant binary size increases for AOT.  I've factored out the majority of those large changes to only be used in a netcoreapp build, not in a uap build.  There are still code paths that test whether an object is IPartition or IIListProvider, but there are no types now in the UAP build that implement them.
- As part of this, I replaced several places where `EmptyPartition<TResult>.Instance` was being used directly to implement an `IEnumerable<T>`, changed them to use `Enumerable.Empty<T>`, and then changed `Enumerable.Empty<T>` so that on netcoreapp it returns `EmptyPartition<TResult>.Instance`, and on uap it returns `Array.Empty<T>`.  This also means now that code paths lighting-up on partitions will also light-up on `Enumerable.Empty<T>`.  It also means that I changed the empty partition's `IEnumerator.Reset` method to be a nop instead of throwing, to match the same behavior as array's `IEnumerator.Reset`.
- LargeArrayBuilder uses T[][], which introduces lots of new array types and corresponding interface instantiations, helper types, etc.  I've specialized LargeArrayBuilder in the UAP build to just be a thin wrapper around ArrayBuilder; we still end up with unnecessary instantiations of LargeArrayBuilder, but they're relatively small, and it saves everything to do with those T[][] instantiations.

* Rename files from netcoreapp/uap to SpeedOpt/SizeOpt

* Fix tests for Reset-becoming-nop change

Commit migrated from https://github.com/dotnet/corefx/commit/143df51926f2ad397fef9c9ca7ede88e2721e801

6 years agoRe-enable Test_BadEventSource_MismatchedIds_WithEtwListener. (dotnet/corefx#31027)
Brian Robbins [Fri, 13 Jul 2018 22:44:30 +0000 (15:44 -0700)]
Re-enable Test_BadEventSource_MismatchedIds_WithEtwListener. (dotnet/corefx#31027)

Commit migrated from https://github.com/dotnet/corefx/commit/911dcaa6b49a8bcc1f39270b8c4f233bd21f7f8d

6 years agoadding more #if netcoreapp where needed
Afsaneh Rafighi [Fri, 13 Jul 2018 21:49:15 +0000 (14:49 -0700)]
adding more #if netcoreapp where needed

fix #if netcoreapp

Commit migrated from https://github.com/dotnet/corefx/commit/4fca5c076e03c0c60130d77ab91684ecbaa0f4c5

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup to preview1-03013-01, preview1-26713...
dotnet-maestro-bot [Fri, 13 Jul 2018 19:44:16 +0000 (12:44 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup to preview1-03013-01, preview1-26713-10, preview1-26713-04, preview1-26713-01, respectively (dotnet/corefx#31055)

Commit migrated from https://github.com/dotnet/corefx/commit/bff367af9bd900257c75ba08120c8d34a15182d1

6 years agoGlobalization coverage: use proper runtimeconfig.json (dotnet/corefx#31054)
Paulo Janotti [Fri, 13 Jul 2018 18:31:23 +0000 (11:31 -0700)]
Globalization coverage: use proper runtimeconfig.json (dotnet/corefx#31054)

Commit migrated from https://github.com/dotnet/corefx/commit/33230b5fc1e0bf05952c796f75ca81a518f0721d

6 years agoAdded a preprocessor check for CODEDOM. This will help support frameworks that have...
Steve Pfister [Fri, 13 Jul 2018 17:57:16 +0000 (13:57 -0400)]
Added a preprocessor check for CODEDOM.  This will help support frameworks that have not fully incorporated all of corefx and want to use System.Configuration.ConfigurationManager (dotnet/corefx#30943)

Commit migrated from https://github.com/dotnet/corefx/commit/16a1230577ed71b6f5c34d74bbd1bc14b44fb536

6 years agoAdd Marshal tests and cleanup existing tests a little (dotnet/corefx#30928)
Hugh Bellamy [Fri, 13 Jul 2018 17:39:09 +0000 (18:39 +0100)]
Add Marshal tests and cleanup existing tests a little (dotnet/corefx#30928)

* Add Marshal tests and cleanup existing tests a little

* Split Marshal tests into their own files and add some new tests

* Enable test

* Address PR feedback

* Remove unecessary tests

Commit migrated from https://github.com/dotnet/corefx/commit/cde110caff0ef993f0db2fde3892e9be6488c3e3

6 years agoAdd more Int32/Int64 parsing tests (dotnet/corefx#31045)
Stephen Toub [Fri, 13 Jul 2018 17:37:53 +0000 (13:37 -0400)]
Add more Int32/Int64 parsing tests (dotnet/corefx#31045)

Add more cases to the Int32 tests, then reuse most of those for Int64 as well.

Commit migrated from https://github.com/dotnet/corefx/commit/ea000f28a9d24214545db2897fad3ecfcc6cfe6a

6 years agoEnable compilation with -Wincompatible-pointer-types-discards-qualifiers for native...
Filip Navara [Fri, 13 Jul 2018 17:37:40 +0000 (19:37 +0200)]
Enable compilation with -Wincompatible-pointer-types-discards-qualifiers for native code. (dotnet/corefx#30890)

* Enable compilation with -Wincompatible-pointer-types-discards-qualifiers for native code.

* Temporarily reenable -Wno-incompatible-pointer-types-discards-qualifiers for System.Net.Security.Native.

* Remove unnecessary casts.

* Use a different trick to implement CONST_CAST that doesn't rely on GCC extension.

* Address review comments.

* Fix build.

* Address review comments.

* Remove the duplicate error checks at EnumerateTrust.

* Re-add the code that sets pCertsOut = NULL on error.

* Formatting fixes.

Commit migrated from https://github.com/dotnet/corefx/commit/810a623ac01236a7fabeabab9c3471fd1d2ede4d

6 years agoAdded Utf8SupportTest.
Keerat Singh [Fri, 13 Jul 2018 17:18:52 +0000 (10:18 -0700)]
Added Utf8SupportTest.

Commit migrated from https://github.com/dotnet/corefx/commit/7fc013c17fb2b2cea007b7403c175b81bcb2f8d3

6 years agoMake Thumbprint use GetCertHashString
Alfred Myers [Fri, 13 Jul 2018 14:50:41 +0000 (11:50 -0300)]
Make Thumbprint use GetCertHashString

Matches .NET Framework, and removes redundant work.

Commit migrated from https://github.com/dotnet/corefx/commit/952b260f230afb771e8aa65586ea213418641082

6 years agoRemove stale comment
Stephen Toub [Fri, 13 Jul 2018 13:17:06 +0000 (09:17 -0400)]
Remove stale comment

Commit migrated from https://github.com/dotnet/corefx/commit/384fa4ad8ed793974218d767aa9e781fb4e99e7c

6 years agoExpose new SignedXml members that were added in .NET 4.6.2.
Filip Navara [Fri, 13 Jul 2018 13:08:05 +0000 (15:08 +0200)]
Expose new SignedXml members that were added in .NET 4.6.2.

Commit migrated from https://github.com/dotnet/corefx/commit/77f783715f2cdfc00f213551f4d416d70faa81f9

6 years agoUpdate symbol uploader to version 1.0.0-beta-63112-02 (dotnet/corefx#31043)
Mike McLaughlin [Fri, 13 Jul 2018 02:36:16 +0000 (19:36 -0700)]
Update symbol uploader to version 1.0.0-beta-63112-02 (dotnet/corefx#31043)

Commit migrated from https://github.com/dotnet/corefx/commit/041f9198463609caa621dd8e867a1755ecaad1f8

6 years agoRemove ExactSpelling = true (dotnet/corefx#31035)
Luqun Lou [Fri, 13 Jul 2018 02:29:52 +0000 (19:29 -0700)]
Remove ExactSpelling = true (dotnet/corefx#31035)

Commit migrated from https://github.com/dotnet/corefx/commit/fabaf360d608614dc7274373e7369f7cd2d3c3f2

6 years agoClean up CheckReaderCount and related functions (dotnet/corefx#30995)
Jiayi Yu [Thu, 12 Jul 2018 22:09:35 +0000 (15:09 -0700)]
Clean up CheckReaderCount and related functions (dotnet/corefx#30995)

* Clean up CheckReaderCount and related methods

Commit migrated from https://github.com/dotnet/corefx/commit/4113317ebd94cb645ed7a7729cdc4bfe12d4bbaa

6 years agoAddressed Saurabh's review feedback.
Keerat Singh [Thu, 12 Jul 2018 20:35:53 +0000 (13:35 -0700)]
Addressed Saurabh's review feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/0c591e408df1f3dc8293fb83c9259b6c1e4e9dae

6 years agoAdd placeholder configurations to Microsoft.CSharp and Microsoft.VisualBasic (dotnet...
Santiago Fernandez Madero [Thu, 12 Jul 2018 20:14:44 +0000 (13:14 -0700)]
Add placeholder configurations to Microsoft.CSharp and Microsoft.VisualBasic (dotnet/corefx#31033)

Commit migrated from https://github.com/dotnet/corefx/commit/2a66228c6b466096af73d1ce546365b646b22754

6 years agoDisable PostRewindableStreamContentMultipleTimes test on NETFX (dotnet/corefx#31031)
David Shulman [Thu, 12 Jul 2018 19:45:39 +0000 (12:45 -0700)]
Disable PostRewindableStreamContentMultipleTimes test on NETFX (dotnet/corefx#31031)

PR dotnet/corefx#19082 changed .NET Core behavior to no longer dispose request content after send. However, the original behavior remains in .NET Framework. So, the test should be skipped on NETFX.

Closes dotnet/corefx#30987

Commit migrated from https://github.com/dotnet/corefx/commit/2a5e017d506fc7a2b5a8a7e03a0b87068d28033b

6 years agoExpose/test CancellationTokenRegistration.Unregister (dotnet/corefx#31008)
Stephen Toub [Thu, 12 Jul 2018 18:52:31 +0000 (14:52 -0400)]
Expose/test CancellationTokenRegistration.Unregister (dotnet/corefx#31008)

* Expose/test CancellationTokenRegistration.Unregister

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7e32ee3c9566e0273e479945e0b62750aedf069e

6 years agoMerge pull request dotnet/corefx#30853 from weshaggard/FixBlockStable
Wes Haggard [Thu, 12 Jul 2018 17:27:02 +0000 (10:27 -0700)]
Merge pull request dotnet/corefx#30853 from weshaggard/FixBlockStable

Allows include build number for packages blocked from going stable

Commit migrated from https://github.com/dotnet/corefx/commit/626840ef01f614f7651b5c226198c0ad85482091

6 years agoMilliSecond Granualrity added to Copy operation on unix (dotnet/corefx#30996)
Anirudh Agnihotry [Thu, 12 Jul 2018 17:19:39 +0000 (10:19 -0700)]
MilliSecond Granualrity added to Copy operation on unix (dotnet/corefx#30996)

* test added

* Test Modified

* Adding Implementation

* tabs removed

* modifyingTest

* Fixing build on HFS

* Space around arithemetic operator

Commit migrated from https://github.com/dotnet/corefx/commit/387aa6c624f0cc8b1c0c013dfddeb115f7c16e27

6 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-26712-00, beta-26712-00, respectively...
dotnet-maestro-bot [Thu, 12 Jul 2018 17:07:13 +0000 (10:07 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26712-00, beta-26712-00, respectively (dotnet/corefx#31023)

Commit migrated from https://github.com/dotnet/corefx/commit/2f19f47c8aebece3fe3f8b44b7f288781d57555a

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview1-26712-06, preview1-26712-04, preview1...
dotnet-maestro-bot [Thu, 12 Jul 2018 14:44:00 +0000 (07:44 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26712-06, preview1-26712-04, preview1-26712-01, respectively (dotnet/corefx#31010)

Commit migrated from https://github.com/dotnet/corefx/commit/3c150ba50dc08a1df3ee85cf9f869ff8f933febe

6 years agoEnsure ConcurrentBag's TryTake is linearizable (dotnet/corefx#30947)
Stephen Toub [Thu, 12 Jul 2018 02:14:44 +0000 (22:14 -0400)]
Ensure ConcurrentBag's TryTake is linearizable (dotnet/corefx#30947)

For .NET Core 2.0, I ported the ThreadPool's work-stealing implementation to ConcurrentBag, leading to significant performance throughput and allocation improvements.  However, there's a subtle difference in the concurrency guarantees the ThreadPool's implementation provided from what ConcurrentBag needs, which ends up breaking certain usage patterns on top of ConcurrentBag.

Specifically, ThreadPool's "steal" implementation need not be fully linearizable.  It's possible for a thread to see the bag's count as 1, and then while the thread is doing a take/steal for its count to never drop below 1, but for the steal to still fail, even though there was always an item available.  This is ok for the thread pool because it manages a known count of work items in the queues separately, and if it sees that there are still items available after a steal has failed, it'll try again.  That "try again" logic provided above the work-stealing queue thus didn't make it over to ConcurrentBag, which breaks some usages of ConcurrentBag, in particular cases where a type like BlockingCollection is wrapping the bag and managing its own count.  It's possible now for BlockingCollection to know that there's an item in the bag but to then fail to take it, which causes problems such as exceptions being thrown.

The fix is to port back the relevant portion of ConcurrentBag from .NET Core 1.x / .NET Framework, where local push operations on a list track the number of times the list transitions from empty to non-empty.  A steal operation then looks at those counts prior to doing the steal, and if the steal fails, it looks again after: if the count has increased, it retries.  This unfortunately means that local pushes on small lists are now more expensive than in .NET Core 2.0/2.1, as if there are <= 2 items in the list, it takes the lock, but this seems unavoidable given the work-stealing design.

Commit migrated from https://github.com/dotnet/corefx/commit/864e82e39b06f7df0acefe822f5c7c48592b53e1

6 years agoUpdate CoreClr, CoreSetup to preview1-26711-07, preview1-26711-04, respectively ...
dotnet-maestro-bot [Thu, 12 Jul 2018 00:28:08 +0000 (17:28 -0700)]
Update CoreClr, CoreSetup to preview1-26711-07, preview1-26711-04, respectively (dotnet/corefx#31004)

Commit migrated from https://github.com/dotnet/corefx/commit/5571df012717b710248d37f4192510fffa49003c

6 years agoMerge branch 'master' of https://github.com/dotnet/corefx into utf8-feature-extension
Keerat Singh [Wed, 11 Jul 2018 23:42:10 +0000 (16:42 -0700)]
Merge branch 'master' of https://github.com/dotnet/corefx into utf8-feature-extension

Commit migrated from https://github.com/dotnet/corefx/commit/d57d3d34c66b7c70e77b7ba4204769575bcff559

6 years agoAddressed Uday's review feedback.
Keerat Singh [Wed, 11 Jul 2018 23:41:55 +0000 (16:41 -0700)]
Addressed Uday's review feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/4b5ba1472d95e77e73309177d76858797f936c4b

6 years agoPorting StandardOleMarshalObject and IMarshal (dotnet/corefx#30931)
Anirudh Agnihotry [Wed, 11 Jul 2018 22:34:47 +0000 (15:34 -0700)]
Porting  StandardOleMarshalObject and IMarshal (dotnet/corefx#30931)

* Porting IMarshal

* Writing ref File and minor changes

* ported from .netfx

* formatting and adding aditional files

* Minor fixes

* Feedback addressed

Commit migrated from https://github.com/dotnet/corefx/commit/f70599a192fcfbeefa52b8ae35a9b1391fe5b809

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Wed, 11 Jul 2018 19:38:30 +0000 (12:38 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03011-03, preview1-26711-05, preview1-26711-05, preview1-26711-01, beta-26711-00, beta-26711-00, respectively (dotnet/corefx#30973)

Commit migrated from https://github.com/dotnet/corefx/commit/003ce301cd66c353aad84b770dae038de07b75d0

6 years agoTweaks to reflect current status for coverage. (dotnet/corefx#30967)
Paulo Janotti [Wed, 11 Jul 2018 17:13:09 +0000 (10:13 -0700)]
Tweaks to reflect current status for coverage. (dotnet/corefx#30967)

Commit migrated from https://github.com/dotnet/corefx/commit/f8fc5e333e607236f3e2717e5d79d11ebc964622

6 years agoMerge pull request dotnet/corefx#30975 from riarenas/riarenas/always-run-end-script
Ricardo Arenas [Wed, 11 Jul 2018 15:39:53 +0000 (08:39 -0700)]
Merge pull request dotnet/corefx#30975 from riarenas/riarenas/always-run-end-script

Always run end.sh/ps1 step

Commit migrated from https://github.com/dotnet/corefx/commit/e2c27b7d6fa230c89bf78c4a5ff2bb440fabe936

6 years agoFixing Pkcs9SigningTime behavior on the X.509 Time UtcTime range [1950;2049)
Maxim Lipnin [Wed, 11 Jul 2018 13:24:45 +0000 (16:24 +0300)]
Fixing Pkcs9SigningTime behavior on the X.509 Time UtcTime range [1950;2049)

Add AsnWriter.WriteUtcTime overload to align the behavior of Pkcs9SigningTime type on the X.509 Time range [1950;2049)

Commit migrated from https://github.com/dotnet/corefx/commit/ba36ab8bcf157b8181e52a7b29a226d9202bf92d

6 years agoBring the AlgorithmIdentifier.Parameters property back
Maxim Lipnin [Wed, 11 Jul 2018 13:18:23 +0000 (16:18 +0300)]
Bring the AlgorithmIdentifier.Parameters property back

Add AlgorithmIdentifier.Parameters, but always set it to the empty array.

There aren't any really understood scenarios for why someone would want to read the algorithm parameters.  Combined with .NET Framework only assigning a non-empty value some of the time, never assigning the correct value, and not having a consistent incorrect value, the empty array seemed the best thing for now.

Commit migrated from https://github.com/dotnet/corefx/commit/64bab987f50b399b78cc1dc23a8e42325e5e175a

6 years agoSmall updates regarding code coverage (dotnet/corefx#30966)
Paulo Janotti [Wed, 11 Jul 2018 00:10:07 +0000 (17:10 -0700)]
Small updates regarding code coverage (dotnet/corefx#30966)

* Small updates regarding code coverage

* Update developer-guide.md

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/f9f200e53600fa4af761ce59e44921b607cbe905

6 years agoReduce coverage run timeout (dotnet/corefx#30972)
Paulo Janotti [Tue, 10 Jul 2018 23:43:34 +0000 (16:43 -0700)]
Reduce coverage run timeout (dotnet/corefx#30972)

Commit migrated from https://github.com/dotnet/corefx/commit/9a2ff8365d923b0efbefb97d6001707607a2991e

6 years agoCleanup in System.Drawing, remove usings and add Gdip alias to SafeNativeMethods...
Santiago Fernandez Madero [Tue, 10 Jul 2018 23:42:08 +0000 (16:42 -0700)]
Cleanup in System.Drawing, remove usings and add Gdip alias to SafeNativeMethods (dotnet/corefx#30970)

Commit migrated from https://github.com/dotnet/corefx/commit/9a507ddef293dbbefe89b4711a7b7d981fa227e8

6 years agoUpdate netfx alias to target .NET 4.7.2 (dotnet/corefx#28883)
Santiago Fernandez Madero [Tue, 10 Jul 2018 22:04:27 +0000 (15:04 -0700)]
Update netfx alias to target .NET 4.7.2 (dotnet/corefx#28883)

* Change netfx to target .NET 4.7.1

* Fix CoreFx.Private.TestUtilities to not reference System.Runtime.InteropServices.RuntimeInformation which is now inbox in netfx

* Fix StackTrace.Tests to be built against netstandard and run against netfx inbox

* Fix ValueTuple configurations to support net461 and add netfx placeholder configuration since in net471 it is now inbox

* Fix projects' package configurations that had netfx (net461) to still support net461 and netfx as a buildconfigurations

* Disable failing tests when running on .NET 4.7.1

* Make netfx target net472 and merge with master

* Update ActiveIssue comments to issue number only

* Workaround packages tests due to not installed targeting pack

* Match NSSupportPackage version to CLI's

* Remove netstandard support lib bin placing to runtime and testhost for netfx, fix reference paths to match new package

* Run UpdateVSConfigurations after merging conflicts with the newly updated SDK projects

* Add net461 package configuration to System.CodeDom

* Add net461 package configuration to System.Configuration.ConfigurationManager

* Add net461 package configuration to System.Security.Cryptography.Xml

* Add net461 package configuration to System.Security.Permissions

* Add net461 package configuration to System.ServiceModel.Syndication

Commit migrated from https://github.com/dotnet/corefx/commit/faad2e63b35bed10fe18195987a413308b97eded