platform/core/dotnet/diagnostics.git
16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4503)
dotnet-maestro[bot] [Fri, 9 Feb 2024 17:52:34 +0000 (09:52 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4503)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240208.1
- **Date Produced**: February 8, 2024 2:41:31 PM UTC
- **Commit**: 6b94d1513777c3aa0426f648649ce06d0d705bb2
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24107.1 to 9.0.0-alpha.1.24108.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/a739c05eb1...6b94d15137

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4502)
dotnet-maestro[bot] [Thu, 8 Feb 2024 17:33:39 +0000 (09:33 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4502)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240207.1
- **Date Produced**: February 7, 2024 11:09:23 AM UTC
- **Commit**: a739c05eb1a5200d7fa2f1e3977b4dc54fdec36a
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24105.3 to 9.0.0-alpha.1.24107.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/ffac2194c3...a739c05eb1

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months agoFix dotnet-trace rundown default (#4499)
Mike McLaughlin [Tue, 6 Feb 2024 17:36:20 +0000 (09:36 -0800)]
Fix dotnet-trace rundown default (#4499)

16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4501)
dotnet-maestro[bot] [Tue, 6 Feb 2024 17:30:26 +0000 (09:30 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4501)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240205.3
- **Date Produced**: February 5, 2024 6:21:57 PM UTC
- **Commit**: ffac2194c39660f03761ba81bdd6026202942184
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24101.2 to 9.0.0-alpha.1.24105.3][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/69b60d2af1...ffac2194c3

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/symstore (#4500)
dotnet-maestro[bot] [Tue, 6 Feb 2024 17:30:08 +0000 (09:30 -0800)]
[main] Update dependencies from dotnet/symstore (#4500)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20240205.1
- **Date Produced**: February 5, 2024 6:30:05 PM UTC
- **Commit**: 36d076932232b23c4e2de271e894b23a16c34ef6
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.507901 to 1.0.510501][1]

[1]: https://github.com/dotnet/symstore/compare/0c7b75fc18...36d0769322

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/installer (#4497)
dotnet-maestro[bot] [Mon, 5 Feb 2024 18:00:45 +0000 (10:00 -0800)]
[main] Update dependencies from dotnet/installer (#4497)

This pull request updates the following dependencies

[marker]: <> (Begin:638f1194-0c1a-4d47-eb59-08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**: 638f1194-0c1a-4d47-eb59-08d8e4d5099b
- **Build**: 20240203.2
- **Date Produced**: February 4, 2024 6:15:58 AM UTC
- **Commit**: 3210d5ad3b47b6f2bbf029fb03eb1f73b87ade25
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 9.0.100-preview.2.24078.1 to
9.0.100-preview.2.24103.2][1]

[1]: https://github.com/dotnet/installer/compare/1c496970b7...3210d5ad3b

[DependencyUpdate]: <> (End)

[marker]: <> (End:638f1194-0c1a-4d47-eb59-08d8e4d5099b)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/arcade (#4496)
dotnet-maestro[bot] [Mon, 5 Feb 2024 18:00:31 +0000 (10:00 -0800)]
[main] Update dependencies from dotnet/arcade (#4496)

This pull request updates the following dependencies

[marker]: <> (Begin:6d3f346d-45bf-4275-0e83-08d8e40a189f)
## From https://github.com/dotnet/arcade
- **Subscription**: 6d3f346d-45bf-4275-0e83-08d8e40a189f
- **Build**: 20240202.4
- **Date Produced**: February 2, 2024 10:58:06 PM UTC
- **Commit**: 2fb543a45580400a559b5ae41c96a815ea14dac5
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.SourceBuild.Intermediate.arcade**: [from
9.0.0-beta.24076.5 to 9.0.0-beta.24102.4][1]
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.24076.5 to
9.0.0-beta.24102.4][1]
- **Microsoft.DotNet.CodeAnalysis**: [from 9.0.0-beta.24076.5 to
9.0.0-beta.24102.4][1]

[1]: https://github.com/dotnet/arcade/compare/66c9c5397d...2fb543a455

[DependencyUpdate]: <> (End)

[marker]: <> (End:6d3f346d-45bf-4275-0e83-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months agoFix a few Watson/!analyze issues (#4492)
Mike McLaughlin [Fri, 2 Feb 2024 22:27:52 +0000 (14:27 -0800)]
Fix a few Watson/!analyze issues (#4492)

Don't call ICLRRuntimeHost::Stop() on desktop hosting failures

Fix ICLRManagedAnalysis instance ref count

16 months agoMove SB metadata to intermediates (#4487)
Ella Hathaway [Fri, 2 Feb 2024 20:25:18 +0000 (12:25 -0800)]
Move SB metadata to intermediates (#4487)

The changes in this pull request aim to [improve the UX and guideance
around the SourceBuild
metadata](https://github.com/dotnet/source-build/issues/3373) by placing
the metadata on explicit source-build intermediates.

The changes include:

- Removing existing SourceBuild metadata from all non-intermediate
dependencies.
- Defining new explicit intermediate dependencies and adding SourceBuild
metadata to those dependencies.

Related to https://github.com/dotnet/source-build/issues/3373 and
https://github.com/dotnet/source-build/issues/4073

16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4489)
dotnet-maestro[bot] [Fri, 2 Feb 2024 18:48:43 +0000 (10:48 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4489)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240201.2
- **Date Produced**: February 1, 2024 8:43:47 PM UTC
- **Commit**: 69b60d2af1775f374c91b3e52da02de6b7de1943
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24080.1 to 9.0.0-alpha.1.24101.2][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/960c24c32a...69b60d2af1

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months agoUpdate to Unified Build controls (#4486)
Matt Mitchell [Thu, 1 Feb 2024 23:28:18 +0000 (15:28 -0800)]
Update to Unified Build controls (#4486)

16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4485)
dotnet-maestro[bot] [Wed, 31 Jan 2024 18:20:40 +0000 (10:20 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4485)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240130.1
- **Date Produced**: January 30, 2024 6:06:51 PM UTC
- **Commit**: 960c24c32a4bde8a83073f33fec25de7ec88a062
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24079.1 to 9.0.0-alpha.1.24080.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/bafaf783af...960c24c32a

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/installer (#4480)
dotnet-maestro[bot] [Tue, 30 Jan 2024 23:13:57 +0000 (15:13 -0800)]
[main] Update dependencies from dotnet/installer (#4480)

This pull request updates the following dependencies

[marker]: <> (Begin:638f1194-0c1a-4d47-eb59-08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**: 638f1194-0c1a-4d47-eb59-08d8e4d5099b
- **Build**: 20240128.1
- **Date Produced**: January 29, 2024 3:50:10 AM UTC
- **Commit**: 1c496970b7479284364bc7eaf5c30e59f1cdb2ec
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 9.0.100-alpha.1.24070.3 to
9.0.100-preview.2.24078.1][1]

[1]: https://github.com/dotnet/installer/compare/f91d4ca399...1c496970b7

[DependencyUpdate]: <> (End)

[marker]: <> (End:638f1194-0c1a-4d47-eb59-08d8e4d5099b)

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4483)
dotnet-maestro[bot] [Tue, 30 Jan 2024 17:41:51 +0000 (09:41 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4483)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240129.1
- **Date Produced**: January 29, 2024 2:55:39 PM UTC
- **Commit**: bafaf783afbd8152b66ba429746ea5861fb84c75
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24075.1 to 9.0.0-alpha.1.24079.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/e659f328bf...bafaf783af

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/symstore (#4482)
dotnet-maestro[bot] [Tue, 30 Jan 2024 17:41:35 +0000 (09:41 -0800)]
[main] Update dependencies from dotnet/symstore (#4482)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20240129.1
- **Date Produced**: January 29, 2024 6:44:53 PM UTC
- **Commit**: 0c7b75fc18db3a4f9b7737ae55a0d04e913ac40c
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.507201 to 1.0.507901][1]

[1]: https://github.com/dotnet/symstore/compare/130f269d41...0c7b75fc18

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/arcade (#4479)
dotnet-maestro[bot] [Mon, 29 Jan 2024 18:12:58 +0000 (10:12 -0800)]
[main] Update dependencies from dotnet/arcade (#4479)

This pull request updates the following dependencies

[marker]: <> (Begin:6d3f346d-45bf-4275-0e83-08d8e40a189f)
## From https://github.com/dotnet/arcade
- **Subscription**: 6d3f346d-45bf-4275-0e83-08d8e40a189f
- **Build**: 20240126.5
- **Date Produced**: January 26, 2024 11:54:14 PM UTC
- **Commit**: 66c9c5397d599af40f2a94989241944f5a73442a
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.24069.2 to
9.0.0-beta.24076.5][1]
- **Microsoft.DotNet.CodeAnalysis**: [from 9.0.0-beta.24069.2 to
9.0.0-beta.24076.5][1]

[1]: https://github.com/dotnet/arcade/compare/abddd0bd51...66c9c5397d

[DependencyUpdate]: <> (End)

[marker]: <> (End:6d3f346d-45bf-4275-0e83-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/arcade (#4471)
dotnet-maestro[bot] [Fri, 26 Jan 2024 19:27:22 +0000 (19:27 +0000)]
[main] Update dependencies from dotnet/arcade (#4471)

[main] Update dependencies from dotnet/arcade

 - Fix warning (turned into error) in counters test

16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4478)
dotnet-maestro[bot] [Fri, 26 Jan 2024 17:14:43 +0000 (09:14 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4478)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240125.1
- **Date Produced**: January 25, 2024 10:33:23 PM UTC
- **Commit**: e659f328bf255d3e17e81296117c3aed1d461f2f
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24073.1 to 9.0.0-alpha.1.24075.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/412264fd6c...e659f328bf

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4476)
dotnet-maestro[bot] [Wed, 24 Jan 2024 19:43:02 +0000 (11:43 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4476)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240123.1
- **Date Produced**: January 23, 2024 4:24:32 PM UTC
- **Commit**: 412264fd6c04712d1d31ff05d37c6919101ef4f4
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24072.5 to 9.0.0-alpha.1.24073.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/2249c9a81e...412264fd6c

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4475)
dotnet-maestro[bot] [Tue, 23 Jan 2024 17:26:57 +0000 (09:26 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4475)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240122.5
- **Date Produced**: January 22, 2024 7:13:26 PM UTC
- **Commit**: 2249c9a81ec9b6cd86791c21e6e69fbc07099788
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24067.1 to 9.0.0-alpha.1.24072.5][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/549aadff16...2249c9a81e

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months ago[main] Update dependencies from dotnet/symstore (#4474)
dotnet-maestro[bot] [Tue, 23 Jan 2024 17:26:31 +0000 (09:26 -0800)]
[main] Update dependencies from dotnet/symstore (#4474)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20240122.1
- **Date Produced**: January 22, 2024 7:59:33 PM UTC
- **Commit**: 130f269d4162ead65afc7992205cd5a0fe9a22b8
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.506501 to 1.0.507201][1]

[1]: https://github.com/dotnet/symstore/compare/39e2ea2473...130f269d41

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
16 months agoadded an option to collect rundown events (#4470)
Maoni Stephens [Mon, 22 Jan 2024 23:08:39 +0000 (15:08 -0800)]
added an option to collect rundown events (#4470)

and have gc-collect not collect them.

dotnet trace right now always collects rundown events but they are not
needed in some scenarios, eg, the gc-collect profile. it's much
preferred to not include these unnecessary events which could take up
way more space than the GC events.

Co-authored-by: Maoni0 <maoni@microsoft.com>
16 months ago[main] Update dependencies from dotnet/installer (#4472)
dotnet-maestro[bot] [Mon, 22 Jan 2024 19:28:32 +0000 (11:28 -0800)]
[main] Update dependencies from dotnet/installer (#4472)

This pull request updates the following dependencies

[marker]: <> (Begin:638f1194-0c1a-4d47-eb59-08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**: 638f1194-0c1a-4d47-eb59-08d8e4d5099b
- **Build**: 20240120.3
- **Date Produced**: January 20, 2024 9:10:48 PM UTC
- **Commit**: f91d4ca399ea4389d04b4700965d207f3a8d5c3b
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 9.0.100-alpha.1.24062.11 to
9.0.100-alpha.1.24070.3][1]

[1]: https://github.com/dotnet/installer/compare/5e2e0f9758...f91d4ca399

[DependencyUpdate]: <> (End)

[marker]: <> (End:638f1194-0c1a-4d47-eb59-08d8e4d5099b)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4469)
dotnet-maestro[bot] [Thu, 18 Jan 2024 18:03:12 +0000 (10:03 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4469)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240117.1
- **Date Produced**: January 17, 2024 2:37:23 PM UTC
- **Commit**: 549aadff1660b230bdfffa562eea3edf59dd0bb4
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24066.1 to 9.0.0-alpha.1.24067.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/aefcb948d0...549aadff16

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4468)
dotnet-maestro[bot] [Wed, 17 Jan 2024 18:07:19 +0000 (10:07 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4468)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240116.1
- **Date Produced**: January 16, 2024 8:57:45 PM UTC
- **Commit**: aefcb948d0ba9e0215f5081004f94309873124fc
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24065.2 to 9.0.0-alpha.1.24066.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/b527807268...aefcb948d0

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[FabricBot] Remove usage of 'noActivitySince' operand condition (#4456)
Jeff Handley [Wed, 17 Jan 2024 02:13:09 +0000 (18:13 -0800)]
[FabricBot] Remove usage of 'noActivitySince' operand condition (#4456)

With the pending migration away from FabricBot to the Policy Service
bot, the `noActivitySince` event condition will no longer be supported.
This PR removes the only occurrence of that condition in this
repository's configuration, as the condition was redundant with other
automation anyway.

The condition was used in an idle issue management task such that:

* A comment was made on a closed issue by the issue's author and the
issue has the label of `Needs: Author Feedback`
* Filtered to the condition of "NOT noActivitySince 30 days ago", thus
there _has_ been other activity within 30 days (this event does not
count as activity)
* Reopen the issue, remove the `Needs: Author Feedback` and `Status: No
Recent Activity` labels, and add the `Needs: Attention ðŸ‘‹` label

This condition of ensuring there _has_ been activity within 30 days is
redundant with the other automation that locks issues with 30 days of
inactivity after closure. Therefore, rather than replicating this
condition/behavior a different way, we can rely on the issue being
unlocked as sufficient.

_Note: The `noActivitySince` search condition will still be supported
within scheduled searches as used in this configuration; it's only
unsupported in event triggers going forward.

17 months agoFix some packaging issues (#4465)
Mike McLaughlin [Wed, 17 Jan 2024 01:41:35 +0000 (17:41 -0800)]
Fix some packaging issues (#4465)

Change SOS installer to copy subdirectories

17 months agoCounter instruments display absolute values now in dotnet-counters (#4455)
Noah Falk [Tue, 16 Jan 2024 23:46:31 +0000 (15:46 -0800)]
Counter instruments display absolute values now in dotnet-counters (#4455)

Fixes #3751

Previously we always showed counter instruments as a rate, but
for a variety of counters that isn't the most useful value. Now
we are showing the absolute value as long as the target process
is running .NET 8. For cases where it was useful to see rate of change
there is now a --showDeltas option which enables a 2nd column
of output for dotnet-counters monitor. The deltas show the difference
between the previous value and the current value. Making the new
column optional rather than a default setting is intended to minimize
consuming horizontal line space which is already at a premium. When
using csv or json outputs it is assumed the user's tool that processes
the data later can compute the rate if desired so there is no special
delta handling added for those.

Take a look at the updated exporter tests to see the specific changes
in dotnet-counters output format.

For other tools consuming System.Diagnostics.Monitoring.EventPipe
there is a new setting on the settings object that allows opting in to
the new behavior. I'm guessing dotnet-monitor will want to do it too
but I wanted to ensure they can opt-into the new behavior at a
time of their choosing.

17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4467)
dotnet-maestro[bot] [Tue, 16 Jan 2024 17:48:05 +0000 (09:48 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4467)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240115.2
- **Date Produced**: January 15, 2024 3:12:03 PM UTC
- **Commit**: b52780726894aeecc634ac2afa1d19e2c712fde2
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24059.3 to 9.0.0-alpha.1.24065.2][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/f2c3fed628...b527807268

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/symstore (#4466)
dotnet-maestro[bot] [Tue, 16 Jan 2024 17:47:18 +0000 (09:47 -0800)]
[main] Update dependencies from dotnet/symstore (#4466)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20240115.1
- **Date Produced**: January 15, 2024 8:14:33 PM UTC
- **Commit**: 39e2ea2473d44b2dc272543277adbce89f79e064
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.505801 to 1.0.506501][1]

[1]: https://github.com/dotnet/symstore/compare/b89d84ab3a...39e2ea2473

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/installer (#4463)
dotnet-maestro[bot] [Mon, 15 Jan 2024 19:46:42 +0000 (11:46 -0800)]
[main] Update dependencies from dotnet/installer (#4463)

This pull request updates the following dependencies

[marker]: <> (Begin:638f1194-0c1a-4d47-eb59-08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**: 638f1194-0c1a-4d47-eb59-08d8e4d5099b
- **Build**: 20240112.11
- **Date Produced**: January 12, 2024 8:29:44 PM UTC
- **Commit**: 5e2e0f97587ecd33d108d16208522e4c764bb7c6
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 9.0.100-alpha.1.24058.1 to
9.0.100-alpha.1.24062.11][1]

[1]: https://github.com/dotnet/installer/compare/7e601e1c0b...5e2e0f9758

[DependencyUpdate]: <> (End)

[marker]: <> (End:638f1194-0c1a-4d47-eb59-08d8e4d5099b)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/arcade (#4462)
dotnet-maestro[bot] [Mon, 15 Jan 2024 19:46:15 +0000 (11:46 -0800)]
[main] Update dependencies from dotnet/arcade (#4462)

This pull request updates the following dependencies

[marker]: <> (Begin:6d3f346d-45bf-4275-0e83-08d8e40a189f)
## From https://github.com/dotnet/arcade
- **Subscription**: 6d3f346d-45bf-4275-0e83-08d8e40a189f
- **Build**: 20240112.5
- **Date Produced**: January 12, 2024 10:34:01 PM UTC
- **Commit**: d731f58a502086842739a358ab490bec08fdb8a7
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.24055.2 to
9.0.0-beta.24062.5][1]
- **Microsoft.DotNet.CodeAnalysis**: [from 9.0.0-beta.24055.2 to
9.0.0-beta.24062.5][1]

[1]: https://github.com/dotnet/arcade/compare/bab85ba457...d731f58a50

[DependencyUpdate]: <> (End)

[marker]: <> (End:6d3f346d-45bf-4275-0e83-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from microsoft/clrmd (#4461)
dotnet-maestro[bot] [Fri, 12 Jan 2024 19:12:16 +0000 (11:12 -0800)]
[main] Update dependencies from microsoft/clrmd (#4461)

This pull request updates the following dependencies

[marker]: <> (Begin:cb58fe07-ae24-4e73-0e84-08d8e40a189f)
## From https://github.com/microsoft/clrmd
- **Subscription**: cb58fe07-ae24-4e73-0e84-08d8e40a189f
- **Build**: 20240111.1
- **Date Produced**: January 11, 2024 8:30:53 PM UTC
- **Commit**: 437022b361da20cf5f02d401a01c5e2c6c366097
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Diagnostics.Runtime**: [from 3.1.506001 to 3.1.506101][1]
- **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.1.506001 to
3.1.506101][1]

[1]: https://github.com/microsoft/clrmd/compare/a4f62f4f68...437022b361

[DependencyUpdate]: <> (End)

[marker]: <> (End:cb58fe07-ae24-4e73-0e84-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from microsoft/clrmd (#4460)
dotnet-maestro[bot] [Thu, 11 Jan 2024 18:38:59 +0000 (10:38 -0800)]
[main] Update dependencies from microsoft/clrmd (#4460)

This pull request updates the following dependencies

[marker]: <> (Begin:cb58fe07-ae24-4e73-0e84-08d8e40a189f)
## From https://github.com/microsoft/clrmd
- **Subscription**: cb58fe07-ae24-4e73-0e84-08d8e40a189f
- **Build**: 20240110.1
- **Date Produced**: January 10, 2024 9:07:15 PM UTC
- **Commit**: a4f62f4f680095ce06e37a83eaa94149de9f69b8
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Diagnostics.Runtime**: [from 3.1.457001 to 3.1.506001][1]
- **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.1.457001 to
3.1.506001][1]

[1]: https://github.com/microsoft/clrmd/compare/b9b01f21c3...a4f62f4f68

[DependencyUpdate]: <> (End)

[marker]: <> (End:cb58fe07-ae24-4e73-0e84-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4459)
dotnet-maestro[bot] [Wed, 10 Jan 2024 17:53:32 +0000 (09:53 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4459)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240109.3
- **Date Produced**: January 10, 2024 12:44:08 AM UTC
- **Commit**: f2c3fed62861b918dfe300f01b497551813a56df
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24055.1 to 9.0.0-alpha.1.24059.3][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/ef691e3c40...f2c3fed628

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/symstore (#4458)
dotnet-maestro[bot] [Wed, 10 Jan 2024 17:52:38 +0000 (09:52 -0800)]
[main] Update dependencies from dotnet/symstore (#4458)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20240108.1
- **Date Produced**: January 8, 2024 7:08:12 PM UTC
- **Commit**: b89d84ab3a08678acb113c86452fcd0037d26f97
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.505101 to 1.0.505801][1]

[1]: https://github.com/dotnet/symstore/compare/b26b065af8...b89d84ab3a

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/arcade (#4450)
dotnet-maestro[bot] [Mon, 8 Jan 2024 20:42:39 +0000 (12:42 -0800)]
[main] Update dependencies from dotnet/arcade (#4450)

This pull request updates the following dependencies

[marker]: <> (Begin:6d3f346d-45bf-4275-0e83-08d8e40a189f)
## From https://github.com/dotnet/arcade
- **Subscription**: 6d3f346d-45bf-4275-0e83-08d8e40a189f
- **Build**: 20240105.2
- **Date Produced**: January 5, 2024 7:12:42 PM UTC
- **Commit**: bab85ba4579526962b0dbb0aa4db625c50da8859
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.23628.1 to
9.0.0-beta.24055.2][1]
- **Microsoft.DotNet.CodeAnalysis**: [from 9.0.0-beta.23628.1 to
9.0.0-beta.24055.2][1]

[1]: https://github.com/dotnet/arcade/compare/9e5fd26c0d...bab85ba457

[DependencyUpdate]: <> (End)

[marker]: <> (End:6d3f346d-45bf-4275-0e83-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/installer (#4451)
dotnet-maestro[bot] [Mon, 8 Jan 2024 20:41:38 +0000 (12:41 -0800)]
[main] Update dependencies from dotnet/installer (#4451)

This pull request updates the following dependencies

[marker]: <> (Begin:638f1194-0c1a-4d47-eb59-08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**: 638f1194-0c1a-4d47-eb59-08d8e4d5099b
- **Build**: 20240108.1
- **Date Produced**: January 8, 2024 11:47:07 AM UTC
- **Commit**: 7e601e1c0b94986e101c0bd2d45fbf4bb1da909f
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 9.0.100-alpha.1.24055.6 to
9.0.100-alpha.1.24058.1][1]

[1]: https://github.com/dotnet/installer/compare/ca1439c8ae...7e601e1c0b

[DependencyUpdate]: <> (End)

[marker]: <> (End:638f1194-0c1a-4d47-eb59-08d8e4d5099b)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoUpdate `ConsoleExporterTests` To Use Updated `RatePayload` (#4454)
kkeirstead [Mon, 8 Jan 2024 20:20:27 +0000 (12:20 -0800)]
Update `ConsoleExporterTests` To Use Updated `RatePayload` (#4454)

It looks like #4324 hadn't run a build in a while, and was checked in
without validating against the new tests in
https://github.com/dotnet/diagnostics/pull/4376 (causing the builds in
main to fail). I don't believe there are any other issues, but this
should give us a fresh build to confirm that.

17 months agoAdd Meter Tags, Instrument Tags, and Scopes to System Diagnostics Metrics (#4324)
kkeirstead [Mon, 8 Jan 2024 15:19:34 +0000 (07:19 -0800)]
Add Meter Tags, Instrument Tags, and Scopes to System Diagnostics Metrics (#4324)

17 months ago[main] Update dependencies from dotnet/installer (#4448)
dotnet-maestro[bot] [Sun, 7 Jan 2024 23:45:06 +0000 (15:45 -0800)]
[main] Update dependencies from dotnet/installer (#4448)

This pull request updates the following dependencies

[marker]: <> (Begin:638f1194-0c1a-4d47-eb59-08d8e4d5099b)
## From https://github.com/dotnet/installer
- **Subscription**: 638f1194-0c1a-4d47-eb59-08d8e4d5099b
- **Build**: 20240105.6
- **Date Produced**: January 6, 2024 1:22:17 AM UTC
- **Commit**: ca1439c8ae7f38b51cd0d2c70ba1f747ebf9e035
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Dotnet.Sdk.Internal**: [from 8.0.101-servicing.23614.6 to
9.0.100-alpha.1.24055.6][1]

[1]: https://github.com/dotnet/installer/compare/461c776642...ca1439c8ae

[DependencyUpdate]: <> (End)

[marker]: <> (End:638f1194-0c1a-4d47-eb59-08d8e4d5099b)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4447)
dotnet-maestro[bot] [Sat, 6 Jan 2024 18:21:08 +0000 (10:21 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4447)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240105.1
- **Date Produced**: January 5, 2024 5:52:20 PM UTC
- **Commit**: ef691e3c401949dab9986a50d8288a6e489f72bb
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24053.1 to 9.0.0-alpha.1.24055.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/5f670e45d0...ef691e3c40

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoAdd dotnet-counters console exporter tests (#4376)
Noah Falk [Sat, 6 Jan 2024 01:05:29 +0000 (17:05 -0800)]
Add dotnet-counters console exporter tests (#4376)

Today all the testing of the console formatting is mostly manual. This
adds some automated testing of the formatting logic in preparation to
both refactor and make some design changes. The tests should make it
very obvious in the future when the output formatting intentionally
changes.

17 months ago[main] Update dependencies from dotnet/installer (#4420)
dotnet-maestro[bot] [Fri, 5 Jan 2024 09:45:06 +0000 (09:45 +0000)]
[main] Update dependencies from dotnet/installer (#4420)

[main] Update dependencies from dotnet/installer

17 months ago[main] Update dependencies from dotnet/arcade (#4434)
dotnet-maestro[bot] [Fri, 5 Jan 2024 02:12:00 +0000 (02:12 +0000)]
[main] Update dependencies from dotnet/arcade (#4434)

[main] Update dependencies from dotnet/arcade

 - Update Versions.props

Latest Microsoft.CodeAnalysis.NetAnalyzers version

 - Update Versions.props

Undo previous commit.

 - Fix a few things to enable testing against a .NET 9.0 SDK

 - Restore single-file version

 - Update 7.0 single-file version

17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4445)
dotnet-maestro[bot] [Thu, 4 Jan 2024 18:24:36 +0000 (10:24 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4445)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240103.1
- **Date Produced**: January 3, 2024 5:53:23 PM UTC
- **Commit**: 5f670e45d060b25d5b07646dfcd94eae31893191
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.24052.1 to 9.0.0-alpha.1.24053.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/5357f2bafb...5f670e45d0

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/symstore (#4441)
dotnet-maestro[bot] [Tue, 2 Jan 2024 19:13:02 +0000 (11:13 -0800)]
[main] Update dependencies from dotnet/symstore (#4441)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20240101.1
- **Date Produced**: January 1, 2024 6:57:16 PM UTC
- **Commit**: b26b065af8647262418c1ef4609de690a003bfa3
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.461801 to 1.0.505101][1]

[1]: https://github.com/dotnet/symstore/compare/a5237ea435...b26b065af8

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4442)
dotnet-maestro[bot] [Tue, 2 Jan 2024 19:12:14 +0000 (11:12 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4442)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20240102.1
- **Date Produced**: January 2, 2024 8:59:47 AM UTC
- **Commit**: 5357f2bafb9e23858aa57136d38dbb113cdf81a2
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23627.2 to 9.0.0-alpha.1.24052.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/2a008ae4f4...5357f2bafb

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4440)
dotnet-maestro[bot] [Thu, 28 Dec 2023 01:03:20 +0000 (17:03 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4440)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231227.2
- **Date Produced**: December 27, 2023 10:37:05 AM UTC
- **Commit**: 2a008ae4f42c0db384db5a4864752b2ff52d720b
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23618.2 to 9.0.0-alpha.1.23627.2][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/c49c1f4e46...2a008ae4f4

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
17 months agoDon't lock Microsoft.Diagnostics.DebugServices to 7.0 (#4439)
Mike McLaughlin [Sun, 24 Dec 2023 17:11:22 +0000 (09:11 -0800)]
Don't lock Microsoft.Diagnostics.DebugServices to 7.0 (#4439)

17 months agoAdd CLRMA support to SOS. (#4437)
Mike McLaughlin [Sat, 23 Dec 2023 07:53:38 +0000 (23:53 -0800)]
Add CLRMA support to SOS. (#4437)

Add the CLRMA exports on SOS.dll. Implement the CLRMA interfaces on top
of ICrashInfoServices.

Update ICrashInfoService to be more generic and not JSON crash info
specific.

Renamed IManagedException to IException.

Add IStackFrame.GetMethodName replacing Offset/MethodName.

Cleanup/change name of SOSHost.INativeClient

Change TraceError used in extensions lib not to depend on SOS globals
being initialized

18 months ago[main] Update dependencies from dotnet/symstore (#4435)
dotnet-maestro[bot] [Tue, 19 Dec 2023 18:39:42 +0000 (10:39 -0800)]
[main] Update dependencies from dotnet/symstore (#4435)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20231218.1
- **Date Produced**: December 18, 2023 8:30:41 PM UTC
- **Commit**: a5237ea435a344d9363de492d0374442ff9623ce
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.461101 to 1.0.461801][1]

[1]: https://github.com/dotnet/symstore/compare/f3e7fb5a0c...a5237ea435

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4436)
dotnet-maestro[bot] [Tue, 19 Dec 2023 18:39:28 +0000 (10:39 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4436)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231218.2
- **Date Produced**: December 18, 2023 3:22:39 PM UTC
- **Commit**: c49c1f4e461b4b57d6d3449671942786bf8fcbb6
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23615.3 to 9.0.0-alpha.1.23618.2][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/ad27491492...c49c1f4e46

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4433)
dotnet-maestro[bot] [Sat, 16 Dec 2023 21:03:01 +0000 (13:03 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4433)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231215.3
- **Date Produced**: December 15, 2023 7:04:58 PM UTC
- **Commit**: ad274914920e8e51c5269d215a641e592af8182c
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23611.3 to 9.0.0-alpha.1.23615.3][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/2294642997...ad27491492

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4432)
dotnet-maestro[bot] [Tue, 12 Dec 2023 17:41:07 +0000 (09:41 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4432)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231211.3
- **Date Produced**: December 11, 2023 10:47:18 PM UTC
- **Commit**: 229464299759d6667e8b907d9c321d31a8dcc123
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23608.1 to 9.0.0-alpha.1.23611.3][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/9e09ace189...2294642997

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/symstore (#4431)
dotnet-maestro[bot] [Tue, 12 Dec 2023 17:39:36 +0000 (09:39 -0800)]
[main] Update dependencies from dotnet/symstore (#4431)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20231211.1
- **Date Produced**: December 11, 2023 6:40:38 PM UTC
- **Commit**: f3e7fb5a0cf070f32dee1343427c0fed122de49b
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.460401 to 1.0.461101][1]

[1]: https://github.com/dotnet/symstore/compare/8b17b7a1a0...f3e7fb5a0c

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/arcade (#4429)
dotnet-maestro[bot] [Mon, 11 Dec 2023 18:05:47 +0000 (10:05 -0800)]
[main] Update dependencies from dotnet/arcade (#4429)

This pull request updates the following dependencies

[marker]: <> (Begin:6d3f346d-45bf-4275-0e83-08d8e40a189f)
## From https://github.com/dotnet/arcade
- **Subscription**: 6d3f346d-45bf-4275-0e83-08d8e40a189f
- **Build**: 20231207.2
- **Date Produced**: December 7, 2023 11:06:00 PM UTC
- **Commit**: 3faeb9817f465151aa4bbcdb315f0a6170206760
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.23601.1 to
9.0.0-beta.23607.2][1]
- **Microsoft.DotNet.CodeAnalysis**: [from 9.0.0-beta.23601.1 to
9.0.0-beta.23607.2][1]

[1]: https://github.com/dotnet/arcade/compare/38aa367e01...3faeb9817f

[DependencyUpdate]: <> (End)

[marker]: <> (End:6d3f346d-45bf-4275-0e83-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4428)
dotnet-maestro[bot] [Sat, 9 Dec 2023 20:20:57 +0000 (12:20 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4428)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231208.1
- **Date Produced**: December 8, 2023 4:29:38 PM UTC
- **Commit**: 9e09ace1897546ac85dab114a6e1a5b6f773db7a
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23607.1 to 9.0.0-alpha.1.23608.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/c7796fc86b...9e09ace189

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months agoRemove Microsoft.SourceBuild.Intermediate from prebuilt baseline (#4427)
Ella Hathaway [Sat, 9 Dec 2023 02:28:18 +0000 (18:28 -0800)]
Remove Microsoft.SourceBuild.Intermediate from prebuilt baseline (#4427)

Prebuilt detection no longer detects Microsoft.SourceBuild.Intermediates
as prebuilts due to https://github.com/dotnet/arcade/pull/13935.

Addresses https://github.com/dotnet/source-build/issues/3010

18 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4426)
dotnet-maestro[bot] [Fri, 8 Dec 2023 19:30:01 +0000 (11:30 -0800)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4426)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231207.1
- **Date Produced**: December 7, 2023 9:26:18 PM UTC
- **Commit**: c7796fc86b1cc2ad8be7ba7af8e19237d7d65d77
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23565.2 to 9.0.0-alpha.1.23607.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/b5ceed90b7...c7796fc86b

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months agoMigrate to the Locker GitHub action for locking closed/stale issues/PRs (#4417)
Jeff Handley [Thu, 7 Dec 2023 21:39:42 +0000 (13:39 -0800)]
Migrate to the Locker GitHub action for locking closed/stale issues/PRs (#4417)

This migrates away from the FabricBot implementation of a scheduled
search over closed issues and adopts the
[Locker](https://github.com/microsoft/vscode-github-triage-actions/?tab=readme-ov-file#locker)
GitHub action authored by the VS Code team.

The updated fabricbot.json was generated via
https://github.com/dotnet/fabricbot-config/pull/83. The workflow file
was implemented and tested at
https://github.com/dotnet/fabricbot-config/blob/main/.github/workflows/locker.yml.

Since this workflow uses the actions/checkout action, we need to ensure
the following GitHub Actions settings are enabled:

1. Allow enterprise, and select non-enterprise, actions and reusable
workflows
2. Allow actions created by GitHub

/cc @wtgodbe

18 months agoAn additional flag to parallel stacks to include runtime stacks to pstacks command...
Igor Bagdamyan [Tue, 5 Dec 2023 21:27:40 +0000 (00:27 +0300)]
An additional flag to parallel stacks to include runtime stacks to pstacks command (#4423)

This adds "-r" flag to include Runtime stacks to pstacks output
It will still ignore the frame if it's method is null. It's just a
matter of checking for both Runtime and Managed kinds
Sometimes it might be useful to have those too, for example like in
https://github.com/dotnet/diagnostics/issues/4418 when it is still
useful to know which threads are in locked state

18 months ago[main] Update dependencies from dotnet/symstore (#4422)
dotnet-maestro[bot] [Tue, 5 Dec 2023 18:29:32 +0000 (10:29 -0800)]
[main] Update dependencies from dotnet/symstore (#4422)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20231204.1
- **Date Produced**: December 4, 2023 7:23:41 PM UTC
- **Commit**: 8b17b7a1a0d86d0e748db791b163b2c21a7845c8
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.457701 to 1.0.460401][1]

[1]: https://github.com/dotnet/symstore/compare/94b6cc6e11...8b17b7a1a0

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/arcade (#4419)
dotnet-maestro[bot] [Mon, 4 Dec 2023 14:13:32 +0000 (14:13 +0000)]
[main] Update dependencies from dotnet/arcade (#4419)

[main] Update dependencies from dotnet/arcade

18 months agoAdded dump referenced objects command (#4416)
Igor Bagdamyan [Sun, 3 Dec 2023 14:38:08 +0000 (17:38 +0300)]
Added dump referenced objects command (#4416)

This is something I've found useful in my latest investigation. I've
encountered a cache in the library we've used which happened ot be a
"dominator" e.g. referenced many many objects. It was useful to know
which objects were referenced. I think it can also be generally applied
to get information on how much stuff a single object is transivitely
referencing.

I wanted to make a DumpDominators command to automate such analysis
(e.g. find objects that keep many other objects alive) but I'm still not
sure how to do it. Calculations can take forever and there is a need to
filter out objects that aren't really interesting (e.g. it has no sense
to report static root as a dominator, it's obvious).

Also added an option to limit gcroots count as there were 403 roots of
an object I tried to analyze. Generally I don't think there is a need to
print that many roots so a limiting option is quite welcome.

Feel free to close this if you don't think this is helpful or have other
future plans of similar work

18 months ago[main] Update dependencies from dotnet/arcade (#4407)
dotnet-maestro[bot] [Fri, 1 Dec 2023 22:15:53 +0000 (22:15 +0000)]
[main] Update dependencies from dotnet/arcade (#4407)

[main] Update dependencies from dotnet/arcade

 - Update aspnetcore versions

18 months ago[main] Update dependencies from dotnet/symstore (#4414)
dotnet-maestro[bot] [Tue, 28 Nov 2023 14:27:43 +0000 (14:27 +0000)]
[main] Update dependencies from dotnet/symstore (#4414)

[main] Update dependencies from dotnet/symstore

18 months agoProvide better error messages for IPC connect failures (#4406)
Tom McDonald [Wed, 22 Nov 2023 21:25:46 +0000 (16:25 -0500)]
Provide better error messages for IPC connect failures (#4406)

18 months agovalidate that providers are > 0 to provide clear error when using Diagnostics Client...
Dan Espinosa [Wed, 22 Nov 2023 07:41:31 +0000 (23:41 -0800)]
validate that providers are > 0 to provide clear error when using Diagnostics Client (#4411)

validate that providers are > 0 otherwise START Failed 0x80131384 get…s
thrown and it's not clear what the issue is.

The current behavior when an empty list of providers is provided is to
throw START Failed 0x80131384 (BadEncoding) and that doesn't make it
very clear about what the issue is. This PR proposes validating the
number of providers so developers know that they should be providing 1
provider at least.

Before:
<img width="677" alt="image"
src="https://github.com/dotnet/diagnostics/assets/30415120/0dfe0963-97ae-4f1a-8ce5-46b992b55428">

After:
<img width="679" alt="image"
src="https://github.com/dotnet/diagnostics/assets/30415120/f171687b-eaa5-4bbb-945c-16a43f4b97b0">

Co-authored-by: Daniel Espinosa <luespino@microsoft.com>
18 months ago[main] Update dependencies from microsoft/clrmd (#4409)
dotnet-maestro[bot] [Tue, 21 Nov 2023 17:58:15 +0000 (09:58 -0800)]
[main] Update dependencies from microsoft/clrmd (#4409)

This pull request updates the following dependencies

[marker]: <> (Begin:cb58fe07-ae24-4e73-0e84-08d8e40a189f)
## From https://github.com/microsoft/clrmd
- **Subscription**: cb58fe07-ae24-4e73-0e84-08d8e40a189f
- **Build**: 20231120.1
- **Date Produced**: November 20, 2023 6:34:45 PM UTC
- **Commit**: b9b01f21c353f59908b1563e1f17831eaad41b28
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.Diagnostics.Runtime**: [from 3.1.456501 to 3.1.457001][1]
- **Microsoft.Diagnostics.Runtime.Utilities**: [from 3.1.456501 to
3.1.457001][1]

[1]: https://github.com/microsoft/clrmd/compare/49b694dbf8...b9b01f21c3

[DependencyUpdate]: <> (End)

[marker]: <> (End:cb58fe07-ae24-4e73-0e84-08d8e40a189f)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
18 months ago[main] Update dependencies from dotnet/symstore (#4410)
dotnet-maestro[bot] [Tue, 21 Nov 2023 14:24:09 +0000 (14:24 +0000)]
[main] Update dependencies from dotnet/symstore (#4410)

[main] Update dependencies from dotnet/symstore

18 months agoAdd RequestStackwalk parameter to EventPipeSession (#4290)
Eugene Zhirov [Tue, 21 Nov 2023 08:27:55 +0000 (09:27 +0100)]
Add RequestStackwalk parameter to EventPipeSession (#4290)

Client-side of https://github.com/dotnet/runtime/pull/84077 and the
implementation of https://github.com/dotnet/diagnostics/issues/3696.

To simplify the interface I made `EventPipeSessionConfiguration` public
and introduced a new method in the DiagnosticsClient:
`Task<EventPipeSession>
StartEventPipeSessionAsync(EventPipeSessionConfiguration configuration,
CancellationToken token)`. This is the only method that supports
disabling the stackwalk so no additional overloads with a new bool
parameter and no synchronous counterpart. I believe it'd be easier to
use and maintain a single async method with the options rather than
creating more overloads or default parameters but I may not have all the
context here so please correct me if you think it's a bad idea.

To deal with the backward compatibility I only use `CollectTracingV3`
when necessary i.e. when `RequestStackwalk` option is set to false. I
think it's a good compromise between the added complexity and
potentially surprising behavior:
* when the client is old and the runtime is new everything works because
the runtime supports `CollectTracingV2`
* when the client is new but the runtime is old everything works until
the new option is used. When it's used the session won't start as
`CollectTracingV3` doesn't exist server side: there'd be no clear error
message but it's documented in the option summary.
* when both the client and the runtime are new either `CollectTracingV2`
or `CollectTracingV3` may be used transparently for the user
* we may use the same trick when we introduce `CollectTracingV4`

The alternative is to implement version negotiation of some sort but I'd
like to have your opinion before attempting this as handling the errors
correctly wouldn't be easy (f.e. in [my current
fork](https://github.com/criteo-forks/diagnostics/commit/3946b4a88bbb08cdbbf4e71364fd46d32c4ab3dc#diff-e8365039cd36eae3dec611784fc7076be7dadeda1007733412aaaa63f40a748fR39)
I just hide the exception)

The testing turned out to be a bit complex as I needed to convert
EventPipe stream to `TraceLog` to be able to read the stacktraces. I
couldn't achieve that without writing data to a file. Afaiu the
stackwalk may not work correctly without the rundown that only happens
at the end of the session so I wonder if looking at the stacktraces with
a live session is even possible (though iirc netfw+ETW could do that
back in the days) ?

Thanks for your time !

18 months agoMake DiagnosticsClient.StartEventPipeSessionAsync public (#4394)
Evgeny Morozov [Tue, 21 Nov 2023 08:20:03 +0000 (09:20 +0100)]
Make DiagnosticsClient.StartEventPipeSessionAsync public (#4394)

This allows user code to pass a cancellation token without wrapping the
call to StartEventPipeSession() in Task.Run() or similar. Resolves
#3727.

19 months ago[main] Update dependencies from dotnet/installer (#4408)
dotnet-maestro[bot] [Mon, 20 Nov 2023 14:20:10 +0000 (14:20 +0000)]
[main] Update dependencies from dotnet/installer (#4408)

[main] Update dependencies from dotnet/installer

19 months ago[main] Update dependencies from dotnet/installer (#4374)
dotnet-maestro[bot] [Thu, 16 Nov 2023 18:39:38 +0000 (18:39 +0000)]
[main] Update dependencies from dotnet/installer (#4374)

[main] Update dependencies from dotnet/installer

 - Update Versions.props

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4405)
dotnet-maestro[bot] [Thu, 16 Nov 2023 15:03:27 +0000 (15:03 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4405)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[main] Update dependencies from microsoft/clrmd (#4404)
dotnet-maestro[bot] [Thu, 16 Nov 2023 14:29:14 +0000 (14:29 +0000)]
[main] Update dependencies from microsoft/clrmd (#4404)

[main] Update dependencies from microsoft/clrmd

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4400)
dotnet-maestro[bot] [Wed, 15 Nov 2023 14:46:55 +0000 (14:46 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4400)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[main] Update dependencies from microsoft/clrmd (#4399)
dotnet-maestro[bot] [Wed, 15 Nov 2023 14:23:45 +0000 (14:23 +0000)]
[main] Update dependencies from microsoft/clrmd (#4399)

[main] Update dependencies from microsoft/clrmd

19 months ago[main] Update dependencies from dotnet/symstore (#4396)
dotnet-maestro[bot] [Tue, 14 Nov 2023 18:07:54 +0000 (10:07 -0800)]
[main] Update dependencies from dotnet/symstore (#4396)

This pull request updates the following dependencies

[marker]: <> (Begin:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)
## From https://github.com/dotnet/symstore
- **Subscription**: 678f7c5b-6647-4e77-0d75-08d8e40a4c7c
- **Build**: 20231113.1
- **Date Produced**: November 13, 2023 6:49:55 PM UTC
- **Commit**: ea785d63ff10aac8d882cc2c0bd22d5c1cb554fa
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
  - **Microsoft.SymbolStore**: [from 1.0.455601 to 1.0.456301][1]

[1]: https://github.com/dotnet/symstore/compare/18ccf59197...ea785d63ff

[DependencyUpdate]: <> (End)

[marker]: <> (End:678f7c5b-6647-4e77-0d75-08d8e40a4c7c)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4397)
dotnet-maestro[bot] [Tue, 14 Nov 2023 14:35:30 +0000 (14:35 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4397)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months agoUniversal Time formatting (#4389)
mikelle-rogers [Tue, 14 Nov 2023 00:11:36 +0000 (16:11 -0800)]
Universal Time formatting (#4389)

In dotnet-counters JSON Exporter, change time formatting to universal
time formatting. Fixes #3905

19 months ago[main] Update dependencies from dotnet/arcade (#4393)
dotnet-maestro[bot] [Mon, 13 Nov 2023 18:47:33 +0000 (18:47 +0000)]
[main] Update dependencies from dotnet/arcade (#4393)

[main] Update dependencies from dotnet/arcade

19 months ago[main] Update dependencies from microsoft/clrmd (#4392)
dotnet-maestro[bot] [Sun, 12 Nov 2023 02:28:40 +0000 (02:28 +0000)]
[main] Update dependencies from microsoft/clrmd (#4392)

[main] Update dependencies from microsoft/clrmd

 - Manually bump version

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4391)
dotnet-maestro[bot] [Thu, 9 Nov 2023 14:34:20 +0000 (14:34 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4391)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[RISC-V] Implement SOS related code. (#4385)
Mikhail Kurinnoi [Wed, 8 Nov 2023 01:17:14 +0000 (04:17 +0300)]
[RISC-V] Implement SOS related code. (#4385)

Implement ICorDebug related `clrstack -i`.
Implement `clrstack -r` output.

Related PR in runtime: https://github.com/dotnet/runtime/pull/94454

```
> clrstack
OS Thread Id: 0x40614 (0)
        Child SP               IP Call Site
0000003FCBDD6F70 0000000000000000 [InlinedCallFrame: 0000003fcbdd6f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FCBDD6F70 0000003f32be5758 [InlinedCallFrame: 0000003fcbdd6f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FCBDD6F50 0000003F32BE5758 ILStubClass.IL_STUB_PInvoke(Byte*, Int32)
0000003FCBDD7050 0000003F32BE55BC Interop+Sys.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/Microsoft.Interop.LibraryImportGenerator/Microsoft.Interop.LibraryImportGenerator/LibraryImports.g.cs @ 800]
0000003FCBDD7080 0000003F32BE5464 System.IO.StdInReader.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 83]
0000003FCBDD70B0 0000003F32BE4FBC System.IO.StdInReader.ReadKey() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 337]
0000003FCBDD7560 0000003F32BE3A24 System.IO.StdInReader.ReadLineCore(Boolean) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 160]
0000003FCBDD7740 0000003F32BE3694 System.IO.StdInReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 90]
0000003FCBDD77A0 0000003F32BE353C System.IO.SyncTextReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/SyncTextReader.cs @ 77]
0000003FCBDD77F0 0000003F32BE144C System.Console.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/Console.cs @ 752]
0000003FCBDD7820 0000003F32B9DFD0 TestApp.Program.Main(System.String[]) [/home/viewizard/Desktop/projects_test/test_hr/Program.cs @ 11]
```
```
> clrstack -i
Dumping managed stack and managed variables using ICorDebug.
=============================================================================
Child SP         IP               Call Site
0000003FCBDD6EF0 0000000000000000 [NativeStackFrame]
0000003FCBDD6F50 0000003f32be5758 0000003FCBDD6F70 (null) [Managed to Unmanaged transition: 0000003FCBDD6F70]
0000003FCBDD7050 0000003f32be55bc [DEFAULT] I4 Interop+Sys.ReadStdin(Ptr UI1,I4) (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7080 0000003f32be5464 [DEFAULT] I4 System.IO.StdInReader.ReadStdin(Ptr UI1,I4) (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD70B0 0000003f32be4fbc [DEFAULT] [hasThis] ValueClass System.ConsoleKeyInfo System.IO.StdInReader.ReadKey() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7560 0000003f32be3a24 [DEFAULT] [hasThis] Boolean System.IO.StdInReader.ReadLineCore(Boolean) (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7740 0000003f32be3694 [DEFAULT] [hasThis] String System.IO.StdInReader.ReadLine() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD77A0 0000003f32be353c [DEFAULT] [hasThis] String System.IO.SyncTextReader.ReadLine() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD77F0 0000003f32be144c [DEFAULT] String System.Console.ReadLine() (/home/mkurinnoi/dotnet/System.Console.dll)
0000003FCBDD7820 0000003f32b9dfd0 [DEFAULT] Void TestApp.Program.Main(SZArray String) (/home/mkurinnoi/test_hr.dll)
0000003FCBDD7850 0000003fb1e2307e [NativeStackFrame]
Stack walk complete.
=============================================================================
```

CC @clamp03 @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov

19 months agoFix DumpStackObjects <bounds> error (#4384)
Mike McLaughlin [Tue, 7 Nov 2023 16:55:53 +0000 (08:55 -0800)]
Fix DumpStackObjects <bounds> error (#4384)

19 months ago[main] Update dependencies from dotnet/symstore (#4386)
dotnet-maestro[bot] [Tue, 7 Nov 2023 14:26:42 +0000 (14:26 +0000)]
[main] Update dependencies from dotnet/symstore (#4386)

[main] Update dependencies from dotnet/symstore

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4387)
dotnet-maestro[bot] [Tue, 7 Nov 2023 14:20:07 +0000 (14:20 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4387)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[main] Update dependencies from dotnet/arcade (#4383)
dotnet-maestro[bot] [Mon, 6 Nov 2023 14:13:47 +0000 (14:13 +0000)]
[main] Update dependencies from dotnet/arcade (#4383)

[main] Update dependencies from dotnet/arcade

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4382)
dotnet-maestro[bot] [Sat, 4 Nov 2023 13:22:51 +0000 (13:22 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4382)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[main] Update dependencies from dotnet/symstore (#4381)
dotnet-maestro[bot] [Fri, 3 Nov 2023 13:05:33 +0000 (13:05 +0000)]
[main] Update dependencies from dotnet/symstore (#4381)

[main] Update dependencies from dotnet/symstore

19 months ago[tools][trace] Add stopping event options to dotnet-trace (#4363)
Mitchell Hwang [Thu, 2 Nov 2023 23:07:01 +0000 (19:07 -0400)]
[tools][trace] Add stopping event options to dotnet-trace (#4363)

Fixes https://github.com/dotnet/diagnostics/issues/3125

This PR provides users another method to stop a dotnet-trace via a
stopping event similar to that of dotnet-monitor, originally implemented
in https://github.com/dotnet/dotnet-monitor/pull/2557.

Three arguments are added to the `dotnet-trace collect` command to
specify a stopping event:
| Argument | Description |
|----------|----------|
|`--stopping-event-provider-name` | A string, parsed as-is, that will
stop the trace upon hitting an event with the matching provider name.
For a more specific stopping event, additionally provide
`--stopping-event-event-name` and/or `--stopping-event-payload-filter`.
|
| `--stopping-event-event-name` | A string, parsed as-is, that will stop
the trace upon hitting an event with the matching event name. Requires
`--stopping-event-provider-name` to be set. For a more specific stopping
event, additionally provide `--stopping-event-payload-filter`. |
| `--stopping-event-payload-filter` | A string, parsed as
[payload_field_name]:[payload_field_value] pairs separated by commas,
that will stop the trace upon hitting an event with a matching payload.
Requires `--stopping-event-provider-name` and
`--stopping-event-event-name` to be set. |

Note: Though technically `--stopping-event-payload-filter` can be set
without needing a `--stopping-event-event-name`, this may lead to
mismatched payloads should another `TraceEvent` under the same provider
not have that particular payload field name. Until there is a good
reason to stop a trace given a payload filter regardless of the event
name, we require `--stopping-event-event-name` to be set whenever
`--stopping-event-payload-filter` is provided.

To stop a trace at a particular event, dotnet-monitor's
[approach](https://github.com/dotnet/dotnet-monitor/blob/0820b6911f3ac47b6b5ec867ac906699e5c15787/src/Tools/dotnet-monitor/Trace/TraceUntilEventOperation.cs#L47)
using an
[EventMonitor](https://github.com/dotnet/diagnostics/blob/main/src/Microsoft.Diagnostics.Monitoring.EventPipe/EventMonitor.cs)
is adopted. Upon hitting a TraceEvent with a matching ProviderName,
EventName (if specified), and PayloadFilter (if specified), we trigger
dotnet-trace's fallback logic to stop the EventPipeSession before the
EventStream ends.

Note: As the EventStream is being parsed asynchronously, there will be
some events that pass through between the time a trace event matching
the specified stopping event arguments is parsed and the
EventPipeSession is stopped.

In addition, this PR modifies `EventMonitor` to use the
`ClrTraceEventParser` to parse `TraceEvent` objects under the
`Microsoft-Windows-DotNETRuntime` provider, and the
`DynamicTraceEventParser` otherwise. The `ClrTraceEventParser` is
generated to understand the ETW event manifest for
`Microsoft-Windows-DotNETRuntime` events. The previous implementation
defaulting to `DynamicTraceEventParser` would not work on non-Windows
platforms such as OSX which could not parse the payload to populate
`PayloadNames` and `PayloadValue(i)` because there was no manifest
available. On the other hand, Windows is able to locate manifest data
for known events through the OS.

-------------------

## Testing

With an Android App
``` C#
    private static void PrintA()
    {
        Console.WriteLine("A");
        Thread.Sleep(1000);
    }

    ...

    private static void PrintK()
    {
        Console.WriteLine("K");
        Thread.Sleep(1000);
    }

    public static void Main(string[] args)
    {
        Console.WriteLine("Hello, Android!"); // logcat
        PrintA();
        PrintB();
        PrintC();
        PrintD();
        PrintE();
        PrintF();
        PrintG();
        PrintH();
        PrintI();
        PrintJ();
        PrintK();

        while (true)
        {
            Thread.Sleep(100);
        }
    }
```

Running dotnet-dsrouter to connect the diagnostic tooling with the
android device
`./artifacts/bin/dotnet-dsrouter/Debug/net6.0/dotnet-dsrouter android -v
debug`

Tracing with a stopping event args provided
`./artifacts/bin/dotnet-trace/Debug/net6.0/dotnet-trace collect -p 16683
--providers Microsoft-Windows-DotNETRuntime:0x1F000080018:5
--stopping-event-provider-name Microsoft-Windows-DotNETRuntime
--stopping-event-event-name Method/JittingStarted
--stopping-event-payload-filter MethodName:PrintA`

[dotnet-dsrouter_20231024_165648.nettrace.zip](https://github.com/dotnet/diagnostics/files/13147788/dotnet-dsrouter_20231024_165648.nettrace.zip)

There are no `Method/JittingStarted` events with MethodName `PrintC`
through `PrintK` in the `.nettrace`, showing that the trace was indeed
stopped after seeing the `PrintA` event. The events after `PrintA` are
an artifact of the second note above. Below is the JITStats of the
.nettrace opened in perfview, showing that the last method was `PrintB`.

<img width="1128" alt="JITStatsPrintA"
src="https://github.com/dotnet/diagnostics/assets/16830051/1742baf4-b528-43c3-aef3-b00a576f2fb8">

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4380)
dotnet-maestro[bot] [Thu, 2 Nov 2023 13:20:41 +0000 (13:20 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4380)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months agoAllow ` in hex strings (#4379)
Lee Culver [Tue, 31 Oct 2023 22:26:48 +0000 (15:26 -0700)]
Allow ` in hex strings (#4379)

Update extension command parsing to allow a single \` in the middle of
addresses. We allow "\`0123" because the user might have copied the \`
marker in "0000\`0123". This makes commands more consistent since the
C++ based SOS commands allow for \` in the addresses.

Updated a location where we didn't use TryParseAddress but should have.

Feature request from the GC team.

19 months ago[RISC-V] Add partial SOS 'clrstack' command implementation. (#4356)
Mikhail Kurinnoi [Tue, 31 Oct 2023 15:39:59 +0000 (18:39 +0300)]
[RISC-V] Add partial SOS 'clrstack' command implementation. (#4356)

Changes:
- add partial SOS 'clrstack' command implementation;
- add more RISC-V related code (some still not tested or NYI, but need
for proper SOS build);

This changes allow start and use dotnet-dump+SOS with current runtime
upstream on RISC-V board:
```
mkurinnoi@starfive:~$ ./dotnet/corerun ./tools/dotnet-dump.dll ps
 221935  corerun  /home/mkurinnoi/dotnet/corerun  ./dotnet/corerun ./test_hr.dll

mkurinnoi@starfive:~$ ./dotnet/corerun ./tools/dotnet-dump.dll collect --process-id 221935

Writing full to /home/mkurinnoi/core_20231024_104410
Complete

mkurinnoi@starfive:~$ ./dotnet/corerun ./tools/dotnet-dump.dll analyze /home/mkurinnoi/core_20231024_104410
Loading core dump: /home/mkurinnoi/core_20231024_104410 ...
Ready to process analysis commands. Type 'help' to list available commands or 'help [command]' to get detailed help on a command.
Type 'quit' or 'exit' to exit the session.
> clrstack
OS Thread Id: 0x362ef (0)
        Child SP               IP Call Site
0000003FD9F44F70 0000000000000000 [InlinedCallFrame: 0000003fd9f44f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FD9F44F70 0000003f353b5370 [InlinedCallFrame: 0000003fd9f44f70] Interop+Sys.<ReadStdin>g____PInvoke|44_0(Byte*, Int32)
0000003FD9F44F50 0000003F353B5370 ILStubClass.IL_STUB_PInvoke(Byte*, Int32)
0000003FD9F45050 0000003F353B51D4 Interop+Sys.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/Microsoft.Interop.LibraryImportGenerator/Microsoft.Interop.LibraryImportGenerator/LibraryImports.g.cs @ 800]
0000003FD9F45080 0000003F353B507C System.IO.StdInReader.ReadStdin(Byte*, Int32) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 83]
0000003FD9F450B0 0000003F353B4BD4 System.IO.StdInReader.ReadKey() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 337]
0000003FD9F45560 0000003F353B363C System.IO.StdInReader.ReadLineCore(Boolean) [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 160]
0000003FD9F45740 0000003F353B32AC System.IO.StdInReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/StdInReader.cs @ 90]
0000003FD9F457A0 0000003F353B3154 System.IO.SyncTextReader.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/IO/SyncTextReader.cs @ 77]
0000003FD9F457F0 0000003F353B1064 System.Console.ReadLine() [/home/runtime/src/libraries/System.Console/src/System/Console.cs @ 752]
0000003FD9F45820 0000003F3536DF10 TestApp.Program.Main(System.String[]) [/home/viewizard/Desktop/projects_test/test_hr/Program.cs @ 11]
> q
```
Note, I only start SOS commands implementation for RISC-V (almost
nothing work now).

CC @clamp03 @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4377)
dotnet-maestro[bot] [Tue, 31 Oct 2023 13:39:10 +0000 (13:39 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4377)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[main] Update dependencies from dotnet/arcade (#4373)
dotnet-maestro[bot] [Mon, 30 Oct 2023 13:23:50 +0000 (13:23 +0000)]
[main] Update dependencies from dotnet/arcade (#4373)

[main] Update dependencies from dotnet/arcade

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4372)
dotnet-maestro[bot] [Sat, 28 Oct 2023 13:27:04 +0000 (13:27 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4372)

[main] Update dependencies from dotnet/source-build-reference-packages

19 months ago[main] Update dependencies from dotnet/source-build-reference-packages (#4367)
dotnet-maestro[bot] [Thu, 26 Oct 2023 16:57:58 +0000 (09:57 -0700)]
[main] Update dependencies from dotnet/source-build-reference-packages (#4367)

This pull request updates the following dependencies

[marker]: <> (Begin:8fefa124-13dd-4c66-7dae-08d9c02d7834)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 8fefa124-13dd-4c66-7dae-08d9c02d7834
- **Build**: 20231025.1
- **Date Produced**: October 25, 2023 9:35:01 PM UTC
- **Commit**: 93a261562a815434ceaae0e3c5c15fb6e457f9c4
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23523.4 to 9.0.0-alpha.1.23525.1][1]

[1]:
https://github.com/dotnet/source-build-reference-packages/compare/c397c475b3...93a261562a

[DependencyUpdate]: <> (End)

[marker]: <> (End:8fefa124-13dd-4c66-7dae-08d9c02d7834)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>