Denis Kenzior [Tue, 9 Apr 2013 04:44:59 +0000 (23:44 -0500)]
drivers: Include hfp.h
Denis Kenzior [Tue, 9 Apr 2013 04:43:41 +0000 (23:43 -0500)]
core: Add hfp.h
This will serve as a collection point for all HFP related definitions.
Denis Kenzior [Tue, 9 Apr 2013 04:44:36 +0000 (23:44 -0500)]
include: Remove hfp bits from types.h
Vinicius Costa Gomes [Mon, 8 Apr 2013 22:41:03 +0000 (19:41 -0300)]
handsfree-audio: Remove unused 'codecs' field from agent
Now that we only keep track whether we support wideband speech or not, we
don't have to keep track of the list of codecs supported by the Agent.
Vinicius Costa Gomes [Mon, 8 Apr 2013 22:41:00 +0000 (19:41 -0300)]
handsfree-audio: Implement ofono_handsfree_audio_has_wideband
Vinicius Costa Gomes [Mon, 8 Apr 2013 22:40:59 +0000 (19:40 -0300)]
include: Add ofono_handsfree_audio_has_wideband()
As we can assume that the CVSD codec will be always available, the only
information that we need to export is if we have support for wideband
codecs. Right now only mSBC is defined as wideband.
Denis Kenzior [Tue, 9 Apr 2013 03:14:49 +0000 (22:14 -0500)]
hfp_hf_bluez5: Remove redundant parentheses
Vinicius Costa Gomes [Mon, 8 Apr 2013 22:40:58 +0000 (19:40 -0300)]
hfp_hf_bluez5: Add audio card .connect() for HFP 1.6
Luiz Augusto von Dentz [Wed, 27 Feb 2013 12:00:23 +0000 (14:00 +0200)]
gdbus: Fix not calling property_changed callback
In case a property did not appear by the time proxy_added was called
property_changed has to be called if it appear latter otherwise the
application will be unaware of it.
Lucas De Marchi [Mon, 8 Apr 2013 20:56:18 +0000 (17:56 -0300)]
gdbus: Use gcc builtin instead of g_atomic
g_atomic_* end up using G_STATIC_ASSERT, causing gcc 4.8 to yell due to
-Wunused-local-typedefs.
gdbus/client.c: In function ‘g_dbus_client_ref’:
/usr/include/glib-2.0/glib/gmacros.h:162:53: error: typedef ‘_GStaticAssertCompileTimeAssertion_2’ locally defined but not used [-Werror=unused-local-typedefs]
#define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1]
Vinicius Costa Gomes [Wed, 3 Apr 2013 23:24:39 +0000 (20:24 -0300)]
hfp_hf_bluez5: Use 1.6 card driver
Claudio Takahasi [Wed, 3 Apr 2013 23:24:37 +0000 (20:24 -0300)]
hfp_hf_bluez5: Add extracting version
This patch parses and reads the profile "Version" that comes in the fd
dictionary of the NewConnection method. "Version" is input for Audio Card
registration.
Forest Bond [Thu, 28 Mar 2013 21:00:40 +0000 (17:00 -0400)]
huawei: Use AlwaysOnline for CDMA modems
Forest Bond [Thu, 28 Mar 2013 21:00:32 +0000 (17:00 -0400)]
modem: Support modem property "AlwaysOnline"
This can be set by the modem driver to indicate that the device is
always in the online state when it is enabled. This is useful for
modem drivers that handle both CDMA and GSM devices.
Denis Kenzior [Tue, 2 Apr 2013 02:39:11 +0000 (21:39 -0500)]
AUTHORS: Mention Anthony's contributions
Anthony Viallard [Fri, 22 Mar 2013 10:36:17 +0000 (11:36 +0100)]
sim: Add SIMCOM SIM card ready quirk
SIM is busy right after pin is entered. Use the quirk which
add a CPIN? pooling check until having "CPIN: READY" answer.
Forest Bond [Thu, 28 Mar 2013 14:22:20 +0000 (10:22 -0400)]
modem: Allow setting boolean properties
Vinicius Costa Gomes [Thu, 28 Mar 2013 00:13:01 +0000 (21:13 -0300)]
handsfree-audio: Add .Connect using the card driver
Now each handsfree implementation may be notified that a card wants
its audio to be connected.
Vinicius Costa Gomes [Thu, 28 Mar 2013 00:13:00 +0000 (21:13 -0300)]
handsfree-audio: Add ofono_handsfree_card_connect_sco
Vinicius Costa Gomes [Thu, 28 Mar 2013 00:12:59 +0000 (21:12 -0300)]
include: Add ofono_handsfree_card_connect_sco()
This will be used by HFP plugins to tell the core that a SCO connection
needs to be established.
Denis Kenzior [Thu, 28 Mar 2013 14:30:45 +0000 (09:30 -0500)]
hfp_hf_bluez5: Make sure to call the callback
Vinicius Costa Gomes [Thu, 28 Mar 2013 00:12:58 +0000 (21:12 -0300)]
hfp_hf_bluez5: Add a card driver for HFP 1.6
This is just the skeleton of a Handsfree Audio Card for the HF side of
HFP 1.6.
Denis Kenzior [Wed, 27 Mar 2013 04:28:06 +0000 (23:28 -0500)]
include: Fix hf audio connect method declaration
Vinicius Costa Gomes [Mon, 25 Mar 2013 22:05:20 +0000 (19:05 -0300)]
handsfree-audio: Reject .Connect() from other senders
Only the agent should be able to call .Connect() on the card.
Vinicius Costa Gomes [Mon, 25 Mar 2013 22:05:19 +0000 (19:05 -0300)]
handsfree-audio: Add support for sending the SCO socket
Send the SCO socket to the agent associated with the card that
just got connected.
Vinicius Costa Gomes [Mon, 25 Mar 2013 22:05:18 +0000 (19:05 -0300)]
handsfree-audio: Add support for initiating SCO connections
When calling the card's .Connect() method, we should be able to
establish a SCO connection.
Right now, we only have support for establishing the SCO connection
directly, this is what is expected from HFP 1.5 HF/AG devices.
Denis Kenzior [Tue, 26 Mar 2013 15:53:41 +0000 (10:53 -0500)]
sim900: Fix disable cleanup procedure
Denis Kenzior [Tue, 26 Mar 2013 15:36:25 +0000 (10:36 -0500)]
sim900: Fix compile error
make --no-print-directory all-am
CC plugins/sim900.o
cc1: warnings being treated as errors
plugins/sim900.c: In function ‘shutdown_device’:
plugins/sim900.c:180:9: error: unused variable ‘fd’
make[1]: *** [plugins/sim900.o] Error 1
make: *** [all] Error 2
Denis Kenzior [Tue, 26 Mar 2013 15:35:59 +0000 (10:35 -0500)]
sim900: Remove unneeded goto / label
Denis Kenzior [Tue, 26 Mar 2013 15:34:09 +0000 (10:34 -0500)]
sim900: Properly clean up device IOChannel on error
Renat Zaripov [Tue, 12 Mar 2013 14:37:58 +0000 (18:37 +0400)]
sim900: Add multiplexer support
Also add gprs and call-volume support.
Denis Kenzior [Tue, 26 Mar 2013 15:18:57 +0000 (10:18 -0500)]
sim900: Fix leak of options hash table
Daniel Wagner [Sun, 24 Mar 2013 12:33:47 +0000 (13:33 +0100)]
TODO: Mark BlueZ 5 support in dundee as done
Paulo Borges [Wed, 20 Mar 2013 22:26:42 +0000 (19:26 -0300)]
dundee: Handle Profile connect and disconnect
Paulo Borges [Wed, 20 Mar 2013 22:26:41 +0000 (19:26 -0300)]
dundee: Add dundee disconnect function
Paulo Borges [Wed, 20 Mar 2013 22:26:40 +0000 (19:26 -0300)]
dundee: Add support for driver connect
This patch glues together the dundee driver interface with the
D-Bus Profile1 interface.
When the dundee driver requests a connection, it will call the
Device1's ConnectProfile.
Paulo Borges [Wed, 20 Mar 2013 22:26:39 +0000 (19:26 -0300)]
dundee: Add BlueZ Profile handler
This patch declares the external dundee Profile handler. It
contains the initial implementation of the D-Bus Profile1
interface and methods responsible for handling Bluetooth
connections.
Paulo Borges [Wed, 20 Mar 2013 22:26:38 +0000 (19:26 -0300)]
dundee: Register/unregister dundee device
This patch adds the dundee device struct to the our Bluetooth
device representation.
Paulo Borges [Wed, 20 Mar 2013 22:26:37 +0000 (19:26 -0300)]
dundee: Add dundee device driver skeleton
This patch adds the functions to be called when the dundee will
connect or disconnect with a Bluetooth device.
Paulo Borges [Wed, 20 Mar 2013 22:26:36 +0000 (19:26 -0300)]
dundee: Listen to devices property changes
When a bluetooth device property change and this property is Alias,
we need to refresh our representation of this device.
Paulo Borges [Wed, 20 Mar 2013 22:26:35 +0000 (19:26 -0300)]
dundee: Add tracking of bluetooth devices
This patch tracks the GDBusProxy for Bluetooth devices in order to
be able to get their properties.
Paulo Borges [Wed, 20 Mar 2013 22:26:34 +0000 (19:26 -0300)]
dundee: Add mechanism to store bluetooth devices
This patch adds a hash that will store every known bluetooth
device that implements DUN service.
Paulo Borges [Wed, 20 Mar 2013 22:26:33 +0000 (19:26 -0300)]
dundee: Initial GDBusClient for BlueZ 5
This patch adds callbacks to track additions of BlueZ related
interfaces.
Paulo Borges [Wed, 20 Mar 2013 22:26:31 +0000 (19:26 -0300)]
dundee: Start BlueZ 5 support
This patch adds the BlueZ 5 support file for dundee.
Paulo Borges [Wed, 20 Mar 2013 22:26:30 +0000 (19:26 -0300)]
dundee: Rename dundee BlueZ 4 support
The BlueZ 4 support file for dundee has now been renamed to
bluez4.c to make it easier to add a BlueZ 5 support file.
Denis Kenzior [Thu, 21 Mar 2013 15:19:00 +0000 (10:19 -0500)]
hfp_ag_bluez5: Fix sanity check
We should be checking that modems != NULL, not modems->data. This is
because the list can be empty and we would crash.
Denis Kenzior [Thu, 21 Mar 2013 15:18:11 +0000 (10:18 -0500)]
dun_gw_bluez5: Fix sanity check
We should be checking that modems != NULL, not modems->data. This is
because the list can be empty and we would crash.
Denis Kenzior [Thu, 21 Mar 2013 15:15:16 +0000 (10:15 -0500)]
dun_gw_bluez5: Fix copy-paste error
Frédéric Danis [Tue, 12 Mar 2013 13:01:30 +0000 (14:01 +0100)]
dun_gw: Add BlueZ 5 version
This patch adds initial implementation of the D-Bus Profile1
interface and methods responsible for handling Bluetooth connections.
The DUN GW profile interface is registered as soon as a GPRS capable
modem is registered in oFono.
Frédéric Danis [Tue, 12 Mar 2013 13:01:29 +0000 (14:01 +0100)]
bluetooth: Rename DUN GW plugin
As BlueZ 5 introduced backwards incompatible API changes, and we want to
keep support for BlueZ 4 based DUN GW plugin for some time, we need to
separate DUN GW plugin which is based on BlueZ 4 from the one based on
BlueZ 5.
The dun_gw.c plugin is renamed to dun_gw_bluez4. This will make it easy
to add a DUN GW plugin for BlueZ 5.
Claudio Takahasi [Wed, 20 Mar 2013 23:03:04 +0000 (20:03 -0300)]
doc: Add Handsfree Audio Card "Connect" errors
Vinicius Costa Gomes [Wed, 20 Mar 2013 00:10:33 +0000 (21:10 -0300)]
ofono.conf: Punch hole for HandsfreeAudioAgent
Denis Kenzior [Mon, 18 Mar 2013 19:06:56 +0000 (14:06 -0500)]
handsfree_audio: Call driver remove() on removal
Claudio Takahasi [Tue, 12 Mar 2013 12:42:05 +0000 (09:42 -0300)]
core: Add bt_str2ba() to bluetooth.h
This patch adds a utility Bluetooth function to convert Bluetooth
address from string to bdaddr_t.
Denis Kenzior [Mon, 18 Mar 2013 18:57:30 +0000 (13:57 -0500)]
hfp_hf_bluez5: Set remote and local information
Denis Kenzior [Mon, 18 Mar 2013 18:42:12 +0000 (13:42 -0500)]
hfp_hf_bluez5: Update to the new API
Denis Kenzior [Mon, 18 Mar 2013 18:42:00 +0000 (13:42 -0500)]
handsfree-audio: Match new card API
Denis Kenzior [Mon, 18 Mar 2013 18:41:17 +0000 (13:41 -0500)]
include: Refactor ofono_handsfree_card_create
Denis Kenzior [Wed, 13 Mar 2013 18:14:39 +0000 (13:14 -0500)]
handsfree-audio: Implement get/set data
Denis Kenzior [Wed, 13 Mar 2013 18:13:59 +0000 (13:13 -0500)]
include: Add get/set data handsfree audio card
Denis Kenzior [Wed, 13 Mar 2013 18:01:55 +0000 (13:01 -0500)]
handsfree-audio: Add card driver registration
Denis Kenzior [Wed, 13 Mar 2013 18:01:40 +0000 (13:01 -0500)]
include: Add handsfree card driver registration
Claudio Takahasi [Fri, 8 Mar 2013 23:08:48 +0000 (20:08 -0300)]
hfp_hf_bluez5: Remove duplicated include
Claudio Takahasi [Mon, 4 Mar 2013 20:48:53 +0000 (17:48 -0300)]
handsfree-audio: Reject SCO if agent is unavailable
This patch rejects the incoming SCO connection if there isn't a
Handsfree Audio Agent registered.
Claudio Takahasi [Mon, 4 Mar 2013 20:48:52 +0000 (17:48 -0300)]
handsfree-audio: Reject SCO if Card is not ready
The Audio Card is being created when the NewConnection from BlueZ
Profile is received, and registered when the service level connection
negotiation finishes. This patch rejects SCO connection if the SCO
incoming connection arrives when the service level negotiation is
ongoing.
Claudio Takahasi [Mon, 4 Mar 2013 20:48:51 +0000 (17:48 -0300)]
handsfree-audio: Check local SCO address
This patch verifies if the local Bluetooth address of the incoming
connection also matches with one of available audio cards.
Claudio Takahasi [Mon, 4 Mar 2013 20:48:50 +0000 (17:48 -0300)]
handsfree-audio: Add NewConnection
This patch adds Agent NewConnection call. The card object path, the SCO
file descriptor, and the codec are being passed to the agent. This
initial version supports CVSD codec only.
Claudio Takahasi [Mon, 4 Mar 2013 20:48:49 +0000 (17:48 -0300)]
handsfree-audio: Add SCO handling
Unlike the previous implementation in the plugin, the SCO/SLC matching
is done based on the Audio Card objects.
Audio Cards are created when the RFCOMM fd descriptor is received, and
registered when the service level connetion is established.
Claudio Takahasi [Mon, 4 Mar 2013 20:48:49 +0000 (17:48 -0300)]
hfp_hf_bluez5: Remove SCO handling
This patch moves the SCO socket handling from hfp_hf_bluez5 plugin. It
will be instead handled by the handsfree-audio functionality. This is
the initial step to be able to support sending the file descriptor
through the Agent NewConnection method.
Claudio Takahasi [Mon, 4 Mar 2013 20:48:48 +0000 (17:48 -0300)]
hfp_hf_bluez5: Use new bluetooth.h header
Claudio Takahasi [Mon, 4 Mar 2013 20:48:48 +0000 (17:48 -0300)]
bluez5: Remove Bluetooth related utilities
Claudio Takahasi [Mon, 4 Mar 2013 20:48:48 +0000 (17:48 -0300)]
core: Add new Bluetooth header
This patch adds the Bluetooth utility funtions and socket type
declarations to a new header src/bluetooth.h, allowing to share it
between core, and plugins.
Paulo Borges [Fri, 1 Mar 2013 21:58:59 +0000 (18:58 -0300)]
bluez5: Add bt_register_profile_with_role
This function allows to specify which role is registering when the
profile does not have specific UUIDs for each role.
Claudio Takahasi [Thu, 28 Feb 2013 18:52:50 +0000 (15:52 -0300)]
handsfree-audio: Check CVSD when registering agent
This patch makes CVSD codec mandatory when registering a Handsfree
Audio Agent.
Paulo Borges [Wed, 27 Feb 2013 21:49:13 +0000 (18:49 -0300)]
bluez5: Move ref / unref handsfree audio
This commit moves the ref / unref to hfp_hf_bluez5 to make
bluez5 more generic and reusable.
Claudio Takahasi [Thu, 28 Feb 2013 16:01:10 +0000 (13:01 -0300)]
hfp_hf_bluez5: Remove Card on RequestDisconnection
For local initiated disconnection the GAtChat disconnect callback is not
called. For this case, Audio Card remove function needs to be called.
Claudio Takahasi [Thu, 28 Feb 2013 16:01:09 +0000 (13:01 -0300)]
hfp_hf_bluez5: Remove Card when modem is disabled
Claudio Takahasi [Thu, 28 Feb 2013 16:01:08 +0000 (13:01 -0300)]
hfp_hf_bluez5: Remove Card if SLC is disconnected
This patch removes previous registered Audio Card when the remote
Bluetooth device triggers the service level disconnection.
Claudio Takahasi [Thu, 28 Feb 2013 16:01:07 +0000 (13:01 -0300)]
hfp_hf_bluez5: Remove Card when SLC fails
This patch removes the previously created Audio Card if the service
level negotiation fails.
Claudio Takahasi [Thu, 28 Feb 2013 16:01:06 +0000 (13:01 -0300)]
hfp_hf_bluez5: Add local address to Audio Card
Claudio Takahasi [Thu, 28 Feb 2013 16:01:05 +0000 (13:01 -0300)]
hfp_hf_bluez5: Add registering Audio Card
This patch registers the Handsfree Audio Card when the service level
connection is established.
Denis Kenzior [Tue, 26 Feb 2013 21:46:43 +0000 (15:46 -0600)]
handsfree-audio: properly increment next_card_id
Claudio Takahasi [Tue, 26 Feb 2013 15:59:03 +0000 (12:59 -0300)]
doc: Add possible handsfree-audio API errors
This patch adds possible errors that can be returned by Register and
Unregister methods of the Manager interface.
Patrik Flykt [Tue, 26 Feb 2013 11:15:52 +0000 (13:15 +0200)]
bluez4: Increase Bluez 4 D-Bus timeouts to 60 seconds
RequestAuthorization method call may trigger pairing and/or pop up a
dialog in the remote device to which the user needs to react. Thus
increase D-Bus timeouts to 60 seconds for the Bluez 4 plugin.
Denis Kenzior [Tue, 26 Feb 2013 20:12:09 +0000 (14:12 -0600)]
handsfree-audio: Impelement CardRemoved signal
Denis Kenzior [Tue, 26 Feb 2013 20:03:04 +0000 (14:03 -0600)]
handsfree-audio: Implement CardAdded signal
Denis Kenzior [Tue, 26 Feb 2013 19:48:46 +0000 (13:48 -0600)]
handsfree-audio: Implement the GetCards method
Denis Kenzior [Tue, 26 Feb 2013 19:35:38 +0000 (13:35 -0600)]
handsfree-audio: Implement card GetProperties
Denis Kenzior [Tue, 26 Feb 2013 20:09:15 +0000 (14:09 -0600)]
handsfree-audio: Unregister from DBus on removal
Denis Kenzior [Tue, 26 Feb 2013 19:22:02 +0000 (13:22 -0600)]
handsfree-audio: Add skeleton D-Bus registration
For HandsfreeAudioCard objects
Denis Kenzior [Tue, 26 Feb 2013 20:01:47 +0000 (14:01 -0600)]
handsfree-audio: Don't hardcode '/' path
Use OFONO_MANAGER_PATH instead
Denis Kenzior [Tue, 26 Feb 2013 19:21:32 +0000 (13:21 -0600)]
include: Add handsfree card register method
Denis Kenzior [Tue, 26 Feb 2013 17:03:00 +0000 (11:03 -0600)]
handsfree-audio: Implement card create / remove
Denis Kenzior [Tue, 26 Feb 2013 17:02:43 +0000 (11:02 -0600)]
include: Add handsfree card create / remove API
Claudio Takahasi [Mon, 25 Feb 2013 13:48:39 +0000 (10:48 -0300)]
audio-settings: Fix unneeded async for GetProperties
GetProperties method call for Audio settings returns the reply in the
same iteraction, it doesn't need to be asynchronous.
Tomasz Bursztyka [Fri, 8 Feb 2013 13:58:10 +0000 (15:58 +0200)]
gdbus: Always unreference the message in g_dbus_send_message()
A quick fix on g_dbus_send_message(), if check_signal() fails it returns
FALSE without unreferencing the message as it should. This patch fixes
it.
Denis Kenzior [Fri, 22 Feb 2013 17:29:26 +0000 (11:29 -0600)]
AUTHORS: Mention Paulo's contributions
Paulo Borges [Fri, 22 Feb 2013 17:01:12 +0000 (14:01 -0300)]
dundee: Fix typo in dundee-disconnect test
Paulo Borges [Fri, 22 Feb 2013 17:01:11 +0000 (14:01 -0300)]
dundee: Fix typo in Manager's signal DeviceAdded
This typo was preventing dundee from sending the signal.
Claudio Takahasi [Thu, 21 Feb 2013 22:24:42 +0000 (19:24 -0300)]
hfpmodem: Fix segfault in CIEV GAtChat callback
This patch fixes segmentation fault when the network registration
watch is called without being initialized. CIEV GAtChat callback can
be called before ofono_netreg_register().
==15101== Invalid read of size 8
==15101== at 0x492B56: ofono_netreg_register (network.c:2073)
==15101== by 0x47245E: hfp_netreg_probe (network-registration.c:311)
==15101== by 0x492A8D: ofono_netreg_create (network.c:1881)
==15101== by 0x4849D5: hfp_pre_sim (hfp_hf_bluez5.c:288)
==15101== by 0x48C486: ofono_modem_set_powered (modem.c:1194)
==15101== by 0x484E9D: slc_established (hfp_hf_bluez5.c:85)
==15101== by 0x4702AD: chld_cb (slc.c:147)
==15101== by 0x440457: at_chat_finish_command (gatchat.c:461)
==15101== by 0x44109F: new_bytes (gatchat.c:532)
==15101== by 0x4433B7: received_data (gatio.c:122)
==15101== by 0x3CBAA47824: g_main_context_dispatch (gmain.c:2539)
==15101== by 0x3CBAA47B57: g_main_context_iterate.isra.23
(gmain.c:3146)
==15101== Address 0x18 is not stack'd, malloc'd or (recently) free'd