Bernhard Miklautz [Tue, 1 Mar 2016 11:45:25 +0000 (12:45 +0100)]
winpr/TestFileGetStdHandle: rename variable stdout
stdout shouldn't be used as variable name (can't even be used on
windows).
akallabeth [Thu, 17 Mar 2016 10:06:39 +0000 (11:06 +0100)]
Merge pull request #3243 from hardening/typofix
Fixed a typo in debug messages
Bernhard Miklautz [Thu, 17 Mar 2016 10:02:51 +0000 (11:02 +0100)]
Merge pull request #3240 from akallabeth/drive_fixes
Small Drive fixes
David FORT [Thu, 17 Mar 2016 09:44:11 +0000 (10:44 +0100)]
Fixed a typo in debug messages
Armin Novak [Thu, 17 Mar 2016 08:34:24 +0000 (09:34 +0100)]
Replace SetFilePointerEx with SetFilePointer.
Armin Novak [Thu, 17 Mar 2016 08:33:39 +0000 (09:33 +0100)]
Print device name when loading channel.
Martin Fleisz [Wed, 16 Mar 2016 14:19:11 +0000 (15:19 +0100)]
Merge pull request #3164 from akallabeth/windows_UnixChangeFileMode
Implemented UnixChangeFileMode for windows.
Bernhard Miklautz [Wed, 16 Mar 2016 13:05:55 +0000 (14:05 +0100)]
Merge pull request #3215 from akallabeth/avc_444
Avc 444 support
Bernhard Miklautz [Wed, 16 Mar 2016 12:56:39 +0000 (13:56 +0100)]
Merge pull request #3204 from akallabeth/rdp_file_preference_fix
Rdp file preference fix
Armin Novak [Wed, 16 Mar 2016 12:46:47 +0000 (13:46 +0100)]
Assume the update rectangle is inclusive.
Armin Novak [Mon, 14 Mar 2016 08:01:57 +0000 (09:01 +0100)]
Fixed comments.
Armin Novak [Mon, 14 Mar 2016 07:57:00 +0000 (08:57 +0100)]
Renamed GFX defines to conform to spec.
Armin Novak [Wed, 2 Mar 2016 14:16:49 +0000 (15:16 +0100)]
Implemented GFX AVC444 support.
Armin Novak [Wed, 2 Mar 2016 13:53:55 +0000 (14:53 +0100)]
Implemented YUV444 related primitives.
Armin Novak [Wed, 2 Mar 2016 13:39:36 +0000 (14:39 +0100)]
Unified RDPGFX_RECT16 and RECTANGLE_16
akallabeth [Wed, 16 Mar 2016 12:32:51 +0000 (13:32 +0100)]
Merge pull request #3226 from rjcorrig/#3198
winpr: Updates time zones and fixes bias values
akallabeth [Wed, 16 Mar 2016 12:32:29 +0000 (13:32 +0100)]
Merge pull request #3234 from bmiklautz/rdkt_version
Increase rdtk version to 2.0.0
Robert Corrigan [Wed, 16 Mar 2016 12:29:21 +0000 (08:29 -0400)]
winpr_detect_windows_time_zone should have void argument
Armin Novak [Wed, 16 Mar 2016 12:15:39 +0000 (13:15 +0100)]
Parse RDP and assistance files in parser.
The command line parser is now populating the settings with
the RDP or assistance file content before parsing the rest
of the arguments.
Armin Novak [Wed, 16 Mar 2016 12:05:00 +0000 (13:05 +0100)]
Removed windows extra handling for RDP files.
Bernhard Miklautz [Wed, 16 Mar 2016 12:15:24 +0000 (13:15 +0100)]
Increase rdtk version to 2.0.0
rdtk was initially 1.0.0 then changed to 0.0.1.
To have a clean cut and prevent problems on systems which already have
FreeRDP in a version where rdtk was 1.0.0 increase it to 2.0.0
Armin Novak [Wed, 16 Mar 2016 12:08:06 +0000 (13:08 +0100)]
Updated ConvertToUnicode return check.
Bernhard Miklautz [Wed, 16 Mar 2016 12:03:33 +0000 (13:03 +0100)]
Merge pull request #3207 from akallabeth/mic_crash_fix
Fixed error handling for channel load failures.
Armin Novak [Wed, 16 Mar 2016 11:39:36 +0000 (12:39 +0100)]
Fixed double free.
Bernhard Miklautz [Wed, 16 Mar 2016 10:58:31 +0000 (11:58 +0100)]
Merge pull request #3214 from hardening/fix_systemd_appender
Make systemd appender honor layout and logs off
akallabeth [Tue, 15 Mar 2016 08:25:50 +0000 (09:25 +0100)]
Merge pull request #3225 from mfleisz/fix_set_err_info
freerdp: Fix possible crash when setting error info in server-mode
Robert Corrigan [Thu, 10 Mar 2016 20:10:49 +0000 (15:10 -0500)]
winpr: Updates time zones and fixes bias values
Bernhard Miklautz [Mon, 14 Mar 2016 14:28:56 +0000 (15:28 +0100)]
Merge pull request #3223 from comicfans/wayland_fix
only compile wayland client when WAYLAND_FOUND
Martin Fleisz [Mon, 14 Mar 2016 14:27:15 +0000 (15:27 +0100)]
freerdp: Fix possible crash when setting error info in server-mode
Bernhard Miklautz [Mon, 14 Mar 2016 14:13:52 +0000 (15:13 +0100)]
Merge pull request #3224 from mfleisz/win32_bld_fix
winpr: Fix definition of PathFileExists on Win32
Martin Fleisz [Mon, 14 Mar 2016 13:08:48 +0000 (14:08 +0100)]
winpr: Fix definition of PathFileExists on Win32
comicfans44 [Mon, 14 Mar 2016 12:51:50 +0000 (12:51 +0000)]
only compile wayland client when WAYLAND_FOUND
Armin Novak [Mon, 14 Mar 2016 12:19:08 +0000 (13:19 +0100)]
Reverted WTS API changes.
Armin Novak [Tue, 8 Mar 2016 12:19:40 +0000 (13:19 +0100)]
Fixed return value for failed malloc.
Armin Novak [Mon, 7 Mar 2016 11:54:49 +0000 (12:54 +0100)]
Fixed error handling for channel load failures.
Bernhard Miklautz [Mon, 14 Mar 2016 12:00:52 +0000 (13:00 +0100)]
Merge pull request #3209 from akallabeth/android_translation_fix
Reverted translation of internal VALUE arrays.
akallabeth [Mon, 14 Mar 2016 09:08:25 +0000 (10:08 +0100)]
Merge pull request #3221 from bmiklautz/fix_nightlies
pkg/deb: adapt channel paths
Bernhard Miklautz [Mon, 14 Mar 2016 08:57:33 +0000 (09:57 +0100)]
Merge pull request #3212 from realjiangms/fix_default_audin
audin: Fixed default sys argument for audin
Armin Novak [Mon, 14 Mar 2016 08:53:45 +0000 (09:53 +0100)]
Removed untranslatable strings from translated files.
Bernhard Miklautz [Mon, 14 Mar 2016 08:38:35 +0000 (09:38 +0100)]
pkg/deb: adapt channel paths
Martin Fleisz [Mon, 14 Mar 2016 08:20:30 +0000 (09:20 +0100)]
Merge pull request #3213 from akallabeth/android_build_fixes
Android build and settings fixes
Martin Fleisz [Fri, 11 Mar 2016 10:22:59 +0000 (11:22 +0100)]
Merge pull request #3177 from akallabeth/codec_reset_fix
Fixed codec reset, now resetting resolution too.
Hardening [Thu, 10 Mar 2016 22:41:12 +0000 (23:41 +0100)]
Make systemd appender honor layout and log off
Armin Novak [Thu, 10 Mar 2016 21:07:30 +0000 (22:07 +0100)]
Replaced version patch with make argument.
Armin Novak [Thu, 10 Mar 2016 20:54:11 +0000 (21:54 +0100)]
Updated OpenSSL version in script.
Armin Novak [Thu, 10 Mar 2016 20:52:40 +0000 (21:52 +0100)]
Fixed settings load/store.
Armin Novak [Thu, 10 Mar 2016 20:18:19 +0000 (21:18 +0100)]
Fixed paralell building issue.
zihao.jiang [Thu, 10 Mar 2016 17:52:18 +0000 (01:52 +0800)]
audin: Fixed default sys argument for audin
PR #3173 fixed argument parsing. However it breaks the usage without specifying subsystem: "/microphone"
In particular, aFreerdp microphone redirect is broken as it exactly uses "/microphone"
This PR fixes the regression.
Fix: We should not call CommandLineParseArgumentsA if argc is only 1 (same case as rdpsnd_main.c)
Martin Fleisz [Thu, 10 Mar 2016 07:22:30 +0000 (08:22 +0100)]
Merge pull request #3210 from hardening/env_fix
Don't require HOME env var to be set for server-side code
David FORT [Wed, 9 Mar 2016 13:10:31 +0000 (14:10 +0100)]
Don't require HOME env var to be set for server-side code
Armin Novak [Tue, 8 Mar 2016 19:34:19 +0000 (20:34 +0100)]
Marked non translatable strings as such.
Armin Novak [Tue, 8 Mar 2016 15:27:51 +0000 (16:27 +0100)]
Reverted translation of internal VALUE arrays.
akallabeth [Tue, 8 Mar 2016 19:50:30 +0000 (20:50 +0100)]
Merge pull request #3172 from realjiangms/android_launch_by_scheme_2720
android: Allow freerdp mobile version to be launched from URI (freerdp://)
zihao.jiang [Sat, 27 Feb 2016 10:31:43 +0000 (18:31 +0800)]
android: Allow freerdp mobile version to be launched from URI (freerdp://)
It would be good if we have a easy way to call aFreeRDP in another Android APP (Requirement also mentioned in #2720)
We can define a scheme (freerdp://) as unified way to launch FreeRDP from another APP or browser and connect to compatible RDP server
1. Define scheme freerdp://
2. General form could be freerdp://user@hostname:port/connect?key1=value&key2=-&key3=%2b&key4=
3. [user] part would be translated to /u:
4. [hostname:port] would be translated to /v:
5. The [user@hostname:port] part would be used as app title, currently it's just the progress dialog title
6. query parameters would be translated to command line arguments. Later same arguments will overwrite the formers:
a. key1=value: => /key1:value
b. key2=-: => -key2
c. key3=%2b => +key3 (%2b is url encoded +)
d. key4= => /key4
e. Especially, drive=sdcard will be properly handled with local sdcard path. On my device it will be translated to /drive:sdcard,/storage/emulated/0
Owing to the refactor work in PR #3097, we now pass same command line argument to JNI for freerdp settings.
We just need to make the SessionActivity accept freerdp scheme and translate argument from URI form to command line form.
Martin Fleisz [Tue, 8 Mar 2016 09:05:57 +0000 (10:05 +0100)]
Merge pull request #3181 from akallabeth/wlog_filter_fix
Respecting filter in WLog_GetLogLevel
Bernhard Miklautz [Mon, 7 Mar 2016 14:39:59 +0000 (15:39 +0100)]
Merge pull request #3206 from akallabeth/openssl_unification
Moved assistance to winpr crypto.
Armin Novak [Mon, 7 Mar 2016 12:12:38 +0000 (13:12 +0100)]
Set variable to NULL to prevent double free.
Armin Novak [Mon, 7 Mar 2016 10:51:13 +0000 (11:51 +0100)]
Moved assistance to winpr crypto.
akallabeth [Mon, 7 Mar 2016 09:55:51 +0000 (10:55 +0100)]
Merge pull request #3086 from DavBfr/fix-rdpdr
Fixes for rdpdr
akallabeth [Mon, 7 Mar 2016 09:50:35 +0000 (10:50 +0100)]
Merge pull request #3200 from dwmw2/master
winpr: Bump API version to 2.0
Armin Novak [Mon, 7 Mar 2016 08:43:35 +0000 (09:43 +0100)]
Use common command line parser.
Armin Novak [Mon, 7 Mar 2016 08:43:53 +0000 (09:43 +0100)]
Reparse command line after RDP or assistance file.
Armin Novak [Mon, 7 Mar 2016 08:44:07 +0000 (09:44 +0100)]
Fix memory leaks if parsed multiple times.
Martin Fleisz [Mon, 7 Mar 2016 08:24:44 +0000 (09:24 +0100)]
Merge pull request #3202 from akallabeth/file_bsd_fix
Fixed FreeBSD support for filetime settings.
Armin Novak [Fri, 4 Mar 2016 08:25:04 +0000 (09:25 +0100)]
Fixed FreeBSD support for filetime settings.
David Woodhouse [Fri, 4 Mar 2016 13:22:58 +0000 (13:22 +0000)]
winpr: Bump API version to 2.0
In commit
12bd0ec8 ("winpr: BUMP the API version to 1.2") it was stated
that the intention was to allow multiple winpr versions to be installed
in parallel.
However, it's not sufficient to change just the *minor* version of the
library. The soname is still 'libwinpr.so.1', and thus we still can't
coexist with earlier versions — in particular, we can't install FreeRDP2
in parallel with existing distribution packages of earlier versions.
Bump the soname so it does actually work
Hardening [Fri, 4 Mar 2016 10:19:00 +0000 (11:19 +0100)]
Merge pull request #3194 from nfedera/fix-convertfromunicode-hardening
ConvertFromUnicode fixes and misc hardening
Bernhard Miklautz [Fri, 4 Mar 2016 10:17:42 +0000 (11:17 +0100)]
Merge pull request #1726 from grpomega/patch-3
Need Week instead of Day for TZ transistion
Norbert Federa [Thu, 3 Mar 2016 23:45:26 +0000 (00:45 +0100)]
fix logon info processing
since there have been reports that certain windows versions send
zero values in the cbDomain field of the Logon Info Version 2
(TS_LOGON_INFO_VERSION_2) struct we allow zero values for cbUserName
and cbDomain in rdp_recv_logon_info_v1 and rdp_recv_logon_info_v2.
Bernhard Miklautz [Thu, 3 Mar 2016 19:39:31 +0000 (20:39 +0100)]
Merge pull request #3173 from akallabeth/audin_arg_fix
Fixed argument parsing for audin.
Martin Fleisz [Thu, 3 Mar 2016 16:34:57 +0000 (17:34 +0100)]
Merge pull request #3196 from akallabeth/exported_symbols_fix
Fixed symbol export for sound plugins.
Armin Novak [Thu, 3 Mar 2016 16:11:26 +0000 (17:11 +0100)]
Fixed symbol export for sound plugins.
Norbert Federa [Thu, 3 Mar 2016 15:21:12 +0000 (16:21 +0100)]
ConvertFromUnicode fixes and misc hardening
- Added missing ConvertFromUnicode checks
- If ConvertToUnicode allocates memory, guarantee the null termination
similar to ConvertFromUnicode's implementation
- Fixed some TestUnicodeConversion.c CTest return values
- Added some CTests for ConvertFromUnicode and ConvertToUnicode
- Misc code and protocol hardening fixes in the surrounding code regions
that have been touched
Bernhard Miklautz [Thu, 3 Mar 2016 12:58:42 +0000 (13:58 +0100)]
Merge pull request #3192 from akallabeth/plugin_path_fix
Updated freerdp plugin path to use major version.
Armin Novak [Thu, 3 Mar 2016 11:07:10 +0000 (12:07 +0100)]
Caching log filter after first use.
Reduce runtime penalty for log level checks by
remembering the log level found during first call.
Martin Fleisz [Thu, 3 Mar 2016 11:12:21 +0000 (12:12 +0100)]
Merge pull request #3191 from hardening/saveInfoPdu_fix
Fix parsing of saveSessionInfo PDU
David FORT [Thu, 3 Mar 2016 10:45:12 +0000 (11:45 +0100)]
Fix parsing of saveSessionInfo PDU
This should fix the case when no username is sent (issue #3186).
Armin Novak [Thu, 3 Mar 2016 10:36:26 +0000 (11:36 +0100)]
Updated freerdp plugin path to use major version.
Martin Fleisz [Thu, 3 Mar 2016 10:06:24 +0000 (11:06 +0100)]
Merge pull request #3187 from akallabeth/client_name_fix
Gateway fix
Armin Novak [Thu, 3 Mar 2016 08:08:30 +0000 (09:08 +0100)]
Removed additional '\0' from TUNNEL_AUTH message.
Hardening [Wed, 2 Mar 2016 19:53:19 +0000 (20:53 +0100)]
Merge pull request #3184 from xhaakon/fix-ubuntu-gcc-build
Fix build on older 32-bit Ubuntu releases
Jakub Adam [Tue, 23 Feb 2016 14:27:33 +0000 (15:27 +0100)]
Fix build on older 32-bit Ubuntu releases
Some older 32-bit versions of gcc fail on '#elif __x86_64__'.
This applies at least to what Ubuntu 14.04 and 15.04 have as
the default compiler.
Armin Novak [Wed, 2 Mar 2016 18:02:01 +0000 (19:02 +0100)]
Remember filter log level.
David PHAM-VAN [Wed, 2 Mar 2016 01:10:22 +0000 (17:10 -0800)]
Fix Uninitialized Variable
akallabeth [Wed, 2 Mar 2016 18:03:46 +0000 (19:03 +0100)]
Merge pull request #3183 from bmiklautz/timezone_regression
winpr: fix regression in timezone detection
David PHAM-VAN [Fri, 26 Feb 2016 18:32:54 +0000 (10:32 -0800)]
Mount only removable devices and network drives in Windows; Adds consistency with Linux and Mac
David PHAM-VAN [Fri, 26 Feb 2016 18:31:14 +0000 (10:31 -0800)]
Move first_hotplug call to parent thread to avoid parallel access to devman dictionary
David PHAM-VAN [Fri, 26 Feb 2016 18:19:21 +0000 (10:19 -0800)]
Improve code using more winpr functions
David PHAM-VAN [Mon, 7 Sep 2015 10:16:03 +0000 (12:16 +0200)]
Add hotplug support for MacOS
David PHAM-VAN [Thu, 7 Jan 2016 19:04:10 +0000 (11:04 -0800)]
Implement FileAllocationInformation
Bernhard Miklautz [Wed, 2 Mar 2016 17:37:48 +0000 (12:37 -0500)]
winpr: fix regression in timezone detection
ConvertToUnicode can't be used if the destination is a static buffer.
StandardName and DaylightName were invalid and timezone
redirection didn't work.
This regression was introduced with PR #3151
Bernhard Miklautz [Wed, 2 Mar 2016 15:33:41 +0000 (10:33 -0500)]
Merge pull request #3182 from xhaakon/shadow-pkg-config
shadow/subsystem: fix pkgconfig file
Jakub Adam [Wed, 2 Mar 2016 09:20:12 +0000 (10:20 +0100)]
shadow/subsystem: fix pkgconfig file
Add freerdp-shadow-subsystem to 'libs' in order to avoid undefined
reference to shadow_subsystem_set_entry_builtin at runtime.
Remove cyclic dependency on itself.
Armin Novak [Tue, 1 Mar 2016 16:30:08 +0000 (17:30 +0100)]
Fixed broken resource cleanup.
Armin Novak [Tue, 1 Mar 2016 16:14:35 +0000 (17:14 +0100)]
Fixed context reset of sample server.
Armin Novak [Tue, 1 Mar 2016 15:56:36 +0000 (16:56 +0100)]
Fixed broken check.
Armin Novak [Tue, 1 Mar 2016 15:39:53 +0000 (16:39 +0100)]
Added log messages for unsupported surface commands.
Armin Novak [Tue, 1 Mar 2016 15:17:28 +0000 (16:17 +0100)]
Fixed codec reset, now resetting resolution too.
H264 and others require the surface resolution to work properly.
This initializes the codecs and the resolution on reset.
Armin Novak [Wed, 2 Mar 2016 13:11:15 +0000 (14:11 +0100)]
Respecting filter in WLog_GetLogLevel
Martin Fleisz [Wed, 2 Mar 2016 08:43:46 +0000 (09:43 +0100)]
Merge pull request #3163 from akallabeth/set_file_time
Implemented SetFileTime