mike@reedtribe.org [Fri, 4 Jan 2013 03:16:52 +0000 (03:16 +0000)]
reorder internal files, in preparation for refactoring. no functional change.
git-svn-id: http://skia.googlecode.com/svn/trunk@7009
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Fri, 4 Jan 2013 02:56:10 +0000 (02:56 +0000)]
remove dead code from SkPath::addOval
git-svn-id: http://skia.googlecode.com/svn/trunk@7008
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 3 Jan 2013 21:18:16 +0000 (21:18 +0000)]
shape ops work in progress
basic functionality works at this point
git-svn-id: http://skia.googlecode.com/svn/trunk@7004
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 3 Jan 2013 19:23:22 +0000 (19:23 +0000)]
* Extended skdiff to report alpha channel differences.
* Created a tools/tests/rebaseline.sh to copy output-actual into output-expected.
* Sample results are available here: http://www.corp.google.com/~rmistry/skia/gm-playback-windows/images-skdiff/
Review URL: https://codereview.appspot.com/
7038048
git-svn-id: http://skia.googlecode.com/svn/trunk@7003
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 3 Jan 2013 15:29:03 +0000 (15:29 +0000)]
ran gm/tests/rebaseline.sh 5-6 times to update the self-test after 6984
git-svn-id: http://skia.googlecode.com/svn/trunk@6995
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 3 Jan 2013 15:22:40 +0000 (15:22 +0000)]
use SkTreatAsSprite in SkDraw (with guard for chrome if needed)
git-svn-id: http://skia.googlecode.com/svn/trunk@6994
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 3 Jan 2013 14:46:41 +0000 (14:46 +0000)]
Fix Windows warning: Changed implicit int32_t to SkScalar cast to explicit SkIntToScalar call.
git-svn-id: http://skia.googlecode.com/svn/trunk@6993
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 3 Jan 2013 13:55:15 +0000 (13:55 +0000)]
Yet another whitespace change
git-svn-id: http://skia.googlecode.com/svn/trunk@6991
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 3 Jan 2013 13:48:08 +0000 (13:48 +0000)]
Another Whitespace Change...
git-svn-id: http://skia.googlecode.com/svn/trunk@6988
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 3 Jan 2013 13:37:29 +0000 (13:37 +0000)]
Whitespace change to trigger rebuild
git-svn-id: http://skia.googlecode.com/svn/trunk@6986
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 3 Jan 2013 13:03:30 +0000 (13:03 +0000)]
#undef SK_IGNORE_QUAD_STROKE_FIX, to enable the fix for stroked quads.
chrome may need to define this in preparation for rebaselining.
git-svn-id: http://skia.googlecode.com/svn/trunk@6984
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 3 Jan 2013 02:01:32 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6982
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 2 Jan 2013 22:03:54 +0000 (22:03 +0000)]
The motivation for this changeset is to fix the following build failure in google3-
third_party/skia/src/core/SkCanvas.cpp:1711:61: error: non-constant-expression cannot be narrowed from type 'int32_t' (aka 'int') to 'SkScalar' (aka 'float') in initializer list [-Wc++11-narrowing]
0, SkIntToScalar(c.fLeft), SkIntToScalar(c.fRight), w
^
third_party/skia/src/core/SkCanvas.cpp:1711:61: note: override this message by inserting an explicit cast
0, SkIntToScalar(c.fLeft), SkIntToScalar(c.fRight), w
^
static_cast<SkScalar>( )
Review URL: https://codereview.appspot.com/
7041044
git-svn-id: http://skia.googlecode.com/svn/trunk@6979
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 2 Jan 2013 20:33:18 +0000 (20:33 +0000)]
Fix warnings about unused function on Mac.
Review URL: https://codereview.appspot.com/
6826074/
git-svn-id: http://skia.googlecode.com/svn/trunk@6976
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 2 Jan 2013 20:20:31 +0000 (20:20 +0000)]
Fixed debugger for addition of drawRRect, clipRRect & drawOval
https://codereview.appspot.com/
7035051/
git-svn-id: http://skia.googlecode.com/svn/trunk@6975
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 2 Jan 2013 20:19:45 +0000 (20:19 +0000)]
add unittest for SkTreatAsSprite
Review URL: https://codereview.appspot.com/
7042044
git-svn-id: http://skia.googlecode.com/svn/trunk@6974
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 2 Jan 2013 19:57:10 +0000 (19:57 +0000)]
Remove GrInstanceCounter.
R=reed@google.com
Review URL: https://codereview.appspot.com/
6849125
git-svn-id: http://skia.googlecode.com/svn/trunk@6972
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 2 Jan 2013 19:29:57 +0000 (19:29 +0000)]
Ensure that GrCacheID::Key instances are fully initialized.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
7036046
git-svn-id: http://skia.googlecode.com/svn/trunk@6971
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 2 Jan 2013 18:32:53 +0000 (18:32 +0000)]
Delete no-longer compiled SkRectShape.cpp
(This should have been removed in https://code.google.com/p/skia/source/detail?r=5033 )
Review URL: https://codereview.appspot.com/
7035052
git-svn-id: http://skia.googlecode.com/svn/trunk@6969
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 2 Jan 2013 16:59:19 +0000 (16:59 +0000)]
Update documentation around picture playback.
Review URL: https://codereview.appspot.com/
7034045
git-svn-id: http://skia.googlecode.com/svn/trunk@6967
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 2 Jan 2013 15:53:25 +0000 (15:53 +0000)]
Add more warnings about https://code.google.com/p/skia/issues/detail?id=677 ('make tools/tests/run.sh work cross-platform')
git-svn-id: http://skia.googlecode.com/svn/trunk@6965
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 2 Jan 2013 15:49:25 +0000 (15:49 +0000)]
remove #ifdef for scalar==float, since it always is
git-svn-id: http://skia.googlecode.com/svn/trunk@6964
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 2 Jan 2013 04:10:33 +0000 (04:10 +0000)]
add metadata to Click for views
git-svn-id: http://skia.googlecode.com/svn/trunk@6963
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sat, 29 Dec 2012 19:50:16 +0000 (19:50 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@6962
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 28 Dec 2012 22:10:41 +0000 (22:10 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6961
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 28 Dec 2012 12:03:18 +0000 (12:03 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@6958
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 28 Dec 2012 02:01:18 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6956
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 27 Dec 2012 18:46:58 +0000 (18:46 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6952
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 27 Dec 2012 02:16:50 +0000 (02:16 +0000)]
Whitespace change to trigger rebuilds
Review URL: https://codereview.appspot.com/
7019046
git-svn-id: http://skia.googlecode.com/svn/trunk@6950
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 26 Dec 2012 13:39:07 +0000 (13:39 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@6949
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 25 Dec 2012 02:01:27 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6947
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 18:26:43 +0000 (18:26 +0000)]
fix warnings:
- initializer order in PictureRenderer.h
- const in xfermode overrides
git-svn-id: http://skia.googlecode.com/svn/trunk@6946
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 18:15:57 +0000 (18:15 +0000)]
add const to unhide virtuals in custom colorfilter
fix some braces for coding style.
git-svn-id: http://skia.googlecode.com/svn/trunk@6945
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 18:11:05 +0000 (18:11 +0000)]
Fix break from eariler change to colorfilters. clang's warnings found that some of these
virtuals were hidden due to missing const.
git-svn-id: http://skia.googlecode.com/svn/trunk@6944
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 14:38:46 +0000 (14:38 +0000)]
fix warnings related to constness in overrides of SkColorFilter
update samples for circle testing
git-svn-id: http://skia.googlecode.com/svn/trunk@6943
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 13:56:17 +0000 (13:56 +0000)]
fix compiler warnings:
- initialization order in SkWriter32.h
- size_t -vs- int in rrects.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@6942
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 11:49:13 +0000 (11:49 +0000)]
disable (using build-flag) change in 6937 until I can figure out how to rebaseline the self-test
in gm/tests.
git-svn-id: http://skia.googlecode.com/svn/trunk@6940
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 11:23:09 +0000 (11:23 +0000)]
revert 6938, as running rebaseline.sh did not seem to work.
Binary files gm/tests/outputs/compared-against-identical-bytes/output-expected/images/8888/dashing2.png and gm/tests/outputs/compared-against-identical-bytes/output-actual/images/8888/dashing2.png differ
diff -r '--exclude=.*' gm/tests/outputs/compared-against-identical-bytes/output-expected/json-summary.txt gm/tests/outputs/compared-against-identical-bytes/output-actual/json-summary.txt
5c5
< "checksum" :
2249048307642991938
---
> "checksum" :
16595425910463109922
diff -r '--exclude=.*' gm/tests/outputs/compared-against-identical-bytes/output-expected/stdout gm/tests/outputs/compared-against-identical-bytes/output-actual/stdout
4c4
< ----- max pixel mismatch for 8888/dashing2 is 16
---
> ----- max pixel mismatch for 8888/dashing2 is 64
6c6
< 8888/dashing2 pixel_error 16
---
> 8888/dashing2 pixel_error 64
failed in: compare_directories gm/tests/outputs/compared-against-identical-bytes/output-expected gm/tests/outputs/compared-against-identical-bytes/output-actual
git-svn-id: http://skia.googlecode.com/svn/trunk@6939
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 11:13:51 +0000 (11:13 +0000)]
rebaseline self-test images after stroke change
git-svn-id: http://skia.googlecode.com/svn/trunk@6938
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 24 Dec 2012 03:10:30 +0000 (03:10 +0000)]
fix strokes for quadratics. #define SK_IGNORE_QUAD_STROKE_FIX to
retain the old behavior (i.e. for skia.gyp until we rebaseline)
git-svn-id: http://skia.googlecode.com/svn/trunk@6937
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Mon, 24 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6936
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 23 Dec 2012 23:11:21 +0000 (23:11 +0000)]
add SkRRect::inset(), which mimics stroking
git-svn-id: http://skia.googlecode.com/svn/trunk@6935
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sun, 23 Dec 2012 02:01:31 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6934
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 22 Dec 2012 20:54:18 +0000 (20:54 +0000)]
add SampleRotatedCircles.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@6933
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 22 Dec 2012 20:53:59 +0000 (20:53 +0000)]
add test for large strokes on circles
git-svn-id: http://skia.googlecode.com/svn/trunk@6932
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 22 Dec 2012 02:02:33 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6930
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 21 Dec 2012 21:34:36 +0000 (21:34 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6929
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 21 Dec 2012 19:19:10 +0000 (19:19 +0000)]
Experimental code to track what methos have been called: Callstacker is used inject LS_TRACE(...) as first thing in a function definition. lightsymbols must be added to the project too.
A experimental/LightSymbolsUtil
A experimental/LightSymbolsUtil/lightsymbols
A experimental/LightSymbolsUtil/lightsymbols/lightsymbols.cc
A experimental/LightSymbolsUtil/lightsymbols/helper.h
A experimental/LightSymbolsUtil/lightsymbols/lightsymbols.h
A experimental/LightSymbolsUtil/Callstacker
A experimental/LightSymbolsUtil/Callstacker/Callstacker.sln
A experimental/LightSymbolsUtil/Callstacker/Callstacker
A experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.vcxproj
A experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.cpp
A experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.vcxproj.filters
A experimental/LightSymbolsUtil/Callstacker/Callstacker/targetver.h
A experimental/LightSymbolsUtil/Callstacker/Callstacker/stdafx.cpp
A experimental/LightSymbolsUtil/Callstacker/Callstacker/ReadMe.txt
A experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.vcxproj.user
A experimental/LightSymbolsUtil/Callstacker/Callstacker/stdafx.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6928
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Dec 2012 15:36:33 +0000 (15:36 +0000)]
unify how we handle externally-provided storage in SkWriter32, with the goal
of simplifying the logic in reserve() so it can be inlined/accelerated.
Review URL: https://codereview.appspot.com/
6962048
git-svn-id: http://skia.googlecode.com/svn/trunk@6923
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 21 Dec 2012 02:01:28 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6921
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 20 Dec 2012 18:34:29 +0000 (18:34 +0000)]
Make gm's json results include checksums even if run without --readPath
Review URL: https://codereview.appspot.com/
6979043
git-svn-id: http://skia.googlecode.com/svn/trunk@6917
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 20 Dec 2012 15:13:01 +0000 (15:13 +0000)]
Reland 6914 w/ fixes.
git-svn-id: http://skia.googlecode.com/svn/trunk@6916
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 20 Dec 2012 14:23:26 +0000 (14:23 +0000)]
Revert 6914 to fix build issues.
git-svn-id: http://skia.googlecode.com/svn/trunk@6915
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 20 Dec 2012 14:18:10 +0000 (14:18 +0000)]
Simplify cache IDs and keys.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
6954047
git-svn-id: http://skia.googlecode.com/svn/trunk@6914
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 20 Dec 2012 11:52:06 +0000 (11:52 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@6913
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 20 Dec 2012 02:01:41 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6911
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 19 Dec 2012 15:55:40 +0000 (15:55 +0000)]
Fixing picture recording scale bug in gm
Review URL: https://codereview.appspot.com/
6965047
git-svn-id: http://skia.googlecode.com/svn/trunk@6901
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 19 Dec 2012 15:24:38 +0000 (15:24 +0000)]
Adding tileGrid scaled playback capability to gm.
BUG=http://code.google.com/p/skia/issues/detail?id=1021
Review URL: https://codereview.appspot.com/
6937077
git-svn-id: http://skia.googlecode.com/svn/trunk@6898
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 19 Dec 2012 14:47:53 +0000 (14:47 +0000)]
Tweak Android bench_pictures configs
Review URL: https://codereview.appspot.com/
6970044
git-svn-id: http://skia.googlecode.com/svn/trunk@6895
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 19 Dec 2012 02:01:38 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6891
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 18 Dec 2012 22:24:03 +0000 (22:24 +0000)]
Flags for render_pictures: verify, clone and writeWholeImage:
1) flag to verify PNGs produced by render_picture that produce the same pixels
as simple renderer.
2) flag to write one single image (in tile we write individual tiles) - this
will help running skdiff also
3) flag to clone the picture before rendering
git-svn-id: http://skia.googlecode.com/svn/trunk@6890
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Dec 2012 21:47:47 +0000 (21:47 +0000)]
Accelerate AA filled rect drawing using drawIndexedInstances
https://codereview.appspot.com/
6947078/
git-svn-id: http://skia.googlecode.com/svn/trunk@6889
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 18 Dec 2012 21:44:53 +0000 (21:44 +0000)]
Modify bench_pictures configs for Android
Review URL: https://codereview.appspot.com/
6942064
git-svn-id: http://skia.googlecode.com/svn/trunk@6888
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 18 Dec 2012 21:40:08 +0000 (21:40 +0000)]
When doing a readback in SkGrPixelRef check whether the dst bmp was allocated.
Review URL: https://codereview.appspot.com/
6936068
git-svn-id: http://skia.googlecode.com/svn/trunk@6887
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 18 Dec 2012 21:09:45 +0000 (21:09 +0000)]
Adding gm test steps for rtree and tileGrid
The new passes are enabled by default, and can be disabled with --nortree and --notileGrid.
With this change, the skia buildbots will begin continuously testing rtree and tileGrid.
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm
Review URL: https://codereview.appspot.com/
6941072
git-svn-id: http://skia.googlecode.com/svn/trunk@6886
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Tue, 18 Dec 2012 20:06:10 +0000 (20:06 +0000)]
Parses per-tile benches and returns the sum as overall skp bench.
Review URL: https://codereview.appspot.com/
6940071
git-svn-id: http://skia.googlecode.com/svn/trunk@6884
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 18 Dec 2012 19:37:49 +0000 (19:37 +0000)]
Adding support for new canvas API method clipRRect with rtree and tileGrid
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm rrect_clip_* with --tileGrid and --rtree
Review URL: https://codereview.appspot.com/
6939073
git-svn-id: http://skia.googlecode.com/svn/trunk@6883
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Dec 2012 19:18:39 +0000 (19:18 +0000)]
change SkMaskFilter methods to const, in preparation for making the class as
immutable and re-entrant safe.
Review URL: https://codereview.appspot.com/
6944069
git-svn-id: http://skia.googlecode.com/svn/trunk@6881
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 18 Dec 2012 19:13:49 +0000 (19:13 +0000)]
Re-land r6843 with copied gyp file to (hopefully) fix Windows build
BUG=https://code.google.com/p/skia/issues/detail?id=1023
Review URL: https://codereview.appspot.com/
6943073
git-svn-id: http://skia.googlecode.com/svn/trunk@6880
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Dec 2012 18:20:44 +0000 (18:20 +0000)]
remove experimental setAsABlur, as it forces the instance to be mutable, and was
not adopted by chrome
Review URL: https://codereview.appspot.com/
6939071
git-svn-id: http://skia.googlecode.com/svn/trunk@6879
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Dec 2012 16:57:03 +0000 (16:57 +0000)]
change all interfaces for SkRasterizer to const, in preparation for marking it
as immutable/re-entrant safe.
Review URL: https://codereview.appspot.com/
6936064
git-svn-id: http://skia.googlecode.com/svn/trunk@6878
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Dec 2012 16:12:09 +0000 (16:12 +0000)]
change all patheffect methods to const, in preparation for marking its
subclasses as immutable/re-entrant safe.
Review URL: https://codereview.appspot.com/
6949071
git-svn-id: http://skia.googlecode.com/svn/trunk@6877
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 18 Dec 2012 14:44:09 +0000 (14:44 +0000)]
Fix drawSprite to record correctly with SkBBoxRecord
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm lighting with -tileGrid
Review URL: https://codereview.appspot.com/
6947075
git-svn-id: http://skia.googlecode.com/svn/trunk@6876
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 18 Dec 2012 14:41:18 +0000 (14:41 +0000)]
Fix compile error on Windows -- remove unsupported branch hint.
git-svn-id: http://skia.googlecode.com/svn/trunk@6875
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 18 Dec 2012 14:13:46 +0000 (14:13 +0000)]
Add AndroidPathRenderer to experimental gyp and get it compiling with Skia code.
https://codereview.appspot.com/
6938074/
git-svn-id: http://skia.googlecode.com/svn/trunk@6874
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 18 Dec 2012 02:03:03 +0000 (02:03 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6872
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 17 Dec 2012 22:32:06 +0000 (22:32 +0000)]
Fix SkBBoxRecord to correctly handle SkRect arguments that are inverted rects.
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm strokerect with --tileGrid
Review URL: https://codereview.appspot.com/
6945071
git-svn-id: http://skia.googlecode.com/svn/trunk@6870
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Dec 2012 21:58:02 +0000 (21:58 +0000)]
Fix compiler warning-as-error issue
git-svn-id: http://skia.googlecode.com/svn/trunk@6867
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Dec 2012 21:48:19 +0000 (21:48 +0000)]
Add RRect GM
https://codereview.appspot.com/
6945063/
git-svn-id: http://skia.googlecode.com/svn/trunk@6866
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 17 Dec 2012 21:30:51 +0000 (21:30 +0000)]
Fixing bounding box computation for inverse filled paths in SkBBoxRecord
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm emptypath with --tileGrid
Review URL: https://codereview.appspot.com/
6944062
git-svn-id: http://skia.googlecode.com/svn/trunk@6865
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Dec 2012 21:20:53 +0000 (21:20 +0000)]
we do not correctly handle inner-style in blurmaskfilter w/ the 9patch
trick, so don't use it (until we fix it).
extend blurrect gm to test all 4 blurstyles
Review URL: https://codereview.appspot.com/
6940075
git-svn-id: http://skia.googlecode.com/svn/trunk@6864
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Mon, 17 Dec 2012 21:16:45 +0000 (21:16 +0000)]
Follow up on the previous patch :
- Moved the SkStrokeRec class in its own file
- Replaced SkStroke by SkStrokeRec in Ganesh
- Moved path stroking to the Ganesh level in some cases (everytime it isn't required to do it directly in SkGpuDevice). PathEffect and MaskFilter still require path stroking at the SkGpuDevice for now.
- Renamed static functions in SkPath with proper names
* No functionality shold have changed with this patch. This is a step towards enabling Ganesh Path Renderers to decide whether or not to stroke the path rather than always receiving the stroked path as an input argument.
BUG=chromium:135111
TEST=Try path rendering tests from the gm
Review URL: https://codereview.appspot.com/
6946072
git-svn-id: http://skia.googlecode.com/svn/trunk@6861
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 17 Dec 2012 20:44:22 +0000 (20:44 +0000)]
Remove unused type GrCacheKey
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/
6947074
git-svn-id: http://skia.googlecode.com/svn/trunk@6858
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Dec 2012 20:21:44 +0000 (20:21 +0000)]
Make all colorfilter methods const, in preparation for declaring them
to be immutable and reentrant-safe
git-svn-id: http://skia.googlecode.com/svn/trunk@6856
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Dec 2012 19:55:24 +0000 (19:55 +0000)]
Mark all methods on SkXfermode as const, in preparation for declaring all
xfermodes as immutable/reentrant-safe
Review URL: https://codereview.appspot.com/
6941065
git-svn-id: http://skia.googlecode.com/svn/trunk@6855
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 17 Dec 2012 19:25:54 +0000 (19:25 +0000)]
Allow setting a scaleFactor in bench_pictures (and render_pictures).
In TiledPictureRenderer and CopyTilesRenderer, do a postTranslate so
the translate is not affected by the scale factor.
Likewise, use clipRegion for tiled renderer so it will be
unaffected by the scale factor.
Respect the viewport for record, playbackCreation, and pipe renderers.
Review URL: https://codereview.appspot.com/
6947072
git-svn-id: http://skia.googlecode.com/svn/trunk@6853
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Dec 2012 18:56:29 +0000 (18:56 +0000)]
3on/3off dashing optimization
https://codereview.appspot.com/
6891046/
git-svn-id: http://skia.googlecode.com/svn/trunk@6851
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 17 Dec 2012 18:23:58 +0000 (18:23 +0000)]
Roll out r6843 to hopefully fix Windows builds
BUG=https://code.google.com/p/skia/issues/detail?id=1023
TBR=borenet
Review URL: https://codereview.appspot.com/
6942061
git-svn-id: http://skia.googlecode.com/svn/trunk@6849
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 17 Dec 2012 17:21:04 +0000 (17:21 +0000)]
Address comments for r6822: https://codereview.appspot.com/
6946052/
Review URL: https://codereview.appspot.com/
6943059
git-svn-id: http://skia.googlecode.com/svn/trunk@6847
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 17 Dec 2012 16:29:34 +0000 (16:29 +0000)]
Adding missing oval and roundedRect primitives to SkBBoxRecord
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm with --tileGrid
Review URL: https://codereview.appspot.com/
6937066
git-svn-id: http://skia.googlecode.com/svn/trunk@6846
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Mon, 17 Dec 2012 16:27:34 +0000 (16:27 +0000)]
Limit the maximum number of dash segments per path
https://crbug.com/165432
In order to avoid trivial out-of-memory exploits, cap path dashing at
1000000 segments per path.
R=reed@google.com
BUG=
Review URL: https://codereview.appspot.com/
6948063
git-svn-id: http://skia.googlecode.com/svn/trunk@6845
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 17 Dec 2012 15:27:30 +0000 (15:27 +0000)]
Add --writeJsonSummary option to gm
This writes out a JSON file containing expected and actual checksum values for every test.
Next step: allow the same checksum file to be compared against, instead of PNG files.
Review URL: https://codereview.appspot.com/
6940053
git-svn-id: http://skia.googlecode.com/svn/trunk@6843
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 17 Dec 2012 15:28:56 +0000 (15:28 +0000)]
Fix SampleApp busted images with --picture on windows.
Review URL: https://codereview.appspot.com/
6942060
git-svn-id: http://skia.googlecode.com/svn/trunk@6842
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Mon, 17 Dec 2012 14:38:59 +0000 (14:38 +0000)]
Fix line rendering with TileGrid and Rtree
BUG=http://code.google.com/p/skia/issues/detail?id=1014
TEST=gm hairmodes with --tileGrid and --rtree
Review URL: https://codereview.appspot.com/
6947056
git-svn-id: http://skia.googlecode.com/svn/trunk@6841
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Dec 2012 14:21:38 +0000 (14:21 +0000)]
detect out-of-memory when we try to create a mask offscreen
git-svn-id: http://skia.googlecode.com/svn/trunk@6839
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 17 Dec 2012 13:58:08 +0000 (13:58 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6837
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Dec 2012 13:39:25 +0000 (13:39 +0000)]
add 4th test
git-svn-id: http://skia.googlecode.com/svn/trunk@6835
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 17 Dec 2012 03:48:12 +0000 (03:48 +0000)]
change delta to 5, to better show the inset trend
git-svn-id: http://skia.googlecode.com/svn/trunk@6834
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 17 Dec 2012 02:34:28 +0000 (02:34 +0000)]
move inset out of SkRRect.h for now, and add experimental versions to gm
git-svn-id: http://skia.googlecode.com/svn/trunk@6833
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Mon, 17 Dec 2012 02:10:42 +0000 (02:10 +0000)]
add gm for rrect, and rrect.inset/outset
git-svn-id: http://skia.googlecode.com/svn/trunk@6832
2bbb7eff-a529-9590-31e7-
b0007b416f81