Slava Zakharin [Thu, 19 Jan 2023 16:46:52 +0000 (08:46 -0800)]
[NFC][flang] Added debug option to bisect TBAA tag attachments.
Reviewed By: jeanPerier, PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D142070
Aaron Ballman [Thu, 19 Jan 2023 17:25:14 +0000 (12:25 -0500)]
Silence some sign comparison warnings; NFC
The std::optional implementation in MSVC causes this code to produce a
sign comparison warning. This ensures the types are the same sign.
Michael Jones [Wed, 21 Dec 2022 22:29:43 +0000 (14:29 -0800)]
[libc] add scanf float converter
This patch adds the %f/F/e/E/g/G/a/A conversions for scanf, as well as
accompanying tests. This implementation matches the definition set forth
in the standard, which may conflict with some other implementations.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D141091
Michael Jones [Fri, 6 Jan 2023 23:00:51 +0000 (15:00 -0800)]
[libc] add internal string class
The scanf implementation needs a dynamically resizing string class. This
patch adds a minimal version of that class along with tests to check the
current functionality.
Reviewed By: sivachandra
Differential Revision: https://reviews.llvm.org/D141162
Kiran Chandramohan [Thu, 19 Jan 2023 16:49:26 +0000 (16:49 +0000)]
[Flang][Debug] Modifications for getting pathname
-> Use file pathname from the Flang frontend. It is the frontend
that is in-charge of finding the files and is hence the canonical
source for paths.
-> Convert pathname to absolute pathname while creating the moduleOp.
Co-authored-by: Peter Klausler <pklausler@nvidia.com>
Reviewed By: PeteSteinfeld, vzakhari, jeanPerier, awarzynski
Differential Revision: https://reviews.llvm.org/D141674
Mark de Wever [Tue, 29 Nov 2022 06:57:30 +0000 (07:57 +0100)]
[libc++][format] Adds formatter std::vector<bool>.
Implements parts of
- P2286R8 Formatting Ranges
Depends on D140653
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D141761
LLVM GN Syncbot [Thu, 19 Jan 2023 16:51:17 +0000 (16:51 +0000)]
[gn build] Port
04d4f4b3d4e4
Zino Benaissa [Thu, 19 Jan 2023 16:44:23 +0000 (16:44 +0000)]
[AARCH64][SVE] Do not optimize vector conversions
shuffle_vector instructions are serialized targeting SVE fixed vectors, see
https://reviews.llvm.org/D139111. This patch disables
optimizeExtendOrTruncateConversion peepholes that generates shuffle_vector.
Differential Revision: https://reviews.llvm.org/D141439
Sjoerd Meijer [Wed, 11 Jan 2023 14:41:10 +0000 (14:41 +0000)]
[CostModel][AArch64] Precommit tests for LD1 single-element to lane. NFC.
Mark de Wever [Thu, 5 May 2022 16:57:32 +0000 (18:57 +0200)]
[libc++][format] Adds container adaptor formatters.
Implements parts of
- P2286R8 Formatting Ranges
Depends on D140653
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D141290
Jonas Paulsson [Wed, 18 Jan 2023 19:29:37 +0000 (13:29 -0600)]
[SystemZ] Improvement in tryRxSBG().
Only allow replacements of nodes that have a single user. This is better as
simple instructions (e.g. XGRK) are one cycle faster, and it helps in cases
where both inputs share a common node.
Review: Ulrich Weigand
Jordan Rupprecht [Thu, 19 Jan 2023 16:43:24 +0000 (08:43 -0800)]
[NFC][bazel] Move _tensor_ops_ext.py to the correct filegroup
Jordan Rupprecht [Thu, 19 Jan 2023 16:39:18 +0000 (08:39 -0800)]
[NFC][bazel] Add _tensor_ops_ext.py to SparseTensorOpsPyFiles
This corresponds to the cmake change in
81ca5aa452400843235e058bc9c83fe71eccd593
Paul Robinson [Wed, 4 Jan 2023 19:35:59 +0000 (11:35 -0800)]
[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL
AFAICT all in-tree lit tests have been converted to use `target=...`
and so there is no longer any need for triples being special.
Some project config files still define their own features based on
the triple, but those are normal feature words (although now are
redundant with target= checks).
Downstream tests that use triple substrings will need to convert.
For example:
UNSUPPORTED: -aix
XFAIL: arm
becomes
UNSUPPORTED: target={{.*}}-aix{{.*}}
XFAIL: target=arm{{.*}}
You can do
git log --grep "special handling for triples"
to find many examples of updates to the upstream tests.
https://discourse.llvm.org/t/rfc-lits-requires-and-triples/66041
Differential Revision: https://reviews.llvm.org/D141007
Valentin Clement [Thu, 19 Jan 2023 16:34:01 +0000 (17:34 +0100)]
[flang] Allow pointer association between derived-type pointer and unlimited polymorphic target
Pointer association to unlimited polymorphic target is allowed for
unlimited polymorphic pointer and non-extensible derived-type.
This is checked by the semantic and this patch allows it in the
fir.rebox operation.
Reviewed By: jeanPerier, PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D142104
Valentin Clement [Thu, 19 Jan 2023 16:33:08 +0000 (17:33 +0100)]
[flang] Support polymorphic source in RESHAPE intrinsic
Result must carry the polymorphic type information
from the source.
Reviewed By: jeanPerier, PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D142095
Valentin Clement [Thu, 19 Jan 2023 16:32:02 +0000 (17:32 +0100)]
[flang] Fix SELECT TYPE lowering when CLASS DEFAULT is not the last type guard
CLASS DEFAULT needs to be the last attribute when fir.select_type op is created.
It needs to be at its actual position in the Fortran code when the TypeGuardStmt
are processed. The current lowering was crashing when CLASS DEFAULT was not at
the last position.
This patch fixes the issue by tracking the actual position of the CLASS DEFAULT
type guard and set it at the correct position after the fir.select_type op
is created.
Reviewed By: jeanPerier, PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D142091
LLVM GN Syncbot [Thu, 19 Jan 2023 16:20:20 +0000 (16:20 +0000)]
[gn build] Port
22e8525dfdd7
Mark de Wever [Thu, 5 May 2022 16:57:32 +0000 (18:57 +0200)]
[libc++][format] Implements range_formatter
Implements parts of
- P2286R8 Formatting Ranges
- P2585R0 Improving default container formatting
Depends on D140651
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D140653
Nikita Popov [Thu, 19 Jan 2023 16:10:09 +0000 (17:10 +0100)]
[SROA] Check TBAA metadata in tests (NFC)
By switching to --check-globals. Also make sure that the
!tbaa.struct metadata mapping is preserved.
Haojian Wu [Thu, 19 Jan 2023 16:03:08 +0000 (17:03 +0100)]
[clangd] Fix clangd-fuzzer build.
Matt Devereau [Mon, 16 Jan 2023 14:21:18 +0000 (14:21 +0000)]
[AArch64] Allow poison elements of fixed-vectors to be duplicated as a widened element
Expanding upon https://reviews.llvm.org/D138203, allow null indices in
InsertElts to be matched with any value and be duplicated if the fixed
vector the scalar values are inserted into is poison, and the scalable vector
the subvector being inserted into is poison.
Differential Revision: https://reviews.llvm.org/D141846
Yitzhak Mandelbaum [Fri, 13 Jan 2023 18:33:52 +0000 (18:33 +0000)]
[clang][dataflow] Fix bug in joining bool values.
Currently, the code assumes that all boolean-typed values are an instance of
`BoolValue` (or its subclasses). Yet, lvalues violate this assumption. This
patch drops the assumption and strengthens the check to confirm the shape of
both values being joined.
The patch also notes as FIXMES a number of problems discovered fixing this bug.
Differential Revision: https://reviews.llvm.org/D141709
Jean Perier [Thu, 19 Jan 2023 15:56:56 +0000 (16:56 +0100)]
[flang][hlfir] Lower whole allocatable or pointer component ref
Compare to other component ref lowering, the hlfir.designate result type
computation is different, and the allocatable/pointer/contiguous must
be set on the hlfir.designate so that the component attributes are
kept in the IR.
Differential Revision: https://reviews.llvm.org/D142111
Nikita Popov [Thu, 19 Jan 2023 15:55:23 +0000 (16:55 +0100)]
[Local] Preserve noundef metadata in copyMetadataForLoad()
If we're only changing the type of the load, preserve the noundef
metadata.
Kelvin Li [Thu, 19 Jan 2023 15:52:10 +0000 (10:52 -0500)]
[flang] Add semantic check for multiple part-ref with non-zero rank
This patch is to diagnose the case when a type bound procedure is passed as an actual procedure argument.
call sub0(t%t3%t2%t%info1)
Fix: https://github.com/llvm/llvm-project/issues/55826
Committed on behalf of DanielCChen
Differential Revision: https://reviews.llvm.org/D141506
Nikita Popov [Thu, 19 Jan 2023 15:50:02 +0000 (16:50 +0100)]
[InstCombine] Add test for load type conversion with !noundef (NFC)
The !noundef metadata is currently dropped.
David Green [Thu, 19 Jan 2023 15:37:50 +0000 (15:37 +0000)]
[AArch64] Armv9-A implies FP16
As Armv9-a implies SVE2 it implies SVE (added in D141411) and so it
should also imply FP16, which this patch adds. This helps get the target
features correct when using `target("arch=armv9-a")` attributes.
There is also an adjustment to AssertSameExtensionFlags in this patch to
make it print cpu names, useful when the TargetParser unit tests are run
through lit to distinguish which cpu is failing.
Differential Revision: https://reviews.llvm.org/D142087
Guilherme Valarini [Thu, 19 Jan 2023 15:11:20 +0000 (12:11 -0300)]
[OpenMP][Fix] Track all threads that may delete an entry
The entries inside a "target data end" is processed in three steps:
1. Query internal data maps for the entries and dispatch any necessary
device-side operations (i.e., data retrieval);
2. Synchronize the such operations;
3. Update the host-side pointers and remove any entry which reference
counter reached zero.
Such steps may be executed by multiple threads which may even operate on
the same entries. The current implementation (D121058) tries to
synchronize these threads by tracking the "owner" for the deletion of
each entry using their thread ID. Unfortunately it may failed to do so
because of the following reasons:
1. The owner is always assigned at the first step only if the
reference count is 0 when the map is queried. This does not work
when such owner thread is faster than a previous one that is also
processing the same entry on another "target data end", leading to
user-after-free problems.
2. The entry is only added for post-processing (step 3) if its
reference count was 0 at query time (step 1). This does not allow
for threads to exchange responsibility for the deletion, leading
again to user-after-free problems.
3. An entry may appear multiple times in the arguments array of a
"target data end", which may lead to deleting the entry
prematurely, leading, again, to user-after-free problems.
This patch addresses these problems by tracking all the threads that are
using an entry at "target data end" region through a counter, ensuring
only the last one deletes it when needed. It also ensures that all
entries that are successfully found inside the data maps in step 1 are
also processed in step 3, regardless if their reference count was zeroed
or not at query time. This ensures the deletion ownership may be passed
to any thread that is using such entry.
Reviewed By: ye-luo
Differential Revision: https://reviews.llvm.org/D132676
Ben Mudd [Thu, 19 Jan 2023 15:05:04 +0000 (15:05 +0000)]
[Dexter] Add on_line parameter to DexExpectStepOrder command
DexExpectStepOrder uses the line to expect a debugger step from the actual line
of the command in the Dexter source file. Now Dexter scripts have mainly moved
to thier own script files instead of the actual source, there should be a
option to override this behaviour to choose your own debugger step location.
Reviewed By: Orlando
Differential Revision: https://reviews.llvm.org/D142099
Nikita Popov [Thu, 19 Jan 2023 15:05:45 +0000 (16:05 +0100)]
[InstCombine] Add non-logical variants for some ctpop and/or tests (NFC)
And regenerate test checks to pick up new names.
Nikita Popov [Thu, 19 Jan 2023 14:55:26 +0000 (15:55 +0100)]
[InstCombine] Drop incorrect test (NFC)
I made a typo here, this was supposed to be !align rather than
!aligned. But then !align can only be applied to loads, not calls
(where one would use the return attribute instead). And freeze
can't be pushed through loads anyway, so there's no way to test
this case (same as !nonnull).
Yitzhak Mandelbaum [Fri, 13 Jan 2023 19:26:57 +0000 (19:26 +0000)]
[clang][dataflow] Add (initial) debug printing for `Value` and `Environment`.
Also adds uses of the new printing in analysis inner loop.
Differential Revision: https://reviews.llvm.org/D141716
Michal Paszkowski [Wed, 18 Jan 2023 21:23:11 +0000 (22:23 +0100)]
[SPIR-V] Emit OpExecutionMode ContractionOff for no FP_CONTRACT metadata
This change makes the AsmPrinter emit OpExecutionMode ContractionOff
when both opencl.enable.FP_CONTRACT and spirv.ExecutionMode
metadata are not present.
Differential Revision: https://reviews.llvm.org/D141734
Nikita Popov [Thu, 19 Jan 2023 14:23:48 +0000 (15:23 +0100)]
[InstCombine] Add tests for freeze with !range and !align metadata (NFC)
These are currently being miscompiled, see PR59888.
Alex Brachet [Thu, 19 Jan 2023 14:10:31 +0000 (14:10 +0000)]
[X86] Add register definitions for cfi directives
Add {e,r}flags, {g,f}s.base registers so they can be referenced in cfi
directives,. They are not otherwise useable in any instructions,
but can be implicitly pushed to the stack like with pushf for
{e,r}flags.
Differential Revision: https://reviews.llvm.org/D141879
Nico Weber [Thu, 19 Jan 2023 14:01:29 +0000 (09:01 -0500)]
[gn] port
939dce12f9f3 (clangd uses include-cleaner) more
Nico Weber [Thu, 19 Jan 2023 13:45:56 +0000 (08:45 -0500)]
[gn] port
939dce12f9f3 (clangd uses include-cleaner)
Haojian Wu [Mon, 2 Jan 2023 21:10:11 +0000 (22:10 +0100)]
[clangd] Implement unused include warnings with include-cleaner library.
A prototype of using include-cleaner library in clangd:
- (re)implement clangd's "unused include" warnings with the library
- the new implementation is hidden under a flag `Config::UnusedIncludesPolicy::Experiment`
Differential Revision: https://reviews.llvm.org/D140875
Christian Ulmann [Thu, 19 Jan 2023 11:04:53 +0000 (12:04 +0100)]
[llvm][ir] Purge MD_prof custom accessors
This commit purges direct accesses to MD_prof metadata and replaces them
with the accessors provided from the utility file wherever possible.
This commit can be seen as the first step towards switching the branch weights to 64 bits.
See post here: https://discourse.llvm.org/t/extend-md-prof-branch-weights-metadata-from-32-to-64-bits/67492
Reviewed By: davidxl, paulkirth
Differential Revision: https://reviews.llvm.org/D141393
Amaury Séchet [Tue, 17 Jan 2023 02:17:18 +0000 (02:17 +0000)]
[DAG] Peek through ZEXT/TRUNC in foldAddSubMasked1
Fix a regression in D141883
Depends on D141883
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D141884
Haojian Wu [Tue, 3 Jan 2023 14:08:42 +0000 (15:08 +0100)]
[clang] Build UsingType for elaborated type specifiers.
Support building UsingType for elaborated type specifiers:
```
namespace ns { class Foo {}; }
using ns::Foo;
// The TypeLoc of `Foo` below should be a ElaboratedTypeLoc with an
// inner UsingTypeLoc rather than the underlying `CXXRecordTypeLoc`
class Foo foo;
```
Differential Revision: https://reviews.llvm.org/D141280
Jean Perier [Thu, 19 Jan 2023 13:18:08 +0000 (14:18 +0100)]
[flang][hlfir] Enable lowering and passing of allocatables and pointers.
Adds support for:
- referencing a whole allocatable/pointer symbol
- passing allocatable/pointer in a call
This required update in HLFIRTools.cpp helpers so that the
raw address, extents, lower bounds, and type parameters of a
fir.box/fir.class can be extracted.
This is required because in hlfir lowering, dereferencing a
pointer/alloc is only doing the fir.load fir.box part, and the
helpers have to be able to reason about that fir.box without the
help of a "fir::FortranVariableOpInterface".
Missing:
- referencing part of allocatable/pointer (will need to update
Designator lowering to dereference the pointer/alloc). Same
for whole allocatable and pointer components.
- allocate/deallocate/pointer assignment statements.
- Whole allocatable assignment.
- Lower inquires.
Differential Revision: https://reviews.llvm.org/D142043
serge-sans-paille [Wed, 18 Jan 2023 15:43:56 +0000 (16:43 +0100)]
Optimize OptTable::findNearest implementation and usage
When used to find an exact match, some extra context can be used to
totally cut some computations.
This saves 1% of the instruction count when pre processing sqlite3.c
through
valgrind --tool=callgrind ./bin/clang -E sqlite3.c -o/dev/null
Differential Revision: https://reviews.llvm.org/D142026
Groverkss [Thu, 19 Jan 2023 13:01:56 +0000 (18:31 +0530)]
[MLIR][Presburger] Support divisions in union of two PWMAFunction
This patch adds support for divisions in the union of two PWMAFunction. This is
now possible because of previous patches, which made divisions explicitly
stored in MultiAffineFunction (MAF). This patch also refactors the previous
implementation, moving the implementation for obtaining a set of points where a
MAF is lexicographically "better" than the other to MAF.
Reviewed By: arjunp
Differential Revision: https://reviews.llvm.org/D138118
Michal Paszkowski [Wed, 18 Jan 2023 23:05:37 +0000 (00:05 +0100)]
[SPIR-V] Add -opaque-pointers=0 to some LIT tests
Differential Revision: https://reviews.llvm.org/D142061
Timm Bäder [Thu, 19 Jan 2023 12:52:05 +0000 (13:52 +0100)]
Revert "[clang][Interp] Unify visiting variable declarations"
This reverts commit
5b54cf1a2892767fe949826a32d7820732028a38.
This breaks a builder: https://lab.llvm.org/buildbot/#/builders/5/builds/30854
Timm Bäder [Thu, 19 Jan 2023 12:51:26 +0000 (13:51 +0100)]
Revert "[clang][Interp] Implement missing compound assign operators"
This reverts commit
490e8214fca48824beda8b508d6d6bbbf3d8d9a7.
This breaks a builder: https://lab.llvm.org/buildbot/#/builders/214/builds/5415
Timm Bäder [Thu, 19 Jan 2023 12:24:40 +0000 (13:24 +0100)]
[clang][Interp][NFC] Remove shift error checking code duplication
Amaury Séchet [Sun, 1 May 2022 15:58:32 +0000 (15:58 +0000)]
[DAG] Do not combine any_ext when we combine and into zext.
This transofrm loses information that can be useful for other transforms.
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D141883
Evan Smal [Thu, 19 Jan 2023 12:11:07 +0000 (13:11 +0100)]
[clang] Improve diagnostic for "initializer-string for char array is too long"
This patch improves the diagnostic message "initializer-string for
char array is too long" by specifying an expected array length and by
indicating that the initializer string implicitly includes the
null terminator.
Fixes #58829
Differential Revision: https://reviews.llvm.org/D141283
Florian Hahn [Thu, 19 Jan 2023 12:07:27 +0000 (12:07 +0000)]
[VPlan] Add vp_depth_first_shallow + graph traits for wrapper(NFC)
This patch adds a new VPBlockShallowTraversalWrapper struct to
provide graph traits specialization that do not traverse through
VPRegionBlocks. This matches the behavior of the existing traits for
plain VPBlockBase and is a step before moving the graph traits for
VPBlockBase to traverse through VPRegionBlocks to enable cross region
support in VPDominatorTree.
Depends on D140511.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D140512
Mariusz Sikora [Wed, 18 Jan 2023 14:30:38 +0000 (15:30 +0100)]
[AMDGPU] Add feature predicate for v_fmac_f64 instruction
Introducing feature predicate VFmacF64Inst for targets which
supports v_fmac_f64 instructions.
Differential Revision: https://reviews.llvm.org/D142017
Timm Bäder [Thu, 19 Jan 2023 12:03:20 +0000 (13:03 +0100)]
Revert "[clang][Interp][NFC] Remove shift error checking code duplication"
This reverts commit
fddf6418e8492a544c9bfdb42a4dbc949d9dc2ee.
Apparently this also breaks some builders:
/usr/bin/ld: EvalEmitter.cpp:(.text._ZN5clang6interp11EvalEmitter7emitShlENS0_8PrimTypeES2_RKNS0_10SourceInfoE+0x1f54): undefined reference to `bool clang::interp::CheckShift<clang::interp::Integral<16u, true> >(clang::interp::InterpState&, clang::interp::CodePtr, clang::interp::Integral<16u, true> const&, unsigned int)'
/usr/bin/ld: EvalEmitter.cpp:(.text._ZN5clang6interp11EvalEmitter7emitShlENS0_8PrimTypeES2_RKNS0_10SourceInfoE+0x1fd4): undefined reference to `bool clang::interp::CheckShift<clang::interp::Integral<32u, true> >(clang::interp::InterpState&, clang::interp::CodePtr, clang::interp::Integral<32u, true> const&, unsigned int)'
/usr/bin/ld: EvalEmitter.cpp:(.text._ZN5clang6interp11EvalEmitter7emitShlENS0_8PrimTypeES2_RKNS0_10SourceInfoE+0x2058): undefined reference to `bool clang::interp::CheckShift<clang::interp::Integral<32u, true> >(clang::interp::InterpState&, clang::interp::CodePtr, clang::interp::Integral<32u, true> const&, unsigned int)'
(etc)
Dominik Adamski [Thu, 22 Dec 2022 12:26:47 +0000 (06:26 -0600)]
[mlir][OpenMP] Add nontemporal clause definition to simd construct
simd nontemporal construct is represented as a list of variables
which have low locality accross simd iterations
Added verifier of nontemporal clause. MLIR tests were updated to test
correctness of MLIR definition of nontemporal clause.
Differential Revision: https://reviews.llvm.org/D140553
Reviewed By: kiranchandramohan
Jordan Rupprecht [Thu, 19 Jan 2023 11:40:59 +0000 (03:40 -0800)]
[NFC][bazel] Enable layering_check for mlir/unittests
Timm Bäder [Thu, 19 Jan 2023 11:37:20 +0000 (12:37 +0100)]
Revert "[clang][Interp][NFC] Move CheckDivRem() implementation into Interp.cpp"
This reverts commit
9ee0d7494eb35f5addefcb730cdf5c002ddeacd2.
Timm Bäder [Mon, 31 Oct 2022 11:44:38 +0000 (12:44 +0100)]
[clang][Interp] Implement missing compound assign operators
Implement mul, div, rem, etc. compound assign operators.
Differential Revision: https://reviews.llvm.org/D137071
Timm Bäder [Sun, 30 Oct 2022 09:21:58 +0000 (10:21 +0100)]
[clang][Interp][NFC] Move CheckDivRem() implementation into Interp.cpp
Just like we do with all the other Check* functions.
Timm Bäder [Sun, 30 Oct 2022 09:20:04 +0000 (10:20 +0100)]
[clang][Interp][NFC] Remove shift error checking code duplication
Timm Bäder [Sun, 30 Oct 2022 06:28:17 +0000 (07:28 +0100)]
[clang][Interp][NFCI] Pull IsConstantContext into State
This way we can check for this flag in the new interpreter as well.
Quentin Colombet [Tue, 17 Jan 2023 11:54:40 +0000 (11:54 +0000)]
[mlir][vector] Add a custom builder for LowerVectorsOp
The `lower_vectors` operation of the transform dialect takes a lot of
arguments to build.
In order to make C++ code easier to work with when using this
instruction, introduce a new structure, named `LowerVectorsOptions`, that
aggregates all the options that are used to build this instruction.
This allows to use patterns like:
```
LowerVectorsOptions opts;
opts.setOptZ(...)
.setOptY(...)...;
builder.create<LowerVectorsOp>(target, opts);
```
Instead of having to pass all N options directly to the builder and set
them in the right order.
NFC
Differential Revision: https://reviews.llvm.org/D141923
Christian Ulmann [Thu, 12 Jan 2023 15:48:19 +0000 (16:48 +0100)]
[mlir][LLVM] Replace readnone with memory effects
This commit introduces LLVM's `MemoryEffects` attribute and replaces the
deprecated usage of `llvm.readnone` in the LLVM dialect.
The absence of the attribute on a `LLVMFuncOp` implies that it might
access all kinds of memory. This semantic corresponds to `llvm::Function`'s
behaviour.
Depends on D142002
Differential Revision: https://reviews.llvm.org/D142013
Alex Zinenko [Thu, 19 Jan 2023 10:32:42 +0000 (10:32 +0000)]
[mlir] fix mlir integration tests
Alex Zinenko [Mon, 9 Jan 2023 18:06:09 +0000 (18:06 +0000)]
[mlir] simpler transform dialect silenceable failures
Simplify the handling of silenceable failures in the transform dialect.
Previously, the logic of `TransformEachOpTrait` required that
`applyToEach` returned a list of null pointers when a silenceable
failure was emitted. This was not done consistently and also crept into
ops without this trait although they did not require it. Handle this
case earlier in the interpreter and homogeneously associated preivously
unset transform dialect values (both handles and parameters) with empty
lists of the matching kind. Ignore the results of `applyToEach` for the
targets for which it produced a silenceable failure. As a result, one
never needs to set results to lists containing nulls. Furthermore, the
objects associated with transform dialect values must never be null.
Depends On D140980
Reviewed By: nicolasvasilache
Differential Revision: https://reviews.llvm.org/D141305
Alex Zinenko [Wed, 4 Jan 2023 14:04:53 +0000 (14:04 +0000)]
[mlir] make multi-size tiling use transform parameters
Use the recently introduced transform dialect parameter mechanism to
perform controllable multi-size tiling with sizes computed at the
transformation time rather than at runtime.
This requires to generalize tile and split structured transform
operations to work with any transform dialect handle types, which is
desirable in itself to avoid unchecked overuse of PDL OperationType.
Reviewed By: shabalin
Differential Revision: https://reviews.llvm.org/D140980
Nikita Popov [Thu, 19 Jan 2023 09:04:03 +0000 (10:04 +0100)]
[Regex] Avoid NFA machinery for fixed prefix chars (NFC)
Similarly to what backref() does, add an "easy path" to slow()
that can handle some non-branching cases, in particular simple
character matches.
This has the dual effect of reducing the number of characters we
need to match, and the number of states in the NFA.
This reduces FileCheck runtime on vloxseg.c from 17s to 12s on
my machine.
Timm Bäder [Thu, 27 Oct 2022 09:37:11 +0000 (11:37 +0200)]
[clang][Interp] Diagnose uninitialized array record fields
Just like we do for record members, diagnose uninitialized array record
fields.
Differential Revision: https://reviews.llvm.org/D136828
Haojian Wu [Thu, 19 Jan 2023 09:46:53 +0000 (10:46 +0100)]
[clangd] Simplify some tests in IncludeCleanerTests, NFC
They were pointed out in the review of https://reviews.llvm.org/D140875
Timm Bäder [Thu, 27 Oct 2022 04:16:01 +0000 (06:16 +0200)]
[clang][Interp] Unify visiting variable declarations
We often visit the same variable multiple times, e.g. once when checking
its initializer and later when compiling the function. Unify both of
those in visitVarDecl() and do the returning of the value in
visitDecl().
Differential Revision: https://reviews.llvm.org/D136815
David Sherwood [Tue, 17 Jan 2023 15:16:25 +0000 (15:16 +0000)]
[AArch64][SVE2p1] Add SVE2.1 while (predicate-pair) intrinsics
Adds intrinsics for the following instructions:
* WHILEGE (predicate pair)
* WHILEGT (predicate pair)
* WHILEHI (predicate pair)
* WHILEHS (predicate pair)
* WHILELE (predicate pair)
* WHILELO (predicate pair)
* WHILELS (predicate pair)
* WHILELT (predicate pair)
I've added an opcode selector called SelectOpcodeFromVT to
AArch64ISelDAGToDAG.cpp that we will extend in future to
select opcodes from different MVTs. For now, the only use is
for selecting predicate types.
NOTE: These intrinsics are still in development and are subject
to future changes.
Differential Revision: https://reviews.llvm.org/D141936
Christian Ulmann [Thu, 19 Jan 2023 09:02:39 +0000 (10:02 +0100)]
[mlir][FuncToLLVM] Drop llvm.linkage attribute
This commit ensures that all functions produced by `FuncToLLVM` drop the
llvm.linkage attribute. Furthermore, it adds a small test that checks if
the readnone attribute is preserved.
Reviewed By: gysit
Differential Revision: https://reviews.llvm.org/D142002
Quentin Colombet [Thu, 19 Jan 2023 09:22:37 +0000 (10:22 +0100)]
[test][InstCombine] Remove out-of-date comment
NFC
Quentin Colombet [Wed, 18 Jan 2023 15:01:43 +0000 (16:01 +0100)]
[InstCombine] Don't optimize idempotent `atomicrmw <op>, 0` into `load atomic`
Turning idempotent `atomicrmw`s into `load atomic` is perfectly legal
with respect to how the loading happens, but it may not be legal for the
whole program semantic.
Indeed, this optimization removes a store that may have some effects on
the legality of other optimizations.
Essentially, we lose some information and depending on the backend
it may or may not produce incorrect code, so don't do it!
This fixes llvm.org/PR56450.
Differential Revision: https://reviews.llvm.org/D141277
Johannes de Fine Licht [Thu, 19 Jan 2023 08:52:08 +0000 (09:52 +0100)]
[MLIR][LLVM] Don't use void return type in `getCallableResults`.
In the LLVM IR dialect, `LLVMVoidType` is used to model the return type
of LLVM IR functions with no return value. This is inconsistent with
MLIR APIs, which expect a function with no return value to have an
empty return type. Handle this special case in `LLVMFuncOp` to avoid
mismatches between the number of return values and return types between
caller and callee.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D141676
Alex Zinenko [Thu, 19 Jan 2023 08:58:34 +0000 (08:58 +0000)]
[mlir] fix python test
It was using an incorrect attribute type, but the test was still passing
because of the value being present in the output.
Timm Bäder [Tue, 25 Oct 2022 15:34:31 +0000 (17:34 +0200)]
[clang][Interp] Check Field initialization after constructor call
Differential Revision: https://reviews.llvm.org/D136694
wanglei [Thu, 19 Jan 2023 08:29:14 +0000 (16:29 +0800)]
[LoongArch] Add an option for MCInstPrinter to print numeric reg names
`-loongarch-numeric-reg` for llvm-mc and llc.
`-M numeric` (which matches GNU objdump) for llvm-objdump and llvm-mc.
Reviewed By: SixWeining
Differential Revision: https://reviews.llvm.org/D141743
Yingchi Long [Thu, 19 Jan 2023 08:22:49 +0000 (16:22 +0800)]
[InstCombine] regenerete icmp-logical tests (NFC)
These pattern names are inconsistent with current update_checks.py.
Timm Bäder [Wed, 18 Jan 2023 14:10:40 +0000 (15:10 +0100)]
[clang][Interp][NFC] Initialize constants as ~0u
Timm Bäder [Fri, 2 Dec 2022 07:19:14 +0000 (08:19 +0100)]
[clang][Interp] Use placement new to construct opcode args into vector
Differential Revision: https://reviews.llvm.org/D139185
Timm Bäder [Tue, 17 Jan 2023 08:07:48 +0000 (09:07 +0100)]
[clang][Interp][NFC] Remove unused functions
icedrocket [Thu, 19 Jan 2023 06:35:13 +0000 (22:35 -0800)]
[X86] Avoid converting u64 to f32 using x87 on Windows
The code below currently prints less accurate values only on Windows 32-bit. On Windows, the default precision control on x87 is only 53-bit, and FADD triggers rounding with that precision, so the final result may be less accurate. This revision avoids less accurate conversions by using library calls instead.
```
int main() {
int64_t n = 0b0000000000111111111111111111111111011111111111111111111111111111;
printf("%lld, %.0f, %.0f", n, (float)n, (float)(uint64_t)n);
return 0;
}
```
Reviewed By: craig.topper, lebedev.ri
Differential Revision: https://reviews.llvm.org/D141074
Kazu Hirata [Thu, 19 Jan 2023 03:58:44 +0000 (19:58 -0800)]
Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)
This patch drops the ZeroBehavior parameter from bit counting
functions like countLeadingZeros. ZeroBehavior specifies the behavior
when the input to count{Leading,Trailing}Zeros is zero and when the
input to count{Leading,Trailing}Ones is all ones.
ZeroBehavior was first introduced on May 24, 2013 in commit
eb91eac9fb866ab1243366d2e238b9961895612d. While that patch did not
state the intention, I would guess ZeroBehavior was for performance
reasons. The x86 machines around that time required a conditional
branch to implement countLeadingZero<uint32_t> that returns the 32 on
zero:
test edi, edi
je .LBB0_2
bsr eax, edi
xor eax, 31
.LBB1_2:
mov eax, 32
That is, we can remove the conditional branch if we don't care about
the behavior on zero.
IIUC, Intel's Haswell architecture, launched on June 4, 2013,
introduced several bit manipulation instructions, including lzcnt and
tzcnt, which eliminated the need for the conditional branch.
I think it's time to retire ZeroBehavior as its utility is very
limited. If you care about compilation speed, you should build LLVM
with an appropriate -march= to take advantage of lzcnt and tzcnt.
Even if not, modern host compilers should be able to optimize away
quite a few conditional branches because the input is often known to
be nonzero from dominating conditional branches.
Differential Revision: https://reviews.llvm.org/D141798
Slava Zakharin [Thu, 19 Jan 2023 02:10:09 +0000 (18:10 -0800)]
[flang] Fixed unittest build issue with older gcc.
I am getting this error with `check-flang`:
```
ld.lld: error: undefined symbol: mlir::SuccessorRange::SuccessorRange(mlir::Operation*)
>>> referenced by Operation.h:549 (/llvm-project/llvm/../mlir/include/mlir/IR/Operation.h:549)
>>> CMakeFiles/FlangRuntimeTests.dir/Allocatable.cpp.o:(mlir::Operation::getSuccessors())
```
The buildbots are okay, so I guess it has something to do with
gcc-9 that I am using.
Differential Revision: https://reviews.llvm.org/D142069
River Riddle [Fri, 16 Dec 2022 10:33:53 +0000 (02:33 -0800)]
[mlir] Make FunctionOpInterface inherit SymbolOpInterface
This lets users of FunctionOpInterface finally have the
name/visibility accessors from SymbolOpInterface. This also
lets us remove the clunky "getName" method from FunctionOpInterface.
Differential Revision: https://reviews.llvm.org/D140199
River Riddle [Thu, 12 Jan 2023 21:35:15 +0000 (13:35 -0800)]
[mlir] Add support for interface inheritance
This allows for interfaces to define a set of "base classes",
which are interfaces whose methods/extra class decls/etc.
should be inherited by the derived interface. This more
easily enables combining interfaces and their dependencies,
without lots of awkard casting. Additional implicit conversion
operators also greatly simplify the conversion process.
One other aspect of this "inheritance" is that we also implicitly
add the base interfaces to the attr/op/type. The user can still
add them manually if desired, but this should help remove some
of the boiler plate when an interface has dependencies.
See https://discourse.llvm.org/t/interface-inheritance-and-dependencies-interface-method-visibility-interface-composition
Differential Revision: https://reviews.llvm.org/D140198
River Riddle [Fri, 16 Dec 2022 09:16:15 +0000 (01:16 -0800)]
[mlir] Move SymbolOpInterfaces "classof" check to a proper "extraClassOf" interface field
SymbolOpInterface overrides the base classof to provide support
for optionally implementing the interface. This is currently placed
in the extraClassDeclarations, but that is kind of awkard given that
it requires underlying knowledge of how the base classof is implemented.
This commit adds a proper "extraClassOf" field to allow interfaces to
implement this, which abstracts away the default classof logic.
Differential Revision: https://reviews.llvm.org/D140197
River Riddle [Thu, 15 Dec 2022 22:02:06 +0000 (14:02 -0800)]
[mlir] Limit Interface generation to the top-level input file
There are very few instances in which we use multiple files
for interface definitions (none upstream), and this allows
for including interfaces that shouldn't be generated (for
interface inheritance, dependencies, etc.)
Differential Revision: https://reviews.llvm.org/D140196
Jan Korous [Thu, 19 Jan 2023 02:54:48 +0000 (18:54 -0800)]
[-Wunsafe-buffer-usage][NFC] Fix Fixables filtering
We have WIP Fixables for local variables and this central part of the machinery
was dropping Fixables attached to local variables instead of keeping those and
dropping everything else.
We are in the process of rewriting our patches for emitting fixits after we
discovered a conceptual problem in our design.
That is why there's currently no tests that would've detected the issue but
that will change very shortly.
Chuanqi Xu [Thu, 19 Jan 2023 02:37:48 +0000 (10:37 +0800)]
Revert "[NFC] [Serialization] Add static assert for the size of the decls to"
This reverts commit
c79635cce845d66897970cd7f8d7c77b0a3c0286. Since I
forgot the case for 32-bit machine.
LLVM GN Syncbot [Thu, 19 Jan 2023 02:25:05 +0000 (02:25 +0000)]
[gn build] Port
557a5bc336ff
Chuanqi Xu [Wed, 18 Jan 2023 07:50:04 +0000 (15:50 +0800)]
[NFC] [Serialization] Add static assert for the size of the decls to
mention developers to remember to touch the serializer after them
modified the field of decls
It is easy for the developers to forget to touch the serializer after
they add new field to decls. Then if the existing tests fail to catch
such cases, it may be a bug report from users some day. And it is
time-consuming to solve such bugs.
To mitigate the problem, I add the static_asserts in the serializer. So
that the developers can understand they need to modify the serializer
after they saw the static assertion failure. Although this can't solve
all the problems, I feel the current status can be much better.
Reviewed By: erichkeane
Differential Revision: https://reviews.llvm.org/D141992
Nico Weber [Thu, 19 Jan 2023 02:16:51 +0000 (21:16 -0500)]
[gn] port
a033dbbe5c43 (clang-stat-cache)
Paul Kirth [Fri, 13 Jan 2023 23:20:56 +0000 (23:20 +0000)]
[codegen] Add StackFrameLayoutAnalysisPass
Issue #58168 describes the difficulty diagnosing stack size issues
identified by -Wframe-larger-than. For simple code, its easy to
understand the stack layout and where space is being allocated, but in
more complex programs, where code may be heavily inlined, unrolled, and
have duplicated code paths, it is no longer easy to manually inspect the
source program and understand where stack space can be attributed.
This patch implements a machine function pass that emits remarks with a
textual representation of stack slots, and also outputs any available
debug information to map source variables to those slots.
The new behavior can be used by adding `-Rpass-analysis=stack-frame-layout`
to the compiler invocation. Like other remarks the diagnostic
information can be saved to a file in a machine readable format by
adding -fsave-optimzation-record.
Fixes: #58168
Reviewed By: nickdesaulniers, thegameg
Differential Revision: https://reviews.llvm.org/D135488
Kirill Stoimenov [Wed, 21 Dec 2022 22:31:40 +0000 (22:31 +0000)]
[HWASAN] Init lsan and install at_exit hook
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D141146
Lang Hames [Thu, 19 Jan 2023 01:33:50 +0000 (17:33 -0800)]
[ORC-RT] Specialize non-coalescing-IntervalMap to allow non-comparable values.
In non-coalescing IntervalMaps the value type should not be requried to be
equality-comparable.
Vitaly Buka [Thu, 19 Jan 2023 01:24:10 +0000 (17:24 -0800)]
[NFC][sanitizers] Add COMPILER_RT_HAS_WTHREAD_SAFETY_*_FLAG
Shilei Tian [Thu, 19 Jan 2023 01:08:59 +0000 (20:08 -0500)]
[OpenMP][OMPT] Expect failure from tool_available_search.c on macOS
D91464 introduced verbose tool loading, but the test check only considers Linux.
On macOS, the outputs are totally different, causing the regression afterwards.
This patch simply sets the test to XFAIL on macOS.
Fix #56833.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D142045
Shilei Tian [Thu, 19 Jan 2023 01:08:10 +0000 (20:08 -0500)]
[OpenMP][AMDGPU] Get rid of redundant macro def
The next gen plugin adds the def of `DEBUG_PREFIX` in CMake, causing
compiler warning that `DEBUG_PREFIX` is defined multiple times. This patch simply
guards the macro def.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D142064