Richard Biener [Mon, 12 Aug 2019 11:02:21 +0000 (11:02 +0000)]
re PR lto/91375 (ICE on valid code in subbinfo_with_vtable_at_offset at ipa-devirt.c:2760 since r256685)
2019-08-12 Richard Biener <rguenther@suse.de>
PR lto/91375
* tree.c (free_lang_data_in_type): Do not free TYPE_BINFO dependent on
flag_devirtualize.
From-SVN: r274310
Richard Biener [Mon, 12 Aug 2019 10:59:58 +0000 (10:59 +0000)]
re PR driver/91130 (-MF clashes with -flto on aarch64)
2019-08-12 Richard Biener <rguenther@suse.de>
PR driver/91130
* lto-wrapper.c (get_options_from_collect_gcc_options): Remove
lang_mask option, always use CL_DRIVER.
(get_options_from_collect_gcc_options): Adjust.
(find_and_merge_options): Likewise.
(run_gcc): Likewise.
From-SVN: r274309
Dmitriy Anisimkov [Mon, 12 Aug 2019 09:01:58 +0000 (09:01 +0000)]
[Ada] Fix IPv6 numeric address detection
IPv6 numeric address can't have less than 2 colons. It fixes the error
when Get_Host_By_Name called with hostname composed by only hexadecimal
symbols.
2019-08-12 Dmitriy Anisimkov <anisimko@adacore.com>
gcc/ada/
* libgnat/g-socket.adb (Is_IPv6_Address): Check that no less
then 2 colons in IPv6 numeric address.
From-SVN: r274308
Dmitriy Anisimkov [Mon, 12 Aug 2019 09:01:53 +0000 (09:01 +0000)]
[Ada] New parameter Quiet for procedure GNAT.Command_Line.Getopt
Getopt procedure is parsing the command line or set of strings. If the
command line contains unknown switch than the Getopt prints error
message to the console and raises the exception Invalid_Switch. The
printing can be inappropriate in some cases. The new parameter Quiet
allows avoiding console output.
2019-08-12 Dmitriy Anisimkov <anisimko@adacore.com>
gcc/ada/
* libgnat/g-comlin.ads, libgnat/g-comlin.adb (Getopt): Add
parameter Quiet. Need to do not output error messages to
console. Invalid_Switch exception generation surrounded by an
error message.
From-SVN: r274307
Ed Schonberg [Mon, 12 Aug 2019 09:01:48 +0000 (09:01 +0000)]
[Ada] Missing check on outbound parameter of a non-null access type
This patch adds code to generate proper post-call checks when an actual
for an in-out or out parameter has a non-null access type. No
constraints are applied to an inbound access parameter, but on exit a
not-null check must be performed if the type of the actual requires it.
2019-08-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch6.adb (Expand_Actuals. Add_Call_By_Copy_Code): Add code
to generate proper checks when an actual for an in-out or out
parameter has a non-null access type. No constraints are
applied to an inbound access parameter, but on exit a not-null
check must be performed if the type of the actual requires it.
gcc/testsuite/
* gnat.dg/null_check.adb: New testcase.
From-SVN: r274306
Ed Schonberg [Mon, 12 Aug 2019 09:01:43 +0000 (09:01 +0000)]
[Ada] Crash on illegal left-hand side in assignment of renamed variable
This patch fixes a crash on an assignment where the left-hand side is a
renaming of a function call that does not involve ceiling priorities.
This avoids a compiler crash in some cases, and prevents a useless
retrieval and compilation of run-time packages.
2019-08-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_util.adb (Is_Expaned_Priority_Attribute): Check whether
call comes from a rewritten attribute before comparing name with
Get_Ceiling run-time subprogram.
gcc/testsuite/
* gnat.dg/renaming15.adb: New testcase.
From-SVN: r274305
Eric Botcazou [Mon, 12 Aug 2019 09:01:38 +0000 (09:01 +0000)]
[Ada] Small comment tweaks for 3 predicates on bit-aligned references
They fix a few glitches left and right. No functional changes.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_util.ads (Component_May_Be_Bit_Aligned): Small comment
tweaks.
(Possible_Bit_Aligned_Component): Likewise.
(Type_May_Have_Bit_Aligned_Components): Likewise.
* exp_util.adb (Component_May_Be_Bit_Aligned): Likewise.
(Possible_Bit_Aligned_Component): Likewise.
(Type_May_Have_Bit_Aligned_Components): Likewise.
From-SVN: r274304
Eric Botcazou [Mon, 12 Aug 2019 09:01:33 +0000 (09:01 +0000)]
[Ada] Fix internal error on comparison of unaligned slices
This fixes an internal error in the code generator when it is trying to
take the address of a slice which does not start on a byte boundary, in
order to generate a comparison between slices with a dynamic length.
This case is not supported by the code generator and comes from an
explicit representation clause on a record type, so it must be detected
and handled by the front-end by expanding the comparison on an
element-by-element basis.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Op_Eq): Expand the array equality if
either operand is a possibly unaligned slice.
* exp_ch6.adb (Expand_Simple_Function_Return): Do not generate a
copy for a possibly unaligned object if it is represented as a
scalar.
* exp_util.adb (Is_Possibly_Unaligned_Slice): Do not always
return false if the target doesn't have strict alignment.
gcc/testsuite/
* gnat.dg/slice10.adb: New testcase.
From-SVN: r274303
Bob Duff [Mon, 12 Aug 2019 09:01:25 +0000 (09:01 +0000)]
[Ada] Do not suppress checks in instances of internal generics
This patch removes suppression of checks in nested instances of internal
packages. No test.
This was inconsistent: only for packages, not for subprograms. Only for
nested instantiations, not library level ones. Not for GNAT units.
Furthermore, the user should have control via pragma Suppress or
switches.
Furthermore, without this change, there could be missing tampering
checks in Ada.Containers.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* sem_ch12.adb (Instantiate_Package_Body): Remove suppression of
checks in instances of internal units.
* sem_ch6.adb (Analyze_Function_Return): Do not generate a
constraint check on an extended_return_statement if the subtype
of the return object in the statement is identical to the return
subtype of the function.
From-SVN: r274302
Bob Duff [Mon, 12 Aug 2019 09:01:20 +0000 (09:01 +0000)]
[Ada] Prevent crash in Is_Reachable
This patch fixes a bug in Is_Reachable, which causes a crash when checks
are on.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/a-cbmutr.adb (Is_Reachable): Declare Idx to be of the
base subtype. Clearly it makes no sense to loop "while Idx >=
0", if Idx is of a nonnegative subtype.
From-SVN: r274301
Bob Duff [Mon, 12 Aug 2019 09:01:14 +0000 (09:01 +0000)]
[Ada] Prevent crash in Put_Scaled
This patch fixes a bug in Put_Scaled, which causes a crash when checks
are on.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/a-tifiio.adb (Put_Scaled): Prevent AA from being
negative, since Field is range 0 .. something.
From-SVN: r274300
Bob Duff [Mon, 12 Aug 2019 09:01:09 +0000 (09:01 +0000)]
[Ada] Remove doc for language version switches
Remove documentation for Ada language version switches, and note that
they are no longer needed. These tools now silently ignore such
switches, and process the file correctly no matter what version of Ada
is used.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* doc/gnat_ugn/gnat_utility_programs.rst (gnatmetric, gnatpp,
gnatstub): Remove documentation for Ada language version
switches, and note that they are no longer needed.
From-SVN: r274299
Gary Dismukes [Mon, 12 Aug 2019 09:01:04 +0000 (09:01 +0000)]
[Ada] Hang on loop in generic with subtype indication specifying a range
The compiler may hang when a for loop expanded in a generic
instantiation has a range specified by a subtype indication with an
explicit range that has a bound that is an attribute applied to a
discriminant-dependent array component. The Parent field of the bound
may not be set, which can lead to endless looping when an actual subtype
created for the array component is passed to Insert_Actions. This is
fixed by setting the Parent fields of the copied bounds before
Preanalyze is called on them.
2019-08-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_ch5.adb (Prepare_Param_Spec_Loop): Set the parents of the
copied low and high bounds in the case where the loop range is
given by a discrete_subtype_indication, to prevent hanging (or
Assert_Failure) in Insert_Actions.
gcc/testsuite/
* gnat.dg/generic_inst7.adb, gnat.dg/generic_inst7_pkg.adb,
gnat.dg/generic_inst7_pkg.ads, gnat.dg/generic_inst7_types.ads:
New testcase.
From-SVN: r274298
Ed Schonberg [Mon, 12 Aug 2019 09:00:59 +0000 (09:00 +0000)]
[Ada] Improper error message on equality op with different operand types
2019-08-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch6.adb (heck_Untagged_Equality): Verify that user-defined
equality has the same profile as the predefined equality before
applying legality rule in RM 4.5.2 (9.8).
gcc/testsuite/
* gnat.dg/equal10.adb, gnat.dg/equal10.ads: New testcase.
From-SVN: r274297
Bob Duff [Mon, 12 Aug 2019 09:00:39 +0000 (09:00 +0000)]
[Ada] Minor cleanups in exception handling
No change in behavior, so no test.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/a-except.ads: Update obsolete comment, still making
clear that this is a variant. Add explicit default for Id
component of Exception_Occurrence, because that value is used.
Define Null_Occurrence less redundantly.
* libgnat/a-einuoc.adb: Minor simplification of code.
From-SVN: r274296
Justin Squirek [Mon, 12 Aug 2019 09:00:27 +0000 (09:00 +0000)]
[Ada] Implement Ada.Directories.Hierarchical_File_Names
This patch corrects certain behaviors within Ada.Directories to better
conform to conformance tests and implements the package
Ada.Directories.Hierarchical_File_Names outlined in AI05-0049-1.
Only partial test sources are included.
------------
-- Source --
------------
-- main.ads
with Ada.Directories.Hierarchical_File_Names;
use Ada.Directories.Hierarchical_File_Names;
with Ada.Exceptions; use Ada.Exceptions;
with Ada.Text_IO; use Ada.Text_IO;
procedure Main is
FULL_PATH_A : constant String := "/export/work/user/bug";
FULL_PATH_B : constant String := "/export/work/user";
RELATIVE_PATH_A : constant String := "export/work/user/bug/";
RELATIVE_PATH_B : constant String := "export/work/user/bug";
SIMPLE_PATH_A : constant String := "bug/";
SIMPLE_PATH_B : constant String := "bug";
ROOT_PATH : constant String := "/";
CURRENT_DIR : constant String := ".";
PARENT_DIR : constant String := "..";
RELATIVE_WITH_CURRENT : constant String := RELATIVE_PATH_A & ".";
RELATIVE_WITH_PARENT : constant String := RELATIVE_PATH_A & "..";
begin
Put_Line ("Simple_Name");
Put_Line (Is_Simple_Name (FULL_PATH_A)'Image);
Put_Line (Is_Simple_Name (FULL_PATH_B)'Image);
Put_Line (Is_Simple_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Simple_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Simple_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Simple_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Simple_Name (ROOT_PATH)'Image);
Put_Line (Is_Simple_Name (CURRENT_DIR)'Image);
Put_Line (Is_Simple_Name (PARENT_DIR)'Image);
Put_Line (Is_Simple_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Simple_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line (Simple_Name (FULL_PATH_A));
Put_Line (Simple_Name (FULL_PATH_B));
Put_Line (Simple_Name (RELATIVE_PATH_A));
Put_Line (Simple_Name (RELATIVE_PATH_B));
Put_Line (Simple_Name (SIMPLE_PATH_A));
Put_Line (Simple_Name (SIMPLE_PATH_B));
Put_Line (Simple_Name (ROOT_PATH));
Put_Line (Simple_Name (CURRENT_DIR));
Put_Line (Simple_Name (PARENT_DIR));
Put_Line (Simple_Name (RELATIVE_WITH_CURRENT));
Put_Line (Simple_Name (RELATIVE_WITH_PARENT));
Put_Line ("Root_Directory_Name");
Put_Line (Is_Root_Directory_Name (FULL_PATH_A)'Image);
Put_Line (Is_Root_Directory_Name (FULL_PATH_B)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Root_Directory_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Root_Directory_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Root_Directory_Name (ROOT_PATH)'Image);
Put_Line (Is_Root_Directory_Name (CURRENT_DIR)'Image);
Put_Line (Is_Root_Directory_Name (PARENT_DIR)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Is_Parent_Directory_Name");
Put_Line (Is_Parent_Directory_Name (FULL_PATH_A)'Image);
Put_Line (Is_Parent_Directory_Name (FULL_PATH_B)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Parent_Directory_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Parent_Directory_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Parent_Directory_Name (ROOT_PATH)'Image);
Put_Line (Is_Parent_Directory_Name (CURRENT_DIR)'Image);
Put_Line (Is_Parent_Directory_Name (PARENT_DIR)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Is_Current_Directory_Name");
Put_Line (Is_Current_Directory_Name (FULL_PATH_A)'Image);
Put_Line (Is_Current_Directory_Name (FULL_PATH_B)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Current_Directory_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Current_Directory_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Current_Directory_Name (ROOT_PATH)'Image);
Put_Line (Is_Current_Directory_Name (CURRENT_DIR)'Image);
Put_Line (Is_Current_Directory_Name (PARENT_DIR)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Is_Full_Name");
Put_Line (Is_Full_Name (FULL_PATH_A)'Image);
Put_Line (Is_Full_Name (FULL_PATH_B)'Image);
Put_Line (Is_Full_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Full_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Full_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Full_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Full_Name (ROOT_PATH)'Image);
Put_Line (Is_Full_Name (CURRENT_DIR)'Image);
Put_Line (Is_Full_Name (PARENT_DIR)'Image);
Put_Line (Is_Full_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Full_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Relative_Name");
Put_Line (Is_Relative_Name (FULL_PATH_A)'Image);
Put_Line (Is_Relative_Name (FULL_PATH_B)'Image);
Put_Line (Is_Relative_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Relative_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Relative_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Relative_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Relative_Name (ROOT_PATH)'Image);
Put_Line (Is_Relative_Name (CURRENT_DIR)'Image);
Put_Line (Is_Relative_Name (PARENT_DIR)'Image);
Put_Line (Is_Relative_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Relative_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line (Relative_Name (FULL_PATH_A));
Put_Line (Relative_Name (FULL_PATH_B));
Put_Line (Relative_Name (RELATIVE_PATH_A));
Put_Line (Relative_Name (RELATIVE_PATH_B));
begin
Put_Line (Relative_Name (SIMPLE_PATH_A));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (SIMPLE_PATH_B));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (ROOT_PATH));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (CURRENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (PARENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
Put_Line (Relative_Name (RELATIVE_WITH_CURRENT));
Put_Line (Relative_Name (RELATIVE_WITH_PARENT));
Put_Line ("Containing_Directory");
Put_Line (Containing_Directory (FULL_PATH_A));
Put_Line (Containing_Directory (FULL_PATH_B));
Put_Line (Containing_Directory (RELATIVE_PATH_A));
Put_Line (Containing_Directory (RELATIVE_PATH_B));
Put_Line (Containing_Directory (SIMPLE_PATH_A));
Put_Line (Containing_Directory (SIMPLE_PATH_B));
begin
Put_Line (Containing_Directory (ROOT_PATH));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Containing_Directory (CURRENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Containing_Directory (PARENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
Put_Line (Containing_Directory (RELATIVE_WITH_CURRENT));
Put_Line (Containing_Directory (RELATIVE_WITH_PARENT));
Put_Line ("Initial_Directory");
Put_Line (Initial_Directory (FULL_PATH_A));
Put_Line (Initial_Directory (FULL_PATH_B));
Put_Line (Initial_Directory (RELATIVE_PATH_A));
Put_Line (Initial_Directory (RELATIVE_PATH_B));
Put_Line (Initial_Directory (SIMPLE_PATH_A));
Put_Line (Initial_Directory (SIMPLE_PATH_B));
Put_Line (Initial_Directory (ROOT_PATH));
Put_Line (Initial_Directory (CURRENT_DIR));
Put_Line (Initial_Directory (PARENT_DIR));
Put_Line (Initial_Directory (RELATIVE_WITH_CURRENT));
Put_Line (Initial_Directory (RELATIVE_WITH_PARENT));
end;
-----------------
-- Compilation --
-----------------
$ gnatmake -q main.adb
Simple_Name
FALSE
FALSE
FALSE
FALSE
TRUE
TRUE
FALSE
TRUE
TRUE
FALSE
FALSE
bug
user
bug
bug
bug
bug
/
.
..
.
..
Root_Directory_Name
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
FALSE
FALSE
Is_Parent_Directory_Name
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
Is_Current_Directory_Name
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
FALSE
Is_Full_Name
TRUE
TRUE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
FALSE
FALSE
Relative_Name
FALSE
FALSE
TRUE
TRUE
TRUE
TRUE
FALSE
TRUE
TRUE
TRUE
TRUE
export/work/user/bug
export/work/user
work/user/bug/
work/user/bug
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "bug/" is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "bug" is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "/" is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "." is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name ".." is
composed of a single part
work/user/bug/.
work/user/bug/..
Containing_Directory
/export/work/user
/export/work
export/work/user/bug
export/work/user
bug
.
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory "/" has no containing directory
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory "." has no containing directory
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory ".." has no containing directory
export/work/user/bug
export/work/user/bug
Initial_Directory
/
/
export
export
bug
bug
/
.
..
export
export
2019-08-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* libgnat/a-dhfina.adb, libgnat/a-dhfina.ads (Is_Simple_Name,
Is_Root_Directory, Is_Parent_Directory,
Is_Current_Directory_Name, Is_Relative_Name, Initial_Directory,
Relative_Name, Compose): Add implementation and documentation.
* libgnat/a-direct.adb (Containing_Directory): Modify routine to
use routines from Ada.Directories.Hierarchical_File_Names and
remove incorrect special case for parent directories.
(Fetch_Next_Entry): Add check for current directory and parent
directory and ignore them under certain circumstances.
(Simple_Nmae): Add check for null result from
Simple_Name_Internal and raise Name_Error.
(Simple_Name_Internal): Add explicit check for root directories,
sanitize trailing directory separators, and modify behavior so
that current and parent directories are considered valid
results.
* Makefile.rtl: Add entry to GNATRTL_NONTASKING_OBJS.
From-SVN: r274295
Eric Botcazou [Mon, 12 Aug 2019 09:00:04 +0000 (09:00 +0000)]
[Ada] Improve error message for Object_Size clause on dynamic array
This makes the compiler issue the same error:
size clause not allowed for variable length type
for an Object_Size clause on a variable-sized type as for a Size clause,
for example on the following procedure:
procedure P (X, Y : Integer) is
subtype Sub is String (X .. Y) with Object_Size => 64;
begin
null;
end;
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* freeze.adb (Freeze_Entity): Give the same error for an
Object_Size clause on a variable-sized type as for a Size
clause.
From-SVN: r274294
Gary Dismukes [Mon, 12 Aug 2019 08:59:58 +0000 (08:59 +0000)]
[Ada] Suppress_Initialization not respected for private subtypes
The compiler fails to suppress initialization on a variable of a subtype
of a private type (such as System.Address) even though the subtype has
aspect Suppress_Initialization. This can lead to errors on object
declarations specified with Thread_Local_Storage when Initialize_Scalars
is applied (as well as leading to default initialization when it
shouldn't).
2019-08-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma, Pragma_Suppress_Initialization):
For private types, set the Suppress_Initialization flag on the
Full_View of the entity rather than the entity's base type.
gcc/testsuite/
* gnat.dg/suppress_initialization2.adb,
gnat.dg/suppress_initialization2.ads: New testcase.
From-SVN: r274293
Yannick Moy [Mon, 12 Aug 2019 08:59:53 +0000 (08:59 +0000)]
[Ada] New aspect/pragma No_Caching for analysis of volatile data
A new aspect/pragma can be attached to volatile variables to indicate
that such a variable is not used for interactions with the external
world, but only that accesses to that variable should not be optimized
by the compiler. This is in particular useful for guarding against fault
injection. SPARK Reference manual has been updated to allow this use of
volatile data, see section 7.1.2, so that GNATprove can analyze such
variables as not volatile.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* aspects.adb, aspects.ads (Aspect_No_Caching): New aspect.
* contracts.adb, contracts.ads (Add_Contract_Item): Add handling
of No_Caching.
(Analyze_Object_Contract): Add handling of No_Caching.
* einfo.adb, einfo.ads
(Get_Pragma): Add handling of No_Caching.
* doc/gnat_rm/implementation_defined_aspects.rst,
doc/gnat_rm/implementation_defined_pragmas.rst: Document new
aspect/pragma.
* gnat_rm.texi: Regenerate.
* par-prag.adb (Prag): New pragma Pragma_No_Caching.
* sem_ch13.adb (Analyze_Aspect_Specifications,
Check_Aspect_At_Freeze_Point): Add handling of No_Caching.
* sem_prag.adb (Analyze_Pragma): Deal with pragma No_Caching.
* sem_prag.ads (Analyze_External_Property_In_Decl_Part): Now
applies to No_Caching.
* sem_util.adb, sem_util.ads (Is_Effectively_Volatile): Add
handling of No_Caching.
(No_Caching_Enabled): New query function.
* snames.ads-tmpl: New names for pragma.
gcc/testsuite/
* gnat.dg/no_caching.adb, gnat.dg/no_caching.ads: New testcase.
From-SVN: r274292
Yannick Moy [Mon, 12 Aug 2019 08:59:47 +0000 (08:59 +0000)]
[Ada] Adapt new extended traversal of AST to have optional part
The new extended traversal of the AST for GNATprove use now optionally
traverses the ranges under Itypes, based on a formal parameter.
There is no impact on compilation.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb, sem_util.ads (Traverse_More_Func,
Traverse_More_Proc): Add formal parameter for Itypes traversal.
From-SVN: r274291
Yannick Moy [Mon, 12 Aug 2019 08:59:42 +0000 (08:59 +0000)]
[Ada] More precise handling of Size/Object_Size in GNATprove
GNATprove does a partial expansion which did not allow getting the
most precise value for attributes Size/Object_Size. Now fixed.
There is no impact on compilation.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* exp_attr.adb, exp_attr.ads (Expand_Size_Attribute): New
procedure to share part of the attribute expansion with
GNATprove mode.
(Expand_N_Attribute_Reference): Extract part of the
Size/Object_Size expansion in the new procedure
Expand_Size_Attribute.
* exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Expand
Size/Object_Size attributes using the new procedure
Expand_Size_Attribute.
From-SVN: r274290
Yannick Moy [Mon, 12 Aug 2019 08:59:37 +0000 (08:59 +0000)]
[Ada] SPARK: disable expansion of Enum_Rep
Disable expansion of Enum_Rep into a type conversion as it is incorrect
in SPARK.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Only
expand Enum_Rep attribute when its parameter is a literal.
From-SVN: r274289
Justin Squirek [Mon, 12 Aug 2019 08:59:33 +0000 (08:59 +0000)]
[Ada] Inconsistent compile time Constraint_Error warning
This patch corrects several bugs within the compiler which led to
inconsistent handling of compile time Constraint_Errors. Notibly,
subtype out of range checks which are only out of range of the subtype
must be warnings while out of range checks where the value is out of
range of the base type must be an error. Also, type conversions and
qualified expressions on literals constitute errors on any out of range
value. The compiler needed many of these cases clarified.
------------
-- Source --
------------
-- main.ads
with System;
package Main is
type T_Enum is (Enum_1, Enum_2, Unknown)
with Default_Value => Unknown;
subtype T_Valid_Enum is T_Enum range Enum_1 .. Enum_2;
Value : T_Valid_Enum; -- WARNING
generic
type T_Element is (<>);
Init : T_Element;
package Generic_Test is
Value : T_Element := Init;
end;
package titi is new Generic_Test (T_Valid_Enum, Unknown); -- WARNING
type My_Float is digits System.Max_Base_Digits;
My_Float_Last : constant := My_Float'Last;
Out_Of_Range : constant := My_Float_Last + 1.0;
Flt1 : My_Float := Out_Of_Range; -- ERROR
A : Positive := Positive (16#9999_9999_9999#); -- ERROR
B : Positive := 16#9999_9999_9999#; -- ERROR
C : Positive := 0; -- WARNING
D : Positive := Positive (0); -- ERROR
E : Positive := Positive'(16#9999_9999_9999#); -- ERROR
F : Positive := Positive'(0); -- ERROR
end;
-----------------
-- Compilation --
-----------------
$ gnatmake -q -gnatw_a main.adb
main.ads:9:12: warning: value not in range of type "T_Valid_Enum" defined at
line 7
main.ads:9:12: warning: "Constraint_Error" will be raised at run time
main.ads:18:52: warning: value not in range of type "T_Element" defined at
line 12, instance at line 18
main.ads:18:52: warning: "Constraint_Error" will be raised at run time
main.ads:25:23: value not in range of type "My_Float" defined at line 20
main.ads:25:23: static expression fails Constraint_Check
main.ads:27:19: value not in range of type "Standard.Positive"
main.ads:27:19: static expression fails Constraint_Check
main.ads:28:19: value not in range of type "Standard.Positive"
main.ads:28:19: static expression fails Constraint_Check
main.ads:29:19: warning: value not in range of type "Standard.Positive"
main.ads:29:19: warning: "Constraint_Error" will be raised at run time
main.ads:30:19: value not in range of type "Standard.Positive"
main.ads:30:19: static expression fails Constraint_Check
main.ads:31:27: value not in range of type "Standard.Positive"
main.ads:31:27: static expression fails Constraint_Check
main.ads:32:27: value not in range of type "Standard.Positive"
main.ads:32:27: static expression fails Constraint_Check
gnatmake: "main.ads" compilation error
2019-08-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_eval.adb (Check_Non_Static_Context): Add a condition to
determine if a range violation constitues a warning or an error.
(Out_Of_Range): Add a condition to determine if a range
violation constitues a warning or an error.
From-SVN: r274288
Eric Botcazou [Mon, 12 Aug 2019 08:59:28 +0000 (08:59 +0000)]
[Ada] Eliminate redundant range checks on conversions
This gets rid of redundant range checks generated in 5 out of the 9
cases of scalar conversions, i.e. (integer, fixed-point, floating-point)
converted to (integer, fixed-point, floating-point).
The problem is that the Real_Range_Check routine rewrites the conversion
node into a conversion to the base type so, when its parent node is
analyzed, a new conversion to the subtype may be introduced, depending
on the context, giving rise to a second range check against the subtype
bounds.
This change makes Real_Range_Check rewrite the expression of the
conversion node instead of the node, so that the type of the node is
preserved and no new conversion is introduced. As a matter of fact,
this is exactly what happens in the float-to-float case which goes to
the Generate_Range_Check circuit instead and does not suffer from the
duplication of range checks.
For the following procedure, the compiler must now generate exactly one
range check per nested function:
procedure P is
type I1 is new Integer range -100 .. 100;
type I2 is new Integer range -200 .. 200;
type D1 is delta 0.5 range -100.0 .. 100.0;
type D2 is delta 0.5 range -200.0 .. 200.0;
type F1 is new Long_Float range -100.0 .. 100.0;
type F2 is new Long_Float range -200.0 .. 200.0;
function Conv (A : I2) return I1 is
begin
return I1 (A);
end;
function Conv (A : D2) return I1 is
begin
return I1 (A);
end;
function Conv (A : F2) return I1 is
begin
return I1 (A);
end;
function Conv (A : I2) return D1 is
begin
return D1 (A);
end;
function Conv (A : D2) return D1 is
begin
return D1 (A);
end;
function Conv (A : F2) return D1 is
begin
return D1 (A);
end;
function Conv (A : I2) return F1 is
begin
return F1 (A);
end;
function Conv (A : D2) return F1 is
begin
return F1 (A);
end;
function Conv (A : F2) return F1 is
begin
return F1 (A);
end;
begin
null;
end;
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Real_Range_Check): Do not rewrite the conversion
node but its expression instead, after having fetched its
current value. Clear the Do_Range_Check flag on entry. Return
early for a rewritten float-to-float conversion. Remove
redundant local variable. Suppress all checks when inserting
the temporary and do not reanalyze the node.
From-SVN: r274287
Eric Botcazou [Mon, 12 Aug 2019 08:59:23 +0000 (08:59 +0000)]
[Ada] Sprint: minor comment tweak
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sprint.ads: Minor comment tweak.
From-SVN: r274286
Eric Botcazou [Mon, 12 Aug 2019 08:59:18 +0000 (08:59 +0000)]
[Ada] Fix leak of Do_Range_Check flag in -gnatVa mode
This fixes a small glitch in Insert_Valid_Check, which needs to
propagate the Do_Range_Check flag onto the rewritten expression, but
uses its Original_Node as the source of the copy. Now Original_Node
does not necessarily point to the node that was just rewritten, but to
the ultimately original node, which is not the same node if the
expression was rewritten multiple times. The end result is that a
stalled Do_Range_Check flag can be wrongly resintated and leak to the
code generator.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* checks.adb (Insert_Valid_Check): Do not retrieve the
Do_Range_Check flag from the Original_Node but from the
Validated_Object. Remove useless bypass for floating-point
types.
gcc/testsuite/
* gnat.dg/range_check7.adb: New testcase.
From-SVN: r274285
Yannick Moy [Mon, 12 Aug 2019 08:59:13 +0000 (08:59 +0000)]
[Ada] Extended traversal subprograms for GNATprove
GNATprove needs traversal subprograms that do not simply traverse
syntactic nodes like Atree.Traverse_Func and Atree.Traverse_Proc, but
also traverse semantic nodes which are logically children of the nodes.
Now available through Sem_Util.Traverse_More_Func and
Sem_Util.Traverse_More_Proc.
There is no impact on compilation.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb, sem_util.ads (Traverse_More_Func,
Traverse_More_Proc): New traversal subprograms.
From-SVN: r274284
Jerome Lambourg [Mon, 12 Aug 2019 08:59:08 +0000 (08:59 +0000)]
[Ada] VxWorks: call s-tpopsp.Self only when needed
2019-08-12 Jerome Lambourg <lambourg@adacore.com>
gcc/ada/
* libgnarl/s-taprop__vxworks.adb (Abort_Handler): Only call
s-tpopsp.Self when actually needed.
From-SVN: r274283
Eric Botcazou [Mon, 12 Aug 2019 08:59:02 +0000 (08:59 +0000)]
[Ada] Plug small loophole in Discrete_Range_Check
This routine would not return if range checks are suppressed.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Discrete_Range_Check): Return if checks are
suppressed.
From-SVN: r274282
Eric Botcazou [Mon, 12 Aug 2019 08:58:57 +0000 (08:58 +0000)]
[Ada] Add special bypass for obsolete code pattern
This change prevents the analysis phase of the front-end from setting
the Do_Range_Check flag in the very peculiar case of the source of a
conversion whose result is passed by reference to a "valued procedure",
because the expansion phase would not be able to generate the check.
This pattern appears in the ancient DEC Starlet package and it doesn't
seem to be useful at this point to change the expander to deal with it,
so instead the analysis phase is adjusted. Morever the compiler already
issues a warning in this case so this is probably good enough.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_res.adb: Add with & use clause for Sem_Mech and
alphabetize.
(Resolve_Actuals): Do not apply a scalar range check for the
source of a conversion whose result is passed by reference to a
valued procedure.
From-SVN: r274281
Eric Botcazou [Mon, 12 Aug 2019 08:58:52 +0000 (08:58 +0000)]
[Ada] Fix missing range check for In/Out parameter with -gnatVa
This plugs another small loophole in the front-end which fails to
generate a range check for a scalar In/Out parameter when -gnatVa is
specified. This also fixes a few more leaks of the Do_Range_Check flag
on actual parameters, both in regular and -gnatVa modes, as well as a
leak specific to expression function in -gnatp mode.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* checks.adb (Insert_Valid_Check): Reset the Do_Range_Check flag
on the validated object.
* exp_ch6.adb (Add_Call_By_Copy_Code): Reset the Do_Range_Check
flag on the actual here, as well as on the Expression if the
actual is a N_Type_Conversion node.
(Add_Validation_Call_By_Copy_Code): Generate the incoming range
check if needed and reset the Do_Range_Check flag on the
Expression if the actual is a N_Type_Conversion node.
(Expand_Actuals): Do not reset the Do_Range_Check flag here.
Generate the incoming range check for In parameters here instead
of...
(Expand_Call_Helper): ...here. Remove redudant condition.
* sem_res.adb (Resolve_Actuals): Use local variable A_Typ and
remove obsolete comments.
(Resolve_Type_Conversion): Do not force the Do_Range_Check flag
on the operand if range checks are suppressed.
gcc/testsuite/
* gnat.dg/range_check6.adb: New testcase.
From-SVN: r274280
Eric Botcazou [Mon, 12 Aug 2019 08:58:46 +0000 (08:58 +0000)]
[Ada] Fix incorrect Do_Range_Check on type conversion
This gets rid of another leak of the Do_Range_Check flag to the back-end
which is specific to expression functions. No functional changes.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* checks.adb (Activate_Range_Check): Remove redundant argument.
(Generate_Range_Check): Likewise.
(Apply_Float_Conversion_Check): Reset the Do_Range_Check flag on
entry and remove redundant condition.
From-SVN: r274279
Rainer Orth [Mon, 12 Aug 2019 08:47:34 +0000 (08:47 +0000)]
Fix Ada comparison failure on SPARC
* ipa-predicate.c (add_condition): Restore inverted test.
From-SVN: r274277
Martin Liska [Mon, 12 Aug 2019 07:36:48 +0000 (09:36 +0200)]
Move is_valid_fd to filedescriptor.c file.
2019-08-12 Martin Liska <mliska@suse.cz>
* Makefile.in: Add filedescriptor.c.
* filedescriptor.c: New file.
* lrealpath.c (is_valid_fd): Remove.
From-SVN: r274273
GCC Administrator [Mon, 12 Aug 2019 00:16:25 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274272
Janne Blomqvist [Sun, 11 Aug 2019 09:42:41 +0000 (12:42 +0300)]
PR fortran/91413 Generate warning when making array static
When moving a local variable from the stack to static storage, the
procedure is no longer safe to be called recursively or concurrently
from multiple threads. Thus generate a warning when this is done.
Also double the default limit for switching from stack to static.
Regtested on x86_64-pc-linux-gnu.
gcc/fortran/ChangeLog:
2019-08-11 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/91413
* invoke.texi (-fmax-stack-var-size): Document increased default.
* options.c (gfc_post_options): Increase default stack var size to
65536 bytes.
* trans-decl.c (gfc_finish_var_decl): Generate warning when local
array moved to static storage.
From-SVN: r274264
Iain Buclaw [Sun, 11 Aug 2019 06:53:14 +0000 (06:53 +0000)]
d: Fix ICE: gimplification failed (gimplify.c at 13436)
The expression that caused the ICE
++(a += 1.0);
The D front-end rewrites and applies implicit type conversions so the
expression gets simplified as
(int)((double) a += 1.0) += 1
The codegen pass would subsequently generate the following invalid code
(int)(double) a = (int)((double) a + 1.0) + 1
The LHS expression `(int)(double) a', represented as a FIX_TRUNC_EXPR
being what trips as it is not a valid lvalue for assignment.
While LHS casts are stripped away, convert_expr adds a double cast
because it converts the expression to its original type before
converting it to its target type. There is no valid reason why this is
done, so it has been removed.
gcc/d/ChangeLog:
PR d/90601
* d-convert.cc (convert_expr): Don't convert an expression to its
original front-end type before converting to its target type.
gcc/testsuite/ChangeLog:
PR d/90601
* gdc.dg/pr90601.d: New test.
From-SVN: r274263
Hans-Peter Nilsson [Sun, 11 Aug 2019 01:40:39 +0000 (01:40 +0000)]
Correct a single misfire in previous ChangeLog cleanup.
From-SVN: r274262
GCC Administrator [Sun, 11 Aug 2019 00:16:25 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274261
Steven G. Kargl [Sat, 10 Aug 2019 18:26:13 +0000 (18:26 +0000)]
decl.c (match_old_style_init): Use a clearer error message.
2019-08-10 Steven G. Kargl <kargl@gcc.gnu.org>
* decl.c (match_old_style_init): Use a clearer error message.
* expr.c (gfc_check_assign): Update BOZ checking to provide a stricter
adherence to the Fortran standard. Use gfc_invalid_boz () to
relax errors into warnings.
* gfortran.h (gfc_isym_id): Add new ids GFC_ISYM_DFLOAT,
GFC_ISYM_FLOAT, GFC_ISYM_REALPART, and GFC_ISYM_SNGL
* intrinsic.c (add_functions): Use new ids to split REAL generic into
REAL, FLOAT, DFLOAT, SNGL, and REALPART generics.
(gfc_intrinsic_func_interface): Allow new intrinsics in an
initialization expression
* resolve.c (resolve_operator): Deal with BOZ as operands.
Use gfc_invalid_boz to allow for errors or warnings via the
-fallow-invalid-boz option. A BOZ cannot be an operand to an
unary operator. Both operands of a binary operator cannot be BOZ.
For binary operators, convert a BOZ operand into the type and
kind of the other operand for REAL or INTEGER operand.
* trans-intrinsic.c: Use new ids to cause conversions to happen.
2019-08-10 Steven G. Kargl <kargl@gcc.gnu.org>
* gfortran.dg/boz_8.f90: Adjust error messages.
* gfortran.dg/nan_4.f90: Ditto.
* gfortran.dg/boz_1.f90: Add -fallow-invalid-boz to dg-options,
and test for warnings.
* gfortran.dg/boz_3.f90: Ditto.
* gfortran.dg/boz_4.f90: Ditto.
* gfortran.dg/dec_structure_6.f90: Ditto.
* gfortran.dg/ibits.f90: Ditto.
From-SVN: r274257
Iain Buclaw [Sat, 10 Aug 2019 14:11:49 +0000 (14:11 +0000)]
d: Fix internal compiler error: in add_expr, at tree.c:7794
gcc/d/ChangeLog:
PR d/91238
* d-codegen.cc (build_address): If taking the address of a CALL_EXPR,
wrap it in a TARGET_EXPR.
gcc/testsuite/ChangeLog:
PR d/91238
* gdc.dg/pr91238.d: New test.
From-SVN: r274253
Jakub Jelinek [Sat, 10 Aug 2019 10:18:25 +0000 (12:18 +0200)]
tree-core.h (enum omp_clause_code): Add OMP_CLAUSE_DEVICE_TYPE.
* tree-core.h (enum omp_clause_code): Add OMP_CLAUSE_DEVICE_TYPE.
(enum omp_clause_device_type_kind): New enum.
(struct tree_omp_clause): Add subcode.device_type_kind.
* tree.h (OMP_CLAUSE_DEVICE_TYPE_KIND): Define.
* tree.c (omp_clause_num_ops, omp_clause_code_name): Add entries
for device_type clause.
(walk_tree_1): Handle OMP_CLAUSE_DEVICE_TYPE.
* tree-pretty-print.c (dump_omp_clause): Likewise.
c-family/
* c-pragma.h (enum pragma_omp_clause): Add
PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
c/
* c-parser.c (c_parser_omp_clause_name): Parse device_type.
(c_parser_omp_clause_device_type): New function.
(c_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(OMP_DECLARE_TARGET_CLAUSE_MASK): Add PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(c_parser_omp_declare_target): Handle device_type clauses. Remove
diagnostics for declare target with clauses nested in clause-less
declare target declaration-definition-seq.
* c-typeck.c (c_finish_omp_clauses): Handle OMP_CLAUSE_DEVICE_TYPE.
cp/
* parser.c (cp_parser_omp_clause_name): Parse device_type.
(cp_parser_omp_clause_device_type): New function.
(cp_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(OMP_DECLARE_TARGET_CLAUSE_MASK): Add PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(cp_parser_omp_declare_target): Handle device_type clauses. Remove
diagnostics for declare target with clauses nested in clause-less
declare target declaration-definition-seq.
* semantics.c (finish_omp_clauses): Handle OMP_CLAUSE_DEVICE_TYPE.
testsuite/
* c-c++-common/gomp/declare-target-2.c: Don't expect error for
declare target with clauses in between declare target without clauses
and end declare target.
* c-c++-common/gomp/declare-target-4.c: New test.
From-SVN: r274252
Jakub Jelinek [Sat, 10 Aug 2019 10:13:52 +0000 (12:13 +0200)]
re PR target/91408 (ICE in extract_insn, at recog.c:2310 since r273981)
PR target/91408
* config/i386/mmx.md (usadv8qi): Use register_operand instead of
vector_operand.
* gcc.target/i386/pr91408.c: New test.
From-SVN: r274251
Jakub Jelinek [Sat, 10 Aug 2019 09:59:17 +0000 (11:59 +0200)]
Assorted ChangeLog cleanups.
From-SVN: r274250
Iain Buclaw [Sat, 10 Aug 2019 05:25:44 +0000 (05:25 +0000)]
Fix ODR violation in d/runtime.cc
gcc/d/ChangeLog:
PR d/90893
* runtime.cc (enum libcall_type): Rename to...
(enum d_libcall_type): ...this.
(get_libcall_type): Use d_libcall_type.
(build_libcall_decl): Likewise.
From-SVN: r274249
GCC Administrator [Sat, 10 Aug 2019 00:16:23 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274248
Joseph Myers [Fri, 9 Aug 2019 22:02:08 +0000 (23:02 +0100)]
* zh_TW.po: Update.
From-SVN: r274243
Joseph Myers [Fri, 9 Aug 2019 22:00:35 +0000 (23:00 +0100)]
* uk.po: Update.
From-SVN: r274241
Vladimir Makarov [Fri, 9 Aug 2019 21:22:22 +0000 (21:22 +0000)]
reload1.c (finish_spills): Do not check ira_conflicts_p when handling spilled pseudos.
* reload1.c (finish_spills): Do not check ira_conflicts_p when
handling spilled pseudos.
From-SVN: r274240
Segher Boessenkool [Fri, 9 Aug 2019 17:33:25 +0000 (19:33 +0200)]
rs6000: vec-rotate-*.c fixes
This fixes two minor problems with the new testcases. The first is
that almost all other tests, including all vec* tests, for powerpc use
names with dashes, not underscores. The more important one is the the
vec-rotate-1.c and vec-rotate-3.c tests need the -maltivec flag.
gcc/testsuite/
* gcc.target/powerpc/vec_rotate-1.c: Rename to ...
* gcc.target/powerpc/vec-rotate-1.c: ... this. Add -maltivec option.
* gcc.target/powerpc/vec_rotate-2.c: Rename to ...
* gcc.target/powerpc/vec-rotate-2.c: ... this.
* gcc.target/powerpc/vec_rotate-3.c: Rename to ...
* gcc.target/powerpc/vec-rotate-3.c: ... this. Add -maltivec option.
* gcc.target/powerpc/vec_rotate-4.c: Rename to ...
* gcc.target/powerpc/vec-rotate-4.c: ... this.
From-SVN: r274239
Richard Earnshaw [Fri, 9 Aug 2019 16:14:59 +0000 (16:14 +0000)]
[aarch64] PR target/91386 Use copy_rtx to avoid modifying original insns in peep2 pattern
PR target/91386 is a situation where a peephole2 pattern substitution
is discarded late because the selected instructions contain
frame-related notes that we cannot redistribute (because the pattern
has more than one insn in the output). Unfortunately, the original
insns were being modified during the generation, so after the undo we
are left with corrupt RTL.
We avoid this by ensuring that the modifications are always made on a
copy, so that the original insns are never changed.
PR target/91386
* config/aarch64/aarch64.c (aarch64_gen_adjusted_ldpstp): Use copy_rtx
to preserve the contents of the original insns.
From-SVN: r274238
Richard Earnshaw [Fri, 9 Aug 2019 15:33:18 +0000 (15:33 +0000)]
[arm] Recognize thumb2 16-bit variants of the add and compare instructions
The addsi3_compare_op[12] patterns currently only have constraints to
pick the 32-bit variants of the instructions. Although the assembler
may sometimes opportunistically match a 16-bit t2 instruction, there's
no real control over that within the compiler. Consequently we might
emit a 32-bit adds instruction with a 16-bit subs instruction would
serve equally well. We do, of course still have to be careful about
the small number of boundary cases by controlling the order quite
carefully.
This patch adds the constraints and templates to match the t2 16-bit
variants of these instructions. Now, for example, we can generate
subs r0, r0, #1 // 16-bit instruction
instead of
adds r0, r0, #1 // 32-bit instruction.
*confit/arm/arm.md (addsi3_compare_op1): Add 16-bit thumb-2 variants.
(addsi3_compare_op2): Likewise.
From-SVN: r274237
Sam Tebbs [Fri, 9 Aug 2019 14:11:54 +0000 (14:11 +0000)]
[PATCH][GCC][AARCH64] Add effective-target check to b key execution tests
gcc/testsuite
2019-08-09 Sam Tebbs<sam.tebbs@arm.com>
* lib/target-supports.exp
(check_effective_target_arm_v8_4a_bkey_directive): New proc.
* g++.target/aarch64/return_address_sign_b_exception.C,
return_address_sign_ab_exception.C: Add dg-require-effective-target
checks.
From-SVN: r274236
Martin Liska [Fri, 9 Aug 2019 12:06:30 +0000 (14:06 +0200)]
Strengthen alias_ptr_types_compatible_p in LTO mode.
2019-08-09 Martin Liska <mliska@suse.cz>
* alias.c (alias_ptr_types_compatible_p): Strengten
type comparison in LTO mode.
From-SVN: r274235
Richard Sandiford [Fri, 9 Aug 2019 09:37:55 +0000 (09:37 +0000)]
Reject tail calls that read from an escaped RESULT_DECL (PR90313)
In this PR we have two return paths from a function "map". The common
code sets <result> to the value returned by one path, while the other
path does:
<retval> = map (&<retval>, ...);
We treated this call as tail recursion, losing the copy semantics
on the value returned by the recursive call.
We'd correctly reject the same thing for variables:
local = map (&local, ...);
The problem is that RESULT_DECLs didn't get the same treatment.
2019-08-09 Richard Sandiford <richard.sandiford@arm.com>
gcc/
PR middle-end/90313
* tree-tailcall.c (find_tail_calls): Reject calls that might
read from an escaped RESULT_DECL.
gcc/testsuite/
PR middle-end/90313
* g++.dg/torture/pr90313.cc: New test.
From-SVN: r274234
Alexandre Oliva [Fri, 9 Aug 2019 09:20:58 +0000 (09:20 +0000)]
skip Cholesky decomposition in is>>n_mv_dist
normal_mv_distribution maintains the variance-covariance matrix param
in Cholesky-decomposed form. Existing param_type constructors, when
taking a full or lower-triangle varcov matrix, perform Cholesky
decomposition to convert it to the internal representation. This
internal representation is visible both in the varcov() result, and in
the streamed-out representation of a normal_mv_distribution object.
The problem is that when that representation is streamed back in, the
read-back decomposed varcov matrix is used as a lower-triangle
non-decomposed varcov matrix, and it undergoes Cholesky decomposition
again. So, each cycle of stream-out/stream-in changes the varcov
matrix to its "square root", instead of restoring the original
params.
This patch includes Corentin's changes that introduce verification in
testsuite/ext/random/normal_mv_distribution/operators/serialize.cc and
other similar tests that the object read back in compares equal to the
written-out object: the modified tests pass only if (u == v).
This patch also fixes the error exposed by his change, introducing an
alternate private constructor for param_type, used only by operator>>.
for libstdc++-v3/ChangeLog
* include/ext/random
(normal_mv_distribution::param_type::param_type): New private
ctor taking a decomposed varcov matrix, for use by...
(operator>>): ... this, befriended.
* include/ext/random.tcc (operator>>): Use it.
(normal_mv_distribution::param_type::_M_init_lower): Adjust
member function name in exception message.
for libstdc++-v3/ChangeLog
from Corentin Gay <gay@adacore.com>
* testsuite/ext/random/beta_distribution/operators/serialize.cc,
testsuite/ext/random/hypergeometric_distribution/operators/serialize.cc,
testsuite/ext/random/normal_mv_distribution/operators/serialize.cc,
testsuite/ext/random/triangular_distribution/operators/serialize.cc,
testsuite/ext/random/von_mises_distribution/operators/serialize.cc:
Add call to `VERIFY`.
From-SVN: r274233
Martin Liska [Fri, 9 Aug 2019 08:33:05 +0000 (10:33 +0200)]
Add -flto=auto option value.
2019-08-09 Martin Liska <mliska@suse.cz>
* doc/invoke.texi: Document the option value.
* lto-wrapper.c (run_gcc): Set auto_parallel
only with -flto=auto.
2019-08-09 Martin Liska <mliska@suse.cz>
* g++.dg/lto/devirt-19_0.C: Add -flto=auto.
From-SVN: r274232
Martin Liska [Fri, 9 Aug 2019 07:51:40 +0000 (09:51 +0200)]
Provide proper error message for -flto=abcd.
2019-08-09 Martin Liska <mliska@suse.cz>
* opts.c (common_handle_option): Error for an invalid argument
to -flto=.
2019-08-09 Martin Liska <mliska@suse.cz>
* gcc.dg/spellcheck-options-21.c: New test.
From-SVN: r274231
Martin Liska [Fri, 9 Aug 2019 07:50:12 +0000 (09:50 +0200)]
Implement -fopt-info support for IPA ICF.
2019-08-09 Martin Liska <mliska@suse.cz>
* ipa-icf.c (sem_function::merge): Define AUTO_DUMP_SCOPE and
use dump_printf to report optimization.
(sem_variable::merge): Likwise.
(sem_item_optimizer::merge_classes): Use dump_printf to report
ICF hits.
2019-08-09 Martin Liska <mliska@suse.cz>
* g++.dg/ipa/ipa-icf-2.C: Add -optimized to -fdump-ipa-icf.
* g++.dg/ipa/ipa-icf-3.C: Likewise.
* g++.dg/ipa/ipa-icf-4.C: Likewise.
* g++.dg/ipa/ipa-icf-6.C: Likewise.
* gcc.dg/ipa/ipa-icf-1.c: Likewise.
* gcc.dg/ipa/ipa-icf-10.c: Likewise.
* gcc.dg/ipa/ipa-icf-11.c: Likewise.
* gcc.dg/ipa/ipa-icf-12.c: Likewise.
* gcc.dg/ipa/ipa-icf-13.c: Likewise.
* gcc.dg/ipa/ipa-icf-16.c: Likewise.
* gcc.dg/ipa/ipa-icf-18.c: Likewise.
* gcc.dg/ipa/ipa-icf-2.c: Likewise.
* gcc.dg/ipa/ipa-icf-20.c: Likewise.
* gcc.dg/ipa/ipa-icf-21.c: Likewise.
* gcc.dg/ipa/ipa-icf-23.c: Likewise.
* gcc.dg/ipa/ipa-icf-25.c: Likewise.
* gcc.dg/ipa/ipa-icf-26.c: Likewise.
* gcc.dg/ipa/ipa-icf-27.c: Likewise.
* gcc.dg/ipa/ipa-icf-3.c: Likewise.
* gcc.dg/ipa/ipa-icf-35.c: Likewise.
* gcc.dg/ipa/ipa-icf-36.c: Likewise.
* gcc.dg/ipa/ipa-icf-37.c: Likewise.
* gcc.dg/ipa/ipa-icf-38.c: Likewise.
* gcc.dg/ipa/ipa-icf-39.c: Likewise.
* gcc.dg/ipa/ipa-icf-5.c: Likewise.
* gcc.dg/ipa/ipa-icf-7.c: Likewise.
* gcc.dg/ipa/ipa-icf-8.c: Likewise.
* gcc.dg/ipa/ipa-icf-merge-1.c: Likewise.
* gcc.dg/ipa/pr64307.c: Likewise.
* gcc.dg/ipa/pr90555.c: Likewise.
From-SVN: r274230
Martin Liska [Fri, 9 Aug 2019 07:47:35 +0000 (09:47 +0200)]
Port value profiling to -fopt-info infrastructure.
2019-08-09 Martin Liska <mliska@suse.cz>
* value-prof.c (gimple_divmod_fixed_value_transform):
Use dump_printf_loc.
(gimple_mod_pow2_value_transform): Likewise.
(gimple_mod_subtract_transform): Likewise.
(init_node_map): Likewise.
(gimple_ic_transform): Likewise.
(gimple_stringops_transform): Likewise.
2019-08-09 Martin Liska <mliska@suse.cz>
* g++.dg/tree-prof/indir-call-prof.C: Add -optimize
to -fdump-ipa-profile.
* g++.dg/tree-prof/morefunc.C: Likewise.
* g++.dg/tree-prof/reorder.C: Likewise.
* gcc.dg/tree-prof/ic-misattribution-1.c: Likewise.
* gcc.dg/tree-prof/indir-call-prof.c: Likewise.
* gcc.dg/tree-prof/stringop-1.c: Likewise.
* gcc.dg/tree-prof/stringop-2.c: Likewise.
* gcc.dg/tree-prof/val-prof-1.c: Likewise.
* gcc.dg/tree-prof/val-prof-2.c: Likewise.
* gcc.dg/tree-prof/val-prof-3.c: Likewise.
* gcc.dg/tree-prof/val-prof-4.c: Likewise.
* gcc.dg/tree-prof/val-prof-5.c: Likewise.
* gcc.dg/tree-prof/val-prof-7.c: Likewise.
From-SVN: r274229
Jakub Jelinek [Fri, 9 Aug 2019 07:24:51 +0000 (09:24 +0200)]
c-parser.c (check_no_duplicate_clause): Simplify using omp_find_clause.
c/
* c-parser.c (check_no_duplicate_clause): Simplify using
omp_find_clause.
(c_parser_omp_clause_if): Fix up printing of target {enter,exit} data
directive name modifiers.
(c_parser_omp_clause_proc_bind): Check for duplicate proc_bind clause.
cp/
* parser.c (check_no_duplicate_clause): Simplify using
omp_find_clause.
(cp_parser_omp_clause_if): Fix up printing of target {enter,exit} data
directive name modifiers.
testsuite/
* c-c++-common/gomp/if-4.c: New test.
* c-c++-common/gomp/clause-dups-1.c: New test.
From-SVN: r274227
Jakub Jelinek [Fri, 9 Aug 2019 07:23:03 +0000 (09:23 +0200)]
re PR c/91401 (schedule + dist_schedule clauses rejected on distribute parallel for)
PR c/91401
c/
* c-parser.c (c_parser_omp_clause_dist_schedule): Fix up typos in the
check_no_duplicate_clause call. Comment it out, instead emit a
warning for duplicate dist_schedule clauses.
cp/
* parser.c (cp_parser_omp_clause_dist_schedule): Comment out the
check_no_duplicate_clause call, instead emit a warning for duplicate
dist_schedule clauses.
testsuite/
* c-c++-common/gomp/pr91401-1.c: New test.
* c-c++-common/gomp/pr91401-2.c: New test.
From-SVN: r274226
Alexandre Oliva [Fri, 9 Aug 2019 03:48:53 +0000 (03:48 +0000)]
use rand instead of random
rand is in ISO C, whereas random is only in POSIX, so it makes sense
to use the more portable function everywhere instead of falling back
from one to the other on systems that miss the less portable one.
for gcc/testsuite/ChangeLog
* gcc.target/i386/sse2-mul-1.c: Use rand. Drop fallback.
* gcc.target/i386/sse4_1-blendps-2.c: Likewise.
* gcc.target/i386/sse4_1-blendps.c: Likewise.
* gcc.target/i386/xop-vshift-1.c: Likewise.
* gcc.target/powerpc/direct-move.h: Likewise.
From-SVN: r274225
GCC Administrator [Fri, 9 Aug 2019 00:16:23 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274224
Paolo Carlini [Thu, 8 Aug 2019 22:15:40 +0000 (22:15 +0000)]
decl.c (grokdeclarator): Use id_loc and EXPR_LOCATION in a few error messages.
/cp
2019-08-08 Paolo Carlini <paolo.carlini@oracle.com>
* decl.c (grokdeclarator): Use id_loc and EXPR_LOCATION in
a few error messages.
/testsuite
2019-08-08 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/cpp0x/enum20.C: Test location(s) too.
* g++.dg/other/friend3.C: Likewise.
* g++.dg/parse/dtor5.C: Likewise.
* g++.dg/parse/friend7.C: Likewise.
* g++.dg/template/error22.C: Likewise.
* g++.old-deja/g++.brendan/err-msg5.C: Likewise.
From-SVN: r274220
Mihailo Stojanovic [Thu, 8 Aug 2019 21:06:17 +0000 (21:06 +0000)]
* doc/extend.texi: Add const qualifier to ld intrinsics.
From-SVN: r274219
Segher Boessenkool [Thu, 8 Aug 2019 20:18:56 +0000 (22:18 +0200)]
rs6000: Rename DFP iterator and attr to DDTD and q
This is more in line with the other iterators we have, and a bit easier
to read and write.
* config/rs6000/dfp.md (D64_D128): Rename to ...
(DDTD): ... this, throughout.
(dfp_suffix): Rename to ...
(q): ... this, throughout.
From-SVN: r274218
Segher Boessenkool [Thu, 8 Aug 2019 20:16:53 +0000 (22:16 +0200)]
rs6000: Use iterators in more DFP patterns
I noticed some patterns in dfp.md could use the D64_D128 iterator but
don't yet. This converts all remaining simple cases.
* config/rs6000/dfp.md (D64_D128): Move earlier in the file.
(dfp_suffix): Ditto.
(adddd3, addtd3): Merge to ...
(add<mode>3 for D64_D128): ... this.
(subdd3, subtd3): Merge to ...
(sub<mode>3 for D64_D128): ... this.
(muldd3, multd3): Merge to ...
(mul<mode>3 for D64_D128): ... this.
(divdd3, divtd3): Merge to ...
(div<mode>3 for D64_D128): ... this.
(*cmpdd_internal1, *cmptd_internal1): Merge to ...
(*cmp<mode>_internal1 for D64_D128): ... this.
(ftruncdd2, ftrunctd2): Merge to ...
(ftrunc<mode>2 for D64_D128): ... this.
(fixdddi2, fixtddi2): Merge to ...
(fix<mode>di2 for D64_D128): ... this.
From-SVN: r274217
Jim Wilson [Thu, 8 Aug 2019 19:04:56 +0000 (19:04 +0000)]
RISC-V: Fix C ABI for flattened struct with 0-length bitfield.
gcc/
PR target/91229
* config/riscv/riscv.c (riscv_flatten_aggregate_field): New arg
ignore_zero_width_bit_field_p. Skip zero size bitfields when true.
Pass into recursive call.
(riscv_flatten_aggregate_argument): New arg. Pass to
riscv_flatten_aggregate_field.
(riscv_pass_aggregate_in_fpr_pair_p): New local warned. Call
riscv_flatten_aggregate_argument twice, with false and true as last
arg. Process result twice. Compare results and warn if different.
(riscv_pass_aggregate_in_fpr_and_gpr_p): Likewise.
gcc/testsuite/
* gcc.target/riscv/flattened-struct-abi-1.c: New test.
* gcc.target/riscv/flattened-struct-abi-2.c: New test.
From-SVN: r274215
Marek Polacek [Thu, 8 Aug 2019 17:54:58 +0000 (17:54 +0000)]
re PR c++/79520 (Spurious caching for constexpr arguments)
PR c++/79520
* g++.dg/cpp1y/constexpr-79520.C: New test.
From-SVN: r274214
Richard Sandiford [Thu, 8 Aug 2019 17:12:05 +0000 (17:12 +0000)]
[C] Fix bogus nested enum error message
For:
enum a { A };
enum a { B };
we emit a bogus error about nested definitions before the real error:
foo.c:2:6: error: nested redefinition of ‘enum a’
2 | enum a { B };
| ^
foo.c:2:6: error: redeclaration of ‘enum a’
foo.c:1:6: note: originally defined here
1 | enum a { A };
| ^
This is because we weren't clearing C_TYPE_BEING_DEFINED once the
definition was over.
I think it's OK to clear C_TYPE_BEING_DEFINED even for a definition
that actually is nested (and so whose outer definition is still open),
since we'll already have given an error by then. It means that second
and subsequent attempts to define a nested enum will usually get the
redeclaration error instead of the nested error, but that seems just
as accurate (nested_first and nested_second in the test). The only
exception is if the first nested enum was also invalid by being empty,
but then the enum as a whole has already produced two errors
(nested_empty in the test).
2019-08-08 Richard Sandiford <richard.sandiford@arm.com>
gcc/c/
* c-decl.c (finish_enum): Clear C_TYPE_BEING_DEFINED.
gcc/testsuite/
* gcc.dg/pr79983.c (enum E): Don't allow an error about nested
definitions.
* gcc.dg/enum-redef-1.c: New test.
From-SVN: r274213
Marek Polacek [Thu, 8 Aug 2019 15:37:46 +0000 (15:37 +0000)]
PR c++/87519 - bogus warning with -Wsign-conversion.
* typeck.c (cp_build_binary_op): Use same_type_p instead of comparing
the types directly.
* g++.dg/warn/Wsign-conversion-5.C: New test.
From-SVN: r274211
Marek Polacek [Thu, 8 Aug 2019 14:55:52 +0000 (14:55 +0000)]
constexpr.c (inline_asm_in_constexpr_error): New.
* constexpr.c (inline_asm_in_constexpr_error): New.
(cxx_eval_constant_expression) <case ASM_EXPR>: Call it.
(potential_constant_expression_1) <case ASM_EXPR>: Likewise.
* g++.dg/cpp2a/inline-asm3.C: New test.
From-SVN: r274210
Jonathan Wakely [Thu, 8 Aug 2019 10:18:53 +0000 (11:18 +0100)]
P0325R4 to_array from LFTS with updates
As an extension to what the standard requires, this also adds
conditional noexcept-specifiers to the std::to_array functions.
P0325R4 to_array from LFTS with updates
* include/experimental/array (to_array): Qualify call to __to_array.
* include/std/array (__cpp_lib_to_array, to_array): Define for C++20.
* include/std/version (__cpp_lib_to_array): Likewise.
* testsuite/23_containers/array/creation/1.cc: New test.
* testsuite/23_containers/array/creation/2.cc: New test.
* testsuite/23_containers/array/creation/3_neg.cc: New test.
* testsuite/23_containers/array/tuple_interface/tuple_element_neg.cc:
Use zero for dg-error line number.
From-SVN: r274209
Martin Liska [Thu, 8 Aug 2019 07:50:28 +0000 (09:50 +0200)]
Fix file descriptor existence of MinGW.
2019-08-08 Martin Liska <mliska@suse.cz>
PR bootstrap/91352
* gcc.c (driver::detect_jobserver): Use is_valid_fd.
* lto-wrapper.c (jobserver_active_p): Likewise.
2019-08-08 Martin Liska <mliska@suse.cz>
PR bootstrap/91352
* libiberty.h (is_valid_fd): New function.
2019-08-08 Martin Liska <mliska@suse.cz>
PR bootstrap/91352
* lrealpath.c (is_valid_fd): New function.
From-SVN: r274208
Martin Liska [Thu, 8 Aug 2019 07:43:11 +0000 (09:43 +0200)]
When cloning set operator new/delete to false.
2019-08-08 Martin Liska <mliska@suse.cz>
* cgraphclones.c (set_new_clone_decl_and_node_flags): Drop
IS_OPERATOR_NEW and IS_OPERATOR_DELETE.
(create_version_clone_with_body): Likewise.
From-SVN: r274207
Jakub Jelinek [Thu, 8 Aug 2019 06:39:02 +0000 (08:39 +0200)]
gimplify.c (omp_add_variable): Use GOVD_PRIVATE | GOVD_EXPLICIT for VLA helper variables on target data even if...
* gimplify.c (omp_add_variable): Use GOVD_PRIVATE | GOVD_EXPLICIT
for VLA helper variables on target data even if not GOVD_FIRSTPRIVATE.
(gimplify_scan_omp_clauses): For OMP_CLAUSE_USE_DEVICE_* use just
GOVD_EXPLICIT flags.
(gimplify_omp_workshare): For OMP_TARGET_DATA move all
OMP_CLAUSE_USE_DEVICE_* clauses to the end of clauses chain.
* omp-low.c (scan_sharing_clauses): For OMP_CLAUSE_USE_DEVICE_*
call install_var_field with mask 11 instead of 3.
(lower_omp_target): For OMP_CLAUSE_USE_DEVICE_* use pass
(splay_tree_key) &DECL_UID (var) to build_sender_ref instead of var.
gcc/c/
* c-typeck.c (c_finish_omp_clauses): For C_ORT_OMP
OMP_CLAUSE_USE_DEVICE_* clauses use oacc_reduction_head bitmap
instead of generic_head to track duplicates.
gcc/cp/
* semantics.c (finish_omp_clauses): For C_ORT_OMP
OMP_CLAUSE_USE_DEVICE_* clauses use oacc_reduction_head bitmap
instead of generic_head to track duplicates.
libgomp/
* target.c (gomp_map_vars_internal): For GOMP_MAP_USE_DEVICE_PTR
perform the lookup in the first loop only if !not_found_cnt, otherwise
perform lookups for it in the second loop guarded with
if (not_found_cnt || has_firstprivate).
* testsuite/libgomp.c/target-37.c: New test.
* testsuite/libgomp.c++/target-22.C: New test.
From-SVN: r274206
GCC Administrator [Thu, 8 Aug 2019 00:16:29 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274205
Steven G. Kargl [Wed, 7 Aug 2019 22:33:27 +0000 (22:33 +0000)]
re PR fortran/91359 (logical function X returns .TRUE. - Warning: spaghetti code)
2019-08-07 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/91359
* pr91359_2.f: Fix missing hyphen in dg-do
* pr91359_1.f: Ditto. Remove RESULT variable to test actual fix!
From-SVN: r274201
Marek Polacek [Wed, 7 Aug 2019 21:21:57 +0000 (21:21 +0000)]
re PR c++/67533 (internal compiler error: in build_call_a, at cp/call.c:372)
PR c++/67533
* g++.dg/tls/thread_local-ice5.C: New test.
From-SVN: r274200
Richard Sandiford [Wed, 7 Aug 2019 19:15:58 +0000 (19:15 +0000)]
[AArch64] Fix INSR for zero floats
We used INSR to handle zero integers but not zero floats.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/constraints.md (Z): Handle floating-point zeros too.
* config/aarch64/predicates.md (aarch64_reg_or_zero): Likewise.
gcc/testsuite/
* gcc.target/aarch64/sve/init_13.c: New test.
From-SVN: r274193
Richard Sandiford [Wed, 7 Aug 2019 19:12:15 +0000 (19:12 +0000)]
[AArch64] Prefer FPRs over GPRs for INSR
INSR of GPRs involves a cross-file move while INSR of FPRs doesn't.
We should therefore disparage the GPR version relative to the FPR
version.
The patch also adds MOVPRFX handling, but this is only tested
properly by the ACLE.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64-sve.md (vec_shl_insert_<mode>): Add
MOVPRFX alternatives. Make the GPR alternatives more expensive
than the FPR ones.
gcc/testsuite/
* gcc.target/aarch64/sve/init_12.c: Expect w1 to be moved into
a temporary FPR.
From-SVN: r274192
Richard Sandiford [Wed, 7 Aug 2019 19:08:55 +0000 (19:08 +0000)]
[AArch64] Prefer FPRs over GPRs for CLASTB
This patch makes the SVE CLASTB GPR alternative more expensive than the
FPR alternative in order to avoid unnecessary cross-file moves. It also
fixes the prefix used to print the FPR; <vw> only handles 32-bit and
64-bit elements.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64-sve.md (fold_extract_last_<mode>):
Disparage the GPR alternative relative to the FPR one.
Fix handling of 8-bit and 16-bit FPR values.
gcc/testsuite/
* gcc.target/aarch64/sve/clastb_8.c: New test.
From-SVN: r274191
Richard Sandiford [Wed, 7 Aug 2019 19:05:42 +0000 (19:05 +0000)]
[AArch64] Merge SVE reduction patterns
The reorg showed that we had an unnecessary separation between
the bitwise and max/min reductions for integers, and the
addition and max/min reductions for fp.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/iterators.md (BITWISEV): Delete.
(SVE_INT_REDUCTION, SVE_FP_REDUCTION): New int iterators.
(optab): Handle UNSPEC_UMAXV, UNSPEC_UMINV, UNSPEC_SMAXV,
UNSPEC_SMINV, UNSPEC_FADDV, UNSPEC_FMAXNMV, UNSPEC_FMAXV,
UNSPEC_FMINNMV, UNSPEC_FMINV.
(bit_reduc_op): Delete.
(sve_int_op): New int attribute.
(sve_fp_op): Handle UNSPEC_FADDV, UNSPEC_FMAXNMV, UNSPEC_FMAXV,
UNSPEC_FMINNMV, UNSPEC_FMINV.
* config/aarch64/aarch64-sve.md
(reduc_<MAXMINV:maxmin_uns>_scal_<SVE_I:mode>)
(*reduc_<MAXMINV:maxmin_uns>_scal_<SVE_I:mode>)
(reduc_<BITWISEV:optab>_scal_<SVE_I:mode>)
(*reduc_<BITWISEV:optab>_scal_<SVE_I:mode>): Merge into...
(reduc_<SVE_INT_REDUCTION:optab>_scal_<SVE_I:mode>)
(*reduc_<SVE_INT_REDUCTION:optab>_scal_<SVE_I:mode>): ...these
new patterns.
(reduc_plus_scal_<SVE_F:mode>, *reduc_plus_scal_<SVE_I:mode>)
(reduc_<FMAXMINV:optab>_scal_<SVE_F:mode>)
(*reduc_<FMAXMINV:optab>_scal_<SVE_F:mode>): Merge into...
(reduc_<SVE_FP_REDUCTION:optab>_scal_<SVE_F:mode>)
(*reduc_<SVE_FP_REDUCTION:optab>_scal_<SVE_F:mode>): ...these
new patterns.
From-SVN: r274190
Richard Sandiford [Wed, 7 Aug 2019 19:01:37 +0000 (19:01 +0000)]
[AArch64] Merge SVE ternary FP operations
This patch combines the four individual fused multiply-add optabs
into one pattern and uses unspecs instead of rtx codes. This is
part of a series of patches that change the SVE FP patterns so that
they can describe cases in which the predicate isn't all-true.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64-sve.md (fma<mode>4, *fma<mode>4)
(fnma<mode>4, *fnma<mode>4, fnms<mode>4, *fnms<mode>4)
(fms<mode>4, *fms<mode>4): Replace with...
(<SVE_COND_FP_TERNARY:optab><SVE_F:mode>4)
(*<SVE_COND_FP_TERNARY:optab><SVE_F:mode>4): ...these new patterns.
Use unspecs instead of rtx codes.
(cond_<optab><mode>, *cond_<optab><mode>_2, *cond_<optab><mode>_4)
(*cond_<optab><mode>_any): Add the predicate to SVE_COND_FP_TERNARY.
From-SVN: r274189
Richard Sandiford [Wed, 7 Aug 2019 18:56:48 +0000 (18:56 +0000)]
[AArch64] Merge SVE FMAXNM/FMINNM patterns
This patch makes us use the same define_insn for both the smax/smin
and fmax/fmin optabs. It also continues the process started by
the earlier FP unary patch of moving predicated FP patterns from
rtx codes to unspecs.
There's no need to handle the FMAX and FMIN instructions until
the ACLE patch, since we only use FMAXNM and FMINNM at present.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/iterators.md (SVE_COND_FP_MAXMIN_PUBLIC): New
int iterator.
(maxmin_uns_op): Handle UNSPEC_COND_FMAXNM and UNSPEC_COND_FMINNM.
* config/aarch64/aarch64-sve.md
(<FMAXMIN:su><FMAXMIN:maxmin><SVE_F:mode>3): Rename to...
(<SVE_COND_FP_MAXMIN_PUBLIC:optab><SVE_F:mode>3): ...this and
use a single unspec for the rhs.
(*<su><maxmin><mode>3): Delete.
(<maxmin_uns><SVE_F:mode>3): Use a single unspec for the rhs.
From-SVN: r274188
Richard Sandiford [Wed, 7 Aug 2019 18:51:40 +0000 (18:51 +0000)]
[AArch64] Merge SVE FP unary patterns
This patch merges the SVE FP rounding patterns with the other SVE
FP unary patterns.
At the moment, we only generate unary FP operations for full vectors,
so we can use (sqrt:VNx4SF ...) etc. in the rtl pattern. With the ACLE,
it's also possible to generate predicated operations on partial vectors
without specifying a value for inactive lanes. (sqrt:VNx4SF ...) would
then have different faulting behaviour from the instruction that the
pattern generates.
This patch therefore uses unspecs to represent the operations instead.
Later patches make this change for other patterns.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/iterators.md (UNSPEC_COND_FABS, UNSPEC_COND_FNEG)
(UNSPEC_COND_FRINTA, UNSPEC_COND_FRINTI, UNSPEC_COND_FRINTM)
(UNSPEC_COND_FRINTN, UNSPEC_COND_FRINTP, UNSPEC_COND_FRINTX)
(UNSPEC_COND_FRINTZ, UNSPEC_COND_FSQRT): New unspecs.
(optab, sve_fp_op): Handle them.
(SVE_FP_UNARY): Delete.
(optab): Remove sqrt entry.
(sve_fp_op): Remove neg, abs and sqrt entries.
(SVE_COND_FP_UNARY): New int iterator.
* config/aarch64/aarch64-sve.md (<frint_pattern><mode>2)
(*<frint_pattern><mode>2): Delete.
(<SVE_FP_UNARY:optab><SVE_F:mode>2): Replace with...
(<SVE_COND_FP_UNARY:optab><SVE_F:mode>2): ...this.
(*<SVE_FP_UNARY:optab><SVE_F:mode>2): Replace with...
(*<SVE_COND_FP_UNARY:optab><SVE_F:mode>2): ...this.
From-SVN: r274187
Richard Sandiford [Wed, 7 Aug 2019 18:47:26 +0000 (18:47 +0000)]
[AArch64] Remove redundant SVE FADDA pattern
*pred_fold_left_plus_<mode> could no longer match anything, since
UNSPEC_FADDA now takes three operands. Predicated FADDAs should
now go through mask_fold_left_plus_<mode> instead.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64-sve.md (*pred_fold_left_plus_<mode>): Delete.
From-SVN: r274186
Richard Sandiford [Wed, 7 Aug 2019 18:43:01 +0000 (18:43 +0000)]
[AArch64] Make SVE UNSPEC_COND_*s match the insn mnemonic
This patch makes the UNSPEC_COND* names match the instruction mnemonics,
rather than having the previous mixture in which some used instructions
while others used operator names.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/iterators.md (UNSPEC_COND_ADD): Rename to...
(UNSPEC_COND_FADD): ...this.
(UNSPEC_COND_SUB): Rename to...
(UNSPEC_COND_FSUB): ...this.
(UNSPEC_COND_MUL): Rename to...
(UNSPEC_COND_FMUL): ...this.
(UNSPEC_COND_DIV): Rename to...
(UNSPEC_COND_FDIV): ...this.
(UNSPEC_COND_MAX): Rename to...
(UNSPEC_COND_FMAXNM): ...this.
(UNSPEC_COND_MIN): Rename to...
(UNSPEC_COND_FMINNM): ...this.
(UNSPEC_COND_LT): Rename to...
(UNSPEC_COND_FCMLT): ...this.
(UNSPEC_COND_LE): Rename to...
(UNSPEC_COND_FCMLE): ...this.
(UNSPEC_COND_EQ): Rename to...
(UNSPEC_COND_FCMEQ): ...this.
(UNSPEC_COND_NE): Rename to...
(UNSPEC_COND_FCMNE): ...this.
(UNSPEC_COND_GE): Rename to...
(UNSPEC_COND_FCMGE): ...this.
(UNSPEC_COND_GT): Rename to...
(UNSPEC_COND_FCMGT): ...this.
(SVE_COND_FP_BINARY, SVE_COND_FP_CMP, optab, cmp_op, sve_fp_op)
(sve_fp_op_rev): Update accordingly.
* config/aarch64/aarch64.c (aarch64_unspec_cond_code): Likewise.
From-SVN: r274185
Richard Sandiford [Wed, 7 Aug 2019 18:37:21 +0000 (18:37 +0000)]
[AArch64] Reorganise aarch64-sve.md
aarch64-sve.md was getting a bit jumbled, with related operations
separated by unrelated operations. Also, many SVE instructions need
to have several patterns due to the various ways in which predication
can be used, and it was getting hard to tell which instructions had a
complete set of patterns.
This patch therefore tries to use an explicit grouping scheme.
Banner comments are usually frowned on, but md files have been
a traditional exception (e.g. when using Mike's template for
new targets).
The patch also lists the instructions implemented by each section,
so that it's possible to search the file by instruction mnemonic.
I wouldn't be surprised if I end up having to rip out the contents
section, but I found it useful for the month or so that that I've
been using it locally. The patch checks that the contents remain
up-to-date by running a checking script during an early stage of
the build.
No functional change intended.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64-sve.md: Reorganize contents and add
banner comments.
* config/aarch64/check-sve-md.awk: New file.
* config/aarch64/t-aarch64 (s-check-sve-md): New rule.
(insn-conditions.md): Depend on it.
From-SVN: r274184
Uros Bizjak [Wed, 7 Aug 2019 18:34:11 +0000 (20:34 +0200)]
re PR target/91385 (Zero-extended negation (*negsi2_1_zext) is not generated)
PR target/91385
* config/i386/sse.md (*negsi2_1_zext): Simplify insn pattern.
(*negsi2_cmpz_zext): Ditto.
testsuite/ChangeLog:
PR target/91385
* gcc.target/i386/pr91385.c: New test.
From-SVN: r274183
Richard Sandiford [Wed, 7 Aug 2019 18:32:21 +0000 (18:32 +0000)]
[AArch64] Remove unused commutative attribute
The commutative attribute was once used by the SVE conditional binary
expanders, but it's now dead code.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/iterators.md (commutative): Remove.
From-SVN: r274182
Marek Polacek [Wed, 7 Aug 2019 17:32:12 +0000 (17:32 +0000)]
PR c++/81429 - wrong parsing of constructor with C++11 attribute.
* parser.c (cp_parser_constructor_declarator_p): Handle the scenario
when a parameter declaration begins with [[attribute]].
* g++.dg/cpp0x/gen-attrs-68.C: New test.
* g++.dg/cpp0x/gen-attrs-69.C: New test.
From-SVN: r274181
Richard Earnshaw [Wed, 7 Aug 2019 16:15:35 +0000 (16:15 +0000)]
PR driver/91130 Use CL_DRIVER when handling of COLLECT_GCC_OPTIONS in lto-wrapper.c
Some options are handled differently by the main driver (gcc, g++,
etc) from the back-end compiler programs (cc1, cc1plus, etc) in that
in the driver they do not take an additional argument, while in the
compiler programs they do. The processing option option CL_DRIVER
controls this alternative interpretation of the options.
The environment variable COLLECT_GCC_OPTIONS is the list of options to
add to a compile if the compiler re-invokes itself at some point. As
such, the options are driver options, so CL_DRIVER should be used when
processing this list. Currently lto-wrapper is doing this
incorrectly.
PR driver/91130
* lto-wrapper.c (find_and_merge_options): Use CL_DRIVER when
processing COLLECT_GCC_OPTIONS.
(run_gcc): Likewise.
From-SVN: r274176
Marek Polacek [Wed, 7 Aug 2019 14:20:40 +0000 (14:20 +0000)]
PR c++/91346 - Implement P1668R1, allow unevaluated asm in constexpr.
* constexpr.c (cxx_eval_constant_expression): Handle ASM_EXPR.
(potential_constant_expression_1) <case ASM_EXPR>: Allow.
* cp-tree.h (finish_asm_stmt): Adjust.
* parser.c (cp_parser_asm_definition): Grab the locaion of "asm" and
use it. Change an error to a pedwarn. Allow asm in C++2a, warn
otherwise.
* pt.c (tsubst_expr): Pass a location down to finish_asm_stmt.
* semantics.c (finish_asm_stmt): New location_t parameter. Use it.
* g++.dg/cpp2a/inline-asm1.C: New test.
* g++.dg/cpp2a/inline-asm2.C: New test.
* g++.dg/cpp1y/constexpr-neg1.C: Adjust dg-error.
From-SVN: r274169
Bernd Edlinger [Wed, 7 Aug 2019 13:45:06 +0000 (13:45 +0000)]
re PR tree-optimization/91109 ([arm] gcc.c-torture/execute/
20040709-1.c fails since r273135)
2019-08-07 Bernd Edlinger <bernd.edlinger@hotmail.de>
PR tree-optimization/91109
* lra-remat.c (update_scratch_ops): Remove assignment of the
hard register.
From-SVN: r274163
Richard Sandiford [Wed, 7 Aug 2019 13:18:35 +0000 (13:18 +0000)]
Make IPA predicate::size a poly_int64
This patch changes the IPA predicate::size field from a HOST_WIDE_INT
to a poly_int64.
2019-08-07 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* data-streamer.h (streamer_write_poly_uint64): Declare.
(streamer_read_poly_uint64): Likewise.
* data-streamer-in.c (streamer_read_poly_uint64): New function.
* data-streamer-out.c (streamer_write_poly_uint64): Likewise.
* ipa-predicate.h (condition::size): Turn into a poly_int64.
(add_condition): Take a poly_int64 size.
* ipa-predicate.c (add_condition): Likewise.
* ipa-prop.h (ipa_load_from_parm_agg): Take a poly_int64 size pointer.
* ipa-prop.c (ipa_load_from_parm_agg): Likewise.
(ipcp_modif_dom_walker::before_dom_children): Update accordingly.
* ipa-fnsummary.c (evaluate_conditions_for_known_args): Handle
condition::size as a poly_int64.
(unmodified_parm_1): Take a poly_int64 size pointer.
(unmodified_parm): Likewise.
(unmodified_parm_or_parm_agg_item): Likewise.
(set_cond_stmt_execution_predicate): Update accordingly.
(set_switch_stmt_execution_predicate): Likewise.
(will_be_nonconstant_expr_predicate): Likewise.
(will_be_nonconstant_predicate): Likewise.
(inline_read_section): Stream condition::size as a poly_int.
(ipa_fn_summary_write): Likewise.
From-SVN: r274162
Martin Liska [Wed, 7 Aug 2019 12:45:57 +0000 (14:45 +0200)]
Replace int with boolean in predicate functions.
2019-08-07 Martin Liska <mliska@suse.cz>
* fold-const.c (twoval_comparison_p): Replace int
with bool as a return type.
(simple_operand_p): Likewise.
(operand_equal_p): Replace int with bool as a return type.
* fold-const.h (operand_equal_p): Likewise.
From-SVN: r274161
Janne Blomqvist [Wed, 7 Aug 2019 07:34:10 +0000 (10:34 +0300)]
PR 53796 Make inquire(file=, recl=) conform to F2018
In my original patch to fix PR 53796 I forgot to fix the behavior for
unconnected units when inquiring via filename. This patch fixes that.
Regtested on x86_64-pc-linux-gnu, committed as obvious.
libgfortran/ChangeLog:
2019-08-07 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/53796
* io/inquire.c (inquire_via_filename): Set recl to -1 for
unconnected units.
gcc/testsuite/ChangeLog:
2019-08-07 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/53796
* gfortran.dg/inquire_recl_f2018.f90: Test for unconnected unit
with inquire via filename.
From-SVN: r274160
Jakub Jelinek [Wed, 7 Aug 2019 07:27:10 +0000 (09:27 +0200)]
tree-core.h (enum omp_clause_code): Adjust OMP_CLAUSE_USE_DEVICE_PTR OpenMP description.
* tree-core.h (enum omp_clause_code): Adjust OMP_CLAUSE_USE_DEVICE_PTR
OpenMP description. Add OMP_CLAUSE_USE_DEVICE_ADDR clause.
* tree.c (omp_clause_num_ops, omp_clause_code_name): Add entries
for OMP_CLAUSE_USE_DEVICE_ADDR clause.
(walk_tree_1): Handle OMP_CLAUSE_USE_DEVICE_ADDR.
* tree-pretty-print.c (dump_omp_clause): Likewise.
* tree-nested.c (convert_nonlocal_omp_clauses,
convert_local_omp_clauses): Likewise.
* gimplify.c (gimplify_scan_omp_clauses, gimplify_adjust_omp_clauses):
Likewise.
* omp-low.c (scan_sharing_clauses, lower_omp_target): Likewise.
Treat OMP_CLAUSE_USE_DEVICE_ADDR like OMP_CLAUSE_USE_DEVICE_PTR
clause with array or reference to array types, no matter what type
except for reference it has.
gcc/c-family/
* c-pragma.h (enum pragma_omp_clause): Add
PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR. Set PRAGMA_OACC_CLAUSE_USE_DEVICE
equal to PRAGMA_OMP_CLAUSE_USE_DEVICE_PTR instead of being a separate
enumeration value.
gcc/c/
* c-parser.c (c_parser_omp_clause_name): Parse use_device_addr clause.
(c_parser_omp_clause_use_device_addr): New function.
(c_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR.
(OMP_TARGET_DATA_CLAUSE_MASK): Add PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR.
(c_parser_omp_target_data): Handle PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR
like PRAGMA_OMP_CLAUSE_USE_DEVICE_PTR, adjust diagnostics about no
map or use_device_* clauses.
* c-typeck.c (c_finish_omp_clauses): For OMP_CLAUSE_USE_DEVICE_PTR
in OpenMP, require pointer type rather than pointer or array type.
Handle OMP_CLAUSE_USE_DEVICE_ADDR.
gcc/cp/
* parser.c (cp_parser_omp_clause_name): Parse use_device_addr clause.
(cp_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR.
(OMP_TARGET_DATA_CLAUSE_MASK): Add PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR.
(cp_parser_omp_target_data): Handle PRAGMA_OMP_CLAUSE_USE_DEVICE_ADDR
like PRAGMA_OMP_CLAUSE_USE_DEVICE_PTR, adjust diagnostics about no
map or use_device_* clauses.
* semantics.c (finish_omp_clauses): For OMP_CLAUSE_USE_DEVICE_PTR
in OpenMP, require pointer or reference to pointer type rather than
pointer or array or reference to pointer or array type. Handle
OMP_CLAUSE_USE_DEVICE_ADDR.
* pt.c (tsubst_omp_clauses): Handle OMP_CLAUSE_USE_DEVICE_ADDR.
gcc/testsuite/
* c-c++-common/gomp/target-data-1.c (foo): Use use_device_addr clause
instead of use_device_ptr clause where required by OpenMP 5.0, add
further tests for both use_device_ptr and use_device_addr clauses.
libgomp/
* testsuite/libgomp.c/target-18.c (struct S): New type.
(foo): Use use_device_addr clause instead of use_device_ptr clause
where required by OpenMP 5.0, add further tests for both use_device_ptr
and use_device_addr clauses.
* testsuite/libgomp.c++/target-9.C (struct S): New type.
(foo): Use use_device_addr clause instead of use_device_ptr clause
where required by OpenMP 5.0, add further tests for both use_device_ptr
and use_device_addr clauses. Add t and u arguments.
(main): Adjust caller.
From-SVN: r274159
projects / platform / upstream / gcc.git / log