review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

robertphillips@google.com [Fri, 27 Sep 2013 17:05:59 +0000 (17:05 +0000)]

This CL effectively reverts:

r5997 Altered arcTo's canonical points to (usually) be convex (https://codereview.appspot.com/6709051/)
r9928 GM (and fix) for drawArc capping issue (https://codereview.chromium.org/18271003/)

Instead of pushing some of the on-curve points out to attain convexity, this patch pulls all the off curve points in.

R=reed@google.com

Review URL: https://codereview.chromium.org/24810002

git-svn-id: http://skia.googlecode.com/svn/trunk@11504 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Fri, 27 Sep 2013 15:08:53 +0000 (15:08 +0000)]

Adding gms for tileimagefilter and offsetimagefilter

BUG=skia:1684

Review URL: https://codereview.chromium.org/25068002

git-svn-id: http://skia.googlecode.com/svn/trunk@11501 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 27 Sep 2013 15:02:44 +0000 (15:02 +0000)]

Create HTTP-based GM results viewer.

For now, it only allows VIEWING results... next, it will allow the user to
rebaseline GM results via the web interface.

R=borenet@google.com

Review URL: https://codereview.chromium.org/24274003

git-svn-id: http://skia.googlecode.com/svn/trunk@11500 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Fri, 27 Sep 2013 15:00:22 +0000 (15:00 +0000)]

Rebaselining xfermodeimagefilter

Adding new baselines and removing the line in ignore-tests.txt

BUG=
R=bsalomon@google.com, epoger@google.com

Review URL: https://codereview.chromium.org/25062002

git-svn-id: http://skia.googlecode.com/svn/trunk@11499 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Fri, 27 Sep 2013 14:28:45 +0000 (14:28 +0000)]

Fix android_run_skia

If STATUS_FILENAME doesn't exist, exit 1.

R=djsollen@google.com, jvanverth@google.com

Review URL: https://codereview.chromium.org/24770002

git-svn-id: http://skia.googlecode.com/svn/trunk@11498 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Fri, 27 Sep 2013 13:39:14 +0000 (13:39 +0000)]

Fix asan build. Duh, don't return a stack address...

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/25026004

git-svn-id: http://skia.googlecode.com/svn/trunk@11497 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 27 Sep 2013 13:33:17 +0000 (13:33 +0000)]

Rebaseline hairline images & remove suppression

https://codereview.chromium.org/25045002/

git-svn-id: http://skia.googlecode.com/svn/trunk@11496 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 27 Sep 2013 12:27:27 +0000 (12:27 +0000)]

Compiler warning/error fix for Chromium

git-svn-id: http://skia.googlecode.com/svn/trunk@11494 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 27 Sep 2013 07:01:29 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11493 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 26 Sep 2013 22:58:20 +0000 (22:58 +0000)]

Whitespace change to trigger build.

git-svn-id: http://skia.googlecode.com/svn/trunk@11492 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 26 Sep 2013 21:49:46 +0000 (21:49 +0000)]

Fix a warning.

git-svn-id: http://skia.googlecode.com/svn/trunk@11489 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 26 Sep 2013 21:35:39 +0000 (21:35 +0000)]

Add a buffered SkStream class.

This is used by Android to buffer an input stream which may not
otherwise be able to rewind.

Add a test for the new class.

R=bungeman@google.com, mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23717055

git-svn-id: http://skia.googlecode.com/svn/trunk@11488 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 20:44:24 +0000 (20:44 +0000)]

gm: add a flag to force perspective usage in all gms

BUG=
R=reed@google.com, epoger@google.com, borenet@google.com

Author: edisonn@google.com

Review URL: https://chromiumcodereview.appspot.com/23587029

git-svn-id: http://skia.googlecode.com/svn/trunk@11487 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 26 Sep 2013 19:56:51 +0000 (19:56 +0000)]

move GrMalloc, GrFree, Gr_bzero to their sk equivalents

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23566022

git-svn-id: http://skia.googlecode.com/svn/trunk@11486 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 26 Sep 2013 19:28:27 +0000 (19:28 +0000)]

add counting to Globals, and refactor some for clarity

BUG=

Review URL: https://codereview.chromium.org/24447003

git-svn-id: http://skia.googlecode.com/svn/trunk@11484 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 19:23:03 +0000 (19:23 +0000)]

Remove uses of unnamed namespace in bench/ directory.

Skia prefers to use static over unnamed namespace.

BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24660003

git-svn-id: http://skia.googlecode.com/svn/trunk@11483 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 19:22:54 +0000 (19:22 +0000)]

Add SkDivMod with a special case for ARM.

BUG=skia:1663
R=djsollen@google.com, tomhudson@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/24159009

git-svn-id: http://skia.googlecode.com/svn/trunk@11482 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Thu, 26 Sep 2013 17:24:27 +0000 (17:24 +0000)]

Correcting expectations file

git-svn-id: http://skia.googlecode.com/svn/trunk@11479 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Thu, 26 Sep 2013 17:12:47 +0000 (17:12 +0000)]

Whitespaces

Ignore failing gms

git-svn-id: http://skia.googlecode.com/svn/trunk@11478 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Thu, 26 Sep 2013 17:03:38 +0000 (17:03 +0000)]

Added SkTileImageFilter to SkFlattenable::InitializeFlattenables()

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24764003

git-svn-id: http://skia.googlecode.com/svn/trunk@11477 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 16:09:28 +0000 (16:09 +0000)]

Moving 4 SkImageFilter derived classes from blink to skia

There were 4 classes in blink that derived from SkImageFilter :
- TileImageFilter -> SkTileImageFilter
- OffsetImageFilter -> SkOffsetImageFilter (already existed)
- FloodImageFilter -> SkFloodImageFilter
- CompositeImageFilter -> SkCompositeImageFilter

All functions were copied as is, without modification (except for warnings fixes), except for the offset filter, which was merged into the existing SkOffsetImageFilter class, as a special case when a crop rect is provided. Since the names won't clash with the names in blink, it should be easy to integrate them in blink later and fix issues, if needed.

BUG=
R=senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, reed@google.com, mtklein@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24157005

git-svn-id: http://skia.googlecode.com/svn/trunk@11475 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 15:28:40 +0000 (15:28 +0000)]

GrAtlas refactor: Replace GrMaskFormat usage in GrAtlas with GrPixelConfig.

This gets the font-specific GrMaskFormat out of GrAtlas and replaces it with
more generic configs, allowing GrAtlas to be used for other things.

R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/24751003

git-svn-id: http://skia.googlecode.com/svn/trunk@11474 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 15:25:23 +0000 (15:25 +0000)]

ARM Skia NEON patches - 24 - S32_D565_Blend_Dither slight speedup/bugfix

BlitRow565: S32_D565_Blend_Dither, slight speedup + bugfix

This patch adds a rewrite of S32_D565_Blend_Dither in intrinsics.
The newer version is faster (10-20% depending on the value of count)
and also supports ARGB as well as ABGR. It also adds the missing
assert at the beginning of the function.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22566002

git-svn-id: http://skia.googlecode.com/svn/trunk@11473 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 15:16:12 +0000 (15:16 +0000)]

We don't flatten or unflatten SkPaintOptionsAndroid. Reproduce and fix.

BUG=skia:1625
R=djsollen@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/24075010

git-svn-id: http://skia.googlecode.com/svn/trunk@11472 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 26 Sep 2013 14:49:02 +0000 (14:49 +0000)]

Ignore incosistent results of pdf-mac and pdf-poppler renderers, and remove a temp file checked in by mistake.

Review URL: https://codereview.chromium.org/24642003

git-svn-id: http://skia.googlecode.com/svn/trunk@11471 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Sep 2013 12:57:19 +0000 (12:57 +0000)]

First pass at font cache refactor: Create an atlas manager per texture

This changes the AtlasMgr from a singleton class to one that is
created per-texture. This is the first step in allowing us to create
Atlases of other types (e.g., combine small icons into one big texture).

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/24608002

git-svn-id: http://skia.googlecode.com/svn/trunk@11468 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 26 Sep 2013 12:18:23 +0000 (12:18 +0000)]

Move bound and isFinite into pathref

https://codereview.chromium.org/24350006/

git-svn-id: http://skia.googlecode.com/svn/trunk@11467 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 26 Sep 2013 12:05:32 +0000 (12:05 +0000)]

Add GM case for arc truncation error bug

https://codereview.chromium.org/23532082/

git-svn-id: http://skia.googlecode.com/svn/trunk@11466 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 26 Sep 2013 07:01:39 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11465 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 25 Sep 2013 22:39:22 +0000 (22:39 +0000)]

Add skia_tsan_build to match skia_asan_build and fix one example race.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/24644003

git-svn-id: http://skia.googlecode.com/svn/trunk@11464 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 25 Sep 2013 22:10:04 +0000 (22:10 +0000)]

Fix iOS build.

More SkStream -> SkStreamRewindable.

git-svn-id: http://skia.googlecode.com/svn/trunk@11463 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 25 Sep 2013 22:01:17 +0000 (22:01 +0000)]

Fix a warning.

git-svn-id: http://skia.googlecode.com/svn/trunk@11462 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 25 Sep 2013 21:42:12 +0000 (21:42 +0000)]

Bench baseline for mostly 0 image.

Add a baseline for decoding a mostly 0 image. This is in advance of
https://codereview.chromium.org/24269006/ which provides an option to
skip writing those 0s (as part of BUG=skia:1661). On my Nexus 4, the
benchmark does not slow down after that change.

As suggested in https://codereview.chromium.org/24269006/ add a
resourcePath flag to bench. Will require a change in buildbot in order
to actually use the flag.

Add an image used by the test.

Until https://codereview.chromium.org/24448002 is submitted,
the test will not actually be run by the bots (since it
won't know where to find the file).

BUG=skia:1661
R=djsollen@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/24440002

git-svn-id: http://skia.googlecode.com/svn/trunk@11461 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 25 Sep 2013 21:34:24 +0000 (21:34 +0000)]

Change SkImageDecoders to take an SkStreamRewindable.

Only affects factories, static functions that will use the factories,
and subset decoding, which all require rewinding. The decoders
themselves continue to take an SkStream. This is merely documentation
stating which functions will possibly rewind the passed in SkStream.

This is part of the general change to coordinate SkStreams with
Android's streams, which don't necessarily support rewinding in all
cases.

Update callers to use SkStreamRewindable.

BUG=skia:1572
R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23477009

git-svn-id: http://skia.googlecode.com/svn/trunk@11460 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 25 Sep 2013 21:27:31 +0000 (21:27 +0000)]

Print a better error message.

Use format_message to print the proper error message in JPEG decoder.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/24461002

git-svn-id: http://skia.googlecode.com/svn/trunk@11459 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 25 Sep 2013 21:17:41 +0000 (21:17 +0000)]

Use the default resync_to_restart in jpeg.

Our version requires rewinding the stream, which is not always
supported. Instead, depend on jpeg's default version.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/23464068

git-svn-id: http://skia.googlecode.com/svn/trunk@11458 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 25 Sep 2013 20:57:51 +0000 (20:57 +0000)]

Replace GR_*_BUILD by their SK_BUILD_FOR_* equivalents.

BUG=None
TEST=None, no functional changes.
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24253009

git-svn-id: http://skia.googlecode.com/svn/trunk@11457 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Wed, 25 Sep 2013 20:51:16 +0000 (20:51 +0000)]

Deletes bench_expectations.txt and change comments to refer to the new per-bot expectation files.
Review URL: https://codereview.chromium.org/23830009

git-svn-id: http://skia.googlecode.com/svn/trunk@11456 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 25 Sep 2013 18:21:39 +0000 (18:21 +0000)]

Refactor PathTest.cpp test_isNestedRects and test_isRect.

The existing implementations make it difficult to add new tests
and rely on non-local side effects.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24502004

git-svn-id: http://skia.googlecode.com/svn/trunk@11455 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Wed, 25 Sep 2013 01:01:30 +0000 (01:01 +0000)]

Whitespace change to trigger rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@11452 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Tue, 24 Sep 2013 20:08:47 +0000 (20:08 +0000)]

Use different unique identifier for a fallback family.

BUG=chromium:266412
R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/24288002

git-svn-id: http://skia.googlecode.com/svn/trunk@11451 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 24 Sep 2013 19:59:44 +0000 (19:59 +0000)]

remove obsolete USE_CACHE_HASH

BUG=

Review URL: https://codereview.chromium.org/23526082

git-svn-id: http://skia.googlecode.com/svn/trunk@11450 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Tue, 24 Sep 2013 17:51:26 +0000 (17:51 +0000)]

GalaxyNexus rebaselines for testimagefilters and imagefilterscropped. (I guess this bot was previously failing before generating GMs?)

TBR=bsalomon

Review URL: https://codereview.chromium.org/23531087

git-svn-id: http://skia.googlecode.com/svn/trunk@11449 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Tue, 24 Sep 2013 14:17:12 +0000 (14:17 +0000)]

rebase gradients[_*_perspective] tests on GN after test change.

R=epoger@google.com

Review URL: https://codereview.chromium.org/23531085

git-svn-id: http://skia.googlecode.com/svn/trunk@11445 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Mon, 23 Sep 2013 20:00:30 +0000 (20:00 +0000)]

Rebaseline gradient changes on GN due to test change.

R=epoger@google.com

Review URL: https://codereview.chromium.org/24161005

git-svn-id: http://skia.googlecode.com/svn/trunk@11441 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 23 Sep 2013 17:23:21 +0000 (17:23 +0000)]

Rebaselines -- some stragglers for morphology.

TBR=bungeman

Review URL: https://codereview.chromium.org/23688007

git-svn-id: http://skia.googlecode.com/svn/trunk@11440 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Mon, 23 Sep 2013 13:53:46 +0000 (13:53 +0000)]

Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@11438 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Mon, 23 Sep 2013 12:08:20 +0000 (12:08 +0000)]

Whitespace change to trigger rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@11430 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 22 Sep 2013 21:57:03 +0000 (21:57 +0000)]

Patch SkImage.h so Chrome will compile

git-svn-id: http://skia.googlecode.com/svn/trunk@11429 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 22 Sep 2013 21:01:28 +0000 (21:01 +0000)]

Remove SK_ENABLE_LEGACY_API_ALIASING from SkImage.h

git-svn-id: http://skia.googlecode.com/svn/trunk@11428 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 22 Sep 2013 20:18:07 +0000 (20:18 +0000)]

Revert r11423 (low hanging calloc fruit)

git-svn-id: http://skia.googlecode.com/svn/trunk@11427 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 21 Sep 2013 07:01:53 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11426 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 20 Sep 2013 20:24:55 +0000 (20:24 +0000)]

Moar rebaselines for testimagefilters and imagefilterscropped.

TBR=bungeman

Review URL: https://codereview.chromium.org/23749010

git-svn-id: http://skia.googlecode.com/svn/trunk@11425 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 20 Sep 2013 20:05:01 +0000 (20:05 +0000)]

use new globally scoped SkAlphaType

git-svn-id: http://skia.googlecode.com/svn/trunk@11424 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Fri, 20 Sep 2013 19:59:47 +0000 (19:59 +0000)]

low hanging calloc fruit

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/24267014

git-svn-id: http://skia.googlecode.com/svn/trunk@11423 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 20 Sep 2013 19:47:32 +0000 (19:47 +0000)]

add trailing quote on #error

git-svn-id: http://skia.googlecode.com/svn/trunk@11422 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 20 Sep 2013 19:33:52 +0000 (19:33 +0000)]

promote SkImage::AlphaType to SkAlphaType

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/24130009

git-svn-id: http://skia.googlecode.com/svn/trunk@11421 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 20 Sep 2013 18:58:30 +0000 (18:58 +0000)]

[PDF] clear() and drawPaint() where applying the initial transform twice.

BUG=b/10845219
R=edisonn@google.com, djsollen@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24130010

git-svn-id: http://skia.googlecode.com/svn/trunk@11420 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 20 Sep 2013 17:41:52 +0000 (17:41 +0000)]

Map Calibri to Carlito

Chrome OS will have Carlito as a metric-compatible replacement for Calibri.

This change has to be combined with a Chrome OS change to add
Calibri and configure fontconfig accordingly.

BUG=280557
TEST=With the CrOS change, a page using Calibri will use Carlito instead of the default fallback font (Arimo in case of English UI).
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23618061

git-svn-id: http://skia.googlecode.com/svn/trunk@11418 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 20 Sep 2013 17:25:31 +0000 (17:25 +0000)]

Fix slight hinting with GDI.

Sometimes GDI manages to return a different number of points for hinted
and non-hinted outlines. This change handles that case and falls back
to non-hinted. This does not re-enable slight hinting, so there should be
no observable difference in tests. There are still issues with 'D' in
some font/size combinations where 'flips' are used.

git-svn-id: http://skia.googlecode.com/svn/trunk@11417 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 20 Sep 2013 17:23:56 +0000 (17:23 +0000)]

ravaseline (pdf and gradients)

BUG=

Review URL: https://codereview.chromium.org/23677013

git-svn-id: http://skia.googlecode.com/svn/trunk@11416 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 20 Sep 2013 15:38:49 +0000 (15:38 +0000)]

ARM Skia NEON patches - 21 - new NEON S32_D565_Opaque

BlitRow565: NEON version of S32_D565_Opaque

Here's a new implementation of S32_D565_Opaque in NEON. It
improves dramatically the speed compared to S32A_D565_Opaque.

Here are the benchmark results (speedup vs. existing NEON):

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | +130%     | +139%      |
+-------+-----------+------------+
| 2     | +65,2%    | +51%       |
+-------+-----------+------------+
| 4     | -25,5%    | +10,2%     |
+-------+-----------+------------+
| 8     | +63,8%    | +32,1%     |
+-------+-----------+------------+
| 16    | +110%     | +49,2%     |
+-------+-----------+------------+
| 64    | +153%     | +123,5%    |
+-------+-----------+------------+
| 256   | +151%     | +144,7%    |
+-------+-----------+------------+
| 1024  | +272%     | +157,2%    |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/22351006

git-svn-id: http://skia.googlecode.com/svn/trunk@11415 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Fri, 20 Sep 2013 14:31:45 +0000 (14:31 +0000)]

Add sk_calloc. Remove SkMemory_stdlib, which seems unused.

I'm seeing basically no difference between malloc + bzero and calloc on my desktop, but on a Galaxy Nexus calloc is never slower, and significantly faster once the allocation size becomes large, both for allocation and for _reading_.

BUG=skia:1662
R=reed@google.com

Review URL: https://codereview.chromium.org/24251008

git-svn-id: http://skia.googlecode.com/svn/trunk@11414 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 20 Sep 2013 07:01:33 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11411 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 20 Sep 2013 01:57:40 +0000 (01:57 +0000)]

Yet more testimagefilters and imagefilterscropped rebaselines.

TBR=bungeman

Review URL: https://codereview.chromium.org/24244007

git-svn-id: http://skia.googlecode.com/svn/trunk@11410 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Sep 2013 22:11:38 +0000 (22:11 +0000)]

silence the error test to be a better citizen

BUG=
R=caryclark@google.com, bsalomon@google.com, tfarina@chromium.org, mtklein@google.com

Author: humper@google.com

Review URL: https://chromiumcodereview.appspot.com/23481012

git-svn-id: http://skia.googlecode.com/svn/trunk@11409 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Sep 2013 22:02:37 +0000 (22:02 +0000)]

Fix for SampleFilterFuzz compiler warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@11408 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 19 Sep 2013 21:25:48 +0000 (21:25 +0000)]

Revert ignore-failures changes from r11395, since the tests have been rebaselined.

TBR=epoger

Review URL: https://codereview.chromium.org/23440054

git-svn-id: http://skia.googlecode.com/svn/trunk@11407 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 19 Sep 2013 21:06:10 +0000 (21:06 +0000)]

More testimagefilters and imagefilterscropped rebaselines.

TBR=bungeman

Review URL: https://codereview.chromium.org/23503079

git-svn-id: http://skia.googlecode.com/svn/trunk@11406 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mtklein@google.com [Thu, 19 Sep 2013 20:56:46 +0000 (20:56 +0000)]

Add an even more convenient way to declare tests, with example.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23828008

git-svn-id: http://skia.googlecode.com/svn/trunk@11405 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 19 Sep 2013 20:52:37 +0000 (20:52 +0000)]

rebaseline done for gradient tests, stop ignoring the diffs

Review URL: https://codereview.chromium.org/24269009

git-svn-id: http://skia.googlecode.com/svn/trunk@11404 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 19 Sep 2013 20:52:04 +0000 (20:52 +0000)]

rebaseline gradients (change the size so it does not chop the drawing)

BUG=

Review URL: https://codereview.chromium.org/23803012

git-svn-id: http://skia.googlecode.com/svn/trunk@11403 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 19 Sep 2013 20:35:50 +0000 (20:35 +0000)]

rebaseline pdf expectations (part 2)

BUG=

Review URL: https://codereview.chromium.org/24072010

git-svn-id: http://skia.googlecode.com/svn/trunk@11402 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 19 Sep 2013 20:19:43 +0000 (20:19 +0000)]

New baselines for imagefilterscropped, testimagefilters GMs.

TBR=bungeman

Review URL: https://codereview.chromium.org/23855010

git-svn-id: http://skia.googlecode.com/svn/trunk@11401 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sugoi@google.com [Thu, 19 Sep 2013 19:51:27 +0000 (19:51 +0000)]

Fixed warnings as error

BUG=
R=edisonn@google.com, rmistry@google.com

Review URL: https://codereview.chromium.org/24246006

git-svn-id: http://skia.googlecode.com/svn/trunk@11398 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 19 Sep 2013 19:19:18 +0000 (19:19 +0000)]

rebaseline pdf expected results (caused by not writing a bad pdf object if the feature is NYI)

BUG=

Review URL: https://codereview.chromium.org/24144007

git-svn-id: http://skia.googlecode.com/svn/trunk@11397 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 19 Sep 2013 19:01:45 +0000 (19:01 +0000)]

Rebaseline tilemodes_npot on IMG devices

git-svn-id: http://skia.googlecode.com/svn/trunk@11396 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Sep 2013 18:40:49 +0000 (18:40 +0000)]

I'm investigating how to make the IPC transfer a bit more secure on the
skia side by adding some safety checks. This cl is about brainstorming
and proposing possible solutions for type checking at different stages.

BUG=
R=senorblanco@google.com, sugoi@google.com, scroggo@google.com, reed@android.com, senorblanco@chromium.org, mtklein@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22799007

git-svn-id: http://skia.googlecode.com/svn/trunk@11395 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 19 Sep 2013 18:22:30 +0000 (18:22 +0000)]

Add new entry point that supports fallback font selection based on language.

BUG= chromium:287995
R=reed@google.com, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/23819067

git-svn-id: http://skia.googlecode.com/svn/trunk@11394 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 19 Sep 2013 18:06:03 +0000 (18:06 +0000)]

expand alias fontname test

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/24198004

git-svn-id: http://skia.googlecode.com/svn/trunk@11393 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 19 Sep 2013 17:55:49 +0000 (17:55 +0000)]

make gradients gm view size larger, as it is choping from the pained canvas.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23851037

git-svn-id: http://skia.googlecode.com/svn/trunk@11392 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 19 Sep 2013 17:51:14 +0000 (17:51 +0000)]

Whitespace change to trigger buildbots

git-svn-id: http://skia.googlecode.com/svn/trunk@11391 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 19 Sep 2013 17:41:41 +0000 (17:41 +0000)]

Add expectations/gm/ignored-tests.txt to temporarily ignore failures
BUG=skia:1600
TBR=bsalomon
(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/23531070

git-svn-id: http://skia.googlecode.com/svn/trunk@11390 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 19 Sep 2013 17:36:47 +0000 (17:36 +0000)]

pdf: report NYI features, and fail gracefully when something is not supported in pdf.

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/23654036

git-svn-id: http://skia.googlecode.com/svn/trunk@11388 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 19 Sep 2013 17:26:47 +0000 (17:26 +0000)]

Implement crop rect support for the merge image filter.

Note: this will require rebaselining of the imagefilterscropped and testimagefilters GMs.

R=reed@google.com

Review URL: https://codereview.chromium.org/23600047

git-svn-id: http://skia.googlecode.com/svn/trunk@11387 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 19 Sep 2013 17:21:39 +0000 (17:21 +0000)]

One more try at fixing warnings

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/24276003

git-svn-id: http://skia.googlecode.com/svn/trunk@11386 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Sep 2013 16:36:43 +0000 (16:36 +0000)]

Reenable GrAAHairlinePathRenderer assert w/ fix

https://codereview.chromium.org/24269004/

git-svn-id: http://skia.googlecode.com/svn/trunk@11385 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 19 Sep 2013 16:32:49 +0000 (16:32 +0000)]

Type warning fix for: Add string art GM and sample.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/24258003

git-svn-id: http://skia.googlecode.com/svn/trunk@11384 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Thu, 19 Sep 2013 15:32:22 +0000 (15:32 +0000)]

Add string art GM and sample.

BUG=279014
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23609037

git-svn-id: http://skia.googlecode.com/svn/trunk@11383 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 19 Sep 2013 14:40:42 +0000 (14:40 +0000)]

fix build warning for unused function

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/24240008

git-svn-id: http://skia.googlecode.com/svn/trunk@11382 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 19 Sep 2013 14:29:12 +0000 (14:29 +0000)]

Remove 2 unused defines USE_CHROMIUM_SKIA and SK_BUILD_FOR_CHROMIUM

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23618057

git-svn-id: http://skia.googlecode.com/svn/trunk@11381 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 19 Sep 2013 12:55:26 +0000 (12:55 +0000)]

Disable broken test on Android

R=caryclark@google.com

Review URL: https://codereview.chromium.org/23484057

git-svn-id: http://skia.googlecode.com/svn/trunk@11380 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 19 Sep 2013 12:08:40 +0000 (12:08 +0000)]

Update Android's FontHost to return NULL if familyName does not match

R=scroggo@google.com, wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/23601041

git-svn-id: http://skia.googlecode.com/svn/trunk@11377 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Sep 2013 12:04:59 +0000 (12:04 +0000)]

Fourth round of GPU hairline rebaselines

https://codereview.chromium.org/23452046/

git-svn-id: http://skia.googlecode.com/svn/trunk@11376 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 19 Sep 2013 07:25:55 +0000 (07:25 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11375 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 19 Sep 2013 06:18:27 +0000 (06:18 +0000)]

gm: add --ignoreTests flag
BUG=skia:1600
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23526065

git-svn-id: http://skia.googlecode.com/svn/trunk@11374 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 19 Sep 2013 06:09:32 +0000 (06:09 +0000)]

revert temporary r11371
BUG=skia:1641

Review URL: https://codereview.chromium.org/24256003

git-svn-id: http://skia.googlecode.com/svn/trunk@11373 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 19 Sep 2013 06:04:26 +0000 (06:04 +0000)]

disable some poppler tests due to flakiness (see bug)
BUG=skia:1643
(SkipBuildbotRuns)

TBR=edisonn

Review URL: https://codereview.chromium.org/24258002

git-svn-id: http://skia.googlecode.com/svn/trunk@11372 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 19 Sep 2013 05:25:17 +0000 (05:25 +0000)]

gm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
BUG=skia:1641

Review URL: https://codereview.chromium.org/24153020

git-svn-id: http://skia.googlecode.com/svn/trunk@11371 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Sep 2013 02:20:46 +0000 (02:20 +0000)]

Third round of GPU hairline rebaselines

https://codereview.chromium.org/24240003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11370 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;