** See bug #61841.

2004-07-27  Not Zed  <NotZed@Ximian.com>

        ** See bug #61841.

        * providers/groupwise/camel-groupwise-provider.c: added junk settings.

Changed to be the same prototype as engine_queue().

2004-07-27  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-engine.c
(camel_imap4_engine_prequeue): Changed to be the same prototype as
engine_queue().
(engine_prequeue_folder_select): Updated.

* providers/imap4/camel-imap4-store.c (connect_to_server): Use
engine_prequeue() for STARTTLS in case we are reconnecting and
already have a command queue.
(imap4_try_authenticate): Use prequeue() here too.
(imap4_reconnect): Moved all the connect logic in here.
(imap4_connect): just lock and call reconnect().

do not set transport object for groupwise provider. We want user to use

2004-07-27  Sivaiah Nallagatla <snallagatla@novell.com>

       * providers/groupwise/camel-groupwise-provider.c
       (camel_provider_module_init) : do not set
       transport object for groupwise provider. We want user to
       use SMTP itself instead of "Novell Groupwise"

       Fixes #61454

Fixes #57651, #58637 and #58643
* backends/groupwise/e-cal-backend-groupwise-utils.c:
(e_gw_connection_send_appointment) : Append the container id to
the gwrecordid obtained via ITIP to match the representation
in the SOAP interface.
(e_gw_item_set_changes): Updates to 'completed' field in the Task
is not sticky in the server, when using the modifyRequest. Using a
separate completeRequest call to update the same.
* backends/groupwise/e-cal-backend-groupwise-utils.h: removed the
unused default_zone parameter from e_gw_connection_send_appointment.
* backends/groupwise/e-cal-backend-groupwise.c:
(get_deltas): return boolean values not the connection status as the
caller is not expected to handle it anyway.
(sanitize_component): renamed set_container_id function, so it
correctly depicts what it does.
(e_cal_backend_groupwise_create_object): Make a getItemsRequest to the
server to obtain the items while creating recurring events. The original
call returns only the item ids and the client requires the icalids too
to keep the cache valid.
(e_cal_backend_groupwise_modify_object) : Use the completeRequest method
to update task completion.
(receive_object) : The call to e_gw_connection_send_appointment updated
to reflect the change in its signature.
(e_cal_backend_groupwise_receive_objects): set the method on the subcomp
created before passing it over to receive_object.

Don't instantiate an engine here. Instead, take an engine as an argument

2004-07-26  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-store.c (connect_to_server): Don't
instantiate an engine here. Instead, take an engine as an argument
(it has a service pointer) and connect using that. Also, if
connect fails, don't unref the engine.
(connect_to_server_wrapper): Now also takes an engine argument
rather than a service argument.
(imap4_try_authenticate): Now also takes an engine argument.
(imap4_connect): Pass the engine to connect/auth functions rather
than the store.
(imap4_query_auth_types): Updated.
(imap4_disconnect): Don't unref the engine here.
(camel_imap4_store_init): Create the engine here.
(imap4_get_folder_info): Can't check engine == NULL to know to
connect (that was a broken check anyway).

* providers/imap4/camel-imap4-engine.c (camel_imap4_engine_new):
Now simply takes a service argument rather than a session and url.
(camel_imap4_engine_next_token): Set the state to DISCONNECTED.
(camel_imap4_engine_eat_line): Same.
(camel_imap4_engine_line): Same.
(camel_imap4_engine_literal): Same.

read the "use_ssl" property from ESource and form the uri accrodingly

2004-07-23  Sivaiah Nallagatla <snallagatla@novell.com>

       * backends/groupwise/e-book-backend-groupwise.c
       (e_book_backend_groupwise_load_source) : read the "use_ssl"
       property from ESource and form the uri accrodingly
       (e_book_backend_groupwise_authenticate_user) : when "use_ssl" is
       "when-posible", try with https first and then http if that fails.
       (e_book_backend_groupwise_init) (e_book_backend_groupwise_dispose) :
       initialize and free the newly added priv member use_ssl

Updated Norwegian Nynorsk translation.

2004-07-23  Åsmund Skjæveland  <aasmunds@fys.uio.no>

* nn.po: Updated Norwegian Nynorsk translation.

Fixes #60463 Added a timezone argument and used it to convert the freebusy

2004-07-23  Chenthill Palanisamy <pchenthill@novell.com>

        Fixes #60463
        * backends/groupwise/e-cal-backend-groupwise-utils.c:
        (e_gw_connection_get_freebusy_info):
        Added a timezone  argument and used it to convert the freebusy
        times to default timezone. (Have added the patch again since it was inadvertently removed from
        by some commit)

** See bug #61761.

2004-07-22  Not Zed  <NotZed@Ximian.com>

        ** See bug #61761.

        * providers/pop3/camel-pop3-engine.c (camel_pop3_engine_iterate):
        if we get an io error, move every current/active and queued
        command to the done queue and mark as failed.

Free result after parsing it. Fixes a leak.

2004-07-19  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap/camel-imap-store.c (get_subscribed_folders): Free
result after parsing it. Fixes a leak.

remove proto

2004-07-20  JP Rosevear  <jpr@novell.com>

* e-source-selector.h: remove proto

* e-source-selector.c (selection_func): don't force the item to be
checked
(cell_toggled_callback): allow the cell to be untoggled even if
its primary
(init): set the pixbuf renderable
(e_source_selector_set_toggle_selection): no longer necessary

+ file

only copy 5 chars after the F if we actually have "From ", otherwise we

2004-07-19  Not Zed  <NotZed@Ximian.com>

        * camel-mime-filter-canon.c (filter): only copy 5 chars after the
        F if we actually have "From ", otherwise we might have F.{,4}\n
        instead and break eol canonicalisation.  For #53355.

bump version, libtool numbers, soup requirement

2004-07-19  JP Rosevear  <jpr@novell.com>

* configure.in: bump version, libtool numbers, soup requirement

Really fixes #61052, #61466, #61160. Tested.

2004-07-19  Hans Petter Jansson  <hpj@ximian.com>

Really fixes #61052, #61466, #61160. Tested.

* libebook/e-book.c (e_book_op_remove): Don't lock the book's
mutex here, for symmetry with e_book_new_op ().
(do_add_contact): Lock book around op removal.
(do_commit_contact): Ditto.
(do_get_supported_fields): Ditto.
(do_get_supported_auth_methods): Ditto.
(do_authenticate_user): Ditto.
(do_get_contact): Ditto.
(do_get_contacts): Ditto.
(do_get_changes): Ditto.
(do_open): Ditto.
(do_remove): Ditto.
(emit_async_add_contact_response): Widen the scope of the
book's lock.
(emit_async_elist_response): Ditto.
(emit_async_get_contact_response): Ditto.
(emit_async_get_book_view_response): Ditto.
(emit_async_get_contacts_response): Ditto.
(emit_async_get_changes_response): Ditto.
(emit_async_generic_response): Ditto.
(emit_async_open_response): Ditto.
(e_book_response_add_contact): Lock book around op manipulation,
widen scope.
(e_book_response_get_supported_fields): Ditto.
(e_book_response_get_supported_auth_methods): Ditto.
(e_book_response_get_contact): Ditto.
(e_book_response_get_book_view): Ditto.
(e_book_response_get_contacts): Ditto.
(e_book_response_get_changes): Ditto.
(e_book_response_generic): Ditto.
(e_book_response_open): Ditto.
(e_book_response_remove): Ditto.

provided implementation, search in all fileds of all types of addresses

2004-07-19  Sivaiah Nallagatla <snallagatla@novell.com>

        * libedata-book/e-book-backend-sexp.c (compare_address) : provided
        implementation, search in all fileds of all types of addresses
        till a match occurs
        Fixes #58701

Added some debug stuff.

2004-07-16  Not Zed  <NotZed@Ximian.com>

        * camel-gpg-context.c: Added some debug stuff.

Fixes #58748

2004-07-15  JP Rosevear  <jpr@novell.com>

Fixes #58748

* backends/contacts/e-cal-backend-contacts.c (cdate_to_icaltime):
explicitly set is_utc and set zone to NULL
(create_component): use NULL instead of 0
(e_cal_backend_contacts_set_default_timezone): fix logic typo so
that the default zone is set correctly

Don't grab the connect_lock before calling refresh_info so that we avoid

2004-07-15  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap/camel-imap-folder.c (imap_transfer_online): Don't
grab the connect_lock before calling refresh_info so that we avoid
the deadlock in bug #61551.

disconnet the signal handler registered on source object for CHANGED

2004-07-16  Sivaiah Nallagatla <snallagatla@novell.com>

        * libedataserver/e-source-group.c (e_source_group_remove_source)
        (e_source_group_remove_source) : disconnet the signal
        handler registered on source object for CHANGED singal
        as we may not be interested in the changes in source once
        it is removed form the group

Fixes #57142

2004-07-15  Rodrigo Moya <rodrigo@novell.com>

Fixes #57142

* libecal/e-cal-component.c (ensure_alarm_properties_cb): add the
X-EVOLUTION-NEEDS-DESCRIPTION property to the alarms we create
with no description, and remove the property from the alarms with
a description already.

(e_cal_component_set_summary, set_alarm_description_cb): set the
description on the alarms when the summary changes and remove the
above property when we set a valid description.

[ fixes #61052 ]

2004-07-16  Chris Toshok  <toshok@ximian.com>

[ fixes #61052 ]

* libebook/e-book.c (e_book_op_remove): lock the book's mutex
around operations on the id_to_op hashtable, as is done in all
other e_book_* functions.
(emit_async_add_contact_response): lock the book's mutex around
operations on the pending_idle list.
(e_book_response_add_contact): same.
(emit_async_elist_response): same.
(e_book_response_get_supported_fields): same.
(e_book_response_get_supported_auth_methods): same.
(emit_async_get_contact_response): same.
(e_book_response_get_contact): same.
(emit_async_get_book_view_response): same.
(e_book_response_get_book_view): same.
(emit_async_get_contacts_response): same.
(e_book_response_get_contacts): same.
(emit_async_get_changes_response): same.
(e_book_response_get_changes): same.
(emit_async_generic_response): same.
(e_book_response_generic): same.
(emit_async_open_response): same.
(e_book_response_open): same.
(e_book_response_remove): same.

simplify this a bit, since we don't need to pass the writable state in a

2004-07-14  Chris Toshok  <toshok@ximian.com>

* libebook/e-book.c (e_book_idle_writable): simplify this a bit,
since we don't need to pass the writable state in a closure - we
can just get it from the book.  also wrap stuff up in a mutex
since we can get multiple report_writable calls from a backend.
(e_book_handle_response): make sure we only have 1 idle call at a
time going, and simplify the closure passing to be just the EBook.
same with the mutex juju.
(e_book_dispose): remove the writable idle callback if there is
one registered.

Fix for bug #61538

2004-07-14  Jeffrey Stedfast  <fejj@novell.com>

Fix for bug #61538

* camel-process.c (camel_process_fork): Same.

* camel-filter-driver.c (pipe_to_system): Fixed strings

fixed all the way

fixed changelog

Fixes #60344 Send the timezone present in tzid instead of sending UTC

2004-07-14  Chenthill Palanisamy <pchenthill@novell.com>

       Fixes #60344
       * backends/groupwise/e-cal-backend-groupwise.c:
       (e_cal_backend_groupwise_internal_get_timezone):
       Send the timezone present in tzid instead of sending UTC timezone.

only propagate the GError if @error != NULL. Fixes some console warnings.

2004-07-13  Chris Toshok  <toshok@ximian.com>

* libebook/e-book.c (e_book_get_self): only propagate the GError
if @error != NULL.  Fixes some console warnings.
(e_book_set_default_source): same.
(e_book_new_system_addressbook): same.
(e_book_new_default_addressbook): same.

[ fixes #58639 ]

2004-07-13  Chris Toshok  <toshok@ximian.com>

[ fixes #58639 ]

* libebook/e-book-listener.c (impl_BookListener_respond_get_view):
no need to wrap the g_signal_emit with dup_ref/release_unref.  the
construct for EBookView does a dup_ref of its own.

* libedata-book/e-data-book-view.c
(e_data_book_view_notify_update): don't call
e_data_book_view_notify_remove when the pending_mutex is already
called.  call notify_remove directly.

Access method for getting the XGWRECORDID property from the calendar

* backends/groupwise/e-cal-backend-groupwise-utils.c:
( e_cal_component_get_gw_id): Access method for getting the
XGWRECORDID property from the calendar component.
( set_properties_from_cal_component): Range of priority value
HIGH extended to include values 1 and 2.
The X-EVOLUTION-GROUPWISE-ID is now referred as XGWRECORDID
for consistency with the ITIP messages.
( e_gw_item_to_cal_component) : Absence of due_date does not
invalidate the task component. Fixes #60926.
( e_gw_connection_send_appointment),( e_gw_connection_create_appointment):
Implemented.
( e_gw_connection_get_freebusy_info):
( e_gw_item_set_changes): Fixed compiler warnings.

* backends/groupwise/e-cal-backend-groupwise-utils.h:
Declarations for added functions.
* backends/groupwise/e-cal-backend-groupwise.c:
( populate_cache) : Removed unused variables.
( set_container_id): Extracted a function out of the code as it is
used twice.
( e_cal_backend_groupwise_create_object): Handle changes in the SOAP interface.
The server now returns CVSa list of uids. This is to allow creation of recurring
calendar events.
( e_cal_backend_groupwise_modify_object): Fix some leaks.
( e_cal_backend_groupwise_remove_object), ( receive_object),
( send_object), ( e_cal_backend_groupwise_send_objects): Use the newly created
functions for handling group calendar items.
* e-gw-connection.c:
( e_gw_connection_new) : Fix for #59471 by getting around the server
defect. Substitute the first . by @.
( e_gw_connection_get_deltas): Fix for #56853. The server may indicate
that there are changes but not provide deltas if they are outside our
interest. This is now considered a valid response.
( e_gw_connection_send_item): Handle the change in the SOAP interface.
The sendItemResponse now returns a list of ids.
( e_gw_connection_accept_request), ( e_gw_connection_decline_request),
( e_gw_connection_retract_request), ( e_gw_connection_complete_request):
Implemented.
+
* e-gw-connection.h: Declaration for the added functions.
+
* e-gw-item.c:
( e_gw_item_new_from_soap_parameter): Add organizer only if the item
source is not 'personal'. Use 'priority' instead of Taskpriority for
Todos as recommended by the server team.
( e_gw_item_set_calendar_item_elements): Organize common properties
to Appointments and todo-s into a separate function.
( e_gw_item_append_to_soap_message),
( append_event_changes_to_soap_message),
( e_gw_item_append_changes_to_soap_message): reorder soap elements
in the sequence specified by the schema. The server does not enforce this
but doing it right anyway..

: pass "use_ssl" value to these functions and set it on e-source

2004-07-12 Sivaiah Nallagatla <snallagatla@novell.com>

        * providers/groupwise/camel-gw-listener.c : (add_esource)
        (modify_esource) (add_addressbook_source)
        (modify_addressbook_sources) : pass "use_ssl" value to these functions and
        set it on e-source
        (add_calendar_tasks_source) : read the "use_ssl" param
        from camel url and pass it to add_esource) calls
        (get_addressbook_names_from_server) : use "https" or http
        depending upon whther ssl is enabled or not
        (account_changed) : compare urls from account
        instead of uris formed to know wheter somehting in the account
        changed

** This is no guarantee of security, but its just a helper to prevent old

2004-07-09  Not Zed  <NotZed@Ximian.com>

        ** This is no guarantee of security, but its just a helper to
        prevent old memory accidentally being included/used elsewhere.

        * camel-smime-context.c (sm_decrypt): mark the output stream
        'secure'.

        * camel-gpg-context.c (gpg_decrypt): set the output stream to
        secured, so we automagically blank it out on finalise.

        * camel-stream-mem.c (camel_stream_mem_set_secure): set the
        memory-stream 'secured', all we do at the moment is blank out the
        buffer on finalise.
        (camel_stream_mem_set_byte_array, camel_stream_mem_finalize):
        clear memory if owner and secured.  kill dead comment.
        (clear_mem): utilitiy to set memory to 0xABADF00D

2004-07-08  Not Zed  <NotZed@Ximian.com>

        ** See bug #61186.

        * camel-cipher-context.c (camel_cipher_sign):
        (camel_cipher_verify, camel_cipher_encrypt, camel_cipher_decrypt):
        Add preliminary progress reporting.

[ part of fix for #56520 ]

2004-07-09  Chris Toshok  <toshok@ximian.com>

[ part of fix for #56520 ]

* backends/groupwise/e-book-backend-groupwise.c
(e_book_backend_groupwise_get_static_capabilities): add
"contact-lists".

* backends/vcf/e-book-backend-vcf.c
(e_book_backend_vcf_get_static_capabilities): add "contact-lists".

* backends/file/e-book-backend-file.c
(e_book_backend_file_get_static_capabilities): add
"contact-lists".

[ most likely fixes #57999 ]

2004-07-12  Chris Toshok  <toshok@ximian.com>

[ most likely fixes #57999 ]

* libdb/dist/aclocal/options.ac: set the default unique name to
"_eds".  this will append _eds to all externally visible libdb
symbols, so we can be sure it won't conflict with another libdb
(linked dynamically).

* libdb/dist/configure: regen after options.ac change.

* libdb/dist/.cvsignore: ignore db_int_def.h

12/7/04  aman <amanlinux@netscape.net>add file

read "use_ssl" property from the ESource and form the uri accordingly

2004-07-12  Sivaiah Nallagatla   <snallagatla@novell.com>

        * backends/groupwise/e-cal-backend-groupwise.c
        (form_uri) : read "use_ssl" property from the ESource
        and form the uri accordingly
        (connect_to_server) : when "use_ssl" is "when-possible"
        try with https first and then with http if that fails

Translation updated by Daniel van Eeden.

2004-07-10  Vincent van Adrighem  <adrighem@gnome.org>

* nl.po: Translation updated by Daniel van Eeden.

made this function public.

2004-07-07  Rodrigo Moya <rodrigo@novell.com>

* libedataserver/e-source.[ch] (e_source_build_absolute_uri): made
this function public.

Updated Korean translation

use CAMEL_GROUPWISE_CFLAGS. (libcamelgroupwise_la_LIBADD): use

2004-07-07  Chris Toshok  <toshok@ximian.com>

* providers/groupwise/Makefile.am (INCLUDES): use
CAMEL_GROUPWISE_CFLAGS.
(libcamelgroupwise_la_LIBADD): use CAMEL_GROUPWISE_LIBS.

bind to the right charset (i.e. utf8). See #58976.

2004-07-07  Not Zed  <NotZed@Ximian.com>

        * src/server.c (main): bind to the right charset (i.e. utf8).  See
        #58976.

Updated Albanian translation.

2004-07-05  Laurent Dhima  <laurenti@alblinux.net>

* sq.po: Updated Albanian translation.

bump version, libtool numbers

2004-07-02  JP Rosevear  <jpr@novell.com>

* configure.in: bump version, libtool numbers

Fixes #60463 Added a timezone argument and used it to convert the freebusy

Fixes #60463
* backends/groupwise/e-cal-backend-groupwise-utils.c:
(e_gw_connection_get_freebusy_info):
Added a timezone  argument and used it to convert the freebusy
times to default timezone.

fix the problem of returning from the fucntion without singalling the

2004-07-03  Sivaiah Nallagatla <snallagatla@novell.com>

        * backends/groupwise/e-book-backend-groupwise.c
        (book_view_thread) : fix the problem
        of returning from the fucntion without singalling the
        parent thread when cnc is null. A probable fix for #60947
        Also send the query to server when summary is not present
        (build_summary), (update_summary) : set priv->is_summary_ready
        to TRUE when summary loading is done

[ fixes #60691 ]

2004-07-02  Chris Toshok  <toshok@ximian.com>

[ fixes #60691 ]

* libedataserver/e-iterator.h: rename the "delete" member to
"remove", to fix c++ build.

* libedataserver/e-iterator.c (e_iterator_delete): same.
(e_iterator_class_init): same.

* libedataserver/e-list-iterator.c (e_list_iterator_class_init): same.
(e_list_iterator_remove): same.

s/Can't/Cannot/.

2004-07-02  Christian Neumair  <chris@gnome-de.org>

* camel-smime-context.c: s/Can't/Cannot/.

Set the size of the ptrarray to prevent potentially realloc'ing several

2004-06-30  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-search.c (imap4_body_contains): Set
the size of the ptrarray to prevent potentially realloc'ing
several times.

Aded a new %formatter 'V' which takes a string vector (needed for SEARCH).

2004-06-29  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-command.c
(camel_imap4_command_newv): Aded a new %formatter 'V' which takes
a string vector (needed for SEARCH).

* providers/imap4/camel-imap4-search.[c,h]: New source files
implementing search functionality.

* providers/imap4/camel-imap4-folder.c (imap4_sync_flag): Use the
new public version of imap4_get_uid_set().
(imap4_transfer_messages_to): Same.
(camel_imap4_folder_new): Create a search context.
(camel_imap4_folder_finalize): Unref the search context.
(camel_imap4_folder_class_init): Override the search methods.
(imap4_search_by_expression): New.
(imap4_search_by_uids): New.
(imap4_search_free): New.

* providers/imap4/camel-imap4-utils.c (camel_imap4_get_uid_set):
Moved here from camel-imap4-folder.c

add any parents of the new name before we actually do the rename so the

2004-06-29  Not Zed  <NotZed@Ximian.com>

        * camel-vee-store.c (vee_rename_folder): add any parents of the
        new name before we actually do the rename so the rename has
        somewhere to go to.  #60775.

Translation updated.

2004-06-28  Laurent Dhima  <laurenti@alblinux.net>

* sq.po: Translation updated.

Updated Norwegian translation.

2004-06-28  Kjartan Maraas  <kmaraas@gnome.org>

* no.po: Updated Norwegian translation.

override CAMEL_FOLDER_NAME arg so we can translate "." into "Inbox".

2004-06-28  Not Zed  <NotZed@Ximian.com>

        * providers/local/camel-maildir-folder.c (maildir_folder_getv):
        override CAMEL_FOLDER_NAME arg so we can translate "." into
        "Inbox".

take url argument directly, fixes a memleak. (camel_folder_info_new): make

2004-06-28  Not Zed  <NotZed@Ximian.com>

        * providers/local/camel-maildir-store.c (camel_folder_info_new):
        take url argument directly, fixes a memleak.
        (camel_folder_info_new): make the toplevel "." into "Inbox"
        always.
        (maildir_rename_folder): dont let users rename inbox.

More fixes.

2004-06-27  Jeffrey Stedfast  <fejj@novell.com>

* camel-url-scanner.c (camel_url_web_end): More fixes.

same. (remodel): same.

2004-06-25  Chris Toshok  <toshok@ximian.com>

        * gui/widgets/e-minicard.c (add_field): same.
        (remodel): same.

        * gui/widgets/e-addressbook-reflow-adapter.c (addressbook_height): same.

        * gui/widgets/eab-popup-control.c (email_table_init): same.
        (contact_picker_init): same.

        * gui/widgets/eab-gui-util.c (eab_contact_save): use
        e_contact_get_const here to plug a leak.
        (eab_contact_list_save): same.
        (eab_send_contact_list_as_attachment): same.

remove more debugging printfs

fixed an uninitialised memory read from my last fix

Updated Brazilian Portuguese translation done by Gustavo Maciel Dias

2004-06-25  Gustavo Maciel Dias Vieira <gustavo@sagui.org>

        * pt_BR.po: Updated Brazilian Portuguese translation done by
        Gustavo Maciel Dias Vieira <gustavo@sagui.org>.

Fixed to handle :pass in proto://user:pass@host. Fixes bug #60104.

2004-06-25  Jeffrey Stedfast  <fejj@novell.com>

* camel-url-scanner.c (camel_url_web_end): Fixed to handle :pass
in proto://user:pass@host. Fixes bug #60104.

See bug #51127.

2004-06-24  Hans Petter Jansson  <hpj@ximian.com>

See bug #51127.

* backends/vcf/e-book-backend-vcf.c (e_book_backend_vcf_load_source):
Don't add a default vcard to new books.

* backends/file/e-book-backend-file.c
(e_book_backend_file_load_source): Don't add default vcard to new
books.

Error out and set an exception if camel_pop3_engine_new() returns NULL

2004-06-24  Jeffrey Stedfast  <fejj@novell.com>

* providers/pop3/camel-pop3-store.c (connect_to_server): Error out
and set an exception if camel_pop3_engine_new() returns NULL
(which it can do now).

* providers/pop3/camel-pop3-engine.c (get_capabilities): No longer
reads the greeting.
(camel_pop3_engine_new): Reads the greeting itself and returns
NULL if an error occurs (like stupid braindamaged piece of shit
POP servers that spew debug prinfs).

If we fail to lock the folder, close the lockfd and reset it to -1. Fixes

2004-06-24  Jeffrey Stedfast  <fejj@novell.com>

* providers/local/camel-spool-folder.c (spool_lock): If we fail to
lock the folder, close the lockfd and reset it to -1. Fixes bug
#54680.

Add a call to e_source_selector_set_select_new here so that we can select

2004-06-24  Rodney Dawes  <dobey@novell.com>

* gui/calendar-component.c (create_component_view):
* gui/tasks-component.c (create_component_view):
Add a call to e_source_selector_set_select_new here so that we can
select new sources when we create them

2004-06-24  Rodney Dawes  <dobey@novell.com>

* e-source-selector.[ch]: Add new "select_new" property to
private structure of the ESourceSelector
(rebuild_cb): Add code to select the new source, and cause the
selection_changed signal to get emitted, if we select new sources
(init): Don't select new sources by default
(e_source_selector_set_select_new): Add function to set whether or not
we want to select new sources when we add them

First LIST/LSUB the toplevel folder, and then LIST/LSUB the subfolders (it

2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-store.c (imap4_get_folder_info):
First LIST/LSUB the toplevel folder, and then LIST/LSUB the
subfolders (it needs to be 2 commands to work properly).
(imap4_delete_folder): CLOSE the folder we are about to DELETE if
it is currently SELECTED.

Same.

2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap/camel-imap-provider.c (imap_url_equal): Same.

* providers/imap4/camel-imap4-provider.c (imap4_url_equal): Check
the protocol.

ref in the assignment. (e_book_response_get_supported_fields): same.

2004-06-23  Chris Toshok  <toshok@ximian.com>

* libebook/e-book.c (e_book_response_add_contact): ref in the
assignment.
(e_book_response_get_supported_fields): same.
(e_book_response_get_supported_auth_methods): same.
(emit_async_get_contact_response): unref the book before
returning.
(e_book_response_get_contact): ref the book in the assignment.
(emit_async_get_book_view_response): unref the book before
returning.
(e_book_response_get_book_view): ref the book in the assignment.
(e_book_response_get_contacts): same.
(emit_async_get_changes_response): unref the book before
returning.
(e_book_response_get_changes): ref the book in the assignment.
(emit_async_generic_response): we ref before registering the idle
handler.
(e_book_response_generic): ref the book in the assignment.
(emit_async_open_response): unref the book before returning
(e_book_response_open): ref the book in the assignment.
(e_book_response_remove): same.

Register a segv handler to popup bug-buddy or whatever. Fixes bug #51165.

2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

* src/server.c (main): Register a segv handler to popup bug-buddy
or whatever. Fixes bug #51165.

Keep a ref on the book while we're accessing it, since the callback might

2004-06-23  Hans Petter Jansson  <hpj@ximan.com>

* libebook/e-book.c (emit_async_generic_response): Keep a ref on
the book while we're accessing it, since the callback might unref
it to zero, causing a crash.

Hide password, etc info in the fi->uri's. (imap4_create_folder): Don't

2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-store.c (imap4_build_folder_info):
Hide password, etc info in the fi->uri's.
(imap4_create_folder): Don't bother to use
imap4_get_folder_info(), we can construct the fi ourselves.
(imap4_delete_folder): Emit the folder_deleted signal and
construct an fi ourselves.
(imap4_subscribe_folder): Same.
(imap4_unsubscribe_folder): Same.

* providers/imap4/camel-imap4-provider.c: Specify that the
fragment is the path.

Hide password, etc info in the fi->uri's.

2004-06-23  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-store.c (imap4_build_folder_info):
Hide password, etc info in the fi->uri's.

* providers/imap4/camel-imap4-provider.c: Specify that the
fragment is the path.

Add preconditions. Make sure garbage or NULL data doesn't get used.

2004-06-22  Hans Petter Jansson  <hpj@ximian.com>

* misc/e-source-selector.c (e_source_selector_peek_primary_selection):
Add preconditions. Make sure garbage or NULL data doesn't get used.

allow consumers of EDataBookView to control the thresholds used in

2004-06-22  Chris Toshok  <toshok@ximian.com>

* libedata-book/e-data-book-view.c
(e_data_book_view_set_thresholds): allow consumers of
EDataBookView to control the thresholds used in aggregating
contacts before sending them to the gui.  allows us to implement
the different thresholds that were used in the 1.4.x ldap and file
backends.

* libedata-book/e-data-book-view.h: add prototype for
e_data_book_view_set_thresholds.

clamp the search result limit to the ldap backend's limit.

2004-06-21  Chris Toshok  <toshok@ximian.com>

* backends/ldap/e-book-backend-ldap.c
(e_book_backend_ldap_search): clamp the search result limit to the
ldap backend's limit.

i2004-06-21  Chris Toshok  <toshok@ximian.com>

* libebook/e-contact.c (e_contact_get_const): reorder some stuff
so we only generate 1 free per string on object destruction.

cache the most recently fetched const pointer so we can hand it out more

2004-06-21  Chris Toshok  <toshok@ximian.com>

* libebook/e-contact.c (e_contact_get_const): cache the most
recently fetched const pointer so we can hand it out more than
once (unless there's an intervening _set).  Should substantially
lessen the number of allocations we do because of this function.
(e_contact_set): clear the cached slot for this field, so we'll
allocate/return a new const string from e_contact_get_const.

Really set the path if tag is CAMEL_SERVICE_PATH.

2004-06-21  Christian Kellner <gicmo@xatom.net>

* camel-service.c (service_setv): Really set the path if tag is
CAMEL_SERVICE_PATH.

Fixed a number of issues described in bug #49497.

2004-06-21  Jeffrey Stedfast  <fejj@novell.com>

* camel-mime-filter-enriched.c (enriched_to_html): Fixed a number
of issues described in bug #49497.

[ fixes #59978 ]

2004-06-18  Chris Toshok  <toshok@ximian.com>

[ fixes #59978 ]

* backends/ldap/e-book-backend-ldap.c (photo_ber): implement
(photo_compare): same.
(prop_info): set add ber/compare functions for E_CONTACT_PHOTO.

make camel_shutdown() an atexit handler again

Call camel_mime_utils_shutdown() and camel_operation_shutdown().

2004-06-18  Jeffrey Stedfast  <fejj@novell.com>

* camel.c (camel_shutdown): Call camel_mime_utils_shutdown() and
camel_operation_shutdown().
(camel_init): Don't register camel_shutdown() as an atexit
handler.

* camel-operation.c (camel_operation_shutdown): New function.

* camel-mime-utils.c (camel_mime_utils_shutdown): New function to
clean up the compiled regexes.

Call camel_mime_utils_shutdown() and camel_operation_shutdown().

2004-06-18  Jeffrey Stedfast  <fejj@novell.com>

* camel.c (camel_shutdown): Call camel_mime_utils_shutdown() and
camel_operation_shutdown().

* camel-operation.c (camel_operation_shutdown): New function.

* camel-mime-utils.c (camel_mime_utils_shutdown): New function to
clean up the compiled regexes.

Need to re-init sbf->ptr and sbf->end too, or we'll be sorrryy!

2004-06-18  Jeffrey Stedfast  <fejj@novell.com>

* camel-stream-buffer.c (set_vbuf): Need to re-init sbf->ptr and
sbf->end too, or we'll be sorrryy!

"oops".

2004-06-18  Chris Toshok  <toshok@ximian.com>

* libebook/e-book.c (e_book_new_system_addressbook): "oops".

[ fixes #57628 ]

2004-06-18  Chris Toshok  <toshok@ximian.com>

[ fixes #57628 ]

* libebook/e-book.c (e_book_new_system_addressbook): use the
new_default_addressbook model, and search for a property on
sources (system=true).  If we find one, use that source, otherwise
default to ~/.evolution/local/system.

setup for static inititialisation.

2004-06-18  Not Zed  <NotZed@Ximian.com>

        * camel-exception.h (CAMEL_EXCEPTION_INITIALISER): setup for
        static inititialisation.

make 'colon' a const char *

init tail->last to (guint32) -1, so that index = tail->last + 1 will start

2004-06-17  Jeffrey Stedfast  <fejj@ximian.com>

* providers/imap4/camel-imap4-folder.c (uidset_init): init
tail->last to (guint32) -1, so that index = tail->last + 1 will
start at 0 :-)

down with e-book-async.h, up with e-book.h.

2004-06-17  Chris Toshok  <toshok@ximian.com>

* tests/ebook/test-ebook-async.c: down with e-book-async.h, up
with e-book.h.

* libedata-book/e-data-book.h: add @opid args to all the
e_data_book_respond* functions.

* libedata-book/e-data-book.c
(impl_GNOME_Evolution_Addressbook_Book_open): add @opid arg and
pass it on.
(impl_GNOME_Evolution_Addressbook_Book_remove): same.
(impl_GNOME_Evolution_Addressbook_Book_getContact): same.
(impl_GNOME_Evolution_Addressbook_Book_getContactList): same.
(impl_GNOME_Evolution_Addressbook_Book_authenticateUser): same.
(impl_GNOME_Evolution_Addressbook_Book_addContact): same.
(impl_GNOME_Evolution_Addressbook_Book_removeContacts): same.
(impl_GNOME_Evolution_Addressbook_Book_modifyContact): same.
(impl_GNOME_Evolution_Addressbook_Book_getBookView): same.
(impl_GNOME_Evolution_Addressbook_Book_getChanges): same.
(impl_GNOME_Evolution_Addressbook_Book_getSupportedFields): same.
(impl_GNOME_Evolution_Addressbook_Book_getSupportedAuthMethods): same.
(e_data_book_respond_open): same.
(e_data_book_respond_remove): same.
(e_data_book_respond_create): same.
(e_data_book_respond_remove_contacts): same.
(e_data_book_respond_modify): same.
(e_data_book_respond_authenticate_user): same.
(e_data_book_respond_get_supported_fields): same.
(e_data_book_respond_get_supported_auth_methods): same.
(e_data_book_respond_get_book_view): same.
(e_data_book_respond_get_contact): same.
(e_data_book_respond_get_contact_list): same.
(e_data_book_respond_get_changes): same.

* libedata-book/e-book-backend.h: add @opid args everywhere.

* libedata-book/e-book-backend.c (e_book_backend_open): add @opid
arg, and pass it along to the backend subclass, as well as all
calls to e_data_book_respond_*.
(e_book_backend_remove): same.
(e_book_backend_create_contact): same.
(e_book_backend_remove_contacts): same.
(e_book_backend_modify_contact): same.
(e_book_backend_get_contact): same.
(e_book_backend_get_contact_list): same.
(e_book_backend_start_book_view): same.
(e_book_backend_stop_book_view): same.
(e_book_backend_get_changes): same.
(e_book_backend_authenticate_user): same.
(e_book_backend_get_supported_fields): same.
(e_book_backend_get_supported_auth_methods): same.

* libedata-book/e-book-backend-sync.h: add @opid args everywhere.

* libedata-book/e-book-backend-sync.c
(e_book_backend_sync_create_contact): add @opid arg and pass it
along to subclass.
(e_book_backend_sync_remove): same.
(e_book_backend_sync_remove_contacts): same.
(e_book_backend_sync_modify_contact): same.
(e_book_backend_sync_get_contact): same.
(e_book_backend_sync_get_contact_list): same.
(e_book_backend_sync_get_changes): same.
(e_book_backend_sync_authenticate_user): same.
(e_book_backend_sync_get_supported_fields): same.
(e_book_backend_sync_get_supported_auth_methods): same.
(_e_book_backend_remove): same.
(_e_book_backend_create_contact): same.
(_e_book_backend_remove_contacts): same.
(_e_book_backend_modify_contact): same.
(_e_book_backend_get_contact): same.
(_e_book_backend_get_contact_list): same.
(_e_book_backend_get_changes): same.
(_e_book_backend_authenticate_user): same.
(_e_book_backend_get_supported_fields): same.
(_e_book_backend_get_supported_auth_methods): same.

* libebook/e-book.c (struct EBookOp): augment this structure with
enough info to handle the asynchronous operations.
(struct _EBookPrivate): remove the current_op pointer and add a
hashtable mapping ids to ops.  The current sync op is always id 0.
(e_book_new_op): add @sync arg.
(e_book_get_op): add @opid arg, and look up the op in the
hashtable.
(e_book_get_current_sync_op): convenience function to lookup the
current sync op.
(e_book_op_remove): remove the op from the hashtable.
(do_add_contact): split out all the code from e_book_add_contact
here, and make it handle both synchronous and async calling
sequences.
(e_book_add_contact): call do_add_contact.
(e_book_async_add_contact): same.
(e_book_response_add_contact): handle both sync/async ops.  sync =
notify on our cvar and return.  async = add idle handler that will
call the op's callback.
(emit_async_add_contact_response): idle handler for adding
contacts asynchronously.
(do_commit_contact): same pattern as above...
(do_get_supported_fields): same.
(do_get_supported_auth_methods): same.
(do_authenticate_user): same.
(do_get_contact): same.
(do_remove_contacts): same.
(do_get_book_view): same.
(do_get_contacts): same.
(do_get_changes): same.
(do_open): same.
(do_remove): same.

* libebook/e-book.h: move all the async api foo here.

* libebook/e-book-listener.h (struct _EBookListenerResponse): add
opid slot.

* libebook/e-book-listener.c
(impl_BookListener_respond_create_contact): add @opid arg and add
it to the response struct.
(impl_BookListener_respond_remove_contacts): same.
(impl_BookListener_respond_modify_contact): same.
(impl_BookListener_respond_get_contact): same.
(impl_BookListener_respond_get_contact_list): same.
(impl_BookListener_respond_get_view): same.
(impl_BookListener_respond_get_changes): same
(impl_BookListener_respond_open_book): same.
(impl_BookListener_respond_remove_book): same.
(impl_BookListener_respond_authentication_result): same.
(impl_BookListener_respond_get_supported_fields): same.
(impl_BookListener_respond_get_supported_auth_methods): same.

* libebook/Makefile.am (libebook_la_SOURCES): remove
e-book-async.c
(libebookinclude_HEADERS): remove e-book-async.h

* idl/Evolution-DataServer-Addressbook.idl: add opid args to all
the oneway void Book methods, and to all the responses in
BookListener.

* backends/vcf/e-book-backend-vcf.c
(e_book_backend_vcf_create_contact)
(e_book_backend_vcf_remove_contacts)
(e_book_backend_vcf_modify_contact)
(e_book_backend_vcf_get_contact)
(e_book_backend_vcf_get_contact_list)
(e_book_backend_vcf_authenticate_user)
(e_book_backend_vcf_get_supported_fields): add @opid arg.
(init_closure): make this more like the file:// backend.
(closure_destroy): free the cvar.
(book_view_thread): move the search code into another thread.
(e_book_backend_vcf_start_book_view): steal this from the file
backend.
(e_book_backend_vcf_stop_book_view): same.

* backends/ldap/e-book-backend-ldap.c (struct LDAPOp): add opid.
(ldap_op_add): add @opid arg.
(create_contact_handler): use op->opid in calls to
e_data_book_respond_*.
(e_book_backend_ldap_create_contact): same.
(remove_contact_handler): same.
(e_book_backend_ldap_remove_contacts): same.
(modify_contact_modify_handler): same.
(modify_contact_search_handler): same.
(e_book_backend_ldap_modify_contact): same.
(get_contact_handler): same.
(e_book_backend_ldap_get_contact): same.
(contact_list_handler): same.
(e_book_backend_ldap_get_contact_list): same.
(e_book_backend_ldap_authenticate_user): same.
(e_book_backend_ldap_get_supported_fields): same.
(e_book_backend_ldap_get_supported_auth_methods): same.
(e_book_backend_ldap_get_changes): add @opid arg.
(e_book_backend_ldap_remove): same.

* backends/groupwise/e-book-backend-groupwise.c
(e_book_backend_groupwise_create_contact)
(e_book_backend_groupwise_remove_contacts)
(e_book_backend_groupwise_modify_contact)
(e_book_backend_groupwise_get_contact)
(e_book_backend_groupwise_get_contact_list)
(e_book_backend_groupwise_get_changes)
(e_book_backend_groupwise_authenticate_user)
(e_book_backend_groupwise_get_supported_fields)
(e_book_backend_groupwise_get_supported_auth_methods)
(e_book_backend_groupwise_remove): : add @opid arg, and pass it to
e_data_book_respond_* functions.

* backends/file/e-book-backend-file.c
(e_book_backend_file_create_contact)
(e_book_backend_file_remove_contacts)
(e_book_backend_file_modify_contact)
(e_book_backend_file_get_contact)
(e_book_backend_file_get_contact_list)
(e_book_backend_file_get_changes)
(e_book_backend_file_authenticate_user)
(e_book_backend_file_get_supported_fields)
(e_book_backend_file_remove): add @opid arg.

Add support for the webcal, callto, and h323 URIs when we get them in

2004-06-17  Rodney Dawes  <dobey@novell.com>

* camel-mime-filter-tohtml.c: Add support for the webcal, callto, and
h323 URIs when we get them in mails

Don't foolishly unmunge From_ lines. First off, we don't even know if our

2004-06-17  Jeffrey Stedfast  <fejj@novell.com>

* camel-mime-filter-tohtml.c: Don't foolishly unmunge From_
lines. First off, we don't even know if our input stream came from
an mbox file and secondly, the ">From " may have been intentional
by the author. We Just Don't Know (tm).

Make sure we have elements in the array, if not then we're done (return a

2004-06-15  Jeffrey Stedfast  <fejj@novell.com>

* providers/imap4/camel-imap4-store.c (imap4_build_folder_info):
Make sure we have elements in the array, if not then we're done
(return a NULL fi).

Fixed to work properly. It was getting ranges wrong before sometimes which

2004-06-17  Jeffrey Stedfast  <fejj@ximian.com>

* providers/imap4/camel-imap4-folder.c (imap4_get_uid_set): Fixed
to work properly. It was getting ranges wrong before sometimes
which was making me lose mail! Ugh.

Thanks to Christian Kellner for pointing out these bugs (and submitting

2004-06-17  Jeffrey Stedfast  <fejj@ximian.com>

Thanks to Christian Kellner for pointing out these bugs (and
submitting the original patch for service_setv)

* camel-service.c (service_setv): Don't use (tag &
CAMEL_ARG_IGNORE) to determine if we should ignore this
tag. CAMEL_ARG_IGNORE is not a bit flag.

* providers/imap/camel-imap-store.c (imap_setv): Don't use (tag &
CAMEL_ARG_IGNORE) to determine if we should ignore this
tag. CAMEL_ARG_IGNORE is not a bit flag.

simplified further

Only ignore if (tag & CAMEL_ARG_TAG) == CAMEL_ARG_IGNORE, not if (tag &

2004-06-17  Jeffrey Stedfast  <fejj@ximian.com>

* providers/imap/camel-imap-store.c (imap_setv): Only ignore if
(tag & CAMEL_ARG_TAG) == CAMEL_ARG_IGNORE, not if (tag &
CAMEL_ARG_IGNORE) is true.

Only force a re-update of all FLAGS if this folder wasn't in the SELECTED

2004-06-16  Jeffrey Stedfast  <fejj@ximian.com>

* providers/imap4/camel-imap4-folder.c (imap4_refresh_info): Only
force a re-update of all FLAGS if this folder wasn't in the
SELECTED state. Otherwise, simply send a NOOP.

Added a 'first' member to the imap_fetch_all_t struct so we can use that

2004-06-16  Jeffrey Stedfast  <fejj@ximian.com>

* providers/imap4/camel-imap4-summary.c: Added a 'first' member to
the imap_fetch_all_t struct so we can use that as a base offset in
our GPtrArray, allowing us to limit resource consumption which
could otherwise get quite large. Also added a ChangeInfo member
that was needed for changes to untagged_fetch_all().
(imap4_fetch_all_add): Use fetch->first as a base offset and
change int i to guint32 i. Also updated to sue the fetch->changes.
(imap4_fetch_all_update): Same.
(untagged_fetch_all): Same - this is where it is really valuable,
since we can avoid adding elements to the GPtrArray that we won't
even use. Also needed to change code a big in case index <
fetch->first (which could happen if a server notified us of a
FLAGS change for a message we didn't request info about).
(imap4_fetch_all_free): Free the ChangeInfo.
(imap4_summary_fetch_all): Init fetch->changes and fetch->first.
(imap4_summary_fetch_flags): Same.
(camel_imap4_summary_flush_updates): Only request envelope info if
first <= summary->exists. Avoids needless queries.
(info_uid_sort): #if 0'd
(camel_imap4_summary_flush_updates): No need to sort the summary -
this should never have been needed. I can't remember why I did
this...

Added a 'first' member to the imap_fetch_all_t struct so we can use that

2004-06-16  Jeffrey Stedfast  <fejj@ximian.com>

* providers/imap4/camel-imap4-summary.c: Added a 'first' member to
the imap_fetch_all_t struct so we can use that as a base offset in
our GPtrArray, allowing us to limit resource consumption which
could otherwise get quite large. Also added a ChangeInfo member
that was needed for changes to untagged_fetch_all().
(imap4_fetch_all_add): Use fetch->first as a base offset and change
int i to guint32 i. Also updated to sue the fetch->changes.
(imap4_fetch_all_update): Same.
(untagged_fetch_all): Same - this is where it is really valuable,
since we can avoid adding elements to the GPtrArray that we won't
even use. Also needed to change code a big in case index <
fetch->first (which could happen if a server notified us of a
FLAGS change for a message we didn't request info about).
(imap4_fetch_all_free): Free the ChangeInfo.
(imap4_summary_fetch_all): Init fetch->changes and fetch->first.
(imap4_summary_fetch_flags): Same.

fix a path leak and maek the code more structured.

2004-06-16  Not Zed  <NotZed@Ximian.com>

        * e-source-selector.c (cell_toggled_callback): fix a path leak and
        maek the code more structured.
        (e_source_selector_set_toggle_selection): set the mode on whether
        you can toggle the currnet selection or not.
        (cell_toggled_callback): implement set_toggle_selection behaviour.