jpu@apple.com [Tue, 26 Jun 2012 18:38:56 +0000 (18:38 +0000)]
On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982
Reviewed by Darin Adler.
Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
behave consistently.
Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor().
* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:34:54 +0000 (18:34 +0000)]
Do early-return when author and user styles are disabled.
https://bugs.webkit.org/show_bug.cgi?id=89947
Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Andreas Kling.
* dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:27:44 +0000 (18:27 +0000)]
webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Eric Seidel.
webkit-patch patches-to-review will now output the list of
bugs with patches pending for review that has the user on CC,
excluding patches with cq-, sorted by the age of the patch.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_from_review_queue):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_from_review_queue):
(MockBugzilla.__init__):
(MockBugzilla.authenticate):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview):
(PatchesToReview.__init__):
(PatchesToReview._print_report):
(PatchesToReview._generate_report):
(PatchesToReview.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_patches_to_review):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:09:22 +0000 (18:09 +0000)]
[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=89933
Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Kenneth Russell.
Source/WebCore:
GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
Since the compositor doesn't use GC3D any more, these are no longer needed.
* platform/chromium/support/Extensions3DChromium.cpp:
* platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
* platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DPrivate::grContext):
* platform/chromium/support/GraphicsContext3DPrivate.h:
(WebCore):
(GraphicsContext3DPrivate):
* platform/graphics/chromium/Extensions3DChromium.h:
Source/WebKit/chromium:
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 17:56:46 +0000 (17:56 +0000)]
[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=89797
Patch by Yasuhiro Matsuda <mazda@chromium.org> on 2012-06-26
Reviewed by James Robinson.
No new tests. This patch doesn't change behavior.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 26 Jun 2012 17:01:21 +0000 (17:01 +0000)]
nrwt: broken for chromium on vista
https://bugs.webkit.org/show_bug.cgi?id=89988
Reviewed by Tony Chang.
r121194 removed support for 'chromium-win-vista' as a separate
port, but this actually prevented the code from running on vista
at all, which is unduly harsh and broke the websocket tests on
the (non-webkit) chromium bots that are still running on vista.
It's probably good enough to pretend that vista is win7 instead;
some layout tests will still fail but at least things'll run.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.determine_full_port_name):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 16:30:49 +0000 (16:30 +0000)]
Web Inspector: Native memory snapshots crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=89977
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Tue, 26 Jun 2012 16:20:07 +0000 (16:20 +0000)]
[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931
Reviewed by James Robinson.
WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
#ifdef or #if have different behavior. There are some places in
the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should
actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those
#ifdef statements.
* public/WebTextRun.h:
(WebTextRun):
* public/linux/WebFontRenderStyle.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 26 Jun 2012 15:00:43 +0000 (15:00 +0000)]
cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215
We need it because it is deprecated and will be dropped in buildbot 0.8.7
Reviewed by Tony Chang.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.__init__):
(Factory.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 14:39:59 +0000 (14:39 +0000)]
[Qt] Baseline missing for 3D transforms tests.
https://bugs.webkit.org/show_bug.cgi?id=89973
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.
Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
Add missing baselines for all unskipped 3D transforms tests.
* platform/qt/Skipped:
* platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 26 Jun 2012 14:01:12 +0000 (14:01 +0000)]
[Qt][Win] Symbols are not exported in QtWebKit5.dll
https://bugs.webkit.org/show_bug.cgi?id=88873
Reviewed by Tor Arne Vestbø.
Source/WebKit:
* api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.
Tools:
When linking the target dll make sure to re-export the symbols from
the static libraries marked as export, with the help of a little python
script and a qmake extra compiler.
* Scripts/generate-win32-export-forwards: Added.
* qmake/mkspecs/features/win32/default_post.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 13:09:25 +0000 (13:09 +0000)]
[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=89924
"bytesPerLine == targetRect.width() / 4" is invalid.
This patch amended it into "bytesPerLine == targetRect.width() * 4".
Moreover, changed magic number 4 to bytesPerPixel.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-26
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 13:07:17 +0000 (13:07 +0000)]
Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-26
Reviewed by Noam Rosenthal.
Defined a new member that says what type of output code must be generated
(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):
* platform/graphics/ANGLEWebKitBridge.h:
(ANGLEWebKitBridge):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 26 Jun 2012 12:56:13 +0000 (12:56 +0000)]
Fix bug where animations failed to start
https://bugs.webkit.org/show_bug.cgi?id=89943
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The unpause code previously checked that the animations had not started
before un-setting the pause state. This meant that if an animation was
paused and unpaused before the animations started, it would remain in the
paused state. This patch simply reorders the unpause logic to fix this bug.
Test: svg/custom/animate-initial-pause-unpause.html
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::resume):
LayoutTests:
* svg/custom/animate-initial-pause-unpause-expected.txt: Added.
* svg/custom/animate-initial-pause-unpause.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 12:49:12 +0000 (12:49 +0000)]
[EFL] Gardening of new passing tests
https://bugs.webkit.org/show_bug.cgi?id=89970
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
* platform/efl/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 26 Jun 2012 12:32:38 +0000 (12:32 +0000)]
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955
Reviewed by Vsevolod Vlasov.
Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 12:17:41 +0000 (12:17 +0000)]
[BlackBerry] Limit session storage quota to 5MB by default
https://bugs.webkit.org/show_bug.cgi?id=89941
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-06-26
Reviewed by Rob Buis.
Limit session storage quota to 5MB by default for BlackBerry
porting.
Internally reviewed by George Staikos.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::sessionStorageQuota):
(BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
* Api/WebSettings.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 12:10:58 +0000 (12:10 +0000)]
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.
Simplify the implementation of SharedBuffer::createWithContentsOfFile()
in EFL port.
No new test, no behavior change.
* platform/efl/SharedBufferEfl.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 11:27:55 +0000 (11:27 +0000)]
[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=89964
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Andreas Kling.
Added missing null pointer check.
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 10:36:21 +0000 (10:36 +0000)]
[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89647
Unreviewed, update GTK test expectations.
r121215 has fixed the assertion failure, so the test doesn't crash
anymore.
Patch by Simon Pena <spena@igalia.com> on 2012-06-26
* platform/gtk/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Tue, 26 Jun 2012 10:26:26 +0000 (10:26 +0000)]
Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/filesystem/get-metadata.html
* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.Entry.prototype.get isDirectory):
(WebInspector.FileSystemModel.Entry.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._directoryContentReceived):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.directoryContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):
LayoutTests:
* http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.writeFile):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest):
(writeFile.didGetFileSystem):
(writeFile):
(writeFile.didGetWriter.writer.onwrite):
(writeFile.didGetWriter):
* http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
* http/tests/inspector/filesystem/get-metadata.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 26 Jun 2012 10:19:20 +0000 (10:19 +0000)]
[Qt] GraphicsSurface: Fix tile update artifacts on Mac
https://bugs.webkit.org/show_bug.cgi?id=89887
Reviewed by Noam Rosenthal.
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformCopyToGLTexture):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 26 Jun 2012 10:17:44 +0000 (10:17 +0000)]
GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
https://bugs.webkit.org/show_bug.cgi?id=89883
Reviewed by Noam Rosenthal.
Follow the documentation which says: "If locking the buffer requires a readback,
the lock will fail with an error return of kIOReturnCannotLock."
Also make sure that we use the same set of flags when locking and unlocking
for simplicity and to follow this requirement on the kIOSurfaceLockReadOnly flag.
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 26 Jun 2012 10:16:05 +0000 (10:16 +0000)]
Add a note about hostname completion not working well with --cc completion
Reviewed by Simon Hausmann.
Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.
* Scripts/webkit-tools-completion.sh:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 26 Jun 2012 10:11:28 +0000 (10:11 +0000)]
Unreviewed, rolling out r121244.
http://trac.webkit.org/changeset/121244
https://bugs.webkit.org/show_bug.cgi?id=89966
skip list path is incorrect now. (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 26 Jun 2012 10:06:34 +0000 (10:06 +0000)]
Fix setCurrentTime for paused animations
https://bugs.webkit.org/show_bug.cgi?id=81350
Reviewed by Nikolas Zimmermann.
Source/WebCore:
SMILTimeContainer::setElapsed was not resetting the pause time, breaking
setCurrentTime if the animation was paused.
Test: svg/custom/animate-pause-resume.html
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
LayoutTests:
This test does not use the SVG animation test framework because the framework
works by pausing animations and testing animated values at fixed times
(through calling setCurrentTime). Testing this patch requires that we run
the animation and cannot be tested with the animation test framework.
* svg/custom/animate-pause-resume-expected.txt: Added.
* svg/custom/animate-pause-resume.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Tue, 26 Jun 2012 10:04:40 +0000 (10:04 +0000)]
[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
https://bugs.webkit.org/show_bug.cgi?id=89960
Reviewed by Antonio Gomes.
We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
in a page, even though only the one in fullscreen mode will process this.
With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
which is either a plugin, or an Video element.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 09:42:06 +0000 (09:42 +0000)]
[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-26
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 26 Jun 2012 09:22:45 +0000 (09:22 +0000)]
New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=89953
Reviewed by Zoltan Herczeg.
DFG 32-bit JIT was confused about the difference between a predicted type and a
proven type. This is easy to get confused about, since a local that is predicted int32
almost always means that the local must be an int32 since speculations are hoisted to
stores to locals. But that is less likely to be the case for arguments, where there is
an additional least-upper-bounding step: any store to an argument with a weird type
may force the argument to be any type.
This patch basically duplicates the functionality in DFGSpeculativeJIT64.cpp for
GetLocal: the decision of whether to load a local as an int32 (or as an array, or as
a boolean) is made based on the AbstractValue::m_type, which is a type proof, rather
than the VariableAccessData::prediction(), which is a predicted type.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 26 Jun 2012 09:21:20 +0000 (09:21 +0000)]
[Qt] Unreviewed typo fix after r121144.
* Target.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 26 Jun 2012 09:11:58 +0000 (09:11 +0000)]
[Qt] Enable grid layout LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=89909
Reviewed by Csaba Osztrogonác.
Source/WebKit/qt:
These tests pass, we just need to hook up the overridePreference.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h: Add enum value for CSS grid layout
Tools:
These tests pass, we just need to hook up the overridePreference.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
LayoutTests:
* platform/qt/Skipped: Enable fast/css-grid-layout tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 26 Jun 2012 09:04:31 +0000 (09:04 +0000)]
Web Inspector: columns in heap snapshot summary view are not resizable
https://bugs.webkit.org/show_bug.cgi?id=89952
Reviewed by Vsevolod Vlasov.
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): overriden method
should call overriden one to make sure column resizers are added to the DataGrid.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 26 Jun 2012 08:25:11 +0000 (08:25 +0000)]
Unreviewed, rolling out r121236.
http://trac.webkit.org/changeset/121236
https://bugs.webkit.org/show_bug.cgi?id=89956
It's broke the nrwt on qt and gtk platform (Requested by
kkristof on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 26 Jun 2012 07:59:11 +0000 (07:59 +0000)]
Unreviewed gardening after r120845.
Update expectations for test crashing in the GTK 64bit debug bot.
* platform/gtk/TestExpectations: Add test to CRASHING section.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 07:59:07 +0000 (07:59 +0000)]
Allow using <input type="color"> UI in ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=89944
Patch by Jun Mukai <mukai@chromium.org> on 2012-06-26
Reviewed by Kent Tamura.
http://crrev.com/144111 adds the UI of <input type="color"> for
ChromeOS, so now we can set its flag too.
* features.gypi:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 26 Jun 2012 07:55:26 +0000 (07:55 +0000)]
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.__init__):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 26 Jun 2012 07:55:18 +0000 (07:55 +0000)]
Refactoring: Simplify FormController interface
https://bugs.webkit.org/show_bug.cgi?id=89951
Reviewed by Kentaro Hara.
- Remove FormController::hasStateForNewFormElements()
takeStateForFormElement() can check the emptiness, and return an empty
FormControlState.
- Change the argument of takeStateForFormElement()
Passing just one HTMLFormControlElementWithState object instead of two
AtomicStringImpl. This is a preparation to use
HTMLFormControlElementWithState::form() in FormController.
No new tests. Just a refactoring.
* html/FormController.cpp:
(WebCore::FormController::takeStateForFormElement):
* html/FormController.h:
(FormController):
* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dominicc@chromium.org [Tue, 26 Jun 2012 07:41:32 +0000 (07:41 +0000)]
WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104
Reviewed by Kentaro Hara.
Source/WebCore:
The spec for WheelEvent is
<http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent>
Tests: fast/events/event-creation.html
http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent
* bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
* bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
* dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor
(WebCore::WheelEvent::isMouseEvent): Existing callers use this just for
moves and clicks, ie the type is exactly MouseEvent.
* dom/WheelEvent.h: Extend MouseEvent
* dom/WheelEvent.idl: "
LayoutTests:
* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 07:24:03 +0000 (07:24 +0000)]
[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=89948
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Martin Robinson.
Properly initialize didInitializeState in
TextChecker::state().
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::state):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 26 Jun 2012 06:29:58 +0000 (06:29 +0000)]
Get rid of firstItem and nextItem from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=89923
Reviewed by Andreas Kling.
Source/WebCore:
Removed HTMLCollection::firstItem and HTMLCollection::nextItem.
Also added hasAnyItem() and hasExactlyOneItem() to HTMLCollection so that named getter on Document
doesn't need to compute the full length before returning a HTMLCollection.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
* dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
* html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore):
(WebCore::HTMLCollection::item):
* html/HTMLCollection.h:
(HTMLCollection):
(WebCore::HTMLCollection::hasAnyItem):
(WebCore::HTMLCollection::hasExactlyOneItem):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
Source/WebKit/chromium:
Re-implement WebNodeCollection::firstItem() and WebNodeCollection::nextItem() in WebKit code
because we got rid of it from WebCore implementation.
This is an extremely poor API and we shouldn't be exposing it in the future.
* public/WebNodeCollection.h:
(WebKit::WebNodeCollection::WebNodeCollection):
(WebNodeCollection):
* src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::nextItem):
(WebKit::WebNodeCollection::firstItem):
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::collectTargetFrames):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Tue, 26 Jun 2012 06:05:25 +0000 (06:05 +0000)]
JavaScript resources have low priority when SVG is enabled
https://bugs.webkit.org/show_bug.cgi?id=89932
<rdar://problem/
11741325>
Reviewed by Adele Peterson.
r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set
the correct priority for scripts. Also, move the code so that all ifdefs are together at the
bottom to make it a bit easier to read..
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 26 Jun 2012 05:32:44 +0000 (05:32 +0000)]
Unreviewed build fix: Don't do QT += widgets with Qt 4
Source/WebKit:
* WebKit1.pro: This is already done in WebKit1.pri.
Source/WebKit/qt:
* examples/platformplugin/platformplugin.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 26 Jun 2012 05:23:57 +0000 (05:23 +0000)]
Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag).
https://bugs.webkit.org/show_bug.cgi?id=89542
Reviewed by Dimitri Glazkov.
Source/WebCore:
Added fast/css/variables/build-supports-variables.html to test runtime flag in test environment.
Updated all other css variables tests to enable the runtime flag from JS.
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::cssVariablesEnabled):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h:
(CSSParserContext):
* page/Settings.h:
(Settings):
(WebCore::Settings::setCSSVariablesEnabled):
(WebCore::Settings::cssVariablesEnabled):
Source/WebKit/chromium:
* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 26 Jun 2012 04:47:14 +0000 (04:47 +0000)]
[Qt] Make it possible to build WebKit without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=78109
Reviewed by Tor Arne Vestbø.
.:
* Source/QtWebKit.pro: Don't build WK1 tests and examples if WK1 is disabled.
* Source/api.pri: Move WK1 sources away from here and use WEBKIT += webkit1 instead
* WebKit.pro: Add WK1 to SUBDIRS unless no_webkit1 is set.
Source/WebKit:
Moved WebKit1 sources into a separate static library. Only WK1
depends on QtWidgets.
* WebKit1.pri: Added.
* WebKit1.pro: Added.
Source/WebKit2:
* WebKit2.pri: Add missing WK2 specific dependencies.
* qt/MainQt.cpp: Do the QStyle initialization hook only if we are
compiling with QtWidgets support.
(WebKit):
(main):
Tools:
* Tools.pro: Disable various tools that depend on WK1.
* qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
* qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
* qmake/mkspecs/modules/webkit1.prf: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 26 Jun 2012 04:43:44 +0000 (04:43 +0000)]
[chromium] Add WebPluginScrollbar and WebPluginScrollbarClient stub implementations
https://bugs.webkit.org/show_bug.cgi?id=89928
Reviewed by Darin Fisher.
These classes are just typedef'd to be the non-Plugin version. The
next step is to change Chromium to use the Plugin version, then move
most of WebPluginScrollbar to a WebScrollbar in Platform to separate
out the base functionality, while providing the same top level API.
* WebKit.gyp:
* public/WebPluginScrollbar.h: Added.
(WebKit):
* public/WebPluginScrollbarClient.h: Added.
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 26 Jun 2012 04:41:25 +0000 (04:41 +0000)]
Unreviewed build fix after r121223.
Fix the --minimal Qt build, TextureMapperGL now requires WebGL to be enabled.
* Target.pri:
* WebCore.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Tue, 26 Jun 2012 04:31:48 +0000 (04:31 +0000)]
[BlackBerry] Fill more data in device motion event
https://bugs.webkit.org/show_bug.cgi?id=89857
Reviewed by Antonio Gomes.
Reviewed internally by Robin Cao.
Fill acceleration and rotation rate into DeviceMotionData.
* WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
(DeviceMotionClientBlackBerry::onMotion):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Tue, 26 Jun 2012 04:14:54 +0000 (04:14 +0000)]
[chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels
https://bugs.webkit.org/show_bug.cgi?id=89922
Reviewed by Adrienne Walker.
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 03:59:30 +0000 (03:59 +0000)]
[Texmap] Remove platform specific code in BitmapImageGL::updateContents by using
GraphicsContext3D::extractImageData.
https://bugs.webkit.org/show_bug.cgi?id=89867
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Tue, 26 Jun 2012 03:46:14 +0000 (03:46 +0000)]
[EFL][WK2] Include unistd.h in PlatformProcessIdentifier.h.
https://bugs.webkit.org/show_bug.cgi?id=89804
Reviewed by Hajime Morita.
The pid_t typedef ends up coming from stdlib.h (indirectly via WTF
includes) on Mac and Linux, even though that is not mandated by
POSIX and breaks other platforms (such as FreeBSD). Fix that by
explicitly including unistd.h, which is where the typedef is
supposed to come from.
* Platform/PlatformProcessIdentifier.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 03:41:27 +0000 (03:41 +0000)]
[WK2][Qt][EFL] Extract common code from LayerTreeHostQt
https://bugs.webkit.org/show_bug.cgi?id=89837
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-06-25
Reviewed by Noam Rosenthal.
Extract common code from LayerTreeHostQt to be used by both Qt and Efl.
I renamed LayerTreeHost to LayerTreeCoordinator, and these are moved under WebProcess/WebPage/LayerTreeCoordinator.
I Modified LayerTreeHostProxy to LayerTreeCoordinatorProxy too, Because LayerTreeHostProxy and LayerTreeHost were pair.
Also WebGraphicsLayer moved under that directory.
* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Platform/CoreIPC/MessageID.h:
* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didReceiveLayerTreeCoordinatorProxyMessage):
* UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeCoordinatorProxy):
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeCoordinatorProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.h:
(WebKit):
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeCoordinatorProxy.cpp: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp.
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::~LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::updateViewport):
(WebKit::LayerTreeCoordinatorProxy::dispatchUpdate):
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerState):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerChildren):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerFilters):
(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):
(WebKit::LayerTreeCoordinatorProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeCoordinatorProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeCoordinatorProxy::setContentsSize):
(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
(WebKit::LayerTreeCoordinatorProxy::renderNextFrame):
(WebKit::LayerTreeCoordinatorProxy::didChangeScrollPosition):
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
* UIProcess/LayerTreeCoordinatorProxy.h: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.
(WebKit):
(LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::layerTreeRenderer):
* UIProcess/LayerTreeCoordinatorProxy.messages.in: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.messages.in.
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
* UIProcess/WebLayerTreeRenderer.h:
(WebKit):
(WebLayerTreeRenderer):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
* WebKit2.pri:
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveLayerTreeCoordinatorMessage):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp.
(WebKit):
(WebKit::LayerTreeCoordinator::create):
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeCoordinator::scheduleLayerFlush):
(WebKit::LayerTreeCoordinator::cancelPendingLayerFlush):
(WebKit::LayerTreeCoordinator::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::setRootCompositingLayer):
(WebKit::LayerTreeCoordinator::invalidate):
(WebKit::LayerTreeCoordinator::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeCoordinator::scrollNonCompositedContents):
(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::sizeDidChange):
(WebKit::LayerTreeCoordinator::didInstallPageOverlay):
(WebKit::LayerTreeCoordinator::didUninstallPageOverlay):
(WebKit::LayerTreeCoordinator::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeCoordinator::setPageOverlayOpacity):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::syncLayerState):
(WebKit::LayerTreeCoordinator::syncLayerChildren):
(WebKit::LayerTreeCoordinator::syncCanvas):
(WebKit::LayerTreeCoordinator::syncLayerFilters):
(WebKit::LayerTreeCoordinator::attachLayer):
(WebKit::LayerTreeCoordinator::detachLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeCoordinator::syncFixedLayers):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::layerFlushTimerFired):
(WebKit::LayerTreeCoordinator::createPageOverlayLayer):
(WebKit::LayerTreeCoordinator::destroyPageOverlayLayer):
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
(WebKit::LayerTreeCoordinator::notifyAnimationStarted):
(WebKit::LayerTreeCoordinator::notifySyncRequired):
(WebKit::LayerTreeCoordinator::paintContents):
(WebKit::LayerTreeCoordinator::showDebugBorders):
(WebKit::LayerTreeCoordinator::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::visibleContentsRect):
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):
(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::layerTreeTileUpdatesAllowed):
(WebKit::LayerTreeCoordinator::purgeBackingStores):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h: Renamed from Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h.
(WebKit):
(LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::layerTreeContext):
(WebKit::LayerTreeCoordinator::pageOverlayShouldApplyFadeWhenPainting):
(WebKit::LayerTreeCoordinator::pauseRendering):
(WebKit::LayerTreeCoordinator::resumeRendering):
(WebKit::LayerTreeCoordinator::deviceScaleFactorDidChange):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.messages.in: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeHost.messages.in.
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp.
(WebCore):
(WebCore::layerByIDMap):
(WebCore::WebGraphicsLayer::layerByID):
(WebCore::toWebLayerID):
(WebCore::WebGraphicsLayer::didChangeLayerState):
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore::WebGraphicsLayer::didChangeFilters):
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::willBeDestroyed):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setMasksToBounds):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setBackfaceVisibility):
(WebCore::WebGraphicsLayer::setOpacity):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToCanvas):
(WebCore::WebGraphicsLayer::setFilters):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::id):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::toWebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncChildren):
(WebCore::WebGraphicsLayer::syncFilters):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::syncCanvas):
(WebCore::WebGraphicsLayer::ensureImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::effectiveContentsScale):
(WebCore::WebGraphicsLayer::adjustContentsScale):
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::shouldUseTiledBackingStore):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
(WebCore::createWebGraphicsLayer):
(WebCore::WebGraphicsLayer::initFactory):
(WebCore::WebGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h.
(WebCore):
(WebKit):
(WebGraphicsLayerClient):
(WebGraphicsLayer):
(WebCore::WebGraphicsLayer::image):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebCore::WebGraphicsLayer::maskTarget):
(WebCore::WebGraphicsLayer::setMaskTarget):
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 03:37:53 +0000 (03:37 +0000)]
[chromium] Remove uncalled ManagedTexture::framebufferTexture2D
https://bugs.webkit.org/show_bug.cgi?id=89930
Patch by James Robinson <jamesr@chromium.org> on 2012-06-25
Reviewed by Adrienne Walker.
Removing dead code.
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ManagedTexture.h:
(ManagedTexture):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 03:28:53 +0000 (03:28 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 26 Jun 2012 02:53:39 +0000 (02:53 +0000)]
JSC should try to make profiling deterministic because otherwise reproducing failures is
nearly impossible
https://bugs.webkit.org/show_bug.cgi?id=89940
Rubber stamped by Gavin Barraclough.
This rolls out the part of http://trac.webkit.org/changeset/121215 that introduced randomness
into the system. Now, instead of randomizing the tier-up threshold, we always set it to an
artificially low (and statically predetermined!) value. This gives most of the benefit of
threshold randomization without actually making the system behave completely differently on
each invocation.
* bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 02:52:11 +0000 (02:52 +0000)]
Unreviewed, rolling out r121206.
http://trac.webkit.org/changeset/121206
https://bugs.webkit.org/show_bug.cgi?id=89935
[chromium] webkit_unit_tests
WebViewTest.MHTMLWithMissingResourceFinishesLoading crash
(Requested by ukai on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
Source/WebCore:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
Source/WebKit/chromium:
* tests/EventListenerTest.cpp:
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
(FrameTestHelpers):
* tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Tue, 26 Jun 2012 02:28:35 +0000 (02:28 +0000)]
Unreviewed, update chromium test expectations.
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 26 Jun 2012 02:14:07 +0000 (02:14 +0000)]
Value profiling should use tier-up threshold randomization to get more coverage
https://bugs.webkit.org/show_bug.cgi?id=89802
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
This patch causes both LLInt and Baseline JIT code to take the OSR slow path several
times before actually doing OSR. If we take the OSR slow path before the execution
count threshold is reached, then we just call CodeBlock::updateAllPredictions() to
compute the current latest least-upper-bound SpecType of all values seen in each
ValueProfile.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(CodeBlock):
(JSC::CodeBlock::updateAllPredictions):
* bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::status):
(JSC):
* bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::count):
(ExecutionCounter):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::weakRandomInteger):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* runtime/WeakRandom.h:
(WeakRandom):
(JSC::WeakRandom::seedUnsafe):
LayoutTests:
Reviewed by Gavin Barraclough.
* fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Added.
* fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Added.
* fast/js/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Added.
(foo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 02:02:32 +0000 (02:02 +0000)]
[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
per platform executes on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89914
Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2012-06-25
Reviewed by James Robinson.
No new tests. (HW video decode is still only being tested manually for orientation)
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 26 Jun 2012 01:59:57 +0000 (01:59 +0000)]
[Chromium] Let the embedder override the max page scale factor set by the page
https://bugs.webkit.org/show_bug.cgi?id=89406
Reviewed by James Robinson.
Chrome on Android has an option to force the web site to allow page
scaling (for accessibility). This patch adds
WebView::setIgnoreViewportTagMaximumScale, which instructs the WebView
to ignore the maximum scale factor supplied by by the page in the
viewport meta tag.
This patch is a bit different from how this is implemented on the
chromium-android branch, but I'll clean up the branch once this patch
lands.
* public/WebView.h:
(WebView):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIgnoreViewportTagMaximumScale):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::ignoreViewportTagMaximumScale):
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 01:57:37 +0000 (01:57 +0000)]
Unreviewed, rolling out r121176.
http://trac.webkit.org/changeset/121176
https://bugs.webkit.org/show_bug.cgi?id=89934
[chromium] browser_tests assert failed:
FATAL:native_theme_win.cc(1541)] Check failed: false. Invalid
part: 16 (Requested by ukai on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
Source/Platform:
* chromium/public/win/WebThemeEngine.h:
(WebKit::WebThemeEngine::paintProgressBar):
Source/WebCore:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Tue, 26 Jun 2012 01:49:11 +0000 (01:49 +0000)]
[Shadow] Deleting list distributed to Shadow DOM does not work correctly.
https://bugs.webkit.org/show_bug.cgi?id=89170
Reviewed by Ryosuke Niwa.
Source/WebCore:
When deleting several elements distributed to Shadow DOM, some renderers might be gone in
processing deletion. To fix them, we should call isContentEditable() instead of rendererIsEditable().
Test: editing/shadow/delete-list-in-shadow.html
* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
LayoutTests:
* editing/shadow/delete-list-in-shadow-expected.txt: Added.
* editing/shadow/delete-list-in-shadow.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 01:34:36 +0000 (01:34 +0000)]
[Chromium] Fix the css stylesheet for android media controls after recent changes
https://bugs.webkit.org/show_bug.cgi?id=89910
Patch by Min Qin <qinmin@chromium.org> on 2012-06-25
Reviewed by Adam Barth.
After the recent changes on upstream chrome video controls, we need to change the css style sheet for chrome on android.
No tests needed, just css changes.
* css/mediaControlsChromiumAndroid.css:
(audio):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(::-webkit-media-controls):
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-fullscreen-button):
(input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-media-slider-thumb):
(audio::-webkit-media-controls-fullscreen-button):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 01:30:19 +0000 (01:30 +0000)]
[Qt] Avoid a deep copy of QImage in GraphicsContext3D::getImageData.
https://bugs.webkit.org/show_bug.cgi?id=89865
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 01:26:17 +0000 (01:26 +0000)]
Reduce memory footprint of BitmapImage Vectors.
https://bugs.webkit.org/show_bug.cgi?id=86563
Patch by Nick Carter <nick@chromium.org> on 2012-06-25
Reviewed by Simon Fraser.
No new tests, affects template params only.
* platform/graphics/BitmapImage.h:
(BitmapImage): use an inline capacity of 1 for the image frame Vector
* platform/image-decoders/ImageDecoder.h:
(ImageDecoder): use an inline capacity of 1 for the image frame Vector
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 26 Jun 2012 01:20:05 +0000 (01:20 +0000)]
Unreviewed, rolling out r121145.
http://trac.webkit.org/changeset/121145
https://bugs.webkit.org/show_bug.cgi?id=89847
Had an objection for the change.
Source/WebCore:
* html/FormController.cpp:
(WebCore):
(WebCore::FormControlState::serializeTo):
(WebCore::FormControlState::deserialize):
(WebCore::formStateSignature):
(WebCore::FormController::formElementsState):
(WebCore::FormController::setStateForNewFormElements):
* html/FormController.h:
(FormControlState):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::addJavaScriptString):
Source/WTF:
* wtf/text/StringBuilder.h:
LayoutTests:
* fast/forms/state-restore-broken-state-expected.txt:
* fast/forms/state-restore-various-values-expected.txt: Removed.
* fast/forms/state-restore-various-values.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Tue, 26 Jun 2012 01:12:06 +0000 (01:12 +0000)]
Fix progress load reporting for MHTML documents.
MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859
Reviewed by Nate Chapin.
Source/WebCore:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
Source/WebKit/chromium:
* tests/EventListenerTest.cpp:
* tests/FrameTestHelpers.cpp:
(FrameTestHelpers):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
(FrameTestHelpers):
* tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):
(TestWebViewClient):
(WebKit::TestWebViewClient::TestWebViewClient):
(WebKit::TestWebViewClient::didStartLoading):
(WebKit::TestWebViewClient::didStopLoading):
(WebKit::TestWebViewClient::didChangeLoadProgress):
(WebKit::TestWebViewClient::loadingStarted):
(WebKit::TestWebViewClient::loadingStopped):
(WebKit::TestWebViewClient::loadProgress):
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 26 Jun 2012 00:56:41 +0000 (00:56 +0000)]
put vista back for chromium (non-webkit) bots ...
https://bugs.webkit.org/show_bug.cgi?id=89929
Unreviewed, build fix.
Turns out we've only gotten rid of vista on the webkit tests so
far. Put vista back for the other chromium bots ...
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(chromiumPlatform):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 26 Jun 2012 00:55:55 +0000 (00:55 +0000)]
[chromium] Use WebGraphicsContext3D in compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=89700
Reviewed by Adrienne Walker.
Source/Platform:
Puts all callback destructors in protected section and removes obsolete memory callback signature.
* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
Source/WebCore:
This converts the compositor implementation from using WebCore::GraphicsContext3D to using the Platform-provided
WebGraphicsContext3D. This removes several unnecessary layers of indirection/wrapping and cuts down the
compositor's implementation dependencies. GraphicsContext3D.h is still widely used to provide GL enum values.
Most of the changes are purely mechanical - changing type names and the like.
Ownership is changed a bit. Instead of multiple components holding references to the compositor's context, the
context is now owned by the CCGraphicsContext, which is now owned directly by CCLayerTreeHostImpl.
CCLayerTreeHostImpl also has ownership of its CCRenderer (LayerRendererChromium in 3D mode) and passes a
non-owning pointer down to the CCRenderer.
Extension checking is a bit different. The compositor does not (and never has) used extensions provided by
WebGL's request/ensure mechanism. It simply checks for the existence of extensions it needs in the GL_EXTENSIONS
string.
FrameBufferSkPictureCanvasLayerTextureUpdater had to be patched as well, since it was grabbing a GrContext off
of the compositor's GraphicsContext3D. This caused many problems. It was inefficient, since it required a full
state flush when switching between ganesh and compositor calls. The gpu memory management was completely broken
since the compositor clobbered ganesh's onMemoryAllocationChanged callback. This moves FBSkPCLTU over to using
the appropriate SharedGraphicsContext3D, like filters.
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
(FrameBufferSkPictureCanvasLayerTextureUpdater):
* platform/graphics/chromium/GeometryBinding.cpp:
(WebCore::GeometryBinding::GeometryBinding):
* platform/graphics/chromium/GeometryBinding.h:
(WebKit):
(GeometryBinding):
(WebCore::GeometryBinding::context):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::context):
(WebCore::LayerRendererChromium::debugGLCall):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::onMemoryAllocationChanged):
(WebCore):
(WebCore::LayerRendererChromium::onMemoryAllocationChangedOnImplThread):
(WebCore::LayerRendererChromium::discardFramebuffer):
(WebCore::LayerRendererChromium::ensureFramebuffer):
(WebCore::LayerRendererChromium::onContextLost):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::isContextLost):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebKit):
(WebCore):
(LayerRendererChromium):
(WebCore::LayerRendererChromium::isFramebufferDiscarded):
* platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/PlatformColor.h:
(WebCore::PlatformColor::bestTextureFormat):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::contextLost):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
* platform/graphics/chromium/ProgramBinding.h:
(WebKit):
(ProgramBindingBase):
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderCheckerboard::init):
* platform/graphics/chromium/ShaderChromium.h:
(WebKit):
(VertexShaderPosTex):
(VertexShaderPosTexYUVStretch):
(VertexShaderPos):
(WebCore::VertexShaderPosTexIdentity::init):
(VertexShaderPosTexTransform):
(VertexShaderQuad):
(VertexShaderTile):
(VertexShaderVideoTransform):
(FragmentTexAlphaBinding):
(FragmentTexOpaqueBinding):
(FragmentShaderOESImageExternal):
(FragmentShaderRGBATexAlphaAA):
(FragmentTexClampAlphaAABinding):
(FragmentShaderRGBATexAlphaMask):
(FragmentShaderRGBATexAlphaMaskAA):
(FragmentShaderYUVVideo):
(FragmentShaderColor):
(FragmentShaderCheckerboard):
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::~AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h:
(WebKit):
(WebCore):
(WebCore::AcceleratedTextureCopier::create):
(AcceleratedTextureCopier):
* platform/graphics/chromium/TextureManager.h:
* platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::Query::Query):
(WebCore::ThrottledTextureUploader::Query::~Query):
(WebCore::ThrottledTextureUploader::Query::begin):
(WebCore::ThrottledTextureUploader::Query::end):
(WebCore::ThrottledTextureUploader::Query::isPending):
(WebCore::ThrottledTextureUploader::Query::wait):
(WebCore::ThrottledTextureUploader::ThrottledTextureUploader):
* platform/graphics/chromium/ThrottledTextureUploader.h:
(WebKit):
(WebCore::ThrottledTextureUploader::create):
(WebCore::ThrottledTextureUploader::Query::create):
(Query):
(ThrottledTextureUploader):
* platform/graphics/chromium/TrackingTextureAllocator.cpp:
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
(WebCore::TrackingTextureAllocator::deleteAllTextures):
* platform/graphics/chromium/TrackingTextureAllocator.h:
(WebKit):
(WebCore::TrackingTextureAllocator::create):
(TrackingTextureAllocator):
* platform/graphics/chromium/cc/CCGraphicsContext.h:
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createContext):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
(LayerRendererCapabilities):
(WebCore::CCLayerTreeHost::needsSharedContext):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
Source/WebKit/chromium:
Updates tests for refactor, mostly by removing unnecessary GraphicsContext3D wrapper around mock contexts.
* WebKit.gypi:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::context):
* src/WebLayerTreeViewImpl.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
* tests/CCSingleThreadProxyTest.cpp:
* tests/CCThreadedTest.cpp:
(WebKitTests::TestHooks::createContext):
* tests/CCThreadedTest.h:
(TestHooks):
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
* tests/CompositorFakeGraphicsContext3D.h: Removed.
* tests/DrawingBufferChromiumTest.cpp: Removed.
* tests/FakeCCLayerTreeHostClient.h:
* tests/FakeGraphicsContext3DTest.cpp:
(TEST):
* tests/GraphicsLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST_F):
(TEST):
* tests/TextureCopierTest.cpp:
* tests/ThrottledTextureUploaderTest.cpp:
(WebKit::TEST):
* tests/TiledLayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 26 Jun 2012 00:43:47 +0000 (00:43 +0000)]
[Lion WK2] fast/loader/reload-zero-byte-plugin.html hits assert
https://bugs.webkit.org/show_bug.cgi?id=89611
<rdar://problem/
11714023>
Reviewed by Sam Weinig.
Source/WebKit2:
Make sure to send the response along to the plug-in in the case where the stream was empty.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::finishedLoading):
LayoutTests:
Remove the test from the Skipped list.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 26 Jun 2012 00:31:21 +0000 (00:31 +0000)]
remove chromium vista baselines
https://bugs.webkit.org/show_bug.cgi?id=89927
Unreviewed, expectations change.
Now that we no longer run tests on Vista, no need for the
baselines either.
* platform/chromium-win-vista/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
* platform/chromium-win-vista/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Removed.
* platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
* platform/chromium-win-vista/compositing/overflow/theme-affects-visual-overflow-expected.txt: Removed.
* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-win-vista/css1/font_properties/font-expected.txt: Removed.
* platform/chromium-win-vista/css1/text_properties/line_height-expected.txt: Removed.
* platform/chromium-win-vista/css1/units/percentage_units-expected.png: Removed.
* platform/chromium-win-vista/css2.1/t040103-ident-03-c-expected.png: Removed.
* platform/chromium-win-vista/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-32-expected.txt: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
* platform/chromium-win-vista/editing/inserting/4959067-expected.txt: Removed.
* platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Removed.
* platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Removed.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
* platform/chromium-win-vista/fast/block/positioning/trailing-space-test-expected.png: Removed.
* platform/chromium-win-vista/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-win-vista/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
* platform/chromium-win-vista/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
* platform/chromium-win-vista/fast/canvas/webgl/context-lost-expected.txt: Removed.
* platform/chromium-win-vista/fast/compact/001-expected.png: Removed.
* platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png: Removed.
* platform/chromium-win-vista/fast/css/text-rendering-expected.png: Removed.
* platform/chromium-win-vista/fast/css/text-rendering-expected.txt: Removed.
* platform/chromium-win-vista/fast/css/zoom-body-scroll-expected.txt: Removed.
* platform/chromium-win-vista/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* platform/chromium-win-vista/fast/dom/HTMLProgressElement/progress-element-expected.txt: Removed.
* platform/chromium-win-vista/fast/forms/select-writing-direction-natural-expected.txt: Removed.
* platform/chromium-win-vista/fast/inline-block/002-expected.png: Removed.
* platform/chromium-win-vista/fast/inline/002-expected.png: Removed.
* platform/chromium-win-vista/fast/js/large-expressions-expected.txt: Removed.
* platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Removed.
* platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
* platform/chromium-win-vista/fast/parser/style-script-head-test-expected.png: Removed.
* platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Removed.
* platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Removed.
* platform/chromium-win-vista/fast/replaced/image-tag-expected.png: Removed.
* platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Removed.
* platform/chromium-win-vista/fast/table/tableInsideCaption-expected.png: Removed.
* platform/chromium-win-vista/fast/text/atsui-kerning-and-ligatures-expected.png: Removed.
* platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/international/bidi-neutral-run-expected.png: Removed.
* platform/chromium-win-vista/fast/text/international/danda-space-expected.png: Removed.
* platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/selection-rect-rounding-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
* platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
* platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Removed.
* platform/chromium-win-vista/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
* platform/chromium-win-vista/fast/writing-mode/broken-ideographic-font-expected.txt: Removed.
* platform/chromium-win-vista/fast/writing-mode/english-lr-text-expected.png: Removed.
* platform/chromium-win-vista/http/tests/misc/acid2-expected.txt: Removed.
* platform/chromium-win-vista/http/tests/misc/acid2-pixel-expected.png: Removed.
* platform/chromium-win-vista/platform/chromium/compositing/layout-width-change-expected.png: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
* platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
* platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.txt: Removed.
* platform/chromium-win-vista/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
* platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Removed.
* platform/chromium-win-vista/svg/css/shadow-changes-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/bug45331-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/use-clipped-hit-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/use-modify-target-symbol-expected.txt: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/big-sized-filter-2-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feComposite-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feMerge-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/subRegion-in-userSpace-expected.png: Removed.
* platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
* platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-query-expected.png: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-query-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
* platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug120107-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug1271-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug13169-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug196870-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/marvin/tables_align_center-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
* platform/chromium-win-vista/transforms/2d/hindi-rotated-expected.png: Removed.
* platform/chromium-win-vista/transforms/2d/hindi-rotated-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 26 Jun 2012 00:29:20 +0000 (00:29 +0000)]
[chromium] Make CCThreadProxy not draw a frame mid-commit
https://bugs.webkit.org/show_bug.cgi?id=89905
Reviewed by James Robinson.
If commitComplete is not called before the next frame goes up, then
then the max scroll position on the root scroll layer is not updated.
This causes the compositor-side scrollbar to have an incorrect
visibleSize, causing the thumbRect to become stretched, relative to
when it was originally painted.
CCScheduler::setVisible has the side effect of kicking off a frame, so
move it last.
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionCommit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 26 Jun 2012 00:18:30 +0000 (00:18 +0000)]
update flakiness dashboard after removing chromium-vista bots
https://bugs.webkit.org/show_bug.cgi?id=89925
Unreviewed, build fix.
More changes missed in r121194 :(.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(chromiumPlatform):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 00:11:55 +0000 (00:11 +0000)]
[Chromium] Add a chromium-webkit API to create a serializable file system.
https://bugs.webkit.org/show_bug.cgi?id=89776
In order to send a DOMFileSystem as part of WebIntent payload data it
should be serializable. Therefore, I added an API that allows us to
create serializable file system in chromium code.
Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-06-25
Reviewed by Adam Barth.
* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit):
* src/WebFrameImpl.h:
(WebFrameImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 00:08:19 +0000 (00:08 +0000)]
[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779
Patch by Yong Li <yoli@rim.com> on 2012-06-25
Reviewed by Rob Buis.
Source/JavaScriptCore:
Add MemoryStatistics.cpp into build, and fill JITBytes for BlackBerry port.
* PlatformBlackBerry.cmake:
* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):
Source/WebKit/blackberry:
Add detailed JS memory statistics to about:memory page.
* WebCoreSupport/AboutData.cpp:
(WebCore::dumpJSCTypeCountSetToTableHTML):
(WebCore):
(WebCore::memoryPage):
Source/WTF:
Turn on WTF_USE_EXPORT_MACROS for BlackBerry port.
This will make macros like JS_EXPORT_PRIVATE work without
extra porting.
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 23:59:55 +0000 (23:59 +0000)]
EventSource: Events should not be dispatched after close()
https://bugs.webkit.org/show_bug.cgi?id=85346
Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-25
Reviewed by Adam Barth.
Source/WebCore:
Spec changed to make sure that no events are dispatched after close() is
called, even if more data was received before the call to close().
See,
https://www.w3.org/Bugs/Public/show_bug.cgi?id=14331#c5
http://html5.org/tools/web-apps-tracker?from=6771&to=6772
Firefox behaves like this already.
Test: http/tests/eventsource/eventsource-events-after-close.html
* page/EventSource.cpp:
(WebCore::EventSource::parseEventStream):
LayoutTests:
* http/tests/eventsource/eventsource-events-after-close-expected.txt: Added.
* http/tests/eventsource/eventsource-events-after-close.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 25 Jun 2012 23:53:10 +0000 (23:53 +0000)]
remove support for chromium vista from tools
https://bugs.webkit.org/show_bug.cgi?id=89915
Reviewed by Tony Chang.
Tools:
This change is all deleting code and updating tests to handle
the configuration being gone. All tests now pass except for a
few unittests for the flakiness dashboard which were failing
before this patch.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_complex_shadowing):
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):
(ChromiumWinTest.test_baseline_path):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
LayoutTests:
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Mon, 25 Jun 2012 23:28:19 +0000 (23:28 +0000)]
Unreviewed. Build fix.
Rebaseline layout test expectations from r121179.
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 23:15:44 +0000 (23:15 +0000)]
Fixing compilation failure in StyleResolver.cpp/CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=89892
Patch by Mike West <mkwst@chromium.com> on 2012-06-25
Reviewed by Alexis Menard.
Adding CSSPropertyVariable to switch statements in CSSParser and
StyleResolver to fix compilation errors under ninja/clang. I've
added both as new cases to the switches, with FIXME comments for
implementation.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Mon, 25 Jun 2012 23:03:28 +0000 (23:03 +0000)]
Fix for a memory leak with MHTMLArchives.
MHTML files present a flat list of frames and resources but the WebKit Archive
has a tree strcture. So the MHTMLArchive class make sures that every frame
knows about any other frames and resources.
Because these objects are ref counted, that would introduce circular references
preventing the entire Archive from being deleted.
This fixes this by:
- making sure the top-frame (which appears as the first entry in the MHTML) is
not referenced by the other frames.
- when the main frame is deleted it traverse the entire subarchive (sub-frames)
graph and makes sure they clear all their references to other subarchives.
https://bugs.webkit.org/show_bug.cgi?id=88470
Reviewed by Adam Barth.
* loader/archive/Archive.cpp:
(WebCore::Archive::clearAllSubframeArchives):
(WebCore):
(WebCore::Archive::clearAllSubframeArchivesImpl):
* loader/archive/Archive.h:
(Archive):
* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::~MHTMLArchive):
(WebCore):
(WebCore::MHTMLArchive::create):
* loader/archive/mhtml/MHTMLArchive.h:
(MHTMLArchive):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Mon, 25 Jun 2012 22:45:39 +0000 (22:45 +0000)]
Unreviewed, rolling out r121178.
http://trac.webkit.org/changeset/121178
https://bugs.webkit.org/show_bug.cgi?id=89784
New unit test added is failing on WebKit Linux (dbg)
Source/WebCore:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Mon, 25 Jun 2012 22:27:06 +0000 (22:27 +0000)]
Unreviewed, rolling out r121137.
http://trac.webkit.org/changeset/121137
Chromium build fix, (un)touch files to build on Chromium Win
Release
* css/CSSParserMode.h:
* css/CSSValue.h:
(WebCore):
* css/CSSVariableValue.h:
* page/Settings.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleVariableData.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Mon, 25 Jun 2012 22:25:05 +0000 (22:25 +0000)]
Mac bot gardening.
https://bugs.webkit.org/show_bug.cgi?id=89611
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Mon, 25 Jun 2012 22:19:03 +0000 (22:19 +0000)]
Unreviewed, rolling out r121129.
http://trac.webkit.org/changeset/121129
https://bugs.webkit.org/show_bug.cgi?id=89542
Chromium ASan failure: crbug.com/134402
Source/WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h:
(CSSParserContext):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
Source/WebKit/chromium:
* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
(WebSettingsImpl):
LayoutTests:
* fast/css/variables/border-width.html:
* fast/css/variables/build-supports-variables-expected.txt: Removed.
* fast/css/variables/build-supports-variables.html: Removed.
* fast/css/variables/colors-test.html:
* fast/css/variables/complex-cycle.html:
* fast/css/variables/computed-style.html:
* fast/css/variables/inherited-values.html:
* fast/css/variables/inline-styles.html:
* fast/css/variables/invalid-shorthand.html:
* fast/css/variables/invalid-variable-value.html:
* fast/css/variables/multi-level-cycle.html:
* fast/css/variables/redefinition.html:
* fast/css/variables/shorthand.html:
* fast/css/variables/simple-cycle.html:
* fast/css/variables/transform-test.html:
* fast/css/variables/undefined.html:
* fast/css/variables/use-before-defined.html:
* fast/css/variables/var-inside-shorthand.html:
* fast/css/variables/variable-chain.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Mon, 25 Jun 2012 22:13:24 +0000 (22:13 +0000)]
Roll Chromium DEPS to r144020
https://bugs.webkit.org/show_bug.cgi?id=89912
Build fixed now! Unreviewed.
Rolled DEPS to fix chromium build.
Patch by Scott Graham <scottmg@chromium.org>.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 22:09:36 +0000 (22:09 +0000)]
IndexedDB: Stub out new onSuccess() handler for chromium
https://bugs.webkit.org/show_bug.cgi?id=89895
This is the chromium side of a refactor which will
introduce an onSuccess() method which includes the raw
SerializedScriptValue to the frontend, so the primaryKey
injection can happen in the front end, rather than
the V8 helper process.
Patch by Alec Flett <alecflett@chromium.org> on 2012-06-25
Reviewed by Darin Fisher.
* public/WebIDBCallbacks.h:
(WebKit):
(WebKit::WebIDBCallbacks::onSuccess):
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
* src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
(WebKit):
* src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 25 Jun 2012 22:01:23 +0000 (22:01 +0000)]
Use InterpolationLow on chromium-android
https://bugs.webkit.org/show_bug.cgi?id=89849
Reviewed by Daniel Bates.
Source/WebCore:
Min Qin writes:
Using InterpolationHigh is very very expensive when resampling
images. For example, it took 1400ms to decode an image on
http://www.crossfitsunnyvale.com/blog/, but it took 2800 ms to do the
resampling Switch to InterpolationLow will result in linear
resampling. It is much faster as the time it tooks is almost
non-noticable [sic] on the trace.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
Source/WTF:
Introduce a USE macro to control image interpolation quality.
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Mon, 25 Jun 2012 21:57:14 +0000 (21:57 +0000)]
IndexedDB: Remove unused backend property accessors
https://bugs.webkit.org/show_bug.cgi?id=89893
Reviewed by Darin Fisher.
Source/WebCore:
Following the "metadata" API addition in trac.webkit.org/changeset/121059
the IDBXXXBackendInterface types no longer need per-property accessors.
No new tests - no functional changes.
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Remove method implementation.
* Modules/indexeddb/IDBDatabaseBackendImpl.h: Remove methods.
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h: Remove methods.
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBIndexBackendImpl.h: Make methods simple accessors.
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::name):
(WebCore::IDBIndexBackendImpl::keyPath):
(WebCore::IDBIndexBackendImpl::unique):
(WebCore::IDBIndexBackendImpl::multiEntry):
* Modules/indexeddb/IDBIndexBackendInterface.h: Remove methods.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Remove method implementation.
* Modules/indexeddb/IDBObjectStoreBackendImpl.h: Make methods simple accessors.
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Remove methods.
Source/WebKit/chromium:
Following the "metadata" API addition in trac.webkit.org/changeset/121059
per-property accessors can be removed from the Chromium WebKit API.
* src/WebIDBDatabaseImpl.cpp: Removed name, version, objectStoreNames.
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBIndexImpl.cpp: Removed name, keyPath, unique, multiEntry.
* src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
* src/WebIDBObjectStoreImpl.cpp: Removed name, keyPath, autoIncrement, indexNames.
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 21:45:37 +0000 (21:45 +0000)]
Add layout tests for audio codecs
https://bugs.webkit.org/show_bug.cgi?id=88794
Patch by Raymond Toy <rtoy@google.com> on 2012-06-25
Reviewed by Chris Rogers.
New tests and expected results
* webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* webaudio/codec-tests/aac/vbr-128kbps-44khz.html: Added.
* webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* webaudio/codec-tests/mp3/128kbps-44khz.html: Added.
* webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
* webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html: Added.
* webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html: Added.
* webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
* webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html: Added.
* webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
* webaudio/codec-tests/wav/24bit-22khz-resample.html: Added.
* webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
* webaudio/codec-tests/wav/24bit-44khz.html: Added.
* webaudio/resources/audio-codec-test.js: Added.
(runDecodingTest):
(finishedLoading):
Media files for the tests
* webaudio/resources/media/128kbps-44khz.mp3: Added.
* webaudio/resources/media/24bit-22khz.wav: Added.
* webaudio/resources/media/24bit-44khz.wav: Added.
* webaudio/resources/media/vbr-128kbps-44khz.m4a: Added.
* webaudio/resources/media/vbr-128kbps-44khz.ogg: Added.
* webaudio/resources/media/vbr-70kbps-44khz.ogg: Added.
* webaudio/resources/media/vbr-96kbps-44khz.ogg: Added.
Platform-specific expected results
* platform/chromium-linux/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* platform/chromium-linux/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* platform/chromium-linux/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
* platform/chromium-mac/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* platform/chromium-mac/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* platform/chromium-win/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* platform/chromium-win/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* platform/chromium-win/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
New test expectations
* platform/chromium/TestExpectations: Disable aac/mp3 tests until bots have support.
* platform/efl/TestExpectations: Disable all webaudio codec tests
* platform/gtk/TestExpectations: Disable all webaudio codec tests
* platform/mac/TestExpectations: Disable all webaudio codec tests
* platform/qt/TestExpectations: Disable all webaudio codec tests
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Mon, 25 Jun 2012 21:31:38 +0000 (21:31 +0000)]
[Chromium] add empty impl of WebThemeEngine::getSize() for DRT
https://bugs.webkit.org/show_bug.cgi?id=89907
Not reviewed. Fix build in Chromium.
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(WebThemeEngineDRTWin::getSize):
* DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
(WebThemeEngineDRTWin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 21:26:06 +0000 (21:26 +0000)]
[EFL] Add support for building with ENABLE_MEDIA_STREAM
https://bugs.webkit.org/show_bug.cgi?id=88413
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-25
Reviewed by Dirk Pranke.
Add files which are needed for supporting the Media Stream
feature.
No change in functionality so no new tests.
* PlatformEfl.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 21:18:22 +0000 (21:18 +0000)]
[Texmap] TextureMapperPaintOptions should keep current surface.
https://bugs.webkit.org/show_bug.cgi?id=89266
Source/WebCore:
Before this patch, if a replica layer has a descendant replica child, the child
layer does not render the result in the parent layer's surface because
TextureMapperPaintOptions does not keep current surface.
This patch amends that TextureMapperPaintOptions keeps current surface before
calling paintSelfAndChildrenWithReplica recursively, so previous surface could be
restored after paintSelfAndChildrenWithReplica.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
Test: compositing/reflections/animation-inside-reflection.html
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintRecursive):
LayoutTests:
Add a opacity property to two div layers in animation-insiVde-reflection
test.
Texmap has a bug when a transparent reflection layer has another
transparent reflection layer, so two reflection layer in
animation-inside-reflection test have opacity in order to cover Texmap's
bug.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
* compositing/reflections/animation-inside-reflection.html:
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
* platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
* platform/mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/qt/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/qt/compositing/reflections/animation-inside-reflection-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 20:19:35 +0000 (20:19 +0000)]
[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.
Source/WebCore:
Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 19:47:57 +0000 (19:47 +0000)]
Source/Platform: Plumb Scrollbar button dimensions through WebThemeEngine
https://bugs.webkit.org/show_bug.cgi?id=89264
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Rather than making the height of the scrollbar buttons the same as the
width of the scrollbar, delegate to the WebThemeEngine. This allows
matching the Aura theme rather than the standard Windows theme.
* chromium/public/win/WebThemeEngine.h:
(WebKit):
(WebThemeEngine):
Source/WebCore: Plumb Scrollbar button dimensions down to WebThemeEngine
https://bugs.webkit.org/show_bug.cgi?id=89264
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Rather than making the height of the scrollbar buttons the same as the
width of the scrollbar, delegate to the WebThemeEngine. This allows
matching the Aura theme rather than the standard Windows theme.
No new tests, as bounds are overridden for DRT.
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
Source/WebKit/chromium: Plumb Scrollbar button dimensions down to WebThemeEngine
https://bugs.webkit.org/show_bug.cgi?id=89264
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Rather than making the height of the scrollbar buttons the same as the
width of the scrollbar, delegate to the WebThemeEngine. This allows
matching the Aura theme rather than the standard Windows theme.
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getThemePartSize):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 25 Jun 2012 19:33:07 +0000 (19:33 +0000)]
Fast path for simple transform parsing
https://bugs.webkit.org/show_bug.cgi?id=89898
Reviewed by Anders Carlsson.
When manipulating transforms using script, the transform value parsing can show up in profiles pretty heavily
(up 4% in some cases). We can optimize it easily by implementing a fast path that does not spin up the full CSS
parser, like we already do for several other common value types.
The patch implements a fast path for transform(), transformX/Y/Z() and transform3D(). It speeds up parsing by >5x.
* css/CSSParser.cpp:
(WebCore):
(WebCore::parseTransformArguments):
(WebCore::parseTransformValue):
(WebCore::CSSParser::parseValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 19:04:11 +0000 (19:04 +0000)]
Remove unused static function shadowFor
https://bugs.webkit.org/show_bug.cgi?id=89824
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-25
Reviewed by Daniel Bates.
shadowFor is not used anymore after r117796. No behaviour changes.
* dom/TreeScopeAdopter.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 18:56:20 +0000 (18:56 +0000)]
Remove unused constant timeWithoutMouseMovementBeforeHidingControls
https://bugs.webkit.org/show_bug.cgi?id=89823
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-25
Reviewed by Daniel Bates.
After r87692, timeWithoutMouseMovementBeforeHidingControls is not used anymore.
* html/HTMLMediaElement.cpp:
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 18:49:38 +0000 (18:49 +0000)]
[Chromium] RenderPass textures are evicted at the end of every frame
https://bugs.webkit.org/show_bug.cgi?id=89786
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-25
Reviewed by Adrienne Walker.
Source/WebCore:
Removed calls to TextureManager::reduceMemoryToLimit inside
finishDrawingFrame() method.
Added unit tests to verify new behavior.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finishDrawingFrame):
Source/WebKit/chromium:
Added unit tests to verify large textures are staying in memory
and available for render pass optimization.
* tests/CCLayerTreeHostImplTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Mon, 25 Jun 2012 18:05:13 +0000 (18:05 +0000)]
Missing implementation of textInputController.setComposition() causes bot redness
https://bugs.webkit.org/show_bug.cgi?id=89845
* platform/mac/Skipped: Skip fast/forms/input-set-composition-scroll.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Mon, 25 Jun 2012 18:01:42 +0000 (18:01 +0000)]
[EFL] Implement Network Information API
https://bugs.webkit.org/show_bug.cgi?id=87067
Reviewed by Kenneth Rohde Christiansen.
.:
* Source/cmake/FindEFL.cmake: Find eeze library in build system.
Source/WebKit:
* PlatformEfl.cmake: Add dependency of eeze library.
Source/WebKit/efl:
Implement NetworkInfoClientEfl.cpp using eeze library. However, this patch only
supports this feature on ethernet interface.
* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore):
(WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
* WebCoreSupport/NetworkInfoClientEfl.h:
(NetworkInfoClientEfl):
Tools:
* efl/jhbuild.modules: Add eeze library dependency.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 25 Jun 2012 17:47:44 +0000 (17:47 +0000)]
[GTK] Add graphviz debug output for the gstreamer video pipeline.
https://bugs.webkit.org/show_bug.cgi?id=89660
Patch by Allan Xavier <allan.xavier@undefinedltd.co.uk> on 2012-06-25
Reviewed by Martin Robinson.
Dump the current video pipeline as a graphviz DOT file when the
pipeline state changes or when an error occours.
No new tests as the change is only useful for debugging.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc