platform/upstream/mesa.git
17 months agodocs: add pipeline library support for tu
Mike Blumenkrantz [Mon, 27 Feb 2023 16:27:14 +0000 (11:27 -0500)]
docs: add pipeline library support for tu

Acked-by: Connor Abbott <cwabbott0@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21560>

17 months agoRevert "venus: temporarily redirect VkDrmFormatModifierPropertiesListEXT to "2" variant"
Ryan Neph [Wed, 15 Feb 2023 22:37:32 +0000 (14:37 -0800)]
Revert "venus: temporarily redirect VkDrmFormatModifierPropertiesListEXT to "2" variant"

No longer need to redirect, since the renderer should use the fixed
decoder for VkDrmFormatModifierPropertiesListEXT::drmFormatModifierCount
by now.

This reverts commit 525b8c582f2e8e3e8f12589c1d384d683fee5dc4.

Signed-off-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21395>

17 months agovenus: update venus-protocol headers to fix WA1
Ryan Neph [Sat, 11 Feb 2023 00:45:21 +0000 (16:45 -0800)]
venus: update venus-protocol headers to fix WA1

Follow-up to previous commit, this time to fix encoding/decoding for
VkDrmFormatModifierPropertiesListEXT::drmFormatModifierCount. Fixes a
workaround (WA1) in the venus-protocol.

Signed-off-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21395>

17 months agonir/lower_blend: Don't dereference null
Alyssa Rosenzweig [Mon, 27 Feb 2023 00:15:48 +0000 (19:15 -0500)]
nir/lower_blend: Don't dereference null

If a dual source blend colour is never written, src1 will be null and it will be
invalid to dereference it. src1 is dereferenced both for the f2fN instruction
but also if a dual blend factor is used... even if the latter isn't strictly
valid, segfaulting in the NIR pass seems a lot meaner than blending with zero.

The referenced commit hosed Asahi, causing anything that used blending to crash.
Panfrost is unaffected since it always supplies a dual colour due to our crude
construction of blend shaders.

Fixes: 83130165437 ("nir/lower_blend: Consume dual stores")
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21544>

17 months agoaco: always update orig_names in get_reg_phi()
Rhys Perry [Thu, 23 Feb 2023 17:09:40 +0000 (17:09 +0000)]
aco: always update orig_names in get_reg_phi()

No idea why this wasn't done if pc.first was a renamed temporary.

Fixes navi10 RA validation error with
dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_geom_buffers1_sets3_imm_samplers

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8349
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21501>

17 months agoradv: split linker script for android since it requires different symbols
Eric Engestrom [Fri, 24 Feb 2023 10:57:24 +0000 (10:57 +0000)]
radv: split linker script for android since it requires different symbols

Fixes: 4956f6d0bf477568731f ("radv: Add Android module info to linker script.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8338
Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21518>

17 months agomeson: Use sse2_arg and sse2_args to replace usage of c and c_sse2_args
Yonggang Luo [Fri, 17 Feb 2023 06:45:08 +0000 (14:45 +0800)]
meson: Use sse2_arg and sse2_args to replace usage of c and c_sse2_args

And now c_sse2_arg and c_sse2_args are remvoed

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21375>

17 months agomeson: Split sse2_arg and sse2_args out of c_cpp_args
Yonggang Luo [Fri, 17 Feb 2023 06:24:20 +0000 (14:24 +0800)]
meson: Split sse2_arg and sse2_args out of c_cpp_args

This is used to replace c_sse2_arg and c_sse2_args in latter commits

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21375>

17 months agomeson: When sse2 enabled, both c and cpp using sse2 options
Yonggang Luo [Fri, 17 Feb 2023 06:25:54 +0000 (14:25 +0800)]
meson: When sse2 enabled, both c and cpp using sse2 options

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21375>

17 months agovulkan/wsi/x11: make 4 image minimum for xwayland driver-specific
Mike Blumenkrantz [Tue, 21 Feb 2023 13:42:58 +0000 (08:42 -0500)]
vulkan/wsi/x11: make 4 image minimum for xwayland driver-specific

this avoids adding extra frames of latency to drivers that don't need
it

Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21447>

17 months agovulkan/wsi: switch to using an options struct for last param
Mike Blumenkrantz [Tue, 21 Feb 2023 13:40:23 +0000 (08:40 -0500)]
vulkan/wsi: switch to using an options struct for last param

this makes adding values easier since the drivers won't need to be updated

Acked-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21447>

17 months agoaco: use and swizzle mask in dpp quad perm
Georg Lehmann [Thu, 23 Feb 2023 10:35:13 +0000 (11:35 +0100)]
aco: use and swizzle mask in dpp quad perm

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21412>

17 months agoaco/gfx11: use dpp_row_xmask and dpp_row_share
Georg Lehmann [Sun, 19 Feb 2023 21:09:01 +0000 (22:09 +0100)]
aco/gfx11: use dpp_row_xmask and dpp_row_share

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21412>

17 months agoaco: use v_permlane(x)16_b32 for masked swizzle
Georg Lehmann [Sun, 19 Feb 2023 15:49:02 +0000 (16:49 +0100)]
aco: use v_permlane(x)16_b32 for masked swizzle

Should be cheaper than ds_swizzle.

Totals from 8 (0.01% of 134913) affected shaders:
CodeSize: 16316 -> 16388 (+0.44%)
Instrs: 3088 -> 3086 (-0.06%)
Latency: 49558 -> 49508 (-0.10%)
InvThroughput: 9180 -> 9198 (+0.20%)
Copies: 376 -> 384 (+2.13%)

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21412>

17 months agoamd: d16 uses rtz conversion for 32bit float
Georg Lehmann [Sat, 18 Feb 2023 12:40:22 +0000 (13:40 +0100)]
amd: d16 uses rtz conversion for 32bit float

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21404>

17 months agoamd: don't use d16 for integer loads
Georg Lehmann [Sat, 18 Feb 2023 12:38:46 +0000 (13:38 +0100)]
amd: don't use d16 for integer loads

D16 saturates to min/max instead of just truncating.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21404>

17 months agonir: change 16bit image dest folding option to per type
Georg Lehmann [Sat, 18 Feb 2023 12:37:48 +0000 (13:37 +0100)]
nir: change 16bit image dest folding option to per type

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21404>

17 months agoradv: enable primitiveUnderestimation on GFX9+
Samuel Pitoiset [Tue, 21 Feb 2023 15:46:41 +0000 (16:46 +0100)]
radv: enable primitiveUnderestimation on GFX9+

It's passing dEQP-VK.rasterization.conservative.underestimate.* on
NAVI21.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21459>

17 months agoradv: set MSAA_NUM_SAMPLES to 0 for underestimate rasterization
Samuel Pitoiset [Wed, 22 Feb 2023 08:50:15 +0000 (09:50 +0100)]
radv: set MSAA_NUM_SAMPLES to 0 for underestimate rasterization

Based on PAL.

Fixes
dEQP-VK.rasterization.conservative.underestimate.samples_*.triangles.normal.test.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21459>

17 months agoradv: stop setting ENABLE_POSTZ_OVERRASTERIZATION to 1
Samuel Pitoiset [Wed, 22 Feb 2023 07:49:12 +0000 (08:49 +0100)]
radv: stop setting ENABLE_POSTZ_OVERRASTERIZATION to 1

According to PAL this isn't set.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21459>

17 months agoradv: cleanup radv_emit_{conservative,msaa}_state() functions
Samuel Pitoiset [Wed, 22 Feb 2023 08:47:50 +0000 (09:47 +0100)]
radv: cleanup radv_emit_{conservative,msaa}_state() functions

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21459>

17 months agolavapipe: EXT_image_sliced_view_of_3d
Mike Blumenkrantz [Mon, 13 Feb 2023 17:22:47 +0000 (12:22 -0500)]
lavapipe: EXT_image_sliced_view_of_3d

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21514>

17 months agovulkan/runtime: store parameters of VK_EXT_sliced_view_of_3d
Lionel Landwerlin [Thu, 26 Jan 2023 09:54:42 +0000 (11:54 +0200)]
vulkan/runtime: store parameters of VK_EXT_sliced_view_of_3d

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21514>

17 months agoradv/sqtt: Use code buffer from radv_shader directly instead of copying.
Tatsuyuki Ishi [Fri, 24 Feb 2023 06:56:50 +0000 (15:56 +0900)]
radv/sqtt: Use code buffer from radv_shader directly instead of copying.

The reference-counted radv_shader always outlives the pipeline, so we can
use this buffer directly when dumping code objects to the trace.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21513>

17 months agoradv: Keep shader code ptr in a separately allocated buffer.
Tatsuyuki Ishi [Fri, 24 Feb 2023 09:27:04 +0000 (18:27 +0900)]
radv: Keep shader code ptr in a separately allocated buffer.

RGP traces need a dump of shader code in order to display ISA and
instruction trace. Previously, this was read back from GPU at trace
creation time. However, for future changes that implements upload shader
to invisible VRAM, the upload destination will be a temporary staging
buffer and will be only accessible during shader creation.

To allow dumping in such cases, copy the shader code to a separate buffer
at creation time, if thread tracing is enabled.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21513>

17 months agozink: allow direct memory mapping for any COHERENT+CACHED buffer
Mike Blumenkrantz [Mon, 24 Oct 2022 15:58:13 +0000 (11:58 -0400)]
zink: allow direct memory mapping for any COHERENT+CACHED buffer

some drivers may provide this in heaps that get used by non-staging resources,
so avoid extra copies in that case

unlike the previous attempt at this optimization, this utilizes the screen-based
context for thread-safe transfers, which should avoid races/crashes

fix #8171

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21452>

17 months agozink: add locking for zink_screen::copy_context and defer creation
Mike Blumenkrantz [Tue, 21 Feb 2023 15:11:15 +0000 (10:11 -0500)]
zink: add locking for zink_screen::copy_context and defer creation

the copy context isn't always used, so this allows its creation to
be deferred and potentially save a bunch of memory

also add locking for multi-context thread safety

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21452>

17 months agozink: avoid adding ubo/ssbo bindings multiple times for different bitsizes
Mike Blumenkrantz [Fri, 24 Feb 2023 15:32:10 +0000 (10:32 -0500)]
zink: avoid adding ubo/ssbo bindings multiple times for different bitsizes

these are valid variables, but the descriptor binding needs to be unique

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agozink: simplify/rework image typing in ntv
Mike Blumenkrantz [Fri, 24 Feb 2023 15:22:52 +0000 (10:22 -0500)]
zink: simplify/rework image typing in ntv

the array approach was broken if a shader contained both bindless
and non-bindless resources, whereas a hash table is simpler and can
handle both images and samplers

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agozink: delete unused emit_image param in ntv
Mike Blumenkrantz [Fri, 24 Feb 2023 15:10:17 +0000 (10:10 -0500)]
zink: delete unused emit_image param in ntv

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agozink: fix bindless texture barrier generation
Mike Blumenkrantz [Fri, 24 Feb 2023 15:04:25 +0000 (10:04 -0500)]
zink: fix bindless texture barrier generation

whenever I redid barriers I forgot to handle bindless textures,
which meant they weren't getting barriers added

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agozink: rework descriptor unbind params to use is_compute directly
Mike Blumenkrantz [Fri, 24 Feb 2023 16:07:41 +0000 (11:07 -0500)]
zink: rework descriptor unbind params to use is_compute directly

much simpler

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agozink: fix shader read access removal for barrier generation
Mike Blumenkrantz [Fri, 24 Feb 2023 16:03:57 +0000 (11:03 -0500)]
zink: fix shader read access removal for barrier generation

barrier access is based on total binds per gfx/compute, not per stage

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agozink: delete dead uniform variables
Mike Blumenkrantz [Thu, 23 Feb 2023 21:25:17 +0000 (16:25 -0500)]
zink: delete dead uniform variables

this just obfuscate nir, so delete them now

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21522>

17 months agoagx: Lower sampler LOD bias
Alyssa Rosenzweig [Mon, 13 Feb 2023 01:21:31 +0000 (20:21 -0500)]
agx: Lower sampler LOD bias

G13 does not support sampler descriptor LOD biasing, so this needs to be lowered
to shader code for APIs that require this functionality. Add an option to do
this lowering while doing our other backend texture lowerings. This generates
lod_bias_agx texture instructions which the driver is expected to lower
according to its binding model.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21276>

17 months agoasahi: Lower lod_bias_agx to uniform registers
Alyssa Rosenzweig [Mon, 13 Feb 2023 01:20:28 +0000 (20:20 -0500)]
asahi: Lower lod_bias_agx to uniform registers

Track the LOD bias of samplers and upload them at draw time to uniform
registers. This could be optimized in the future.

Vulkan will probably want to pull from a descriptor set instead.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21276>

17 months agonir: Add nir_texop_lod_bias_agx
Alyssa Rosenzweig [Mon, 13 Feb 2023 01:19:41 +0000 (20:19 -0500)]
nir: Add nir_texop_lod_bias_agx

Add a new texture opcode that returns the LOD bias of the sampler. This will be
used on AGX to lower sampler LOD bias to txb and friends. This needs to be a
texture op (and not a new intrinsic) to handle both bindless and bindful
samplers across GL and Vulkan in a uniform way.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21276>

17 months agoac/llvm,radeonsi: lower fbfetch in abi
Qiang Yu [Sat, 11 Feb 2023 11:11:08 +0000 (19:11 +0800)]
ac/llvm,radeonsi: lower fbfetch in abi

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21436>

17 months agoradeonsi: add num_component param to load_internal_binding
Qiang Yu [Fri, 10 Feb 2023 06:51:41 +0000 (14:51 +0800)]
radeonsi: add num_component param to load_internal_binding

Prepare for different component number, ie. 8 when image desc.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21436>

17 months agoac/llvm,radeonsi: lower nir_load_barycentric_at_sample in abi
Qiang Yu [Fri, 10 Feb 2023 03:15:46 +0000 (11:15 +0800)]
ac/llvm,radeonsi: lower nir_load_barycentric_at_sample in abi

RADV already did this in radv_lower_fs_intrinsics().

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21436>

17 months agonir: lower to fragment_mask_fetch/load_amd with EQAA correctly
Marek Olšák [Fri, 24 Feb 2023 20:40:47 +0000 (15:40 -0500)]
nir: lower to fragment_mask_fetch/load_amd with EQAA correctly

Fixes: 194add2c232 ("nir: lower image add lower_to_fragment_mask_load_amd option")
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Signed-off-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21436>

17 months agonir/lower_blend: Consume dual stores
Alyssa Rosenzweig [Mon, 20 Feb 2023 04:08:58 +0000 (23:08 -0500)]
nir/lower_blend: Consume dual stores

Now that we're working on lowered I/O, passing in the dual source blend colour
via a sideband doesn't make any sense. The primary source blend colours are
implicitly passed in as the sources of store_output intrinsics; likewise, we
should get dual source blend colours from their respective stores. And since
dual colours are only needed by blending, we can delete the stores as we go.
That means nir_lower_blend now provides an all-in-one software lowering of dual
source blending with no driver support needed! It even works for 8 dual-src
render targets, but I don't have a use case for that.

The only tricky bit here is making sure we are robust against different orders
of store_output within the exit block. In particular, if we naively lower

   x = ...
   primary color = x
   y = ...
   dual color = y

we end up emitting uses of y before it has been defined, something like

   x = ...
   primary color = blend(x, y)
   y = ...

Instead, we remove dual stores and sink blend stores to the bottom of the block,
so we end up with the correct

   x = ...
   y = ...
   primary color = blend(x, y)

lower_io_to_temporaries ensures that the stores will be in the same (exit)
block, so we don't need to sink further than that ourselves.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21426>

17 months agopanfrost: Use proper locations in blend shaders
Alyssa Rosenzweig [Mon, 6 Feb 2023 15:49:41 +0000 (10:49 -0500)]
panfrost: Use proper locations in blend shaders

Rather than always blending to FRAG_RESULT_DATA0. This removes silly special
cases in the compiler.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21426>

17 months agointel/rt: Fix L3 bank performance bottlenecks due to SW stack stride alignment.
Francisco Jerez [Wed, 19 Oct 2022 23:13:24 +0000 (16:13 -0700)]
intel/rt: Fix L3 bank performance bottlenecks due to SW stack stride alignment.

Power-of-two SW stack sizes are prone to causing collisions in the
hashing function used by the L3 to map memory addresses to banks,
which can cause stack accesses from most DSSes to bottleneck on a
single L3 bank.  Fix it by padding the SW stack stride by a single
cacheline if it was a power of two.  This has been reported by Felix
DeGrood to improve Quake2 RTX performance by ~30% on DG2-512 in
combination with other RT patches Lionel Landwerlin has been working
on.

Many thanks to Felix DeGrood for doing much of the legwork and
providing several iterations of Q2RTX performance counter dumps which
eventually prompted me to consider the hash collision theory and
motivated this patch, and for providing additional performance counter
dumps confirming that there is no longer an appreciable imbalance in
traffic across L3 banks after this change.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21461>

17 months agodocs: Fix formatting for RMV tracing docs
Friedrich Vock [Thu, 23 Feb 2023 19:00:23 +0000 (20:00 +0100)]
docs: Fix formatting for RMV tracing docs

Fixes: e1cbff22 ("docs: Add short documentation about RMV tracing variables")
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21502>

17 months agomeson: print c_cpp_args
David Heidelberg [Sun, 26 Feb 2023 15:45:18 +0000 (16:45 +0100)]
meson: print c_cpp_args

Acked-by: Dylan Baker <dylan@pnwbakers.com>
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21539>

17 months agoradv/rt: Pre shift cull_mask
Konstantin Seurer [Sat, 25 Feb 2023 11:15:57 +0000 (12:15 +0100)]
radv/rt: Pre shift cull_mask

This removes the need for masking the instance mask.

Totals from 14 (14.43% of 97) affected shaders:
CodeSize: 378696 -> 378308 (-0.10%); split: -0.12%, +0.02%
Instrs: 70854 -> 70855 (+0.00%); split: -0.02%, +0.02%
Latency: 1651235 -> 1651215 (-0.00%); split: -0.00%, +0.00%
InvThroughput: 336290 -> 336285 (-0.00%); split: -0.00%, +0.00%
Copies: 9915 -> 9923 (+0.08%); split: -0.03%, +0.11%
PreSGPRs: 890 -> 896 (+0.67%)

 PERCENTAGE DELTAS Shaders  CodeSize   Instrs   Latency  InvThroughput   Copies   PreSGPRs
 q2rtx-pipe        48        -0.02%    -0.02%    -0.00%      -0.00%      -0.03%      .
 q2rtx_1           49        -0.10%    +0.02%    +0.00%      +0.00%      +0.14%    +0.31%
 -------------------------------------------------------------------------------------------
 All affected      14        -0.10%    +0.00%    -0.00%      -0.00%      +0.08%    +0.67%
 -------------------------------------------------------------------------------------------
 Total             97        -0.06%    +0.00%    -0.00%      -0.00%      +0.06%    +0.16%

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21530>

17 months agopvr: remove duplicate define
Frank Binns [Thu, 23 Feb 2023 09:58:29 +0000 (09:58 +0000)]
pvr: remove duplicate define

The same define appears a few lines above.

Signed-off-by: Frank Binns <frank.binns@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21495>

17 months agopvr: stop restricting the compiler to the Sascha Willems triangle demo
Frank Binns [Wed, 22 Feb 2023 22:42:14 +0000 (22:42 +0000)]
pvr: stop restricting the compiler to the Sascha Willems triangle demo

Do this by removing the compatibility table and only using hard coded shaders
when present. The hard coded shaders, along with the hard coding framework
itself, can be dropped once the compiler is capable of compiling the hard coded
shaders. In the meantime we don't want to risk regressing things that we know
work because we temporarily can't test them.

This restriction is being dropped now as the new compiler framework has been
merged and we want to make use of it so it can be developed further.

Signed-off-by: Frank Binns <frank.binns@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21495>

17 months agod3d12: Track up to 16 active context resource states locally in d3d12_bo
Giancarlo Devich [Sat, 25 Feb 2023 00:20:21 +0000 (16:20 -0800)]
d3d12: Track up to 16 active context resource states locally in d3d12_bo

After 16 entries, we fall back to the previous logic that used a hash
map to link the resource's state per context.

Preventing hash map churn by cheaply tracking up to 16 context's worth
of states per resource significantly reduces CPU cost in
find_or_create_state_entry

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21528>

17 months agod3d12: Assign up to 16 simultaneously active contexts unique IDs
Giancarlo Devich [Sat, 25 Feb 2023 00:19:16 +0000 (16:19 -0800)]
d3d12: Assign up to 16 simultaneously active contexts unique IDs

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21528>

17 months agod3d12: Move d3d12_context_state_table_entry to d3d12_resource_state.h
Giancarlo Devich [Sat, 25 Feb 2023 00:17:43 +0000 (16:17 -0800)]
d3d12: Move d3d12_context_state_table_entry to d3d12_resource_state.h

Also renamed desired_resource_state to d3d12_desired_resource_state,
since it's also in the header now.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21528>

17 months agotu/kgsl: Propagate tu_physical_device_init() errors
Rob Clark [Fri, 24 Feb 2023 22:58:32 +0000 (14:58 -0800)]
tu/kgsl: Propagate tu_physical_device_init() errors

Should fix dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agotu+meson: Re-work KMD selection
Rob Clark [Fri, 17 Feb 2023 19:51:49 +0000 (11:51 -0800)]
tu+meson: Re-work KMD selection

Now that turnip can support multiple kernel-mode drivers in a single
build, re-work the meson option to have a single list of KMDs, rather
than special options to enable kgsl for turnip or virtio for gallium.

It is temporarily a bit awkward as gallium does not yet support kgsl
and turnip does not yet support virtio.  But both of those are planned
or in-progress, so long term a single list is the most sensible option.

TODO freedreno/drm support to build with only virtio support.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: Refactor device loading
Rob Clark [Fri, 17 Feb 2023 19:10:24 +0000 (11:10 -0800)]
turnip: Refactor device loading

1) Allow the two different entrypoints for drm vs non-drm (kgsl) to
   coexist.
2) Split the generic drm related device initialization from the msm
   specifics.  This will simplify adding support for additional drm
   based kernel mode drivers (ie. virtgpu)

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: Handle kgsl vs drm specifics at runtime
Rob Clark [Fri, 17 Feb 2023 18:13:41 +0000 (10:13 -0800)]
turnip: Handle kgsl vs drm specifics at runtime

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: Move QueueWaitIdle entrypoint to kgsl
Rob Clark [Fri, 17 Feb 2023 18:07:56 +0000 (10:07 -0800)]
turnip: Move QueueWaitIdle entrypoint to kgsl

Handle in the same way as other kgsl specific entrypoints.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: Allow knl backend specific entrypoints
Rob Clark [Fri, 17 Feb 2023 17:41:10 +0000 (09:41 -0800)]
turnip: Allow knl backend specific entrypoints

Because kgsl sync primitives are not drm_syncobj, the kgsl kernel
support needs the ability to patch in it's own entrypoints related
to fences, etc.  The current entrypoint table magic using weak syms
won't work if we are building both kgsl and drm support into one
binary, so switch to runtime patching in the kgsl specific entry-
points.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: Split out vfuncs for kernel interface
Rob Clark [Thu, 16 Feb 2023 21:56:14 +0000 (13:56 -0800)]
turnip: Split out vfuncs for kernel interface

To allow support for multiple KMD's to coexist, split out vfuncs.  This
doesn't quite *yet* let us have kgsl and msm coexist, because of the
different vk entrypoints needed by the kgsl backend.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: drm code-motion
Rob Clark [Thu, 16 Feb 2023 21:22:47 +0000 (13:22 -0800)]
turnip: drm code-motion

Move a few functions around in prep for next commit.  Only code-motion.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoturnip: Move things to prep for multi-kernel support
Rob Clark [Thu, 16 Feb 2023 19:43:20 +0000 (11:43 -0800)]
turnip: Move things to prep for multi-kernel support

The end goal is a single build that supports kgsl (non-drm) as well
as msm and virtgpu (both drm).  First lets move around some files to
accomodate that.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agovk/runtime: Allow enumerate and try_create_for_drm to coexist
Rob Clark [Thu, 16 Feb 2023 19:24:00 +0000 (11:24 -0800)]
vk/runtime: Allow enumerate and try_create_for_drm to coexist

For drivers that can support both drm and non-drm kernel mode drivers it
is useful to be able to provide both entrypoints.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21394>

17 months agoci/freedreno: add flaking KHR-GL45.buffer_storage.map_persistent_dispatch
David Heidelberg [Sat, 25 Feb 2023 15:38:24 +0000 (16:38 +0100)]
ci/freedreno: add flaking KHR-GL45.buffer_storage.map_persistent_dispatch

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21531>

17 months agodocs: update link to intel optimization reference manual
Erik Faye-Lund [Tue, 21 Feb 2023 14:05:16 +0000 (15:05 +0100)]
docs: update link to intel optimization reference manual

Seems this document has moved since last we updated this link. But
instead of chasing the exact CDN link, let's link to the document on
Intel's website. There's both a download-link there, as well as the
ability to read the document online.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21448>

17 months agoci: correct typo in name of linkcheck job
Erik Faye-Lund [Tue, 21 Feb 2023 14:08:56 +0000 (15:08 +0100)]
ci: correct typo in name of linkcheck job

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21448>

17 months agointel: use c_see2_arg instead of explicit -msse2
David Heidelberg [Thu, 16 Feb 2023 21:17:02 +0000 (22:17 +0100)]
intel: use c_see2_arg instead of explicit -msse2

This allows us to also inherit `-mfpmath=sse` added in previous commit.

Acked-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21371>

17 months agointel: enable -mfpmath=sse on x86
David Heidelberg [Thu, 16 Feb 2023 21:11:50 +0000 (22:11 +0100)]
intel: enable -mfpmath=sse on x86

It's not enabled by default until `-msse2` and -ffast-math is passed.
We pass only the `-msse2`. Let's align it with main `meson.build`.

See: https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html (-mfpmath).

Acked-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21371>

17 months agor600/sfn: Fix minimum required registers
Gert Wollny [Fri, 24 Feb 2023 16:27:30 +0000 (17:27 +0100)]
r600/sfn: Fix minimum required registers

Don't count the local registers, just the arrays, because local
registers might be renamed during register allocation.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8100

Fixes: 9fd9f3cd10cf58549f850aeca9103d8cca5a5f81
   r600/sfn: Set minimum required registers based on array allocation

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21523>

17 months agoradv/rt: Merge cull_mask and flags
Konstantin Seurer [Wed, 22 Feb 2023 16:48:23 +0000 (17:48 +0100)]
radv/rt: Merge cull_mask and flags

Since cull_mask is only one byte, we can trivially store it in the same
register as the flags. This leaves us with a 2% performance gain in
Quake II RTX:

Totals from 7 (14.00% of 50) affected shaders:
VGPRs: 720 -> 688 (-4.44%)
CodeSize: 213052 -> 212980 (-0.03%); split: -0.05%, +0.02%
MaxWaves: 67 -> 70 (+4.48%)
Instrs: 39429 -> 39394 (-0.09%); split: -0.15%, +0.06%
Latency: 1096258 -> 1096943 (+0.06%); split: -0.05%, +0.11%
InvThroughput: 230661 -> 222963 (-3.34%); split: -3.42%, +0.08%
VClause: 1208 -> 1206 (-0.17%); split: -0.25%, +0.08%
Copies: 5321 -> 5269 (-0.98%); split: -1.22%, +0.24%
Branches: 1903 -> 1902 (-0.05%)
PreVGPRs: 650 -> 645 (-0.77%)

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21470>

17 months agonir: Add cull_mask_and_flags_amd intrinsic
Konstantin Seurer [Wed, 22 Feb 2023 16:47:58 +0000 (17:47 +0100)]
nir: Add cull_mask_and_flags_amd intrinsic

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21470>

17 months agoanv: remove assert typed write support when using NULL surface
Lionel Landwerlin [Fri, 17 Feb 2023 12:31:00 +0000 (14:31 +0200)]
anv: remove assert typed write support when using NULL surface

A number of apps hit this assert in debug mode.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21382>

17 months agoci: uprev virglrenderer
Ryan Neph [Thu, 23 Feb 2023 17:00:12 +0000 (09:00 -0800)]
ci: uprev virglrenderer

Update virglrenderer to bring in venus protocol fixes described in
https://gitlab.freedesktop.org/olv/venus-protocol/-/issues/4.

Signed-off-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21496>

17 months agozink: fix build with -Dvulkan-beta=true
Philipp Zabel [Thu, 23 Feb 2023 14:54:15 +0000 (15:54 +0100)]
zink: fix build with -Dvulkan-beta=true

Fix a build error with -Dvulkan-beta=true:

  ../src/gallium/drivers/zink/zink_screen.c: In function ‘zink_internal_create_screen’:
  ../src/gallium/drivers/zink/zink_screen.c:2764:20: error: ‘struct zink_device_info’ has no member named ‘have_KHR_portability_subset’
   2764 |    if (screen->info.have_KHR_portability_subset) {
        |                    ^
  ../src/gallium/drivers/zink/zink_screen.c:2765:60: error: ‘struct zink_device_info’ has no member named ‘portability_subset_feats’
   2765 |       screen->have_triangle_fans = (VK_TRUE == screen->info.portability_subset_feats.triangleFans);
        |                                                            ^

Fixes: e02cdb397e62 ("zink: prefer vulkan_core.h over vulkan.h")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21491>

17 months agozink: fix slab allocator sizing
Mike Blumenkrantz [Fri, 24 Feb 2023 20:56:05 +0000 (15:56 -0500)]
zink: fix slab allocator sizing

now that the mem type is passed directly to pb, there have to be enough
slabs to allocate all the mem types (not heaps), so create memoryTypeCount
slabs to allow this

fixes #8369

Fixes: f6d3a5755f6 ("zink: zink_heap isn't 1-to-1 with memoryTypeIndex"
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21526>

17 months agovbo/save: fix possible crash related to fixup_vertex()
Patrick Lerda [Fri, 17 Feb 2023 02:01:37 +0000 (03:01 +0100)]
vbo/save: fix possible crash related to fixup_vertex()

Indeed, buffer_in_ram could be reallocated by fixup_vertex()
which triggers this issue.

For instance, with "piglit/gl-1.0-dlist-materials -auto -fbo":
==28392==ERROR: AddressSanitizer: heap-use-after-free on address 0x607000010024 at pc 0x7f3f416fcf18 bp 0x7f3f33d12800 sp 0x7f3f33d127f8
WRITE of size 4 at 0x607000010024 thread T6
    #0 0x7f3f416fcf17 in _save_Materialfv ../src/mesa/vbo/vbo_save_api.c:1405
    #1 0x7f3f418199de in _mesa_unmarshal_Materialfv src/mapi/glapi/gen/marshal_generated0.c:5006
    #2 0x7f3f413c6863 in glthread_unmarshal_batch ../src/mesa/main/glthread.c:65
    #3 0x7f3f4124d368 in util_queue_thread_func ../src/util/u_queue.c:309
    #4 0x7f3f41391eba in impl_thrd_routine ../src/c11/impl/threads_posix.c:67
    #5 0x7f3f4c619c6b in start_thread glibc-2.35/nptl/pthread_create.c:442
    #6 0x7f3f4c69e1fb in __clone3 (/lib64/libc.so.6+0x10c1fb)

0x607000010024 is located 20 bytes inside of 80-byte region [0x607000010010,0x607000010060)
freed by thread T6 here:
    #0 0x7f3f4f093b48 in __interceptor_realloc (/usr/lib64/libasan.so.6+0xb1b48)
    #1 0x7f3f416e5b0c in grow_vertex_storage ../src/mesa/vbo/vbo_save_api.c:417
    #2 0x7f3f416e69bc in fixup_vertex ../src/mesa/vbo/vbo_save_api.c:1266
    #3 0x7f3f416fb13e in _save_Materialfv ../src/mesa/vbo/vbo_save_api.c:1405
    #4 0x7f3f418199de in _mesa_unmarshal_Materialfv src/mapi/glapi/gen/marshal_generated0.c:5006
    #5 0x7f3f413c6863 in glthread_unmarshal_batch ../src/mesa/main/glthread.c:65
    #6 0x7f3f4124d368 in util_queue_thread_func ../src/util/u_queue.c:309
    #7 0x7f3f41391eba in impl_thrd_routine ../src/c11/impl/threads_posix.c:67
    #8 0x7f3f4c619c6b in start_thread glibc-2.35/nptl/pthread_create.c:442

Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21419>

17 months agoanv: stop tracking color blend state in the pipeline
Iván Briano [Thu, 23 Feb 2023 22:41:54 +0000 (14:41 -0800)]
anv: stop tracking color blend state in the pipeline

Now that all color blend bits are dynamic, emit_cb_state() is doing
almost nothing and half of that is wrong.

In the case that color write enable is dynamic, at the time the pipeline
state is emitted, it sees all the color attachments as having write
disabled and stores the WriteDisabled bit for each channel.
When all dynamic state is flushed, we have the right values already but
the values recorded into the command buffer get ORed with the ones
stored in the pipeline, and so WriteDisabled tag along when they
shouldn't.

Since all disabled color attachments are handled already when dynamic
state is flushed, there's no point in doing so at pipeline creation
time too. And since the only other thing done by emit_cb_state() is
writing three hardcoded values, they might as well be taken care of in
the same place as everything else.

Fixes CTS from the future:
dEQP-VK.pipeline.*.extended_dynamic_state.*.color_blend_equation_*dynamic*
dEQP-VK.pipeline.*.extended_dynamic_state.*.color_blend_all_*

Fixes: fc3fd7c69e8 (anv: dynamic color write mask)

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21509>

17 months agoanv: fix testing for dynamic color blend bits
Iván Briano [Thu, 23 Feb 2023 20:20:56 +0000 (12:20 -0800)]
anv: fix testing for dynamic color blend bits

Fixes: fc3fd7c69e8 (anv: dynamic color write mask)
Fixes: 9dc6bed9a10 (anv: dynamic state for logic op enable)

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21509>

17 months agovulkan: track the right value on CmdSetColorWriteMasks
Iván Briano [Thu, 23 Feb 2023 19:52:58 +0000 (11:52 -0800)]
vulkan: track the right value on CmdSetColorWriteMasks

Fixes: 092be5a3290 ("vulkan: Add more dynamic color blend states")

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21509>

17 months agonir,amd: add and use nir_intrinsic_load_esgs_vertex_stride_amd
Marek Olšák [Mon, 20 Feb 2023 05:50:24 +0000 (00:50 -0500)]
nir,amd: add and use nir_intrinsic_load_esgs_vertex_stride_amd

This will emulate VGT_ESGS_RING_ITEMSIZE, which does the multiplication
for us. It's beneficial to stop setting VGT_ESGS_RING_ITEMSIZE to reduce
context rolls, and also the register will be removed in the future.

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd/gpu_info: add a workaround for SI_FORCE_FAMILY=gfx1100
Marek Olšák [Sun, 19 Feb 2023 05:00:45 +0000 (00:00 -0500)]
amd/gpu_info: add a workaround for SI_FORCE_FAMILY=gfx1100

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd: implement conformant TRUNC_COORD behavior for gfx11
Marek Olšák [Wed, 25 Jan 2023 00:15:35 +0000 (19:15 -0500)]
amd: implement conformant TRUNC_COORD behavior for gfx11

For testing, the conformant behavior can be enabled by setting
conformant_trunc_coord to true manually and running this to enable
the conformant behavior in hw:
    umr -w *.*.regTA_CNTL2 0x40000

The layer index rounding and TRUNC_COORD resetting workarounds can disabled
in the shader compiler.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi/gfx11: change the default of COMPUTE_DISPATCH_INTERLEAVE to 256
Marek Olšák [Tue, 21 Feb 2023 13:04:41 +0000 (08:04 -0500)]
radeonsi/gfx11: change the default of COMPUTE_DISPATCH_INTERLEAVE to 256

This is an internal recommendation.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: don't set PACKET_TO_ONE_PA for line stippling
Marek Olšák [Tue, 21 Feb 2023 07:16:37 +0000 (02:16 -0500)]
radeonsi: don't set PACKET_TO_ONE_PA for line stippling

A hw guy told me this.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: reorganize si_init_depth_surface for better readability
Marek Olšák [Sun, 19 Feb 2023 09:40:59 +0000 (04:40 -0500)]
radeonsi: reorganize si_init_depth_surface for better readability

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: reorganize si_initialize_color_surface for better readability
Marek Olšák [Sun, 19 Feb 2023 09:40:34 +0000 (04:40 -0500)]
radeonsi: reorganize si_initialize_color_surface for better readability

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: reorganize emit_db_render_state and simplify VRS code
Marek Olšák [Sun, 19 Feb 2023 09:39:47 +0000 (04:39 -0500)]
radeonsi: reorganize emit_db_render_state and simplify VRS code

for better readability

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd/registers: only define SPI and COMPUTE registers in the 0xB000 range
Marek Olšák [Sun, 5 Feb 2023 00:06:14 +0000 (19:06 -0500)]
amd/registers: only define SPI and COMPUTE registers in the 0xB000 range

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: don't clamp z_samples to fix Unreal Tournament 99
Marek Olšák [Sat, 18 Feb 2023 09:33:38 +0000 (04:33 -0500)]
radeonsi: don't clamp z_samples to fix Unreal Tournament 99

Fixes: a29218b5 - radeonsi/gfx11: always set MSAA_NUM_SAMPLES=0 for DCC_DECOMPRESS
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8261

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd: query the per-SIMD VGPR counts from the kernel, don't hardcode them
Marek Olšák [Wed, 25 Jan 2023 01:31:19 +0000 (20:31 -0500)]
amd: query the per-SIMD VGPR counts from the kernel, don't hardcode them

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: rename esgs_itemsize -> esgs_vertex_stride
Marek Olšák [Mon, 20 Feb 2023 05:26:15 +0000 (00:26 -0500)]
radeonsi: rename esgs_itemsize -> esgs_vertex_stride

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: correct and clean up obsolete vs_state_bits comments
Marek Olšák [Mon, 20 Feb 2023 05:25:01 +0000 (00:25 -0500)]
radeonsi: correct and clean up obsolete vs_state_bits comments

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: always add 1 to lshs_vertex_stride now that LS_OUT_PATCH_SIZE is gone
Marek Olšák [Mon, 20 Feb 2023 05:22:48 +0000 (00:22 -0500)]
radeonsi: always add 1 to lshs_vertex_stride now that LS_OUT_PATCH_SIZE is gone

LS_OUT_PATCH_SIZE limited the maximum value.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: remove unused VS_STATE_LS_OUT_PATCH_SIZE
Marek Olšák [Mon, 20 Feb 2023 05:13:35 +0000 (00:13 -0500)]
radeonsi: remove unused VS_STATE_LS_OUT_PATCH_SIZE

This became unused when we switched to nir_lower_hs_inputs_to_mem.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: remove a gfx11 check in si_shader_gs (legacy GS)
Marek Olšák [Mon, 20 Feb 2023 04:46:46 +0000 (23:46 -0500)]
radeonsi: remove a gfx11 check in si_shader_gs (legacy GS)

Gfx11 doesn't support legacy GS.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: reformat emit_cb_render_state, create_blend_state, create_rs_state
Marek Olšák [Sun, 19 Feb 2023 09:38:03 +0000 (04:38 -0500)]
radeonsi: reformat emit_cb_render_state, create_blend_state, create_rs_state

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: remove returns from si_emit_global_shader_pointers
Marek Olšák [Sun, 19 Feb 2023 09:05:02 +0000 (04:05 -0500)]
radeonsi: remove returns from si_emit_global_shader_pointers

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd: replace SI_BIG_ENDIAN with UTIL_ARCH_BIG_ENDIAN
Marek Olšák [Sun, 19 Feb 2023 08:51:54 +0000 (03:51 -0500)]
amd: replace SI_BIG_ENDIAN with UTIL_ARCH_BIG_ENDIAN

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd/registers: unify VRS combiner definition names between gfx103 and gfx11
Marek Olšák [Fri, 17 Feb 2023 23:44:29 +0000 (18:44 -0500)]
amd/registers: unify VRS combiner definition names between gfx103 and gfx11

use gfx11 names

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoamd,radeonsi: remove unused LLVM functions
Marek Olšák [Sat, 18 Feb 2023 14:58:50 +0000 (09:58 -0500)]
amd,radeonsi: remove unused LLVM functions

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>

17 months agoradeonsi: disable Smart Access Memory because CPU access has large overhead
Marek Olšák [Sat, 18 Feb 2023 09:51:28 +0000 (04:51 -0500)]
radeonsi: disable Smart Access Memory because CPU access has large overhead

It will be remove completely in the next commit.

Related: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8176

Cc: mesa-stable
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21525>