platform/upstream/libvpx.git
7 years agovp9: Compute source sad for every superblock when partition copy is on.
Jerome Jiang [Thu, 5 Jan 2017 00:19:42 +0000 (16:19 -0800)]
vp9: Compute source sad for every superblock when partition copy is on.

The source sad could be used to copy the partition without going into
choose_partitioning function to speed up vp9 encoding. Computing source
sad takes little time. Speed test on Android and Linux shows little
encoding time gain (less than 1.4%).

Turned off for now since partition copy is turned off.

Change-Id: I61c9d5b8f22329760cb29a4ee30a7f9c232ce8d3

7 years agovp9: Set short circuit to level 3 for VGA for speed 8.
Jerome Jiang [Wed, 4 Jan 2017 19:22:51 +0000 (11:22 -0800)]
vp9: Set short circuit to level 3 for VGA for speed 8.

vp9: Set short circuit to level 3 for VGA for speed 8. Also change the
threshold_32x32 to 5/8*thresholds[1] to improve quality regression
caused to VGA clips.

Change-Id: Ia1590e91e7cb22be78d5b85013387bb1be4272e3

7 years agoMerge "vp9: 1 pass cbr: allow noise estimation down to 360p."
Marco Paniconi [Wed, 4 Jan 2017 17:24:08 +0000 (17:24 +0000)]
Merge "vp9: 1 pass cbr: allow noise estimation down to 360p."

7 years agovp9: 1 pass cbr: allow noise estimation down to 360p.
Marco [Wed, 4 Jan 2017 00:01:05 +0000 (16:01 -0800)]
vp9: 1 pass cbr: allow noise estimation down to 360p.

Also adjust some thresholds for noise level setting.

Change-Id: I7e03d7057ef2061c9447728deb9c6aff5d3da4b7

7 years agovp9: SVC unittests: fix to use y4m source.
Marco [Wed, 21 Dec 2016 20:53:51 +0000 (12:53 -0800)]
vp9: SVC unittests: fix to use y4m source.

Comment out check on buffer underrun, as it currently fails
on some of the svc tests.

Also cast the update of bits_in_buffer_model_, as this can
go negative now due to the buffer underrun.
This fixes the issue in #1352.

BUG=webm:1350
BUG=webm:1352

Change-Id: Ibd4ef23921daf09e5c15b000aca904aa4573599c

7 years agoMerge "Fix for out of range motion vector bug in joint motion search"
Yunqing Wang [Tue, 3 Jan 2017 17:46:15 +0000 (17:46 +0000)]
Merge "Fix for out of range motion vector bug in joint motion search"

7 years agoFix for out of range motion vector bug in joint motion search
Ranjit Kumar Tulabandu [Wed, 21 Dec 2016 09:42:17 +0000 (15:12 +0530)]
Fix for out of range motion vector bug in joint motion search

Clamped the initial mv in vp9_refining_search_8p_c.

BUG=webm:1354

Change-Id: I47d302b350937e3e6e52e95c983b5fb0b4c64fba

7 years agoMerge "Make sub-pixel mv search's return value consistent with the return type"
Yunqing Wang [Thu, 29 Dec 2016 19:16:00 +0000 (19:16 +0000)]
Merge "Make sub-pixel mv search's return value consistent with the return type"

7 years agoMerge "Bug fix to avoid random crashes during ARNR filtering"
Yunqing Wang [Thu, 29 Dec 2016 17:24:24 +0000 (17:24 +0000)]
Merge "Bug fix to avoid random crashes during ARNR filtering"

7 years agoMerge "Remove superfluous conditional on 'shortcut'"
Gabriel Marin [Thu, 29 Dec 2016 06:03:43 +0000 (06:03 +0000)]
Merge "Remove superfluous conditional on 'shortcut'"

7 years agoMake sub-pixel mv search's return value consistent with the return type
Yunqing Wang [Tue, 27 Dec 2016 19:52:39 +0000 (11:52 -0800)]
Make sub-pixel mv search's return value consistent with the return type

For out-of-range cases, returned UINT_MAX instead of INT_MAX in the
sub-pixel mv search to be consistent with the "uint32_t" return type.

Change-Id: I8e206d771228c13d89bafbbe9f14722c8ecc6a7a

7 years agoBug fix to avoid random crashes during ARNR filtering
Ranjit Kumar Tulabandu [Wed, 23 Nov 2016 13:16:44 +0000 (18:46 +0530)]
Bug fix to avoid random crashes during ARNR filtering

The function 'vp9_find_best_sub_pixel_tree_pruned_more' is modified
to return INT_MAX for handling invalid MV cases from UINT32_MAX.

yunqingwang:
patch 3: rebased on top of the tree.
patch 4: The return type of vp9_find_best_sub_pixel_tree* was changed
to uint32_t to fix ubsan warnings. Changing UINT_MAX back to INT_MAX
was not quite right. Patch 4 modified vp9_temporal_filter.c to accept
uint32_t.
(Note: Inconsistency exists in vp9_find_best_sub_pixel_tree*, which
will be fixed in a separate CL.)

Change-Id: Ib1a79dc2aa41ea6335c21669c76883cdbb7e0535

7 years agoMerge "Clean idct 8x8 neon functions"
Linfeng Zhang [Tue, 27 Dec 2016 17:59:27 +0000 (17:59 +0000)]
Merge "Clean idct 8x8 neon functions"

7 years agoRevert "vp9: SVC unittests: fix to use y4m source."
James Zern [Fri, 23 Dec 2016 22:10:13 +0000 (14:10 -0800)]
Revert "vp9: SVC unittests: fix to use y4m source."

This reverts commit f0b491a52405abb1b3dbb6b2c74dd6a4c7a7ddb1.

This change results in unsigned integer overflows (as reported by
-fsanitize=integer) in datarate_test.cc,
for many of --gtest_filter=VP9/DatarateOnePassCbrSvc.OnePassCbrSvc*:
unsigned integer overflow: 167198 - 185560 cannot be represented in type
'unsigned long'

As the encoder didn't change, but the input with the change to
(correctly) use Y4mVideoSource, this revert is merely masking the issue.

BUG=webm:1352

Change-Id: Iecd9a6c83b3fca67c566732a5c92d36193cc2060

7 years agoMerge "vp9: SVC unittests: fix to use y4m source."
Marco Paniconi [Thu, 22 Dec 2016 17:26:41 +0000 (17:26 +0000)]
Merge "vp9: SVC unittests: fix to use y4m source."

7 years agolibs.mk/stress.sh,curl: set --retry to 1
James Zern [Thu, 22 Dec 2016 13:20:55 +0000 (08:20 -0500)]
libs.mk/stress.sh,curl: set --retry to 1

provide some resilience for transient errors

Change-Id: I8db3d4eb5ef3cccc235a8c4c0052199c0ce23a27

7 years agovp9: SVC unittests: fix to use y4m source.
Marco [Wed, 21 Dec 2016 20:53:51 +0000 (12:53 -0800)]
vp9: SVC unittests: fix to use y4m source.

Comment out check on buffer underrun, as it currently fails
on some of the svc tests.

BUG=webm:1350

Change-Id: I73c88b800cdcc06bd2f900f7b7e2a5fd08248065

7 years agoClean idct 8x8 neon functions
Linfeng Zhang [Wed, 21 Dec 2016 22:24:17 +0000 (14:24 -0800)]
Clean idct 8x8 neon functions

BUG=webm:1301

Change-Id: I05f47dca1fddc155c8396e627cfccf6449677307

7 years agovp9: 1 pass vbr: Skip find_predictors in pickmode when source is altref.
Marco [Fri, 16 Dec 2016 00:10:30 +0000 (16:10 -0800)]
vp9: 1 pass vbr: Skip find_predictors in pickmode when source is altref.

When source frame is altref, we only do zero-mv mode, so we can skip
the find_predictors(). No change in compression.
Small speed gain, ~1%.

Only affects 1 pass vbr with lookhead altref, for ytlive with
the macro flag USE_ALTREF_FOR_ONE_PASS on.

Change-Id: I9318c5da8521f017bf54919cd652438b3a6313d1

7 years agoMerge "vp9; Fix to unitest for high noise."
Marco Paniconi [Wed, 21 Dec 2016 19:38:00 +0000 (19:38 +0000)]
Merge "vp9; Fix to unitest for high noise."

7 years agovp9; Fix to unitest for high noise.
Marco [Wed, 21 Dec 2016 18:19:44 +0000 (10:19 -0800)]
vp9; Fix to unitest for high noise.

Source if y4m, and fix comment.

Change-Id: I1eb84977d42dd0f9009c276b56b3fdb03949bfc2

7 years agoMerge "vp9: Add datarate test for denoiser, for high noise case."
Marco Paniconi [Wed, 21 Dec 2016 03:56:10 +0000 (03:56 +0000)]
Merge "vp9: Add datarate test for denoiser, for high noise case."

7 years agovp9: Add datarate test for denoiser, for high noise case.
Marco [Mon, 19 Dec 2016 22:07:49 +0000 (14:07 -0800)]
vp9: Add datarate test for denoiser, for high noise case.

Also breakout the denoiser tests, as the denoiser only
runs for real-time speed >=5.

Change-Id: I921b785860c35e9d1ebfad0833673a98490186c2

7 years agoMerge "vp9: Add feature to copy partition from the last frame."
Jerome Jiang [Tue, 20 Dec 2016 21:46:43 +0000 (21:46 +0000)]
Merge "vp9: Add feature to copy partition from the last frame."

7 years agoRemove superfluous conditional on 'shortcut'
Gabriel Marin [Wed, 14 Dec 2016 19:07:50 +0000 (11:07 -0800)]
Remove superfluous conditional on 'shortcut'

Remove superfluous test. Produces a small improvement in instruction scheduling.
Measured a 1% to 1.5% reduction in execution time for routine vp9_optimize_b
with different compilers.

No change in behavior.

TEST=Verified that encoded files match bit for bit, with and without this
change.
BUG=b/33678225

Change-Id: I2bf248d4c25fc0256147d7a8766ff9108ae9cba3

7 years agoMerge "Add mips msa vp9 intrapred tests"
Kaustubh Raste [Tue, 20 Dec 2016 02:27:07 +0000 (02:27 +0000)]
Merge "Add mips msa vp9 intrapred tests"

7 years agovp9: Add feature to copy partition from the last frame.
Jerome Jiang [Mon, 19 Dec 2016 18:39:04 +0000 (10:39 -0800)]
vp9: Add feature to copy partition from the last frame.

Add feature to copy partition from the last frame.
The copy is only done under certain conditions that SAD is below threshold.
Feature is currently disabled, until threshold is tuned.
Feature will be initially used for Speed 8 (ARM).

Under extreme case of always copying partition for speed 8:
Encode time is reduced by 5.4% on rtc_derf and 7.8% on rtc.
Overall PSNR reduced by 2.1 on rtc_derf and 0.968 on rtc.

Change-Id: I1bcab515af3088e4d60675758f72613c2d3dc7a5

7 years agoMerge "Simplify address arithmetic in vp9_optimize_b"
Gabriel Marin [Mon, 19 Dec 2016 23:25:38 +0000 (23:25 +0000)]
Merge "Simplify address arithmetic in vp9_optimize_b"

7 years agoMerge "vpx_idct32x32_1024_add_neon: quiet uninitialized warning"
James Zern [Mon, 19 Dec 2016 22:39:01 +0000 (22:39 +0000)]
Merge "vpx_idct32x32_1024_add_neon: quiet uninitialized warning"

7 years agoMerge "vp9 denoiser: Fix the logic for re-evaluating zeromv after denoising."
Marco Paniconi [Mon, 19 Dec 2016 21:15:36 +0000 (21:15 +0000)]
Merge "vp9 denoiser: Fix the logic for re-evaluating zeromv after denoising."

7 years agoSimplify address arithmetic in vp9_optimize_b
Gabriel Marin [Wed, 14 Dec 2016 00:22:48 +0000 (16:22 -0800)]
Simplify address arithmetic in vp9_optimize_b

Simplify address arithmetic on token_costs to reduce the number of generated
instructions that are used for address arithmetic inside routine
vp9_optimize_b. It also helps improve instruction scheduling depending on
compiler and optimization level.

Measured a 9.3% reduction in retired instructions and 5.3% reduction in
execution time for this routine with GCC v4.8.4 and optimization flags -O3,
and a reduction of up to 11.6% in execution time with other compilers.

No change in behavior.

TEST=Verified that encoded files match bit for bit, with and without this
change.
BUG=b/33678225

Change-Id: I6098650fb5cd2aa04e014fe6e68ca20761f3a21f

7 years agovpx_idct32x32_1024_add_neon: quiet uninitialized warning
James Zern [Mon, 19 Dec 2016 18:51:59 +0000 (10:51 -0800)]
vpx_idct32x32_1024_add_neon: quiet uninitialized warning

relocate the assignment to 'in' outside of the for loop. this quiets a
spurious warning in visual studio builds since:
86e340c enable vpx_idct32x32_1024_add_neon in hbd builds

+ give the variable a more descriptive name

BUG=webm:1294

Change-Id: I5c3da5c7939621477e0fc0ad3a1b2a3045c5bffd

7 years agovp9: With denoising on, only estimate noise level for higher resolns.
Marco [Sat, 17 Dec 2016 00:01:59 +0000 (16:01 -0800)]
vp9: With denoising on, only estimate noise level for higher resolns.

Allow it for resolns above 640x360 for now.

Change-Id: I087d0d8173f96b316164fdd4a499110ce2e7a233

7 years agovp9 denoiser: Fix the logic for re-evaluating zeromv after denoising.
Marco [Mon, 19 Dec 2016 17:22:44 +0000 (09:22 -0800)]
vp9 denoiser: Fix the logic for re-evaluating zeromv after denoising.

Correctly set interp_filter to SWITCHABLE for INTRA mode.
Also reduce threshold on noise level for re-evaluating zeromv.

Change-Id: Id32c01e193209fb380aa07204f0be3babf29f70a

7 years agoMerge "Clean hbd idct 4x4 neon functions and other"
Linfeng Zhang [Mon, 19 Dec 2016 17:09:26 +0000 (17:09 +0000)]
Merge "Clean hbd idct 4x4 neon functions and other"

7 years agoAdd mips msa vp9 intrapred tests
Kaustubh Raste [Mon, 19 Dec 2016 11:56:17 +0000 (17:26 +0530)]
Add mips msa vp9 intrapred tests

Change-Id: I49b91464a87cad8692f4b1477e45e5f567b4fe87

7 years agoMerge "post proc test: add padding for sse2 tests"
Johann Koenig [Sat, 17 Dec 2016 01:12:34 +0000 (01:12 +0000)]
Merge "post proc test: add padding for sse2 tests"

7 years agoMerge "vp9: Change condition to enable recheck_zeromv_after_denoising."
Marco Paniconi [Fri, 16 Dec 2016 23:53:32 +0000 (23:53 +0000)]
Merge "vp9: Change condition to enable recheck_zeromv_after_denoising."

7 years agovp9: Change condition to enable recheck_zeromv_after_denoising.
Marco [Fri, 16 Dec 2016 19:15:57 +0000 (11:15 -0800)]
vp9: Change condition to enable recheck_zeromv_after_denoising.

For when denoising enabled: change condition to enable
the recheck_zeromv_after_denoising for only very high noise level.
This is causing an issue, so enabling it for very high noise
to effectively shut it off.

Change-Id: Ic40d6025f3f398338cedd270d17c0ccd9a3daa84

7 years agopost proc test: add padding for sse2 tests
Johann [Fri, 16 Dec 2016 22:03:53 +0000 (14:03 -0800)]
post proc test: add padding for sse2 tests

Avoid valgrind warnings for reading out of bounds when the width is not
divisible by 16.

Change-Id: I5670d7cfbbce00874b98cfb7472f99c7936c2c47

7 years agopostproc test: disable new down and across test
Johann [Fri, 16 Dec 2016 20:19:00 +0000 (12:19 -0800)]
postproc test: disable new down and across test

The new test is causing valgrind failures:
[ RUN      ] SSE2/VpxPostProcDownAndAcrossMbRowTest.CheckCvsAssembly/0
==28923== Invalid read of size 16
28923==    at 0x724016: ??? (deblock_sse2.asm:146)

Disable during investigation. The test is new but the code is not.

Change-Id: I5521e5fd48a595e3798b833bf7e3cc97b81c1975

7 years agovp8 : use threading mutex's for tsan only.
Jim Bankoski [Fri, 16 Dec 2016 16:50:55 +0000 (08:50 -0800)]
vp8 : use threading mutex's for tsan only.

To avoid decode performance hit of 2% when running on hyperthreaded
cores.

This patch only uses the mutex's when we are running tsan.

This is safe because 32 bit operations like read and store are atomic
on all the platforms we care about. Tsan warns about race situations,
but in this case either situation ( read occurs before write or write
before read) the worst case is that we go around one extra time in the
loop.  So the ordering doesn't really matter.

That said a few other things have been tried :

for instance as per here:
webrtc/base/atomicops.h#52

In this patch they use:
__atomic_load_n(i, __ATOMIC_ACQUIRE);
__atomic_store_n(i, value, __ATOMIC_RELEASE);

This code works on gcc, clang ( replacing protected write and read), and
avoids tsan errors. Incurring no penalty in performance.  In C11 its
replaced by straight atomic operands.

However there is no equivalent in the visual studio's we support as
int32 on all windows platforms is already atomic.  To avoid tsan like
warnings on windows we'd need to use interlocked exchange and the
end result doesn't gain us any thing.

Change-Id: I2066e3c7f42641ebb23d53feb1f16f23f85bcf59

7 years agoMerge "vp9: Fix to usage of flag USE_ALTREF_FOR_ONE_PASS"
Marco Paniconi [Thu, 15 Dec 2016 19:48:16 +0000 (19:48 +0000)]
Merge "vp9: Fix to usage of flag USE_ALTREF_FOR_ONE_PASS"

7 years agopostproc: neon down and across macroblock filter
Johann [Tue, 13 Dec 2016 00:47:05 +0000 (16:47 -0800)]
postproc: neon down and across macroblock filter

Implement vpx_post_proc_down_and_across_mb_row in NEON.
Runs about 6-7x faster than C.

BUG=webm:1320

Change-Id: Ic5c7d3552a88cfcf999ec5bf2bd46fee460642c2

7 years agovp9: Fix to usage of flag USE_ALTREF_FOR_ONE_PASS
Marco [Wed, 14 Dec 2016 22:08:09 +0000 (14:08 -0800)]
vp9: Fix to usage of flag USE_ALTREF_FOR_ONE_PASS

The flag USE_ALTREF_FOR_ONE_PASS allows for alt-ref lookahead
in 1 pass vbr (from https://chromium-review.googlesource.com/#/c/365498).
This change is to make sure this macro flag only has effect if
the config flag cpi->oxcf.enable_auto_altef is also on.

No change in ytlive encoding, as USE_ALTREF_FOR_ONE_PASS is not
yet enabled.

Change-Id: I1a69681e4a15c5244581a3dab4587fca08f02e0f

7 years agoClean hbd idct 4x4 neon functions and other
Linfeng Zhang [Wed, 14 Dec 2016 18:42:01 +0000 (10:42 -0800)]
Clean hbd idct 4x4 neon functions and other

BUG=webm:1301

Change-Id: I387b7eae716a7df15c691dc6f368b07602df7342

7 years agoChange order of operation to avoid ubsan warnings
Yaowu Xu [Wed, 14 Dec 2016 17:37:14 +0000 (09:37 -0800)]
Change order of operation to avoid ubsan warnings

This commit change an order of operation to avoid left shifts of
negative numbers.

Change-Id: I607c7eb91658c7a5ef397fc1504721d1b10e3dd6

7 years agoMerge "Update idct test code to test 8-bit & high bitdepth simultaneously"
Linfeng Zhang [Wed, 14 Dec 2016 17:05:34 +0000 (17:05 +0000)]
Merge "Update idct test code to test 8-bit & high bitdepth simultaneously"

7 years agoUpdate idct test code to test 8-bit & high bitdepth simultaneously
Linfeng Zhang [Mon, 12 Dec 2016 20:53:22 +0000 (12:53 -0800)]
Update idct test code to test 8-bit & high bitdepth simultaneously

Change-Id: Icc0eb9c0ddf2a13ec832877a089450972134e8ec

7 years agoMerge "Reapply 'Amend and improve VP8 multithreading implementation'"
James Bankoski [Wed, 14 Dec 2016 01:21:49 +0000 (01:21 +0000)]
Merge "Reapply 'Amend and improve VP8 multithreading implementation'"

7 years agoenable vpx_idct32x32_1024_add_neon in hbd builds
James Zern [Wed, 7 Dec 2016 04:52:34 +0000 (20:52 -0800)]
enable vpx_idct32x32_1024_add_neon in hbd builds

BUG=webm:1294

Change-Id: Ibdda54e6d1303b0f73bc7bc71417e4041d7618de

7 years agoReapply 'Amend and improve VP8 multithreading implementation'
Jim Bankoski [Tue, 13 Dec 2016 00:27:21 +0000 (16:27 -0800)]
Reapply 'Amend and improve VP8 multithreading implementation'

Reapply this patch:
ff0107f Amend and improve VP8 multithreading implementation

Amended the patch to add a unit test, and fix an asan error.

BUG=webm:851

Change-Id: I6572c03256169c64e80248bf5a5e99f59a2fc93c

7 years agoCosmetics by unifying dest_stride to stride in idct
Linfeng Zhang [Mon, 12 Dec 2016 23:13:22 +0000 (15:13 -0800)]
Cosmetics by unifying dest_stride to stride in idct

Change-Id: Ie9336a808a3c3592bb4fd5d4ad3839028bfcafba

7 years agoMerge "vp8: adds multithread testing."
James Bankoski [Sat, 10 Dec 2016 00:01:32 +0000 (00:01 +0000)]
Merge "vp8: adds multithread testing."

7 years agoMerge "vp9: Fix to crash in svc code."
Marco Paniconi [Fri, 9 Dec 2016 23:47:01 +0000 (23:47 +0000)]
Merge "vp9: Fix to crash in svc code."

7 years agovp8: adds multithread testing.
Jim Bankoski [Fri, 9 Dec 2016 23:05:59 +0000 (15:05 -0800)]
vp8: adds multithread testing.

The test is disabled because of TSAN errors until we resolve
BUG=webm:851

Change-Id: I0b21c8d815bc1ea365da024b1e2ee5e1fc5715c2

7 years agoMove load_and_transpose to transpose_neon.h
Johann [Fri, 9 Dec 2016 20:54:55 +0000 (12:54 -0800)]
Move load_and_transpose to transpose_neon.h

Allows for use outside the idcts without pulling in idct_neon.h

Change-Id: I4a94c1af3dac3e1b5bc8296ec9eab0ddcc8cfecf

7 years agovp9: Fix to crash in svc code.
Marco [Wed, 7 Dec 2016 17:50:27 +0000 (09:50 -0800)]
vp9: Fix to crash in svc code.

use_base_mv assumes 2x2 scaling, so fix is to shutoff
this feature unless spatial scale factors are 2.

Added svc unittest for 2 spatial layers with 5x5 scaling,
which generates the issue without this fix.

Also fix some settings in svc unittest:
let the speed setting vary (from 5 to 8), and enable static threshold.

BUG=webm:1344

Change-Id: Idfd0a6c633c21b49a0479601506302cfe974e30e

7 years agoMerge "idct16x16_add_neon: fix arm visual studio builds"
James Zern [Fri, 9 Dec 2016 03:19:16 +0000 (03:19 +0000)]
Merge "idct16x16_add_neon: fix arm visual studio builds"

7 years agovp8 multi_res_encoder: Ajust some settings in sample encoder.
Marco [Thu, 8 Dec 2016 23:25:07 +0000 (15:25 -0800)]
vp8 multi_res_encoder: Ajust some settings in sample encoder.

Set #threads to default 1 for all streams, change bit allocaton
for 3 temporal layers, and enable denoiser on middle resolution layer.

Change-Id: I4a57adbfdb2c319002b8f3cf359613842dc00d75

7 years agoidct16x16_add_neon: fix arm visual studio builds
James Zern [Thu, 8 Dec 2016 21:02:30 +0000 (13:02 -0800)]
idct16x16_add_neon: fix arm visual studio builds

after:
2d3d95f enable vpx_idct16x16_256_add_neon in hbd builds

reorder INCLUDEs and fix indent of IF/ENDIFs

remove vpx_config.asm to avoid multiple symbol definitions in windows
builds and shift idct_neon.asm.S to the top to allow use of
CONFIG_VP9_HIGHBITDEPTH in the export list.

Change-Id: I0dacfbae62a6ec8fe4a26940c1a52da2dfad2029

7 years agoMerge "Remove an unused first pass statistic"
Yunqing Wang [Thu, 8 Dec 2016 22:46:44 +0000 (22:46 +0000)]
Merge "Remove an unused first pass statistic"

7 years agoRemove an unused first pass statistic
Yunqing Wang [Wed, 7 Dec 2016 18:00:36 +0000 (10:00 -0800)]
Remove an unused first pass statistic

One of the first pass stats "new_mv_count" is no longer used in VP9,
and is removed. This also makes it easy to implement a multi-threaded
first pass. This change doesn't affect the coding performance, which
has been verified by borg tests.

Change-Id: I4c7c7bf9465fda838eb230814ef0c631c068c903

7 years agoMerge "vp9: Fix some TODOs in svc code."
Marco Paniconi [Wed, 7 Dec 2016 22:06:01 +0000 (22:06 +0000)]
Merge "vp9: Fix some TODOs in svc code."

7 years agoMerge "Update TEST_P(PartialIDctTest, RunQuantCheck)"
Linfeng Zhang [Wed, 7 Dec 2016 21:05:05 +0000 (21:05 +0000)]
Merge "Update TEST_P(PartialIDctTest, RunQuantCheck)"

7 years agoMerge "Update idct NEON optimization to not use narrowing saturating shift"
Linfeng Zhang [Wed, 7 Dec 2016 21:03:21 +0000 (21:03 +0000)]
Merge "Update idct NEON optimization to not use narrowing saturating shift"

7 years agovp9: Fix some TODOs in svc code.
Marco [Wed, 7 Dec 2016 21:02:10 +0000 (13:02 -0800)]
vp9: Fix some TODOs in svc code.

Change-Id: Ie9f441245987ade9dab38af69adf4dd1fb38ca3f

7 years agoMerge "enable vpx_idct16x16_256_add_neon in hbd builds"
James Zern [Wed, 7 Dec 2016 20:26:43 +0000 (20:26 +0000)]
Merge "enable vpx_idct16x16_256_add_neon in hbd builds"

7 years agoUpdate TEST_P(PartialIDctTest, RunQuantCheck)
Linfeng Zhang [Wed, 7 Dec 2016 19:34:00 +0000 (11:34 -0800)]
Update TEST_P(PartialIDctTest, RunQuantCheck)

1. Use correct projections when copying real dct/quant outputs.
2. Remove local random number generator and combine loops.
3. Quantization with minimum allowed step sizes instead of maximum.
   This may generate larger inputs.

Change-Id: I154afc26230c894d564671cff4b8fd5485b69598

7 years agoMerge "vp9: Adjust the weight factor for segment rate cost for aq-mode=3."
Marco Paniconi [Wed, 7 Dec 2016 19:31:13 +0000 (19:31 +0000)]
Merge "vp9: Adjust the weight factor for segment rate cost for aq-mode=3."

7 years agoUpdate idct NEON optimization to not use narrowing saturating shift
Linfeng Zhang [Tue, 22 Nov 2016 22:21:36 +0000 (14:21 -0800)]
Update idct NEON optimization to not use narrowing saturating shift

Change-Id: Iae517017217dbacd638d40fcfeeb0f4bba7b8b8b

7 years agoenable vpx_idct16x16_256_add_neon in hbd builds
James Zern [Tue, 29 Nov 2016 04:20:28 +0000 (20:20 -0800)]
enable vpx_idct16x16_256_add_neon in hbd builds

BUG=webm:1294

Change-Id: Ib421c150b0d29dee0a81390a612bf01a4a28cff1

7 years agoMerge changes Ibad079f2,I7858a0a1
James Zern [Wed, 7 Dec 2016 01:40:28 +0000 (01:40 +0000)]
Merge changes Ibad079f2,I7858a0a1

* changes:
  enable vpx_idct16x16_10_add_neon in hbd builds
  idct16x16,NEON: rm output_stride from pass1 fns

7 years agoenable vpx_idct16x16_10_add_neon in hbd builds
James Zern [Thu, 24 Nov 2016 04:48:00 +0000 (20:48 -0800)]
enable vpx_idct16x16_10_add_neon in hbd builds

BUG=webm:1294

Change-Id: Ibad079f25e673d4f5181961896a8a8333a51e825

7 years agoidct16x16,NEON: rm output_stride from pass1 fns
James Zern [Wed, 30 Nov 2016 03:47:50 +0000 (19:47 -0800)]
idct16x16,NEON: rm output_stride from pass1 fns

vpx_idct16x16_256_add_neon_pass1, vpx_idct16x16_10_add_neon:
this was a constant 8 in all cases meaning the results are stored
contiguously, this allows the number of stores to be reduced.

Change-Id: I7858a0a15a284883ef45c13dfd97c308df9ea09e

7 years agoRefine 8-bit 8x8 idct NEON intrinsics
Linfeng Zhang [Wed, 16 Nov 2016 21:22:50 +0000 (13:22 -0800)]
Refine 8-bit 8x8 idct NEON intrinsics

Change-Id: I4ec4ad1928ec2ed87f596f52f097bc52065278dd

7 years agovp9: Adjust the weight factor for segment rate cost for aq-mode=3.
Marco [Mon, 5 Dec 2016 20:05:35 +0000 (12:05 -0800)]
vp9: Adjust the weight factor for segment rate cost for aq-mode=3.

Use the segment weight factor based on the target (cr->percent_refresh)
if it less than the current estimate (avergae of past usage and target).
Small improvement at low bitrates.

Change-Id: Iba8fd909e203f94458901366d3a991f7ea854d49

7 years agoCheck in vpx_lpf_vertical_4_dual_neon() assembly
Linfeng Zhang [Fri, 7 Oct 2016 00:01:30 +0000 (17:01 -0700)]
Check in vpx_lpf_vertical_4_dual_neon() assembly

This replaces its C version.

Change-Id: Ie39e9324305fdc0fff610ced608a037e44a85a1a

7 years agoMerge changes I4afc130e,Iaa64d23f
James Zern [Fri, 2 Dec 2016 04:01:27 +0000 (04:01 +0000)]
Merge changes I4afc130e,Iaa64d23f

* changes:
  Add high bitdepth 4x4 idct NEON intrinsics
  Update idct x86 intrinsics to not use saturated add and sub

7 years agoAdd high bitdepth 4x4 idct NEON intrinsics
Linfeng Zhang [Tue, 8 Nov 2016 23:20:18 +0000 (15:20 -0800)]
Add high bitdepth 4x4 idct NEON intrinsics

Change-Id: I4afc130effa05b8be2e9f982967216b1beb2ce4b

7 years agoUpdate idct x86 intrinsics to not use saturated add and sub
Linfeng Zhang [Wed, 23 Nov 2016 00:59:17 +0000 (16:59 -0800)]
Update idct x86 intrinsics to not use saturated add and sub

Change-Id: Iaa64d23fdb45ca1f235b0ea57e614516e548eca4

7 years agoidct16x16,NEON,cosmetics: normalize fn signatures
James Zern [Thu, 24 Nov 2016 01:21:26 +0000 (17:21 -0800)]
idct16x16,NEON,cosmetics: normalize fn signatures

+ remove unused parameters from vpx_idct16x16_10_add_neon_pass2

Change-Id: Ie5912a4abdd308fab589380bca054a2e7234a2c4

7 years agoMerge changes Ide6d3994,I164cfcbe
James Zern [Tue, 29 Nov 2016 00:12:45 +0000 (00:12 +0000)]
Merge changes Ide6d3994,I164cfcbe

* changes:
  enable vpx_idct32x32_135_add_neon in hbd builds
  idct_neon: rename load_tran_low_to_s16 -> ...s16q

7 years agoMerge "build/make/Android.mk: correct rtcd template var refs"
James Zern [Mon, 28 Nov 2016 23:39:37 +0000 (23:39 +0000)]
Merge "build/make/Android.mk: correct rtcd template var refs"

7 years agoMerge "svc_test: fix two warnings"
James Bankoski [Mon, 28 Nov 2016 22:27:25 +0000 (22:27 +0000)]
Merge "svc_test: fix two warnings"

7 years agosvc_test: fix two warnings
Jim Bankoski [Mon, 28 Nov 2016 20:53:39 +0000 (12:53 -0800)]
svc_test: fix two warnings

Use of possibly uninitialized variable and missing test initializer.

Change-Id: I2192c81c39ef4239cc11a309850c0ee8781ef17e

7 years agoCosmetic changes to variable names in deblocker tests.
Jerome Jiang [Mon, 28 Nov 2016 18:08:12 +0000 (10:08 -0800)]
Cosmetic changes to variable names in deblocker tests.

Change kExpectedOutput to expected_output in function parameters in
the deblocker test.

Change-Id: I5baf8d1285ac47922950887406c7aa519ddc512a

7 years agobuild/make/Android.mk: correct rtcd template var refs
James Zern [Fri, 25 Nov 2016 01:51:10 +0000 (17:51 -0800)]
build/make/Android.mk: correct rtcd template var refs

the expansion of findstring and rtcd_dep_template_CONFIG_ASM_ABIS needs
to be deferred until the block is parsed as makefile syntax rather than
eval time where rtcd_dep_template_CONFIG_ASM_ABIS will be unset. this
ensures vpx_config.asm is properly created.

Change-Id: I7c38c6c082da78397936467482789dd468adc316

7 years agoMerge changes I6b4cd56e,I88f91b92
James Zern [Thu, 24 Nov 2016 07:22:04 +0000 (07:22 +0000)]
Merge changes I6b4cd56e,I88f91b92

* changes:
  Android.mk,armv7: fix idct_neon.asm.S creation
  build/make/Android.mk: set/use qexec appropriately

7 years agoenable vpx_idct32x32_135_add_neon in hbd builds
James Zern [Wed, 23 Nov 2016 01:47:38 +0000 (17:47 -0800)]
enable vpx_idct32x32_135_add_neon in hbd builds

BUG=webm:1294

Change-Id: Ide6d3994fe01c4320c9d143e6d059b49568048e4

7 years agoidct_neon: rename load_tran_low_to_s16 -> ...s16q
James Zern [Sat, 19 Nov 2016 04:25:17 +0000 (20:25 -0800)]
idct_neon: rename load_tran_low_to_s16 -> ...s16q

BUG=webm:1294

Change-Id: I164cfcbe9bc4511d1d04af9206cf351a0ec2957b

7 years agoMerge changes Icc4ead05,Ib019964b,I3b5fd3b3,Ieedadee2
James Zern [Thu, 24 Nov 2016 03:31:25 +0000 (03:31 +0000)]
Merge changes Icc4ead05,Ib019964b,I3b5fd3b3,Ieedadee2

* changes:
  Update vpx_idct4x4_16_add_neon() to pass SingleExtremeCoeff test
  Refine 8-bit 4x4 idct NEON intrinsics
  Add idct speed test.
  Update partial_idct_test.cc to support high bitdepth

7 years agoMerge "Change C/MSA post proc to match SSE2."
Jerome Jiang [Thu, 24 Nov 2016 01:56:34 +0000 (01:56 +0000)]
Merge "Change C/MSA post proc to match SSE2."

7 years agoMerge "Cover more filter levels in unit tests for post proc."
Jerome Jiang [Thu, 24 Nov 2016 01:56:22 +0000 (01:56 +0000)]
Merge "Cover more filter levels in unit tests for post proc."

7 years agoAndroid.mk,armv7: fix idct_neon.asm.S creation
James Zern [Thu, 24 Nov 2016 00:49:19 +0000 (16:49 -0800)]
Android.mk,armv7: fix idct_neon.asm.S creation

force this to be created before any other .S files. this change
additionally removes the file from the source list as it doesn't need to
be compiled on its own.

Change-Id: I6b4cd56ef6059d08f75f06fb749cddf76e0e165e

7 years agobuild/make/Android.mk: set/use qexec appropriately
James Zern [Thu, 24 Nov 2016 00:46:50 +0000 (16:46 -0800)]
build/make/Android.mk: set/use qexec appropriately

commands are echo'd when V=1; libs.mk depends on this variable as well

Change-Id: I88f91b9260f16686cfccdf6bd3f29d246521b62e

7 years agovp9: Adjust cyclic refresh parameters for low bitrates.
Marco [Tue, 22 Nov 2016 00:37:32 +0000 (16:37 -0800)]
vp9: Adjust cyclic refresh parameters for low bitrates.

Increase the motion threshold and qp-delta for segment#2 boost.
This can increase the frame-drop at low bitrates, but generally
better spatial quality.

Only affects real-time mode with aq-mode=3, at very low bitrates.

Change-Id: I5ccb784667f70d0c27d369806b93b1f93d5605d1

7 years agoMerge "use storage.googleapis for testdata download"
James Zern [Wed, 23 Nov 2016 19:27:20 +0000 (19:27 +0000)]
Merge "use storage.googleapis for testdata download"

7 years agoChange C/MSA post proc to match SSE2.
Jerome Jiang [Sat, 19 Nov 2016 01:11:59 +0000 (17:11 -0800)]
Change C/MSA post proc to match SSE2.

BUG=webm:1321

Change-Id: I719023375dc48cf7d8ed72188853f0f1ccc4ad7f

7 years agoCover more filter levels in unit tests for post proc.
Jerome Jiang [Sat, 19 Nov 2016 01:07:20 +0000 (17:07 -0800)]
Cover more filter levels in unit tests for post proc.

For some filter level, the C/MSA doesn't match SSE2. Part of unit tests
are disabled. They will be re-enabled when C/MSA funcs are fixed.
BUG=webm:1321

Change-Id: Ib16b98b5eecb15d2252aa4ea267b782ee2b27533