platform/upstream/iotivity.git
8 years ago[IOT-1294] Fixed build failure for WITH_RA_IBB flags
George Nash [Mon, 12 Sep 2016 22:42:20 +0000 (15:42 -0700)]
[IOT-1294] Fixed build failure for WITH_RA_IBB flags

When building code with the WITH_RA_IBB=1 the build
would fail with undefined references to code found in the external
code found in extlibs/libstrophe and extlibs/wksxmppxep.

The code was already being built but was not properly linked by the
linker. This commit adds the library paths and libraries needed to
pass the build.

Change-Id: Ia9a1a6c40f6eeed174caaeb428224b97ffb6b59d
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11715
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
8 years agoOptimize stack for Arduino.
Abhishek Sharma [Thu, 18 Aug 2016 06:06:00 +0000 (11:36 +0530)]
Optimize stack for Arduino.

In RI, headeroptions are maintained as array with default size as this macro.
A default 100 headeroptions are too high and results in a structure size of 3KB+.
Moreover any vendor will not add 100 CoAP options.
Also optimized few clonings.

Change-Id: I65860c44ec1ba0c3ef2800a88f27ecad0f483568
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit a40e07bb0634b61a810ff1b0faf2c8b51f53cca2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11777

8 years agoCloud Acl Management for master branch
Jongmin Choi [Tue, 13 Sep 2016 09:30:21 +0000 (18:30 +0900)]
Cloud Acl Management for master branch

Cloud Acl Management moved from cloud-interface to master

Change-Id: Ib35221c06e5dc409dddeed641124d0505fea55a4
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11733
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 7a9211a856c5236420cc84e6aeafdda40a6408a8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11767
Tested-by: Randeep Singh <randeep.s@samsung.com>
8 years agoAdded jni/android implementation for trust cert chain
Sunil Kumar K R [Sat, 27 Aug 2016 13:16:32 +0000 (18:46 +0530)]
Added jni/android implementation for trust cert chain
Provisioning client modified for save and provision cert chain

Change-Id: Iad4b7286ed9076026399d7f7088c4fc39d58c624
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11001
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 98ca376871d06d2ddaf80e0375e4072a3e2f5878)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11721
Tested-by: Randeep Singh <randeep.s@samsung.com>
8 years agoFix windows build in master (2)
Andrii Shtompel [Mon, 12 Sep 2016 12:29:31 +0000 (21:29 +0900)]
Fix windows build in master (2)

[Patch #2] Removed duplicate sqlite parse-config for tizen
[Patch #3] Fix typo that causes tizen build fail

Change-Id: I75f6cadc3120d37357278f556ab44eecd7682a01
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11689
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11719

8 years agoThe wrapper unittest is not required"
nikhil.a [Mon, 12 Sep 2016 10:02:16 +0000 (15:32 +0530)]
The wrapper unittest is not required"

Change-Id: I3646b0da24192b6a34ceef64f2b4fd602a9a99c8
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11675
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agofix warning caleadapter and fragmentation
jihwan.seo [Thu, 8 Sep 2016 07:26:31 +0000 (16:26 +0900)]
fix warning caleadapter and fragmentation

Change-Id: Ib6a83e0c59f2dde92881eb077d7575658deffbb4
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11557
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoSend normal GET response for register request to
Ziran Sun [Fri, 9 Sep 2016 14:33:48 +0000 (15:33 +0100)]
Send normal GET response for register request to
non-observablbe resource(s).

Bug: https://jira.iotivity.org/browse/IOT-1279
Change-Id: I93be3d3dc79bfc782e98ded57ef6cc0122077d7c
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11635
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoCloud Client
Andrii Shtompel [Mon, 12 Sep 2016 09:15:36 +0000 (18:15 +0900)]
Cloud Client

Implemented:
1. Cloud Client itself with menu and folders structure
2. CRL/ACL requests according latest spec

[Patch #2] Remove OCPayload to ACL/CRL convertion.
           Convert OCpayload back to char * and
           Use ACL/CRL resource functions to parse and update DB
[Patch #3] Add sync to menu and start userRequests as thread
[Patch #4] Save minor changes before merge both clients
[Patch #5] Merge CSR to this cloud client
[Patch #6] Clean-up changes. Merged cloud client works
[Patch #7] Save minor changes before move to cloud-interface branch
[Patch #8] Store private data
[Patch #9] Implement CRL on device according latest spec
[Patch #10] Minor Crl on device fixes
[Patch #11] Handle review comments
[Patch #12] Implement ACL get info on device according spec
            Remove OC_EXPORT from headers
[Patch #13] Fix CBOR encoding
[Patch #14] Crl last update, crl db changes, fix build error
[Patch #15] Crl Get/Post are fully implemented
[Patch #16] Acl fix uri path'es
[Patch #17] PKIX interface to SRM
[Patch #18] CRL rcsn fix (use String Array instead of String)
[Patch #19] ACL callbacks implemetation (parse and print recv data)
[Patch #20] Complete ACL callbacks
[Patch #21] Update Menu UI
[Patch #22] ACL uid's length fixes
[Patch #23] ACL ace request + CRL encoding fix
[Patch #24] Fix crash when receive empty aclist
[Patch #25] Set public data default encoding to DER
            Fix CRL initialization
[Patch #26, 27] Restore #24
[Patch #28] Fix build error related to PKIX
[Patch #29] ACL few fixes, clean-up code, add comments
[Patch #32] Clean-up csr + handle all review comments
[Patch #34] Revert ocpayload.c changes
[Patch #35] Fix build without WITH_TCP, CRL/ACL clean-up, error on exit
[Patch #37] Fix private data encoding
[Patch #38] Test build on Windows
[Patch #40] Remove accidental changes
[Patch #41] TLS sample fix
[Patch #42] CRL changes to use CBORPayload() functions
[Patch #43] ACL changes to use CBORpayload() + printAcl() + minor fixes
[Patch #44] Added extern C for external linkage to C++
[Patch #45] Revert #44 + acl fix
[Patch #47] Implement OC_LOG_PAYLOAD to show nested objects and arrays
[Patch #48] Fix review comments
            Add dynamic cipher based on SVR
            Change close notify to alert
[Patch #49] Add rootcer.crt and SaveTrustCert in cloudClient sample
[Patch #50] Change cipher priority and add choose cipher option in sample
[Patch #51] Remove accidental changes
[Patch #52] Add RSA cipher selection
[Patch #53] Huge changes in API and handlers to provide it to external team
[Patch #54] Minor fix, clean-up, add comments
[Patch #55] Resoved issue for save TrustCert with PEM in cloudClient sample
[Patch #56] UpdateACE fix, add CoAPs selection to Menu
[Patch #57] Few ACL requests fix, now all of them are working
[Patch #58] Add db file to command-line args + few fixes
[Patch #60] Add alert messages
[Patch #61] Fix cipher selection
[Patch #62] Fix Svace warnings
[Patch #63] Fix acl db issue. Create CBORpayloadToAcl2() for cloud response
            Because in latest spec its wrong we need this workaround
[Patch #64] Fix service folder build error when secured enabled
[Patch #65] Implement responses to cloud cpp wrapper API
[Patch #66] Minor fix to cloud cpp wrapper responses
[Patch #67] Fix Cbor allocation when credresource increase
[Patch #68] Revert wrong changes made in Patch #64
[Patch #69] Remove wrong changes in other SConscript files
[Patch #70] Fix minor build error
[Patch #71] Remove wrong changes from 2 source files + clean-up Sconscripts
[Patch #72] Return back credresource.c + fix crlresource.c for tizen
[Patch #73] Return back richdk scons
[Patch #74] Disable build stack samples without SECURED=1
[Patch #75] Fix OTM PIN
[Patch #76] Fix conflict
[Patch #77,78] Fix tizen build error
[Patch #80] Remove changes in secure stack samples
[Patch #81] Add ours headers to doxygen, update comments, add static
[Patch #83] Fix conflicts with master
[Patch #84] Add Discovery + Get/Put/Post device-to-device requests
            Separate most sample source code to cloud folder
[Patch #86] Arduino build fix
[Patch #87] Resolve merge conflict

Change-Id: Ib83b14a40d49df3b62dd5a1863777c8a5504a4e5
Signed-off-by: Jonsgung Lee<js126.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10785
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
8 years agoSimpleBase code clean up
Jaehong Jo [Fri, 2 Sep 2016 05:17:17 +0000 (14:17 +0900)]
SimpleBase code clean up

Remove warning and change main page

Change-Id: I1535fe015414462d9320fccddee6ddea9bb7a530
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agofixed multicast presence for sample related c-sdk.
jihwan.seo [Fri, 2 Sep 2016 06:41:33 +0000 (15:41 +0900)]
fixed multicast presence for sample related c-sdk.

Change-Id: I011b0575b34b957ef776a3ca56db0b3f2d751f2b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11329
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years ago[IOT-1248] Fix multiple APIs throwing wrong exception
saurabh.s9 [Mon, 12 Sep 2016 04:55:31 +0000 (10:25 +0530)]
[IOT-1248] Fix multiple APIs throwing wrong exception

Change-Id: Ide5d534e301492bfd5499fa6d1cc7778bf5e7611
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11671
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>
8 years agoadd empty parameter checking in OCAccountManager
Jaewook Jung [Mon, 12 Sep 2016 00:56:05 +0000 (09:56 +0900)]
add empty parameter checking in OCAccountManager

Since empty parameter checking for APIs in OCAccountManager is missing,
I added.

And modified signUp API according to the OCF cloud specification.

Change-Id: I23ecc376d3ac6522d411b7a0a9408d79f11fab24
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoremove warning for keepalive
jihwan.seo [Fri, 9 Sep 2016 09:26:07 +0000 (18:26 +0900)]
remove warning for keepalive

- check return value for OCDoresource

Change-Id: Ia3efa0d8365dd60ecb0c0e7dc751d242bcffa97d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11633
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoadd deleteLocalRef for findResource callback
jihwan.seo [Sun, 4 Sep 2016 22:26:46 +0000 (07:26 +0900)]
add deleteLocalRef for findResource callback

since findResource callback is called for several times.
it is better to call DeleteLocalRef after the variables is used.

Change-Id: I4d7e7eee7bda8ecba2880371fcc1bc87a90e32c1
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11367
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoEnable IPv6 Interface for Android, Tizen
hyuna0213.jo [Mon, 5 Sep 2016 02:43:54 +0000 (11:43 +0900)]
Enable IPv6 Interface for Android, Tizen

Enable IPv6 Interface for Android, Tizen

Change-Id: Ic92d724556240e4a9f5f77ea2c4b546dc93c2226
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoDevelopment of CoAP-HTTP Proxy
Abhishek Sharma [Thu, 8 Sep 2016 11:25:24 +0000 (16:55 +0530)]
Development of CoAP-HTTP Proxy

Wiki page: https://wiki.iotivity.org/coap-http_proxy
JIRA Issue: https://jira.iotivity.org/browse/IOT-1128

Change-Id: I12a6c53589a428bdc1f94ea6d48a692ac07aabfe
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11601
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoUpdate a policy of successful cloud provisioning
Jihun Ha [Sun, 11 Sep 2016 11:05:16 +0000 (20:05 +0900)]
Update a policy of successful cloud provisioning

If an enrollee already has an ACL and certificate for communication
with Cloudserver, a mediator does not need to provide them.
That is, ACL and certificate provisioning can be skipped for this case.

Change-Id: Id22566e21c22f92b552a3861a41f0de83959dcf3
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11655
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix SetDoxmDeviceId()
Jongmin Choi [Thu, 8 Sep 2016 05:56:21 +0000 (14:56 +0900)]
Fix SetDoxmDeviceId()

Fix SetDoxmDeviceId()
PT check removed
sqlite3 linking removed

Change-Id: I3bced8ba7c8e65ef3b97bea7113eee5cdbde9168
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
8 years agoMerge "Merge remote-tracking branch 'origin/notification-service' Updated with static...
Uze Choi [Mon, 12 Sep 2016 04:44:07 +0000 (04:44 +0000)]
Merge "Merge remote-tracking branch 'origin/notification-service' Updated with static analysis."

8 years agoresource-container: Change file permission of SampleResource sources
Philippe Coval [Fri, 11 Dec 2015 10:10:49 +0000 (15:40 +0530)]
resource-container: Change file permission of SampleResource sources

Removed the execute permission for the SampleResourceClient.cpp and
SampleResourceServer.cpp files in service/resource-encapsulation/examples/linux

Change-Id: I2ac6381ada31d76aead5e7139ea62d888d1a2877
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Author: Ravi Nanjundappa <nravi.n@samsung.com>
Origin: 1.0.1
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11485
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoresource-encapsulation: Avoid reinterpret_cast in const_expr
Philippe Coval [Fri, 9 Sep 2016 17:12:26 +0000 (19:12 +0200)]
resource-encapsulation: Avoid reinterpret_cast in const_expr

As unsupported in C++11 standard and g++-6 or clang

Reported error message is:

  service/resource-encapsulation/src/serverBuilder/unittests/RCSResourceObjectTest.cpp:368:13:
  error: reinterpret_cast from integer to pointer
  reinterpret_cast<OCRequestHandle>(0x1234);

Problem was observed while building for Yocto with generic toolchain:
  i586-poky-linux-g++ (GCC) 6.2.0

For reference see p125 of:

  http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3797.pdf

Change-Id: I20b21ad1bdac40c2aec44706501343ae1d9d7b69
Bug: https://jira.iotivity.org/browse/IOT-1111
Origin: https://github.com/tizenteam/meta-oic
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11663
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agosecurity: Improve with more specific error core and log of it
Philippe Coval [Thu, 21 Jul 2016 08:38:18 +0000 (10:38 +0200)]
security: Improve with more specific error core and log of it

This improvement has been suggested by Randeep Singh at :

 https://gerrit.iotivity.org/gerrit/#/c/9521/

Also reducing presence of "goto:" is always welcome ;)

Change-Id: I2ca21c37105c530c92e2cfd4b6ae9e3cfbc06231
Origin: https://gerrit.iotivity.org/gerrit/#/c/9543/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
8 years agoMerge remote-tracking branch 'origin/notification-service'
cc [Mon, 12 Sep 2016 02:06:07 +0000 (11:06 +0900)]
Merge remote-tracking branch 'origin/notification-service'
Updated with static analysis.

Change-Id: I73120da7cafc810f613fd2d9b265366ff773bbd3
Signed-off-by: cc <ch79.cho@samsung.com>
8 years agoAdd setCredID to mediator sample application
Jihun Ha [Sun, 11 Sep 2016 07:11:49 +0000 (16:11 +0900)]
Add setCredID to mediator sample application

To tranfer a certificate to Enrollee, you need to specify a credential ID
corresponding to the certificate.

Change-Id: I79c39ff1a6f0f90175cfe11c6ca7ed719f3cf222
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11653
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix Jira issues(IOT-1263)
Jihun Ha [Sun, 11 Sep 2016 11:57:09 +0000 (20:57 +0900)]
Fix Jira issues(IOT-1263)

IOT-1263:
  [ES][Linux] Get Location API can not get expected location
  (https://jira.iotivity.org/browse/IOT-1263)

Change-Id: Ifc0a088c3d7c8166fdc093976bebb3e84d036295
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11659
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix Jira issues(IOT-1268)
Jihun Ha [Sun, 11 Sep 2016 11:56:29 +0000 (20:56 +0900)]
Fix Jira issues(IOT-1268)

IOT-1268:
  [ES][Android] APIs crashed with null parameter
  (https://jira.iotivity.org/browse/IOT-1268)

Change-Id: I7b3bb5b9eb78df12b60e852a878ee73cb0d1c189
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11521
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd a dependency in building notification-service for android.
Jihun Ha [Sun, 11 Sep 2016 11:49:59 +0000 (20:49 +0900)]
Add a dependency in building notification-service for android.

After libnotification_provider_wrapper.so is created, its android SDK
should be built.

Change-Id: I6df993e6ccd60f29017cd2e47fe75b2d3cc78892
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11657
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoRemove logs with non-LOGGING build option.
KIM JungYong [Fri, 9 Sep 2016 06:11:46 +0000 (15:11 +0900)]
Remove logs with non-LOGGING build option.

When notification service build on non-Logging mode, log is removed.
For the above reason, newly appeared warning is resolved.

Change-Id: Ibc7a1ee32e3063934ad5fccdaf363707ef5a247c
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11621
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoRemove unused task type on consumer service.
KIM JungYong [Fri, 9 Sep 2016 08:36:29 +0000 (17:36 +0900)]
Remove unused task type on consumer service.

Named TASK_CONSUMER_GET_TOPIC_LIST task is remove reason by unused.

Change-Id: Id65cca0a284a4c0d3f216fc74bc9c0d4bcc4edfa
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11631
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix for result of static analysis.
KIM JungYong [Fri, 9 Sep 2016 04:21:04 +0000 (13:21 +0900)]
Fix for result of static analysis.

Pointer value casting is fixed for valid size.
If statement is fixed.

Change-Id: I4e6304769c683f78caca8eea4f4dc1da5c369a59
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11619
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
8 years agoFix bug for select topic.
KIM JungYong [Fri, 9 Sep 2016 07:24:29 +0000 (16:24 +0900)]
Fix bug for select topic.

When consumer service get topic to provider, consumer id is excepted.
Consumer id is added on request get topic.
linux sample app is updated for print topic.

Change-Id: I383c2032856e034e80241cc49b1601fece04d230
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11625
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
8 years agoAdd sendMessage for NSProviderSetConsumerTopic and bug fixes for API.
jaesick.shin [Fri, 9 Sep 2016 07:27:14 +0000 (16:27 +0900)]
Add sendMessage for NSProviderSetConsumerTopic and bug fixes for API.

1. Add sendmessage when call NSProviderSetConsumerTopic function.
2. Add bug fixes for API ('\0' case)

Change-Id: If5c204909cb37220ea0c2f007e9224aae0c494b2
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11627
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years agoUpdate consumer service termination logic.
KIM JungYong [Fri, 9 Sep 2016 02:27:00 +0000 (11:27 +0900)]
Update consumer service termination logic.

When consumer service termination or stopped,
memory deallocation of thread, mutex, list object is added.

unit test of NSConsumerGetProvider is added.

Change-Id: I61c30b46645d5a88eeac7f4ed6ca06d5b3d1036e
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11615
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years agomodified observe exception, when channel is disconnected upstream_real
Jung Seungho [Thu, 1 Sep 2016 07:43:14 +0000 (16:43 +0900)]
modified observe exception, when channel is disconnected

Change-Id: I6309712296cb8269c9dba027d64e8656e8479428
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11213
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
8 years agoFixes for build errors hit by some versions of Visual Studio
Dave Thaler [Fri, 26 Aug 2016 01:13:24 +0000 (18:13 -0700)]
Fixes for build errors hit by some versions of Visual Studio

Change-Id: Id8bcb4a5cd65d855b8e371c981f1c9bb4e6ed26d
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10929
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
8 years agoFixed discarded-qualifiers warning
George Nash [Wed, 7 Sep 2016 23:43:28 +0000 (16:43 -0700)]
Fixed discarded-qualifiers warning

by asigning the const pointer type to a non-const pointer type
the code was discarding the const qualifier. Added const key
word to fix warning.

Change-Id: Ided09959ac9406ed80f69606e9ed065d2498ebd2
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11527
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jaehyun Cho <jaehyun3.cho@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
8 years agoFixed shift-negative-value warning
George Nash [Wed, 7 Sep 2016 23:18:01 +0000 (16:18 -0700)]
Fixed shift-negative-value warning

The compilar was interpreting the number zero '0' as a
signed number not an unsigned number. The left shift behavior
for signed numbers is undefined. The 'u' sufix was added to
tell the compilar that the '0' is an unsigned number.

Change-Id: Ida6c5c5ee2a7ea556755ca55d71858469a0691ac
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: jaehyun Cho <jaehyun3.cho@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
8 years agoFixed implicit-function-declaration warning for strncasecmp
George Nash [Thu, 8 Sep 2016 00:28:48 +0000 (17:28 -0700)]
Fixed implicit-function-declaration warning for strncasecmp

Both csdk/security/src/aclresource.c and
csdk/security/src/pstatresource.c reports that there is an
implicit declaration of function 'strncasecmp' this means
the code does not see the 'strncasecmp' function from the
header.

The 'strncasecmp function exist in the strings.h header or
in string.h header. To have the funtion in the string.h
header the _GNU_SOURCE or _DEFAULT_SOURCE macro must be
defined.

Since aclresource.c explicity excludes strings.h if string.h
is found the _GNU_SOURCE macro was added.

The _GNU_SOURCE macro was used over the _DEFAULT_SOURCE
macro since there already apears to be a presidence for
the _GNU_SOURCE macro elsewhere in the code.

Change-Id: I2d29521d0f28811be2a58349a5bc8be39b17d76e
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11529
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>
8 years agoFixed implicit-function-declaration warning for strnlen function
George Nash [Wed, 7 Sep 2016 22:19:10 +0000 (15:19 -0700)]
Fixed implicit-function-declaration warning for strnlen function

The strnlen is a GNU extension and not a standard C function and
is not avalible unless the macro _DEFAULT_SOURCE or _GNU_SOURCE is
defined.

It looks like _GNU_SOURCE already has a precidence so it was added
to the build script.

Change-Id: Ied150e5b97a965c1b4b240d364e49669bdad4f11
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11523
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
8 years agoFix setting adapter type value of Endpoint for TCP adapter.
jihwan.seo [Thu, 1 Sep 2016 10:38:14 +0000 (19:38 +0900)]
Fix setting adapter type value of Endpoint for TCP adapter.

These was no set adapter value in Endpoint previously.

Change-Id: Id52d3c4393943dac205c2953ceb3334a3e43f8bf
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11273
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoFix for JIRA issue 1242, 1245, 1247
Abhishek Sharma [Thu, 8 Sep 2016 06:37:23 +0000 (12:07 +0530)]
Fix for JIRA issue 1242, 1245, 1247

https://jira.iotivity.org/browse/IOT-1242
https://jira.iotivity.org/browse/IOT-1245
https://jira.iotivity.org/browse/IOT-1247

Change-Id: I93a5f2bf3780ed2dc0ab74cd9701d100c1bbcb87
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11545
Reviewed-by: Masud Bhuiyan <m.parves@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years ago[IOT-1265] fix writeCharacteristic success signal logic
jihwan.seo [Thu, 8 Sep 2016 05:31:30 +0000 (14:31 +0900)]
[IOT-1265] fix writeCharacteristic success signal logic

Change-Id: Ib9a5b4ad18298fc2541fb128d964e2e634280cb2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11539
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years ago[IOT-1272] added null checker for address in setAutoConnectionDevice API
jihwan.seo [Thu, 8 Sep 2016 08:33:48 +0000 (17:33 +0900)]
[IOT-1272] added null checker for address in setAutoConnectionDevice API

Change-Id: Ib89a3856d3089d68e58e6d72112f76c59322f055
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11563
Reviewed-by: Suchita Sultana <suchita.rs@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoAdd logic for media contents.
KIM JungYong [Thu, 8 Sep 2016 10:47:27 +0000 (19:47 +0900)]
Add logic for media contents.

Media contents parse and copy, remove logic is added at consumer service.

Change-Id: If2079e33fcb0f84f983212468786657cfdc91976
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11571
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoUpdated cpp wrapper UnitTest
nikhil.a [Thu, 8 Sep 2016 10:58:18 +0000 (16:28 +0530)]
Updated cpp wrapper UnitTest

1) Updated code according to latest API names.
2) Added new test cases required for checking topic resource apis

Change-Id: Ib68d1a8dfe1aea2bc07d50def87cc366d4f60a84
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11503
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years agoAdd response logic for TopicListener.
jaesick.shin [Thu, 8 Sep 2016 09:03:36 +0000 (18:03 +0900)]
Add response logic for TopicListener.

Add response logic for OC_REST_POST case.
and call the NSSendTopicUpdationToConsumer().

Change-Id: I38de295bf143d504bb03cb090b6294a3d25017ec
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11565
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years agoUpdate unit test and Fix bug.
KIM JungYong [Thu, 8 Sep 2016 09:02:41 +0000 (18:02 +0900)]
Update unit test and Fix bug.

Unit test is updated for apply latest consumer logic.
And unit test of basic topic operation is added.

Invalid memory access is fixed.

Change-Id: I0fd30c6e0eb3e97196e591b5754aaf38c814ffa2
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11569
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years agoUndo revert "Generate iotivity_config.h at build time"
David Antler [Tue, 6 Sep 2016 16:59:59 +0000 (09:59 -0700)]
Undo revert "Generate iotivity_config.h at build time"

This reverts commit 8754a91b157e957b0c0ade9f07804cde2b3cd225.

Change-Id: I180eea046754d3c67fc12e426b675c569df57331
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
8 years ago[IOT-1270] Fix building with SECURED=0 for Windows
Dan Mihai [Thu, 8 Sep 2016 01:26:53 +0000 (18:26 -0700)]
[IOT-1270] Fix building with SECURED=0 for Windows

Don't try to link or export security-related APIs when SECURED=0.

Also, fix scons warning related to sqlite, in security/provisioning.

Change-Id: I61ddab0aeecdc917427bcc5051fb6be960b4b63f
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11533
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years ago[IOT-1259] README for cloud MQ updated
Minji Park [Thu, 8 Sep 2016 07:14:23 +0000 (16:14 +0900)]
[IOT-1259] README for cloud MQ updated

Change-Id: I9ea9e1e6ca1914bf196525506cf88621b15b9288
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11555
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
8 years agoRevert "Development of CoAP-HTTP Proxy"
Madan Lanka [Thu, 8 Sep 2016 11:05:43 +0000 (11:05 +0000)]
Revert "Development of CoAP-HTTP Proxy"

This reverts commit fa393dc92a9ea0e8809d4474d54d916e845b2d0e.

Change-Id: Ic3754979f2d9e672437110d5ae076792cf421330
Signed-off-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11599
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoDevelopment of CoAP-HTTP Proxy
Abhishek Sharma [Mon, 22 Aug 2016 09:00:41 +0000 (14:30 +0530)]
Development of CoAP-HTTP Proxy

Wiki page: https://wiki.iotivity.org/coap-http_proxy
JIRA Issue: https://jira.iotivity.org/browse/IOT-1128

Change-Id: I14f3e6a68c83e5c2cebfedbe1a0e1247e3cb85c2
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
8 years agoFix cainterface crash issue
jihwan.seo [Tue, 6 Sep 2016 10:48:03 +0000 (19:48 +0900)]
Fix cainterface crash issue

GetStaticMethodID doesn't need to use DeleteGlobalRef.

Change-Id: Ifea9490e9e7fa142d92687363436a1b8529f43a3
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11437
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agoUpdate parse logic of introspectProvider result.
KIM JungYong [Sun, 4 Sep 2016 04:49:44 +0000 (13:49 +0900)]
Update parse logic of introspectProvider result.

When received introspect provider result,
consumer service expect to get provider policy as type of boolean.
But, policy is integer type although provider side set boolean type.
So, parse logic of policy is updated to parse for given type by received payload.

Change-Id: I695e81179172376499345f9b1f6323a04325a015
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11383
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoRemove NSMessage Storage of consumer service.
KIM JungYong [Wed, 7 Sep 2016 05:33:14 +0000 (14:33 +0900)]
Remove NSMessage Storage of consumer service.

NSMessage storage is removed reason by unnecessariness functionality.
But, for the prevent of duplicated message, messageId and NSSyncType need to store.
So, linked list of information for message sync state is added.

Change-Id: Iea80b20a4ca44d9b17b2d3f0746d1f33212d9a3e
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd Unittest for topic.
jaesick.shin [Wed, 7 Sep 2016 05:11:50 +0000 (14:11 +0900)]
Add Unittest for topic.

1. Unregister topic case.
2. setTopic case.
3. unSet Topic case.

second patch,
remove warning code.

Change-Id: I8f918bcc23297311d86fcb7f4c13419b99b02d36
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11477
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd setting the icon image.
jaesick.shin [Thu, 8 Sep 2016 07:36:02 +0000 (16:36 +0900)]
Add setting the icon image.

Add setting the icon image in NSSetMessagePayload.
Add NS_ATTRIBUTE_ICON_IMAGE in NSConstants.h

Change-Id: Ia1327da32c80737283ea54f8b2e9f2d4f376efb5
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11559
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoChange while condition in resource broker
Hun-je Yeon [Wed, 7 Sep 2016 14:16:58 +0000 (23:16 +0900)]
Change while condition in resource broker

Removing possible infinite loop with while(1) condition

Change-Id: I07a85de3a38fad3265fd8712a8ce1c912fccf690
Signed-off-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoUpdate logic of callback when provider discovered.
KIM JungYong [Wed, 7 Sep 2016 07:38:28 +0000 (16:38 +0900)]
Update logic of callback when provider discovered.

When consumer discover already discovered provider as unsubscribing,
does not callback to upper layer before,
but we decide to callback to upper layer, so related logic is updated.

Change-Id: Iddeb4577f94f941473452ad035949aaf7c135914
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11499
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoremove scons build warning from sample app
ch79.cho [Wed, 7 Sep 2016 05:56:42 +0000 (14:56 +0900)]
remove scons build warning from sample app

gets function is changed to input function to remove warining.

Change-Id: I1f2ad5c1962f81a2321597f078baf513a1b83227
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11481
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd Macro for related resource and bug fixes for Topic.
jaesick.shin [Wed, 7 Sep 2016 06:36:29 +0000 (15:36 +0900)]
Add Macro for related resource and bug fixes for Topic.

1. Add Macro - createResource, deleteResource
2. Add NS_FAIL for fail case in NSAddTopics Function.

Change-Id: Ic94403298cf824e9d7a47de91d8c42bfa84b1460
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11489
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix bug for callback as seperated thread.
KIM JungYong [Wed, 7 Sep 2016 06:55:02 +0000 (15:55 +0900)]
Fix bug for callback as seperated thread.

Problem: It is degined that consumer service executes
     the registered callback function in different thread
But, the registered callback function for ProviderChanged event
      is called in same thread.

Fix: Separate the thread for this callback function execution
     from main thread

Change-Id: Ic4c9edce1c058a7e04aa7a38fad8f66f2e586d3d
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11493
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd condition for topic of sendNotification.
jaesick.shin [Wed, 7 Sep 2016 00:32:52 +0000 (09:32 +0900)]
Add condition for topic of sendNotification.

topic case is Null or '\0'.

Change-Id: I216fd165145bd7523810e8636919c95f89470ef0
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11465
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoMerge "Merge remote-tracking branch 'origin/master' into notification-service" into...
Uze Choi [Thu, 8 Sep 2016 04:59:26 +0000 (04:59 +0000)]
Merge "Merge remote-tracking branch 'origin/master' into notification-service" into notification-service

8 years agoRemoved build warning: Two different environments in C++ wrapper
Abitha Shankar [Wed, 7 Sep 2016 11:54:05 +0000 (17:24 +0530)]
Removed build warning: Two different environments in C++ wrapper

Removed unUsed variable warnings
Removed warnings for printing variables

Change-Id: I5d6ba48df298c91f46ba7388ea355bc6a833a679
Signed-off-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11501
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
8 years agoSet unused OCDeviceInfo struct fields to NULL
ljsachs [Mon, 8 Aug 2016 21:25:24 +0000 (14:25 -0700)]
Set unused OCDeviceInfo struct fields to NULL

Java DeviceInfo never uses the optional OCDeviceInfo fields,
these must be set to NULL to avoid potential corrupt data.

Change-Id: I7eda3be60d17591ab6169c0d487784c474f6325d
Signed-off-by: ljsachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10165
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agobuild: Exit with return code from builds
Philippe Coval [Mon, 29 Aug 2016 18:57:36 +0000 (11:57 -0700)]
build: Exit with return code from builds

[Trevor Bramwell <tbramwell@linuxfoundation.org>]
The exit code from scons calls is being silently ignored. Returning the
exit code from 'wait()' in auto_build.py and passing it to 'exit()'
should correctly fail builds.

[Philippe Coval <philippe.coval@osg.samsung.com>]
To sort out and sync ourselves, I added Bug-Id to commit message.
Content is same, feel free keep that link and push over.

Change-Id: I5afce52a3bddf7fb4e6b68acb57a1d51f3034067
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Author: Trevor Bramwell <tbramwell@linuxfoundation.org>
Bug: https://jira.iotivity.org/browse/IOT-1260
Origin: https://gerrit.iotivity.org/gerrit/#/c/11087/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11087
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoMerge remote-tracking branch 'origin/master' into notification-service
cc [Thu, 8 Sep 2016 01:29:09 +0000 (10:29 +0900)]
Merge remote-tracking branch 'origin/master' into notification-service

Change-Id: I46af88cce1a821841baa1fe3f5226537ae1eb83b
Signed-off-by: cc <ch79.cho@samsung.com>
8 years agoAdd dependency to build Easy setup android application
Jihun Ha [Wed, 7 Sep 2016 13:46:40 +0000 (22:46 +0900)]
Add dependency to build Easy setup android application

Before building Android Mediator sample application, Easy setup SDK should
be built. This patch makes such a dependency.

Change-Id: I8e9ddbeac1f5f9a3ad12e4505de4423469b94bb5
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11515
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agotizen: Link to systemwide's sqlite
Philippe Coval [Wed, 7 Sep 2016 08:15:46 +0000 (10:15 +0200)]
tizen: Link to systemwide's sqlite

Without this change, error may occurs and display this message:

   Linking resource/csdk/liboctbstack.so
   out/tizen/x86_64/release/libocsrm.a(provisioningdatabasemanager.o): In function `createDB':
   provisioningdatabasemanager.c:(.text+0x2c): undefined reference to `sqlite3_open_v2'

Bug: https://jira.iotivity.org/browse/IOT-1260
Change-Id: I6fbb51d5746f7d02bb3fd15d337d5d91c592b4ec
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd connectivity_abstraction lib to randomtests build script
George Nash [Thu, 1 Sep 2016 21:54:53 +0000 (14:54 -0700)]
Add connectivity_abstraction lib to randomtests build script

This fixed a build issue seen on fedora linux

Change-Id: Ia9e2bdcba55f4af90891b03f8247608b0920095b
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11309
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
8 years agoparseChain() PEM update
Oleksii Beketov [Thu, 25 Aug 2016 14:38:07 +0000 (17:38 +0300)]
parseChain() PEM update

parseChain() from ca_adapter_net_tls.c modified in order to parse
PEM certificates. Input buffer may contain either PEM or DER
certificates in a jumble. Each PEM format certificate in a chain
must be terminated with null byte.

Change-Id: Id0e7ff5dddf4af4213dfb0ffe8a8ca05f96581a7
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10741
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
8 years agoChanged svr db file for certification provisioning.
Parkhi [Wed, 7 Sep 2016 06:12:45 +0000 (15:12 +0900)]
Changed svr db file for certification provisioning.

Change-Id: I189cd935ca3255f3b7823f59040cb17a0cb55443
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11487
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
8 years agocorrected menu option
amar [Wed, 7 Sep 2016 04:19:11 +0000 (09:49 +0530)]
corrected menu option

Change-Id: Iaaf88464ca1eca36edc78707dce826688ba1b7f9
Signed-off-by: amar <amar.sri@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11471
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
8 years ago[IOT-1246] Resolved exception error
Randeep Singh [Tue, 6 Sep 2016 13:11:45 +0000 (18:41 +0530)]
[IOT-1246] Resolved exception error

Change-Id: I69a1c072634e688d35617708aec3e7c32acd3878
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11441
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
8 years agoupdate TCP & ARDUINO filter in secure mode
jihwan.seo [Wed, 7 Sep 2016 06:50:15 +0000 (15:50 +0900)]
update TCP & ARDUINO filter in secure mode

Change-Id: I14a9d6a24b8dcac6acd7f92fbe5afee58297fdca
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
8 years agolinux: Fix ./autobuild.py linux to build only for linux
Philippe Coval [Mon, 29 Aug 2016 14:06:33 +0000 (16:06 +0200)]
linux: Fix ./autobuild.py linux to build only for linux

Change-Id: Id40055ef67c1d86ec92b7939cb757f9865b12262
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11075
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ajay Saini <ajay.saini@intel.com>
Reviewed-by: Jon A. Cruz <jon@joncruz.org>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
8 years agoAdd WITH_TCP and WITH_CLOUD option in common build script files for tizen easy-setup...
sy01.youn [Tue, 6 Sep 2016 07:51:22 +0000 (16:51 +0900)]
Add WITH_TCP and WITH_CLOUD option in common build script files for tizen easy-setup sample app.

Change-Id: I909dc85679693342ae840bc229d1157a9f250d7a
Signed-off-by: sy01.youn <sy01.youn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11421
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
8 years agoRevert "Enable disabled Configure unit tests in OCPlatformTest."
jihwan.seo [Tue, 6 Sep 2016 08:17:53 +0000 (17:17 +0900)]
Revert "Enable disabled Configure unit tests in OCPlatformTest."

This reverts commit 3e1e7340107bbbd6cffe4e4159b5fd2c5e1e9fc0.

Change-Id: I751a67d585bafeaf075e3718429836eb89c8a27e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11425
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years ago1. Added sendMessage without Topics in sample application
Abitha Shankar [Tue, 6 Sep 2016 08:48:57 +0000 (14:18 +0530)]
1. Added sendMessage without Topics in sample application

2. Removed Discovered state from ProviderState
3. Added null checks

Change-Id: I23713dae5a610df37543776c1892927b3377a5fe
Signed-off-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11419
Reviewed-by: jaesick shin <jaesick.shin@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
8 years agoremove build warning: Two different environments..
ch79.cho [Wed, 7 Sep 2016 04:42:21 +0000 (13:42 +0900)]
remove build warning: Two different environments..

Scons warning is removed:
"Two different environments were specified for target"

Change-Id: Iba5dc62b891bb12712e4f049545008bef00b5a7a
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11475
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix Arduino CI
David Antler [Thu, 1 Sep 2016 21:46:06 +0000 (14:46 -0700)]
Fix Arduino CI

This should fix an issue with Arduino CI introduced through a
false-positive result.

Change-Id: I0255e8f78038557ececc7e0a1ff9741a9140f346
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdd a path for header inclusion for security provisioning manager functionality.
Jihun Ha [Wed, 7 Sep 2016 01:49:59 +0000 (10:49 +0900)]
Add a path for header inclusion for security provisioning manager functionality.

Within https://gerrit.iotivity.org/gerrit/#/c/11283/, provisioningdatabasemanager.h
has been moved to resource/csdk/security/provisioning/include/internal/.
To cope with this change, this path should be included to one of our SConcript.

Change-Id: I27c97c3d2b50394a6892d6fd94641042e4640fb4
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11467
Reviewed-by: Jongho Park <jh8397.park@samsung.com>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoAdded SetDoxmDeviceId() API.
Randeep Singh [Tue, 6 Sep 2016 12:42:34 +0000 (18:12 +0530)]
Added SetDoxmDeviceId() API.

 - Patch #1 : Initial upload.
 - Patch #2 : 1. Move the PDM related files to SRM layer.
              Becuase PDM PAI is required from DOXM to check owned device list.
              2. Add logic to check OTM state.

Change-Id: Ib21a2984fde0f1aa4fc98e5fc246d56ef15456c8
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11283
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
8 years agoBuild scripts updated for android build issue for connectivity layer
saurabh.s9 [Mon, 5 Sep 2016 06:52:44 +0000 (12:22 +0530)]
Build scripts updated for android build issue for connectivity layer

Change-Id: Ia8781f4adbf39529c763521bc6dcfb5c5b4a78c1
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11399
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
8 years agoUpdated cloud provisioning retry logic.
Heewon Park [Fri, 2 Sep 2016 05:39:43 +0000 (14:39 +0900)]
Updated cloud provisioning retry logic.

 - For mediator can retry cloud-provisioning process, when missed response packet of post.

Change-Id: Id38ab1b2fe37580f590880ff8b96d28eea948a19
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix a logic to filter out an exception in createRemoteEnrollee API for Android
Jihun Ha [Mon, 5 Sep 2016 05:54:36 +0000 (14:54 +0900)]
Fix a logic to filter out an exception in createRemoteEnrollee API for Android

If a resource does not have a "oic.wk.prov" resource type, createRemoteEnrollee
API should return a NULL pointer. However, this exception has not been
handled in jni implementation. To resolve this problem, this patch make
this exception returned to android layer, properly.

Change-Id: I70d9dfbcd6cd21757e4f594abbc99902dc367681
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11395
Reviewed-by: Jongho Park <jh8397.park@samsung.com>
Reviewed-by: Sijae Kim <sijae.kim@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoUpdate parse logic of introspectProvider result.
KIM JungYong [Sun, 4 Sep 2016 04:49:44 +0000 (13:49 +0900)]
Update parse logic of introspectProvider result.

When received introspect provider result,
consumer service expect to get provider policy as type of boolean.
But, policy is integer type although provider side set boolean type.
So, parse logic of policy is updated to parse for given type by received payload.

Change-Id: I695e81179172376499345f9b1f6323a04325a015
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11359
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoFix bug for sample and remove unused functions.
KIM JungYong [Sun, 4 Sep 2016 07:36:47 +0000 (16:36 +0900)]
Fix bug for sample and remove unused functions.

1) Bug of consumer sample app is fixed.
2) Unused function of consumer service is removed.

Change-Id: Idc7f7decdde34d8067177d84410af979f173a279
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11361
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoUpdate unit test of consumer service.
KIM JungYong [Mon, 5 Sep 2016 07:46:51 +0000 (16:46 +0900)]
Update unit test of consumer service.

negative test case is added.
some of test case is updated.
presence stop case is added.

Change-Id: I86f1e50e6208e5a603f40b57f2d9a10e24d237ea
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoRequired to check consumer unitest
cc [Fri, 2 Sep 2016 13:57:35 +0000 (22:57 +0900)]
Required to check consumer unitest

Consumer unittest will be upgraded.

Change-Id: I758fa0ffc1e54874858fda23e76d34293c18dbd2
Signed-off-by: cc <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11347
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 81ac23211bdd85e636e197a2cba0cf03de2b9c40)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11377
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
8 years agochange warning code for scanf.
jaesick.shin [Mon, 5 Sep 2016 04:45:57 +0000 (13:45 +0900)]
change warning code for scanf.

add condition for scanf.
remove warning only.

Change-Id: If4912d286b6c7d78dac0bda5ffe05d6e1cdfb0cc
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11389
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoHold GetTopics API return until related code finishes in the other thread
jaesick.shin [Sun, 4 Sep 2016 22:17:02 +0000 (07:17 +0900)]
Hold GetTopics API return until related code finishes in the other thread

Issue: Crash happen Get Topic just after Topic registration.
 (between RegistrerTopic and GetTopics/GetConsumerTopic APIs)

Fix: apply condition variable to RegistrerTopic API logic and
     GetTopics/GetConsumerTopic API logic.

Other Fixes:
 locking the NSProviderInterface.
 modify unittest for functions of 1 and 2.

Change-Id: Ia8e75d7b21198b3d4c3810050baa0867d60eeb78
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11365
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
8 years agoGet back to the previous code.
jaesick.shin [Sun, 4 Sep 2016 22:00:10 +0000 (07:00 +0900)]
Get back to the previous code.

change input logic for example.

second patch included,
change fgets to input function.

Change-Id: Id763ae718db2daaeaeac9cc55149f6eb58183361
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11363
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoLogic was added when the topic list has not been registered yet.
jaesick.shin [Mon, 5 Sep 2016 04:17:49 +0000 (13:17 +0900)]
Logic was added when the topic list has not been registered yet.

Logic was added when consumer request of OC_REST_GET.

Change-Id: I510959517c7f1e1c506f081eb6d59b88c6f9cd22
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11385
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agofix resource-container unit test
Minji Park [Tue, 6 Sep 2016 04:09:04 +0000 (13:09 +0900)]
fix resource-container unit test

- default callback waiting time
  and test resource type for discovery test changed.

Change-Id: I1f659d488b418a7359ccfce857deb3eff6a8bb3c
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11411
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoEnable disabled Configure unit tests in OCPlatformTest.
Ziran Sun [Tue, 23 Aug 2016 14:08:26 +0000 (15:08 +0100)]
Enable disabled Configure unit tests in OCPlatformTest.

Since all the functionalities called in these unit tests
are now available, enable these tests. Verification via
local tests has been done before enable any of these tests.

Change-Id: Ie5086e3394460452dd92199629017b30f1ef0030
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10809
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sungkyu Ko <sungkyu.ko@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
8 years agogtest: Hotfix to prevent download failure
Philippe Coval [Tue, 30 Aug 2016 07:38:22 +0000 (09:38 +0200)]
gtest: Hotfix to prevent download failure

gtest-1.7.0.zip (md5=2d6ec8ccdf5c46b05ba54a9fd1d130d7) is gone from:
  https://googletest.googlecode.com/files/gtest-1.7.0.zip

So let's switch to a mirrored file:
  http://pkgs.fedoraproject.org/repo/pkgs/gtest/gtest-1.7.0.zip/2d6ec8ccdf5c46b05ba54a9fd1d130d7/gtest-1.7.0.zip

Note, now upstream project moved to:
  https://github.com/google/googletest/archive/release-1.7.0.zip

But archive structure is different (configure is missing),
 so a additional works are needed,
 maybe it worth to be done on latest release instead (1.8.0 ATM).

Change-Id: Ib1cf308fb2d3a15bdf69246cccfd379234bbce22
Bug: https://jira.iotivity.org/browse/IOT-820
Origin: https://gerrit.iotivity.org/gerrit/#/c/11119/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11119
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
8 years agoRevert "Generate iotivity_config.h at build time"
Jaewook Jung [Mon, 5 Sep 2016 05:50:30 +0000 (14:50 +0900)]
Revert "Generate iotivity_config.h at build time"

This reverts commit dbcc3f47fe5abd2102750cdd3ace7f92619e8dd0.

Change-Id: I1fe54489a0d73940ca74f4abd293608c255fe645
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11393
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>