Brian Sullivan [Tue, 25 Sep 2018 20:06:24 +0000 (13:06 -0700)]
Full support for exception sets in value numbering.
New method that add exception sets:
fgValueNumberAddExceptionSet
- fgValueNumberAddExceptionSetForIndirection
- fgValueNumberAddExceptionSetForDivision
- fgValueNumberAddExceptionSetForOverflow
- fgValueNumberAddExceptionSetForCkFinite
Refactoring work added methods:
VNEvalShouldFold - method to decide if constant folding should be performed
EvalUsingMathIdentity - Uses math identities to simplify value number exoressions
Renamed fgValueNumberHelperMethVNFunc to fgValueNumberJitHelperMethodVNFunc
Removed the suffixes from the method headers comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a6f0c8f0c706c3a5ed5e98feeca80de1da57b5d
Michal Strehovský [Fri, 5 Oct 2018 10:51:06 +0000 (12:51 +0200)]
Report instantiation argument in non-virtual interface calls (dotnet/coreclr#20257)
The existing code would incorrectly inhibit codegen from generating instantiation argument in non-virtual calls to default interface methods (i.e. those that can happen with the `base` syntax in C#).
Fixes dotnet/coreclr#16775.
Commit migrated from https://github.com/dotnet/coreclr/commit/
27c848e37e9998142b60e776cf5b5d08a3543fe1
John Doe [Fri, 5 Oct 2018 01:56:04 +0000 (18:56 -0700)]
Typos (dotnet/coreclr#20271)
* oportunistically -> opportunistically
* oppportunity -> opportunity
* Oppporunity -> Opportunity
* optinal -> optional
* optimisitic -> optimistic
* optionaly -> optionally
* origianl -> original
* orignally -> originally
* otheriwse -> otherwise
* otherrwise -> otherwise
Commit migrated from https://github.com/dotnet/coreclr/commit/
af0c1f287d31ca3a641151df60baa7371635f508
Jan Vorlicek [Fri, 5 Oct 2018 01:08:51 +0000 (03:08 +0200)]
Remove context statics stuff (dotnet/coreclr#20256)
* Remove context statics stuff part 1
This change removes all context statics stuff from the runtime since
context statics are not supported and this code was obsolete.
* Remove context statics stuff from the debugger code
Commit migrated from https://github.com/dotnet/coreclr/commit/
da6498e6c1013dd38d33e782bc777bd89aa0f0ee
Jonathan Marler [Fri, 5 Oct 2018 01:08:22 +0000 (19:08 -0600)]
Synchronize access to static variable call_count (dotnet/coreclr#20259)
call_count is a static variable that is being read/modified and written to without any synchronization. Fortunately, a critical section is already available that can be leveraged to synchronize access to it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f59d17e2741e69bf878b8b168828de3a0a3d12e
Jan Vorlicek [Fri, 5 Oct 2018 00:11:35 +0000 (02:11 +0200)]
Add printing of LoaderAllocator to MethodTable in SOS (dotnet/coreclr#20255)
This change adds printing of LoaderAllocator to MethodTable dump in SOS
for collectible types.
Commit migrated from https://github.com/dotnet/coreclr/commit/
957eceed83cf635fc3146eadc448bf50efde5431
Tomáš Rylek [Thu, 4 Oct 2018 19:29:24 +0000 (21:29 +0200)]
R2RDump fixes for dumping method instance entrypoint table (dotnet/coreclr#20243)
R2RDump fixes for dumping method instance entrypoint table
While investigating Michal's unit test demonstrating a bug in the
CPAOT compiler I found out that R2RDump is broken in multiple
aspects w.r.t. instantiated methods. Parsing of the method
signatures in the instance entrypoint table was just broken
and the R2RMethod was duplicating parts of the signature decoding
and name formatting process.
I created a new flag "normalize" that requests normalization of various R2R
tables in the dump aimed at improving diff quality. I have also
noticed and fixed somewhat weird formatting of method signatures.
As a slight cleanup I have lumped the various dump flags into
a helper class DumpOptions. Last but not least I have renamed "Canon"
to "__Canon".
Thanks
Tomas
Commit migrated from https://github.com/dotnet/coreclr/commit/
030e0af89bb897554acef575075c69aaf5176268
Steve Harter [Thu, 4 Oct 2018 15:26:11 +0000 (10:26 -0500)]
Merge pull request dotnet/coreclr#20252 from steveharter/FixIsAssignableFrom
Fix compat issue with Type.IsAssignableFrom
Commit migrated from https://github.com/dotnet/coreclr/commit/
e43bc521df71513061c7194efc4af4c70a1b9b42
Jan Vorlicek [Thu, 4 Oct 2018 08:26:06 +0000 (10:26 +0200)]
Enable thread statics for collectible classes (dotnet/coreclr#19944)
* Enable thread statics for collectible classes
This change removes checks that were preventing usage of thread statics
in collectible classes and also implements all the necessary changes.
The handles that hold arrays with thread statics are allocated from
LoaderAllocator for collectible classes instead of using the global
strong handle like in the case of non-collectible classes.
The change very much mimics what is done for regular statics.
This change also adds ability to reuse freed handles to the
LoaderAllocator handle table. Freed handle indexes are stored into a
stack and when a new handle allocation is requested, the indices from
this stack are used first.
Due to the code path from which the FreeTLM that in turn frees the
handles is called, I had to modify the critical section flags and also
refactor the handle allocation so that the actual managed array
representing the handle table is allocated out of the critical section.
When I was touching the code, I have also moved the code that was
dealing with handles that are not stored in the LoaderAllocator handle
tables out of the critical section, since there is no point in having it
inside of it.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7559844bbe9e4230217a9a9cf4be8a857531c8c8
Jan Vorlicek [Thu, 4 Oct 2018 08:18:23 +0000 (10:18 +0200)]
Remove AppDomain unload (dotnet/coreclr#20250)
* Remove AppDomain unload
This change removes all code in AppDomain that's related to AppDomain
unloading which is obsolete in CoreCLR. It also removes all calls to the
removed methods.
In few places, I have made the change simpler by taking into account the
fact that there is always just one AppDomain.
Commit migrated from https://github.com/dotnet/coreclr/commit/
11832401739148f1f1e9419cb51180ba5263a41b
Bruce Forstall [Thu, 4 Oct 2018 03:16:28 +0000 (20:16 -0700)]
Merge pull request dotnet/coreclr#20235 from BruceForstall/Disable19361
Disable GitHub_19361 for Linux arm64
Commit migrated from https://github.com/dotnet/coreclr/commit/
0068168531e849cbad8388f00f3f23e58d3a01b4
dotnet-maestro-bot [Thu, 4 Oct 2018 02:38:12 +0000 (19:38 -0700)]
Update CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview1-27003-01, preview1-27003-02, preview1-27003-01, master-
20181003-0045, master-
20181003-0040, respectively (master) (dotnet/coreclr#20241)
* Update CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview1-27003-01, preview1-27003-02, preview1-27003-01, master-
20181003-0045, master-
20181003-0040, respectively
* Disabled outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
209bca9c6caf59bc60bffd16a8da5c67c6d6138b
Steve Harter [Wed, 3 Oct 2018 22:52:31 +0000 (17:52 -0500)]
Fix compat issue with Type.IsAssignableFrom
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d227d6f1d3a6032bde52af47099471c38f22840
Carol Eidt [Wed, 3 Oct 2018 21:18:47 +0000 (14:18 -0700)]
Merge pull request dotnet/coreclr#20173 from fiigii/retest
Optimize some SSE2 intrinsic importation and re-enable tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
bac49ea2198a958f018c8a6b0fb4c1c07561042b
David Mason [Wed, 3 Oct 2018 19:52:32 +0000 (12:52 -0700)]
report the entire generation table in EnumWksGlobalMemoryRegions and EnumSvrGlobalMemoryRegions (dotnet/coreclr#20233)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d4b291c10ace6baf35d2c7b45f50f98d6cea4060
Egor Chesakov [Wed, 3 Oct 2018 17:21:23 +0000 (10:21 -0700)]
Support building cross-architecture components on armel (dotnet/coreclr#20190)
Commit migrated from https://github.com/dotnet/coreclr/commit/
48a8c74e355fad5c1a569b131f4038218c98dfee
Jeremy Koritzinsky [Wed, 3 Oct 2018 16:32:34 +0000 (09:32 -0700)]
Marshal blittable structs via memcpy even if nested within non-blittable struct (dotnet/coreclr#20194)
* Add regression test for dotnet/coreclrdotnet/coreclr#18521.
* Add custom marshaler for fixed buffers that acts as a scalar memory copy of the length of the fixed buffer.
* Remove regression test. Moving it to a unit test in corefx.
* Move attribute class name into classnames.h
* Remove unreachable code left over from debugging.
* Marshal fixed buffers by reusing the field marshaler of the single field to pretend that there are multiple fields consecutively in the structure.
* Remove now-dead code paths.
* Use initializers in FieldMarshaler_NestedValueClass constructor where appropriate.
* Clean up IsFixedBuffer implementation.
* Remove unused GC_PROTECTs.
* Specifically check that the attribute exists, not just that there wasn't an error.
* Fix missing else statement.
* Add asserts so we don't corrupt the heap.
* Add unit test for masked bug (incorrect native size of structure calculated).
* Don't use new behavior on non-blittable fixed buffers.
* Revert "Add unit test for masked bug (incorrect native size of structure calculated)."
This reverts commit dotnet/coreclr@
496eef5906638c3c2696ede0d922a5e707447b4e.
* Use memcpy instead of field emulation.
* Remove unused forward-declared class.
* Clean up code. Refactor one GetMethodTable call I missed.
* Remove now-unneeded custom attribute includes. More diff cleanup.
* Remove unneeded FixedBufferAttribute define.
Commit migrated from https://github.com/dotnet/coreclr/commit/
302630ed5a3730470e9ffeeebcd38c737c03963d
Koundinya Veluri [Wed, 3 Oct 2018 15:52:40 +0000 (08:52 -0700)]
Add MethodImplOptions.AggressiveOptimization and use it for tiering (dotnet/coreclr#20009)
Add MethodImplOptions.AggressiveOptimization and use it for tiering
Part of fix for https://github.com/dotnet/corefx/issues/32235
Workaround for https://github.com/dotnet/coreclr/issues/19751
- Added and set CORJIT_FLAG_AGGRESSIVE_OPT to indicate that a method is flagged with AggressiveOptimization
- For a method flagged with AggressiveOptimization, tiering uses a foreground tier 1 JIT on first call to the method, skipping the tier 0 JIT and call counting
- When tiering is disabled, a method flagged with AggressiveOptimization does not use r2r-pregenerated code
- R2r crossgen does not generate code for a method flagged with AggressiveOptimization
Commit migrated from https://github.com/dotnet/coreclr/commit/
b68296ce2c56188cf2a7bd263903e27c67717702
Paresh [Wed, 3 Oct 2018 09:49:27 +0000 (15:19 +0530)]
PDF link wasn't working (dotnet/coreclr#20242)
Correct pdf link
Commit migrated from https://github.com/dotnet/coreclr/commit/
50567db6e3851f4c4680771424a354e2258333b4
Tomáš Rylek [Wed, 3 Oct 2018 00:04:51 +0000 (02:04 +0200)]
Fix X86 disassembly and a bug regarding ExportedTypes in R2RDump (dotnet/coreclr#20230)
1) X86 CoreDisTools disassembler has a bug in decoding absolute
indirections, interpreting them as RIP-relative offsets. I have
reused the logic that's already in place for patching X64
RIP-relative addresses to take care of this additional case.
2) the CoreDisTools disassembly apparently only produces newline
(0A) characters that don't work well in Notepad and other viewers;
I have forcibly replaced them with the platform newline separator.
3) I hit a bug in available type decoding - the logic wasn't
properly checking whether the type is exported or not.
Thanks
Tomas
Commit migrated from https://github.com/dotnet/coreclr/commit/
31955025defa95915c0532773dbf5cb4a932953a
Bruce Forstall [Tue, 2 Oct 2018 23:50:08 +0000 (16:50 -0700)]
Merge pull request dotnet/coreclr#20237 from BruceForstall/MakeInnerloopArm64DefaultTriggered
Change the innerloop arm64 Linux jobs to be default triggered
Commit migrated from https://github.com/dotnet/coreclr/commit/
d9ac5ad482510ed944315b847e1a587816553b1c
Bruce Forstall [Tue, 2 Oct 2018 22:05:54 +0000 (15:05 -0700)]
Change the innerloop arm64 Linux jobs to be default triggered
The two innerloop jobs had been push triggered, to see how the
jobs behave in the system. They have been pretty stable, so
change to make them default triggered.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b31168a4bb56d627792f5f1d85fd5e7ec55a7d0d
Bruce Forstall [Tue, 2 Oct 2018 21:36:46 +0000 (14:36 -0700)]
Disable GitHub_19361 for Linux arm64
Tracking: dotnet/coreclr#20232
Commit migrated from https://github.com/dotnet/coreclr/commit/
5e4d050285d1b8fdc93292b482cdf3d07fd7c24b
Raul Hidalgo Caballero [Tue, 2 Oct 2018 21:25:18 +0000 (23:25 +0200)]
Add Bionic to sources.list for cross (dotnet/coreclr#20202)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d112e78bb863cb22d2f0600fbbb8288ce8fc8ab5
Andy Ayers [Tue, 2 Oct 2018 20:01:30 +0000 (13:01 -0700)]
Merge pull request dotnet/coreclr#20203 from AndyAyersMS/FixGtIndexAddrTest
Fix test for GT_INDEX_ADDR to forcibly compile with minopts
Commit migrated from https://github.com/dotnet/coreclr/commit/
d9bfde1b88bb4d7d0d1bf024a192b13bf7405f82
Carol Eidt [Tue, 2 Oct 2018 16:35:39 +0000 (09:35 -0700)]
Merge pull request dotnet/coreclr#20193 from fiigii/addbc
Add pointer overloads for Avx2.BroadcastScalarToVector256
Commit migrated from https://github.com/dotnet/coreclr/commit/
3552e51d9faa3bbd032e4dbd7d36d804ec5679f8
mikedn [Tue, 2 Oct 2018 02:54:06 +0000 (05:54 +0300)]
Stop updating gtRsvdRegs before LSRA (dotnet/coreclr#20136)
Commit migrated from https://github.com/dotnet/coreclr/commit/
080617e1c74c3d498a6013684c939709ecaf5646
Bruce Forstall [Mon, 1 Oct 2018 21:41:37 +0000 (14:41 -0700)]
Merge pull request dotnet/coreclr#20201 from jkotas/update-lst
Delete removed tests from Tests.lst
Commit migrated from https://github.com/dotnet/coreclr/commit/
232c9e9c8f2e5e341f68ce57adbaaa96edbe5596
Andy Ayers [Mon, 1 Oct 2018 18:53:21 +0000 (11:53 -0700)]
Fix test for GT_INDEX_ADDR to forcibly compile with minopts
Update test introduced in dotnet/coreclr#20047 so that the key method `ReadBytes` is compiled
with minopts by default.
Commit migrated from https://github.com/dotnet/coreclr/commit/
80334f6ed542a79aefc61f6f1ca25dc4a5755fb3
Luqun Lou [Mon, 1 Oct 2018 16:47:14 +0000 (09:47 -0700)]
Add back ExeFile directory for non-Windows (dotnet/coreclr#20192)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffe1cd63154b4681fea7bb4429c8f5b23958017d
Jan Kotas [Sun, 30 Sep 2018 15:24:01 +0000 (08:24 -0700)]
Delete removed tests from Tests.lst
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f0ffe7b3527cc47fe07875584ed155d423a9748
Stephen Toub [Sat, 29 Sep 2018 23:12:48 +0000 (19:12 -0400)]
Improve Guid parsing performance (dotnet/coreclr#20183)
* Improve Guid parsing performance
Significantly improves the performance of parsing all Guid number styles, primarily by avoiding using the StringToInt core helper that was used previously to parse each of the consistuent components, as well as avoiding some unnecessary searches of the strings in order to determine which format is employed.
I kept strong compatibility with the existing implementation, down to what exceptions are thrown when (even when they’re a bit strange). However, there are a few cases where the error messages in those exceptions differ from what they previously were, due to ambiguities, and IMO it not being worth making the implementation slower to try to maintain the exact same choice. For example, the string “{0xdddddddd, 0xdddd 0xdddd,{0xdd,0xdd,0xdd,0xdd,0xdd,0xdd,0xdd,0xdd}}” isn’t parsable, because it’s missing a comma between the second and third components, and with whitespace removed the parser will try to parse “0xdddd0xdddd” and fail to do so. Previously that would result in an error message “Additional non-parsable characters are at the end of the string”, and now it’ll result in an error message “Guid string should only contain hexadecimal characters.” Similarly, “(-ddddddd-dddd-dddd-dddd-
dddddddddddd)” would previously fail with “Unrecognized Guid format”, and now it’ll also fail with “Guid string should only contain hexadecimal characters.”
* Undo int->uint / short->ushort field changes
* Address PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
c04fee1611a7ad7075bc28d9c4e0546ccdad8b30
Jan Kotas [Sat, 29 Sep 2018 13:37:45 +0000 (06:37 -0700)]
Simplify SafeBuffer.Initialize implementation (dotnet/coreclr#20198)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecbbcf6edab9c4fb723bd59fba04c8177c977840
Jeremy Koritzinsky [Sat, 29 Sep 2018 06:37:34 +0000 (23:37 -0700)]
Unify argument verification for Marshal.GetHINSTANCE off-Windows (dotnet/coreclr#20130)
Commit migrated from https://github.com/dotnet/coreclr/commit/
87e96eafa84545335dd6ec02cb4e233211456677
Jan Kotas [Sat, 29 Sep 2018 06:33:00 +0000 (23:33 -0700)]
Delete redundant framework API tests (dotnet/coreclr#20187)
Contributes to dotnet/coreclr#12782
Commit migrated from https://github.com/dotnet/coreclr/commit/
21d2d302b3eec9d72493b28028784c39cc531a73
Sergey Andreenko [Sat, 29 Sep 2018 01:57:29 +0000 (18:57 -0700)]
Make `structType` optional in jitEEInterface method `getFieldType`. (dotnet/coreclr#20191)
* Make `structType` optional in `getFieldType`.
The declaration in corinfo.h says: "if 'structType' == 0, then don't bother the structure info". However, `getFieldTypeInternal ` did not check this case.
* Do not bother the structure info when we do not need it from `getFieldType`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f7f0929a468f9a4d115b51da0dc5b9328413352c
Stephen Toub [Sat, 29 Sep 2018 00:05:29 +0000 (20:05 -0400)]
Avoid allocation in Task.Yield() awaiter (dotnet/coreclr#20186)
Now that IAsyncStateMachineBox is an IThreadPoolWorkItem, we can queue it directly in Task.Yield's awaiter. This makes `await Task.Yield();` allocation-free when the default scheduler is used.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d14e3a60dd9eff95e60b919cf30fd9f306e0e75
Fei Peng [Fri, 28 Sep 2018 22:59:44 +0000 (15:59 -0700)]
Add pointer overloads for Avx2.BroadcastScalarToVector256
Commit migrated from https://github.com/dotnet/coreclr/commit/
c3a34c5ce75d3f38495300325a800bda40c55a42
Egor Chesakov [Fri, 28 Sep 2018 22:30:26 +0000 (15:30 -0700)]
Specify configuration to runtest.sh to make runtest.py use the correct build_type value (dotnet/coreclr#20188)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c6ef88d88fe8c95323247393c04e6b161da3bb0e
Drew Scoggins [Fri, 28 Sep 2018 22:17:32 +0000 (15:17 -0700)]
Merge pull request dotnet/coreclr#20152 from DrewScoggins/UpdateIBCDeps
Update ibc deps
Commit migrated from https://github.com/dotnet/coreclr/commit/
be944fae4506939e7dbe322148c35826c4bc9dd3
Jan Vorlicek [Fri, 28 Sep 2018 20:09:24 +0000 (22:09 +0200)]
Enable delegate marshalling for collectible types (dotnet/coreclr#20158)
* Enable delegate marshalling for collectible types
This change is trivial - it just removes checks preventing the delegate
marshalling for collectible types. The unmanaged to managed thunks are
allocated from a global LoaderAllocator and they are released when the
corresponding managed delegates are collected. So for unloadability, we
don't need to change this behavior in any way.
* Disable CoreFX tests outdated by the change
Commit migrated from https://github.com/dotnet/coreclr/commit/
49209e181103006603e2cf4e05dccb564bef537d
Tanner Gooding [Fri, 28 Sep 2018 18:02:55 +0000 (11:02 -0700)]
Updating NumberToStringFormat to not print the sign if there are no digits being returned (dotnet/coreclr#20109)
Commit migrated from https://github.com/dotnet/coreclr/commit/
98aff4a23a2ecf8d823ece9b201045f52aa0624a
Luqun Lou [Fri, 28 Sep 2018 17:15:12 +0000 (10:15 -0700)]
Enable BSTR Marshaling Support for x-plat PInvoke (dotnet/coreclr#19766)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f90b65858d7ca0604e7aa1a1d04e9e5261e7f7af
dotnet-maestro-bot [Fri, 28 Sep 2018 15:48:15 +0000 (08:48 -0700)]
Update CoreClr, CoreFx to preview1-26928-03, preview1-26928-03, respectively (dotnet/coreclr#20180)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a67ce5980d6457f1af91b088fed7b95400aa7def
Alexander Soldatov [Fri, 28 Sep 2018 15:16:29 +0000 (18:16 +0300)]
Added transcript of ARMEnabled. (dotnet/coreclr#20181)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c4bf09d95011c0b4f86be1001b228b337a11fdd4
dotnet-maestro-bot [Fri, 28 Sep 2018 11:25:33 +0000 (04:25 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26928-01, preview1-26928-01, preview1-26928-01, respectively (dotnet/coreclr#20175)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c07b543de35c626db2c2b380fd1f4eeccaa5fce0
Stephen Toub [Fri, 28 Sep 2018 00:13:27 +0000 (20:13 -0400)]
Avoid AwaitTaskContinuation allocation in some awaits (dotnet/coreclr#20159)
In .NET Core 2.1, I added a bunch of optimizations to async methods that are based on reusing the async state machine object itself for other purposes in order to avoid related allocations. One of those optimizations was using the boxed state machine itself as the continuation object that could be queued onto a Task, and in the common case where the continuation could be executed synchronously, there would then not be any further allocations. However, if the continuation needed to be run asynchronously (e.g. because the Task required it via RunContinuationsAsynchronously), the code would allocate a new work item object and queue that to the thread pool to execute. This then also forced the state machine object to lazily allocate the Action delegate for its MoveNext method. This PR extends the system slightly to also cover that asynchronous execution case, by making the state machine box itself being queueable to the thread pool. In doing so, it avoids that AwaitTaskContinuation allocation and also avoids forcing the delegate into existence. (As is the case for other optimizations, this one is only employed when ETW logging isn't enabled; if it is enabled, we need to flow more information, and enabling that would penalize the non-logging case.)
Commit migrated from https://github.com/dotnet/coreclr/commit/
03ead514a3aa414b26246a4160d0593811fd1044
Fei Peng [Thu, 27 Sep 2018 23:54:46 +0000 (16:54 -0700)]
Optimize SSE2 intrinsic importation
Commit migrated from https://github.com/dotnet/coreclr/commit/
945b636566de8756742de1b3488f8c3db7333ca1
Fei Peng [Thu, 27 Sep 2018 23:54:10 +0000 (16:54 -0700)]
Re-enable hardware intrinsic tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
225391f8238914f224f6a67707753e14fe13ae85
dotnet-maestro-bot [Thu, 27 Sep 2018 20:09:51 +0000 (13:09 -0700)]
Update CoreClr, CoreFx, CoreSetup, PgoData to preview1-26927-03, preview1-26927-03, preview1-26927-01, master-
20180926-0038, respectively (dotnet/coreclr#20153)
Commit migrated from https://github.com/dotnet/coreclr/commit/
883cc1a1d611727e47332507cbfbac01c36c6dec
Stephen Toub [Thu, 27 Sep 2018 18:58:18 +0000 (14:58 -0400)]
Fix CancellationTokenRegistration.Dispose racing with cancellation (dotnet/coreclr#20145)
CancellationTokenRegistration.Dispose is guaranteed to only return when the associated callback has already finished running or has been successfully removed such that it'll never run. This is to ensure that code following Dispose can be guaranteed that the callback isn't currently running and won't after that point, as if it did, it could potentially depend on mutable shared state or itself mutate shared state in a non-thread-safe manner.
However, significant optimizations introduced in .NET Core 2.1 impacted a specific case of this guarantee. It still behaves correctly if cancellation hasn't already been requested, if cancellation has already processed the associated callback, and even if cancellation is currently executing the associated callback. However, if cancellation is currently processing other callbacks and hasn't yet gotten around to processing the associated one, Dispose() may incorrectly return immediately, such that the callback may still end up getting invoked after Dispose() returns, which can violate assumptions of consuming code in very impactful ways.
This commit modifies how the callbacks are removed from the registration list in order to fix the issue. Previously, all of the callbacks were swapped out at once, which then left the list empty, which is what caused subsequent disposals to think the callback had already been processed or unregistered. With this change, we instead just remove each registration as it's being processed, such that a concurrent disposal can still successfully find the registration in the callback list if it's not yet been processed.
This change does have a small perf impact, but only on the case where cancellation is actually invoked, which is the less common case; most usage of CTS doesn't actually result in cancellation, and optimization is focused on registration and unregistration perf. Rather than taking and releasing the lock once when cancellation is requested, we now take and release the lock per callback when cancellation is requested.
Commit migrated from https://github.com/dotnet/coreclr/commit/
552f4bf7addc944d85f4604fd2fe228ac984412d
Egor Chesakov [Thu, 27 Sep 2018 18:28:17 +0000 (11:28 -0700)]
Enable Ubuntu arm Cross Release crossgen_comparison scenario by default (dotnet/coreclr#20160)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c11f789873e46a53b42bb1c91ce81c3669ca7145
Egor Chesakov [Thu, 27 Sep 2018 16:01:39 +0000 (09:01 -0700)]
Merge pull request dotnet/coreclr#19960 from echesakovMSFT/UseCrossBitnessLinuxCrossGenByDefault
Use Hostx64/arm crossgen to crossgen System.Private.CoreLib on Linux
Commit migrated from https://github.com/dotnet/coreclr/commit/
9404b663a48979d3dc4b7545077ceb627d539dde
Michelle McDaniel [Thu, 27 Sep 2018 14:28:36 +0000 (07:28 -0700)]
Replace Crst* with CrstStatic for IBCLogger (dotnet/coreclr#20148)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d9eed70cfc299906c94e0f2722c7d39f777f27d
Viktor Hofer [Thu, 27 Sep 2018 04:43:48 +0000 (06:43 +0200)]
Maestro dependency update without buildtools (dotnet/coreclr#20143)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, PgoData to preview1-03224-03, preview1-26925-05, preview1-26925-06, preview1-26925-01, master-
20180925-0031, respectively
* Enable RestoreOutputPath override
* Disable System.Security.Cryptography.Pkcs.Tests
To help unblock corefx, etc. update.
* Revert buildtools changes
* Disable buildtools auto updates
Commit migrated from https://github.com/dotnet/coreclr/commit/
0bc8c62cfb7514b91b4ebd5f073835391e0502a3
Egor Chesakov [Thu, 27 Sep 2018 02:52:44 +0000 (19:52 -0700)]
Enable Ubuntu arm crossgen_comparison Checked in each PR (dotnet/coreclr#20139)
* Run Ubuntu arm crossgen_comparison (Checked | Release) daily
* Enable Ubuntu arm Checked crossgen_comparison by default
Commit migrated from https://github.com/dotnet/coreclr/commit/
6dc2556a685674ecb9c716aa21720f2295ff8df0
Egor Chesakov [Thu, 27 Sep 2018 02:47:18 +0000 (19:47 -0700)]
Cross-bitness in VTable Calls (dotnet/coreclr#20137)
* Use TARGET_POINTER_SIZE in CEEInfo::getMethodVTableOffset in src/vm/jitinterface.cpp
* Use SIZEOF__MethodTable_ in src/vm/methodtable.h
Commit migrated from https://github.com/dotnet/coreclr/commit/
be18f2b4a7e0a4f7257df048e92d64a73035ed92
Sergey Andreenko [Wed, 26 Sep 2018 23:48:13 +0000 (16:48 -0700)]
Do not treat a custom layout as overlapping when trying to inline a struct method. (dotnet/coreclr#20141)
* Do not treat custom layout as overlapping when trying to inline struct method.
That hack was added 4 years ago with independent struct promotion for parameters.
I was not able to find any related issues.
This change produces asm diffs because it allows us to inline more (lvaCanPromoteStructVar is a multiplier for
inlineIsProfitable parameter).
For System.Private.CoreLib we have total bytes of diff: 294 (0.01% of base).
For example, we started to inline methods from 'System.Threading.Tasks.ValueTask' that has '[StructLayout(LayoutKind.Auto)]'.
* Always sort fields in lcCanPromoteStructType.
It will be optimized away in the future commits.
* Delete the argument that is no longer used.
* Fix variable name according to jit-coding-conventions.
Rename 'StructPromotionInfo' to 'structPromotionInfo'.
Commit migrated from https://github.com/dotnet/coreclr/commit/
24bbc37eb70895b6d7cc9cc95b8453742cdc0cae
Jacek Blaszczynski [Wed, 26 Sep 2018 23:47:14 +0000 (01:47 +0200)]
Remove deleted HW intrinsic tests from exclusion lists for Windows arm, arm64 targets (dotnet/coreclr#20151)
Fixes dotnet/coreclr#20149
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1a9f1fdb0ef7a9dbf1659a419a0bf064c38106e
Bruce Forstall [Wed, 26 Sep 2018 23:09:10 +0000 (16:09 -0700)]
Merge pull request dotnet/coreclr#20098 from dotnetrt/fix-win-unix-format
[CI] Fix failures in Windows/Linux CI Formatting jobs by force killing all dotnet processess
Commit migrated from https://github.com/dotnet/coreclr/commit/
5addb2d0ca2e845d8bb512eab9b6f221092cafa0
Drew Scoggins [Wed, 26 Sep 2018 22:44:33 +0000 (15:44 -0700)]
Update BuildInfoPaths for PGO and IBC packages
Commit migrated from https://github.com/dotnet/coreclr/commit/
d79d5e08dc9d38f8464a3242e046c4058797eebc
Jeremy Koritzinsky [Wed, 26 Sep 2018 22:38:24 +0000 (15:38 -0700)]
Merge pull request dotnet/coreclr#20132 from jkoritzinsky/fixes/coreclr/7829
Fix possible overflow in SafeBuffer.Initialize.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c7e9526b108c10360b71f7649e118831c54399ea
Drew Scoggins [Wed, 26 Sep 2018 20:34:21 +0000 (13:34 -0700)]
Update dependencies.props to fix typo
In the XmlUpdateStep item for the IBC data had a typo and was called
Data not IbcData. This was causing Maestro to not update the
IbcCurrentRef automatically.
Commit migrated from https://github.com/dotnet/coreclr/commit/
fc3e4cb86fd7effe7e76b6c4a3f29b762a113999
Bruce Forstall [Wed, 26 Sep 2018 18:17:16 +0000 (11:17 -0700)]
Merge pull request dotnet/coreclr#19939 from mikedn/visit-cmpxchg
Fix incorrect CMPXCHG visiting order
Commit migrated from https://github.com/dotnet/coreclr/commit/
da1ad5976a8002612cb8aef23aecd3a47f6453be
Jeremy Koritzinsky [Wed, 26 Sep 2018 17:57:18 +0000 (10:57 -0700)]
Remove duplicated test
Commit migrated from https://github.com/dotnet/coreclr/commit/
ae752f0e0a31784b30c7283c959c83c59ed2a154
Jeremy Koritzinsky [Wed, 26 Sep 2018 17:39:43 +0000 (10:39 -0700)]
Add outdated test to CoreFX.issues.json
Commit migrated from https://github.com/dotnet/coreclr/commit/
904e0f142ff5e48e563a0e22f422e758ffab6c9e
Jeremy Koritzinsky [Wed, 26 Sep 2018 17:31:58 +0000 (10:31 -0700)]
PR Feedback and exclude regression test on 64-bit processes.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f211a76a9e45f2ed7e5f515810e0e04e97520ff2
Luqun Lou [Wed, 26 Sep 2018 16:32:26 +0000 (09:32 -0700)]
Use platformdefines through lib instead of cpp (dotnet/coreclr#19948)
* Use platformdefines through lib instead of cpp
* add a dummy export function
* Remove dummy export
* Compile as Static Library
* revert platformdefines.cpp file
* remove DLL_EXPORT
Commit migrated from https://github.com/dotnet/coreclr/commit/
e2a45dce9a853c3eead8aa635317f5615d60bdb6
Jan Kotas [Wed, 26 Sep 2018 06:07:00 +0000 (23:07 -0700)]
Delete dead .NET Framework activation code (dotnet/coreclr#20134)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5f73ff2758f5c308561716fe8fb8b7cf6bc3cda
Jeremy Koritzinsky [Tue, 25 Sep 2018 23:58:20 +0000 (16:58 -0700)]
Add regression test.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9864e50091aebb4c0c5cca873d94e71f0dd84207
Jeremy Koritzinsky [Tue, 25 Sep 2018 23:45:04 +0000 (16:45 -0700)]
Simpler implementation from PR feedback.
Commit migrated from https://github.com/dotnet/coreclr/commit/
35dff1a2277d583b9d554c853bc4b9a31f6f79a0
Sung Yoon Whang [Tue, 25 Sep 2018 23:18:14 +0000 (16:18 -0700)]
Porting fix on Desktop for VirtualUnlock perf issue on WKS GC when we reset mem (dotnet/coreclr#20115)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b67d2fa8fc8cf5b8c41f5c34b1abe31e704386c4
Jeremy Koritzinsky [Tue, 25 Sep 2018 21:54:26 +0000 (14:54 -0700)]
Fix possible overflow in SafeBuffer.Initialize.
Since a 0-length buffer is technically possible (though not very usable), have sizeOfEachElement==0 -> ByteLength == 0.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c288c367db3dc7c296e67a4bb2fff84f0f93c3f
Egor Chesakov [Tue, 25 Sep 2018 18:51:42 +0000 (11:51 -0700)]
Merge pull request dotnet/coreclr#19979 from echesakovMSFT/CrossGenComparisonSymbolFiles
CrossGen comparison - compare debugging files
Commit migrated from https://github.com/dotnet/coreclr/commit/
694d8d7fd2fb5d5cf0f664a185d94fea1166ae2f
Jacek Blaszczynski [Tue, 25 Sep 2018 17:11:26 +0000 (19:11 +0200)]
Add header files to ildasm, ilasm vcxproj (dotnet/coreclr#20052)
Commit migrated from https://github.com/dotnet/coreclr/commit/
659af58047a949ed50d11101708538d2e87f2568
Bruce Forstall [Tue, 25 Sep 2018 16:55:29 +0000 (09:55 -0700)]
Merge pull request dotnet/coreclr#20107 from dotnet/dev/unix_test_workflow
Improve Linux arm32/arm64 corefx test runs
Commit migrated from https://github.com/dotnet/coreclr/commit/
1496647a946279908acd8d03210ac3ad114204d2
Sergey Andreenko [Tue, 25 Sep 2018 16:38:42 +0000 (09:38 -0700)]
switch to netcoreapp2.0 (dotnet/coreclr#20120)
Allows to get rid of warning " CSC : warning CS1685: The predefined type 'MarshalByRefObject' is defined in multiple assemblies in the global alias;".
Commit migrated from https://github.com/dotnet/coreclr/commit/
337f0e0fc4ee05106909e3d881279dc4d494e36f
Jacek Blaszczynski [Tue, 25 Sep 2018 14:20:05 +0000 (16:20 +0200)]
Add headers to cordb{di, ee_dac, ee_wks}.vcxproj files to improve developer experience (dotnet/coreclr#20049)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2e56748c414f9ead45b9730a0a7fb364f751ab83
Jan Vorlicek [Mon, 24 Sep 2018 23:51:44 +0000 (01:51 +0200)]
Fix hijacking for ARM/ARM64/x86 on Unix (dotnet/coreclr#20042)
* Fix hijacking for ARM/ARM64/x86 on Unix
We were not checking the case when we have interrupted a thread inside
of a function epilog for other architectures than amd64. When such an
interruption happens, GS cookie check in a stack walking has failed,
since we are unable to decode GS cookie location when the IP is in
epilog.
This fix implements IsIPInEpilog for all architectures and makes the
check unconditional.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3984776548d45f1ac06f791c8ee8658d7927fad
Davis Goodin [Mon, 24 Sep 2018 23:48:05 +0000 (18:48 -0500)]
Don't check for libintl.h on Darwin (OSX) (dotnet/coreclr#20094)
Commit migrated from https://github.com/dotnet/coreclr/commit/
4e4665f127d2ec8f361ad068690f79be20a63280
Sergey Andreenko [Mon, 24 Sep 2018 23:03:36 +0000 (16:03 -0700)]
clean code that counts promoted implict byref argument occurrences. (dotnet/coreclr#20113)
* clean code that counts promoted implict byref argument occurrences.
Move 3 copies of that code into one in `PreOrderVisit`. Run this check after we have made morph for fields and structs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bcb2a56138685748c5a8c1d8c973ff1a51c81883
Jan Kotas [Mon, 24 Sep 2018 21:19:05 +0000 (14:19 -0700)]
Simplify OSVERSIONINFOEX interop (dotnet/coreclr#20111)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f0c406fc9f56e9ad2ae6f7138b88c15e96d0716
谭九鼎 [Sun, 23 Sep 2018 18:52:46 +0000 (02:52 +0800)]
Remove unnecessary parenthesis (dotnet/corefxdotnet/coreclr#32419)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
72ba9e20d488a85e8a7eac0ff62a01968a2f6be5
Bruce Forstall [Sat, 22 Sep 2018 06:10:55 +0000 (23:10 -0700)]
Improve Linux arm32/arm64 corefx test runs.
Add proper parallelism.
Prevent per-test output during parallel runs from interleaving
by saving output per process and displaying it after the
process has completed.
Improve summary test/failure output at end of log.
Change Linux arm32/arm64 corefx jobs to run tests in parallel.
Change Linux/arm64 corefx scheduled jobs to be daily, not weekly,
since they are very fast when run in parallel (<20 minutes).
Commit migrated from https://github.com/dotnet/coreclr/commit/
07b8ea2ca94fc519c68f211e1494ebc7ccd588f1
Bruce Forstall [Fri, 21 Sep 2018 22:50:17 +0000 (15:50 -0700)]
Move run-tests.sh from corefx
This is the script used by Jenkins to run arm32/arm64 corefx testing
in the coreclr repo.
Leave the original one around, in case anyone uses it.
Name it run-corefx-tests.sh, to more closely model what we have for
Windows arm/arm64 corefx testing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a08d45d8dab3e8a0154d2e9fbc51afd3dd4159df
Tanner Gooding [Sat, 22 Sep 2018 13:43:30 +0000 (06:43 -0700)]
Porting NumberToDouble to managed code. (dotnet/coreclr#20080)
* Porting NumberToDouble to managed code.
* Deleting bcltype/number.cpp and bcltype/number.h
* Fixing NumberToDouble to call Int64BitsToDouble, rather than DoubleToInt64Bits
* Some minor code cleanup in NumberToDouble for better readability.
* Some additional code cleanup in the Number.NumberToDouble.cs code
Commit migrated from https://github.com/dotnet/coreclr/commit/
09cc49e8cac72915b72240c766e25ada171e9fe7
Jacek Blaszczynski [Fri, 21 Sep 2018 23:30:49 +0000 (01:30 +0200)]
Fix failures in Windows/Linux CI Formatting jobs by killing all dotnet processess
Use shell commands to kill all processess with dotnet/dotnet.exe name before
attempting the final cleanup of the CI workspace
Commit migrated from https://github.com/dotnet/coreclr/commit/
29025ba85295cf0f1d3a1b45dcbc3be96ad74690
Egor Chesakov [Thu, 20 Sep 2018 22:56:12 +0000 (15:56 -0700)]
Address PR feedback - Cleanup temp dirs after usage
Commit migrated from https://github.com/dotnet/coreclr/commit/
223a88c02050887b5284ca334c5fbbef9180df9e
Bruce Forstall [Sat, 22 Sep 2018 01:17:24 +0000 (18:17 -0700)]
Merge pull request dotnet/coreclr#20095 from BruceForstall/Disable80373
Disable test b80373 for all non-Windows targets
Commit migrated from https://github.com/dotnet/coreclr/commit/
99bf5ce15efc1179b47d1e1d1522673a30ae8628
Ahson Khan [Sat, 22 Sep 2018 00:47:47 +0000 (17:47 -0700)]
Streamline MemoryExtension Trim and Trim(char) by removing calls to TrimStart/End and avoiding unnecessary Slice. (dotnet/coreclr#19959)
* Mark TrimStart and TrimEnd as Aggressively Inline to improve perf
* Remove inlining attribute and streamline Trim
Commit migrated from https://github.com/dotnet/coreclr/commit/
1fd5caec53c82d437d7c792d3dbf3e9f6a43e018
Billy O'Neal [Fri, 21 Sep 2018 23:02:58 +0000 (16:02 -0700)]
Add missing <cmath> header for fabs to fix Visual C++ vNext break, av… (dotnet/coreclr#20079)
* Add missing <cmath> header for fabs to fix Visual C++ vNext break, avoid narrowing to float from double
Commit migrated from https://github.com/dotnet/coreclr/commit/
a6474505115fe45fb1cef161e7ba71c30c62001a
Bruce Forstall [Fri, 21 Sep 2018 22:14:48 +0000 (15:14 -0700)]
Disable test b80373 for all non-Windows targets
Tracked by dotnet/coreclr#20024
Commit migrated from https://github.com/dotnet/coreclr/commit/
cadedd4bc656ec50f00658ac4c065ab55b82bb14
Brian Sullivan [Fri, 21 Sep 2018 21:01:11 +0000 (14:01 -0700)]
Merge pull request dotnet/coreclr#20033 from briansull/normalizeAssertionProp
Changes to use VNNormalValue in assertionProp
Commit migrated from https://github.com/dotnet/coreclr/commit/
48095cba91577ded6a440e05a969a81fa85b0b88
Andrew Arnott [Fri, 21 Sep 2018 17:13:43 +0000 (10:13 -0700)]
Fix copy-paste error in xml doc comment (dotnet/corefxdotnet/coreclr#32388)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
53e92937a5a8cc454921b55c7a296d3ab7bedf96
Michelle McDaniel [Fri, 21 Sep 2018 16:48:31 +0000 (09:48 -0700)]
Move smoketests to new helix queue (dotnet/coreclr#20090)
Commit migrated from https://github.com/dotnet/coreclr/commit/
deb192495ca8e9f7b02786ffe31067b8fbcfd32e
Marek Safar [Fri, 21 Sep 2018 15:07:36 +0000 (17:07 +0200)]
Simplifies UTF32Encoding/UTF8Encoding/UnicodeEncoding ctors initialization flow (dotnet/coreclr#20072)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6654fd3e291128f1d2dee9e0a1ee49d1fd612dff
Simon Nattress [Thu, 20 Sep 2018 20:47:09 +0000 (13:47 -0700)]
Fix decoding bug in r2rdump's native format reader
Sign extension is done based on a 32-bit int. We were incorrectly basing it off the size of a byte.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6410f031da3dd7f25dce79ad29fa348733598df2
Fadi Hanna [Fri, 21 Sep 2018 05:06:48 +0000 (22:06 -0700)]
Performance fix for R2R: vtable calls (dotnet/coreclr#20061)
* Performance fix for R2R: use vtable-based codegen for virtual calls within the System.Private.CoreLib version bubble, avoiding the use of the VSD, or in the generics case, a dictionary lookup.
The CoreLib assembly will always be serviced along side the coreclr runtime, so special casing CoreLib to using vtable-based calls like the fragile NI case is ok.
Commit migrated from https://github.com/dotnet/coreclr/commit/
0149085e0156e357d7cfc2fe28c3f62355027167
Mike McLaughlin [Fri, 21 Sep 2018 04:28:27 +0000 (21:28 -0700)]
Fix issue dotnet/coreclr#20076 createdump faults. (dotnet/coreclr#20084)
Return E_FAIL instead of S_FALSE from ClrDataFrame::GetLocalSig().
Also issue https://github.com/dotnet/diagnostics/issues/61
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1cf6e7172ae0f0fc3c4617c810d71c514c5e0ba
Simon Nattress [Wed, 19 Sep 2018 17:24:02 +0000 (10:24 -0700)]
Make EH table optional in R2RDump
Ready-to-run binaries don't always have an EH table. Fix r2rdump so it doesn't crash if the table isn't present.
Commit migrated from https://github.com/dotnet/coreclr/commit/
10e34eb55c3bb0a16969b45c97e12b275549ec20