Jaeun Choi [Wed, 16 May 2018 11:33:58 +0000 (20:33 +0900)]
evas: modify return value for compatibility
@tizen_only
Change-Id: I33b8215113ce5761289454e85636ab40d5b17191
Jaeun Choi [Wed, 16 May 2018 08:20:50 +0000 (17:20 +0900)]
evas: maintian return value of deprecated APIs for compatibility
@tizen_only
Change-Id: I1216b7cdca1b559ad2a73c022f846494a8642768
Jaeun Choi [Tue, 15 May 2018 12:34:55 +0000 (21:34 +0900)]
evas: modify return value for compatibility
@tizen_only
Change-Id: If19d0cc76c8e80feeebf30a7f7d157762687da57
Jaehyun Cho [Mon, 11 Jun 2018 11:11:42 +0000 (20:11 +0900)]
elm_spinner: Fix typo
Change-Id: Ife0fd94116220b0f91e64d6ba23e9f42a024c00b
Woochan Lee [Thu, 17 May 2018 06:59:59 +0000 (15:59 +0900)]
elm_spinner: Call changed callback when value changed in min_max_set() API.
@tizen_feature
Change-Id: I4bcc15422852b3c9aa5411c4a2a3575bf65ce697
Jaehyun Cho [Mon, 11 Jun 2018 08:17:43 +0000 (17:17 +0900)]
elm_focus: Restore legacy focus of tizen genlist
This commit is a part of missing code of
2a28a50a105b2262e84388a45fc8af04c2b48e15
@tizen-fix
Change-Id: Ia791e204043aeafc892a04f8add8632c2de35c48
Taehyub Kim [Fri, 4 May 2018 08:47:56 +0000 (17:47 +0900)]
efl_ui_dnd: fix the TC break
Change-Id: I848d2c6e1530a8ad1141d1d7024525c5d09456c9
Taehyub Kim [Fri, 4 May 2018 02:08:03 +0000 (11:08 +0900)]
cbhm_helper: fixed the memory leak for coverity
Change-Id: I1de8488d19bf9de1ce3bac7dad147ff5e7da1445
Taehyub Kim [Fri, 11 May 2018 08:06:46 +0000 (17:06 +0900)]
eldbus: remove EINA_DEPRECATED for removing warning message
Change-Id: I69da5509a8eafd29fcdeef69b9d85170cfd477ce
Taehyub Kim [Mon, 2 Apr 2018 12:48:36 +0000 (21:48 +0900)]
eldbus: deprecate eldbus APIs
Change-Id: If2dd327f94a1cc29c7f600778553080337b013d0
Shinwoo Kim [Thu, 10 May 2018 06:39:04 +0000 (15:39 +0900)]
evas_render: disable render cache feature
Following commit added render cache feature.
commit
69cb85aaca1e8d6bd7ef070fc1f2a3cb78b838f6
Author: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Sat Nov 26 10:47:34 2016 +0900
evas render - cache object arrays rto avoid processing them in phase1
It has an issue. If a smart object does not changed...
i.e. obj_changed in _evas_render_phase1_object_process does not changed,
then _evas_render_phase1_object_(no_)changed_smart does not call
_evas_render_phase1_object_process using its smart members at all.
So even though there is a changed smart member object, the object cannot be
rendered. The following would be the issue case.
smart object A - changed: 0 -> 0
smart member B of A - changed: 1 -> 1
smart member C of B - changed: 0 -> 1
Moreover, the changed value of C is changed but it cannot make change the
value of A, because the value of B is aready 1. see evas_object_change.
@tizen_only
Change-Id: Ifaf9b4d58f2c87cac79a3b37102955d4877ea9bd
Jongmin Lee [Wed, 23 May 2018 01:25:14 +0000 (10:25 +0900)]
efl: generate efl-locale package when generating elementary package
@tizen_fix
Change-Id: I72485bcdb355e69adbce1cd226abf6b04fcceba1
Jongmin Lee [Fri, 11 May 2018 08:04:31 +0000 (17:04 +0900)]
efl: use tizen_profile_name build macro instead of TIZEN_PRODUCT_TV
replacing TIZEN_PRODUCT_TV build macro into tizen_profile_name build macro
since TIZEN_PRODUCT_TV build macro is deprecated.
@tizen_fix
Change-Id: I86b32e28083b235d999f172826a4c20bdf898759
Jongmin Lee [Thu, 10 May 2018 01:26:00 +0000 (10:26 +0900)]
efl: support elementary optional build
add --with-elementary=[elm/efl/both] to configure option.
By default, "--with-elementary=both" option is applied.
@tizen_feature
Change-Id: I34d00cb30063087526602a355287a0495e2723f9
Jongmin Lee [Mon, 30 Apr 2018 03:59:42 +0000 (12:59 +0900)]
Elementary: Move eldbus dependency from public header to private header
Since eldbus is deprecated and removed in Tizen for the security reason,
Eldbus header dependency in Elementary public header should be removed
in order to hide it to application developer who use Tizen SDK.
@tizen_fix
Change-Id: I4f92529fc7185c17e2700c576ef3fe40a1a33120
Jiyoun Park [Fri, 18 May 2018 08:14:34 +0000 (17:14 +0900)]
efl_ui_win: fix double free bug related with fake window
fake window should call ecore_wl2_window_free only when it make ecore_wl2_window by itself
Change-Id: I2f8d4bba93aea2f66cf9a25a7dfbbe2471cfcaa8
Myoungwoon Roy, Kim [Fri, 11 May 2018 05:25:31 +0000 (14:25 +0900)]
ecore_con: Check valid port number
Add a handling code to check valid port number input
Change-Id: I6655202dd5e2b3aff674d900c2917a5005a1f776
Myoungwoon Roy, Kim [Thu, 10 May 2018 09:57:44 +0000 (18:57 +0900)]
evas_out: Restores evas_out APIs
Restores evas_out_add, evas_output_del, evas_output_view_get APIs for backward compatibility.
Change-Id: Ia4b44f222ee13df166337a4ad93c0222349cf7b6
Youngbok Shin [Fri, 8 Jun 2018 10:16:53 +0000 (19:16 +0900)]
efl_ui_layout: fix build failure casued by renamed Eo class
@tizen_fix
Change-Id: Ifa8555c5fa6eecd80db964dc7aaf7384613f6133
Youngbok Shin [Fri, 8 Jun 2018 10:09:43 +0000 (19:09 +0900)]
entry: fix build break caused by recent changes of Eo
Change-Id: I5620b0cb01f054f2ca970d6de945a19f76b1c31b
Youngbok Shin [Tue, 5 Jun 2018 04:32:33 +0000 (13:32 +0900)]
elementary: add elm_entry_cursor_coord_set/get
@tizen_feature
Change-Id: I9018f8c8d0dcddf2e4ae22aa521b8327f1a5bf9a
Youngbok Shin [Tue, 11 Jul 2017 11:30:53 +0000 (20:30 +0900)]
edje: send cursor,changed signal when cursor is changed by function call
@tizen_fix
Change-Id: Ic905c59a3adc4bf7bc528d5ac3f916478c383866
Youngbok Shin [Fri, 18 May 2018 09:26:08 +0000 (18:26 +0900)]
elementary_tizen: remove unreachable code
@tizen_fix
Change-Id: I2b1da0c190dcfc392e9b2721d6b2caa99239a0b3
Youngbok Shin [Fri, 18 May 2018 09:01:45 +0000 (18:01 +0900)]
elementary: fix wrong non-void return value of void function
@tizen_fix
Change-Id: I5e6085c6d85b2f8cb6f61fa70c09c0c5632b2de7
Youngbok Shin [Tue, 15 May 2018 06:24:38 +0000 (15:24 +0900)]
elementary image: fix elm_image_smooth_scale_* TC fails
It was caused by recent change for fixing no_scale issue.
@tizen_fix
Change-Id: Ie95ecae86ba56ef24f2307fbbd42efb0acaba187
Youngbok Shin [Mon, 14 May 2018 05:26:49 +0000 (14:26 +0900)]
elementary layout: fix elm_layout_text_set to return proper result
It fixes API breaks of upstream EFL.
@tizen_fix
Change-Id: I8b917a7bc0fed8373d2c09f7dfcf61fe1eab4789
Youngbok Shin [Mon, 14 May 2018 05:06:41 +0000 (14:06 +0900)]
elementary entry: support legacy focused/unfocused callback calls
It is needed to replace focus callbacks of reverted new focus feature.
@tizen_fix
Change-Id: Iffed6f8e09a636575b83ab61b93fb956a2480046
Youngbok Shin [Fri, 11 May 2018 05:27:36 +0000 (14:27 +0900)]
elementary label: restore label size calc logic from Tizen 4.0
@tizen_fix
Change-Id: Ic636e617a87a23b8572467d32df063b4a58c041b
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Youngbok Shin [Mon, 13 Nov 2017 06:22:33 +0000 (15:22 +0900)]
evas text: update paragraph direction before layouting its text
It fixes the following issue.
- Edje's alignment is not updated when paragraph direction is changed.
@tizen_fix
Change-Id: Ic7b5e35d82e2e6615f5dd7ebc39667611ca400e0
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Youngbok Shin [Wed, 9 May 2018 04:58:33 +0000 (13:58 +0900)]
evas textblock: fix default values for text alignment
From upstream EFL, the text alignment default values are not handled properly.
@tizen_fix
Change-Id: Id5d14783ac5ac25a5116cc48281509d08bc924d5
Youngbok Shin [Tue, 8 May 2018 13:16:30 +0000 (22:16 +0900)]
elementary: fix layout_part_cursor things and eo hierarchy of part_box/part_table
All elm_layout_part_cursor_* had worked at box and table parts.
After applying new interfaces, all elm_layout_part_cursor_* ignored box/table parts.
It caused a lot of problems. I don't know why part_box/part_table didn't inherit Efl.Ui.Part.
But, it needs Efl.Ui.Part for keeping backward compatiblity.
@tizen_fix
Change-Id: I35152f46d14b6d9f71ad328d0de1d4b8e8e957ce
Youngbok Shin [Wed, 2 May 2018 07:00:43 +0000 (16:00 +0900)]
elementary: remove warning message from paragraph_direction_set/get
@tizen_fix
Change-Id: Id478c1134e812535c4e71ed4b53195431b82cc36
Youngbok Shin [Mon, 30 Apr 2018 06:22:37 +0000 (15:22 +0900)]
elementary cnp: fix duplicated string memory issue
The eina_slice_dup() function does not take care of NULL termination of
a duplicated memory. It caused wrong copy&paste results.
@tizen_fix
Change-Id: I6778ad3c68c508fc391c1bf961501ec65909febc
Hosang Kim [Thu, 24 May 2018 08:06:09 +0000 (17:06 +0900)]
ecore_wl2_window: modified window shutdown location.
_ecore_wl2_window_shutdown should not be called
before _ecore_wl2_init_count is 0.
@fix
Change-Id: Idc3e39ee4da750d6c3189345fff1b9a44d5c7b76
Hosang Kim [Thu, 17 May 2018 12:59:24 +0000 (21:59 +0900)]
ecore_con_url: disable unused initialization.
@tizen_fix
Change-Id: Ib10782eaff0b142df0523c7c958d37bf344d1381
Hosang Kim [Fri, 8 Jun 2018 09:48:31 +0000 (18:48 +0900)]
efl_ui_win: apply precreated window.
@tizen_feature
Change-Id: Ic5b239288f8506a3027006d500799d879422ce2c
Hosang Kim [Mon, 14 May 2018 09:44:00 +0000 (18:44 +0900)]
ecore_event: fix backword compatibility bug for ecore event handler
add missing condition
@tizen
Change-Id: I269362a1e773211e28e458a23b2b38fc04cfd07f
SangHyeon Lee [Thu, 17 May 2018 02:03:40 +0000 (11:03 +0900)]
genlist : refactoring on_focus_update as none legacy case
Change-Id: Ic5655c568aa05abaa65b36d67f6a33a41f5dfd86
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
YeongJong Lee [Wed, 23 May 2018 12:24:37 +0000 (21:24 +0900)]
tizen ctxpopup: fix backward compatibility for "default" name part
If you use legacy content/text set/get/unset with "default" part name,
_elm_layout_part_aliasing_eval change the part name to "elm.swallow.content".
Because internal _content_set/get/unset checked only "default" string,
legacy content/test set/get/unset with "default" part name was not working.
This patch fixes that bug.
Change-Id: I8400a47e6e9d159066ea022cc14945212381b084
YeongJong Lee [Thu, 10 May 2018 11:46:05 +0000 (20:46 +0900)]
elc_ctxpopup: use data(ctxpopup) instead of obj(edje)
Change-Id: Ib43f4a5c32b73ee6086ecc2418cdf5613b32e1fc
Hermet Park [Fri, 8 Jun 2018 07:35:25 +0000 (16:35 +0900)]
ecore_device: fix migration issue.
It doesn't allow efl_add() with no parent.
That case, use efl_add_ref() instead.
Change-Id: I380baa798d2a3199e8651e2f8c6542a42fe2eeab
Jaehyun Cho [Thu, 7 Jun 2018 05:02:02 +0000 (14:02 +0900)]
migration: fix crash in elm_genlist_clear
Change-Id: I17f66605d732d6d67bfec332a75561ea921dcdb2
Daniel Hirt [Thu, 1 Feb 2018 17:24:44 +0000 (19:24 +0200)]
Ui layout: fix another text retrieval line of code
This is a follow-up to
a44ae48df811ff2bd085da86db1688c0f387efc4.Need to
undo the markup_get call, so that the correct code path
(_efl_ui_layout_text_set) is used. Legacy checks are in that code path.
ref T6642
JunsuChoi [Fri, 8 Jun 2018 00:00:56 +0000 (09:00 +0900)]
ecore_con : Fix that null pointer access for segmentation fault
Summary:
"cl->svr" was to be null on line 281.
This problem occurred from
384f30c8ecc9.
Replacing "cl->svr" with "svr" corrects the error
while preserving the changes in
384f30c8ecc9.
Test Plan: N/A
Reviewers: #committers, cedric, Hermet, zmike
Subscribers: bowonryu, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6255
Change-Id: I91c2cf9db48e510a4f6d7c9373de8dedcc634b21
Hermet Park [Fri, 18 May 2018 06:51:43 +0000 (15:51 +0900)]
eo: Turn thread-validation off for unstable Tizen 5.0 apps which are violating thread-safety.
Eo has gotten more strict-check for thread violiation API calls.
Since Tizen 5.0, many apps(which violates EAPI thread safety rules) unexpectedly became unstable cause of thread-validation.
We disable this function for now but wish to remove this temporary code in the near future when apps are ready to go.
Change-Id: Ibbd99d3b26609fca23fd4c5bd029e67f63e3a830
Hermet Park [Thu, 26 Apr 2018 11:20:37 +0000 (20:20 +0900)]
efl_ecore_input_device: unify efl_ecore_input_device in efl_input_device.
Efl_Ecore_Input_Device was introduced wrongly in merging upstream efl.
First, conceptually, efl interface should not allow Ecore.
This is totally wrong in interface design.
Second, Efl_Ecore_Input_Device conceptually same with Efl_Input_Device.
We don't need both interfaces. Even their bodies are perfectly same.
Third, EFl_Ecore_Input_Device is not compatible with Efl_Input_Device,
Whole Events in efl will be passing through with Efl_Input_Device interface,
but their classes are different, Eo will fault in type checking,
Efl_Ecore_Input_Device(or Ecore_Device) won't be passed properly.
All in all, current Efl_Ecore_Input_Device just breaks system and useless.
Change-Id: I276761e67d598457087bd2e3e06f44e58161427f
Hermet Park [Wed, 2 May 2018 06:13:22 +0000 (15:13 +0900)]
ecore_con: update doc.
fix invalid parameter name in doc.
Change-Id: I5d9d27f0fcb412384210af667d6803efc6105fe5
WooHyun Jung [Wed, 25 Apr 2018 11:12:05 +0000 (20:12 +0900)]
elm_spinner: fix wrong use of ev
Legacy ev should be gotten from efl_input_legacy_info_get.
@tizen_fix
Change-Id: I9c4d9ab2a61297f152fcc2eeeabf09ccc3251792
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
WooHyun Jung [Tue, 8 May 2018 06:49:58 +0000 (15:49 +0900)]
focus: onscreen_is should not be checked for keeping compatiblity
@tizen_fix
Change-Id: If81e7b3e49d6813f3d45237fd9f25c2511cc6cbd
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
Jeonghyun Yun [Wed, 23 May 2018 01:45:44 +0000 (10:45 +0900)]
efl_ui_widget: fixed wrong character in _elm_widget_edje_class_get
@tizen_fix
Change-Id: I61bfdc2f331e227b0b7da33c4519a6c81c046cee
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Jeonghyun Yun [Fri, 11 May 2018 02:56:57 +0000 (11:56 +0900)]
elementry: add missing item class and add exception handling code for edjc_class parse
@tizen_fix
Change-Id: I3341c98052d80e2cdbac5cd5468fa82ee70882bd
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Youngbok Shin [Fri, 4 May 2018 06:41:35 +0000 (15:41 +0900)]
elementary: add missing item class names and fix edje_class parse rule for legacy
@tizen_fix
Change-Id: I480cd5a4bac02ba11d806cef25bcdc2d92d74f7a
Youngbok Shin [Mon, 30 Apr 2018 07:52:14 +0000 (16:52 +0900)]
elementary widget: fix missing legacy type for Gesture_Layer
There is a missing legacy type in the table: Elm.Gesture_Layer => Elm_Gesture_Layer
@tizen_fix
Change-Id: I34f002fc037c1453494659518a101087704357d0
WooHyun Jung [Wed, 9 May 2018 15:48:54 +0000 (00:48 +0900)]
elm_interface_scrollable: fix wrong use of animator_del
Change-Id: I7aadec676120a01a53e072952ee085d5b90b246b
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
JunsuChoi [Thu, 17 May 2018 06:37:22 +0000 (15:37 +0900)]
elm_panes : Add deprecated version for deprecated APIs
Deprecated APIs since 5.0
elm_panes_content_left_unset
elm_panes_content_right_unset
Change-Id: I5dee4f4c4be280b15a996fe4f2af12acad64180c
JunsuChoi [Wed, 9 May 2018 10:10:28 +0000 (19:10 +0900)]
efl_access: Support legacy API for elm_atspi_text
Change-Id: Id65cec0f250b8105ad8278763c75d57ea03c5498
Hosang Kim [Mon, 4 Apr 2016 09:37:27 +0000 (18:37 +0900)]
elm_conform: fix condition for recalculating vkbd area.
Vkbd geometry is not (0, 0, 0, 0), when vkbd is hidden in Wayland.
@tizen_fix
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: Icc481af1580d735480d69410391b8072fdbf46da
Hosang Kim [Mon, 9 May 2016 10:34:22 +0000 (19:34 +0900)]
elm_conform: support different thing in Tizen 3.0
In Tizen 2.4, virtual keyboard size is 0 when virtual keyboard is off.
But it is different in Tizen 3.0. So I added one condition before
calculating keyboard size.
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Change-Id: Id76b80bead0bfaf88d681bff45eda325e8818e98
YeongJong Lee [Thu, 7 Jun 2018 04:16:13 +0000 (13:16 +0900)]
elm_focus: Restore legacy focus
@tizen-fix
Change-Id: I3b270f4998386a39818635f8cc8f47011d2059ea
Marcel Hollerbach [Wed, 6 Jun 2018 19:20:11 +0000 (14:20 -0500)]
eo: _efl_unref correctly
Summary:
this function calls _efl_ref in the beginning, so _efl_unref them in the
end. This fixes bugs where wrong evas_object_del is called to often,
which would lead to the internal refcount rising instead of getting to
0.
Reviewers: cedric, zmike, stefan_schmidt, q66
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6246
Derek Foreman [Wed, 6 Jun 2018 17:40:56 +0000 (12:40 -0500)]
ecore: Use poller instead of animator for mem stats
Summary:
Animators shouldn't be used as a general purpose timer mechanism,
we could use a timer, but a poller seems to make more sense as
it limits the impact of the instrumentation on the code it's
instrumenting.
Reviewers: stephenmhouston, zmike
Reviewed By: stephenmhouston, zmike
Subscribers: stephenmhouston, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6251
Mike Blumenkrantz [Tue, 5 Jun 2018 17:13:08 +0000 (12:13 -0500)]
evas engines: do not immediately free native surface when unsetting it
Summary:
this is a longstanding issue which was exposed by recent patches to standardize
object lifecycles. when a native surface is used by multiple images, unsetting
the surface from one image must not destroy the native surface or else the
remaining images
fix T6970
@fix
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6970
Differential Revision: https://phab.enlightenment.org/D6235
Marcel Hollerbach [Tue, 5 Jun 2018 14:56:09 +0000 (10:56 -0400)]
eo: make noref also a special count
Summary:
this brings down the first frame time from 2.0 sec. to something at 0.7
sec.
ref T6983
Reviewers: zmike
Reviewed By: zmike
Subscribers: YOhoho, cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6983
Differential Revision: https://phab.enlightenment.org/D6244
Hermet Park [Tue, 5 Jun 2018 12:36:22 +0000 (21:36 +0900)]
Revert "evas canvas: remove unused goto tag."
This reverts commit
b2f85bb9ed69a4f2baf303b8d58ef7ea44493ea6.
this is a subsquent patch for the previous revert:
77684dc53a5bdaf59fa70917c5f6680825484204
ps. JackDaniel saved efl world from a guy who broke the system and ran away...
Hermet Park [Tue, 5 Jun 2018 11:58:35 +0000 (20:58 +0900)]
Revert "evas: fix a map rendering problem."
This reverts commit
9fcd03952ee51d34871794cb95585f3e589a3bb9.
Just noticed from ManMower, this caused a side-effect that drops
enlightenment performance. I need to check it seriously then
decide again how this patch to be.
Hermet Park [Tue, 5 Jun 2018 11:22:04 +0000 (20:22 +0900)]
elementary widget: fix to trigger object signal emit properly.
This is more generic way to trigger signals for all derived classes of layout.
This fixes the dayselector item signal emit issue as well.
@fix T6981
Daniel Zaoui [Tue, 5 Jun 2018 07:16:27 +0000 (10:16 +0300)]
Test/Genlist: set back selection to item in show/bring test
For some unknown reason, the selected_set has been removed from the
test.
Since no response has been given in D5499, I assume it has been removed
by mistake so I put it back.
YeongJong Lee [Mon, 4 Jun 2018 11:12:50 +0000 (20:12 +0900)]
elm_label: remove needless variable
Reviewers: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6238
YeongJong Lee [Mon, 4 Jun 2018 08:48:06 +0000 (17:48 +0900)]
elementary: fix wrong signal emission
Summary:
When _icon_signal_emit is called, "icon" part always exist. so, it only make
"visible" signal.
this fixes that issue
Test Plan:
elm_object_content_unset(button);
elm_object_content_unset(radio);
elm_object_content_unset(check);
elm_object_content_unset(progressbar);
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6241
Jihoon Kim [Mon, 4 Jun 2018 01:47:55 +0000 (10:47 +0900)]
ecore_imf: turn off autocapital mode in password layout
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
YeongJong Lee [Thu, 31 May 2018 12:04:55 +0000 (12:04 +0000)]
elm_table/grid: remove non-widgets from focus elements.
ref
5a3ee984a1229c069c84e71a109a7d39437d5cc0
Differential Revision: https://phab.enlightenment.org/D6236
YeongJong Lee [Fri, 1 Jun 2018 14:13:14 +0000 (09:13 -0500)]
ee_wayland: remove needless variable
Reviewers: ManMower, zmike
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6239
YeongJong Lee [Fri, 1 Jun 2018 02:36:01 +0000 (11:36 +0900)]
elm_hoversel: inherit elm_button
Summary:
elm_hoversel is legacy widget. it should inherit legacy Elm_Button instead of
Efl.Ui.Button.
this patch also fixes icon signal emit bug.
fixes T6971
Test Plan:
1. elementary_test -to hoversel
2. check that ther is icon (sky) on "Icon + Lebel" hoversel
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers, JackDanielZ, zmike
Tags: #efl
Maniphest Tasks: T6971
Differential Revision: https://phab.enlightenment.org/D6240
Wonki Kim [Tue, 5 Jun 2018 03:36:07 +0000 (12:36 +0900)]
migration: modify elementary-tizen code to match with upstream code
Change-Id: Ide74c1e2eeff990bf2a1899febcb2db56ebccab0
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Mon, 4 Jun 2018 08:06:05 +0000 (17:06 +0900)]
Revert "migration: turn off tizen only elementary"
This reverts commit
43802272a9da1632cae7b0002e1d09eac1f10083.
Change-Id: I729ef9f285fb10c60287494046a51702fee4e8b1
Wonki Kim [Mon, 4 Jun 2018 08:23:20 +0000 (17:23 +0900)]
migration: update elementary-tizen automake script
Change-Id: Ic85a4477b6e90cc249d93067aa29646e17b62715
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Mon, 4 Jun 2018 07:24:24 +0000 (16:24 +0900)]
ecore_input_device: Modify efl_add by efl_add_ref
@tizen_fix
Change-Id: I8ae012abe9101c99a3c8a7adf83a1028406ede35
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Mike Blumenkrantz [Thu, 31 May 2018 18:11:09 +0000 (13:11 -0500)]
gl_common: fix invalid memory access
Summary:
code was added which ignores the comment explicitly warning not to
do what was done here
ref
9e01cf2698d5b24f440d696fd57d469cdc5a6b5f
ref T6970
==4829== Invalid read of size 1
==4829== at 0x246D8F06: evas_gl_common_image_update (evas_gl_image.c:907)
==4829== by 0x246DAA7B: evas_gl_common_image_draw (evas_gl_image.c:1417)
==4829== by 0x246A2AB6: eng_image_draw (evas_engine.c:1240)
==4829== by 0x6A87842: _draw_image (evas_object_image.c:1403)
==4829== by 0x6A8A1BF: _evas_image_render (evas_object_image.c:2171)
==4829== by 0x6A890C1: evas_object_image_render (evas_object_image.c:1868)
==4829== by 0x6B09C82: evas_render_mapped (evas_render.c:2292)
==4829== by 0x6B0CE90: evas_render_updates_internal_loop (evas_render.c:3079)
==4829== by 0x6B0EACA: evas_render_updates_internal (evas_render.c:3522)
==4829== by 0x6B1087C: evas_render_updates_internal_wait (evas_render.c:3946)
==4829== by 0x6B10A4D: _evas_canvas_render_updates (evas_render.c:3971)
==4829== by 0x6A7A234: evas_canvas_render_updates (evas_canvas.eo.c:212)
==4829== by 0x6A7BBD4: evas_render_updates (evas_canvas.eo.c:758)
==4829== by 0x808A7D8: ecore_evas_render (ecore_evas.c:177)
==4829== by 0x808AA58: _ecore_evas_idle_enter (ecore_evas.c:284)
==4829== by 0x5CC1E46: _ecore_call_task_cb (ecore_private.h:442)
==4829== by 0x5CC1EAE: _ecore_factorized_idle_process (ecore_idler.c:35)
==4829== by 0xBFA4DD4: _event_callback_call (eo_base_class.c:1663)
==4829== by 0xBFA50A6: _efl_object_event_callback_call (eo_base_class.c:1747)
==4829== by 0xBFA514C: efl_event_callback_call (eo_base_class.c:1750)
==4829== by 0x5CC661B: _ecore_main_loop_iterate_internal (ecore_main.c:2352)
==4829== by 0x5CC3F65: _ecore_main_loop_begin (ecore_main.c:1175)
==4829== by 0x5CCC856: _efl_loop_begin (efl_loop.c:83)
==4829== by 0x5CCEF6D: efl_loop_begin (efl_loop.eo.c:28)
==4829== by 0x5CC40DF: ecore_main_loop_begin (ecore_main.c:1248)
==4829== by 0x5480EE: main (e_main.c:1090)
==4829== Address 0x2bfc30f8 is 328 bytes inside a block of size 560 free'd
==4829== at 0x4C30D18: free (vg_replace_malloc.c:530)
==4829== by 0x540AE91: _eina_freeq_free_do (eina_freeq.c:118)
==4829== by 0x540B7B0: eina_freeq_ptr_add (eina_freeq.c:372)
==4829== by 0x6BCD23C: _evas_common_rgba_image_delete (evas_image_main.c:555)
==4829== by 0x6B41538: _evas_cache_image_entry_delete (evas_cache_image.c:205)
==4829== by 0x6B43503: evas_cache_image_drop (evas_cache_image.c:945)
==4829== by 0x6B43F4F: evas_cache_image_size_set (evas_cache_image.c:1166)
==4829== by 0x246D6548: evas_gl_common_image_alloc_ensure (evas_gl_image.c:17)
==4829== by 0x246D8EA8: evas_gl_common_image_update (evas_gl_image.c:869)
==4829== by 0x246DAA7B: evas_gl_common_image_draw (evas_gl_image.c:1417)
==4829== by 0x246A2AB6: eng_image_draw (evas_engine.c:1240)
==4829== by 0x6A87842: _draw_image (evas_object_image.c:1403)
==4829== by 0x6A8A1BF: _evas_image_render (evas_object_image.c:2171)
==4829== by 0x6A890C1: evas_object_image_render (evas_object_image.c:1868)
==4829== by 0x6B09C82: evas_render_mapped (evas_render.c:2292)
==4829== by 0x6B0CE90: evas_render_updates_internal_loop (evas_render.c:3079)
==4829== by 0x6B0EACA: evas_render_updates_internal (evas_render.c:3522)
==4829== by 0x6B1087C: evas_render_updates_internal_wait (evas_render.c:3946)
==4829== by 0x6B10A4D: _evas_canvas_render_updates (evas_render.c:3971)
==4829== by 0x6A7A234: evas_canvas_render_updates (evas_canvas.eo.c:212)
==4829== by 0x6A7BBD4: evas_render_updates (evas_canvas.eo.c:758)
==4829== by 0x808A7D8: ecore_evas_render (ecore_evas.c:177)
==4829== by 0x808AA58: _ecore_evas_idle_enter (ecore_evas.c:284)
==4829== by 0x5CC1E46: _ecore_call_task_cb (ecore_private.h:442)
==4829== by 0x5CC1EAE: _ecore_factorized_idle_process (ecore_idler.c:35)
==4829== by 0xBFA4DD4: _event_callback_call (eo_base_class.c:1663)
==4829== by 0xBFA50A6: _efl_object_event_callback_call (eo_base_class.c:1747)
==4829== by 0xBFA514C: efl_event_callback_call (eo_base_class.c:1750)
==4829== by 0x5CC661B: _ecore_main_loop_iterate_internal (ecore_main.c:2352)
==4829== by 0x5CC3F65: _ecore_main_loop_begin (ecore_main.c:1175)
==4829== by 0x5CCC856: _efl_loop_begin (efl_loop.c:83)
==4829== by 0x5CCEF6D: efl_loop_begin (efl_loop.eo.c:28)
==4829== by 0x5CC40DF: ecore_main_loop_begin (ecore_main.c:1248)
==4829== by 0x5480EE: main (e_main.c:1090)
==4829== Block was alloc'd at
==4829== at 0x4C31A1E: calloc (vg_replace_malloc.c:711)
==4829== by 0x6BCCF2F: _evas_common_rgba_image_new (evas_image_main.c:509)
==4829== by 0x6B41588: _evas_cache_image_entry_new (evas_cache_image.c:261)
==4829== by 0x6B44861: evas_cache_image_empty (evas_cache_image.c:1447)
==4829== by 0x246D845B: evas_gl_common_image_native_disable (evas_gl_image.c:624)
==4829== by 0x253F3C09: eng_image_native_set (evas_engine.c:1234)
==4829== by 0x6A86204: _evas_image_native_surface_set (evas_object_image.c:1021)
==4829== by 0x6A7E110: evas_object_image_native_surface_set (evas_image_legacy.c:509)
==4829== by 0x6A8609A: _on_image_native_surface_del (evas_object_image.c:998)
==4829== by 0x6A55190: _eo_evas_object_cb (evas_callbacks.c:184)
==4829== by 0xBFA4EB7: _event_callback_call (eo_base_class.c:1686)
==4829== by 0xBFA51F8: _efl_object_event_callback_legacy_call (eo_base_class.c:1759)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A968ED: _efl_canvas_object_efl_object_event_callback_legacy_call (evas_object_main.c:1229)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A55C3D: evas_object_event_callback_call (evas_callbacks.c:413)
==4829== by 0x6A96D3E: _efl_canvas_object_efl_object_invalidate (evas_object_main.c:1279)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0xBFA0A09: _efl_invalidate (eo_base_class.c:170)
==4829== by 0xBFA2737: _efl_object_parent_set (eo_base_class.c:734)
==4829== by 0xBFA6BDA: efl_parent_set (efl_object.eo.c:12)
==4829== by 0xBFA2537: efl_del (eo_base_class.c:686)
==4829== by 0x6A96082: evas_object_del (evas_object_main.c:1041)
==4829== by 0x2C9D519F: _bar_icon_preview_del (bar.c:762)
==4829== by 0x6A55190: _eo_evas_object_cb (evas_callbacks.c:184)
==4829== by 0xBFA4EB7: _event_callback_call (eo_base_class.c:1686)
==4829== by 0xBFA51F8: _efl_object_event_callback_legacy_call (eo_base_class.c:1759)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A968ED: _efl_canvas_object_efl_object_event_callback_legacy_call (evas_object_main.c:1229)
==4829== by 0xBFA529E: efl_event_callback_legacy_call (eo_base_class.c:1762)
==4829== by 0x6A55C3D: evas_object_event_callback_call (evas_callbacks.c:413)
==4829== by 0x6A96D3E: _efl_canvas_object_efl_object_invalidate (evas_object_main.c:1279)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0x7BE9326: _efl_access_object_efl_object_invalidate (efl_access_object.c:634)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0xBFA0A09: _efl_invalidate (eo_base_class.c:170)
==4829== by 0xBFA2737: _efl_object_parent_set (eo_base_class.c:734)
==4829== by 0xBFA6BDA: efl_parent_set (efl_object.eo.c:12)
==4829== by 0xBFA2537: efl_del (eo_base_class.c:686)
==4829== by 0x6A96082: evas_object_del (evas_object_main.c:1041)
==4829== by 0x7CD5F2C: _efl_ui_widget_efl_canvas_group_group_del (efl_ui_widget.c:855)
==4829== by 0x6AAD303: efl_canvas_group_del (evas_object_smart.c:1862)
==4829== by 0x7AFF104: _elm_box_efl_canvas_group_group_del (elm_box.c:362)
==4829== by 0x6AAD303: efl_canvas_group_del (evas_object_smart.c:1862)
==4829== by 0x6AABB79: evas_object_smart_del (evas_object_smart.c:1288)
==4829== by 0x6A97179: _efl_canvas_object_efl_object_invalidate (evas_object_main.c:1336)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0x7BE9326: _efl_access_object_efl_object_invalidate (efl_access_object.c:634)
==4829== by 0xBFA7BAB: efl_invalidate (efl_object.eo.c:72)
==4829== by 0xBFA0A09: _efl_invalidate (eo_base_class.c:170)
==4829== by 0xBFA2737: _efl_object_parent_set (eo_base_class.c:734)
==4829== by 0xBFA6BDA: efl_parent_set (efl_object.eo.c:12)
==4829== by 0xBFA2537: efl_del (eo_base_class.c:686)
==4829== by 0x6A96082: evas_object_del (evas_object_main.c:1041)
==4829== by 0x2C9D41DA: _bar_icon_preview_hide (bar.c:450)
==4829== by 0x5CFE14C: _ecore_call_task_cb (ecore_private.h:442)
==4829== by 0x5CFE5C4: _ecore_timer_legacy_tick (ecore_timer.c:160)
==4829== by 0xBFA4DD4: _event_callback_call (eo_base_class.c:1663)
==4829== by 0xBFA50A6: _efl_object_event_callback_call (eo_base_class.c:1747)
==4829== by 0xBFA514C: efl_event_callback_call (eo_base_class.c:1750)
==4829== by 0x5CFF880: _efl_loop_timer_expired_call (ecore_timer.c:634)
==4829== by 0x5CFF6AF: _efl_loop_timer_expired_timers_call (ecore_timer.c:587)
==4829== by 0x5CC6522: _ecore_main_loop_iterate_internal (ecore_main.c:2317)
==4829== by 0x5CC3F65: _ecore_main_loop_begin (ecore_main.c:1175)
==4829== by 0x5CCC856: _efl_loop_begin (efl_loop.c:83)
==4829== by 0x5CCEF6D: efl_loop_begin (efl_loop.eo.c:28)
==4829== by 0x5CC40DF: ecore_main_loop_begin (ecore_main.c:1248)
==4829== by 0x5480EE: main (e_main.c:1090)
Reviewers: ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6234
YeongJong Lee [Thu, 31 May 2018 13:46:12 +0000 (09:46 -0400)]
elm_tooltip: use window as parent instead of NULL for elm_theme_object_set
Summary:
see
421217b15019966a093ed49a34837f9535e00827
If parent is NULL, is_legacy in _elm_theme_set is always true. and it will use
"efl/xxx" for mmap_set. this patch avoid this case.
fixes T6921
Test Plan:
1. elementary_test -to tooltip
2. check that "Hello", "Big Icon Tooltip", "Insanel Big Icon Tooltip" is working
Reviewers: zmike
Subscribers: cedric, ManMower, #committers
Tags: #efl
Maniphest Tasks: T6921
Differential Revision: https://phab.enlightenment.org/D6232
YeongJong Lee [Thu, 31 May 2018 12:39:34 +0000 (21:39 +0900)]
elm_win: fix widget type name for backward compatibility
Summary:
It should use legacy class in elm_win_add.
this patch fixes T6898, T6899
Test Plan: make check
Reviewers: zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6899, T6898
Differential Revision: https://phab.enlightenment.org/D6233
Xavi Artigas [Wed, 30 May 2018 11:33:01 +0000 (07:33 -0400)]
Do not consider the Evas_Vg API as BETA anymore
Summary:
It has been widely used for quite some time now.
Fixes T6889
Test Plan:
Manually built the evas-vg-simple.c and evas-vg-batman.c examples after
removing the manual define of EFL_BETA_API_SUPPORT and EFL_EO_API_SUPPORT
that they have at the top.
Reviewers: ajwillia.ms, zmike
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6889
Differential Revision: https://phab.enlightenment.org/D6230
Change-Id: I6ade2d86773f14a6a48ccee7e9d3f9d3a3e6eba3
Hermet Park [Wed, 30 May 2018 04:44:34 +0000 (13:44 +0900)]
elementary genlist: optimize data.
Hermet Park [Wed, 30 May 2018 04:41:21 +0000 (13:41 +0900)]
evas canvas: remove unused goto tag.
Hermet Park [Wed, 30 May 2018 04:37:35 +0000 (13:37 +0900)]
elementary: packing data properly.
Marcel Hollerbach [Tue, 29 May 2018 16:24:55 +0000 (12:24 -0400)]
evas_object_box: adjust to recent EFL_EVENT_DEL changes
Summary:
the same change as the one for evas table, just for box.
Depends on D6228
Reviewers: cedric, zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6229
Marcel Hollerbach [Tue, 29 May 2018 16:24:53 +0000 (12:24 -0400)]
evas_focus: adjust to recent EFL_EVENT_DEL changes
Summary:
when focus events have been emitted the smart parent was persistent, now
its not anymore, lets restore this behaviour
Depends on D6227
Reviewers: cedric, zmike, stefan_schmidt
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6228
Marcel Hollerbach [Tue, 29 May 2018 16:24:44 +0000 (12:24 -0400)]
evas_clip: fix current EFL_EVENT_DEL event changes
Summary:
Before the parent was persistent when the intersept function and events
for clipper changes have been called. Lets get back to this behaviour.
Depends on D6226
Reviewers: cedric, zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6227
Marcel Hollerbach [Tue, 29 May 2018 16:24:36 +0000 (12:24 -0400)]
evas: be less error prone
Summary:
Dont spin infinitly when the refcount accidently is already < 0.
Depends on D6225
Reviewers: zmike, cedric, stefan_schmidt, #committers
Reviewed By: zmike, #committers
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6226
Marcel Hollerbach [Tue, 29 May 2018 16:24:31 +0000 (12:24 -0400)]
evas_object_table: adjust to recent EFL_EVENT_DEL changes
Summary:
EFL_EVENT_DEL is wrong here, as the callback uses a parent, which is
gone at the time of EFL_EVENT_DEL.
Reviewers: zmike, cedric, stefan_schmidt
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6225
Mike Blumenkrantz [Tue, 29 May 2018 11:25:32 +0000 (13:25 +0200)]
tests: make statically-defined eldbus bus names unique
Summary:
if not unique, these bus names will collide if run from separate
connections resulting in test failure
fix T6848
Depends on D6203
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6848
Differential Revision: https://phab.enlightenment.org/D6204
Mike Blumenkrantz [Tue, 29 May 2018 11:25:26 +0000 (13:25 +0200)]
tests: use eldbus in dbus test naming instead of enlightenment
Summary:
these tests are for eldbus; enlightenment has its own dbus namespace and
should not be mentioned here to avoid confusion
Depends on D6202
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6203
Mike Blumenkrantz [Tue, 29 May 2018 11:25:06 +0000 (13:25 +0200)]
tests: print dbus errors on fail in eldbus_test_eldbus_message
Summary: Depends on D6200
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6201
Mike Blumenkrantz [Tue, 29 May 2018 11:24:44 +0000 (13:24 +0200)]
tests: print error messages when eldbus tests fail to acquire requested name
Summary: Depends on D6199
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6200
Mike Blumenkrantz [Tue, 29 May 2018 11:24:35 +0000 (13:24 +0200)]
tests: reduce duration of all timers in eldbus tests
Summary:
these values seem to assume that network latency or some other form
of delay exists in dbus communications. dbus is a local socket protocol,
so such lengthy timers do nothing but waste runtime
ref T6952
Depends on D6198
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6952
Differential Revision: https://phab.enlightenment.org/D6199
Mike Blumenkrantz [Tue, 29 May 2018 11:24:27 +0000 (13:24 +0200)]
tests: always use session bus for eldbus tests
Summary:
1eeb3cbdf7369686980135707c953e766a67d16c causes all tests to run
inside a dbus session, so use this bus to avoid possible issues with
security policies
ref T6838
Depends on D6197
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6838
Differential Revision: https://phab.enlightenment.org/D6198
Mike Blumenkrantz [Tue, 29 May 2018 11:24:15 +0000 (13:24 +0200)]
tests: fix eldbus_test_eldbus_name_owner_changed test
Summary:
this is supposed to check an fdo dbus spec implementation, so the test
should exit with success after verifying it instead of waiting for a timeout
ref T6952
Depends on D6196
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6952
Differential Revision: https://phab.enlightenment.org/D6197
Mike Blumenkrantz [Tue, 29 May 2018 11:23:27 +0000 (13:23 +0200)]
tests: remove eldbus_test_eldbus_main_loop
Summary:
this test has no relation to eldbus
ref T6952
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6952
Differential Revision: https://phab.enlightenment.org/D6196
Hermet Park [Tue, 29 May 2018 07:25:54 +0000 (16:25 +0900)]
evas render: remove compile warnings.
Some bunch of code is unused when RENDCACHE is disabled.
Migrated them into RENDCACHE scope. No logical changes actually.
Marcel Hollerbach [Tue, 29 May 2018 04:39:15 +0000 (21:39 -0700)]
edje: a new testcase for what was happening before
Summary:
this checks explicitly that the lifecycle is alive.
Depends on D6223
Reviewers: cedric, zmike, JackDanielZ
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6224
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Marcel Hollerbach [Tue, 29 May 2018 04:38:51 +0000 (21:38 -0700)]
eo: do not return efl_invalidated true when its not true
Summary:
the object is invalidated AFTER the parent is lost, (thats what the doc
says). Returning invalidated as true when the parent is still present is
thus not correctly.
Depends on D6222
Reviewers: cedric, zmike, JackDanielZ
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6223
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>