platform/upstream/mesa.git
17 months agoasahi: Add batch state debugging
Asahi Lina [Wed, 5 Apr 2023 09:03:02 +0000 (18:03 +0900)]
asahi: Add batch state debugging

I've had to reimplement this more than once, let's just make a flag for
it.

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>

17 months agoasahi: Free low VA BOs correctly
Janne Grunau [Wed, 12 Apr 2023 09:01:07 +0000 (11:01 +0200)]
asahi: Free low VA BOs correctly

These need the shader_base added to them. Fixes GEM_BIND errors after
usc_head provides VA without the VM_SHADER_START offset from returned
low VA.

Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>

17 months agoasahi: Fix typo in debug/error message helper macro
Janne Grunau [Fri, 7 Apr 2023 18:27:00 +0000 (20:27 +0200)]
asahi: Fix typo in debug/error message helper macro

The typo is in the !__GLIBC__ case and was observed while building on
Alpine.

Fixes: 0a132b06406d ("asahi: Add a helper macro for debug/error messages")
Reported-by: mps
Tested-by: mps
Signed-off-by: Janne Grunau <j@jannau.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>

17 months agoasahi: Enable 2xMSAA (for deqp)
Asahi Lina [Fri, 7 Apr 2023 14:17:13 +0000 (23:17 +0900)]
asahi: Enable 2xMSAA (for deqp)

This also just works, let's enable it (still gated on deqp).

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>

17 months agoasahi: Broadcast Z for all components on texture fetch
Asahi Lina [Fri, 7 Apr 2023 14:09:45 +0000 (23:09 +0900)]
asahi: Broadcast Z for all components on texture fetch

Gallium expects this.

Related commit: 6cac9c748e

Co-authored-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>

17 months agoasahi: Identify ZS resolve bits (tentative)
Asahi Lina [Fri, 7 Apr 2023 14:08:50 +0000 (23:08 +0900)]
asahi: Identify ZS resolve bits (tentative)

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>

17 months agonir/lower_fp16_casts: Fix SSA dominance
Konstantin Seurer [Tue, 2 May 2023 17:56:44 +0000 (19:56 +0200)]
nir/lower_fp16_casts: Fix SSA dominance

Fixes: 01dfd65 ("nir: port fp16 casting code from dxil")
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22804>

17 months agoci: uprev kernel to 6.3.1 with fixed patch for Adreno SMMU
David Heidelberg [Fri, 5 May 2023 12:57:01 +0000 (14:57 +0200)]
ci: uprev kernel to 6.3.1 with fixed patch for Adreno SMMU

Going from release candidate to stable kernel hopefully also improve
overall stability.

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22873>

17 months agofreedreno/a6xx+: Use template to handle a6xx vs a7xx differences
Rob Clark [Fri, 3 Mar 2023 21:45:34 +0000 (13:45 -0800)]
freedreno/a6xx+: Use template to handle a6xx vs a7xx differences

This doesn't enable support for a7xx yet, but uses the new register pack
builders for registers that differ between a7xx and a6xx.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22837>

17 months agofreedreno/a6xx: Rework set_bin_size()
Rob Clark [Sat, 4 Mar 2023 20:01:31 +0000 (12:01 -0800)]
freedreno/a6xx: Rework set_bin_size()

The open-coded flag param for "all the other bits" won't work once we
have register variants in play.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22837>

17 months agor600/sfn: fix cube to array lowering for LOD
Gert Wollny [Sat, 6 May 2023 07:24:42 +0000 (09:24 +0200)]
r600/sfn: fix cube to array lowering for LOD

Makes piglits related to texturequerylod and samplercubearray pass.

Fixes: 79ca456b4837 ("r600/sfn: rewrite NIR backend")
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22883>

17 months agor600/sfn: Ass support for image_samples
Gert Wollny [Sat, 6 May 2023 07:20:55 +0000 (09:20 +0200)]
r600/sfn: Ass support for image_samples

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8971

Fixes: 79ca456b4837 ("r600/sfn: rewrite NIR backend")
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22883>

18 months agodocs/tgsi: use \ll and \gg for left and right shift
Erik Faye-Lund [Tue, 14 Mar 2023 09:39:46 +0000 (10:39 +0100)]
docs/tgsi: use \ll and \gg for left and right shift

This renders a bit cleaner.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: fixup latex for TEX and TEX2
Erik Faye-Lund [Tue, 14 Mar 2023 09:35:17 +0000 (10:35 +0100)]
docs/tgsi: fixup latex for TEX and TEX2

We need to excape the underscores for shadow_ref, as well as escape
non-math symbols.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: do not use math-block for non-latex
Erik Faye-Lund [Tue, 14 Mar 2023 09:23:43 +0000 (10:23 +0100)]
docs/tgsi: do not use math-block for non-latex

This block isn't valid latex, so let's just use a pseudocode-block like
we do elsewhere here.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: use math-notations for conditionals
Erik Faye-Lund [Tue, 14 Mar 2023 09:09:02 +0000 (10:09 +0100)]
docs/tgsi: use math-notations for conditionals

These are math-blocks, which is supposed to use math-notation for
conditionals. So let's change it to math notation.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: wrap overly long lines
Erik Faye-Lund [Mon, 13 Mar 2023 15:28:39 +0000 (16:28 +0100)]
docs/tgsi: wrap overly long lines

While we're at it, use some alignment so the equations still reads
reasonably.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: fixup bad latex
Erik Faye-Lund [Tue, 14 Mar 2023 08:49:02 +0000 (09:49 +0100)]
docs/tgsi: fixup bad latex

It's better to split these two equations in two than to try to write
extra text that needs lots of escaping. This fixes the LaTeX rendering
to be somewhat readable.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: fix bad latex
Erik Faye-Lund [Tue, 14 Mar 2023 08:45:47 +0000 (09:45 +0100)]
docs/tgsi: fix bad latex

We need empty spaces here, otherwise LaTeX thinks it's one equation, and
puts it all back onto one line.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodocs/tgsi: fix up indent
Erik Faye-Lund [Mon, 13 Mar 2023 15:23:38 +0000 (16:23 +0100)]
docs/tgsi: fix up indent

There's a mixture of indent styles here, with either two or three
spaces. We have standardized on three spaces for .rst-files in the
editorconfig, so let's apply that.

While we're at it, make sure math-blocks are indented into their
opcode-block. While the result might look the same most of the time,
this matters when we have textual explaination following math-blocks,
like we have in a few caess. If we don't indent the math there, we
end up with having to unindent the text following the math-block for it
not to count as a part of the math block, which looks very confusing
when reading the source code.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21893>

18 months agodzn: fix pointer type mismatch
Eric Engestrom [Fri, 5 May 2023 16:49:12 +0000 (17:49 +0100)]
dzn: fix pointer type mismatch

    ../src/microsoft/vulkan/dzn_image.c: In function ‘dzn_GetImageMemoryRequirements2’:
    ../src/microsoft/vulkan/dzn_image.c:918:91: error: passing argument 6 of ‘dzn_ID3D12Device12_GetResourceAllocationInfo3’ from incompatible pointer type [-Werror=incompatible-pointer-types]
      918 |                                                            &image->castable_format_count, &image->castable_formats,
          |                                                                                           ^~~~~~~~~~~~~~~~~~~~~~~~
          |                                                                                           |
          |                                                                                           DXGI_FORMAT **
    In file included from ../src/microsoft/vulkan/dzn_private.h:67,
                     from ../src/microsoft/vulkan/dzn_image.c:24:
    ../src/microsoft/vulkan/dzn_abi_helper.h:64:107: note: expected ‘const DXGI_FORMAT * const*’ but argument is of type ‘DXGI_FORMAT **’
       64 |                                               const UINT *num_castable_formats, const DXGI_FORMAT *const *castable_formats,
          |                                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors
    ninja: build stopped: subcommand failed.

Fixes: 71dbb3120a9d0fb0de32 ("dzn: Use GetResourceAllocationInfo3 for castable formats")
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22877>

18 months agoci/turnip: Drop the IUB bug fallout flakes.
Emma Anholt [Thu, 4 May 2023 21:43:15 +0000 (14:43 -0700)]
ci/turnip: Drop the IUB bug fallout flakes.

They haven't been seen since my fix landed.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22863>

18 months agoci/turnip: Drop an xfail from the full run for a recent fix.
Emma Anholt [Thu, 4 May 2023 21:01:58 +0000 (14:01 -0700)]
ci/turnip: Drop an xfail from the full run for a recent fix.

Fixes: 2cbc24b9da01 ("turnip: fix buffer markers using wrong addresses")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22863>

18 months agoci/radv: Disable flaky heaven d3d9 trace.
Emma Anholt [Thu, 4 May 2023 20:53:00 +0000 (13:53 -0700)]
ci/radv: Disable flaky heaven d3d9 trace.

10 flakes this month, starting with the noted job.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22863>

18 months agoci/radeonsi: Mark glx-make-current as flaky.
Emma Anholt [Thu, 4 May 2023 20:52:41 +0000 (13:52 -0700)]
ci/radeonsi: Mark glx-make-current as flaky.

It no longer 100% crashes, but instead sometimes fails.

Fixes: 91b06ea8b254 ("Uprev Piglit to 2391a83d1639a7ab7bbea02853b922878687b0e5")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22863>

18 months agointel/tools: decode ACTHD printed by newer kernels
Marcin Ślusarz [Fri, 5 May 2023 12:55:37 +0000 (14:55 +0200)]
intel/tools: decode ACTHD printed by newer kernels

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22874>

18 months agoradeonsi/vcn: fix decoding bs buffer alignement issue.
Ruijing Dong [Thu, 4 May 2023 01:20:51 +0000 (21:20 -0400)]
radeonsi/vcn: fix decoding bs buffer alignement issue.

reason:
  in some cases, bs buffer size could cause assertion,
  and some bitstreams of certain resolutions could
  not be decoded.

solution:
  to align the bs buffer to 128.

fixes: 4f1646d73fa8bac82ff2195f06a5f6011853f647

Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22844>

18 months agozink: add ZINK_DEBUG=optimal_keys
Mike Blumenkrantz [Thu, 4 May 2023 14:11:02 +0000 (10:11 -0400)]
zink: add ZINK_DEBUG=optimal_keys

it's otherwise very annoying to figure out why this may or may not be
available

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22854>

18 months agozink: disable EXT_shader_object if !optimal_keys
Mike Blumenkrantz [Thu, 4 May 2023 13:46:45 +0000 (09:46 -0400)]
zink: disable EXT_shader_object if !optimal_keys

this has the same requirements as GPL and then some

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22854>

18 months agozink: break out optimal key handling into separate function
Mike Blumenkrantz [Thu, 4 May 2023 13:46:07 +0000 (09:46 -0400)]
zink: break out optimal key handling into separate function

this is growing to be much larger than the original conditional

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22854>

18 months agozink: move EXT_shader_object check to another place
Mike Blumenkrantz [Thu, 4 May 2023 13:43:26 +0000 (09:43 -0400)]
zink: move EXT_shader_object check to another place

no functional changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22854>

18 months agoanv: increase instruction heap to 2Gb
Lionel Landwerlin [Thu, 4 May 2023 07:58:34 +0000 (10:58 +0300)]
anv: increase instruction heap to 2Gb

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8917
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22847>

18 months agoanv: make internal address space allocation more dynamic
Lionel Landwerlin [Thu, 23 Feb 2023 07:59:45 +0000 (09:59 +0200)]
anv: make internal address space allocation more dynamic

We're about to manipulate these pools and dealing with the fix address
ranges is painful.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22847>

18 months agoanv: link anv_bo to its VMA heap
Lionel Landwerlin [Tue, 6 Dec 2022 14:32:49 +0000 (16:32 +0200)]
anv: link anv_bo to its VMA heap

We want to add more heaps in the future and so not having to do
address checks to find out in what heap to release a BO is convinient.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22847>

18 months agoanv: avoid hardcoding instruction VA constant in shaders
Lionel Landwerlin [Thu, 23 Feb 2023 07:50:02 +0000 (09:50 +0200)]
anv: avoid hardcoding instruction VA constant in shaders

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22847>

18 months agoanv: remove 48bit address space checks
Lionel Landwerlin [Thu, 23 Feb 2023 07:16:40 +0000 (09:16 +0200)]
anv: remove 48bit address space checks

All the supported platforms should have 36+ bits of virtual address
space.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22847>

18 months agoisl: fix layout for comparing surf and view properties
Tapani Pälli [Thu, 4 May 2023 10:39:41 +0000 (13:39 +0300)]
isl: fix layout for comparing surf and view properties

These asserts were checking isl_format_layout against itself, change
to compare surface format layout against view format layout.

Fixes: 628bfaf1c6f ("intel/isl: Add some sanity checks for compressed surfaces")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22790>

18 months agointel/fs: fix scheduling of HALT instructions
Lionel Landwerlin [Mon, 3 Apr 2023 11:52:59 +0000 (14:52 +0300)]
intel/fs: fix scheduling of HALT instructions

With the following test :

dEQP-VK.spirv_assembly.instruction.terminate_invocation.terminate.no_out_of_bounds_load

There is a :

shader_start:
   ...                                 <- no control flow
   g0 = some_alu
   g1 = fbl
   g2 = broadcast g3, g1
   g4 = get_buffer_size g2
   ...                                 <- no control flow
   halt                                <- on some lanes
   g5 = send <surface>, g4

eliminate_find_live_channel will remove the fbl/broadcast because it
assumes lane0 is active at get_buffer_size :

shader_start:
   ...                                 <- no control flow
   g0 = some_alu
   g4 = get_buffer_size g0
   ...                                 <- no control flow
   halt                                <- on some lanes
   g5 = send <surface>, g4

But then the instruction scheduler will move the get_buffer_size after
the halt :

shader_start:
   ...                                 <- no control flow
   halt                                <- on some lanes
   g0 = some_alu
   g4 = get_buffer_size g0
   g5 = send <surface>, g4

get_buffer_size pulls the surface index from lane0 in g0 which could
have been turned off by the halt and we end up accessing an invalid
surface handle.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: mesa-stable
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20765>

18 months agoamd: Cleanup old GS intrinsics code.
Timur Kristóf [Tue, 25 Apr 2023 16:40:18 +0000 (18:40 +0200)]
amd: Cleanup old GS intrinsics code.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoac/nir/ngg: Use sendmsg in NGG lowering.
Timur Kristóf [Tue, 25 Apr 2023 16:20:57 +0000 (18:20 +0200)]
ac/nir/ngg: Use sendmsg in NGG lowering.

There is no need to use alloc_vertices_and_primitives anymore,
because it will be compiled to sendmsg anyway.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoac/nir: Emit legacy GS DONE signal in NIR.
Timur Kristóf [Tue, 25 Apr 2023 16:38:12 +0000 (18:38 +0200)]
ac/nir: Emit legacy GS DONE signal in NIR.

Legacy GS needs to emit a DONE signal at the end. Do this in NIR
instead of in the backends.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoac/nir: Use sendmsg in legacy GS lowering.
Timur Kristóf [Tue, 25 Apr 2023 16:15:03 +0000 (18:15 +0200)]
ac/nir: Use sendmsg in legacy GS lowering.

Remove the GS intrinsics completely and emit the sendmsg here
instead of in the backend. This is done to simplify backend code.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoac/llvm: Clarify arguments of ac_build_sendmsg.
Timur Kristóf [Tue, 25 Apr 2023 15:57:05 +0000 (17:57 +0200)]
ac/llvm: Clarify arguments of ac_build_sendmsg.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoamd: Move sendmsg defines to ac_shader_util.
Timur Kristóf [Tue, 25 Apr 2023 16:23:02 +0000 (18:23 +0200)]
amd: Move sendmsg defines to ac_shader_util.

Will be used by ac/nir legacy and NGG lowerings.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoamd: Add and implement gs_wave_id sysval.
Timur Kristóf [Wed, 26 Apr 2023 12:27:10 +0000 (14:27 +0200)]
amd: Add and implement gs_wave_id sysval.

Contains a global wave ID of legacy GS waves.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoamd: Add and implement sendmsg_amd intrinsic.
Timur Kristóf [Tue, 25 Apr 2023 15:56:50 +0000 (17:56 +0200)]
amd: Add and implement sendmsg_amd intrinsic.

This intrinsic is going to be used for simplifying GS code.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoaco: Disallow constant propagation on SOPP and fixed operands.
Timur Kristóf [Wed, 3 May 2023 16:58:36 +0000 (18:58 +0200)]
aco: Disallow constant propagation on SOPP and fixed operands.

Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agoaco/ra: create M0-affinities for s_sendmsg
Rhys Perry [Thu, 27 Apr 2023 15:22:52 +0000 (16:22 +0100)]
aco/ra: create M0-affinities for s_sendmsg

v2 by Timur Kristóf:
Do not add the affinity for instructions that can't write m0
reliably, such as readlane-like instructions on GFX8.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22690>

18 months agointel/compiler: UNDEF SubgroupInvocation's register
Kenneth Graunke [Wed, 3 May 2023 09:05:16 +0000 (02:05 -0700)]
intel/compiler: UNDEF SubgroupInvocation's register

This value takes a few instructions to create, involving expanding
V-immediates, adding 8 for SIMD16, and so on.  We can mark it UNDEF
so that it's clear that although these are partial writes, we are
actually defining the entire value.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22835>

18 months agointel/compiler: UNDEF comparisons with smaller than 32-bit
Kenneth Graunke [Wed, 3 May 2023 08:49:56 +0000 (01:49 -0700)]
intel/compiler: UNDEF comparisons with smaller than 32-bit

Comparisons which produce 32-bit boolean results (0 or 0xFFFFFFFF)
but operate on 16-bit types would first generate a CMP instruction
with W or HF types, before expanding it out.  This CMP is a partial
write, which leads us to think the register may contain some prior
contents still.  When placed in a loop, this causes its live range
to extend beyond its real life time.

Mark the register with UNDEF first so that we know that no prior
contents exist and need to be preserved.

This affects:
flt32, fge32, feq32, fneu32, ilt32, ult32, ige32, uge32, ieq32, ine32

On one of Cyberpunk 2077's most complex compute shaders, this reduces
the maximum live registers from 696 to 537 (22.8%).  Together with the
next patch, Cyberpunk's spills and fills are cut by 10.23% and 9.19%,
respectively.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22835>

18 months agovulkan: Document vk_physical_device::supported_features
Faith Ekstrand [Thu, 4 May 2023 04:11:35 +0000 (23:11 -0500)]
vulkan: Document vk_physical_device::supported_features

While we're here, move it to after supported extensions to stay
consistent with the vk_physical_device_init parameters.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Constantine Shablya <constantine.shablya@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22845>

18 months agozink: take location_frac into account in pv emulation
antonino [Thu, 4 May 2023 14:54:03 +0000 (16:54 +0200)]
zink: take location_frac into account in pv emulation

The pv mode emulation code was not taking into account the location_frac
of variables, they where beeing stored in a 1D array leading to
collisions.

Fixes: 5a4083349f3 ("zink: add provoking vertex mode lowering")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22856>

18 months agonir: switch to a normal sampler for ARB program with not depth textures
Illia Polishchuk [Fri, 21 Apr 2023 07:45:47 +0000 (10:45 +0300)]
nir: switch to a normal sampler for ARB program with not depth textures

It is undefined behavior when an ARB assembly or shadow2d GLSL func
uses SHADOW2D target with a texture in not depth format.
In this case AMD and NVIDIA automatically replaces SHADOW sampler
with a normal sampler and some games like Penumbra Overture which abuses
this UB works fine but breaks with mesa.

Replace the shadow sampler with a normal one here by recompiling
the ARB program variant

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8425
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Illia Polishchuk <illia.a.polishchuk@globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22147>

18 months agodrirc: add allow_sampled_tex_copy option
Illia Polishchuk [Mon, 27 Mar 2023 17:11:15 +0000 (20:11 +0300)]
drirc: add allow_sampled_tex_copy option

From OpenGL spec 8.6
"An INVALID_OPERATION error is generated if the object bound to
READ_FRAMEBUFFER_BINDING is framebuffer complete and its effective
value of SAMPLE_BUFFERS (see section 9.2.3.1) is one"

But some games might do this

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8425
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Illia Polishchuk <illia.a.polishchuk@globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22147>

18 months agoUprev Piglit to 79a084c56b6dd79f7c3a97b57a72963121ebb1e6
Collabora's Gfx CI Team [Wed, 3 May 2023 06:16:46 +0000 (06:16 +0000)]
Uprev Piglit to 79a084c56b6dd79f7c3a97b57a72963121ebb1e6

https://gitlab.freedesktop.org/mesa/piglit/-/compare/355ad6bcb2cb3d9e030b7c6eef2b076b0dfb4d63...79a084c56b6dd79f7c3a97b57a72963121ebb1e6

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22548>

18 months agopvr: Move heap initialisation out of pvr_winsys_helper.
Donald Robson [Wed, 3 May 2023 13:50:36 +0000 (14:50 +0100)]
pvr: Move heap initialisation out of pvr_winsys_helper.

This code will not be used by the new KMD, so it is being moved out of
this shared code area.

Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22826>

18 months agopanvk: clear dangling pointers
David Heidelberg [Wed, 3 May 2023 14:57:03 +0000 (16:57 +0200)]
panvk: clear dangling pointers

Fixes:
```
[829/1646] Compiling C object src/panfrost/vulkan/libpanvk_v6.a.p/panvk_vX_meta_clear.c.o
In function 'panvk_meta_clear_zs_img',
    inlined from 'panvk_v6_CmdClearDepthStencilImage' at ../src/panfrost/vulkan/panvk_vX_meta_clear.c:457:7:
../src/panfrost/vulkan/panvk_vX_meta_clear.c:415:26: warning: storing the address of local variable 'view' in '((struct pan_fb_info *)((char *)commandBuffer + 144))[23].zs.view.zs' [-Wdangling-pointer=]
  415 |       fbinfo->zs.view.zs = &view;
      |       ~~~~~~~~~~~~~~~~~~~^~~~~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c: In function 'panvk_v6_CmdClearDepthStencilImage':
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'view' declared here
  393 |    struct pan_image_view view = {
      |                          ^~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'commandBuffer' declared here
[844/1646] Compiling C object src/panfrost/vulkan/libpanvk_v7.a.p/panvk_vX_meta_clear.c.o
In function 'panvk_meta_clear_zs_img',
    inlined from 'panvk_v7_CmdClearDepthStencilImage' at ../src/panfrost/vulkan/panvk_vX_meta_clear.c:457:7:
../src/panfrost/vulkan/panvk_vX_meta_clear.c:415:26: warning: storing the address of local variable 'view' in '((struct pan_fb_info *)((char *)commandBuffer + 144))[23].zs.view.zs' [-Wdangling-pointer=]
  415 |       fbinfo->zs.view.zs = &view;
      |       ~~~~~~~~~~~~~~~~~~~^~~~~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c: In function 'panvk_v7_CmdClearDepthStencilImage':
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'view' declared here
  393 |    struct pan_image_view view = {
      |                          ^~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'commandBuffer' declared here
```

Cc: mesa-stable
Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22829>

18 months agoanv: implement VK_KHR_ray_tracing_position_fetch
Lionel Landwerlin [Thu, 1 Dec 2022 21:30:59 +0000 (23:30 +0200)]
anv: implement VK_KHR_ray_tracing_position_fetch

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <f{merge_request.web_url}>

18 months agointel/nir/rt: wire position fetch intrinsic
Lionel Landwerlin [Fri, 2 Dec 2022 11:05:34 +0000 (13:05 +0200)]
intel/nir/rt: wire position fetch intrinsic

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <f{merge_request.web_url}>

18 months agointel/nir/rt: use a single load for instance leaf loading
Lionel Landwerlin [Fri, 2 Dec 2022 11:06:02 +0000 (13:06 +0200)]
intel/nir/rt: use a single load for instance leaf loading

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <f{merge_request.web_url}>

18 months agospirv/nir: wire ray interection triangle position fetch
Lionel Landwerlin [Thu, 1 Dec 2022 15:09:22 +0000 (17:09 +0200)]
spirv/nir: wire ray interection triangle position fetch

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <f{merge_request.web_url}>

18 months agospirv: update to latest headers
Lionel Landwerlin [Thu, 27 Apr 2023 12:49:41 +0000 (15:49 +0300)]
spirv: update to latest headers

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <f{merge_request.web_url}>

18 months agovulkan: bump headers to 1.3.249
Lionel Landwerlin [Thu, 1 Dec 2022 14:44:53 +0000 (16:44 +0200)]
vulkan: bump headers to 1.3.249

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <f{merge_request.web_url}>

18 months agopvr: Reduce free list initial size when multiple devices are created
Jarred Davies [Fri, 17 Mar 2023 14:26:48 +0000 (14:26 +0000)]
pvr: Reduce free list initial size when multiple devices are created

Will hopefully reduce the memory load when running dEQP.

Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22330>

18 months agopvr: Use vk_device's enabled features struct
Jarred Davies [Wed, 22 Mar 2023 16:38:43 +0000 (16:38 +0000)]
pvr: Use vk_device's enabled features struct

Avoids duplicating the struct in pvr_device and fixes uninitialized
accesses when ppEnabledFeatures was NULL.

Noticed when running valgrind over dEQP.

Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22331>

18 months agopvr: Don't ralloc build context from compiler
Jarred Davies [Fri, 24 Mar 2023 17:58:49 +0000 (17:58 +0000)]
pvr: Don't ralloc build context from compiler

rogue_compiler is allocated for each VkPhysicalDevice which means it can
be used from multiple threads when compiling. Allocating the build context
from this will lead to race conditions as ralloc is not thread safe.

Signed-off-by: Jarred Davies <jarred.davies@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22332>

18 months agopanvk: port panvk_logi to vk_logi
nihui [Sat, 29 Apr 2023 14:27:21 +0000 (22:27 +0800)]
panvk: port panvk_logi to vk_logi

Signed-off-by: Hui Ni <shuizhuyuanluo@126.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22772>

18 months agopvr: Adjust clear's region clip words
James Glanville [Tue, 2 May 2023 14:46:45 +0000 (15:46 +0100)]
pvr: Adjust clear's region clip words

Co-Authored-By: : Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Signed-off-by: James Glanville <james.glanville@imgtec.com>
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22822>

18 months agopvr: Fix incorrect PBE packmode for S8_UINT
James Glanville [Fri, 28 Apr 2023 15:09:46 +0000 (16:09 +0100)]
pvr: Fix incorrect PBE packmode for S8_UINT

Fixes:
dEQP-VK.pipeline.monolithic.stencil.format.d24_unorm_s8_uint.states
  .fail_keep.pass_keep.dfail_keep.comp_always

Signed-off-by: James Glanville <james.glanville@imgtec.com>
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22822>

18 months agopvr: Don't advertise S8_UINT support
Karmjit Mahil [Thu, 20 Apr 2023 14:38:18 +0000 (15:38 +0100)]
pvr: Don't advertise S8_UINT support

S8_UINT is not a requirement for Vulkan 1.0.

Revert "pvr: Add initial support for VK_FORMAT_S8_UINT".

This reverts commit 220356e0831bc870a189cf8d116a8b0ff6e1e500.

Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22822>

18 months agopvr: fix sync waiting while using pvrsrvkm
SoroushIMG [Wed, 26 Apr 2023 19:46:36 +0000 (20:46 +0100)]
pvr: fix sync waiting while using pvrsrvkm

pvrsrvkm type sync objects can have a pending state where,
the fence is unsignaled but does not have a valid sync file
due to not yet being submitted to kernel.

The wait function therefore needs to handle these types of syncs
through a spin loop.

This was seen as crashes in dEQP-VK.synchronization.timeline_semaphore.*

Signed-off-by: SoroushIMG <soroush.kashani@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22822>

18 months agodocs: fixup About Mesa3D.org link
Erik Faye-Lund [Wed, 3 May 2023 13:12:42 +0000 (15:12 +0200)]
docs: fixup About Mesa3D.org link

This link is supposed to point to www.mesa3d.org, not docs.mesa3d.org.
Let's fix it up!

Fixes: 7da0482636a ("docs: add custom html theme")
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22825>

18 months agollvmpipe: fixup refactor copypasta
Erik Faye-Lund [Wed, 3 May 2023 16:31:38 +0000 (18:31 +0200)]
llvmpipe: fixup refactor copypasta

I accidentally set this state based on the wrong state when refactoring,
whoops!

Fixes: a1846e39269 ("llvmpipe: merge all rasterizer-bind functions")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22832>

18 months agomesa/main: drop use_legacy_math_rules
Erik Faye-Lund [Sat, 15 Apr 2023 17:03:00 +0000 (19:03 +0200)]
mesa/main: drop use_legacy_math_rules

Seems the only thing that really needs this is fpow(0, 0), which should
return NaN, but then gets multiplied with zero. Let's fix that by doing
a bcsel instead of fmul to select the result here. While we're at it,
get rid of the fabs for stop, which isn't needed.

This fixes a piglits failure for most (if not all?) drivers that doesn't
support legacy math rules.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Acked-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22789>

18 months agor600: remove unused code
Thomas H.P. Andersen [Thu, 27 Apr 2023 18:40:42 +0000 (20:40 +0200)]
r600: remove unused code

With the cleanup in 337dc7d76604e646f1a85615ab2d9d238427bf46 this code
became unused.

Fixes: 337dc7d76604 ("r600: remove TGSI code path")
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22743>

18 months agonir/lower_io_to_vector: initialize base
David Heidelberg [Wed, 3 May 2023 21:30:27 +0000 (23:30 +0200)]
nir/lower_io_to_vector: initialize base

Prevent GCC warning:
```
[230/1401] Compiling C object src/compiler/nir/libnir.a.p/nir_lower_io_to_vector.c.o
In function 'get_flat_type',
    inlined from 'create_new_io_vars' at ../src/compiler/nir/nir_lower_io_to_vector.c:300:10:
../src/compiler/nir/nir_lower_io_to_vector.c:208:14: warning: 'base' may be used uninitialized [-Wmaybe-uninitialized]
  208 |       return glsl_array_type(glsl_vector_type(base, 4), slots, 0);
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/compiler/nir/nir_lower_io_to_vector.c: In function 'create_new_io_vars':
../src/compiler/nir/nir_lower_io_to_vector.c:163:24: note: 'base' was declared here
  163 |    enum glsl_base_type base;
      |                        ^~~~
```

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8957

Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22840>

18 months agodzn: Delete queue-level event waits
Jesse Natalie [Wed, 3 May 2023 22:51:51 +0000 (15:51 -0700)]
dzn: Delete queue-level event waits

These are unneeded. Events can't be used to indefinitely stall work
like you can with a semaphore or timeline semaphore. The signals
still need to happen so that execution will modify the state that
can be polled from the CPU though.

Fixes dEQP-VK.synchronization.basic.event.single_submit_multi_command_buffer

Fixes: 04fa6c71 ("dzn: Batch command lists together")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22842>

18 months agodzn: Support separate depth/stencil resolves via blits
Jesse Natalie [Wed, 3 May 2023 19:46:17 +0000 (12:46 -0700)]
dzn: Support separate depth/stencil resolves via blits

In theory, ResolveSubresourceRegion should be able to resolve just
the depth or just the stencil. In practice, WARP had bugs, which
means that was never tested, so just do it via blits.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22836>

18 months agodzn: Support all available depth/stencil resolve modes
Jesse Natalie [Wed, 3 May 2023 18:19:09 +0000 (11:19 -0700)]
dzn: Support all available depth/stencil resolve modes

Fixes dEQP-VK.imageless_framebuffer.depth_stencil_resolve and
dEQP-VK.renderpass2.depth_stencil_resolve.misc.properties

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22836>

18 months agodzn: Augment blit resolve to support min/max/sample-zero modes
Jesse Natalie [Wed, 3 May 2023 18:18:52 +0000 (11:18 -0700)]
dzn: Augment blit resolve to support min/max/sample-zero modes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22836>

18 months agovulkan: write beta extensions into generator scripts.
Dave Airlie [Tue, 14 Mar 2023 05:39:14 +0000 (15:39 +1000)]
vulkan: write beta extensions into generator scripts.

Updated by: Hyunjun Ko <zzoon@igalia.com>

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21806>

18 months agovulkan/cmd_queue: handle beta extensions.
Dave Airlie [Thu, 9 Mar 2023 04:18:25 +0000 (14:18 +1000)]
vulkan/cmd_queue: handle beta extensions.

Since this was moved to vulkan_core.h, we have to add the beta header
ourselves when required.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21806>

18 months agonir: add/update comments for gl_access_qualifier
Marek Olšák [Fri, 28 Apr 2023 03:12:46 +0000 (23:12 -0400)]
nir: add/update comments for gl_access_qualifier

Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22769>

18 months agonir: rename ACCESS_STREAM_CACHE_POLICY -> ACCESS_NON_TEMPORAL and document
Marek Olšák [Fri, 28 Apr 2023 03:02:28 +0000 (23:02 -0400)]
nir: rename ACCESS_STREAM_CACHE_POLICY -> ACCESS_NON_TEMPORAL and document

Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22769>

18 months agodevice_select_layer: log selectable devices if MESA_VK_DEVICE_SELECT_DEBUG or DRI_PRI...
Luna Nova [Tue, 17 Jan 2023 01:05:39 +0000 (17:05 -0800)]
device_select_layer: log selectable devices if MESA_VK_DEVICE_SELECT_DEBUG or DRI_PRIME_DEBUG are set

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19101>

18 months agodevice_select_layer: add MESA_VK_DEVICE_SELECT_DEBUG which logs why default selection...
Luna Nova [Mon, 16 Jan 2023 00:23:32 +0000 (16:23 -0800)]
device_select_layer: add MESA_VK_DEVICE_SELECT_DEBUG which logs why default selection was made

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19101>

18 months agodevice_select_layer: pick a default device before applying DRI_PRIME
Luna Nova [Mon, 16 Jan 2023 00:12:59 +0000 (16:12 -0800)]
device_select_layer: pick a default device before applying DRI_PRIME

This ensures DRI_PRIME works if there are multiple CPU devices available

Suggested by @pepp

Fixes: afa1fba1 ("vulkan/device_select: don't pick a cpu driver as the default")

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19101>

18 months agodevice_select_layer: apply DRI_PRIME even if default device is > 1 to match opengl...
Luna Nova [Mon, 16 Jan 2023 00:09:04 +0000 (16:09 -0800)]
device_select_layer: apply DRI_PRIME even if default device is > 1 to match opengl behavior

This fixes DRI_PRIME=1 doing nothing if the GPU order is [dGPU, dGPU,
iGPU, cpu] (or more GPUs than that) and the iGPU is the default GPU.

Fixes: afa1fba1 ("vulkan/device_select: don't pick a cpu driver as the default")

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19101>

18 months agodevice_select_layer: fix inverted strcmp in device_select_find_dri_prime_tag_default...
Luna Nova [Sun, 16 Oct 2022 23:10:47 +0000 (16:10 -0700)]
device_select_layer: fix inverted strcmp in device_select_find_dri_prime_tag_default (v1)

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7498
Fixes: 9bc5b2d169d ("vulkan: add initial device selection layer. (v6.1)")

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19101>

18 months agosvga: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
svga: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agollvmpipe: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
llvmpipe: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agovc4: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
vc4: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agov3d: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
v3d: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agosoftpipe: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
softpipe: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agoiris: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
iris: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agoi915: use util_unreference_framebuffer_state to unref fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:24:56 +0000 (16:24 -0400)]
i915: use util_unreference_framebuffer_state to unref fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agoi915: use util_copy_framebuffer_state to set fb state
Mike Blumenkrantz [Mon, 24 Apr 2023 20:27:11 +0000 (16:27 -0400)]
i915: use util_copy_framebuffer_state to set fb state

Fixes: f5bde99cbdd ("gallium: plumb resolve attachments through from frontends -> pipe_framebuffer_state")

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agocso: unbind fb state when unbinding the context
Mike Blumenkrantz [Mon, 24 Apr 2023 20:23:52 +0000 (16:23 -0400)]
cso: unbind fb state when unbinding the context

this avoids leaking/ballooning references

cc: mesa-stable

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22673>

18 months agoci: carry venus-protocol 1.0 release patches in virglrenderer
Yiwei Zhang [Tue, 2 May 2023 23:43:12 +0000 (16:43 -0700)]
ci: carry venus-protocol 1.0 release patches in virglrenderer

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22547>

18 months agodocs: update Virtio-GPU Venus driver page
Yiwei Zhang [Mon, 17 Apr 2023 22:40:49 +0000 (15:40 -0700)]
docs: update Virtio-GPU Venus driver page

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22547>