isaacs [Tue, 25 Jun 2013 18:12:33 +0000 (11:12 -0700)]
Merge remote-tracking branch 'ry/v0.10' into master
Conflicts:
ChangeLog
deps/uv/ChangeLog
deps/uv/src/unix/stream.c
deps/uv/src/version.c
deps/v8/build/common.gypi
deps/v8/src/frames.h
deps/v8/src/runtime.cc
deps/v8/test/mjsunit/debug-set-variable-value.js
lib/http.js
src/node_version.h
Ben Noordhuis [Mon, 24 Jun 2013 09:16:48 +0000 (11:16 +0200)]
doc: fs: synchronize watchFile/unwatchFile warning
One said "if available", the other "if possible". Now they both say
"if possible."
Ben Noordhuis [Thu, 20 Jun 2013 21:13:28 +0000 (23:13 +0200)]
child_process: emit 'disconnect' asynchronously
Deferring I/O-triggered events to the next event loop tick is not just
a good idea, IT'S THE LAW!
Mathias Bynens [Sun, 2 Jun 2013 12:25:51 +0000 (15:25 +0300)]
doc: improve punycode.js documentation
Ben Noordhuis [Thu, 20 Jun 2013 11:21:05 +0000 (13:21 +0200)]
buffer: fix gcc 4.2 build breakage
gcc 4.2 on OS X gets confused about the call to node::Buffer::Data().
Fully qualify the function name to help it along.
Fixes the following build error:
../../deps/v8/include/v8.h: In function ‘char*
node::Buffer::Data(v8::Handle<v8::Value>)’:
../../deps/v8/include/v8.h:900: error: ‘class v8::Data’
is not a function,
../../src/node_buffer.h:38: error:
conflict with ‘char* node::Buffer::Data(v8::Handle<v8::Object>)’
../../src/node_buffer.cc:94: error:
in call to ‘Data’
Mathias Bynens [Thu, 20 Jun 2013 10:40:44 +0000 (12:40 +0200)]
punycode: update to v1.2.3
Timothy J Fontaine [Thu, 20 Jun 2013 00:10:02 +0000 (17:10 -0700)]
string_bytes: properly detect 64bit
Trevor Norris [Wed, 19 Jun 2013 20:07:24 +0000 (13:07 -0700)]
buffer: write strings directly from call
Buffer(<String>) used to pass the string to js where it would then be
passed back to cpp for processing. Now only the buffer object
instantiation is done in js and the string is processed in cpp.
Also added a Buffer api that also accepts the encoding.
Fedor Indutny [Wed, 19 Jun 2013 08:16:59 +0000 (10:16 +0200)]
crypto: change assertion to condition in bio
Read head can be the same as write head, even if there's some data to
read.
Trevor Norris [Fri, 7 Jun 2013 17:31:53 +0000 (10:31 -0700)]
buffer: proper API export for Windows
So that Windows users can properly include smalloc and node_buffer,
NODE_EXTERN was added to the headers that export this functionality.
Trevor Norris [Fri, 24 May 2013 17:58:30 +0000 (10:58 -0700)]
buffer: implement new fill behavior
Old fill would take the char code of the first character and wrap around
the int to fit in the 127 range. Now fill will duplicate whatever string
is given through the entirety of the buffer.
Note: There is one bug around ending on a partial fill of any character
outside the ASCII range.
Trevor Norris [Fri, 26 Apr 2013 23:58:18 +0000 (16:58 -0700)]
buffer: deprecate legacy code
Several things are now no longer necessary. These have been deprecated,
and will be removed in v0.13.
Trevor Norris [Mon, 29 Apr 2013 05:13:45 +0000 (22:13 -0700)]
buffer: remove c-style casts
Trevor Norris [Wed, 15 May 2013 18:01:33 +0000 (11:01 -0700)]
buffer: expose class methods alloc and dispose
Expose the ability for users to allocate and manually dispose data on
any object. These are user-safe versions of internal smalloc functions.
Trevor Norris [Wed, 17 Apr 2013 23:29:14 +0000 (16:29 -0700)]
buffer: reimplement Buffer pools
While the new Buffer implementation is much faster we still have the
necessity of using Buffer pools. This is undesirable because it may
still lead to unwanted memory retention, but for the time being this is
the best solution.
Because of this re-introduction, and since there is no more SlowBuffer
type, the SlowBuffer method has been re-purposed to return a non-pooled
Buffer instance. This will be helpful for developers to store data for
indeterminate lengths of time without introducing a memory leak.
Another change to Buffer pools was that they are only allocated if the
requested chunk is < poolSize / 2. This was done because allocations are
much quicker now, and it's a better use of the pool.
Trevor Norris [Wed, 17 Apr 2013 23:26:15 +0000 (16:26 -0700)]
buffer: use smalloc as backing data store
Memory allocations are now done through smalloc. The Buffer cc class has
been removed completely, but for backwards compatibility have left the
namespace as Buffer.
The .parent attribute is only set if the Buffer is a slice of an
allocation. Which is then set to the alloc object (not a Buffer).
The .offset attribute is now a ReadOnly set to 0, for backwards
compatibility. I'd like to remove it in the future (pre v1.0).
A few alterations have been made to how arguments are either coerced or
thrown. All primitives will now be coerced to their respective values,
and (most) all out of range index requests will throw.
The indexes that are coerced were left for backwards compatibility. For
example: Buffer slice operates more like Array slice, and coerces
instead of throwing out of range indexes. This may change in the future.
The reason for wanting to throw for out of range indexes is because
giving js access to raw memory has high potential risk. To mitigate that
it's easier to make sure the developer is always quickly alerted to the
fact that their code is attempting to access beyond memory bounds.
Because SlowBuffer will be deprecated, and simply returns a new Buffer
instance, all tests on SlowBuffer have been removed.
Heapdumps will now show usage under "smalloc" instead of "Buffer".
ParseArrayIndex was added to node_internals to support proper uint
argument checking/coercion for external array data indexes.
SlabAllocator had to be updated since handle_ no longer exists.
Trevor Norris [Tue, 14 May 2013 23:27:10 +0000 (16:27 -0700)]
smalloc: add api to manually dispose Persistent
If the user knows the allocation is no longer needed then the memory can
be manually released.
Currently this will not ClearWeak the Persistent, so the callback will
still run.
If the user passed a ClearWeak callback, and then disposed the object,
the buffer callback argument will == NULL.
Trevor Norris [Wed, 17 Apr 2013 23:18:47 +0000 (16:18 -0700)]
smalloc: initial implementation
smalloc is a simple utility for quickly allocating external memory onto
js objects. This will be used to centralize how memory is managed in
node, and will become the backer for Buffers. So in the future crypto's
SlabBuffer, stream's SlabAllocator will be removed.
Note on the js API: because no arguments are optional the order of
arguments have been placed to match their cc counterparts as closely as
possible.
Sam Roberts [Tue, 11 Jun 2013 23:49:56 +0000 (16:49 -0700)]
doc: call console module 'console' not 'stdio'
The console module has always been called 'stdio' in the
table-of-contents, but nowhere else, since its name is
'console'. This makes it difficult to find.
This is a back-port of commit 226a20d from the master branch.
isaacs [Tue, 18 Jun 2013 18:15:09 +0000 (11:15 -0700)]
blog: Release 0.10.12
isaacs [Tue, 18 Jun 2013 18:14:57 +0000 (11:14 -0700)]
Now working on 0.10.13
isaacs [Tue, 18 Jun 2013 18:13:26 +0000 (11:13 -0700)]
Merge branch 'v0.10.12-release' into v0.10
isaacs [Tue, 18 Jun 2013 16:50:53 +0000 (09:50 -0700)]
2013.06.18, Version 0.10.12 (Stable)
* npm: Upgrade to 1.2.32
* readline: make `ctrl + L` clear the screen (Yuan Chuan)
* v8: add setVariableValue debugger command (Ben Noordhuis)
* net: Do not destroy socket mid-write (isaacs)
* v8: fix build for mips32r2 architecture (Andrei Sedoi)
* configure: fix cross-compilation host_arch_cc() (Andrei Sedoi)
isaacs [Tue, 18 Jun 2013 16:42:42 +0000 (09:42 -0700)]
npm: Upgrade to 1.2.32
Rod Vagg [Sun, 16 Jun 2013 07:30:50 +0000 (17:30 +1000)]
doc: cleanup addons code, fix isolate positioning
isolate declaration global and above `using namespace v8`
removed BUILDING_NODE_EXTENSION and tidied up code
Rod Vagg [Thu, 13 Jun 2013 05:05:33 +0000 (15:05 +1000)]
doc: cleanup addons docs for 80 char lines
Bert Belder [Mon, 17 Jun 2013 23:15:25 +0000 (01:15 +0200)]
stream_wrap: remove bogus assert
Libuv may provide a NULL buffer to the uv_read callback in case of an
error, so with this assert we'd be using the api incorrectly. None of
the current DoRead implementations rely on this constraint, either.
Ben Noordhuis [Mon, 17 Jun 2013 21:25:01 +0000 (23:25 +0200)]
src: clean up `using` directives
Remove the unused ones and alphabetically sort the ones that remain.
Sam Roberts [Tue, 11 Jun 2013 23:49:56 +0000 (16:49 -0700)]
doc: call console module 'console' not 'stdio'
The console module has always been called 'stdio' in the
table-of-contents, but nowhere else, since its name is
'console'. This makes it difficult to find.
Timothy J Fontaine [Mon, 17 Jun 2013 17:26:07 +0000 (10:26 -0700)]
build: fix include order for building on windows
fallout from the tls_wrap feature landing
Linus Mårtensson [Wed, 8 May 2013 12:10:07 +0000 (14:10 +0200)]
build: add android support
Resolves minor discrepancies between android and standard POSIX systems.
In addition, some configure parameters were added, and a helper-script
for android configuration. Ideally, this script should be merged into
the standard configure script.
To build for android, source the android-configure script with an NDK
path:
source ./android-configure ~/android-ndk-r8d
This will create an android standalone toolchain and export the
necessary environment parameters.
After that, build as normal:
make -j8
After the build, you should now have android-compatible NodeJS binaries.
Krzysztof Chrapka [Tue, 4 Jun 2013 15:01:14 +0000 (17:01 +0200)]
readline: strip ctrl chars for prompt width calc
Use regular expression to strip vt ansi escape codes from display when
calulating prompt display width and cursor position
Fixes #3860 and #5628.
Yuan Chuan [Sat, 15 Jun 2013 07:48:36 +0000 (15:48 +0800)]
readline: make `ctrl + L` clear the screen
Ben Noordhuis [Mon, 3 Dec 2012 20:29:29 +0000 (20:29 +0000)]
v8: add setVariableValue debugger command
Issue 2399 part 1: In debugger allow modifying local variable values
Issue 2399 part 2: In debugger allow modifying local variable values
Review URL: https://codereview.chromium.org/
11415042
Review URL: https://codereview.chromium.org/
11412310
This is a back-port of upstream svn commits r13122 and r13202.
Fedor Indutny [Mon, 17 Jun 2013 10:11:13 +0000 (12:11 +0200)]
tls: session API returns
isaacs [Fri, 14 Jun 2013 22:57:11 +0000 (15:57 -0700)]
net: Do not destroy socket mid-write
The fix in
e0519ace315c7ce14278d5eaab8d1d72a0a0a054 is overly zealous,
and can destroy a socket while there are still outstanding writes in
progress.
Closes GH-5688
isaacs [Mon, 17 Jun 2013 01:56:00 +0000 (18:56 -0700)]
doc: Correct TLS deprecation notices
Ben Noordhuis [Sun, 16 Jun 2013 23:23:57 +0000 (01:23 +0200)]
stream_wrap: fix signed/unsigned comparison warning
Ben Noordhuis [Sun, 16 Jun 2013 23:22:41 +0000 (01:22 +0200)]
cares: fix uninitialized variable warning
Suppress the following warning:
../../src/cares_wrap.cc: In function ‘v8::Handle<v8::Value>
node::cares_wrap::SetServers(const v8::Arguments&)’:
../../src/cares_wrap.cc:1017:5: warning: ‘uv_ret.uv_err_s::code’
may be used uninitialized in this function [-Wuninitialized]
Fedor Indutny [Thu, 13 Jun 2013 19:47:31 +0000 (21:47 +0200)]
tls: share socket._hadError with http_client
Fedor Indutny [Thu, 13 Jun 2013 13:36:00 +0000 (15:36 +0200)]
tls: introduce TLSSocket based on tls_wrap binding
Split `tls.js` into `_tls_legacy.js`, containing legacy
`createSecurePair` API, and `_tls_wrap.js` containing new code based on
`tls_wrap` binding.
Remove tests that are no longer useful/valid.
Fedor Indutny [Tue, 11 Jun 2013 10:59:10 +0000 (12:59 +0200)]
tls_wrap: embed TLS encryption into streamwrap
Fedor Indutny [Tue, 11 Jun 2013 10:55:49 +0000 (12:55 +0200)]
stream_wrap: introduce StreamWrapCallbacks
StreamWrapCallbacks is a helper class for incepting into uv_stream_t*
management process.
Fedor Indutny [Tue, 11 Jun 2013 10:52:27 +0000 (12:52 +0200)]
process: abstract out HandleToStream
Originally contributed by @tjfontaine, but modified to be faster and
more generic.
Fedor Indutny [Thu, 13 Jun 2013 11:29:15 +0000 (13:29 +0200)]
crypto: clear error on return in AddCRL
Fedor Indutny [Tue, 11 Jun 2013 14:11:48 +0000 (16:11 +0200)]
crypto: ensure that read head is always non-empty
Ben Noordhuis [Sat, 15 Jun 2013 18:33:17 +0000 (20:33 +0200)]
test: add https tls session reuse test
Check that TLS session resumptions work with HTTPS servers.
Regression test for #3901.
isaacs [Fri, 14 Jun 2013 17:26:15 +0000 (10:26 -0700)]
blog: Add favicon to blog site
isaacs [Fri, 14 Jun 2013 17:25:47 +0000 (10:25 -0700)]
doc: Remove unnecessary sh script tags
Andrei Sedoi [Fri, 14 Jun 2013 14:48:49 +0000 (17:48 +0300)]
v8: fix build for mips32r2 architecture
This is a floating patch as a backport from v8 3.15.0
Committed: https://code.google.com/p/v8/source/detail?r=12833
Fedor Indutny [Thu, 13 Jun 2013 10:59:29 +0000 (12:59 +0200)]
crypto: do not deallocate embedded buffer
Fedor Indutny [Tue, 11 Jun 2013 10:49:03 +0000 (12:49 +0200)]
crypto: fix excessive buffer allocation
Allocate buffer only if the next one isn't free.
Andrei Sedoi [Fri, 14 Jun 2013 12:49:14 +0000 (15:49 +0300)]
configure: fix cross-compilation host_arch_cc()
In case of cross-compilation host_arch_cc() function could return
target arch if CC was set to target arch compiler. Host arch
compiler should always be used in this case. This was broken
by commit 707863c.
isaacs [Thu, 13 Jun 2013 20:22:46 +0000 (13:22 -0700)]
doc: v0.8.25 changelog entry
isaacs [Thu, 13 Jun 2013 20:22:07 +0000 (13:22 -0700)]
blog: Release v0.8.25
isaacs [Thu, 13 Jun 2013 18:37:18 +0000 (11:37 -0700)]
blog: Release 0.10.11
isaacs [Thu, 13 Jun 2013 18:37:04 +0000 (11:37 -0700)]
Now working on 0.10.12
isaacs [Thu, 13 Jun 2013 18:36:41 +0000 (11:36 -0700)]
Merge branch 'v0.10.11-release' into v0.10
isaacs [Thu, 13 Jun 2013 17:35:30 +0000 (10:35 -0700)]
2013.06.13, Version 0.10.11 (Stable)
* uv: upgrade to 0.10.11
* npm: Upgrade to 1.2.30
* openssl: add missing configuration pieces for MIPS (Andrei Sedoi)
* Revert "http: remove bodyHead from 'upgrade' events" (isaacs)
* v8: fix pointer arithmetic undefined behavior (Trevor Norris)
* crypto: fix utf8/utf-8 encoding check (Ben Noordhuis)
* net: Fix busy loop on POLLERR|POLLHUP on older linux kernels (Ben Noordhuis, isaacs)
Veres Lajos [Wed, 12 Jun 2013 22:51:17 +0000 (23:51 +0100)]
test: minor typo fixes
Andrei Sedoi [Wed, 12 Jun 2013 15:47:10 +0000 (18:47 +0300)]
openssl: add missing configuration pieces for MIPS
isaacs [Thu, 13 Jun 2013 00:45:30 +0000 (17:45 -0700)]
Revert "http: remove bodyHead from 'upgrade' events"
This reverts commit
a40133d10cdb911b27fe8d46d67a835b0103bbf1.
Unfortunately, this breaks socket.io. Even though it's not strictly an
API change, it is too subtle and in too brittle an area of node, to be
done in a stable branch.
Conflicts:
doc/api/http.markdown
Trevor Norris [Tue, 11 Jun 2013 21:30:16 +0000 (14:30 -0700)]
string_bytes: write strings using new API
StringBytes::Write now uses new v8 API and also does preliminary check
if the string is external, then will use external memory instead.
Trevor Norris [Sun, 9 Jun 2013 22:54:30 +0000 (15:54 -0700)]
string_bytes: use external for large strings
When large strings are used they cause v8's GC to spend a lot more time
cleaning up. In these cases it's much faster to use external string
resources.
UTF8 strings do not use external string resources because only one and
two byte external strings are supported.
EXTERN_APEX is the value at which v8's GC overtakes performance.
The following table has the type and buffer size that use to encode the
strings as rough estimates of the percentage of performance gain from
this patch (UTF8 is missing because they cannot be externalized).
encoding 128KB 1MB 5MB
-----------------------------
ASCII 58% 208% 250%
HEX 15% 74% 86%
BASE64 11% 74% 71%
UCS2 2% 225% 398%
BINARY 2234% 1728% 2305%
BINARY is so much faster across the board because of using the new v8
WriteOneByte API.
Ben Noordhuis [Wed, 12 Jun 2013 20:10:39 +0000 (22:10 +0200)]
uv: upgrade to 0.10.11
isaacs [Wed, 12 Jun 2013 17:59:44 +0000 (10:59 -0700)]
npm: Upgrade to 1.2.30
Trevor Norris [Sun, 9 Jun 2013 21:34:11 +0000 (14:34 -0700)]
string_bytes: implement new v8 API
v8 has a new API to write out strings to memory. This has been
implemented.
One other change of note is BINARY encoded strings have a new
implementation. This has improved performance substantially.
Trevor Norris [Sun, 9 Jun 2013 21:20:01 +0000 (14:20 -0700)]
lint: add mising isolates and minor style fixes
Ben Noordhuis [Tue, 11 Jun 2013 22:24:41 +0000 (00:24 +0200)]
test: fix up weakref.cc after v8 api change
Ben Noordhuis [Tue, 11 Jun 2013 22:07:26 +0000 (00:07 +0200)]
src: upgrade after v8 api change
The prototype of v8::Persistent<T>::MakeWeak() has changed. Update the
code in src/ to follow suit.
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches
Ben Noordhuis [Tue, 11 Jun 2013 21:45:46 +0000 (23:45 +0200)]
v8: upgrade to v3.19.13
Trevor Norris [Tue, 11 Jun 2013 21:39:25 +0000 (14:39 -0700)]
v8: fix pointer arithmetic undefined behavior
Clang branch release_33 would optimize out a != NULL check because of
some undefined behavior. This is a floating patch as a backport of that
fix.
Committed: http://code.google.com/p/v8/source/detail?r=13570
Ben Noordhuis [Mon, 10 Jun 2013 21:34:11 +0000 (23:34 +0200)]
crypto: fix utf8/utf-8 encoding check
Normalize the encoding in getEncoding() before using it. Fixes a
"AssertionError: Cannot change encoding" exception when the caller
mixes "utf8" and "utf-8".
Fixes #5655.
Fedor Indutny [Fri, 7 Jun 2013 11:31:24 +0000 (15:31 +0400)]
crypto: free excessive memory in NodeBIO
Before this commit NodeBIO never shrank, possibly consuming a lot of
memory (depending on reader's haste).
All buffers between write_head's child and read_head should be
deallocated on read, leaving only space left in write_head and in the
next buffer.
Ben Noordhuis [Fri, 7 Jun 2013 14:47:54 +0000 (16:47 +0200)]
src: unexport node_isolate
Commit
0bba5902 accidentally (or maybe erroneously) added node_isolate
to src/node.h and src/node_object_wrap.h.
Undo that, said variable is not for public consumption. Add-on authors
should use v8::Isolate::GetCurrent() instead.
I missed that while reviewing. Mea culpa.
Fixes #5639.
Timothy J Fontaine [Tue, 4 Jun 2013 00:05:56 +0000 (17:05 -0700)]
build: add pkgsrc rule
isaacs [Thu, 6 Jun 2013 21:44:48 +0000 (14:44 -0700)]
npm: Upgrade to 1.2.27
isaacs [Wed, 5 Jun 2013 20:38:38 +0000 (13:38 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
ChangeLog
deps/uv/AUTHORS
deps/uv/ChangeLog
deps/uv/src/unix/linux-core.c
deps/uv/src/version.c
deps/uv/src/win/timer.c
lib/url.js
src/node_version.h
test/simple/test-url.js
isaacs [Wed, 5 Jun 2013 06:43:29 +0000 (23:43 -0700)]
net: Destroy when not readable and not writable
This is only relevant for CentOS 6.3 using kernel version 2.6.32.
On other linuxes and darwin, the `read` call gets an ECONNRESET in that
case. On sunos, the `write` call fails with EPIPE.
However, old CentOS will occasionally send an EOF instead of a
ECONNRESET or EPIPE when the client has been destroyed abruptly.
Make sure we don't keep trying to write or read more in that case.
Fixes #5504
However, there is still the question of what libuv should do when it
gets an EOF. Apparently in this case, it will continue trying to read,
which is almost certainly the wrong thing to do.
That should be fixed in libuv, even though this works around the issue.
isaacs [Tue, 4 Jun 2013 21:38:41 +0000 (14:38 -0700)]
Now working on v0.10.11
isaacs [Tue, 4 Jun 2013 21:38:29 +0000 (14:38 -0700)]
blog: Release v0.10.10
isaacs [Tue, 4 Jun 2013 21:38:10 +0000 (14:38 -0700)]
Merge branch 'v0.10.10-release' into v0.10
isaacs [Tue, 4 Jun 2013 19:13:46 +0000 (12:13 -0700)]
2013.06.04, Version 0.10.10 (Stable)
* uv: Upgrade to 0.10.10
* npm: Upgrade to 1.2.25
* url: Properly parse certain oddly formed urls (isaacs)
* stream: unshift('') is a noop (isaacs)
isaacs [Tue, 4 Jun 2013 19:11:03 +0000 (12:11 -0700)]
uv: Upgrade to 0.10.10
Ben Noordhuis [Tue, 21 May 2013 21:04:58 +0000 (23:04 +0200)]
url: remove unused global variable
isaacs [Tue, 4 Jun 2013 18:42:32 +0000 (11:42 -0700)]
npm: Upgrade to 1.2.25
isaacs [Tue, 4 Jun 2013 18:22:14 +0000 (11:22 -0700)]
doc: ChangeLog update for v0.8.24
isaacs [Tue, 4 Jun 2013 18:19:10 +0000 (11:19 -0700)]
blog: 0.8 is maintenace, not stable
isaacs [Tue, 4 Jun 2013 18:12:54 +0000 (11:12 -0700)]
blog: Release v0.8.24
isaacs [Tue, 4 Jun 2013 18:12:44 +0000 (11:12 -0700)]
blog: Release v0.10.9
Ben Noordhuis [Tue, 4 Jun 2013 10:21:58 +0000 (12:21 +0200)]
src: replace ngx-queue.h with queue.h
No functional changes, just one less entry in the LICENSE file.
Nick Desaulniers [Tue, 4 Jun 2013 07:09:00 +0000 (00:09 -0700)]
src: wrap macros in `do {...} while (0)`
Wrapped two macros in do {...} while (0) blocks and lined up
backslashes. Uses up semicolon in contexts where a dangling semicolon
is erroneous.
isaacs [Mon, 3 Jun 2013 23:02:51 +0000 (16:02 -0700)]
url: Set href to null by default
isaacs [Mon, 3 Jun 2013 20:39:57 +0000 (13:39 -0700)]
url: Properly parse certain oddly formed urls
In cases where there are multiple @-chars in a url, Node currently
parses the hostname and auth sections differently than web browsers.
This part of the bug is serious, and should be landed in v0.10, and
also ported to v0.8, and releases made as soon as possible.
The less serious issue is that there are many other sorts of malformed
urls which Node either accepts when it should reject, or interprets
differently than web browsers. For example, `http://a.com*foo` is
interpreted by Node like `http://a.com/*foo` when web browsers treat
this as `http://a.com%3Bfoo/`.
In general, *only* the `hostEndingChars` should be the characters that
delimit the host portion of the URL. Most of the current `nonHostChars`
that appear in the hostname should be escaped, but some of them (such as
`;` and `%` when it does not introduce a hex pair) should raise an
error.
We need to have a broader discussion about whether it's best to throw in
these cases, and potentially break extant programs, or return an object
that has every field set to `null` so that any attempt to read the
hostname/auth/etc. will appear to be empty.
isaacs [Mon, 3 Jun 2013 17:50:02 +0000 (10:50 -0700)]
stream: unshift('') is a noop
In some cases, the http CONNECT/Upgrade API is unshifting an empty
bodyHead buffer onto the socket.
Normally, stream.unshift(chunk) does not set state.reading=false.
However, this check was not being done for the case when the chunk was
empty (either `''` or `Buffer(0)`), and as a result, it was causing the
socket to think that a read had completed, and to stop providing data.
This bug is not limited to http or web sockets, but rather would affect
any parser that unshifts data back onto the source stream without being
very careful to never unshift an empty chunk. Since the intent of
unshift is to *not* change the state.reading property, this is a bug.
Fixes #5557
Fixes LearnBoost/socket.io#1242
isaacs [Fri, 31 May 2013 18:52:57 +0000 (11:52 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
ChangeLog
src/node_version.h
Trevor Norris [Thu, 30 May 2013 23:51:41 +0000 (16:51 -0700)]
process: use Tock for nextTickQueue items
v8 plays very well with constructed objects, so we're using one in the
nextTickQueue.
Trevor Norris [Thu, 30 May 2013 22:09:50 +0000 (15:09 -0700)]
src: remove old comment code
Now that maxTickDepth no longer exists there's no depth index on
infoBox. Forgot to remove the comment about this.
Trevor Norris [Thu, 30 May 2013 17:33:29 +0000 (10:33 -0700)]
process: remove spinner
Remove the need to call start/stop the uv_idle spinner between
MakeCallbacks. The one place where the tick processor needs to be kicked
is where a user catches uncaughtException. For that we'll now use
setImmediate, which accomplishes the same task.