platform/upstream/libSkiaSharp.git
9 years agoadd SkMatrix::decomposeScale
reed [Thu, 19 Mar 2015 23:10:54 +0000 (16:10 -0700)]
add SkMatrix::decomposeScale

BUG=skia:

Review URL: https://codereview.chromium.org/1006173005

9 years agoTry out operator overloads for Sk2x.
mtklein [Thu, 19 Mar 2015 21:28:31 +0000 (14:28 -0700)]
Try out operator overloads for Sk2x.

BUG=skia:

Review URL: https://codereview.chromium.org/1024473005

9 years agoSupport BGR with DirectWrite.
bungeman [Thu, 19 Mar 2015 20:57:36 +0000 (13:57 -0700)]
Support BGR with DirectWrite.

BUG=chromium:468509

Review URL: https://codereview.chromium.org/1018863003

9 years agoRemove now-unused uniqueID param from SkDropShadowImageFilter::Create().
senorblanco [Thu, 19 Mar 2015 20:39:19 +0000 (13:39 -0700)]
Remove now-unused uniqueID param from SkDropShadowImageFilter::Create().

Also make both input & crop rect default NULL, as in other filter Create functions.

BUG=skia:

Review URL: https://codereview.chromium.org/1016343002

9 years agoBlacklist certain win7 gms that are never finishing on dm
egdaniel [Thu, 19 Mar 2015 20:09:17 +0000 (13:09 -0700)]
Blacklist certain win7 gms that are never finishing on dm

BUG=skia:

Review URL: https://codereview.chromium.org/1013483004

9 years agoSk2x for NEON
mtklein [Thu, 19 Mar 2015 19:08:29 +0000 (12:08 -0700)]
Sk2x for NEON

Also decreases the precision of Sk4f::rsqrt() for speed, keeping Sk4f::sqrt() the same:
instead of doing two estimation steps in rsqrt(), do one there and one more in sqrt().

Tests pass on my Nexus 7.  float64x2_t is still a TODO for when I get a hold of a Nexus 9.

BUG=skia:

Review URL: https://codereview.chromium.org/1018423003

9 years agoPort to real Sk2f.
mtklein [Thu, 19 Mar 2015 19:03:29 +0000 (12:03 -0700)]
Port to real Sk2f.

The bench improves from 39 to 30, about half from porting to Sk2f, half from
x.add(x) instead of x.multiply(two).

Remove Sk4f Load2/store2 now that we have Sk2f.

BUG=skia:

Review URL: https://codereview.chromium.org/1019773004

9 years agoremove unneeded SK_SUPPORT_LEGACY_MIPMAP_EFFECTIVE_SCALE guard
reed [Thu, 19 Mar 2015 18:37:18 +0000 (11:37 -0700)]
remove unneeded SK_SUPPORT_LEGACY_MIPMAP_EFFECTIVE_SCALE guard

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1019343002

9 years agoAdd minimum size for using distance fields.
jvanverth [Thu, 19 Mar 2015 18:34:13 +0000 (11:34 -0700)]
Add minimum size for using distance fields.

Since we're not scaling down as far, we can increase the base
sizes a little.

Also darken debug text colors to get better value comparison
with black.

BUG=skia:3541

Review URL: https://codereview.chromium.org/1001183003

9 years agoMove skp nanobench tile size back to 256x256 to see if it fixes nanobench crashes
egdaniel [Thu, 19 Mar 2015 18:00:09 +0000 (11:00 -0700)]
Move skp nanobench tile size back to 256x256 to see if it fixes nanobench crashes

Going back to old nanobench tile size to see if the increase to tile is what has been
causing recent nanobench crashes. The crashes seem very nondeterministic and hard to
debug manually.

256x256 is too small of a tile to give accurate gpu results but if this fixes we can try some compromise in the middle

BUG=skia:

Review URL: https://codereview.chromium.org/1022823003

9 years agoSk2x
mtklein [Thu, 19 Mar 2015 17:44:27 +0000 (10:44 -0700)]
Sk2x

This adds an API, an SSE impl, a portable impl, and some tests for Sk2f/Sk2d/Sk2s.

BUG=skia:

Review URL: https://codereview.chromium.org/1025463002

9 years agoUse typographic font metrics when the font requests.
bungeman [Thu, 19 Mar 2015 17:43:57 +0000 (10:43 -0700)]
Use typographic font metrics when the font requests.

FreeType always returns the 'hhea' font metrics for ascent and descent,
and ignores the 'OS/2'::fsSelection::UseTypoMetrics bit. (It also
ignores the VDMX table, which makes this change correct.) This change
uses the typographic font metrics when the font requests their use.

Review URL: https://codereview.chromium.org/1020643002

9 years agoReorg Sk4x to match the pattern of SkPMFloat.
mtklein [Thu, 19 Mar 2015 17:19:48 +0000 (10:19 -0700)]
Reorg Sk4x to match the pattern of SkPMFloat.

No real changes here, just moving files around:
  - move impl files into src/opts
  - rename _portable _none

BUG=skia:

Review URL: https://codereview.chromium.org/1021713004

9 years agoalt SkEvalQuadAt that returns its answer, using Sk2f
reed [Thu, 19 Mar 2015 17:18:47 +0000 (10:18 -0700)]
alt SkEvalQuadAt that returns its answer, using Sk2f

BUG=skia:

Review URL: https://codereview.chromium.org/1011493003

9 years agoremove unused clip parameter to SkEdge::setClip
reed [Thu, 19 Mar 2015 16:49:09 +0000 (09:49 -0700)]
remove unused clip parameter to SkEdge::setClip

BUG=skia:

Review URL: https://codereview.chromium.org/1019183002

9 years agoguarded change to SkImageGenerator to make getInfo() const
reed [Thu, 19 Mar 2015 15:31:14 +0000 (08:31 -0700)]
guarded change to SkImageGenerator to make getInfo() const

BUG=skia:

Review URL: https://codereview.chromium.org/1017293002

9 years agoWhitespace change to test the CQ
rmistry [Thu, 19 Mar 2015 14:56:12 +0000 (07:56 -0700)]
Whitespace change to test the CQ

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1019313002

9 years agoEnsure that we use different glyph entries for regular and df text.
jvanverth [Thu, 19 Mar 2015 13:08:31 +0000 (06:08 -0700)]
Ensure that we use different glyph entries for regular and df text.

Currently if we switch between regular text and df text while using
the same GrContext, they may use the same entry in the Ganesh font cache,
which is incorrect. This change ensures that they will have different entries.

Committed: https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034

Review URL: https://codereview.chromium.org/1020593003

9 years agoRun CodecSrc DM.
scroggo [Thu, 19 Mar 2015 13:03:39 +0000 (06:03 -0700)]
Run CodecSrc  DM.

Rather than making SkCodec an option instead of SkImageDecoder,
create a separate CodecSrc. This allows us to compare the two.

For both CodecSrc and ImageSrc, do not decode to a gpu backend.

BUG=skia:3475

Review URL: https://codereview.chromium.org/978823002

9 years agoRevert of replace SkFixedDiv impl with native 64bit math (patchset #2 id:20001 of...
reed [Thu, 19 Mar 2015 11:10:42 +0000 (04:10 -0700)]
Revert of replace SkFixedDiv impl with native 64bit math (patchset #2 id:20001 of https://codereview.chromium.org/1022543003/)

Reason for revert:
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53096

layouttests failures

Original issue's description:
> replace SkFixedDiv impl with native 64bit math
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/7c44ca926bf42b3b2e56131f250c0fd58f87ac71

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1018523008

9 years agoremove unused SkXRay functions
reed [Thu, 19 Mar 2015 02:32:47 +0000 (19:32 -0700)]
remove unused SkXRay functions

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1016263002

9 years agoreplace SkFixedDiv impl with native 64bit math
reed [Thu, 19 Mar 2015 02:04:43 +0000 (19:04 -0700)]
replace SkFixedDiv impl with native 64bit math

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1022543003

9 years agoRevert of Ensure that we use different glyph entries for regular and df text. (patchs...
jvanverth [Wed, 18 Mar 2015 22:14:05 +0000 (15:14 -0700)]
Revert of Ensure that we use different glyph entries for regular and df text. (patchset #2 id:20001 of https://codereview.chromium.org/1020593003/)

Reason for revert:
Bad glyphs in dftext GM.

Original issue's description:
> Ensure that we use different glyph entries for regular and df text.
>
> Currently if we switch between regular text and df text while using
> the same GrContext, they may use the same entry in the Ganesh font cache,
> which is incorrect. This change ensures that they will have different entries.
>
> Committed: https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034

TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1011403005

9 years agoEnsure that we use different glyph entries for regular and df text.
jvanverth [Wed, 18 Mar 2015 21:46:38 +0000 (14:46 -0700)]
Ensure that we use different glyph entries for regular and df text.

Currently if we switch between regular text and df text while using
the same GrContext, they may use the same entry in the Ganesh font cache,
which is incorrect. This change ensures that they will have different entries.

Review URL: https://codereview.chromium.org/1020593003

9 years agotemporarily stifle Math test on TSAN bot
mtklein [Wed, 18 Mar 2015 21:06:55 +0000 (14:06 -0700)]
temporarily stifle Math test on TSAN bot

BUG=skia:3562

Review URL: https://codereview.chromium.org/1017283002

9 years agoRemove recent changes to use temp fbo to do stencil clears.
egdaniel [Wed, 18 Mar 2015 20:26:11 +0000 (13:26 -0700)]
Remove recent changes to use temp fbo to do stencil clears.

In order to implement these stencil clears we had to use a work around where we
would bind a color buffer renderbuffer to the fbo before clearing the stencil buffer.
However this workaround seems to cause the win 7 hd2000 machines to all crash on some
memory access issue.

For now we will comment on the change and go back to the old world

BUG=skia:

Review URL: https://codereview.chromium.org/1015223002

9 years agoBump picture version for uniqueID-less SkImageFilter.
senorblanco [Wed, 18 Mar 2015 20:14:54 +0000 (13:14 -0700)]
Bump picture version for uniqueID-less SkImageFilter.

Remove writing of the uniqueID, and put reading behind a version check.

BUG=skia:3559

Review URL: https://codereview.chromium.org/1010433003

9 years agoRevert of Improve tracking of bound FBOs in GrGLGpu. (patchset #17 id:320001 of https...
egdaniel [Wed, 18 Mar 2015 20:01:52 +0000 (13:01 -0700)]
Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #17 id:320001 of https://codereview.chromium.org/949263002/)

Reason for revert:
Perf regression on win8 hd7700 gpu skps

Original issue's description:
> Improve tracking of bound FBOs in GrGLGpu.
>
> Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0
>
> Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589
>
> Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef
>
> Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac
>
> Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88
>
> Committed: https://skia.googlesource.com/skia/+/160f24ce0e8d6dd7ca80b78871e063d4f4609cfb

TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1009563003

9 years agoDo not create empty color table if it does not exist
msarett [Wed, 18 Mar 2015 19:59:46 +0000 (12:59 -0700)]
Do not create empty color table if it does not exist

BUG=skia:

Review URL: https://codereview.chromium.org/1019543003

9 years agoAdd Load2/store2 to Sk4x (dumb impl for now)
reed [Wed, 18 Mar 2015 19:56:46 +0000 (12:56 -0700)]
Add Load2/store2 to Sk4x (dumb impl for now)

patch from issue 1001003002 at patchset 1 (http://crrev.com/1001003002#ps1)

BUG=skia:

Review URL: https://codereview.chromium.org/1001453006

9 years agoRemove uniqueID from all filter serialization.
senorblanco [Wed, 18 Mar 2015 19:11:33 +0000 (12:11 -0700)]
Remove uniqueID from all filter serialization.

(This is essentially a revert of https://codereview.chromium.org/503833002/.)

This was necessary back when SkPaint was flattened even for in-process use. Now that we only flatten SkPaint for cross-process use, there's no need to serialize UniqueIDs.

Note: SkDropShadowImageFilter is being constructed with a croprect and UniqueID (of 0) in Blink. I've made the uniqueID param default to 0 temporarily, until this rolls in and Blink can be changed. (Blink can't be changed first, since unlike the other filters, there's no constructor that takes a cropRect but not a uniqueID.)

BUG=skia:

Review URL: https://codereview.chromium.org/1019493002

9 years agoextend neon table as well for gray8
reed [Wed, 18 Mar 2015 18:52:35 +0000 (11:52 -0700)]
extend neon table as well for gray8

BUG=skia:

Review URL: https://codereview.chromium.org/1021583002

9 years agoSimple patch to have draw path call an internal drawPath
joshualitt [Wed, 18 Mar 2015 18:49:12 +0000 (11:49 -0700)]
Simple patch to have draw path call an internal drawPath

The purpose of this patch is to expose an internal draw path call which text contexts can use.

BUG=skia:

Review URL: https://codereview.chromium.org/1012143005

9 years agoLet's find out what's up with the TSAN bot test failures.
mtklein [Wed, 18 Mar 2015 18:32:21 +0000 (11:32 -0700)]
Let's find out what's up with the TSAN bot test failures.

BUG=skia:

Review URL: https://codereview.chromium.org/1020573002

9 years agoAdding swizzles for bmp:
msarett [Wed, 18 Mar 2015 18:11:19 +0000 (11:11 -0700)]
Adding swizzles for bmp:
    We now support kN32 and kRGB_565 color types.
    Additionally, we support premul, unpremul, and opaque alpha types.
    Unpremul is currently untested as we cannot currently draw to unpremul.

BUG=skia:

Review URL: https://codereview.chromium.org/1013743003

9 years agoUpdate to identically match the sources used on Android
djsollen [Wed, 18 Mar 2015 17:58:02 +0000 (10:58 -0700)]
Update to identically match the sources used on Android

Review URL: https://codereview.chromium.org/1020563002

9 years agoImplement SkCodec::getScaledDimensions.
scroggo [Wed, 18 Mar 2015 17:50:37 +0000 (10:50 -0700)]
Implement SkCodec::getScaledDimensions.

Left out of a prior CL since no one was calling it...

Review URL: https://codereview.chromium.org/995303004

9 years agoSkPMFloat: avoid loads and stores where possible.
mtklein [Wed, 18 Mar 2015 16:51:23 +0000 (09:51 -0700)]
SkPMFloat: avoid loads and stores where possible.

A store/load pair like this is a redundant no-op:
  store simd_register_a, memory_address
  load  memory_address, simd_register_a

Everyone seems to be good at removing those when using SSE, but GCC and Clang
are pretty terrible at this for NEON.  We end up issuing both redundant
commands, usually to and from the stack.  That's slow.  Let's not do that.

This CL unions in the native SIMD register type into SkPMFloat, so that we can
assign to and from it directly, which is generating a lot better NEON code.  On
my Nexus 5, the benchmarks improve from 36ns to 23ns.

SSE is just as fast either way, but I paralleled the NEON code for consistency.
It's a little terser.  And because it needed the platform headers anyway, I
moved all includes into SkPMFloat.h, again only for consistency.

I'd union in Sk4f too to make its conversion methods a little clearer,
but MSVC won't let me (it has a copy constructor... they're apparently not up
to speed with C++11 unrestricted unions).

BUG=skia:

Review URL: https://codereview.chromium.org/1015083004

9 years agoRestore GDI text size rounding.
bungeman [Wed, 18 Mar 2015 15:25:43 +0000 (08:25 -0700)]
Restore GDI text size rounding.

Add call to SkScalarRoundToScalar(). The old code calculated the scale
from the text size, but now the text size is calculated from the scale
(which is arguably the right way to think about it). However, the old
code always rounded the final resulting text size, while the new code
does not.

In the 'no hinting' case, the text size is already rounded to an integer
(so that the rest of the matrix is minimized). In the 'hinted' case, the
entire scale has been removed from the matrix, so the scale value is the
'real' residual size. The old code rounded this size, and the new code
should as well.

BUG=464784

Review URL: https://codereview.chromium.org/1014953002

9 years agoAdd comment describing SkColorTable constructor.
scroggo [Wed, 18 Mar 2015 15:00:27 +0000 (08:00 -0700)]
Add comment describing SkColorTable constructor.

Review URL: https://codereview.chromium.org/1011263002

9 years agoIndexed PNG decoding: Ensure color table is large enough that the bit depth of the...
dml [Wed, 18 Mar 2015 13:03:29 +0000 (06:03 -0700)]
Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end.

BUG=skia:3440
R=rmistry@google.com, scroggo@google.com

Committed: https://skia.googlesource.com/skia/+/493c1ce1cd406ef28683203146274154783452ce

Review URL: https://codereview.chromium.org/948163002

9 years agoWhitespace change to test new GCE compile bot
Ravi Mistry [Wed, 18 Mar 2015 12:50:30 +0000 (08:50 -0400)]
Whitespace change to test new GCE compile bot

9 years agoDisplay currently running tests as the keepalive message.
mtklein [Wed, 18 Mar 2015 12:27:14 +0000 (05:27 -0700)]
Display currently running tests as the keepalive message.

...
( 466MB   550) 31.9ms   gpu gm colorwheelnative
( 466MB   549) 50.1ms   gpu gm colorwheel
( 468MB   548) 512ms    gpu gm colortype_xfermodes
Currently running:
    unit test PathOpsRectsThreaded
    unit test PathOpsSimplifyDegeneratesThreaded
    unit test PathOpsSimplifyQuadralateralsThreaded
    gpu gm colortype

( 468MB   547) 90.8ms   gpu gm colortype
( 469MB   546) 2.03s    unit test PathOpsSimplifyDegeneratesThreaded
...

BUG=skia:

Review URL: https://codereview.chromium.org/1017903002

9 years agoadd kGray_8_SkColorType
reed [Wed, 18 Mar 2015 00:44:06 +0000 (17:44 -0700)]
add kGray_8_SkColorType

patch from issue 1014783003 at patchset 60001 (http://crrev.com/1014783003#ps60001)

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1010343002

9 years agoImprove tracking of bound FBOs in GrGLGpu.
bsalomon [Tue, 17 Mar 2015 22:55:42 +0000 (15:55 -0700)]
Improve tracking of bound FBOs in GrGLGpu.

Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0

Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589

Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef

Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac

Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88

Review URL: https://codereview.chromium.org/949263002

9 years agoUse sample count for temp renderbuffer when clearing stenci
Brian Salomon [Tue, 17 Mar 2015 20:03:19 +0000 (16:03 -0400)]
Use sample count for temp renderbuffer when clearing stenci

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1016903002

9 years agoDM: disable image src type on Windows.
mtklein [Tue, 17 Mar 2015 19:52:16 +0000 (12:52 -0700)]
DM: disable image src type on Windows.

BUG=skia:

Review URL: https://codereview.chromium.org/1012183002

9 years agoRevert of Improve tracking of bound FBOs in GrGLGpu. (patchset #16 id:300001 of https...
bsalomon [Tue, 17 Mar 2015 19:46:56 +0000 (12:46 -0700)]
Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #16 id:300001 of https://codereview.chromium.org/949263002/)

Reason for revert:
locally hit assert.

Original issue's description:
> Improve tracking of bound FBOs in GrGLGpu.
>
> Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0
>
> Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589
>
> Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef
>
> Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac
>
> Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88

TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1017803002

9 years agoImprove tracking of bound FBOs in GrGLGpu.
bsalomon [Tue, 17 Mar 2015 19:33:33 +0000 (12:33 -0700)]
Improve tracking of bound FBOs in GrGLGpu.

Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0

Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589

Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef

Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac

Review URL: https://codereview.chromium.org/949263002

9 years agoAdd stencil-only clear bug workaround back but for all devices.
bsalomon [Tue, 17 Mar 2015 19:06:19 +0000 (12:06 -0700)]
Add stencil-only clear bug workaround back but for all devices.

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1010253002

9 years agoCurrent RSS on linux and android too?
mtklein [Tue, 17 Mar 2015 17:24:49 +0000 (10:24 -0700)]
Current RSS on linux and android too?

BUG=skia:

Review URL: https://codereview.chromium.org/1009313003

9 years agoDoc: htmlify roles table to allow easier modification
halcanary [Tue, 17 Mar 2015 16:56:33 +0000 (09:56 -0700)]
Doc:  htmlify roles table to allow easier modification

TODO: make sure the table is up to date.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1011753004

Review URL: https://codereview.chromium.org/1011753004

9 years agoimagefilters always need to disable lcd
reed [Tue, 17 Mar 2015 15:34:38 +0000 (08:34 -0700)]
imagefilters always need to disable lcd

This prev CL accidentally stopped forcing (indirectly) the pixel-geometry to unknown. https://codereview.chromium.org/1010503002

BUG=467882

Review URL: https://codereview.chromium.org/1012113002

9 years agoRemove SkLONGLONG.
bungeman [Tue, 17 Mar 2015 14:23:39 +0000 (07:23 -0700)]
Remove SkLONGLONG.

All users now define SkLONGLONG.
This fixes a long outstanding TODO now that int64_t is required.

BUG=skia:179

Review URL: https://codereview.chromium.org/1000933003

9 years agoRevert "Indexed PNG decoding: Ensure color table is large enough that the bit depth...
scroggo [Tue, 17 Mar 2015 12:25:54 +0000 (05:25 -0700)]
Revert "Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end."

This reverts commit 493c1ce1cd406ef28683203146274154783452ce.

NOTRY=true
NOTREECHECKS=true
TBR=egdaniel@google.com,dml@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1014553003

9 years agoIndexed PNG decoding: Ensure color table is large enough that the bit depth of the...
Leon Scroggins III [Tue, 17 Mar 2015 12:14:07 +0000 (08:14 -0400)]
Indexed PNG decoding: Ensure color table is large enough that the bit depth of the image will not allow reads beyond its end.

BUG=skia:3440
R=rmistry@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/948163002

9 years agoOption for SkCodec to treat dst as all zeroes.
scroggo [Tue, 17 Mar 2015 12:02:17 +0000 (05:02 -0700)]
Option for SkCodec to treat dst as all zeroes.

This recreates SkImageDecoder's feature to skip writing zeroes for
SkCodec.

Review URL: https://codereview.chromium.org/980903002

9 years agoDisable GL_MULTISAMPLE when it's not being used
cdalton [Tue, 17 Mar 2015 00:19:58 +0000 (17:19 -0700)]
Disable GL_MULTISAMPLE when it's not being used

Updates Gr to disable GL_MULTISAMPLE when drawing to an aliased render
target. This is an important step for NV_framebuffer_mixed_samples,
where just because the color buffer isn't multisampled doesn't mean
other stages in the graphics pipeline aren't. It also removes the need
for the "isLineDraw" workaround that was in GrGLGpu::flushHWAAState.

BUG=skia:

Review URL: https://codereview.chromium.org/1002013006

9 years agowiden leak supression. looks like start_keepalive is sometimes inlined.
mtklein [Mon, 16 Mar 2015 22:06:00 +0000 (15:06 -0700)]
widen leak supression.  looks like start_keepalive is sometimes inlined.

BUG=skia:

Review URL: https://codereview.chromium.org/1008873003

9 years agoFix build for UCLIBC platforms
smcgruer [Mon, 16 Mar 2015 21:45:00 +0000 (14:45 -0700)]
Fix build for UCLIBC platforms

malloc_usable_size does not exist in UCLIBC, so fall back to just
returning 0 for SkVarAlloc::heap_size().

BUG=skia:

Review URL: https://codereview.chromium.org/1006073003

9 years agoMove GrAutoLocaleSetter to new file and fix issue with null locale
bsalomon [Mon, 16 Mar 2015 21:00:52 +0000 (14:00 -0700)]
Move GrAutoLocaleSetter to new file and fix issue with null locale

TBR=egdaniel@google.com
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1002623004

9 years agoremove dead code
reed [Mon, 16 Mar 2015 20:56:42 +0000 (13:56 -0700)]
remove dead code

BUG=skia:

Review URL: https://codereview.chromium.org/1016523002

9 years agoremove unneeded flags
reed [Mon, 16 Mar 2015 20:55:48 +0000 (13:55 -0700)]
remove unneeded flags

BUG=skia:

Review URL: https://codereview.chromium.org/1010063002

9 years agoFix up some issues introduced by https://codereview.chromium.org/1013773002/
jvanverth [Mon, 16 Mar 2015 19:58:43 +0000 (12:58 -0700)]
Fix up some issues introduced by https://codereview.chromium.org/1013773002/

Need to check for zero-length gradients when using the new correction.
Make sure we use the old text sizes for color emoji test in dftext GM.

BUG=skia:3540

Review URL: https://codereview.chromium.org/1009973004

9 years agoalways reset locale (not just in debug).
Brian Salomon [Mon, 16 Mar 2015 19:36:44 +0000 (15:36 -0400)]
always reset locale (not just in debug).

BUG=skia:

Review URL: https://codereview.chromium.org/1007283009

9 years agofix ios build wrt locale?
Brian Salomon [Mon, 16 Mar 2015 19:05:23 +0000 (15:05 -0400)]
fix ios build wrt locale?

BUG=skia:3330

Review URL: https://codereview.chromium.org/1012773004

9 years agoUse C locale for numerics when emitting shaders.
bsalomon [Mon, 16 Mar 2015 18:56:29 +0000 (11:56 -0700)]
Use C locale for numerics when emitting shaders.

BUG=skia:3330

Review URL: https://codereview.chromium.org/1012723002

9 years agoRevert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of...
msarett [Mon, 16 Mar 2015 18:55:18 +0000 (11:55 -0700)]
Revert "Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/)"

This reverts commit d18475854ce232de71c5463e0654f459d4abfd43.

Revert "Revert "Implementation of image decoding for bmp files, in accordance with the new API.""

This reverts commit dfdec78a5d02e8690998741a9fe5b71a08ca3232.

BUG=skia:

TBR=

Review URL: https://codereview.chromium.org/1016443003

9 years agoFix SDF gradient calculation for non-uniform xforms
jvanverth [Mon, 16 Mar 2015 18:32:49 +0000 (11:32 -0700)]
Fix SDF gradient calculation for non-uniform xforms

Also adds two non-uniform test cases to the dftext GM.

BUG=skia:3540

Review URL: https://codereview.chromium.org/1013773002

9 years agoRevert "Implementation of image decoding for bmp files, in accordance with the new...
msarett [Mon, 16 Mar 2015 18:07:02 +0000 (11:07 -0700)]
Revert "Implementation of image decoding for bmp files, in accordance with the new API."

This reverts commit 3675874468de7228944ce21922e6ec863f5f2310.

BUG=skia:
NOTREECHECKS=true
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/1012873002

9 years agoRevert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https...
egdaniel [Mon, 16 Mar 2015 17:50:12 +0000 (10:50 -0700)]
Revert of fix for invalid for loop syntax broke build (patchset #1 id:1 of https://codereview.chromium.org/1007373003/)

Reason for revert:
needed to revert early patch

Original issue's description:
> fix for invalid for loop syntax broke build
> NOTREECHECKS=true
> NOTRY=true
> TBR=
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/fdc310855dbf04ffb33787f5c0d76fef90b303d4

TBR=msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1015473002

9 years agoDM: allow SKPs to be smaller than 1000x1000
mtklein [Mon, 16 Mar 2015 17:38:07 +0000 (10:38 -0700)]
DM: allow SKPs to be smaller than 1000x1000

This sniffs the .skp dimensions and intersects them with our 1000x1000 viewport.

This fixes things like desk_carsvg.skp, which is only 902 pixels tall.  In 565 now,
the remaining 98 pixels draw as black, which looks funny and is confusing to triage.

No apparent affect on DM memory usage.  (We're about to map the file anyway.)

BUG=skia:

Review URL: https://codereview.chromium.org/986103002

9 years agoFilterLevel -> SkFilterQuality
reed [Mon, 16 Mar 2015 17:26:13 +0000 (10:26 -0700)]
FilterLevel -> SkFilterQuality

BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True

Review URL: https://codereview.chromium.org/1010023002

9 years agoSkPaint::FilterLevel -> SkFilterQuality
reed [Mon, 16 Mar 2015 17:08:34 +0000 (10:08 -0700)]
SkPaint::FilterLevel -> SkFilterQuality

clone (+rebase) of https://codereview.chromium.org/1009183002/

BUG=skia:
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/1014533004

9 years agoAdd __STDC_LIMIT_MACROS to SkDraw.cpp.
bungeman [Mon, 16 Mar 2015 17:00:09 +0000 (13:00 -0400)]
Add __STDC_LIMIT_MACROS to SkDraw.cpp.

9 years agoTest for glyphs which straddle the edge of device space.
bungeman [Mon, 16 Mar 2015 16:49:54 +0000 (09:49 -0700)]
Test for glyphs which straddle the edge of device space.

If a glyph ends up with a left edge near the extreme right edge of
device space, the right edge may end up at the extreme left. The
current clip tests do not test for this situation and attempt to
draw the glyphs. This results in the blitters never reaching the
right edge of the glyph and so reading from other memory.

BUG=chromium:467011

Review URL: https://codereview.chromium.org/1012763002

9 years agofix for invalid for loop syntax broke build
msarett [Mon, 16 Mar 2015 15:47:55 +0000 (08:47 -0700)]
fix for invalid for loop syntax broke build
NOTREECHECKS=true
NOTRY=true
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/1007373003

9 years agoImplementation of image decoding for bmp files, in accordance with the new API.
msarett [Mon, 16 Mar 2015 15:27:53 +0000 (08:27 -0700)]
Implementation of image decoding for bmp files, in accordance with the new API.

Currently decodes to opaque and unpremul.

Tested on local test suite.

BUG=skia:3257

Review URL: https://codereview.chromium.org/947283002

9 years agocheck for null-pixelref
reed [Mon, 16 Mar 2015 14:28:12 +0000 (07:28 -0700)]
check for null-pixelref

BUG=skia:3497

Review URL: https://codereview.chromium.org/1004313002

9 years agoremove deprecated setFilterBitmap/isFilterBitmap
reed [Mon, 16 Mar 2015 14:24:05 +0000 (07:24 -0700)]
remove deprecated setFilterBitmap/isFilterBitmap

BUG=skia:

Review URL: https://codereview.chromium.org/1006213002

9 years agoSuppress keepalive thread leak in DM.
mtklein [Mon, 16 Mar 2015 13:59:18 +0000 (06:59 -0700)]
Suppress keepalive thread leak in DM.

BUG=skia:

Review URL: https://codereview.chromium.org/1006143002

9 years agomove kTileModeCount out of TileMode enum
reed [Sun, 15 Mar 2015 21:01:21 +0000 (14:01 -0700)]
move kTileModeCount out of TileMode enum

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1009193002

9 years agoUpdate SKP version
skia.buildbots [Sun, 15 Mar 2015 08:13:36 +0000 (01:13 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1005353003

9 years agoremove legacy onCreateCompatibleDevice
reed [Sun, 15 Mar 2015 00:51:34 +0000 (17:51 -0700)]
remove legacy onCreateCompatibleDevice

needs this to land in chrome first : https://codereview.chromium.org/1013453002/

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1006183002

9 years agoRevert of Improve tracking of bound FBOs in GrGLGpu. (patchset #12 id:220001 of https...
bsalomon [Sat, 14 Mar 2015 19:08:51 +0000 (12:08 -0700)]
Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #12 id:220001 of https://codereview.chromium.org/949263002/)

Reason for revert:
That one needs to be reverted to fix black boxes with GPU
raster, and GPU bot failures.

BUG=466690

Original issue's description:
> Improve tracking of bound FBOs in GrGLGpu.
>
> Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0
>
> Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589
>
> Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef
>
> Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac

TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1011493002

9 years agoRevert of Add terrible workaround to fix stencil clear crash on S3. (patchset #1...
ccameron [Sat, 14 Mar 2015 19:06:54 +0000 (12:06 -0700)]
Revert of Add terrible workaround to fix stencil clear crash on S3. (patchset #1 id:1 of https://codereview.chromium.org/1001693003/)

Reason for revert:
Needs to be reverted in order to cleanly revert
https://codereview.chromium.org/949263002

That one needs to be reverted to fix black boxes with GPU
raster, and GPU bot failures.

BUG=466690

Original issue's description:
> Add terrible workaround to fix stencil clear crash on S3.
>
> BUG=skia:3525
>
> Committed: https://skia.googlesource.com/skia/+/084340bb9bbb538baf02a11ac36e29f0d9cdc493

TBR=joshualitt@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3525

Review URL: https://codereview.chromium.org/1005263002

9 years agoRevert[6] of Change device creation to see the (optional) layer-paint
reed [Sat, 14 Mar 2015 17:54:31 +0000 (10:54 -0700)]
Revert[6] of Change device creation to see the (optional) layer-paint

This reverts commit 173e5fe5f4be28272246e5676f5d2e5c4b1f9167.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1010503002

9 years agoSkip absurdly slow PDF tests on Valgrind bot.
mtklein [Sat, 14 Mar 2015 14:24:29 +0000 (07:24 -0700)]
Skip absurdly slow PDF tests on Valgrind bot.

Our Valgrind-with-keepalive CPU bot is still running its first run as I write
this.  It's been going ~48 hours.  'pdf gm fontmgr_iter' finished after ~19
hours.  'pdf image PANO_20121023_214540.jpg' still seems to be running.

After this, the next slowest will be '565 gm fontmgr_iter' at about 37 minutes.

TBR=borenet@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1003423002

9 years agoadd onCreateDevice to eventually replace onCreateCompatibleDevice
reed [Sat, 14 Mar 2015 11:30:21 +0000 (04:30 -0700)]
add onCreateDevice to eventually replace onCreateCompatibleDevice

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1006923004

9 years agoRevert of Revert of Revert of Revert of Revert of Change device creation to see the...
reed [Sat, 14 Mar 2015 03:05:18 +0000 (20:05 -0700)]
Revert of Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1005173004/)

Reason for revert:
arrrg. this is a staging nightmare. override required on the chrome side. must revert (again)

Original issue's description:
> Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1001423002/)
>
> Reason for revert:
> chrome now has the new virtual, so trying again
>
> Original issue's description:
> > Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/)
> >
> > Reason for revert:
> > platform_canvas tests failures
> >
> > skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2
> > Flakiness dashboard
> >
> > failures:
> > PlatformCanvas.TranslateLayer
> > PlatformCanvas.FillLayer
> >
> > Original issue's description:
> > > Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/)
> > >
> > > Reason for revert:
> > > guard in chrome has landed
> > >
> > > Original issue's description:
> > > > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/)
> > > >
> > > > Reason for revert:
> > > > need to have chrome opt-in for the older API before this can land (in chrome)
> > > >
> > > > Original issue's description:
> > > > > Change device creation to see the (optional) layer-paint
> > > > >
> > > > > Motivation:
> > > > >
> > > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.
> > > > >
> > > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.
> > > > >
> > > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0
> > > >
> > > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90
> > >
> > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > >
> > > Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477
> >
> > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://skia.googlesource.com/skia/+/8e14d660b2a434bc708a70180c84210883611683
>
> TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/307d1ed129ff75eb64137dea75df858f9e250b69

TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1005183003

9 years agoRevert of Revert of Revert of Revert of Change device creation to see the (optional...
reed [Sat, 14 Mar 2015 02:52:59 +0000 (19:52 -0700)]
Revert of Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1001423002/)

Reason for revert:
chrome now has the new virtual, so trying again

Original issue's description:
> Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/)
>
> Reason for revert:
> platform_canvas tests failures
>
> skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2
> Flakiness dashboard
>
> failures:
> PlatformCanvas.TranslateLayer
> PlatformCanvas.FillLayer
>
> Original issue's description:
> > Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/)
> >
> > Reason for revert:
> > guard in chrome has landed
> >
> > Original issue's description:
> > > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/)
> > >
> > > Reason for revert:
> > > need to have chrome opt-in for the older API before this can land (in chrome)
> > >
> > > Original issue's description:
> > > > Change device creation to see the (optional) layer-paint
> > > >
> > > > Motivation:
> > > >
> > > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.
> > > >
> > > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.
> > > >
> > > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0
> > >
> > > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > >
> > > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90
> >
> > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477
>
> TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/8e14d660b2a434bc708a70180c84210883611683

TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1005173004

9 years agoRevert of Revert of Revert of Change device creation to see the (optional) layer...
reed [Fri, 13 Mar 2015 19:34:32 +0000 (12:34 -0700)]
Revert of Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1006923002/)

Reason for revert:
platform_canvas tests failures

skia_unittests (with patch) skia_unittests (with patch) PlatformCanvas.TranslateLayer failed 2
Flakiness dashboard

failures:
PlatformCanvas.TranslateLayer
PlatformCanvas.FillLayer

Original issue's description:
> Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/)
>
> Reason for revert:
> guard in chrome has landed
>
> Original issue's description:
> > Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/)
> >
> > Reason for revert:
> > need to have chrome opt-in for the older API before this can land (in chrome)
> >
> > Original issue's description:
> > > Change device creation to see the (optional) layer-paint
> > >
> > > Motivation:
> > >
> > > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.
> > >
> > > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.
> > >
> > > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0
> >
> > TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90
>
> TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/f7076a13e2d4269903b34ef2780e1c84723e4477

TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1001423002

9 years agoCreation of GrBatchAtlas and Distancefieldpathrenderer batch
joshualitt [Fri, 13 Mar 2015 18:47:42 +0000 (11:47 -0700)]
Creation of GrBatchAtlas and Distancefieldpathrenderer batch

BUG=skia:

Review URL: https://codereview.chromium.org/975303005

9 years agoFix bug with very large round rects with large radii
robertphillips [Fri, 13 Mar 2015 16:53:01 +0000 (09:53 -0700)]
Fix bug with very large round rects with large radii

BUG=463920

Review URL: https://codereview.chromium.org/998903003

9 years agoHandle paths that do not report empty, but have no edges.
reed [Fri, 13 Mar 2015 15:48:26 +0000 (08:48 -0700)]
Handle paths that do not report empty, but have no edges.

patch from issue 999963005 at patchset 1 (http://crrev.com/999963005#ps1)

BUG=skia:3527

Review URL: https://codereview.chromium.org/1008883002

9 years agoRevert of Revert of Change device creation to see the (optional) layer-paint (patchse...
reed [Fri, 13 Mar 2015 15:46:12 +0000 (08:46 -0700)]
Revert of Revert of Change device creation to see the (optional) layer-paint (patchset #1 id:1 of https://codereview.chromium.org/1008863002/)

Reason for revert:
guard in chrome has landed

Original issue's description:
> Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/)
>
> Reason for revert:
> need to have chrome opt-in for the older API before this can land (in chrome)
>
> Original issue's description:
> > Change device creation to see the (optional) layer-paint
> >
> > Motivation:
> >
> > PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.
> >
> > This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.
> >
> > Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0
>
> TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/0e040f7da2fdfeb49aa60d24117306e3b1e6ea90

TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1006923002

9 years agoCall to retrieve SkDescriptor for SkScalarContext from SkPaint.
joshualitt [Fri, 13 Mar 2015 15:38:43 +0000 (08:38 -0700)]
Call to retrieve SkDescriptor for SkScalarContext from SkPaint.

Review URL: https://codereview.chromium.org/1005103003

9 years agoIco security issues fix
msarett [Fri, 13 Mar 2015 15:07:01 +0000 (08:07 -0700)]
Ico security issues fix

BUG=skia:3401
BUG=skia:3426
BUG=skia:3441

Review URL: https://codereview.chromium.org/996173005

9 years agoRevert of Change device creation to see the (optional) layer-paint (patchset #9 id...
reed [Fri, 13 Mar 2015 14:28:28 +0000 (07:28 -0700)]
Revert of Change device creation to see the (optional) layer-paint (patchset #9 id:160001 of https://codereview.chromium.org/988413003/)

Reason for revert:
need to have chrome opt-in for the older API before this can land (in chrome)

Original issue's description:
> Change device creation to see the (optional) layer-paint
>
> Motivation:
>
> PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.
>
> This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.
>
> Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0

TBR=halcanary@google.com,senorblanco@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1008863002

9 years agoChange device creation to see the (optional) layer-paint
reed [Fri, 13 Mar 2015 14:16:09 +0000 (07:16 -0700)]
Change device creation to see the (optional) layer-paint

Motivation:

PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.

This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.

Review URL: https://codereview.chromium.org/988413003