framework/web/wrt-installer.git
11 years agoRemoved unused "i18n-dao-ro" header
sung-su.kim [Tue, 15 Oct 2013 23:03:37 +0000 (08:03 +0900)]
Removed unused "i18n-dao-ro" header

[Issue#]     N/A
[Problem]    Still remains unused header
[Cause]      N/A
[Solution]   Unused "i18n-dao-ro" header removed
[Verification] Build wrt-insatller repo
[SCMRequest] N/A

Change-Id: Ifc1be6d510287adf6c2f84daf3acaeaaf4f5020a

11 years agoFix installation of widgets with defaultlocale
Zbigniew Kostrzewa [Tue, 8 Oct 2013 10:01:16 +0000 (12:01 +0200)]
Fix installation of widgets with defaultlocale

[Issue#]   WGL-560, WGL-563
[Problem]  Installation of test widgets (with defaultlocale attribute in
configuration file) fails
[Cause] Installer application does not have access to WRT I18N DB and
backendlib does not attach to WRT I18N DB
[Solution] Restore LanguageSubtagRstTreeSingleton used for checking
language tag validity

[Verification]
1. Build repository
2. Run test widgets from WGL-560
(https://bugs.tizendev.org/jira/browse/WGL-560)

[SCMRequest] Depends on: https://review.tizendev.org/gerrit/92271

Change-Id: I3c8d97e62c5f292b00b71874fe73a56aaedbea44

11 years ago[Release] wrt-installer_0.1.138
sung-su.kim [Tue, 15 Oct 2013 00:40:17 +0000 (09:40 +0900)]
[Release] wrt-installer_0.1.138

Change-Id: I54bf804769fd0b377f9fc8d72ed1d748050a00a9

11 years agoInitialize exception value for decide success.
sung-su.kim [Mon, 14 Oct 2013 07:47:38 +0000 (16:47 +0900)]
Initialize exception value for decide success.

[Issue#]   N_SE-55213
[Problem]  Sometimes uninstall fail pop up is shown even uninstall is success.
[Cause]    For determining success the exception value was not initialized.
[Solution] Initialize to exception value for decide success.
           In current wrt-installer structure, installer verify this exception value
           at the end of uninstallation. If uninstallation fail, the value is changed
           to error code. If not, this value was initial value.
[Verification] N/A (Not always issue and logical issue)
[SCMRequest] N/A

Change-Id: I8a4bb3bdec871b291fc8d5cd6911bf19720798f5

11 years agoReplace "dpl/unused.h" to "dpl/availability.h"
Jihoon Chung [Mon, 14 Oct 2013 01:41:04 +0000 (10:41 +0900)]
Replace "dpl/unused.h" to "dpl/availability.h"

[Issue#]     LINUXWRT-1015
[Problem]    To create common header for various macro, "dpl/availability.h" is added.
             Old macro usage case should replace to use new header.
[Cause]      N/A
[Solution]   DPL_UNUSED and DPL_UNUSED_PARAM macro move to "dpl/availability.h"
[Verification] Build package.
[SCMRequest] N/A

Change-Id: I7b9e7cba103189517c70c29da0f012c2ff21d65b

11 years ago[Release] wrt-installer_0.1.137
sung-su.kim [Fri, 11 Oct 2013 01:40:15 +0000 (10:40 +0900)]
[Release] wrt-installer_0.1.137

Change-Id: I2d5c05aa61200e7a8aec198c56357da8350bd0c4

11 years agoMerge "Change account icon path from resource directory to shared directory"
HOSEON LEE [Fri, 11 Oct 2013 01:22:55 +0000 (01:22 +0000)]
Merge "Change account icon path from resource directory to shared directory"

11 years agoChange account icon path from resource directory to shared directory
sung-su.kim [Thu, 10 Oct 2013 07:36:02 +0000 (16:36 +0900)]
Change account icon path from resource directory to shared directory

[Issue#]   N_SE-54764
[Problem]  "Account" application cannot show icon.
[Cause]    SMACK access is denied when "Account" application process touch
           account icon which is in other application resource directory.
[Solution] Copy account icon to application shared directory.
             - Resource directory : [package]/res/wgt/
             - Shared directory : [package]/shared/res/
           Shared directory is assigned "*" label.
           Changed account icon path in manifest file.

Change-Id: I08f0dfbc42b3754780996d80a9bed8980743dc6c

11 years ago[Release] wrt-installer_0.1.136
sung-su.kim [Wed, 9 Oct 2013 23:30:51 +0000 (08:30 +0900)]
[Release] wrt-installer_0.1.136

Change-Id: Id07a679780396d0078ce8868b8b88765aeb2187c

11 years agoBuild Fix
Adam Banasiak [Wed, 9 Oct 2013 09:05:23 +0000 (11:05 +0200)]
Build Fix

[Issue#]   N/A
[Problem]  Build break.
[Cause]    Missing ; at the end.
[Solution] Fixed

Change-Id: Ibcdb80d224e1235c012d7af35a64c641c67fd603

11 years agoSet default launguage for display name of account
Soyoung Kim [Tue, 8 Oct 2013 12:04:56 +0000 (21:04 +0900)]
Set default launguage for display name of account

[Issue#]   N_SE-54261
[Problem]  The default language in account menu is not showing in Settings.
[Cause]    The default language is not specified in the manifest file.
[Solution] - If there is "en-gb" in display name of account, installer set
             "en-gb" as default language.
           - If there is not "en-gb" in display name, installer set the first
             value from display name as defalt language.

[Verification] Install the attached widget.
https://bugs.tizendev.org/jira/secure/attachment/164604/Emptyui.zip

[SCMRequest] N/A

Change-Id: I438ec0cd6fb16da9fd182138853bbeef63ccbd30

11 years agoFix Prevent issue
Zbigniew Kostrzewa [Mon, 7 Oct 2013 08:41:53 +0000 (10:41 +0200)]
Fix Prevent issue

[Issue#]   CID: 30986
[Problem]  Unchecked return value
[Cause]    Returned value from a function is not checked
[Solution] Check return value

[Verification] Build repository

Change-Id: I512a0848ea5325bf1a7a8d6aa487346f486e19ee

11 years ago[Release] wrt-installer_0.1.135
sung-su.kim [Tue, 8 Oct 2013 06:17:28 +0000 (15:17 +0900)]
[Release] wrt-installer_0.1.135

Change-Id: Ia34363906d6382a09f604243d872dd2ac7f258af

11 years agoModify uninstall steps in case app is installed on an external memory
sung-su.kim [Mon, 7 Oct 2013 09:21:23 +0000 (18:21 +0900)]
Modify uninstall steps in case app is installed on an external memory

[Issue#]   N_SE-53790
[Problem]  Re-install fails after uninstall app which was installed on external memory.
[Cause]    When uninstalling an app on external memory, unexpected error occurred.
            : SD card isn't inserted or unmounted
           In this case, wrt-installer skips to remove directory in internal memory.
           The remaining internal directory caused "application already existed" error.
[Solution] Change uninstall work-flow.
           Before : Remove the information to only an external memory (e.g., SD card).
           After  : Remove the information on both internal and external memory.

Change-Id: If7a4fe063b80ecdb6a6f5b60f2d95bd48e9cb284

11 years agoClean up pkgmgr_installer API usage
Tomasz Iwanek [Thu, 3 Oct 2013 15:54:36 +0000 (17:54 +0200)]
Clean up pkgmgr_installer API usage

[Issue#]   LINUXWRT-894
[Problem]  Pkgmgr refactoring
[Cause]    N/A
[Solution] Refactoring - minor fixes:
           - hiding sending signals -> adding extra methods
           - hiding pkgmgr_installer types in pkgmgr_signal.h header

[Verification] Build repository. Review that logic is the same.

Change-Id: Iac7a229628af072974500724f38fc7efd95eb6e1

11 years agoTaskConfiguration refactoring - part 3/3
Tomasz Iwanek [Thu, 5 Sep 2013 08:02:31 +0000 (10:02 +0200)]
TaskConfiguration refactoring - part 3/3

[Issue#]   LINUXWRT-820
[Problem]  Refatoring - CheckAppRunningStateStep for TaskConfiguration
[Cause]    N/A
[Solution] Refactoring.

[Verification] Install successfully any app. Try update app when it's running.
               App should be killed before installation start.

Change-Id: Ie15cbbb6736be9b7ae30e8547ee8f7b5b3abb85c

11 years agoAdded new target file extension of encryption, ".htm", with consideration of capital...
Tae-Jeong Lee [Mon, 7 Oct 2013 04:38:32 +0000 (13:38 +0900)]
Added new target file extension of encryption, ".htm", with consideration of capital letters.

[Issue#]   LINUXWRT-983
[Problem]  Some html files included in encryption widget are not encrypted after installation.
[Cause]    wrt-installer decides target files of encryption by refering to each filename extension.
           However, ".htm" was omitted in target list.
[Solution] Added new extension define, ".htm", for encryption.
           Additionally, consideration of capital letter was also added.

Change-Id: If6efdf3f54ead6085631bdd37fec1e23ae10b7ee

11 years agoRemove unused code
Tomasz Iwanek [Fri, 4 Oct 2013 14:37:42 +0000 (16:37 +0200)]
Remove unused code

[Issue#]   LINUXWRT-995
[Problem]  Unused code
[Cause]    N/A
[Solution] Remove it.

[Verification] Build repository.

Change-Id: Icfdf81acbfce565c87f429af93da323be70b86b8

11 years ago[Release] wrt-installer_0.1.134
Jihoon Chung [Sat, 5 Oct 2013 08:31:12 +0000 (17:31 +0900)]
[Release] wrt-installer_0.1.134

Change-Id: Ib83f6fb6f08ccaa4af05b4e694c8583012fa90db

11 years agoThe order of ui-application element in manifest.xml is changed
Hoseon LEE [Sat, 5 Oct 2013 06:38:46 +0000 (15:38 +0900)]
The order of ui-application element in manifest.xml is changed

[Issue#] P131004-00766
[Problem] The dbox execution file is selected to the main UI application by package manager
[Cause] The order of ui-application element is wrong.
        The dbox execution file is first. And the main web application execution is second.
        The first is set to main ui-application by package manager.
[Solution] The order of ui-application element in manifest.xml is changed.
           But this is the temporary solution.
           The final solution is that the 'mainapp=true' is set in to the main ui-application element.
           Therefore, this commit must be updated with the final solution.

Change-Id: I34445ce0571453cc9c554efb2cabc8d245117cdf

11 years ago[Release] wrt-installer_0.1.133
Jihoon Chung [Sat, 5 Oct 2013 03:37:19 +0000 (12:37 +0900)]
[Release] wrt-installer_0.1.133

Change-Id: Ifc290c42a712ae926094206e1e41ccaa961bcee1

11 years agoFixed build break
Jihoon Chung [Sat, 5 Oct 2013 03:27:28 +0000 (12:27 +0900)]
Fixed build break

[Issue#]     N/A
[Problem]    Build break is occurred
[Cause]      N/A
[Solution]   Fixed build break
[SCMRequest] N/A

Change-Id: I04674d6c240ad37dc4c2b1479137e7b9e7bda2c6

11 years agoMerge "[Release] wrt-installer_0.1.132"
HOSEON LEE [Fri, 4 Oct 2013 12:37:10 +0000 (12:37 +0000)]
Merge "[Release] wrt-installer_0.1.132"

11 years agoInstaller check setting value, if install-location is auto.
Soyoung Kim [Mon, 23 Sep 2013 11:30:32 +0000 (20:30 +0900)]
Installer check setting value, if install-location is auto.

[Issue#]   P130919-00555
[Problem]  WebApp install to internal storage
           even if installation storage set to external on setting menu.
[Cause]    Installer doesn't check setting value about installation storage.
[Solution] Installer will check setting value about install-location.
[Description]
           Two values to determine the location of the installation
           1. install location element value in config.xml, internal-only|auto|preper-external
           2. install location setting menu in target, internal|SD card
           Installed on SD card conditions
           1. config type sets preper_external & inserted MMC
           2. config type sets auto & target type sets SD card
           3. config type sets auto & target type sets internal & out of internal memory

Change-Id: I7dfb193a72e3e765b9d908574246f2212a5e6c4e

11 years ago[Release] wrt-installer_0.1.132
sung-su.kim [Fri, 4 Oct 2013 04:36:10 +0000 (13:36 +0900)]
[Release] wrt-installer_0.1.132

Change-Id: I95eea0203dc5a90f352665740072ce24ea3b2b5a

11 years ago2nd config.xml parsing removal
Tomasz Iwanek [Wed, 4 Sep 2013 12:14:00 +0000 (14:14 +0200)]
2nd config.xml parsing removal

[Issue#]   LINUXWRT-820
[Problem]  Config.xml parsed twice
[Cause]    N/A
[Solution] TaskProcessConfig fixture.

[Verification] Install, update. uninstall widgets attached in:
               http://cam.sprc.samsung.pl/browse/LINUXWRT-820

Change-Id: I3a3923b4bbd6d81feeecd1e4ac1f21f93e3f26df

11 years ago[Release] wrt-installer_0.1.131
sung-su.kim [Wed, 2 Oct 2013 00:04:18 +0000 (09:04 +0900)]
[Release] wrt-installer_0.1.131

Change-Id: Ief3f88c01b94a0878a99694479e4633fe1d2472f

11 years agoId in <tizen:app-widget> element should begin with <TIZEN_APPLICATION_ID>
Karol Pawlowski [Tue, 1 Oct 2013 12:21:01 +0000 (14:21 +0200)]
Id in <tizen:app-widget> element should begin with <TIZEN_APPLICATION_ID>

[Issue#]   WGL-573
[Problem]  Valid Id of <tizen:app-widget> element should be in format of
           <TIZEN_APPLICATION_ID>.<STRING>
[Cause]    Missing proper routine to check this condition.
[Solution] Add routine to check app-widget id.

[Verification]
    * Install widget attached to issue, which should fail:
      https://bugs.tizendev.org/jira/browse/WGL-573
    * Install correct widget, which should pass:
      https://bugs.tizendev.org/jira/browse/WGL-574

Change-Id: I07c408f192aab083cd0513e73bc35ffab7ed870d

11 years agoTaskConfiguration refactoring - part 2/3
Tomasz Iwanek [Tue, 3 Sep 2013 12:05:07 +0000 (14:05 +0200)]
TaskConfiguration refactoring - part 2/3

[Issue#]       LINUXWRT-820
[Problem]      Refactoring
[Cause]        Code needs clean up
[Solution]     This change is solving:
 - "Stepifying" TaskConfiguration (identification of sub-problems of this task)

This change makes clean up/reordering in TaskConfiguration,
(now called) TaskProcessWidget is just to be fixed.

[Verification] Walk through following procedure:
1. Testing SetupTempDirStep & DetectUpdateInstallationStep
   (run app after each installation, uninstall successfully app if not needed):
 1.1. Install any new widget for first time
 1.2. Update widget several times
 1.3. Test installtion from browser installation:
       wrt-installer -i /opt/share/widget/tests/widgetstest/config.xml (wrt-extra)
 1.4. hybrid app -> test new installation
       (hybrid app can be found in "HybridApplication/res" directory
        in TCT behavioural tests; change extension to .wgt)
 1.5. hybrid app -> test update installation (run it again)
2. Testing ResourceEncryptionStep:
 2.1 Check points 1.1 and 1.2 for encrypted widget.
3. (optional if possible) Testing InstallationFSLocationSte:
 3.1 Check installation on external card
      (sets setting in widget config: install-location="prefer-external")
      (make sure it's really installed on card)
4. Testing CheckRDSSupportStep:
 4.1 Install widget without encryption using SDk and update it (reinstall).
     SDK should run RDS deployment (check console for succesfull installation messages)
 4.2 Install widget encryption using SDK and update it (reinstall).
     SDK should run normal installation.
     SDK may try to install it with RDS. wrt-installer should prompt then about error (RDS not supported).
     SDK shoudl recognized message and run normal installation automatically if RDS fails.
5. Testing pkgmgr interaction (pkgmgr should display proper type of instalaltion, notifications and icons):
 5.1. Run new isntallation through Installer app on phone (access .wgt from myfiles)
 5.2. Run update installation through Installer app on phone (access .wgt from myfiles)
 5.3. Run new isntallation through Installer app on phone (access .wgt from myfiles) of hybrid app
 5.4. Run update installation through Installer app on phone (access .wgt from myfiles) of hybrid app

---

Update may be tested (1.2.):
 wrt-installer-tests-general --output=text --regexp="Update"
Hosted app may be tested (1.3.):
 wrt-extra-tests-widgets --output=text --regexp="hosted_app_simple_install"
Encrypted widget is located:
 /opt/share/widget/tests/misc/widgets/encrypted.wgt (wrt-extra).

---

This change is also fixing hosted app installation as it was broken.

---

Change-Id: Idd1bfba88d3c8569fcbbc80eda1462cf7dfc9f16

11 years agoAdd i18n database attach and detach code
sung-su.kim [Tue, 1 Oct 2013 12:11:43 +0000 (21:11 +0900)]
Add i18n database attach and detach code

[Issue#]   N/A
[Problem]  Installation fail to TCT.
[Cause]    Fail to database access for IANA locale check.
[Solution] Add i18n database attach and detach code.

[SCMRequest] N/A

Change-Id: I83648a1438e700ff63bba32cde34a8bb28b19d60

11 years agoChanged header inclusion format
sung-su.kim [Tue, 1 Oct 2013 11:58:41 +0000 (20:58 +0900)]
Changed header inclusion format

[Issue#]   N/A
[Problem]  Was used " " when header include
[Cause]    Violation coding rule
[Solution] Changed header include from " " to < >

[SCMRequest] N/A

Change-Id: Ibb069856c87bd9b654b776014248e0c6fc116960

11 years agoFixed account icon path to manifest file
Soyoung Kim [Fri, 27 Sep 2013 06:44:30 +0000 (15:44 +0900)]
Fixed account icon path to manifest file

[Issue#]   N/A
[Problem]  Can't loaded account icon.
[Cause]    Account icon path is wrong to manifest file.
[Solution] Changed account icon path from relative path to absolute path.

[Remarks]
- config.xml path: <tizen:icon section="Account">icon.png</tizen:icon>
- old manifest: <icon section="account">icon.png</icon>
- new manifest: <icon section="account">/opt/usr/apps/[package]/res/wgt/icon.png</icon>

Change-Id: I75a531e1da1f737fbe474adc0cdedfc89cf30284

11 years agoFixed installer couldn't add account to manifest file
Soyoung Kim [Fri, 27 Sep 2013 06:44:30 +0000 (15:44 +0900)]
Fixed installer couldn't add account to manifest file

[Issue#]   N_SE-53213
[Problem]  Can't add account to manifest file
           even if account information is in config.xml.
[Cause]    Wrt-installer did not create the account information
           to manifest file when parsing config.xml.
[Solution] Fixed parsing context to create the account information.

[SCMRequest] N/A

Change-Id: I51f2b3b7f1d6ff5a0593714c15e20cc64e09cdd9

11 years ago[Release] wrt-installer_0.1.130
sung-su.kim [Mon, 30 Sep 2013 04:23:50 +0000 (13:23 +0900)]
[Release] wrt-installer_0.1.130

Change-Id: Ibf89e0c6b88f39ad5b177670815cfc856e9b3a69

11 years agoFix bug on checking error conditions when calling dlsym()
Soo-Hyun Choi [Wed, 25 Sep 2013 16:20:31 +0000 (01:20 +0900)]
Fix bug on checking error conditions when calling dlsym()

[Issue#]   N/A
[Problem]  A bug on checking error conditions when calling dlsym()
[Cause]    Missed to call dlerror() to clear any old error conditions.
[Solution] Added dlerror() before calling dlsym().
           Also, separated error conditions:
           one for dlsym related error and another for DRM API related error.

[Remarks] DLOPEN(3)
    The function dlsym() takes a "handle" of a dynamic library returned by
    dlopen() and the null-terminated symbol name, returning the address where
    that  symbol is loaded into memory.  If the symbol is not found, in the
    specified library or any of the libraries that were automatically loaded
    by dlopen() when that library was loaded, dlsym() returns NULL.  (The
    search performed by dlsym() is breadth first through the  dependency  tree
    of  these libraries.)  Since the value of the symbol could actually be
    NULL (so that a NULL return from dlsym() need not indicate an error), the
    correct way to test for an error is to call dlerror() to clear any old
    error conditions, then call dlsym(), and then call dlerror() again,  sav‐
    ing its return value into a variable, and check whether this saved value
    is not NULL.

Change-Id: Idee1834fbdcfee184d07f757c871994e9832d7d4

11 years agoError thrown when the same appControl element is present more than once in config.xml
Tomasz Iwanek [Thu, 26 Sep 2013 15:35:58 +0000 (17:35 +0200)]
Error thrown when the same appControl element is present more than once in config.xml

[Issue#]   N_SE-53206
[Problem]  Instalaltion should fail in a proper way if the same elements of
           appControl are specified twice.
[Cause]    N/A
[Solution] Check for appControl similarity..

[Verification]
    * Try to reproduce steps described in the issue tracker.
    * Issue should not be reproduced.

Change-Id: I86e0e7754657a112e373c408a677293811c164ee

11 years ago<tizen:box-icon /> element's occurrence should be 0 or 1
Tomasz Iwanek [Thu, 26 Sep 2013 14:41:00 +0000 (16:41 +0200)]
<tizen:box-icon /> element's occurrence should be 0 or 1

[Issue#]   WGL-572
[Problem]  Valid <tizen:box-icon /> element should occur as 0 or 1 time.
[Cause]    Missing proper routine to check this condition.
[Solution] Add routine to check the previous occurrence.

[Verification]
    * Install widget attached to issue: https://bugs.tizendev.org/jira/browse/WGL-572
    * Installation should fail at parsing config.xml.

Change-Id: I9fccb31f77974cfe379d697622d57b4766d49398

11 years agoFix a common mistake about errno(3) usage
Soo-Hyun Choi [Thu, 26 Sep 2013 05:52:30 +0000 (14:52 +0900)]
Fix a common mistake about errno(3) usage

[Issue#]   N/A
[Problem]  errno may have been changed by other system call.
[Cause]    errno should be preserved.
[Solution] Save errno to a local variable

[Remarks] ERRNO(3)

A common mistake is to do

    if (somecall() == -1) {
        printf("somecall() failed\n");
        if (errno == ...) { ... }
    }

where  errno  no  longer  needs  to have the value it had upon return from somecall()
(i.e., it may have been changed by the printf(3)).
If the value of errno should be preserved across a library call, it must be saved:

if (somecall() == -1) {
    int errsv = errno;
    printf("somecall() failed\n");
    if (errsv == ...) { ... }
}

Change-Id: Ib407b8a7b1cd13d37c3f182c4c28f059bb1749ea

11 years ago[Release] wrt-installer_0.1.129
sung-su.kim [Fri, 27 Sep 2013 02:41:33 +0000 (11:41 +0900)]
[Release] wrt-installer_0.1.129

Change-Id: I3a520cb9059492dd860e22769d5348a36b53e8ae

11 years agoMerge "[Release] wrt-installer_0.1.128"
HOSEON LEE [Thu, 26 Sep 2013 04:41:13 +0000 (04:41 +0000)]
Merge "[Release] wrt-installer_0.1.128"

11 years agoCreate symbolic link to /usr/bin/WebProcess for app with dynamic box
Yunchan Cho [Mon, 26 Aug 2013 09:04:58 +0000 (18:04 +0900)]
Create symbolic link to /usr/bin/WebProcess for app with dynamic box

- Tizen application is registered to app_info DB on installation time, hence
  this change needs to be done in wrt-installer

[Issue]    N/A
[Problem]  wrt-plugins (or external root daemon) cannot retrieve appid properly
           based on the pid of Box WebProcess.
[Cause]    app_manager API which gets appid from pid considers only
           registered executable path on app_info DB.
           (app_manager gets executable path from /proc/<pid>/cmdline
             matched to pid of WebProcess)
[Solution] WebProcess associated with the box needs to be registered to
           app_info DB on installation time.
           1. Register symbolic link (/usr/bin/WebProcess) per box
           2. Register the box's new appid to app_info DB on installation time

Change-Id: Ic6b59de89d6428b83f705da51c791806ac94e3ce

11 years agoRevert "Register a new appid for dynamic box and its symbolic link to /usr/bin/WebPro...
Soo-Hyun Choi [Wed, 25 Sep 2013 14:45:02 +0000 (23:45 +0900)]
Revert "Register a new appid for dynamic box and its symbolic link to /usr/bin/WebProcess"

This reverts commit 03dd9db6f0df82df0df091321467fceedd22199f.

Conflicts:
src/jobs/widget_install/task_manifest_file.cpp

[Remarks]
    * If setting root_path of app manifest is enabled, a web api plugin
      using dummy root_path doesn' work well.
    * Even if wrt-installer has not set 'root_path', the web api plugin
      have been using 'root_path',
      hoping prefix of the path is /opt/usr/apps
    * In the case of preload app that has /usr/apps base path, the web api
      doesn't work well.
    * Therefore, emove code regarding root_path of app manifest,
      because there are other way to find root path of web apps.

Change-Id: Ia365aec499a5973d874114481f6be1b9b94ede93

11 years ago[Release] wrt-installer_0.1.128
sung-su.kim [Wed, 25 Sep 2013 23:58:51 +0000 (08:58 +0900)]
[Release] wrt-installer_0.1.128

Change-Id: I37ebf05d50bec5e6eda9ed643f80b89708d1d4d5

11 years agoFix Prevent issue
Tomasz Iwanek [Wed, 25 Sep 2013 07:32:19 +0000 (09:32 +0200)]
Fix Prevent issue

[Issue#]   CID: 30993, 30994, LINUXWRT-906
[Bug]      Prevent issues.
[Cause]    Dereference of null pointer
[Solution] Small fixes

[Verification] Build repository.

Change-Id: I50a21a13f31593330ca5893ff5412ed392773599

11 years agoFix build warning
Soo-Hyun Choi [Thu, 19 Sep 2013 06:22:07 +0000 (15:22 +0900)]
Fix build warning

* warning: deprecated conversion from string constant to 'char*'

[Issue#]   N/A
[Problme]  Build warning
[Cause]    deprecated conversion from string constant to 'char*'
[Solution] cast to char pointer

Change-Id: I70e7289fdde412fa1d6bc786e10dec0ed38fbcbc

11 years agoMerge "TaskConfiguration refactoring - part 1/3"
Zbigniew Kostrzewa [Mon, 23 Sep 2013 08:11:10 +0000 (08:11 +0000)]
Merge "TaskConfiguration refactoring - part 1/3"

11 years agoUse local variable 'pkgId' instead of member variable 'm_pkgId'
Soo-Hyun Choi [Thu, 19 Sep 2013 05:52:47 +0000 (14:52 +0900)]
Use local variable 'pkgId' instead of member variable 'm_pkgId'

[Issue#]   N/A
[Problem]  'm_pkgId' is given as a parameter, pkgId, of setLabelForSharedDir(),
           but it still uses 'm_pkgId' inside of setLabelForSharedDir() function.
[Cause]    Declared a local variable which was not used correctly.
[Solution] Changed 'm_pkgId' to 'pkgId'.

Change-Id: If361b7481b49ab23b69ea947d01293f93105b0e3

11 years agoTaskConfiguration refactoring - part 1/3
Tomasz Iwanek [Tue, 3 Sep 2013 12:05:07 +0000 (14:05 +0200)]
TaskConfiguration refactoring - part 1/3

[Issue#]       LINUXWRT-820
[Feature]      Refactoring
[Cause]        Useless code in form of rethroing expections in failure task.
[Solution]     This change is solving:
 - JobWidgetInstall context clean up
 - removal of ConfigureResult type from TaskConfiguration (it was addded due to eceptions out of task scope)
 - removal task_installer_failure - this was step just to throw exceptions (exception have no need to be rethrown now)

This change makes clean up/reordering in TaskConfiguration, (now called) TaskProcessWidget is just to be fixed.

[Verification] Test installation for widget:
1. Widget with invalid config.xml -> see installation fail, notification from pkmgr if installed from myfiles.
2. Widget with malformed zip file -> see installation fail, notification from pkmgr if installed from myfiles.
3. Correct instalaltion and update of widget (widget have to has version for update if using same widget).

Change-Id: I035fb917004ffdb1a2fad0e201dc1f43a1c9a8f3

11 years ago[Release] wrt-installer_0.1.127
sung-su.kim [Mon, 23 Sep 2013 01:08:05 +0000 (10:08 +0900)]
[Release] wrt-installer_0.1.127

Change-Id: Id53f8f4b583dd6664dcb84827cf905fd83a9cab1

11 years agoRemove print guid log
sung-su.kim [Tue, 17 Sep 2013 10:23:09 +0000 (19:23 +0900)]
Remove print guid log

[Issue#]   N/A
[Problem]  Not exist guid value.
[Cause]    Try to print guid before set guid.
[Solution] Remove print guid log.
   Because configuration task run before get guid value from config file.
[SCMRequest] N/A

Change-Id: Ic0e88a1fd3564b16756a78c75d9cd7ce7e947554

11 years agoFix Prevent issue
Tomasz Iwanek [Fri, 20 Sep 2013 10:59:14 +0000 (12:59 +0200)]
Fix Prevent issue

- Incorrect usage of TEMP_FAILURE_RETRY

[Issue#]   CID: 22993, 22996, LINUXWRT-906
[Problem]  closedir() repeated if EINTR occurrs
[Cause]    Same as Prevent CID: 22995
           https://review.tizendev.org/gerrit/#/c/83449/

  * For POSIX closedir() specifies two possible errno values: EBADF, EINTR
    (see closedir(3p)).
  * For Linux, on the other hand, only one errno value is specified: EBADF
    (see closedir(3)).
  * In fact, closedir() implementation in GNU C Library may set other errno
    values as well, e.g. EINVAL if value NULL is passed to the function
    (verified for glibc 2.15, source file sysdeps/unix/closedir.c).

  * Assuming that closedir() is just a wrapper around a call to close()
    system call and having in mind that it was decided (and confirmed by
    Linus Torvalds) that repeating close() even for EINTR is unsafe which I have
    decided to not repeat closedir() in such case as well.

  * What's more, implementation of closedir() in GNU C Library calls free()
    on the stream handle, so repeating closedir() may lead to memory
    corruption (as reported by Prevent).

[Solution] Do not repeat closedir() on error (even EINTR).

[SCMRequest] N/A
[Verification] Build repository.

Change-Id: I857861d1f10954d4c199bf8d54fc5ea13cb00d44

11 years agoFix build warning
Soo-Hyun Choi [Thu, 19 Sep 2013 06:35:47 +0000 (15:35 +0900)]
Fix build warning

* warning: 'Logic::InstallerLogic::m_NextHandle' will be initialized after
  warning:   'Jobs::Job* Logic::InstallerLogic::m_job'

[Issue#]   N/A
[Problem]  Build warning
[Cause]    Disordering when initializes member variables
[Solution] Fixed initialization order

Change-Id: I0d853e23d433b73ba194c6f1ad75b421477172a7

11 years agoFix buildbreak for wrt-installer testsuite
Tomasz Iwanek [Tue, 17 Sep 2013 09:05:49 +0000 (11:05 +0200)]
Fix buildbreak for wrt-installer testsuite

[Issue#]       N/A
[Bug]          Buildbreak introduced
[Cause]        N/A
[Solution]     N/A
[Verification] Build with option: --define "WITH_TESTS ON"

Change-Id: If22057b9b52793f28352a8940689e7749a509adc

11 years agoReformatting wrt-installer debug logs
sung-su.kim [Tue, 17 Sep 2013 01:20:46 +0000 (10:20 +0900)]
Reformatting wrt-installer debug logs

[Issue#]   N/A
[Problem]  N/A
[Cause]    Change wrt-installer log form C++ style to C style.
[Solution] Change wrt-installer log from C++ style to C style.
           Remove <dlog.h> & <dpl/log/log> header
[SCMRequest] N/A

Change-Id: I491114e21406e37ab0ce3581618c9f0967455835

11 years agoFix installation of widgets with multiple default icons
Zbigniew Kostrzewa [Fri, 13 Sep 2013 13:00:33 +0000 (15:00 +0200)]
Fix installation of widgets with multiple default icons

[Issue#]   WGL-540
[Problem]  The default Tizen icon is displayed on menu tray
           instead of the one provided with web application.
[Cause]    When more than one default icons are provided with web application
           (e.g. icon.jpg and icon.png) then one of them is installed in the file
           system (icon.png) but the other one is set in manifest file (icon.jpg).
           As a result, web application's icon cannot be found and tizen default
           icon is displayed instead.
[Solution] Make sure that the same icon is installed in the file system
           as is set in manifest file (with respect to the default icon search
           order specified by W3C P&C spec).

[Verification]
  1. Build repository
  2. Install web application attached to WGL-540
     (icon.png should be used as the web application's icon)
  3. Install any web application with a single default icon provided
     inside the web application's package.
  4. Install any web application with an icon specified in the web
     application's configuration file.
  5. Install any web application with an icon specified in the web
     application's configuration file and a default icon available in the
     web application's package (icon explicitly specified in the web
     application's configuration file should be used).

Change-Id: Ia3b05a1c6d926ab8fb9bc70766340d07f469ac8f

11 years agoFix Prevent issue
Zbigniew Kostrzewa [Mon, 16 Sep 2013 06:23:13 +0000 (08:23 +0200)]
Fix Prevent issue

[Issue#]   CID: 31536
[Problem]  Unreachable code
[Cause]    Condition that is never true
[Solution] Remove dead code

[Verification] Build repository

Change-Id: Idd0e37f350b47d9355575bfa93ebcc2ee2209f4b

11 years agoRevert "Reformatting wrt-installer debug logs"
HOSEON LEE [Mon, 16 Sep 2013 03:05:56 +0000 (03:05 +0000)]
Revert "Reformatting wrt-installer debug logs"

This reverts commit 7facd01b36d15dceca3819baa339163d2a24f679.

Change-Id: I74b9c82da92d047d669fc1c1afb474ca40e5bfb8

11 years ago[Release] wrt-installer_0.1.126
sung-su.kim [Sun, 15 Sep 2013 23:42:44 +0000 (08:42 +0900)]
[Release] wrt-installer_0.1.126

Change-Id: I4bccc49e228395e0fcba783ec3bc6ea69abe6d9a

11 years agoFixed build break after Change-Id: I3277d5796e029b382719df03381078af910ebdda
sung-su.kim [Sun, 15 Sep 2013 10:58:43 +0000 (19:58 +0900)]
Fixed build break after Change-Id: I3277d5796e029b382719df03381078af910ebdda

[Issue#]   N/A
[Problem]  Build break after Change-Id: I3277d5796e029b382719df03381078af910ebdda
[Cause]    The order of header file inclusion matters.
[Solution] Re-ordered header file inclusions.

Change-Id: Ieb4ba8b3b83e7cd6b2414defbf7e146db1cc5d2c

11 years agoReformatting wrt-installer debug logs
sung-su.kim [Sun, 15 Sep 2013 09:51:59 +0000 (18:51 +0900)]
Reformatting wrt-installer debug logs

[Issue#]   N/A
[Problem]  N/A
[Cause]    Change wrt-installer log form C++ style to C style.
[Solution] Change wrt-installer log from C++ style to C style.
           Remove <dlog.h> & <dpl/log/log> header
[SCMRequest] N/A

Change-Id: Ib1e7db709e43db399b83eafa6af337efaadf1a84

11 years agoAdd functions to represent package directories
Adam Banasiak [Tue, 10 Sep 2013 15:46:22 +0000 (17:46 +0200)]
Add functions to represent package directories

[Issue#]   LINUXWRT-358
[Problem]  Function wasn't invoked due to objective programming standards
[Cause]    N/A
[Solution] Add two new functions in src/misc/widget_location.cpp:
            - getUsrSharePackagesDir
            - getOptSharePackagesDir

Change-Id: Ia38d2982443274ec300e376f5b8c94457e417b9a

11 years agoAdd typedef for the long class types
Adam Banasiak [Tue, 10 Sep 2013 15:40:05 +0000 (17:40 +0200)]
Add typedef for the long class types

[Issue#]   LINUXWRT-358
[Problem]  Long type names are hard to read
[Cause]    N/A
[Solution] Created typedefs for the followings:
            - InstallerBase
            - WidgetInstallationBase
            - WidgetUnistallStructBase
            - UninstallContextBase

Change-Id: I8aff13bca4fbf83ccf72962c149845e0277f90ae

11 years agoAdd forward declarations
Adam Banasiak [Tue, 10 Sep 2013 15:22:55 +0000 (17:22 +0200)]
Add forward declarations

[Issue#]   LINUXWRT-358
[Problem]  Forward declarations needed
[Cause]    N/A
[Solution] Added forward declariations in
            - src/jobs/plugin_install/job_plugin_install.cpp
            - src/jobs/widget_uninstall/task_db_update.h
            - src/jobs/widget_uninstall/task_delete_pkginfo.h

[SCMRequest] N/A

Change-Id: I3277d5796e029b382719df03381078af910ebdda

11 years ago[Release] wrt-installer_0.1.125
sung-su.kim [Fri, 13 Sep 2013 01:30:49 +0000 (10:30 +0900)]
[Release] wrt-installer_0.1.125

Change-Id: I44fb5c2d8df47bcdc2671f6da1c6cbd205ffba70

11 years agoFix update logic for preloaded app
Tomasz Iwanek [Thu, 12 Sep 2013 15:14:21 +0000 (17:14 +0200)]
Fix update logic for preloaded app

[Issue#]   LINUXWRT-864
[Problem]  Preloader/RO app fails to update
[Cause]    Shared directory tried to be copied
[Solution] "shared" direcotry is already always on RW partion (/opt/usr) so no need "moving".

[Verification] Install and update:
    - preloaded app (run any app wrt-installer -ip [.wgt] (for update same))
    - normal app (run any app wrt-installer -i [.wgt] (for update same))

Change-Id: Ia6feb9a9fb41d3256290f61eee9da7c161d53f36

11 years agoFixed csc web app's preload attribute.
Soyoung Kim [Mon, 9 Sep 2013 08:32:27 +0000 (17:32 +0900)]
Fixed csc web app's preload attribute.

[Issue#] N/A
[Problem] The web app installed by csc display download app at setting menu.
[Cause] preload attribute doesn't set if installed by csc.
[Solution] set preload attribute if installed csc.
[SCMRequest] N/A

Change-Id: I3a3490511ecd86b2a604e75ef231d053ef85a6e5

11 years agoFixed update failed after uninstall hybrid web app.
Soyoung Kim [Thu, 12 Sep 2013 04:41:32 +0000 (13:41 +0900)]
Fixed update failed after uninstall hybrid web app.

[Issue#] N/A
[Problem] uninstallation failed during osp service app.
[Cause] pkg info is checked during uninstall osp service app.
But wrt-installer remove pkg info before call uninstallation osp app.
[Solution] Task of uninstall osp service app move to front of removing pkg information.
[SCMRequest] N/A

Change-Id: I5165754e17a46b42e162056c77001bce83734d06

11 years ago[Release] wrt-installer_0.1.124
sung-su.kim [Wed, 11 Sep 2013 23:09:43 +0000 (08:09 +0900)]
[Release] wrt-installer_0.1.124

Change-Id: I8c782d8cffe2c0eac54bff54222083e7c6869ec4

11 years agoAdd WidgetInstallationStruct into namespace
Adam Banasiak [Tue, 10 Sep 2013 14:55:34 +0000 (16:55 +0200)]
Add WidgetInstallationStruct into namespace

[Issue#]   Linux-358
[Problem]  Declaration Widget Installation Struct without any namespace
[Cause]    N/A
[Solution] WidgetInstallationStruct added into Jobs::WidgetInstall namespace

Change-Id: Iacc417fa211412e30387c01b4d43628b8f9c1552

11 years agoDefine wrt-installer log format
sung-su.kim [Wed, 11 Sep 2013 12:02:57 +0000 (21:02 +0900)]
Define wrt-installer log format

[Issue]    N/A
[Problem]  N/A
[Cause]    Change wrt-installer log form C++ style to C style
[Solution] Define wrt-installer log format using wrt-commons log format.
            - LogDebug/LogError/LogWarning to _D, _E, _W
            - Error log color change to red.
            - Define macro for type change from DPL::String to char*

[SCMRequest] N/A

Change-Id: I1b585b4a93cfaa9ea38da11f5f9fc4860ec0d5d3

11 years agoUpdate screen size feature list
Hoseon LEE [Wed, 11 Sep 2013 04:48:59 +0000 (13:48 +0900)]
Update screen size feature list

- Filtering rule based on application's "screen size" has been fixed:

[Issue#]   N/A
[Problem]  Missing a screen size according to the new rule.
[Cause]    Fixed the list of supported screen size recently.
            - 600X1024 is added
[Solution] Update screen size in the list.
[SCMRequest] N/A

Change-Id: I73e46e35ec81431e9141ea4425e5c21b8c952bdb

11 years agoRemove "TODO" comments from the various places in the code
Adam Banasiak [Tue, 10 Sep 2013 14:25:18 +0000 (16:25 +0200)]
Remove "TODO" comments from the various places in the code

[Issue#]   LINUXWRT-358
[Problem]  Outdated TODO's, Unnecessary 'include' directives
[Cause]    N/A
[Solution] Removed "TODO" comments

Change-Id: Ia80e1131c3ec8526549ad887d0e24f8fa8444c36

11 years agoChange name (getInstallerStruct -> GetInstallerStruct)
Adam Banasiak [Tue, 10 Sep 2013 13:49:02 +0000 (15:49 +0200)]
Change name (getInstallerStruct -> GetInstallerStruct)

[Issue#]   LINUXWRT-358
[Problem]  Incorrect function name
[Cause]    N/A
[Solution] Rename function
            - src/jobs/plugin_install/job_plugin_install.cpp
            - src/jobs/widget_uninstall/job_widget_uninstall.cpp

Change-Id: Ic3724cb330968f607c2d43f22f84073d1cb25524

11 years agoChange name (getInstallerStruct -> GetInstallerStruct)
Adam Banasiak [Tue, 10 Sep 2013 13:46:41 +0000 (15:46 +0200)]
Change name (getInstallerStruct -> GetInstallerStruct)

[Issue#]   LINUXWRT-358
[Problem]  Incorrect function name
[Cause]    N/A
[Solution] Rename function in src/jobs/widget_install/job_widget_install.cpp

Change-Id: I36e92f37799a93d6537ee60b16fcb7d1d0e454d3

11 years agoChange name (getInstallerStruct -> GetInstallerStruct)
Adam Banasiak [Tue, 10 Sep 2013 13:44:27 +0000 (15:44 +0200)]
Change name (getInstallerStruct -> GetInstallerStruct)

[Issue#]   LINUXWRT-358
[Problem]  Incorrect function name
[Cause]    N/A
[Solution] Rename function

Change-Id: I56bde2c393a61cc8af5a05f6f0d9dd92bc897a70

11 years agoChange function and variable name (UndoType -> abortStarted)
Adam Banasiak [Tue, 10 Sep 2013 12:04:31 +0000 (14:04 +0200)]
Change function and variable name (UndoType -> abortStarted)

[Issue#]   LINUXWRT-358
[Problem]  Incorrect names of variable and function
[Cause]    N/A
[Solution] Rename function and variable names

Change-Id: Iea9bb7fecd8ec57f54d90bebb2e906abd4a8cde7

11 years agoAdd routine to check valid locale
Adam Banasiak [Tue, 10 Sep 2013 10:05:00 +0000 (12:05 +0200)]
Add routine to check valid locale

[Issue#]   LINUXWRT-358
[Problem]  Missing logic to validate the default locale in widget parser
[Cause]    N/A
[Solution] Add default locale validation to widget parser

Change-Id: Ib8183f0ce9454676415154cd868d2d078012acae

11 years ago[Release] wrt-installer_0.1.123
sung-su.kim [Tue, 10 Sep 2013 23:21:49 +0000 (08:21 +0900)]
[Release] wrt-installer_0.1.123

Change-Id: Id28058b48d575ea65ad427b7b59fccddbd61ac6c

11 years agoRegister a new appid for dynamic box and its symbolic link to /usr/bin/WebProcess
Yunchan Cho [Mon, 26 Aug 2013 09:04:58 +0000 (18:04 +0900)]
Register a new appid for dynamic box and its symbolic link to /usr/bin/WebProcess

- Tizen application is registered to app_info DB on installation time, hence
  this change needs to be done in wrt-installer

[Issue]    N/A
[Problem]  wrt-plugins (or external root daemon) cannot retrieve appid properly
           based on the pid of Box WebProcess.
[Cause]    app_manager API which gets appid from pid considers only
           registered executable path on app_info DB.
           (app_manager gets executable path from /proc/<pid>/cmdline
             matched to pid of WebProcess)
[Solution] WebProcess associated with the box needs to be registered to
           app_info DB on installation time.
           1. Register symbolic link (/usr/bin/WebProcess) per box
           2. Register the box's new appid to app_info DB on installation time
           2. wrt-installer adds 'root_path' attribute of <package> on application xml.
              - 'root_path' has application root directory (absolute path) as value,
                so that web-provider gets root dir of package using pkgmgr API.

Change-Id: Ic37d5172d9ee4434375858d5e441257ae8e7a736

11 years agoBroken header guard for pkgmgr_signal.h
Tomasz Iwanek [Mon, 9 Sep 2013 15:07:20 +0000 (17:07 +0200)]
Broken header guard for pkgmgr_signal.h

[Issue#]       N/A
[Bug]          Broken header guard for pkgmgr_signal.h
[Cause]        Broken header guard for pkgmgr_signal.h
[Solution]     Fix
[Verification] Build repo.

Change-Id: Ib7ba7689f7f03f280776d6955d73c5c3fc9303cf

11 years ago[Release] wrt-installer_0.1.122
sung-su.kim [Sun, 8 Sep 2013 23:21:12 +0000 (08:21 +0900)]
[Release] wrt-installer_0.1.122

Change-Id: I77e1e31d9cc1fb7277ea355af5fd543ff05541c5

11 years agoFix uninstallation failure followed by https://tizendev.org/gerrit/#/c/85895/
Soyoung Kim [Fri, 6 Sep 2013 10:19:53 +0000 (19:19 +0900)]
Fix uninstallation failure followed by https://tizendev.org/gerrit/#/c/85895/

[Issue#]   N/A
[Problem]  Uninstall web app failure followed by:
           commit 04ed54303f1236635e13a0f0d7b99b2d8ebcf51f
[Cause]    DB operations were moved to just before removing files.
[Solution] Removing external file logic is moved to the DB operations.

[SCMRequest] N/A

Change-Id: Ie6b429c9815cac61212ad50ae6936428a5ac3b25

11 years agoSeparate update package information. Phase2.
Soyoung Kim [Wed, 7 Aug 2013 05:58:44 +0000 (14:58 +0900)]
Separate update package information. Phase2.

[Issue#] N/A
[Problem] N/A
[Cause] N/A
[Solution] 1. To update package information separte from removefiles.
2. organize the task lists of uninstallation.
[SCMRequest] N/A

Change-Id: I8e29dcc6f66f4d5516d2596754889c218d8821be

11 years agoFix building the package with GCC-4.8
Grzegorz Rynkowski [Wed, 4 Sep 2013 13:32:48 +0000 (15:32 +0200)]
Fix building the package with GCC-4.8

[Problem]      The package cannot be built with gcc-4.8.
[Cause]        Missing #include statements.
[Solution]     Add the missing #include statements.
[Verification] Build package both with current (GCC-4.5) and (GCC-4.8) version of compiler.

Change-Id: I9acb3034aee32ae1481315bf56673104506485a7

11 years ago[Release] wrt-installer_0.1.121
sung-su.kim [Wed, 4 Sep 2013 06:39:42 +0000 (15:39 +0900)]
[Release] wrt-installer_0.1.121

Change-Id: I98a453a5999d905e410d28bd7b5d938c79353cba

11 years agoFix backendlib - wrong icon returned
Tomasz Iwanek [Tue, 3 Sep 2013 09:04:53 +0000 (11:04 +0200)]
Fix backendlib - wrong icon returned

[Issue#]  LINUXWRT-824
[Problem] First icon is always returned from backendlib
          i.e., Curent locale settigns are not taken into account.
[Cause]   This was just not handled before.
            - The exact problem is that after installation icon is ok(notiication)
              but before it is read from package file.
            - This operation does not involve full steps in case of installation.
              Backend lib should do it in more checking to find best icon.
[Solution] Added workaround to return icon according to locale setting

[Verification] Install bm.wgt (W3C P&C icon test) from MyFiles app.
    Icon in "install prompt view" (before installing) and in notification
    should be used for proper locale (change locale to en).

Change-Id: If9d9d32dd2a69914bf72aacf6a82c7881cab2918

11 years ago[Path Usage Unification] Plugin Installation Paths (further enhancements)
Kamil Nowac [Mon, 10 Jun 2013 11:51:49 +0000 (13:51 +0200)]
[Path Usage Unification] Plugin Installation Paths (further enhancements)

[Issue#]   LINUXWRT-422
[Problem]  A lot of paths used in wrt are constructed manually
[Cause]    N/A
[Solution] Created class PluginPath which gathers all manually constructed paths

[Verification]
    1. Build wrt-installer repo with --define "WITH_TESTS ON"
    2. Install plugins by using wrt-installer -p and
        run tests wrt-installer-tests-general --output=text
    They shoud install without problems and tests should pass.

Change-Id: I82f1f3d2e9b46b9363f93311557984da1aeaabbd

11 years agoJobWidgetInstall refactoring - TaskConfiguration
Tomasz Iwanek [Tue, 27 Aug 2013 09:24:00 +0000 (11:24 +0200)]
JobWidgetInstall refactoring - TaskConfiguration

[Issue#]   LINUXWRT-820
[Feature]  Refactoring
[Cause]    There is too much logic in JobWidgetInstall
[Solution] This commit just moves code of JobWIdgetInstall to TaskConfiguration.

ALL OTHER CHANGES ARE MARKED as TODO (job_install_refactoring) and will be done later.
Following changes to be do in next:
- make proper steps in TaskConfiguration,
- clean getInstallerSTruct in TaskConfiguration,
- remove second parsing of config.xml,
- refactor TaskUnzip leftovers,
- fix TODOs in JobWidgetInstall context,
- header clean up in TaskConfiguration, JobWidgetInstall,
- (maybe) functions appendTaskList* shoule be refactored to seperate abstraction,

Jobs now uses MutableTaskList and tasks can be appended in running state.
There is no change in code because most of code uses installer context anyway.
Two additional fields were temporary supplied to installer context:
needEncryption and configureResult (those was internal variables in JobWidgetInstall).
Failure task was moved to seperate file.

[Verification] There was finally changed only few branches of code.
Do following steps (this tests two extracted to install context variables):
1. run wrt-installer -p - plugins should be installed.
2. Get widegt with some files (prefer with dozens of file e.g. use some game)
- install this widget and run it - success,
- run wrt-installer -i again and run widget - success,
- uninstall widget and isntall it again - widget should be runnign properly,
3. Get wigdet with encryption set (repeat steps from point 2.).
4. Get malformed zip file.
 - try to install and observe failure message:
     ## wrt-installer :  installation has failed - invalid widget package

[SCMRequest] This change requires: https://review.tizendev.org/gerrit/87851

Change-Id: Ib0abe152a1e524310692e213255a34c19cfb14e3

11 years ago[Release] wrt-installer_0.1.120
sung-su.kim [Mon, 2 Sep 2013 00:09:08 +0000 (09:09 +0900)]
[Release] wrt-installer_0.1.120

Change-Id: I5198eaa5972bdfa0cd5625aeaeb2c79f407d6322

11 years agoMerge "Added logs to help debugging regarding dynamic linking loader error."
HOSEON LEE [Thu, 29 Aug 2013 04:37:54 +0000 (04:37 +0000)]
Merge "Added logs to help debugging regarding dynamic linking loader error."

11 years agoVerify the size of DynamicBox
leerang song [Tue, 27 Aug 2013 08:18:37 +0000 (17:18 +0900)]
Verify the size of DynamicBox

* How it works:
  - When wrt-installer installs DynamicBox webapp, parse the boxsize attribute in config.xml.
  - Verify the boxsize using web_provider_plugin_check_supported_size API provided from web-provier.
  - If unsupported size is found, installer sends a ThrowMsg
  - Web application install should fail.

[Issue#]   N/A
[Problem]  When there is unsupported boxsize specified in config.xml, webapp is still installed successfully.
[Cause]    The boxsize attribute of DynamicBox in config.xml is not checked at the install time.
[Solution] Verify the boxsize attribute of DynamicBox in config.xml

[SCMRequest] N/A

Change-Id: If18ea9136687bfacf8d516bcbbadf8042cbb3e12

11 years agoIcon extension for package manager and manifest fix
Tomasz Iwanek [Mon, 19 Aug 2013 09:58:29 +0000 (11:58 +0200)]
Icon extension for package manager and manifest fix

[Issue#]   LINUXWRT-804 / WGL-428
[Bug]      Hardcoded .png extension
[Cause]    Missing an API that can retrieve file extension.
[Solution] Make use the file extension of used icon

[SCMRequest] Depends upon https://review.tizendev.org/gerrit/86777
[Verification]
   1. Install widget from https://bugs.tizendev.org/jira/browse/WGL-428.
   2. Manifest file in /opt/share/packages/J7tHY89x22.xml should contain icon with .svg extension
      (<icon>J7tHY89x22.Y2y1.svg</icon>).

Change-Id: I06ccc45566afe8b49f39515e192ce58a1c1cac86

11 years agoAdded logs to help debugging regarding dynamic linking loader error.
Tae-Jeong Lee [Mon, 26 Aug 2013 14:03:57 +0000 (23:03 +0900)]
Added logs to help debugging regarding dynamic linking loader error.

[Issue#] N/A
[Problem] When a dependency error occured during wrt-plugins installation, the dynamic linking loader works strangely after that.
          Because of that, to help debugging, some logs were added.
[Cause] N/A
[Solution] Added some 'stderr' logs regarding dynamic linking loader error. It will show the reason of fail to dlopen().

Change-Id: I964db7d7434274549197d79655cf7eea50884ea7

11 years agoProgress callback log set to 'Pedantic' level
Tomasz Iwanek [Fri, 23 Aug 2013 11:50:01 +0000 (13:50 +0200)]
Progress callback log set to 'Pedantic' level

[Issue#]       N/A
[Feature]      Those lines makes no information gain usually but makes log harder to read
[Cause]        N/A
[Solution]     Lvel log logging changed
[Verification] Build repo.

Change-Id: I3528b0e0583185593795a18809f2212f0ff311a8

11 years ago[Release] wrt-installer_0.1.119
sung-su.kim [Thu, 22 Aug 2013 04:45:48 +0000 (13:45 +0900)]
[Release] wrt-installer_0.1.119

Change-Id: Iec9544adbe20431359f2cc3f928f2331a75e0a9c

11 years agoFixed copy icon for dynamic box failed.
Soyoung Kim [Thu, 22 Aug 2013 04:25:22 +0000 (13:25 +0900)]
Fixed copy icon for dynamic box failed.

[Issue#] P130821-05213
[Problem] To copy dynamic's icon fail when update.
[Cause] there was no shared/data directory.
 Because original directory is empty so to copy directory doesn't work.
[Solution] shared directory always is made whenever install or update.
[SCMRequest] N/A

Change-Id: I96b90a762d9bd66e8543902fce51a4509c6ca855

11 years ago[Release] wrt-installer_0.1.118
sung-su.kim [Wed, 21 Aug 2013 01:41:03 +0000 (10:41 +0900)]
[Release] wrt-installer_0.1.118

Change-Id: I9fe5fd7efa7ce5f419b28c6983440553eeb3e70d

11 years agoUpdate the screen size feature list
Hoseon LEE [Wed, 21 Aug 2013 01:29:35 +0000 (10:29 +0900)]
Update the screen size feature list

[Issue] N/A
[Problem] N/A
[Cause] Screen size feature list is fixed by platform.
[Solution] Screen size feature list is updated.
[SCMRequest] N/A

Change-Id: If341b6b67a8571247440d24c0bfd84d9e1deccd8

11 years agoThis commit has a dependency of wrt-commons.
HOSEON LEE [Wed, 21 Aug 2013 01:33:59 +0000 (01:33 +0000)]
This commit has a dependency of wrt-commons.
Therefore, this commit is reverted.
Please merge wrt-commons commit before this commit.

Revert "Icon extension for package manager and manifest fix"

This reverts commit e11660bf9e6ad7fa8183ae7eecd435763a1bf027.

Change-Id: I08a01cbdecc0f3222bbae8522dd1ef9c29bc79d5

11 years agoIcon extension for package manager and manifest fix
Tomasz Iwanek [Mon, 19 Aug 2013 09:58:29 +0000 (11:58 +0200)]
Icon extension for package manager and manifest fix

[Issue#]       LINUXWRT-804 / WGL-428
[Bug]          Hardcoded .png extension
[Cause]        N/A
[Solution]     Use extension of used icon
[SCMRequest]   This requries wrt-commons change: https://review.tizendev.org/gerrit/86777
[Verification] Install widget from https://bugs.tizendev.org/jira/browse/WGL-428.
Manifest file in /opt/share/packages/J7tHY89x22.xml should contain icon with .svg extension
(<icon>J7tHY89x22.Y2y1.svg</icon>).

Change-Id: Ifef3f38e1566b92817f62aa01c1ac73bc073d71b