platform/upstream/libSkiaSharp.git
10 years agoanticipate more optimizations by renaming some files and methods
commit-bot@chromium.org [Mon, 21 Apr 2014 15:03:36 +0000 (15:03 +0000)]
anticipate more optimizations by renaming some files and methods

also, call the new SkRecordOptimize in bench_playback

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/243243003

git-svn-id: http://skia.googlecode.com/svn/trunk@14277 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd --match to bench tools, extra decimal to bench_pictures.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:59:59 +0000 (14:59 +0000)]
Add --match to bench tools, extra decimal to bench_pictures.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/243273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14276 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPicking from the wrong end of the workspace history list.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:57:50 +0000 (14:57 +0000)]
Picking from the wrong end of the workspace history list.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244133002

git-svn-id: http://skia.googlecode.com/svn/trunk@14275 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase test f7927dd
commit-bot@chromium.org [Mon, 21 Apr 2014 14:48:53 +0000 (14:48 +0000)]
bench rebase test f7927dd
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/245223002

git-svn-id: http://skia.googlecode.com/svn/trunk@14274 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow running gyp_to_android without SkUserConfig.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:45:01 +0000 (14:45 +0000)]
Allow running gyp_to_android without SkUserConfig.

The old code requires that include/config/SkUserConfig.h exists,
to ensure that it gets copied into Android's
include/core/SkUserConfig.h when we do a merge. However, if a
developer wants to make changes and rerun the script, they
should not have to recreate include/config/SkUserConfig.h just
to rerun the script. By default, allow the original to not
exist and just skip the copy.

Update tests to pass. Also add tests to support this use case.

Make gyp_to_android.py executable.

R=robertphillips@google.com, halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/242203008

git-svn-id: http://skia.googlecode.com/svn/trunk@14273 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSupport clip to layer flag on Android framework.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:42:38 +0000 (14:42 +0000)]
Support clip to layer flag on Android framework.

This flag is being transitioned out, but the Android framework
still needs it.

R=reed@google.com, fmalita@google.com, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/243843002

git-svn-id: http://skia.googlecode.com/svn/trunk@14272 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd flipped gradient branch to two point conical gradient
commit-bot@chromium.org [Mon, 21 Apr 2014 13:10:25 +0000 (13:10 +0000)]
Add flipped gradient branch to two point conical gradient

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14235

R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/227623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14271 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sun, 20 Apr 2014 03:04:55 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14270 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove sizeof check -- triggers warning in chrome
reed@google.com [Sun, 20 Apr 2014 00:56:50 +0000 (00:56 +0000)]
remove sizeof check -- triggers warning in chrome

git-svn-id: http://skia.googlecode.com/svn/trunk@14269 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinline SkMulDiv now that 64bit mul is inlineable
commit-bot@chromium.org [Sat, 19 Apr 2014 22:12:35 +0000 (22:12 +0000)]
inline SkMulDiv now that 64bit mul is inlineable

TBR=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/242493006

git-svn-id: http://skia.googlecode.com/svn/trunk@14268 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix warnings around size_t/int
commit-bot@chromium.org [Sat, 19 Apr 2014 22:00:40 +0000 (22:00 +0000)]
fix warnings around size_t/int
fix warnings around undeclared (non-static) functions

TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/242643008

git-svn-id: http://skia.googlecode.com/svn/trunk@14267 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd support for serving up a view that can be iframed.
commit-bot@chromium.org [Sat, 19 Apr 2014 14:50:23 +0000 (14:50 +0000)]
Add support for serving up a view that can be iframed.

Also add support for creating the <iframe /> code needed for embedding.

This CL must land after https://codereview.chromium.org/240773003/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/242613005

git-svn-id: http://skia.googlecode.com/svn/trunk@14266 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFirst pass at workspaces.
commit-bot@chromium.org [Sat, 19 Apr 2014 13:55:50 +0000 (13:55 +0000)]
First pass at workspaces.

Ability to create new workspaces. Run tries in a workspace, each try is added to a history of a workspace.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/240773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14265 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 19 Apr 2014 03:04:56 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14264 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMass baseline for filltypespersp
bsalomon@google.com [Fri, 18 Apr 2014 21:57:48 +0000 (21:57 +0000)]
Mass baseline for filltypespersp

Review URL: https://codereview.chromium.org/243853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14263 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMass baselining of drrect GM
bsalomon@google.com [Fri, 18 Apr 2014 21:06:59 +0000 (21:06 +0000)]
Mass baselining of drrect GM

Review URL: https://codereview.chromium.org/243723003

git-svn-id: http://skia.googlecode.com/svn/trunk@14262 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMass rebaseline of the rrect_* GMs
bsalomon@google.com [Fri, 18 Apr 2014 20:13:43 +0000 (20:13 +0000)]
Mass rebaseline of the rrect_* GMs

Review URL: https://codereview.chromium.org/243693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14261 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused fOverflowed from SkClampRange
reed@google.com [Fri, 18 Apr 2014 19:36:22 +0000 (19:36 +0000)]
remove unused fOverflowed from SkClampRange

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/243563002

git-svn-id: http://skia.googlecode.com/svn/trunk@14260 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix int/size_t warnings
reed@google.com [Fri, 18 Apr 2014 19:29:07 +0000 (19:29 +0000)]
fix int/size_t warnings

patch from issue 239933002

BUG=skia:
R=bungeman@google.com

Review URL: https://codereview.chromium.org/242113010

git-svn-id: http://skia.googlecode.com/svn/trunk@14259 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStaging for cleanup of SkPicture-related headers
robertphillips@google.com [Fri, 18 Apr 2014 18:04:41 +0000 (18:04 +0000)]
Staging for cleanup of SkPicture-related headers

https://codereview.chromium.org/243173002

git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogradient_many gm to test banding and precision
reed@google.com [Fri, 18 Apr 2014 17:55:37 +0000 (17:55 +0000)]
gradient_many gm to test banding and precision

BUG=skia:

Review URL: https://codereview.chromium.org/243133005

git-svn-id: http://skia.googlecode.com/svn/trunk@14257 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Fri, 18 Apr 2014 17:38:43 +0000 (17:38 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14256 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorename SkPaintParts.* to SkPaintPart.*
reed@google.com [Fri, 18 Apr 2014 15:14:25 +0000 (15:14 +0000)]
rename SkPaintParts.* to SkPaintPart.*

BUG=skia:
R=caryclark@google.com

Review URL: https://codereview.chromium.org/242943004

git-svn-id: http://skia.googlecode.com/svn/trunk@14255 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGet gradient information for gpu effect directly from SkGradientShader instead of...
commit-bot@chromium.org [Fri, 18 Apr 2014 14:42:11 +0000 (14:42 +0000)]
Get gradient information for gpu effect directly from SkGradientShader instead of calling asAGradient

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/241173005

git-svn-id: http://skia.googlecode.com/svn/trunk@14254 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReduce internal explicit SaveFlags usage.
commit-bot@chromium.org [Fri, 18 Apr 2014 14:19:31 +0000 (14:19 +0000)]
Reduce internal explicit SaveFlags usage.

Most of these are either redundant/defaults or (hopefully)
unnecessarily specific.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/241453003

git-svn-id: http://skia.googlecode.com/svn/trunk@14253 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 18 Apr 2014 03:03:54 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14252 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStaged removal of SkPicture-derived classes
commit-bot@chromium.org [Thu, 17 Apr 2014 23:35:06 +0000 (23:35 +0000)]
Staged removal of SkPicture-derived classes

This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted).

The only interesting bits are in SkPicture* and Sk*Picture.*

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/238273012

git-svn-id: http://skia.googlecode.com/svn/trunk@14251 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd SK_SUPPORT_LEGACY_PROCXFERMODE to skia_for_chromium_defines.gypi
commit-bot@chromium.org [Thu, 17 Apr 2014 23:25:50 +0000 (23:25 +0000)]
add SK_SUPPORT_LEGACY_PROCXFERMODE to skia_for_chromium_defines.gypi

R=reed@google.com
TBR=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/242053002

git-svn-id: http://skia.googlecode.com/svn/trunk@14250 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoclean up gitignore; sort, add chromeos/externals, remove trailing /.
commit-bot@chromium.org [Thu, 17 Apr 2014 22:56:46 +0000 (22:56 +0000)]
clean up gitignore; sort, add chromeos/externals, remove trailing /.

R=mtklein@google.com, epoger@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/240173008

git-svn-id: http://skia.googlecode.com/svn/trunk@14249 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Roll ANGLE. (https://codereview.chromium.org/237173002/)
commit-bot@chromium.org [Thu, 17 Apr 2014 21:31:32 +0000 (21:31 +0000)]
Revert of Roll ANGLE. (https://codereview.chromium.org/237173002/)

Reason for revert:
http://skbug.com/2437

Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243

R=bsalomon@chromium.org, geofflang@chromium.org
TBR=bsalomon@chromium.org, geofflang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2272

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/238863006

git-svn-id: http://skia.googlecode.com/svn/trunk@14248 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Extract most of the mutable state of SkShader into a separate Context objec...
commit-bot@chromium.org [Thu, 17 Apr 2014 21:09:49 +0000 (21:09 +0000)]
Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/)

Reason for revert:
Causing memory leaks in Chromium.

Original issue's description:
> Extract most of the mutable state of SkShader into a separate Context object.
>
> SkShader currently stores some state during draw calls via setContext(...).
> Move that mutable state into a separate SkShader::Context class that is
> constructed on demand for the duration of the draw.
>
> Calls to setContext() are replaced with createContext() which returns a context
> corresponding to the shader object or NULL if the parameters to createContext
> are invalid.
>
> TEST=out/Debug/dm
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14216

R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/241283003

git-svn-id: http://skia.googlecode.com/svn/trunk@14247 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r14218.
bungeman@google.com [Thu, 17 Apr 2014 21:09:00 +0000 (21:09 +0000)]
Revert r14218.

git-svn-id: http://skia.googlecode.com/svn/trunk@14246 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/24030...
commit-bot@chromium.org [Thu, 17 Apr 2014 21:02:29 +0000 (21:02 +0000)]
Revert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/240303003/)

Reason for revert:
This and https://codereview.chromium.org/207683004 are causing memory leaks.

Original issue's description:
> Fix memory leak in SkGradientShader.
>
> Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap.
> Rename methods returning a "pre-reffed" object to indicate obligations.
>
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14223

R=reed@google.com, scroggo@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/241603002

git-svn-id: http://skia.googlecode.com/svn/trunk@14245 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkiaSampleRenderer - handle case where compiler won't cast jint to void*.
commit-bot@chromium.org [Thu, 17 Apr 2014 19:41:06 +0000 (19:41 +0000)]
SkiaSampleRenderer - handle case where compiler won't cast jint to void*.

R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239703016

git-svn-id: http://skia.googlecode.com/svn/trunk@14244 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRoll ANGLE.
commit-bot@chromium.org [Thu, 17 Apr 2014 18:29:06 +0000 (18:29 +0000)]
Roll ANGLE.

BUG=skia:2272
R=bsalomon@chromium.org, bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/237173002

git-svn-id: http://skia.googlecode.com/svn/trunk@14243 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAshmem functions compile when size_t != __u32
commit-bot@chromium.org [Thu, 17 Apr 2014 17:28:20 +0000 (17:28 +0000)]
Ashmem functions compile when size_t != __u32

R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/241123002

git-svn-id: http://skia.googlecode.com/svn/trunk@14242 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd some asserts for mipmaps, and cleanup fFilterLevel if mipping failed
commit-bot@chromium.org [Thu, 17 Apr 2014 16:46:07 +0000 (16:46 +0000)]
add some asserts for mipmaps, and cleanup fFilterLevel if mipping failed

BUG=skia:
R=scroggo@google.com, humper@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240633003

git-svn-id: http://skia.googlecode.com/svn/trunk@14241 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix expected size in 32bit builds
reed@google.com [Thu, 17 Apr 2014 16:14:26 +0000 (16:14 +0000)]
fix expected size in 32bit builds

BUG=skia:

Review URL: https://codereview.chromium.org/240283012

git-svn-id: http://skia.googlecode.com/svn/trunk@14240 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoallow gyp_skia to be run from any directory.
commit-bot@chromium.org [Thu, 17 Apr 2014 16:11:58 +0000 (16:11 +0000)]
allow gyp_skia to be run from any directory.

R=epoger@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/240383003

git-svn-id: http://skia.googlecode.com/svn/trunk@14239 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoOrphan ProcXfermode, with an eye towards removing it
commit-bot@chromium.org [Thu, 17 Apr 2014 15:19:32 +0000 (15:19 +0000)]
Orphan ProcXfermode, with an eye towards removing it

BUG=skia:
R=scroggo@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240533003

git-svn-id: http://skia.googlecode.com/svn/trunk@14238 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused tests to fix new clang build
commit-bot@chromium.org [Thu, 17 Apr 2014 15:18:21 +0000 (15:18 +0000)]
remove unused tests to fix new clang build

R=mtklein@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/241043002

git-svn-id: http://skia.googlecode.com/svn/trunk@14237 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Add flipped gradient branch to two point conical gradient (https://coderevi...
commit-bot@chromium.org [Thu, 17 Apr 2014 13:57:31 +0000 (13:57 +0000)]
Revert of Add flipped gradient branch to two point conical gradient (https://codereview.chromium.org/227623004/)

Reason for revert:
Breaking all CompareGMs

Original issue's description:
> Add flipped gradient branch to two point conical gradient
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14235

R=bsalomon@google.com, mtklein@google.com
TBR=bsalomon@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/239993006

git-svn-id: http://skia.googlecode.com/svn/trunk@14236 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd flipped gradient branch to two point conical gradient
commit-bot@chromium.org [Thu, 17 Apr 2014 13:28:06 +0000 (13:28 +0000)]
Add flipped gradient branch to two point conical gradient

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/227623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14235 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 17 Apr 2014 03:05:10 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14234 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore flags needed to build Android framework.
commit-bot@chromium.org [Wed, 16 Apr 2014 23:06:29 +0000 (23:06 +0000)]
More flags needed to build Android framework.

R=djsollen@google.com
TBR=djsollen@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/240563005

git-svn-id: http://skia.googlecode.com/svn/trunk@14233 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't unset gFCSafeToUse when it's still safe to use.
commit-bot@chromium.org [Wed, 16 Apr 2014 22:10:52 +0000 (22:10 +0000)]
Don't unset gFCSafeToUse when it's still safe to use.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/240513003

git-svn-id: http://skia.googlecode.com/svn/trunk@14232 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinstall_dependencides tool for posix-type systems
commit-bot@chromium.org [Wed, 16 Apr 2014 22:10:48 +0000 (22:10 +0000)]
install_dependencides tool for posix-type systems

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239303010

git-svn-id: http://skia.googlecode.com/svn/trunk@14231 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSupport picture recording in Android framework.
commit-bot@chromium.org [Wed, 16 Apr 2014 22:08:32 +0000 (22:08 +0000)]
Support picture recording in Android framework.

Fixes master-skia build.

R=djsollen@google.com
TBR=djsollen@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/240093007

git-svn-id: http://skia.googlecode.com/svn/trunk@14230 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoalways store bitfields along with dirty in FlatteningTraits
commit-bot@chromium.org [Wed, 16 Apr 2014 20:48:10 +0000 (20:48 +0000)]
always store bitfields along with dirty in FlatteningTraits

This allows us to simplify lots of setters in SkPaint, which in the non-android case, could now be just assignments (and therefore inlineable).

R=mtklein@google.com, robertphillips@google.com, tomhudson@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240273004

git-svn-id: http://skia.googlecode.com/svn/trunk@14229 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRoll ANGLE.
commit-bot@chromium.org [Wed, 16 Apr 2014 20:31:54 +0000 (20:31 +0000)]
Roll ANGLE.

Contains small changes to ANGLE to pass skia tests.

BUG=skia:2272
R=bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/235923020

git-svn-id: http://skia.googlecode.com/svn/trunk@14228 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis is an short replacement for gclient.
commit-bot@chromium.org [Wed, 16 Apr 2014 19:21:00 +0000 (19:21 +0000)]
This is an short replacement for gclient.

Makes use of our current DEPS file to allow for a smooth transition.

BUG=skia:291
NOTRY=true
R=borenet@google.com, tfarina@chromium.org, epoger@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/191133005

git-svn-id: http://skia.googlecode.com/svn/trunk@14227 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting r14225 (Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling - https://coderevie...
robertphillips@google.com [Wed, 16 Apr 2014 17:10:12 +0000 (17:10 +0000)]
Reverting r14225 (Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling - https://codereview.chromium.org/237673017/) due to compiler complaints

git-svn-id: http://skia.googlecode.com/svn/trunk@14226 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling
robertphillips@google.com [Wed, 16 Apr 2014 17:00:05 +0000 (17:00 +0000)]
Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling

https://codereview.chromium.org/237673017/

git-svn-id: http://skia.googlecode.com/svn/trunk@14225 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoread/write function_ptrs as just void*, and not as 'array of bytes'
commit-bot@chromium.org [Wed, 16 Apr 2014 16:24:08 +0000 (16:24 +0000)]
read/write function_ptrs as just void*, and not as 'array of bytes'

BUG=skia:
R=mtklein@google.com, bungeman@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240013005

git-svn-id: http://skia.googlecode.com/svn/trunk@14224 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix memory leak in SkGradientShader.
commit-bot@chromium.org [Wed, 16 Apr 2014 16:17:39 +0000 (16:17 +0000)]
Fix memory leak in SkGradientShader.

Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap.
Rename methods returning a "pre-reffed" object to indicate obligations.

BUG=skia:1976
R=reed@google.com, scroggo@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/240303003

git-svn-id: http://skia.googlecode.com/svn/trunk@14223 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDouble assignment in GrGpuGL::configToGLFormats()
commit-bot@chromium.org [Wed, 16 Apr 2014 16:07:37 +0000 (16:07 +0000)]
Double assignment in GrGpuGL::configToGLFormats()

Remove the first one.

R=hcm@google.com, bsalomon@google.com
BUG=skia:2427

Author: siglesias@igalia.com

Review URL: https://codereview.chromium.org/240123002

git-svn-id: http://skia.googlecode.com/svn/trunk@14222 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRetract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API
commit-bot@chromium.org [Wed, 16 Apr 2014 16:02:10 +0000 (16:02 +0000)]
Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API

This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag
from the public API (more work needs to be done in Blink & Chrome). In the new world the only way
to set this flag (and thus instantiate an SkPicture-derived
class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using
factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and
do away with the SkPicture-derived classes.

BUG=skia:2315
R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/239703006

git-svn-id: http://skia.googlecode.com/svn/trunk@14221 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoglDiscardFramebuffer() in GrGpuGL::discard uses invalid GLenum
commit-bot@chromium.org [Wed, 16 Apr 2014 14:33:27 +0000 (14:33 +0000)]
glDiscardFramebuffer() in GrGpuGL::discard uses invalid GLenum

According to the spec:

  "If a framebuffer object is bound to <target>, then <attachments> may
  contain COLOR_ATTACHMENT0, DEPTH_ATTACHMENT, and/or
  STENCIL_ATTACHMENT.  If the framebuffer object is not complete,
  DiscardFramebufferEXT may be ignored.

  If the default framebuffer is bound to <target>,
  then <attachment> may contain COLOR, identifying the color buffer;
  DEPTH, identifying the depth buffer; or STENCIL, identifying the
  stencil buffer."

Do the same as in glInvalidateFramebuffer() case.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
R=bsalomon@google.com
BUG=skia:2411

Author: siglesias@igalia.com

Review URL: https://codereview.chromium.org/236193007

git-svn-id: http://skia.googlecode.com/svn/trunk@14220 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate baselines for bug 2404.
bsalomon@google.com [Wed, 16 Apr 2014 13:48:52 +0000 (13:48 +0000)]
Update baselines for bug 2404.

BUG=skia:2404

Review URL: https://codereview.chromium.org/240303002

git-svn-id: http://skia.googlecode.com/svn/trunk@14219 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix #if SK_DEBUG -- should be #ifdef SK_DEBUG
reed@google.com [Wed, 16 Apr 2014 13:44:43 +0000 (13:44 +0000)]
fix #if SK_DEBUG -- should be #ifdef SK_DEBUG

git-svn-id: http://skia.googlecode.com/svn/trunk@14218 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove legacy filter-flags, and store FilterLevel directly
commit-bot@chromium.org [Wed, 16 Apr 2014 12:58:02 +0000 (12:58 +0000)]
remove legacy filter-flags, and store FilterLevel directly

BUG=skia:
R=robertphillips@google.com, humper@google.com, jvanverth@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/239393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14217 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoExtract most of the mutable state of SkShader into a separate Context object.
commit-bot@chromium.org [Wed, 16 Apr 2014 10:16:39 +0000 (10:16 +0000)]
Extract most of the mutable state of SkShader into a separate Context object.

SkShader currently stores some state during draw calls via setContext(...).
Move that mutable state into a separate SkShader::Context class that is
constructed on demand for the duration of the draw.

Calls to setContext() are replaced with createContext() which returns a context
corresponding to the shader object or NULL if the parameters to createContext
are invalid.

TEST=out/Debug/dm
BUG=skia:1976
R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, bungeman@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/207683004

git-svn-id: http://skia.googlecode.com/svn/trunk@14216 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 16 Apr 2014 03:04:01 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14215 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix bug in SampleApp's Tiling View
commit-bot@chromium.org [Tue, 15 Apr 2014 23:00:57 +0000 (23:00 +0000)]
Fix bug in SampleApp's Tiling View

SampleApp was crashing when invoked as "SampleApp --slide Tiling" due to r14171 (split SkPictureRecorder out of SkPicture - https://codereview.chromium.org/214953003/)

R=bungeman@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/239353006

git-svn-id: http://skia.googlecode.com/svn/trunk@14214 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 21:43:57 +0000 (21:43 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14213 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix generation of Android SampleApp APK now that we default to using gyp's ninja...
commit-bot@chromium.org [Tue, 15 Apr 2014 21:37:12 +0000 (21:37 +0000)]
Fix generation of Android SampleApp APK now that we default to using gyp's ninja generator.

R=scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/235783003

git-svn-id: http://skia.googlecode.com/svn/trunk@14212 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPull ANGLE's new repository to third_party/external/angle2.
commit-bot@chromium.org [Tue, 15 Apr 2014 21:11:09 +0000 (21:11 +0000)]
Pull ANGLE's new repository to third_party/external/angle2.

BUG=skia:2272
R=bsalomon@chromium.org, bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/239593002

git-svn-id: http://skia.googlecode.com/svn/trunk@14211 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoarm64_download script - fix error starting vm twice.
commit-bot@chromium.org [Tue, 15 Apr 2014 20:29:38 +0000 (20:29 +0000)]
arm64_download script - fix error starting vm twice.
R=epoger@google.com
TBR=epoger@google.com
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239653003

git-svn-id: http://skia.googlecode.com/svn/trunk@14210 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoarm64_download script waits for VM to boot before finishing.
commit-bot@chromium.org [Tue, 15 Apr 2014 20:05:24 +0000 (20:05 +0000)]
arm64_download script waits for VM to boot before finishing.

It may take an unknown amount of time to boot.

Also, add `set -e` to the script to simplify error handling.

BUG=skia:2425
NOTRY=true
R=epoger@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239243005

git-svn-id: http://skia.googlecode.com/svn/trunk@14209 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 19:39:52 +0000 (19:39 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14208 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of rebaseline_server: multithreaded loading/diffing of images (https://coderev...
commit-bot@chromium.org [Tue, 15 Apr 2014 18:50:12 +0000 (18:50 +0000)]
Revert of rebaseline_server: multithreaded loading/diffing of images (https://codereview.chromium.org/235923002/)

Reason for revert:
Caused https://code.google.com/p/skia/issues/detail?id=2423 ('"Deadline exceeded" error when connecting to live rebaseline_server').  Reverting until I can figure it out.

Original issue's description:
> rebaseline_server: multithreaded loading/diffing of images
>
> BUG=skia:2414
> NOTRY=True
>
> Committed: http://code.google.com/p/skia/source/detail?r=14184

R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2414

Author: epoger@google.com

Review URL: https://codereview.chromium.org/239623002

git-svn-id: http://skia.googlecode.com/svn/trunk@14207 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 18:35:49 +0000 (18:35 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14206 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Tue, 15 Apr 2014 18:24:58 +0000 (18:24 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14205 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinitialize bounds in this test
commit-bot@chromium.org [Tue, 15 Apr 2014 18:00:57 +0000 (18:00 +0000)]
initialize bounds in this test

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/238353007

git-svn-id: http://skia.googlecode.com/svn/trunk@14204 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix artifacts in distance field rendering due to bilerp
commit-bot@chromium.org [Tue, 15 Apr 2014 17:53:21 +0000 (17:53 +0000)]
Fix artifacts in distance field rendering due to bilerp

Because we were using the full distance field glyph rect, there were cases
when a neighboring texel might be set to full value (e.g. we might copy the
glyph over old data after a purge). This was giving artifacts, and insetting
the rect by 1 solves the problem. In doing this, I discovered that removing the
extra 1 texel pad around the glyph meant to handle bilerp, and insetting by 2,
works just as well and saves space in the glyph atlas.

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/239333002

git-svn-id: http://skia.googlecode.com/svn/trunk@14203 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd cast for warning as error on Windows from r14201.
bungeman@google.com [Tue, 15 Apr 2014 16:08:29 +0000 (16:08 +0000)]
Add cast for warning as error on Windows from r14201.

git-svn-id: http://skia.googlecode.com/svn/trunk@14202 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix size of rotated text with FreeType.
bungeman@google.com [Tue, 15 Apr 2014 15:52:07 +0000 (15:52 +0000)]
Fix size of rotated text with FreeType.

This generalizes and shares the solution found for a similar issue with
GDI. The issue is that the text size is applied early, and the rest of
the transformation late. This allows us to isolate and independently
control the text size from the rest of the transformation.

R=reed@google.com

Review URL: https://codereview.chromium.org/213153006

git-svn-id: http://skia.googlecode.com/svn/trunk@14201 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake sure SkDrawLooper objects can only be allocated on the heap.
commit-bot@chromium.org [Tue, 15 Apr 2014 15:48:36 +0000 (15:48 +0000)]
Make sure SkDrawLooper objects can only be allocated on the heap.

Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public.
Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is
used to create new objects.
Provide factory method for creating SkBlurDrawLooper.

BUG=2141
R=scroggo@google.com, reed@google.com, djsollen@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/232913003

git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd GL_CHROMIUM_map_sub functions to GrGLInterface and bit to GrGLCaps.
commit-bot@chromium.org [Tue, 15 Apr 2014 15:37:51 +0000 (15:37 +0000)]
Add GL_CHROMIUM_map_sub functions to GrGLInterface and bit to GrGLCaps.

BUG=skia:2402
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/231773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14199 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoignore Test-Linux-Bare-NoGPU-Arm8_64 GM failures
commit-bot@chromium.org [Tue, 15 Apr 2014 15:26:50 +0000 (15:26 +0000)]
ignore Test-Linux-Bare-NoGPU-Arm8_64 GM failures

(SkipBuildbotRuns)
BUG=skia:2422
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com
TBR=halcanary

Author: epoger@google.com

Review URL: https://codereview.chromium.org/239323002

git-svn-id: http://skia.googlecode.com/svn/trunk@14198 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecord bug fixes
commit-bot@chromium.org [Tue, 15 Apr 2014 14:27:14 +0000 (14:27 +0000)]
SkRecord bug fixes

Optional arguments to SkCanvas calls leaked refs (but not memory) because we
didn't destruct the optional objects (really, just SkPaint: other optional args
are all POD).  This adds Optional and PODArray, where Optional makes sure to
call the destructor.

I overlooked that SkPictureRecord really does call paint.computeFastBounds().
Do the same in SkRecordDraw.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/235983015

git-svn-id: http://skia.googlecode.com/svn/trunk@14197 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 15 Apr 2014 03:04:18 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14196 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore sanitizing input.
commit-bot@chromium.org [Tue, 15 Apr 2014 00:43:51 +0000 (00:43 +0000)]
More sanitizing input.

Also fix issue with parsing time on MySQL.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235953008

git-svn-id: http://skia.googlecode.com/svn/trunk@14195 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate pathops gms for r14183.
bungeman@google.com [Mon, 14 Apr 2014 22:28:00 +0000 (22:28 +0000)]
Update pathops gms for r14183.

git-svn-id: http://skia.googlecode.com/svn/trunk@14194 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove distance field generation to the glyph cache.
commit-bot@chromium.org [Mon, 14 Apr 2014 22:05:07 +0000 (22:05 +0000)]
Move distance field generation to the glyph cache.

Distance fields are currently created in GrTextStrike, which is the wrong place. This moves that to the glyph cache where it belongs.

As part of my testing, I found that when we fall back to paths in the GrDistanceFieldTextContext it was not scaling them properly, so that's fixed in here too.

R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/227593010

git-svn-id: http://skia.googlecode.com/svn/trunk@14193 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecordDraw: use SkCanvas::quickRejectY for text draws
commit-bot@chromium.org [Mon, 14 Apr 2014 20:35:12 +0000 (20:35 +0000)]
SkRecordDraw: use SkCanvas::quickRejectY for text draws

 PS 1) factor apart into canSkip, draw, updateClip
 PS 2) use quickRejectY for text

BUG=skia:2378
R=fmalita@chromium.org, reed@google.com, mtklein@google.com, tomhudson@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/233493004

git-svn-id: http://skia.googlecode.com/svn/trunk@14192 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecord: turn on cull annotation pass in public API.
commit-bot@chromium.org [Mon, 14 Apr 2014 20:33:05 +0000 (20:33 +0000)]
SkRecord: turn on cull annotation pass in public API.

Also, switch Skia internal tools over to use the public headers where
possible.  Where it's not, the tools -Isrc/record explicitly now, and
if it's not obvious, note why they don't use SkRecording.h.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231853006

git-svn-id: http://skia.googlecode.com/svn/trunk@14191 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd /recent, a page that displays the last 20 tries.
commit-bot@chromium.org [Mon, 14 Apr 2014 20:12:08 +0000 (20:12 +0000)]
Add /recent, a page that displays the last 20 tries.

Also broke out CSS as a separate file and added a title bar across both pages to easily navigate between Home and Recent.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/236193011

git-svn-id: http://skia.googlecode.com/svn/trunk@14190 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agochange #if SK_DEBUG to #ifdef SK_DEBUG
commit-bot@chromium.org [Mon, 14 Apr 2014 19:49:53 +0000 (19:49 +0000)]
change #if SK_DEBUG to #ifdef SK_DEBUG

fix broken build

change #if DEBUG to #ifdef DEBUG (fixes canary)

NOTRY=true
R=reed@google.com
TBR=reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/237573002

git-svn-id: http://skia.googlecode.com/svn/trunk@14189 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline pathopsinverse GMs
commit-bot@chromium.org [Mon, 14 Apr 2014 18:56:43 +0000 (18:56 +0000)]
rebaseline pathopsinverse GMs
to account for https://skia.googlesource.com/skia.git/+/4431e7757cfcb8cfa99535eed0e9f156dabf95c2

NOTRY=True
R=caryclark@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/233253006

git-svn-id: http://skia.googlecode.com/svn/trunk@14188 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNow with permalinks.
commit-bot@chromium.org [Mon, 14 Apr 2014 18:53:10 +0000 (18:53 +0000)]
Now with permalinks.

Once we get a response from our XHR request update the URL to a permalink to that code.

This CL comes after https://codereview.chromium.org/235373002/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/235323006

git-svn-id: http://skia.googlecode.com/svn/trunk@14187 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix broken build
commit-bot@chromium.org [Mon, 14 Apr 2014 18:33:03 +0000 (18:33 +0000)]
fix broken build

change 'char' to 'int8_t'

BUG=skia:

NOTRY=true
TBR=reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/237263004

git-svn-id: http://skia.googlecode.com/svn/trunk@14186 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert of use templates instead of macros to build blitters (https://coderevi...
reed@google.com [Mon, 14 Apr 2014 18:27:18 +0000 (18:27 +0000)]
Revert "Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/120633004/)"

This reverts commit e9d2798fd37e2fb33b545d142a5baa21a4b747fe.

BUG=skia:

Review URL: https://codereview.chromium.org/236303008

git-svn-id: http://skia.googlecode.com/svn/trunk@14185 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: multithreaded loading/diffing of images
commit-bot@chromium.org [Mon, 14 Apr 2014 18:15:29 +0000 (18:15 +0000)]
rebaseline_server: multithreaded loading/diffing of images

BUG=skia:2414
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/235923002

git-svn-id: http://skia.googlecode.com/svn/trunk@14184 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMike R: please sanity check SkPostConfig.h
commit-bot@chromium.org [Mon, 14 Apr 2014 17:08:59 +0000 (17:08 +0000)]
Mike R: please sanity check SkPostConfig.h
Mike K: please sanity check Test.cpp and skia_test.cpp

Feel free to look at the rest, but I don't expect any in depth review of path ops innards.

Path Ops first iteration used QuickSort to order segments radiating from an intersection to compute the winding rule.

This revision uses a circular sort instead. Breaking out the circular sort into its own long-lived structure (SkOpAngle) allows doing less work and provides a home for caching additional sorting data.

The circle sort is more stable than the former sort, has a robust ordering and fewer exceptions. It finds unsortable ordering less often. It is less reliant on the initial curve  tangent, using convex hulls instead whenever it can.

Additional debug validation makes sure that the computed structures are self-consistent. A new visualization tool helps verify that the angle ordering is correct.

The 70+M tests pass with this change on Windows, Mac, Linux 32 and Linux 64 in debug and release.

R=mtklein@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/131103009

git-svn-id: http://skia.googlecode.com/svn/trunk@14183 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd conical special cases to GradientBench
commit-bot@chromium.org [Mon, 14 Apr 2014 16:02:31 +0000 (16:02 +0000)]
Add conical special cases to GradientBench

BUG=skia:
R=reed@google.com, bsalomon@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/234603006

git-svn-id: http://skia.googlecode.com/svn/trunk@14182 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow clients to specify an external SkImageFilter cache.
senorblanco@chromium.org [Mon, 14 Apr 2014 15:51:48 +0000 (15:51 +0000)]
Allow clients to specify an external SkImageFilter cache.

This change allows external callers to substitute their own
SkImageFilter cache for the default intra-frame cache in Skia. This
allows the caller to perform inter-frame caching for example, by the
maintaining a persistent cache between frames and doing custom
invalidation.

R=reed@google.com

Review URL: https://codereview.chromium.org/225903010

git-svn-id: http://skia.googlecode.com/svn/trunk@14181 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of use templates instead of macros to build blitters (https://codereview.chrom...
commit-bot@chromium.org [Mon, 14 Apr 2014 15:45:58 +0000 (15:45 +0000)]
Revert of use templates instead of macros to build blitters (https://codereview.chromium.org/120633004/)

Reason for revert:
Broke build.

Original issue's description:
> use templates instead of macros to build blitters
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=14178

R=mtklein@google.com, reed@google.com
TBR=mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/236593006

git-svn-id: http://skia.googlecode.com/svn/trunk@14180 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove currently unused code
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:50 +0000 (15:02 +0000)]
Remove currently unused code

This code is currently unused and is contrary to the way in which we seem to be moving towards accomplishing this (i.e., device-specific optimization passes).

This is a partial revert of r13704 (First version of bitmap use tracking in SkPictureRecord - https://codereview.chromium.org/187833003/)

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/237013002

git-svn-id: http://skia.googlecode.com/svn/trunk@14179 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse templates instead of macros to build blitters
commit-bot@chromium.org [Mon, 14 Apr 2014 15:02:35 +0000 (15:02 +0000)]
use templates instead of macros to build blitters

BUG=
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/120633004

git-svn-id: http://skia.googlecode.com/svn/trunk@14178 2bbb7eff-a529-9590-31e7-b0007b416f81