Jes Sorensen [Sat, 21 Jun 2014 14:50:19 +0000 (16:50 +0200)]
staging: rtl8723au: issue_probersp(): No need to calculate location of IEs, we know where they are
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:18 +0000 (16:50 +0200)]
staging: rtl8723au: issue_probersp(): Don't insert beacon data twice
In case of AP mode, we were inserting the beacon data twice in the
probe_resp frame, leading to a corrupted on the wire frame.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:17 +0000 (16:50 +0200)]
staging: rtl8723au: rtw_joinbss_update_network23a(): update beacon info as well
We need to copy over the beacon info (interval, capability, tsf) as
well as the IE data.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:16 +0000 (16:50 +0200)]
staging: rtl8723au: rtw_survey_event_cb23a(): Remember to clone beacon data
We need to clone all the beacon information, not just the IE data, in
particular as the long term goal is to stop carrying this information
in the IE data.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:15 +0000 (16:50 +0200)]
staging: rtl8723au: Remove (hopefully) last duplicate define of WLAN_EID_RSN
So much for thinking the removal of the previous 217 duplicate copies
would suffice ....
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:14 +0000 (16:50 +0200)]
staging: rtl8723au: Remove write-only struct security_priv->authenticator_ie
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:13 +0000 (16:50 +0200)]
staging: rtl8723au: Remove unused struct mlme_priv->wfd_* entries
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:12 +0000 (16:50 +0200)]
staging: rtl8723au: Remove obsolete mlme_priv->p2p_* entries
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:11 +0000 (16:50 +0200)]
staging: rtl8723au: Remove unused struct mlme_priv->wps_probe_resp_ie
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:10 +0000 (16:50 +0200)]
staging: rtl8723au: Remove unused mlme_priv->wps_assoc_resp_ie and friends
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 21 Jun 2014 14:50:09 +0000 (16:50 +0200)]
staging: rtl8723au: struct mlme_priv->wps_beacon_ie is never set
Remove all code trying to use it
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:47 +0000 (20:29 +0530)]
staging: rtl8188eu: Move all efuse related code to rtw_efuse.c
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:46 +0000 (20:29 +0530)]
staging: rtl8188eu: rtw_efuse.c: Remove unnecessary comments
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:45 +0000 (20:29 +0530)]
staging: rtl8188eu: rtw_efuse.c: Remove unused local variables
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:44 +0000 (20:29 +0530)]
staging: rtl8188eu: rtw_efuse.c: Remove unused global variables
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:43 +0000 (20:29 +0530)]
staging: rtl8188eu: hal_EfusePartialWriteCheck(): Remove bluetooth specific code
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:42 +0000 (20:29 +0530)]
staging: rtl8188eu: rtl8188e_hal_init.c: Remove forward declarations
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:41 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove bool bPseudoTest parameter from efuse functions
In most of the functions bPseudoTest is not used and in remaining ones
it's always false.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:40 +0000 (20:29 +0530)]
staging: rtl8188eu: hal_EfuseCheckIfDatafollowed(): Remove unused parameter
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:39 +0000 (20:29 +0530)]
staging: rtl8188eu: Efuse_WordEnableDataWrite(): Remove unused parameter test
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:38 +0000 (20:29 +0530)]
staging: rtl8188eu: EFUSE_ShadowMapUpdate():Remove unused parameter bool test
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:37 +0000 (20:29 +0530)]
staging: rtl8188eu: Efuse_ReadAllMap(): Remove unused parameter bool test
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:36 +0000 (20:29 +0530)]
staging: rtl8188eu: Efuse_GetCurrentSize(): Remove parameter bool test
test is always false.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:35 +0000 (20:29 +0530)]
staging: rtl8188eu: efuse_ReadEFuse(): Remove parameter bool bPseudoTest
bPseudoTest is always false.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:34 +0000 (20:29 +0530)]
staging: rtl8188eu: efuse_OneByteWrite(): Remove unused parameter bool test
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:33 +0000 (20:29 +0530)]
staging: rtl8188eu: efuse_OneByteRead():Remove unused parameter bool test
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:32 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove unused function EFUSE_Read1Byte()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:31 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove unused function ReadEFuseByte()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:30 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove function rtw_BT_efuse_map_read()
rtl8188eu is not a wifi/bluetooth combo device, so remove bluetooth
related code.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:29 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove unused function Efuse_PgPacketWrite_BT()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:28 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove function rtw_BT_efuse_map_write()
rtl8188eu is not a wifi/bluetooth combo device, so remove bluetooth
related code.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:27 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove function Efuse_Read1ByteFromFakeContent()
Efuse_Read1ByteFromFakeContent() is never called because pseudo
is always false in Efuse_CalculateWordCnts() and efuse_OneByteRead().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:26 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove function Efuse_Write1ByteToFakeContent()
Efuse_Write1ByteToFakeContent() is used only in efuse_OneByteWrite(),
when pseudo is true, but pseudo is always false.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:25 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename hal_EfusePgPacketWrite_8188e()
Rename hal_EfusePgPacketWrite_8188e() to Efuse_PgPacketWrite()
and remove original Efuse_PgPacketWrite() function,
so that driver can call hal_EfusePgPacketWrite_8188e() directly
without going through Efuse_PgPacketWrite().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:24 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename hal_EfusePgPacketRead_8188e() to Efuse_PgPacketRead()
Rename hal_EfusePgPacketRead_8188e() to Efuse_PgPacketRead()
and remove original EFUSE_GetEfuseDefinition() function,
so that driver can call hal_EfusePgPacketRead_8188e() directly
without going through Efuse_PgPacketRead().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:23 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename function ReadEFuseByIC() to efuse_ReadEFuse()
Rename ReadEFuseByIC() to efuse_ReadEFuse() and remove original
efuse_ReadEFuse() function, so that driver can call ReadEFuseByIC()
directly without going through efuse_ReadEFuse().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:22 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove function Hal_EfuseReadEFuse88E()
Hal_EfuseReadEFuse88E() is called in ReadEFuseByIC(), when bPseudoTest is true
but it's always false.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:21 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename function Hal_EfuseWordEnableDataWrite()
Rename Hal_EfuseWordEnableDataWrite() to Efuse_WordEnableDataWrite()
and remove original EFUSE_GetEfuseDefinition() function,
so that driver can call Hal_EfuseWordEnableDataWrite() directly
without going through Efuse_WordEnableDataWrite().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:20 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename rtl8188e_EfusePowerSwitch() to Efuse_PowerSwitch()
Rename rtl8188e_EfusePowerSwitch() to Efuse_PowerSwitch()
and remove original Efuse_PowerSwitch() function,
so that driver can call rtl8188e_EfusePowerSwitch() directly
without going through Efuse_PowerSwitch().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:19 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename hal_EfuseGetCurrentSize_8188e()
Rename hal_EfuseGetCurrentSize_8188e() to Efuse_GetCurrentSize()
and remove original Efuse_GetCurrentSize() function,
so that driver can call hal_EfuseGetCurrentSize_8188e() directly
without going through Efuse_GetCurrentSize().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:18 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename rtl8188e_EFUSE_GetEfuseDefinition()
Rename rtl8188e_EFUSE_GetEfuseDefinition() to EFUSE_GetEfuseDefinition()
and remove original EFUSE_GetEfuseDefinition() function,
so that driver can call rtl8188e_EFUSE_GetEfuseDefinition() directly
without going through EFUSE_GetEfuseDefinition().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:17 +0000 (20:29 +0530)]
staging: rtl8188eu: rtw_efuse.c: Remove unnecessary function declaration
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:16 +0000 (20:29 +0530)]
staging:rtl8188eu: Assign rtl8188e_Efuse_WordEnableDataWrite() to ->Efuse_WordEnableDataWrite
Assign rtl8188e_Efuse_WordEnableDataWrite() to ->Efuse_WordEnableDataWrite
instead of going through many functions.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:15 +0000 (20:29 +0530)]
staging:rtl8188eu:assign hal_EfusePgPacketWrite_8188e() to ->Efuse_PgPacketWrite
assign hal_EfusePgPacketWrite_8188e() to ->Efuse_PgPacketWrite directly
instead of going through many functions.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:14 +0000 (20:29 +0530)]
staging: rtl8188eu: assign hal_EfusePgPacketRead_8188e() to ->Efuse_PgPacketRead
assign hal_EfusePgPacketRead_8188e() to ->Efuse_PgPacketRead directly
instead of going through many functions.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:13 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename Hal_EFUSEGetEfuseDefinition88E()
Rename Hal_EFUSEGetEfuseDefinition88E() to rtl8188e_EFUSE_GetEfuseDefinition()
and remove original rtl8188e_EFUSE_GetEfuseDefinition(), so that driver can call
Hal_EFUSEGetEfuseDefinition88E() directly without going through
rtl8188e_EFUSE_GetEfuseDefinition().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:12 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove function Hal_EFUSEGetEfuseDefinition_Pseudo88E()
Definition of Hal_EFUSEGetEfuseDefinition_Pseudo88E() is identical
to Hal_EFUSEGetEfuseDefinition88E().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:11 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove unused function Hal_EfuseGetCurrentSize_Pseudo()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:10 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove rtl8188e_EfuseGetCurrentSize()
rtl8188e_EfuseGetCurrentSize() checks bool bPseudoTest and then calls suitable
function to get efuse size, hal_EfuseGetCurrentSize_8188e() also does same thing.
So use hal_EfuseGetCurrentSize_8188e() and drop rtl8188e_EfuseGetCurrentSize().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:09 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove unused function ReadEFuse_Pseudo()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:08 +0000 (20:29 +0530)]
staging: rtl8188eu: Remove rtl8188e_ReadEFuse()
rtl8188e_ReadEFuse() checks bool bPseudoTest and then calls suitable
function to read Fuse, ReadEFuseByIC() also does same thing.
So use ReadEFuseByIC() and drop rtl8188e_ReadEFuse().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 20 Jun 2014 14:59:07 +0000 (20:29 +0530)]
staging: rtl8188eu: Rename hal_EfusePowerSwitch_RTL8188E()
Rename hal_EfusePowerSwitch_RTL8188E() to rtl8188e_EfusePowerSwitch() and
remove original rtl8188e_EfusePowerSwitch(), so that driver can call
hal_EfusePowerSwitch_RTL8188E() directly without going through
rtl8188e_EfusePowerSwitch().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:38:04 +0000 (17:38 +0200)]
Staging: bcm: Qos.c: fix checkpatch errors: whitespaces
This patch improves coding style in Qos.c
Whitespaces according to the coding guideline
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:38:03 +0000 (17:38 +0200)]
Staging: bcm: Qos.c: fix checkpatch errors: comments
This patch improves coding style in Qos.c
Comments according to the coding guideline
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:38:02 +0000 (17:38 +0200)]
Staging: bcm: Queue.h: fix checkpatch errors: whitespaces
This patch improves coding style in Queue.h
Whitespaces according to the coding guideline
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:38:01 +0000 (17:38 +0200)]
Staging: bcm: Queue.h: fix checkpatch errors: brackets
This patch improves coding style in Queue.h:
Brackets according to the coding guideline
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:38:00 +0000 (17:38 +0200)]
Staging: bcm: Queue.h: fix checkpatch errors: comments
This patch improves coding style in Queue.h
Comments according to the coding guideline
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:37:59 +0000 (17:37 +0200)]
Staging: bcm: Prototypes.h: fix checkpatch errors: whitespaces
This patch improves coding style in Prototypes.h:
Whitespaces according to the coding guideline
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Martin Gumbrecht [Fri, 20 Jun 2014 15:37:58 +0000 (17:37 +0200)]
Staging: bcm: Prototypes.h: fix checkpatch errors: blank lines
This patch improves coding style in Prototypes.h:
Exactly one blank line after each declaration
Signed-off-by: Martin Gumbrecht <martin.gumbrecht@googlemail.com>
Signed-off-by: Christian Bay <christian.bay@studium.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Fri, 20 Jun 2014 13:15:04 +0000 (14:15 +0100)]
staging: comedi: describe struct comedi_async
Describe `struct comedi_async` in kerneldoc format. Expand on the
members involved in reading/writing the buffer.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vincent Heuken [Fri, 20 Jun 2014 13:08:07 +0000 (06:08 -0700)]
Staging: serqt_usb2: fixed blank line style warning in serqt_usb2.c
This is a patch to the serqt_usb2.c file that fixes the following
warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Vincent Heuken <me@vincentheuken.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arnd Bergmann [Fri, 20 Jun 2014 12:23:28 +0000 (14:23 +0200)]
staging/lustre: disable virtual block device for 64K pages
The lustre virtual block device cannot handle 64K pages and fails at compile
time. To avoid running into this error, let's disable the Kconfig option
for this driver in cases it doesn't support.
Reported-by: Dann Frazier <dann.frazier@canonical.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Toralf Förster [Fri, 20 Jun 2014 14:14:37 +0000 (16:14 +0200)]
v2 staging: translates 3 comments into english in HalBtc8812a1Ant.c
Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fred Brooks [Fri, 20 Jun 2014 11:53:15 +0000 (12:53 +0100)]
staging: comedi: ni_daq_700: add AI range and input mode switching
Add support for switching the input range and the single-ended/
differential input mode for the AI subdevice. We needed to clear the
FIFO of data before the conversion to handle card mode switching
glitches.
[ Minor whitespace fixes and driver comment reformatting. - Ian ]
Signed-off-by: Fred Brooks <frederick.brooks@microchip.com>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 20 Jun 2014 09:21:50 +0000 (18:21 +0900)]
staging: dgap: make dgap_found_board() return a brd pointer
Make dgap_found_board() return a brd pointer and that brd pointer
assign to dgap_board[] in the end of the dgap_init_one().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Evgeny Budilovsky [Fri, 20 Jun 2014 08:22:14 +0000 (11:22 +0300)]
staging/cptm1217: fix checkpatch warnings about else clause
Signed-off-by: Evgeny Budilovsky <budevg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pramod Gurav [Fri, 20 Jun 2014 08:43:59 +0000 (14:13 +0530)]
staging: alarm-dev: Set the license to GPL
Adding "GPL" license to fix a warning while compiling as
module.
CC: Brian Swetland <swetland@google.com>
Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Fri, 20 Jun 2014 14:49:59 +0000 (17:49 +0300)]
staging: crystalhd: remove driver
The driver hasn't had significant work done on it for a long time.
Broadcom has EOLed the hardware and is no longer selling it. There are
probably very few people still using it. So remove the driver.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Cc: Naren Sankar <nsankar@broadcom.com>
Cc: Jarod Wilson <jarod@wilsonet.com>
Cc: Scott Davilla <davilla@4pi.com>
Cc: Manu Abraham <abraham.manu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heesub Shin [Fri, 20 Jun 2014 02:46:14 +0000 (11:46 +0900)]
staging: ion: fixup invalid kfree() calls on heap destroy
I've noticed that the last commit to ion_system_heap.c ('staging: ion:
optimize struct ion_system_heap') has an omission, so an invalid kfree()
gets called on ion_system_heap_destroy(). As ION system heap is never
destroyed until system shutdown, it may not cause any harm, but should
be fixed. I should have caught this before the merge, my bad.
Signed-off-by: Heesub Shin <heesub.shin@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pramod Gurav [Fri, 13 Jun 2014 06:19:43 +0000 (11:49 +0530)]
staging: alarm-dev: Support to Compile as Module
Currently this alarm-dev can be compiles only as built in
driver. This adds support to compile it as module as well which is in
planned activity (See drivers/staging/android/TODO)
CC: Brian Swetland <swetland@google.com>
Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pramod Gurav [Fri, 13 Jun 2014 06:19:42 +0000 (11:49 +0530)]
alarmtimer: Export symbols of alarmtimer_get_rtcdev
Export symbol of alarmtimer_get_rtcdev so that it is used by
any driver when built as module like,
drivers/staging/android/alarm-dev.c.
CC: John Stultz <john.stultz@linaro.org>
CC: Marcus Gelderie <redmnic@gmail.com>
Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johannes Stadlinger [Thu, 19 Jun 2014 19:20:20 +0000 (21:20 +0200)]
wlan-ng/prism2sta:checkpatch: Insert blank lines
This patch inserts blank lines after declarations to avoid checkpatch
warnings.
After our fixes in 'wlan-ng/prism2sta' there is still a checkpatch
warning about prefering 'ether_addr_copy' instead of 'memcpy'
remaining.
Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
CC: linux-kernel@i4.cs.fau.de
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
CC: Tugce Sirin <ztugcesirin@gmail.com>
CC: Himangi Saraogi <himangi774@gmail.com>
CC: Paul Gortmaker <paul.gortmaker@windriver.com>
CC: Vitaly Osipov <vitaly.osipov@gmail.com>
CC: Neil Armstrong <superna9999@gmail.com>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johannes Stadlinger [Thu, 19 Jun 2014 19:20:19 +0000 (21:20 +0200)]
wlan-ng/prism2sta:checkpatch: Fix string split
This patch fixes a warning of checkpatch about string splitting.
Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
CC: linux-kernel@i4.cs.fau.de
CC: Tugce Sirin <ztugcesirin@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
CC: Vitaly Osipov <vitaly.osipov@gmail.com>
CC: Neil Armstrong <superna9999@gmail.com>
CC: Paul Gortmaker <paul.gortmaker@windriver.com>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johannes Stadlinger [Thu, 19 Jun 2014 19:20:16 +0000 (21:20 +0200)]
wlan-ng/prism2mib:checkpatch: Fix string split
This patch fixes a warning of checkpatch about string splitting.
Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
CC: linux-kernel@i4.cs.fau.de
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
CC: Vitaly Osipov <vitaly.osipov@gmail.com>
CC: Himangi Saraogi <himangi774@gmail.com>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johannes Stadlinger [Thu, 19 Jun 2014 19:20:15 +0000 (21:20 +0200)]
wlan-ng/prism2mgmt:checkpatch: Insert blank line
This patch inserts a blank line after a declaration to avoid checkpatch
warning.
Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
CC: linux-kernel@i4.cs.fau.de
Meh-by: Josh Triplett <josh@joshtriplett.org>
CC: Himangi Saraogi <himangi774@gmail.com>
CC: Vitaly Osipov <vitaly.osipov@gmail.com>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johannes Stadlinger [Thu, 19 Jun 2014 19:20:14 +0000 (21:20 +0200)]
wlan-ng/prism2mgmt:checkpatch: Fix string split
This patch fixes all warnings of checkpatch about string splitting.
Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
CC: linux-kernel@i4.cs.fau.de
CC: Himangi Saraogi <himangi774@gmail.com>
CC: Vitaly Osipov <vitaly.osipov@gmail.com>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johannes Stadlinger [Thu, 19 Jun 2014 19:20:13 +0000 (21:20 +0200)]
wlan-ng/prism2mgmt:checkpatch: Fix long lines
This patch fixes all warnings of checkpatch about lines over 80
characters.
Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
CC: linux-kernel@i4.cs.fau.de
CC: Himangi Saraogi <himangi774@gmail.com>
CC: Vitaly Osipov <vitaly.osipov@gmail.com>
CC: devel@driverdev.osuosl.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephan Gabert [Mon, 16 Jun 2014 14:50:53 +0000 (16:50 +0200)]
staging/wlags49_h2: checkpatch: line over 80 characters
Signed-off-by: Stephan Gabert <stephan.gabert@fau.de>
Signed-off-by: Nicolas Pfeiffer <nicolas.pfeiffer@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephan Gabert [Mon, 16 Jun 2014 14:50:50 +0000 (16:50 +0200)]
staging/wlags49_h2: checkpatch: added spaces around equal sign
Hereby the checkpatch message
ERROR: spaces required around that '=' (ctx:VxV)
gets resolved
and the neighboring equal signs are positioned in the same column.
Signed-off-by: Stephan Gabert <stephan.gabert@fau.de>
Signed-off-by: Nicolas Pfeiffer <nicolas.pfeiffer@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stephan Gabert [Mon, 16 Jun 2014 14:50:49 +0000 (16:50 +0200)]
staging/wlags49_h2: checkpatch: including <linux/*.h> instead of <asm/*.h>
As warned by checkpatch.pl, one should use #include <linux/io.h>
instead of #include <asm/io.h> and #include <linux/bitops.h>
instead of #include <asm/bitops.h>.
Signed-off-by: Stephan Gabert <stephan.gabert@fau.de>
Signed-off-by: Nicolas Pfeiffer <nicolas.pfeiffer@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 16:01:48 +0000 (02:01 +1000)]
staging: lustre: ldlm: ldlm_lib.c removed unecessary space after function name
- this fixes "WARNING: space prohibited between function name and open
parenthesis '("
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 16:01:47 +0000 (02:01 +1000)]
staging: lustre: lustre: ldlm: ldlm_lib.c - removed unnecessary braces
- this change fixes "WARNING: braces {} are not necessary for single
statement blocks"
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 11:50:42 +0000 (21:50 +1000)]
staging: lustre: lustre: fld: lproc_fld.c fixed warning
fixed warning "WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable"
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 11:50:41 +0000 (21:50 +1000)]
staging: lustre: lustre: fld: lproc_fld.c fixed warning
fixed warning for line over 80 characters by moving the struct init
onto a diff line.
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 15:02:08 +0000 (01:02 +1000)]
staging: lustre: ldlm: ldlm_resource.c replace obsolete function with kstrtoul()
- this change fixes the warning "WARNING: simple_strtoul is obsolete, use
kstrtoul instead"
- removed the unused var 'end' as this is no longer required for
kstrtoul()
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 15:35:48 +0000 (01:35 +1000)]
staging: lustre: ldlm: ldlm_resource.c removed unecessary braces
- this fixed the "WARNING: braces {} are not necessary for
single statement blocks"
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anil Belur [Thu, 19 Jun 2014 07:29:01 +0000 (17:29 +1000)]
staging : lustre : lustre : fid : lproc_fid.c: fixed warning
fixed warning for line over 80 characters by moving the initilation
onto a diff line.
Signed-off-by: Anil Belur <askb23@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Skvortsov [Thu, 19 Jun 2014 07:24:13 +0000 (11:24 +0400)]
staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces coding style issue
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Skvortsov [Thu, 19 Jun 2014 07:24:12 +0000 (11:24 +0400)]
staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Skvortsov [Thu, 19 Jun 2014 07:24:11 +0000 (11:24 +0400)]
staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Paul Bolle [Wed, 18 Jun 2014 15:05:47 +0000 (17:05 +0200)]
staging: Remove useless "default N" lines
Two Kconfig entries default to (uppercase) "N". It was clearly intended
to use "default n". But since (lowercase) "n" is the default anyway,
these lines might as well be removed.
Reported-by: Martin Walch <walch.martin@web.de>
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benedict Boerger [Thu, 19 Jun 2014 18:18:51 +0000 (20:18 +0200)]
staging: sep: Fix checkpatch.pl warnings
Fix checkpatch.pl warnings:
Missing blank line after Declarations
Signed-off-by: Benedict Boerger <benedict.boerger@cs.tu-dortmund.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Adithya Krishnamurthy [Thu, 19 Jun 2014 03:48:00 +0000 (09:18 +0530)]
Staging:tidspbridge Fix minor checkpatch.pl warning
Fixed checkpatch "WARNING: Missing a blank line after declarations"
Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wolfgang Ocker [Sun, 15 Jun 2014 11:03:29 +0000 (13:03 +0200)]
staging cxt1e1: refactored ring buffer dump functions to avoid sparse warnings
Sparse spit out these warnings:
drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block
drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for basic block
The new functions musycc_dump_[rt]xbuffer_ring_locked() assume that the lock is
held. musycc_dump_[rt]xbuffer_ring() take the lock.
Signed-off-by: Wolfgang Ocker <weo@weo1.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sat, 14 Jun 2014 22:56:32 +0000 (00:56 +0200)]
staging: ced1401: userspace: use1401.c: Cleaning up if statement that always evaluates to true
Unsigned variable can't be negative so it is unnecessary to test it.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
A Raghavendra Rao [Wed, 11 Jun 2014 04:58:58 +0000 (10:28 +0530)]
Staging: rtl8192e: dot11d: Fixed printk coding style issues
Replaced 'printk' with 'netdev_' function
Signed-off-by: A Raghavendra Rao <arrao@cdac.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kees Cook [Tue, 10 Jun 2014 18:10:03 +0000 (11:10 -0700)]
staging: r8192ee: avoid leaking format string
This makes sure a format string cannot leak into the work queue name nor
the printk buffer.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 17 Jun 2014 14:59:20 +0000 (23:59 +0900)]
staging: unisys: Remove trailing semicolon from macro
This patch removed trailing semicolon from macro in guestlinuxdebug.h
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robin Schroer [Thu, 12 Jun 2014 23:17:30 +0000 (01:17 +0200)]
drivers/staging/speakup/main: fixed jiffie comparison
speakup_key() used manual comparison of jiffies to determine the time
since the last keypress, replaced it with time_after()
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Khoroshilov [Tue, 10 Jun 2014 20:22:50 +0000 (00:22 +0400)]
staging: line6: do not return 0 from probe if no initialization done
There is a strange "return 0" in line6_probe() before any initialization of
the module is done. It can lead to NULL pointer dereference in other functions.
The patch proposes to return -ENODEV in this case.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-starfive.git / log