Peter Meerwald [Thu, 20 Feb 2014 20:41:47 +0000 (21:41 +0100)]
doc: Assorted spelling and grammar fixes for doxygen output
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Fri, 3 Jan 2014 22:52:19 +0000 (23:52 +0100)]
modules: Fix uninitialized variable in rtp-send
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Koop Mast [Thu, 20 Feb 2014 23:21:46 +0000 (00:21 +0100)]
sconv, svolume: Fix compilation on 32-bit FreeBSD
Don't try to compile this code on 32-bit FreeBSD, it will error out complain
about registers only being available in 64-bit mode.
Arun Raghavan [Mon, 17 Feb 2014 11:02:40 +0000 (16:32 +0530)]
Revert "protocol-native: Don't enumerate unlinked sinks and sources"
This reverts commit
bd0bd9143f8159e5475b1295e30ec026ff0b6fef.
Arun Raghavan [Sat, 15 Feb 2014 04:34:39 +0000 (10:04 +0530)]
build-sys: Bump soname
Bumping from 0->3 since we missed bumping correctly for v4.99.{1,2,3}
Arun Raghavan [Sun, 8 Dec 2013 22:18:00 +0000 (14:18 -0800)]
protocol-native: Don't enumerate unlinked sinks and sources
This makes sure that there is no window between pa_sink/source_new()
and _put() where enumerating sinks/sources causes an assert (several
calls in sink/source_get_info need a linked sink or source).
Tanu Kaskinen [Wed, 12 Feb 2014 10:41:34 +0000 (12:41 +0200)]
sink-input, source-output: Don't crash if format negotiation fails
A segfault was reported on this line:
pa_return_val_if_fail(PA_SINK_IS_LINKED(pa_sink_get_state(data->sink)), -PA_ERR_BADSTATE);
After expanding the pa_sink_get_state() macro, the line looks like
this:
pa_return_val_if_fail(PA_SINK_IS_LINKED(data->sink->state), -PA_ERR_BADSTATE);
So data->sink was apparently NULL. That could happen if we try to fall
back to the default sink, but format negotiation fails.
This bug was introduced in commit
71816ecb7f81fe7a124cefa2258cfa64046908a1.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=74646
Piotr Drąg [Tue, 11 Feb 2014 14:18:08 +0000 (15:18 +0100)]
i18n: Update Polish translation
Tanu Kaskinen [Wed, 12 Feb 2014 12:31:26 +0000 (14:31 +0200)]
man: pulse-cli-syntax: Document the "journal" log target
Juho Hämäläinen [Mon, 10 Feb 2014 10:46:28 +0000 (12:46 +0200)]
dbus: Use correct idxset when getting sources
This fixes get_sources() which iterates wrong idxset when
getting source object paths in GetSources or GetAll.
Wim Taymans [Thu, 6 Feb 2014 15:08:50 +0000 (16:08 +0100)]
man: improve man page and help for cmdline options
Tanu Kaskinen [Wed, 5 Feb 2014 15:55:44 +0000 (17:55 +0200)]
source: Increase max outputs per source
This change is just for being symmetric with sinks, which got this
change in
26bf2df903b1c7439ad3eef0dc3bb1e777835cc3.
Tanu Kaskinen [Tue, 4 Feb 2014 19:28:44 +0000 (21:28 +0200)]
protocol-native: Fix a crash
Without this check pa_source_output_set_volume() crashes if
so->volume_writable is false. The same check already exists for sink
inputs.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=74529
Tanu Kaskinen [Sun, 26 Jan 2014 17:11:07 +0000 (19:11 +0200)]
thread-win32: Implement pa_thread_free_nojoin()
This fixes a build error with mingw32:
pulsecore/.libs/libpulsecommon_4.99_la-lock-autospawn.o: In function `unref':
/home/abuild/rpmbuild/BUILD/pulseaudio-4.99.2/src/pulsecore/lock-autospawn.c:123: undefined reference to `pa_thread_free_nojoin'
collect2: error: ld returned 1 exit status
pa_thread_free_nojoin() was initially only implemented for the pthread
based pa_thread backend, because it was incorrectly assumed that
autospawning (the only user of pa_thread_free_nojoin()) is not used on
Windows.
Reported-By: Michael DePaulo <mikedep333@gmail.com>
Tanu Kaskinen [Wed, 29 Jan 2014 18:54:39 +0000 (20:54 +0200)]
card-restore: Fix a memory leak
entry_read() may set entry->profile, so we need to free that string
before we can replace it with a new string.
Peter Meerwald [Mon, 2 Dec 2013 16:27:01 +0000 (17:27 +0100)]
resampler: Resample first followed by remapping if have more out channels than in channels
Reintroduces a cleaned-up version of commit
30ce3a14e5ae1cd316a18bec95b831c07ac57a1a which
was reverted by
1ce71cbd8206d1be59ac62274ad83cdbe693a96a; for more information see
http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/17479/focus=17487
The patch intends to reduce computational load when resampling AND remapping. The PA
resampler performs the following steps:
sample format conversion -> remapping -> resampling -> sample format conversion
In case the number of output channels is higher than the number of input channels, the
resampler has to be run more often than necessary. E.g. in case of mono to 4-channel remapping,
the resampler runs on 4 channels separately.
To ímprove this, the PA resampler pipeline is made adaptive:
if out-channels <= in-channels:
sample format conversion -> remapping -> resampling -> sample format conversion
if out-channels > in-channels:
sample format conversion -> resampling -> remapping -> sample format conversion
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Peter Meerwald [Mon, 2 Dec 2013 16:27:00 +0000 (17:27 +0100)]
resampler: Implement leftover handling in convert_to_work_format()
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 2 Dec 2013 16:26:59 +0000 (17:26 +0100)]
resampler: Extend fit_buf() helper to copy leftover data to new buffer
the patch changes the interface of the (internal) fit_buf() function:
fit_buf() manages the memblock of the buf chunk, it reallocates the memblock
if the requested number of bytes ('len') if larger than the memblock's size ('size')
and optionally preserves 'copy' bytes
the code should be in line with the comment now
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Tanu Kaskinen [Mon, 27 Jan 2014 19:00:58 +0000 (21:00 +0200)]
module: Replace rindex() with strrchr()
rindex() appears to be "non-standard" to an extent, and it caused a
build failure on mingw32.
From the man page of rindex(): "POSIX.1-2008 removes the
specifications of index() and rindex(), recommending strchr(3) and
strrchr(3) instead."
Tanu Kaskinen [Sun, 26 Jan 2014 18:13:50 +0000 (20:13 +0200)]
device-manager: Don't try to use unlinked devices
This fixes an assertion crash:
[pulseaudio] source.c: Assertion 'PA_SOURCE_IS_LINKED(s->state)' failed at pulsecore/source.c:734, function pa_source_update_status(). Aborting.
The crash happened when a Bluetooth headset profile was changed from
a2dp to hsp. During the profile change three devices are created:
a sink, a monitor source for the sink, and a regular source. First
pa_sink/source_new() are called for each device, and that puts the
devices to u->core->sinks/sources. Then, pa_sink_put() is called for
the sink, and that in turn calls pa_source_put() for the source. At
that point module-device-manager decides to reroute all source
outputs. The non-monitor source that the Bluetooth card created hasn't
been linked yet at this stage, because it will only be linked after
the sink and the monitor source have been linked. So,
module-device-manager should take into account during the rerouting
that not all sinks and sources are necessarily linked. This patch does
that.
Reported-By: Iskren Hadzhinedev <i.hadzhinedev@gmail.com>
Tanu Kaskinen [Sun, 26 Jan 2014 14:41:29 +0000 (16:41 +0200)]
caps: Don't require --without-caps on FreeBSD
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=72580
Wim Taymans [Thu, 23 Jan 2014 11:21:53 +0000 (12:21 +0100)]
daemon: Remove deprecated Encoding from .desktop files
Encoding is deprecated according to
http://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
Dominique Leuenberger [Fri, 24 Jan 2014 20:45:52 +0000 (21:45 +0100)]
build-sys: Move ORC_SOURCE definitions outside of "if HAVE_ORC"
Not having ORC_SOURCE defined results in different tarballs depending on
whether the dev issuing 'make dist' has orc support enabled or disabled.
Specifying ORC_SOURCE unconditionally addresses that, without causing
negative effects on users not having orc in the end.
Tanu Kaskinen [Thu, 23 Jan 2014 18:34:58 +0000 (20:34 +0200)]
build-sys: Add tests/runtime-test-util.h to the tarball
The file is used by three test binaries, but none of them mentioned
it in Makefile.am, which caused the file to be left out of the
tarball.
Tanu Kaskinen [Thu, 23 Jan 2014 10:05:52 +0000 (12:05 +0200)]
build-sys: Bump sonames
The bigger than usual bump in libpulse-simple was warranted by the
change in pa_simple_flush() that allows also record streams to be
flushed. There are no changes to the function signature, but it's in
practice a change in the ABI anyway, because new clients using the new
possibility won't work with older versions of the library.
libpulse-mainloop-glib got a bug fix in commit
68156d3f79b67c77f88050e6c9de180698377c64.
Tanu Kaskinen [Thu, 23 Jan 2014 09:21:58 +0000 (11:21 +0200)]
introspect, thread-mainloop: Fix Doxygen "since" tags
Daniel Albers [Thu, 16 Jan 2014 09:00:42 +0000 (10:00 +0100)]
combine-sink: fix segfault
Alexander Potashev [Sat, 11 Jan 2014 16:27:18 +0000 (20:27 +0400)]
Update Russian translation
Translated in sync with the guidelines at http://l10n.lrn.ru/wiki/Pulseaudio
Yuri Chornoivan [Mon, 13 Jan 2014 16:53:46 +0000 (18:53 +0200)]
Update Ukrainian translation
Tanu Kaskinen [Wed, 15 Jan 2014 16:59:18 +0000 (18:59 +0200)]
sink, source: Remove useless attach/detach stuff
The removed stuff wasn't used anywhere.
Tanu Kaskinen [Wed, 15 Jan 2014 12:24:25 +0000 (14:24 +0200)]
Revert "ladspa-sink: Handle empty chunks in sink_input_pop_cb"
This reverts commit
dbe66b0b5e6b6e24df45bda8bf656836f18e7f4b.
I accidentally pushed this patch that was superseded by
e96785c1c34706e902f28c25844f31d8201db2b2.
Ben Brewer [Wed, 15 Jan 2014 11:19:46 +0000 (11:19 +0000)]
ladspa-sink: Set a silence memchunk for the memblockq
A crash was observed that was caused by pa_memblockq_peek() returning
a NULL memblock in sink_input_pop_cb(). The scenario where this was
happening was
1. Delete 2 rtp-recv's connected to a ladspa-sink
2. Delete ladspa-sink
3. Delete alsa-sink
4. Create alsa-sink
5. Create ladspa-sink
6. Create 2 rtp-recv's connected to the ladspa-sink
The crash was probably caused by a rewind that made the read index go
negative while the write index was at least zero, causing there to be
a gap in the memblockq. The problematic rewind might have been caused
by adding the rtp-recv stream to the ladspa-sink. That has not been
proven, but this looks very similar to the bug that was fixed in
module-virtual-sink in commit
6bd34156b130c07b130de10111a12ef6dab18b52.
Ben Brewer [Wed, 15 Jan 2014 10:30:36 +0000 (10:30 +0000)]
ladspa-sink: Handle empty chunks in sink_input_pop_cb
Héctor Martín [Wed, 15 Jan 2014 10:20:27 +0000 (12:20 +0200)]
zeroconf-discover: Specify the interface when connecting to a link-local IPv6 address
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=40785
Tanu Kaskinen [Wed, 15 Jan 2014 09:37:26 +0000 (11:37 +0200)]
alsa: Mute "Bass Speaker" when using headphones or lineout
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=73604
Ben Brewer [Tue, 14 Jan 2014 12:26:47 +0000 (12:26 +0000)]
rtp-send: Remove "don't inhibit auto-suspend" flag
A source is no longer considered idle in pa_source_check_suspend when
module-rtp-send is consuming data from it.
Tanu Kaskinen [Sat, 11 Jan 2014 14:47:56 +0000 (16:47 +0200)]
build-sys: Fix building with --as-needed
pulsecore/core-format.c was recently added to libpulsecommon, and
core-format.c depends on functions in libpulse, which libpulsecommon
doesn't link to. That broke building with --as-needed. This patch adds
pulse/format.c to libpulsecommon, so that core-format.c doesn't need
to depend on libpulse any more. format.c pulls in also the dependency
to json-c.
Reported-By: Jan Steffens <jan.steffens@gmail.com>
Laurentiu Nicola [Tue, 7 Jan 2014 18:26:50 +0000 (20:26 +0200)]
rtp-recv: Only try adding the group membership for multicast addresses
Tanu Kaskinen [Fri, 10 Jan 2014 10:41:00 +0000 (12:41 +0200)]
caps: Use standard macro when checking for Linux
linux and __linux are non-standard, according to
http://sourceforge.net/p/predef/wiki/OperatingSystems/
Reported-By: Damir Jelić <poljarinho@gmail.com>
Peter Meerwald [Fri, 3 Jan 2014 22:21:26 +0000 (23:21 +0100)]
alsa-card: Don't free the modargs in pa__init
The modargs are in both cases (a succesfull as well as a failed module
initialization) freed already in pa__done().
To avoid leaking modargs memory before they are assigned to u->modargs, the
code is reorganized to first allocate userdata, and then allocate the modargs.
Local variable ma is not needed anymore.
discussion here
http://lists.freedesktop.org/archives/pulseaudio-discuss/2013-December/019661.html
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Reported-by: poljar (Damir Jelić) <poljarinho@gmail.com>
Tanu Kaskinen [Wed, 18 Dec 2013 16:28:55 +0000 (18:28 +0200)]
format: Add some error logging
Tanu Kaskinen [Wed, 4 Dec 2013 04:18:42 +0000 (06:18 +0200)]
stream: Mention pa_stream_new_extended() in the high-level stream creation documentation
Tanu Kaskinen [Tue, 17 Dec 2013 21:42:09 +0000 (23:42 +0200)]
stream: Improve pa_stream_connect_playback() documentation
Tanu Kaskinen [Wed, 4 Dec 2013 04:17:11 +0000 (06:17 +0200)]
def, format: Document how to leave PCM parameters to be decided by the server
Tanu Kaskinen [Wed, 4 Dec 2013 04:09:23 +0000 (06:09 +0200)]
sink-input, source-output: Interpret missing PCM parameters in format info as a request to decide those parameters at the server end
The "fix flags" (PA_SINK_INPUT_FIX_FORMAT etc.) don't work properly
with the pa_stream_new_extended() interface. This patch fixes it so
that the same effect can be achieved by leaving some of the PCM
parameters unspecified in format info objects. Also, when converting
a sample spec to a format info when using the old pa_stream_new()
interface, the "fix flags" are taken into account in that conversion.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=68952
Tanu Kaskinen [Tue, 17 Dec 2013 19:22:50 +0000 (21:22 +0200)]
stream: Remove a volume channel validity check
The check is done for clients that use pa_stream_new() but not for
clients that use pa_stream_new_extended(). This is inconsistent. We
could check that the volume channels match the channels set in the
format info struct that is passed to pa_stream_new_extended(), but
that doesn't work if the format info doesn't contain the channel
information (that can happen if the client wants the server to choose
the channel count for the stream). And it should also be possible to
pass a mono volume for a multi-channel stream. The check could be
extended to handle all these cases, but I don't see much point in
wasting time on that. The server will anyway validate the stream
parameters, it's not particularly important to fail already when the
stream is being created at the client side.
Tanu Kaskinen [Tue, 17 Dec 2013 19:17:55 +0000 (21:17 +0200)]
stream-util: Add pa_stream_get_volume_channel_map()
The new function isn't used yet, but it soon will.
Tanu Kaskinen [Tue, 17 Dec 2013 19:14:18 +0000 (21:14 +0200)]
format, core-format: Constify some function parameters
Tanu Kaskinen [Tue, 3 Dec 2013 14:54:48 +0000 (16:54 +0200)]
sink-input, source-output: Do routing related validity checks immediately after routing
It's more logical that way.
Tanu Kaskinen [Tue, 3 Dec 2013 15:49:51 +0000 (17:49 +0200)]
core-format: Add pa_format_info_from_sample_spec2()
The function will be used in pa_sink_input_new() and
pa_source_output_new() to convert the sample spec given by the client
to a format info object. The set_format, set_rate and set_channels
will be set according to the stream flags (PA_SINK_INPUT_FIX_FORMAT
etc.).
Tanu Kaskinen [Mon, 18 Nov 2013 17:58:37 +0000 (19:58 +0200)]
core-format: Add pa_format_info_to_sample_spec2()
The function will be used in pa_sink_input_new() and
pa_source_output_new(). The fallback parameters are used to merge the
data in the format info with the sink/source sample spec and channel
map, when the format info is lacking some information.
Tanu Kaskinen [Tue, 3 Dec 2013 14:45:45 +0000 (16:45 +0200)]
format: Simplify pa_format_info_to_sample_spec()
Tanu Kaskinen [Mon, 25 Nov 2013 12:59:44 +0000 (14:59 +0200)]
core-format: Add pa_format_info_get_channel_map()
Tanu Kaskinen [Mon, 25 Nov 2013 12:51:37 +0000 (14:51 +0200)]
core-format: Add pa_format_info_get_channels()
This also fixes an issue in pa_format_info_to_sample_spec(): it did
no validation for the channels value. Now the validation is taken care
of in pa_format_info_get_channels().
Tanu Kaskinen [Mon, 25 Nov 2013 12:34:58 +0000 (14:34 +0200)]
core-format: Add pa_format_info_get_rate()
This also fixes an issue in pa_format_info_to_sample_spec(): it did
no validation for the rate value. Now the validation is taken care of
in pa_format_info_get_rate().
Tanu Kaskinen [Mon, 25 Nov 2013 14:15:54 +0000 (16:15 +0200)]
core-format: Add pa_format_info_get_sample_format()
Tanu Kaskinen [Mon, 18 Nov 2013 17:43:48 +0000 (19:43 +0200)]
Move pa_format_info_to_sample_spec_fake() to core-format
I will need to use the function from outside libpulse.
I added the channel map argument, because the function will be called
from another function that is expected to initialize the channel map.
I don't know if it's in practice necessary, but it shouldn't do any
harm either.
Tanu Kaskinen [Sat, 14 Dec 2013 07:21:22 +0000 (09:21 +0200)]
volume-test: Increase the allowed number of rouding errors
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=72374
Laurentiu Nicola [Thu, 26 Dec 2013 13:46:50 +0000 (15:46 +0200)]
module-rtp-recv: Add an argument for latency
Tanu Kaskinen [Fri, 3 Jan 2014 11:31:29 +0000 (13:31 +0200)]
caps: Remove the FreeBSD implementation of pa_drop_caps()
Quoting Ryan Lortie from [1]:
I assumed from my reading of the Linux code ("cap_clear()...") that it
was clearing all capabilities of the process when in fact it is only
clearing the "special to root" capabilities.
The FreeBSD version of the code indeed clears _all_ capabilities beyond
ones that the process already has (ie: cannot open any new files, create
sockets, etc.)
This has a pretty obvious adverse effect on pulseaudio's ability to do
what it needs to do -- indeed, it bombs out pretty quickly due to an
inability to read its own config file.
[1] https://bugs.freedesktop.org/show_bug.cgi?id=72580#c11
poljar (Damir Jelić) [Tue, 24 Dec 2013 21:35:41 +0000 (22:35 +0100)]
alsa-mixer: Free the description key in alsa_path_free().
poljar (Damir Jelić) [Tue, 24 Dec 2013 21:35:40 +0000 (22:35 +0100)]
bluez5-util: Free the adapter_path in device_free().
Alexander E. Patrakov [Mon, 21 Oct 2013 23:19:27 +0000 (00:19 +0100)]
Documentation of known misuse of PulseAudio API
Hello.
Over time, I became aware of several instances of tempting but
semantically incorrect usage of PulseAudio API (one from my own bad
proposal of "improving" Wine, one from Parole media player and one
from Webkit-GTK). I want to document these gotchas so that other
developers don't fall for that. See the attached patch.
I have checked that the rendered HTML is correct, but need someone to
confirm the factual accuracy of the proposed changes and, possibly, to
improve the wording.
--
Alexander E. Patrakov
Tanu Kaskinen [Mon, 30 Dec 2013 12:31:33 +0000 (14:31 +0200)]
caps: Fix platform checking
The "#elif __FreeBSD__" line caused a warning, because __FreeBSD__ was
not defined.
Tanu Kaskinen [Fri, 20 Dec 2013 19:54:22 +0000 (21:54 +0200)]
caps: Improve log message
I don't like the expression "this Pulseaudio" (even though that's
originally written by me), just "PulseAudio" is enough. Also, on
FreeBSD there's no libcap, so let's refer only to "capabilities".
Ryan Lortie [Tue, 10 Dec 2013 21:47:53 +0000 (16:47 -0500)]
Add support for FreeBSD <sys/capability.h>
cap_init() and friends are Linux-specific, so only use them if we're on
Linux.
Add support for FreeBSD capabilities if we find <sys/capability.h> to be
available there.
Add an #else (not Linux or FreeBSD) case with an #error requesting
contributions for other platforms.
This patch keeps the cap_init check in configure.ac but removes the
error if it fails. This will ensure we link to -lcap if needed, but
won't fail for the case that capabilities are part of the core system
(as on FreeBSD).
We do however, modify the header check to ensure we fail if there is no
<sys/capability.h> at all and we are on a system where it could be
installed. The logic here is that it is better to give the user the
chance to install it than it is to proceed silently with a disabled
security feature on a system where it could easily be supported.
--without-caps remains an option if the user wants to force it.
https://bugs.freedesktop.org/show_bug.cgi?id=72580
Tanu Kaskinen [Fri, 20 Dec 2013 14:10:53 +0000 (16:10 +0200)]
sink-input: Fix volume_factor_sink initialization
Source outputs handle volume_factor_source in a bit different way,
which is why this bug doesn't affect source outputs.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=72879
poljar (Damir Jelić) [Tue, 3 Dec 2013 00:09:56 +0000 (01:09 +0100)]
log: Add support for the systemd journal
The journal is a component of systemd, that captures Syslog messages,
Kernel log messages, initial RAM disk and early boot messages as well
as messages written to STDOUT/STDERR of all services, indexes them and
makes this available to the user.
It can be used in parallel, or in place of a traditional syslog daemon,
such as rsyslog or syslog-ng.
The journal offers a couple of improvements over traditional logging
facilities (e.g. advanced filtering capabilities).
This patch adds support for logging directly to the journal using its
native API.
Peter Meerwald [Wed, 18 Dec 2013 16:35:08 +0000 (17:35 +0100)]
modules: Add assertion in equalizer-sink
discovered by coverity
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Wed, 18 Dec 2013 16:27:47 +0000 (17:27 +0100)]
core: Fix check for io->output_event in enable_events()
copy-pase error discovered by coverity
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Wed, 18 Dec 2013 16:20:03 +0000 (17:20 +0100)]
core: Remove dead code in pa_mainloop_run()
while ((r = pa_mainloop_iterate(m, 1, retval)) >= 0)
;
if (r == -2)
return 1;
else if (r < 0)
return -1;
else
return 0;
the last else is never reached, discovered by coverity
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Wed, 18 Dec 2013 16:12:25 +0000 (17:12 +0100)]
modules: Remove dead code in position-event-sounds
ma is always NULL in fail path, discovered by coverity
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 23:27:35 +0000 (00:27 +0100)]
core: Use after free in pa_sink_input_new_data_set_formats() and pa_source_output_new_data_set_formats()
intention is to free old data_req->formats before assigning
new formats, discovered by coverity
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 22:54:13 +0000 (23:54 +0100)]
tests: Fix resource leak in sigbus-test
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 17:10:36 +0000 (18:10 +0100)]
modules: Remove redundant code in virtual-surround-sink
https://scan7.coverity.com:8443/reports.htm#v10206/p10016/fileInstanceId=8788&defectInstanceId=3710&mergedDefectId=591297
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 17:01:37 +0000 (18:01 +0100)]
core: Fix asserting command in protocol-native
https://scan7.coverity.com:8443/reports.htm#v10206/p10016/fileInstanceId=8690&defectInstanceId=3688&mergedDefectId=591259
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 16:22:10 +0000 (17:22 +0100)]
modules: Fix uninit value in rtp-send
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8803&defectInstanceId=3705&mergedDefectId=591292&eventIds=3705-36&eventId=3705-36
see http://silviocesare.wordpress.com/2007/10/22/setting-sin_zero-to-0-in-struct-sockaddr_in/
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 16:11:07 +0000 (17:11 +0100)]
core: Fix uninit pointer read in protocol-native
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8690&defectInstanceId=3703&mergedDefectId=591290&eventIds=3703-7&eventId=3703-7
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 16:00:24 +0000 (17:00 +0100)]
modules: Fix resource leak in card-restore
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8728&defectInstanceId=3737&mergedDefectId=591274
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:44:28 +0000 (16:44 +0100)]
modules: Fix resource leak in raop_client
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8899&defectInstanceId=3735&mergedDefectId=591272
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:40:03 +0000 (16:40 +0100)]
modules: Fix resource leak in tunnel-sink-new
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8770&defectInstanceId=3733&mergedDefectId=591270
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:35:50 +0000 (16:35 +0100)]
core: Fix resource leak in core-util
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8477&defectInstanceId=3693&mergedDefectId=591269
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:31:20 +0000 (16:31 +0100)]
modules: Fix resource leak in oss
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8824&defectInstanceId=3731&mergedDefectId=591267
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:25:44 +0000 (16:25 +0100)]
modules: Fix resource leak in alsa-ucm
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8833&defectInstanceId=3732&mergedDefectId=591268
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:15:09 +0000 (16:15 +0100)]
modules: Fix resource leak in device-restore
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8724&defectInstanceId=3728&mergedDefectId=591265
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 15:03:10 +0000 (16:03 +0100)]
modules: Fix resource leak in alsa-card
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8851&defectInstanceId=3725&mergedDefectId=591261
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 14:54:29 +0000 (15:54 +0100)]
modules: Fix resource leak in stream-restore
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8726&defectInstanceId=3724&mergedDefectId=591260
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Jan Alexander Steffens (heftig) [Mon, 16 Dec 2013 23:07:11 +0000 (00:07 +0100)]
thread-mq: Initialize thread_mainloop to NULL if not in use
Fixes a crash when unloading module-zeroconf-publish.
Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Peter Meerwald [Mon, 16 Dec 2013 13:18:17 +0000 (14:18 +0100)]
simple: Enable pa_simple_flush() on record streams and amend documentation
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 13:18:16 +0000 (14:18 +0100)]
doc: Document that pa_stream_flush() is applicable to playback and record streams
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 13:18:15 +0000 (14:18 +0100)]
doc: Document that pa_simple_get_latency() can be used on record streams as well
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 13:18:14 +0000 (14:18 +0100)]
doc: Refer to seek parameter of pa_stream_write() in description of pa_stream_flush()
pa_stream_write() has no delta parameter, but a seek parameter
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Peter Meerwald [Mon, 16 Dec 2013 13:18:13 +0000 (14:18 +0100)]
doc: Fix reference to pa_threaded_mainloop
Generating docs for file mainloop-api.h...
/home/pmeerw/src/pa-missing/src/pulse/mainloop-api.h:118: warning: Found unknown command `\pa_threaded_mainloop'
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Tanu Kaskinen [Wed, 4 Dec 2013 07:50:11 +0000 (09:50 +0200)]
Add pa_channels_valid()
I think this makes the code a bit nicer to read and write. This also
reduces the chances of off-by-one errors when checking the bounds of
channel count values.
Tanu Kaskinen [Wed, 4 Dec 2013 07:50:10 +0000 (09:50 +0200)]
Add pa_sample_rate_valid()
I think this makes the code a bit nicer to read and write. This also
reduces the chances of off-by-one errors when checking the bounds of
sample rate values.
Tanu Kaskinen [Wed, 4 Dec 2013 07:50:09 +0000 (09:50 +0200)]
Add pa_sample_format_valid()
I think this makes the code a bit nicer to read and write. This also
reduces the chances of off-by-one errors when checking the bounds of
the sample format value.
Tanu Kaskinen [Sat, 14 Dec 2013 07:29:24 +0000 (09:29 +0200)]
bluetooth: Fix profile priority comparison
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=72414
Ryan Lortie [Tue, 10 Dec 2013 18:27:52 +0000 (13:27 -0500)]
core-util: set_scheduler: check for RLIMIT_RTTIME
set_scheduler() assumes that if sys/resource.h was found then we will
find RLIMIT_RTTIME there, but this is a non-POSIX extension on Linux.
Change the check to ensure that RLIMIT_RTTIME is actually defined.
Linux indeed defines this as a macro, and POSIX specifies that the other
RLIMIT_ constants must be macros, so having this as an #ifdef seems
correct.
Ryan Lortie [Tue, 10 Dec 2013 18:26:17 +0000 (13:26 -0500)]
bootstrap.sh: use /usr/bin/env to find bash
bootstrap.sh uses some non-POSIX features of bash, so we can't use
/bin/sh. Unlike /bin/sh, bash can be installed anywhere in the path, so
we should use /usr/bin/env to find it.
This helps systems that have bash in /usr/local/bin, for example.
Peter Meerwald [Wed, 11 Dec 2013 16:07:04 +0000 (17:07 +0100)]
modargs: Do not modify alternate_rate in pa_modargs_get_alternate_sample_rate() on failure
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>