platform/upstream/dotnet/runtime.git
5 years agoShrink ReadOnlySequence by 8 bytes (dotnet/corefx#35860)
Ben Adams [Fri, 8 Mar 2019 02:06:49 +0000 (02:06 +0000)]
Shrink ReadOnlySequence by 8 bytes (dotnet/corefx#35860)

* Shrink ReadOnlySequence by 8 bytes

* nit

* Unwrap Start, End when used interally

Commit migrated from https://github.com/dotnet/corefx/commit/fd88c5df4bde4ef56522a1cd81da1ff69c92edc4

5 years agoAdd unit tests for Rune.Decode and friends (dotnet/corefx#35469)
Levi Broderick [Fri, 8 Mar 2019 01:59:49 +0000 (17:59 -0800)]
Add unit tests for Rune.Decode and friends (dotnet/corefx#35469)

Also forwards OperationStatus from System.Memory to System.Runtime

Commit migrated from https://github.com/dotnet/corefx/commit/43bfb492dbde0177a669982dfc9ed93d3236e1ac

5 years agoReplace AsnReader/AsnWriter with updated versions, remove unused AsnSerializer
Filip Navara [Thu, 7 Mar 2019 22:48:30 +0000 (23:48 +0100)]
Replace AsnReader/AsnWriter with updated versions, remove unused AsnSerializer

* Copy AsnReader/AsnWriter unit tests from dotnet/corefxlabs.
Remove original AsnReader/AsnWriter/AsnSerializer.

Original commit message from dotnet/corefxlab:

* Tests
  * AssertExtensions.Throws => Assert.Throws
  * Rename private overloads of public methods to *Core to avoid xunit discovery bug
  * Add tests for WriteUtcTime(maxYear)
  * Add tests for the ObjectDisposedException priority

* Change classes in the System.Security.Cryptography.Asn1 namespace to be "internal" instead of "public".
Change comment for AsnReader.ReadNamedBitListValue to allow compilation in project with warnings-as-errors.

* Update unit test names to match API names

* Add shared project for AsnReader/AsnWriter files

* Update AsnXml template to use new API names and `WriteEncodedValue` overload with `Span`

* S.S.C.Asn1: Regenerate AsnXml files

* Use new `AsnReader` API names in common S.S.C code

* S.S.C.Pkcs: Regenerate AsnXml files

* S.S.C.X509Certificates: Regenerate AsnXml files

* Update code to use `AsnWriter.WriteEncodedValue` with `Span`

* S.S.C.Algorithms: Use shared csproj for AsnReader/AsnWriter, add Argument_EncodeDestinationTooSmall resource

* S.S.C.Cng: Use shared csproj for AsnReader/AsnWriter, add Argument_EncodeDestinationTooSmall resource

* S.S.C.Encoding, S.S.C.Encoding.Tests: Use shared csproj for AsnReader/AsnWriter, add Argument_EncodeDestinationTooSmall resource

* S.S.C.OpenSSL: Use shared csproj for AsnReader/AsnWriter, add Argument_EncodeDestinationTooSmall resource

* S.S.C.Pkcs: Use shared csproj for AsnReader/AsnWriter, add Argument_EncodeDestinationTooSmall resource

* S.S.C.Pkcs: Update usage of `AsnWriter.WriteUtcTime` to use the maximum year instead of minimum year

* S.S.C.Pkcs: Use new `AsnReader` API names

* S.S.C.Pkcs: Use `AsnReader.WriteEncodedValue` with `Span`

* S.S.C.X509Certificates: Use shared csproj for AsnReader/AsnWriter, add Argument_EncodeDestinationTooSmall resource

* S.S.C.X509Certificates: Use new `AsnReader` API names

Commit migrated from https://github.com/dotnet/corefx/commit/1382754add40c899c141803c1cdb03c335d60095

5 years agoExpose AmbiguousImplementationException and add tests (dotnet/corefx#35632)
Maryam Ariyan [Thu, 7 Mar 2019 21:40:50 +0000 (13:40 -0800)]
Expose AmbiguousImplementationException and add tests (dotnet/corefx#35632)

* Expose AmbiguousImplementationException and add tests

Fixes: dotnet/corefx#34124

Commit migrated from https://github.com/dotnet/corefx/commit/34337c3a73675aa06f09d81b15bc926889b44922

5 years agoRename APIs based on API review (dotnet/corefx#35848)
Vance Morrison [Thu, 7 Mar 2019 18:25:58 +0000 (10:25 -0800)]
Rename APIs based on API review (dotnet/corefx#35848)

See https://github.com/dotnet/corefx/issues/34828

Commit migrated from https://github.com/dotnet/corefx/commit/3eacad602f7505f9f199dcd1992429506dd98330

5 years agoAdd FileStream.CopyToAsync missing override to ref (dotnet/corefx#35850)
Stephen Toub [Thu, 7 Mar 2019 16:44:32 +0000 (08:44 -0800)]
Add FileStream.CopyToAsync missing override to ref (dotnet/corefx#35850)

Commit migrated from https://github.com/dotnet/corefx/commit/c710854045bf7ffdffff3c2127b8fddf533ed46f

5 years agoSeed the AsnReader/AsnWriter changes from corefxlab
Jeremy Barton [Thu, 7 Mar 2019 06:26:05 +0000 (22:26 -0800)]
Seed the AsnReader/AsnWriter changes from corefxlab

These files are identical to the files at

https://github.com/dotnet/corefxlab/tree/dotnet/corefx@42ab2422b190521dd21c5c9e816810cf23f6a828/src/System.Security.Cryptography.Asn1.Experimental/System/Security/Cryptography/Asn1

though PointerMemoryManager is not included (already present in corefx)

Commit migrated from https://github.com/dotnet/corefx/commit/b66846b62fd39973eb54204087fe311941c87235

5 years agoDisable used-but-marked-unused warnings in System.Security.Cryptography.Native
Omair Majid [Thu, 7 Mar 2019 06:13:49 +0000 (01:13 -0500)]
Disable used-but-marked-unused warnings in System.Security.Cryptography.Native

When building in non-portable mode, some OpenSSL 1.1 function defnitions
that are marked as unused can be picked up by our build. When those
functions are called, clang reports a warning and fails the build:

    src/Native/Unix/System.Security.Cryptography.Native/openssl.c:432:12:
    error: 'sk_ASN1_OBJECT_num' was marked unused but was used [-Werror,-Wused-but-marked-unused]
          return sk_ASN1_OBJECT_num(eku);
                 ^

This 'unused' attribute was recently added to sk_* methods in OpenSSL
1.1: https://github.com/openssl/openssl/pull/8246

Fixes dotnet/corefx#35807

Commit migrated from https://github.com/dotnet/corefx/commit/4819ac49f2e82158baeb464c56f4cd206da1bfec

5 years agoUpdating the Microsoft.Private.Intellisense package to 3.0.0-preview3-190305-0 (dotne...
Tanner Gooding [Thu, 7 Mar 2019 05:05:10 +0000 (21:05 -0800)]
Updating the Microsoft.Private.Intellisense package to 3.0.0-preview3-190305-0 (dotnet/corefx#35842)

Commit migrated from https://github.com/dotnet/corefx/commit/2283bf7f329ee550b94da0d30d27017d50e630b4

5 years agoImprove JsonSerializer.ReadAsync(Stream) throughput (dotnet/corefx#35823)
Stephen Toub [Thu, 7 Mar 2019 04:49:58 +0000 (20:49 -0800)]
Improve JsonSerializer.ReadAsync(Stream) throughput (dotnet/corefx#35823)

* Improve JsonSerializer.ReadAsync(Stream) throughput

Some low hanging fruit:
- The method was using the Stream.ReadAsync overload that returns a `Task<int>`.  Changed it to take a `Memory<byte>` so that it instead returns a `ValueTask<int>`.
- The method was clearing the full rented buffer upon returning it to the pool, even when only using a small portion of it.  Changed it to only clear what was used.
- The method was resizing the buffer unnecessarily due to faulty logic around how much data remained.  Fixed it to only resize when more than half the buffer is full, which was the original intention.
- The ReadCore method is a bit chunky to call, initializing a new Utf8JsonReader each time, copying large structs, etc.  Since we need to read all of the data from the stream anyway, I changed it to try to fill the buffer, which then minimizes the number of times we need to call ReadCore, in particular avoiding the extra empty call at the end.  We can tweak this further in the future as needed, e.g. only making a second attempt to fill the buffer rather than doing so aggressively.
- Also fixed the exception to contain the full amount of data read from the stream, not just from the most recent call.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7d1a6b0548cb1fb74e2d3e7da4237e2ca56559e8

5 years agodisable tests failing on Windows ARM (dotnet/corefx#35849)
Tomas Weinfurt [Thu, 7 Mar 2019 04:43:28 +0000 (20:43 -0800)]
disable  tests failing on Windows ARM (dotnet/corefx#35849)

Commit migrated from https://github.com/dotnet/corefx/commit/0543bc85905acedfec77cb4c561754c790bed277

5 years agoReduce fix to just S.L.P (dotnet/corefx#35728)
Dan Moseley [Thu, 7 Mar 2019 03:28:24 +0000 (19:28 -0800)]
Reduce fix to just S.L.P (dotnet/corefx#35728)

Commit migrated from https://github.com/dotnet/corefx/commit/b7cc13e495944eb3f23cfbc0d18b69b680e52efb

5 years agoskip tests failing on Windows ARM64 (dotnet/corefx#35825)
Tomas Weinfurt [Wed, 6 Mar 2019 23:11:10 +0000 (15:11 -0800)]
skip tests failing on Windows ARM64 (dotnet/corefx#35825)

* skip tests failing on Windows ARM64

* fix CanWriteToPerfCounters condition to properly exclude run on arm

Commit migrated from https://github.com/dotnet/corefx/commit/229fad3002e6f986b3ae6eab08bc023abaf99bec

5 years agoignore verification failures on 10.14 (dotnet/corefx#35829)
Tomas Weinfurt [Wed, 6 Mar 2019 23:10:51 +0000 (15:10 -0800)]
ignore verification failures on 10.14 (dotnet/corefx#35829)

Commit migrated from https://github.com/dotnet/corefx/commit/9d535849e79a83fed80c506e9edc01590063a54b

5 years agoClean up lots of string.Format / SR.Format usage (dotnet/corefx#35777)
Stephen Toub [Wed, 6 Mar 2019 20:03:00 +0000 (12:03 -0800)]
Clean up lots of string.Format / SR.Format usage (dotnet/corefx#35777)

* Clean up lots of string.Format usage

This PR does a few things:
- Adds new SR.Format overloads, in particular to support accepting an IFormatProvider as the first argument.
- Fixes a bunch of calls to string.Format that should have been using SR.Format.  This not only helps in AOT builds where we want to be able to more cleanly remove resource strings, it enables easier auditing of the remaining string.Format uses to determine whether there are more appropriate implementations.
- Replaces some string.Format uses, in particular in asserts, with easier to read and maintain string interpolation
- Replaces some string.Format uses with string concatenation where it's simple and cheaper
- Fixes a bunch of SR.Format(SR.Something) calls where the SR.Format part is extraneous and should just be removed.
- Replaces a bunch of Debug.Assert(false, ...) calls with Debug.Fail(...).  This isn't directly related to string.Format, but I started this cleanup as part of cleaning up asserts that were using string.Format, and then ended up accidentally merging the chain into the same commit, and decided it was simple enough that I should just leave it rather than trying to separate it out again.

* Address PR feedback

* Fix breaks due to lower netstandard builds

Commit migrated from https://github.com/dotnet/corefx/commit/a6f76f4f620cbe74821c6445af3f13e048361658

5 years agoReduce overhead of ReadOnlySequence<T>.CopyTo (dotnet/corefx#35819)
Stephen Toub [Wed, 6 Mar 2019 19:10:46 +0000 (11:10 -0800)]
Reduce overhead of ReadOnlySequence<T>.CopyTo (dotnet/corefx#35819)

`ReadOnlySequence<T>.Length` isn't as small or fast as `ReadOnlySpan<T>.Length`, which is just a field access.  Since we need the span anyway for the single element case, just get the span first and then compare with its length.

Commit migrated from https://github.com/dotnet/corefx/commit/7fc9d5730aabc6724edf18f5bedde6d32610f681

5 years agore-enable MulticastInterface test on RH6, disable on RH7 and OSX (dotnet/corefx#35798)
Tomas Weinfurt [Wed, 6 Mar 2019 19:08:38 +0000 (11:08 -0800)]
re-enable MulticastInterface test on RH6, disable on RH7 and OSX (dotnet/corefx#35798)

* re-enable MulticastInterface test on RH6, disable on RH7 and OSX

* add missing using

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/ebe74b3ad7d1b7be02217bf199f5dedc05f76297

5 years agoFix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/corefx#35810)
Honza Rameš [Wed, 6 Mar 2019 15:51:17 +0000 (16:51 +0100)]
Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/corefx#35810)

* Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/corefx#35746)

Call to EnsureCapacity may result in invalid buffer size being
allocated.

* Update ValueStringBuilder.Grow to prevent misuse (dotnet/corefx#35746)

Updated name of the argument to make it clearer on the call-site also
added summary co clearly state the behavior of Grow.

Commit migrated from https://github.com/dotnet/corefx/commit/7a627bb7e380c0d56621a6d8acb61328c989fa58

5 years agoUpdate benchmarking.md doc (dotnet/corefx#35786)
Marco Rossignoli [Wed, 6 Mar 2019 09:39:40 +0000 (10:39 +0100)]
Update benchmarking.md doc (dotnet/corefx#35786)

* update doc

* address PR feedback

Co-Authored-By: MarcoRossignoli <marco.rossignoli@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/7e3d30144cdb7d9ec16fcd8b73d02edd23e1bced

5 years agoImprove X509Chain handling of NotSignatureValid on Linux (dotnet/corefx#35801)
Jeremy Barton [Wed, 6 Mar 2019 04:59:57 +0000 (20:59 -0800)]
Improve X509Chain handling of NotSignatureValid on Linux (dotnet/corefx#35801)

* Native changes for better NotSignatureValid support

* clang-format -i the modified files

* Tests and managed changes for better supporting NotSignatureValid chains

* Chain the WorkingChain ctors

* Fix tests on macOS (Classic) Sierra

Commit migrated from https://github.com/dotnet/corefx/commit/148623a7cd0eb2789dfb0d1fd2bfb9fc925baa60

5 years agoRemove dead code from GuidConverter and add tests (dotnet/corefx#35790)
Hugh Bellamy [Wed, 6 Mar 2019 02:11:16 +0000 (02:11 +0000)]
Remove dead code from GuidConverter and add tests (dotnet/corefx#35790)

Commit migrated from https://github.com/dotnet/corefx/commit/b1c9885c6d1fdd6d7bcaca216861e0b8fc4d388d

5 years agoreplace WaitForPipeDrain with Flush in Kill_EntireProcessTree_True_EntireTreeTerminat...
Tomas Weinfurt [Wed, 6 Mar 2019 01:47:45 +0000 (17:47 -0800)]
replace WaitForPipeDrain with Flush in Kill_EntireProcessTree_True_EntireTreeTerminated test (dotnet/corefx#35796)

* replace WaitForPipeDrain with FLush

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/758c059b3d1a2a9a365f66a7e5563f18413f8002

5 years agoFix publish.proj when pushing corefx-test-assets.xml file (dotnet/corefx#35802)
Santiago Fernandez Madero [Wed, 6 Mar 2019 00:04:34 +0000 (16:04 -0800)]
Fix publish.proj when pushing corefx-test-assets.xml file (dotnet/corefx#35802)

Commit migrated from https://github.com/dotnet/corefx/commit/e031c37884aae34196dbb5592234e10b24ba06ce

5 years agoCleanup some Syndication code (dotnet/corefx#35175)
Hugh Bellamy [Tue, 5 Mar 2019 21:22:50 +0000 (21:22 +0000)]
Cleanup some Syndication code (dotnet/corefx#35175)

Commit migrated from https://github.com/dotnet/corefx/commit/327d8ed428b40491b499cad4d4114af4fa3f8f30

5 years agoFix ArgIterator condition (dotnet/corefx#35741)
Dan Moseley [Tue, 5 Mar 2019 21:01:05 +0000 (13:01 -0800)]
Fix ArgIterator condition (dotnet/corefx#35741)

Commit migrated from https://github.com/dotnet/corefx/commit/5540da6584fb78e4de9f8df9751a00bf09d9cd1b

5 years agoAdd Alpine arm64 official build (dotnet/corefx#35778)
Santiago Fernandez Madero [Tue, 5 Mar 2019 20:55:16 +0000 (12:55 -0800)]
Add Alpine arm64 official build (dotnet/corefx#35778)

* Add Alpine arm64 official build

* Include musl_arm64 in PRs as well

Commit migrated from https://github.com/dotnet/corefx/commit/a33c5e92879eaa6c1cc07527deb7e85fc0a074a0

5 years agoTweak ImmutableDictionary.TryGetValue to improve throughput (dotnet/corefx#35759)
Stephen Toub [Tue, 5 Mar 2019 19:55:56 +0000 (11:55 -0800)]
Tweak ImmutableDictionary.TryGetValue to improve throughput (dotnet/corefx#35759)

* Avoid recursive calls in SortedInt32KeyNode.Search

* Compare first key directly in HashBucket

* Seal a few internal types that have virtual overrides or interface implementations

* Avoid extra level of indirection with Search

Now that it's no longer recursive, we can just inline it and build the caller's decisions right into it.

Commit migrated from https://github.com/dotnet/corefx/commit/8c54cd84f98c553b75356c69d2c8f5a4029717bc

5 years agoAdd more Syndication tests (dotnet/corefx#35107)
Hugh Bellamy [Tue, 5 Mar 2019 19:49:26 +0000 (19:49 +0000)]
Add more Syndication tests (dotnet/corefx#35107)

* Add more Syndication tests

Commit migrated from https://github.com/dotnet/corefx/commit/013fd82b1bb218d171300e127a487ebc39e1fc2e

5 years agoReduce inner and outer loop test time for S.T.Json (dotnet/corefx#35776)
Ahson Khan [Tue, 5 Mar 2019 19:47:31 +0000 (11:47 -0800)]
Reduce inner and outer loop test time for S.T.Json (dotnet/corefx#35776)

* Reduce inner and outer loop test time for S.T.Json

* Remove redundant sequence slicing, only compare the SequencePositions.

Commit migrated from https://github.com/dotnet/corefx/commit/0c264c6d61cd6d18fbe7a760606f0e8548ff334d

5 years ago[master] Update dependencies from dotnet/core-setup (dotnet/corefx#35713)
dotnet-maestro[bot] [Tue, 5 Mar 2019 19:17:12 +0000 (19:17 +0000)]
[master] Update dependencies from dotnet/core-setup (dotnet/corefx#35713)

* Update dependencies from https://github.com/dotnet/core-setup build 20190301.13

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27501-13

* Remove workaround for System.Runtime.CompilerServices.Unsafe

* Update dependencies from https://github.com/dotnet/core-setup build 20190302.8

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27502-8

* Update dependencies from https://github.com/dotnet/core-setup build 20190303.9

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27503-9

* Update dependencies from https://github.com/dotnet/core-setup build 20190304.10

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27504-10

* Don't include EventRegistrationToken on Unix

This type was accidentally duplicated between CoreLib and contracts.

Suppress that for now since we're detecting the duplication in the shared framework.

Make a fix in the shared items to restore the condition on this type.

Commit migrated from https://github.com/dotnet/corefx/commit/ae1426803f77356a7bed0b14c505c8b6030b3a6e

5 years agoFix issue with BufferSegment reuse (dotnet/corefx#35779)
David Fowler [Tue, 5 Mar 2019 18:10:09 +0000 (10:10 -0800)]
Fix issue with BufferSegment reuse (dotnet/corefx#35779)

- We stored the last examined segment to compute how many bytes we should decrement on the writer side but if that segment is returned to the segment pool, we end up in a bad state. This properly clears the state so that doesn't happen.

Commit migrated from https://github.com/dotnet/corefx/commit/c6b999d77e6f7e36851523662a9471e343555e16

5 years agoFix Linux chain.ChainStatus when multiple layers have errors
Jeremy Barton [Tue, 5 Mar 2019 17:21:27 +0000 (09:21 -0800)]
Fix Linux chain.ChainStatus when multiple layers have errors

The recent chain rewrite caused only the last layer with errors to be reported.

Commit migrated from https://github.com/dotnet/corefx/commit/fc9629cae7bfcda2196b24ba5127265efce1716a

5 years agoAllow CreateRelationship to work with FileAccess.Write (dotnet/corefx#35763)
Eric StJohn [Tue, 5 Mar 2019 16:48:42 +0000 (08:48 -0800)]
Allow CreateRelationship to work with FileAccess.Write (dotnet/corefx#35763)

When adding a relationship InternalRelationshipCollection was creating a part
but not writing anything to it.  This caused an empty entry to be created in
the zip archive which later needed to be rewritten.  That's disallowed with
FileAccess.Write.  Instead, avoid creating the entry until it's content is
written.

When writing a relationship file InternalRelationshipCollection was attempting
to truncate any existing content.  This throws when the package is open  with
FileAccess.Write since the part stream is not seekable.  Don't do the seek
when package is open for FileAccess.Write since no pre-existing content is
possible.

In Package.PartExists don't attempt to get the part.  PartExists on .NETCore
only needs to query its local list of parts.  Since it isn't returning a
mutable part, it doesn't need to throw for packages opened with FileAccess.Write.

Avoid out of bounds exception when enumerating part keys. The fix that delays
creating the relationship part until its content exposed an issue in
DoOperationOnEachPart.  This was creating a copy of the part keys, but then
enumerating over the length of original list instead of the copy.  Since I
delayed the creating of a part until it was flushed this made the length change
while iterating the loop.  Since this code was using its copied list of keys
it should have never been using the original bounds.

Commit migrated from https://github.com/dotnet/corefx/commit/1822fec76a7bc02764ffa94c0e1f97b8ebfdbdea

5 years agodisable AllHelperPortsAreInGetPortNames on ARM Windows (dotnet/corefx#35773)
Tomas Weinfurt [Tue, 5 Mar 2019 03:28:24 +0000 (19:28 -0800)]
disable AllHelperPortsAreInGetPortNames on ARM Windows (dotnet/corefx#35773)

Commit migrated from https://github.com/dotnet/corefx/commit/8a730a6ecd96fef04d74e1807c8b1d193e0a5f16

5 years agoUpdate API for new RCW license impl in coreclr (dotnet/corefx#35767)
Aaron Robinson [Tue, 5 Mar 2019 00:41:37 +0000 (16:41 -0800)]
Update API for new RCW license impl in coreclr (dotnet/corefx#35767)

Commit migrated from https://github.com/dotnet/corefx/commit/4f9e62149207fb1bbef18426bb302cea6869b78a

5 years agoAdhere to desktop implementation of [Can]ConvertFrom (dotnet/corefx#35760)
Adeel Mujahid [Mon, 4 Mar 2019 23:30:57 +0000 (01:30 +0200)]
Adhere to desktop implementation of [Can]ConvertFrom (dotnet/corefx#35760)

* Adhere to desktop implementation of [Can]ConvertFrom

* Add tests for InstanceDescriptor in TypeConverter

Commit migrated from https://github.com/dotnet/corefx/commit/f603cea8ca5bdb62b33b0d67c67ab84d6d50300f

5 years agoDisable alpine39 (dotnet/corefx#35770)
Tomas Weinfurt [Mon, 4 Mar 2019 23:27:20 +0000 (15:27 -0800)]
Disable alpine39 (dotnet/corefx#35770)

* disable alpine3.9

Commit migrated from https://github.com/dotnet/corefx/commit/ad13ae9528b0717b74aefa929ea933e6db50cf5d

5 years agoUpdate adding-api-guidelines.md
Viktor Hofer [Mon, 4 Mar 2019 22:19:26 +0000 (23:19 +0100)]
Update adding-api-guidelines.md

Commit migrated from https://github.com/dotnet/corefx/commit/f75d8e8d9cb48abe623cf43f649fc49b6b8435d8

5 years agoUpdate brotli to v1.0.7 (dotnet/corefx#35172)
Clinton Ingram [Mon, 4 Mar 2019 22:07:01 +0000 (14:07 -0800)]
Update brotli to v1.0.7 (dotnet/corefx#35172)

* update to brotli v1.0.7

* update WithState perf test to use compressLevel arg

* update brotli-version.txt

Commit migrated from https://github.com/dotnet/corefx/commit/6ad08fec6cd1fcb7348dfe60fda775ca69476a8d

5 years agoremoved test from full .net framework
Daniel Turan [Fri, 1 Mar 2019 08:08:40 +0000 (09:08 +0100)]
removed test from full .net framework

Commit migrated from https://github.com/dotnet/corefx/commit/cb726dd396dc70d87a9cf69a1e84f05e8ecc224a

5 years agoIgnored tests for custom ValidationResults on .NET Framework, since it is not support...
Daniel Turan [Fri, 1 Mar 2019 08:05:42 +0000 (09:05 +0100)]
Ignored tests for custom ValidationResults on .NET Framework, since it is not supported there

Commit migrated from https://github.com/dotnet/corefx/commit/f2e274bd435c3494dd6b22883b3b589bea5cde6e

5 years agoRemoved extra leading space
Daniel Turan [Wed, 27 Feb 2019 08:01:42 +0000 (09:01 +0100)]
Removed extra leading space

Commit migrated from https://github.com/dotnet/corefx/commit/959cdfac0744b0a12c41fa06b9f5df55a91ff415

5 years agoAdding support for custom ValidationResult (derived class) in CustomValidationAttribute
Daniel Turan [Tue, 26 Feb 2019 11:52:15 +0000 (12:52 +0100)]
Adding support for custom ValidationResult (derived class) in CustomValidationAttribute

Commit migrated from https://github.com/dotnet/corefx/commit/27af01cb476debb4e791e3a8305bed279efecfbc

5 years agoUse C# async iterator to implement ChannelReader.ReadAllAsync (dotnet/corefx#35745)
Stephen Toub [Mon, 4 Mar 2019 20:13:52 +0000 (12:13 -0800)]
Use C# async iterator to implement ChannelReader.ReadAllAsync (dotnet/corefx#35745)

While the hand-written implementation is a bit faster than what the compiler currently generates, it's also a lot more code, and complex, error-prone code.  Better to go with the simpler implementation, and work to improve the compiler for the future.

Commit migrated from https://github.com/dotnet/corefx/commit/0ce020951d5956916a9084820cefe3684d19f856

5 years agoSBCSCodePageEncoding: Don't call DecoderFallback.CreateFallbackBuffer until needed...
slozier [Mon, 4 Mar 2019 18:55:12 +0000 (13:55 -0500)]
SBCSCodePageEncoding: Don't call DecoderFallback.CreateFallbackBuffer until needed (dotnet/corefx#35199)

* Don't call DecoderFallback.CreateFallbackBuffer until needed

* Use null instead of fallbackBuffer

Commit migrated from https://github.com/dotnet/corefx/commit/5419ecd858d11f08938019ba49477039de93ec3f

5 years agoRemove SharedFrameworkValidation (dotnet/corefx#35747)
Viktor Hofer [Mon, 4 Mar 2019 17:44:25 +0000 (18:44 +0100)]
Remove SharedFrameworkValidation (dotnet/corefx#35747)

Commit migrated from https://github.com/dotnet/corefx/commit/365e78019c73158fa8819141a3191b0e9c1493d1

5 years agoAdd tests for dotnet/coreclrdotnet/corefx#20815 - new Math and MathF rounding modes...
hamish-rose [Mon, 4 Mar 2019 16:03:27 +0000 (05:03 +1300)]
Add tests for dotnet/coreclrdotnet/corefx#20815 - new Math and MathF rounding modes (dotnet/corefx#33297)

* add tests for new midpointrounding modes

new tests added for Math.cs double Round methods

* add tests for float, decimal

convert to theory

* Update tests

tests now reflect correct rounding behavior

* add tests for existing modes

* code review feedback

- refactor tests to use member data
- move MathF tests to MathF.netcoreapp.cs
- add tests for new modes with digits and special cases

* move math tests to mathtests.netcoreapp.cs

netcoreapp specific tests moved

Commit migrated from https://github.com/dotnet/corefx/commit/cc42bb95b0877a653d4f556a0839d261ea3563b7

5 years agoAvoid NullReferenceException in BinaryObjectInfo (dotnet/corefx#35740)
Stephen Toub [Mon, 4 Mar 2019 00:22:23 +0000 (19:22 -0500)]
Avoid NullReferenceException in BinaryObjectInfo (dotnet/corefx#35740)

A corrupted BinaryFormatter stream can result in a BinaryObjectInfo getting constructed before the ObjectManager is constructed, resulting in the BinaryObjectInfo not having a reference to the ObjectManager.  Attempts to use it then hit a null reference exception.

Commit migrated from https://github.com/dotnet/corefx/commit/7622efd2dbd363a632e00b6b95be4d990ea125de

5 years agoProject msbuild syntax cleanup (dotnet/corefx#35686)
Viktor Hofer [Sun, 3 Mar 2019 17:55:25 +0000 (18:55 +0100)]
Project msbuild syntax cleanup (dotnet/corefx#35686)

* Remove license header from non-shipping files

* Remove obsolete Project attributes

* Remove xml header and remove DefaultTargets

Commit migrated from https://github.com/dotnet/corefx/commit/c390ce7df50252e11f5d322276e9d19e046d1332

5 years agoOSX to macOS rename in dev guide
Viktor Hofer [Sun, 3 Mar 2019 17:43:07 +0000 (18:43 +0100)]
OSX to macOS rename in dev guide

Commit migrated from https://github.com/dotnet/corefx/commit/9f22abfdf98d79dc4ffbc8d77a1de41da519b6bd

5 years agoUpdate developer-guide to address workflow changes
Viktor Hofer [Sun, 3 Mar 2019 17:41:19 +0000 (18:41 +0100)]
Update developer-guide to address workflow changes

Commit migrated from https://github.com/dotnet/corefx/commit/255ec6fb26d5efd3154047641aba031bb2303ad5

5 years agoRevisit back pressure implementation (dotnet/corefx#35711)
David Fowler [Sun, 3 Mar 2019 08:16:33 +0000 (00:16 -0800)]
Revisit back pressure implementation (dotnet/corefx#35711)

- Today when using a PipeReader from a Pipe, when the pause threshold is hit and the reader does not consume enough data to unblock the writer (enough to reduce the resume threshold) an exception is thrown. This exception is extremely hard to understand and work around since it's based on a limit set by the owner of the Pipe. It leads to people setting an extremely big limit (bigger than the biggest message) or disabling the limit completely.
- The changes the back pressure mechanic to be based on examined instead of consumed. This pauses the writer if the pause threshold is hit, but lets the reader continue to buffer until a logical payload is reached (whatever matters to the protocol).
- This breaks software that relied on these limits to enforce a maximum buffer size and those pieces of code need to now handle their own maximum buffer size.

Commit migrated from https://github.com/dotnet/corefx/commit/ce278ee840561e90b2c6bb9daaee5ff4b9cce293

5 years agoAdd Windows ARM64 to official builds (dotnet/corefx#35721)
Dan Moseley [Sun, 3 Mar 2019 03:55:06 +0000 (19:55 -0800)]
Add Windows ARM64 to official builds (dotnet/corefx#35721)

* Add Windows ARM64 to official builds

* Add ARMxx properties

* Disable WMI tests for ARMxx

Commit migrated from https://github.com/dotnet/corefx/commit/1d6287840322200f6b83d7c459588a23666df3bd

5 years agoImprove assert error message in Process tests (dotnet/corefx#35725)
Stephen Toub [Sun, 3 Mar 2019 03:07:24 +0000 (22:07 -0500)]
Improve assert error message in Process tests (dotnet/corefx#35725)

Commit migrated from https://github.com/dotnet/corefx/commit/9a542f020ed230888cb956c90494910bfc9035c0

5 years agoGet RH6 outerloop clean
danmosemsft [Sat, 2 Mar 2019 23:26:32 +0000 (15:26 -0800)]
Get RH6 outerloop clean

Commit migrated from https://github.com/dotnet/corefx/commit/21799a3c1613285a90398eb3cf9ce41d704e786b

5 years agoPR feedback
Hugh Bellamy [Sat, 23 Feb 2019 12:54:12 +0000 (12:54 +0000)]
PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3814b5fcea2a215f7f0a34f6d944fda711e27cd8

5 years agoFix null reference exceptions in TypeConverter
Hugh Bellamy [Mon, 4 Feb 2019 19:51:38 +0000 (19:51 +0000)]
Fix null reference exceptions in TypeConverter

Commit migrated from https://github.com/dotnet/corefx/commit/a7d0e7b048a549fbce55831d60e19e0e36f33851

5 years agoAdd support for param name for netcore-only exception
Hugh Bellamy [Mon, 4 Feb 2019 19:51:17 +0000 (19:51 +0000)]
Add support for param name for netcore-only exception

Commit migrated from https://github.com/dotnet/corefx/commit/fa4ae94b220d477b4c8eef2a290542585f50c81c

5 years agoInitial Json serialization functionality (dotnet/corefx#35609)
Steve Harter [Sat, 2 Mar 2019 19:20:34 +0000 (13:20 -0600)]
Initial Json serialization functionality (dotnet/corefx#35609)

Commit migrated from https://github.com/dotnet/corefx/commit/20657b549ab4de422c3f7a9c50e22bf4d7f789a5

5 years agoMove MaxDepth setting to JsonReaderOptions from the JsonReaderState (dotnet/corefx...
Ahson Khan [Sat, 2 Mar 2019 05:43:59 +0000 (21:43 -0800)]
Move MaxDepth setting to JsonReaderOptions from the JsonReaderState (dotnet/corefx#35312)

* Move MaxDepth setting to JsonReaderOptions from the JsonReaderState.

* Update JsonDocument to support custom MaxDepth

* Address PR feedback.

* Address feedback - cleanup tests and remove unnecessary condition

Commit migrated from https://github.com/dotnet/corefx/commit/e1a355dd81f61e32500769b23ccbea2cb3331003

5 years agoMake BitOperations public (CoreFX) (dotnet/corefx#35606)
Grant [Sat, 2 Mar 2019 04:01:53 +0000 (20:01 -0800)]
Make BitOperations public (CoreFX) (dotnet/corefx#35606)

* Add ref assembly class

* Add [CLSCompliantAttribute(false)]

* Change name to System.Numerics.BitOperations

* Move ref to System.Runtime.Extensions

Commit migrated from https://github.com/dotnet/corefx/commit/0ae011a57253959b79c952219c5fa16389255b7b

5 years agoFix ImplicitMachineConfigHost parameter checking (dotnet/corefx#28894)
Jeremy Kuhne [Sat, 2 Mar 2019 00:58:36 +0000 (16:58 -0800)]
Fix ImplicitMachineConfigHost parameter checking (dotnet/corefx#28894)

* Fix ImplicitMachineConfigHost parameter checking

Don't assume index of the ConfigurationFileMap in params

Fixes: dotnet/corefx#28784

Commit migrated from https://github.com/dotnet/corefx/commit/63e052c114b3555c5e595348cc92e4dd3cc0e755

5 years agoMake Stacktrace Symbols Cache Aware of Unloadability (phase 1) (dotnet/corefx#35541)
John Salem [Sat, 2 Mar 2019 00:22:29 +0000 (16:22 -0800)]
Make Stacktrace Symbols Cache Aware of Unloadability (phase 1) (dotnet/corefx#35541)

Adds GetSourceLineInfo overload that consumes an Assembly, but does not use it.  A follow-up change will use that assembly for caching the MetadataReaderProvider.

dotnet/coreclrdotnet/corefx#20179

Commit migrated from https://github.com/dotnet/corefx/commit/fa2a3ea5be4a317402e47674c9a1286da24c6d68

5 years agoMerge pull request dotnet/corefx#35623 from MarcoRossignoli/fixuseragentparsing
Geoff Kizer [Fri, 1 Mar 2019 23:40:58 +0000 (15:40 -0800)]
Merge pull request dotnet/corefx#35623 from MarcoRossignoli/fixuseragentparsing

Fix bug: UserAgent malformed parsing

Commit migrated from https://github.com/dotnet/corefx/commit/cb54ad963cc655d4c783033a2ab3dc3576d0dc65

5 years agoFix netfx build break
Jan Kotas [Fri, 1 Mar 2019 21:59:19 +0000 (13:59 -0800)]
Fix netfx build break

Commit migrated from https://github.com/dotnet/corefx/commit/524afe84f963b2a87230b19838e72174d4fa90f9

5 years agoCleanup System.Runtime and System.Runtime.Extensions refs (dotnet/corefx#35704)
Jan Kotas [Fri, 1 Mar 2019 23:24:44 +0000 (15:24 -0800)]
Cleanup System.Runtime and System.Runtime.Extensions refs (dotnet/corefx#35704)

Commit migrated from https://github.com/dotnet/corefx/commit/d733469bd423e48ded1a34fad15c062738954437

5 years agocontinue parsing after nested call
Marco Rossignoli [Fri, 1 Mar 2019 22:11:29 +0000 (23:11 +0100)]
continue parsing after nested call

Commit migrated from https://github.com/dotnet/corefx/commit/b2865f5e4dcda0a3745b96d704aebec82ab22d60

5 years agoAdding parsing tests to validate we consider enough significant digits to always...
Tanner Gooding [Fri, 1 Mar 2019 22:06:35 +0000 (14:06 -0800)]
Adding parsing tests to validate we consider enough significant digits to always round correctly. (dotnet/corefx#35701)

Commit migrated from https://github.com/dotnet/corefx/commit/34118b74d46129b3095e1b4dbad8441c4db62e33

5 years agoAdd Pull Request Builds documentation (dotnet/corefx#35672)
Santiago Fernandez Madero [Fri, 1 Mar 2019 22:06:14 +0000 (14:06 -0800)]
Add Pull Request Builds documentation (dotnet/corefx#35672)

* Add Pull Request Builds documentation

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/f709c1014e9ee854af1945e83219b573d0a46252

5 years agoRemove InitTools and ToolsDir (dotnet/corefx#35677)
Eric StJohn [Fri, 1 Mar 2019 21:40:45 +0000 (13:40 -0800)]
Remove InitTools and ToolsDir (dotnet/corefx#35677)

* Remove buildtools init-tools and various BuildTools specific properties

* Workaround NuGet restore GeneratePathProperty case-sensitivity

See https://github.com/NuGet/Home/issues/7843

Commit migrated from https://github.com/dotnet/corefx/commit/e7159674bb5bd2ac3688dd0789efb45e5de62299

5 years agoMove dir.traversal.targets to eng (dotnet/corefx#35684)
Viktor Hofer [Fri, 1 Mar 2019 21:39:06 +0000 (22:39 +0100)]
Move dir.traversal.targets to eng (dotnet/corefx#35684)

Commit migrated from https://github.com/dotnet/corefx/commit/32724ccf66bfdb4a48e8745ca4bc07480d15805a

5 years agoAdd test to verify that DangerousRelease preserves Marshal.GetLastWin32Error (dotnet...
Jan Kotas [Fri, 1 Mar 2019 21:10:15 +0000 (13:10 -0800)]
Add test to verify that DangerousRelease preserves Marshal.GetLastWin32Error (dotnet/corefx#35612)

Commit migrated from https://github.com/dotnet/corefx/commit/d6db020cc7c66f95b0695e03b997936b3cf1f610

5 years agoConsume optimization data from bar & cleanup standard repo consumption (dotnet/corefx...
Eric StJohn [Fri, 1 Mar 2019 18:09:59 +0000 (10:09 -0800)]
Consume optimization data from bar & cleanup standard repo consumption (dotnet/corefx#35675)

* Consume optimization data from bar & cleanup standard repo consumption

* Remove restoresources from optimizationData.depproj

Commit migrated from https://github.com/dotnet/corefx/commit/6bc5f9e37ae26eb3ceead1a1c0afac81166b3c8c

5 years agoRe-enable BeginSendFile tests (dotnet/corefx#35696)
Stephen Toub [Fri, 1 Mar 2019 18:02:15 +0000 (13:02 -0500)]
Re-enable BeginSendFile tests (dotnet/corefx#35696)

Commit migrated from https://github.com/dotnet/corefx/commit/560bbb1f5906ea4ff7f9a6888bf8fe083cf94087

5 years agoFix minor Activity W3C format issues (dotnet/corefx#35650)
Liudmila Molkova [Fri, 1 Mar 2019 17:15:03 +0000 (09:15 -0800)]
Fix minor Activity  W3C format issues (dotnet/corefx#35650)

* Fix minor W3C Activity format issues

* undo csproj changes

* review nits

* review: parentSpanId invalid

* add security safe critical attributes, fix tests

Commit migrated from https://github.com/dotnet/corefx/commit/ba5d02d92ecdf5ee902f8e4b348bc0ffd2a34a96

5 years agoFix XmlWriterTraceListenerTests handling of DateTime (dotnet/corefx#35692)
Stephen Toub [Fri, 1 Mar 2019 16:57:55 +0000 (11:57 -0500)]
Fix XmlWriterTraceListenerTests handling of DateTime (dotnet/corefx#35692)

Some of these tests compare a textual date time from an XmlWriterTraceListener (which internally uses DateTime.Now) against a textual date time from a TraceEventCache (which internally uses DateTime.UtcNow).  This means that there's a few hour window (depending on time zone) at the transition of every month where the months end up differing and the test fails.

The tests also have a bug in that the format string used is buggy and isn't actually resulting in day and year being included, just month.  And further, even if the time zones are fixed, it's still possible but rare that taking the Now at two different moments could straddle a boundary.  So, rather than comparing ToStrings, we just compare the DateTimes, albeit with an allowed window.

Commit migrated from https://github.com/dotnet/corefx/commit/1b80f1e1da2630b8fe877a35c285d9c4ffe9f2ce

5 years agoMerge pull request dotnet/corefx#35655 from dotnet/darc-master-7c963d5e-3797-4b68...
Stephen Toub [Fri, 1 Mar 2019 15:38:45 +0000 (10:38 -0500)]
Merge pull request dotnet/corefx#35655 from dotnet/darc-master-7c963d5e-3797-4b68-9fad-354784eeb96a

[master] Update dependencies from dotnet/coreclr

Commit migrated from https://github.com/dotnet/corefx/commit/d1d5e038f37bddce4b3a7910b684d9d4936e2a09

5 years agoMerge branch 'master' into darc-master-7c963d5e-3797-4b68-9fad-354784eeb96a
Stephen Toub [Fri, 1 Mar 2019 15:38:01 +0000 (10:38 -0500)]
Merge branch 'master' into darc-master-7c963d5e-3797-4b68-9fad-354784eeb96a

Commit migrated from https://github.com/dotnet/corefx/commit/c523e9a012be1a8ab76df474d66ca0be81c606f1

5 years agoMove codeanalysisruleset to src (dotnet/corefx#35687)
Viktor Hofer [Fri, 1 Mar 2019 14:06:07 +0000 (15:06 +0100)]
Move codeanalysisruleset to src (dotnet/corefx#35687)

Commit migrated from https://github.com/dotnet/corefx/commit/9940166bff52155600f25f15da13a83c982526d2

5 years agoAdapt corefx to recent coreclr changes
Stephen Toub [Thu, 28 Feb 2019 15:57:01 +0000 (10:57 -0500)]
Adapt corefx to recent coreclr changes

Commit migrated from https://github.com/dotnet/corefx/commit/feb6eb3db7ca0a886f08ecd1eb259e0ae8ca434c

5 years agoTestCheckChildProcessUserAndGroupIdsElevated: handle GetGroups returning the same...
Tom Deseyn [Fri, 1 Mar 2019 12:30:16 +0000 (13:30 +0100)]
TestCheckChildProcessUserAndGroupIdsElevated: handle GetGroups returning the same group several times (dotnet/corefx#35680)

Commit migrated from https://github.com/dotnet/corefx/commit/bd9e7342508a05782446572baa3353b9a00cf6dd

5 years agoDelete old vssettings in favor of editorconfig (dotnet/corefx#35683)
Viktor Hofer [Fri, 1 Mar 2019 11:14:48 +0000 (12:14 +0100)]
Delete old vssettings in favor of editorconfig (dotnet/corefx#35683)

Commit migrated from https://github.com/dotnet/corefx/commit/49c86d5fd8120a972d13229e4f36dedfdf6a477c

5 years agoAdd ref asm + tests for creating Rune instances from surrogates
Levi Broderick [Thu, 14 Feb 2019 01:39:52 +0000 (17:39 -0800)]
Add ref asm + tests for creating Rune instances from surrogates

Commit migrated from https://github.com/dotnet/corefx/commit/99436aa00c3772f852d8801f4879869df7cf26c8

5 years agoAdd missing license headers
Stephen Toub [Fri, 1 Mar 2019 01:05:06 +0000 (20:05 -0500)]
Add missing license headers

Add missing license headers, and make the asn.xslt generator do it going forward.

Commit migrated from https://github.com/dotnet/corefx/commit/5dc8132370532804a5381b90e2ce87d6c52b61f6

5 years agoEnsure ZipPackage can handle file lengths over int.MaxValue … (dotnet/corefx#35660)
Eric StJohn [Fri, 1 Mar 2019 00:41:22 +0000 (16:41 -0800)]
Ensure ZipPackage can handle file lengths over int.MaxValue … (dotnet/corefx#35660)

* Ensure ZipPackage can handle file lengths over int.MaxValue when using FileAccess.Read and FileAccess.Write.

This helps unblock the scenario of using large files with System.IO.Packaging

FileAccess.Write was completely broken before because ZipPackage would create an entry
and immediately delete it, which is disallowed when you're writing an archive.  This
was a porting error, the desktop code had this under an else that was incorrectly removed.

Additionally when reading an archive with a large file, accessing the length of the
stream would cause the entire stream to be read into memory uncompressed and
overflow since this used a MemoryStream backed by a int.max-limited managed array.
Instead use the length info from the archive entry.

* Fix new packaging tests on desktop, respond to CR feedback

Desktop does not support FileAccess.Write on Package.Open: it throws when attempting to
create the ZipArchive.  It only supports FileAccess.Read or FileAccess.ReadWrite.

Also clean up the test code.

* Code review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/125eac5808fc63bde5c238acdbaba9cac055855e

5 years agoRemoving the ExtractVector128 and InsertVector128 APIs that take an address. (dotnet...
Tanner Gooding [Fri, 1 Mar 2019 00:28:30 +0000 (16:28 -0800)]
Removing the ExtractVector128 and InsertVector128 APIs that take an address. (dotnet/corefx#35596)

Commit migrated from https://github.com/dotnet/corefx/commit/2104ad984999fec501cf060e6b6ab7f74c0b0558

5 years agopull in yet another updated Alpine image (dotnet/corefx#35674)
Tomas Weinfurt [Fri, 1 Mar 2019 00:18:41 +0000 (16:18 -0800)]
pull in yet another updated Alpine image (dotnet/corefx#35674)

* pull in updated images with LANG set

Commit migrated from https://github.com/dotnet/corefx/commit/b9710cb25b86ef4da002949df2dee1d63933734d

5 years agoAllow single hyphen arguments in bash build (dotnet/corefx#35628)
Viktor Hofer [Thu, 28 Feb 2019 17:55:25 +0000 (18:55 +0100)]
Allow single hyphen arguments in bash build (dotnet/corefx#35628)

* Allow single hyphen arguments in bash build

* Add clean switch

* Darc update from build '20190228.2'

Commit migrated from https://github.com/dotnet/corefx/commit/76e08b605f237bffb74283d83241eaadc4e7ce93

5 years agopull in Alpine image with LANG fix (dotnet/corefx#35657)
Tomas Weinfurt [Thu, 28 Feb 2019 17:13:57 +0000 (09:13 -0800)]
pull in Alpine image with LANG fix (dotnet/corefx#35657)

Commit migrated from https://github.com/dotnet/corefx/commit/6ff8bf5722ffdb5b1386b062a12f9d59c3adea87

5 years agoadd some tests
Marco Rossignoli [Thu, 28 Feb 2019 15:13:24 +0000 (16:13 +0100)]
add some tests

Commit migrated from https://github.com/dotnet/corefx/commit/12fc04b6f8c20d901f9c89a1b8d8a540fa22dd0d

5 years agoFix the SslStream order of intermediate certificates with long chains (dotnet/corefx...
Jeremy Barton [Thu, 28 Feb 2019 11:31:06 +0000 (03:31 -0800)]
Fix the SslStream order of intermediate certificates with long chains (dotnet/corefx#35641)

Commit migrated from https://github.com/dotnet/corefx/commit/b30e7723c98a6e7da0fa7d6edd4a54643275afad

5 years agoUpdate LicenseInterop API (dotnet/corefx#35577)
Aaron Robinson [Thu, 28 Feb 2019 05:50:57 +0000 (21:50 -0800)]
Update LicenseInterop API (dotnet/corefx#35577)

* Clean up the Interop helper API for managed COM server activation via IClassFactory2.

Commit migrated from https://github.com/dotnet/corefx/commit/bf09f74c8fe5b6094771266e6beeb36e7447b252

5 years agoAvoid re-scanning the whole input ROSequence when getting position in Utf8JsonReader...
Ahson Khan [Thu, 28 Feb 2019 03:41:48 +0000 (19:41 -0800)]
Avoid re-scanning the whole input ROSequence when getting position in Utf8JsonReader (dotnet/corefx#35310)

* Make sure SequencePosition is saved as part of JsonReaderState

* Avoid rescanning whole ROSequence when getting position.

* We don't guarantee the position for invalid JSON.

* Remove isSingleSegment check when getting position and add single
segment tests

* Address feedback: remove else block and add some comments.

Commit migrated from https://github.com/dotnet/corefx/commit/b85d017ecac090e6966822f159b48e7edfef37ce

5 years agoAuto-generate the reference assemblies and separate type forwards (dotnet/corefx...
Ahson Khan [Thu, 28 Feb 2019 03:39:21 +0000 (19:39 -0800)]
Auto-generate the reference assemblies and separate type forwards (dotnet/corefx#35557)

* Auto-generate the reference assemblies

* Add back type forwards.

* Revert "Add back type forwards."

This reverts commit dotnet/corefx@3acf74aabb2e3ba90ac7280d541723d13d72c74a.

* Add back TypeForwardedTo in .Forward.cs files

* Add new type forward files to the csproj files

* Add back if-defs and move TestUtilities comment from ref to source

* Remove duplicate definitions, delete unnecessary manual files,

* Fix build breaks

* Add back missing AsyncMethodBuilderAttr to S.Runtime ref

* Fix typo between XmlDocument and XPath.XDocument

* Add type forward fild missed from previous commit

* Fix ECDiffieHellmanCngPublicKey internal ctor for netfx 4.6.1

* Remove "this type was moved to comments" from the type forwards.

* Add back the Xml and Debugger* attributes to Xml.ReaderWriter

* Add back struct layout attributes

* Add back attributes missing (highlighted from api compat)

* Add missing toolbox item attribute in s.data.common.

* Add missing struct layout attributes and remove unnecessary additions

* Add back InterfaceTypeAttribute

Commit migrated from https://github.com/dotnet/corefx/commit/16689aa0a933517dc45465fc6edb6223222414a6

5 years agoProcess: Unix: use groups of ProcessStartInfo.UserName (dotnet/corefx#34961)
Tom Deseyn [Thu, 28 Feb 2019 02:55:26 +0000 (03:55 +0100)]
Process: Unix: use groups of ProcessStartInfo.UserName (dotnet/corefx#34961)

* Process: Unix: use groups of ProcessStartInfo.UserName

* PR feedback

* Fix OSX build

* Fix OSX build II

* Fix OSX build III

* Set ngroups to -1 on error

* Handle setgroups EPERM with fallback to process groups

* pal_process: handle zero groups length

This is for completeness, managed code calls this with at least one group: the primary group of the user.

* Remove uid_t and gid_t sizeof asserts

* Determine user ids using 'id' command

* Deal with OSX and musl specifics

* Try to fix OSX TestStartWithNormalUser by handling setgroups EINVAL

* Fix UnauthorizedAccessException for ExceptionFile when RemoteInvoke as sudo

* OSX getgrouplist is not thread safe

* Try to fix Ubuntu 18.10 test failures

* Refactor RunTestAsSudo to use RemoteInvoke child Process checking

* Try to fix OSX 13.10 fails

* Update test for truncated groups

* Extend tests

* Try fix/debug OSX test fail

* Test: special case OSX for getgrouplist truncate

* PR feedback

* Improve groups checking: O(N*M) to O(N*log(M))

Commit migrated from https://github.com/dotnet/corefx/commit/b10e8d67b260e26f2e47750cf96669e6f48e774d

5 years agopull updated Alpine3.9 image one more time (dotnet/corefx#35639)
Tomas Weinfurt [Thu, 28 Feb 2019 00:52:54 +0000 (16:52 -0800)]
pull updated Alpine3.9 image one more time (dotnet/corefx#35639)

Commit migrated from https://github.com/dotnet/corefx/commit/94322619b200b05dbb9a386db391407f97ebefa2

5 years agoFix advance for single length delimiter (dotnet/corefx#35597)
Jeremy Kuhne [Thu, 28 Feb 2019 00:33:56 +0000 (16:33 -0800)]
Fix advance for single length delimiter (dotnet/corefx#35597)

* Fix advance for single length delimiter

If the delimiter span for TryReadTo was only one character long we weren't advancing past the delimiter if requested. Add regression test.

* Address feedback

* Scan from beginning as well

Commit migrated from https://github.com/dotnet/corefx/commit/b0bc99d6f7943a8081a84bea23c5542831c9359e

5 years agoupdate SqlClient Area Owners (dotnet/corefx#35634)
Afsaneh Rafighi [Wed, 27 Feb 2019 20:55:57 +0000 (12:55 -0800)]
update SqlClient Area Owners (dotnet/corefx#35634)

Commit migrated from https://github.com/dotnet/corefx/commit/5aeccae0ab98af86e56043c1017474b7c05358e0

5 years agoupdate container name (dotnet/corefx#35631)
Tomas Weinfurt [Wed, 27 Feb 2019 19:46:57 +0000 (11:46 -0800)]
update container name (dotnet/corefx#35631)

* pul in updated Alpine39 image

* images no longer published to old place

Commit migrated from https://github.com/dotnet/corefx/commit/417c3b8a97b29f7c5c1d25d5f7357b387bc5a68b

5 years agopul in updated Alpine39 image (dotnet/corefx#35627)
Tomas Weinfurt [Wed, 27 Feb 2019 17:37:56 +0000 (09:37 -0800)]
pul in updated Alpine39 image (dotnet/corefx#35627)

Commit migrated from https://github.com/dotnet/corefx/commit/cbb3159d041c4489ced4ef7142a40a86aa54e35f