platform/upstream/efl.git
5 years agoeina_vpath: specilice the eina_vpath headers
Marcel Hollerbach [Tue, 14 Aug 2018 21:09:22 +0000 (17:09 -0400)]
eina_vpath: specilice the eina_vpath headers

Summary: For now its beta, and the since tag is added.

Reviewers: zmike

Reviewed By: zmike

Subscribers: #reviewers, kimcinoo, Hermet, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6751

5 years agobuild: fix evas static build of gl engines
Mike Blumenkrantz [Tue, 14 Aug 2018 21:09:11 +0000 (17:09 -0400)]
build: fix evas static build of gl engines

Summary:
when gl_common is built statically, the include directories for it need
to be added to the main evas library build

@fix

Reviewers: devilhorns, vtorri, ManMower

Reviewed By: ManMower

Subscribers: ManMower, #reviewers, cedric, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D6681

5 years agoelm_panel: return instead of EINA_SAFETY_ON_FALSE_RETURN
Alastair Poole [Tue, 14 Aug 2018 19:48:27 +0000 (15:48 -0400)]
elm_panel: return instead of EINA_SAFETY_ON_FALSE_RETURN

Summary:
As with other checks in ELM return if object is not yet
finalized. This stops lots of console noise.

@fix T7265

Test Plan:
elementary_test: use panel test from console and view the noise
from EINA. Apply then do the same.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, zmike

Tags: #efl

Maniphest Tasks: T7265

Differential Revision: https://phab.enlightenment.org/D6826

5 years agoelementary: Check for valid cursor_rect when (un)setting focus
Chris Michael [Tue, 14 Aug 2018 14:45:30 +0000 (15:45 +0100)]
elementary: Check for valid cursor_rect when (un)setting focus

Summary:
As the cursor_rect for elm_code_widget is not created until the code
widget gets focus, we cannot just assume it is already there when
trying to emit a focus signal. The cursor_rect does not get created
until widget_cursor_update is called.

This fixes an issue where NULL is passed to efl_layout_signal_emit.

To test this, just launch elementary_test and click the Code Editor
test. As soon as you try to click into the Code Editor, this gets
triggered.

ref T7030

Reviewers: netstar, ajwillia.ms

Reviewed By: netstar

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6701

5 years agoedje: unset internal _need_imf flag on shutdown
Mike Blumenkrantz [Tue, 14 Aug 2018 14:45:13 +0000 (10:45 -0400)]
edje: unset internal _need_imf flag on shutdown

Summary:
failing to unset this causes the ecore_imf flag to go negative if edje
is ever completely shut down twice

@fix

Reviewers: ManMower

Reviewed By: ManMower

Subscribers: ManMower, #reviewers, cedric, #committers

Tags: #efl_layout_engine, #easy

Differential Revision: https://phab.enlightenment.org/D6763

5 years agotheme: add programs for deferred naviframe push/pop signals
Jaehyun Cho [Tue, 14 Aug 2018 14:19:16 +0000 (10:19 -0400)]
theme: add programs for deferred naviframe push/pop signals

Summary:
Naviframe provides deferred push/pop signals to begin transition effect and
not to emit signals frequently for transition callbacks.

To handle the deferred naviframe push/pop signals, programs which catch the
signals are added.

@fix

Test Plan: Test naviframe in elementary_test by pressing next and prev buttons.

Reviewers: zmike, Hermet

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6823

5 years agotests/genlist: add focus test
Yeongjong Lee [Thu, 9 Aug 2018 08:36:27 +0000 (08:36 +0000)]
tests/genlist: add focus test

This adds test for simulating focus state.
Differential Revision: https://phab.enlightenment.org/D6800

5 years agoefl_ui_focus_manager_calc: restore focus correctly if redirect gets NULL
Marcel Hollerbach [Thu, 9 Aug 2018 08:52:55 +0000 (10:52 +0200)]
efl_ui_focus_manager_calc: restore focus correctly if redirect gets NULL

Otherwise we might end up with focus beeing NULL.

Differential Revision: https://phab.enlightenment.org/D6803

5 years agoefl_ui_focus_manager_calc: fix unregistering the root of a redirect
Marcel Hollerbach [Thu, 9 Aug 2018 08:50:44 +0000 (10:50 +0200)]
efl_ui_focus_manager_calc: fix unregistering the root of a redirect

There is often a tree of elements registered in a manager that are
having all the same redirect element. Unserting the redirect property
just because the node has this redirect element is not helpfull as this
would break basically elm_tests button search. However, if it is the
container itself, then the redirect can be unset, as nothing else can
ever reach again the redirect manager.

ref D6800

Differential Revision: https://phab.enlightenment.org/D6802

5 years agoefl_ui_focus_manager: adjust pop history pop
Marcel Hollerbach [Thu, 9 Aug 2018 08:38:27 +0000 (10:38 +0200)]
efl_ui_focus_manager: adjust pop history pop

It now searches for a element if the focus stack is empty.

Differential Revision: https://phab.enlightenment.org/D6801

5 years agoefl-cxx: Add -Wno-shadow to disable huge warnings in C++
Felipe Magno de Almeida [Mon, 13 Aug 2018 15:12:44 +0000 (11:12 -0400)]
efl-cxx: Add -Wno-shadow to disable huge warnings in C++

Summary:
-Wno-shadow warnings disable a improper warning directive for C++, this is made because
it is common for people to use the same CFLAGS as CXXFLAGS, enabling, unadvertadly, the
smae warning for C and C++.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6821

5 years agoElementary test : add a checkbox to hide beta apis.
chris [Mon, 13 Aug 2018 14:55:52 +0000 (10:55 -0400)]
Elementary test : add a checkbox to hide beta apis.

Reviewers: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6817

5 years agoemotion: make intree running work
Marcel Hollerbach [Mon, 13 Aug 2018 13:57:47 +0000 (09:57 -0400)]
emotion: make intree running work

Summary:
before it would have only worked if there would have been the
architecture in the path, which was definitly not the case.
This fixes the problems.
Depends on D6795

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6819

5 years agoelm: bring back elm/uiclock
Xavi Artigas [Mon, 13 Aug 2018 11:03:39 +0000 (07:03 -0400)]
elm: bring back elm/uiclock

Summary:
It turns out elm/uiclock (which was removed in 89675c3219) is actually used,
at least by the datetime legacy widget. Removing this widget broke the
datetime_example test.
This commit reverts 89675c3219 and fixes the elm/uiclock part names:
- Part names are prefixed with 'elm.'
- efl_ui_clock.c (which is used for both the new efl and the legacy elm widgets)
  now looks for part names with 'efl.' and 'elm.' prefixes, and without any
  prefix, for compatibility with older themes.

Fixes T6928

Test Plan: the Datetime elementary_test (and all other clock-related tests) now work.

Reviewers: zmike, jsuya, CHAN, devilhorns, Jaehyun_Cho

Reviewed By: zmike, jsuya, CHAN

Subscribers: #reviewers, Jaehyun, Hermet, cedric, #committers

Tags: #efl

Maniphest Tasks: T6928

Differential Revision: https://phab.enlightenment.org/D6577

5 years agoelm/naviframe: implement invalidate method for naviframe items
Mike Blumenkrantz [Mon, 13 Aug 2018 06:07:31 +0000 (15:07 +0900)]
elm/naviframe: implement invalidate method for naviframe items

Summary:
move most of the _item_free() calls to the invalidate method and unset some
delete callbacks on content items to avoid invalid calls during deletion

calling any of this during the object destructor is invalid because the parent
object can no longer be accessed at this time

fix T7236

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, stefan_schmidt, cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7236

Differential Revision: https://phab.enlightenment.org/D6759

5 years agoeio: fix poll backend
Marcel Hollerbach [Sun, 12 Aug 2018 08:21:19 +0000 (10:21 +0200)]
eio: fix poll backend

it seems that this should have been a pop call, not the function
pointer. This key eina_array_pop is never used. Nor would the array get
smaller, so i assume this should be a pop call.

Differential Revision: https://phab.enlightenment.org/D6814

5 years agoelm_map: add EINA_UNUSED to avoid build warning
Yeongjong Lee [Fri, 10 Aug 2018 16:49:50 +0000 (12:49 -0400)]
elm_map: add EINA_UNUSED to avoid build warning

Test Plan: make

Reviewers: devilhorns, zmike

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6813

5 years agoevas gl_common: code refactoring.
Hermet Park [Fri, 10 Aug 2018 16:06:42 +0000 (12:06 -0400)]
evas gl_common: code refactoring.

Summary: use boolean instead int, no logic changes.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6807

5 years agoee_wayland: Remove spurious manual_render
Derek Foreman [Fri, 10 Aug 2018 15:38:25 +0000 (11:38 -0400)]
ee_wayland: Remove spurious manual_render

Summary:
The line prior to this damages the canvas and should result in a render
anyway.

Forcing a manual render here (without regard to the manual_render_set
state) will cause a post render callback to fire for clients that
think they've disabled automatic rendering.

fix T7275

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7275

Differential Revision: https://phab.enlightenment.org/D6809

5 years agoelm_image : Remove unnecessary test about image
JunsuChoi [Fri, 10 Aug 2018 02:02:16 +0000 (11:02 +0900)]
elm_image : Remove unnecessary test about image

Summary:
The elm_transit test is in test_transit.c.
Testing for elm_transit in test_image.c is unnecessary

Test Plan: elementary_test -to "image click"

Reviewers: Hermet, #reviewers, eunue

Reviewed By: Hermet, #reviewers

Subscribers: cedric, akanad, bowonryu, #reviewers, YOhoho, #committers, JackDanielZ, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6799

5 years agoecore-evas: make manual_render_set a no-op when setting the current value
Mike Blumenkrantz [Thu, 9 Aug 2018 19:51:41 +0000 (15:51 -0400)]
ecore-evas: make manual_render_set a no-op when setting the current value

Summary:
this should not take any action if the existing value of manual_render is
set to the passed value

Reviewers: devilhorns, kimcinoo, ManMower

Reviewed By: devilhorns, kimcinoo, ManMower

Subscribers: ManMower, cedric, #reviewers, #committers

Tags: #efl_display_system

Differential Revision: https://phab.enlightenment.org/D6786

5 years agoevas: add safety check code to avoid crash
Yeongjong Lee [Thu, 9 Aug 2018 15:19:46 +0000 (11:19 -0400)]
evas: add safety check code to avoid crash

Test Plan: evas_smart_objects_calculate(NULL);

Reviewers: zmike, Hermet, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6805

5 years agorelease: Update NEWS and bump version for 1.21.0-beta2 release
Stefan Schmidt [Thu, 9 Aug 2018 09:42:35 +0000 (11:42 +0200)]
release: Update NEWS and bump version for 1.21.0-beta2 release

5 years agoelm genlist - remove execsivve calls where we could do less eo lookups
Carsten Haitzler (Rasterman) [Tue, 24 Jul 2018 08:49:50 +0000 (17:49 +0900)]
elm genlist - remove execsivve calls where we could do less eo lookups

something to help T6580 ... but not that much (0.3% fewer eo calls)

5 years agoee_drm: Fix tick job timestamps for funny GPU clocks
Derek Foreman [Wed, 8 Aug 2018 20:58:33 +0000 (16:58 -0400)]
ee_drm: Fix tick job timestamps for funny GPU clocks

Summary:
The animator timestamps were only getting the offset applied when they
came from page flips.  The "early tick" logic failed to apply the offset.

This likely only changes behaviour on vmware's graphics stack, and
only the env var ECORE_EVAS_DRM_GPU_CLOCK_WRONG is set.

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: bu5hm4n, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6792

5 years agobuild: explicitly add eolian generated files to CLEANFILES
Mike Blumenkrantz [Wed, 8 Aug 2018 16:09:55 +0000 (12:09 -0400)]
build: explicitly add eolian generated files to CLEANFILES

these are all being generated now so they must also be cleaned for
distcheck to pass

Differential Revision: https://phab.enlightenment.org/D6782

5 years agoee_wayland: Update configured state on short-circuit ack-configure
Derek Foreman [Wed, 8 Aug 2018 18:58:47 +0000 (14:58 -0400)]
ee_wayland: Update configured state on short-circuit ack-configure

Summary:
When we BAIL from the configure callback with an immediate ack we don't
properly update state, commit the ack, or allow ecore_wl2 to process
a deferred ack_configure that happened during async rendering.

Using a commit here instead should update internal state properly.

ref T7243
Depends on D6783

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7243

Differential Revision: https://phab.enlightenment.org/D6784

5 years agoRevert "ee_wayland: Remove pointless ack_configure"
Derek Foreman [Wed, 8 Aug 2018 18:58:44 +0000 (14:58 -0400)]
Revert "ee_wayland: Remove pointless ack_configure"

Summary:
This reverts commit a61f254f19df163c860235e6c19e0d65ce9eb0c4.
and a follow up commit that removed some warnings

Apparently this is instrumental in enlightenment's window maximize
animation processing.

The removed bits would force an ack configure when an inbound
configure didn't result in a change that would cause a re-render.
Since this calculation needs knowledge of state ecore_wl2 doesn't
track, it does need to happen here.

ref T7243

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Maniphest Tasks: T7243

Differential Revision: https://phab.enlightenment.org/D6783

5 years agoefl/ui_format: Use STRING type for format strings that contain %%
Stephen Houston [Wed, 8 Aug 2018 18:57:00 +0000 (14:57 -0400)]
efl/ui_format: Use STRING type for format strings that contain %%

Summary: This fixes progressbar format strings that contain the pattern %%, thus making it a string and not a format.

Test Plan: elementary_test progressbar shows %% on the first vertical progressbar before this patch.  afterwords it shows % correctly.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6790

5 years agobuild: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites
Mike Blumenkrantz [Wed, 8 Aug 2018 13:45:30 +0000 (09:45 -0400)]
build: define PACKAGE_BUILD_DIR as $(abs_top_builddir) for all test suites

Summary:
this needs to be consistent so that it can be used reliably across suites

also these build flags really need to be consolidated into a single variable
that can be reused

Depends on D6666

Reviewers: devilhorns, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #committers

Tags: #efl_build

Differential Revision: https://phab.enlightenment.org/D6731

5 years agoefl_ui_composition: remove all registered children on unregister
Marcel Hollerbach [Wed, 8 Aug 2018 13:39:22 +0000 (09:39 -0400)]
efl_ui_composition: remove all registered children on unregister

Summary:
ensure that all the children are gone once we unregister the widget
itself. This helps widgets that are not cleaning up theire children /
items on invalidation.

ref T7213.

Reviewers: CHAN, YOhoho, zmike

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7213

Differential Revision: https://phab.enlightenment.org/D6754

5 years agoefl_ui_focus_composition: do not call legacy API here
Marcel Hollerbach [Wed, 8 Aug 2018 13:39:15 +0000 (09:39 -0400)]
efl_ui_focus_composition: do not call legacy API here

Summary:
calling this on a object that is legacy is not going to work. And will
print a error. This will make new widgets less verbose.

ref T7213
Depends on D6755

Reviewers: YOhoho, zmike, CHAN

Reviewed By: YOhoho

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7213

Differential Revision: https://phab.enlightenment.org/D6756

5 years agoci: automatically clear config.cache if it cannot be used
Mike Blumenkrantz [Wed, 8 Aug 2018 13:38:24 +0000 (09:38 -0400)]
ci: automatically clear config.cache if it cannot be used

Summary:
if env vars change between runs then the cache is invalidated, causing
configure to print a very specific error

by running a separate script to catch this error, the build can detect
and clear the cache when necessary to avoid having to manually disable
the cache when changing build settings
Depends on D6697

Reviewers: stefan_schmidt, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6732

5 years agowayland: Fix elementary setting window parents at creation time
Derek Foreman [Wed, 8 Aug 2018 13:37:29 +0000 (09:37 -0400)]
wayland: Fix elementary setting window parents at creation time

Summary:
We need to pass the entire pointer, not just 32-bits of it.

Fixes a crash with enlightenment sandbox gadgets where
ecore_wl2_window_alpha_get() is called with an invalid pointer while
trying to display a pop-up.

Reviewers: zmike, devilhorns

Reviewed By: zmike, devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6775

5 years agotests/naviframe: namespace test function names
Mike Blumenkrantz [Wed, 8 Aug 2018 13:37:07 +0000 (09:37 -0400)]
tests/naviframe: namespace test function names

Summary:
no functional changes
Depends on D6759

Reviewers: stefan_schmidt

Reviewed By: stefan_schmidt

Subscribers: cedric, #committers

Tags: #efl_widgets, #efl_tests

Differential Revision: https://phab.enlightenment.org/D6760

5 years agotests/genlist: add full test for expanding and contracting a genlist item
Mike Blumenkrantz [Wed, 8 Aug 2018 13:36:33 +0000 (09:36 -0400)]
tests/genlist: add full test for expanding and contracting a genlist item

Summary:
this adds a fairly complete test for simulating the expand and contract
of a tree item in a genlist, as triggered by a user clicking the expand arrow
on an item

presently this test fails, as it is set to abort if any error messages are
logged and there are a number of focus manager errors

ref D6737
ref T6837

Reviewers: bu5hm4n, Hermet

Reviewed By: Hermet

Subscribers: SanghyeonLee, cedric, #committers

Tags: #efl_tests, #efl_widgets

Maniphest Tasks: T6837

Differential Revision: https://phab.enlightenment.org/D6750

5 years agotests/genlist: use genlist test namespace for test functions
Mike Blumenkrantz [Wed, 8 Aug 2018 13:36:27 +0000 (09:36 -0400)]
tests/genlist: use genlist test namespace for test functions

Summary:
namespacing test function names makes test output easier to read.

no functional changes

Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: SanghyeonLee, cedric, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D6758

5 years agoedje_cc: change .mo file write location to be relative to the .edj file
Mike Blumenkrantz [Thu, 19 Jul 2018 23:45:34 +0000 (19:45 -0400)]
edje_cc: change .mo file write location to be relative to the .edj file

previously this would attempt to write the .mo file to the same directory
that the .po file was found in, which is invalid in cases such as distcheck
where the source directory is not writable

@fix

Differential Revision: https://phab.enlightenment.org/D6636

5 years agobuild: rewrite remaining $(OBJEXT) rules
Mike Blumenkrantz [Tue, 24 Jul 2018 15:40:28 +0000 (11:40 -0400)]
build: rewrite remaining $(OBJEXT) rules

fix the naming for these targets based on automake 1.16+ presence and
naming scheme

ref D6594
fix T7154

Differential Revision: https://phab.enlightenment.org/D6675

5 years agoelm_map: remove unreasonable efl_super call
Yeongjong Lee [Wed, 8 Aug 2018 07:11:02 +0000 (16:11 +0900)]
elm_map: remove unreasonable efl_super call

Summary:
Efl_Ui_Widget which is super of Elm_Map is not implement Efl_Ui_Zoom. to call
efl_super of Elm_Map for Efl_Ui_Zoom method occurs unresolved function error.

Test Plan:
map_example_01

Check that there is no error message.

Reviewers: zmike, Hermet

Reviewed By: Hermet

Subscribers: #reviewers, cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6772

5 years agoelm_map: implement zoom_mode_get, zoom_level_get
Yeongjong Lee [Wed, 8 Aug 2018 07:05:16 +0000 (16:05 +0900)]
elm_map: implement zoom_mode_get, zoom_level_get

Test Plan:
map_example_01

Check that +,- button is working and no error message.

Reviewers: zmike, Hermet

Reviewed By: Hermet

Subscribers: #reviewers, cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6771

5 years agoefl_ui/image_zoomable: fix internal eina file refcounting
Mike Blumenkrantz [Wed, 8 Aug 2018 06:56:02 +0000 (15:56 +0900)]
efl_ui/image_zoomable: fix internal eina file refcounting

Summary:
this pointer is owned by elm_theme, not the image, so the image refcount
must be increased in order to avoid accidentally closing the file which is
still in use by elm_theme and triggering a crash

this resolves the crash in the `efl_ui_image_zoomable_icon` test

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: #reviewers, cedric, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D6774

5 years agoefl_ui_tab_pager: clean up and remove unnecessary signals.
Bowon Ryu [Wed, 8 Aug 2018 06:20:42 +0000 (15:20 +0900)]
efl_ui_tab_pager: clean up and remove unnecessary signals.

Summary:
TAB of efl_ui_tab_bar is no longer widget_item.
TAB is now layout,
so, do not need below signals.
"efl,text,visible"
"efl,text,hidden"
"efl,icon,visible"
"efl,icon,hidden"

Test Plan: elementary_test -to efl.ui.tab_pager

Reviewers: Jaehyun_Cho, Hermet

Reviewed By: Jaehyun_Cho

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6770

5 years agoeina: Add doxygen in/out tags for rectangle
Bryce Harrington [Wed, 8 Aug 2018 04:52:25 +0000 (13:52 +0900)]
eina: Add doxygen in/out tags for rectangle

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6776

5 years agoeina_prefix: Fix a logic to use a canonical path for finding prefix 39/182439/2
Wonki Kim [Mon, 25 Jun 2018 06:56:11 +0000 (15:56 +0900)]
eina_prefix: Fix a logic to use a canonical path for finding prefix

wip

Change-Id: Ib6b8f9ff15da7cfd3540d93dd8c7021d53678768
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoevas gl: fix missing map texture target.
Hermet Park [Tue, 14 Aug 2018 21:13:24 +0000 (17:13 -0400)]
evas gl: fix missing map texture target.

Summary:
Map context missed setting texture target.
I guess this is one of regression bugs in gl backend.

When shader is flushed, it sets invalid texture target with map texture.
That caused blank map rendering, this could be observed temporary
because gl pipe contexts are reusable and missing texture target means,
it could use previous texture target values that mostly have GL_TEXTURE_2D.

@fix

Reviewers: #committers, ManMower

Reviewed By: #committers, ManMower

Subscribers: ManMower, cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6818

Change-Id: I4fa4f70864da7ee1e244a187116d7f71159e1940

5 years agoatspi: check service, bus and path names for Dbus communication
Lukasz Wlazly [Fri, 10 Aug 2018 08:27:13 +0000 (10:27 +0200)]
atspi: check service, bus and path names for Dbus communication

This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.

Change-Id: Icb6171e61255b3e5561982387ced4e8440ce234a

5 years agoedje_cc: remove edje_cc build warning message caused by efl_version
Youngbok Shin [Thu, 9 Aug 2018 09:43:45 +0000 (18:43 +0900)]
edje_cc: remove edje_cc build warning message caused by efl_version

In Tizen, new Textblock calculation is already applied by default.
So, this warning message is meaningless in Tizen.

@tizen_fix

Change-Id: I9a02653ddd5c7f6c6eedea767d930687c1f3da54

5 years agoevas : fixed coverty issue CID:111611
Joogab Yun [Thu, 9 Aug 2018 03:58:45 +0000 (12:58 +0900)]
evas : fixed coverty issue CID:111611

Change-Id: If5cfe093d251fb75d7c15380ad71a6e81cb5a790

5 years agoevas : fixed coverity issue CID:1013912
Joogab Yun [Thu, 9 Aug 2018 03:34:49 +0000 (12:34 +0900)]
evas : fixed coverity issue CID:1013912

Change-Id: I8bfcf9e9e2235dd76947f91261fde19c875659b1

5 years agoecore_wl_dnd: free seat selection event when num_types are less than 0
Taehyub Kim [Thu, 9 Aug 2018 02:00:53 +0000 (11:00 +0900)]
ecore_wl_dnd: free seat selection event when num_types are less than 0

Change-Id: Ieaf11eb564c478f22c3b0f6ec0b38811b9fa65d3

5 years agoevas image: fix screen flickering issue at partial + image preloading
Hermet Park [Wed, 8 Aug 2018 07:01:11 +0000 (16:01 +0900)]
evas image: fix screen flickering issue at partial + image preloading

Summary:
Prerequisite: Partial rendering ON + Image Prealoding + Triple surface buffer of GL.

Previously, evas trys to draw of an image which didn't prepare of image data yet (in case of preloading)
This time, it will draw a solid color onto the dest sufrace 1,
But luckily, preloading is finished just after, it draws proper image data onto next surface 2 and 3.

Now, triple buffer is filled with the image data but only first frame is still empty. That's a problem.

This patch skips to draw image if it doesn't prepare data yet, but once the preloading is finished,
it starts to draw images.

@fix

Reviewers: #committers

Subscribers: kimcinoo, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6739

Change-Id: I64f4b5a6ca68feba086f05b3d8da5e5110416345

5 years agoevas_image: do not render while preloading
Shinwoo Kim [Wed, 8 Aug 2018 04:51:40 +0000 (13:51 +0900)]
evas_image: do not render while preloading

Summary:
Unexpected image shows if image data is not ready.
Even though there is a change to check the 'preloading' in pre_render phase,
evas_object_image_render is called. So we need to check here as well.

Reference: https://phab.enlightenment.org/D6739

It seems that the 'preloading' is not enough. The 'preloading' could be reset
to FALSE by _evas_image_load_async_cancel > _image_preload_internal.

If the following step happens, then this patch set is neccessary.
(1) evas_object_image_pre_render
(2) _evas_iamge_load_async_start
(3) evas_object_image_render

I could not find out what the correct step, but it actullay happens.
The evas_object_image_render could be called with the 'preloading' TURE.

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6778

Change-Id: I0b0d941868ee53bd4f89a0895b029034b6f035f2

5 years agoelementary image: don't calc size using empty ones.
Hermet Park [Wed, 8 Aug 2018 06:52:37 +0000 (15:52 +0900)]
elementary image: don't calc size using empty ones.

Summary:
Zero-sized image occasionally happens.
That occurs insane img/clipper region.

bj size => (w, h) then resize => (0, 0)
file_set(xx.jpg) then file_set (NULL)

Because of this, region could be flickered during prev/cur preloading images.

@fix

Reviewers: #committers, zmike

Subscribers: #reviewers, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6725

Change-Id: If3f01f66efe2eef6f62520dabbb6237d68dfb8b5

5 years agoatspi: check service, bus and path names for Dbus communication 68/186668/2
Lukasz Wlazly [Mon, 13 Aug 2018 08:54:22 +0000 (10:54 +0200)]
atspi: check service, bus and path names for Dbus communication

This patch provides some functions to check and sanitize
improper Dbus bus and path identificators.

Change-Id: I558c4f41ce72321272db3db433f259c4d6f08387

5 years agoRevert "evas engines: do not immediately free native surface when unsetting it" 87/186787/1
Yeongjong Lee [Tue, 14 Aug 2018 09:41:23 +0000 (18:41 +0900)]
Revert "evas engines: do not immediately free native surface when unsetting it"

This reverts commit c0ddc1b6a0dc710f4220250b40fd67234cb4ff9a.

@tizen-fix

Change-Id: I2426a5e602b1da688302555c943c9f01002066f6
Signed-off-by: Yeongjong Lee <yj34.lee@samsung.com>
5 years agoefl_ui_popup_alert_text: apply tizen theme for label 24/186224/1
Taehyub Kim [Wed, 8 Aug 2018 06:54:29 +0000 (15:54 +0900)]
efl_ui_popup_alert_text: apply tizen theme for label

Change-Id: I1c5a30990bf08f2d42262eb75de9f53a7ffffb9e

5 years agoecore_evas: use timer for animator
Shinwoo Kim [Mon, 18 Jun 2018 10:36:10 +0000 (19:36 +0900)]
ecore_evas: use timer for animator

[Problem]
The animator on the wayland ecore_evas engine used wl_surface frame callback
as its source(of _ecore_evas_tick_source_find). This made wl_surface_commit
be called too much and caused the Enlightenment performance issue.

[Solution]
So this patch set is using the timer for animator source.
The animator is working without intervention of the Enlightenment.

@tizen_only

Change-Id: Id20a95a35107454a908397eeb3640d7f6650ef2d

5 years agoefl_selection: check the sel lost object to prevent invalid acesss
Taehyub Kim [Tue, 7 Aug 2018 06:23:53 +0000 (15:23 +0900)]
efl_selection: check the sel lost object to prevent invalid acesss

Change-Id: Iad7928d7da691e96dcce6b409f756ac80342a353

5 years agotests/eolian: remove eolian_decl test
Mike Blumenkrantz [Tue, 7 Aug 2018 16:10:22 +0000 (12:10 -0400)]
tests/eolian: remove eolian_decl test

Summary:
<q66> just remove decl.eo and remove the eolian_decl test; it's useless
<q66> the reason: it used to be testing some specific API, which got replaced with more generalized API that is now used everywhere in the tests, so that specific test no longer has a purpose

resolves some compile errors due to type conflicts

Reviewers: q66

Reviewed By: q66

Subscribers: cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6773

5 years agoelm_genlist: fix item registration by correct realization
Marcel Hollerbach [Tue, 7 Aug 2018 04:25:34 +0000 (13:25 +0900)]
elm_genlist: fix item registration by correct realization

Summary:
there was a case when a block could be realized while a item that is
realized was brought from one block to the this new one. The block now
is simply realized using api instead of just setting the flag, this sets
the correct focus registrations. While fixing this the error of double
regiration of items came up, this is also fixed by unregistration and
reregistration in the correct block.

fix T7247

Reviewers: zmike, SanghyeonLee, YOhoho

Reviewed By: zmike

Subscribers: Hermet, cedric, #committers

Tags: #efl

Maniphest Tasks: T7247

Differential Revision: https://phab.enlightenment.org/D6737

5 years agoecore-evas/wayland: fix parent setting on canvas creation
Mike Blumenkrantz [Mon, 6 Aug 2018 19:18:14 +0000 (15:18 -0400)]
ecore-evas/wayland: fix parent setting on canvas creation

Summary:
use the correct pointer when applying the passed parent object in order to
successfully set the parent

ref 78f27a3efff24ba3b935cc9e2620718e51af9304

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers

Tags: #efl_display_system

Differential Revision: https://phab.enlightenment.org/D6757

Change-Id: Iad0aeeb7542a3e6145c986434aa92b5d8a97fd3f

5 years agoevas image: code refactoring.
Hermet Park [Mon, 6 Aug 2018 11:23:48 +0000 (07:23 -0400)]
evas image: code refactoring.

Summary: remove duplicated, no logical changes.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6738

5 years agoelm_genlist: remove unused function
Marcel Hollerbach [Mon, 6 Aug 2018 07:38:58 +0000 (16:38 +0900)]
elm_genlist: remove unused function

Summary:
this got replaced by the none composition implementation and is not
required anymore.

Depends on D6737

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6752

Change-Id: I025bda18f9a6b67229a2ef33cc89a332a48e26ba

5 years agoelm_genlist: fix ghost objects from the genlist cache
Marcel Hollerbach [Mon, 6 Aug 2018 07:34:05 +0000 (16:34 +0900)]
elm_genlist: fix ghost objects from the genlist cache

Summary:
the cache simply moved the objects to -9999 -9999 while leaving them
visible and focusable. Hiding them does not work since edje makes it
visible all the time again. Making them unfocusable fixes this.
Depends on D6752

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6753

Change-Id: I3e7ee3f04aa9f18110ca07305134dd56ca9be8cf

5 years agotests/elm: when using buffer engine, clamp render and edje timing to 0.05s
Mike Blumenkrantz [Mon, 6 Aug 2018 07:26:52 +0000 (16:26 +0900)]
tests/elm: when using buffer engine, clamp render and edje timing to 0.05s

Summary:
this sets manual render on buffer engine windows and dumps the render at every
interval in order to avoid doing any real rendering or animating or having to
wait on some irrelevant timing.

tests using buffer engine just want to complete as fast as possible, as they are
never being displayed anywhere, so just perform canvas operations (recalcs mostly)
and BAIL

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers

Tags: #efl_tests

Differential Revision: https://phab.enlightenment.org/D6749

5 years agotest/evas: add to check smart class overriding
Shinwoo Kim [Mon, 6 Aug 2018 07:21:55 +0000 (16:21 +0900)]
test/evas: add to check smart class overriding

Summary:
If Evas_Smart_Class.move is overridden,
then user defined move function should be used.
Check if "https://phab.enlightenment.org/D6468" works or not.

Reviewers: zmike

Subscribers: cedric, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6740

5 years agoelm_code_widget: match bg color with widget color.
Alastair Poole [Sun, 5 Aug 2018 20:13:39 +0000 (21:13 +0100)]
elm_code_widget: match bg color with widget color.

Test Plan: elm_test -> "Code Editor" -> Consistent widget colours.

Reviewers: #committers, ajwillia.ms, zmike

Reviewed By: #committers, ajwillia.ms

Subscribers: cedric

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6719

5 years agoci: add build time to IRC notification
Mike Blumenkrantz [Mon, 23 Jul 2018 14:27:53 +0000 (10:27 -0400)]
ci: add build time to IRC notification

this will be useful while profiling CI builds to know whether a patch
has made builds slower so that it can potentially be examined

Differential Revision: https://phab.enlightenment.org/D6666

5 years agoci: remove --always-build-examples from misc build
Mike Blumenkrantz [Sun, 22 Jul 2018 16:01:47 +0000 (12:01 -0400)]
ci: remove --always-build-examples from misc build

these should only be explicitly built by the examples target or built
during distcheck

Differential Revision: https://phab.enlightenment.org/D6665

5 years agobuild: remove infuriating VTIME build define
Mike Blumenkrantz [Sun, 22 Jul 2018 02:22:17 +0000 (22:22 -0400)]
build: remove infuriating VTIME build define

this does nothing but ruin your entire ccache every time configure runs.

ref cae354d299688304f609c5f064702891f02260b9
ref T5495

Differential Revision: https://phab.enlightenment.org/D6662

5 years agobuild: remove BUILT_SOURCES usage from cxx examples makefiles
Mike Blumenkrantz [Fri, 20 Jul 2018 21:46:44 +0000 (17:46 -0400)]
build: remove BUILT_SOURCES usage from cxx examples makefiles

ref T7154

Differential Revision: https://phab.enlightenment.org/D6656

5 years agobuild: move src/examples/ to a single makefile
Mike Blumenkrantz [Wed, 18 Jul 2018 21:55:09 +0000 (17:55 -0400)]
build: move src/examples/ to a single makefile

this greatly improves build times by improving parallelizing, though it
does introduce more BUILT_SOURCES usage which causes builds with cxx
bindings to take significantly longer

fix T7157
ref T7154

Differential Revision: https://phab.enlightenment.org/D6633

5 years agoelm/genlist: use correct type of list when iterating
Mike Blumenkrantz [Thu, 2 Aug 2018 20:42:56 +0000 (16:42 -0400)]
elm/genlist: use correct type of list when iterating

itb-items is Eina_List, not Eina_Inlist. this crashes due to wrong type
use

ref D6720
fix T7246

Differential Revision: https://phab.enlightenment.org/D6736

5 years agogenlist: rework the focus model for performance
Marcel Hollerbach [Thu, 2 Aug 2018 13:42:06 +0000 (09:42 -0400)]
genlist: rework the focus model for performance

Summary:
the focus model before was more meant for simplicity and not for
performance, this now is more made for performance.

The performance boost is achived by not using composition anymore,
but rather register realized items by hand. This keeps the amount
of items bound to the size of the viewport.

Additionally item realization that is followed by unrealization
immediately is not resulting in focus calls.

This solves the performance issue from T6580 in regards of focus.

perf results after this:
http://www.enlightenment.org/ss/e-5b61b50657f3c3.82619729.png

Reviewers: ManMower, zmike

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6720

Change-Id: I5b753db6fca3d1feed5e4f13d7e08da717d9977e

5 years agoelementary image: apply lazy calculation and guarantee retained method.
Hermet Park [Thu, 2 Aug 2018 13:22:59 +0000 (09:22 -0400)]
elementary image: apply lazy calculation and guarantee retained method.

Summary:
Image couldn't gurantee retained concept status.
This patch change to setting up image object on the request time,
recovering image status, removing unencessary jobs.

Reviewers: #committers

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6726

Change-Id: I8aec4de5c865d5110d1d317094e8f31a8aba9e71

5 years agoecore: fix that timers are not called in the order they were registered.
Hosang Kim [Thu, 2 Aug 2018 13:14:15 +0000 (09:14 -0400)]
ecore: fix that timers are not called in the order they were registered.

Summary:
Timers are not called in the order they were registered.
Because when current timer is deleted, getting next timer is called twice.

Test Plan:
<error>
Timer1 expired after 0.001 seconds.
Timer3 expired after 0.001 seconds.
Timer5 expired after 0.001 seconds.
Timer7 expired after 0.001 seconds.
Timer2 expired after 0.001 seconds.
Timer6 expired after 0.001 seconds.
Timer4 expired after 0.001 seconds.
Timer8 expired after 0.001 seconds.
<correct>
Timer1 expired after 0.001 seconds.
Timer2 expired after 0.001 seconds.
Timer3 expired after 0.001 seconds.
Timer4 expired after 0.001 seconds.
Timer5 expired after 0.001 seconds.
Timer6 expired after 0.001 seconds.
Timer7 expired after 0.001 seconds.
Timer8 expired after 0.001 seconds.|

{F3268233}

Reviewers: Hermet, Jaehyun_Cho, zmike, SanghyeonLee

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl_tests

Differential Revision: https://phab.enlightenment.org/D6700

5 years agoEfl.Canvas.Group: use desired function
Shinwoo Kim [Thu, 2 Aug 2018 13:10:41 +0000 (09:10 -0400)]
Efl.Canvas.Group: use desired function

Summary:
If a smart class overrides Evas_Smart_Class.move as below,
then original behavior must not be used for the smart class.

   Evas_Smart_Class sc = EVAS_SMART_CLASS_INIT_NAME_VERSION("MyClass");
   evas_object_smart_clipped_smart_set(&sc);
   sc.move = &myMove;

But current implementation makes original behavior work.
So before using the original method, this patch is checking if the original
method is changed or not.

Reviewers: zmike, devilhorns

Reviewed By: zmike

Subscribers: woohyun, jypark, cedric, raster, jpeg, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6468

5 years agoelementary bg: fix to guarantee compatibility.
Hermet Park [Thu, 2 Aug 2018 13:08:43 +0000 (09:08 -0400)]
elementary bg: fix to guarantee compatibility.

Summary: This is additional fix to b9b209f60f040d0afbccc1db0c96c8e36d14e682.

Reviewers: #committers, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6727

5 years agoelm/genlist: remove conditional in _calc_job for verifying show_item code
Mike Blumenkrantz [Wed, 27 Jun 2018 20:53:55 +0000 (16:53 -0400)]
elm/genlist: remove conditional in _calc_job for verifying show_item code

I think at some point in the past this was necessary to avoid weird show
mechanics, but now things have changed and it's best to always attempt to
scroll and let the scroller internals figure things out

this resolves the case where attempting to scroll to an item during a genlist's
calc (ie. the item was not present in a full layout calc) would fail to scroll
to the item if the scroll method was TOP and the item was too close to the
bottom of the list

fix T6368
@fix

Differential Revision: https://phab.enlightenment.org/D6466

5 years agoevas_events: Fix to set mouse_in state to all pointers in the seat.
Jaehyun Cho [Thu, 2 Aug 2018 09:16:46 +0000 (18:16 +0900)]
evas_events: Fix to set mouse_in state to all pointers in the seat.

Summary:
mouse coordinate is set by seat.
Therefore, mouse_in state should be set based on seat.
As a result, mouse_in state of all pointers in the seat should be
updated at the same time.

Reviewers: eagleeye, devilhorns, zmike

Reviewed By: eagleeye, devilhorns, zmike

Subscribers: devilhorns, Hermet, kimcinoo, cedric, iscaro, zmike, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6699

5 years agoedje: add back function prototype for edje_object_color_class_description_get
Mike Blumenkrantz [Mon, 30 Jul 2018 11:12:31 +0000 (07:12 -0400)]
edje: add back function prototype for edje_object_color_class_description_get

this was removed in D4403

Differential Revision: https://phab.enlightenment.org/D6694

5 years agoevas sdl: don't make confusing, we only use one-indexed egl handles.
Hermet Park [Thu, 2 Aug 2018 03:20:27 +0000 (12:20 +0900)]
evas sdl: don't make confusing, we only use one-indexed egl handles.

Reviewers: ManMower

Subscribers: devilhorns, cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6693

5 years agoelementary: efl_ui_view_list cleanup
Felipe Magno de Almeida [Wed, 1 Aug 2018 22:45:36 +0000 (19:45 -0300)]
elementary: efl_ui_view_list cleanup

Summary:
private data cleanup
removed callbacks

Reviewers: felipealmeida, SanghyeonLee

Reviewed By: felipealmeida

Subscribers: Hermet

Differential Revision: https://phab.enlightenment.org/D6707

Change-Id: I20c7af06992ba7b03ab72ff773c6f7a866e0f75e

5 years agoEfl.Ui.Layout.Factory: added missing factory_model_connect
Felipe Magno de Almeida [Wed, 1 Aug 2018 21:42:13 +0000 (18:42 -0300)]
Efl.Ui.Layout.Factory: added missing factory_model_connect

Summary:
connect factory to edje part name
when create a new layout connect a factory to it
change example to use the factory_model_connect

Reviewers: felipealmeida

Differential Revision: https://phab.enlightenment.org/D6667

5 years agobuild: disable Lua binding generation
Daniel Kolesa [Wed, 1 Aug 2018 17:31:15 +0000 (13:31 -0400)]
build: disable Lua binding generation

Summary:
As Lua bindings don't work right now, it is pointless to waste
build time generating them. Elua itself on the other hand is
useful and should stay enabled.

This also does some preparation work for separate configure
switch for bindings after release, but for now keep configure
switches as they are.

Reviewers: zmike, stefan_schmidt

Subscribers: cedric, bu5hm4n, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6721

5 years agoci: print config.log if configure fails
Mike Blumenkrantz [Wed, 1 Aug 2018 00:05:07 +0000 (20:05 -0400)]
ci: print config.log if configure fails

Differential Revision: https://phab.enlightenment.org/D6717

5 years agoci: explicitly set PKG_CONFIG_PATH for openssl
Mike Blumenkrantz [Wed, 1 Aug 2018 02:38:03 +0000 (22:38 -0400)]
ci: explicitly set PKG_CONFIG_PATH for openssl

travis upgraded to macos high sierra overnight without notification(?)
and this is now required in order to find openssl for some reason

also disable config.cache to prevent configure errors

Differential Revision: https://phab.enlightenment.org/D6718

5 years agottrace: apply ttrace log system. 02/182902/4
Hosang Kim [Thu, 28 Jun 2018 11:17:46 +0000 (20:17 +0900)]
ttrace: apply ttrace log system.

@tizen_fix

Change-Id: I31526279b4ca1f6b15f01c157b385bcf4b2a14a1

5 years agoneon: fix a build fail on aarch64
Wonki Kim [Wed, 1 Aug 2018 12:02:34 +0000 (21:02 +0900)]
neon: fix a build fail on aarch64

there is a tizen only code on draw_convert.c.
and it make a build fail on aarch64.
this patch fix it.

Change-Id: I3b1270f5bb2258aca241222843b96e5d4bf8f82a
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
5 years agoevas gl_tbm: don't make confusing, we only use one-indexed egl handles.
Hermet Park [Mon, 30 Jul 2018 06:25:08 +0000 (15:25 +0900)]
evas gl_tbm: don't make confusing, we only use one-indexed egl handles.

Change-Id: I7d2708707b9d80e27ea4f21dc01702cd1ce5f9da

5 years agoregion_add: Fix copying wrong rect during smart merge
Yeshwanth Reddivari [Mon, 30 Jul 2018 16:34:44 +0000 (22:04 +0530)]
region_add: Fix copying wrong rect during smart merge

Summary:
    When testing partial rendering on TV, found this bug.
    Probably this was caused because of wrong copy/paste.
    When region1 completely subsumes region2, region2 should be ignored.
    But currently region2 is copied to region1 which makes region1 rect completly wrong.
    This was causing lot of visual defects because of wrong rects.
    This patch will fix those visual defects when partial rendering is enabled.

Test Plan: Tested with the patch on TV after enabling partial rendering.

Differential Revision: https://phab.enlightenment.org/D6696

Change-Id: I63c2d91e48a29311562d116ccb03c1a0e2db4ed1
Signed-off-by: Yeshwanth Reddivari <yashu21985@gmail.com>
5 years agoevas_tbm : Send correct eglSurface and Remove duplicate SetDamageRegion
Yeshwanth Reddivari [Fri, 27 Jul 2018 20:29:54 +0000 (01:59 +0530)]
evas_tbm : Send correct eglSurface and Remove duplicate SetDamageRegion

As per the spec https://www.khronos.org/registry/EGL/extensions/KHR/EGL_KHR_partial_update.txt,
its an error to call multiple eglSetDamageRegionKHR within same frame boundary.
So, removed the duplicate SetDamageRegion.
Also, wrong eglSurface was passed to DDK which caused issue in partial rendering

Change-Id: I70a5bda0aa5fee9785264f2528d9e184201ddb07
Signed-off-by: Yeshwanth Reddivari <r.yeshwanth@samsung.com>
5 years agocanvas render: stop render_pre/post cb if it didn't render.
Hermet Park [Thu, 12 Jul 2018 13:14:32 +0000 (09:14 -0400)]
canvas render: stop render_pre/post cb if it didn't render.

Summary:
Basically, render_pre/post should be called only if rendering happens.
Unfortunately, this behavior had been broken by some mistakes.

As far as I understand after reading history carefully,
this issue introduced for fixing unpair of pre/post cbs.

In case of async render, the post callback would be triggered in
evas_render_pipe_wakeup(), it means POST callbake shouldn't be tiggered in
evas_render_updates_internal(). If that post callback were removed in
evas_render_updates_internal(), then in case of sync_render,
POST callback won't be triggered. So previously, the PRE/POST couldn't get
paired.

I guess cedric put a mistake that nothing2rendering which brought
the pre/post pair issue, even he said that patch fix the unpair of them.
(But actually that patch brought the issue!)

See this: dc841ed9b2ccf880df2d7590ea46d95e03e8752f

Whatever it was intented or not, that patch totally insane, even
non-descripting.

If we just trigger post cb only if sync render or no_rendered case,
We could make satisfication for both cases.

@fix

Reviewers: #committers, devilhorns, zmike

Reviewed By: #committers, zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6573

Change-Id: I267072faf71838b0ff4902b5c45e499a3f2af423

5 years agoecore_wl2_dnd: Supporting copy and paste for cbhm
Taehyub Kim [Thu, 26 Jul 2018 06:15:45 +0000 (15:15 +0900)]
ecore_wl2_dnd: Supporting copy and paste for cbhm

- cbhm needs multiple mimetypes when selection occurs

Change-Id: I4b80e8df2615a5904cb122e8af5aaeae48e9385e

5 years agoefl_selection_manager, ecore_wl2_dnd: Supporting Drag and Drop
Taehyub Kim [Thu, 26 Jul 2018 06:04:17 +0000 (15:04 +0900)]
efl_selection_manager, ecore_wl2_dnd: Supporting Drag and Drop

- There is a problem that the visibility of drag_win(ELM_WIN_DND) depends on the order of show and resize.
  Normally, The order should not be matter, but drag_win is visible in show and resize order not resize and show order.
  So It should be fixed later.
- Ecore_Wl2_Event_Dnd_End is changed to Ecore_Wl2_Event_Data_Source_End in efl_selection_manager.c to make it consistency.
- Serial logic in efl_selection_manager.c is not stable now, so disable it.

Change-Id: I67aa5a4fb4f4c26192a2a638ca45063dc2457c49

5 years agoRevert "Revert "efl_ui_win: add missing wayland interface for setting role of winodw""
Taehyub Kim [Thu, 26 Jul 2018 08:09:16 +0000 (17:09 +0900)]
Revert "Revert "efl_ui_win: add missing wayland interface for setting role of winodw""

This reverts commit 95b7a0938871585491ebe10e53ed04f53b3afde9.

Change-Id: I7d54541fa2403c64f1d4752add898ef741d1707b

5 years agoevas : apply tizen only for evas gl thread support
SangHyeon Jade Lee [Wed, 1 Aug 2018 05:30:34 +0000 (14:30 +0900)]
evas : apply tizen only for evas gl thread support

Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
5 years agoelm/bg: call color_set up the class chain internally
Mike Blumenkrantz [Tue, 31 Jul 2018 22:49:57 +0000 (18:49 -0400)]
elm/bg: call color_set up the class chain internally

Summary:
this ensures that the color_set call is propagated correctly, resulting
eventually in a call to the smart clipped class method for color_set which
will change the opacity of the edje object in addition to the bg widget's
internal rect object

this seems to have been a regression created during the move to the interfaces
version of the bg widget

fix T7232

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7232

Differential Revision: https://phab.enlightenment.org/D6716

5 years agoelementary: Check for valid object before calling smart calculate
Chris Michael [Tue, 31 Jul 2018 21:23:46 +0000 (17:23 -0400)]
elementary: Check for valid object before calling smart calculate

Summary:
Small patch fixes an issue where evas_object_smart_calculate was being
called with a NULL box.

ref T7030
Depends on D6704

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #committers, zmike

Tags: #efl

Maniphest Tasks: T7030

Differential Revision: https://phab.enlightenment.org/D6710