caryclark [Wed, 7 Jan 2015 15:36:52 +0000 (07:36 -0800)]
revert buildbot breaker
Hals's change broke a buildbot has shown here
http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/510/steps/gm/logs/stdio
Got unknown flag "--useDocumentInsteadOfDevice". Exiting.
TBR=halcanary
Review URL: https://codereview.chromium.org/
832183006
kkinnunen [Wed, 7 Jan 2015 15:33:46 +0000 (07:33 -0800)]
debugger: Update inspector view data consistently while paused
Make all fields of inspector view (details tab, clipstack tab, geometry
view) update the correct info when user selects a draw command. Also
update the info regardless if the painting is paused or not.
Current clip and matrix will not update consistently even after this
patch, as they depend on stateful debug canvas draw (may be fixed
later).
Review URL: https://codereview.chromium.org/
835903002
skia.buildbots [Wed, 7 Jan 2015 15:31:47 +0000 (07:31 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
843493002
robertphillips [Wed, 7 Jan 2015 15:28:41 +0000 (07:28 -0800)]
Rename SkDrawPictureCallback to SkPicture::AbortCallback
Committed: https://skia.googlesource.com/skia/+/
7ef197255deb4e2fa64c03c7130d56ddf164e83c
Review URL: https://codereview.chromium.org/
829983003
egdaniel [Wed, 7 Jan 2015 15:26:39 +0000 (07:26 -0800)]
Rebasing more conic stuff
TBR=
NOTRY=True
NOTREECHECKS=True
BUG=skia:
Review URL: https://codereview.chromium.org/
837913002
reed [Wed, 7 Jan 2015 15:04:09 +0000 (07:04 -0800)]
rebaseline after use-conics
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
800193004
egdaniel [Wed, 7 Jan 2015 14:51:02 +0000 (06:51 -0800)]
More rebases from conic change
TBR=
NOTRY=True
NOTREECHECKS=True
BUG=skia:
Review URL: https://codereview.chromium.org/
841693003
reed [Wed, 7 Jan 2015 14:08:50 +0000 (06:08 -0800)]
rebaseline after use-conics
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
841703002
reed [Wed, 7 Jan 2015 00:26:16 +0000 (16:26 -0800)]
use conics for ovals and roundrects
This reverts commit
e3b61eb7997d12c5f9b844dd3af1847492d9f411.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
834303002
reed [Wed, 7 Jan 2015 00:15:25 +0000 (16:15 -0800)]
Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (patchset #2 id:20001 of https://codereview.chromium.org/
829983003/)
Reason for revert:
speculative revert to unblock DEPS roll
Original issue's description:
> Rename SkDrawPictureCallback to SkPicture::AbortCallback
>
> Committed: https://skia.googlesource.com/skia/+/
7ef197255deb4e2fa64c03c7130d56ddf164e83c
TBR=reed@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
824013004
halcanary [Tue, 6 Jan 2015 23:13:49 +0000 (15:13 -0800)]
Remove SkPDFDocument and SkPDFDevice from the public headers.
Committed: https://skia.googlesource.com/skia/+/
8b1f761365df6652ea9304b6572d2dd91917b9aa
Review URL: https://codereview.chromium.org/
841533002
tomhudson [Tue, 6 Jan 2015 20:59:05 +0000 (12:59 -0800)]
Comment out unused names in src/core/SkGlyphCache.h
Android violates our encapsulation and depends on this file;
to keep their compiles clean they want us to hide the names
of unused parameters.
Follow-up to https://codereview.chromium.org/
726923002/.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
839583005
robertphillips [Tue, 6 Jan 2015 20:26:08 +0000 (12:26 -0800)]
Rename SkDrawPictureCallback to SkPicture::AbortCallback
Review URL: https://codereview.chromium.org/
829983003
reed [Tue, 6 Jan 2015 19:30:45 +0000 (11:30 -0800)]
will write a custom one for blink later
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
810603003
reed [Tue, 6 Jan 2015 17:55:33 +0000 (09:55 -0800)]
rebaseline after conic fixes
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
831993004
reed [Tue, 6 Jan 2015 17:54:13 +0000 (09:54 -0800)]
Revert "Remove SkPDFDocument and SkPDFDevice from the public headers."
This reverts commit
8b1f761365df6652ea9304b6572d2dd91917b9aa.
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
839603002
halcanary [Tue, 6 Jan 2015 17:30:10 +0000 (09:30 -0800)]
Remove SkPDFDocument and SkPDFDevice from the public headers.
Review URL: https://codereview.chromium.org/
841533002
robertphillips [Tue, 6 Jan 2015 17:17:02 +0000 (09:17 -0800)]
Require explicit disabling of cross process pictureimagefilters
This is to allow capturing .skp files with their pictureimagefilters intact.
This is a companion to https://codereview.chromium.org/
810933004/ (Provide a way of allowing cross process pictureimagefilters).
Review URL: https://codereview.chromium.org/
834673006
reed [Tue, 6 Jan 2015 15:44:21 +0000 (07:44 -0800)]
fixes for conics
- use std tolerance in edgebuilder, since the path has not been scaled-up to its super-sample size (that happens in the builder methods.
- off-by-1 fix for pathops when using the output of the conicquadder
BUG=skia:
Review URL: https://codereview.chromium.org/
837023002
reed [Tue, 6 Jan 2015 15:39:55 +0000 (07:39 -0800)]
add --listfailingbase option
BUG=skia:
Review URL: https://codereview.chromium.org/
833223002
skia.buildbots [Tue, 6 Jan 2015 15:19:59 +0000 (07:19 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
840533002
reed [Tue, 6 Jan 2015 15:17:49 +0000 (07:17 -0800)]
Revert of use conics for ovals and roundrects (patchset #1 id:1 of https://codereview.chromium.org/
817283005/)
Reason for revert:
need fix in edgebuilder+aa
Original issue's description:
> use conics for ovals and roundrects
>
> adapted from https://codereview.chromium.org/
831313002/
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
2bf1c4d58b84c73c6421edcb25e3afb4971da200
TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
840573002
reed [Tue, 6 Jan 2015 15:13:19 +0000 (07:13 -0800)]
improve sanity checks on gradient constructor parameters
BUG=445807
Review URL: https://codereview.chromium.org/
837013002
reed [Tue, 6 Jan 2015 15:12:42 +0000 (07:12 -0800)]
Revert of add missed tests for conics (patchset #1 id:1 of https://codereview.chromium.org/
835993004/)
Reason for revert:
need to fix edgebuilder+aa
Original issue's description:
> add missed tests for conics
>
> BUG=skia:
> TBR=
> NOTRY=True
> NOTREECHECKS=True
>
> Committed: https://skia.googlesource.com/skia/+/
6b0f701687edcdfc4fc996aed085054912866aff
TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
797403003
reed [Tue, 6 Jan 2015 05:01:40 +0000 (21:01 -0800)]
add missed tests for conics
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
835993004
reed [Tue, 6 Jan 2015 04:15:28 +0000 (20:15 -0800)]
use conics for ovals and roundrects
adapted from https://codereview.chromium.org/
831313002/
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
817283005
tfarina [Tue, 6 Jan 2015 01:18:51 +0000 (17:18 -0800)]
Cleanup: More override fixes - another round.
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
831113002
fmalita [Tue, 6 Jan 2015 00:10:37 +0000 (16:10 -0800)]
Rebaseline thinstrokedrects GM
BUG=skia:3278
TBR=caryclark@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
836023002
kkinnunen [Mon, 5 Jan 2015 20:58:56 +0000 (12:58 -0800)]
Remove draw window size state from SkDebugCanvas
The SkDebugCanvas can be (or is currently) being used to draw to multiple
different canvases. If this use-case is intended, then storing draw
-related state in the canvas causes bugs.
Remove draw window size state form SkDebugCanvas. Instead, use the canvas
base layer size as the window size to clip to. This is consistent with
the current use in debugger.
This is part of work trying to remove bugs in debugger that result from
replaying one SkDrawCanvas to two different canvases. Currently the
SkDrawCanvas stores state that can only be valid if it is used for one
canvas.
Review URL: https://codereview.chromium.org/
835113002
egdaniel [Mon, 5 Jan 2015 20:55:46 +0000 (12:55 -0800)]
Rebase perspective gpu gm's after conic change
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
831333002
robertphillips [Mon, 5 Jan 2015 20:29:15 +0000 (12:29 -0800)]
Cap id size returned by GrScratchKey::GenerateResourceType
kkinnunen@ has been seeing compiler warnings on GrScratchKey::GenerateResourceType (https://codereview.chromium.org/
833913002/ - Cast the scratch resource key in order to fix a warning)(presumably due to the unsigned/signed comparison in kInvalidResourceType == type). This CL limits the returned id to its effective range to, hopefully, clarify the whole int32_t -> uint32_t conversion & wrapping problem.
Review URL: https://codereview.chromium.org/
827923006
robertphillips [Mon, 5 Jan 2015 20:22:14 +0000 (12:22 -0800)]
Remove SkPath::asRect
AFAICT the asRect entry point is not needed.
Greg: GPU
Reed: API
Cary: Path
Review URL: https://codereview.chromium.org/
833193002
kkinnunen [Mon, 5 Jan 2015 19:51:13 +0000 (11:51 -0800)]
debugger: Update the picture view when the first command is selected
Update the picture view in the debugger when the first command is
selected. DebugCanvas::drawTo(index) draws up to and including the index.
Review URL: https://codereview.chromium.org/
837483002
fmalita [Mon, 5 Jan 2015 19:31:02 +0000 (11:31 -0800)]
Fix thin rect stroking.
When both edges of a thin (sub-unit) stroke fall within the same pixel, we compute the wrong coverage and also blit the same line twice.
To avoid these issues, tweak the inner/outer hulls to ensure one of the edges is always pixel-aligned.
BUG=skia:3278
R=reed@google.com
Review URL: https://codereview.chromium.org/
819253003
jcgregorio [Mon, 5 Jan 2015 19:17:27 +0000 (11:17 -0800)]
First set of minimal docs for the new Markdown server, which will eventually replace https://sites.google.com/site/skiadocs/.
Design of the new Markdown server is documented here:
https://github.com/google/skia-buildbot/blob/master/doc/README.md
You can see the server up and running here: http://skiadocs.com:8000/
This is *reed because it adds a new top level directory to the skia repo.
BUG=skia:
Review URL: https://codereview.chromium.org/
835083003
robertphillips [Mon, 5 Jan 2015 19:11:21 +0000 (11:11 -0800)]
Update PdfViewer's SkNulCanvas
This appears to have been missed in https://codereview.chromium.org/
831253002/ (move remaining virtual draw methods to onDraw)
Review URL: https://codereview.chromium.org/
839433002
egdaniel [Mon, 5 Jan 2015 18:22:28 +0000 (10:22 -0800)]
Add conic support to Default and AAConvex path redender.
This is achieved but chopping up conics into quads.
With this change conics should be ready to be used on the gpu side of things
BUG=skia:3258
Review URL: https://codereview.chromium.org/
825443002
robertphillips [Mon, 5 Jan 2015 18:13:46 +0000 (10:13 -0800)]
Cleanup isRect variants
Review URL: https://codereview.chromium.org/
832083002
reed [Mon, 5 Jan 2015 18:01:25 +0000 (10:01 -0800)]
Revert of Revert of enable conics gm (patchset #1 id:1 of https://codereview.chromium.org/
811863006/)
Reason for revert:
maybe this wasn't the cause of the chromeos crash?
Original issue's description:
> Revert of enable conics gm (patchset #3 id:40001 of https://codereview.chromium.org/
835593002/)
>
> Reason for revert:
> did I break the build?
>
> Original issue's description:
> > enable conics gm
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/
03119ba4f815bc2c2774a9349ca8278ab1695072
>
> TBR=egdaniel@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
ede901c7a2e21a44552b8c1436d9521ce33f4de5
TBR=egdaniel@google.com,reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
836773002
robertphillips [Mon, 5 Jan 2015 17:20:04 +0000 (09:20 -0800)]
Print out failing PathRef test on ChromeOS
This is intended to provide additional information for a flaky assertion failure on ChromeOS Daisy.
BUG=skia:3282
Review URL: https://codereview.chromium.org/
821683002
halcanary [Mon, 5 Jan 2015 16:55:34 +0000 (08:55 -0800)]
Correctly declare skiagm::DCShader to be not flattenable.
Motivation: As part of my testing I serialize all of our GMs to SKP
files. This was breaking my code.
Review URL: https://codereview.chromium.org/
832393002
halcanary [Mon, 5 Jan 2015 16:55:24 +0000 (08:55 -0800)]
experimental skp_to_pdf_md5 program.
This program takes a list of Skia Picture (SKP) files and
renders each as a multipage PDF, then prints out the MD5
checksum of the PDF file. This can be used to verify that
changes to the PDF backend will not change PDF output.
Review URL: https://codereview.chromium.org/
832403002
joshualitt [Mon, 5 Jan 2015 16:34:28 +0000 (08:34 -0800)]
removing dashcubics from ignore, may cause failures
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
834673004
reed [Mon, 5 Jan 2015 15:49:08 +0000 (07:49 -0800)]
Revert of Revert of move remaining virtual draw methods to onDraw (patchset #1 id:1 of https://codereview.chromium.org/
835913002/)
Reason for revert:
test to see if it wasn't this CL that broke chromeos
Original issue's description:
> Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/
817723005/)
>
> Reason for revert:
> did this cause chromeos heap corruption on skp?
>
> Original issue's description:
> > move remaining virtual draw methods to onDraw
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
2e0f7d53bba5438c9bf11ee5ccae2c301e348419
>
> TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
e87e383351e1547b21d96d02bcd0c3cbbe0837f1
TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com,reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
831253002
mtklein [Mon, 5 Jan 2015 15:02:45 +0000 (07:02 -0800)]
Clean up dead clear() code in SkRecord.
This removes the SkRecords::Clear struct and everything that refers to it.
Notice there is nothing actually creating a Clear, which means this is all
dead code.
Now that all ops obey the clip, I don't think we need the weird
inflate-empty-to-epsilon hack for BBH queries.
BUG=skia:
Review URL: https://codereview.chromium.org/
835813002
reed [Mon, 5 Jan 2015 14:47:44 +0000 (06:47 -0800)]
add SkGeometry.h to core.gypi
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
820683005
mtklein [Mon, 5 Jan 2015 14:47:41 +0000 (06:47 -0800)]
dm/gold: Let's consider source_type a key.
Ex.
"results" : [
{
"key" : {
"config" : "565",
"mode" : "direct",
"name" : "textblob",
"source_type" : "GM"
},
"md5" : "
024ecfc3be8c08ea0cc580c12411fe09"
},
BUG=skia:3255
Review URL: https://codereview.chromium.org/
811403003
borenet [Mon, 5 Jan 2015 14:38:26 +0000 (06:38 -0800)]
Whitespace change to trigger rebuilds after gsutil fix
BUG=434422
TBR=rmistry
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
776463003
reed [Mon, 5 Jan 2015 12:49:38 +0000 (04:49 -0800)]
Revert of move remaining virtual draw methods to onDraw (patchset #5 id:80001 of https://codereview.chromium.org/
817723005/)
Reason for revert:
did this cause chromeos heap corruption on skp?
Original issue's description:
> move remaining virtual draw methods to onDraw
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
2e0f7d53bba5438c9bf11ee5ccae2c301e348419
TBR=robertphillips@google.com,djsollen@google.com,bsalomon@google.com,mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
835913002
kkinnunen [Mon, 5 Jan 2015 09:14:11 +0000 (01:14 -0800)]
debugger: Remove few redundant variables
Use the GUI widget states instead of instance variables
reflecting the widget state.
Fixes the case where pause state would be left on when
switching files, but the image would change to the last
frame of newly loaded image.
Review URL: https://codereview.chromium.org/
810033004
skia.buildbots [Mon, 5 Jan 2015 06:27:44 +0000 (22:27 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
835813003
reed [Mon, 5 Jan 2015 05:09:04 +0000 (21:09 -0800)]
move remaining virtual draw methods to onDraw
BUG=skia:
Review URL: https://codereview.chromium.org/
817723005
reed [Mon, 5 Jan 2015 04:52:15 +0000 (20:52 -0800)]
Revert of enable conics gm (patchset #3 id:40001 of https://codereview.chromium.org/
835593002/)
Reason for revert:
did I break the build?
Original issue's description:
> enable conics gm
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
03119ba4f815bc2c2774a9349ca8278ab1695072
TBR=egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
811863006
reed [Mon, 5 Jan 2015 04:24:42 +0000 (20:24 -0800)]
enable conics gm
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
835593002
skia.buildbots [Sat, 3 Jan 2015 07:10:47 +0000 (23:10 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
832983002
reed [Sat, 3 Jan 2015 04:45:37 +0000 (20:45 -0800)]
add toString to SkImage
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
823013003
joshualitt [Fri, 2 Jan 2015 18:54:26 +0000 (10:54 -0800)]
Fix for chrome fuzzer
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
801493003
kkinnunen [Fri, 2 Jan 2015 15:24:14 +0000 (07:24 -0800)]
debugger: Move Skia initialization out of the GUI widget class
Move Skia initialization out of the GUI widget class to the
main function.
Before, Skia may have been already called before the SkGraphics::Init
was run.
Review URL: https://codereview.chromium.org/
822583003
reed [Fri, 2 Jan 2015 14:39:51 +0000 (06:39 -0800)]
remove unused drawData
BUG=skia:
Review URL: https://codereview.chromium.org/
830083002
kkinnunen [Fri, 2 Jan 2015 14:35:43 +0000 (06:35 -0800)]
debugger: Make inspector widget smaller
Make inspector widget a bit smaller by letting the Qt widget system
layout the widgets.
Let the inspector widget calculate its own smallest size. Use stretch
factor of 0 for inspector, 1 for picture canvas.
Group the matrix and clip widgets in groups. Put the text edits in a grid
layout instead of a handwritted column layout containing row layouts.
This commit is part of work that tries to make the debugger window to be
a bit more resizeable, so that it would fit 1900x1200 screen.
Review URL: https://codereview.chromium.org/
830743002
skia.buildbots [Fri, 2 Jan 2015 06:27:03 +0000 (22:27 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
832013002
skia.buildbots [Thu, 1 Jan 2015 06:55:21 +0000 (22:55 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
832823002
reed [Thu, 1 Jan 2015 04:07:01 +0000 (20:07 -0800)]
fix conic gm to have fixed wrapping
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
815143003
reed [Wed, 31 Dec 2014 20:31:43 +0000 (12:31 -0800)]
change API contract: disallow zero-sized images or surfaces
BUG=skia:
Review URL: https://codereview.chromium.org/
830033003
robertphillips [Wed, 31 Dec 2014 19:28:28 +0000 (11:28 -0800)]
Rebaseline complexclip2_rect_aa & simpleaaclip_rect GMs for the S4
I believe these are left over from https://codereview.chromium.org/
822483003/ (rebase)
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/
828973002
robertphillips [Wed, 31 Dec 2014 17:52:08 +0000 (09:52 -0800)]
Rebaseline lagging K1 GMs
The Nexus9 took a break from 12/20/14 until 12/30/14. This updates the GMs for all the changes during that time. Except for the changes due to https://codereview.chromium.org/
834503002/ (Update stroke path to use rect returned from isRect (to fix trailing moveTo bug)), in which a GM was changed, they are all imperceptible.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
831953002
robertphillips [Wed, 31 Dec 2014 17:41:22 +0000 (09:41 -0800)]
Rebaselines after "Fix computation of bound in FillBounds::updateSaveBounds"
The CL in question impacted the size of the hoisted layers and thus impacted the image results for the MPD GMs (for the GPU configs).
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
827423003
reed [Wed, 31 Dec 2014 16:27:52 +0000 (08:27 -0800)]
ignore failure -- pdf gradients on mac-mini
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
810653004
reed [Wed, 31 Dec 2014 16:23:19 +0000 (08:23 -0800)]
rebaseline after GM change
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
794833003
skia.buildbots [Wed, 31 Dec 2014 07:12:01 +0000 (23:12 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
805813006
kkinnunen [Wed, 31 Dec 2014 07:03:56 +0000 (23:03 -0800)]
debugger: Make draw command image widget resize
Make draw command image widget resize. The widget was not resizing,
effectively preventing the window from being resized smaller.
Make the rasterized draw command image be proportional to the widget
size. The draw rasterization canvas is still an equilateral rectangle
with dimensions of the smaller side of the widget.
Makes the widget re-rasterize the image only when the draw command
changes, not for each widget paint.
Renames the widget from "image widget" to "draw command geometry
widget".
Makes the background of the image black, similar to the raster widget
background.
Adds a tooltip saying "Command geometry" for the widget, so that user might
understand what the contents should be.
This commit is part of work that tries to make the debugger window to be
a bit more resizeable, so that it would fit 1900x1200 screen.
Review URL: https://codereview.chromium.org/
787143004
kkinnunen [Wed, 31 Dec 2014 06:49:58 +0000 (22:49 -0800)]
debugger: Make settings widget resizeable
The settings widget was laid out by hand, eg. the widths of most
elements were hardcoded. This prevented it from being laid out by the Qt
widget system. This in turn prevents the widget from shrinking to its
optimal size. This in turn causes cascading effect where the geometry of
many of the UI widgets has to be hard-coded. This in turn prevents
proper resizing of the UI.
Make Qt layout the settings widget by following changes:
a) Group settings in QGroupBox groups instead of hand-written
layouts and labels hardcoded in certain places.
b) Remove "Expanding" size policy from settings widget. The widget
calculates its own size based on the widgets inside. Thus "Preferred"
is the correct policy to use, as expanding the widget will not
bring any new content visible.
c) Remove maximum width 250 from Settings widget
d) Make "canvas settings and image layout", eg. the horizontal layout
holding the settings widget divide the space between the picture and
settings like so: settings uses up only as much as it needs (stretch
factor 0), while picture uses up everything else (stretch factor 1).
In order to do a) reasonably, reorganize the UI and the code a bit:
a1) Rename settings group "visual filter" to "Visualizations".
a2) Make "visual filter: on/off" combo box a checkbox in
"Visualizations".
a3) Move "Mega viz" setting checkbox from "raster" (or "render targets")
section to "Visualizations"
a4) Move "PathOps" setting checkbox from "raster" to "Visualizations"
a5) Make Raster and GL checkboxes use QGroupBox checkbox feature
a6) Move "current command", "command hitbox" and "zoom level" from
"Settings" widget to part of "Inspector" concept. These pieces of
information are now visualized as their own box in the right-hand
bar, below settings.
a7) Do not expose settings user selects through the UI widgets
state that record the user interacts with. Instead, expose it as state
of the "settings widget". Thus settings widget provides "raster settings
changed" signal, which the client hook to and then query the state
through the object API.
This makes the full window a bit shorter.
This commit is part of work that tries to make the
debugger window to be a bit more resizeable, so that it would fit
1900x1200 screen.
Review URL: https://codereview.chromium.org/
829933002
robertphillips [Tue, 30 Dec 2014 21:53:51 +0000 (13:53 -0800)]
Fix computation of bound in FillBounds::updateSaveBounds
intersect doesn't change the bounds when the two bounds do not intersect. This is definitely not the intended behavior.
With the SKPs captured on 12/23/14, Chrome began passing Skia drawPicture ops that did not intersect the current clip - which revealed this bug.
Review URL: https://codereview.chromium.org/
817483004
bsalomon [Tue, 30 Dec 2014 20:50:52 +0000 (12:50 -0800)]
Add a simpler key type for scratch resource keys.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
815833004
egdaniel [Tue, 30 Dec 2014 17:42:49 +0000 (09:42 -0800)]
Fix for disabled color writes xp on n6
The N6 has some driver bug that is required us to give some value to gl_FragColor.
The disabledColorWriteXP should not need to set any value in its shader, but to fix
this crash this cl sets gl_FragColor to 0.
BUG=445377
Review URL: https://codereview.chromium.org/
823053003
joshualitt [Tue, 30 Dec 2014 17:04:15 +0000 (09:04 -0800)]
ViewMatrix uniform upload moved to GeometryProcessor
BUG=skia:
Review URL: https://codereview.chromium.org/
827973002
skia.buildbots [Tue, 30 Dec 2014 15:40:28 +0000 (07:40 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
831793002
kkinnunen [Tue, 30 Dec 2014 15:22:58 +0000 (07:22 -0800)]
Change DebugCanvas API to not encourage memory leaks
Pass command strings and offset arrays as out parameters instead of
returning new arrays from the functions.
This simplifies debugger leak investigations, as the app leaks less by
design.
Review URL: https://codereview.chromium.org/
821663003
joshualitt [Tue, 30 Dec 2014 15:04:16 +0000 (07:04 -0800)]
rebase
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
822483003
robertphillips [Tue, 30 Dec 2014 14:06:19 +0000 (06:06 -0800)]
Update stroke-fill GM baselines
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
827243002
joshualitt [Mon, 29 Dec 2014 23:10:07 +0000 (15:10 -0800)]
Move ViewMatrix off of drawstate
BUG=skia:
Review URL: https://codereview.chromium.org/
815553003
robertphillips [Mon, 29 Dec 2014 22:06:51 +0000 (14:06 -0800)]
Update stroke path to use rect returned from isRect (to fix trailing moveTo bug)
This basically recreates what was done in:
https://codereview.chromium.org/
16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo) with the addition of GM representation
BUG=skia:247770
Review URL: https://codereview.chromium.org/
834503002
robertphillips [Mon, 29 Dec 2014 19:36:39 +0000 (11:36 -0800)]
Fix bound returned by SkPath::isRect when the path contains a trailing moveTo
Oddly enough this was fixed in:
https://codereview.chromium.org/
16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo)
but was reverted here:
https://skia.googlesource.com/skia/+/
8fd160350ca5f57fbb1b2e03383c5778414a9b48
since it appeared to be crashing Chrome's trybots. I think it just fell through the cracks after that.
If this sticks I will land a follow on patch for the stroke issue reported in the original bug (crbug.com/247770).
BUG=247770,445368
Review URL: https://codereview.chromium.org/
834483002
joshualitt [Mon, 29 Dec 2014 17:04:40 +0000 (09:04 -0800)]
removing coord change matrices
BUG=skia:
Review URL: https://codereview.chromium.org/
821243003
joshualitt [Mon, 29 Dec 2014 15:43:36 +0000 (07:43 -0800)]
Remove coordchanges from drawstate
BUG=skia:
Review URL: https://codereview.chromium.org/
818233002
bsalomon [Mon, 29 Dec 2014 15:05:27 +0000 (07:05 -0800)]
Add device space skshader GM to test kDevice_GrCoordSet
Review URL: https://codereview.chromium.org/
816003002
skia.buildbots [Mon, 29 Dec 2014 06:24:29 +0000 (22:24 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
829753002
skia.buildbots [Sun, 28 Dec 2014 06:24:05 +0000 (22:24 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
827813002
skia.buildbots [Fri, 26 Dec 2014 06:45:02 +0000 (22:45 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
822393002
reed [Fri, 26 Dec 2014 04:41:13 +0000 (20:41 -0800)]
disable using codecs until that can work in chrome
BUG=skia:3275
TBR=
Review URL: https://codereview.chromium.org/
820343002
reed [Fri, 26 Dec 2014 00:40:13 +0000 (16:40 -0800)]
mark c_gms to be rebaselined (gm updated)
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
820303002
reed [Thu, 25 Dec 2014 22:16:21 +0000 (14:16 -0800)]
add image-from-codec to c api
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
822203002
reed [Thu, 25 Dec 2014 21:55:08 +0000 (13:55 -0800)]
fix images in multi-thread by doing shallow-copies
BUG=skia:
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
791473006
skia.buildbots [Wed, 24 Dec 2014 07:16:19 +0000 (23:16 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
806243004
reed [Tue, 23 Dec 2014 22:11:11 +0000 (14:11 -0800)]
add maskfilter to c api
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
822053002
jvanverth [Tue, 23 Dec 2014 17:19:59 +0000 (09:19 -0800)]
Add baselines for Tegra2 complexclip* GMs.
They look bad, so marked as failure-ignored and tagged with a bug #.
BUG=skia:3273
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
800523003
jvanverth [Tue, 23 Dec 2014 16:34:00 +0000 (08:34 -0800)]
Lay down baselines for complexclip_*_invert and complexclip3_*.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
821093007
joshualitt [Tue, 23 Dec 2014 15:58:02 +0000 (07:58 -0800)]
fix for valgrind
BUG=skia:
Review URL: https://codereview.chromium.org/
816103003
skia.buildbots [Tue, 23 Dec 2014 07:08:17 +0000 (23:08 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
796993003
joshualitt [Tue, 23 Dec 2014 02:20:31 +0000 (18:20 -0800)]
ignoring imageblur2 on galaxy
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
816893003