Layomi Akinrinade [Thu, 1 Jun 2023 16:33:36 +0000 (09:33 -0700)]
Update binder gen parser to issue diagnostics for invalid input types (#86856)
* Update binder gen parser to issue diagnostics for invalid input types
* Address feedback; tests for more invalid types; fix failing CI test
t-mustafin [Thu, 1 Jun 2023 14:31:03 +0000 (17:31 +0300)]
[RISC-V] Fix typo in UMEntryThunkCode::Decode (#86997)
Marek Fišera [Thu, 1 Jun 2023 13:53:23 +0000 (15:53 +0200)]
[wasm][build] Fix webcil publish temp path (#86994)
Fix typo from #86972
Ruslan Murtazin [Thu, 1 Jun 2023 13:33:18 +0000 (16:33 +0300)]
Read StartDiskNumber as uint32 (#83923)
Fix #31825
Co-authored-by: Ruslan Murtazin <ruslan.murtazin@yahoo.com>
Milos Kotlar [Thu, 1 Jun 2023 10:15:14 +0000 (12:15 +0200)]
[nativeaot][tests] Add Native AOT iOS perf scenarios (#85317)
This PR updates the CI jobs to include the Native AOT iOS performance scenarios. The changes include building the NativeAOT iOS scenarios and running them, as well as updating the underlying scripts and project files to support it. Additionally, it separates the scenarios from the current Mono AOT sample measurements.
Egor Bogatov [Thu, 1 Jun 2023 09:57:48 +0000 (11:57 +0200)]
Fix rounding error in getLikelyClassesOrMethods (#86965)
dotnet bot [Thu, 1 Jun 2023 09:52:09 +0000 (02:52 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2191992 (#86981)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2191755
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2191755
Alexander Soldatov [Thu, 1 Jun 2023 09:35:43 +0000 (12:35 +0300)]
[RISC-V] Optimize Load Immediate (#86790)
Reduce amount of instructions required for loading 64-bit immediate to
register. In the worst case for full 64 bit constant it's still require
8 instructions (LUI + ADDIW + SLLI + ADDI + SLLI + ADDI + SLLI + ADDI).
But addresses and constants which don't use full 64 bits might be loaded
using only 2, 4 or 6 instructions.
Mark Plesko [Thu, 1 Jun 2023 05:52:46 +0000 (22:52 -0700)]
Update runtime-codeql.yml to run 3x/week (#86979)
Carlos Sánchez López [Thu, 1 Jun 2023 03:35:53 +0000 (20:35 -0700)]
Tar: Improve unseekable stream handling (#84279)
* Add tests that verify we handle unseekable streams correctly.
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.
* Add expected data field locations for all supported formats.
* Add exception message for when attempting to write an unseekable data stream into an unseekable archive stream.
* Add seekability validation in public TarWriter entry writing methods.
* Add TarFile stream roundtrip tests for unseekable streams.
* Add missing async TarFile roundtrip tests.
* Support unseekable streams in TarHeader.Write.
* Reuse and simplify the code.
* More reuse, remove unused and not needed.
* Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it in a separate PR.
* Remove unnecessary resx comments.
* Dedicated method for writing fields to buffer depending on the format.
* Specify `Data` in name of method that expects unseekable data stream. Add extra debug asserts.
* Delete unnecessary method.
* Rename WritePadding to WriteEmptyPadding
* Rename test variables
* Merge identical test arrays into one
* Invert if else to be more clear about conditions
* remove size assign comment
* Remove redundant debug assert
* Async padding byte array creation simplification
* Apply suggestions from code review
---------
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Stephen Toub [Thu, 1 Jun 2023 01:04:59 +0000 (21:04 -0400)]
Use IUtf8SpanFormattable.TryFormat in a few more places (#86931)
* Use IUtf8SpanFormattable.TryFormat in a few more places
* Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs
* Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
---------
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Aleksey Kliger (λgeek) [Thu, 1 Jun 2023 00:33:49 +0000 (20:33 -0400)]
[wasm][build] Don't use GetTempFileName; emit webcil to subdir of obj (#86972)
See https://github.com/dotnet/runtime/issues/73793
Instead of using GetTempFileName (which can run out of temp file names
on Windows after 64K files), emit the temporary webcil files to a
directory in IntermediateOutputPath before copying them to the final
location, if they changed (which is elsewhere in
IntermediateOutputPath).
Ankit Jain [Wed, 31 May 2023 22:16:51 +0000 (18:16 -0400)]
[wasm] Use an older version of chrome for testing `113.0.5672.63` (#86968)
.. because of crashes being hit on linux.
Issue: https://github.com/dotnet/runtime/issues/86919
Aaron Robinson [Wed, 31 May 2023 22:11:00 +0000 (15:11 -0700)]
Clean-up error in `IDispatch::Invoke()` scenario (#86964)
* Clean-up error in IDispatch::Invoke scenario
Buyaa Namnan [Wed, 31 May 2023 21:01:01 +0000 (14:01 -0700)]
Fix warnings found with CA1861 Avoid constant arrays as arguments (#86229)
* Fix warnings found with CA1861
* Update src/coreclr/tools/aot/ILCompiler/Program.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Remove supression from static field
* Revert using string.Split(char)
* Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationILGen.cs
---------
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Tom Deseyn [Wed, 31 May 2023 20:26:24 +0000 (22:26 +0200)]
System.Data: override System.Data.Sql tfm only when ArcadeBuildFromSource. (#86962)
Michal Strehovský [Wed, 31 May 2023 20:08:03 +0000 (05:08 +0900)]
Remove some working tests from issues.targets (#86939)
Fixes #86561
Fixes dotnet/runtimelab#1136
t-mustafin [Wed, 31 May 2023 18:47:30 +0000 (21:47 +0300)]
[RISC-V] Fix typo in ReversePInvoke (#86958)
Badre BSAILA [Wed, 31 May 2023 17:53:25 +0000 (19:53 +0200)]
The ConstructorBuilder and MethodBuilder generated parameter should not have default value by default (#84550)
* The ConstructorBuilder and MethodBuilder generated parameter should not has default value by default
* return parameter has no default value
* use dbnull.value
* exclude test from native aot because it returns always a true
* add test for nativeaot
* refactor nativeaot test
* simplify ReturnParameter DefaultValueImpl
Marc Brooks [Wed, 31 May 2023 17:52:05 +0000 (12:52 -0500)]
Add message for AmbiguousMatchException (#84512)
Add information to what is ambiguously matched when an AmbiguousMatchException is thrown as we know what we found multiple matching items for.
Renames of SR/RESX strings. Removal of `.ToString()` calls. Remove unused strings from RESX RESX string rewording.
Change the exception format string to "found for" style.
Cleanup of DefaultBinder.cs FindMostDerived* to use the local variable.
Remove copy-pasta ThrowHelper.cs instance.
Don't emit the CustomAtrributeData's type
All MemberInfo cases pass a (possibly null) `DeclaringType`.
Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
dotnet-maestro[bot] [Wed, 31 May 2023 17:18:36 +0000 (10:18 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20230530.3 (#86951)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23280.1 -> To Version 8.0.0-beta.23280.3
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23272.1 -> To Version 1.0.0-beta.23279.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Piotr [Wed, 31 May 2023 15:46:51 +0000 (17:46 +0200)]
Removed unnecessary string interpolation (#86945)
Qiao Pengcheng [Wed, 31 May 2023 15:40:25 +0000 (23:40 +0800)]
[LoongArch64] redesign the Prolog/Epilog for enabling OSR. (#86866)
Also fix the comparing errors when debugging libraries.
Varorbc [Wed, 31 May 2023 15:38:16 +0000 (23:38 +0800)]
Remove implicitly dependent reference (#86938)
Marc Brooks [Wed, 31 May 2023 15:35:39 +0000 (10:35 -0500)]
Cleanup BitMapper sizeof type (#86881)
Egor Bogatov [Wed, 31 May 2023 14:35:49 +0000 (16:35 +0200)]
Early out in impMarkInlineCandidate for minopts (#86949)
Radek Doulik [Wed, 31 May 2023 14:25:35 +0000 (16:25 +0200)]
[wasm][bench] Limit initial samples (#86953)
* [wasm][bench] Limit initial samples
Try to limit initial samples measurement to 1 second.
Currently some of string measurements with hybrid globalization turned on
can take hundreds of seconds. This makes the browser stop the benchmark
and the measurement job times out.
This should limit the initial samples to take cca 1 second or take just
one initial sample if it takes more time.
Also increase the initial samples for string comparison, where it was on
the edge and the times were flipping between cca 5 and 10 seconds.
* Do GC collect only when doing initial samples
Vladimir Sadov [Wed, 31 May 2023 14:24:42 +0000 (07:24 -0700)]
[NativeAOT] implement Interlocked.ReadMemoryBarrier intrinsic (#86842)
* ReadMemoryBarrier
* remove more literals (use constants)
* missing include for win-arm64
* removed nonintrinsic implementations of ReadMemoryBarrier
* removed nonintrinsic MemoryBarrier()
* unified Interlocked.MemoryBarrier
* added a test for indirect calling Interlocked.MemoryBarrier
* PR feedback
* use no-inlining peoperties
* NoInlining must be with methods (not properties)
Eirik Tsarpalis [Wed, 31 May 2023 13:59:31 +0000 (14:59 +0100)]
Fix recursive type support when consuming source generated code from the .NET 6 sdk. (#86821)
Tom Deseyn [Wed, 31 May 2023 13:54:47 +0000 (15:54 +0200)]
CI: specify BaseOS for the unknown rid build. (#86688)
Badre BSAILA [Wed, 31 May 2023 11:29:27 +0000 (13:29 +0200)]
Use underlying type converter for nullable type (#84208)
* Use underlying type converter for nullable type
* verify that we use underlying type converter for nullable types
* rollback a little change
* Update src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
* Update src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
* Use consistent indentation.
* Fix runtime support for nullable properties with custom converters.
---------
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Michal Strehovský [Wed, 31 May 2023 09:34:54 +0000 (18:34 +0900)]
Use Knobs to populate AppContext switches (#86883)
Previously AppContext switches were set by injecting a method that calls `AppContext.SetSwitch` at startup. Use the configuration blob added in #86068 instead. This makes startup a tiny bit faster and the outputs a tiny bit smaller.
Fixes #77054.
Milos Kotlar [Wed, 31 May 2023 09:32:00 +0000 (11:32 +0200)]
[mono][aot] Add support for deferred failures during AOT compilation (#86554)
* Add deferred failures to the AOT comiler
* Move type_load_failure_callback to mono-error.c
* Add default mono_class_set_deferred_type_load_failure_callback
* Disable failing test in llvm AOT configurations
Vlad Brezae [Wed, 31 May 2023 09:04:16 +0000 (12:04 +0300)]
[mono][interp] Preserve type information of stack args when inlining (#86898)
In order to enable more devirtualization. Type information from caller method should always be more specific (or the same) as the one coming from inlined method signature.
dotnet bot [Wed, 31 May 2023 07:24:26 +0000 (00:24 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2191208 (#86925)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2190984
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2190984
Michal Strehovský [Wed, 31 May 2023 05:40:57 +0000 (14:40 +0900)]
Do less work building Delegate.GetMethodInfo lookup (#86930)
This code is very problematic for startup. We're spending 6.6% of startup samples of the Stage2 app in `ComputeLdftnReverseLookup_InvokeMap`. This code supports `Delegate.GetMethodInfo` and builds a reverse lookup table to lookup code metadata from code address. The data structure we have in the image is optimized for lookups in the other direction. 2.2% of the total time is spent trying to decode the entrypoint as an unboxing stub (the requires looking up unwinding info for the method). Shortcut this and do it only for valuetypes.
Medium term we'd want to do something about this. In the end this is the same problem as https://github.com/dotnet/runtime/pull/79921#discussion_r1056547078. Except this time we need to be able to lookup this information both ways (from metadata to function pointer and from function pointer to metadata). One thing I'm thinking about is whether we could store the hashcode of the owning type in the unwinding information of the method to give us something to go off.
dotnet-maestro[bot] [Wed, 31 May 2023 05:16:44 +0000 (07:16 +0200)]
[main] Update dependencies from dotnet/arcade (#86494)
* Update dependencies from https://github.com/dotnet/arcade build
20230519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
* Update dependencies from https://github.com/dotnet/arcade build
20230519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
* Update dependencies from https://github.com/dotnet/arcade build
20230524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
* Update dependencies from https://github.com/dotnet/arcade build
20230525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/arcade build
20230526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/arcade build
20230527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/arcade build
20230529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/arcade build
20230529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/arcade build
20230530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Remove duplicate package references
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Marc Brooks [Wed, 31 May 2023 04:32:32 +0000 (23:32 -0500)]
Remove comment in ZipFile.Create.cs (#86927)
* Remove comment in ZipFile.Create.cs
In #85491 the stream-based version of the `DoCreateFromDirectory` override copy-pasted comments from the string-based version
```csharp
// Rely on Path.GetFullPath for validation of sourceDirectoryName and destinationArchive
```
The last clause of that comment is not relevant in the stream-based version (the argument is `Stream destination`) so deleted that clause.
It's possible that the other comment is also misleading as we test the `compressionLevel ` argument just above (unlike in the `String destinationArchive` version
```csharp
// Checking of compressionLevel is passed down to DeflateStream and the IDeflater implementation
// as it is a pluggable component that completely encapsulates the meaning of compressionLevel.
```
* Remove compressionLevel validation comment
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
---------
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Katelyn Gadd [Wed, 31 May 2023 02:50:34 +0000 (19:50 -0700)]
[wasm] Exploit unallocated zero page to remove null checks in jiterpreter (#86403)
* Fuse null and length checks for getelema1 and getchr
* Sense whether zero page optimizations are safe based on the location of the emscripten stack and contents of memory near zero
* Improve jiterpreter stats formatting
Eirik Tsarpalis [Tue, 30 May 2023 22:12:23 +0000 (23:12 +0100)]
Ensure Memory<T>/ReadOnlyMemory<T> are marked as unsupported types. (#86900)
* Ensure Memory<T>/ReadOnlyMemory<T> are marked as unsupported types.
* Update src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs
Koundinya Veluri [Tue, 30 May 2023 21:19:28 +0000 (14:19 -0700)]
Fix ClrEtwAllMeta.lst for the ContentionLockCreated event (#86907)
Eirik Tsarpalis [Tue, 30 May 2023 18:25:02 +0000 (19:25 +0100)]
Fix deserialization of nullable structs with constructors. (#86896)
Peter Sollich [Tue, 30 May 2023 17:55:52 +0000 (19:55 +0200)]
Fix assert failure in grow_heap_segment for SVR GC. (#86889)
For my previous change, I overlooked the fact that we may call grow_heap_segment from within should_proceed_for_no_gc(), so it's too late to turn off gradual_decommit_in_progress_p after this method returns.
Carlos Sánchez López [Tue, 30 May 2023 16:48:39 +0000 (09:48 -0700)]
Implement stream-based ZipFile ExtractToDirectory and CreateFromDirectory method overloads (#85491)
* ref: Add stream-based ZipFile.CreateFromDirectory and ZipFile.ExtractToDirectory methods.
* src: Add stream-based ZipFile.CreateFromDirectory ZipFile.ExtractToDirectory methods.
* tests: Move wrongly placed tests to the correct class.
* tests: Add stream-based tests for ZipFile.CreateFromDirectory and ZipFile.ExtractToDirectory.
* src: Documentation and resource strings.
* tests: More tests for unseekable/unreadable/unwritable streams.
* Address suggestions and include more exception validation tests.
* Fix braces after resolving conflict.
* Use AssertExtensions.SequenceEqual for clearer error message.
* Reset the resx file again.
* Order results of dir enumeration tests
Koundinya Veluri [Tue, 30 May 2023 15:46:52 +0000 (08:46 -0700)]
Change the LockCreated event to ContentionLockCreated (#86817)
- The event was added in .NET 8, I have updated the event name based on the suggestion in https://github.com/microsoft/perfview/pull/1731#issuecomment-
1293961643.
- The name now matches the convention used for most other events, and shows up as Contention/LockCreated as expected in PerfView
Tarun047 [Tue, 30 May 2023 14:49:19 +0000 (20:19 +0530)]
Add PipeOptions.FirstPipeInstance enum value (#83936)
Co-authored-by: Gudipati.Tarun <Gudipati.Tarun@wisetechglobal.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Vitek Karas [Tue, 30 May 2023 10:09:42 +0000 (03:09 -0700)]
Fix formatting issues in DependencyGraphViewer (#86890)
Whitespace only change, to fix tabs/spaces and trailing spaces.
Without this the tool doesn't build.
t-mustafin [Tue, 30 May 2023 07:47:14 +0000 (10:47 +0300)]
[RISC-V] Fix receiving of 2nd register in struct (#86144)
* [RISC-V] Fix receiving of 2nd register in struct
* jit-format patch apply
Dong-Heon Jung [Tue, 30 May 2023 07:45:53 +0000 (16:45 +0900)]
[RISC-V][JIT] Fix branch (#86482)
* [RISC-V][JIT] Fix branch
* [RISC-V][JIT] Updated emitJumpDistBind
* jit-format
* Update JALR offset value
* Updated by reviews
* Updated by reviews and fix
* [RISC-V][JIT] Fixed the dest reg of jalr
- Pass `./JIT/jit64/opt/cse/HugeField2/HugeField2.sh` test
Ilona Tomkowicz [Tue, 30 May 2023 06:54:51 +0000 (08:54 +0200)]
[wasm][globalization] `HybridGlobalization` fix bug in change case (#86799)
* Fix + test.
* Fix surrogates problem, document final sigma.
* Update change-case.ts
* Fix NLS
Vladimir Sadov [Tue, 30 May 2023 06:03:26 +0000 (23:03 -0700)]
[NativeAOT] Fix MD array GC series (#86877)
* Fix MD array GC series
* add a test
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Michal Strehovský [Tue, 30 May 2023 05:45:14 +0000 (14:45 +0900)]
Do not compute debug names of reflection objects (#86880)
We're spending 5% of Stage2 app startup computing debug names.
This code originates from .NET Native where we had a "release mode with developer experience mode enabled" mode that tried to make troubleshooting trimming issues easier. One of the things it did was providing names of things in the debugger. Since we lack compiler support for this, developer experience mode is always enabled right now.
Since in .NET 5+ people are not supposed to troubleshoot trimming issues in the debugger, this mode doesn't make much sense (we also don't have a managed debugger to surface the `DebuggerDisplay` anyway)
Andrii Kurdiumov [Tue, 30 May 2023 03:44:37 +0000 (09:44 +0600)]
Read public GC options if available (#86068)
Jan Kotas [Tue, 30 May 2023 03:07:56 +0000 (20:07 -0700)]
Annotate test with IsPreciseGcSupported (#86869)
Fixes #86861
Michal Strehovský [Mon, 29 May 2023 23:58:32 +0000 (08:58 +0900)]
Implement resource lookup in satellite assemblies (#86689)
Fixes #86651.
This was implemented in .NET Native so we just need to resurface it from the compiler.
Note that this is not full support for satellite assemblies (in the assembly binder, etc.) that never existed and nobody ever asked for and I don't even know what it entails.
Michal Strehovský [Mon, 29 May 2023 21:06:42 +0000 (06:06 +0900)]
Faster ConstructorInfo.Invoke (#86855)
* Faster ConstructorInfo.Invoke
Speeds up reflection-invoking constructors by about 30%.
Noticed we spend some time in the `ConstructorInfo` invocation infrastructure for no good reason.
* We'd first allocate an instance of the object using a general purpose allocator (that first needs to dissect the `MethodTable` to figure out how to allocate), and then
* We'd call into general-purpose Invoke infrastructure that would validate the `this` is valid.
Neither of those are necessary - we can figure out the right allocator at the time the method invoker is first accessed, and validating `this` is not necessary because we _just_ allocated the right one.
* This is reachable and the old behavior was needed
* Apply suggestions from code review
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Pavel Savara [Mon, 29 May 2023 17:09:19 +0000 (19:09 +0200)]
[browser][MT] fix different url base of the worker (#86863)
* fix different url base of the worker
broudy3 [Mon, 29 May 2023 16:58:32 +0000 (18:58 +0200)]
[RISC-V] Fix linking problem (#86870)
dotnet-maestro[bot] [Mon, 29 May 2023 16:53:50 +0000 (11:53 -0500)]
[main] Update dependencies from dotnet/roslyn-analyzers (#86793)
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230525.7
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23270.2 -> To Version 3.3.5-beta1.23275.7
* Fix new findings with CA1822 analyzer
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
dotnet-maestro[bot] [Mon, 29 May 2023 15:58:46 +0000 (10:58 -0500)]
[main] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/emsdk dotnet/runtime (#86678)
* Update dependencies from https://github.com/dotnet/llvm-project build
20230523.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 14.0.0-alpha.1.23269.1 -> To Version 14.0.0-alpha.1.23273.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20230523.3
runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 14.0.0-alpha.1.23269.1 -> To Version 14.0.0-alpha.1.23273.3
* Update dependencies from https://github.com/dotnet/runtime-assets build
20230523.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23273.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230523.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.5.23273.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230524.4
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.6.23274.4
* Bump main version to Preview 6
* Update dependencies from https://github.com/dotnet/emsdk build
20230525.1
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.6.23275.1
* Update dependencies from https://github.com/dotnet/emsdk build
20230527.2
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-preview.5.23265.1 -> To Version 8.0.0-preview.6.23277.2
* Update dependencies from https://github.com/dotnet/runtime build
20230529.2
Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 8.0.0-preview.5.23272.1 -> To Version 8.0.0-preview.5.23279.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Ilona Tomkowicz [Mon, 29 May 2023 15:02:47 +0000 (17:02 +0200)]
[codespaces] Fix V8 error when running lib tests (#86871)
Vlad Brezae [Mon, 29 May 2023 13:48:21 +0000 (16:48 +0300)]
[mono][interp] Use vectorized opcodes for Vector<T> operators (#86859)
* [mono][interp] Remove some duplicated code in transform-simd.c
* [mono][interp] Intrinsify Vector<T> operators
They do the same thing as the Vector128 counterpart
* [mono][interp] Add missing simd opcodes
Marie Píchová [Mon, 29 May 2023 10:47:10 +0000 (12:47 +0200)]
Fix unfailing helix test run when testResults.xml are missing (#86342)
* Attempt to fix unfailing helix test run when testResults.xml are missing
* Feedback and docker image attemted fix
* Commenting out RHEL7 for a test run to see if there are any remaining problems elsewhere
* AlmaLinux 8 instead of RHEL7
* Test docker image
* Kdepak asi soudruzi udelali chybu
* Fixed docker from centos stream 9 to 8
* Test with different Queue
* Fixed docker image name
dotnet bot [Mon, 29 May 2023 07:53:51 +0000 (00:53 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189827 (#86818)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189200
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189200
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2189240
Michal Strehovský [Mon, 29 May 2023 05:51:10 +0000 (14:51 +0900)]
Revert "Change our Android build and test legs to use the new CBL-Mariner-based images. (#86776)" (#86854)
This reverts commit
559f630beea2d72e9357505a891ea514e731650c.
Isabelle Santin [Sun, 28 May 2023 19:57:15 +0000 (14:57 -0500)]
[browser][mt] Update memory views after growth, refactor string processing, fix SharedArrayBuffer detection (#86664)
Co-authored-by: pavelsavara <pavel.savara@gmail.com>
Egor Bogatov [Sat, 27 May 2023 18:38:16 +0000 (20:38 +0200)]
Multiple GDV: ignore non-inlineable candidates (#86835)
Koundinya Veluri [Sat, 27 May 2023 18:37:18 +0000 (11:37 -0700)]
Fix tiered PGO info in TC Settings event (#86827)
- Moved initialization of the tiered PGO config values in EEConfig to before the TC Settings event is sent
- After this change, the TC Settings event shows the correct flags when tiered PGO is enabled
Fixes https://github.com/dotnet/runtime/issues/84607
Adeel Mujahid [Sat, 27 May 2023 14:31:56 +0000 (17:31 +0300)]
Fix packs subset build (#86832)
Michal Strehovský [Sat, 27 May 2023 07:38:18 +0000 (16:38 +0900)]
Add NativeAOT build and runtime pack for linux-bionic (#86781)
Build and runtime pack for linux-bionic (Android without the Java part).
I tried not to regress the existing CoreCLR Android build that is based on a crossrootfs (#56622) - the if's basically deal with that. Note that it's likely broken anyway (#66562).
Theodore Tsirpanis [Sat, 27 May 2023 00:14:23 +0000 (03:14 +0300)]
Use `u8` literals in `ManagedTextSection`. (#86657)
Ankit Jain [Fri, 26 May 2023 23:50:09 +0000 (19:50 -0400)]
CI: Fix running the workaround for `NuGet-Migrations` issue (#85692)
* CI: Fix running the workaround for `NuGet-Migrations` issue
The workaround adds:
`(CONSOLE_TEMP_DIR="%24(mktemp -d)" %3B "$DOTNET_ROOT/dotnet" new console -o "$CONSOLE_TEMP_DIR" %3B rm -rf "$CONSOLE_TEMP_DIR") || true`
which uses `$DOTNET_ROOT/dotnet`. But this is set for `HelixPreCommand`
which runs *before* `DOTNET_ROOT` is set.
Instead, use `HelixCommandPrefixItem`.
* rename HelixCommandPrefixItem to HelixCommandPrefixEnvVarItem
* Fix in helixpublishwitharcade.proj also
* Add the workaround for legacy payloads also, which includes wasm runtime tests
* fix typo
Tarek Mahmoud Sayed [Fri, 26 May 2023 23:34:55 +0000 (16:34 -0700)]
Address Metrics APIs issues (#86740)
Layomi Akinrinade [Fri, 26 May 2023 21:58:23 +0000 (14:58 -0700)]
Add support for types with parameterized ctors to config binder gen (#86365)
* Add support for types with parameterized ctors to config binder gen
* Ensure param-prop binding & exception behavior match reflection implementation
* Fix ctor preference logic and enable passing test
Jeremy Koritzinsky [Fri, 26 May 2023 21:38:17 +0000 (14:38 -0700)]
Change our Android build and test legs to use the new CBL-Mariner-based images. (#86776)
Jackson Schuster [Fri, 26 May 2023 20:52:09 +0000 (13:52 -0700)]
[ComInterfaceGenerator] Fix StringMarshalling error message and actually copy attributes from methods to shadows (#86731)
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Jakob Botsch Nielsen [Fri, 26 May 2023 19:39:48 +0000 (21:39 +0200)]
JIT: Pick some low-hanging fruit in physical promotion throughput (#86792)
* Skip any IR traversals entirely if there are no candidates locals for
physical promotion
* During accounting, do a quick pre-check for candidates in each
statement using the linked locals list, before doing the tree walk.
Result:
```
Collection PDIFF
aspnet.run.windows.x64.checked.mch -0.59%
benchmarks.run.windows.x64.checked.mch -0.65%
benchmarks.run_pgo.windows.x64.checked.mch -0.65%
benchmarks.run_tiered.windows.x64.checked.mch -0.65%
coreclr_tests.run.windows.x64.checked.mch -0.66%
libraries.crossgen2.windows.x64.checked.mch -0.61%
libraries.pmi.windows.x64.checked.mch -0.63%
libraries_tests.pmi.windows.x64.checked.mch -0.68%
```
Jakob Botsch Nielsen [Fri, 26 May 2023 19:15:33 +0000 (21:15 +0200)]
JIT: Have physical promotion insert read backs before possible implicit control flow (#86706)
Physical promotion relies on being able to read back any promoted field
that is fresher in its struct local before control flows to any
successor block. This was failing to take implicit control flow into
account.
Fix #86498
Jakob Botsch Nielsen [Fri, 26 May 2023 19:12:09 +0000 (21:12 +0200)]
JIT: Allow RBO for known relops even without a dominator (#86774)
Delay the check for whether there is a dominator to the case where we're
actually going to try to infer from it.
Egor Bogatov [Fri, 26 May 2023 18:47:12 +0000 (20:47 +0200)]
Guarded devirtualization: multiple type checks (#86551)
Co-authored-by: Andy Ayers <andya@microsoft.com>
Sven Boemer [Fri, 26 May 2023 17:44:43 +0000 (10:44 -0700)]
Update NativeAot with latest ILLink changes (#86712)
This brings us up to date with changes from `dotnet/linker` and
allows us to remove the `ReferenceSource` directories.
* Update Dataflow ReferenceSource
* Update ILCompiler DataFlow
* Update Logging ReferenceSource
* Update ILCompiler Logging
* Update Common/Compiler ReferenceSource
* Apply formatting
* Fix up license headers
* Update Common/Compiler
* Remove ReferenceSource
* Apply suggestions from code review
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Ilona Tomkowicz [Fri, 26 May 2023 17:10:03 +0000 (19:10 +0200)]
[mono][debugger] Remove cast bug (#86789)
* Fix.
* Test standardization.
skyoxZ [Fri, 26 May 2023 16:24:07 +0000 (00:24 +0800)]
Remove inconsistent comments in Convert.cs (#86425)
* Remove inconsistent comments
* Fix inconsistent comments
* Fix inconsistent comments
Stefan [Fri, 26 May 2023 15:45:01 +0000 (17:45 +0200)]
Add adjacency row length check (#86716)
Tomas Weinfurt [Fri, 26 May 2023 14:56:20 +0000 (16:56 +0200)]
update MediaTypeNames (#86770)
Egor Bogatov [Fri, 26 May 2023 09:55:14 +0000 (11:55 +0200)]
fix ISA outerloop tests (#86705)
Egor Bogatov [Fri, 26 May 2023 09:08:58 +0000 (11:08 +0200)]
Expand CORINFO_HELP_CHKCASTANY cast (#86728)
Milos Kotlar [Fri, 26 May 2023 08:39:48 +0000 (10:39 +0200)]
[mono] Exclude unused bundle files in AppleAppBuilder (#86316)
* Exclude .cs dedup file
* Use excludes list and use a wildcard for icudt_*
* Use variable for ExcludeFromAppDir
Dan Moseley [Fri, 26 May 2023 07:56:47 +0000 (02:56 -0500)]
Dump data in proc test (#86784)
Ankit Jain [Fri, 26 May 2023 06:22:05 +0000 (02:22 -0400)]
[wasm] Add build-runtime-tests make target (#86785)
dotnet bot [Fri, 26 May 2023 05:08:07 +0000 (22:08 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2188652 (#86779)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2188521
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2188521
Ankit Jain [Fri, 26 May 2023 03:55:25 +0000 (23:55 -0400)]
[wasm] Re-enable ~6700 runtime tests that got disabled mistakenly (#86747)
* [wasm] Fix running merged test wrappers in runtime tests
- These were all getting removed because it looked for the incorrect
script path in case of wasm
* [wasm] Disable a multithreaded runtime test
```
Operation is not supported on this platform.
at System.Threading.Thread.ThrowIfNoThreadStart(Boolean internalThread)
at System.Threading.Thread.Start(Boolean captureContext, Boolean internalThread)
at System.Threading.Thread.Start()
at MutualThdRecur_fptr.main()
at Program.<>c__DisplayClass0_0.<<Main>$>g__TestExecutor29|30(TestFilter filter, StreamWriter tempLogSw, StreamWriter statsCsvSw)
```
* [wasm] Disable a failing test in JIT.Performance
`JIT/Performance/CodeQuality/Benchstones/MDBenchI/MDPuzzle/`
https://github.com/dotnet/runtime/issues/86772
* [wasm] Disable all JIT.Performance tests for now
Jeremy Koritzinsky [Thu, 25 May 2023 22:38:38 +0000 (15:38 -0700)]
Define the managed dependencies of the crossgen-corelib.proj file through ProjectReferences (#86735)
Jeremy Koritzinsky [Thu, 25 May 2023 22:38:16 +0000 (15:38 -0700)]
Add some more testing around shadowing, inheritance, and project boundaries. (#86732)
Radek Doulik [Thu, 25 May 2023 20:00:22 +0000 (22:00 +0200)]
[wasm] Install latest LTS npm/node for codespaces (#86767)
* [wasm] Install latest LTS npm/node for codespaces
* Fix docker build
SwapnilGaikwad [Thu, 25 May 2023 20:00:09 +0000 (21:00 +0100)]
Use cinv and cneg instead of csel when possible (#84926)
* Use cinv instead of csel when possible
* Fix when the operands of conditional select should be reversed
* Scope down the cinv optimisation to local vars
* Use more generic CSINV instead of CINV instruction
* Add support for CSNEG and refactor conditional selects
* Fix initialisation of srcReg2
* Add RequiresProcessIsolation property to fix test failures
* Address review comments - Part 1
* Remove output type from conditional negate tests
* Ensure operands of cneg/cinv are invariants while optimising
* Update tests to the new format
* Use annotations to run tests through the framework
* Fix conditional negate tests
* Handle conditional negate/invert of shifted operands
Parker Bibus [Thu, 25 May 2023 19:46:50 +0000 (12:46 -0700)]
Make helix-inner-step send job warnaserror the same between windows and non-windows platforms (#86729)
Add warnaserror to the Unix send to Helix step to match the windows send to helix step.
Elinor Fung [Thu, 25 May 2023 19:40:52 +0000 (21:40 +0200)]
[NativeAOT] Handle event pipe environment variable configuration and output to file (#86656)
Updates to NativeAOT event pipe:
- Respect environment variable configuration
- Handle writing out to a file
- Enable tracing/eventpipe/config/name_config_with_pid test, which uses environment variable configuration to write directly to a file.
Jackson Schuster [Thu, 25 May 2023 18:27:07 +0000 (11:27 -0700)]
Add `DiagnosticOr<T>` type for gracefully handling failures in incremental generator transformations (#86603)
Vlad Brezae [Thu, 25 May 2023 15:37:56 +0000 (18:37 +0300)]
[mono][debugger] Don't pass uninitialized context to debugger (#86625)
mono_dbg_debugger_agent_user_break first tries to initialize a context before sending it to the debugger machinery. If, during unwinding, we don't have a saved context, we were passing uninitialized data (with interpreter for example). On some architectures this was making unwinding break in mono_walk_stack_full, because the stack pointer was invalid. This change makes it so we at least pass a valid context.