Vatsala Narang [Sat, 23 Mar 2019 23:20:07 +0000 (04:50 +0530)]
staging: media: zoran: Use unsigned int instead of unsigned
Replace 'unsigned' with 'unsigned int' to get rid of checkpatch warning
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Sat, 23 Mar 2019 07:51:29 +0000 (13:21 +0530)]
Staging: media: imx: mipi-csi2: Remove unnecessary error messages
The function devm_ioremap already prints error message when there
is no enough memory.
Remove print statements that give error messages
Issue found using coccinelle
The following semantic patch is used to solve this:
<smpl>
@@
expression x;
constant char[] C;
identifier f;
@@
x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));
if(x==NULL)
{
...
(
-f(C,...);
|
-f(...,C);
)
...
}
</smpl>
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Mon, 25 Mar 2019 11:27:24 +0000 (16:57 +0530)]
staging: vt6655: lines should not end with a parentheses
Adjust code to fix the style issue-lines should not end with a
parentheses
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ganesh Biradar [Sun, 24 Mar 2019 13:06:09 +0000 (18:36 +0530)]
staging: vt6655: Modify comment style of SPDX License Identifier
Fix the comment style of SPDX license identifier based on header file
type
Signed-off-by: Ganesh Biradar <grbesd1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Sun, 24 Mar 2019 03:43:42 +0000 (09:13 +0530)]
staging: rts5208: correction in spelling
Correct misspelled word.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Sat, 23 Mar 2019 22:09:15 +0000 (03:39 +0530)]
staging: rtl8723bs: include: Fix identation issue
Corrected the identation of switch case to get rid of checkpatch error
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Sat, 23 Mar 2019 22:05:14 +0000 (03:35 +0530)]
staging: rtl8723bs: include: Fix a space issue
Replace 'foo * bar' with 'foo *bar' to fix a checkpatch warning
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Sat, 23 Mar 2019 10:39:24 +0000 (16:09 +0530)]
staging: rtl8723bs: include: Fix spelling mistake
Replace negoitation with negotiation to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Fri, 22 Mar 2019 14:38:26 +0000 (20:08 +0530)]
staging: rtl8723bs: Remove function rtw_alloc_network()
Remove function rtw_alloc_network() as all it does is call
_rtw_alloc_network().
Rename _rtw_alloc_network() to rtw_alloc_network().
Change references to _rtw_alloc_network() to refer to
rtw_alloc_network().
Issue first noticed while using Coccinelle and ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Fri, 22 Mar 2019 14:38:25 +0000 (20:08 +0530)]
staging: rtl8723bs: core: Remove parentheses
Remove unnecessary parentheses around variables. Issue found with
Checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Fri, 22 Mar 2019 14:38:24 +0000 (20:08 +0530)]
staging: rtl8723bs: core: Change datatype from sint to int
Change datatype of local variable from sint to int.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Fri, 22 Mar 2019 14:38:23 +0000 (20:08 +0530)]
staging; rtl8723bs: Remove unnecessary function rtw_init_mlme_priv()
Remove function rtw_init_mlme_priv() as all it does is call
_rtw_init_mlme_priv().
Change the name of _rtw_init_mlme_priv() to rtw_init_mlme_priv() and its
return type to int.
Remove references to _rtw_init_mlme_priv() from the corresponding header
file.
Suggestion to delete return variable from rtw_init_mlme_priv() put forward
by Coccinelle using ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Wed, 20 Mar 2019 22:42:05 +0000 (16:42 -0600)]
staging: mt7621-mmc: Check for nonzero number of scatterlist entries
The buffer descriptor setup loop is correct only if it is setting up at
least one bd struct. Besides, there is an error if dma_map_sg() returns
0, which is possible and must be handled.
Additionally, remove the BUG_ON() checking sglen, which is unnecessary
because we configure DMA with that constraint during init.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Wed, 20 Mar 2019 22:42:03 +0000 (16:42 -0600)]
staging: mt7621-mmc: Fix warning when reloading module with debug msgs enabled
The kernel complained:
[ 510.277151] WARNING: CPU: 0 PID: 395 at fs/proc/generic.c:360 proc_register+0xf0/0x108
[ 510.292891] proc_dir_entry '/proc/msdc_debug' already registered
when doing a modprobe/rmmod/modprobe of this module if debug messages
are compiled in. Fix this by removing the proc entry when the module is
unloaded.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Fri, 22 Mar 2019 02:38:16 +0000 (10:38 +0800)]
staging: erofs: Use !x or x in place of NULL comparision
Test for NULL as !x instead of NULL comparisions.
Issue found using coccinelle
Semantic patch used to solve the problem is as follows
// <smpl>
@@
expression x;
statement S;
@@
x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));
-if(x==NULL)
+if(!x)
S
@@
expression e;
@@
-e == NULL
+!e
// </smpl>
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
[ Gao Xiang: fix x != NULL comparision to x as well. ]
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Fri, 22 Mar 2019 13:17:06 +0000 (14:17 +0100)]
staging: rtl8188eu: remove unnecessary parentheses
Remove unnecessary parentheses in rtl8188eu_xmit.c.
Reported by checkpatch.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Thu, 21 Mar 2019 20:13:56 +0000 (01:43 +0530)]
staging: rtl8723bs: core: Remove return variables in rtw_mlme_ext.c
Remove unnecessary local return variables in rtw_mlme_ext.c. Issue found
with Coccinelle using ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Thu, 21 Mar 2019 20:13:54 +0000 (01:43 +0530)]
staging: rtl8723bs: core: Change NULL comparisons to Boolean negation
Change NULL comparisons to Boolean negations. Issue found with
Coccinelle using matchnull.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Thu, 21 Mar 2019 19:55:56 +0000 (01:25 +0530)]
staging: wilc1000: Remove return variables from wilc_spi.c
Remove return variables from wilc_spi.c. Issue found with Coccinelle
using ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Thu, 21 Mar 2019 19:55:55 +0000 (01:25 +0530)]
staging: wilc1000: Remove return variable from host_interface.c
Remove return variable from host_interface.c. Issue found with
Coccinelle using ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Thu, 21 Mar 2019 21:40:05 +0000 (03:10 +0530)]
staging: vt6655: Add spaces around operator
Add spaces around '-' operator to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jules Irenge [Thu, 21 Mar 2019 19:54:08 +0000 (19:54 +0000)]
staging: pi433: remove empty space to fix line over 80 characters warning
Remove empty space to solve checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Fri, 22 Mar 2019 12:40:10 +0000 (18:10 +0530)]
Staging: gdm724x: Remove unnecessary print statements
Remove print statements that provide information about error messages
when memory allocation is failed.
Issue found using coccinelle
The following semantic patch is used to solve this:
<smpl>
@@
expression x;
constant char[] C;
identifier f;
@@
x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));
if(x==NULL)
{
...
(
-f(C,...);
|
-f(...,C);
)
...
}
</smpl>
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Arash Fotouhi [Thu, 21 Mar 2019 19:18:12 +0000 (12:18 -0700)]
Staging: comedi: ni_mio_common.c: Added blank line after declarations
Added blank line after declarations.
Signed-off-by: Arash Fotouhi <arash@arashfotouhi.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Thu, 21 Mar 2019 18:14:05 +0000 (23:44 +0530)]
staging: rtl8723bs: include: remove typedef for struct pno_scan_info
Remove typedef for struct pno_scan_info as The Linux kernel coding style
guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Thu, 21 Mar 2019 18:14:04 +0000 (23:44 +0530)]
staging: rtl8723bs: include: remove typedef for struct pno_scan_channel_info
Remove typedef for struct pno_scan_channel_info as The Linux kernel
coding style guidelines discourage the use of typedefs for struct
types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Thu, 21 Mar 2019 18:14:03 +0000 (23:44 +0530)]
staging: rtl8723bs: include: remove typedef for struct pno_ssid_list
Remove typedef from struct pno_ssid_list as The Linux kernel coding
style guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Thu, 21 Mar 2019 18:14:02 +0000 (23:44 +0530)]
staging: rtl8723bs: include: remove typedef for struct pno_ssid
Remove typedef for struct pno_ssid as The Linux kernel coding style
guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Thu, 21 Mar 2019 18:14:01 +0000 (23:44 +0530)]
staging: rtl8723bs: include: remove typedef for struct pno_nlo_info
Remove typedef for struct pno_nlo_info as the Linux kernel coding style
guidelines discourage the use of typedefs for struct types.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Thu, 21 Mar 2019 18:48:46 +0000 (00:18 +0530)]
staging: rtl8723bs: core: Change NULL comparison to Boolean negation
Change NULL comparison to Boolean negation. Issue found with Coccinelle
using matchnull.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 15:59:06 +0000 (21:29 +0530)]
staging: rtl8712: rtl8712_led.c: remove blank line
To avoid style issues, remove multiple blank lines.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 15:50:54 +0000 (21:20 +0530)]
staging: rtl8712: rtl8712_led.c: alignment should match open parenthesis
Align code to the open parenthesis to fix the alignment issue.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 15:44:10 +0000 (21:14 +0530)]
staging: rtl8712: rtl8712_led.c: remove unnecessary parentheses
Fix unnecessary parentheses issue.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 14:51:45 +0000 (20:21 +0530)]
staging: rtl8712: rtl8712_efuse.h: alignment should match open parenthesis
Align code to the open parenthesis to fix the alignment issue.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 14:46:38 +0000 (20:16 +0530)]
staging: rtl8712: rtl8712_efuse.h: remove blank line
To avoid style issues, remove multiple blank lines.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 14:39:08 +0000 (20:09 +0530)]
staging: rtl8712: alignment should match open parenthesis
Align code to the open parenthesis to fix the alignment issue.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 14:26:43 +0000 (19:56 +0530)]
staging: rtl8712: remove blank line
To avoid style issues, remove multiple blank lines.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhanusree Pola [Thu, 21 Mar 2019 09:35:27 +0000 (15:05 +0530)]
Staging: media: Use !x in place of NULL comparision
Test for NULL as !x instead of NULL comparisions for
functions that return NULL on failure.
Issue found using coccinelle
Semantic patch used to solve the problem is as follows
// <smpl>
@@
expression x;
statement S;
@@
x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));
-if(x==NULL)
+if(!x)
// </smpl>
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himadri Pandya [Thu, 21 Mar 2019 09:57:17 +0000 (15:27 +0530)]
staging: netlogic: Remove unnecessary error print
Kmalloc normally produces a backtrace when there is not enough memory.
So it is unnecessary to print an error message that provides only this
information. Hence, remove pr_error() from memory allocation check.
Issue found using Coccinelle.
Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 10:35:36 +0000 (16:05 +0530)]
staging: vt6655: lines should not end with a parenthesis
Adjust code to fix the style issue – lines should not end with a
parenthesis.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 09:52:56 +0000 (15:22 +0530)]
staging: vt6655: correction in spelling
Correct misspelled word.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anushka Shukla [Thu, 21 Mar 2019 18:26:17 +0000 (23:56 +0530)]
staging: rtl8192e: kconfig: use help over --help--
use help over --help-- for new help text
Signed-off-by: Anushka Shukla <anushkacharu9@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Thu, 21 Mar 2019 15:14:47 +0000 (20:44 +0530)]
staging: rtl8188eu: core: Add spaces around operators
Add spaces around '+' operator to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Thu, 21 Mar 2019 15:12:45 +0000 (20:42 +0530)]
staging: rtl8188eu: core: Remove unnecessary parentheses
Remove unnecessary parentheses after 'address-of' operator
Issue found with checkpatch.pl
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Thu, 21 Mar 2019 07:54:04 +0000 (13:24 +0530)]
staging: rtl8188eu: core: rtw_mlme: Remove return variables.
The last two lines in the function could
be compressed into one. Avoid usage of local variable.
Issue found with Coccinelle using ret.cocci.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Payal Kshirsagar [Thu, 21 Mar 2019 11:40:04 +0000 (17:10 +0530)]
staging: emxx_udc: lines should not end with parenthesis
Adjust code to meet the style of “lines should not end with
parenthesis”.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Thu, 21 Mar 2019 16:31:08 +0000 (22:01 +0530)]
staging: greybus: sdio.c: Remove unncessary paranthesis.
Challenge suggested by coccinelle.
Remove unnecessary parathesis around the right hand of
assignment using the below script.
@@
binary operator op = {==,!=,&&,||,>=,<=,&,|};
expression l, r, t;
@@
(
l = (r op t)
|
l =
-(
r
-)
)
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Thu, 21 Mar 2019 00:06:13 +0000 (05:36 +0530)]
staging: erofs: Replace NULL comparisons
Replace all NULL comparisons in the file to get rid of checkpatch
warnings
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Wed, 20 Mar 2019 18:37:04 +0000 (14:37 -0400)]
staging: gdm724x: Rename dftEpsId to dft_eps_id
Rename member element dftEpsId to dft_eps_id to avoid camelcase.
checkpatch warning: Avoid CamelCase.
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Wed, 20 Mar 2019 23:02:02 +0000 (18:02 -0500)]
Staging: rtl8723bs: Change return type and type of local variable
rtw_startbss_cmd can return the result of calling rtw_enqueue_cmd, which
can return the result of calling _rtw_enqueue_cmd, but they all have
different return types (u8, u32, and sint, respectively).
As all of these functions return error codes, change all the return types
to int, in preparation for converting these functions to use standard
kernel error codes.
Also, remove extern from the function declaration to maintain Linux kernel
coding style.
Issue suggested by Coccinelle.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Wed, 20 Mar 2019 14:31:44 +0000 (17:31 +0300)]
staging: r8188eu: refactor recvframe_defrag()
Local variables pfhdr and prframe always have a same value,
so one of them is unnecessary.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Wed, 20 Mar 2019 17:22:07 +0000 (13:22 -0400)]
staging: wlan-ng: Correct typo in comment message
Add space between two words for better readability in the
comments.
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Wed, 20 Mar 2019 17:22:06 +0000 (13:22 -0400)]
staging: wlan-ng: malformed SPDX-License-Identifier
Correct malformed SPDX-License-Identifier so that it
matches Linux kernel comment coding style.
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Wed, 20 Mar 2019 17:19:15 +0000 (11:19 -0600)]
staging: mt7621-spi: Remove references to nonexistent mt7621_spi_ops
This struct does not exist, and when it is looked up in the
compatibility tree, it returns null. Remove these nonfunctional lines.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Wed, 20 Mar 2019 15:37:18 +0000 (21:07 +0530)]
staging: rtl8188eu: core: rtw_recv.c: Modify return type suggested by Coccinelle.
The last two lines in the function could
be compressed into one. Avoid usage of local variable.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Wed, 20 Mar 2019 13:18:18 +0000 (18:48 +0530)]
staging: rtl8192u: r8192U_dm: Remove unnecessary comments.
Remove comments which are not necessary.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Wed, 20 Mar 2019 12:45:19 +0000 (15:45 +0300)]
staging: netlogic: replace skb_put/pull pair with skb_reserve
The sequence
skb_put(skb);
skb_pull(skb);
leads to the same result as
skb_reserve(skb);
but second is a little shorter and clearer.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Wed, 20 Mar 2019 11:16:18 +0000 (16:46 +0530)]
staging: rtl8192u: ieee80211: ieee80211_rx.c: Remove unnecessary braces.
Remove braces around single statement block.
Issue found by checkpatch.pl
WARNING: braces {} are not necessary for a single statement block
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Wed, 20 Mar 2019 08:50:29 +0000 (09:50 +0100)]
staging: rtl8188eu: remove unused WFD defines
All defined WFD* in wifi.h are unused in the driver code,
so remove them.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Wed, 20 Mar 2019 07:09:01 +0000 (00:09 -0700)]
Staging: unisys: Correct malformed SPDX-License-Identifier
Correct SPDX-License-Identifier comment characters to silence
checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 19 Mar 2019 16:54:44 +0000 (16:54 +0000)]
staging: comedi: ni_mio_common: use insn->n in ni_m_series_eeprom_insn_read()
The `insn_read` handler for the EEPROM subdevice on M-series boards
(`ni_m_series_eeprom_insn_read()`) currently ignores `insn->n` (the
number of samples to read) and assumes a single sample is to be read
into `data[0]`. Fortunately, the Comedi core ensures that `data[]` has
a length of at least 16 so there is no problem with array bounds.
The usual Comedi convention for `insn_read` handlers is to read the same
channel `insn->n` times into successive elements of `data[]` so let's do
that. (Each channel corresponds to a single EEPROM address.) In this
case, the data value comes from a local copy of the EEPROM contents.
Also, follow the usual Comedi convention and return `insn->n` from the
handler to indicate success (although any non-negative value will do).
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 19 Mar 2019 16:54:43 +0000 (16:54 +0000)]
staging: comedi: ni_mio_common: use insn->n in ni_eeprom_insn_read()
The `insn_read` handler for the EEPROM subdevice on E-series boards
(`ni_eeprom_insn_read()`) currently ignores `insn->n` (the number of
samples to read) and assumes a single sample is to be read into
`data[0]`. Fortunately, the Comedi core ensures that `data[]` has a
length of at least 16 so there is no problem with array bounds.
The usual Comedi convention for `insn_read` handlers is to read the same
channel `insn->n` times into successive elements of `data[]` so let's do
that. (Each channel number corresponds to a single EEPROM address.)
Since we do not expect the EEPROM data at a particular address to change
between readings, let's just read it once and copy the value `insn->n`
times.
Also, follow the usual Comedi convention and return `insn->n` from the
handler to indicate success (although any non-negative value will do).
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 19 Mar 2019 16:54:42 +0000 (16:54 +0000)]
staging: comedi: ni_mio_common: use insn->n in ni_calib_insn_read()
The `insn_read` handler for the calibration subdevice
(`ni_calib_insn_read()`) currently ignores `insn->n` (the number of
samples to read) and assumes a single sample is to be read into
`data[0]`. Fortunately, the Comedi core ensures that `data[]` has a
length of at least 16, so there is no problem with array bounds.
The usual Comedi convention for `insn_read` handlers is to read the same
channel `insn->n` times into successive elements of `data[]`, so let's
do that.
Also, follow the usual Comedi convention and return `insn->n` from the
handler to indicate success (although any non-negative value will do).
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 19 Mar 2019 16:54:41 +0000 (16:54 +0000)]
staging: comedi: ni_mio_common: Use insn->n in ni_calib_insn_write()
The `insn_write` handler for the calibration subdevice
(`ni_calib_insn_write()`) currently ignores `insn->n` (the number of
samples to write) and assumes a single sample is to be written, but
`insn->n` could be 0, meaning no samples should be written, in which
case `data[0]` is invalid.
Change `ni_calib_insn_write()` to only write to the calibration device
if `insn->n > 0`. There isn't much point writing all the values when
`insn->n > 1`, so just write the last one (`data[insn->n - 1]`).
Also follow the usual Comedi convention and return `insn->n` from the
handler to indicate success (although any non-negative return value will
do as far as the Comedi core is concerned).
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:12 +0000 (20:20 -0600)]
staging: mt7621-mmc: Only unmap_sg if mapped
A failure while processing the start command could cause dma_unmap_sg()
to be called without first calling dma_map_sg().
Since calling dma_unmap_sg() is only needed when data != NULL, move the
unmap call into the corresponding if {} block.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:11 +0000 (20:20 -0600)]
staging: mt7621-mmc: Fix BRUST -> BURST typo
Obvious typo. It is specified as BURST in the datasheet.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:10 +0000 (20:20 -0600)]
staging: mt7621-mmc: Immediately notify mmc layer of card change detection
There is no need to delay notifying the mmc layer. Schedule the delayed
work to run immediately.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:09 +0000 (20:20 -0600)]
staging: mt7621-mmc: Remove redundant host->mmc->f_max write
This is set once during initialization and never changed. Don't bother
setting it again in the interrupt handler.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:06 +0000 (20:20 -0600)]
staging: mt7621-mmc: Bill the caller for I/O time
When waiting on completions, use the _io variant so the caller is
charged as using I/O.
This should have no effect on the module's functionality, only improve
CPU accounting.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:05 +0000 (20:20 -0600)]
staging: mt7621-mmc: Use pinctrl subsystem to select SDXC pin mode
The driver previously grabbed the SD pins for itself, ignoring the pin
controller. Remove this, and allow the pinctrl subsystem to set up the
pins using the device tree mappings. This allows this driver to work on
related devices that have a different pin controller mapping, such as
the MT7688. The hardcoded bit index was incorrect on that device.
The driver now needs a pin controller reference in its device tree node:
sdhci: /* ... */ {
compatible = "ralink,mt7620-sdhci";
pinctrl-names = "default";
pinctrl-0 = <&sdhci_pins>;
// ...
};
This change could break SD controller functionality on existing devices
whose device trees do not specify a pin controller and state for the SD
node.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:03 +0000 (20:20 -0600)]
staging: mt7621-mmc: Remove obsolete comments and variables
These comments don't contain useful code or alternate implementation
ideas. Remove them.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
George Hilliard [Tue, 19 Mar 2019 02:20:02 +0000 (20:20 -0600)]
staging: mt7621-mmc: fix unused variable compiler warning
The compiler complains:
drivers/staging/mt7621-mmc/dbg.c: In function ‘msdc_debug_proc_write’:
drivers/staging/mt7621-mmc/dbg.c:237:12: warning: unused variable ‘size’ [-Wunused-variable]
int mode, size;
^~~~
drivers/staging/mt7621-mmc/dbg.c:237:6: warning: unused variable ‘mode’ [-Wunused-variable]
int mode, size;
^~~~
Remove these declarations.
Signed-off-by: George Hilliard <thirtythreeforty@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Tue, 19 Mar 2019 19:22:31 +0000 (00:52 +0530)]
staging: fsl-dpaa2: ethsw: Remove return variable
Remove return variable and return return value directly. Issue found by
Coccinelle using ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Wed, 20 Mar 2019 04:44:59 +0000 (21:44 -0700)]
Staging: unisys: visorhba: Replace '--help--' with 'help' in Kconfig
Replace '--help--' in Kconfig and indent the subsequent text to silence
checkpatch.pl
warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Wed, 20 Mar 2019 04:45:00 +0000 (21:45 -0700)]
Staging: unisys: visorinput: Replace '--help--' with 'help' in Kconfig
Replace '--help--' in Kconfig and indent the subsequent text to silence
checkpatch.pl
warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wentao Cai [Wed, 20 Mar 2019 04:45:01 +0000 (21:45 -0700)]
Staging: unisys: visornic: Replace '--help--' with 'help' in Kconfig
Replace '--help--' in Kconfig and indent the subsequent text to silence
checkpatch.pl
warning:
WARNING: prefer 'help' over '---help---' for new help texts
Signed-off-by: Wentao Cai <etsai042@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vatsala Narang [Tue, 19 Mar 2019 20:21:57 +0000 (01:51 +0530)]
staging: sm750fb: Eliminate camel case
Edit CamelCase function name
Issue found by checkpatch.pl
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Tue, 19 Mar 2019 17:46:28 +0000 (23:16 +0530)]
staging: rtl8192u: ieee80211: ieee80211_tx.c: Adjust space around else.
Fix the spacce around else.
Issue found by checkpatch.pl
ERROR: spaces required before that open brace '{'
ERROR: spaces required before that close brace '}'
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Tue, 19 Mar 2019 17:05:26 +0000 (22:35 +0530)]
staging: rtl8192u: ieee80211: ieee80211_rx.c: Fix NULL comparisions.
Replace NULL comparisons in the file.
Issue found by checkpatch.pl
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Tue, 19 Mar 2019 15:26:48 +0000 (20:56 +0530)]
staging: rtl8192u: r8192U_dm: Remove unnecessary blank lines.
Remove unnecessary blank lines.
Issue found by checkpatch.pl
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Tue, 19 Mar 2019 15:25:17 +0000 (20:55 +0530)]
staging: rtl8192u: r8192U_dm: Fix space issue around operators.
Add spaces around the operators.
Issue found by checkpatch.pl
CHECK: spaces preferred around that '+'
CHECK: spaces preferred around that '*'
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Tue, 19 Mar 2019 15:23:55 +0000 (20:53 +0530)]
staging: rtl8192u: r8192U_dm: Fix alignment issue.
Ajdust alignment to match open paranthesis.
Issue found by checkpatch.pl
CHECK: Alignment should match open paranthesis.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Tue, 19 Mar 2019 19:29:11 +0000 (00:59 +0530)]
staging: gasket: Remove return variable
Remove return variable and return the return value directly. Issue
suggested by ret.cocci.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nishka Dasgupta [Tue, 19 Mar 2019 20:03:08 +0000 (01:33 +0530)]
staging: greybus: Remove parentheses around variable
Remove parentheses around variable.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julian Merida [Mon, 18 Mar 2019 23:58:41 +0000 (20:58 -0300)]
staging: erofs: fix parenthesis alignment
Fix all checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Julian Merida <julianmr97@gmail.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhagyashri Dighole [Tue, 19 Mar 2019 11:00:37 +0000 (16:30 +0530)]
staging: fbtft: ternary statement to if statement.
Convert a ternary statement into a if statement which is detected while
resolving "WARNING: line over 80 characters". Use BIT() macro instead
manually left shifting.
Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Emanuel Bennici [Mon, 18 Mar 2019 18:58:43 +0000 (19:58 +0100)]
staging: mt7621-pci-phy: Add Spaces to Macro Definition
Improve Code readability by adding Tabs and Spaces after #define
Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Tue, 19 Mar 2019 12:34:18 +0000 (18:04 +0530)]
Staging: rtl8192u: r8180_93cx6.c: Fix space around '<<'.
Fix the check as per Linux kernel style for use of spaces.
Issue found by checkpatch.pl
CHECK:spaces preffered around that '<<'
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Mon, 18 Mar 2019 23:12:36 +0000 (18:12 -0500)]
Staging: rtl8723bs: Add missing NULL check for kmalloc
Include missing NULL check for kmalloc in function rtw_init_evt_priv.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Mon, 18 Mar 2019 23:12:35 +0000 (18:12 -0500)]
Staging: rtl8723bs: Replace NULL comparison with !
Replace NULL comparison with ! in function rtw_init_cmd_priv, to
maintain Linux kernel coding style.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Mon, 18 Mar 2019 23:12:34 +0000 (18:12 -0500)]
Staging: rtl8723bs: Change values to standard error codes in functions
Change values for standard error codes in functions rtw_init_cmd_priv and
rtw_init_evt_priv, as _SUCCESS should be 0 and _FAIL should be -ENOMEM.
Also, change the values in corresponding call sites of the functions.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Madhumitha Prabakaran [Mon, 18 Mar 2019 23:12:33 +0000 (18:12 -0500)]
Staging: rtl8723bs: Remove unnecessary local variable in function
Remove unnecessary local variable 'res' in function and
replace the value directly in the return of the function.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergey Senozhatsky [Mon, 18 Mar 2019 11:22:21 +0000 (20:22 +0900)]
staging: rtl8723bs: do not use __constant_cpu_to_le16
cpu_to_le16() is capable enough to detect __builtin_constant_p()
and to use an appropriate compile time ___constant_swahbXX()
function.
So we can use cpu_to_le16() instead of __constant_cpu_to_le16().
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Mon, 18 Mar 2019 10:57:49 +0000 (10:57 +0000)]
staging: ks7010: remove redundant auth_type check
The range check on auth_type is redundant as there is a prior
check on the auth_type values and the only way the block is entered
is if auth_type is one of TYPE_PMK1, TYPE_GMK1 and TYPE_GMK2. Hence
the auth_type check can be removed.
Detected by static analysis with cppcheck.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Straube [Mon, 18 Mar 2019 10:23:59 +0000 (11:23 +0100)]
staging: rtl8188eu: remove unused defines from wifi.h
All defined P2P* in wifi.h are unused in the driver code,
so remove them.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Mon, 18 Mar 2019 17:56:31 +0000 (23:26 +0530)]
Staging: rtl8188eu: rtw_ieee80211: Fix indent for 'if' statement.
Adjust indentation for the condition statement.
Issue found by checkpatch.pl
WARNING: suspect code indent for condition statements(8,24)
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Mon, 18 Mar 2019 14:29:44 +0000 (19:59 +0530)]
Staging: rtl8188eu: core: rtw_mlme.c: Replace NULL comparision.
Replace NULL comparison with '!' in the file rtw_mlme.c
Issue found by checkpatch.pl semantic patch results for rtw_mlme.c
CHECK:Comparision to NULL could be written "!candidate"
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sanjana Sanikommu [Mon, 18 Mar 2019 16:18:40 +0000 (21:48 +0530)]
Staging: gasket: gasket_sysfs.c: Fix string split issue.
Concatenate a multi-line string constant into a single
line.Issue found by checkpatch.pl.
WARNING:quoted string split across line.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Branden Bonaby [Mon, 18 Mar 2019 17:25:06 +0000 (13:25 -0400)]
staging: wlan-ng: line over 80 character limit
Align function to prevent it from going over
the 80 character a line limit for readability.
WARNING: line over 80 characters
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jules Irenge [Mon, 18 Mar 2019 13:21:10 +0000 (13:21 +0000)]
staging: speakup: fix printk KERN_LEVEL facility level warning
Replace printk with pr_info to solve checkpatch.pl warning:
" WARNING: printk() should include KERN_<LEVEL> facility level"
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi.git / log