platform/upstream/dotnet/runtime.git
8 years agoMerge pull request dotnet/coreclr#3331 from brianrob/crossgen_perfmap
Jan Kotas [Thu, 25 Feb 2016 02:15:11 +0000 (18:15 -0800)]
Merge pull request dotnet/coreclr#3331 from brianrob/crossgen_perfmap

Update Crossgen /CreatePerfMap to clear NGENWORKER_FLAGS_READYTORUN

Commit migrated from https://github.com/dotnet/coreclr/commit/68569db603a6a0ff3a1414648a0e2b4ea0f870ce

8 years agoMerge pull request dotnet/coreclr#3348 from JohnChen0/master
Jan Kotas [Thu, 25 Feb 2016 00:58:56 +0000 (16:58 -0800)]
Merge pull request dotnet/coreclr#3348 from JohnChen0/master

Fix .gitignore so src/tools is not ignored

Commit migrated from https://github.com/dotnet/coreclr/commit/fd3b7660e8374d4388d25edb507526c0b960d535

8 years agoMerge pull request dotnet/coreclr#3333 from pgavlin/JitAllocatorCleanup
Pat Gavlin [Thu, 25 Feb 2016 00:29:55 +0000 (16:29 -0800)]
Merge pull request dotnet/coreclr#3333 from pgavlin/JitAllocatorCleanup

Remove dead definitions in alloc.h.

Commit migrated from https://github.com/dotnet/coreclr/commit/b3492ccb912ea1e13c4f89e7ecc66b5023177733

8 years agoMerge pull request dotnet/coreclr#3345 from sivarv/vector3fix
Sivarv [Wed, 24 Feb 2016 23:56:25 +0000 (15:56 -0800)]
Merge pull request dotnet/coreclr#3345 from sivarv/vector3fix

Fix to second CoreFX SIMD test failure mentioned in issue dotnet/coreclr#2886.

Commit migrated from https://github.com/dotnet/coreclr/commit/5d85c07b48ec44975e16eb6a0c22d2ccc16f7f1f

8 years agoMerge pull request dotnet/coreclr#3343 from rahku/Helix
Rahul Kumar [Wed, 24 Feb 2016 21:30:48 +0000 (13:30 -0800)]
Merge pull request dotnet/coreclr#3343 from rahku/Helix

Helix testing : Add xunit.performance.core to core_root. required for few jit tests

Commit migrated from https://github.com/dotnet/coreclr/commit/0d88461f079c94cce1dbfc005b41d88cf0bc124c

8 years agoFix to second CoreFX SIMD test failure mentioned in issue dotnet/coreclr#2886.
sivarv [Wed, 24 Feb 2016 19:26:15 +0000 (11:26 -0800)]
Fix to second CoreFX SIMD test failure mentioned in issue dotnet/coreclr#2886.

Root Cause:
The following managed method is executed by the test

  Vector3 Vecor3.Normalize(Vector3)

Vector3 on Unix gets passed in two registers by caller of Normalize()
method.  Within prolog of Normalie(), RyuJIt homes Vector3 arg by
writing only 12 bytes of arg regs xmm0/xmm1. As a result the upper
4-bytes could end up garbage.  Further down test performs dot product
and the codegen of which makes the assumption that Vector3 types
when loaded in regs will have upper 4-bytes zero'ed out.  Since
that assumption is violated, incorrect results gets computed and
hence CoreFx test failure not fiding expected result.

Fix:  While homing Vector3 arg treat it as TYP_SIMD16 and home
16-bytes of arg regs xmm0/xmm1.

Also added a TODO comment on the assumptions RyuJIT is making on
Vector3 type.  Will be opening a Git issue for the same.

Commit migrated from https://github.com/dotnet/coreclr/commit/c12afaa189db63f67720c64e792e9846a58d7604

8 years agoMerge pull request dotnet/coreclr#3315 from AndyAyersMS/InlineRefactor5
Andy Ayers [Wed, 24 Feb 2016 18:41:21 +0000 (10:41 -0800)]
Merge pull request dotnet/coreclr#3315 from AndyAyersMS/InlineRefactor5

InlineRefactoring: introducing InlinePolicy

Commit migrated from https://github.com/dotnet/coreclr/commit/71106b6403a3497a3742d0e7b788b81098a9b007

8 years agoMerge pull request dotnet/coreclr#3233 from vancem/RemoveSecurityCheck
Jan Kotas [Wed, 24 Feb 2016 17:23:01 +0000 (09:23 -0800)]
Merge pull request dotnet/coreclr#3233 from vancem/RemoveSecurityCheck

Revert "Revert "Remove useless security checks""

Commit migrated from https://github.com/dotnet/coreclr/commit/dbff91b27458ee1472ea4ed3f68f49e40b3df5ed

8 years agoMerge pull request dotnet/coreclr#3316 from kyulee1/fixmustexpand
Kyungwoo Lee [Wed, 24 Feb 2016 17:14:48 +0000 (09:14 -0800)]
Merge pull request dotnet/coreclr#3316 from kyulee1/fixmustexpand

Fix for pMustExpand early fail.

Commit migrated from https://github.com/dotnet/coreclr/commit/4c3193cbda64ed2be1354a1ca739c9eed84cfeeb

8 years agoRemove dead definitions in alloc.h.
Pat Gavlin [Tue, 23 Feb 2016 23:46:23 +0000 (15:46 -0800)]
Remove dead definitions in alloc.h.

Just what it says on the tin.

Commit migrated from https://github.com/dotnet/coreclr/commit/6b50b538e0c91a46da9f266d1aa01435cda8a34f

8 years agoUpdate crossgen /CreatePerfMap to clear NGENWORKER_FLAGS_READYTORUN.
Brian Robbins [Tue, 23 Feb 2016 22:01:12 +0000 (14:01 -0800)]
Update crossgen /CreatePerfMap to clear NGENWORKER_FLAGS_READYTORUN.

Commit migrated from https://github.com/dotnet/coreclr/commit/78f3320ae95430479fe375240989236587262415

8 years agoFix for pMustExpand early fail.
Kyungwoo Lee [Tue, 23 Feb 2016 16:34:59 +0000 (08:34 -0800)]
Fix for pMustExpand early fail.

When EE tells Jit to enforce intrinsic expansion, we also checked whether
the intrinsic will be turned into a user call by IsIntrinsicImplementedByUserCall.
In fact, this API is primarily for math intrinsic and thus somewhat ambiguous since
even for any arbitrary non-math intrinsic ID, it returns true.
There are some side-effects, so I didn't refactor this API in this change.
Instead, the fix for pMustExpand is to check whether gtFlags has GTF_CALL.

Commit migrated from https://github.com/dotnet/coreclr/commit/650a53b9d0778525cfec881e6ea88d58e15451cd

8 years agoInlineRefactoring: introducing InlinePolicy
Andy Ayers [Mon, 22 Feb 2016 21:51:52 +0000 (13:51 -0800)]
InlineRefactoring: introducing InlinePolicy

Split the policy aspect of the InlineResult into a separate
policy object, acessed from the InlineResult via a base class.

Implement a LegacyPolicy to capture today's behavior.

Create a factory method for determining what policy to use. Right
now it always creates a LegacyPolicy. This is newed up for each
Inline decision, but since the InlineResult has relatively short
lifetime, we should probably recycle policy objects (might be
more desirable once they start having a bit more state).

Split out a bunch of the InlineDecision helper methods that lived
on InlineResult into global methods since policies will want to refer
to them too. Shame that enum classes don't allow member functions.

Commit migrated from https://github.com/dotnet/coreclr/commit/d5d25db5934520997ef085bd5f973451fd15a947

8 years agoMerge pull request dotnet/coreclr#3300 from dotnet/InlineRefactor4f
Andy Ayers [Tue, 23 Feb 2016 16:21:51 +0000 (08:21 -0800)]
Merge pull request dotnet/coreclr#3300 from dotnet/InlineRefactor4f

InlineRefactoring: capture remaining failing cases in inline tree

Commit migrated from https://github.com/dotnet/coreclr/commit/e9fa953a295d16b7e00e9192b4973743398358e9

8 years agoMerge pull request dotnet/coreclr#3301 from stephentoub/fix_guid_tryparse
Jan Kotas [Tue, 23 Feb 2016 15:03:14 +0000 (07:03 -0800)]
Merge pull request dotnet/coreclr#3301 from stephentoub/fix_guid_tryparse

Fix Guid.TryParse to not throw FormatException

Commit migrated from https://github.com/dotnet/coreclr/commit/b8f49126e79e850382d8837241b0dd27566de91f

8 years agoMerge pull request dotnet/coreclr#3307 from krytarowski/netbsd-support-56
Jan Kotas [Tue, 23 Feb 2016 14:59:03 +0000 (06:59 -0800)]
Merge pull request dotnet/coreclr#3307 from krytarowski/netbsd-support-56

Fix build issue on NetBSD: Include <stdarg.h> for va_list

Commit migrated from https://github.com/dotnet/coreclr/commit/c9dc9eab848e88142329435348538feedf9af03f

8 years agoInlineRefactoring: capture remaining failing cases in inline tree
Andy Ayers [Mon, 22 Feb 2016 18:38:49 +0000 (10:38 -0800)]
InlineRefactoring: capture remaining failing cases in inline tree

The main ininling loop in `fgInline` currently only looks at calls
that are inline candidates and at top-level in their statements.
This is sensible since any call that is an inline candidate has been
hoisted to top-level during importing.

However, to find all the failed inline cases, the jit also needs to
look through the full tree to find calls that were not identified as
candidates.

For instance, in the Secant test, the jit decides to inline `TestBase`
into `Main`. While importing the code for `TestBase` for inlining, the
jit sees that the call to `Bench` is marked with
`[MethodImpl(MethodImplOptions.NoInlining)]` and so the call is not
considered to be an inline candidate. And because `Bench` returns a
value, the call expression is in a subtree under an assign expression.
Thus the failure to inline `Bench` is overlooked by the current code.

```
;; current code
Inlines into Secant:Main():int
  [IL=0000 TR=000001] [below ALWAYS_INLINE size] Secant:TestBase():bool
```

With this change, under DEBUG, the main inline control loop in `fgInline`
now also scans the tree for non-candidates, and adds their failures
to the InlineContext tree in appropriate locations.

`fgMorphInline` and `fgMorphInlineHelper` are now simpified since they
can assume any call they see must be a candidate.

The jit now also only notes failures for `CT_USER_FUNC` calls, since
otherwise the trees would be full of failed calls to helpers and the
like.

With this change, the jit can now report that `Bench` is a failed inline
into `Main`.

```
;; new code
Inlines into Secant:Main():int
  [IL=0000 TR=000001] [below ALWAYS_INLINE size] Secant:TestBase():bool
    [IL=0000 TR=000021] [FAILED: noinline per IL/cached result] Secant:Bench():bool
```

Commit migrated from https://github.com/dotnet/coreclr/commit/fff03183878a074539544f9b3c3d1cda8176fc85

8 years agoMerge pull request dotnet/coreclr#3303 from LLITCHEV/PutArgStk-GC-hole
Lubomir Litchev [Tue, 23 Feb 2016 03:25:46 +0000 (19:25 -0800)]
Merge pull request dotnet/coreclr#3303 from LLITCHEV/PutArgStk-GC-hole

Fix a hole in the GC generated for PutArgStructStk.
Thanks all!

Commit migrated from https://github.com/dotnet/coreclr/commit/bdd5be00414fc53d427a03f515e447f73f4fd5c5

8 years agoMerge pull request dotnet/coreclr#3304 from andschwa/sigchld
Jan Kotas [Tue, 23 Feb 2016 03:04:24 +0000 (19:04 -0800)]
Merge pull request dotnet/coreclr#3304 from andschwa/sigchld

Remove mask of SIGCHLD

Commit migrated from https://github.com/dotnet/coreclr/commit/0b1b9f4052de4019bb111f835771dfbba9c814c9

8 years agoAdd xunit.performance.core to core_root. required for few jit tests
Rahul Kumar [Tue, 23 Feb 2016 02:03:28 +0000 (18:03 -0800)]
Add xunit.performance.core to core_root. required for few jit tests

Commit migrated from https://github.com/dotnet/coreclr/commit/e1a873cc9215fe92831c4b8c665fc07d60746b43

8 years agoMerge pull request dotnet/coreclr#3248 from adityamandaleeka/twowaypipe_cleanup
Aditya Mandaleeka [Tue, 23 Feb 2016 02:03:20 +0000 (18:03 -0800)]
Merge pull request dotnet/coreclr#3248 from adityamandaleeka/twowaypipe_cleanup

Disambiguate debug pipe names with more than just PID

Commit migrated from https://github.com/dotnet/coreclr/commit/0a3fe0f45ae75f31db0b5d2518847ed51b4f13dd

8 years agoFix a hole in the GC generated for PutArgStructStk.
Lubomir Litchev [Mon, 22 Feb 2016 22:45:53 +0000 (14:45 -0800)]
Fix a hole in the GC generated for PutArgStructStk.

On System V there is a hole (tanks @CarolEidt for pointing it out) where
while copying struct to the stack in the OutgoingParamArea the GC-ness
for the register used to copy the struct is not  properly set.
This change fixes the issue.

This change also makes sure when copying to/from stack, an emitAttr of
EA_PTRSIZE is used - stack variables are never moved by GC, so using this
type in such case should is fine.

Commit migrated from https://github.com/dotnet/coreclr/commit/21db33e10cfee04f914fdaceefa1ed2fd2ad1f52

8 years agoFix build issue on NetBSD: Include <stdarg.h> for va_list
Kamil Rytarowski [Tue, 23 Feb 2016 00:17:42 +0000 (01:17 +0100)]
Fix build issue on NetBSD: Include <stdarg.h> for va_list

This has been triggered during llilc build.

Commit migrated from https://github.com/dotnet/coreclr/commit/5c8e36a432f78f6535121b3e271804d49e8e6814

8 years agoRemove mask of SIGCHLD
Andrew Schwartzmeyer [Mon, 22 Feb 2016 23:08:05 +0000 (15:08 -0800)]
Remove mask of SIGCHLD

When a .NET Core program invoked a process that invoked its own child,
the masking of SIGCHLD prevented the process from recognizing its child
had exited, which some processes require. This caused the .NET Core app
to hang in certain internal scenarios.

Commit migrated from https://github.com/dotnet/coreclr/commit/d0ede1557b29f833268845ba85fd27bb66fcb23b

8 years agoMerge pull request dotnet/coreclr#3293 from jkotas/r2r-default-callconv
Jan Kotas [Mon, 22 Feb 2016 21:47:27 +0000 (13:47 -0800)]
Merge pull request dotnet/coreclr#3293 from jkotas/r2r-default-callconv

Use default calling convention small type widening rules for R2R

Commit migrated from https://github.com/dotnet/coreclr/commit/50d84032861511d703125d80b9b4a6da11c2650a

8 years agoMerge pull request dotnet/coreclr#3298 from jkotas/ryujit-version
Jan Kotas [Mon, 22 Feb 2016 21:47:08 +0000 (13:47 -0800)]
Merge pull request dotnet/coreclr#3298 from jkotas/ryujit-version

Update RyuJIT package version

Commit migrated from https://github.com/dotnet/coreclr/commit/9a4dbc7fecf1dbafea614882c0c44ff22ee4ca8d

8 years agoMerge pull request dotnet/coreclr#3302 from wtgodbe/datetime
William Godbe [Mon, 22 Feb 2016 21:39:00 +0000 (13:39 -0800)]
Merge pull request dotnet/coreclr#3302 from wtgodbe/datetime

Integrate ToF version of DateTimeKind test to prevent failures on non-Windows platforms

Commit migrated from https://github.com/dotnet/coreclr/commit/1cf4b0eb05fe2ae3ec6ccc0688290195bc9d5fcb

8 years agoFix Guid.TryParse to not throw FormatException
stephentoub [Mon, 22 Feb 2016 19:58:49 +0000 (14:58 -0500)]
Fix Guid.TryParse to not throw FormatException

In certain situations, e.g.
```
Guid g;
Guid.TryParse("{0xdddddddd, 0xdddd, 0xdddd,{0xdd0xdd,0xdd,0xdd,0xdd,0xdd,0xdd,0xdd}}", out g);
```
Guid.TryParse is throwing a FormatException rather than returning false.  This is due to a call to Convert.ToInt32 on one code path that's throwing.

Commit migrated from https://github.com/dotnet/coreclr/commit/6f387a835b4da5fce3bc199bd4286f15467e2f52

8 years agoMerge pull request dotnet/coreclr#3244 from erozenfeld/SIMDInit
Eugene Rozenfeld [Mon, 22 Feb 2016 21:12:18 +0000 (13:12 -0800)]
Merge pull request dotnet/coreclr#3244 from erozenfeld/SIMDInit

Fix for SIMD Initialize intrinsic expansion.

Commit migrated from https://github.com/dotnet/coreclr/commit/7728a1274d3729b0691602f4090e7ffcbe53018c

8 years agoMerge pull request dotnet/coreclr#3259 from sejongoh/add_corefx_minopts
Sejong Oh [Mon, 22 Feb 2016 20:36:12 +0000 (12:36 -0800)]
Merge pull request dotnet/coreclr#3259 from sejongoh/add_corefx_minopts

Add minopts and fix few bugs

Commit migrated from https://github.com/dotnet/coreclr/commit/c1109f39a7298b8e8ccec1b48ead102932fa9516

8 years agoAdd minopts and fix few bugs
Sejong Oh [Fri, 19 Feb 2016 20:55:53 +0000 (12:55 -0800)]
Add minopts and fix few bugs

Commit migrated from https://github.com/dotnet/coreclr/commit/55894a7344b4a23a22d1a24deffdd562a05f06bd

8 years agoIntegrate ToF version of DateTimeKind test to prevent failures on non-Windows platforms
William Godbe [Mon, 22 Feb 2016 20:11:28 +0000 (12:11 -0800)]
Integrate ToF version of DateTimeKind test to prevent failures on non-Windows platforms

Commit migrated from https://github.com/dotnet/coreclr/commit/f5bdec238852f4e0e164508acb633678879a6bfd

8 years agoMerge pull request dotnet/coreclr#3294 from jkotas/delete-zero-offset-allowed
Jan Kotas [Mon, 22 Feb 2016 19:42:58 +0000 (11:42 -0800)]
Merge pull request dotnet/coreclr#3294 from jkotas/delete-zero-offset-allowed

Delete FEATURE_REF_ZERO_OFFSET_ALLOWED

Commit migrated from https://github.com/dotnet/coreclr/commit/98c2b749ef5b7441f79d2ce1cfaf2665b7f138cf

8 years agoMerge pull request dotnet/coreclr#3266 from rahku/Helix
Rahul Kumar [Mon, 22 Feb 2016 19:37:11 +0000 (11:37 -0800)]
Merge pull request dotnet/coreclr#3266 from rahku/Helix

add helix run support to coreclr repo

Commit migrated from https://github.com/dotnet/coreclr/commit/e4be82f41fa5032b6a622e74404e92468b5806a8

8 years agoadd helix run support to coreclr repo
Rahul Kumar [Mon, 25 Jan 2016 22:50:20 +0000 (14:50 -0800)]
add helix run support to coreclr repo

Commit migrated from https://github.com/dotnet/coreclr/commit/a8741647cfa038e67a644237bd0806b78fb77b46

8 years agoUpdate RyuJIT package version
Jan Kotas [Mon, 22 Feb 2016 19:29:30 +0000 (11:29 -0800)]
Update RyuJIT package version

Commit migrated from https://github.com/dotnet/coreclr/commit/e538b22fb0fa25c364d9348d5af590eef940a006

8 years agoMerge pull request dotnet/coreclr#3270 from CarolEidt/x86TypeCtxtOnFrame
Carol Eidt [Mon, 22 Feb 2016 18:47:28 +0000 (10:47 -0800)]
Merge pull request dotnet/coreclr#3270 from CarolEidt/x86TypeCtxtOnFrame

Mark compTypeCtxtArg as lvOnFrame

Commit migrated from https://github.com/dotnet/coreclr/commit/284729c614bd87dc7db2834dbcde909fd4275116

8 years agoAdd in code to do NullArgumentChecks for compatibiity
Vance Morrison [Mon, 22 Feb 2016 18:31:44 +0000 (10:31 -0800)]
Add in code to do NullArgumentChecks for compatibiity

Commit migrated from https://github.com/dotnet/coreclr/commit/d47f6dce43ce951e48c431a7ececd9e0c54cb925

8 years agoMerge pull request dotnet/coreclr#3282 from gkhanna79/WinX86Nuget
Gaurav Khanna [Mon, 22 Feb 2016 18:10:06 +0000 (09:10 -0900)]
Merge pull request dotnet/coreclr#3282 from gkhanna79/WinX86Nuget

Generate WinX86 Nuget package

Commit migrated from https://github.com/dotnet/coreclr/commit/7134c1fda85aa147b74401d99275df2a2bd7a985

8 years agoDelete FEATURE_REF_ZERO_OFFSET_ALLOWED
Jan Kotas [Mon, 22 Feb 2016 17:47:53 +0000 (09:47 -0800)]
Delete FEATURE_REF_ZERO_OFFSET_ALLOWED

Commit migrated from https://github.com/dotnet/coreclr/commit/ba504fb286a56178e5e9d1a830438de553bd6298

8 years agoMerge pull request dotnet/coreclr#3289 from AndyAyersMS/InlineRefactor4e
Andy Ayers [Mon, 22 Feb 2016 17:38:39 +0000 (09:38 -0800)]
Merge pull request dotnet/coreclr#3289 from AndyAyersMS/InlineRefactor4e

Inline refactoring: split up depth and recursion checks

Commit migrated from https://github.com/dotnet/coreclr/commit/bc60ca1cc2602b3ce667464be1d065af1df7e0f7

8 years agoUse default calling convention small type widening rules for R2R
Jan Kotas [Mon, 22 Feb 2016 17:38:34 +0000 (09:38 -0800)]
Use default calling convention small type widening rules for R2R

Sticking to default calling convention is key for interoperability that is the primary goal of R2R.

Commit migrated from https://github.com/dotnet/coreclr/commit/7f61feafae3cdc9e560629e0bf2a03e64936a7b5

8 years agoGenerate WinX86 Nuget package
Gaurav Khanna [Sun, 21 Feb 2016 01:35:42 +0000 (17:35 -0800)]
Generate WinX86 Nuget package

Commit migrated from https://github.com/dotnet/coreclr/commit/7077d3a5bad55d011c6c838d4ffab22cc5097ae3

8 years agoMerge pull request dotnet/coreclr#3286 from sejongoh/add_export
Matt Mitchell [Mon, 22 Feb 2016 16:10:48 +0000 (08:10 -0800)]
Merge pull request dotnet/coreclr#3286 from sejongoh/add_export

Add export to define environment variables

Commit migrated from https://github.com/dotnet/coreclr/commit/e7dfcbb625d52f9d04dfe8f5f78349795178ac8b

8 years agoMerge pull request dotnet/coreclr#3255 from juergenhoetzel/build_script_fixes
Jan Vorlicek [Mon, 22 Feb 2016 12:37:36 +0000 (13:37 +0100)]
Merge pull request dotnet/coreclr#3255 from juergenhoetzel/build_script_fixes

Handle CMakeArgs correctly

Commit migrated from https://github.com/dotnet/coreclr/commit/4e15bf1e269ceb51dbbc18df2cfb73952f4028db

8 years agoMerge pull request dotnet/coreclr#3260 from gkhanna79/CentOS
Matt Ellis [Mon, 22 Feb 2016 06:19:14 +0000 (22:19 -0800)]
Merge pull request dotnet/coreclr#3260 from gkhanna79/CentOS

Fixes to build CentOS CoreCLR Nuget Package

Commit migrated from https://github.com/dotnet/coreclr/commit/b4304b1ad2c0aee2363c3cffb5485d9844f70d73

8 years agoMerge pull request dotnet/coreclr#3290 from krytarowski/netbsd-support-55
Jan Kotas [Mon, 22 Feb 2016 02:36:30 +0000 (18:36 -0800)]
Merge pull request dotnet/coreclr#3290 from krytarowski/netbsd-support-55

PAL tests on NetBSD: Clean-up

Commit migrated from https://github.com/dotnet/coreclr/commit/4bdea050e863027da07c7c8eb8d1c6dfa7dcbab3

8 years agoTemporarily disable paltest_pal_sxs_test1 on NetBSD
Kamil Rytarowski [Mon, 22 Feb 2016 00:01:04 +0000 (01:01 +0100)]
Temporarily disable paltest_pal_sxs_test1 on NetBSD

This test has been also disabled on FreeBSD as hardware exceptions
always seem to abort on NetBSD as well.

Related issues: dotnet/coreclrdotnet/coreclr#2090 dotnet/coreclrdotnet/coreclr#3287

Commit migrated from https://github.com/dotnet/coreclr/commit/ea2bbc1f34240764bf9683c27fab632a9a103308

8 years agoFix typo in the name of the paltest_getcurrentthread_test2 test
Kamil Rytarowski [Sun, 21 Feb 2016 23:43:15 +0000 (00:43 +0100)]
Fix typo in the name of the paltest_getcurrentthread_test2 test

It was recently disabled on NetBSD and due to pasto it reports a wrong name.

Commit migrated from https://github.com/dotnet/coreclr/commit/693034eeb712a6a008d52edb39122aafdcd108e2

8 years agoInline refactoring: split up depth and recursion checks
Andy Ayers [Sat, 20 Feb 2016 19:21:08 +0000 (11:21 -0800)]
Inline refactoring: split up depth and recursion checks

Separate out the recursive inline and inline too deep obervations.
Have the checker update the inline result directly rather than
deferring to the caller.

Add a bit more commentary on how the various inline classes
are used during compilation.

Commit migrated from https://github.com/dotnet/coreclr/commit/336832d2119d3877f633891b367315ee935afdd7

8 years agoMerge pull request dotnet/coreclr#3275 from AndyAyersMS/InlineRefactor4d
Andy Ayers [Sun, 21 Feb 2016 19:37:42 +0000 (11:37 -0800)]
Merge pull request dotnet/coreclr#3275 from AndyAyersMS/InlineRefactor4d

InlineRefactoring: start to capture failures in the inline tree

Commit migrated from https://github.com/dotnet/coreclr/commit/c2a8bfad36f433fed397efc1419f948709ccfc5e

8 years agoMerge pull request dotnet/coreclr#3278 from jamesqo/patch-7
Jan Kotas [Sun, 21 Feb 2016 14:22:06 +0000 (06:22 -0800)]
Merge pull request dotnet/coreclr#3278 from jamesqo/patch-7

Short-circuit for empty strings in string.Insert and Remove

Commit migrated from https://github.com/dotnet/coreclr/commit/53148ebbc2b62f7a9b0d2369003ef7087a4c3e3c

8 years agoMerge pull request dotnet/coreclr#3285 from krytarowski/netbsd-support-54
Jan Kotas [Sun, 21 Feb 2016 14:11:54 +0000 (06:11 -0800)]
Merge pull request dotnet/coreclr#3285 from krytarowski/netbsd-support-54

Fix test issue on NetBSD: Walk-around getrusage(2) implementation nits

Commit migrated from https://github.com/dotnet/coreclr/commit/dec83bd64d40fcff76e14f5700b8fb69413e4057

8 years agoAdd export to define environment variables
Sejong Oh [Sun, 21 Feb 2016 07:51:26 +0000 (23:51 -0800)]
Add export to define environment variables

Commit migrated from https://github.com/dotnet/coreclr/commit/85df1f59fae915e0e165d3649d329047a931eed2

8 years agoFix test issue on NetBSD: Walk-around getrusage(2) implementation nits
Kamil Rytarowski [Sun, 21 Feb 2016 04:36:03 +0000 (05:36 +0100)]
Fix test issue on NetBSD: Walk-around getrusage(2) implementation nits

The following code:

int main(int argc, char **argv)
{
    int i, j, k, total;
    struct rusage resUsage1, resUsage2;

    if (getrusage (RUSAGE_SELF, &resUsage1) == -1)
        errx(1, "getrusage");

    /* simulate some activity */
    for( i=0; i<1000; i++ )
    {
        for( j=0; j<1000; j++ )
        {
            total = j * i;
            for( k=0; k<1000; k++ )
            {
                total += k + i;
            }
        }
    }

    if (getrusage (RUSAGE_SELF, &resUsage2) == -1)
        errx(1, "getrusage");

    printf("kernel1 %ld.%06ld\n", resUsage1.ru_stime.tv_sec, resUsage1.ru_stime.tv_usec);
    printf("kernel2 %ld.%06ld\n", resUsage2.ru_stime.tv_sec, resUsage2.ru_stime.tv_usec);

    printf("user1 %ld.%06ld\n", resUsage1.ru_utime.tv_sec, resUsage1.ru_utime.tv_usec);
    printf("user2 %ld.%06ld\n", resUsage2.ru_utime.tv_sec, resUsage2.ru_utime.tv_usec);

    return 0;
}

Returns the following values:

$ ./test
kernel1 0.000262
kernel2 0.000000
user1 0.000262
user2 2.279965

The reason for it is as follows:

    The reason is that the scheduler keeps a precise total cpu time of
    a process but the systime/usertime is only sampled by a much slower
    clock. The ratio systime/usertime is then used to return an approximation
    so that systime and usertime sum up to the total time(*).

    As a result it is possible that usertime or systime go backwards.

    FreeBSD has implemented a workaround by remembering reported
    usertime/systime values for a process and clamping getrusage()
    against these values. As a result the usertime/systime value
    is usually too high but it is monotonic.

    Another approach would be to round down the usertime/systime values,
    by not approximating 'measurments' that do not exist. The result
    would be that usertime/systime values that are too low and don't
    sum up to the total CPU time but are again monotonic.

    The approximation is done in kern_resource/calc().
    (*) The sampled interrupt time is also included.

-- by Michael van Elst
-- http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=30115

Walkaround it by doing kernel-work with subsequent malloc(3) and free(3) calls.
Note that doing these calls for smaller chunks (it looks like a compiler/libc
can optimize it without going to the host kernel) or just 1000 times is not
sufficient.

Commit migrated from https://github.com/dotnet/coreclr/commit/4c389ad3e373cf4bb6ae643e8a91b7104eb6c39a

8 years agoShort-circuit for empty strings in Insert/Remove
James Ko [Sun, 21 Feb 2016 02:44:23 +0000 (21:44 -0500)]
Short-circuit for empty strings in Insert/Remove

Commit migrated from https://github.com/dotnet/coreclr/commit/74709851898330c6ac3a20eb04d085e9b0e2dcf0

8 years agoMerge pull request dotnet/coreclr#3280 from jamesqo/patch-8
Jan Kotas [Sun, 21 Feb 2016 02:27:09 +0000 (18:27 -0800)]
Merge pull request dotnet/coreclr#3280 from jamesqo/patch-8

Avoid string allocations in some Concat overloads

Commit migrated from https://github.com/dotnet/coreclr/commit/a8e10c51b050917606b755b1f11f2a3dd9436dcf

8 years agoMerge pull request dotnet/coreclr#3279 from krytarowski/netbsd-support-53
Jan Kotas [Sun, 21 Feb 2016 01:01:42 +0000 (17:01 -0800)]
Merge pull request dotnet/coreclr#3279 from krytarowski/netbsd-support-53

Disable not relevant tests for NetBSD: SCHED_OTHER may not be reassignable

Commit migrated from https://github.com/dotnet/coreclr/commit/77374b2d56441e924d0340a0c3da04e19a3d53dc

8 years agoRemove trailing whitespace
Kamil Rytarowski [Sat, 20 Feb 2016 23:44:02 +0000 (00:44 +0100)]
Remove trailing whitespace

Commit migrated from https://github.com/dotnet/coreclr/commit/f05754aa297c3bb66a296bea1f3e7ffba09a5c47

8 years agoAvoid string allocations in some Concat overloads
James Ko [Sat, 20 Feb 2016 23:47:24 +0000 (18:47 -0500)]
Avoid string allocations in some Concat overloads

Commit migrated from https://github.com/dotnet/coreclr/commit/b99e5c1638a7e909c918be313ef386b7d0ccb3c3

8 years agoDisable not relevant tests for NetBSD: SCHED_OTHER may not be reassignable
Kamil Rytarowski [Sat, 20 Feb 2016 23:41:04 +0000 (00:41 +0100)]
Disable not relevant tests for NetBSD: SCHED_OTHER may not be reassignable

This addresses the following issues:

threading/GetCurrentThread/test1/paltest_getcurrentthread_test1. Exit code: 1
threading/GetCurrentThread/test2/paltest_getcurrentthread_test2. Exit code: 1
threading/GetProcessTimes/test2/paltest_getprocesstimes_test2. Exit code: 1

Commit migrated from https://github.com/dotnet/coreclr/commit/c341d9b33e5b827e48f52671a21bf3dde89fd5c8

8 years agoMerge pull request dotnet/coreclr#3265 from wtgodbe/coverage
Sergiy Kuryata [Sat, 20 Feb 2016 21:56:34 +0000 (13:56 -0800)]
Merge pull request dotnet/coreclr#3265 from wtgodbe/coverage

Add option to runtest.sh to generate code coverage reports for coreclr

Commit migrated from https://github.com/dotnet/coreclr/commit/2a694dd1cea6cd7d176893ad661041cd1dacf9a2

8 years agoMerge pull request dotnet/coreclr#3262 from wtgodbe/disable
Jan Kotas [Sat, 20 Feb 2016 19:39:27 +0000 (11:39 -0800)]
Merge pull request dotnet/coreclr#3262 from wtgodbe/disable

Delete poorly-written tests failing on OSX

Commit migrated from https://github.com/dotnet/coreclr/commit/a4bc674885e548d039ec68a139c48f2be8c90e2a

8 years agoMerge pull request dotnet/coreclr#3274 from jamesqo/patch-5
Jan Kotas [Sat, 20 Feb 2016 19:38:04 +0000 (11:38 -0800)]
Merge pull request dotnet/coreclr#3274 from jamesqo/patch-5

Remove unnecessary ref parameters from String.cs

Commit migrated from https://github.com/dotnet/coreclr/commit/168db67b352e3a43acbbff8c07b215b42e5d751b

8 years agoRemove unnecessary ref parameters from String.cs
James Ko [Sat, 20 Feb 2016 17:24:02 +0000 (12:24 -0500)]
Remove unnecessary ref parameters from String.cs

For some reason, there seems to be some code in String.Split that takes ref parameters, even though they aren't actually assigned to.

This commit removes the `ref` annotations from the methods and their callers.

Commit migrated from https://github.com/dotnet/coreclr/commit/7ce28d1a2efd44eeeb6bc15d2dd11272e4759df6

8 years agoMerge pull request dotnet/coreclr#3221 from jamesqo/patch-5
Jan Kotas [Sat, 20 Feb 2016 16:34:38 +0000 (08:34 -0800)]
Merge pull request dotnet/coreclr#3221 from jamesqo/patch-5

Optimize String.Replace when the chars are the same

Commit migrated from https://github.com/dotnet/coreclr/commit/a2010dfb628b2d7409a2ad9752309388181e8823

8 years agoMerge pull request dotnet/coreclr#3269 from JoshVarty/master
Jan Kotas [Sat, 20 Feb 2016 16:29:28 +0000 (08:29 -0800)]
Merge pull request dotnet/coreclr#3269 from JoshVarty/master

Fix ecma-spec link

Commit migrated from https://github.com/dotnet/coreclr/commit/8b4162ebd4b4e9deb5f8829404f671cda4d71c36

8 years agoMerge pull request dotnet/coreclr#3273 from krytarowski/netbsd-support-52
Jan Kotas [Sat, 20 Feb 2016 16:27:46 +0000 (08:27 -0800)]
Merge pull request dotnet/coreclr#3273 from krytarowski/netbsd-support-52

Disallow setting of priority for SCHED_OTHER threads on NetBSD

Commit migrated from https://github.com/dotnet/coreclr/commit/44cd35e3d9a8eda6713c1bbdebe85609f055323d

8 years agoDisallow setting of priority for SCHED_OTHER threads on NetBSD
Kamil Rytarowski [Sat, 20 Feb 2016 14:51:18 +0000 (15:51 +0100)]
Disallow setting of priority for SCHED_OTHER threads on NetBSD

There are 7 PAL tests that are falling down due to calling
pthread_setschedparam(3) on NetBSD.

Diving into the kernel code I have found that SCHED_OTHER does not support
setting priorities other than PRI_NONE.

        /* Disallow setting of priority for SCHED_OTHER threads */
        if (lpolicy == SCHED_OTHER && pri != PRI_NONE) {
            lwp_unlock(t);
            error = EINVAL;
            break;
        }

-- NetBSD sources sys/kern/sys_sched.c Line 167

/usr/include/sys/param.h:#define    PRI_NONE        (-1)

It looks like the same rule applies for Linux:

       SCHED_OTHER is the default universal time-sharing scheduler policy used
       by most processes, SCHED_FIFO and SCHED_RR  are  intended  for  special
       time-critical  applications  that  need precise control over the way in
       which runnable processes are selected for execution.  Processes  sched-
       uled with SCHED_OTHER must be assigned the static priority 0, processes
       scheduled under SCHED_FIFO or SCHED_RR can have a  static  priority  in
       the  range  1 to 99. Only processes with superuser privileges can get a
       ordering within the list of runnable processes with equal static prior-
       ity.

-- http://ccrma.stanford.edu/planetccrma/man/man2/sched_setscheduler.2.html

Standard says:

    The pthread_getschedparam() and pthread_setschedparam() functions shall,
    respectively, get and set the scheduling policy and parameters of individual
    threads within a multi-threaded process to be retrieved and set. For
    SCHED_FIFO and SCHED_RR, the only required member of the sched_param
    structure is the priority sched_priority. For SCHED_OTHER, the affected
    scheduling parameters are implementation-defined.

    The policy parameter may have the value SCHED_OTHER, SCHED_FIFO, or
    SCHED_RR. The scheduling parameters for the SCHED_OTHER policy are
    implementation-defined. The SCHED_FIFO and SCHED_RR policies shall have a
    single scheduling parameter, priority.

http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_getschedparam.html

The culprit code is here: src/pal/src/thread/thread.cpp Line 1276

Fix dotnet/coreclr#3272

Commit migrated from https://github.com/dotnet/coreclr/commit/d279c120b271393726920d85f46c2b503cb1b14d

8 years agoFix misleading typo
Juergen Hoetzel [Sat, 20 Feb 2016 09:58:03 +0000 (10:58 +0100)]
Fix misleading typo

Commit migrated from https://github.com/dotnet/coreclr/commit/d5a6959435a3ce8fbf0217c9b74425c66f4e3aa1

8 years agoHandle CMakeArgs correctly
Juergen Hoetzel [Fri, 19 Feb 2016 14:38:24 +0000 (15:38 +0100)]
Handle CMakeArgs correctly

CMakeArgs were not passed correctly to (included initial whitespace).
Also unquote CMakeArgs to allow us to pass multiple cmake arguments.

Commit migrated from https://github.com/dotnet/coreclr/commit/49da0f48512f92c40ccd6357c99e0a7a510f15aa

8 years agoMark compTypeCtxtArg as lvOnFrame
Carol Eidt [Sat, 20 Feb 2016 05:55:47 +0000 (21:55 -0800)]
Mark compTypeCtxtArg as lvOnFrame

The type context argument must be initialized to lvOnFrame if it is
not a register argument (as on x86, since it is passed after user
arguments).

Commit migrated from https://github.com/dotnet/coreclr/commit/4e7444549e94d6c4857448fe74434a0ae7fb8272

8 years agoFix ecma-spec link
Josh Varty [Sat, 20 Feb 2016 05:10:15 +0000 (00:10 -0500)]
Fix ecma-spec link

Commit migrated from https://github.com/dotnet/coreclr/commit/3d20b2ea1c6c731056b6a1b4bfac624f826474b6

8 years agoMerge pull request dotnet/coreclr#2998 from ramarag/LongFileSupport
Rama krishnan Raghupathy [Sat, 20 Feb 2016 03:31:15 +0000 (19:31 -0800)]
Merge pull request dotnet/coreclr#2998 from ramarag/LongFileSupport

Initial Support  for LongFile in the VM

Commit migrated from https://github.com/dotnet/coreclr/commit/7045ca7a6de381b382a709dc0a61f49ca713d160

8 years agoInlineRefactoring: start to capture failures in the inline tree
Andy Ayers [Fri, 19 Feb 2016 19:57:41 +0000 (11:57 -0800)]
InlineRefactoring: start to capture failures in the inline tree

This change starts capturing information about failed inlines in the
inline tree. Not all failures are captured yet; see below for notes.

Sample trees showing a failure:
```
Inlines into Secant:Inner(byref,byref,double,double,int,byref)
  [IL=0004 TR=000008] [FAILED: exceeds profit threshold] Secant:FF(double):double
  [IL=0023 TR=000036] [native size estimate ok] Secant:FF(double):double
```

InlineContext is revised to have 3 static constructors: one for the
root context, one for successful inlines, and one for failed inlines.
Successful inlines are always captured in the tree, since they are used
to track inline depth and recursion. Failures are only captured in
DEBUG and are just there for diagnostic purposes. The success and
failure constructors also link the new contexts into the tree at the
proper spot.

With this the jit can now capture failures for calls that were
initially identified as candidates. Top-level non-candidates are still
screened out in fgInline, and lower-level non-candidates simply aren't
seen at all by the current code. This will be addressed in a subsequent
change.

New calls can appear in the gap between caller and callee, as the code
for the two is stitched together. These are never candidates and never
given candidate screening. For now, if a new failing context is unable
to find a parent context from the IR, the code assumes the IR was
created in this gap. Down the road we may want to insist that all IR be
covered by some InlineContext (eg for improved debugging of optimized
code).

The InlineContext now also captures and prints the tree ID of the call
to make it easier to relate back to IR dumps.

Commit migrated from https://github.com/dotnet/coreclr/commit/ea53f9a34f4c658b207c214568e78c2635629711

8 years agoThis Change Adds initial Support for LongFiles in the VM,
Rama Krishnan Raghupathy [Fri, 19 Feb 2016 02:21:18 +0000 (18:21 -0800)]
This Change Adds initial Support for LongFiles in the VM,
They are:
1. Wrappers for OS APIs which  take or return PATHS

2. Fixing the usage of following Api's:

GetEnvironmentVariableW
SearchPathW
GetShortPathNameW
GetLongPathNameW
GetModuleFileName

Work remaining:
Remove fixed size buffers in the VM

Commit migrated from https://github.com/dotnet/coreclr/commit/f98fb85e72d0f24c58d9e54b8b3bff2c67f985fb

8 years agoFix for SIMD intrinsic Initialize expansion.
Eugene Rozenfeld [Fri, 19 Feb 2016 01:46:38 +0000 (17:46 -0800)]
Fix for SIMD intrinsic Initialize expansion.

Initialize expansion was missing register zero initialization
in some cases. This caused silent bad codegen in dotnet/coreclr#3208.

Closes dotnet/coreclr#3208.

Commit migrated from https://github.com/dotnet/coreclr/commit/c4603ee6a1e29bcf9e4aff2ea095ec529024692c

8 years agoAdd PID disambiguation to debugger named semaphores.
Aditya Mandaleeka [Sat, 20 Feb 2016 01:22:50 +0000 (17:22 -0800)]
Add PID disambiguation to debugger named semaphores.

Commit migrated from https://github.com/dotnet/coreclr/commit/798009b0af35ca95e65888ed706d1fe5f0c229cb

8 years agoMerge pull request dotnet/coreclr#3257 from kyulee1/cleanbuild
Kyungwoo Lee [Sat, 20 Feb 2016 01:31:51 +0000 (17:31 -0800)]
Merge pull request dotnet/coreclr#3257 from kyulee1/cleanbuild

Fix clean test build

Commit migrated from https://github.com/dotnet/coreclr/commit/a60523e59973b07f7240f3970a4fa41e14c9d6a6

8 years agoFixes to build CentOS CoreCLR Nuget Package
Gaurav Khanna (CLR) [Fri, 19 Feb 2016 10:20:17 +0000 (02:20 -0800)]
Fixes to build CentOS CoreCLR Nuget Package

Commit migrated from https://github.com/dotnet/coreclr/commit/eaa900f12fca6fdd44e579ef65f6297a3986d270

8 years agoMerge pull request dotnet/coreclr#3236 from mikedn/noinline-new
Jan Kotas [Sat, 20 Feb 2016 00:16:16 +0000 (16:16 -0800)]
Merge pull request dotnet/coreclr#3236 from mikedn/noinline-new

Do not define global inline new/delete operators

Commit migrated from https://github.com/dotnet/coreclr/commit/f0b5ca1bf84f2704426b6bda266b410a4eda508f

8 years agoAdd option to runtest.sh to generate code coverage reports for coreclr
William Godbe [Wed, 10 Feb 2016 22:41:03 +0000 (14:41 -0800)]
Add option to runtest.sh to generate code coverage reports for coreclr

Commit migrated from https://github.com/dotnet/coreclr/commit/c219cf99af9f0bc10de97e502574db8d34b2f45d

8 years agoMerge pull request dotnet/coreclr#3256 from ellismg/add-rhel72-badge
Matt Ellis [Fri, 19 Feb 2016 23:43:59 +0000 (15:43 -0800)]
Merge pull request dotnet/coreclr#3256 from ellismg/add-rhel72-badge

Add RHEL Badges

Commit migrated from https://github.com/dotnet/coreclr/commit/68b6ed99aef0f783535d4621d9ee052fb10b8131

8 years agoMerge pull request dotnet/coreclr#3264 from dotnet/revert-3253-add_pr_trigger_for_str...
Matt Mitchell [Fri, 19 Feb 2016 23:43:00 +0000 (15:43 -0800)]
Merge pull request dotnet/coreclr#3264 from dotnet/revert-3253-add_pr_trigger_for_stress_test_on_ubuntu

Revert "Fix PR trigger for ubuntu/osx corefx testing"

Commit migrated from https://github.com/dotnet/coreclr/commit/8de21af6a6e2d1fe2479676c002e927711014b89

8 years agoRevert "Fix PR trigger for ubuntu/osx corefx testing"
Matt Mitchell [Fri, 19 Feb 2016 23:42:21 +0000 (15:42 -0800)]
Revert "Fix PR trigger for ubuntu/osx corefx testing"

Commit migrated from https://github.com/dotnet/coreclr/commit/ce58c16d913aab08daf196dfd57ec56603ac59d2

8 years agoMerge pull request dotnet/coreclr#3254 from hoyMS/bug2388
Hongtao Yu [Fri, 19 Feb 2016 23:24:02 +0000 (15:24 -0800)]
Merge pull request dotnet/coreclr#3254 from hoyMS/bug2388

Bug 2388 Do not transform user-implemented math intrinsics that are tail calls.

Commit migrated from https://github.com/dotnet/coreclr/commit/1340098bdc6ac20566ccece2eb7de135866947f4

8 years agoFix clean test build
Kyungwoo Lee [Fri, 19 Feb 2016 19:06:41 +0000 (11:06 -0800)]
Fix clean test build

I often fall into a build failure like the following when passing /clean
E:\Github\coreclr\tests\runtest.proj : error MSB4057: The target "rebuild"
does not exist in the project.
runtest.proj is actually invoked in two places one from a part of
build.cmd targeting CreateTestOverlay only, and the other from
runtest.cmd, which creates wrapper and actually running the tests.
So, definining "rebuild" target that does "clean" and "build" doesn't
solve this problem.
The fix is to not target "rebuild" in the former case since we are
explicitly targeting "CreateTestOverlay" only. Instead of putting "/t:rebuild"
in the common msbuild argument, I added it to each instance except this case.

Commit migrated from https://github.com/dotnet/coreclr/commit/06f6edeffcae1905cc77a130c7bc916188eba1c7

8 years agoDo not transform user-implemented math intrinsics that are tail calls
Hongtao Yu [Fri, 19 Feb 2016 17:22:12 +0000 (09:22 -0800)]
Do not transform user-implemented math intrinsics that are tail calls

Intrinsics that are not implemented directly by target instructions will be rematerialized as users calls in rationalizer. For prefixed tail calls, don't do this optimization, because
       1. Languages like F# requires a mandatory tail call optimization. A tail call converted to an intrinsic and then converted back to a call will miss out the tail call optimization.
       2. Tail call optimization may be more beneficial.

Commit migrated from https://github.com/dotnet/coreclr/commit/17a406d81c866e2813705b4f8ea5be85da5fde59

8 years agoDisable tests failing on OSX
William Godbe [Fri, 19 Feb 2016 22:06:07 +0000 (14:06 -0800)]
Disable tests failing on OSX

Commit migrated from https://github.com/dotnet/coreclr/commit/6f0ae1d3bfb7208ffeb56bef06368732e2924d8b

8 years agoMerge pull request dotnet/coreclr#3253 from sejongoh/add_pr_trigger_for_stress_test_o...
Matt Mitchell [Fri, 19 Feb 2016 21:24:19 +0000 (13:24 -0800)]
Merge pull request dotnet/coreclr#3253 from sejongoh/add_pr_trigger_for_stress_test_on_ubuntu

Fix PR trigger for ubuntu/osx corefx testing

Commit migrated from https://github.com/dotnet/coreclr/commit/338ba2d874ceb570491367a921a31c3276a202ae

8 years agoMerge pull request dotnet/coreclr#3247 from AndyAyersMS/InlineRefactor4c
Andy Ayers [Fri, 19 Feb 2016 19:57:29 +0000 (11:57 -0800)]
Merge pull request dotnet/coreclr#3247 from AndyAyersMS/InlineRefactor4c

InlineRefactoring: rename inlExpLst to InlineContext

Commit migrated from https://github.com/dotnet/coreclr/commit/c0d7cb0cccfa6b088397638f94aa0de106fc5ac4

8 years agoMerge pull request dotnet/coreclr#3241 from wtgodbe/cscbench
Sergiy Kuryata [Fri, 19 Feb 2016 19:43:26 +0000 (11:43 -0800)]
Merge pull request dotnet/coreclr#3241 from wtgodbe/cscbench

Stop copying of bad System.Runtime version

Commit migrated from https://github.com/dotnet/coreclr/commit/021e5dc7a877f707a46b0b8a99b99a6445900c82

8 years agoMerge pull request dotnet/coreclr#3250 from janvorli/fix-explicit-frames-popping-2
Sergiy Kuryata [Fri, 19 Feb 2016 18:44:16 +0000 (10:44 -0800)]
Merge pull request dotnet/coreclr#3250 from janvorli/fix-explicit-frames-popping-2

Fix the explicit frames unwinding on Unix

Commit migrated from https://github.com/dotnet/coreclr/commit/06242b1c9811cee96108b8f29237b3be1a065e6b

8 years agoMerge pull request dotnet/coreclr#3242 from briansull/arm64conds
Brian Sullivan [Fri, 19 Feb 2016 18:12:52 +0000 (10:12 -0800)]
Merge pull request dotnet/coreclr#3242 from briansull/arm64conds

Refactor of conditional branches for the ARM architecture

Commit migrated from https://github.com/dotnet/coreclr/commit/2f0057cde6753040452fc439c6101c3fa7beb970

8 years agoMerge pull request dotnet/coreclr#3238 from tarekgh/DateTimeRefactor
Tarek Mahmoud Sayed [Fri, 19 Feb 2016 17:08:44 +0000 (09:08 -0800)]
Merge pull request dotnet/coreclr#3238 from tarekgh/DateTimeRefactor

Small refactoring in DateTime comparing methods

Commit migrated from https://github.com/dotnet/coreclr/commit/e78212837f61e5b5a55f5f83ead08cba7e5b56d2

8 years agoFix PR trigger for ubuntu/osx corefx testing
Sejong Oh [Fri, 19 Feb 2016 13:00:27 +0000 (05:00 -0800)]
Fix PR trigger for ubuntu/osx corefx testing

Commit migrated from https://github.com/dotnet/coreclr/commit/bfa01b4c8077737c628d0b47f993fb51225278ae

8 years agoFix the explicit frames unwinding on Unix
Jan Vorlicek [Thu, 18 Feb 2016 22:36:43 +0000 (23:36 +0100)]
Fix the explicit frames unwinding on Unix

This change fixes a problem when exception unwinds native frames of code that contains
explicit frames. There were two issues. First, the destructor of the explicit frame
base class Frame that was responsible for popping the frames was missing switch to
GC cooperative mode and so it could pop frames that GC was currently walking.
And second, after adding the switch to cooperative mode, it turned out that if a
thread gets blocked in the Frame destructor due to GC and the stack walker tries to
get stack cookie from FrameWithCookie wrapper of a class derived from the Frame,
it fails since the vtable pointer was already reset to the vtable of the base Frame
class and it detects that as an invalid case.

The fix was to add destructors to all final classes derived from Frame and perform
the frame popping from there.

Commit migrated from https://github.com/dotnet/coreclr/commit/0e14371a2638dd27222fd63af6032b5cd1a64add

8 years agoMerge pull request dotnet/coreclr#3243 from LLITCHEV/structDesc-clone
Lubomir Litchev [Fri, 19 Feb 2016 07:47:11 +0000 (23:47 -0800)]
Merge pull request dotnet/coreclr#3243 from LLITCHEV/structDesc-clone

Added code to clone the structDesc member of GT_CALL.

Commit migrated from https://github.com/dotnet/coreclr/commit/5a49e66de150413ad8277bdbc8c2dacf0d461eae

8 years agoMerge pull request dotnet/coreclr#3135 from CarolEidt/x86VirtualStubDirect
Carol Eidt [Fri, 19 Feb 2016 05:33:20 +0000 (21:33 -0800)]
Merge pull request dotnet/coreclr#3135 from CarolEidt/x86VirtualStubDirect

Enable Virtual Stub calls that are direct for x86

Commit migrated from https://github.com/dotnet/coreclr/commit/edb8791a974187c27284b72e72ba061dc3a1bbf0

8 years agoAdded code to clone the structDesc member of GT_CALL.
Lubomir Litchev [Fri, 19 Feb 2016 00:22:36 +0000 (16:22 -0800)]
Added code to clone the structDesc member of GT_CALL.

Adds code to clone the structDesc member of GT_CALL. It modifies the
importer to get the structDesc directly in this field, instead of using a
separate local and eliminates the obsolete SetRegisterReturningStructState
method of GenTreeCall.

Fixes 3239.

Commit migrated from https://github.com/dotnet/coreclr/commit/e46554c494f4ed2c4fda6d3df46eb31f6dc35cdf