commit-bot@chromium.org [Tue, 27 May 2014 15:16:37 +0000 (15:16 +0000)]
Drop support for non-atomic non-mutex platforms.
(Clients can still provide these themselves if they really want.)
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
295373005
git-svn-id: http://skia.googlecode.com/svn/trunk@14894
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:04:57 +0000 (15:04 +0000)]
Update expectations for etc1bitmap
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
300063007
git-svn-id: http://skia.googlecode.com/svn/trunk@14893
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 15:00:32 +0000 (15:00 +0000)]
Implement sk_atomic_conditional_inc with sk_atomic_cas.
Now that we have sk_atomic_cas, we can replace all the platform-specific CAS loops with one.
BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
300553003
git-svn-id: http://skia.googlecode.com/svn/trunk@14892
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:59:47 +0000 (14:59 +0000)]
Move SkDecodingImageGenerator.h to include/
This will allow Android to access it and remove SkImageRef.
Depends on https://codereview.chromium.org/
293283002/
BUG=skia:2389
R=reed@google.com, djsollen@google.com, halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
228613003
git-svn-id: http://skia.googlecode.com/svn/trunk@14891
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:35:25 +0000 (14:35 +0000)]
Add OpenGL Compressed Texture enum values
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
293263004
git-svn-id: http://skia.googlecode.com/svn/trunk@14890
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:14:22 +0000 (14:14 +0000)]
hide discardable factory from public imagegenerator api
BUG=skia:
R=halcanary@google.com, scroggo@google.com, djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
295243006
git-svn-id: http://skia.googlecode.com/svn/trunk@14889
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 14:03:51 +0000 (14:03 +0000)]
remove SK_SUPPORT_LEGACY_BITMAPFLATTEN code
BUG=skia:
R=scroggo@google.com, reed@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
303563002
git-svn-id: http://skia.googlecode.com/svn/trunk@14888
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 13:52:51 +0000 (13:52 +0000)]
Adding new filters to fuzzer
New image filters were added since the last time I worked on the fuzzer, so I added them to the fuzzer. Same changes will be made to the clusterfuzz fuzzer.
BUG=skia:
R=bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
300153002
git-svn-id: http://skia.googlecode.com/svn/trunk@14887
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 12:45:42 +0000 (12:45 +0000)]
sk_memcpy32 should fall back on libc memcpy.
Writing it out ourselves was a ~2x slowdown on ARM.
BUG=skia:
R=henrik.smiding@intel.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
292663013
git-svn-id: http://skia.googlecode.com/svn/trunk@14886
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 27 May 2014 00:23:36 +0000 (00:23 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
293393007
git-svn-id: http://skia.googlecode.com/svn/trunk@14885
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 24 May 2014 03:05:26 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14884
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:40:26 +0000 (20:40 +0000)]
Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/
292323003/)
Reason for revert:
Signeness comparison breaks build. After working some more, I think the API design will be cleaner without the Uncompressed enum, so I'm removing it and retesting everything.
Original issue's description:
> Add compressed texture capabilities for GPU devices
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14880
R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
296313003
git-svn-id: http://skia.googlecode.com/svn/trunk@14883
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:25:15 +0000 (20:25 +0000)]
move ashmem switching logic to SkDiscardableMemory::Create
R=scroggo@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
293283002
git-svn-id: http://skia.googlecode.com/svn/trunk@14882
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:00:59 +0000 (20:00 +0000)]
Change the PKM decoder to adhere to sampler size
This fixes a bug where the red and blue channels seemed to be swapped on some platforms after decoding, and brings it more in line with the logic already in libbmp.
BUG=skia:
R=halcanary@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
297853005
git-svn-id: http://skia.googlecode.com/svn/trunk@14881
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 20:00:54 +0000 (20:00 +0000)]
Add compressed texture capabilities for GPU devices
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
292323003
git-svn-id: http://skia.googlecode.com/svn/trunk@14880
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:22:13 +0000 (19:22 +0000)]
rather than committing new unreviewed expectations, just ignore the failures
This way, subsequent runs of the bots will try to re-upload the image file. (They don't try to upload images for passing tests.)
BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
297853007
git-svn-id: http://skia.googlecode.com/svn/trunk@14879
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:13:56 +0000 (19:13 +0000)]
Revert of Modify sample buffer size for larger displays. (https://codereview.chromium.org/
240433002/)
Reason for revert:
This also changes verylargebitmap, and the difference appears to be meaningful. Henrik, I have emailed you the images that differ.
Original issue's description:
> Modify sample buffer size for larger displays.
>
> Increases the intermediate buffer size for sample pixel indexes,
> used in the sample proc function calls. If the operation is bigger
> than the buffer it's split into multiple calls, creating overhead.
> This would especially impact the performance of SIMD optimizations.
> Also, aligns the start address of the buffer to 16 bytes, to enable
> more efficient SIMD optimizations.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14825
>
> Committed: http://code.google.com/p/skia/source/detail?r=14872
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, bsalomon@chromium.org, bsalomon@google.com, henrik.smiding@intel.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
294023016
git-svn-id: http://skia.googlecode.com/svn/trunk@14878
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:09:46 +0000 (19:09 +0000)]
Revert of Suppress more GMs pending rebaseline after
0533146d005 (https://codereview.chromium.org/
296173009/)
Reason for revert:
The CL for which these were added needs to be reverted. The best example of its breakage is in verylargebitmap.
Original issue's description:
> Suppress more GMs pending rebaseline after
0533146d005
>
> TBR=scroggo@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=14874
R=fmalita@chromium.org
TBR=fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
298973008
git-svn-id: http://skia.googlecode.com/svn/trunk@14877
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 19:08:17 +0000 (19:08 +0000)]
instead of ignoring testimagefilters EVERYWHERE, just ignore particular failures
BUG=skia:2603
NOTREECHECKS=True
NOTRY=True
R=fmalita@google.com
TBR=fmalita
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
296213009
git-svn-id: http://skia.googlecode.com/svn/trunk@14876
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 23 May 2014 18:44:21 +0000 (18:44 +0000)]
Suppress testimagefilters GM.
Failing on Android, but results missing.
BUG=skia:2603
TBR=epoger@google.com
Review URL: https://codereview.chromium.org/
299143006
git-svn-id: http://skia.googlecode.com/svn/trunk@14875
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Fri, 23 May 2014 18:34:18 +0000 (18:34 +0000)]
Suppress more GMs pending rebaseline after
0533146d005
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
296173009
git-svn-id: http://skia.googlecode.com/svn/trunk@14874
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:26:57 +0000 (16:26 +0000)]
manual bench rebase after f757fd3
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
293093007
git-svn-id: http://skia.googlecode.com/svn/trunk@14873
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:05:43 +0000 (16:05 +0000)]
Modify sample buffer size for larger displays.
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14825
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
240433002
git-svn-id: http://skia.googlecode.com/svn/trunk@14872
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:01:31 +0000 (16:01 +0000)]
(bad) rebaselines for shader change
TBR=halcanary
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
296983013
git-svn-id: http://skia.googlecode.com/svn/trunk@14871
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 16:01:09 +0000 (16:01 +0000)]
Adds more bots for bench alerts.
Bypassing trybots:
NOTRY=true
R=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
291343008
git-svn-id: http://skia.googlecode.com/svn/trunk@14870
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 15:31:02 +0000 (15:31 +0000)]
fix bench rebase tool to cope with wider range of bots.
BUG=skia:2373
R=kelvinly@google.com
TBR=kelvinly@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
292623005
git-svn-id: http://skia.googlecode.com/svn/trunk@14869
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 13:55:44 +0000 (13:55 +0000)]
rebaseline after unitmapper shader change
TBR=epoger
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
294973012
git-svn-id: http://skia.googlecode.com/svn/trunk@14868
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 13:21:55 +0000 (13:21 +0000)]
stop calling SkBitmap::flatten
BUG=skia:
R=scroggo@google.com, halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
295793002
git-svn-id: http://skia.googlecode.com/svn/trunk@14867
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 13:05:33 +0000 (13:05 +0000)]
Adds angle to bench expectation configs.
BUG=skia:2576
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
293033013
git-svn-id: http://skia.googlecode.com/svn/trunk@14866
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 12:32:23 +0000 (12:32 +0000)]
fix stroking large drawPosText
BUG=skia:
R=bungeman@google.com, yunchao.he@intel.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
288983004
git-svn-id: http://skia.googlecode.com/svn/trunk@14865
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 11:51:16 +0000 (11:51 +0000)]
manual bench rebase after 7693dbf
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
297943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14864
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 08:09:26 +0000 (08:09 +0000)]
fix the visual diff of raster vs gpu -- vertices_80. The sw-raster is correct, all images are blurry.
While some images generated by gpu doesn't respect SkPaint's alpha value.
In gpu path, when pass SkPaint's alpha and color to GrPaint by SkPaint2GrPaintNoShader,
either alpha or colors can't not be passed. We can't pass both of them by the API.
Premultiply paint's alpha to colors's alpha in drawVertices, and pass colors to GrPaint.
The rendering result will respect colors in drawVertices, and the alpha value set in SkPaint as well.
BUG=skia:2592
R=bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
292943002
git-svn-id: http://skia.googlecode.com/svn/trunk@14863
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 23 May 2014 03:03:34 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14862
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 23 May 2014 01:02:21 +0000 (01:02 +0000)]
Revert of Turn on preprocessing by default (https://codereview.chromium.org/
299033002/)
Reason for revert:
Don't want this enabled by default right now
Original issue's description:
> Turn on preprocessing by default
>
> The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs.
>
> Committed: http://code.google.com/p/skia/source/detail?r=14860
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
299123002
git-svn-id: http://skia.googlecode.com/svn/trunk@14861
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 23:27:27 +0000 (23:27 +0000)]
Turn on preprocessing by default
The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
299033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14860
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 22:35:24 +0000 (22:35 +0000)]
temporarily add back in the factores that took a unitmapper
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
292513006
git-svn-id: http://skia.googlecode.com/svn/trunk@14859
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 22 May 2014 21:29:20 +0000 (21:29 +0000)]
Add pkm missing from r14852 (Simple PKM image decoder - https://codereview.chromium.org/
292663011/) commit
git-svn-id: http://skia.googlecode.com/svn/trunk@14858
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 20:09:05 +0000 (20:09 +0000)]
remove bit rotted gyp from most
BUG=skia:2597
R=epoger@google.com
TBR=epoger
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
297823004
git-svn-id: http://skia.googlecode.com/svn/trunk@14857
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 19:58:22 +0000 (19:58 +0000)]
remove bit rot test gyp
BUG=skia:2597
R=epoger@google.com
TBR=epoger
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
296053016
git-svn-id: http://skia.googlecode.com/svn/trunk@14856
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 19:30:54 +0000 (19:30 +0000)]
If our gyp does not exist, use chromium's.
The previous version had faith that if the third_party folder
existed, it must contain externals/gyp. A recent change added
third_party (in git, as opposed to using DEPS), so now Android
has third_party but not externals/gyp.
Now check the full filepath. If it's not there, back up to
chromium's version.
Fixes Android canary bot.
R=halcanary@google.com
TBR=halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
295103008
git-svn-id: http://skia.googlecode.com/svn/trunk@14855
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 22 May 2014 18:53:10 +0000 (18:53 +0000)]
turn assert into not_implemented_yet for patheffects on text
git-svn-id: http://skia.googlecode.com/svn/trunk@14854
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 18:43:05 +0000 (18:43 +0000)]
re-expose hasLocalMatrix for now (can't hurt) -- unblocks blink
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
299043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14853
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 22 May 2014 18:40:29 +0000 (18:40 +0000)]
Simple PKM image decoder.
https://codereview.chromium.org/
292663011/
git-svn-id: http://skia.googlecode.com/svn/trunk@14852
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 18:24:42 +0000 (18:24 +0000)]
Fix memcpy32_sse2_unalign.
The whole point of mempcy32_sse2_unalign is that we didn't align dst128
and src128. So it's not safe at all to cast them back to dst and src.
That tells the compiler that dst/src are 128-bit aligned, and then it
autovectorizes the cleanup while-loop using that (false) knowledge with
aligned SSE instructions.
This leads to crashes on memcpy32_sse2_unalign_10, which is small enough
that we actually get non-16-byte aligned memory. The larger size
benches could be crashing too, but they're big enough allocations that
they're probably always 16-byte aligned anyway.
BUG=skia:2589
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
291893008
git-svn-id: http://skia.googlecode.com/svn/trunk@14851
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 22 May 2014 17:59:51 +0000 (17:59 +0000)]
tweak stroketext GM to actually test dashing
git-svn-id: http://skia.googlecode.com/svn/trunk@14850
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 22 May 2014 17:59:21 +0000 (17:59 +0000)]
Remove SK_IGNORE_UNDERLINE_POSITION_FIX now that it is no longer used.
R=reed@google.com
Review URL: https://codereview.chromium.org/
294663016
git-svn-id: http://skia.googlecode.com/svn/trunk@14849
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 17:41:41 +0000 (17:41 +0000)]
update stroketext gm
TBR=bungeman
Author: reed@google.com
Review URL: https://codereview.chromium.org/
293983016
git-svn-id: http://skia.googlecode.com/svn/trunk@14848
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 22 May 2014 17:06:31 +0000 (17:06 +0000)]
Rebaseline two GMs that subtly changed in perspective after convexity fix.
BUG=skia:
Review URL: https://codereview.chromium.org/
292983015
git-svn-id: http://skia.googlecode.com/svn/trunk@14847
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 22 May 2014 15:54:05 +0000 (15:54 +0000)]
Don't try to remove xcodebuild directory on Windows.
make.py is a python script to be run *only* on Windows and thus
xcodebuild directory should not exist there. If we never create it on Windows,
then why should we try to remove something we don't create there?
R=epoger@google.com
Review URL: https://codereview.chromium.org/
299443005
git-svn-id: http://skia.googlecode.com/svn/trunk@14846
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 14:58:53 +0000 (14:58 +0000)]
In convexity checker don't advance last vector when x-product isn't significant.
BUG=skia:2235
R=caryclark@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
298973004
git-svn-id: http://skia.googlecode.com/svn/trunk@14845
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 13:42:34 +0000 (13:42 +0000)]
Revert "Temporarily disable NEON on Android framework builds."
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
294183002
git-svn-id: http://skia.googlecode.com/svn/trunk@14844
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 13:18:32 +0000 (13:18 +0000)]
Disable bench that's crashing on ChromeOS/Alex perf bot.
BUG=skia:2589
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
292203009
git-svn-id: http://skia.googlecode.com/svn/trunk@14843
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 12:27:41 +0000 (12:27 +0000)]
Remove unused (by clients) SkUnitMapper
This reverts commit
874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.
TBR=scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/
288313009
git-svn-id: http://skia.googlecode.com/svn/trunk@14842
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 12:00:55 +0000 (12:00 +0000)]
bench rebase tools: format commit message and title.
BUG=skia:
R=kelvinly@google.com
TBR=kelvinly@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
296943004
git-svn-id: http://skia.googlecode.com/svn/trunk@14841
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 06:29:38 +0000 (06:29 +0000)]
manual bench rebase after ecd856c
R=robertphillips@google.com
TBR=robertphillips@google.com
Bypassing trybots:
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
291243008
git-svn-id: http://skia.googlecode.com/svn/trunk@14840
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 03:20:47 +0000 (03:20 +0000)]
Revert of Fix compilation error when building with clang on Linux. (https://codereview.chromium.org/
287193006/)
Reason for revert:
need to revert this along with reverting the big unitmapper cl
Original issue's description:
> Fix compilation error when building with clang on Linux.
>
> ../../src/effects/gradients/SkGradientShader.cpp:487:22: error: unused
> function 'bitsTo16' [-Werror,-Wunused-function]
> static inline U16CPU bitsTo16(unsigned x, const unsigned bits) {
>
> R=bsalomon@google.com
> TEST=make tests
>
> Committed: http://code.google.com/p/skia/source/detail?r=14835
R=bsalomon@google.com, reed@google.com, tfarina@chromium.org
TBR=bsalomon@google.com, reed@google.com, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
297803010
git-svn-id: http://skia.googlecode.com/svn/trunk@14839
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 02:55:59 +0000 (02:55 +0000)]
Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/
283273002/) (https://codereview.chromium.org/
288343009/)
Reason for revert:
required blink change failed to land
Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/
283273002/)
>
> This reverts commit
dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830
R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
296823008
git-svn-id: http://skia.googlecode.com/svn/trunk@14838
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 22 May 2014 00:36:05 +0000 (00:36 +0000)]
Call write() within render_pictures but not bench_pictures
BUG=skia:2584
R=bsalomon@google.com, robertphillips@google.com, bensong@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
291843010
git-svn-id: http://skia.googlecode.com/svn/trunk@14837
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 22:57:44 +0000 (22:57 +0000)]
fix some bench rebase tool problems.
BUG=skia:2373
NOTRY=true
TBR=kelvinly@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
298683004
git-svn-id: http://skia.googlecode.com/svn/trunk@14836
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 22:31:00 +0000 (22:31 +0000)]
Fix compilation error when building with clang on Linux.
../../src/effects/gradients/SkGradientShader.cpp:487:22: error: unused
function 'bitsTo16' [-Werror,-Wunused-function]
static inline U16CPU bitsTo16(unsigned x, const unsigned bits) {
R=bsalomon@google.com, reed@google.com
TEST=make tests
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
287193006
git-svn-id: http://skia.googlecode.com/svn/trunk@14835
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 21:51:48 +0000 (21:51 +0000)]
Fix ANGLE config (take 2)
Bot was failing with:
"sequence item 7: expected string, int found"
R=borenet@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
292313002
git-svn-id: http://skia.googlecode.com/svn/trunk@14834
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 21:12:11 +0000 (21:12 +0000)]
Adds bench rebase tools to experimental for version control and self update.
BUG=skia:
NOTRY=true
R=kelvinly@google.com
TBR=kelvinly@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
296453016
git-svn-id: http://skia.googlecode.com/svn/trunk@14833
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 20:42:57 +0000 (20:42 +0000)]
Remove SkDebugf that is gumming up the bot logs
This SkDebugf is making the bot logs a bit harder to read:
http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release-ANGLE/builds/1959/steps/BenchPictures/logs/stdio
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
296153003
git-svn-id: http://skia.googlecode.com/svn/trunk@14832
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 20:18:49 +0000 (20:18 +0000)]
Fix problems with angle bot's configurations
BUG=skia:2577
R=borenet@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
296693009
git-svn-id: http://skia.googlecode.com/svn/trunk@14831
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 19:56:46 +0000 (19:56 +0000)]
Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/
283273002/)
This reverts commit
dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
288343009
git-svn-id: http://skia.googlecode.com/svn/trunk@14830
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 21 May 2014 19:44:39 +0000 (19:44 +0000)]
Fix undefined behavior in DirectWrite GDI compatible metrics.
GetGdiCompatibleGlyphMetrics checks the matrix passed to it.
If the matrix has any NaNs or INFs or otherwise looks bad, it returns
E_INVALIDARG and so the advances will be zero.
BUG=skia:2579
R=reed@google.com
Review URL: https://codereview.chromium.org/
298863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14829
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 19:44:24 +0000 (19:44 +0000)]
Remove 1/2 pixel offsets for distance field layout.
The 1/2 pixel offsets are for rounding when snapping the glyphs to integer boundaries. Since we're using subpixel layout and sampled textures, we shouldn't snap to integer boundaries.
BUG=skia:2173
R=bungeman@google.com, reed@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
298753005
git-svn-id: http://skia.googlecode.com/svn/trunk@14828
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 21 May 2014 16:38:43 +0000 (16:38 +0000)]
Revert "Modify sample buffer size for larger displays."
This reverts commit
dd72f3bd0d500b9b3f900bcb8e904161ee51eae5.
git-svn-id: http://skia.googlecode.com/svn/trunk@14827
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 15:58:00 +0000 (15:58 +0000)]
Revert of Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi… (https://codereview.chromium.org/
291163005/)
Reason for revert:
broke 6 webgl/canvas tests in blink (don't know why yet)
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_7/27348/layout-test-results/results.html
Original issue's description:
> Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/
246513002/)"""
>
> This reverts commit
3dbceb4f8283b2fb1728d0daf010d036099a2eae.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14806
R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
295093003
git-svn-id: http://skia.googlecode.com/svn/trunk@14826
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 15:16:15 +0000 (15:16 +0000)]
Modify sample buffer size for larger displays.
Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
240433002
git-svn-id: http://skia.googlecode.com/svn/trunk@14825
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 15:10:20 +0000 (15:10 +0000)]
bench rebase after 661832c
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
292113006
git-svn-id: http://skia.googlecode.com/svn/trunk@14824
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 21 May 2014 13:52:13 +0000 (13:52 +0000)]
Add EXT suffix to EXT_map_buffer_range references
This rearranges the code to use the non-suffixed entry point for ES
3.x contexts, and the suffixed entry point on ES 2.0 contexts that
have the extension.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
293993010
git-svn-id: http://skia.googlecode.com/svn/trunk@14823
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 12:43:07 +0000 (12:43 +0000)]
SSE2 implementation of memcpy32
With SSE2 version memcpy32, S32_Opaque_BlitRow32() in SkBlitRow_D32.cpp
has about 30% performance improvement. Here are the data on desktop
i7-3770.
before:
bitmap_scale_filter_90_90 8888: cmsecs = 2.01
bitmaprect_FF_filter_trans 8888: cmsecs = 3.61
bitmaprect_FF_nofilter_trans 8888: cmsecs = 3.57
bitmaprect_FF_filter_identity 8888: cmsecs = 3.53
bitmaprect_FF_nofilter_identity 8888: cmsecs = 3.53
bitmap_4444_update 8888: cmsecs = 4.84
bitmap_4444_update_volatile 8888: cmsecs = 4.81
bitmap_4444 8888: cmsecs = 4.81
after:
bitmap_scale_filter_90_90 8888: cmsecs = 1.83
bitmaprect_FF_filter_trans 8888: cmsecs = 2.36
bitmaprect_FF_nofilter_trans 8888: cmsecs = 2.36
bitmaprect_FF_filter_identity 8888: cmsecs = 2.60
bitmaprect_FF_nofilter_identity 8888: cmsecs = 2.63
bitmap_4444_update 8888: cmsecs = 3.30
bitmap_4444_update_volatile 8888: cmsecs = 3.30
bitmap_4444 8888: cmsecs = 3.29
BUG=skia:
R=mtklein@google.com, reed@google.com, bsalomon@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/
285313002
git-svn-id: http://skia.googlecode.com/svn/trunk@14822
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 21 May 2014 12:24:58 +0000 (12:24 +0000)]
Fix windows compiler failures by using SkIsFinite.
BUG=skia:2574
Review URL: https://codereview.chromium.org/
296103003
git-svn-id: http://skia.googlecode.com/svn/trunk@14821
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 12:07:22 +0000 (12:07 +0000)]
bench rebase after 29de433
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
294973004
git-svn-id: http://skia.googlecode.com/svn/trunk@14820
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 11:57:16 +0000 (11:57 +0000)]
speed up benches: postpone hash computation in PictureRenderer.cpp
fixes phantom performance regression after https://codereview.chromium.org/
273783004
R=borenet@google.com, bensong@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
299763002
git-svn-id: http://skia.googlecode.com/svn/trunk@14819
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 21 May 2014 11:57:12 +0000 (11:57 +0000)]
Fix skpdiff segfault caused by NaN computation.
BUG=skia:2574
R=mtklein@google.com, rmistry@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
296033004
git-svn-id: http://skia.googlecode.com/svn/trunk@14818
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 21 May 2014 03:05:49 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14817
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 23:07:26 +0000 (23:07 +0000)]
Undo troublesome SSE 4.1 change for now to unblock Skia -> Chrome roll.
BUG=chromium:374796
NOTREECHECKS=true
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
292563005
git-svn-id: http://skia.googlecode.com/svn/trunk@14816
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 22:31:46 +0000 (22:31 +0000)]
Rebaseline Alex/Debug for FP math with SSE.
BUG=skia:
NOTREECHECKS=true
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
297703003
git-svn-id: http://skia.googlecode.com/svn/trunk@14815
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 20:48:23 +0000 (20:48 +0000)]
Rebaseline Alex/Release for FP math with SSE.
BUG=skia:
NOTREECHECKS=true
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
298793002
git-svn-id: http://skia.googlecode.com/svn/trunk@14814
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 20:29:04 +0000 (20:29 +0000)]
Rebase 32-bit Linux GMs now that they use SSE for FP math.
BUG=skia:
NOTREECHECKS=true
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
297683006
git-svn-id: http://skia.googlecode.com/svn/trunk@14813
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 19:42:03 +0000 (19:42 +0000)]
Remove -mfpmath=sse for clang, which does it automatically and sometimes is annoyed by it.
BUG=skia:
NOTREECHECKS=true
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
296793003
git-svn-id: http://skia.googlecode.com/svn/trunk@14812
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 19:02:55 +0000 (19:02 +0000)]
SSE2 everywhere.
As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
requires SSSE3 on Macs). Android already requires SSE2 for x86 chips.
This effectively just forces it on for 32-bit Linux builds; everyone else already had it.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14800
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
294963002
git-svn-id: http://skia.googlecode.com/svn/trunk@14811
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 20 May 2014 18:57:34 +0000 (18:57 +0000)]
rebaseline pictureshader GM on GPU
Review URL: https://codereview.chromium.org/
294103003
git-svn-id: http://skia.googlecode.com/svn/trunk@14810
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 17:51:13 +0000 (17:51 +0000)]
Centralize decision about whether to do bicubic filtering, and fallbacks to mip, bilerp, or nearest
R=robertphillips@google.com, humper@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
282293004
git-svn-id: http://skia.googlecode.com/svn/trunk@14809
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 17:35:10 +0000 (17:35 +0000)]
Changed JSON formatting more, workaround bug where SkStringPrintf causes encoding issues
BUG=skia:
R=bensong@google.com, jcgregorio@google.com, reed@google.com, bsalomon@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
294093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14808
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 17:31:08 +0000 (17:31 +0000)]
formalize named picture versions
BUG=skia:
R=mtklein@google.com, robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
291913004
git-svn-id: http://skia.googlecode.com/svn/trunk@14807
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 17:08:12 +0000 (17:08 +0000)]
Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/
246513002/)"""
This reverts commit
3dbceb4f8283b2fb1728d0daf010d036099a2eae.
BUG=skia:
R=bsalomon@google.com, robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
291163005
git-svn-id: http://skia.googlecode.com/svn/trunk@14806
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 17:05:45 +0000 (17:05 +0000)]
Rebaseline poppler (for me) and pictureshader/bleed on GPU (for Brian).
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
284313009
git-svn-id: http://skia.googlecode.com/svn/trunk@14805
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 17:02:03 +0000 (17:02 +0000)]
Add function to get both min and max scale factors from matrix
R=reed@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
298473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14804
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 15:27:35 +0000 (15:27 +0000)]
Revert of SSE2 everywhere. (https://codereview.chromium.org/
294963002/)
Reason for revert:
Making GM run fewer tests than expected?
Original issue's description:
> SSE2 everywhere.
>
> As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
> requires SSSE3 on Macs). Android already requires SSE2 for x86 chips.
>
> This effectively just forces it on for 32-bit Linux builds; everyone else already had it.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14800
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
282093015
git-svn-id: http://skia.googlecode.com/svn/trunk@14803
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 15:07:53 +0000 (15:07 +0000)]
Since we're only using it on Linux now, just require poppler as a system dependency.
The Ubuntu package needed is libpoppler-cpp-dev.
iconv and fontconfig were only used as Poppler dependencies. bson_c is also unused.
BUG=skia:
R=reed@google.com, rmistry@google.com, borenet@google.com, halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
294683003
git-svn-id: http://skia.googlecode.com/svn/trunk@14802
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 15:06:29 +0000 (15:06 +0000)]
Preserve GrContext's matrix when calling SkShader::asNewEffect.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
298713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14801
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 14:54:09 +0000 (14:54 +0000)]
SSE2 everywhere.
As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
requires SSSE3 on Macs). Android already requires SSE2 for x86 chips.
This effectively just forces it on for 32-bit Linux builds; everyone else already had it.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
294963002
git-svn-id: http://skia.googlecode.com/svn/trunk@14800
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 14:54:04 +0000 (14:54 +0000)]
Add Memcpy32 bench.
This compares 32-bit copies using memcpy, autovectorization, and when SSE2 is
available, aligned and unaligned SSE2.
Running this on my desktop (Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz), I see
all four perform essentially the same, except Clang's autovectorization looks
a little better than GCC's. memcpy is calling libc 2.19's __memcpy_sse2_unaligned.
BUG=skia:
R=reed@google.com, qiankun.miao@intel.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
290533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14799
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 14:53:45 +0000 (14:53 +0000)]
Rename SkMatrix::get(Max|Min)Stretch to get(Min|Max)Scale
R=reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
295713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14798
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 14:53:32 +0000 (14:53 +0000)]
Remove legacy constructor for blur draw looper.
Now that Android no longer uses the constructor, remove it, along
with the flag.
R=djsollen@google.com, reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
299683002
git-svn-id: http://skia.googlecode.com/svn/trunk@14797
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 20 May 2014 13:43:34 +0000 (13:43 +0000)]
Rebaselines for gpu dashing
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
291893004
git-svn-id: http://skia.googlecode.com/svn/trunk@14796
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 May 2014 12:39:37 +0000 (12:39 +0000)]
"Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/
246513002/)""
This reverts commit
65b9f33cab9f53821720f982667412e56a340093.
git-svn-id: http://skia.googlecode.com/svn/trunk@14795
2bbb7eff-a529-9590-31e7-
b0007b416f81