ChunEon Park [Tue, 19 Nov 2013 23:53:20 +0000 (08:53 +0900)]
elementary/transit - fix the T511 "_transit_auto_reverse_get() Elm_Transit transit has already been deleted"
Tom Hacohen [Tue, 19 Nov 2013 17:13:31 +0000 (17:13 +0000)]
Hoversel: Fix access to already deleted object.
Thank you eo pointer indirection for detecting this.
The issue is a mix of design choices (will discuss on the ML) and
a bug in hoversel which was probably caused because of the confusing design
choices.
The problem is that while widget_item->view is set by whoever created
the item, it's automatically deleted by elm_widget_item_del. This means
that objects that decided to delete their views, but were too sloppy to
update the widget_item->view pointer to NULL, would trigger an attempt
to deleted an already deleted object. This does not happen in 1.7
because widget_item->view was introduced in 1.8.
The automatic view deletion is problematic, as smart subobjects are
already deleted when the parent subobject (the widget) is deleted. So
clearing the views is redundant. However if the widget item is manually
deleted, the view should be deleted. This causes this mixture of cases
that are problematic at best.
Indication error:
Error:
ERR<5394>:eo lib/eo/eo_ptr_indirection.x:275 eo_obj_pointer_get()
obj_id 0x8000002900000149 is not pointing to a valid object. Maybe
it has already been freed.
This fixes T500.
Tom Hacohen [Tue, 19 Nov 2013 13:25:11 +0000 (13:25 +0000)]
Tests: Added elm_suite.h to EXTRA_DIST.
Fixes make dist.
Ryuan Choi [Tue, 19 Nov 2013 13:18:02 +0000 (13:18 +0000)]
Introduce check for unit testing framework of Elementary
Reviewers: seoz, tasn
CC: tasn, cedric
Differential Revision: https://phab.enlightenment.org/D91
Carsten Haitzler (Rasterman) [Tue, 19 Nov 2013 08:21:59 +0000 (17:21 +0900)]
1.8.0-alpha2
Carsten Haitzler (Rasterman) [Tue, 19 Nov 2013 06:10:03 +0000 (15:10 +0900)]
genlist - fix queue processor to not account for entire loop run in time
Carsten Haitzler (Rasterman) [Mon, 18 Nov 2013 23:21:46 +0000 (08:21 +0900)]
theme-randr - extend pwr event area for those who dont click where indicated
Stefan Schmidt [Mon, 18 Nov 2013 15:35:32 +0000 (16:35 +0100)]
mailmap: Sync file with changes from efl
Ryuan Choi [Mon, 18 Nov 2013 15:10:58 +0000 (00:10 +0900)]
elm_web: Fixed warnings when opened popup for <select>
elm_notify and elm_list should be made using Eo based class as a parent.
Daniel Juyung Seo [Mon, 18 Nov 2013 13:33:37 +0000 (22:33 +0900)]
elc_hoversel.c: use int_ret instead of ret because ret can be null.
This fixes coverity CID 1129609 and 1129610.
Daniel Juyung Seo [Mon, 18 Nov 2013 12:28:47 +0000 (21:28 +0900)]
tooltip.edc: fixed a comment typo.
ChunEon Park [Mon, 18 Nov 2013 04:15:56 +0000 (13:15 +0900)]
elementary - added a warning for elm_widget_item_track().
Daniel Juyung Seo [Mon, 18 Nov 2013 00:57:41 +0000 (09:57 +0900)]
test_main_menu.c: refactored button callback function.
- removed unnecessary casting.
- used a proper type, Eina_Bool, for the return value of elm_object_item_disabled_get()
- printed out more useful information.
Daniel Juyung Seo [Mon, 18 Nov 2013 00:57:16 +0000 (09:57 +0900)]
test_genlist.c: removed unnecessary spaces from legacy codes.
Daniel Juyung Seo [Mon, 18 Nov 2013 00:54:21 +0000 (09:54 +0900)]
test_genlist.c: added callbacks for unrealized and delete to test the callback sequence.
Yakov Goldberg [Sun, 17 Nov 2013 07:49:12 +0000 (09:49 +0200)]
thumb: typo in Eo OP_ID name
Yakov Goldberg [Sun, 17 Nov 2013 07:48:54 +0000 (09:48 +0200)]
widget: typo in Eo OP_ID name
Daniel Juyung Seo [Sun, 17 Nov 2013 08:18:15 +0000 (17:18 +0900)]
elm_authors.h: escape ryuan from email crawler.
Carsten Haitzler (Rasterman) [Sun, 17 Nov 2013 02:46:52 +0000 (11:46 +0900)]
check + radio - fix sizing evals and emits on content set
this should fix T261
Carsten Haitzler (Rasterman) [Sun, 17 Nov 2013 01:04:26 +0000 (10:04 +0900)]
test - unify glsl formatting to match glview gears example
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 09:13:37 +0000 (18:13 +0900)]
list - fix separators to be the correct direction
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 08:50:11 +0000 (17:50 +0900)]
list - fix item disable and infinite loop on next select
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 04:21:36 +0000 (13:21 +0900)]
entry - fix autosave timer del on shutdown
this fixes T509
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 03:50:25 +0000 (12:50 +0900)]
po - update
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 03:50:07 +0000 (12:50 +0900)]
theme - remove unused images
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 03:49:26 +0000 (12:49 +0900)]
elm-test - oops - fix colorsel premul
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 03:42:55 +0000 (12:42 +0900)]
theme - add more usability hints for ranr dialog like power button
Michael Bouchaud [Sat, 16 Nov 2013 01:48:29 +0000 (02:48 +0100)]
elementary: fix image counts in slideshow exemple
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2013 01:21:03 +0000 (10:21 +0900)]
fix color premul complaints in examples
this should fix T498
Andrii Kroitor [Sat, 16 Nov 2013 00:50:32 +0000 (09:50 +0900)]
Elm_menu: fixed item disable hook for elm_dbus_menu
Summary:
Menu items in dbus-mode (in Ubunut/Unity) were not updated on
disabled/enabled state changes. They were applied only after
adding/removing an item.
Reviewers: cedric, seoz, raster
Reviewed By: raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D333
Daniel Juyung Seo [Fri, 15 Nov 2013 13:51:10 +0000 (22:51 +0900)]
scroller, slider: fixed wrong changed I made by
6a683df1598a4c3293a33765cc60dd
I caused by c&p bug.
Special thanks to stefan and coverity.
This fixes coverity CID 1128353 and 1128354.
Daniel Juyung Seo [Fri, 15 Nov 2013 13:32:56 +0000 (22:32 +0900)]
elm_index.c: changed internal smart data variable name more descriptive.
- event -> event_rect
- and added a comment for that variable.
Daniel Juyung Seo [Fri, 15 Nov 2013 12:53:39 +0000 (21:53 +0900)]
elm_main.c: use a direct variable check instead of unnecessary additional function call like other lines of code.
Daniel Juyung Seo [Fri, 15 Nov 2013 12:52:19 +0000 (21:52 +0900)]
elm_win.c: removed build warning when there is no wayland support.
Daniel Juyung Seo [Fri, 15 Nov 2013 12:48:46 +0000 (21:48 +0900)]
elm_index.c: internal refactoring as a code cleanup.
- removed unnecessary duplicated parameter passing.
- moved smart callback add to a proper place not to be confused with other object's smart callback addition.
- removed unnecessary sub object add. it's done automatically in elm_layout_content_set.
Daniel Juyung Seo [Fri, 15 Nov 2013 12:18:04 +0000 (21:18 +0900)]
test_index.c: added index clear example and use activated callback for entry.
Daniel Juyung Seo [Fri, 15 Nov 2013 09:35:07 +0000 (18:35 +0900)]
test_index.c: internal refactoring of test code.
1. Set internal function as static.
2. Put prefix '_' for internal functions.
3. Moved window resize/show code.
Chris Michael [Fri, 15 Nov 2013 10:14:08 +0000 (10:14 +0000)]
Make routines to get the wayland window from an ecore_evas be more
inline with their X counterparts. Also, remove some EINA_UNUSED where
parameters were being used.
The previous code to get the Ecore_Wl_Window from an Ecore_Evas did
not check to make sure the Ecore_Evas Engine was a wayland engine, and
thus elm_tests like Window Inline would spew CRIT & ERR messages from
ecore_evas about the interface.
This fixes Phab Ticket T502
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 15 Nov 2013 08:47:54 +0000 (08:47 +0000)]
Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
ChunEon Park [Thu, 14 Nov 2013 13:51:03 +0000 (22:51 +0900)]
elementary/entry - internal change of the magnifier.
use the fill_set instead of the clipper.
soon after 1.8, proxy just created the filled area buffer, then magnifier surface size will be fixed regardless of the entry source.
Chris Michael [Thu, 14 Nov 2013 09:30:14 +0000 (09:30 +0000)]
Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 14 Nov 2013 09:26:04 +0000 (09:26 +0000)]
Stop fetching the same Evas and Clip object 4 times
We can just fetch this information once as it is not going to change
during the for loop.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Sebastian Dransfeld [Thu, 14 Nov 2013 04:15:43 +0000 (05:15 +0100)]
quicklaunch: Add AC_LANG_SOURCE to source code
Fixes warning:
configure.ac:217: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
m4/elm_quicklaunch.m4:9: ELM_QUICKLAUNCH is expanded from...
configure.ac:217: the top level
Jean-Philippe Andre [Tue, 5 Nov 2013 09:17:58 +0000 (18:17 +0900)]
Quicklaunch: don't increment init count twice
Ooops, don't increment elm_init count from quicklaunch init
when running normally.
Ryuan Choi [Wed, 13 Nov 2013 18:47:31 +0000 (03:47 +0900)]
elm_web : Moved elm_widget_sub_object_parent_add() call from ewk_view's smart_add to elm_web's
Because ewk_view is smart class and it's parent is Evas, it prints below warning.
... Can't execute function Elm_Widget:ELM_WIDGET_SUB_ID_SUB_OBJECT_ADD (op 0x9f)
for class 'Evas'. Aborting.
Amitesh Singh [Wed, 13 Nov 2013 11:32:31 +0000 (20:32 +0900)]
[hoversel] - Added focus support on hoversel items.
Summary: Focus support on hoversel items.
Test Plan: elementary_test->hoversel2
Reviewers: seoz, raster, Hermet
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D316
Daniel Juyung Seo [Wed, 13 Nov 2013 08:03:49 +0000 (17:03 +0900)]
test_genlist.c: added "genlist del" example to reveal more genlist issues.
This example tests the following cases on item selection.
1. genlist item deletion
2. genlist clear and item append
3. genlist del
ChunEon Park [Wed, 13 Nov 2013 05:51:55 +0000 (14:51 +0900)]
elementary/entry - use a convenient api.
And actually magnifier needs to update fill area if it is resized.
ChunEon Park [Wed, 13 Nov 2013 05:36:22 +0000 (14:36 +0900)]
Revert "elementary/entry - clean up the magnifier code."
This reverts commit
46b007a7c9d0028aeab43587bc773724c06d0ec8.
sorry, this is wrong fix. clip should be removed explicitly.
ChunEon Park [Wed, 13 Nov 2013 05:25:21 +0000 (14:25 +0900)]
elementary/entry - clean up the magnifier code.
ChunEon Park [Wed, 13 Nov 2013 04:29:28 +0000 (13:29 +0900)]
elementary/entry - clean up the magnifier code.
Daniel Juyung Seo [Wed, 13 Nov 2013 01:53:43 +0000 (10:53 +0900)]
test_button.c: added dynamic label change example to button.
Daniel Juyung Seo [Wed, 13 Nov 2013 01:29:30 +0000 (10:29 +0900)]
ctxpopup, player, slideshow, spinner, toolbar, video: internal refactoring of smart event routines.
Now most of smart events codes look consistent.
Daniel Juyung Seo [Wed, 13 Nov 2013 01:19:47 +0000 (10:19 +0900)]
test_toolbar.c: fixed wrong image name.
Give a warm spank to jeyzu :)
Daniel Juyung Seo [Wed, 13 Nov 2013 01:16:33 +0000 (10:16 +0900)]
test_toolbar.c: gave more meaningful name 'Toolbar Vartical' to toolbar test 6.
Daniel Juyung Seo [Wed, 13 Nov 2013 00:54:37 +0000 (09:54 +0900)]
button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
Now they look more consistent.
Daniel Juyung Seo [Wed, 13 Nov 2013 00:34:58 +0000 (09:34 +0900)]
test_hoversel.c: print out hoversel item's text when it's selected.
Daniel Juyung Seo [Wed, 13 Nov 2013 00:32:20 +0000 (09:32 +0900)]
test_hoversel.c: removed unnecessary weight/align set.
Gustavo Sverzut Barbieri [Tue, 12 Nov 2013 19:56:45 +0000 (17:56 -0200)]
remove unused var.
Gustavo Sverzut Barbieri [Tue, 12 Nov 2013 19:17:13 +0000 (17:17 -0200)]
delete window and children when button is gone
Gustavo Sverzut Barbieri [Tue, 12 Nov 2013 19:03:49 +0000 (17:03 -0200)]
fix doc typo and breakage due widget_type case changes.
elm_widget_type_get() is not lowercase anymoe, rather "Elm_Win". As
other parts of the elementary source were using evas_object_type_get()
use it, and it still returns the legacy lowercase name.
Daniel Juyung Seo [Tue, 12 Nov 2013 18:26:48 +0000 (03:26 +0900)]
configure.ac: say 'no' not 'none' when webkit is not detected during autogen.
Daniel Juyung Seo [Tue, 12 Nov 2013 18:24:59 +0000 (03:24 +0900)]
elm_dayselector.c: fixed wrong widget style name set on smart add.
Daniel Juyung Seo [Tue, 12 Nov 2013 18:24:26 +0000 (03:24 +0900)]
elm_dayselector.c: fixed wrong widget name check.
This fixes T481.
https://phab.enlightenment.org/T481
Daniel Juyung Seo [Tue, 12 Nov 2013 18:24:03 +0000 (03:24 +0900)]
elm_dayselector.c: fixed formatting before working on it.
Carsten Haitzler (Rasterman) [Tue, 12 Nov 2013 14:13:41 +0000 (23:13 +0900)]
deps removal - fix pc file to match
Yakov Goldberg [Tue, 12 Nov 2013 13:54:58 +0000 (15:54 +0200)]
elm_app_client: fix eo define for not yet implemented func
Yakov Goldberg [Tue, 12 Nov 2013 13:50:17 +0000 (15:50 +0200)]
dayselector/gesture_layer/layout: typo doxygen
Carsten Haitzler (Rasterman) [Tue, 12 Nov 2013 13:56:05 +0000 (22:56 +0900)]
option build deps that efl guarantees... now just are assumed and not ifdef'd
Ryuan Choi [Mon, 11 Nov 2013 15:26:26 +0000 (00:26 +0900)]
elm_web: Fixed compilation warning
maxerba [Sun, 10 Nov 2013 16:50:43 +0000 (17:50 +0100)]
Small correction
maxerba [Sun, 10 Nov 2013 12:40:45 +0000 (13:40 +0100)]
updating portuguese and italian translations
Carsten Haitzler (Rasterman) [Sat, 9 Nov 2013 06:21:22 +0000 (15:21 +0900)]
Revert "remove ifdef from glsl in glview shader - ifdefs not universally supported"
This reverts commit
54883cb7fb0c42f37615f1485e554d947b42c369.
Daniel Juyung Seo [Fri, 8 Nov 2013 12:52:37 +0000 (21:52 +0900)]
elm_index.c: Removed unused local variables.
Daniel Juyung Seo [Fri, 8 Nov 2013 12:49:52 +0000 (21:49 +0900)]
button,inwin,radio,scroller,slider: Do not call smart_activate when the widget is disabled.
Jaehwan Kim [Fri, 8 Nov 2013 12:46:58 +0000 (21:46 +0900)]
elm_check.c: Do not execute smart_activate when the widget is disabled.
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 09:12:55 +0000 (18:12 +0900)]
fix warning
Jaeun Choi [Fri, 8 Nov 2013 09:11:06 +0000 (18:11 +0900)]
bug fix: clear index omit info for omit disabled case as well
Summary:
In the original code, omit related information was cleared and recalculated
only when omit function was enabled. So dynamic omit mode change didn't work in elementary_test.
The information should be cleared everytime the index box is filled. fixed it.
Test Plan: None
Reviewers: seoz, Hermet, raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D262
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 08:35:53 +0000 (17:35 +0900)]
warning--
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 08:34:59 +0000 (17:34 +0900)]
warning--
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 08:18:28 +0000 (17:18 +0900)]
fix formatting, typose and downed naming
Thiep Ha [Fri, 8 Nov 2013 08:06:08 +0000 (17:06 +0900)]
Move selection handler from edje to elm
Reviewers: cedric, raster, seoz, Hermet, tasn
CC: raster
Differential Revision: https://phab.enlightenment.org/D311
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 07:56:24 +0000 (16:56 +0900)]
fix cursor to stay shown when cursor moves due to manual placement or typing
related to https://phab.enlightenment.org/D204 which doesn't apply or
has the emit in the wrong place. this now has it done right.
Thiep Ha [Fri, 8 Nov 2013 07:08:47 +0000 (16:08 +0900)]
elm_entry: fix magnifier not showing up.
The swallow part was properly renamed and namespaced, so reflect that
in the code. Also force a edje object recalc before moving the magnifier.
Reviewers: raster, cedric, Hermet, tasn
Reviewed By: cedric
CC: seoz
Differential Revision: https://phab.enlightenment.org/D286
Signed-off-by: Cedric Bail <cedric.bail@samsung.com>
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 06:42:31 +0000 (15:42 +0900)]
colorsel - dont free up palette CONFIG except when clearing palette.
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 06:33:13 +0000 (15:33 +0900)]
config - standard can't use default-desktop as it doesn't exist as a theme
Carsten Haitzler (Rasterman) [Fri, 8 Nov 2013 02:54:09 +0000 (11:54 +0900)]
external symbols need to be EAPI marked even in headers.
Daniel Juyung Seo [Fri, 8 Nov 2013 02:30:50 +0000 (11:30 +0900)]
elm_dbus_menu.c: Removed unused pointer value assignment.
This fixes coverity CID 1039975.
Daniel Juyung Seo [Fri, 8 Nov 2013 02:22:01 +0000 (11:22 +0900)]
elm_prefs_data.c: Check return value of eina_value_get().
This fixes coverity CID 1040042.
Daniel Juyung Seo [Fri, 8 Nov 2013 01:27:44 +0000 (10:27 +0900)]
elm_config.c: Check null for profile. I can be null.
This fixes coverity CID 1040032.
Tom Hacohen [Thu, 7 Nov 2013 14:29:38 +0000 (14:29 +0000)]
Changed Eo class names to be consistent. #2
All the class names are now of the format: Elm_Type_Subtype_Extra
Thanks to Yakov for pointing out I forgot a few and for giving me a nice
list.
Chris Michael [Thu, 7 Nov 2013 14:26:57 +0000 (14:26 +0000)]
Fix selection type when trying to get a selection. Also fix pasting
from terminology into other elm apps (selection format issue).
Wayland has no concept of primary or secondary clipboards so we need
to test for selection == those due to some X apps.
*cough*terminology*cough* using only Primary or Secondary.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 7 Nov 2013 12:01:00 +0000 (12:01 +0000)]
Fix elm_entry to work with copy/paste (mouse and keyboard) under
wayland.
This also unifies some of the code between X & wayland wrt copy/paste.
This is part of a larger copy/paste fix for efl/elm wayland.
Previously, copy/paste would not work via keyboard shortcuts. This
series of changes fixes that issue (wrt elm_entry anyway).
This also adds addtional copy/paste support (wrt efl wayland),
including support for various mime types (text/plain, elm-markup, and html).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 7 Nov 2013 11:57:14 +0000 (11:57 +0000)]
Fix elementary copy/paste for wayland. Rework copy/paste code in elm.
This is part of a larger copy/paste fix for efl/elm wayland.
Previously, copy/paste would not work via keyboard shortcuts. This
series of changes fixes that issue (wrt elm_entry anyway).
This also adds addtional copy/paste support (wrt efl wayland),
including support for various mime types (text/plain, elm-markup, and
html).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
ChunEon Park [Thu, 7 Nov 2013 13:34:57 +0000 (22:34 +0900)]
elementary/scroller - don't focus region show if the scroller is disabled.
ChunEon Park [Thu, 7 Nov 2013 13:33:25 +0000 (22:33 +0900)]
elementary - fixed changelog typo
Tom Hacohen [Thu, 7 Nov 2013 11:44:22 +0000 (11:44 +0000)]
Changed Eo class names to be consistent.
All the class names are now of the format: Elm_Type_Subtype_Extra
Doug Newgard [Thu, 7 Nov 2013 11:05:01 +0000 (20:05 +0900)]
Minor PKGBUILD cleanup
Summary:
Add PKGBUILD to make dist so it will be in the snapshots
Change dep to current efl package since efl_x11 isn't there anymore
Check for Makefile before running make clean distclean otherwise build fails
Set correct arch on elementary_doc
Install docs to /usr/share/doc
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D282
Carsten Haitzler (Rasterman) [Thu, 7 Nov 2013 08:25:53 +0000 (17:25 +0900)]
reandme == 1.8.0
Daniel Juyung Seo [Wed, 6 Nov 2013 16:24:12 +0000 (01:24 +0900)]
test_genlist.c: Fixed wrong item class name.
This fixes coverity CID 1126089.