Michal Michalski [Mon, 17 Feb 2020 10:04:25 +0000 (11:04 +0100)]
[SDL-92][messaging] Macro parameters should be wrapped in brackets.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If2a2cdfac845faec13c36f12b61a8e31a18097d7
[version] 2.61
Change-Id: I77f7340c0972610dc2088c995ced2b94367c3b17
Piotr Kosko [Tue, 11 Feb 2020 09:40:30 +0000 (09:40 +0000)]
Merge "[Filesystem] Fixing SVACE issue 423267" into tizen
[Filesystem] Fixing SVACE issue 423267
Preventing integer overflow during subtraction.
Change-Id: I5ea92045a0b3b12641cba8c05de914f71997dae9
Pawel Wasowski [Wed, 5 Feb 2020 13:00:47 +0000 (14:00 +0100)]
[common][messaging] Move toLowerCase from messaging to common module
The function is generic and may be used in modules other than messaging.
Function name was changed to comply with Google C++ coding style.
Change-Id: I52053780fb6f860fe7fcc1e0c7c1d912ecdd85f9
Verification: auto tct-messaging-{email,sms,mms}-tizen-tests pass rate: 100%
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Merge branch 'tizen_5.5' into tizen
Change-Id: I86a17b4aceb2d036060b303bde438784463f316c
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: Ibf67711087f0a032290a8e953b90335e4400372b
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I47343e6732942b125e9eae672626a60967704062
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1bd47bf631acfcd842c26a5076c3538d8cbe8247
[version] 2.40
Change-Id: I06a43e95787fe3e97fc87cbaaee7f2e430b99b97
Pawel Wasowski [Wed, 8 Jan 2020 10:28:08 +0000 (11:28 +0100)]
[Archive] Prevent extracting files with ".." in relative paths
This change mitigates a potential security issue, which could occur if
a zip archive contained files with ".." in their paths.
ArchiveEntry.extract() and Archive.extractAll() will not extract such
files.
Verification: auto tct-tizen-archive-tests pass rate: 100%
Manual tests: attempts to extract files with forbidden
".." results in an UnknownError.
Change-Id: I563744d834d24e896493f55d15e579e714d539f9
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Tue, 7 Jan 2020 13:44:55 +0000 (13:44 +0000)]
Merge "[6.0][mediacontroller] fix issues" into tizen
Mikhail Kashkarov [Fri, 20 Dec 2019 18:44:18 +0000 (21:44 +0300)]
[Tizen 6.0] Support build with glibc 2.30
Support armv7l builds for OBS
[ 391s] + out/Default/desc_gentool /usr/lib/tizen-extensions-crosswalk/common
/home/abuild/rpmbuild/BUILDROOT/webapi-plugins-2.58-3.3.arm/usr/lib/tizen-extensions-crosswalk/common
[ 391s] scandir: Value too large for defined data type
which caused by different dirent layout since glibc 2.25 and dirent is used by
scandir routine:
struct dirent
{
#ifndef __USE_FILE_OFFSET64
__ino_t d_ino; /* File serial number. */
#else
__ino64_t d_ino;
#endif
....
Change-Id: I3cba875d7b1c1958f99258b8aff9b72af372535e
Signed-off-by: Mikhail Kashkarov <m.kashkarov@partner.samsung.com>
Pawel Wasowski [Fri, 27 Dec 2019 15:56:00 +0000 (16:56 +0100)]
Resolve compilation build problems occurring after switch to GCC 9
Build status:
Standard:
armv7l: builds successfully
aarch64: builds successfully
i586: builds successfully
x86_64: builds successfully
Emulator:
i586: builds successfully
x86_64: builds successfully
Change-Id: Iebb8423fbfae40e3c84f9e78b283163b97b8001b
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Dawid Juszczak [Thu, 19 Dec 2019 10:09:23 +0000 (11:09 +0100)]
[6.0][mediacontroller] fix issues
[ACR]
https://code.sec.samsung.net/jira/browse/TWDAPI-246
https://code.sec.samsung.net/jira/browse/TWDAPI-248
[Description]
1) Now methods sendPlaybackAction, sendPlaybackPosition,
sendShuffleMode and sendRepeatState throws TypMismatchError
when undefined is passed as second attribute.
2) rename methods:
- addPlaylistUpdateListener() -> addPlaylistUpdatedListener()
- removePlaylistUpdateListener() -> removePlaylistUpdatedListener()
3) add checking if playlist_obj passed to getPlaylist() function is not nullptr
[Verification]
Tested manually on chrome console
tct-mediacontroller-tizen-tests fails with 2 testcases:
- MediaControllerServer_iconURI_attribute
- MediaControllerServerInfo_iconURI_attribute
It fails because attribute iconURI is no longer
readonly and tests should be fixed.
Change-Id: I9b4e893f9ada7824dc53e0f07e3574a90f460205
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Thu, 12 Dec 2019 13:51:16 +0000 (13:51 +0000)]
Merge "[messaging] Adjusting code to match our coding standard." into tizen
Piotr Kosko [Thu, 12 Dec 2019 13:05:44 +0000 (13:05 +0000)]
Merge "[messaging] MessageFolder alias has been removed." into tizen
Piotr Kosko [Thu, 12 Dec 2019 13:04:01 +0000 (13:04 +0000)]
Merge "[messaging] Replace MessageFolder with json." into tizen
Piotr Kosko [Thu, 12 Dec 2019 13:03:05 +0000 (13:03 +0000)]
Merge "[messaging] Make MessageFolder.attributes a picojson::value." into tizen
Piotr Kosko [Thu, 12 Dec 2019 12:57:02 +0000 (12:57 +0000)]
Merge "[messaging] Remove MessageFolder(json) constructor." into tizen
Piotr Kosko [Thu, 12 Dec 2019 12:56:45 +0000 (12:56 +0000)]
Merge "[messaging] Remove MessageFolder constructor." into tizen
[version] 2.59
Change-Id: Id08331c3bb8f3f0342813fc02b8d0c841ee2dd85
Piotr Kosko [Wed, 11 Dec 2019 10:07:21 +0000 (10:07 +0000)]
Merge "[mediacontroller] add new methods for playlists" into tizen
Piotr Kosko [Wed, 11 Dec 2019 10:04:21 +0000 (10:04 +0000)]
Merge "[mediacontroller] deleting useless lines" into tizen
Dawid Juszczak [Fri, 4 Oct 2019 10:07:51 +0000 (12:07 +0200)]
[mediacontroller] add new methods for playlists
[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-239
[description]
added method getPlaylist for interfaces:
- MediaControllerPlaylists
- MediaControllerPlaylistsInfo
[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests fails with 2 TC:
- MediaControllerServer_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
- MediaControllerServerInfo_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
Change-Id: Idbe3e7f45144574f2dcc799f9e2fc936904c9fff
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Tue, 10 Dec 2019 12:45:34 +0000 (13:45 +0100)]
[messaging] Adjusting code to match our coding standard.
+ export message folder attributes constants
+ change CAPITAL_CASE to kCamelCase constants names format
+ reorder initialization of message folder attributes in createMessageFolder() to match
arguments order,
+ use named attribute constant instead of string literal
[Verification] code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I52dcb4659d28cd952f8c823d100183c819fda93d
Michal Michalski [Tue, 10 Dec 2019 11:00:32 +0000 (12:00 +0100)]
[messaging] MessageFolder alias has been removed.
[Verification] code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I631a2a7ef9ecd0727857002d235c867a6175d1b6
Michal Michalski [Mon, 9 Dec 2019 15:37:30 +0000 (16:37 +0100)]
[messaging] Replace MessageFolder with json.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I211ef9a458b3bab6f795071dc6ed8daa14e6bcf3
Michal Michalski [Mon, 9 Dec 2019 14:36:27 +0000 (15:36 +0100)]
[messaging] Make MessageFolder.attributes a picojson::value.
Previously attributes were picojson::object. I decided to switch
to picojson::value to make the removal of MessageFolder class more
straightforward.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icb5bcb51469819420bb2e7b5071e0ada04594a14
Michal Michalski [Mon, 9 Dec 2019 14:14:07 +0000 (15:14 +0100)]
[messaging] Remove MessageFolder(json) constructor.
Last step before removing MessageFolder class completely.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I2fc451d80c1cdc2b9b1d0fc2e77d020eb1870e36
Piotr Kosko [Tue, 10 Dec 2019 10:43:21 +0000 (10:43 +0000)]
Merge "[6.0][mediacontroller] add MediaControllerPlaylistsInfo interface" into tizen
Piotr Kosko [Tue, 10 Dec 2019 10:40:02 +0000 (10:40 +0000)]
Merge "[6.0][mediacontroller] add MediaControllerPlaylists interface" into tizen
Dawid Juszczak [Wed, 13 Nov 2019 09:43:36 +0000 (10:43 +0100)]
[mediacontroller] deleting useless lines
[description]
this commit deletes unused attribute names (in js file)
and special cases for TOGGLE_PLAY_PAUSE
[verification]
tct-mediacontroller-tizen-tests 100% PASS
Change-Id: I723c1cc525a35c48eb9ae854bd154b5cd3c9b2df
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Fri, 6 Dec 2019 10:42:03 +0000 (11:42 +0100)]
[messaging] Remove MessageFolder constructor.
+ Removed MessageFolder constructor from attributes.
+ MessageFolder(json) constructor is used to create folders.
+ Add createMessageFolder() -> json function.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I17442348d4f91c8ac275787adfe7ca8fb8ae88ff
Dawid Juszczak [Tue, 5 Nov 2019 10:32:52 +0000 (11:32 +0100)]
[6.0][mediacontroller] add MediaControllerPlaylistsInfo interface
[acr]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-248
[description]
>> refactor_05 <<
add MediaControllerPlaylistsInfo interface to MediaControllerServerInfo.
Methods added to MediaControllerPlaylistsInfo interface:
+ getAllPlaylists
+ sendPlaybackItem
+ addPlaylistUpdatedListener
+ removePlaylistUpdatedListener
[verification]
tested manually in chrome console
tct-mediacontroller-tizen-tests fails with 2 TC:
- MediaControllerServer_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
- MediaControllerServerInfo_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
Change-Id: I761bd30eb7988a0d874f1569cdf2e7f147012ee8
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Mon, 4 Nov 2019 17:03:33 +0000 (18:03 +0100)]
[6.0][mediacontroller] add MediaControllerPlaylists interface
[acr]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-247
[description]
>> refactor_04 <<
add MediaControllerPlaylists interface to MediaControllerServer.
Methods added to MediaControllerPlaylists interface:
+ createPlaylist
+ savePlaylist
+ deletePlaylist
+ getAllPlaylists
[verification]
tested manually in chrome console
tct-mediacontroller-tizen-tests fails with 2 TC:
- MediaControllerServer_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
- MediaControllerServerInfo_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
Change-Id: I4cd792eb6e87f1803bd3e56b54accc91f1e0fd8d
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Merge branch 'tizen_5.5' into tizen
Change-Id: I7a3b0ec2473d5524af05e2d842cda818e778c199
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: I140956e31d498f825947f58cb0c6990cb40c279f
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Ib491adc102418f59ef279fc47d45a7ef3f867569
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I46b19761d8c18ed668e27a078c7e8094c1dde614
[version] 2.39
Change-Id: I4b83c04cba5ab218c11cefdbffd4e89054f54540
[Messageport] Fixed listener issues
[Bugs]
* There was a problem with missing unregistration of
listeners for local ports, it was added.
* There was invalid calling of listeners (only latest listener was called),
now each registered listener is called properly.
[Verification] Messageport TCT passrate 100%.
Below scenario calls 3 different callbacks:
abc = tizen.messageport.requestLocalMessagePort("abc");
abc.addMessagePortListener((data, name) => {console.log(abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc.addMessagePortListener((data, name) => {console.log("2" + abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc.addMessagePortListener((data, name) => {console.log("3" + abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc_remote = tizen.messageport.requestRemoteMessagePort(tizen.application.getCurrentApplication().appInfo.id, "abc");
abc_remote.sendMessage([{key: "key1", value: "val1"}]);
Change-Id: If3a4b362de76599904c83737137c0d0cd4d023c7
Piotr Kosko [Fri, 6 Dec 2019 10:33:40 +0000 (10:33 +0000)]
Merge changes If208ce7c,I10799622,I4e9cfc73,If4ea326e into tizen
* changes:
[messaging] MessageFolder no longer implements FilterableObject interface.
[messaging] Implement isMatching(json) methods.
[messaging] AbstractFilter::isMatching(json) interface.
[messaging] Remove MessageFolder(email_mailbox_t) constructor.
Piotr Kosko [Fri, 6 Dec 2019 10:33:35 +0000 (10:33 +0000)]
Merge "[messaging] EmailGetMailboxById native function wrapper." into tizen
Piotr Kosko [Fri, 6 Dec 2019 09:30:55 +0000 (09:30 +0000)]
Merge "[messaging] MessageFolderType as string." into tizen
Piotr Kosko [Fri, 6 Dec 2019 09:00:26 +0000 (09:00 +0000)]
Merge "[messaging] Replacing MessageFolder with picojson part 2." into tizen
Piotr Kosko [Fri, 6 Dec 2019 08:57:01 +0000 (08:57 +0000)]
Merge "[messaging] Move folder-related code to message_folder." into tizen
Piotr Kosko [Fri, 6 Dec 2019 08:54:25 +0000 (08:54 +0000)]
Merge "[messaging] Replace MessageFolder class with plain json part 1." into tizen
Michal Michalski [Thu, 5 Dec 2019 12:18:56 +0000 (13:18 +0100)]
[messaging] MessageFolder no longer implements FilterableObject interface.
Due to introduction of AbstractFilter::isMatching(json) method, MessageFolder no
longer needs to implement FilterableObject interface, because folders are filtered
using new implementation.
+ Remove MessageFolder::isMatchingAttribute()
+ Remove MessageFolder::isMatchingAttributeRange()
+ MessageFolder no longer inherits from FilterableObject
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If208ce7c6bce999c2b6422e5a282f04f625e1af2
Michal Michalski [Thu, 5 Dec 2019 11:16:41 +0000 (12:16 +0100)]
[messaging] Implement isMatching(json) methods.
+ Implement AttributeFilter::isMatching(const picojson::value&)
+ Implement AttributeRangeFilter::isMatching(const picojson::value&)
+ Implement CompositeFilter::isMatching(const picojson::value&)
+ Switch to new isMatching() method for MessageFolder objects.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I10799622eb280b252fdd8535d5cd6eaff4c3b447
Michal Michalski [Wed, 4 Dec 2019 13:42:13 +0000 (14:42 +0100)]
[messaging] EmailGetMailboxById native function wrapper.
+ Created wrapper to native email_get_mailbox_by_mailbox_id() function.
[Verification]
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Iad88d2c59ac872394c52cc0506c8f5a0ab52865a
Michal Michalski [Wed, 4 Dec 2019 15:02:09 +0000 (16:02 +0100)]
[messaging] AbstractFilter::isMatching(json) interface.
+ Created AbstractFilter::isMatching(picojson::value) method to prepare
for plain json filtering.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4e9cfc7343a33c3af71250f827ed39c8b7d1c74b
Michal Michalski [Wed, 4 Dec 2019 13:45:51 +0000 (14:45 +0100)]
[messaging] Remove MessageFolder(email_mailbox_t) constructor.
+ Conversion from email_mailbox_t to MessageFolder is now performed inside native function wrappers.
[Verification] In progress.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If4ea326eaf9b3242d7c72285e6ba0f4db247d553
Michal Michalski [Mon, 2 Dec 2019 16:34:10 +0000 (17:34 +0100)]
[messaging] MessageFolderType as string.
+ Remove getType() and getId() methods from MessageFolder.
+ Replace MessageFolderType enum with strings everywhere.
+ Remove unused messageFolderTypeToString() function.
+ Add MessageFolderTypeStr string array of folder type values.
+ Align code using old folder type implementation.
+ Inline MessageFolder::toJSON() calls and remove this method.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I96b8a76508c9e6b1a807e773ab08dca3da851585
Michal Michalski [Mon, 2 Dec 2019 11:35:18 +0000 (12:35 +0100)]
[messaging] Replacing MessageFolder with picojson part 2.
+ FilterUtils::isMatching() overload for picojson::value.
+ Removed some getters/setters from MeessageFolder.
+ Removed unused FoldersChangeCallback::getFilter() method.
+ Simplified implementation of MessageFolder::isMatchingAttribute().
+ Removed stringToMessageFolderType() unused function.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I578dcbd7b9d4fb5650f0eca1ecb264a78aff8962
Michal Michalski [Fri, 29 Nov 2019 14:01:02 +0000 (15:01 +0100)]
[messaging] Move folder-related code to message_folder.
+ Moved FindFolderTaskParams to message_folder.h
+ Moved filterFolders() from folders_changed_callback to message_folder.
+ Moved MESSAGE_FOLDER_ATTRTIBUTE_* constants to message_folder.cc
+ Remove FolderPtr typedef.
+ Remove unneccessary extern declarations.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5289f7f0e9e84ec71bf92031e5c5c56b2cb65df6
Michal Michalski [Fri, 29 Nov 2019 08:34:43 +0000 (09:34 +0100)]
[messaging] Replace MessageFolder class with plain json part 1.
+ MessageFolder::filterFolders() method converted to function and removed from the header.
+ Replace MessageUtils::folderToJson() with MessageFolder::toJSON() method.
+ Replace all MessageFolder attributes with single picojson object.
+ Move folder-related methods and types from messaging_util to message_folder module.
+ Replace jsonToFolder() method with MessageFolder(picojson::value) constructor.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I08143e5fa65978a6979b4a9a1753cfba8adaa3ed
Dawid Juszczak [Mon, 4 Nov 2019 16:11:19 +0000 (17:11 +0100)]
[6.0][mediacontroller] add methods to MediaControllerServerPlaybackInfo
[acr]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-246
[description]
>> refactor_03 <<
add methods to serverInfoPlaybackInfo interface:
+ sendPlaybackAction
+ sendPlaybackPosition
+ sendShuffleMode
+ sendRepeatState
+ addPlaybackInfoChangeListener
+ removePlaybackInfoChangeListener
[verification]
tested manually in chrome console
tct-mediacontroller-tizen-tests fails with 2 TC:
- MediaControllerServer_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
- MediaControllerServerInfo_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
Change-Id: I3b24e1e3d6bfee1ced8d24962a790ae9e71b445a
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Thu, 31 Oct 2019 15:11:43 +0000 (16:11 +0100)]
[6.0][mediacontroller] add playback action enum, listeners to server pbInfo and change iconURI
[acr]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-245
[description]
>> refactor_02 <<
+ change iconURI to NOT readonly
+ add listeners in serverPlaybackInfo
+ add playbackAction enum
+ add onplaybackactionrequest
[verification]
tested manually in chrome console
tct-mediacontroller-tizen-tests fails with 2 TC:
- MediaControllerServer_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
- MediaControllerServerInfo_iconURI_attribute.html <- has to be modified,
because attribute iconURI is no longer readonly
Change-Id: I1a234adbab71be72ec6c24a7fec4e8b5d7fcc55c
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Piotr Kosko [Thu, 5 Dec 2019 15:53:34 +0000 (15:53 +0000)]
Merge "[6.0][mediacontroller] add new playback interfaces" into tizen
Merge branch 'tizen_5.5' into tizen
Change-Id: Iad45d3ae313f7966bca8f697f562411e0d6cfc2b
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: Idb060dbb650969c05e7ecdd193e551dc42cb070d
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I6272ee91b469df02a70c0ddea192ef9cc46b0123
[version] 2.39
Change-Id: I06df52433c2f8c159d42ae7ad11e10531b13a60d
[Code format] Fixed formatting issues
Change-Id: Ieb6000829e03777e709ecfa9e447185975828866
[Code format] Fixed formating with auto-format tool
* added ignoring "src/google" directories in code_format script
Change-Id: If843a91d21bb558b8354c09e2832cb3d4934ea26
Michal Michalski [Wed, 27 Nov 2019 15:13:10 +0000 (16:13 +0100)]
[messaging] Get rid of FoldersDataCallback structure.
[Verification] tct-messaging-*-tizen-tests 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If63afc96ff26cbd820aad8781e233eee8b3c4e26
Michal Michalski [Wed, 4 Dec 2019 07:59:42 +0000 (08:59 +0100)]
[messaging] MessageStorageFindFolders simplified implementation.
+ reimplement MessageStorageFindFolders without using PostQueue
+ replace FoldersCallbackData with simpler FindFoldersTaskParams
+ improve code readability in other minor ways
[Verification] tct-messaging-*-tizen-tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4842fc6e43971960f591b86b30d9d4d6720620a4
Michal Michalski [Wed, 4 Dec 2019 07:58:26 +0000 (08:58 +0100)]
[common] MessageStorageFindFolders simplified implementation.
+ add default constructor to PlatformResult
+ add tools::PostMessage overload for json message
[Verification] code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Iafed8da9ebc6519f84f3341324f7ef4908ac9e61
Piotr Kosko [Mon, 2 Dec 2019 11:29:59 +0000 (11:29 +0000)]
Merge "[ham] Fixed sleep recorder, returned value" into tizen
Piotr Kosko [Mon, 2 Dec 2019 11:21:50 +0000 (11:21 +0000)]
Merge "[ham] Fixed sleep recorder, returned value" into tizen_4.0
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
Piotr Kosko [Mon, 2 Dec 2019 07:21:30 +0000 (07:21 +0000)]
Merge "[MediaController] Fix removing invalid listener" into tizen_4.0
Pawel Wasowski [Thu, 22 Aug 2019 10:46:35 +0000 (12:46 +0200)]
[messaging] Remove unused code
Some class methods and fields were never used. This commit removes them.
[Verification] Code compiles
Change-Id: I978bc8e7ffc70f6ddb9c88ddb3dad33cdddd51ee
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Piotr Kosko [Tue, 26 Nov 2019 08:07:13 +0000 (08:07 +0000)]
Merge "[messaging] Fixed AttributeFilter for TO attribute." into tizen
Piotr Kosko [Tue, 26 Nov 2019 06:29:13 +0000 (06:29 +0000)]
Merge "[HAM] Adding accumulative pedometer data to HumanActivityPedometerData" into tizen
Piotr Kosko [Fri, 22 Nov 2019 11:01:39 +0000 (11:01 +0000)]
Merge "[tizen] Remove unused _filter() methods." into tizen
Piotr Kosko [Fri, 22 Nov 2019 10:59:02 +0000 (10:59 +0000)]
Merge "[tizen] Remove unused function." into tizen
Piotr Kosko [Fri, 22 Nov 2019 10:58:15 +0000 (10:58 +0000)]
Merge "[common] JsonFilter prototype implementation." into tizen
Merge branch 'tizen_5.5' into tizen
Change-Id: I3a58e60aa1c56fc0716a54e38d9dead62621292e
Merge branch 'tizen_5.0' into tizen_5.5
Change-Id: I39e4601ffb169013301568e4b1631f1b5234664e
Rafal Walczyna [Thu, 21 Nov 2019 08:31:42 +0000 (09:31 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iefec897b80c611421c9a7592df571ffe75588576
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: I0e0154add6a286b1fb259a2d973210d3887c3a94
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I19c718eb38545fda3bf0b49403e1cbd88960ec4f
[version] 2.38
Change-Id: Id74d1d21292bd36c33771009e5a6fac0bd50537b
Rafal Walczyna [Thu, 21 Nov 2019 08:31:42 +0000 (09:31 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iefec897b80c611421c9a7592df571ffe75588576
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Michal Michalski [Fri, 15 Nov 2019 09:46:24 +0000 (10:46 +0100)]
[tizen] Remove unused _filter() methods.
AttributeFilter, AttributeRangeFilter and CompositeFilter
classes had undocumented _filter method which was not used
anywhere within WebAPI.
[Verification] grep.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4708d308be73ef619e63317c7fe9ba7aa974b067
Michal Michalski [Fri, 15 Nov 2019 09:21:53 +0000 (10:21 +0100)]
[tizen] Remove unused function.
Function _is_tizen_filter() was not used anywhere in the API.
[Verification] grep
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ia2e460264e46a1120d75e463f8102d5787caefcd
Michal Michalski [Thu, 14 Nov 2019 16:54:50 +0000 (17:54 +0100)]
[common] JsonFilter prototype implementation.
In present WebAPI implementation, several modules implement their own
data filtering algorithms. This commit is an attempt to provide a common,
unified way to perform data filtering across entire API.
Design goal for this change was simplicity. I was not looking for ways
to optimize the performance, as this will require in-depth performance
testing in specific use cases.
[Verification] Unit tests for JsonFilter class has been implemented which validate
main logic.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I6cfb9fc98f6a1be8d6364a9dfff2bf07ba239dfa
Piotr Kosko [Tue, 19 Nov 2019 10:27:15 +0000 (10:27 +0000)]
Merge "[messaging] Support new filtering options in findFolders (SMS/MMS)" into tizen
Piotr Kosko [Tue, 19 Nov 2019 10:12:29 +0000 (10:12 +0000)]
Merge "[Tizen] Remove unused PERMISSION_DENIED_ERR from code" into tizen
Piotr Kosko [Tue, 19 Nov 2019 10:10:15 +0000 (10:10 +0000)]
Merge "[Tizen] Remove unused DATABASE_ERROR from code" into tizen
Lukasz Bardeli [Mon, 18 Nov 2019 08:48:25 +0000 (09:48 +0100)]
[Tizen] Remove unused PERMISSION_DENIED_ERR from code
[Verification] Code compiles without error
Change-Id: Ib2a7bc19d493c7498ec9a03f11d6835d17fc8194
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Wasowski [Tue, 5 Mar 2019 16:38:11 +0000 (17:38 +0100)]
[messaging] Support new filtering options in findFolders (email)
Related ACR: TWDAPI-205
[Verification] tct-messaging-email-tests: pass rate
did not change after applying the commit
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200909/
Change-Id of the original change was:
I911d1631d879fd805367f0837eec03e004b7167d
Change-Id: I75d057ba1ad12c760b455e040c41f0e143941e48
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>