platform/upstream/ofono.git
14 years agoAdd: support for EF_ICCID in isimodem.
Pessi Pekka (Nokia-D/Helsinki) [Tue, 25 May 2010 20:37:04 +0000 (22:37 +0200)]
Add: support for EF_ICCID in isimodem.

14 years agohuawei: remove voicecall support
Kalle Valo [Tue, 25 May 2010 14:23:32 +0000 (17:23 +0300)]
huawei: remove voicecall support

These modems don't support voicecall anyway. Recommended by Denis.

14 years agohuawei: send a prefix with AT commands
Kalle Valo [Tue, 25 May 2010 14:23:26 +0000 (17:23 +0300)]
huawei: send a prefix with AT commands

14 years agohuawei: properly notify sim state to ofono
Kalle Valo [Tue, 25 May 2010 14:23:19 +0000 (17:23 +0300)]
huawei: properly notify sim state to ofono

Instead of using ofono_modem_set_powered(), use ofono_sim_inserted_notify()
which is the proper way to notify about sim state changes.

Now the problem is that voicecall commands fail with my Huawei E1552:

ofonod[12395]: > AT+CRC=1\r
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+CLIP=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+COLP=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+CCWA=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: drivers/atmodem/voicecall.c:at_voicecall_initialized()
  voicecall_init: registering to notifications
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: > AT^SYSINFO\r
ofonod[12395]: < \r\n^SYSINFO:0,0,0,0,255,,0\r\n\r\nOK\r\n
ofonod[12395]: > AT+CGMI\r
ofonod[12395]: < \r\nhuawei\r\n\r\nOK\r\n
ofonod[12395]: EventChannel: < \r\n^STIN:0,0,0\r\n
ofonod[12395]: > AT+CLCC\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n

But as I can't make voice calls with this modem anyway, I don't worry
about them right now.

14 years agohuawei: use g_at_result_iter_skip_next()
Kalle Valo [Tue, 25 May 2010 14:23:13 +0000 (17:23 +0300)]
huawei: use g_at_result_iter_skip_next()

14 years agoSome minor cleanups for the Huawei plugin
Marcel Holtmann [Tue, 25 May 2010 09:13:48 +0000 (11:13 +0200)]
Some minor cleanups for the Huawei plugin

14 years agohuawei: follow sim state change notifications
Kalle Valo [Tue, 25 May 2010 08:48:57 +0000 (11:48 +0300)]
huawei: follow sim state change notifications

With Huawei E1552 I got sim busy errors when I plugged in the modem
and ofono was already running:

May 24 17:02:04 tukki ofonod[7619]: > AT+CRC=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n
May 24 17:02:04 tukki ofonod[7619]: > AT+CLIP=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n

Fix this by following sim state changes with ^SIMST notification and
only enable modem after SIM is ready. In case SIM is already ready
and we miss the notification for some reason, also use AT^SYSINFO
to check the state during enable phase.

Also change huawei_enable() to return -EINPROGRESS to make sure that
ofono modem is not powered too early. I believe this was a bug.

14 years agoBreak function declaration down to two lines
Marcel Holtmann [Tue, 25 May 2010 09:08:58 +0000 (11:08 +0200)]
Break function declaration down to two lines

14 years agoBring back -d option without need for argument
Gustavo F. Padovan [Tue, 25 May 2010 08:09:21 +0000 (05:09 -0300)]
Bring back -d option without need for argument

14 years agoSome extra empty lines to separate chapters
Marcel Holtmann [Fri, 21 May 2010 09:43:30 +0000 (11:43 +0200)]
Some extra empty lines to separate chapters

14 years agosim: Read EFiccid after EFphase
Denis Kenzior [Thu, 20 May 2010 04:48:34 +0000 (23:48 -0500)]
sim: Read EFiccid after EFphase

14 years agosim: No need for this define
Denis Kenzior [Thu, 20 May 2010 04:47:41 +0000 (23:47 -0500)]
sim: No need for this define

14 years agoRead EF_ICCID property of SIM
Daniel Wagner [Thu, 20 May 2010 10:01:48 +0000 (12:01 +0200)]
Read EF_ICCID property of SIM

Tested with phonesim.

14 years agonetreg: Fix crash when CREG is reported too early
Denis Kenzior [Thu, 20 May 2010 04:33:17 +0000 (23:33 -0500)]
netreg: Fix crash when CREG is reported too early

If we register for CREG notifications before the netreg atom is
registered (e.g. in MBM due to CIND queries) we crash if the CREG
notification arrives before the CIND is queried.

14 years agohuawei: add gprs context
Kalle Valo [Thu, 20 May 2010 10:53:28 +0000 (13:53 +0300)]
huawei: add gprs context

Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid
SIM.

14 years agoMove report_signal_strength to atutil
Kalle Valo [Thu, 20 May 2010 10:53:21 +0000 (13:53 +0300)]
Move report_signal_strength to atutil

The function is needed in two different places, better to move it
to atutil.h.

14 years agohuawei: detect possible secondary device
Kalle Valo [Thu, 20 May 2010 10:53:15 +0000 (13:53 +0300)]
huawei: detect possible secondary device

14 years agoUpdate TODO
Denis Kenzior [Wed, 19 May 2010 11:58:37 +0000 (06:58 -0500)]
Update TODO

14 years agoUpdate TODO
Denis Kenzior [Wed, 19 May 2010 11:49:24 +0000 (06:49 -0500)]
Update TODO

14 years agoUpdate TODO
Denis Kenzior [Wed, 19 May 2010 11:37:56 +0000 (06:37 -0500)]
Update TODO

14 years agoUpdate TODO
Denis Kenzior [Wed, 19 May 2010 11:32:29 +0000 (06:32 -0500)]
Update TODO

14 years agoAdd some extra markups for TODO list
Marcel Holtmann [Wed, 19 May 2010 12:58:04 +0000 (14:58 +0200)]
Add some extra markups for TODO list

14 years agocore: Trivial whitespace error
Denis Kenzior [Wed, 19 May 2010 10:26:35 +0000 (05:26 -0500)]
core: Trivial whitespace error

14 years agoppp: Trivial whitespace error
Denis Kenzior [Wed, 19 May 2010 10:26:21 +0000 (05:26 -0500)]
ppp: Trivial whitespace error

14 years agoAdd initial TODO file
Denis Kenzior [Wed, 19 May 2010 10:25:06 +0000 (05:25 -0500)]
Add initial TODO file

14 years agoppp: implement ppp_packet_new
Kristen Carlson Accardi [Thu, 13 May 2010 17:31:32 +0000 (10:31 -0700)]
ppp: implement ppp_packet_new

14 years agoAdd isimodem support for network time
Aki Niemi [Tue, 18 May 2010 16:28:31 +0000 (19:28 +0300)]
Add isimodem support for network time

14 years agoAdd network time support
Aki Niemi [Tue, 18 May 2010 14:07:54 +0000 (17:07 +0300)]
Add network time support

Adding a new notify function in the netreg atom for notifying a
received Network Identification and Timezone (NITZ) indication. This
data is consumed via a nettime plugin, of which there is also an
example.

14 years agogisi: Fix style issues
Aki Niemi [Mon, 17 May 2010 11:26:01 +0000 (14:26 +0300)]
gisi: Fix style issues

14 years agoMake isimodem use linkstate directly
Pekka Pessi [Tue, 11 May 2010 15:38:46 +0000 (18:38 +0300)]
Make isimodem use linkstate directly

14 years agoConfigure phonet link in usbpnmodem
Pekka Pessi [Wed, 28 Apr 2010 13:37:38 +0000 (16:37 +0300)]
Configure phonet link in usbpnmodem

14 years agogisi: Fix netlink style issues
Aki Niemi [Mon, 17 May 2010 10:50:50 +0000 (13:50 +0300)]
gisi: Fix netlink style issues

14 years agogisi: Add phonet netlink functions
Pekka Pessi [Wed, 28 Apr 2010 13:37:10 +0000 (16:37 +0300)]
gisi: Add phonet netlink functions

Adding g_pn_netlink_set_address() and g_pn_netlink_add_route().
Automatically configure phonet links without external software.

14 years agoUse g_pn_netlink_by_modem() in isimodem driver
Pekka Pessi [Wed, 28 Apr 2010 13:21:16 +0000 (16:21 +0300)]
Use g_pn_netlink_by_modem() in isimodem driver

14 years agoUse g_pn_netlink_by_modem() in usbpnmodem plugin
Pekka Pessi [Wed, 28 Apr 2010 13:20:42 +0000 (16:20 +0300)]
Use g_pn_netlink_by_modem() in usbpnmodem plugin

14 years agogisi: Remove g_pn_netlink_by_name()
Pekka Pessi [Wed, 28 Apr 2010 13:19:15 +0000 (16:19 +0300)]
gisi: Remove g_pn_netlink_by_name()

14 years agoRemove unused declaration
Aki Niemi [Sat, 15 May 2010 07:44:40 +0000 (10:44 +0300)]
Remove unused declaration

14 years agoFix typo in comment
Aki Niemi [Sat, 15 May 2010 07:42:13 +0000 (10:42 +0300)]
Fix typo in comment

14 years agoFix copy-paste typo
Aki Niemi [Sat, 15 May 2010 07:35:44 +0000 (10:35 +0300)]
Fix copy-paste typo

14 years agoAdd proper debug configuration to isimodem SMS
Aki Niemi [Sat, 15 May 2010 07:23:24 +0000 (10:23 +0300)]
Add proper debug configuration to isimodem SMS

14 years agoAdd SCA query and setter to isimodem SMS driver
Aki Niemi [Sat, 15 May 2010 07:23:03 +0000 (10:23 +0300)]
Add SCA query and setter to isimodem SMS driver

14 years agoAdd missing SIM codepoints
Aki Niemi [Sat, 15 May 2010 07:19:28 +0000 (10:19 +0300)]
Add missing SIM codepoints

14 years agoRefactor isimodem CBS driver
Aki Niemi [Fri, 14 May 2010 14:04:54 +0000 (17:04 +0300)]
Refactor isimodem CBS driver

14 years agoFix CBS routing request failure reporting
Aki Niemi [Fri, 14 May 2010 13:28:17 +0000 (16:28 +0300)]
Fix CBS routing request failure reporting

14 years agoAdd isimodem support for MO and MT SMS
Aki Niemi [Fri, 14 May 2010 13:45:48 +0000 (16:45 +0300)]
Add isimodem support for MO and MT SMS

14 years agoAdd missing SMS ISI codepoints
Aki Niemi [Fri, 14 May 2010 13:45:09 +0000 (16:45 +0300)]
Add missing SMS ISI codepoints

14 years agogisi: Add support for NTF requests
Aki Niemi [Fri, 14 May 2010 13:44:48 +0000 (16:44 +0300)]
gisi: Add support for NTF requests

Notify requests are requests sent by ISA servers towards clients. They
are identical to indications in that no response is necessary, but
different in that subscription is done not using the mechanism used
for indications, but out-of-band. Typically routing for notify
requests is enabled using a request-response pair.

14 years agogisi: Return negative errnos
Aki Niemi [Fri, 14 May 2010 13:34:00 +0000 (16:34 +0300)]
gisi: Return negative errnos

14 years agogisi: Fix typo in documentation
Aki Niemi [Fri, 14 May 2010 13:33:13 +0000 (16:33 +0300)]
gisi: Fix typo in documentation

14 years agogisi: Add debugging support for requests
Aki Niemi [Fri, 14 May 2010 13:32:52 +0000 (16:32 +0300)]
gisi: Add debugging support for requests

14 years agostkutil: reorder command struct order
Denis Kenzior [Thu, 13 May 2010 20:36:35 +0000 (15:36 -0500)]
stkutil: reorder command struct order

14 years agotest-stk: Add test for timer management parser
Yang Gu [Thu, 13 May 2010 10:48:44 +0000 (18:48 +0800)]
test-stk: Add test for timer management parser

14 years agostkutil: Add timer management command parser
Yang Gu [Thu, 13 May 2010 10:48:43 +0000 (18:48 +0800)]
stkutil: Add timer management command parser

14 years agotest-stk: Add test for get reader status parser
Yang Gu [Thu, 13 May 2010 10:48:42 +0000 (18:48 +0800)]
test-stk: Add test for get reader status parser

14 years agostkutil: Add get reader status command parser
Yang Gu [Thu, 13 May 2010 10:48:41 +0000 (18:48 +0800)]
stkutil: Add get reader status command parser

14 years agostkutil: Add power on card command parser
Yang Gu [Thu, 13 May 2010 10:48:40 +0000 (18:48 +0800)]
stkutil: Add power on card command parser

14 years agostkutil: Add power off card command parser
Yang Gu [Thu, 13 May 2010 10:48:39 +0000 (18:48 +0800)]
stkutil: Add power off card command parser

14 years agostkutil: Minor style issues and a typo
Denis Kenzior [Thu, 13 May 2010 20:31:21 +0000 (15:31 -0500)]
stkutil: Minor style issues and a typo

14 years agotest-stk: Add test for perform card apdu parser
Yang Gu [Thu, 13 May 2010 10:48:38 +0000 (18:48 +0800)]
test-stk: Add test for perform card apdu parser

14 years agostkutil: Add perform card apdu command parser
Yang Gu [Thu, 13 May 2010 10:48:37 +0000 (18:48 +0800)]
stkutil: Add perform card apdu command parser

14 years agotest-stkutil: Add test for event list parser
Yang Gu [Thu, 13 May 2010 10:48:36 +0000 (18:48 +0800)]
test-stkutil: Add test for event list parser

14 years agostkutil: Add event list command parser
Yang Gu [Thu, 13 May 2010 10:48:35 +0000 (18:48 +0800)]
stkutil: Add event list command parser

14 years agostyle: Whitespace errors
Denis Kenzior [Thu, 13 May 2010 18:55:35 +0000 (13:55 -0500)]
style: Whitespace errors

14 years agotest-stk: Add test for provide local info parser
Yang Gu [Thu, 13 May 2010 10:48:34 +0000 (18:48 +0800)]
test-stk: Add test for provide local info parser

14 years agostkutil: Add provide local info command parser
Yang Gu [Thu, 13 May 2010 10:48:33 +0000 (18:48 +0800)]
stkutil: Add provide local info command parser

14 years agotest-stkutil: Add test for polling off parser
Yang Gu [Thu, 13 May 2010 10:48:32 +0000 (18:48 +0800)]
test-stkutil: Add test for polling off parser

14 years agostkutil: Add polling off proactive command parser
Yang Gu [Thu, 13 May 2010 10:48:31 +0000 (18:48 +0800)]
stkutil: Add polling off proactive command parser

14 years agotest-stkutil: file_list instead of fl is better
Denis Kenzior [Thu, 13 May 2010 18:51:50 +0000 (13:51 -0500)]
test-stkutil: file_list instead of fl is better

14 years agostkutil: file_list instead of fl is better
Denis Kenzior [Thu, 13 May 2010 18:51:38 +0000 (13:51 -0500)]
stkutil: file_list instead of fl is better

14 years agotest-stkutil: Add test for refresh parser
Yang Gu [Thu, 13 May 2010 10:48:30 +0000 (18:48 +0800)]
test-stkutil: Add test for refresh parser

14 years agostkutil: Add refresh proactive command parser
Yang Gu [Thu, 13 May 2010 10:48:29 +0000 (18:48 +0800)]
stkutil: Add refresh proactive command parser

14 years agotest-stkutil: Add unit test for setup call parser
Yang Gu [Thu, 13 May 2010 10:48:28 +0000 (18:48 +0800)]
test-stkutil: Add unit test for setup call parser

14 years agostkutil: Add setup call proactive command parser
Yang Gu [Thu, 13 May 2010 10:48:27 +0000 (18:48 +0800)]
stkutil: Add setup call proactive command parser

14 years agostk: Adjust the sequence of dataobj
Yang Gu [Thu, 13 May 2010 10:48:26 +0000 (18:48 +0800)]
stk: Adjust the sequence of dataobj

14 years agotest-stkutil: Refactor test for send sms parser
Yang Gu [Thu, 13 May 2010 10:48:25 +0000 (18:48 +0800)]
test-stkutil: Refactor test for send sms parser

14 years agotest-stkutil: Use dedicated functions to check
Yang Gu [Thu, 13 May 2010 10:48:24 +0000 (18:48 +0800)]
test-stkutil: Use dedicated functions to check

14 years agotest-stkutil: Handle NULL strings
Denis Kenzior [Thu, 13 May 2010 18:43:41 +0000 (13:43 -0500)]
test-stkutil: Handle NULL strings

g_str_equal does not handle NULL strings

14 years agostkutil: Refactor parse_list into parse_item_list
Denis Kenzior [Thu, 13 May 2010 18:43:16 +0000 (13:43 -0500)]
stkutil: Refactor parse_list into parse_item_list

Makes the code much easier to follow

14 years agotest-stkutil: Add test for select item parser
Yang Gu [Thu, 13 May 2010 10:48:23 +0000 (18:48 +0800)]
test-stkutil: Add test for select item parser

14 years agostkutil: Add select item proactive command parser
Yang Gu [Thu, 13 May 2010 10:48:22 +0000 (18:48 +0800)]
stkutil: Add select item proactive command parser

14 years agotest-stkutil: Add test for setup menu parser
Yang Gu [Thu, 13 May 2010 10:48:21 +0000 (18:48 +0800)]
test-stkutil: Add test for setup menu parser

14 years agostkutil: Add setup menu proactive command parse
Yang Gu [Thu, 13 May 2010 10:48:19 +0000 (18:48 +0800)]
stkutil: Add setup menu proactive command parse

14 years agostyle: remove extra whitespace
Yang Gu [Thu, 13 May 2010 10:48:19 +0000 (18:48 +0800)]
style: remove extra whitespace

14 years agostkutil: item objects can be NULL
Yang Gu [Thu, 13 May 2010 10:48:19 +0000 (18:48 +0800)]
stkutil: item objects can be NULL

ETSI 102.223 doesn't mention that alpha id objects can be NULL, however
such objects exist in the 102.384 test specification.

14 years agostkutil: alpha id objects can be NULL
Yang Gu [Thu, 13 May 2010 10:48:19 +0000 (18:48 +0800)]
stkutil: alpha id objects can be NULL

ETSI 102.223 doesn't mention that alpha id objects can be NULL, however
such objects exist in the 102.384 test specification.

14 years agosimutil: Add comprehension tlv copy
Yang Gu [Thu, 13 May 2010 10:48:19 +0000 (18:48 +0800)]
simutil: Add comprehension tlv copy

Can be used to save the state of the current iterator and 'peek' ahead.

14 years agotest-stkutil: Add test for poll interval parser
Yang Gu [Thu, 13 May 2010 10:48:19 +0000 (18:48 +0800)]
test-stkutil: Add test for poll interval parser

14 years agostk: Add poll interval proactive command parser
Yang Gu [Thu, 13 May 2010 10:48:18 +0000 (18:48 +0800)]
stk: Add poll interval proactive command parser

14 years agombm: Check there's a SIM card inserted.
Andrzej Zaborowski [Wed, 12 May 2010 01:22:38 +0000 (03:22 +0200)]
mbm: Check there's a SIM card inserted.

14 years agombm: Register sim toolkit atom in mbm plugin.
Andrzej Zaborowski [Wed, 12 May 2010 01:22:03 +0000 (03:22 +0200)]
mbm: Register sim toolkit atom in mbm plugin.

14 years agombm: Simplify STKR callback logic
Denis Kenzior [Wed, 12 May 2010 18:42:19 +0000 (13:42 -0500)]
mbm: Simplify STKR callback logic

14 years agombm: Simplify STKE logic
Denis Kenzior [Wed, 12 May 2010 18:36:07 +0000 (13:36 -0500)]
mbm: Simplify STKE logic

We shouldn't use CALLBACK_WITH_FAILURE unless we can't parse the
response from the modem.  This most likely indicates an integration
error.

14 years agombm: NULL check on a g_free is not necessary
Denis Kenzior [Wed, 12 May 2010 18:09:08 +0000 (13:09 -0500)]
mbm: NULL check on a g_free is not necessary

This is a change from previously accepted practice

14 years agombm: Few style issues with indentation
Denis Kenzior [Wed, 12 May 2010 18:08:35 +0000 (13:08 -0500)]
mbm: Few style issues with indentation

14 years agombm: Add STK driver.
Andrzej Zaborowski [Wed, 12 May 2010 01:21:17 +0000 (03:21 +0200)]
mbm: Add STK driver.

14 years agoatmodem: Pass allowed response prefixes to gatchat
Andrzej Zaborowski [Wed, 12 May 2010 01:20:53 +0000 (03:20 +0200)]
atmodem: Pass allowed response prefixes to gatchat

Not doing this creates a race condition where any notification
comming in in the middle of a sequence of commands may be counted
as a response to one of the commands and get lost.

14 years agostkutil: Parse cdma tpdu in send sms parser
Yang Gu [Mon, 10 May 2010 10:38:59 +0000 (18:38 +0800)]
stkutil: Parse cdma tpdu in send sms parser

14 years agostkutil: Don't use escaped strings
Denis Kenzior [Tue, 11 May 2010 17:29:11 +0000 (12:29 -0500)]
stkutil: Don't use escaped strings

In general this is bad style, using concatentated strings ala "" "" is
better.

14 years agotest-stkutil: Add unit test for play tone parser
Yang Gu [Mon, 10 May 2010 10:38:51 +0000 (18:38 +0800)]
test-stkutil: Add unit test for play tone parser

14 years agostkutil: Refactor parser for tone objects
Yang Gu [Mon, 10 May 2010 10:38:50 +0000 (18:38 +0800)]
stkutil: Refactor parser for tone objects