platform/upstream/gstreamer.git
10 years agogl/color: remove if statement with no effect
Matthew Waters [Sat, 12 Apr 2014 08:24:43 +0000 (18:24 +1000)]
gl/color: remove if statement with no effect

Coverity 1199698

10 years agogl/color: pass large value by reference
Matthew Waters [Sat, 12 Apr 2014 08:16:29 +0000 (18:16 +1000)]
gl/color: pass large value by reference

Coverity 1199700

10 years agosrtpdec: fix assertion checking ssrc from rtcp packets
Aleix Conchillo Flaqué [Wed, 2 Apr 2014 19:59:58 +0000 (12:59 -0700)]
srtpdec: fix assertion checking ssrc from rtcp packets

rtcp_buffer_get_ssrc is called even with RTP buffers. this means we
might end up with an exception and not find any valid RTCP packet type
and thus hit GST_RTCP_TYPE_INVALID. we now take care of this.

https://bugzilla.gnome.org/show_bug.cgi?id=727512

10 years agojp2kdecimator: fix maybe-uninitialized compiler error
Andoni Morales Alastruey [Fri, 11 Apr 2014 10:29:17 +0000 (12:29 +0200)]
jp2kdecimator: fix maybe-uninitialized compiler error

10 years agompegtsmux: Remove unneeded unref
Edward Hervey [Fri, 11 Apr 2014 09:34:26 +0000 (11:34 +0200)]
mpegtsmux: Remove unneeded unref

packet_buffer has already been cleared in all code paths leading
to this point.

CID #1199696

10 years agodvbsrc: Handle symbols added in minor version 7 and 8
Edward Hervey [Fri, 11 Apr 2014 06:39:29 +0000 (08:39 +0200)]
dvbsrc: Handle symbols added in minor version 7 and 8

Some symbols were re-defined in minor v8 (GO TEAM BACKWARDS COMPATIBLE!)

Some symbols were added in minor v7

https://bugzilla.gnome.org/show_bug.cgi?id=727977

10 years agogl/mem: cache the stride/unpack length for upload
Matthew Waters [Fri, 11 Apr 2014 07:24:39 +0000 (17:24 +1000)]
gl/mem: cache the stride/unpack length for upload

10 years agogl/color: explicitly map the buffers we are copying into
Matthew Waters [Fri, 11 Apr 2014 07:23:32 +0000 (17:23 +1000)]
gl/color: explicitly map the buffers we are copying into

Otherwise it may not be downloaded at all.

10 years agodvbsrc: Add comment with all DVB API v5 minor changes
Edward Hervey [Fri, 11 Apr 2014 06:16:01 +0000 (08:16 +0200)]
dvbsrc: Add comment with all DVB API v5 minor changes

There wasn't a definite list anyway, so I just dove in the kernel
and extract all that information.

10 years agogl/color: cache the temporary textures
Matthew Waters [Fri, 11 Apr 2014 06:09:09 +0000 (16:09 +1000)]
gl/color: cache the temporary textures

10 years agogl/mem: provide defines for tokens not defined in GLES2/ancient platforms
Matthew Waters [Fri, 11 Apr 2014 01:04:43 +0000 (11:04 +1000)]
gl/mem: provide defines for tokens not defined in GLES2/ancient platforms

10 years agogl: fixup incorrect number of arguments
Matthew Waters [Fri, 11 Apr 2014 01:03:19 +0000 (11:03 +1000)]
gl: fixup incorrect number of arguments

10 years agogl: fix incorrect usage of g_return_if_fail
Matthew Waters [Fri, 11 Apr 2014 00:55:21 +0000 (10:55 +1000)]
gl: fix incorrect usage of g_return_if_fail

10 years agogl/mem: allocate the memory per plane
Matthew Waters [Wed, 2 Apr 2014 06:43:52 +0000 (17:43 +1100)]
gl/mem: allocate the memory per plane

This patch provides the basic infrastructure required for this.
Upload and Download has been ported to this.

Has the nice effect of allowing GstGLMemory to be our
refcounted texture object for any texture type (not just RGBA).

Should not lose any features/video formats.

10 years agogl/eglimage: #if 0 unused code
Matthew Waters [Tue, 1 Apr 2014 04:10:05 +0000 (15:10 +1100)]
gl/eglimage: #if 0 unused code

10 years agogl: add colorconvert object that converts between color spaces/formats
Matthew Waters [Tue, 1 Apr 2014 02:30:51 +0000 (13:30 +1100)]
gl: add colorconvert object that converts between color spaces/formats

Currently used by both upload and download objects separately.

10 years agofaac: fix faac API error checking
Vincent Penquerc'h [Thu, 10 Apr 2014 16:55:21 +0000 (17:55 +0100)]
faac: fix faac API error checking

Coverity 1139790

10 years agodashdemux: do not ignore failure to register typefinder
Vincent Penquerc'h [Thu, 10 Apr 2014 16:52:02 +0000 (17:52 +0100)]
dashdemux: do not ignore failure to register typefinder

Coverity 1139629

10 years agodashdemux: fix time leak
Vincent Penquerc'h [Thu, 10 Apr 2014 16:48:03 +0000 (17:48 +0100)]
dashdemux: fix time leak

Coverity 1147016

10 years agodashdemux: remove dead code and variable
Vincent Penquerc'h [Thu, 10 Apr 2014 16:44:14 +0000 (17:44 +0100)]
dashdemux: remove dead code and variable

A recent commit made stream not able to be NULL, ending up with
a flag being always set to FALSE when it matters.

Coverity 1146968, 1147012

10 years agocurl: remove unneeded NULL check
Vincent Penquerc'h [Thu, 10 Apr 2014 16:37:22 +0000 (17:37 +0100)]
curl: remove unneeded NULL check

We just checked for NULL and allocated if it was. And glib aborts
if it can't allocate, I'm told.

Coverity 1139841

10 years agocurl: remove duplicate assignment
Vincent Penquerc'h [Thu, 10 Apr 2014 16:33:55 +0000 (17:33 +0100)]
curl: remove duplicate assignment

Coverity 1197708

10 years agohlsdemux: Also update the sequence position when updating non-live playlists
Sebastian Dröge [Thu, 10 Apr 2014 14:53:42 +0000 (16:53 +0200)]
hlsdemux: Also update the sequence position when updating non-live playlists

10 years agohlsdemux: Try reloading the playlist first if downloading a fragment fails
Sebastian Dröge [Thu, 10 Apr 2014 12:59:57 +0000 (14:59 +0200)]
hlsdemux: Try reloading the playlist first if downloading a fragment fails

But only add this for non-live playlists. For live playlists we already
have another thread that is periodically updating playlists.

Reason for this is that sometimes downloading a fragment can fail because
the URIs have changed or expired since last time.

10 years agohlsdemux: When updating a non-live playlist make sure to find the current sequence...
Sebastian Dröge [Thu, 10 Apr 2014 12:46:01 +0000 (14:46 +0200)]
hlsdemux: When updating a non-live playlist make sure to find the current sequence by time

Sequence numbers in different playlists are not guaranteed to be the same for the
same position, e.g. fragments could have different durations in different playlists.

In theory we should do exactly the same for live playlists, but unfortunately we can't
because doing this kind of seeking requires the complete playlist since we started
playback. For live playlists the server is however dropping fragments in the beginning
over time and we have no absolute time references.

10 years agosmoothstreaming: avoid using an uninitialized manifest
Vincent Penquerc'h [Wed, 9 Apr 2014 16:28:49 +0000 (17:28 +0100)]
smoothstreaming: avoid using an uninitialized manifest

If we did not set the manifest yet, early out in the seeking query.

Coverity 1139737

10 years agoh264parse: Set framerate even for interlaced videos
Thibault Saunier [Mon, 17 Mar 2014 15:39:42 +0000 (16:39 +0100)]
h264parse: Set framerate even for interlaced videos

Co-Authored by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>

https://bugzilla.gnome.org/show_bug.cgi?id=726752

10 years agompegts: add atsc terrestrial virtual channel table
Stefan Ringel [Wed, 9 Apr 2014 08:04:46 +0000 (10:04 +0200)]
mpegts: add atsc terrestrial virtual channel table

https://bugzilla.gnome.org/show_bug.cgi?id=727460

10 years agoliveadder: fix memory leak querying sink caps
Santiago Carot-Nemesio [Wed, 9 Apr 2014 13:07:19 +0000 (15:07 +0200)]
liveadder: fix memory leak querying sink caps

https://bugzilla.gnome.org/show_bug.cgi?id=727894

10 years agohlssink: catch failure to write playlist file
Vincent Penquerc'h [Wed, 9 Apr 2014 17:44:38 +0000 (18:44 +0100)]
hlssink: catch failure to write playlist file

Coverity 1139613

10 years agokate: fix implicit promotion to signed int breaking on largeish inputs
Vincent Penquerc'h [Wed, 9 Apr 2014 17:31:31 +0000 (18:31 +0100)]
kate: fix implicit promotion to signed int breaking on largeish inputs

Coverity 1139858, 1139857

10 years agoladspa: remove duplicate assignment
Vincent Penquerc'h [Wed, 9 Apr 2014 17:16:52 +0000 (18:16 +0100)]
ladspa: remove duplicate assignment

Coverity 1139706

10 years agomimdec: fix open error checking
Vincent Penquerc'h [Wed, 9 Apr 2014 17:12:58 +0000 (18:12 +0100)]
mimdec: fix open error checking

Coverity 206364

10 years agoschrodec: remove unnecessary check
Vincent Penquerc'h [Wed, 9 Apr 2014 16:37:41 +0000 (17:37 +0100)]
schrodec: remove unnecessary check

The tag was dereferenced earier. From the libschroedinger code,
it's not obvious to see whether tag and frame would be NULL at
the same time. I think is likely that both will be non NULL
here, but that's not certain. Additional tests may be needed
to avoid dereferencing tag and/or frame, but what to do if
only one is NULL isn't obvious, as the _get_tag function does
transfer ownership so isn't undoable.

Coverity 1139850

10 years agosmoothstreaming: remove unnecessary check
Vincent Penquerc'h [Wed, 9 Apr 2014 16:10:06 +0000 (17:10 +0100)]
smoothstreaming: remove unnecessary check

The function is static, the only call site passes a non NULL
pointer, and the pointer is dereferenced before anyway.

Coverity 1139839

10 years agosrtp: remove dead assignment
Vincent Penquerc'h [Wed, 9 Apr 2014 15:55:30 +0000 (16:55 +0100)]
srtp: remove dead assignment

Coverity 1197707

10 years agompegts: fix sdt length check
Vincent Penquerc'h [Wed, 9 Apr 2014 14:54:18 +0000 (15:54 +0100)]
mpegts: fix sdt length check

It was originally test for 9 bytes (as the comment says) and was
rewritten buggily. So rewrite it a third way, which is now
hopefully consistent with the original and the comment, while
being more sense-making to humans.

Coverity 1139654

10 years agoRevert "tsmux: catch alloc failure"
Vincent Penquerc'h [Wed, 9 Apr 2014 15:00:24 +0000 (16:00 +0100)]
Revert "tsmux: catch alloc failure"

Turns out glib aborts on allocation failure, so this is pointless.
We'll just ignore Coverity warnings on such constructs.

This reverts commit d347809a82e24057302f948269392e76aaacea10.

10 years agompegts: turns out glib aborts on allocation failure
Vincent Penquerc'h [Wed, 9 Apr 2014 14:58:37 +0000 (15:58 +0100)]
mpegts: turns out glib aborts on allocation failure

So this is actually pointless. We'll just have to ignore
Coverity moaning on those.

Revert "mpegts: test for allocation failure"

This reverts commit 224cb81b8fcbf03df5e07f045ecb9ecf64189400.

10 years agompegts: test for allocation failure
Vincent Penquerc'h [Wed, 9 Apr 2014 14:44:10 +0000 (15:44 +0100)]
mpegts: test for allocation failure

While it's unlikely to get there, it silences the coverity warning
on the error code path that we test for NULL before freeing, when
all branches there are from locations where pmt cannot be NULL,
and removing the NULL check makes the code more vulnerable to a
hypothetical future branch from somewhere where it can be.

Coverity 1139852

10 years agoasfmux: remove unnecessary test
Vincent Penquerc'h [Wed, 9 Apr 2014 14:41:11 +0000 (15:41 +0100)]
asfmux: remove unnecessary test

We've been dereferencing that object like there's no tomorrow
in the code just before that.

Coverity 206369

10 years agoasfmux: remove stray gst_buffer_unmap on error path
Vincent Penquerc'h [Wed, 9 Apr 2014 14:37:55 +0000 (15:37 +0100)]
asfmux: remove stray gst_buffer_unmap on error path

A previous commit removed the map, and the unmap on the main
code path, but not the one on the error path.

Coverity 1139930

10 years agoautoconvert: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 14:28:05 +0000 (15:28 +0100)]
autoconvert: remove dead code

Those events were previously taken from a cached events list,
which was removed during the port to 0.11, but this bit stayed.

Coverity 1139684

10 years agocamerabin2: remove unneeded check
Vincent Penquerc'h [Wed, 9 Apr 2014 14:24:13 +0000 (15:24 +0100)]
camerabin2: remove unneeded check

A message may not be NULL in the message handling function
(and nothing there sets it to NULL).

Coverity 1139848

10 years agocompare: special case empty regions with 1 SSIM to avoid dividing by 0
Vincent Penquerc'h [Wed, 9 Apr 2014 14:18:22 +0000 (15:18 +0100)]
compare: special case empty regions with 1 SSIM to avoid dividing by 0

Coverity 1139689, 1139688

10 years agointer: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 14:09:25 +0000 (15:09 +0100)]
inter: remove dead code

Coverity 1139666

10 years agoliveadder: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 14:03:45 +0000 (15:03 +0100)]
liveadder: remove dead code

From the 0.11 port

Coverity 1139676

10 years agoresindvd: avoid crashing in pathological case
Vincent Penquerc'h [Wed, 9 Apr 2014 13:37:48 +0000 (14:37 +0100)]
resindvd: avoid crashing in pathological case

When we'd see an unknown stream type, then a SDDS stream.
Then we'd get to the end of the switch with a NULL temp stream
pointer, and dereference it.

Coverity 1139708

10 years agompegtsdemux: catch prev-not-found when inserting in the group list
Vincent Penquerc'h [Wed, 9 Apr 2014 13:13:46 +0000 (14:13 +0100)]
mpegtsdemux: catch prev-not-found when inserting in the group list

While this probably should never happen if callers are well behaved,
this avoids a crash if it does. With a warning about it. Unsure if
it'd be better to not add at all, but it should not happen...

Coverity 1139713

10 years agompegtsmux: guard against _dispose being called mutiple times
Vincent Penquerc'h [Wed, 9 Apr 2014 12:51:41 +0000 (13:51 +0100)]
mpegtsmux: guard against _dispose being called mutiple times

_dispose calls _reset, so we need to make sure _reset handles
already NULLed fields.

Coverity 1139843

10 years agotsmux: prevent possible double free on error path
Vincent Penquerc'h [Wed, 9 Apr 2014 12:43:10 +0000 (13:43 +0100)]
tsmux: prevent possible double free on error path

Spotted while looking at a Coverity issue in the area.

10 years agotsmux: catch alloc failure
Vincent Penquerc'h [Wed, 9 Apr 2014 12:41:35 +0000 (13:41 +0100)]
tsmux: catch alloc failure

While it will probably not trigger, it should silence a Coverity
warning about the fail code path testing for NULLness before
freeing, where the buffer was already dereferenced. It seems
safest to keep that test, in case future goto fail statements
happen to have a NULL buffer there.

Coverity 1139851

10 years agodecklink: initialize priv to NULL
Vincent Penquerc'h [Wed, 9 Apr 2014 10:43:23 +0000 (11:43 +0100)]
decklink: initialize priv to NULL

While the code that creates the object sets priv to some existing
pointer after new, this ensures any future new not doing this will
hit the various priv!=NULL asserts in the code.

Coverity 1139935

10 years agospeed: make duration query able to convert bytes to time
Vincent Penquerc'h [Wed, 9 Apr 2014 10:15:10 +0000 (11:15 +0100)]
speed: make duration query able to convert bytes to time

It was only querying in time, but then trying to use dead bytes
to time conversion code.

Coverity 1139677

10 years agomfc: fix left crop change test
Vincent Penquerc'h [Wed, 9 Apr 2014 10:04:32 +0000 (11:04 +0100)]
mfc: fix left crop change test

It was testing a noop

Coverity 1139643

10 years agoopus: add missing va_end in variadic function
Vincent Penquerc'h [Wed, 9 Apr 2014 10:02:00 +0000 (11:02 +0100)]
opus: add missing va_end in variadic function

Coverity 1139944

10 years agoshm: remove dead code
Vincent Penquerc'h [Wed, 9 Apr 2014 10:00:22 +0000 (11:00 +0100)]
shm: remove dead code

Coverity 1139683

10 years agomfc: reset "in use" flag on failure to initialize
Vincent Penquerc'h [Wed, 9 Apr 2014 09:56:16 +0000 (10:56 +0100)]
mfc: reset "in use" flag on failure to initialize

10 years agomfc: test for allocation failure before dereferencing
Vincent Penquerc'h [Wed, 9 Apr 2014 09:55:46 +0000 (10:55 +0100)]
mfc: test for allocation failure before dereferencing

Coverity 1139849

10 years agompeg2enc: remove dead assignment
Vincent Penquerc'h [Wed, 9 Apr 2014 09:33:10 +0000 (10:33 +0100)]
mpeg2enc: remove dead assignment

Coverity 1139829

10 years agogl: pass large structure by const pointer, not value
Vincent Penquerc'h [Wed, 9 Apr 2014 09:28:46 +0000 (10:28 +0100)]
gl: pass large structure by const pointer, not value

Avoids large pointless memcpy.

Coverity 206236, 206237

10 years agocamerabin: add any feature to viewfinderbin static pad template
Mohammed Sameer [Tue, 8 Apr 2014 18:39:20 +0000 (21:39 +0300)]
camerabin: add any feature to viewfinderbin static pad template

https://bugzilla.gnome.org/show_bug.cgi?id=727857

10 years agocamerabin: report an error if we fail to link vfsrc and viewfinder queue
Mohammed Sameer [Tue, 8 Apr 2014 17:54:26 +0000 (20:54 +0300)]
camerabin: report an error if we fail to link vfsrc and viewfinder queue

https://bugzilla.gnome.org/show_bug.cgi?id=727855

10 years agod3dvideosink: post proper error message when window disappears
Tim-Philipp Müller [Tue, 8 Apr 2014 16:45:46 +0000 (17:45 +0100)]
d3dvideosink: post proper error message when window disappears

10 years agoflite: fix off by one in channel mask building
Vincent Penquerc'h [Tue, 8 Apr 2014 16:34:13 +0000 (17:34 +0100)]
flite: fix off by one in channel mask building

The first loop would shift 1 by 64, which is either undefined
or implementation defined, instead of clearing the top bit.

Coverity 1197691

10 years agohls: restore NULL test mistakenly removed
Vincent Penquerc'h [Tue, 8 Apr 2014 16:10:27 +0000 (17:10 +0100)]
hls: restore NULL test mistakenly removed

Thanks to tpm for point out I'm an idiot.

10 years agohls: only set DISCONT flag on a valid buffer
Vincent Penquerc'h [Tue, 8 Apr 2014 15:53:54 +0000 (16:53 +0100)]
hls: only set DISCONT flag on a valid buffer

Recent refactoring causes this code to be called with either a NULL
fragment, or a non NULL fragment. In the former case, we don't have
a buffer. In the latter case, the original code dealing with DISCONT
assumed the buffer was valid. Testing for a NULL buffer here thus
does not seem to change the intent, and fixes:

Coverity 1195147

10 years agomxfdemux: guard against NULL material track
Tim-Philipp Müller [Tue, 8 Apr 2014 15:53:41 +0000 (16:53 +0100)]
mxfdemux: guard against NULL material track

Just to be on the safe side.

10 years agohls: bring NULL test before dereference
Vincent Penquerc'h [Tue, 8 Apr 2014 15:46:56 +0000 (16:46 +0100)]
hls: bring NULL test before dereference

Coverity 1195168

10 years agogl: test for frame NULLness before dereferencing it
Vincent Penquerc'h [Tue, 8 Apr 2014 15:23:50 +0000 (16:23 +0100)]
gl: test for frame NULLness before dereferencing it

Coverity 1195172, 1195171

10 years agodvbsuboverlay: Avoid infinite loops on short data
Jan Schmidt [Tue, 8 Apr 2014 14:44:08 +0000 (00:44 +1000)]
dvbsuboverlay: Avoid infinite loops on short data

10 years agodvb: fix compilation
Tim-Philipp Müller [Tue, 8 Apr 2014 15:09:16 +0000 (16:09 +0100)]
dvb: fix compilation

10 years agogl: fix leaks
Vincent Penquerc'h [Tue, 8 Apr 2014 14:54:01 +0000 (15:54 +0100)]
gl: fix leaks

As the relevant variables are initialized to 0/NULL, we can loop
over the full range and make sure we free partial allocations
when an error happens partway through initialization.

10 years agodvb: reject too long socket paths
Vincent Penquerc'h [Tue, 8 Apr 2014 14:26:04 +0000 (15:26 +0100)]
dvb: reject too long socket paths

Coverity 206004

10 years agomxfdemux: implement simple KEY_UNIT seeking
Tim-Philipp Müller [Tue, 8 Apr 2014 13:33:06 +0000 (14:33 +0100)]
mxfdemux: implement simple KEY_UNIT seeking

If a KEY_UNIT seek was requested, adjust segment
start to position of the key frame.

10 years agoresindvd: guard against overflow in audio subtitle streams
Vincent Penquerc'h [Tue, 8 Apr 2014 13:24:31 +0000 (14:24 +0100)]
resindvd: guard against overflow in audio subtitle streams

Turns out there was the same issue as with subtitles.

There is space for a single audio stream, but up to 255
may be used based on a uint8_t value in a struct, which may
or may not be read from the (untrusted) data.
A comment in ifo_types.h says this value is either 0 or 1, so
we can ensure this here without drawbacks.

Coverity 1139585

10 years agoresindvd: guard against overflow in menu subtitle streams
Vincent Penquerc'h [Tue, 8 Apr 2014 13:19:29 +0000 (14:19 +0100)]
resindvd: guard against overflow in menu subtitle streams

There is space for a single subtitle stream, but up to 255
may be used based on a uint8_t value in a struct, which may
or may not be read from the (untrusted) data.
A comment in ifo_types.h says this value is either 0 or 1, so
we can ensure this here without drawbacks.

Coverity 1139586

10 years agomxfdemux: fix seeking, send data starting from a key unit
Tim-Philipp Müller [Tue, 8 Apr 2014 12:26:49 +0000 (13:26 +0100)]
mxfdemux: fix seeking, send data starting from a key unit

Fixes multiple seeking issues. When doing ACCURATE or normal
non-KEYUNIT seeks, mxfdemux would just send data from the
edit unit that covered the seek position, whether that's
a keyframe or not. Decoders would only output things from
the next keyframe then, which means there's a gap between
the start of the segment and the first decoded data in
some cases. In combination with gst-editing-services this
might result in a frozen picture for the duration of that
gap at the beginning (if videorate fixes up the first
buffer's start timestamp to cover the entire gap), or
a black frame (if no videorate is used and videomixer
fills the gap). Also fixes A/V sync issue when requesting
a KEYUNIT seek.

10 years agodtsdec: fix buffer overflows
Vincent Penquerc'h [Tue, 8 Apr 2014 11:37:30 +0000 (12:37 +0100)]
dtsdec: fix buffer overflows

Channels can be up to 7. Also add a guard in case more can be
returned in the future.

Coverity 1139820, 1139821

10 years agodirectsoundsrc: Fix critical due to missing debug category initialization
Xavi Artigas [Tue, 8 Apr 2014 11:20:54 +0000 (13:20 +0200)]
directsoundsrc: Fix critical due to missing debug category initialization

https://bugzilla.gnome.org/show_bug.cgi?id=727812

10 years agofestival: fix fd leak
Vincent Penquerc'h [Tue, 8 Apr 2014 11:20:40 +0000 (12:20 +0100)]
festival: fix fd leak

Coverity 1139831

10 years agospeed: Clarify passthrough in switch statement
Edward Hervey [Tue, 8 Apr 2014 09:26:38 +0000 (11:26 +0200)]
speed: Clarify passthrough in switch statement

We do want the caps event to be forwarded downstream

CID #1139754

10 years agosoundtouch: Add missing break in switch
Edward Hervey [Tue, 8 Apr 2014 09:23:50 +0000 (11:23 +0200)]
soundtouch: Add missing break in switch

Whoops, modifying the pitch when modifying the output rate ...

CID #1139749

10 years agorsvg: Add missing break in switch statement
Edward Hervey [Tue, 8 Apr 2014 09:21:44 +0000 (11:21 +0200)]
rsvg: Add missing break in switch statement

This wasn't fatal before (worst case it would clear an already empty
adapter).

CID #1139758

10 years agompeg2enc: Add missing break in switch
Edward Hervey [Tue, 8 Apr 2014 09:20:29 +0000 (11:20 +0200)]
mpeg2enc: Add missing break in switch

QUERY_CAPS is fully handled, we don't need to passthrough to the default
handler.

CID #1139756

10 years agobz2: Initialize variables
Edward Hervey [Tue, 8 Apr 2014 07:51:08 +0000 (09:51 +0200)]
bz2: Initialize variables

There is a small chance that we might end up in the done step without
having any output available.

Furthermore, when going through not_ready, we need to ensure gst_buffer_unmap
has a properly initialized GstMapInfo.

CID #1139923
CID #1139924
CID #1139919
CID #1139920

10 years agocheck: Fix mpegtsmux caps
Edward Hervey [Tue, 8 Apr 2014 05:48:28 +0000 (07:48 +0200)]
check: Fix mpegtsmux caps

Incoming streams need to be parsed. Doesn't fix the test completely though

10 years agompegtsmux: Initialize helper mpegts library
Edward Hervey [Tue, 8 Apr 2014 05:47:15 +0000 (07:47 +0200)]
mpegtsmux: Initialize helper mpegts library

We now use that library, we need to initialize it so that debug
categories (amongst other things) get properly initialized

10 years agomxf: fix stop date parsing using the wrong input
Vincent Penquerc'h [Mon, 7 Apr 2014 12:25:56 +0000 (13:25 +0100)]
mxf: fix stop date parsing using the wrong input

Coverity 1139645

10 years agojp2kdecimator: fix copy/paste errors in expressions
Vincent Penquerc'h [Mon, 7 Apr 2014 12:22:22 +0000 (13:22 +0100)]
jp2kdecimator: fix copy/paste errors in expressions

Correct formulae found in ITU T.800, B.12.1.[345]

Coverity 1139649, 1139650, 1139651

10 years agotests: fix shm test deadlock
Vincent Penquerc'h [Fri, 4 Apr 2014 14:30:20 +0000 (15:30 +0100)]
tests: fix shm test deadlock

The test was not bringing the source back to NULL, so its thread
could start creating a buffer while the pads were being shutdown.

10 years agoglimagesink: Create GL context and set up window from the streaming thread
Sebastian Dröge [Sun, 6 Apr 2014 09:57:12 +0000 (11:57 +0200)]
glimagesink: Create GL context and set up window from the streaming thread

gst_gl_context_create() might need to dispatch some operations to the
application's main thread, and calling this in the change_state function
can cause deadlocks.

10 years agoconfigure: Fix check for iOS for the OpenGL support
Sebastian Dröge [Fri, 4 Apr 2014 07:19:39 +0000 (09:19 +0200)]
configure: Fix check for iOS for the OpenGL support

There is also an i386 version of iOS, which is for the simulator.
Better use our already existing HAVE_IOS check instead of relying
on the host triplet.

10 years agowildmidi: fix possible uninitialized variables
Wim Taymans [Thu, 3 Apr 2014 09:54:41 +0000 (11:54 +0200)]
wildmidi: fix possible uninitialized variables

10 years agompdparse: only add location when node existed
Wim Taymans [Thu, 3 Apr 2014 09:48:07 +0000 (11:48 +0200)]
mpdparse: only add location when node existed

Actually return FALSE when the location node was non-existing
Only add the location node when it existed

10 years agompegtsmux: Require parsed/framed input for most of the supported formats
Sebastian Dröge [Wed, 2 Apr 2014 21:49:37 +0000 (23:49 +0200)]
mpegtsmux: Require parsed/framed input for most of the supported formats

https://bugzilla.gnome.org/show_bug.cgi?id=719519

10 years agod3dvideosink: Only pass a dest rectangle if set, otherwise pass NULL
Sebastian Dröge [Wed, 2 Apr 2014 21:08:36 +0000 (23:08 +0200)]
d3dvideosink: Only pass a dest rectangle if set, otherwise pass NULL

Call with an uninitialized rectangle will cause errors.

https://bugzilla.gnome.org/show_bug.cgi?id=714998

10 years agotests: fix gl unit tests for recent API changes
Tim-Philipp Müller [Wed, 2 Apr 2014 12:48:02 +0000 (13:48 +0100)]
tests: fix gl unit tests for recent API changes

10 years agogl: pass video info's by reference
Matthew Waters [Wed, 2 Apr 2014 12:05:47 +0000 (23:05 +1100)]
gl: pass video info's by reference

10 years agogl: fix array initialization
Matthew Waters [Wed, 2 Apr 2014 12:05:11 +0000 (23:05 +1100)]
gl: fix array initialization