Forest Bond [Fri, 20 May 2011 16:07:05 +0000 (12:07 -0400)]
module-combine-sink: Initialize smoother with offset pa_rtclock_now()
The smoother was being initialized with offset zero, which caused
the sink latency to be unconditionally reported as zero.
Colin Guthrie [Thu, 2 Jun 2011 09:44:21 +0000 (11:44 +0200)]
streams: Fix the actual resampler method shown in debug messages.
Daniel Mack [Fri, 27 May 2011 13:33:17 +0000 (15:33 +0200)]
osx: pass -headerpad_max_install_names to the linker, too
This option won't make it to the actual libtool command which does the
linking when not prefixed with -Wl,
Lu Guanqun [Thu, 26 May 2011 08:49:52 +0000 (16:49 +0800)]
alsa-mixer: Fix the assumption that volume is always positive
Add a variable to track whether the actual volume is set or not.
Suppose this:
min volume: -126 max volume: 0
then when user wants to set some constant volume to -10, it would fail.
While the alsa values are typically positive, some values are "funky"
and have negative values. It is desirable to fix this at the alsa
level so that the numbers are positive, but it's not technically
invalid, and thus we have to support it.
Discussed here:
http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/9832
and
http://thread.gmane.org/gmane.linux.alsa.devel/85459
Arun Raghavan [Sat, 28 May 2011 02:21:35 +0000 (07:51 +0530)]
echo-cancel: Fix a crash is speex cleanup
If module initialisation fails, the speex done() function might try to
free a value that's not been allocated yet. Adding protection for this
condition.
Bart Cerneels [Sat, 28 May 2011 02:27:22 +0000 (07:57 +0530)]
echo-cancel: Fix echo suppression, add some knobs
The echo suppress attenuation value was being incorrectly modified.
Fixed and added 2 arguments to change the attenuation of the residual
echo filter. Default values of the speex preprocessor will be used when
omitted.
Bart Cerneels [Sat, 28 May 2011 02:26:00 +0000 (07:56 +0530)]
echo-cancel: Speex preprocessor has to run *after* the AEC.
This is how it is expected to be run.
Arun Raghavan [Thu, 19 May 2011 07:59:49 +0000 (13:29 +0530)]
echo-cancel: Add speex preprocessing
This allows the selective enabling of speex' preprocessing algorithms
before running the echo-canceller -- for now this includes automatic
gain control, noise suppression and echo suppression. It's all off by
default for now, though at some point in the near future we might want
to enable at least denoising by default.
The denoising works pretty well, though we might want to add a way to
tweak the noise-suppression knob that libspeex provides.
The AGC option is just a stop-gap -- we need a real AGC mechanism that
tweaks the source volume rather than doing this in software.
The speex documentation mentions VAD and dereverb, but it appears that
these are not complete yet.
We don't do all this in a separate module from module-echo-cancel to
avoid the overhead of adding another virtual source. It makes more sense
to make a separate virtual source module that can be used for cases
where preprocessing is useful but AEC is not (for e.g. noise suppression
for fan noise in a recording application).
Another reason to keep this integrated with the AEC module is that the
echo suppression bits use the speex echo canceller state. This does leak
some information about the AEC implementation into module-echo-cancel,
but this is unavoidable.
Arun Raghavan [Fri, 20 May 2011 13:51:02 +0000 (19:21 +0530)]
format: Fix channel map handling
Channel map handling in the extended API was broken. Thanks for Milos_SD
for pointing this out on IRC.
Arun Raghavan [Fri, 20 May 2011 04:31:16 +0000 (10:01 +0530)]
echo-cancel: Remove extraneous debug message
This was making it impossible to run in debug mode with save_aec=1
Arun Raghavan [Sat, 14 May 2011 12:14:23 +0000 (17:44 +0530)]
echo-cancel: Don't overpad variable
The padding was to be 16 bytes, not 16 elements.
Sjoerd Simons [Mon, 16 May 2011 10:00:37 +0000 (10:00 +0000)]
build-sys: Link libpulse directly to libdbus-1 if needed
Linking libpulse with gold or when using ld --no-add-needed fails
as libpulse uses dbus methods directly but isn't explicitly linked to it.
So link to it when needed :)
Colin Guthrie [Mon, 16 May 2011 08:26:32 +0000 (09:26 +0100)]
protocol-native: Fix memory leaks introduced in protocol 21 (passthrough support)
The proplist used may never be freed if an error condition was found with
CHECK_VALIDITY macro and the formats idxset was never freed regardless
of error state.
This change fixes adds a new maco CHECK_VALIDITY_GOTO() which allows
for cleanup to be done before returning.
Colin Guthrie [Sun, 15 May 2011 17:41:31 +0000 (18:41 +0100)]
sink-input: Fix memory leak of proplist when sending format-changed events
Tanu Kaskinen [Sat, 14 May 2011 13:11:25 +0000 (16:11 +0300)]
loopback: Add a modarg for disabling remixing.
Colin Guthrie [Sun, 15 May 2011 14:05:44 +0000 (15:05 +0100)]
bluetooth: Fix early return styling and add missing return value
Thanks to Tanu Kaskinen for pointing out the missing return.
Jyri Sarha [Fri, 8 Apr 2011 14:18:13 +0000 (17:18 +0300)]
suspend-on-idle: Trigger mempool vacuuming
In a setup with one or more filter sinks or sources there is always at
least one stream existing. In such a situation normal mempool
vacuuming never happens. This patch causes suspend-on-idle module to
vacuum memory when ever it notices that all sinks and sources are
suspended. The behavior can be enabled with a module parameter.
Jyri Sarha [Fri, 8 Apr 2011 14:18:12 +0000 (17:18 +0300)]
protocol-native: Stop auto timing updates if connected to suspended sink or source
This quite is an old patch. It was added to N900 to avoid unnecessary
wake-ups when the phone is in power save mode (= blank screen and
no user interaction). In this situation if the user had a browser
window with flash animation open pulseaudio kept waking up every
10 seconds, causing a severe hit to use times.
Anyway I do not see any reason to send timing updates if the sink or
source where the stream is connected to is suspended.
Colin Guthrie [Sun, 15 May 2011 13:31:22 +0000 (14:31 +0100)]
i18n: Fix POTFILES
Colin Guthrie [Sun, 15 May 2011 13:16:52 +0000 (14:16 +0100)]
tests: Fix resampler-test.
This has been broken since
c376ac5920fdeb46ca844d9518e22f17adffb635 when run
without any arguments. Passing in -v (verbose) caused the test to work fine.
I think this oversight is just a thinko in the original work but it obviously
broke 'make check' and thus distcheck.
Also fix a couple compiler warnings.
Colin Guthrie [Sun, 15 May 2011 12:14:33 +0000 (13:14 +0100)]
Merge branch 'passthrough'
Arun Raghavan [Sun, 15 May 2011 04:24:17 +0000 (09:54 +0530)]
module-tunnel: Update for recent protocol changes
This updates the tunnel module for protocol version >= 19.
module-tunnel-sink does not proxy server-side passthrough support (yet).
This would require a few more changes, namely keeping track of what
formats are available and if any other sink inputs are connected on the
server-side.
Arun Raghavan [Thu, 5 May 2011 10:28:46 +0000 (15:58 +0530)]
doxygen: generate documentation for format.h
Arun Raghavan [Wed, 13 Apr 2011 10:07:25 +0000 (15:37 +0530)]
format: Add some convenience API for setting properties
Adds functions to set sample format, rate, channels and channel map on a
format to make life easier for users of the API.
Arun Raghavan [Wed, 13 Apr 2011 08:35:18 +0000 (14:05 +0530)]
format: Extend properties to handle lists/ranges
This replaces the simple string used by pa_format_info's proplist with a
JSON string (accessed via new API only). This allows us to express lists
and ranges more cleanly, and embed type information for future
extensibility.
We use json-c for JSON parsing. This is a lightweight depdency (32 KB on
my system) and avoids the hassle of having to reinvent a JSON parser.
Also included is a test which verifies functionality and is
valgrind-clean.
Arun Raghavan [Sun, 10 Apr 2011 10:54:33 +0000 (16:24 +0530)]
sink-input: Provide more information to client when format is lost
When the sink format changes and we kill the stream, clients need a way
to know (a) what device they should reconnect to, and (b) what the
stream running time was when the stream got killed (pa_stream_get_time()
won't work after the stream has been killed). This adds these two bits
of information in the event callback's proplist parameter.
Arun Raghavan [Sat, 9 Apr 2011 04:06:25 +0000 (09:36 +0530)]
format: Add correct sample spec conversion for E-AC3
IEC61937-encapsulated E-AC3 frames contain 6 audio blocks per substream,
which corresponds to 1536 samples contained a 24576-byte frame. To cope
with this, we maintain the s16le stereo sample spec, but quadruple the
sample rate so that the conversion remains accurate.
Arun Raghavan [Tue, 29 Mar 2011 11:46:08 +0000 (17:16 +0530)]
format: Export pa_format_info_is_compatible in API
This allows clients to perform checks between formats as well.
Arun Raghavan [Mon, 28 Mar 2011 03:16:40 +0000 (08:46 +0530)]
sink-input: Add a format-lost event
This event is emitted if the sink-input could not be moved to a new sink
because it doesn't support the format of the sink-input. Clients can
reconnect their stream with a different format if they wish or
gracefully exit.
Arun Raghavan [Mon, 28 Mar 2011 03:16:20 +0000 (08:46 +0530)]
sink-input: Don't restore volume for passthrough streams
Arun Raghavan [Mon, 28 Mar 2011 03:15:31 +0000 (08:45 +0530)]
sink-input: Don't print an error if a passthrough connection fails
The assertion message is misleading, since the passthrough connection
can fail for reasons the client has no control over (like other sink
inputs being connected).
Arun Raghavan [Tue, 10 May 2011 08:03:28 +0000 (13:33 +0530)]
echo-cancel: Remove unnecessary noalign attribute
This was just introduced for debugging and should not have been in the
final commit. Won't make a difference at the moment since this function
is used as a pointer, but removing this in case we change this in the
future.
Arun Raghavan [Mon, 9 May 2011 08:10:24 +0000 (13:40 +0530)]
echo-cancel: Handle alignment requirement manually
PA_ALIGNED can't always guarantee that the alignment we want (the GCC
man page suggests that the linker might not be able to meet the
alignment requirements we desire). Instead, we now allocate some extra
memory and guaratee that the alignment we require is met.
Lennart Poettering [Fri, 6 May 2011 20:54:48 +0000 (22:54 +0200)]
rtkit: use private bus connection in order to avoid threading issues when invoking pa_make_realtime()
Arun Raghavan [Mon, 2 May 2011 04:41:47 +0000 (10:11 +0530)]
filter-apply: Mark modules as being autoloaded
(Based on Colin's review) We mark modules as being autoloaded so that
they can handle this as a special case if needed (which is required by
module-echo-cancel for now). This inverts how things were done and makes
using these modules manually less error-prone.
Arun Raghavan [Wed, 16 Mar 2011 10:38:23 +0000 (16:08 +0530)]
core: Factor out passthrough checks into their own functions
Since we currently have two mechanisms to signal a passthrough
connection (non-PCM format or PA_SINK_INPUT_PASSTHROUGH flag), we move
all the related checks into functions and use those everywhere.
This makes things more consistent, and should we decide to get rid of
the flag, we only need to change pa_sink_input_*_is_passthrough()
accordingly.
Arun Raghavan [Wed, 9 Mar 2011 15:20:25 +0000 (20:50 +0530)]
format: Add a type for DTS
Arun Raghavan [Tue, 8 Mar 2011 18:01:59 +0000 (23:31 +0530)]
introspect: Get format of sink input
This gets the negotiated format of sink inputs in
pa_context_get_sink_input*(). Also prints the format in 'pactl list'.
Arun Raghavan [Tue, 8 Mar 2011 18:00:24 +0000 (23:30 +0530)]
introspect: Get formats for sinks
This gets the list of supported formats for a sink in
pa_context_get_sink_info*(). Also prints these in 'pactl list'.
Arun Raghavan [Tue, 8 Mar 2011 14:46:00 +0000 (20:16 +0530)]
stream: Add API to get a stream's pa_format_info
Arun Raghavan [Tue, 8 Mar 2011 14:45:36 +0000 (20:15 +0530)]
format: Add some convenience functions for printing
Arun Raghavan [Tue, 8 Mar 2011 14:44:46 +0000 (20:14 +0530)]
format: Const-ify some parameters
Arun Raghavan [Tue, 8 Mar 2011 08:52:24 +0000 (14:22 +0530)]
alsa: Reconfigure sink sample rate for passthrough inputs
When a passthrough sink-input is added, we need to reconfigure the
sink's sample rate since no resampling occurs. We revert to the original
rate when the passthrough sink-input is removed.
Arun Raghavan [Thu, 3 Mar 2011 13:32:45 +0000 (19:02 +0530)]
core: Suspend monitor when a sink enters passthrough mode
In most cases it is expected that clients cannot consume compressed
data from monitor sources, so we suspend the monitor source when the
sink goes into passthrough mode.
Eventually, when the extended API includes client notifications for
changed formats, we should emit a notification on the monitor so that
clients can decide what they want to do when this happens (disconnect or
consume the data anyway).
Arun Raghavan [Thu, 3 Mar 2011 13:05:14 +0000 (18:35 +0530)]
sink: Trivial typo fix in comment
Arun Raghavan [Thu, 3 Mar 2011 07:22:21 +0000 (12:52 +0530)]
alsa-mixer: Remove passthrough profiles
These aren't used any more - we handle passthrough mode in the iec958*
profiles now.
Arun Raghavan [Wed, 2 Mar 2011 07:24:02 +0000 (12:54 +0530)]
core: Fix some FIXMEs for the extended API
This adds some checks that I'd postponed and adds a
"should-be-good-enough" guess for tlength when using a compressed
format.
Arun Raghavan [Wed, 2 Mar 2011 06:08:01 +0000 (11:38 +0530)]
sink-input: Kill passthrough streams if moving to an unsupported sink
This will eventually be replaced by a hook to let clients know that the
stream has moved so that they can gracefully reconnect and renegotiate a
supported format.
Arun Raghavan [Wed, 2 Mar 2011 05:46:48 +0000 (11:16 +0530)]
sink: Fix leak in pa_sink_check_formats()
We weren't freeing the sink formats idxset.
Arun Raghavan [Wed, 2 Mar 2011 06:01:51 +0000 (11:31 +0530)]
format: Avoid some code duplication
We frequently need to free an idxset containing pa_format_infos, so
define an internal free function that can be used directly with this
(instead of defining it once-per-file).
Arun Raghavan [Wed, 2 Mar 2011 05:46:07 +0000 (11:16 +0530)]
sink-input: Don't assert on bad formats
Handles bad format input more gracefully and returns an error instead.
Arun Raghavan [Wed, 2 Mar 2011 05:30:49 +0000 (11:00 +0530)]
sink-input: Return NOTSUPPORTED if format negotiation fails
This is easier for clients to grok than INVALID.
Arun Raghavan [Wed, 2 Mar 2011 05:23:45 +0000 (10:53 +0530)]
sink-input: Minor cleanups
Removes a couple of warnings and simplifies the assertion logic that
verifies format negotiation was successful.
Arun Raghavan [Wed, 2 Mar 2011 05:21:56 +0000 (10:51 +0530)]
tests: Add a trivial test for the extended API
This is just sync-playback.c modified to use the extended API. We need
something more sophisticated for properly testing the compressed
formats, but that is a non-trivial task in itself.
Arun Raghavan [Tue, 1 Mar 2011 20:36:54 +0000 (02:06 +0530)]
sink: Remove PASSTHROUGH flag
This removes the passthrough flag from sinks since we will drop
exclusively passthrough sinks in favour of providing a list of formats
supported by each sink. We can still determine whether a sink is in
passthrough mode by checking if any non-PCM streams are attached to it.
Arun Raghavan [Tue, 1 Mar 2011 11:04:06 +0000 (16:34 +0530)]
format: Add convenience API to check if a format is PCM or not
Arun Raghavan [Mon, 28 Feb 2011 07:53:23 +0000 (13:23 +0530)]
core: Add extended stream API to support compressed formats
This is the beginning of work to support compressed formats natively in
PulseAudio. This adds a pa_stream_new_extended() that takes a format
structure, sends it to the server (=> protocol extension) and has the
server negotiate with the appropropriate sink to figure out what format
it should use.
This is work in progress, and works only with PCM streams. Actual
compressed format support in some sink needs to be implemented, and
extensive testing is required.
More details on how this is supposed to work is available at:
http://pulseaudio.org/wiki/PassthroughSupport
Arun Raghavan [Mon, 28 Feb 2011 07:30:20 +0000 (13:00 +0530)]
sink: Extend API for compressed formats support
This adds a get_formats() vfunc for sinks to provide a list of formats
they can support. pa_sink_check_formats() can be used during or after
routing to determine what formats from a stream the sink can support.
Arun Raghavan [Mon, 28 Feb 2011 05:23:41 +0000 (10:53 +0530)]
format: Add some properties and internal API
The properties will be used by clients to set the sample format,
sampling rate, etc. The functions will be used internally.
Arun Raghavan [Fri, 25 Feb 2011 07:05:14 +0000 (12:35 +0530)]
core: Add a pa_format_info structure
This will be used to represent the format of data provided by the client
for both compressed and PCM formats in a new extended API.
Arun Raghavan [Thu, 24 Feb 2011 09:16:01 +0000 (14:46 +0530)]
sample: Use PA_SAMPLE_INVALID instead of numeric value
Arun Raghavan [Fri, 25 Feb 2011 07:14:53 +0000 (12:44 +0530)]
sink: Trivial typo fix
Pierre-Louis Bossart [Tue, 8 Mar 2011 09:42:56 +0000 (15:12 +0530)]
sink-input: Don't resample passthrough inputs
Arun Raghavan [Mon, 2 May 2011 04:38:27 +0000 (10:08 +0530)]
filter-apply: Mark modules as being autoloaded
(Based on Colin's review) We mark modules as being autoloaded so that
they can handle this as a special case if needed (which is required by
module-echo-cancel for now). This inverts how things were done and makes
using these modules manually less error-prone.
Maarten Bosmans [Sat, 30 Apr 2011 19:46:30 +0000 (21:46 +0200)]
Make connect-stress test compile for win32
Maarten Bosmans [Sat, 30 Apr 2011 13:25:55 +0000 (15:25 +0200)]
build-system: Small fixes
Maarten Bosmans [Sat, 30 Apr 2011 13:25:54 +0000 (15:25 +0200)]
build-system: Rearrange database selection
Maarten Bosmans [Sat, 30 Apr 2011 13:25:53 +0000 (15:25 +0200)]
build-system: Replace some more conditionals with AS_IF
Maarten Bosmans [Sat, 30 Apr 2011 13:25:52 +0000 (15:25 +0200)]
build-system: Move dependency error messages to outer scope
Maarten Bosmans [Sat, 30 Apr 2011 13:25:51 +0000 (15:25 +0200)]
build-system: Move AC_DEFINE to separate line with AS_IF
Maarten Bosmans [Sat, 30 Apr 2011 13:25:50 +0000 (15:25 +0200)]
build-system: Use AS_IF macro for configure output
And add some HAVE_[feature] variables for clarity.
Maarten Bosmans [Sat, 30 Apr 2011 13:25:49 +0000 (15:25 +0200)]
build-system: Simplify AC_ARG_ENABLE usage
Make use of the enable_[feature] variable automatically defined
by AC_ARG_ENABLE instead of defining our own variable.
Colin Guthrie [Fri, 29 Apr 2011 15:40:50 +0000 (16:40 +0100)]
combine: Rename module-combine to module-combine-sink.
This also includes a compatibility module that will ultimately be removed in
a future release.
Luiz Augusto von Dentz [Fri, 29 Apr 2011 14:48:07 +0000 (17:48 +0300)]
bluetooth: Only close SCO if status has changed
In case the io thread is starting there is no point on closing SCO just
to resume it latter when the source/sink changes to opened state.
Luiz Augusto von Dentz [Fri, 29 Apr 2011 14:48:06 +0000 (17:48 +0300)]
bluetooth: Fix using pointer-pointer when appending an array as variant
pa_dbus_append_basic_array_variant_dict_entry should take the direct
pointer to the array.
Luiz Augusto von Dentz [Fri, 29 Apr 2011 14:48:05 +0000 (17:48 +0300)]
bluetooth: Fix not updating sample spec when using Media API
When using transport configured via Media API sample spec needs to be
updated since codec configuration may affect it when e.g. headset
configure a different frequency or number of channels from default.
Arnaud Fontaine [Tue, 29 Mar 2011 20:57:28 +0000 (22:56 +0159)]
x11: More XCB fixes.
Commit 65ef80b fixed building with xcb-util >= 0.3.8, but the reply is never
checked (possible SIGSEGV if the reply is NULL) nor freed (memory leak at each
call of the functions).
Also, remove include and dependencies on xcb-atom, as it was only meaningful
for xcb_atom_get() and STRING, and depend instead on xcb >= 1.6 for
XCB_ATOM_STRING.
Tanu Kaskinen [Fri, 29 Apr 2011 10:58:43 +0000 (13:58 +0300)]
dbus: Fix the order of freeing stuff when unloading module-dbus-protocol.
Tanu Kaskinen [Fri, 29 Apr 2011 10:58:42 +0000 (13:58 +0300)]
dbus: Fix connection idxset freeing when unloading the module.
If u->connections isn't empty when module-dbus-protocol is
unloaded, then connection_free() is called for the
remaining connections when the idxset is freed.
connection_free() tries to remove the connection from the
idxset, but that fails, because the item has already been
removed from the idxset in this scenario.
The problem is solved by not trying to remove the connection
from the idxset in connection_free(). Instead, whoever wants
to delete connections, has to remove the connection from the
idxset in addition to calling connection_free().
Tanu Kaskinen [Fri, 29 Apr 2011 10:45:29 +0000 (13:45 +0300)]
match: Support for both merging and replacing proplist updates.
This patch adds a new update mode specifier that can be optionally
given in match rules after the regexp. Property list updates triggered
by the rule will honour the given mode. The two allowed modes are 'merge'
and 'replace', corresponding to PA_UPDATE_MERGE and PA_UPDATE_REPLACE
respectively. If omitted, the mode defaults to PA_UPDATE_MERGE, ie. to
the original behavior.
For example, to force 'media.role' to be overwritten with 'bar' for
streams matching foo you can use an entry like this:
foo replace "bar"
This will really overwrite media.role to bar even if it has already been
set to something else by the application.
Thanks to Krisztian Litkey for the original patch and the description
above. In addition to implementing the new feature, this patch fixes
a number of bugs in the parsing code.
Antti-Ville Jansson [Wed, 20 Apr 2011 12:56:29 +0000 (15:56 +0300)]
core: Drop empty gaps in the memblockq when playing data from it.
It's possible that the memblockq of a sink input is rewound to a negative read
index if the sink input is moved between sinks shortly after its creation. When
this happens, pa_memblockq_peek() returns a memchunk whose 'memblock' field is
NULL and whose 'length' field indicates the length of the gap caused by the
negative read index. This will trigger an assert in play-memblockq.c.
If the memblockq had a silence memchunk, pa_memblockq_peek() would return
silence for the duration of the gap and the assert would be avoided. However,
this approach would prevent the sink input from being drained and is thus not
possible. Instead, we handle the aforementioned situation by dropping the gap
indicated by the 'length' field of the memchunk and by peeking the actual data
that comes after the gap.
This scenario seems to be quite rare in everyday use, but it causes a severe
bug in the handheld world. The assert can be triggered e.g. by loading two null
sinks, playing a sample from the cache to one of them and then moving the
created sink input between the two sinks. The rewinds done by the null sinks
seem to be quite long (I don't know if this is normal behaviour or something
fishy in module-null-sink).
See also:
6bd34156b130c07b130de10111a12ef6dab18b52
virtual-sink: Fix a crash when moving the sink to a new master right after setup.
https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-February/009105.html
Reproduce:
This problem can be reproduced with the following script:
SAMPLE_PATH="/usr/share/sounds/alsa/"
SAMPLE="Front_Left"
pactl remove-sample $SAMPLE 2> /dev/null
pactl upload-sample $SAMPLE_PATH$SAMPLE.wav
mod1=`pactl load-module module-null-sink sink_name=null1`
mod2=`pactl load-module module-null-sink sink_name=null2`
pactl play-sample $SAMPLE null1
input=`pactl list | grep "Sink Input #" | tail -n 1 | cut -d# -f2`
echo "Sample $SAMPLE playing as Sink Input #$input"
pactl move-sink-input $input null2
pactl move-sink-input $input null1
pactl unload-module $mod1
pactl unload-module $mod2
Tanu Kaskinen [Wed, 27 Apr 2011 10:08:38 +0000 (13:08 +0300)]
stream-restore: Enable database dumping if DEBUG_VOLUME is defined.
Marc-André Lureau [Wed, 27 Apr 2011 11:50:00 +0000 (14:50 +0300)]
module-null-source: New null-source module
Maciej Grela [Tue, 29 Mar 2011 20:57:28 +0000 (22:56 +0159)]
x11: Fix build errors with newest xcb-util.
The xcb_atom_get functions were removed from xcb-util. Changed these to
xcb_intern_atom/xcb_intern_atom_reply. Also, STRING is now
XCB_ATOM_STRING.
Arun Raghavan [Fri, 22 Apr 2011 14:27:29 +0000 (19:57 +0530)]
filter-heuristics: Match roles correctly
Arun Raghavan [Fri, 22 Apr 2011 12:14:50 +0000 (17:44 +0530)]
echo-cancel: Play nice with module-filter-*
With automaticl filter loading by module-filter-apply, setting the
virtual sink/source to have the "phone" intended role will break routing
when you first connect a phone stream to an ALSA device and then turn on
your Bluetooth headset. This happens because module-intended-roles
doesn't move a stream if it is already on a device that provides the
required role.
This patch introduces a "manual_load" parameter that is meant to be used
when not using module-filter-apply for loading the AEC module. If this
parameter is set, the virtual devices are given the "phone" role, else
we count on module-filter-heuristics to do the right thing.
Arun Raghavan [Fri, 22 Apr 2011 12:03:03 +0000 (17:33 +0530)]
filters: Handle filters on sources as well
This makes the core code in the filter-* modules generic enough to be
used on sources or sinks. We need special handling for modules that
introduce more than one sink (for now echo-cancel only).
Arun Raghavan [Thu, 21 Apr 2011 07:22:27 +0000 (12:52 +0530)]
filters: Handle stream moves properly
This makes sure that we handle streams moving between sinks properly. To
do this, we change the way the filter.* properties are handled a little
bit.
Firstly, this splits up the "filter.apply" property into two properties
- "filter.want" and "filter.apply". "filter.apply" acts as before - it
bypasses module-filter-heuristics and directly tells module-filter-apply
what filters are to be applied.
"filter.want" is used to tell module-filter-heuristics what filters the
client wants. The module then decides whether to actually apply the
filter or not (for now, this makes sure we don't apply echo-cancellation
even if requested on phone sinks (where it is assumed AEC is taken care
of or is not required).
Next, we also make sure that we track whether the client set
"filter.apply" or module-filter-heuristics did - and in the latter case,
we recalculate "filter.apply" and then have module-filter-apply apply
the filter if required. This introduces some evil in the form of causing
the move_finish callback to possibly trigger another move, but we
protect for this case (with a property) to be doubly sure of not causing
an infinite loop.
Arun Raghavan [Wed, 20 Apr 2011 12:15:26 +0000 (17:45 +0530)]
filter-heuristics: Only apply AEC if we're not already on a phone sink
This makes sure that we don't apply AEC on sinks that are already
connected to a "phone" device, the assumptiong being that anything
marked as such either doesn't have need it, or handles it itself.
Colin Guthrie [Fri, 22 Apr 2011 09:25:42 +0000 (10:25 +0100)]
test: Make the connect-stress less likely to bail out due to >32 streams.
When running two connect-stress tests at the same time the liklihood of >32 streams
per sink increases. All it takes is for an event sound to fire to trigger an abort of
the test.
This leaves just a little bit of wriggle room for a couple external streams.
Of course the overall problem is still there but this just makes it
slightly less likely without really affecting the test itself.
Daniel Mack [Fri, 22 Apr 2011 00:41:24 +0000 (02:41 +0200)]
build-sys: Make -isysroot and -mmacosx-version-min configurable
Tanu Kaskinen [Thu, 21 Apr 2011 05:06:53 +0000 (08:06 +0300)]
protocol-dbus: Fix some memory management bugs.
There were several memory leaks. In addition to those,
pa_dbus_protocol_add_interface() used a string from the
caller as a key to a hashmap, instead of a copy of the
string. This caused trouble when the caller freed the
string while the key was still in use in the hashmap.
Marc-André Lureau [Wed, 20 Apr 2011 12:22:46 +0000 (15:22 +0300)]
match: Match rule earlier, in SINK_INPUT_NEW
Marc-André Lureau [Wed, 20 Apr 2011 11:49:18 +0000 (14:49 +0300)]
match: Don't double free in case of missing table file
Daniel Mack [Fri, 22 Apr 2011 02:12:36 +0000 (04:12 +0200)]
module-coreaudio-device: Fix two build warnings
Daniel Mack [Fri, 22 Apr 2011 02:10:46 +0000 (04:10 +0200)]
module-coreaudio-device: Set the thread name to device name
This makes gdb's "info threads" better understandable
Daniel Mack [Fri, 22 Apr 2011 02:08:45 +0000 (04:08 +0200)]
module-coreaudio-device: Dispatch sink/source state messages from main loop
This fixes a long standing race condition when tearing down streams on
Mac OS X.
Daniel Mack [Fri, 22 Apr 2011 02:28:11 +0000 (04:28 +0200)]
thread-posix: Use pthread_(get|set)name_np() if available
Newer generations of libpthread have functions to set and get the thread
names. If available, use them.
Daniel Mack [Fri, 22 Apr 2011 00:27:35 +0000 (02:27 +0200)]
pulsecore:: Define _POSIX_C_SOURCE locally for rtclock on OSX
Defining this macro on a global level is disadvantageous for other APIs,
and as we need it for clock_gettime() only on Mac OS X, define it
locally in pulsecore/core-rtclock.c only.
Daniel Mack [Fri, 15 Apr 2011 17:35:25 +0000 (19:35 +0200)]
util: Implement pa_get_binary_name() for Mac OS X